xen_intr.c
ClosedPublic
Actions

Authored by ehem_freebsd_m5p.com on May 12 2021, 9:37 PM.

Details

Reviewers

royger
mhorne

Commits

rG5e2183dab871: xen/intr: move sys/x86/xen/xen_intr.c to sys/dev/xen/bus/

Summary

Major changes are necessary to make this processor-independent, but
moving the file out of x86 and into common is the first step (to preempt
addition of further x86-isms).

Submitted by: Elliott Mitchell <ehem+freebsd@m5p.com>
Original implementation: Julien Grall <julien@xen.org>, 2014-01-13 17:41:04

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 47937
Build 44824: arc lint + arc unit

Event Timeline

ehem_freebsd_m5p.com created this revision.May 12 2021, 9:37 PM

Herald added a subscriber: imp. · View Herald TranscriptMay 12 2021, 9:37 PM

ehem_freebsd_m5p.com requested review of this revision.May 12 2021, 9:37 PM

Harbormaster completed remote builds in B39148: Diff 89094.May 12 2021, 9:37 PM

ehem_freebsd_m5p.com added a child revision: D30006: xen/intr: adjust xen_intr_handle_upcall() to match interrupt filter.May 13 2021, 4:11 AM

ehem_freebsd_m5p.com mentioned this in D30006: xen/intr: adjust xen_intr_handle_upcall() to match interrupt filter.

ehem_freebsd_m5p.com added a child revision: D30598: xen/intr: merge parts of resume functionality into new function.Jun 1 2021, 3:47 PM

ehem_freebsd_m5p.com added a child revision: D30600: xen/intr: disable xen_intr_suspend() and xen_intr_resume() on !x86.Jun 1 2021, 4:30 PM

ehem_freebsd_m5p.com mentioned this in D30600: xen/intr: disable xen_intr_suspend() and xen_intr_resume() on !x86.

ehem_freebsd_m5p.com added a child revision: D30605: xen/intr: remove xen_intr_alloc_and_bind_ipi() from !x86.Jun 1 2021, 6:56 PM

Any news on D30236?

From playing with this I'm wondering if perhaps this should instead move to sys/dev/xen/bus/intr.c instead. This file really looks like a combination of an interrupt controller and a small interface library. xen_intr_handle_upcall() is the call for servicing the interrupt on the system primary controller, which xen_intr.c then fans out to several software interrupts.

As a result this sort of acts like an interrupt controller associated with the xenpv bus. I'm wondering whether the Xen child devices should be allocating interrupts via the normal bus interface to xenpv.

ehem_freebsd_m5p.com added a child revision: D30950: xen/arm64: enable arm64 Xen configuration.Jun 30 2021, 1:28 AM

ehem_freebsd_m5p.com removed a child revision: D30006: xen/intr: adjust xen_intr_handle_upcall() to match interrupt filter.Jul 1 2021, 1:59 AM

ehem_freebsd_m5p.com removed a child revision: D30598: xen/intr: merge parts of resume functionality into new function.

Splitting this. Depending upon how things evolve, there could be a need to have the two files live side-by-side for a bit. The non-split version was okayed in e-mail.

Harbormaster completed remote builds in B47937: Diff 112066.Oct 21 2022, 12:24 AM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 14 2023, 2:02 PM

Closed by commit rG5e2183dab871: xen/intr: move sys/x86/xen/xen_intr.c to sys/dev/xen/bus/ (authored by julien_xen.org, committed by royger). · Explain Why

This revision was automatically updated to reflect the committed changes.

royger added a commit: rG5e2183dab871: xen/intr: move sys/x86/xen/xen_intr.c to sys/dev/xen/bus/.