Page MenuHomeFreeBSD

erj (Eric Joyner)
Network Software Engineer @ Intel

Projects

User Details

User Since
Jan 27 2015, 7:34 PM (194 w, 3 d)

Recent Activity

Today

erj accepted D17404: iflib: drain enqueued tasks before detaching from taskqgroup.

Looks like it does what it's supposed to.

Fri, Oct 19, 4:50 PM

Tue, Oct 16

erj added a comment to D17404: iflib: drain enqueued tasks before detaching from taskqgroup.

iflib_admin_intr_deferred() called with STATE_LOCK() in a few places.

I've moved STATE_UNLOCK before iflib_admin_intr_defereed call although releasing lock just to immediately grab it again makes me a bit uneasy. Maybe it would be better idea to use mtx_owned in iflib_in_detach to check if this lock is already aquired?

Tue, Oct 16, 8:14 PM

Mon, Oct 15

erj committed rS339362: iavf(4): Finish rename/rebrand internally.
iavf(4): Finish rename/rebrand internally
Mon, Oct 15, 5:24 PM
erj closed D17544: iavf: Finish the rename/rebrand internally.
Mon, Oct 15, 5:23 PM
erj added a comment to D17544: iavf: Finish the rename/rebrand internally.

Err, "arc patch" doesn't apply this cleanly to my svn tree -- it complains that it can't find the new files if_iavf.c, iavf_vc.c, and iavf.h to patch.

Mon, Oct 15, 4:40 PM
erj added a comment to D17544: iavf: Finish the rename/rebrand internally.

@erj do you want to ask RE permission to commit this?

Mon, Oct 15, 4:34 PM
erj accepted D17544: iavf: Finish the rename/rebrand internally.
Mon, Oct 15, 4:29 PM

Sun, Oct 14

erj committed rS339354: em/igb/ix(4): Port two Tx/Rx fixes made to ixl in r339338.
em/igb/ix(4): Port two Tx/Rx fixes made to ixl in r339338
Sun, Oct 14, 5:09 AM

Sat, Oct 13

erj accepted D17544: iavf: Finish the rename/rebrand internally.

My only nitpick is that ixlvc.c should probably be renamed to iavf_vc.c instead; it's supposed to contain the functions that communicate via the PF<->VF virtchannel.

Sat, Oct 13, 7:58 PM

Fri, Oct 12

erj abandoned D16428: iflib: Changes for ixlv(4) update.
Fri, Oct 12, 10:59 PM · Intel Networking
erj committed rS339340: ixl/iavf: Update ixl(4) and iavf(4) [previously ixlv] man pages.
ixl/iavf: Update ixl(4) and iavf(4) [previously ixlv] man pages
Fri, Oct 12, 10:58 PM
erj closed D15927: Update ixl(4) and ixlv(4) man pages.
Fri, Oct 12, 10:58 PM
erj committed rS339338: ixl/iavf(4): Change ixlv to iavf and update it to use iflib(9).
ixl/iavf(4): Change ixlv to iavf and update it to use iflib(9)
Fri, Oct 12, 10:41 PM
erj closed D16429: ixlv(4): Update to use iflib; change name to iavf(4).
Fri, Oct 12, 10:41 PM · Intel Networking
erj removed a parent revision for D16429: ixlv(4): Update to use iflib; change name to iavf(4): D16428: iflib: Changes for ixlv(4) update.
Fri, Oct 12, 5:28 PM · Intel Networking
erj removed a child revision for D16428: iflib: Changes for ixlv(4) update: D16429: ixlv(4): Update to use iflib; change name to iavf(4).
Fri, Oct 12, 5:28 PM · Intel Networking

Thu, Oct 11

erj added a comment to D16429: ixlv(4): Update to use iflib; change name to iavf(4).

Any last-minute assents or objections?

Thu, Oct 11, 11:04 PM · Intel Networking
erj added a comment to D15927: Update ixl(4) and ixlv(4) man pages.

I'm going to try to get these committed, soon; I don't have any more planned changes.

Thu, Oct 11, 10:40 PM

Tue, Oct 9

erj added a comment to D17404: iflib: drain enqueued tasks before detaching from taskqgroup.

@krzysztof.galazka_intel.com , you need to re-upload this patch

Tue, Oct 9, 6:20 PM

Mon, Oct 8

erj added inline comments to D17443: net/intel-ix-kmod: New port for 10g Intel Ethernet Base Driver.
Mon, Oct 8, 8:28 PM · Intel Networking
erj added a comment to D17473: fix PNP entries for if_ix and if_ixv.

I can't tell if this is right or not, but it looks like an ok change to me.

Mon, Oct 8, 4:42 PM

Fri, Oct 5

erj added a comment to D17404: iflib: drain enqueued tasks before detaching from taskqgroup.

Hrm, I don't think we can obtain CTX_LOCK() in those functions.

Fri, Oct 5, 9:57 PM
erj added a comment to D17404: iflib: drain enqueued tasks before detaching from taskqgroup.

Wouldn't iflib_iov_intr_deferred() need it too?

Fri, Oct 5, 9:38 PM
erj accepted D17442: Fix egregious magic number constants.

It's a reasonable change, but it's still kind of a surprise to me that em doesn't support IPv6 hardware offloads.

Fri, Oct 5, 9:08 PM
erj requested changes to D17404: iflib: drain enqueued tasks before detaching from taskqgroup.

You're apparently not allowed to delete changesets, so this'll have to be updated with the old diff.

Fri, Oct 5, 8:31 PM
erj removed an edge from rS339207: Fix igb corrupting checksums with BPF and VLAN: D17404: iflib: drain enqueued tasks before detaching from taskqgroup.
Fri, Oct 5, 8:25 PM
erj removed 1 commit(s) for D17404: iflib: drain enqueued tasks before detaching from taskqgroup: rS339207: Fix igb corrupting checksums with BPF and VLAN.
Fri, Oct 5, 8:25 PM
erj added 1 commit(s) for D17393: Attempt to fix PR231416 (UDP BPF VLAN checksum errors): rS339207: Fix igb corrupting checksums with BPF and VLAN.
Fri, Oct 5, 8:24 PM
erj added an edge to rS339207: Fix igb corrupting checksums with BPF and VLAN: D17393: Attempt to fix PR231416 (UDP BPF VLAN checksum errors).
Fri, Oct 5, 8:24 PM
erj added a child revision for D16429: ixlv(4): Update to use iflib; change name to iavf(4): D15927: Update ixl(4) and ixlv(4) man pages.
Fri, Oct 5, 8:21 PM · Intel Networking
erj added a parent revision for D15927: Update ixl(4) and ixlv(4) man pages: D16429: ixlv(4): Update to use iflib; change name to iavf(4).
Fri, Oct 5, 8:21 PM
erj added a child revision for D16428: iflib: Changes for ixlv(4) update: D16429: ixlv(4): Update to use iflib; change name to iavf(4).
Fri, Oct 5, 8:21 PM · Intel Networking
erj added a parent revision for D16429: ixlv(4): Update to use iflib; change name to iavf(4): D16428: iflib: Changes for ixlv(4) update.
Fri, Oct 5, 8:21 PM · Intel Networking
erj reopened D17404: iflib: drain enqueued tasks before detaching from taskqgroup.

rS339207 has the wrong Differential Revision, I think

Fri, Oct 5, 8:20 PM
erj added a comment to D17404: iflib: drain enqueued tasks before detaching from taskqgroup.

Is there a reason not to do this in taskqgroup_detach()?

I don't see any obvious thing which prevents something being enqueued between the gtaskqueue_drain() and taskqgroup_detach() calls.

Fri, Oct 5, 8:16 PM
erj updated the diff for D16429: ixlv(4): Update to use iflib; change name to iavf(4).
  • iavf(4): Move modules/Makefile entry so that it's in alphabetical order
  • iavf(4): Update MODULE_* macros with new "iavf" name
Fri, Oct 5, 6:53 PM · Intel Networking
erj updated the diff for D15927: Update ixl(4) and ixlv(4) man pages.
  • Change name of ixlv(4) to iavf(4) and update Makefile
Fri, Oct 5, 5:23 PM

Thu, Oct 4

erj planned changes to D15927: Update ixl(4) and ixlv(4) man pages.

Sorry guys, ixlv(4) is getting a name change. :p

Thu, Oct 4, 10:54 PM
erj retitled D16429: ixlv(4): Update to use iflib; change name to iavf(4) from ixlv(4): Update to use iflib to ixlv(4): Update to use iflib; change name to iavf(4).
Thu, Oct 4, 10:31 PM · Intel Networking
erj updated the diff for D16429: ixlv(4): Update to use iflib; change name to iavf(4).
  • ixlv/iavf(4): Change "ixlv" driver name to "iavf"
Thu, Oct 4, 10:29 PM · Intel Networking

Wed, Oct 3

erj added a comment to D16429: ixlv(4): Update to use iflib; change name to iavf(4).

Ugh, rebasing changes the commit SHAs :(

Wed, Oct 3, 8:14 PM · Intel Networking
erj updated the diff for D16429: ixlv(4): Update to use iflib; change name to iavf(4).

Rebased onto latest master, and added:

Wed, Oct 3, 8:10 PM · Intel Networking
erj resigned from D6585: Avoid naming collisions between linuxkpi's struct device and FreeBSD's struct device .
Wed, Oct 3, 5:22 PM
erj resigned from D4295: Add driver backpressure.
Wed, Oct 3, 5:22 PM · transport
erj resigned from D12142: Don't start grouptaskqueue threads for unused grouptaskqueues.
Wed, Oct 3, 5:21 PM
erj resigned from D12487: Combine LROed mbufs for a single call to if_input().
Wed, Oct 3, 5:21 PM
erj removed a reviewer for D13858: 1 << 31 redux: Intel Networking.
Wed, Oct 3, 5:20 PM

Tue, Oct 2

erj updated the diff for D15927: Update ixl(4) and ixlv(4) man pages.

Fix incorrect use of .Fx macro

Tue, Oct 2, 11:37 PM
erj updated the summary of D15927: Update ixl(4) and ixlv(4) man pages.
Tue, Oct 2, 3:54 PM
erj updated the diff for D15927: Update ixl(4) and ixlv(4) man pages.
  • Fix style issues found by @0mp
Tue, Oct 2, 3:53 PM
erj retitled D15927: Update ixl(4) and ixlv(4) man pages from Update ixl(4) man page to Update ixl(4) and ixlv(4) man pages.
Tue, Oct 2, 6:03 AM
erj updated the diff for D15927: Update ixl(4) and ixlv(4) man pages.
  • ixl/ixlv(4): Update both manpages.
Tue, Oct 2, 6:02 AM

Thu, Sep 27

erj updated the diff for D16428: iflib: Changes for ixlv(4) update.
  • Revert "iflib: Free RX queue TCP LRO memory on unload"
Thu, Sep 27, 12:57 AM · Intel Networking
erj updated the diff for D16429: ixlv(4): Update to use iflib; change name to iavf(4).
  • ixlv(4): Update driver version to 2.0.0-k
  • ixlv(4): Remove dynamic ITR code, since it's unused
  • ixlv(4): Set max number of queues used in iflib based on number VF receives from PF
  • ixlv(4): Code cleanup
  • ixlv(4): Don't sleep for a response to a VC msg if driver is in detach
  • ixl(4): Clear VF qtag queue flags when VF is being reinitialized
  • ixlv(4): Move queue disable to earlier in ixlv_if_init, and don't sleep for completion
  • ixlv(4): Modify debug prints, and stop printing out "Queue already enabled" warnings
  • ixl(4): Update version number to 2.1.0-k
Thu, Sep 27, 12:56 AM · Intel Networking

Tue, Sep 25

erj committed rD52304: Document FreeBSD version 1102503..
Document FreeBSD version 1102503.
Tue, Sep 25, 7:59 PM
erj committed rS338931: Bump __FreeBSD_version after r338871 introduced new media types.
Bump __FreeBSD_version after r338871 introduced new media types
Tue, Sep 25, 7:53 PM

Fri, Sep 21

erj committed rS338873: Revert MFC of r334231 in r338871..
Revert MFC of r334231 in r338871.
Fri, Sep 21, 11:54 PM
erj committed rS338871: MFC r334231, r334779, r335322, and r338208 to stable/11 from head.
MFC r334231, r334779, r335322, and r338208 to stable/11 from head
Fri, Sep 21, 11:31 PM

Thu, Sep 20

erj updated the diff for D16429: ixlv(4): Update to use iflib; change name to iavf(4).
  • ixl(4): Fix filter handling when SR-IOV is enabled
  • Revert "iflib: Free RX queue TCP LRO memory on unload"
Thu, Sep 20, 5:40 PM · Intel Networking

Sep 19 2018

erj accepted D17242: Add IFCAP_TSO6 for igb.
Sep 19 2018, 6:14 PM

Sep 13 2018

erj updated the diff for D16429: ixlv(4): Update to use iflib; change name to iavf(4).
  • ixl(4): Fix compile error introduced by previous commit
Sep 13 2018, 11:10 PM · Intel Networking
erj updated the diff for D16429: ixlv(4): Update to use iflib; change name to iavf(4).
  • ixl(4): Configure promiscuous mode during driver init
Sep 13 2018, 11:00 PM · Intel Networking
erj updated the diff for D16429: ixlv(4): Update to use iflib; change name to iavf(4).
  • ixlv(4): Disable queues before initialization.
Sep 13 2018, 6:00 PM · Intel Networking

Sep 12 2018

erj added a comment to D16428: iflib: Changes for ixlv(4) update.

I'm confused; this is just doing a normal store / load for the in detach - you need a lock to serialize reading it with other operations.

Sep 12 2018, 9:42 PM · Intel Networking

Sep 11 2018

erj committed rS338593: ix(4), ixv(4): VLAN tag stripping fixes for Amazon EC2 Enhanced Networking.
ix(4), ixv(4): VLAN tag stripping fixes for Amazon EC2 Enhanced Networking
Sep 11 2018, 6:33 PM
erj closed D17061: ix(4), ixv(4): Add VLAN tag strip check when receiving packets; ixv(4): Fix support for VLAN_HWTAGGING and VLAN_HWFILTER flags.
Sep 11 2018, 6:33 PM · Intel Networking

Sep 4 2018

erj updated the diff for D16429: ixlv(4): Update to use iflib; change name to iavf(4).
  • ixlv(4): Swap MALLOC_DEFINE/DECLARE statements
  • ixlv(4): Remove commented out code
  • ixlv(4): Check return value of ixlv_add_mac_filter when adding MC addresses
  • ixlv(4): Update some debug printf()'s to use newer debug functions
  • ixlv(4): malloc() the correct size for the heads of the MAC/vlan filter lists
Sep 4 2018, 11:33 PM · Intel Networking

Aug 31 2018

erj updated the diff for D16428: iflib: Changes for ixlv(4) update.
  • iflib: Destroy state lock at end of iflib_device_deregister()
  • iflib: Move ifc_in_detach variable to flag in if_ctx_t's ifc_flags, and lock around it
Aug 31 2018, 12:05 AM · Intel Networking
erj updated the diff for D16429: ixlv(4): Update to use iflib; change name to iavf(4).
  • iflib: Destroy state lock at end of iflib_device_deregister()
  • iflib: Move ifc_in_detach variable to flag in if_ctx_t's ifc_flags, and lock around it
  • ixl(4): Fix kernel panic during init() when Admin Queue is not alive
Aug 31 2018, 12:01 AM · Intel Networking

Aug 28 2018

erj accepted D16920: Add an iflib manpage to section 4.
Aug 28 2018, 9:19 PM

Aug 27 2018

erj planned changes to D15927: Update ixl(4) and ixlv(4) man pages.

Yes -- I did this quick update because someone mentioned the textproc/igor utility in another review. It also reminded me to come back to this.

Aug 27 2018, 7:11 PM
erj updated the diff for D15927: Update ixl(4) and ixlv(4) man pages.
  • Run manpage through textproc/igor and fix resulting issues
Aug 27 2018, 6:20 PM
erj added a comment to D16920: Add an iflib manpage to section 4.

I wish there was a previewer for these...

Aug 27 2018, 4:02 PM
erj updated the diff for D16429: ixlv(4): Update to use iflib; change name to iavf(4).
  • ixl/ixlv Missing semicolon in DWB fix
Aug 27 2018, 3:43 PM · Intel Networking

Aug 23 2018

erj added a comment to D16875: Possible fix for "desc avail = " dmesg spam and igb breakage.

The in-tree igb never sets IFLIB_ADMIN_ALWAYS_RUN. Is this for a modified version of igb?

Aug 23 2018, 11:58 PM
erj accepted D16733: iflib sysctl cleanup.
Aug 23 2018, 11:55 PM
erj added inline comments to D16428: iflib: Changes for ixlv(4) update.
Aug 23 2018, 11:55 PM · Intel Networking
erj updated the diff for D16429: ixlv(4): Update to use iflib; change name to iavf(4).
  • ixl(4): Fix memory leak when head writeback is disabled
Aug 23 2018, 9:22 PM · Intel Networking
erj updated the diff for D16429: ixlv(4): Update to use iflib; change name to iavf(4).
  • ixl/ixlv(4): Fix TXD credits update for DWB mode
Aug 23 2018, 5:56 PM · Intel Networking

Aug 22 2018

erj committed rS338208: if_media: Add new 2.5G/5G/25G/40G/50G/100G/200G/400G media types.
if_media: Add new 2.5G/5G/25G/40G/50G/100G/200G/400G media types
Aug 22 2018, 6:20 PM
erj closed D16731: if_media: Add new 2.5G/5G/25G/40G/50G/100G/200G/400G media types.
Aug 22 2018, 6:20 PM
erj updated the diff for D16731: if_media: Add new 2.5G/5G/25G/40G/50G/100G/200G/400G media types.

Fix typo (from @hselasky)

Aug 22 2018, 12:52 AM
erj updated the diff for D16429: ixlv(4): Update to use iflib; change name to iavf(4).
  • ixlv(4): Make ixlv_if_init() and ixlv_stop() wait for ENABLE/DISABLE queue command completion
  • ixl(4): Cosmetic change to message PF sends in reply to VF promiscuous config message
Aug 22 2018, 12:48 AM · Intel Networking

Aug 21 2018

erj added a comment to D16731: if_media: Add new 2.5G/5G/25G/40G/50G/100G/200G/400G media types.

Can I get this patch re-reviewed before committing it?

Aug 21 2018, 5:38 PM
erj updated the diff for D16429: ixlv(4): Update to use iflib; change name to iavf(4).
  • ixl(4): Fix RX MDD event display
  • ixl/ixlv(4): Add more MPASS statements to TX path
Aug 21 2018, 12:42 AM · Intel Networking

Aug 20 2018

erj updated the diff for D16731: if_media: Add new 2.5G/5G/25G/40G/50G/100G/200G/400G media types.
  • if_media: Add 40Gbase-ER4 media type.
Aug 20 2018, 6:38 PM
erj added a comment to D16731: if_media: Add new 2.5G/5G/25G/40G/50G/100G/200G/400G media types.

I see IFM_40G_ER4 is missing from the table. There is only IFM_40G_LR4 currently.

Can you add IFM_40G_ER4 as part of this patch aswell?

Aug 20 2018, 3:54 PM

Aug 16 2018

erj updated the diff for D16429: ixlv(4): Update to use iflib; change name to iavf(4).
  • ixl(4): Enhance Malicious Driver Detection messages with VF information
  • ixl(4): Print out additional event information when a LAN Overflow Event occurs
  • ixl/ixlv(4): Add additional MPASS() asserts to the driver TX path
Aug 16 2018, 11:45 PM · Intel Networking

Aug 15 2018

erj created D16731: if_media: Add new 2.5G/5G/25G/40G/50G/100G/200G/400G media types.
Aug 15 2018, 6:59 PM

Aug 14 2018

erj updated the diff for D16429: ixlv(4): Update to use iflib; change name to iavf(4).
  • ixlv(4): Change remaining M_DEVBUF malloc types to M_IXLV
  • ixlv(4): Fix a memory leak when interrupt setup fails
  • ixlv(4): Convert some malloc()'s to M_WAITOK from M_NOWAIT
  • ixlv(4): Remove comments and commented out code
  • ixlv(4): Remove list of media types displayed in "ifconfig -m"
Aug 14 2018, 12:03 AM · Intel Networking
erj updated the diff for D16428: iflib: Changes for ixlv(4) update.
  • iflib: Free remaining interrupt resources on failure in iflib_device_register()
  • iflib: Free RX queue TCP LRO memory on unload
Aug 14 2018, 12:02 AM · Intel Networking

Aug 10 2018

erj updated the diff for D16429: ixlv(4): Update to use iflib; change name to iavf(4).
  • ixl/ixlv(4): Fix panic when receiving jumbo frame (>4k mtu) traffic
Aug 10 2018, 5:37 PM · Intel Networking

Aug 9 2018

erj updated the diff for D16429: ixlv(4): Update to use iflib; change name to iavf(4).
  • ixl(4): Fix compile error when PCI_IOV isn't defined
Aug 9 2018, 10:24 PM · Intel Networking
erj updated the diff for D16429: ixlv(4): Update to use iflib; change name to iavf(4).

Changes from D16428:

  • iflib: Prevent kernel panic on detach in _task_fn_admin by checking if in detach
  • iflib: Add STATE_LOCK() around flag setting in iflib_request_reset()

New changes for D16429:

  • ixl(4): Add tunable to enable VF loopback; enable by default
  • ixl/ixlv(4): Fix dev.ixl/v.#.vsi.rxq#.bytes sysctl not incrementing
Aug 9 2018, 6:41 PM · Intel Networking
erj updated the diff for D16428: iflib: Changes for ixlv(4) update.
  • iflib: Prevent kernel panic on detach in _task_fn_admin by checking if in detach
  • iflib: Add STATE_LOCK() around flag setting in iflib_request_reset()
Aug 9 2018, 6:39 PM · Intel Networking

Aug 3 2018

erj updated the diff for D16429: ixlv(4): Update to use iflib; change name to iavf(4).
  • ixl(4): Lie to the VF about configuring promiscuous mode if VF isn't allowed to configure it
Aug 3 2018, 6:33 PM · Intel Networking

Aug 2 2018

erj added a comment to D16429: ixlv(4): Update to use iflib; change name to iavf(4).

@gallatin, I address your specific comments, but I would need to look through ixlvc.c some more to find more code that can be shared. There is almost certainly some in there that can be shared between the PF/VF drivers.

Aug 2 2018, 8:48 PM · Intel Networking
erj updated the diff for D16429: ixlv(4): Update to use iflib; change name to iavf(4).
  • ixl(4): Combine PF-only/VF-only ixl_disable_rings() in PF driver into one function.
  • Remove a space
Aug 2 2018, 8:47 PM · Intel Networking
erj planned changes to D16428: iflib: Changes for ixlv(4) update.

I need to add the state lock to iflib_request_reset

Aug 2 2018, 5:08 PM · Intel Networking

Aug 1 2018

erj accepted D16534: e1000: Don't use 9k jumbo clusters.
Aug 1 2018, 7:52 PM