Page MenuHomeFreeBSD
People erj

erj (Eric Joyner)
Network Software Engineer @ Intel

Projects

User Details

User Since
Jan 27 2015, 7:34 PM (237 w, 4 d)

Recent Activity
View All

Yesterday

erj closed D21041: net: Update SFF-8024 definitions and strings with values from rev 4.6.
Sat, Aug 17, 12:11 AM · network
erj committed rS351153: net: Update SFF-8024 definitions and strings with values from rev 4.6.
net: Update SFF-8024 definitions and strings with values from rev 4.6
Sat, Aug 17, 12:11 AM

Fri, Aug 16

erj committed rS351152: iflib: add iflib_deregister to help cleanup on exit.
iflib: add iflib_deregister to help cleanup on exit
Fri, Aug 16, 11:34 PM
erj closed D21005: iflib: add iflib_deregister to help cleanup on exit.
Fri, Aug 16, 11:34 PM
erj accepted D21005: iflib: add iflib_deregister to help cleanup on exit.
Fri, Aug 16, 11:33 PM

Thu, Aug 1

erj committed rS350509: iflib: Prevent kernel panic caused by loading driver with a specific interrupt….
iflib: Prevent kernel panic caused by loading driver with a specific interrupt…
Thu, Aug 1, 5:37 PM
erj closed D20747: iflib: Prevent kernel panic caused by loading driver with a specific interrupt configuration.
Thu, Aug 1, 5:37 PM
erj committed rS350507: iflib: remove kobject class reference increment.
iflib: remove kobject class reference increment
Thu, Aug 1, 5:29 PM
erj closed D21125: iflib: remove kobject class reference increment.
Thu, Aug 1, 5:29 PM
erj accepted D21125: iflib: remove kobject class reference increment.
Thu, Aug 1, 5:20 PM

Wed, Jul 24

erj closed D21003: iflib: fix dangling device softc pointer.
Wed, Jul 24, 9:44 PM
erj committed rS350306: iflib: fix dangling device softc pointer.
iflib: fix dangling device softc pointer
Wed, Jul 24, 9:44 PM
erj added a reviewer for D21005: iflib: add iflib_deregister to help cleanup on exit: gallatin.
Wed, Jul 24, 4:38 PM
erj added a reviewer for D21003: iflib: fix dangling device softc pointer: gallatin.
Wed, Jul 24, 4:38 PM
erj added inline comments to D21041: net: Update SFF-8024 definitions and strings with values from rev 4.6.
Wed, Jul 24, 4:29 PM · network
erj added reviewers for D21041: net: Update SFF-8024 definitions and strings with values from rev 4.6: hselasky, melifaro, jhb, np.
Wed, Jul 24, 4:23 PM · network

Tue, Jul 23

erj created D21041: net: Update SFF-8024 definitions and strings with values from rev 4.6.
Tue, Jul 23, 8:45 PM · network
erj added a comment to D21005: iflib: add iflib_deregister to help cleanup on exit.
In D21005#455734, @jacob.e.keller_intel.com wrote:

This is built on top of https://reviews.freebsd.org/D21004
It could probably be backported, but isn't as necessary as the previous patch which is why I kept them separate.

Tue, Jul 23, 6:17 PM
erj committed rS350253: ixgbe(4): Fix enabling/disabling and reconfiguration of queues.
ixgbe(4): Fix enabling/disabling and reconfiguration of queues
Tue, Jul 23, 6:14 PM
erj closed D20826: ixgbe(4): Fix enabling/disabling and reconfiguration of queues.
Tue, Jul 23, 6:14 PM
erj accepted D20826: ixgbe(4): Fix enabling/disabling and reconfiguration of queues.
Tue, Jul 23, 6:13 PM
erj accepted D21003: iflib: fix dangling device softc pointer.
Tue, Jul 23, 5:44 PM

Jun 24 2019

erj added a comment to D20747: iflib: Prevent kernel panic caused by loading driver with a specific interrupt configuration.

Wrap line to keep it under 80 cols

Jun 24 2019, 11:26 PM
erj abandoned D20749: iflib: Prevent kernel panic caused by loading driver with a specific interrupt configuration.
Jun 24 2019, 11:25 PM
erj created D20749: iflib: Prevent kernel panic caused by loading driver with a specific interrupt configuration.
Jun 24 2019, 11:25 PM
erj created D20747: iflib: Prevent kernel panic caused by loading driver with a specific interrupt configuration.
Jun 24 2019, 8:17 PM
erj added a comment to D20290: Update Intel XL710 PF and VF drivers to version ixl-1.11.9 and ixlv-1.5.8.

This was committed to stable/11 in rS349163 and releng/11.3 in rS349181.

Jun 24 2019, 6:39 PM

Jun 19 2019

erj committed rS349181: MFS r349163: ixl(4)/ixlv(4): Update Intel XL710 PF and VF drivers to ixl-1.11.9….
MFS r349163: ixl(4)/ixlv(4): Update Intel XL710 PF and VF drivers to ixl-1.11.9…
Jun 19 2019, 12:38 AM

Jun 18 2019

erj committed rS349163: ixl(4)/ixlv(4): Update Intel XL710 PF and VF drivers to ixl-1.11.9 and ixlv-1.5..
ixl(4)/ixlv(4): Update Intel XL710 PF and VF drivers to ixl-1.11.9 and ixlv-1.5.
Jun 18 2019, 12:08 AM

May 29 2019

erj accepted D20428: ixl(4): fix the code not guarded by the guarded by the if clause.

This is fine -- this was a result of our code stripping process, I think.

May 29 2019, 10:25 PM
erj committed rS348372: iflib: provide probe wrapper for vendor drivers.
iflib: provide probe wrapper for vendor drivers
May 29 2019, 10:24 PM
erj closed D20221: iflib: provide probe wrapper for vendor drivers.
May 29 2019, 10:24 PM

May 10 2019

erj accepted D20221: iflib: provide probe wrapper for vendor drivers.
May 10 2019, 5:11 PM
erj committed rS347419: ix(4): Move {mod,msf,mbx,fdir,phy,link}_task to lock protected handler.
ix(4): Move {mod,msf,mbx,fdir,phy,link}_task to lock protected handler
May 10 2019, 12:46 AM
erj closed D19711: ix(4): Move {mod,msf,mbx,fdir,phy,link}_task to lock protected handler.
May 10 2019, 12:46 AM · Intel Networking
erj committed rS347418: iflib: use default ntxd and nrxd when user value is not power of 2.
iflib: use default ntxd and nrxd when user value is not power of 2
May 10 2019, 12:42 AM
erj closed D19880: iflib: use default ntxd and nrxd when user value is not power of 2.
May 10 2019, 12:42 AM

May 8 2019

erj committed rS347373: iflib: Add missing return statement that was left out from r347197.
iflib: Add missing return statement that was left out from r347197
May 8 2019, 11:13 PM

May 6 2019

erj committed rS347213: MFC r345312: iflib: mark isc_driver_version as constant.
MFC r345312: iflib: mark isc_driver_version as constant
May 6 2019, 9:31 PM
erj committed rS347212: MFC r345303, 345658, and partially MFC r345305.
MFC r345303, 345658, and partially MFC r345305
May 6 2019, 9:21 PM
erj committed rS347210: MFC r344817: Remove references to CONTIGMALLOC_WORKS in iflib and em.
MFC r344817: Remove references to CONTIGMALLOC_WORKS in iflib and em
May 6 2019, 8:48 PM
erj committed rS347208: MFC r340435: Prevent POLA violation with TSO/CSUM offload.
MFC r340435: Prevent POLA violation with TSO/CSUM offload
May 6 2019, 8:42 PM
erj closed D19949: MFC important iflib changes to stable/11.
May 6 2019, 6:50 PM
erj committed rS347197: MFC r332389, r3342331, r334343, and partially r339338.
MFC r332389, r3342331, r334343, and partially r339338
May 6 2019, 6:50 PM

Apr 18 2019

erj added a reviewer for D19949: MFC important iflib changes to stable/11: Intel Networking.
Apr 18 2019, 1:33 AM
erj created D19949: MFC important iflib changes to stable/11.
Apr 18 2019, 1:32 AM
erj abandoned D19947: MFC r344817: Remove references to CONTIGMALLOC_WORKS in iflib and em.
Apr 18 2019, 1:19 AM

Apr 17 2019

erj updated the diff for D19947: MFC r344817: Remove references to CONTIGMALLOC_WORKS in iflib and em.

Attempt to fix paths for stable/11.

Apr 17 2019, 11:36 PM
erj created D19947: MFC r344817: Remove references to CONTIGMALLOC_WORKS in iflib and em.
Apr 17 2019, 11:34 PM
erj committed rS346338: MFC r345312.
MFC r345312
Apr 17 2019, 11:09 PM
erj committed rS346337: MFC r345303, r345305, r345657, r345658.
MFC r345303, r345305, r345657, r345658
Apr 17 2019, 11:02 PM
erj committed rS346336: MFC r344817.
MFC r344817
Apr 17 2019, 10:45 PM
erj committed rS346335: MFC r344643 and r345306.
MFC r344643 and r345306
Apr 17 2019, 10:41 PM

Apr 16 2019

erj updated the diff for D19647: ifconfig: Add option to report VF status info.
  • Replace a space after #define with tab
Apr 16 2019, 12:40 AM

Apr 11 2019

erj updated the diff for D19647: ifconfig: Add option to report VF status info.
  • ifconfig: Add option to report VF status info
  • ixl: Add a license to ifvfstatus.c
  • ixl: Updates to if_ixl.c
  • Add spare data fields to struct ifvfstatus
Apr 11 2019, 6:38 PM
erj added inline comments to D19647: ifconfig: Add option to report VF status info.
Apr 11 2019, 6:18 PM

Mar 28 2019

erj closed D19652: iflib: return ENETDOWN when the network device is down.
Mar 28 2019, 8:47 PM
erj committed rS345658: iflib: return ENETDOWN when the network device is down.
iflib: return ENETDOWN when the network device is down
Mar 28 2019, 8:47 PM
erj committed rS345657: iflib: hold the CTX lock in iflib_pseudo_register.
iflib: hold the CTX lock in iflib_pseudo_register
Mar 28 2019, 8:44 PM
erj closed D19604: iflib: hold the CTX lock in iflib_pseudo_register.
Mar 28 2019, 8:44 PM

Mar 19 2019

erj committed rS345312: iflib: mark isc_driver_version as constant.
iflib: mark isc_driver_version as constant
Mar 19 2019, 11:44 PM
erj closed D19577: iflib: mark isc_driver_version as constant.
Mar 19 2019, 11:44 PM
erj accepted D19577: iflib: mark isc_driver_version as constant.
Mar 19 2019, 11:24 PM
erj created D19647: ifconfig: Add option to report VF status info.
Mar 19 2019, 6:25 PM
erj planned changes to D19647: ifconfig: Add option to report VF status info.
Mar 19 2019, 6:25 PM
erj accepted D19604: iflib: hold the CTX lock in iflib_pseudo_register.

Anyone else have any feedback? It makes sense to me that the attach process for pseudo devices should use the context lock like the attach process for regular devices.

Mar 19 2019, 6:09 PM
erj closed D19402: ixv(4): Add missing IFLIB_IS_VF flag in iflib shared ctx.
Mar 19 2019, 6:07 PM
erj committed rS345306: ixv(4): Add missing IFLIB_IS_VF flag in iflib shared ctx.
ixv(4): Add missing IFLIB_IS_VF flag in iflib shared ctx
Mar 19 2019, 6:07 PM
erj accepted D19402: ixv(4): Add missing IFLIB_IS_VF flag in iflib shared ctx.
Mar 19 2019, 6:03 PM
erj resigned from D16875: Possible fix for "desc avail = " dmesg spam and igb breakage.

Should this revision get closed? Nothing's happened on it for months.

Mar 19 2019, 6:01 PM
erj committed rS345305: iflib: expose the Rx mbuf buffer size to drivers.
iflib: expose the Rx mbuf buffer size to drivers
Mar 19 2019, 6:00 PM
erj closed D19489: iflib: expose the Rx mbuf buffer size to drivers.
Mar 19 2019, 6:00 PM
erj accepted D19489: iflib: expose the Rx mbuf buffer size to drivers.
Mar 19 2019, 5:52 PM
erj closed D19468: iflib: prevent possible infinite loop in iflib_encap.
Mar 19 2019, 5:49 PM
erj committed rS345303: iflib: prevent possible infinite loop in iflib_encap.
iflib: prevent possible infinite loop in iflib_encap
Mar 19 2019, 5:49 PM
erj added inline comments to D19645: add pfil hooks to iflib.
Mar 19 2019, 5:03 PM

Mar 14 2019

erj added a member for iflib: erj.
Mar 14 2019, 4:49 PM

Mar 13 2019

erj accepted D19577: iflib: mark isc_driver_version as constant.
Mar 13 2019, 11:40 PM
erj added inline comments to D19489: iflib: expose the Rx mbuf buffer size to drivers.
Mar 13 2019, 6:46 PM

Mar 7 2019

erj added inline comments to D19489: iflib: expose the Rx mbuf buffer size to drivers.
Mar 7 2019, 8:34 PM
erj accepted D19279: ix(4): Fix SRIOV initialization.
Mar 7 2019, 6:38 PM

Mar 5 2019

erj committed rS344817: Remove references to CONTIGMALLOC_WORKS in iflib and em.
Remove references to CONTIGMALLOC_WORKS in iflib and em
Mar 5 2019, 7:13 PM
erj closed D19199: remove references to CONTIGMALLOC_WORKS in iflib.
Mar 5 2019, 7:12 PM

Mar 2 2019

erj added a comment to D19279: ix(4): Fix SRIOV initialization.

Does this match what the Linux PF driver does?

Mar 2 2019, 12:38 AM
erj accepted D19402: ixv(4): Add missing IFLIB_IS_VF flag in iflib shared ctx.
Mar 2 2019, 12:37 AM

Feb 27 2019

erj committed rS344643: ixgbe(4): Fix panic triggered by assertion from interrupt.
ixgbe(4): Fix panic triggered by assertion from interrupt
Feb 27 2019, 10:26 PM

Feb 21 2019

erj accepted D19175: ix: Fix accessing wrong register.
Feb 21 2019, 7:09 PM
erj accepted D19176: ix, ixv: Update link status with autonegotiated baudrate value.
Feb 21 2019, 7:09 PM

Feb 15 2019

erj committed rS344163: MFC r344132:.
MFC r344132:
Feb 15 2019, 7:13 PM

Feb 14 2019

erj committed rS344132: ixl: Fix panic caused by bug exposed by r344062.
ixl: Fix panic caused by bug exposed by r344062
Feb 14 2019, 6:02 PM

Feb 7 2019

erj added a comment to D18469: ix: Fix accessing wrong register, improve WoL support recognition ix, ixv: Update link status with autonegotiated baudrate value.

@piotr.pietruszewski_intel.com Are we going to abandon this for now?

Feb 7 2019, 8:18 PM
erj accepted D19070: Fix em(4) tx interrupt routing.
Feb 7 2019, 8:17 PM
erj added inline comments to D19108: Assorted fixes and cleanup for em(4).
Feb 7 2019, 8:05 PM

Jan 31 2019

erj committed rS343622: ix(4),ixv(4): Fix TSO offloads when TXCSUM is disabled.
ix(4),ixv(4): Fix TSO offloads when TXCSUM is disabled
Jan 31 2019, 9:53 PM
erj closed D18470: ix(4),ixv(4): Fix TSO offloads when TXCSUM is disabled.
Jan 31 2019, 9:53 PM
erj committed rS343621: ix(4): Run {mod,msf,mbx,fdir,phy}_task in if_update_admin_status.
ix(4): Run {mod,msf,mbx,fdir,phy}_task in if_update_admin_status
Jan 31 2019, 9:44 PM
erj closed D18468: ix(4): Run {mod,msf,mbx,fdir,phy}_task in if_update_admin_status.
Jan 31 2019, 9:44 PM
erj accepted D19041: Make iflib a loadable module..
In D19041#407181, @marius wrote:

Well, I would just have went with "PCI" but if you prefer to state all variants :)

Jan 31 2019, 7:03 PM
erj accepted D18470: ix(4),ixv(4): Fix TSO offloads when TXCSUM is disabled.
Jan 31 2019, 5:42 PM
erj added a comment to D19041: Make iflib a loadable module..

Would it be a good idea to group the iflib drivers together in the config files, so it's obvious there?

Jan 31 2019, 12:09 AM