Page MenuHomeFreeBSD

erj (Eric Joyner)
Network Software Engineer @ Intel

Projects

User Details

User Since
Jan 27 2015, 7:34 PM (317 w, 6 d)

Recent Activity

Tue, Feb 23

erj accepted D28900: iflib: Avoid double counting in rxeof.
Tue, Feb 23, 10:43 PM
erj added inline comments to D28900: iflib: Avoid double counting in rxeof.
Tue, Feb 23, 5:44 PM
erj updated the diff for D28640: ice(4): Update to version 0.28.1-k.
  • Commit the ice_ddp package in a separate commit
Tue, Feb 23, 2:06 AM
erj committed R10:a7ac518bff64: ice_ddp: Update package file to 1.3.19.0 (authored by erj).
ice_ddp: Update package file to 1.3.19.0
Tue, Feb 23, 2:04 AM

Thu, Feb 18

erj accepted D28774: iflib: Fix detach of pseudo interfaces.
Thu, Feb 18, 10:06 PM
erj planned changes to D28636: iavf: Split source and update to 3.0.26.
Thu, Feb 18, 5:45 AM

Wed, Feb 17

erj accepted D28598: iflib: Cast the result of iflib_netmap_txq_init() to void..
Wed, Feb 17, 11:21 PM
erj requested changes to D28598: iflib: Cast the result of iflib_netmap_txq_init() to void..

So, it sounds like it'd be preferred to use (void)0 instead of using an empty stub?

Wed, Feb 17, 10:38 PM
erj added a comment to D21797: Add IFCAP_NOMAP to iflib.

Is this going to get committed?

Wed, Feb 17, 7:09 PM
erj added inline comments to D28706: iflib: add new field: isc_dma_width.
Wed, Feb 17, 7:08 PM
erj updated the diff for D28640: ice(4): Update to version 0.28.1-k.
  • Actually make the new ice_vlan_mode.c file that was added
Wed, Feb 17, 2:01 AM
erj retitled D28640: ice(4): Update to version 0.28.1-k from ice(4): Update to version 0.28.0-k to ice(4): Update to version 0.28.1-k.
Wed, Feb 17, 1:39 AM
erj updated the diff for D28640: ice(4): Update to version 0.28.1-k.
  • ice: Update to 0.28.1-k from 0.28.0-k, restore changes made by non-Intel commits
Wed, Feb 17, 1:38 AM

Tue, Feb 16

erj planned changes to D28640: ice(4): Update to version 0.28.1-k.

I also need to make other changes to this, too.

Tue, Feb 16, 7:54 PM
erj added inline comments to D28640: ice(4): Update to version 0.28.1-k.
Tue, Feb 16, 5:30 PM

Sat, Feb 13

erj added reviewers for D28640: ice(4): Update to version 0.28.1-k: Intel Networking, iflib.
Sat, Feb 13, 12:30 AM
erj requested review of D28640: ice(4): Update to version 0.28.1-k.
Sat, Feb 13, 12:29 AM
erj updated the summary of D28637: iavf: Add Doxyfile.
Sat, Feb 13, 12:18 AM
erj added reviewers for D28636: iavf: Split source and update to 3.0.26: Intel Networking, iflib.
Sat, Feb 13, 12:16 AM
erj requested review of D28638: ixl(4): Remove iavf(4) source files.
Sat, Feb 13, 12:15 AM
erj requested review of D28637: iavf: Add Doxyfile.
Sat, Feb 13, 12:15 AM
erj requested review of D28636: iavf: Split source and update to 3.0.26.
Sat, Feb 13, 12:15 AM

Thu, Feb 11

erj added a reviewer for D28598: iflib: Cast the result of iflib_netmap_txq_init() to void.: vmaffione.
Thu, Feb 11, 11:03 PM

Thu, Feb 4

erj closed D28137: ixl(4): Fix VLAN HW filtering.
Thu, Feb 4, 11:35 PM
erj committed R10:7d4dceec1030: ixl(4): Fix VLAN HW filtering (authored by krzysztof.galazka_intel.com).
ixl(4): Fix VLAN HW filtering
Thu, Feb 4, 11:34 PM

Nov 24 2020

erj updated subscribers of D27291: sysutils/intel-nvmupdate: Update to version 8.10.
Nov 24 2020, 9:33 PM
erj edited reviewers for D27265: Use the standard method for localizing of MSI-X table bar., added: Intel Networking; removed: erj.
Nov 24 2020, 9:32 PM
erj updated subscribers of D27265: Use the standard method for localizing of MSI-X table bar..
Nov 24 2020, 9:31 PM
erj updated subscribers of D27342: Detach Rx/Tx/IOV tasks upon iflib device or psuedo device register failure..
Nov 24 2020, 9:30 PM
erj updated subscribers of D27260: em: fix a null de-reference in em_free_pci_resources.
Nov 24 2020, 9:30 PM

Nov 20 2020

erj accepted D27191: ix(4): Report RX errors as sum of all RX error counters.
Nov 20 2020, 12:36 AM
erj added a comment to D27291: sysutils/intel-nvmupdate: Update to version 8.10.

portlint output:

Nov 20 2020, 12:22 AM
erj requested review of D27291: sysutils/intel-nvmupdate: Update to version 8.10.
Nov 20 2020, 12:19 AM

Sep 23 2020

erj committed rS366097: MFS r365983.
MFS r365983
Sep 23 2020, 11:57 PM

Sep 21 2020

erj committed rS365983: MFC r365774 and r365776.
MFC r365774 and r365776
Sep 21 2020, 10:53 PM

Sep 15 2020

erj committed rS365776: e1000: Properly retain promisc flag.
e1000: Properly retain promisc flag
Sep 15 2020, 9:07 PM
erj committed rS365774: igb(4): Fix define and includes with RSS option enabled.
igb(4): Fix define and includes with RSS option enabled
Sep 15 2020, 9:00 PM
erj closed D26322: ice(4): Update to 0.26.16.
Sep 15 2020, 8:56 PM

Sep 14 2020

erj committed rS365736: MFS r365647: ixl powerpc64 fixes.
MFS r365647: ixl powerpc64 fixes
Sep 14 2020, 11:49 PM
erj committed rS365733: ice(4): Add Intel 100GbE Ethernet Driver to kernel.
ice(4): Add Intel 100GbE Ethernet Driver to kernel
Sep 14 2020, 10:43 PM
erj committed rS365731: ice: MFC commits for update to 0.26.16.
ice: MFC commits for update to 0.26.16
Sep 14 2020, 9:33 PM

Sep 12 2020

erj committed rS365647: MFC r358698 and r364241.
MFC r358698 and r364241
Sep 12 2020, 12:22 AM

Sep 11 2020

erj accepted D26276: Add definitions for the Finisar 40GE LM4 transceiver.

Yeah, I think the rest of this looks good.

Sep 11 2020, 8:17 PM
erj added a comment to D26383: net/intel-em-kmod: Update to 7.7.8.
MAX_NETMAP_OSVERSION=   1199999  # Doesn't build w/NETMAP on 12

@erj, is it still true?

Sep 11 2020, 8:14 PM

Sep 10 2020

erj committed rS365617: ice(4): Update to 0.26.16.
ice(4): Update to 0.26.16
Sep 10 2020, 11:46 PM
erj updated the summary of D26322: ice(4): Update to 0.26.16.
Sep 10 2020, 11:43 PM
erj updated the summary of D26322: ice(4): Update to 0.26.16.
Sep 10 2020, 11:41 PM
erj updated the summary of D26322: ice(4): Update to 0.26.16.
Sep 10 2020, 11:40 PM
erj committed rS365612: MFC r361541, r362038, r364240.
MFC r361541, r362038, r364240
Sep 10 2020, 8:46 PM
erj updated the diff for D26322: ice(4): Update to 0.26.16.

Rebase with upstream with fixed package file.

Sep 10 2020, 5:21 AM
erj committed rS365550: ice_ddp: Fix 1.3.16.0 package.
ice_ddp: Fix 1.3.16.0 package
Sep 10 2020, 4:00 AM

Sep 9 2020

erj updated subscribers of D26383: net/intel-em-kmod: Update to 7.7.8.
Sep 9 2020, 9:48 PM
erj added a comment to D26383: net/intel-em-kmod: Update to 7.7.8.

poudriere testport log:

Sep 9 2020, 9:48 PM
erj added a comment to D26383: net/intel-em-kmod: Update to 7.7.8.

portlint -AC output:

WARN: Makefile: NETMAP_AUTO is listed in OPTIONS_DEFINE, but no PORT_OPTIONS:MNETMAP_AUTO appears in this slave Makefile.  Make sure it appears in the master's Makefile.
WARN: Makefile: NETMAP_ON is listed in OPTIONS_DEFINE, but no PORT_OPTIONS:MNETMAP_ON appears in this slave Makefile.  Make sure it appears in the master's Makefile.
WARN: Makefile: NETMAP_OFF is listed in OPTIONS_DEFINE, but no PORT_OPTIONS:MNETMAP_OFF appears in this slave Makefile.  Make sure it appears in the master's Makefile.
WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy.
WARN: Makefile: new ports should not set PORTREVISION.
WARN: Makefile: new ports should not set PORTEPOCH.
FATAL: Makefile: extra item "BROKEN_armv6" placed in the LICENSE section.
1 fatal error and 6 warnings found.
Sep 9 2020, 9:42 PM
erj requested review of D26383: net/intel-em-kmod: Update to 7.7.8.
Sep 9 2020, 9:40 PM

Sep 4 2020

erj committed rS365339: MFC r365231: ixl(4): Add support for X710-T*L devices.
MFC r365231: ixl(4): Add support for X710-T*L devices
Sep 4 2020, 9:21 PM
erj updated the diff for D26322: ice(4): Update to 0.26.16.

Commit package file updates since Phabricator cannot handle them properly

Sep 4 2020, 6:10 PM
erj updated the summary of D26322: ice(4): Update to 0.26.16.
Sep 4 2020, 5:41 PM
erj committed rS365332: ice_ddp: Update package file to 1.3.16.0.
ice_ddp: Update package file to 1.3.16.0
Sep 4 2020, 5:38 PM
erj added a comment to D26322: ice(4): Update to 0.26.16.

arc patch does not work with this revision, probably because of this Phabricator issue: https://secure.phabricator.com/T9069

Sep 4 2020, 5:25 PM
erj abandoned D26326: (TEST) update ice to 0.26.16.
Sep 4 2020, 5:08 PM
erj requested review of D26326: (TEST) update ice to 0.26.16.
Sep 4 2020, 5:06 PM
erj updated the diff for D26322: ice(4): Update to 0.26.16.

Remove ! characters from converted README

Sep 4 2020, 5:11 AM
erj updated the diff for D26322: ice(4): Update to 0.26.16.

Convert DDP README from utf-16le/dos to utf-8/unix

Sep 4 2020, 5:07 AM
erj added a comment to D26322: ice(4): Update to 0.26.16.

Why is sys/contrib/dev/ice/README a binary file?

Sep 4 2020, 4:59 AM
erj updated the diff for D26322: ice(4): Update to 0.26.16.

Fix some files.

Sep 4 2020, 4:48 AM
erj retitled D26322: ice(4): Update to 0.26.16 from ice: Update to 0.26.16 to ice(4): Update to 0.26.16.
Sep 4 2020, 4:36 AM
erj requested review of D26322: ice(4): Update to 0.26.16.
Sep 4 2020, 4:35 AM

Sep 1 2020

erj closed D25549: ixl(4): Add support for X710-T*L devices.
Sep 1 2020, 11:17 PM
erj committed rS365231: ixl(4): Add support for X710-T*L devices.
ixl(4): Add support for X710-T*L devices
Sep 1 2020, 11:17 PM
erj added a comment to D26276: Add definitions for the Finisar 40GE LM4 transceiver.

Hi, adding some Intel folks who have appeared on recent ixl(4) reviews/submissions.

I am attempting to upstream this patch from NetApp, who wrote it originally.
It seems that updates to these definitions usually come from upstream as part of
larger ixl driver updates, so forgive me if this is not the usual process.

Sep 1 2020, 8:57 PM

Aug 25 2020

erj added a comment to D25549: ixl(4): Add support for X710-T*L devices.

Any updates on this?

Aug 25 2020, 4:38 PM

Aug 22 2020

erj added a comment to D26118: sysutils/intel-nvmupdate: Update from 7.30 to 8.00.

New poudriere testport log:

Aug 22 2020, 2:40 AM
erj added a comment to D26118: sysutils/intel-nvmupdate: Update from 7.30 to 8.00.

New portlint output:

WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy.
0 fatal errors and 1 warning found.
Aug 22 2020, 2:34 AM
erj added a comment to D26118: sysutils/intel-nvmupdate: Update from 7.30 to 8.00.
In D26118#580232, @mat wrote:
In D26118#579726, @erj wrote:

Output from portlint -AC:

WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy.
WARN: Makefile: "IGNORE_DragonFly" has to appear earlier.
WARN: Makefile: "ONLY_FOR_ARCHS" has to appear earlier.
WARN: Makefile: "ONLY_FOR_ARCHS_REASON" has to appear earlier.
0 fatal errors and 4 warnings found.

Please do fix those warnings. The reference for how to write a Makefile is available there https://www.freebsd.org/doc/en/books/porters-handbook/porting-order.html

Aug 22 2020, 2:33 AM
erj updated the diff for D26118: sysutils/intel-nvmupdate: Update from 7.30 to 8.00.

Edit Makefile to make portlint happy

Aug 22 2020, 2:31 AM

Aug 21 2020

erj added a comment to D26106: net/intel-ixl-kmod: Update to 1.12.2.

I've attached the poudriere testport log:

Aug 21 2020, 7:45 PM

Aug 18 2020

erj added a comment to D26106: net/intel-ixl-kmod: Update to 1.12.2.

portlint -AC output:

WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy.
WARN: Makefile: unless this is a master port, PORTNAME has to be set by "=", not by "?=".
WARN: Makefile: unless this is a master port, PORTVERSION has to be set by "=", not by "?=".
WARN: Makefile: new ports should not set PORTREVISION.
WARN: Makefile: unless this is a master port, MAINTAINER has to be set by "=", not by "?=".
WARN: Makefile: unless this is a master port, COMMENT has to be set by "=", not by "?=".
WARN: Makefile: "ONLY_FOR_ARCHS" has to appear earlier.
WARN: Makefile: "ONLY_FOR_ARCHS_REASON" has to appear earlier.
0 fatal errors and 8 warnings found.
Aug 18 2020, 10:08 PM
erj requested review of D26118: sysutils/intel-nvmupdate: Update from 7.30 to 8.00.
Aug 18 2020, 9:51 PM
erj updated the summary of D26106: net/intel-ixl-kmod: Update to 1.12.2.
Aug 18 2020, 5:45 PM
erj requested review of D26106: net/intel-ixl-kmod: Update to 1.12.2.
Aug 18 2020, 5:44 PM

Aug 10 2020

erj accepted D25953: Remove redeclaration found by gcc build.

@jacob.e.keller_intel.com do you maybe have any thoughts on this, too?

Aug 10 2020, 10:29 PM
erj added a comment to D25953: Remove redeclaration found by gcc build.

The latter nvm related functions can be removed immediately; these have been removed in a newer version of the driver.

Aug 10 2020, 10:27 PM

Aug 4 2020

erj committed rS363876: MFC r361992: ixl(4): Add FW recovery mode support and other things.
MFC r361992: ixl(4): Add FW recovery mode support and other things
Aug 4 2020, 11:30 PM

Jul 30 2020

erj committed rS363712: MFC r358908: Enable ixl device on PowerPC64.
MFC r358908: Enable ixl device on PowerPC64
Jul 30 2020, 7:11 PM
erj committed rS363711: MFC r362063: em(4): Always reinit interface when adding/removing VLAN.
MFC r362063: em(4): Always reinit interface when adding/removing VLAN
Jul 30 2020, 6:31 PM

Jul 29 2020

erj added a reviewer for D25873: vxlan(4): Support for stateless NIC hardware offloads with VXLAN encapsulated traffic.: gallatin.
Jul 29 2020, 6:06 PM

Jun 26 2020

erj added a comment to D21122: Proof-of-concept hack: remove mp_ring from TX path.

Is someone else going to take over? Is this still something worthwhile to pursue? It seems like it based on the latest comments.

Jun 26 2020, 2:53 PM

Jun 25 2020

erj accepted D25408: dev.ixl.<N>.debug: mark as MPSAFE.

How did you find this? Do you have something automated that checks for this?

Jun 25 2020, 7:58 PM

Jun 12 2020

erj committed rS362080: MFC r361805: em(4): Add support for Comet Lake Mobile Platform.
MFC r361805: em(4): Add support for Comet Lake Mobile Platform
Jun 12 2020, 12:42 AM

Jun 11 2020

erj committed rS362063: em(4): Always reinit interface when adding/removing VLAN.
em(4): Always reinit interface when adding/removing VLAN
Jun 11 2020, 4:00 PM

Jun 10 2020

erj accepted D25222: Hard-code the ice_ddp firmware version..
Jun 10 2020, 11:59 PM
erj closed D24564: ixl(4): Add FW recovery mode support.

I committed this in rS361992.

Jun 10 2020, 4:10 PM

Jun 9 2020

erj committed rS361992: ixl(4): Add FW recovery mode support and other things.
ixl(4): Add FW recovery mode support and other things
Jun 9 2020, 10:43 PM
erj accepted D24564: ixl(4): Add FW recovery mode support.
Jun 9 2020, 10:38 PM
erj accepted D24564: ixl(4): Add FW recovery mode support.

This description looks better; thanks.

Jun 9 2020, 10:37 PM

Jun 4 2020

erj committed rS361805: em(4): Add support for Comet Lake Mobile Platform, update shared code.
em(4): Add support for Comet Lake Mobile Platform, update shared code
Jun 4 2020, 8:39 PM
erj closed D25035: em(4): Add support for Comet Lake Mobile Platform, update shared code.
Jun 4 2020, 8:39 PM
erj accepted D25035: em(4): Add support for Comet Lake Mobile Platform, update shared code.
Jun 4 2020, 8:36 PM
erj requested changes to D24564: ixl(4): Add FW recovery mode support.

Before I commit this, I'd like to have a better description of the changes that are going into this patch; I see there are changes around Recovery Mode support, but I'd like things like significant bugs or feature additions to be called out since this is pretty large.

Jun 4 2020, 8:31 PM