Page MenuHomeFreeBSD

erj (Eric Joyner)
Network Software Engineer @ Intel

Projects

User Details

User Since
Jan 27 2015, 7:34 PM (435 w, 3 d)

Recent Activity

Yesterday

erj committed rG197106cf41df: ixgbe: Change if condition for RSS and rxcsum (authored by przemyslawx.lewandowski_intel.com).
ixgbe: Change if condition for RSS and rxcsum
Fri, Jun 2, 7:37 PM
erj committed rG95aced446a8c: ixgbe: Change if condition for RSS and rxcsum (authored by przemyslawx.lewandowski_intel.com).
ixgbe: Change if condition for RSS and rxcsum
Fri, Jun 2, 7:31 PM
erj committed rGa138508ef6b0: ice(4): Update to 1.37.11-k (authored by erj).
ice(4): Update to 1.37.11-k
Fri, Jun 2, 7:20 PM

Fri, May 26

erj closed D39821: ice(4): Update to 1.37.11-k.
Fri, May 26, 9:50 AM

Wed, May 24

erj committed rG9dc2f6e26fc2: ice(4): Update to 1.37.11-k (authored by erj).
ice(4): Update to 1.37.11-k
Wed, May 24, 11:44 PM
erj closed D38621: ixgbe: Change if condition for RSS and rxcsum.
Wed, May 24, 11:37 PM
erj committed rG156424fce98a: ixgbe: Change if condition for RSS and rxcsum (authored by przemyslawx.lewandowski_intel.com).
ixgbe: Change if condition for RSS and rxcsum
Wed, May 24, 11:37 PM
erj accepted D38621: ixgbe: Change if condition for RSS and rxcsum.
Wed, May 24, 11:26 PM

Tue, May 16

erj accepted D39977: em: sync platform detection with Linux.
Tue, May 16, 8:46 PM

Mon, May 15

erj accepted D40003: ix(4): correct max MTU.

This looks accurate to me. Is there other review required from someone in doc?

Mon, May 15, 10:56 PM

May 3 2023

erj added inline comments to D39930: iflib: Add helper functions for subinterface creation.
May 3 2023, 12:23 AM

May 1 2023

erj published D39930: iflib: Add helper functions for subinterface creation for review.
May 1 2023, 11:43 PM
erj abandoned D39929: iflib: Add subinterface interrupt allocation function.
May 1 2023, 11:43 PM
erj abandoned D39928: iflib: Add sysctl to request extra MSIX vectors on driver load.
May 1 2023, 11:42 PM
erj requested review of D39929: iflib: Add subinterface interrupt allocation function.
May 1 2023, 11:35 PM
erj requested review of D39928: iflib: Add sysctl to request extra MSIX vectors on driver load.
May 1 2023, 11:35 PM

Apr 26 2023

erj added a reviewer for D39785: ixgbe: Warn once for unsupported SFPs: krzysztof.galazka_intel.com.
Apr 26 2023, 4:23 AM
erj added a reviewer for D39821: ice(4): Update to 1.37.11-k: Intel Networking.
Apr 26 2023, 4:20 AM

Apr 25 2023

erj accepted D39719: irdma: Silence an unused function warning.

Bartek is currently out, but I'll approve it in his absence for now. It'd be nice to know why that function is unused.

Apr 25 2023, 10:43 PM
erj requested review of D39821: ice(4): Update to 1.37.11-k.
Apr 25 2023, 10:21 PM

Apr 17 2023

erj added a comment to D39457: iflib: fix panic during driver reload stress test.
In D39457#900952, @jhb wrote:

It may be that the current interrupt code has a race in bus_teardown_intr() when used with filters in that we can't ensure that bus_teardown_intr() will block if the filter handler is running on another core, but in that case that's the real race to fix.

Apr 17 2023, 6:44 PM

Apr 12 2023

erj accepted D39510: net: replace IFF_KNOWSEPOCH with IFF_NEEDSEPOCH.
Apr 12 2023, 4:39 PM

Apr 10 2023

erj accepted D39466: Use macros CTLFLAG_R[DW]TUN.
Apr 10 2023, 4:06 PM

Mar 28 2023

erj closed D39173: irdma(4): upgrade the driver to 1.1.11-k.

Committed in rG35105900c65bb5adcde05d37ae34ad006970d4f9.

Mar 28 2023, 9:58 PM
erj committed rG35105900c65b: irdma(4): Upgrade the driver to 1.1.11-k (authored by bartosz.sobczak_intel.com).
irdma(4): Upgrade the driver to 1.1.11-k
Mar 28 2023, 9:30 PM

Mar 24 2023

erj added a comment to D38929: ice: Use IfAPI accessor in place of if_capenable reference.

@erj can you fix this the right way given what you also wrote in your now deleted comment? I could just revert the original change to the line if that's all that's needed.

Mar 24 2023, 7:07 AM
erj committed rG949d971f0b69: ice(4): Restore old conditional overwritten by last update (authored by erj).
ice(4): Restore old conditional overwritten by last update
Mar 24 2023, 7:06 AM

Mar 7 2023

erj added a reviewer for D38960: irdma: Convert to IfAPI: bartosz.sobczak_intel.com.
Mar 7 2023, 10:50 PM
erj added a comment to D38929: ice: Use IfAPI accessor in place of if_capenable reference.
Mar 7 2023, 12:13 AM
erj added a comment to D38929: ice: Use IfAPI accessor in place of if_capenable reference.

@erj was the original change to this intended? Before the change it was:

if ((scctx->isc_capenable & IFCAP_RXCSUM) != 0)

From the rest of the file it looks unintended, but I can't tell.

Mar 7 2023, 12:07 AM
erj accepted D38928: iflib: Further convert to use IfAPI accessors.
Mar 7 2023, 12:05 AM

Feb 21 2023

erj committed rG576955dd669e: ice(4): Update to 1.37.7-k (authored by pkubaj).
ice(4): Update to 1.37.7-k
Feb 21 2023, 11:58 PM
erj committed rG0f59de6879b8: ixl(4): Fix MAC/VLAN filters accounting (authored by krzysztof.galazka_intel.com).
ixl(4): Fix MAC/VLAN filters accounting
Feb 21 2023, 11:58 PM
erj committed rG7006923991c6: ixgbe(4): Filter out spurious link up indication (authored by krzysztof.galazka_intel.com).
ixgbe(4): Filter out spurious link up indication
Feb 21 2023, 11:58 PM
erj committed rGe8046d1cc4b9: ice_ddp: Update package to 1.3.30.0 (authored by erj).
ice_ddp: Update package to 1.3.30.0
Feb 21 2023, 11:58 PM
erj committed rGa6fa27eb5267: ixl(4): Fix MAC/VLAN filters accounting (authored by krzysztof.galazka_intel.com).
ixl(4): Fix MAC/VLAN filters accounting
Feb 21 2023, 10:46 PM
erj committed rG25d43e3c6b36: ixgbe(4): Filter out spurious link up indication (authored by krzysztof.galazka_intel.com).
ixgbe(4): Filter out spurious link up indication
Feb 21 2023, 10:46 PM
erj committed rGa8c86b2e05ca: irdma: fix LINT-NOIP/NOINET/NOINET6 builds (authored by mhorne).
irdma: fix LINT-NOIP/NOINET/NOINET6 builds
Feb 21 2023, 10:42 PM

Feb 17 2023

erj committed rGebc914f942f6: ice(4): Update to 1.37.7-k (authored by pkubaj).
ice(4): Update to 1.37.7-k
Feb 17 2023, 11:12 PM
erj committed rGcd280c60a5b8: ice_ddp: Update package to 1.3.30.0 (authored by erj).
ice_ddp: Update package to 1.3.30.0
Feb 17 2023, 11:12 PM

Feb 15 2023

erj committed rG7333d34e5ec9: irdma: fix LINT-NOIP/NOINET/NOINET6 builds (authored by mhorne).
irdma: fix LINT-NOIP/NOINET/NOINET6 builds
Feb 15 2023, 10:47 PM
erj committed rG04a5e6d7cadd: ixgbe(4): Filter out spurious link up indication (authored by krzysztof.galazka_intel.com).
ixgbe(4): Filter out spurious link up indication
Feb 15 2023, 10:42 PM
erj closed D38395: ixgbe(4): Filter out spurious link up indication.
Feb 15 2023, 10:41 PM
erj accepted D38395: ixgbe(4): Filter out spurious link up indication.
Feb 15 2023, 10:36 PM
erj committed rG1d02c6b1b859: ixl(4): Fix MAC/VLAN filters accounting (authored by krzysztof.galazka_intel.com).
ixl(4): Fix MAC/VLAN filters accounting
Feb 15 2023, 10:35 PM
erj closed D37457: ixl(4): Fix MAC/VLAN filters accounting.
Feb 15 2023, 10:35 PM
erj accepted D37457: ixl(4): Fix MAC/VLAN filters accounting.
Feb 15 2023, 10:35 PM

Feb 14 2023

erj closed D38109: ice: update to 1.37.7-k.

Committed in rG8923de59054358980102ea5acda6c6dd58273957.

Feb 14 2023, 5:10 PM
erj committed rG8923de590543: ice(4): Update to 1.37.7-k (authored by pkubaj).
ice(4): Update to 1.37.7-k
Feb 14 2023, 1:38 AM
erj accepted D38109: ice: update to 1.37.7-k.
Feb 14 2023, 1:31 AM

Feb 8 2023

erj committed rGc051c1ff703c: irdma(4): Upgrade driver to 1.1.5-k (authored by bartosz.sobczak_intel.com).
irdma(4): Upgrade driver to 1.1.5-k
Feb 8 2023, 12:27 AM
erj committed rGe7a0ef3217c6: irdma(4): remove 14-current specific code (authored by bartosz.sobczak_intel.com).
irdma(4): remove 14-current specific code
Feb 8 2023, 12:27 AM
erj committed rGe675a260ceba: irdma(4): Add code for compilation on stable/13 branch (authored by bartosz.sobczak_intel.com).
irdma(4): Add code for compilation on stable/13 branch
Feb 8 2023, 12:27 AM
erj committed rGe894da6d9a1d: irdma(4): hide tasklet-related definitions to avoid redefines (authored by bartosz.sobczak_intel.com).
irdma(4): hide tasklet-related definitions to avoid redefines
Feb 8 2023, 12:27 AM
erj committed rG42bad04a2156: irdma: Add RDMA driver for Intel(R) Ethernet Controller E810 (authored by bartosz.sobczak_intel.com).
irdma: Add RDMA driver for Intel(R) Ethernet Controller E810
Feb 8 2023, 12:27 AM
erj committed rG75b7e4f157e0: Adjust irdma_prep_for_unregister() definition to avoid clang 15 warning (authored by dim).
Adjust irdma_prep_for_unregister() definition to avoid clang 15 warning
Feb 8 2023, 12:27 AM
erj committed rG3b65af50fc2a: ibcore: The use of IN_LOOPBACK() now requires a valid VNET context. (authored by hselasky).
ibcore: The use of IN_LOOPBACK() now requires a valid VNET context.
Feb 8 2023, 12:27 AM

Feb 7 2023

erj accepted D38423: IfAPI: Finish changes of ice(4)..
Feb 7 2023, 10:34 PM
erj committed rGc907f13af0e6: iflib: Add null check to iflib_stop() (authored by przemyslawx.lewandowski_intel.com).
iflib: Add null check to iflib_stop()
Feb 7 2023, 12:33 AM
erj committed rG4ad47cfc1458: iflib: Add null check to iflib_stop() (authored by przemyslawx.lewandowski_intel.com).
iflib: Add null check to iflib_stop()
Feb 7 2023, 12:17 AM

Feb 6 2023

erj committed rGb4e0be6df772: vtd: Increase DRHD_MAX_UNITS (authored by erj).
vtd: Increase DRHD_MAX_UNITS
Feb 6 2023, 10:52 PM
erj committed rG7aaa7dad32ca: vtd: Increase DRHD_MAX_UNITS (authored by erj).
vtd: Increase DRHD_MAX_UNITS
Feb 6 2023, 10:49 PM
erj committed rGa527c18cd7ba: irdma(4): Add code for compilation on stable/13 branch (authored by bartosz.sobczak_intel.com).
irdma(4): Add code for compilation on stable/13 branch
Feb 6 2023, 10:41 PM
erj closed D38170: irdma(4): add code for comipilation on stable/13 branch.
Feb 6 2023, 10:40 PM
erj committed rGc0548bfc3a09: em(4): Add IDs for new Intel(R) I219 devices (authored by pkubaj).
em(4): Add IDs for new Intel(R) I219 devices
Feb 6 2023, 10:37 PM
erj closed D38376: em: add support for Intel(R) I219-V RPL(22).
Feb 6 2023, 10:36 PM
erj accepted D38376: em: add support for Intel(R) I219-V RPL(22).
Feb 6 2023, 7:23 PM
erj added inline comments to D38376: em: add support for Intel(R) I219-V RPL(22).
Feb 6 2023, 6:57 PM
erj added inline comments to D38376: em: add support for Intel(R) I219-V RPL(22).
Feb 6 2023, 6:19 PM

Feb 3 2023

erj added a comment to D38376: em: add support for Intel(R) I219-V RPL(22).

The PR mentions only this one, the others were probably not tested. Do you think it would be appriopriate to add them anyway?

Feb 3 2023, 7:08 PM
erj added a comment to D38376: em: add support for Intel(R) I219-V RPL(22).

What about everything between I219 (19) and (22)? :p

Feb 3 2023, 7:02 PM
erj accepted D38374: iwm(4), iwmfw(4): mention iwm7265Dfw.
Feb 3 2023, 5:47 PM

Feb 1 2023

erj added a comment to D38285: vtd: Increase DRHD_MAX_UNITS.
In D38285#871102, @jhb wrote:

It would be nice to make these dynamically sized rather than a fixed-sized array. However, reviewing and integrating @kib's patch to use the ACPI_DMAR driver for this instead is probably the better long-term fix.

Feb 1 2023, 10:24 PM
erj accepted D38346: ixgbe: Do not count l3/l4 checksum errors as input errors.

I think this is reasonable.

Feb 1 2023, 8:32 PM

Jan 31 2023

erj closed D38285: vtd: Increase DRHD_MAX_UNITS.
Jan 31 2023, 9:58 PM
erj committed rG53545967642d: vtd: Increase DRHD_MAX_UNITS (authored by erj).
vtd: Increase DRHD_MAX_UNITS
Jan 31 2023, 9:58 PM

Jan 30 2023

erj updated the summary of D38109: ice: update to 1.37.7-k.
Jan 30 2023, 10:35 PM
erj updated the summary of D38285: vtd: Increase DRHD_MAX_UNITS.
Jan 30 2023, 9:43 PM
erj updated the summary of D38285: vtd: Increase DRHD_MAX_UNITS.
Jan 30 2023, 9:41 PM
erj updated the summary of D38285: vtd: Increase DRHD_MAX_UNITS.
Jan 30 2023, 9:40 PM
erj requested review of D38285: vtd: Increase DRHD_MAX_UNITS.
Jan 30 2023, 9:40 PM

Jan 24 2023

erj committed rG9147969bc277: iflib: Add null check to iflib_stop() (authored by przemyslawx.lewandowski_intel.com).
iflib: Add null check to iflib_stop()
Jan 24 2023, 11:47 PM
erj closed D37892: Add null check to iflib_stop().
Jan 24 2023, 11:47 PM
erj accepted D37892: Add null check to iflib_stop().
Jan 24 2023, 11:43 PM
erj added a comment to D38109: ice: update to 1.37.7-k.

I pushed the DDP update part, so this needs to be rebased.

Jan 24 2023, 10:26 PM
erj committed rG2508da22cd6f: ice_ddp: Update package to 1.3.30.0 (authored by erj).
ice_ddp: Update package to 1.3.30.0
Jan 24 2023, 10:22 PM

Jan 10 2023

erj accepted D37892: Add null check to iflib_stop().

I think this looks good.

Jan 10 2023, 11:08 PM
erj accepted D37858: Mechanically convert iavf(4) to DrvAPI.
Jan 10 2023, 6:20 PM
erj accepted D37857: Mechanically convert ixl(4) to DrvAPI.
Jan 10 2023, 6:19 PM
erj accepted D37845: Mechanically convert ixgbe(4) to DrvAPI.
Jan 10 2023, 6:18 PM

Dec 22 2022

erj closed D36944: irdma(4): upgrade the driver to 1.1.5-k.

Committed in linked commit.

Dec 22 2022, 1:19 AM
erj committed rG777e472cd86b: irdma(4): Upgrade driver to 1.1.5-k (authored by bartosz.sobczak_intel.com).
irdma(4): Upgrade driver to 1.1.5-k
Dec 22 2022, 1:16 AM
erj accepted D36944: irdma(4): upgrade the driver to 1.1.5-k.
Dec 22 2022, 1:11 AM

Dec 21 2022

erj added inline comments to D37768: Convert iflib(4) and iflib-based drivers to the DrvAPI.
Dec 21 2022, 7:45 PM
erj added inline comments to D37768: Convert iflib(4) and iflib-based drivers to the DrvAPI.
Dec 21 2022, 7:09 PM

Dec 12 2022

erj removed a member for Intel Networking: piotr.pietruszewski_intel.com.
Dec 12 2022, 11:31 PM
erj added a member for Intel Networking: pkubaj.
Dec 12 2022, 11:31 PM

Dec 9 2022

erj added inline comments to D36944: irdma(4): upgrade the driver to 1.1.5-k.
Dec 9 2022, 6:50 PM
erj added a reviewer for D36944: irdma(4): upgrade the driver to 1.1.5-k: jhb.
Dec 9 2022, 6:48 PM

Dec 6 2022

erj abandoned D34894: iflib: Introduce v2 of TX Queue Select Functionality (for stable/13).
Dec 6 2022, 5:11 PM