erj (Eric Joyner)
Network Software Engineer @ Intel

Projects

User Details

User Since
Jan 27 2015, 7:34 PM (173 w, 4 d)

Recent Activity

Yesterday

erj updated the diff for D15577: Update ixl(4) to use iflib..

Include contents of/update to D15558 again, since relying on dependent revisions
in Phabricator is a PITA.

Sat, May 26, 1:43 AM
erj added a dependency for D15577: Update ixl(4) to use iflib.: D15558: iflib: Record TCP checksum info in iflib for ixl(4).
Sat, May 26, 1:20 AM
erj added a dependent revision for D15558: iflib: Record TCP checksum info in iflib for ixl(4): D15577: Update ixl(4) to use iflib..
Sat, May 26, 1:20 AM · Intel Networking
erj updated the diff for D15577: Update ixl(4) to use iflib..

Pulled out TCP saving changes since those are in D15558

Sat, May 26, 1:20 AM
erj updated the diff for D15577: Update ixl(4) to use iflib..

Update due to D15575 being committed.

Sat, May 26, 1:09 AM
erj closed D15575: iflib: Add new shared flag to iflib: IFLIB_ADMIN_ALWAYS_RUN.
Sat, May 26, 12:46 AM
erj committed rS334231: iflib: Add new shared flag: IFLIB_ADMIN_ALWAYS_RUN.
iflib: Add new shared flag: IFLIB_ADMIN_ALWAYS_RUN
Sat, May 26, 12:46 AM

Fri, May 25

erj updated the diff for D15558: iflib: Record TCP checksum info in iflib for ixl(4).
  • iflib: Move stats increment in IPv6 case to match IPv4 case
Fri, May 25, 11:18 PM · Intel Networking
erj added inline comments to D15558: iflib: Record TCP checksum info in iflib for ixl(4).
Fri, May 25, 11:17 PM · Intel Networking
erj updated the diff for D15558: iflib: Record TCP checksum info in iflib for ixl(4).
  • iflib: Remove comment and restore/fix setting CSUM_IP6_TCP flag during TSO6
Fri, May 25, 10:52 PM · Intel Networking
erj added inline comments to D15558: iflib: Record TCP checksum info in iflib for ixl(4).
Fri, May 25, 7:52 PM · Intel Networking
erj updated the diff for D15575: iflib: Add new shared flag to iflib: IFLIB_ADMIN_ALWAYS_RUN.
  • Make style fix.
Fri, May 25, 7:37 PM
erj abandoned D5214: Convert ixl(4)to use iflib.

Replaced by https://reviews.freebsd.org/D15577

Fri, May 25, 7:19 PM
erj updated the summary of D15577: Update ixl(4) to use iflib..
Fri, May 25, 7:00 PM
erj updated the summary of D15577: Update ixl(4) to use iflib..
Fri, May 25, 6:59 PM
erj updated the summary of D15577: Update ixl(4) to use iflib..
Fri, May 25, 6:58 PM
erj updated the summary of D15577: Update ixl(4) to use iflib..
Fri, May 25, 6:54 PM
erj updated the diff for D15577: Update ixl(4) to use iflib..

Remove testing config files and make spelling fixes.

Fri, May 25, 6:52 PM
erj created D15577: Update ixl(4) to use iflib..
Fri, May 25, 6:50 PM
erj set the repository for D15575: iflib: Add new shared flag to iflib: IFLIB_ADMIN_ALWAYS_RUN to rS FreeBSD src repository.
Fri, May 25, 5:46 PM
erj created D15575: iflib: Add new shared flag to iflib: IFLIB_ADMIN_ALWAYS_RUN.
Fri, May 25, 5:45 PM

Thu, May 24

erj updated the diff for D15558: iflib: Record TCP checksum info in iflib for ixl(4).
  • iflib: Fixup changes made to record TCP checksum info in iflib for ixl
Thu, May 24, 9:27 PM · Intel Networking
erj updated the summary of D15558: iflib: Record TCP checksum info in iflib for ixl(4).
Thu, May 24, 6:30 PM · Intel Networking
erj added 1 blocking reviewer(s) for D15558: iflib: Record TCP checksum info in iflib for ixl(4): shurd.
Thu, May 24, 6:20 PM · Intel Networking
erj created D15558: iflib: Record TCP checksum info in iflib for ixl(4).
Thu, May 24, 6:16 PM · Intel Networking

Mon, May 14

erj committed rS333149: ixl(4): Update to 1.9.9-k.
ixl(4): Update to 1.9.9-k
Mon, May 14, 2:07 PM

Mon, May 7

erj committed rS333343: MFC r333149: ixl(4): Update to 1.9.9-k.
MFC r333149: ixl(4): Update to 1.9.9-k
Mon, May 7, 11:23 PM
erj committed rS333336: MFC r326571: ifconfig(8): Display extended compliance code string for SFP….
MFC r326571: ifconfig(8): Display extended compliance code string for SFP…
Mon, May 7, 9:26 PM
erj committed rS333331: MFC r319797, r320972:.
MFC r319797, r320972:
Mon, May 7, 8:41 PM

Apr 17 2018

erj updated the summary of D5214: Convert ixl(4)to use iflib.
Apr 17 2018, 12:34 AM
erj updated the summary of D5214: Convert ixl(4)to use iflib.
Apr 17 2018, 12:33 AM
erj updated the diff for D5214: Convert ixl(4)to use iflib.

Update converted version of ixl(4) to 1.9.8-k; includes some other bugfixes and updates.

Apr 17 2018, 12:32 AM

Apr 8 2018

erj accepted D14985: ixl(4): Update to 1.9.9-k.

I've reviewed this patch-by-patch; it all looks good to me. We just need to make sure validation says it compiles and does what it's supposed to, too.

Apr 8 2018, 6:38 PM
erj added a comment to D14967: split out flag manipulation from general context manipulation in iflib.

Y'all want this committed?

Apr 8 2018, 5:35 PM

Apr 6 2018

erj accepted D14967: split out flag manipulation from general context manipulation in iflib.

I don't see the console hanging on the version of ixl-iflib where I did see them when watchdogs happened, so this appears to fix the deadlock in that situation.

Apr 6 2018, 7:02 PM
erj added a comment to D14984: Sleep rather than spin in e1000 when doing long running config operations.
In D14984#315219, @bcr wrote:

When I read the title of the review, I thought it was some kind of medical advice for sysadmins or something. ;-)
Sorry, this does not help the review, just wanted to let you know.

Apr 6 2018, 5:16 PM

Mar 19 2018

erj committed rS331224: ixgbe(4): Update shared code, add support for X552 1G, fix bug.
ixgbe(4): Update shared code, add support for X552 1G, fix bug
Mar 19 2018, 10:40 PM
erj closed D2046: Fix races during ixl SR-IOV initialization.
Mar 19 2018, 10:38 PM
erj closed D2050: ixl: Propagate link state changes to VFs.
Mar 19 2018, 10:38 PM
erj closed D13885: ixgbe(4): Update shared code, add support for X552, fix bug.

Committed in rS331224.

Mar 19 2018, 10:37 PM

Feb 14 2018

erj added a comment to D13980: Fix ixl driver performance issue.

You mentioned polling in a previous comment -- did you make changes to the kernel to enable that? I'm assuming you've also made changes to the driver as well, since we don't have polling support in the driver.

Feb 14 2018, 6:07 PM

Feb 13 2018

erj added a comment to D13980: Fix ixl driver performance issue.

As I look at this more, I don't think that last section of the patch is right. ixl_rxeof() makes that same DD bit check in the for-loop; it's supposed to have processed as many descriptors as it can by the time it hits the end of the function.

Feb 13 2018, 12:54 AM

Feb 9 2018

erj requested changes to D13980: Fix ixl driver performance issue.

Until Chris's questions get answered.

Feb 9 2018, 7:57 PM

Feb 7 2018

erj added a member for Intel Networking: jeb.
Feb 7 2018, 11:07 PM
erj awarded Dev Summit Attendee to recipient: erj.
Feb 7 2018, 11:05 PM
erj added a member for committers: jeb.
Feb 7 2018, 11:03 PM
erj accepted D13980: Fix ixl driver performance issue.

These changes look good to me, but I'm going to add a co-worker to get his opinion, too. We may want to delay committing this until we get our internal updated version of ixl(4) committed.

Feb 7 2018, 11:01 PM
erj committed rS328998: Add Jeb Cramer (jeb@) as a src committer..
Add Jeb Cramer (jeb@) as a src committer.
Feb 7 2018, 10:54 PM

Feb 6 2018

erj committed rD51408: Refresh PGP subkey expiration for erj, too..
Refresh PGP subkey expiration for erj, too.
Feb 6 2018, 10:21 PM
erj committed rD51407: Refresh PGP key..
Refresh PGP key.
Feb 6 2018, 10:20 PM

Jan 22 2018

erj committed rS328265: ixv(4): Stop setting editing ifnet flags in ixv_if_init().
ixv(4): Stop setting editing ifnet flags in ixv_if_init()
Jan 22 2018, 8:56 PM

Jan 11 2018

erj committed rS327842: e1000: Fix typos in value written to register and a comment.
e1000: Fix typos in value written to register and a comment
Jan 11 2018, 7:25 PM
erj accepted D13858: 1 << 31 redux.

The changes to the Intel ethernet drivers look fine to me.

Jan 11 2018, 5:54 PM
erj added a comment to D13766: Introduce mallocarray() in the kernel.

Is this going to be MFC'd into stable/10 and/or stable/11?

Jan 11 2018, 5:52 PM

Jan 10 2018

erj added a comment to D13833: Make use of the newly introduce mallocarray(9)..
In D13833#290191, @erj wrote:

Why didn't they provide a calloc(), to follow the malloc()/free() pattern?

(It looks like this was introduced in rS327674)

Jan 10 2018, 9:57 PM
erj accepted D13833: Make use of the newly introduce mallocarray(9)..
Jan 10 2018, 9:54 PM
erj added a comment to D13833: Make use of the newly introduce mallocarray(9)..

Why didn't they provide a calloc(), to follow the malloc()/free() pattern?

Jan 10 2018, 9:49 PM

Jan 4 2018

erj added inline comments to D13660: e1000: Add support for Ice Lake and Cannon Lake.
Jan 4 2018, 7:18 PM
erj added inline comments to D13660: e1000: Add support for Ice Lake and Cannon Lake.
Jan 4 2018, 7:12 PM

Jan 3 2018

erj abandoned D7802: ixl(4)/ixlv(4): MFC 1.4.27-k and fixes to stable/10.

@erj Do you want to abandon this review in light of your work on newer releases?

Jan 3 2018, 9:22 PM · Intel Networking

Jan 2 2018

erj added a comment to D13660: e1000: Add support for Ice Lake and Cannon Lake.

We don't have anything for the Ice Lake hardware, but the Cannon Lake stuff looks like it's good.

Jan 2 2018, 8:39 PM

Dec 21 2017

erj committed rS327051: ixgbe(4): Fix build error on i386..
ixgbe(4): Fix build error on i386.
Dec 21 2017, 12:35 AM

Dec 20 2017

erj committed rS327031: ixgbe(4): Convert driver to use iflib.
ixgbe(4): Convert driver to use iflib
Dec 20 2017, 6:35 PM
erj closed D11727: ixgbe(4): Update HEAD to use iflib.

Committed in rS327031.

Dec 20 2017, 6:30 PM

Dec 5 2017

erj committed rS326571: ifconfig(8): Display extended compliance code string for SFP transceivers.
ifconfig(8): Display extended compliance code string for SFP transceivers
Dec 5 2017, 6:42 PM
erj closed D13286: ifconfig(8): Display extended compliance code for SFP transceivers.
Dec 5 2017, 6:42 PM

Nov 28 2017

erj updated the summary of D13286: ifconfig(8): Display extended compliance code for SFP transceivers.
Nov 28 2017, 7:03 PM
erj added reviewers for D13286: ifconfig(8): Display extended compliance code for SFP transceivers: melifaro, hselasky.
Nov 28 2017, 6:39 PM
erj created D13286: ifconfig(8): Display extended compliance code for SFP transceivers.
Nov 28 2017, 6:38 PM

Oct 17 2017

erj added a comment to D5214: Convert ixl(4)to use iflib.

I'm working on this on a github branch here:

Oct 17 2017, 9:05 PM

Sep 23 2017

erj accepted D12450: ixl: Fix mbuf hash type settings..
Sep 23 2017, 6:13 PM

Aug 24 2017

erj committed rS322865: ixv(4): Add more robust mailbox API negotiation.
ixv(4): Add more robust mailbox API negotiation
Aug 24 2017, 10:56 PM
erj removed a watcher for Intel Networking: jacob.e.keller_intel.com.
Aug 24 2017, 10:48 PM
erj added a member for Intel Networking: jacob.e.keller_intel.com.
Aug 24 2017, 10:48 PM
erj requested changes to D12040: direct vlan handling in ixgbe.

I guess formally recognize the current state the patch is in.

Aug 24 2017, 10:47 PM
erj added a comment to D12101: swfw_sync DELAY -> sleep conversion.

The busy waiting would cause 10% CPU usage on my system when no cable connected to em0 (traced to em_if_update_admin_status).
This patch also fixes this. I can no longer detect any unusual CPU usage.

Getting a lot of witness output. Like a few per second or so.

Aug 24 2017, 6:08 PM · network

Aug 22 2017

erj added a comment to D12101: swfw_sync DELAY -> sleep conversion.
In D12101#251141, @erj wrote:

Can we also get a description of what this fixes, for future reference?

Two problems:

  • As we've discussed at length elsewhere, Intel drivers will busy wait for arbitrary lengths of time with a default mutex held when waiting for the firmware to release a resource.
  • There is a lot of mostly duplicated code with tiny (dubious) variations.
Aug 22 2017, 8:16 PM · network
erj added a comment to D12101: swfw_sync DELAY -> sleep conversion.

Can we also get a description of what this fixes, for future reference?

Aug 22 2017, 5:09 PM · network

Aug 11 2017

erj added a comment to D11969: refactoring in support of *future* change to cope with slow configuration path on INTC and BRCM drivers.

Can you remind me what lock is held?

Aug 11 2017, 3:58 PM

Aug 7 2017

erj added a comment to D11378: iWARP driver for Intel X722 Adapter - initial commit.

@erj are you going to commit this once you've made the IXL updates required for it to function?

Aug 7 2017, 8:33 PM

Jul 31 2017

erj committed rS321802: Add myself to calendar.freebsd.
Add myself to calendar.freebsd
Jul 31 2017, 5:58 PM

Jul 27 2017

erj added a comment to D11378: iWARP driver for Intel X722 Adapter - initial commit.

I don't think these are very significant, but I get the following warnings during a build:

/home/sbruno/bsd/fbsd_head/sys/modules/ixl/iw_ixl/../../../dev/ixl/iwarp/iw_ixl_utils.c:943:46: warning: taking address of packed member 'ip6_dst' of class or structure 'ip6_hdr' may result in an unaligned pointer value [-Waddress-of-packed-member]
                i40iw_copy_ip_ntohl(loc_addr, (__be32 *) & ip6h->ip6_dst);
                                                           ^~~~~~~~~~~~~
/home/sbruno/bsd/fbsd_head/sys/modules/ixl/iw_ixl/../../../dev/ixl/iwarp/iw_ixl_utils.c:944:46: warning: taking address of packed member 'ip6_src' of class or structure 'ip6_hdr' may result in an unaligned pointer value [-Waddress-of-packed-member]
                i40iw_copy_ip_ntohl(rem_addr, (__be32 *) & ip6h->ip6_src);
                                                           ^~~~~~~~~~~~~
/home/sbruno/bsd/fbsd_head/sys/modules/ixl/iw_ixl/../../../dev/ixl/iwarp/iw_ixl_cm.c:488:36: warning: taking address of packed member 'ip6_src' of class or structure 'ip6_hdr' may result in an unaligned pointer value [-Waddress-of-packed-member]
                i40iw_copy_ip_htonl((__be32 *) & ip6h->ip6_src,
                                                 ^~~~~~~~~~~~~
/home/sbruno/bsd/fbsd_head/sys/modules/ixl/iw_ixl/../../../dev/ixl/iwarp/iw_ixl_cm.c:490:36: warning: taking address of packed member 'ip6_dst' of class or structure 'ip6_hdr' may result in an unaligned pointer value [-Waddress-of-packed-member]
                i40iw_copy_ip_htonl((__be32 *) & ip6h->ip6_dst,
                                                 ^~~~~~~~~~~~~
/home/sbruno/bsd/fbsd_head/sys/modules/ixl/iw_ixl/../../../dev/ixl/iwarp/iw_ixl_cm.c:3046:22: warning: taking address of packed member 'ip6_dst' of class or structure 'ip6_hdr' may result in an unaligned pointer value [-Waddress-of-packed-member]
                                    (__be32 *) & ip6h->ip6_dst);
                                                 ^~~~~~~~~~~~~
/home/sbruno/bsd/fbsd_head/sys/modules/ixl/iw_ixl/../../../dev/ixl/iwarp/iw_ixl_cm.c:3048:22: warning: taking address of packed member 'ip6_src' of class or structure 'ip6_hdr' may result in an unaligned pointer value [-Waddress-of-packed-member]
                                    (__be32 *) & ip6h->ip6_src);

Indeed, I don't find it too significant. I guess this is just a performance issue, which is insignificant given the amount of times this operation is done. And what is more important, this is related to the path which would be exercised only when using ipv6. The ipv6 is currently not supported, and there are some changes to the OFED going to be needed to make it work.
I may probably get rid of these warnings if it was really needed.

Jul 27 2017, 10:04 PM
erj added a comment to D11378: iWARP driver for Intel X722 Adapter - initial commit.

@sbruno - I think Bartosz needed an update to the in-kernel ixl(4) for this to work properly.

Jul 27 2017, 10:02 PM
erj accepted D11724: Drop ixl rx lock during TCP LRO.
Jul 27 2017, 9:45 PM · Intel Networking

Jul 24 2017

erj planned changes to D5214: Convert ixl(4)to use iflib.
Jul 24 2017, 5:25 PM

Jul 13 2017

erj committed rS320972: ixl(4)/ixlv(4): Stop leaking every busdma entry in receive path.
ixl(4)/ixlv(4): Stop leaking every busdma entry in receive path
Jul 13 2017, 10:12 PM
erj accepted D10385: Remove many write-only variables from kernel.

With the answer from @sbruno, I approve of the change to em(4).

Jul 13 2017, 8:45 PM
erj requested changes to D11058: ixgbe(4): Update 11-STABLE to 3.2.12-k.

This should be abandoned, right?

Jul 13 2017, 8:43 PM
erj requested changes to D8532: ixgbe(4) Update driver API.

This probably needs to be regenerated right? Or is it going to be dropped due to the upcoming conversion to iflib?

Jul 13 2017, 8:42 PM
erj accepted D11414: ixl: gcc build errors.

There's still only one entry before the patch. But this looks more correct.

Jul 13 2017, 8:40 PM

Jul 12 2017

erj requested changes to D11414: ixl: gcc build errors.

@rlibby , after reading the linked bug report, I think it would be a good idea to go the extern route. Could you regenerate the patch and define ixl_bcast_addr and ixl_fc_string in ixl_pf_main.c? (The latter would only ever get used in the PF driver; only the PF driver uses the former). Or just commit everything but the changes to those two, and I could make those changes.

Jul 12 2017, 10:36 PM
erj added a comment to D11414: ixl: gcc build errors.

Is gcc requiring the additional const keywords?

Jul 12 2017, 6:45 PM

Jul 11 2017

erj committed rS320897: MFC r316541, r316544, and r320688 from HEAD to stable/11..
MFC r316541, r316544, and r320688 from HEAD to stable/11.
Jul 11 2017, 9:25 PM

Jul 8 2017

erj committed rS320688: ixgbe(4): Update HEAD (p3) to 3.2.12-k.
ixgbe(4): Update HEAD (p3) to 3.2.12-k
Jul 8 2017, 1:44 AM

Jul 5 2017

erj accepted D11232: ixgbe(4): Update HEAD (p3) to 3.2.12-k.
Jul 5 2017, 5:28 PM

Jun 27 2017

erj added a comment to D11378: iWARP driver for Intel X722 Adapter - initial commit.

I should add that we're going to update the ixl(4) driver soon because as @bartosz.sobczak_intel.com mentioned, it will fix a crash.

Jun 27 2017, 4:49 PM
erj added a reviewer for D11378: iWARP driver for Intel X722 Adapter - initial commit: np.
Jun 27 2017, 4:47 PM

Jun 21 2017

erj added inline comments to D10681: bnxt: Enable HW LRO and Fix out-of-order updates to rxd's completely..
Jun 21 2017, 12:28 AM

Jun 10 2017

erj committed rS319797: ixl(4)/ixlv(4): Fix some busdma tags and improper map NULL..
ixl(4)/ixlv(4): Fix some busdma tags and improper map NULL.
Jun 10 2017, 6:56 PM

May 16 2017

erj committed rS318358: MFC r318147: Add several new media types to if_media.h.
MFC r318147: Add several new media types to if_media.h
May 16 2017, 5:51 PM