erj (Eric Joyner)
Network Software Engineer @ Intel

Projects

User Details

User Since
Jan 27 2015, 7:34 PM (186 w, 7 h)

Recent Activity

Today

erj updated the diff for D16731: if_media: Add new 2.5G/5G/25G/40G/50G/100G/200G/400G media types.

Fix typo (from @hselasky)

Wed, Aug 22, 12:52 AM
erj updated the diff for D16429: ixlv(4): Update to use iflib.
  • ixlv(4): Make ixlv_if_init() and ixlv_stop() wait for ENABLE/DISABLE queue command completion
  • ixl(4): Cosmetic change to message PF sends in reply to VF promiscuous config message
Wed, Aug 22, 12:48 AM · Intel Networking

Yesterday

erj added a comment to D16731: if_media: Add new 2.5G/5G/25G/40G/50G/100G/200G/400G media types.

Can I get this patch re-reviewed before committing it?

Tue, Aug 21, 5:38 PM
erj updated the diff for D16429: ixlv(4): Update to use iflib.
  • ixl(4): Fix RX MDD event display
  • ixl/ixlv(4): Add more MPASS statements to TX path
Tue, Aug 21, 12:42 AM · Intel Networking

Mon, Aug 20

erj updated the diff for D16731: if_media: Add new 2.5G/5G/25G/40G/50G/100G/200G/400G media types.
  • if_media: Add 40Gbase-ER4 media type.
Mon, Aug 20, 6:38 PM
erj added a comment to D16731: if_media: Add new 2.5G/5G/25G/40G/50G/100G/200G/400G media types.

I see IFM_40G_ER4 is missing from the table. There is only IFM_40G_LR4 currently.

Can you add IFM_40G_ER4 as part of this patch aswell?

Mon, Aug 20, 3:54 PM

Thu, Aug 16

erj updated the diff for D16429: ixlv(4): Update to use iflib.
  • ixl(4): Enhance Malicious Driver Detection messages with VF information
  • ixl(4): Print out additional event information when a LAN Overflow Event occurs
  • ixl/ixlv(4): Add additional MPASS() asserts to the driver TX path
Thu, Aug 16, 11:45 PM · Intel Networking

Wed, Aug 15

erj created D16731: if_media: Add new 2.5G/5G/25G/40G/50G/100G/200G/400G media types.
Wed, Aug 15, 6:59 PM

Tue, Aug 14

erj updated the diff for D16429: ixlv(4): Update to use iflib.
  • ixlv(4): Change remaining M_DEVBUF malloc types to M_IXLV
  • ixlv(4): Fix a memory leak when interrupt setup fails
  • ixlv(4): Convert some malloc()'s to M_WAITOK from M_NOWAIT
  • ixlv(4): Remove comments and commented out code
  • ixlv(4): Remove list of media types displayed in "ifconfig -m"
Tue, Aug 14, 12:03 AM · Intel Networking
erj updated the diff for D16428: iflib: Changes for ixlv(4) update.
  • iflib: Free remaining interrupt resources on failure in iflib_device_register()
  • iflib: Free RX queue TCP LRO memory on unload
Tue, Aug 14, 12:02 AM · Intel Networking

Fri, Aug 10

erj updated the diff for D16429: ixlv(4): Update to use iflib.
  • ixl/ixlv(4): Fix panic when receiving jumbo frame (>4k mtu) traffic
Fri, Aug 10, 5:37 PM · Intel Networking

Thu, Aug 9

erj updated the diff for D16429: ixlv(4): Update to use iflib.
  • ixl(4): Fix compile error when PCI_IOV isn't defined
Thu, Aug 9, 10:24 PM · Intel Networking
erj updated the diff for D16429: ixlv(4): Update to use iflib.

Changes from D16428:

  • iflib: Prevent kernel panic on detach in _task_fn_admin by checking if in detach
  • iflib: Add STATE_LOCK() around flag setting in iflib_request_reset()

New changes for D16429:

  • ixl(4): Add tunable to enable VF loopback; enable by default
  • ixl/ixlv(4): Fix dev.ixl/v.#.vsi.rxq#.bytes sysctl not incrementing
Thu, Aug 9, 6:41 PM · Intel Networking
erj updated the diff for D16428: iflib: Changes for ixlv(4) update.
  • iflib: Prevent kernel panic on detach in _task_fn_admin by checking if in detach
  • iflib: Add STATE_LOCK() around flag setting in iflib_request_reset()
Thu, Aug 9, 6:39 PM · Intel Networking

Fri, Aug 3

erj updated the diff for D16429: ixlv(4): Update to use iflib.
  • ixl(4): Lie to the VF about configuring promiscuous mode if VF isn't allowed to configure it
Fri, Aug 3, 6:33 PM · Intel Networking

Thu, Aug 2

erj added a comment to D16429: ixlv(4): Update to use iflib.

@gallatin, I address your specific comments, but I would need to look through ixlvc.c some more to find more code that can be shared. There is almost certainly some in there that can be shared between the PF/VF drivers.

Thu, Aug 2, 8:48 PM · Intel Networking
erj updated the diff for D16429: ixlv(4): Update to use iflib.
  • ixl(4): Combine PF-only/VF-only ixl_disable_rings() in PF driver into one function.
  • Remove a space
Thu, Aug 2, 8:47 PM · Intel Networking
erj planned changes to D16428: iflib: Changes for ixlv(4) update.

I need to add the state lock to iflib_request_reset

Thu, Aug 2, 5:08 PM · Intel Networking

Wed, Aug 1

erj accepted D16534: e1000: Don't use 9k jumbo clusters.
Wed, Aug 1, 7:52 PM

Thu, Jul 26

erj updated the diff for D16429: ixlv(4): Update to use iflib.
  • ixl(4): Fix module Makefile when PCI_IOV is enabled
Thu, Jul 26, 9:08 PM · Intel Networking

Wed, Jul 25

erj updated the diff for D16429: ixlv(4): Update to use iflib.
  • ixlv(4): Use same TX DMA seg sizes as the ones in ixl(4)
  • ixl/ixlv(4): Preserve code removal done in r336313
Wed, Jul 25, 7:59 PM · Intel Networking
erj updated the diff for D16429: ixlv(4): Update to use iflib.
  • ixlv(4): Remove old/dead code
Wed, Jul 25, 6:02 PM · Intel Networking
erj added a reviewer for D16429: ixlv(4): Update to use iflib: gallatin.
Wed, Jul 25, 4:25 PM · Intel Networking
erj added a reviewer for D16428: iflib: Changes for ixlv(4) update: mmacy.
Wed, Jul 25, 4:25 PM · Intel Networking
erj updated the diff for D16429: ixlv(4): Update to use iflib.
  • ixlv(4): Re-add driver to GENERIC and build files
  • ixl/ixlv(4): Fix module Makefiles
Wed, Jul 25, 4:22 PM · Intel Networking

Tue, Jul 24

erj updated the summary of D16429: ixlv(4): Update to use iflib.
Tue, Jul 24, 6:38 PM · Intel Networking
erj created D16429: ixlv(4): Update to use iflib.
Tue, Jul 24, 6:37 PM · Intel Networking
erj created D16428: iflib: Changes for ixlv(4) update.
Tue, Jul 24, 6:34 PM · Intel Networking

Jul 12 2018

erj committed rS336223: ixl(4): Set baudrate on link up using proper link_speed variable.
ixl(4): Set baudrate on link up using proper link_speed variable
Jul 12 2018, 5:42 PM
erj added a comment to D15927: Update ixl(4) man page.

I'll work on adding those pointers; they're important tools for these cards.

Jul 12 2018, 5:35 PM

Jul 11 2018

erj added a comment to D15720: Assorted TSO fixes for em(4)/iflib(9) and dead code removal from em(4).

Any update? It's been almost a month.

Jul 11 2018, 4:15 PM

Jul 9 2018

erj added a comment to D16037: net/intel-ixl-kmod: Update to 1.9.13.

Is someone going to commit this? I'm getting tired of the pkg-fallout emails. 📟

Jul 9 2018, 10:54 PM

Jul 7 2018

erj added a comment to D16164: Make options IFLIB a real configuration option..

can iflib.ko be created and then the driver modules depend on that?

Jul 7 2018, 5:22 PM

Jun 27 2018

erj accepted D16037: net/intel-ixl-kmod: Update to 1.9.13.
Jun 27 2018, 8:30 PM

Jun 22 2018

erj updated the diff for D15927: Update ixl(4) man page.

Remove (bailed)s

Jun 22 2018, 7:04 PM
erj added a comment to D15927: Update ixl(4) man page.
In D15927#338138, @pi wrote:

Yes, please add sections on how to use both tools, and reference the ports (sysutils/intel-qcu and
sysutils/intel-nvmupdate).

I've looked up 'bailed' on dict.leo.org but did not find a valid translation. What are those 'bailed' devices ?

Jun 22 2018, 6:51 PM
erj added a comment to D15927: Update ixl(4) man page.

Should I add a section about the QCU and nvmupdate utilities? They have ports, but I don't think they have manpages, so I don't know how to properly reference them.

Jun 22 2018, 6:40 PM
erj updated the diff for D15927: Update ixl(4) man page.

Add acronym expansions and info on qualified module check.

Jun 22 2018, 6:38 PM
erj added a comment to D15927: Update ixl(4) man page.
In D15927#337633, @pi wrote:

Please expand LOM to 'onboard interfaces (LAN on Motherboard, LOM)', if possible. I'm a 30-years user of ethernet, but I've never heard that abbreviation.

I don't think it's that rare of an abbreviation, but I can add the expansion.

If an admin can see if an interface is external or LOM, by whatever magic, can you write about it in the man page ?

I looked into this yesterday, and there may not be a 100% accurate way to do this in the driver. I can add something and maybe identify exceptions.

Jun 22 2018, 5:15 PM

Jun 21 2018

erj added a comment to D15927: Update ixl(4) man page.
In D15927#337347, @pi wrote:

Thanks -- will that be written down somewhere in the man page ? Who is selling EXL cards, because I've never found that ? And: What is LOM ?

Jun 21 2018, 5:17 PM
erj added a comment to D15927: Update ixl(4) man page.
In D15927#337295, @pi wrote:

Can you tell if the boards now accept foreign/unsupported SFP+ modules ? Is there a flag now for this
or does it still insist to only accept intel-branded SFP+ modules ?

Jun 21 2018, 12:10 AM

Jun 20 2018

erj added a comment to D15927: Update ixl(4) man page.

Any additional information that should be added to the man page? Some stats descriptions? iflib sysctls? More VF usage information?

Jun 20 2018, 11:06 PM
erj accepted D15720: Assorted TSO fixes for em(4)/iflib(9) and dead code removal from em(4).
Jun 20 2018, 10:19 PM
erj committed rS335462: ixl(4): Fix gcc build errors.
ixl(4): Fix gcc build errors
Jun 20 2018, 10:17 PM
erj updated the summary of D15927: Update ixl(4) man page.
Jun 20 2018, 7:47 PM
erj updated the diff for D15927: Update ixl(4) man page.

Address comments.

Jun 20 2018, 6:00 PM
erj added a reviewer for D15927: Update ixl(4) man page: Intel Networking.
Jun 20 2018, 4:27 PM
erj created D15927: Update ixl(4) man page.
Jun 20 2018, 4:26 PM

Jun 19 2018

erj updated the summary of D15577: Update ixl(4) to use iflib..
Jun 19 2018, 5:47 PM
erj committed rS335358: ixl(4): Remove ixlvc.c from files.amd64.
ixl(4): Remove ixlvc.c from files.amd64
Jun 19 2018, 3:11 AM

Jun 18 2018

erj committed rS335339: ixl(4): Update version number to 2.0.0-k.
ixl(4): Update version number to 2.0.0-k
Jun 18 2018, 8:33 PM
erj committed rS335338: ixl(4): Update to use iflib.
ixl(4): Update to use iflib
Jun 18 2018, 8:13 PM
erj closed D15577: Update ixl(4) to use iflib..
Jun 18 2018, 8:13 PM
erj added a comment to D15577: Update ixl(4) to use iflib..

Any last-minute objections? This is the version that's going in!

Jun 18 2018, 6:03 PM
erj updated the diff for D15577: Update ixl(4) to use iflib..

Commit iflib style fixes separately.

Jun 18 2018, 5:46 PM
erj committed rS335322: iflib: Style fixes.
iflib: Style fixes
Jun 18 2018, 5:28 PM
erj updated the diff for D15577: Update ixl(4) to use iflib..
  • Revert "ixl(4): Increase default ITR values to 500 (1000us)"
Jun 18 2018, 4:43 PM

Jun 14 2018

erj added a comment to D15577: Update ixl(4) to use iflib..

You might want to go for some middle ground here. 1ms is a bit much (even for us).

Jun 14 2018, 6:24 PM

Jun 13 2018

erj updated the diff for D15577: Update ixl(4) to use iflib..

Based on a report by @gallatin:

Jun 13 2018, 8:50 PM

Jun 12 2018

erj updated the diff for D15577: Update ixl(4) to use iflib..

Comment out printf()'s introduced in previous commit

Jun 12 2018, 12:11 AM

Jun 11 2018

erj updated the diff for D15577: Update ixl(4) to use iflib..

Add these changes from @krzysztof.galazka_intel.com

Jun 11 2018, 10:53 PM

Jun 7 2018

erj updated the diff for D15577: Update ixl(4) to use iflib..

Update to exclude code in D15558, since that is now committed.

Jun 7 2018, 1:58 PM
erj committed rS334779: iflib: Record TCP checksum info in iflib when TCP checksum is requested.
iflib: Record TCP checksum info in iflib when TCP checksum is requested
Jun 7 2018, 1:09 PM
erj closed D15558: iflib: Record TCP checksum info in iflib for ixl(4).
Jun 7 2018, 1:09 PM · Intel Networking

Jun 4 2018

erj added a comment to D15558: iflib: Record TCP checksum info in iflib for ixl(4).

@gallatin I'm assuming you no longer have any objections to this patch?

Jun 4 2018, 5:55 PM · Intel Networking

May 26 2018

erj updated the diff for D15577: Update ixl(4) to use iflib..

Include contents of/update to D15558 again, since relying on dependent revisions
in Phabricator is a PITA.

May 26 2018, 1:43 AM
erj added a parent revision for D15577: Update ixl(4) to use iflib.: D15558: iflib: Record TCP checksum info in iflib for ixl(4).
May 26 2018, 1:20 AM
erj added a child revision for D15558: iflib: Record TCP checksum info in iflib for ixl(4): D15577: Update ixl(4) to use iflib..
May 26 2018, 1:20 AM · Intel Networking
erj updated the diff for D15577: Update ixl(4) to use iflib..

Pulled out TCP saving changes since those are in D15558

May 26 2018, 1:20 AM
erj updated the diff for D15577: Update ixl(4) to use iflib..

Update due to D15575 being committed.

May 26 2018, 1:09 AM
erj closed D15575: iflib: Add new shared flag to iflib: IFLIB_ADMIN_ALWAYS_RUN.
May 26 2018, 12:46 AM
erj committed rS334231: iflib: Add new shared flag: IFLIB_ADMIN_ALWAYS_RUN.
iflib: Add new shared flag: IFLIB_ADMIN_ALWAYS_RUN
May 26 2018, 12:46 AM

May 25 2018

erj updated the diff for D15558: iflib: Record TCP checksum info in iflib for ixl(4).
  • iflib: Move stats increment in IPv6 case to match IPv4 case
May 25 2018, 11:18 PM · Intel Networking
erj added inline comments to D15558: iflib: Record TCP checksum info in iflib for ixl(4).
May 25 2018, 11:17 PM · Intel Networking
erj updated the diff for D15558: iflib: Record TCP checksum info in iflib for ixl(4).
  • iflib: Remove comment and restore/fix setting CSUM_IP6_TCP flag during TSO6
May 25 2018, 10:52 PM · Intel Networking
erj added inline comments to D15558: iflib: Record TCP checksum info in iflib for ixl(4).
May 25 2018, 7:52 PM · Intel Networking
erj updated the diff for D15575: iflib: Add new shared flag to iflib: IFLIB_ADMIN_ALWAYS_RUN.
  • Make style fix.
May 25 2018, 7:37 PM
erj abandoned D5214: Convert ixl(4)to use iflib.

Replaced by https://reviews.freebsd.org/D15577

May 25 2018, 7:19 PM
erj updated the summary of D15577: Update ixl(4) to use iflib..
May 25 2018, 7:00 PM
erj updated the summary of D15577: Update ixl(4) to use iflib..
May 25 2018, 6:59 PM
erj updated the summary of D15577: Update ixl(4) to use iflib..
May 25 2018, 6:58 PM
erj updated the summary of D15577: Update ixl(4) to use iflib..
May 25 2018, 6:54 PM
erj updated the diff for D15577: Update ixl(4) to use iflib..

Remove testing config files and make spelling fixes.

May 25 2018, 6:52 PM
erj created D15577: Update ixl(4) to use iflib..
May 25 2018, 6:50 PM
erj set the repository for D15575: iflib: Add new shared flag to iflib: IFLIB_ADMIN_ALWAYS_RUN to rS FreeBSD src repository.
May 25 2018, 5:46 PM
erj created D15575: iflib: Add new shared flag to iflib: IFLIB_ADMIN_ALWAYS_RUN.
May 25 2018, 5:45 PM

May 24 2018

erj updated the diff for D15558: iflib: Record TCP checksum info in iflib for ixl(4).
  • iflib: Fixup changes made to record TCP checksum info in iflib for ixl
May 24 2018, 9:27 PM · Intel Networking
erj updated the summary of D15558: iflib: Record TCP checksum info in iflib for ixl(4).
May 24 2018, 6:30 PM · Intel Networking
erj added 1 blocking reviewer(s) for D15558: iflib: Record TCP checksum info in iflib for ixl(4): shurd.
May 24 2018, 6:20 PM · Intel Networking
erj created D15558: iflib: Record TCP checksum info in iflib for ixl(4).
May 24 2018, 6:16 PM · Intel Networking

May 14 2018

erj committed rS333149: ixl(4): Update to 1.9.9-k.
ixl(4): Update to 1.9.9-k
May 14 2018, 2:07 PM

May 7 2018

erj committed rS333343: MFC r333149: ixl(4): Update to 1.9.9-k.
MFC r333149: ixl(4): Update to 1.9.9-k
May 7 2018, 11:23 PM
erj committed rS333336: MFC r326571: ifconfig(8): Display extended compliance code string for SFP….
MFC r326571: ifconfig(8): Display extended compliance code string for SFP…
May 7 2018, 9:26 PM
erj committed rS333331: MFC r319797, r320972:.
MFC r319797, r320972:
May 7 2018, 8:41 PM

Apr 17 2018

erj updated the summary of D5214: Convert ixl(4)to use iflib.
Apr 17 2018, 12:34 AM
erj updated the summary of D5214: Convert ixl(4)to use iflib.
Apr 17 2018, 12:33 AM
erj updated the diff for D5214: Convert ixl(4)to use iflib.

Update converted version of ixl(4) to 1.9.8-k; includes some other bugfixes and updates.

Apr 17 2018, 12:32 AM

Apr 8 2018

erj accepted D14985: ixl(4): Update to 1.9.9-k.

I've reviewed this patch-by-patch; it all looks good to me. We just need to make sure validation says it compiles and does what it's supposed to, too.

Apr 8 2018, 6:38 PM
erj added a comment to D14967: split out flag manipulation from general context manipulation in iflib.

Y'all want this committed?

Apr 8 2018, 5:35 PM

Apr 6 2018

erj accepted D14967: split out flag manipulation from general context manipulation in iflib.

I don't see the console hanging on the version of ixl-iflib where I did see them when watchdogs happened, so this appears to fix the deadlock in that situation.

Apr 6 2018, 7:02 PM