Page MenuHomeFreeBSD

erj (Eric Joyner)
Network Software Engineer @ Intel

Projects

User Details

User Since
Jan 27 2015, 7:34 PM (380 w, 5 d)

Recent Activity

Apr 13 2022

erj updated the summary of D34894: iflib: Introduce v2 of TX Queue Select Functionality (for stable/13).
Apr 13 2022, 12:17 AM
erj requested review of D34894: iflib: Introduce v2 of TX Queue Select Functionality (for stable/13).
Apr 13 2022, 12:16 AM

Apr 12 2022

erj accepted D34828: ix: Remove cpu_id and related code from ixgbe_if_msix_intr_assign..

Digging through using git blame, it doesn't look like the cpu_id was ever even used in the first place...

Apr 12 2022, 10:42 PM
erj resigned from D21223: ixl(4): Fix issues with MTU change while passing traffic.

FreeBSD 11 is EoL.

Apr 12 2022, 8:20 PM
erj accepted D34449: Allow em(4) to particpate in auto-negotiation for fixed 100b or 10b configuration.

Is anyone else going to look at this? This does seem alright to me, though I don't know how to answer the autoneg_wait_to_complete question.

Apr 12 2022, 8:18 PM
erj edited reviewers for D34449: Allow em(4) to particpate in auto-negotiation for fixed 100b or 10b configuration, added: kbowling; removed: jfv.
Apr 12 2022, 8:17 PM
erj accepted D34829: i40e_validate_filter_settings: Remove unused variables..
Apr 12 2022, 8:15 PM

Apr 11 2022

erj requested changes to D34829: i40e_validate_filter_settings: Remove unused variables..

Checking internally, it looks like those variables can just be removed. I also don't see anything similar to the GLHMC_FCOEFMAX register in the hardware for the PE filters or contexts.

Apr 11 2022, 6:46 PM
erj added a reviewer for D34829: i40e_validate_filter_settings: Remove unused variables.: krzysztof.galazka_intel.com.
Apr 11 2022, 6:39 PM
erj added a comment to D34828: ix: Remove cpu_id and related code from ixgbe_if_msix_intr_assign..

I'm going to go with just having all of the cpu_id code be axed. I added @krzysztof.galazka_intel.com to see if he has an opinion, but I can't recall or figure out what the cpu_id code is for. I guess it could've remained from an older version of the iflib api; I vaguely remember some softirq argument change where the cpu_id was removed.

Apr 11 2022, 6:38 PM
erj added a reviewer for D34828: ix: Remove cpu_id and related code from ixgbe_if_msix_intr_assign.: krzysztof.galazka_intel.com.
Apr 11 2022, 6:36 PM

Apr 1 2022

erj added reviewers for D34742: iflib: Introduce v2 of TX Queue Select Functionality: Intel Networking, bartosz.sobczak_intel.com.
Apr 1 2022, 11:09 PM
erj requested review of D34742: iflib: Introduce v2 of TX Queue Select Functionality.
Apr 1 2022, 11:08 PM

Mar 25 2022

erj closed D34024: ice(4): Update to 1.34.2-k.
Mar 25 2022, 8:45 PM

Mar 21 2022

erj committed R9:2d15b42e818b: Add back my (erj) PGP key. (authored by erj).
Add back my (erj) PGP key.
Mar 21 2022, 9:14 PM

Mar 8 2022

erj committed R10:9eed130b298f: ix(4): Add control of 2.5/5G autonegotiation speeds (authored by piotr.pietruszewski_intel.com).
ix(4): Add control of 2.5/5G autonegotiation speeds
Mar 8 2022, 12:23 AM
erj committed R10:69793834e625: ixv(4): Allow PF to control the VF link state (authored by piotr.pietruszewski_intel.com).
ixv(4): Allow PF to control the VF link state
Mar 8 2022, 12:23 AM
erj committed R10:3abd066b6dca: powerpc: enable ice in GENERIC64LE (authored by pkubaj).
powerpc: enable ice in GENERIC64LE
Mar 8 2022, 12:22 AM
erj committed R10:c185d44f1c5f: ice_ddp: Update to 1.3.27.0 (authored by erj).
ice_ddp: Update to 1.3.27.0
Mar 8 2022, 12:22 AM
erj committed R10:a0cdf45ea1d1: ice(4): Update to 1.34.2-k (authored by erj).
ice(4): Update to 1.34.2-k
Mar 8 2022, 12:22 AM
erj committed R10:bde1cafb7c2b: iflib: Allow drivers to determine which queue to TX on (authored by erj).
iflib: Allow drivers to determine which queue to TX on
Mar 8 2022, 12:22 AM
erj committed R10:f34bf8f8a124: ixl(4): Remove unused function declaration (authored by erj).
ixl(4): Remove unused function declaration
Mar 8 2022, 12:22 AM
erj committed R10:fe95a05a07ae: iavf(4): Include RSS header file when RSS is defined (authored by erj).
iavf(4): Include RSS header file when RSS is defined
Mar 8 2022, 12:22 AM
erj committed R10:794a0fa5ad8e: ixl(4): Remove iavf(4) source files (authored by erj).
ixl(4): Remove iavf(4) source files
Mar 8 2022, 12:22 AM
erj committed R10:41423f3a62e3: iavf(4): Split source and update to 3.0.26-k (authored by erj).
iavf(4): Split source and update to 3.0.26-k
Mar 8 2022, 12:22 AM
erj committed R10:232f141b32bf: ice_ddp: Update to 1.3.24.0 (authored by erj).
ice_ddp: Update to 1.3.24.0
Mar 8 2022, 12:22 AM
erj committed R10:a00b31f69810: ice(4): Update to version 0.29.4-k (authored by erj).
ice(4): Update to version 0.29.4-k
Mar 8 2022, 12:22 AM

Mar 4 2022

erj committed R10:61d83041ab11: ice(4): Fix build error when ALTQ is enabled (authored by erj).
ice(4): Fix build error when ALTQ is enabled
Mar 4 2022, 10:14 PM
erj committed R10:d381c807510d: ix(4): Add control of 2.5/5G autonegotiation speeds (authored by piotr.pietruszewski_intel.com).
ix(4): Add control of 2.5/5G autonegotiation speeds
Mar 4 2022, 6:55 PM
erj closed D26245: ix(4): Add control of 2.5/5G autonegotiation speeds.
Mar 4 2022, 6:55 PM
erj committed R10:a3e719bbc21a: ixv(4): Allow PF to control the VF link state (authored by piotr.pietruszewski_intel.com).
ixv(4): Allow PF to control the VF link state
Mar 4 2022, 6:55 PM
erj closed D32004: ixv(4): Allow PF to control the VF link state.
Mar 4 2022, 6:54 PM
erj committed R10:56429daea255: ice(4): Update to 1.34.2-k (authored by erj).
ice(4): Update to 1.34.2-k
Mar 4 2022, 6:54 PM

Feb 4 2022

erj accepted D34152: style(9): Default to omitting $FreeBSD$.
Feb 4 2022, 5:27 PM

Feb 3 2022

erj accepted D34152: style(9): Default to omitting $FreeBSD$.
Feb 3 2022, 11:19 PM

Jan 26 2022

erj added inline comments to D34024: ice(4): Update to 1.34.2-k.
Jan 26 2022, 12:36 AM
erj updated the summary of D34024: ice(4): Update to 1.34.2-k.
Jan 26 2022, 12:26 AM
erj added inline comments to D34024: ice(4): Update to 1.34.2-k.
Jan 26 2022, 12:26 AM

Jan 25 2022

erj added inline comments to D30889: ice(4): Add RDMA Client Interface.
Jan 25 2022, 3:26 AM
erj updated the summary of D30889: ice(4): Add RDMA Client Interface.
Jan 25 2022, 3:24 AM
erj updated the diff for D30889: ice(4): Add RDMA Client Interface.

Update with latest driver version's interface; now based on 1.34.2-k.

Jan 25 2022, 3:24 AM
erj updated the diff for D34024: ice(4): Update to 1.34.2-k.

Fix spelling mistake caught by lint

Jan 25 2022, 3:16 AM
erj updated the summary of D34024: ice(4): Update to 1.34.2-k.
Jan 25 2022, 3:13 AM
erj added reviewers for D34024: ice(4): Update to 1.34.2-k: Intel Networking, stallamr_netapp.com.
Jan 25 2022, 3:10 AM
erj requested review of D34024: ice(4): Update to 1.34.2-k.
Jan 25 2022, 3:09 AM
erj committed R10:e438f0a97538: ice_ddp: Update to 1.3.27.0 (authored by erj).
ice_ddp: Update to 1.3.27.0
Jan 25 2022, 2:29 AM
erj committed R10:213e91399b79: iflib: Allow drivers to determine which queue to TX on (authored by erj).
iflib: Allow drivers to determine which queue to TX on
Jan 25 2022, 2:25 AM
erj closed D31485: iflib: Allow drivers to determine which queue to TX on.
Jan 25 2022, 2:25 AM
erj updated the diff for D31485: iflib: Allow drivers to determine which queue to TX on.

Rebase on latest main; change version number to latest

Jan 25 2022, 1:43 AM

Jan 24 2022

erj added a comment to D31485: iflib: Allow drivers to determine which queue to TX on.

If no one has any objections, then I'll update this patch with a new FreeBSD version number, upload that here, and commit it. Then, I can submit a follow-on ice(4) update that uses it.

Jan 24 2022, 7:39 PM

Jan 20 2022

erj accepted D33974: powerpc: enable ice in GENERIC64LE.

Yeah, I don't think there's any hardware limitation that would prevent powerpc from working. We just can't test it or ensure that it works on those systems.

Jan 20 2022, 9:52 PM

Jan 14 2022

erj added a comment to D31485: iflib: Allow drivers to determine which queue to TX on.

We're back, and I think I want to get this committed soon because we're about ready to start adding reviews for the ice(4) update that uses this, as well as upstreaming the FreeBSD RDMA driver. Maybe I'll have to worry about the DSCP changes after this patch.

Jan 14 2022, 6:20 PM

Jan 13 2022

erj committed R10:0e8181c01237: ixl(4): Remove unused function declaration (authored by erj).
ixl(4): Remove unused function declaration
Jan 13 2022, 12:10 AM

Dec 17 2021

erj added a comment to D31485: iflib: Allow drivers to determine which queue to TX on.

Everyone here (at work) is mostly going to be on vacation for the next couple weeks, so we probably won't do much with this patch until people (and me) come back.

Dec 17 2021, 7:12 PM
erj added inline comments to D31485: iflib: Allow drivers to determine which queue to TX on.
Dec 17 2021, 1:36 AM

Dec 14 2021

erj added a comment to D31485: iflib: Allow drivers to determine which queue to TX on.

Either seems reasonable to me. I would bias toward including the if_pkt_info since it has fields for offload handling but I don't know much about other expected use cases, maybe @jhb has some thoughts from crypto and tcp offloads.

Dec 14 2021, 11:53 PM
erj added a reviewer for D31485: iflib: Allow drivers to determine which queue to TX on: Intel Networking.
Dec 14 2021, 5:48 PM

Dec 11 2021

erj updated the test plan for D31485: iflib: Allow drivers to determine which queue to TX on.
Dec 11 2021, 12:33 AM
erj updated the diff for D31485: iflib: Allow drivers to determine which queue to TX on.

Bump __FreeBSD_version and define IFLIB_FEATURE_QUEUE_SELECT to that new version

Dec 11 2021, 12:22 AM

Dec 10 2021

erj added a comment to D31485: iflib: Allow drivers to determine which queue to TX on.

Though, part of the problem with this patch is that I'm not entirely sure with what I want the parameters of ift_txq_select to be.

Dec 10 2021, 7:51 PM
erj added inline comments to D31485: iflib: Allow drivers to determine which queue to TX on.
Dec 10 2021, 7:45 PM

Dec 9 2021

erj added inline comments to D33156: iflib: fix vlan offload processing across multiple drivers..
Dec 9 2021, 9:12 PM

Dec 7 2021

erj added reviewers for D31485: iflib: Allow drivers to determine which queue to TX on: gallatin, kbowling, stallamr_netapp.com.
Dec 7 2021, 5:07 PM

Dec 3 2021

erj published D31485: iflib: Allow drivers to determine which queue to TX on for review.
Dec 3 2021, 10:51 PM
erj committed R10:5577aa338a67: iavf(4): Include RSS header file when RSS is defined (authored by erj).
iavf(4): Include RSS header file when RSS is defined
Dec 3 2021, 8:06 PM

Dec 2 2021

erj requested changes to D33156: iflib: fix vlan offload processing across multiple drivers..
Dec 2 2021, 10:35 PM

Dec 1 2021

erj accepted D33155: em: skip rxcsum offload processing when disabled.
Dec 1 2021, 5:29 PM
erj accepted D33157: e1000: remove unused ifp backpointer.
Dec 1 2021, 5:27 PM

Nov 24 2021

erj added a comment to R10:409b36ad911d: ixl(4): Remove iavf(4) source files.

This has not been a great week for me in terms of writing correct commit messages. -_-

Nov 24 2021, 7:58 PM
erj committed R10:409b36ad911d: ixl(4): Remove iavf(4) source files (authored by erj).
ixl(4): Remove iavf(4) source files
Nov 24 2021, 7:55 PM
erj committed R10:ca853dee3b8f: iavf(4): Split source and update to 3.0.26-k (authored by erj).
iavf(4): Split source and update to 3.0.26-k
Nov 24 2021, 7:55 PM
erj closed D28638: ixl(4): Remove iavf(4) source files.
Nov 24 2021, 7:55 PM
erj closed D28636: iavf(4): Split source and update to 3.0.26-k.
Nov 24 2021, 7:55 PM

Nov 23 2021

erj updated the diff for D28638: ixl(4): Remove iavf(4) source files.

Rebase on main

Nov 23 2021, 10:49 PM
erj updated the diff for D28637: iavf: Add Doxyfile.

Rebase on main

Nov 23 2021, 10:49 PM
erj updated the diff for D28636: iavf(4): Split source and update to 3.0.26-k.

Rebase on main

Nov 23 2021, 10:49 PM
erj closed D30888: ice(4): Update to version 0.29.4-k.

I forgot to add the "Differential Revision" line to the commit R10:9cf1841c4aaf8fbab06132ab9f76094f34ad7c7b, so I'll manually close it.

Nov 23 2021, 10:17 PM
erj committed R10:9cf1841c4aaf: ice(4): Update to version 0.29.4-k (authored by erj).
ice(4): Update to version 0.29.4-k
Nov 23 2021, 10:15 PM
erj accepted D30888: ice(4): Update to version 0.29.4-k.
Nov 23 2021, 10:14 PM
erj updated the diff for D30888: ice(4): Update to version 0.29.4-k.
  • Rebase on main, add fix for a possible kernel panic on unload
Nov 23 2021, 10:13 PM

Nov 5 2021

erj updated the diff for D19647: ifconfig: Add option to report VF status info.

Fix merge conflicts

Nov 5 2021, 6:26 PM

Oct 13 2021

erj updated the diff for D28638: ixl(4): Remove iavf(4) source files.

Rebase on main

Oct 13 2021, 7:42 PM
erj updated the diff for D28637: iavf: Add Doxyfile.

Rebase on main

Oct 13 2021, 7:42 PM
erj updated the diff for D28636: iavf(4): Split source and update to 3.0.26-k.
  • Rebase on main
  • Fix compile errors
Oct 13 2021, 7:42 PM

Sep 23 2021

erj updated the diff for D28638: ixl(4): Remove iavf(4) source files.

Rebase on main

Sep 23 2021, 12:46 AM
erj updated the diff for D28637: iavf: Add Doxyfile.

Rebase on main

Sep 23 2021, 12:46 AM
erj updated the diff for D28636: iavf(4): Split source and update to 3.0.26-k.

Fix spelling mistake

Sep 23 2021, 12:45 AM
erj updated the diff for D28636: iavf(4): Split source and update to 3.0.26-k.

Make RXTX change and update commit message.

Sep 23 2021, 12:44 AM
erj retitled D28636: iavf(4): Split source and update to 3.0.26-k from iavf: Split source and update to 3.0.26 to iavf(4): Split source and update to 3.0.26-k.
Sep 23 2021, 12:42 AM

Sep 20 2021

erj committed R10:6310681f67ef: ixl(4): Fix reporting of unqualified transceivers (authored by krzysztof.galazka_intel.com).
ixl(4): Fix reporting of unqualified transceivers
Sep 20 2021, 11:26 PM
erj committed R10:bc2fa5ace223: ixl(4): Fix 2.5 and 5G speeds reporting and update shared code (authored by krzysztof.galazka_intel.com).
ixl(4): Fix 2.5 and 5G speeds reporting and update shared code
Sep 20 2021, 11:26 PM
erj committed R10:a89887d57b96: ixl(4): Add tunable to override Flow Control settings (authored by krzysztof.galazka_intel.com).
ixl(4): Add tunable to override Flow Control settings
Sep 20 2021, 11:26 PM
erj committed R10:5d38d78f3550: ice(4): Update to version 0.28.1-k (authored by erj).
ice(4): Update to version 0.28.1-k
Sep 20 2021, 11:25 PM
erj committed R10:52323cdab724: ice_ddp: Update package file to 1.3.19.0 (authored by erj).
ice_ddp: Update package file to 1.3.19.0
Sep 20 2021, 11:25 PM
erj committed R10:5574b12aac2b: ix(4): Report RX errors as sum of all RX error counters (authored by piotr.pietruszewski_intel.com).
ix(4): Report RX errors as sum of all RX error counters
Sep 20 2021, 11:25 PM
erj committed R10:9fb4d2769549: ixl(4): Report RX errors as sum of all RX error counters (authored by krzysztof.galazka_intel.com).
ixl(4): Report RX errors as sum of all RX error counters
Sep 20 2021, 11:24 PM
erj committed R10:643f587c95dd: ixl(4): Add ability to control link state on ifconfig down (authored by krzysztof.galazka_intel.com).
ixl(4): Add ability to control link state on ifconfig down
Sep 20 2021, 11:24 PM
erj committed R10:3917b3c7e5e1: ixl(4): Fix 2.5 and 5G speeds reporting and update shared code (authored by krzysztof.galazka_intel.com).
ixl(4): Fix 2.5 and 5G speeds reporting and update shared code
Sep 20 2021, 8:53 PM
erj committed R10:6f6013102be0: ixl(4): Fix reporting of unqualified transceivers (authored by krzysztof.galazka_intel.com).
ixl(4): Fix reporting of unqualified transceivers
Sep 20 2021, 8:52 PM
erj committed R10:6583e845436e: ixl(4): Add tunable to override Flow Control settings (authored by krzysztof.galazka_intel.com).
ixl(4): Add tunable to override Flow Control settings
Sep 20 2021, 8:52 PM