User Details
- User Since
- Jan 27 2015, 7:34 PM (495 w, 3 d)
Thu, Jul 11
I don't know if we'll see any other comments from anyone else on this, so I'll probably go and commit this sometime in the next couple days.
Wed, Jul 10
Jun 7 2024
It would be nice if someone added a comment about what the operations in irdma_ctrl.c are doing, but I think I understand them and the replacements look ok to me.
Jun 4 2024
It looks like it matches the cleanup that happens in the other return paths to me
May 21 2024
The updates look good to me.
May 20 2024
Content-wise, it looks good to me now.
Similar to the iavf(4) update here: https://reviews.freebsd.org/D43093, the documentation team here has generated a new man page for ice(4), but I haven't converted it to the FreeBSD upstream format, yet. I'm fine with this version with some fixes, but if you give me a couple days I can convert it and submit it here for review.
Apr 24 2024
Apr 18 2024
Committed in 015f8cc5b0c10336a048f37a7071ea03516de242.
Apr 12 2024
Feb 23 2024
Feb 21 2024
@gallatin Do you see the Stack tab?
Committed in rG5b5f7d0e77a9eee73eb5d596f43aef4e1a3674d8.
Update value used for IFLIB_FEATURE_SUB_INTERFACES
Rebase on latest main; remove whitespace error
Rebase on latest main
Feb 16 2024
Feb 7 2024
@bartosz.sobczak_intel.com Could you re-upload this patch with all of the diff context?
Feb 6 2024
Dec 19 2023
Dec 8 2023
Nov 30 2023
Nov 29 2023
Sep 28 2023
Sep 22 2023
Sep 13 2023
Committed in rG9c30461dd25bac49045acbeac10e00b6cc13d2bc.
I was preparing to push this yesterday, but I forgot to do the last step; I think @anzhu_netapp.com has a good point here because it'll reduce the number of VIMAGE blocks, but I probably would still push it and would just wait for a fix later.
Sep 12 2023
Aug 31 2023
Aug 24 2023
Aug 23 2023
Aug 22 2023
Aug 18 2023
I'll add an MFC period of 1 month as a reminder to check in about merging this update back to stable/13.
Aug 16 2023
I'm going to agree with @kbowling here -- it looks like it's a driver bug / reasonable to fail if the driver sets IFCAP_TXCSUM without setting the CSUM_* bits that it supports for transmit checksumming.
I wish this was uploaded with context, but I'm not an expert on RDMA so I'm not sure it would let me review this code better.
Aug 14 2023
Aug 11 2023
Aug 10 2023
Any new thoughts on this review or the previous one in the stack? I'd like to get these in for 14.0-RELEASE.
Aug 7 2023
Update variable names and sysctl help string