Page MenuHomeFreeBSD

erj (Eric Joyner)
Network Software Engineer @ Intel

Projects

User Details

User Since
Jan 27 2015, 7:34 PM (220 w, 1 d)

Recent Activity

Today

erj added a reviewer for D19949: MFC important iflib changes to stable/11: Intel Networking.
Thu, Apr 18, 1:33 AM
erj created D19949: MFC important iflib changes to stable/11.
Thu, Apr 18, 1:32 AM
erj abandoned D19947: MFC r344817: Remove references to CONTIGMALLOC_WORKS in iflib and em.
Thu, Apr 18, 1:19 AM

Yesterday

erj updated the diff for D19947: MFC r344817: Remove references to CONTIGMALLOC_WORKS in iflib and em.

Attempt to fix paths for stable/11.

Wed, Apr 17, 11:36 PM
erj created D19947: MFC r344817: Remove references to CONTIGMALLOC_WORKS in iflib and em.
Wed, Apr 17, 11:34 PM
erj committed rS346338: MFC r345312.
MFC r345312
Wed, Apr 17, 11:09 PM
erj committed rS346337: MFC r345303, r345305, r345657, r345658.
MFC r345303, r345305, r345657, r345658
Wed, Apr 17, 11:02 PM
erj committed rS346336: MFC r344817.
MFC r344817
Wed, Apr 17, 10:45 PM
erj committed rS346335: MFC r344643 and r345306.
MFC r344643 and r345306
Wed, Apr 17, 10:41 PM

Tue, Apr 16

erj updated the diff for D19647: ifconfig: Add option to report VF status info.
  • Replace a space after #define with tab
Tue, Apr 16, 12:40 AM

Thu, Apr 11

erj updated the diff for D19647: ifconfig: Add option to report VF status info.
  • ifconfig: Add option to report VF status info
  • ixl: Add a license to ifvfstatus.c
  • ixl: Updates to if_ixl.c
  • Add spare data fields to struct ifvfstatus
Thu, Apr 11, 6:38 PM
erj added inline comments to D19647: ifconfig: Add option to report VF status info.
Thu, Apr 11, 6:18 PM

Thu, Mar 28

erj closed D19652: iflib: return ENETDOWN when the network device is down.
Thu, Mar 28, 8:47 PM
erj committed rS345658: iflib: return ENETDOWN when the network device is down.
iflib: return ENETDOWN when the network device is down
Thu, Mar 28, 8:47 PM
erj committed rS345657: iflib: hold the CTX lock in iflib_pseudo_register.
iflib: hold the CTX lock in iflib_pseudo_register
Thu, Mar 28, 8:44 PM
erj closed D19604: iflib: hold the CTX lock in iflib_pseudo_register.
Thu, Mar 28, 8:44 PM

Tue, Mar 19

erj committed rS345312: iflib: mark isc_driver_version as constant.
iflib: mark isc_driver_version as constant
Tue, Mar 19, 11:44 PM
erj closed D19577: iflib: mark isc_driver_version as constant.
Tue, Mar 19, 11:44 PM
erj accepted D19577: iflib: mark isc_driver_version as constant.
Tue, Mar 19, 11:24 PM
erj created D19647: ifconfig: Add option to report VF status info.
Tue, Mar 19, 6:25 PM
erj planned changes to D19647: ifconfig: Add option to report VF status info.
Tue, Mar 19, 6:25 PM
erj accepted D19604: iflib: hold the CTX lock in iflib_pseudo_register.

Anyone else have any feedback? It makes sense to me that the attach process for pseudo devices should use the context lock like the attach process for regular devices.

Tue, Mar 19, 6:09 PM
erj closed D19402: ixv(4): Add missing IFLIB_IS_VF flag in iflib shared ctx.
Tue, Mar 19, 6:07 PM
erj committed rS345306: ixv(4): Add missing IFLIB_IS_VF flag in iflib shared ctx.
ixv(4): Add missing IFLIB_IS_VF flag in iflib shared ctx
Tue, Mar 19, 6:07 PM
erj accepted D19402: ixv(4): Add missing IFLIB_IS_VF flag in iflib shared ctx.
Tue, Mar 19, 6:03 PM
erj resigned from D16875: Possible fix for "desc avail = " dmesg spam and igb breakage.

Should this revision get closed? Nothing's happened on it for months.

Tue, Mar 19, 6:01 PM
erj committed rS345305: iflib: expose the Rx mbuf buffer size to drivers.
iflib: expose the Rx mbuf buffer size to drivers
Tue, Mar 19, 6:00 PM
erj closed D19489: iflib: expose the Rx mbuf buffer size to drivers.
Tue, Mar 19, 6:00 PM
erj accepted D19489: iflib: expose the Rx mbuf buffer size to drivers.
Tue, Mar 19, 5:52 PM
erj closed D19468: iflib: prevent possible infinite loop in iflib_encap.
Tue, Mar 19, 5:49 PM
erj committed rS345303: iflib: prevent possible infinite loop in iflib_encap.
iflib: prevent possible infinite loop in iflib_encap
Tue, Mar 19, 5:49 PM
erj added inline comments to D19645: add pfil hooks to iflib.
Tue, Mar 19, 5:03 PM

Mar 14 2019

erj added a member for iflib: erj.
Mar 14 2019, 4:49 PM

Mar 13 2019

erj accepted D19577: iflib: mark isc_driver_version as constant.
Mar 13 2019, 11:40 PM
erj added inline comments to D19489: iflib: expose the Rx mbuf buffer size to drivers.
Mar 13 2019, 6:46 PM

Mar 7 2019

erj added inline comments to D19489: iflib: expose the Rx mbuf buffer size to drivers.
Mar 7 2019, 8:34 PM
erj accepted D19279: ix(4): Fix SRIOV initialization.
Mar 7 2019, 6:38 PM

Mar 5 2019

erj committed rS344817: Remove references to CONTIGMALLOC_WORKS in iflib and em.
Remove references to CONTIGMALLOC_WORKS in iflib and em
Mar 5 2019, 7:13 PM
erj closed D19199: remove references to CONTIGMALLOC_WORKS in iflib.
Mar 5 2019, 7:12 PM

Mar 2 2019

erj added a comment to D19279: ix(4): Fix SRIOV initialization.

Does this match what the Linux PF driver does?

Mar 2 2019, 12:38 AM
erj accepted D19402: ixv(4): Add missing IFLIB_IS_VF flag in iflib shared ctx.
Mar 2 2019, 12:37 AM

Feb 27 2019

erj committed rS344643: ixgbe(4): Fix panic triggered by assertion from interrupt.
ixgbe(4): Fix panic triggered by assertion from interrupt
Feb 27 2019, 10:26 PM

Feb 21 2019

erj accepted D19175: ix: Fix accessing wrong register.
Feb 21 2019, 7:09 PM
erj accepted D19176: ix, ixv: Update link status with autonegotiated baudrate value.
Feb 21 2019, 7:09 PM

Feb 15 2019

erj committed rS344163: MFC r344132:.
MFC r344132:
Feb 15 2019, 7:13 PM

Feb 14 2019

erj committed rS344132: ixl: Fix panic caused by bug exposed by r344062.
ixl: Fix panic caused by bug exposed by r344062
Feb 14 2019, 6:02 PM

Feb 7 2019

erj added a comment to D18469: ix: Fix accessing wrong register, improve WoL support recognition ix, ixv: Update link status with autonegotiated baudrate value.

@piotr.pietruszewski_intel.com Are we going to abandon this for now?

Feb 7 2019, 8:18 PM
erj accepted D19070: Fix em(4) tx interrupt routing.
Feb 7 2019, 8:17 PM
erj added inline comments to D19108: Assorted fixes and cleanup for em(4).
Feb 7 2019, 8:05 PM

Jan 31 2019

erj committed rS343622: ix(4),ixv(4): Fix TSO offloads when TXCSUM is disabled.
ix(4),ixv(4): Fix TSO offloads when TXCSUM is disabled
Jan 31 2019, 9:53 PM
erj closed D18470: ix(4),ixv(4): Fix TSO offloads when TXCSUM is disabled.
Jan 31 2019, 9:53 PM
erj committed rS343621: ix(4): Run {mod,msf,mbx,fdir,phy}_task in if_update_admin_status.
ix(4): Run {mod,msf,mbx,fdir,phy}_task in if_update_admin_status
Jan 31 2019, 9:44 PM
erj closed D18468: ix(4): Run {mod,msf,mbx,fdir,phy}_task in if_update_admin_status.
Jan 31 2019, 9:44 PM
erj accepted D19041: Make iflib a loadable module..

Well, I would just have went with "PCI" but if you prefer to state all variants :)

Jan 31 2019, 7:03 PM
erj accepted D18470: ix(4),ixv(4): Fix TSO offloads when TXCSUM is disabled.
Jan 31 2019, 5:42 PM
erj added a comment to D19041: Make iflib a loadable module..

Would it be a good idea to group the iflib drivers together in the config files, so it's obvious there?

Jan 31 2019, 12:09 AM

Jan 29 2019

erj added a comment to D18402: netmap: ixgbe: add support for jumbo frames.

You're right. I realized that just now.

I guess I could try to modify iflib_netmap_txsync and iflib_netmap_rxsync.
This patch could still be useful for FreeBSD 11, where ixgbe does not use iflib (as far as I see from the code).

Jan 29 2019, 6:29 PM
erj accepted D18984: ixl: remove unnecessary limitations related to netmap.

Having an invalid value for the head writeback value is problematic...I'll check out the PR.

Jan 29 2019, 5:52 PM
erj added a comment to D18470: ix(4),ixv(4): Fix TSO offloads when TXCSUM is disabled.

@jeffrey.e.pieper_intel.com you should re-test this, now that Piotr has updated the patch.

Jan 29 2019, 5:47 PM
erj added a comment to D18980: Stop iflib(4) from leaking MSI messages and along with drivers let it use the correct RIDs when releasing resources.

Ensure that iflib(4) and associated drivers pass correct RIDs to bus_release_resource(9) by obtaining the RIDs via rman_get_rid(9) on the corresponding resources instead of using the RIDs initially passed to bus_alloc_resource_any(9) as the latter function may change those RIDs. Solely bnxt(4) was using the correct RIDs by caching the ones returned by bus_alloc_resource_any(9).

Jan 29 2019, 5:43 PM

Jan 24 2019

erj committed rS343372: ixl(4): Fix handling data passed with ioctl from NVM update tool.
ixl(4): Fix handling data passed with ioctl from NVM update tool
Jan 24 2019, 1:09 AM
erj closed D18817: ixl(4): Fix handling data passed with ioctl from NVM update tool.
Jan 24 2019, 1:09 AM
erj committed rS343369: intel iflib drivers: correct initialization of tx_cidx_processed.
intel iflib drivers: correct initialization of tx_cidx_processed
Jan 24 2019, 1:03 AM
erj closed D18545: intel: correct initialization of tx_cidx_processed.
Jan 24 2019, 1:03 AM
erj added inline comments to D18545: intel: correct initialization of tx_cidx_processed.
Jan 24 2019, 12:41 AM

Jan 18 2019

erj resigned from D13980: Fix ixl driver performance issue.
Jan 18 2019, 7:08 PM
erj added a comment to D18545: intel: correct initialization of tx_cidx_processed.

Should I be the one to commit this, then?

Jan 18 2019, 7:08 PM

Jan 11 2019

erj added a comment to D18817: ixl(4): Fix handling data passed with ioctl from NVM update tool.

Does anyone on this review know why this is necessary on 12.0+? I think we were supposed to be doing this in the first place, but I don't know why this stopped working.

Jan 11 2019, 6:49 PM

Dec 12 2018

erj added a comment to D18470: ix(4),ixv(4): Fix TSO offloads when TXCSUM is disabled.

The description should mention that this also affects/fixes ixv(4), too.

Dec 12 2018, 1:36 AM

Dec 6 2018

erj committed rS341636: MFC r340010.
MFC r340010
Dec 6 2018, 3:28 PM

Nov 8 2018

erj committed rS340263: MFC r340256: ixl/iavf(4): Fix TSO offloads when TXCSUM is disabled.
MFC r340256: ixl/iavf(4): Fix TSO offloads when TXCSUM is disabled
Nov 8 2018, 9:37 PM
erj committed rS340256: ixl/iavf(4): Fix TSO offloads when TXCSUM is disabled.
ixl/iavf(4): Fix TSO offloads when TXCSUM is disabled
Nov 8 2018, 7:10 PM
erj closed D17900: ixl/iavf: fix TSO offloads when TXCSUM is disabled.
Nov 8 2018, 7:10 PM
erj accepted D17900: ixl/iavf: fix TSO offloads when TXCSUM is disabled.

I'll commit this for Jake and try to get it into 12-RELEASE

Nov 8 2018, 6:53 PM

Nov 7 2018

erj added a comment to D17881: Fix rxcsum issue introduced in r338838.

@krzysztof.galazka_intel.com I think @shurd's version here is better in that it masks isc_capabilities before togging RXCSUM/RXCSUM_IPV6. Though I think if you had added that, they might be roughly similar.

Nov 7 2018, 10:16 PM

Nov 1 2018

erj committed rS340010: ixl/iavf(4): Update remaining references of "num_queues" to "num_rx_queues".
ixl/iavf(4): Update remaining references of "num_queues" to "num_rx_queues"
Nov 1 2018, 5:29 PM

Oct 23 2018

erj committed rS339662: Revert r339634..
Revert r339634.
Oct 23 2018, 5:06 PM
erj committed rS339634: iflib: drain enqueued tasks before detaching from taskqgroup.
iflib: drain enqueued tasks before detaching from taskqgroup
Oct 23 2018, 4:37 AM
erj closed D17404: iflib: drain enqueued tasks before detaching from taskqgroup.
Oct 23 2018, 4:37 AM

Oct 19 2018

erj accepted D17404: iflib: drain enqueued tasks before detaching from taskqgroup.

Looks like it does what it's supposed to.

Oct 19 2018, 4:50 PM

Oct 16 2018

erj added a comment to D17404: iflib: drain enqueued tasks before detaching from taskqgroup.

iflib_admin_intr_deferred() called with STATE_LOCK() in a few places.

I've moved STATE_UNLOCK before iflib_admin_intr_defereed call although releasing lock just to immediately grab it again makes me a bit uneasy. Maybe it would be better idea to use mtx_owned in iflib_in_detach to check if this lock is already aquired?

Oct 16 2018, 8:14 PM

Oct 15 2018

erj committed rS339362: iavf(4): Finish rename/rebrand internally.
iavf(4): Finish rename/rebrand internally
Oct 15 2018, 5:24 PM
erj closed D17544: iavf: Finish the rename/rebrand internally.
Oct 15 2018, 5:23 PM
erj added a comment to D17544: iavf: Finish the rename/rebrand internally.

Err, "arc patch" doesn't apply this cleanly to my svn tree -- it complains that it can't find the new files if_iavf.c, iavf_vc.c, and iavf.h to patch.

Oct 15 2018, 4:40 PM
erj added a comment to D17544: iavf: Finish the rename/rebrand internally.

@erj do you want to ask RE permission to commit this?

Oct 15 2018, 4:34 PM
erj accepted D17544: iavf: Finish the rename/rebrand internally.
Oct 15 2018, 4:29 PM

Oct 14 2018

erj committed rS339354: em/igb/ix(4): Port two Tx/Rx fixes made to ixl in r339338.
em/igb/ix(4): Port two Tx/Rx fixes made to ixl in r339338
Oct 14 2018, 5:09 AM

Oct 13 2018

erj accepted D17544: iavf: Finish the rename/rebrand internally.

My only nitpick is that ixlvc.c should probably be renamed to iavf_vc.c instead; it's supposed to contain the functions that communicate via the PF<->VF virtchannel.

Oct 13 2018, 7:58 PM

Oct 12 2018

erj abandoned D16428: iflib: Changes for ixlv(4) update.
Oct 12 2018, 10:59 PM · Intel Networking
erj committed rS339340: ixl/iavf: Update ixl(4) and iavf(4) [previously ixlv] man pages.
ixl/iavf: Update ixl(4) and iavf(4) [previously ixlv] man pages
Oct 12 2018, 10:58 PM
erj closed D15927: Update ixl(4) and ixlv(4) man pages.
Oct 12 2018, 10:58 PM
erj committed rS339338: ixl/iavf(4): Change ixlv to iavf and update it to use iflib(9).
ixl/iavf(4): Change ixlv to iavf and update it to use iflib(9)
Oct 12 2018, 10:41 PM
erj closed D16429: ixlv(4): Update to use iflib; change name to iavf(4).
Oct 12 2018, 10:41 PM · Intel Networking
erj removed a parent revision for D16429: ixlv(4): Update to use iflib; change name to iavf(4): D16428: iflib: Changes for ixlv(4) update.
Oct 12 2018, 5:28 PM · Intel Networking
erj removed a child revision for D16428: iflib: Changes for ixlv(4) update: D16429: ixlv(4): Update to use iflib; change name to iavf(4).
Oct 12 2018, 5:28 PM · Intel Networking

Oct 11 2018

erj added a comment to D16429: ixlv(4): Update to use iflib; change name to iavf(4).

Any last-minute assents or objections?

Oct 11 2018, 11:04 PM · Intel Networking
erj added a comment to D15927: Update ixl(4) and ixlv(4) man pages.

I'm going to try to get these committed, soon; I don't have any more planned changes.

Oct 11 2018, 10:40 PM

Oct 9 2018

erj added a comment to D17404: iflib: drain enqueued tasks before detaching from taskqgroup.

@krzysztof.galazka_intel.com , you need to re-upload this patch

Oct 9 2018, 6:20 PM

Oct 8 2018

erj added inline comments to D17443: net/intel-ix-kmod: New port for 10g Intel Ethernet Base Driver.
Oct 8 2018, 8:28 PM · Intel Networking
erj added a comment to D17473: fix PNP entries for if_ix and if_ixv.

I can't tell if this is right or not, but it looks like an ok change to me.

Oct 8 2018, 4:42 PM