Page MenuHomeFreeBSD

erj (Eric Joyner)
Network Software Engineer @ Intel

Projects

User Details

User Since
Jan 27 2015, 7:34 PM (264 w, 2 d)

Recent Activity

Wed, Feb 12

erj added a comment to D23630: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N).

Is there a reason that these syctls would need "CTLFLAG_NEEDSGIANT", or does this patch default to that flag because it's a safe default if the contents of the sysctl are unknown? I'm aware of the previous review that added these flags, but I didn't get to look at it too closely.

Wed, Feb 12, 2:18 AM

Jan 13 2020

erj added inline comments to D19433: [new driver] tn40xx(4): Tehuti networks tn40xx device driver..
Jan 13 2020, 7:23 PM

Jan 10 2020

erj committed rS356606: MFC r356309: ixl: prevent non-privileged access to NVM update interface.
MFC r356309: ixl: prevent non-privileged access to NVM update interface
Jan 10 2020, 6:32 PM
erj committed rS356605: MFC r356310: iflib: Prevent watchdog from resetting idle queues.
MFC r356310: iflib: Prevent watchdog from resetting idle queues
Jan 10 2020, 6:29 PM

Jan 3 2020

erj requested changes to D22214: factor out remove logic from if_delgroup and if_delgroups.

Can this get regenerated? It no longer applies cleanly.

Jan 3 2020, 5:53 PM
erj added a comment to D22245: route: remove extra reference on ifa in rtinit1..

It looks like this change was part of the recently committed D22912 / rS356107

Jan 3 2020, 5:46 PM

Jan 2 2020

erj closed D21712: iflib: Prevent watchdog from resetting idle queues.
Jan 2 2020, 11:35 PM
erj committed rS356310: iflib: Prevent watchdog from resetting idle queues.
iflib: Prevent watchdog from resetting idle queues
Jan 2 2020, 11:35 PM
erj accepted D21712: iflib: Prevent watchdog from resetting idle queues.
Jan 2 2020, 11:34 PM
erj committed rS356309: ixl: prevent non-privileged access to NVM update interface.
ixl: prevent non-privileged access to NVM update interface
Jan 2 2020, 11:25 PM
erj closed D22870: ixl: prevent non-privileged access to NVM update interface.
Jan 2 2020, 11:25 PM
erj accepted D22870: ixl: prevent non-privileged access to NVM update interface.
Jan 2 2020, 11:23 PM
erj committed rS356307: MFC r355055: Fix gcc build for bitstring_test by specifying "-fno-strict….
MFC r355055: Fix gcc build for bitstring_test by specifying "-fno-strict…
Jan 2 2020, 11:18 PM
erj committed rS356306: MFC r354977: bitstring: add functions to find contiguous set/unset bit sequences.
MFC r354977: bitstring: add functions to find contiguous set/unset bit sequences
Jan 2 2020, 11:16 PM
erj committed rS356304: MFC r354975: bitstring: exit early if _start is past size of the bitstring.
MFC r354975: bitstring: exit early if _start is past size of the bitstring
Jan 2 2020, 11:06 PM
erj committed rS356302: MFC isc_pause_frame field fixes to Intel ethernet drivers.
MFC isc_pause_frame field fixes to Intel ethernet drivers
Jan 2 2020, 10:57 PM
erj committed rS356299: MFC r354344: iflib: properly release memory allocated for DMA.
MFC r354344: iflib: properly release memory allocated for DMA
Jan 2 2020, 10:47 PM
erj committed rS356298: MFC r354207: iflib: cleanup memory leaks on driver detach.
MFC r354207: iflib: cleanup memory leaks on driver detach
Jan 2 2020, 10:44 PM
erj committed rS356297: MFC r353967: iflib: call ether_ifdetach and netmap_detach before stop.
MFC r353967: iflib: call ether_ifdetach and netmap_detach before stop
Jan 2 2020, 10:42 PM
erj committed rS356291: MFC r351153: net: Update SFF-8024 definitions and strings with values from rev….
MFC r351153: net: Update SFF-8024 definitions and strings with values from rev…
Jan 2 2020, 9:58 PM

Dec 19 2019

erj added a comment to D22870: ixl: prevent non-privileged access to NVM update interface.

IMO it makes slightly more sense to have the check in the ixl ioctl handler: it serves as a signal to anyone extending the ioctl handler that they should be careful, and doing so maintains the invariant that internal driver functions need not check for privileges. I am not the maintainer though so I don't insist on any particular approach.

Dec 19 2019, 4:44 AM

Dec 3 2019

erj accepted D22523: Avoid finding every bit transition in bit_ffs_area_at.
Dec 3 2019, 8:42 PM

Dec 2 2019

erj added a comment to D22523: Avoid finding every bit transition in bit_ffs_area_at.

Hmm. I think I understand the change.. but it seems less intuitive.
Do you have any example of how much this improves? I.e. a C program with a large enough test case to show measurable improvement?

Dec 2 2019, 9:26 PM

Nov 21 2019

erj committed rS354977: bitstring: add functions to find contiguous set/unset bit sequences.
bitstring: add functions to find contiguous set/unset bit sequences
Nov 21 2019, 7:58 PM
erj closed D22400: bitstring: add functions to find contiguous set/unset bit sequences.
Nov 21 2019, 7:58 PM
erj accepted D22400: bitstring: add functions to find contiguous set/unset bit sequences.
Nov 21 2019, 7:37 PM
erj committed rS354975: bitstring: exit early if _start is past size of the bitstring.
bitstring: exit early if _start is past size of the bitstring
Nov 21 2019, 7:36 PM
erj closed D22398: bitstring: exit early if _start is past size of the bitstring.
Nov 21 2019, 7:36 PM
erj accepted D22398: bitstring: exit early if _start is past size of the bitstring.
Nov 21 2019, 7:35 PM

Nov 5 2019

erj committed rS354345: net: add ETHER_IS_ZERO macro similar to ETHER_IS_BROADCAST.
net: add ETHER_IS_ZERO macro similar to ETHER_IS_BROADCAST
Nov 5 2019, 12:12 AM
erj closed D21240: net: add ETHER_IS_ZERO macro similar to ETHER_IS_BROADCAST.
Nov 5 2019, 12:12 AM
erj accepted D21240: net: add ETHER_IS_ZERO macro similar to ETHER_IS_BROADCAST.

Builds okay now.

Nov 5 2019, 12:09 AM

Nov 4 2019

erj committed rS354344: iflib: properly release memory allocated for DMA.
iflib: properly release memory allocated for DMA
Nov 4 2019, 11:07 PM
erj closed D22203: iflib: properly release memory allocated for DMA.
Nov 4 2019, 11:07 PM
erj accepted D22203: iflib: properly release memory allocated for DMA.
Nov 4 2019, 11:04 PM
erj closed D21239: net: prefer ETHER_ADDR_LEN over ETH_ADDR_LEN.
Nov 4 2019, 10:58 PM
erj committed rS354343: net: prefer ETHER_ADDR_LEN over ETH_ADDR_LEN.
net: prefer ETHER_ADDR_LEN over ETH_ADDR_LEN
Nov 4 2019, 10:58 PM
erj accepted D21239: net: prefer ETHER_ADDR_LEN over ETH_ADDR_LEN.
Nov 4 2019, 10:56 PM
erj updated the diff for D21239: net: prefer ETHER_ADDR_LEN over ETH_ADDR_LEN.

Don't remove the extra whitespace in if.c

Nov 4 2019, 10:54 PM
erj updated the diff for D21239: net: prefer ETHER_ADDR_LEN over ETH_ADDR_LEN.

Update patch to make it build on HEAD

Nov 4 2019, 10:05 PM
erj requested changes to D21240: net: add ETHER_IS_ZERO macro similar to ETHER_IS_BROADCAST.

I get a build error with this revision:

Nov 4 2019, 9:57 PM
erj accepted D21240: net: add ETHER_IS_ZERO macro similar to ETHER_IS_BROADCAST.
Nov 4 2019, 9:50 PM
erj added a reviewer for D21239: net: prefer ETHER_ADDR_LEN over ETH_ADDR_LEN: jpaetzel.

Adding @jpaetzel since he seemed to be the last person making updates to oce(4); is this change ok to make there? There's no functional change.

Nov 4 2019, 9:49 PM
erj added a reviewer for D21239: net: prefer ETHER_ADDR_LEN over ETH_ADDR_LEN: scottl.
Nov 4 2019, 9:48 PM
erj added a comment to D22203: iflib: properly release memory allocated for DMA.

@jacob.e.keller_intel.com, is this ready to be committed?

Nov 4 2019, 9:45 PM

Oct 30 2019

erj closed D22157: iflib: cleanup memory leaks on driver detach.
Oct 30 2019, 8:45 PM
erj committed rS354207: iflib: cleanup memory leaks on driver detach.
iflib: cleanup memory leaks on driver detach
Oct 30 2019, 8:45 PM
erj accepted D22157: iflib: cleanup memory leaks on driver detach.
Oct 30 2019, 8:43 PM

Oct 23 2019

erj committed rS353967: iflib: call ether_ifdetach and netmap_detach before stop.
iflib: call ether_ifdetach and netmap_detach before stop
Oct 23 2019, 11:21 PM
erj closed D22071: iflib: call ether_ifdetach and netmap_detach before stop.
Oct 23 2019, 11:21 PM
erj accepted D22071: iflib: call ether_ifdetach and netmap_detach before stop.
Oct 23 2019, 11:16 PM
erj updated the diff for D21944: pci_iov: Stop preventing VFs from allocating extra bus numbers.

Update review with a first cut version of the code that checks the bus
ranges of upstream pci bridges; this doesn't incorporate suggestions
that jhb@ had made.

Oct 23 2019, 10:32 PM
erj accepted D21797: Add IFCAP_NOMAP to iflib.
Oct 23 2019, 5:10 PM

Oct 21 2019

erj retitled D22086: iflib: Stop interface before (un)registering VLAN from iflib: Stop interface before unregistering VLAN to iflib: Stop interface before (un)registering VLAN.
Oct 21 2019, 6:30 PM
erj updated the summary of D22086: iflib: Stop interface before (un)registering VLAN.
Oct 21 2019, 6:30 PM
erj updated the diff for D22086: iflib: Stop interface before (un)registering VLAN.
  • Add a specific iflib flag for VLAN anti-spoof and use it
Oct 21 2019, 6:27 PM
erj updated the summary of D22086: iflib: Stop interface before (un)registering VLAN.
Oct 21 2019, 5:55 PM

Oct 18 2019

erj updated the summary of D22086: iflib: Stop interface before (un)registering VLAN.
Oct 18 2019, 10:51 PM
erj created D22086: iflib: Stop interface before (un)registering VLAN.
Oct 18 2019, 10:44 PM
erj updated the diff for D19647: ifconfig: Add option to report VF status info.

Resolve merge conflict

Oct 18 2019, 5:28 AM

Oct 16 2019

erj committed rS353669: MFC r353599.
MFC r353599
Oct 16 2019, 9:55 PM
erj committed rS353665: MFC r353660: ixgbe: Disable EEE for backplane X550EM_X.
MFC r353660: ixgbe: Disable EEE for backplane X550EM_X
Oct 16 2019, 9:46 PM
erj committed rS353661: Fix compile error introduced in r353658.
Fix compile error introduced in r353658
Oct 16 2019, 6:12 PM
erj committed rS353660: MFC r353599.
MFC r353599
Oct 16 2019, 5:26 PM
erj committed rS353658: ixl: report whether device received pause frames.
ixl: report whether device received pause frames
Oct 16 2019, 5:19 PM
erj closed D21870: ixl: report whether device received pause frames.
Oct 16 2019, 5:19 PM
erj committed rS353657: ix: report isc_pause_frames during stat update.
ix: report isc_pause_frames during stat update
Oct 16 2019, 5:16 PM
erj closed D21869: ix: report isc_pause_frames during stat update.
Oct 16 2019, 5:16 PM
erj committed rS353656: e1000: correctly set isc_pause_frames only when XOFF increases.
e1000: correctly set isc_pause_frames only when XOFF increases
Oct 16 2019, 5:14 PM
erj closed D21868: e1000: correctly set isc_pause_frames only when XOFF increases.
Oct 16 2019, 5:14 PM

Oct 15 2019

erj committed rS353599: ixgbe: Disable EEE for backplane X550EM_X.
ixgbe: Disable EEE for backplane X550EM_X
Oct 15 2019, 9:56 PM
erj closed D21673: ixgbe: Disable EEE for backplane X550EM_X.
Oct 15 2019, 9:56 PM · Intel Networking

Oct 10 2019

erj added inline comments to D21959: introduce new 'ice' driver for Intel E800 Ethernet controllers.
Oct 10 2019, 1:27 AM
erj added inline comments to D21959: introduce new 'ice' driver for Intel E800 Ethernet controllers.
Oct 10 2019, 1:25 AM

Oct 9 2019

erj added a reviewer for D21959: introduce new 'ice' driver for Intel E800 Ethernet controllers: iflib.
Oct 9 2019, 7:21 PM
erj added reviewers for D21868: e1000: correctly set isc_pause_frames only when XOFF increases: iflib, Intel Networking.
Oct 9 2019, 6:44 PM
erj added reviewers for D21869: ix: report isc_pause_frames during stat update: Intel Networking, iflib.
Oct 9 2019, 6:44 PM
erj added reviewers for D21870: ixl: report whether device received pause frames: Intel Networking, iflib.
Oct 9 2019, 6:43 PM

Oct 8 2019

erj added a comment to D21944: pci_iov: Stop preventing VFs from allocating extra bus numbers.

Here's the output I got from the first pcib above ice4/ice5 in devinfo:

Oct 8 2019, 11:32 PM
erj added inline comments to D21943: Correct and final KPI to traverse through interface address lists for drivers.Removal of not stack allocated epoch_tracker..
Oct 8 2019, 11:29 PM
erj accepted D21943: Correct and final KPI to traverse through interface address lists for drivers.Removal of not stack allocated epoch_tracker..

I like the changes for the Intel ethernet drivers. I've always been uncomfortable with how we were required to manually iterate through the list in the driver using the LIST_FOREACH macros; like you say in your description, if the data structure changes, then it causes a lot of driver thrash.

Oct 8 2019, 6:36 PM
erj added a comment to D21944: pci_iov: Stop preventing VFs from allocating extra bus numbers.
In D21944#479344, @jhb wrote:

How did this work? Meaning how did you allocate bus numbers? Did the parent PCI-PCI bridge have enough bus numbers in range already? For this to work properly you'd need to ensure that the parent PCI-PCI bridge at the other end of the link has the requested bus numbers mapped into its range of valid bus numbers.

Oct 8 2019, 6:29 PM
erj added a comment to D21223: ixl(4): Fix issues with MTU change while passing traffic.

@krzysztof.galazka_intel.com did this get tested yet?

Oct 8 2019, 5:55 PM
erj added a comment to D21712: iflib: Prevent watchdog from resetting idle queues.

Would it make sense then to assert that the link is down?

Oct 8 2019, 5:54 PM
erj accepted D21673: ixgbe: Disable EEE for backplane X550EM_X.
Oct 8 2019, 5:53 PM · Intel Networking
erj updated the summary of D21944: pci_iov: Stop preventing VFs from allocating extra bus numbers.
Oct 8 2019, 5:50 PM
erj created D21944: pci_iov: Stop preventing VFs from allocating extra bus numbers.
Oct 8 2019, 5:49 PM

Oct 4 2019

erj accepted D21673: ixgbe: Disable EEE for backplane X550EM_X.
Oct 4 2019, 6:29 PM · Intel Networking

Sep 30 2019

erj resigned from D18402: netmap: ixgbe: add support for jumbo frames.
Sep 30 2019, 6:27 PM
erj requested changes to D21673: ixgbe: Disable EEE for backplane X550EM_X.
Sep 30 2019, 6:26 PM · Intel Networking
erj committed rS352912: MFC r352910 and r352911.
MFC r352910 and r352911
Sep 30 2019, 6:22 PM
erj committed rS352911: MFC r352656: ix/ixv: Read MSI-X bar from device config.
MFC r352656: ix/ixv: Read MSI-X bar from device config
Sep 30 2019, 5:36 PM
erj committed rS352910: MFC r352655: iflib: Remove redundant VLAN events deregistration.
MFC r352655: iflib: Remove redundant VLAN events deregistration
Sep 30 2019, 5:34 PM
erj added a comment to rS352655: iflib: Remove redundant VLAN events deregistration.

Relevant bugzilla: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=240610

Sep 30 2019, 5:06 PM
erj added a comment to D21711: iflib: Remove redundant VLAN events deregistration.

Bugzilla link: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=240610

Sep 30 2019, 5:06 PM

Sep 24 2019

erj resigned from D11378: iWARP driver for Intel X722 Adapter - initial commit.
Sep 24 2019, 5:28 PM
erj resigned from D16164: Make options IFLIB a real configuration option..
Sep 24 2019, 5:28 PM
erj resigned from D12040: direct vlan handling in ixgbe.
Sep 24 2019, 5:27 PM
erj committed rS352656: ix, ixv: Read msix_bar from device configuration.
ix, ixv: Read msix_bar from device configuration
Sep 24 2019, 5:06 PM
erj closed D21547: ix, ixv: Read msix_bar from device configuration.
Sep 24 2019, 5:06 PM