Fix typo (from @hselasky)

• ixlv(4): Make ixlv_if_init() and ixlv_stop() wait for ENABLE/DISABLE queue command completion
• ixl(4): Cosmetic change to message PF sends in reply to VF promiscuous config message

Can I get this patch re-reviewed before committing it?

• ixl(4): Fix RX MDD event display
• ixl/ixlv(4): Add more MPASS statements to TX path

• if_media: Add 40Gbase-ER4 media type.

In D16731#357695, @hselasky wrote:

I see IFM_40G_ER4 is missing from the table. There is only IFM_40G_LR4 currently.

Can you add IFM_40G_ER4 as part of this patch aswell?

• ixl(4): Enhance Malicious Driver Detection messages with VF information
• ixl(4): Print out additional event information when a LAN Overflow Event occurs
• ixl/ixlv(4): Add additional MPASS() asserts to the driver TX path

• ixlv(4): Change remaining M_DEVBUF malloc types to M_IXLV
• ixlv(4): Fix a memory leak when interrupt setup fails
• ixlv(4): Convert some malloc()'s to M_WAITOK from M_NOWAIT
• ixlv(4): Remove comments and commented out code
• ixlv(4): Remove list of media types displayed in "ifconfig -m"

• iflib: Free remaining interrupt resources on failure in iflib_device_register()
• iflib: Free RX queue TCP LRO memory on unload

• ixl/ixlv(4): Fix panic when receiving jumbo frame (>4k mtu) traffic

• ixl(4): Fix compile error when PCI_IOV isn't defined

Changes from D16428:

• iflib: Prevent kernel panic on detach in _task_fn_admin by checking if in detach
• iflib: Add STATE_LOCK() around flag setting in iflib_request_reset()

New changes for D16429:

• ixl(4): Add tunable to enable VF loopback; enable by default
• ixl/ixlv(4): Fix dev.ixl/v.#.vsi.rxq#.bytes sysctl not incrementing

• iflib: Prevent kernel panic on detach in _task_fn_admin by checking if in detach
• iflib: Add STATE_LOCK() around flag setting in iflib_request_reset()

• ixl(4): Lie to the VF about configuring promiscuous mode if VF isn't allowed to configure it

@gallatin, I address your specific comments, but I would need to look through ixlvc.c some more to find more code that can be shared. There is almost certainly some in there that can be shared between the PF/VF drivers.

• ixl(4): Combine PF-only/VF-only ixl_disable_rings() in PF driver into one function.
• Remove a space

I need to add the state lock to iflib_request_reset

• ixl(4): Fix module Makefile when PCI_IOV is enabled

• ixlv(4): Use same TX DMA seg sizes as the ones in ixl(4)
• ixl/ixlv(4): Preserve code removal done in r336313

• ixlv(4): Remove old/dead code

• ixlv(4): Re-add driver to GENERIC and build files
• ixl/ixlv(4): Fix module Makefiles

I'll work on adding those pointers; they're important tools for these cards.

Any update? It's been almost a month.

Is someone going to commit this? I'm getting tired of the pkg-fallout emails. 📟

In D16164#342950, @rgrimes wrote:

can iflib.ko be created and then the driver modules depend on that?

Remove (bailed)s

In D15927#338138, @pi wrote:

Yes, please add sections on how to use both tools, and reference the ports (sysutils/intel-qcu and
sysutils/intel-nvmupdate).

I've looked up 'bailed' on dict.leo.org but did not find a valid translation. What are those 'bailed' devices ?

Should I add a section about the QCU and nvmupdate utilities? They have ports, but I don't think they have manpages, so I don't know how to properly reference them.

Add acronym expansions and info on qualified module check.

In D15927#337633, @pi wrote:

Please expand LOM to 'onboard interfaces (LAN on Motherboard, LOM)', if possible. I'm a 30-years user of ethernet, but I've never heard that abbreviation.

I don't think it's that rare of an abbreviation, but I can add the expansion.

If an admin can see if an interface is external or LOM, by whatever magic, can you write about it in the man page ?

I looked into this yesterday, and there may not be a 100% accurate way to do this in the driver. I can add something and maybe identify exceptions.

In D15927#337347, @pi wrote:

Thanks -- will that be written down somewhere in the man page ? Who is selling EXL cards, because I've never found that ? And: What is LOM ?

In D15927#337295, @pi wrote:

Can you tell if the boards now accept foreign/unsupported SFP+ modules ? Is there a flag now for this
or does it still insist to only accept intel-branded SFP+ modules ?

Any additional information that should be added to the man page? Some stats descriptions? iflib sysctls? More VF usage information?

Address comments.

Any last-minute objections? This is the version that's going in!

Commit iflib style fixes separately.

• Revert "ixl(4): Increase default ITR values to 500 (1000us)"

In D15577#334003, @gallatin wrote:

You might want to go for some middle ground here. 1ms is a bit much (even for us).

Based on a report by @gallatin:

Comment out printf()'s introduced in previous commit

Add these changes from @krzysztof.galazka_intel.com

Update to exclude code in D15558, since that is now committed.

@gallatin I'm assuming you no longer have any objections to this patch?

Include contents of/update to D15558 again, since relying on dependent revisions
in Phabricator is a PITA.

Pulled out TCP saving changes since those are in D15558

Update due to D15575 being committed.

• iflib: Move stats increment in IPv6 case to match IPv4 case

• iflib: Remove comment and restore/fix setting CSUM_IP6_TCP flag during TSO6

• Make style fix.

Replaced by https://reviews.freebsd.org/D15577

Remove testing config files and make spelling fixes.

• iflib: Fixup changes made to record TCP checksum info in iflib for ixl

Update converted version of ixl(4) to 1.9.8-k; includes some other bugfixes and updates.

I've reviewed this patch-by-patch; it all looks good to me. We just need to make sure validation says it compiles and does what it's supposed to, too.

In D14967#315794, @sbruno wrote:

Y'all want this committed?

I don't see the console hanging on the version of ixl-iflib where I did see them when watchdogs happened, so this appears to fix the deadlock in that situation.