Page MenuHomeFreeBSD

erj (Eric Joyner)
Network Software Engineer @ Intel

Projects

User Details

User Since
Jan 27 2015, 7:34 PM (338 w, 4 d)

Recent Activity

Fri, Jul 9

erj planned changes to D30889: ice(4): Add RDMA Client Interface.

We'll hold off on doing anything with this until we're ready to upstream the actual RDMA driver and associated code; there may be some more changes identified.

Fri, Jul 9, 3:50 PM
erj updated the summary of D30888: ice(4): Update to version 0.29.4-k.
Fri, Jul 9, 12:22 AM
erj updated the diff for D30889: ice(4): Add RDMA Client Interface.

Rebase on latest main

Fri, Jul 9, 12:22 AM
erj updated the diff for D30888: ice(4): Update to version 0.29.4-k.

Rebase on latest main

Fri, Jul 9, 12:22 AM
erj updated the summary of D30888: ice(4): Update to version 0.29.4-k.
Fri, Jul 9, 12:20 AM
erj updated the diff for D30889: ice(4): Add RDMA Client Interface.

Rebase on updated parent

Fri, Jul 9, 12:19 AM
erj updated the diff for D30888: ice(4): Update to version 0.29.4-k.

Add tunable to allow disabling FW health event reporting by the driver

Fri, Jul 9, 12:18 AM

Tue, Jun 29

erj accepted D30938: handbook/cutting_edge: document the n-number.
Tue, Jun 29, 6:53 PM
erj added inline comments to D30938: handbook/cutting_edge: document the n-number.
Tue, Jun 29, 4:19 PM
erj accepted D30938: handbook/cutting_edge: document the n-number.
Tue, Jun 29, 4:07 PM
erj added inline comments to D30938: handbook/cutting_edge: document the n-number.
Tue, Jun 29, 3:52 PM

Fri, Jun 25

erj committed R10:070f7812da16: ice_ddp: Revert mode back to 0644 (authored by erj).
ice_ddp: Revert mode back to 0644
Fri, Jun 25, 5:30 PM
erj committed R10:538ef055b7ea: ice_ddp: Update to 1.3.24.0 (authored by erj).
ice_ddp: Update to 1.3.24.0
Fri, Jun 25, 5:22 PM
erj closed D30887: ice_ddp: Update to 1.3.24.0.
Fri, Jun 25, 5:22 PM
erj added a comment to D30889: ice(4): Add RDMA Client Interface.

Yes, I meant in-tree-kernel version. Do you have plan to upstream OOT irdma driver ?

Fri, Jun 25, 3:08 PM

Jun 24 2021

erj added a comment to D30889: ice(4): Add RDMA Client Interface.

Eric,

I donot see "irdma" available yet in FreeBSD ?

Jun 24 2021, 8:49 PM
erj added reviewers for D30889: ice(4): Add RDMA Client Interface: stallamr_netapp.com, Intel Networking.
Jun 24 2021, 8:07 PM
erj requested review of D30889: ice(4): Add RDMA Client Interface.
Jun 24 2021, 8:07 PM
erj updated the summary of D30888: ice(4): Update to version 0.29.4-k.
Jun 24 2021, 6:55 PM
erj updated the summary of D30888: ice(4): Update to version 0.29.4-k.
Jun 24 2021, 6:53 PM
erj added reviewers for D30888: ice(4): Update to version 0.29.4-k: stallamr_netapp.com, Intel Networking.
Jun 24 2021, 6:41 PM
erj updated the test plan for D30887: ice_ddp: Update to 1.3.24.0.
Jun 24 2021, 6:41 PM
erj requested review of D30888: ice(4): Update to version 0.29.4-k.
Jun 24 2021, 6:39 PM
erj requested review of D30887: ice_ddp: Update to 1.3.24.0.
Jun 24 2021, 6:39 PM

Jun 15 2021

erj closed D29037: iflib: Add fields for tunneled packets in if_pkt_info.

D30691 replaces this revision.

Jun 15 2021, 3:16 PM
erj accepted D30668: Intel I225 Driver.

I don't see any glaring problems with it that should block it from going upstream. Are you going to announce this addition on the mailing lists?

Jun 15 2021, 3:13 PM
erj accepted D30728: iflib: Add a new quirk.
Jun 15 2021, 3:05 PM

Jun 7 2021

erj added inline comments to D30668: Intel I225 Driver.
Jun 7 2021, 4:52 PM
erj added inline comments to D30668: Intel I225 Driver.
Jun 7 2021, 4:49 PM

May 28 2021

erj requested changes to D30463: iflib:correct vlan register/unregister.

I also don't really understand what this is supposed to fix; we haven't had problems registering VLANs at all.

May 28 2021, 10:55 PM · iflib

May 6 2021

erj added a comment to D30094: ixgbe: Enable AIM by default.

Reading what Sai wrote, I think the best approach from an Intel perspective is to account for Tx data in the AIM calculation; we shouldn't be splitting the Tx/Rx interrupts.

May 6 2021, 11:12 PM
erj added a comment to D30094: ixgbe: Enable AIM by default.
  1. In true spirit, if real intention of IFLIB is to split Rx and Tx queues, then we better have unique IRQs for Rx and Tx queues. So, one cannot influence the other. But this again would increase the need/demand for more IRQs on a given node.

It seems like it would be simplest to split tx/rx interrupts and see if the moderation rate on the rx irq was as expected. We recently bumped the max number of msx vectors in an amd64 system, so perhaps whatever decision lead to tying tx/rx together could be revisited.

May 6 2021, 11:09 PM

Apr 28 2021

erj accepted D29876: ixgbe: Improve device name strings.
Apr 28 2021, 2:31 AM
erj added inline comments to D29876: ixgbe: Improve device name strings.
Apr 28 2021, 1:26 AM

Apr 22 2021

erj accepted D29928: iflib: initialize LRO unconditionally.
Apr 22 2021, 5:54 PM

Apr 21 2021

erj added inline comments to D29872: e1000: Improve device name strings .
Apr 21 2021, 4:23 PM

Apr 19 2021

erj added a comment to D29801: e1000: Add support for [Tiger, Alder, Meteor] Lake client platforms.

Were there any other hacks or hardware workarounds? I think they usually add some every generation, but maybe they've finally stopped with these last I219 versions.

Apr 19 2021, 8:08 PM
erj accepted D29827: ixgbe: Clean up ixgbe_if_multi_set.
Apr 19 2021, 6:59 PM

Apr 16 2021

erj accepted D29798: ixgbe: Clarify variable index usage in ixgbe_mc_filter_apply.
Apr 16 2021, 11:14 PM
erj added a comment to D29037: iflib: Add fields for tunneled packets in if_pkt_info.

I think that for now, since FreeBSD 13.0 has released, we're going to wait on this until we have an implementation of VXLAN offload in ixl(4) that's ready to be upstreamed that will use this.

Apr 16 2021, 8:51 PM
erj added inline comments to D29789: e1000: Correct promiscuous multicast filter handling .
Apr 16 2021, 7:01 PM

Apr 5 2021

erj closed D29338: ixl(4): Add tunable to override Flow Control settings.
Apr 5 2021, 6:22 PM
erj committed R10:20a52706c814: ixl(4): Add tunable to override Flow Control settings (authored by krzysztof.galazka_intel.com).
ixl(4): Add tunable to override Flow Control settings
Apr 5 2021, 6:22 PM
erj accepted D29338: ixl(4): Add tunable to override Flow Control settings.
Apr 5 2021, 6:15 PM

Mar 11 2021

erj committed R10:f9c8aed24422: ixl(4): Add ability to control link state on ifconfig down (authored by krzysztof.galazka_intel.com).
ixl(4): Add ability to control link state on ifconfig down
Mar 11 2021, 1:16 AM
erj committed R10:995755b959a6: ixl(4): Report RX errors as sum of all RX error counters (authored by krzysztof.galazka_intel.com).
ixl(4): Report RX errors as sum of all RX error counters
Mar 11 2021, 1:15 AM
erj committed R10:adc22165c088: ix(4): Report RX errors as sum of all RX error counters (authored by piotr.pietruszewski_intel.com).
ix(4): Report RX errors as sum of all RX error counters
Mar 11 2021, 1:15 AM
erj committed R10:c637a66be46c: ixl(4): Fix VLAN HW filtering (authored by krzysztof.galazka_intel.com).
ixl(4): Fix VLAN HW filtering
Mar 11 2021, 1:15 AM
erj committed R10:6db19df195ef: ice_ddp: Update package file to 1.3.19.0 (authored by erj).
ice_ddp: Update package file to 1.3.19.0
Mar 11 2021, 1:15 AM
erj committed R10:3af5680fe222: ice(4): Update to version 0.28.1-k (authored by erj).
ice(4): Update to version 0.28.1-k
Mar 11 2021, 1:15 AM

Mar 9 2021

erj committed R10:a02640c79e0a: ice_ddp: Update package file to 1.3.19.0 (authored by erj).
ice_ddp: Update package file to 1.3.19.0
Mar 9 2021, 10:43 PM
erj committed R10:1da549169de0: ice(4): Update to version 0.28.1-k (authored by erj).
ice(4): Update to version 0.28.1-k
Mar 9 2021, 10:43 PM

Mar 6 2021

erj accepted D29102: iflib: Make if_shared_ctx_t a pointer to const.
Mar 6 2021, 1:47 AM
erj closed D28640: ice(4): Update to version 0.28.1-k.

Committed.

Mar 6 2021, 1:46 AM
erj committed R10:d08b8680e12a: ice(4): Update to version 0.28.1-k (authored by erj).
ice(4): Update to version 0.28.1-k
Mar 6 2021, 1:40 AM
erj accepted D28640: ice(4): Update to version 0.28.1-k.
Mar 6 2021, 1:39 AM
erj updated the summary of D28640: ice(4): Update to version 0.28.1-k.
Mar 6 2021, 1:39 AM

Mar 5 2021

erj added a comment to D29037: iflib: Add fields for tunneled packets in if_pkt_info.

It'd be nice to get this into 13.0 -- that means at least out of tree iflib drivers can be updated to support VXLAN offload on 13.0-RELEASE.

Mar 5 2021, 5:00 PM
erj committed R10:2b94bda05a6d: ixl(4): Add ability to control link state on ifconfig down (authored by krzysztof.galazka_intel.com).
ixl(4): Add ability to control link state on ifconfig down
Mar 5 2021, 1:24 AM
erj committed R10:b149f7c23d13: ixl(4): Report RX errors as sum of all RX error counters (authored by krzysztof.galazka_intel.com).
ixl(4): Report RX errors as sum of all RX error counters
Mar 5 2021, 1:24 AM
erj committed R10:8fa11f892256: ix(4): Report RX errors as sum of all RX error counters (authored by piotr.pietruszewski_intel.com).
ix(4): Report RX errors as sum of all RX error counters
Mar 5 2021, 1:24 AM
erj committed R10:7e166d608eec: ixl(4): Fix VLAN HW filtering (authored by krzysztof.galazka_intel.com).
ixl(4): Fix VLAN HW filtering
Mar 5 2021, 1:24 AM

Mar 3 2021

erj added a comment to D27344: Bring back AIM (Adaptive Interrupt Moderation) that was lost in IFLIB migration..

Is this going to get committed soon? Possibly for inclusion in 13.0?

Mar 3 2021, 1:59 AM
erj added a comment to D26896: ixl: honor IPI_TX_INTR.

@krzysztof.galazka_intel.com, do you have any update on an answer to @vmaffione's question ?

Mar 3 2021, 1:56 AM
erj added a comment to D26245: ix(4): Add control of 2.5/5G autonegotiation speeds.

Did this get tested?

Mar 3 2021, 1:55 AM
erj added a comment to D24094: Fix allocation of queues to CPUs in iflib.

Has anyone else looked at this yet? I haven't had a chance to.

Mar 3 2021, 1:54 AM
erj added a comment to D21223: ixl(4): Fix issues with MTU change while passing traffic.
In D21223#479325, @erj wrote:

@krzysztof.galazka_intel.com did this get tested yet?

Mar 3 2021, 1:54 AM
erj committed R10:21802a127d83: ixl(4): Add ability to control link state on ifconfig down (authored by krzysztof.galazka_intel.com).
ixl(4): Add ability to control link state on ifconfig down
Mar 3 2021, 1:51 AM
erj closed D28028: ixl(4): Add ability to control link state on ifconfig down.
Mar 3 2021, 1:50 AM
erj accepted D28028: ixl(4): Add ability to control link state on ifconfig down.
Mar 3 2021, 1:43 AM
erj committed R10:9f99061ef9c9: ixl(4): Report RX errors as sum of all RX error counters (authored by krzysztof.galazka_intel.com).
ixl(4): Report RX errors as sum of all RX error counters
Mar 3 2021, 1:38 AM
erj closed D27639: ixl(4): Report RX errors as sum of all RX error counters.
Mar 3 2021, 1:37 AM
erj accepted D27639: ixl(4): Report RX errors as sum of all RX error counters.
Mar 3 2021, 1:36 AM
erj committed R10:afb1aa4e6df2: ix(4): Report RX errors as sum of all RX error counters (authored by piotr.pietruszewski_intel.com).
ix(4): Report RX errors as sum of all RX error counters
Mar 3 2021, 1:32 AM
erj closed D27191: ix(4): Report RX errors as sum of all RX error counters.
Mar 3 2021, 1:31 AM
erj accepted D27191: ix(4): Report RX errors as sum of all RX error counters.
Mar 3 2021, 1:26 AM

Feb 23 2021

erj accepted D28900: iflib: Avoid double counting in rxeof.
Feb 23 2021, 10:43 PM
erj added inline comments to D28900: iflib: Avoid double counting in rxeof.
Feb 23 2021, 5:44 PM
erj updated the diff for D28640: ice(4): Update to version 0.28.1-k.
  • Commit the ice_ddp package in a separate commit
Feb 23 2021, 2:06 AM
erj committed R10:a7ac518bff64: ice_ddp: Update package file to 1.3.19.0 (authored by erj).
ice_ddp: Update package file to 1.3.19.0
Feb 23 2021, 2:04 AM

Feb 18 2021

erj accepted D28774: iflib: Fix detach of pseudo interfaces.
Feb 18 2021, 10:06 PM
erj planned changes to D28636: iavf: Split source and update to 3.0.26.
Feb 18 2021, 5:45 AM

Feb 17 2021

erj accepted D28598: iflib: Cast the result of iflib_netmap_txq_init() to void..
Feb 17 2021, 11:21 PM
erj requested changes to D28598: iflib: Cast the result of iflib_netmap_txq_init() to void..

So, it sounds like it'd be preferred to use (void)0 instead of using an empty stub?

Feb 17 2021, 10:38 PM
erj added a comment to D21797: Add IFCAP_NOMAP to iflib.

Is this going to get committed?

Feb 17 2021, 7:09 PM
erj added inline comments to D28706: iflib: add new field: isc_dma_width.
Feb 17 2021, 7:08 PM
erj updated the diff for D28640: ice(4): Update to version 0.28.1-k.
  • Actually make the new ice_vlan_mode.c file that was added
Feb 17 2021, 2:01 AM
erj retitled D28640: ice(4): Update to version 0.28.1-k from ice(4): Update to version 0.28.0-k to ice(4): Update to version 0.28.1-k.
Feb 17 2021, 1:39 AM
erj updated the diff for D28640: ice(4): Update to version 0.28.1-k.
  • ice: Update to 0.28.1-k from 0.28.0-k, restore changes made by non-Intel commits
Feb 17 2021, 1:38 AM

Feb 16 2021

erj planned changes to D28640: ice(4): Update to version 0.28.1-k.

I also need to make other changes to this, too.

Feb 16 2021, 7:54 PM
erj added inline comments to D28640: ice(4): Update to version 0.28.1-k.
Feb 16 2021, 5:30 PM

Feb 13 2021

erj added reviewers for D28640: ice(4): Update to version 0.28.1-k: Intel Networking, iflib.
Feb 13 2021, 12:30 AM
erj requested review of D28640: ice(4): Update to version 0.28.1-k.
Feb 13 2021, 12:29 AM
erj updated the summary of D28637: iavf: Add Doxyfile.
Feb 13 2021, 12:18 AM
erj added reviewers for D28636: iavf: Split source and update to 3.0.26: Intel Networking, iflib.
Feb 13 2021, 12:16 AM
erj requested review of D28638: ixl(4): Remove iavf(4) source files.
Feb 13 2021, 12:15 AM
erj requested review of D28637: iavf: Add Doxyfile.
Feb 13 2021, 12:15 AM
erj requested review of D28636: iavf: Split source and update to 3.0.26.
Feb 13 2021, 12:15 AM

Feb 11 2021

erj added a reviewer for D28598: iflib: Cast the result of iflib_netmap_txq_init() to void.: vmaffione.
Feb 11 2021, 11:03 PM

Feb 4 2021

erj closed D28137: ixl(4): Fix VLAN HW filtering.
Feb 4 2021, 11:35 PM