Page MenuHomeFreeBSD

erj (Eric Joyner)
Network Software Engineer @ Intel

Projects

User Details

User Since
Jan 27 2015, 7:34 PM (246 w, 2 h)

Recent Activity

Today

erj committed rS353599: ixgbe: Disable EEE for backplane X550EM_X.
ixgbe: Disable EEE for backplane X550EM_X
Tue, Oct 15, 9:56 PM
erj closed D21673: ixgbe: Disable EEE for backplane X550EM_X.
Tue, Oct 15, 9:56 PM · Intel Networking

Thu, Oct 10

erj added inline comments to D21959: introduce new 'ice' driver for Intel E800 Ethernet controllers.
Thu, Oct 10, 1:27 AM
erj added inline comments to D21959: introduce new 'ice' driver for Intel E800 Ethernet controllers.
Thu, Oct 10, 1:25 AM

Wed, Oct 9

erj added a reviewer for D21959: introduce new 'ice' driver for Intel E800 Ethernet controllers: iflib.
Wed, Oct 9, 7:21 PM
erj added reviewers for D21868: e1000: correctly set isc_pause_frames only when XOFF increases: iflib, Intel Networking.
Wed, Oct 9, 6:44 PM
erj added reviewers for D21869: ix: report isc_pause_frames during stat update: Intel Networking, iflib.
Wed, Oct 9, 6:44 PM
erj added reviewers for D21870: ixl: report whether device received pause frames: Intel Networking, iflib.
Wed, Oct 9, 6:43 PM

Tue, Oct 8

erj added a comment to D21944: pci_iov: Stop preventing VFs from allocating extra bus numbers.

Here's the output I got from the first pcib above ice4/ice5 in devinfo:

Tue, Oct 8, 11:32 PM
erj added inline comments to D21943: Correct and final KPI to traverse through interface address lists for drivers.Removal of not stack allocated epoch_tracker..
Tue, Oct 8, 11:29 PM
erj accepted D21943: Correct and final KPI to traverse through interface address lists for drivers.Removal of not stack allocated epoch_tracker..

I like the changes for the Intel ethernet drivers. I've always been uncomfortable with how we were required to manually iterate through the list in the driver using the LIST_FOREACH macros; like you say in your description, if the data structure changes, then it causes a lot of driver thrash.

Tue, Oct 8, 6:36 PM
erj added a comment to D21944: pci_iov: Stop preventing VFs from allocating extra bus numbers.
In D21944#479344, @jhb wrote:

How did this work? Meaning how did you allocate bus numbers? Did the parent PCI-PCI bridge have enough bus numbers in range already? For this to work properly you'd need to ensure that the parent PCI-PCI bridge at the other end of the link has the requested bus numbers mapped into its range of valid bus numbers.

Tue, Oct 8, 6:29 PM
erj added a comment to D21223: ixl(4): Fix issues with MTU change while passing traffic.

@krzysztof.galazka_intel.com did this get tested yet?

Tue, Oct 8, 5:55 PM
erj added a comment to D21712: iflib: Prevent watchdog from resetting idle queues.

Would it make sense then to assert that the link is down?

Tue, Oct 8, 5:54 PM
erj accepted D21673: ixgbe: Disable EEE for backplane X550EM_X.
Tue, Oct 8, 5:53 PM · Intel Networking
erj updated the summary of D21944: pci_iov: Stop preventing VFs from allocating extra bus numbers.
Tue, Oct 8, 5:50 PM
erj created D21944: pci_iov: Stop preventing VFs from allocating extra bus numbers.
Tue, Oct 8, 5:49 PM

Fri, Oct 4

erj accepted D21673: ixgbe: Disable EEE for backplane X550EM_X.
Fri, Oct 4, 6:29 PM · Intel Networking

Mon, Sep 30

erj resigned from D18402: netmap: ixgbe: add support for jumbo frames.
Mon, Sep 30, 6:27 PM
erj requested changes to D21673: ixgbe: Disable EEE for backplane X550EM_X.
Mon, Sep 30, 6:26 PM · Intel Networking
erj committed rS352912: MFC r352910 and r352911.
MFC r352910 and r352911
Mon, Sep 30, 6:22 PM
erj committed rS352911: MFC r352656: ix/ixv: Read MSI-X bar from device config.
MFC r352656: ix/ixv: Read MSI-X bar from device config
Mon, Sep 30, 5:36 PM
erj committed rS352910: MFC r352655: iflib: Remove redundant VLAN events deregistration.
MFC r352655: iflib: Remove redundant VLAN events deregistration
Mon, Sep 30, 5:34 PM
erj added a comment to rS352655: iflib: Remove redundant VLAN events deregistration.

Relevant bugzilla: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=240610

Mon, Sep 30, 5:06 PM
erj added a comment to D21711: iflib: Remove redundant VLAN events deregistration.

Bugzilla link: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=240610

Mon, Sep 30, 5:06 PM

Tue, Sep 24

erj resigned from D11378: iWARP driver for Intel X722 Adapter - initial commit.
Tue, Sep 24, 5:28 PM
erj resigned from D16164: Make options IFLIB a real configuration option..
Tue, Sep 24, 5:28 PM
erj resigned from D12040: direct vlan handling in ixgbe.
Tue, Sep 24, 5:27 PM
erj committed rS352656: ix, ixv: Read msix_bar from device configuration.
ix, ixv: Read msix_bar from device configuration
Tue, Sep 24, 5:06 PM
erj closed D21547: ix, ixv: Read msix_bar from device configuration.
Tue, Sep 24, 5:06 PM
erj closed D21711: iflib: Remove redundant VLAN events deregistration.
Tue, Sep 24, 5:03 PM
erj committed rS352655: iflib: Remove redundant VLAN events deregistration.
iflib: Remove redundant VLAN events deregistration
Tue, Sep 24, 5:03 PM
erj accepted D21711: iflib: Remove redundant VLAN events deregistration.
Tue, Sep 24, 4:59 PM

Tue, Sep 17

erj accepted D21547: ix, ixv: Read msix_bar from device configuration.
Tue, Sep 17, 4:38 PM

Mon, Sep 16

erj added inline comments to D21673: ixgbe: Disable EEE for backplane X550EM_X.
Mon, Sep 16, 9:07 PM · Intel Networking

Sep 9 2019

erj closed D21540: initialize the STATE_LOCK in iflib_register.
Sep 9 2019, 6:07 PM
erj committed rS352091: iflib: initialize the STATE_LOCK in iflib_register.
iflib: initialize the STATE_LOCK in iflib_register
Sep 9 2019, 6:07 PM
erj accepted D21540: initialize the STATE_LOCK in iflib_register.
Sep 9 2019, 6:04 PM
erj added a reviewer for D21547: ix, ixv: Read msix_bar from device configuration: jhb.

Is there a reason that we wouldn't do this for all of our drivers, instead of hardcoding the BAR index?

Sep 9 2019, 5:30 PM

Aug 30 2019

erj committed rS351627: Bump __FreeBSD_version number for changes made in r351276.
Bump __FreeBSD_version number for changes made in r351276
Aug 30 2019, 5:36 PM

Aug 20 2019

erj committed rS351276: MFC various iflib fixes from head.
MFC various iflib fixes from head
Aug 20 2019, 8:15 PM

Aug 17 2019

erj closed D21041: net: Update SFF-8024 definitions and strings with values from rev 4.6.
Aug 17 2019, 12:11 AM · network
erj committed rS351153: net: Update SFF-8024 definitions and strings with values from rev 4.6.
net: Update SFF-8024 definitions and strings with values from rev 4.6
Aug 17 2019, 12:11 AM

Aug 16 2019

erj committed rS351152: iflib: add iflib_deregister to help cleanup on exit.
iflib: add iflib_deregister to help cleanup on exit
Aug 16 2019, 11:34 PM
erj closed D21005: iflib: add iflib_deregister to help cleanup on exit.
Aug 16 2019, 11:34 PM
erj accepted D21005: iflib: add iflib_deregister to help cleanup on exit.
Aug 16 2019, 11:33 PM

Aug 1 2019

erj committed rS350509: iflib: Prevent kernel panic caused by loading driver with a specific interrupt….
iflib: Prevent kernel panic caused by loading driver with a specific interrupt…
Aug 1 2019, 5:37 PM
erj closed D20747: iflib: Prevent kernel panic caused by loading driver with a specific interrupt configuration.
Aug 1 2019, 5:37 PM
erj committed rS350507: iflib: remove kobject class reference increment.
iflib: remove kobject class reference increment
Aug 1 2019, 5:29 PM
erj closed D21125: iflib: remove kobject class reference increment.
Aug 1 2019, 5:29 PM
erj accepted D21125: iflib: remove kobject class reference increment.
Aug 1 2019, 5:20 PM

Jul 24 2019

erj closed D21003: iflib: fix dangling device softc pointer.
Jul 24 2019, 9:44 PM
erj committed rS350306: iflib: fix dangling device softc pointer.
iflib: fix dangling device softc pointer
Jul 24 2019, 9:44 PM
erj added a reviewer for D21005: iflib: add iflib_deregister to help cleanup on exit: gallatin.
Jul 24 2019, 4:38 PM
erj added a reviewer for D21003: iflib: fix dangling device softc pointer: gallatin.
Jul 24 2019, 4:38 PM
erj added inline comments to D21041: net: Update SFF-8024 definitions and strings with values from rev 4.6.
Jul 24 2019, 4:29 PM · network
erj added reviewers for D21041: net: Update SFF-8024 definitions and strings with values from rev 4.6: hselasky, melifaro, jhb, np.
Jul 24 2019, 4:23 PM · network

Jul 23 2019

erj created D21041: net: Update SFF-8024 definitions and strings with values from rev 4.6.
Jul 23 2019, 8:45 PM · network
erj added a comment to D21005: iflib: add iflib_deregister to help cleanup on exit.

This is built on top of https://reviews.freebsd.org/D21004
It could probably be backported, but isn't as necessary as the previous patch which is why I kept them separate.

Jul 23 2019, 6:17 PM
erj committed rS350253: ixgbe(4): Fix enabling/disabling and reconfiguration of queues.
ixgbe(4): Fix enabling/disabling and reconfiguration of queues
Jul 23 2019, 6:14 PM
erj closed D20826: ixgbe(4): Fix enabling/disabling and reconfiguration of queues.
Jul 23 2019, 6:14 PM
erj accepted D20826: ixgbe(4): Fix enabling/disabling and reconfiguration of queues.
Jul 23 2019, 6:13 PM
erj accepted D21003: iflib: fix dangling device softc pointer.
Jul 23 2019, 5:44 PM

Jun 24 2019

erj added a comment to D20747: iflib: Prevent kernel panic caused by loading driver with a specific interrupt configuration.

Wrap line to keep it under 80 cols

Jun 24 2019, 11:26 PM
erj abandoned D20749: iflib: Prevent kernel panic caused by loading driver with a specific interrupt configuration.
Jun 24 2019, 11:25 PM
erj created D20749: iflib: Prevent kernel panic caused by loading driver with a specific interrupt configuration.
Jun 24 2019, 11:25 PM
erj created D20747: iflib: Prevent kernel panic caused by loading driver with a specific interrupt configuration.
Jun 24 2019, 8:17 PM
erj added a comment to D20290: Update Intel XL710 PF and VF drivers to version ixl-1.11.9 and ixlv-1.5.8.

This was committed to stable/11 in rS349163 and releng/11.3 in rS349181.

Jun 24 2019, 6:39 PM

Jun 19 2019

erj committed rS349181: MFS r349163: ixl(4)/ixlv(4): Update Intel XL710 PF and VF drivers to ixl-1.11.9….
MFS r349163: ixl(4)/ixlv(4): Update Intel XL710 PF and VF drivers to ixl-1.11.9…
Jun 19 2019, 12:38 AM

Jun 18 2019

erj committed rS349163: ixl(4)/ixlv(4): Update Intel XL710 PF and VF drivers to ixl-1.11.9 and ixlv-1.5..
ixl(4)/ixlv(4): Update Intel XL710 PF and VF drivers to ixl-1.11.9 and ixlv-1.5.
Jun 18 2019, 12:08 AM

May 29 2019

erj accepted D20428: ixl(4): fix the code not guarded by the guarded by the if clause.

This is fine -- this was a result of our code stripping process, I think.

May 29 2019, 10:25 PM
erj committed rS348372: iflib: provide probe wrapper for vendor drivers.
iflib: provide probe wrapper for vendor drivers
May 29 2019, 10:24 PM
erj closed D20221: iflib: provide probe wrapper for vendor drivers.
May 29 2019, 10:24 PM

May 10 2019

erj accepted D20221: iflib: provide probe wrapper for vendor drivers.
May 10 2019, 5:11 PM
erj committed rS347419: ix(4): Move {mod,msf,mbx,fdir,phy,link}_task to lock protected handler.
ix(4): Move {mod,msf,mbx,fdir,phy,link}_task to lock protected handler
May 10 2019, 12:46 AM
erj closed D19711: ix(4): Move {mod,msf,mbx,fdir,phy,link}_task to lock protected handler.
May 10 2019, 12:46 AM · Intel Networking
erj committed rS347418: iflib: use default ntxd and nrxd when user value is not power of 2.
iflib: use default ntxd and nrxd when user value is not power of 2
May 10 2019, 12:42 AM
erj closed D19880: iflib: use default ntxd and nrxd when user value is not power of 2.
May 10 2019, 12:42 AM

May 8 2019

erj committed rS347373: iflib: Add missing return statement that was left out from r347197.
iflib: Add missing return statement that was left out from r347197
May 8 2019, 11:13 PM

May 6 2019

erj committed rS347213: MFC r345312: iflib: mark isc_driver_version as constant.
MFC r345312: iflib: mark isc_driver_version as constant
May 6 2019, 9:31 PM
erj committed rS347212: MFC r345303, 345658, and partially MFC r345305.
MFC r345303, 345658, and partially MFC r345305
May 6 2019, 9:21 PM
erj committed rS347210: MFC r344817: Remove references to CONTIGMALLOC_WORKS in iflib and em.
MFC r344817: Remove references to CONTIGMALLOC_WORKS in iflib and em
May 6 2019, 8:48 PM
erj committed rS347208: MFC r340435: Prevent POLA violation with TSO/CSUM offload.
MFC r340435: Prevent POLA violation with TSO/CSUM offload
May 6 2019, 8:42 PM
erj closed D19949: MFC important iflib changes to stable/11.
May 6 2019, 6:50 PM
erj committed rS347197: MFC r332389, r3342331, r334343, and partially r339338.
MFC r332389, r3342331, r334343, and partially r339338
May 6 2019, 6:50 PM

Apr 18 2019

erj added a reviewer for D19949: MFC important iflib changes to stable/11: Intel Networking.
Apr 18 2019, 1:33 AM
erj created D19949: MFC important iflib changes to stable/11.
Apr 18 2019, 1:32 AM
erj abandoned D19947: MFC r344817: Remove references to CONTIGMALLOC_WORKS in iflib and em.
Apr 18 2019, 1:19 AM

Apr 17 2019

erj updated the diff for D19947: MFC r344817: Remove references to CONTIGMALLOC_WORKS in iflib and em.

Attempt to fix paths for stable/11.

Apr 17 2019, 11:36 PM
erj created D19947: MFC r344817: Remove references to CONTIGMALLOC_WORKS in iflib and em.
Apr 17 2019, 11:34 PM
erj committed rS346338: MFC r345312.
MFC r345312
Apr 17 2019, 11:09 PM
erj committed rS346337: MFC r345303, r345305, r345657, r345658.
MFC r345303, r345305, r345657, r345658
Apr 17 2019, 11:02 PM
erj committed rS346336: MFC r344817.
MFC r344817
Apr 17 2019, 10:45 PM
erj committed rS346335: MFC r344643 and r345306.
MFC r344643 and r345306
Apr 17 2019, 10:41 PM

Apr 16 2019

erj updated the diff for D19647: ifconfig: Add option to report VF status info.
  • Replace a space after #define with tab
Apr 16 2019, 12:40 AM

Apr 11 2019

erj updated the diff for D19647: ifconfig: Add option to report VF status info.
  • ifconfig: Add option to report VF status info
  • ixl: Add a license to ifvfstatus.c
  • ixl: Updates to if_ixl.c
  • Add spare data fields to struct ifvfstatus
Apr 11 2019, 6:38 PM
erj added inline comments to D19647: ifconfig: Add option to report VF status info.
Apr 11 2019, 6:18 PM

Mar 28 2019

erj closed D19652: iflib: return ENETDOWN when the network device is down.
Mar 28 2019, 8:47 PM
erj committed rS345658: iflib: return ENETDOWN when the network device is down.
iflib: return ENETDOWN when the network device is down
Mar 28 2019, 8:47 PM
erj committed rS345657: iflib: hold the CTX lock in iflib_pseudo_register.
iflib: hold the CTX lock in iflib_pseudo_register
Mar 28 2019, 8:44 PM