Page MenuHomeFreeBSD

erj (Eric Joyner)
Network Software Engineer @ Intel

Projects

User Details

User Since
Jan 27 2015, 7:34 PM (490 w, 4 d)

Recent Activity

Fri, Jun 7

erj accepted D45531: sys/sysctl.h: Fix wrong assertion with multiple access flags.
Fri, Jun 7, 7:31 PM
erj accepted D45494: powerof2: replace loops with fls or ilog2.

It would be nice if someone added a comment about what the operations in irdma_ctrl.c are doing, but I think I understand them and the replacements look ok to me.

Fri, Jun 7, 7:29 PM

Tue, Jun 4

erj accepted D45488: radlib: fix a memory leak.

It looks like it matches the cleanup that happens in the other return paths to me

Tue, Jun 4, 8:07 PM

May 21 2024

erj accepted D43093: iavf(4): Improve man page.
May 21 2024, 11:17 PM
erj added a comment to D43093: iavf(4): Improve man page.

The updates look good to me.

May 21 2024, 9:26 PM
erj added a comment to D43093: iavf(4): Improve man page.
In D43093#1033039, @des wrote:

Eric, do you want me to commandeer this?

May 21 2024, 7:10 AM

May 20 2024

erj accepted D45270: Add man page for the ice network driver..

Content-wise, it looks good to me now.

May 20 2024, 10:50 PM
erj requested changes to D45270: Add man page for the ice network driver..

Similar to the iavf(4) update here: https://reviews.freebsd.org/D43093, the documentation team here has generated a new man page for ice(4), but I haven't converted it to the FreeBSD upstream format, yet. I'm fine with this version with some fixes, but if you give me a couple days I can convert it and submit it here for review.

May 20 2024, 5:45 PM

Apr 24 2024

erj committed rGf6de0a7c94e9: ice(4): Update to 1.39.13-k (authored by erj).
ice(4): Update to 1.39.13-k
Apr 24 2024, 10:15 PM
erj committed rG988dd5a1f361: ice(4): Update copyright year to 2024 (authored by erj).
ice(4): Update copyright year to 2024
Apr 24 2024, 10:15 PM
erj committed rGeafd6c26f95e: ice_ddp: Update package to 1.3.36.0 (authored by erj).
ice_ddp: Update package to 1.3.36.0
Apr 24 2024, 10:15 PM
erj committed rG59d1c385f681: iflib: Add subinterface interrupt allocation function (authored by erj).
iflib: Add subinterface interrupt allocation function
Apr 24 2024, 10:15 PM
erj committed rGff28ca091142: iflib: Add sysctl to request extra MSIX vectors on driver load (authored by erj).
iflib: Add sysctl to request extra MSIX vectors on driver load
Apr 24 2024, 10:15 PM

Apr 18 2024

erj closed D44004: ice(4): Update to 1.39.13-k.

Committed.

Apr 18 2024, 11:27 PM
erj closed D44003: ice(4): Update copyright year to 2024.

Committed in 015f8cc5b0c10336a048f37a7071ea03516de242.

Apr 18 2024, 11:26 PM
erj accepted D44003: ice(4): Update copyright year to 2024.
Apr 18 2024, 11:25 PM
erj committed rG9e54973fc33a: ice(4): Update to 1.39.13-k (authored by erj).
ice(4): Update to 1.39.13-k
Apr 18 2024, 11:24 PM
erj committed rG015f8cc5b0c1: ice(4): Update copyright year to 2024 (authored by erj).
ice(4): Update copyright year to 2024
Apr 18 2024, 11:24 PM
erj committed rGed34a6b6eab9: iflib: Add subinterface interrupt allocation function (authored by erj).
iflib: Add subinterface interrupt allocation function
Apr 18 2024, 11:24 PM
erj committed rG3c7da27a473e: iflib: Add sysctl to request extra MSIX vectors on driver load (authored by erj).
iflib: Add sysctl to request extra MSIX vectors on driver load
Apr 18 2024, 11:24 PM
erj closed D39930: iflib: Add subinterface interrupt allocation function.
Apr 18 2024, 11:24 PM
erj closed D41326: iflib: Add sysctl to request extra MSIX vectors on driver load.
Apr 18 2024, 11:24 PM

Apr 12 2024

erj accepted D44620: iflib: Fix compiler warnings.
Apr 12 2024, 8:07 PM

Feb 23 2024

erj committed rGb33556f035b4: irdma(4): Upgrade to 1.2.36-k (authored by bartosz.sobczak_intel.com).
irdma(4): Upgrade to 1.2.36-k
Feb 23 2024, 10:27 PM

Feb 21 2024

erj added a comment to D41326: iflib: Add sysctl to request extra MSIX vectors on driver load.

@gallatin Do you see the Stack tab?

Feb 21 2024, 6:43 PM
erj committed rGa4510dafa804: irdma(4): Upgrade to 1.2.36-k (authored by bartosz.sobczak_intel.com).
irdma(4): Upgrade to 1.2.36-k
Feb 21 2024, 6:02 AM
erj committed rG43b03b8895ad: irdma(4): Upgrade to 1.2.36-k (authored by bartosz.sobczak_intel.com).
irdma(4): Upgrade to 1.2.36-k
Feb 21 2024, 5:47 AM
erj added a comment to D39930: iflib: Add subinterface interrupt allocation function.

@erj can you post the draft driver update, I'd like to see how it intends to use this patch stack before commentary

Feb 21 2024, 5:36 AM
erj added reviewers for D44004: ice(4): Update to 1.39.13-k: Intel Networking, anzhu_netapp.com.
Feb 21 2024, 5:30 AM
erj closed D43567: irdma(4): upgrade to 1.2.36-k.

Committed in rG5b5f7d0e77a9eee73eb5d596f43aef4e1a3674d8.

Feb 21 2024, 5:29 AM
erj requested review of D44004: ice(4): Update to 1.39.13-k.
Feb 21 2024, 5:27 AM
erj requested review of D44003: ice(4): Update copyright year to 2024.
Feb 21 2024, 5:27 AM
erj updated the diff for D39930: iflib: Add subinterface interrupt allocation function.

Update value used for IFLIB_FEATURE_SUB_INTERFACES

Feb 21 2024, 5:26 AM
erj updated the diff for D39930: iflib: Add subinterface interrupt allocation function.

Rebase on latest main; remove whitespace error

Feb 21 2024, 5:23 AM
erj updated the diff for D41326: iflib: Add sysctl to request extra MSIX vectors on driver load.

Rebase on latest main

Feb 21 2024, 5:20 AM
erj committed rG768329961dc0: ice_ddp: Update package to 1.3.36.0 (authored by erj).
ice_ddp: Update package to 1.3.36.0
Feb 21 2024, 5:15 AM

Feb 16 2024

erj committed rG5b5f7d0e77a9: irdma(4): Upgrade to 1.2.36-k (authored by bartosz.sobczak_intel.com).
irdma(4): Upgrade to 1.2.36-k
Feb 16 2024, 10:04 PM
erj accepted D43567: irdma(4): upgrade to 1.2.36-k.
Feb 16 2024, 10:02 PM

Feb 7 2024

erj added a comment to D43567: irdma(4): upgrade to 1.2.36-k.

@bartosz.sobczak_intel.com Could you re-upload this patch with all of the diff context?

Feb 7 2024, 3:50 PM

Feb 6 2024

erj committed rG8e1f58caf79b: ofed: fix warnings during libibverbs compilation (authored by bartosz.sobczak_intel.com).
ofed: fix warnings during libibverbs compilation
Feb 6 2024, 2:59 AM
erj closed D43491: ofed: fix warnings during libibverbs compilation .
Feb 6 2024, 2:59 AM
erj accepted D43491: ofed: fix warnings during libibverbs compilation .
Feb 6 2024, 2:57 AM

Dec 19 2023

erj added a comment to D43093: iavf(4): Improve man page.

I can't find ice(4). Where is it?

$ uname -a
FreeBSD vm-current 15.0-CURRENT FreeBSD 15.0-CURRENT #18 main-n266137-ede5d4ff5b39: Thu Oct 26 21:44:36 CEST 2023     root@vm-current:/usr/obj/usr/src/amd64.amd64/sys/GENERIC amd64
$ man 4 ice
No manual entry for ice
Dec 19 2023, 9:40 PM
erj added a reviewer for D43093: iavf(4): Improve man page: docs.
Dec 19 2023, 1:33 AM
erj added a reviewer for D43093: iavf(4): Improve man page: Intel Networking.
Dec 19 2023, 1:31 AM
erj requested review of D43093: iavf(4): Improve man page.
Dec 19 2023, 1:30 AM

Dec 8 2023

erj added inline comments to D42792: LinuxKPI: Remove sys/rman.h include from LKPI headers..
Dec 8 2023, 5:18 PM

Nov 30 2023

erj accepted D42832: EN for OpenZFS data corruption issue.
Nov 30 2023, 4:45 PM
erj added inline comments to D42832: EN for OpenZFS data corruption issue.
Nov 30 2023, 12:04 AM

Nov 29 2023

erj added inline comments to D42832: EN for OpenZFS data corruption issue.
Nov 29 2023, 9:37 PM

Sep 28 2023

erj committed rG243853dab752: irdma(4): remove artificial completion generator (authored by bartosz.sobczak_intel.com).
irdma(4): remove artificial completion generator
Sep 28 2023, 10:18 PM
erj committed rGd4a087dcba62: irdma(4): use related vnet for searching netdev (authored by bartosz.sobczak_intel.com).
irdma(4): use related vnet for searching netdev
Sep 28 2023, 10:17 PM
erj committed rGafade1da188e: ice(4): Update to 1.38.16-k (authored by erj).
ice(4): Update to 1.38.16-k
Sep 28 2023, 10:17 PM
erj committed rGdea589710881: ice_ddp: Update to 1.3.35.0 (authored by erj).
ice_ddp: Update to 1.3.35.0
Sep 28 2023, 10:17 PM

Sep 22 2023

erj committed rG8ac750e095a3: irdma(4): remove artificial completion generator (authored by bartosz.sobczak_intel.com).
irdma(4): remove artificial completion generator
Sep 22 2023, 9:58 PM
erj committed rGe3b352597e4b: irdma(4): use related vnet for searching netdev (authored by bartosz.sobczak_intel.com).
irdma(4): use related vnet for searching netdev
Sep 22 2023, 9:58 PM
erj committed rG1002fd41e1b9: ice(4): Match irdma interface changes (authored by bartosz.sobczak_intel.com).
ice(4): Match irdma interface changes
Sep 22 2023, 9:58 PM
erj committed rGf5f2cc9ee688: irdma(4): upgrade to 1.2.17-k (authored by bartosz.sobczak_intel.com).
irdma(4): upgrade to 1.2.17-k
Sep 22 2023, 9:58 PM
erj committed rGdfdf0d7cb41d: irdma(4): Upgrade the driver to 1.1.11-k (authored by bartosz.sobczak_intel.com).
irdma(4): Upgrade the driver to 1.1.11-k
Sep 22 2023, 9:58 PM
Herald added a reviewer for D30889: ice(4): Add RDMA Client Interface: andrew.
Sep 22 2023, 9:06 PM
erj committed rG4e80493a33fe: irdma(4): remove artificial completion generator (authored by bartosz.sobczak_intel.com).
irdma(4): remove artificial completion generator
Sep 22 2023, 8:49 PM
erj committed rGcc1abdc6ab34: irdma(4): use related vnet for searching netdev (authored by bartosz.sobczak_intel.com).
irdma(4): use related vnet for searching netdev
Sep 22 2023, 8:49 PM
erj committed rG6a196646cd15: ice(4): Update to 1.38.16-k (authored by erj).
ice(4): Update to 1.38.16-k
Sep 22 2023, 8:49 PM
erj committed rG65d0d7807328: ice_ddp: Update to 1.3.35.0 (authored by erj).
ice_ddp: Update to 1.3.35.0
Sep 22 2023, 8:48 PM

Sep 13 2023

erj closed D41655: ice(4): Update to 1.38.16-k.

Committed in rG9c30461dd25bac49045acbeac10e00b6cc13d2bc.

Sep 13 2023, 10:52 PM
erj committed rG9c30461dd25b: ice(4): Update to 1.38.16-k (authored by erj).
ice(4): Update to 1.38.16-k
Sep 13 2023, 10:27 PM
erj committed rGffafa6a4d157: irdma(4): remove artificial completion generator (authored by bartosz.sobczak_intel.com).
irdma(4): remove artificial completion generator
Sep 13 2023, 10:18 PM
erj committed rGbc3a013ccd23: irdma(4): use related vnet for searching netdev (authored by bartosz.sobczak_intel.com).
irdma(4): use related vnet for searching netdev
Sep 13 2023, 10:18 PM
erj closed D41593: irdma(4): remove artificial completion generator.
Sep 13 2023, 10:17 PM
erj closed D41592: irdma(4): use related vnet for searching netdev.
Sep 13 2023, 10:17 PM
erj added a comment to D41592: irdma(4): use related vnet for searching netdev.

I was preparing to push this yesterday, but I forgot to do the last step; I think @anzhu_netapp.com has a good point here because it'll reduce the number of VIMAGE blocks, but I probably would still push it and would just wait for a fix later.

Sep 13 2023, 9:26 PM

Sep 12 2023

erj accepted D41593: irdma(4): remove artificial completion generator.
Sep 12 2023, 9:27 PM
erj accepted D41592: irdma(4): use related vnet for searching netdev.
Sep 12 2023, 9:27 PM

Aug 31 2023

erj committed rGe04c4b4a369d: ice_ddp: Update to 1.3.35.0 (authored by erj).
ice_ddp: Update to 1.3.35.0
Aug 31 2023, 3:33 AM
erj requested review of D41655: ice(4): Update to 1.38.16-k.
Aug 31 2023, 3:31 AM
erj added a reviewer for D41655: ice(4): Update to 1.38.16-k: NetApp.
Aug 31 2023, 3:31 AM
erj updated the summary of D41655: ice(4): Update to 1.38.16-k.
Aug 31 2023, 3:31 AM

Aug 24 2023

erj committed rGdadd804ded83: iflib: Fix white space and reduce some line lengths (authored by erj).
iflib: Fix white space and reduce some line lengths
Aug 24 2023, 9:16 PM
erj committed rG3df6b1d39af5: iflib: Remove redundant variable (authored by erj).
iflib: Remove redundant variable
Aug 24 2023, 9:16 PM
erj committed rGcb5152f961bb: iflib: Fix panic during driver reload stress test (authored by przemyslawx.lewandowski_intel.com).
iflib: Fix panic during driver reload stress test
Aug 24 2023, 9:07 PM

Aug 23 2023

erj accepted D41547: iavf: remove compatibility code and address some warnings.
Aug 23 2023, 12:05 AM

Aug 22 2023

erj committed rGc7f73a1588dc: ofed: mask seq_num identifier to occupy only 3 bytes (authored by bartosz.sobczak_intel.com).
ofed: mask seq_num identifier to occupy only 3 bytes
Aug 22 2023, 11:11 PM
erj closed D41531: ofed: mask seq_num identifier to occupy only 3 bytes.
Aug 22 2023, 11:11 PM
erj accepted D41531: ofed: mask seq_num identifier to occupy only 3 bytes.
Aug 22 2023, 8:27 PM

Aug 18 2023

erj closed D41425: irdma(4): upgrade to 1.2.17-k.
Aug 18 2023, 6:41 PM
erj resigned from D18856: new driver: Tehuti networks tn40xx device driver..
Aug 18 2023, 6:40 PM
erj committed rG01fbb86991d5: irdma(4): upgrade to 1.2.17-k (authored by bartosz.sobczak_intel.com).
irdma(4): upgrade to 1.2.17-k
Aug 18 2023, 6:31 PM
erj accepted D41425: irdma(4): upgrade to 1.2.17-k.

I'll add an MFC period of 1 month as a reminder to check in about merging this update back to stable/13.

Aug 18 2023, 6:27 PM
erj added inline comments to D41425: irdma(4): upgrade to 1.2.17-k.
Aug 18 2023, 6:20 PM

Aug 16 2023

erj accepted D40860: ixl: fix multicast filters handling.
Aug 16 2023, 11:50 PM
erj added a comment to D41480: sys/net: only panic on unset tx_csum_flags if cap is disabled.

I'm going to agree with @kbowling here -- it looks like it's a driver bug / reasonable to fail if the driver sets IFCAP_TXCSUM without setting the CSUM_* bits that it supports for transmit checksumming.

Aug 16 2023, 11:49 PM
erj added a comment to D41425: irdma(4): upgrade to 1.2.17-k.

I wish this was uploaded with context, but I'm not an expert on RDMA so I'm not sure it would let me review this code better.

Aug 16 2023, 8:19 PM

Aug 14 2023

erj committed rG8e6654a6a551: ofed: fix roce gid insertion for vlan interfaces (authored by bartosz.sobczak_intel.com).
ofed: fix roce gid insertion for vlan interfaces
Aug 14 2023, 3:54 PM
erj closed D41426: ofed: fix roce gid insertion for vlan interfaces.
Aug 14 2023, 3:54 PM

Aug 11 2023

erj accepted D41426: ofed: fix roce gid insertion for vlan interfaces.
Aug 11 2023, 5:41 PM

Aug 10 2023

erj added a comment to D39930: iflib: Add subinterface interrupt allocation function.

Any new thoughts on this review or the previous one in the stack? I'd like to get these in for 14.0-RELEASE.

Aug 10 2023, 9:52 PM

Aug 7 2023

erj updated the diff for D41326: iflib: Add sysctl to request extra MSIX vectors on driver load.

Update variable names and sysctl help string

Aug 7 2023, 10:58 PM
erj committed rGd2dd3d5a989d: iflib: Remove redundant variable (authored by erj).
iflib: Remove redundant variable
Aug 7 2023, 10:48 PM
erj committed rG7f527d48124b: iflib: Fix white space and reduce some line lengths (authored by erj).
iflib: Fix white space and reduce some line lengths
Aug 7 2023, 10:47 PM
erj closed D41325: iflib: Remove redundant variable.
Aug 7 2023, 10:47 PM