Page MenuHomeFreeBSD

erj (Eric Joyner)
Network Software Engineer @ Intel

Projects

User Details

User Since
Jan 27 2015, 7:34 PM (300 w, 3 d)

Recent Activity

Sep 23 2020

erj committed rS366097: MFS r365983.
MFS r365983
Sep 23 2020, 11:57 PM

Sep 21 2020

erj committed rS365983: MFC r365774 and r365776.
MFC r365774 and r365776
Sep 21 2020, 10:53 PM

Sep 15 2020

erj committed rS365776: e1000: Properly retain promisc flag.
e1000: Properly retain promisc flag
Sep 15 2020, 9:07 PM
erj committed rS365774: igb(4): Fix define and includes with RSS option enabled.
igb(4): Fix define and includes with RSS option enabled
Sep 15 2020, 9:00 PM
erj closed D26322: ice(4): Update to 0.26.16.
Sep 15 2020, 8:56 PM

Sep 14 2020

erj committed rS365736: MFS r365647: ixl powerpc64 fixes.
MFS r365647: ixl powerpc64 fixes
Sep 14 2020, 11:49 PM
erj committed rS365733: ice(4): Add Intel 100GbE Ethernet Driver to kernel.
ice(4): Add Intel 100GbE Ethernet Driver to kernel
Sep 14 2020, 10:43 PM
erj committed rS365731: ice: MFC commits for update to 0.26.16.
ice: MFC commits for update to 0.26.16
Sep 14 2020, 9:33 PM

Sep 12 2020

erj committed rS365647: MFC r358698 and r364241.
MFC r358698 and r364241
Sep 12 2020, 12:22 AM

Sep 11 2020

erj accepted D26276: Add definitions for the Finisar 40GE LM4 transceiver.

Yeah, I think the rest of this looks good.

Sep 11 2020, 8:17 PM
erj added a comment to D26383: net/intel-em-kmod: Update to 7.7.8.
MAX_NETMAP_OSVERSION=   1199999  # Doesn't build w/NETMAP on 12

@erj, is it still true?

Sep 11 2020, 8:14 PM

Sep 10 2020

erj committed rS365617: ice(4): Update to 0.26.16.
ice(4): Update to 0.26.16
Sep 10 2020, 11:46 PM
erj updated the summary of D26322: ice(4): Update to 0.26.16.
Sep 10 2020, 11:43 PM
erj updated the summary of D26322: ice(4): Update to 0.26.16.
Sep 10 2020, 11:41 PM
erj updated the summary of D26322: ice(4): Update to 0.26.16.
Sep 10 2020, 11:40 PM
erj committed rS365612: MFC r361541, r362038, r364240.
MFC r361541, r362038, r364240
Sep 10 2020, 8:46 PM
erj updated the diff for D26322: ice(4): Update to 0.26.16.

Rebase with upstream with fixed package file.

Sep 10 2020, 5:21 AM
erj committed rS365550: ice_ddp: Fix 1.3.16.0 package.
ice_ddp: Fix 1.3.16.0 package
Sep 10 2020, 4:00 AM

Sep 9 2020

erj updated subscribers of D26383: net/intel-em-kmod: Update to 7.7.8.
Sep 9 2020, 9:48 PM
erj added a comment to D26383: net/intel-em-kmod: Update to 7.7.8.

poudriere testport log:

Sep 9 2020, 9:48 PM
erj added a comment to D26383: net/intel-em-kmod: Update to 7.7.8.

portlint -AC output:

WARN: Makefile: NETMAP_AUTO is listed in OPTIONS_DEFINE, but no PORT_OPTIONS:MNETMAP_AUTO appears in this slave Makefile.  Make sure it appears in the master's Makefile.
WARN: Makefile: NETMAP_ON is listed in OPTIONS_DEFINE, but no PORT_OPTIONS:MNETMAP_ON appears in this slave Makefile.  Make sure it appears in the master's Makefile.
WARN: Makefile: NETMAP_OFF is listed in OPTIONS_DEFINE, but no PORT_OPTIONS:MNETMAP_OFF appears in this slave Makefile.  Make sure it appears in the master's Makefile.
WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy.
WARN: Makefile: new ports should not set PORTREVISION.
WARN: Makefile: new ports should not set PORTEPOCH.
FATAL: Makefile: extra item "BROKEN_armv6" placed in the LICENSE section.
1 fatal error and 6 warnings found.
Sep 9 2020, 9:42 PM
erj requested review of D26383: net/intel-em-kmod: Update to 7.7.8.
Sep 9 2020, 9:40 PM

Sep 4 2020

erj committed rS365339: MFC r365231: ixl(4): Add support for X710-T*L devices.
MFC r365231: ixl(4): Add support for X710-T*L devices
Sep 4 2020, 9:21 PM
erj updated the diff for D26322: ice(4): Update to 0.26.16.

Commit package file updates since Phabricator cannot handle them properly

Sep 4 2020, 6:10 PM
erj updated the summary of D26322: ice(4): Update to 0.26.16.
Sep 4 2020, 5:41 PM
erj committed rS365332: ice_ddp: Update package file to 1.3.16.0.
ice_ddp: Update package file to 1.3.16.0
Sep 4 2020, 5:38 PM
erj added a comment to D26322: ice(4): Update to 0.26.16.

arc patch does not work with this revision, probably because of this Phabricator issue: https://secure.phabricator.com/T9069

Sep 4 2020, 5:25 PM
erj abandoned D26326: (TEST) update ice to 0.26.16.
Sep 4 2020, 5:08 PM
erj requested review of D26326: (TEST) update ice to 0.26.16.
Sep 4 2020, 5:06 PM
erj updated the diff for D26322: ice(4): Update to 0.26.16.

Remove ! characters from converted README

Sep 4 2020, 5:11 AM
erj updated the diff for D26322: ice(4): Update to 0.26.16.

Convert DDP README from utf-16le/dos to utf-8/unix

Sep 4 2020, 5:07 AM
erj added a comment to D26322: ice(4): Update to 0.26.16.

Why is sys/contrib/dev/ice/README a binary file?

Sep 4 2020, 4:59 AM
erj updated the diff for D26322: ice(4): Update to 0.26.16.

Fix some files.

Sep 4 2020, 4:48 AM
erj retitled D26322: ice(4): Update to 0.26.16 from ice: Update to 0.26.16 to ice(4): Update to 0.26.16.
Sep 4 2020, 4:36 AM
erj requested review of D26322: ice(4): Update to 0.26.16.
Sep 4 2020, 4:35 AM

Sep 1 2020

erj closed D25549: ixl(4): Add support for X710-T*L devices.
Sep 1 2020, 11:17 PM
erj committed rS365231: ixl(4): Add support for X710-T*L devices.
ixl(4): Add support for X710-T*L devices
Sep 1 2020, 11:17 PM
erj added a comment to D26276: Add definitions for the Finisar 40GE LM4 transceiver.

Hi, adding some Intel folks who have appeared on recent ixl(4) reviews/submissions.

I am attempting to upstream this patch from NetApp, who wrote it originally.
It seems that updates to these definitions usually come from upstream as part of
larger ixl driver updates, so forgive me if this is not the usual process.

Sep 1 2020, 8:57 PM

Aug 25 2020

erj added a comment to D25549: ixl(4): Add support for X710-T*L devices.

Any updates on this?

Aug 25 2020, 4:38 PM

Aug 22 2020

erj added a comment to D26118: sysutils/intel-nvmupdate: Update from 7.30 to 8.00.

New poudriere testport log:

Aug 22 2020, 2:40 AM
erj added a comment to D26118: sysutils/intel-nvmupdate: Update from 7.30 to 8.00.

New portlint output:

WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy.
0 fatal errors and 1 warning found.
Aug 22 2020, 2:34 AM
erj added a comment to D26118: sysutils/intel-nvmupdate: Update from 7.30 to 8.00.
In D26118#580232, @mat wrote:
In D26118#579726, @erj wrote:

Output from portlint -AC:

WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy.
WARN: Makefile: "IGNORE_DragonFly" has to appear earlier.
WARN: Makefile: "ONLY_FOR_ARCHS" has to appear earlier.
WARN: Makefile: "ONLY_FOR_ARCHS_REASON" has to appear earlier.
0 fatal errors and 4 warnings found.

Please do fix those warnings. The reference for how to write a Makefile is available there https://www.freebsd.org/doc/en/books/porters-handbook/porting-order.html

Aug 22 2020, 2:33 AM
erj updated the diff for D26118: sysutils/intel-nvmupdate: Update from 7.30 to 8.00.

Edit Makefile to make portlint happy

Aug 22 2020, 2:31 AM

Aug 21 2020

erj added a comment to D26106: net/intel-ixl-kmod: Update to 1.12.2.

I've attached the poudriere testport log:

Aug 21 2020, 7:45 PM

Aug 18 2020

erj added a comment to D26106: net/intel-ixl-kmod: Update to 1.12.2.

portlint -AC output:

WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy.
WARN: Makefile: unless this is a master port, PORTNAME has to be set by "=", not by "?=".
WARN: Makefile: unless this is a master port, PORTVERSION has to be set by "=", not by "?=".
WARN: Makefile: new ports should not set PORTREVISION.
WARN: Makefile: unless this is a master port, MAINTAINER has to be set by "=", not by "?=".
WARN: Makefile: unless this is a master port, COMMENT has to be set by "=", not by "?=".
WARN: Makefile: "ONLY_FOR_ARCHS" has to appear earlier.
WARN: Makefile: "ONLY_FOR_ARCHS_REASON" has to appear earlier.
0 fatal errors and 8 warnings found.
Aug 18 2020, 10:08 PM
erj requested review of D26118: sysutils/intel-nvmupdate: Update from 7.30 to 8.00.
Aug 18 2020, 9:51 PM
erj updated the summary of D26106: net/intel-ixl-kmod: Update to 1.12.2.
Aug 18 2020, 5:45 PM
erj requested review of D26106: net/intel-ixl-kmod: Update to 1.12.2.
Aug 18 2020, 5:44 PM

Aug 10 2020

erj accepted D25953: Remove redeclaration found by gcc build.

@jacob.e.keller_intel.com do you maybe have any thoughts on this, too?

Aug 10 2020, 10:29 PM
erj added a comment to D25953: Remove redeclaration found by gcc build.

The latter nvm related functions can be removed immediately; these have been removed in a newer version of the driver.

Aug 10 2020, 10:27 PM

Aug 4 2020

erj committed rS363876: MFC r361992: ixl(4): Add FW recovery mode support and other things.
MFC r361992: ixl(4): Add FW recovery mode support and other things
Aug 4 2020, 11:30 PM

Jul 30 2020

erj committed rS363712: MFC r358908: Enable ixl device on PowerPC64.
MFC r358908: Enable ixl device on PowerPC64
Jul 30 2020, 7:11 PM
erj committed rS363711: MFC r362063: em(4): Always reinit interface when adding/removing VLAN.
MFC r362063: em(4): Always reinit interface when adding/removing VLAN
Jul 30 2020, 6:31 PM

Jul 29 2020

erj added a reviewer for D25873: vxlan(4): Support for stateless NIC hardware offloads with VXLAN encapsulated traffic.: gallatin.
Jul 29 2020, 6:06 PM

Jun 26 2020

erj added a comment to D21122: Proof-of-concept hack: remove mp_ring from TX path.

Is someone else going to take over? Is this still something worthwhile to pursue? It seems like it based on the latest comments.

Jun 26 2020, 2:53 PM

Jun 25 2020

erj accepted D25408: dev.ixl.<N>.debug: mark as MPSAFE.

How did you find this? Do you have something automated that checks for this?

Jun 25 2020, 7:58 PM

Jun 12 2020

erj committed rS362080: MFC r361805: em(4): Add support for Comet Lake Mobile Platform.
MFC r361805: em(4): Add support for Comet Lake Mobile Platform
Jun 12 2020, 12:42 AM

Jun 11 2020

erj committed rS362063: em(4): Always reinit interface when adding/removing VLAN.
em(4): Always reinit interface when adding/removing VLAN
Jun 11 2020, 4:00 PM

Jun 10 2020

erj accepted D25222: Hard-code the ice_ddp firmware version..
Jun 10 2020, 11:59 PM
erj closed D24564: ixl(4): Add FW recovery mode support.

I committed this in rS361992.

Jun 10 2020, 4:10 PM

Jun 9 2020

erj committed rS361992: ixl(4): Add FW recovery mode support and other things.
ixl(4): Add FW recovery mode support and other things
Jun 9 2020, 10:43 PM
erj accepted D24564: ixl(4): Add FW recovery mode support.
Jun 9 2020, 10:38 PM
erj accepted D24564: ixl(4): Add FW recovery mode support.

This description looks better; thanks.

Jun 9 2020, 10:37 PM

Jun 4 2020

erj committed rS361805: em(4): Add support for Comet Lake Mobile Platform, update shared code.
em(4): Add support for Comet Lake Mobile Platform, update shared code
Jun 4 2020, 8:39 PM
erj closed D25035: em(4): Add support for Comet Lake Mobile Platform, update shared code.
Jun 4 2020, 8:39 PM
erj accepted D25035: em(4): Add support for Comet Lake Mobile Platform, update shared code.
Jun 4 2020, 8:36 PM
erj requested changes to D24564: ixl(4): Add FW recovery mode support.

Before I commit this, I'd like to have a better description of the changes that are going into this patch; I see there are changes around Recovery Mode support, but I'd like things like significant bugs or feature additions to be called out since this is pretty large.

Jun 4 2020, 8:31 PM

May 28 2020

erj planned changes to D21944: pci_iov: Stop preventing VFs from allocating extra bus numbers.
May 28 2020, 2:54 PM
erj closed D21959: introduce new 'ice' driver for Intel E800 Ethernet controllers.

This was committed in rS361541.

May 28 2020, 2:52 PM
erj accepted D25035: em(4): Add support for Comet Lake Mobile Platform, update shared code.
May 28 2020, 2:50 PM

May 26 2020

erj committed rS361541: ice(4): Introduce new driver for Intel E800 Ethernet controllers.
ice(4): Introduce new driver for Intel E800 Ethernet controllers
May 26 2020, 11:35 PM

May 22 2020

erj added a comment to D21959: introduce new 'ice' driver for Intel E800 Ethernet controllers.

Any other comments before I commit this?

May 22 2020, 8:25 PM

May 21 2020

erj added inline comments to D21959: introduce new 'ice' driver for Intel E800 Ethernet controllers.
May 21 2020, 8:32 PM
erj updated the diff for D21959: introduce new 'ice' driver for Intel E800 Ethernet controllers.
  • ice: Update MAINTAINERS file
  • ice: Remove strange characters in ice_ddp README
May 21 2020, 8:32 PM

May 14 2020

erj updated the diff for D21959: introduce new 'ice' driver for Intel E800 Ethernet controllers.
  • ice: Add entries to arm64 NOTES file
May 14 2020, 10:31 PM
erj updated the diff for D21959: introduce new 'ice' driver for Intel E800 Ethernet controllers.
  • ice: Add support for building on arm64 targets
May 14 2020, 10:23 PM
erj committed rS361063: Partially MFC r354344: iflib: properly release memory allocated for DMA.
Partially MFC r354344: iflib: properly release memory allocated for DMA
May 14 2020, 9:59 PM
erj committed rS361061: MFC r356310: iflib: Prevent watchdog from resetting idle queues.
MFC r356310: iflib: Prevent watchdog from resetting idle queues
May 14 2020, 9:37 PM
erj committed rS361058: MFC r354207: iflib: cleanup memory leaks on driver detach.
MFC r354207: iflib: cleanup memory leaks on driver detach
May 14 2020, 8:44 PM
erj committed rS361057: Partially MFC r353967: iflib: call ether_ifdetach and netmap_detach before stop.
Partially MFC r353967: iflib: call ether_ifdetach and netmap_detach before stop
May 14 2020, 8:23 PM
erj committed rS361055: MFC r360398: iflib: Stop interface before (un)registering VLAN.
MFC r360398: iflib: Stop interface before (un)registering VLAN
May 14 2020, 8:07 PM
erj committed rS361053: MFC r360398 and r360902.
MFC r360398 and r360902
May 14 2020, 7:57 PM

May 13 2020

erj added a comment to D21959: introduce new 'ice' driver for Intel E800 Ethernet controllers.

Can we enable this in an unsupported state for other 64-bit archs (arm64. ppc64)? Just would like to see the files entry correct for such usage.

May 13 2020, 10:34 PM

May 12 2020

erj added a comment to D21959: introduce new 'ice' driver for Intel E800 Ethernet controllers.

Can we enable this in an unsupported state for other 64-bit archs (arm64. ppc64)? Just would like to see the files entry correct for such usage.

May 12 2020, 6:49 PM

May 11 2020

erj updated the diff for D21959: introduce new 'ice' driver for Intel E800 Ethernet controllers.
  • ice-ddp: Use "SRCTOP" instead of "S" in module Makefile
May 11 2020, 11:03 PM
erj closed D24659: em/ix/ixv/ixl/iavf: Implement ifdi_needs_restart iflib method.
May 11 2020, 5:42 PM
erj committed rS360902: em/ix/ixv/ixl/iavf: Implement ifdi_needs_restart iflib method.
em/ix/ixv/ixl/iavf: Implement ifdi_needs_restart iflib method
May 11 2020, 5:42 PM

May 6 2020

erj updated the diff for D24659: em/ix/ixv/ixl/iavf: Implement ifdi_needs_restart iflib method.
  • Add em_if_needs_restart to igb's iflib device method list
May 6 2020, 6:16 PM

May 1 2020

erj added a reviewer for D24659: em/ix/ixv/ixl/iavf: Implement ifdi_needs_restart iflib method: Intel Networking.
May 1 2020, 10:45 PM
erj requested review of D24659: em/ix/ixv/ixl/iavf: Implement ifdi_needs_restart iflib method.
May 1 2020, 10:44 PM

Apr 27 2020

erj committed rS360398: iflib: Stop interface before (un)registering VLAN.
iflib: Stop interface before (un)registering VLAN
Apr 27 2020, 10:03 PM
erj closed D22086: iflib: Stop interface before (un)registering VLAN.
Apr 27 2020, 10:03 PM

Apr 8 2020

erj updated the diff for D22086: iflib: Stop interface before (un)registering VLAN.
  • Use iflib_init_locked()
Apr 8 2020, 12:22 AM
erj updated the diff for D22086: iflib: Stop interface before (un)registering VLAN.

Fix incorrect type usage

Apr 8 2020, 12:20 AM
erj updated the diff for D22086: iflib: Stop interface before (un)registering VLAN.
  • Follow Drew's suggestion and create an iflib method for this
Apr 8 2020, 12:19 AM

Mar 30 2020

erj added a comment to D24214: Avoid switching CPUs in epoch_drain_callbacks()..

This doesn't apply anymore, at least in part because of rS359438

Mar 30 2020, 8:51 PM

Mar 27 2020

erj added reviewers for D21959: introduce new 'ice' driver for Intel E800 Ethernet controllers: adrian, np.

I'll add @adrian to see if I'm using the firmware(9) functionality correctly enough; it's similar to how it's used in the Wi-Fi drivers I think. Add other reviewers if you think it might be helpful.

Mar 27 2020, 9:43 PM
erj updated the diff for D21959: introduce new 'ice' driver for Intel E800 Ethernet controllers.
  • Add ddp to kernel and build process
  • ice: Use fancier ice module Makefile from OOT component
  • Move ice files.amd64 entries to appropriate place
  • ice: Update description in NOTES
Mar 27 2020, 9:38 PM

Mar 25 2020

erj added reviewers for D24179: ixl: Permit 802.1ad frames to pass though the chip: krzysztof.galazka_intel.com, erj.
Mar 25 2020, 11:26 PM

Mar 20 2020

erj updated the diff for D21959: introduce new 'ice' driver for Intel E800 Ethernet controllers.
  • Remove extraneous line breaks from files.amd64
  • ice: Fix spelling mistake caught by arcanist
Mar 20 2020, 7:12 PM