erj (Eric Joyner)
User

Projects

User Details

User Since
Jan 27 2015, 7:34 PM (155 w, 3 h)

Recent Activity

Thu, Jan 11

erj committed rS327842: e1000: Fix typos in value written to register and a comment.
e1000: Fix typos in value written to register and a comment
Thu, Jan 11, 7:25 PM
erj accepted D13858: 1 << 31 redux.

The changes to the Intel ethernet drivers look fine to me.

Thu, Jan 11, 5:54 PM
erj added a comment to D13766: Introduce mallocarray() in the kernel.

Is this going to be MFC'd into stable/10 and/or stable/11?

Thu, Jan 11, 5:52 PM

Wed, Jan 10

erj added a comment to D13833: Make use of the newly introduce mallocarray(9)..
In D13833#290191, @erj wrote:

Why didn't they provide a calloc(), to follow the malloc()/free() pattern?

(It looks like this was introduced in rS327674)

Wed, Jan 10, 9:57 PM
erj accepted D13833: Make use of the newly introduce mallocarray(9)..
Wed, Jan 10, 9:54 PM
erj added a comment to D13833: Make use of the newly introduce mallocarray(9)..

Why didn't they just call it calloc()? To follow the malloc()/free() pattern?

Wed, Jan 10, 9:49 PM

Thu, Jan 4

erj added inline comments to D13660: e1000: Add support for Ice Lake and Cannon Lake.
Thu, Jan 4, 7:18 PM
erj added inline comments to D13660: e1000: Add support for Ice Lake and Cannon Lake.
Thu, Jan 4, 7:12 PM

Wed, Jan 3

erj abandoned D7802: ixl(4)/ixlv(4): MFC 1.4.27-k and fixes to stable/10.

@erj Do you want to abandon this review in light of your work on newer releases?

Wed, Jan 3, 9:22 PM · Intel Networking

Tue, Jan 2

erj added a comment to D13660: e1000: Add support for Ice Lake and Cannon Lake.

We don't have anything for the Ice Lake hardware, but the Cannon Lake stuff looks like it's good.

Tue, Jan 2, 8:39 PM

Thu, Dec 21

erj committed rS327051: ixgbe(4): Fix build error on i386..
ixgbe(4): Fix build error on i386.
Thu, Dec 21, 12:35 AM

Wed, Dec 20

erj committed rS327031: ixgbe(4): Convert driver to use iflib.
ixgbe(4): Convert driver to use iflib
Wed, Dec 20, 6:35 PM
erj closed D11727: ixgbe(4): Update HEAD to use iflib.

Committed in rS327031.

Wed, Dec 20, 6:30 PM

Dec 5 2017

erj committed rS326571: ifconfig(8): Display extended compliance code string for SFP transceivers.
ifconfig(8): Display extended compliance code string for SFP transceivers
Dec 5 2017, 6:42 PM
erj closed D13286: ifconfig(8): Display extended compliance code for SFP transceivers.
Dec 5 2017, 6:42 PM

Nov 28 2017

erj updated the summary of D13286: ifconfig(8): Display extended compliance code for SFP transceivers.
Nov 28 2017, 7:03 PM
erj added reviewers for D13286: ifconfig(8): Display extended compliance code for SFP transceivers: melifaro, hselasky.
Nov 28 2017, 6:39 PM
erj created D13286: ifconfig(8): Display extended compliance code for SFP transceivers.
Nov 28 2017, 6:38 PM

Oct 17 2017

erj added a comment to D5214: convert ixl to iflib.

I'm working on this on a github branch here:

Oct 17 2017, 9:05 PM

Sep 23 2017

erj accepted D12450: ixl: Fix mbuf hash type settings..
Sep 23 2017, 6:13 PM

Aug 24 2017

erj committed rS322865: ixv(4): Add more robust mailbox API negotiation.
ixv(4): Add more robust mailbox API negotiation
Aug 24 2017, 10:56 PM
erj removed a watcher for Intel Networking: jacob.e.keller_intel.com.
Aug 24 2017, 10:48 PM
erj added a member for Intel Networking: jacob.e.keller_intel.com.
Aug 24 2017, 10:48 PM
erj requested changes to D12040: direct vlan handling in ixgbe.

I guess formally recognize the current state the patch is in.

Aug 24 2017, 10:47 PM
erj added a comment to D12101: swfw_sync DELAY -> sleep conversion.

The busy waiting would cause 10% CPU usage on my system when no cable connected to em0 (traced to em_if_update_admin_status).
This patch also fixes this. I can no longer detect any unusual CPU usage.

Getting a lot of witness output. Like a few per second or so.

Aug 24 2017, 6:08 PM · network

Aug 22 2017

erj added a comment to D12101: swfw_sync DELAY -> sleep conversion.
In D12101#251141, @erj wrote:

Can we also get a description of what this fixes, for future reference?

Two problems:

  • As we've discussed at length elsewhere, Intel drivers will busy wait for arbitrary lengths of time with a default mutex held when waiting for the firmware to release a resource.
  • There is a lot of mostly duplicated code with tiny (dubious) variations.
Aug 22 2017, 8:16 PM · network
erj added a comment to D12101: swfw_sync DELAY -> sleep conversion.

Can we also get a description of what this fixes, for future reference?

Aug 22 2017, 5:09 PM · network

Aug 11 2017

erj added a comment to D11969: refactoring in support of *future* change to cope with slow configuration path on INTC and BRCM drivers.

Can you remind me what lock is held?

Aug 11 2017, 3:58 PM

Aug 7 2017

erj added a comment to D11378: iWARP driver for Intel X722 Adapter - initial commit.

@erj are you going to commit this once you've made the IXL updates required for it to function?

Aug 7 2017, 8:33 PM

Jul 31 2017

erj committed rS321802: Add myself to calendar.freebsd.
Add myself to calendar.freebsd
Jul 31 2017, 5:58 PM

Jul 27 2017

erj added a comment to D11378: iWARP driver for Intel X722 Adapter - initial commit.

I don't think these are very significant, but I get the following warnings during a build:

/home/sbruno/bsd/fbsd_head/sys/modules/ixl/iw_ixl/../../../dev/ixl/iwarp/iw_ixl_utils.c:943:46: warning: taking address of packed member 'ip6_dst' of class or structure 'ip6_hdr' may result in an unaligned pointer value [-Waddress-of-packed-member]
                i40iw_copy_ip_ntohl(loc_addr, (__be32 *) & ip6h->ip6_dst);
                                                           ^~~~~~~~~~~~~
/home/sbruno/bsd/fbsd_head/sys/modules/ixl/iw_ixl/../../../dev/ixl/iwarp/iw_ixl_utils.c:944:46: warning: taking address of packed member 'ip6_src' of class or structure 'ip6_hdr' may result in an unaligned pointer value [-Waddress-of-packed-member]
                i40iw_copy_ip_ntohl(rem_addr, (__be32 *) & ip6h->ip6_src);
                                                           ^~~~~~~~~~~~~
/home/sbruno/bsd/fbsd_head/sys/modules/ixl/iw_ixl/../../../dev/ixl/iwarp/iw_ixl_cm.c:488:36: warning: taking address of packed member 'ip6_src' of class or structure 'ip6_hdr' may result in an unaligned pointer value [-Waddress-of-packed-member]
                i40iw_copy_ip_htonl((__be32 *) & ip6h->ip6_src,
                                                 ^~~~~~~~~~~~~
/home/sbruno/bsd/fbsd_head/sys/modules/ixl/iw_ixl/../../../dev/ixl/iwarp/iw_ixl_cm.c:490:36: warning: taking address of packed member 'ip6_dst' of class or structure 'ip6_hdr' may result in an unaligned pointer value [-Waddress-of-packed-member]
                i40iw_copy_ip_htonl((__be32 *) & ip6h->ip6_dst,
                                                 ^~~~~~~~~~~~~
/home/sbruno/bsd/fbsd_head/sys/modules/ixl/iw_ixl/../../../dev/ixl/iwarp/iw_ixl_cm.c:3046:22: warning: taking address of packed member 'ip6_dst' of class or structure 'ip6_hdr' may result in an unaligned pointer value [-Waddress-of-packed-member]
                                    (__be32 *) & ip6h->ip6_dst);
                                                 ^~~~~~~~~~~~~
/home/sbruno/bsd/fbsd_head/sys/modules/ixl/iw_ixl/../../../dev/ixl/iwarp/iw_ixl_cm.c:3048:22: warning: taking address of packed member 'ip6_src' of class or structure 'ip6_hdr' may result in an unaligned pointer value [-Waddress-of-packed-member]
                                    (__be32 *) & ip6h->ip6_src);

Indeed, I don't find it too significant. I guess this is just a performance issue, which is insignificant given the amount of times this operation is done. And what is more important, this is related to the path which would be exercised only when using ipv6. The ipv6 is currently not supported, and there are some changes to the OFED going to be needed to make it work.
I may probably get rid of these warnings if it was really needed.

Jul 27 2017, 10:04 PM
erj added a comment to D11378: iWARP driver for Intel X722 Adapter - initial commit.

@sbruno - I think Bartosz needed an update to the in-kernel ixl(4) for this to work properly.

Jul 27 2017, 10:02 PM
erj accepted D11724: Drop ixl rx lock during TCP LRO.
Jul 27 2017, 9:45 PM · Intel Networking

Jul 24 2017

erj planned changes to D5214: convert ixl to iflib.
Jul 24 2017, 5:25 PM

Jul 13 2017

erj committed rS320972: ixl(4)/ixlv(4): Stop leaking every busdma entry in receive path.
ixl(4)/ixlv(4): Stop leaking every busdma entry in receive path
Jul 13 2017, 10:12 PM
erj accepted D10385: Remove many write-only variables from kernel.

With the answer from @sbruno, I approve of the change to em(4).

Jul 13 2017, 8:45 PM
erj requested changes to D11058: ixgbe(4): Update 11-STABLE to 3.2.12-k.

This should be abandoned, right?

Jul 13 2017, 8:43 PM
erj requested changes to D8532: ixgbe(4) Update driver API.

This probably needs to be regenerated right? Or is it going to be dropped due to the upcoming conversion to iflib?

Jul 13 2017, 8:42 PM
erj accepted D11414: ixl: gcc build errors.

There's still only one entry before the patch. But this looks more correct.

Jul 13 2017, 8:40 PM

Jul 12 2017

erj requested changes to D11414: ixl: gcc build errors.

@rlibby , after reading the linked bug report, I think it would be a good idea to go the extern route. Could you regenerate the patch and define ixl_bcast_addr and ixl_fc_string in ixl_pf_main.c? (The latter would only ever get used in the PF driver; only the PF driver uses the former). Or just commit everything but the changes to those two, and I could make those changes.

Jul 12 2017, 10:36 PM
erj added a comment to D11414: ixl: gcc build errors.

Is gcc requiring the additional const keywords?

Jul 12 2017, 6:45 PM

Jul 11 2017

erj committed rS320897: MFC r316541, r316544, and r320688 from HEAD to stable/11..
MFC r316541, r316544, and r320688 from HEAD to stable/11.
Jul 11 2017, 9:25 PM

Jul 8 2017

erj committed rS320688: ixgbe(4): Update HEAD (p3) to 3.2.12-k.
ixgbe(4): Update HEAD (p3) to 3.2.12-k
Jul 8 2017, 1:44 AM

Jul 5 2017

erj accepted D11232: ixgbe(4): Update HEAD (p3) to 3.2.12-k.
Jul 5 2017, 5:28 PM

Jun 27 2017

erj added a comment to D11378: iWARP driver for Intel X722 Adapter - initial commit.

I should add that we're going to update the ixl(4) driver soon because as @bartosz.sobczak_intel.com mentioned, it will fix a crash.

Jun 27 2017, 4:49 PM
erj added a reviewer for D11378: iWARP driver for Intel X722 Adapter - initial commit: np.
Jun 27 2017, 4:47 PM

Jun 21 2017

erj added inline comments to D10681: bnxt: Enable HW LRO and Fix out-of-order updates to rxd's completely..
Jun 21 2017, 12:28 AM

Jun 10 2017

erj committed rS319797: ixl(4)/ixlv(4): Fix some busdma tags and improper map NULL..
ixl(4)/ixlv(4): Fix some busdma tags and improper map NULL.
Jun 10 2017, 6:56 PM

May 16 2017

erj committed rS318358: MFC r318147: Add several new media types to if_media.h.
MFC r318147: Add several new media types to if_media.h
May 16 2017, 5:51 PM
erj committed rS318357: MFC r313497: ixl(4): Update to 1.7.12-k..
MFC r313497: ixl(4): Update to 1.7.12-k.
May 16 2017, 5:49 PM

May 15 2017

erj accepted D10741: e1000api: misleading-indentation.
May 15 2017, 4:33 PM

May 10 2017

erj committed rS318147: Add several new media types to if_media.h.
Add several new media types to if_media.h
May 10 2017, 6:34 PM
erj closed D10425: net: Add new 10G and 25G media types to if_media.h by committing rS318147: Add several new media types to if_media.h.
May 10 2017, 6:34 PM · network
erj added a comment to D10425: net: Add new 10G and 25G media types to if_media.h.

I've decided against bumping the FreeBSD version number -- there aren't very many defines added here, so adding #ifdef's isn't too big of a deal.

May 10 2017, 6:15 PM · network

May 9 2017

erj committed rS317995: ixv(4): Fix more tinderbox builds by adding missing declarations..
ixv(4): Fix more tinderbox builds by adding missing declarations.
May 9 2017, 12:51 AM

May 2 2017

erj committed rS317711: ixgbe(4): Fix build issue when compiling with netmap enabled.
ixgbe(4): Fix build issue when compiling with netmap enabled
May 2 2017, 10:57 PM

Apr 27 2017

erj updated the diff for D5214: convert ixl to iflib.

Remove ixgbe updates.

Apr 27 2017, 11:27 PM
erj updated the diff for D5214: convert ixl to iflib.
  • Add NOINTEL config file for testing
  • iflib: Update with style(9) fixes.
  • ixl(4): Begin process of converting ixl(4) to use iflib.
  • ixl: Copy over final bits of D5214 diff, possibly break some stuff.
  • ixl: Add more files.
  • ixl(4): Fix a lot of compile errors
  • ixl: ixl pf driver seems to compile ok now
  • Mostly compiles; start to remove legacy code...
  • ixl(4): Driver is iflib-only; compiles but causes kernel panic at attach.
  • ixl(4): PF driver compiles and ping works.
  • ixl(4): Remove comments; make queue interrupts RX-caused only
  • ixl(4): Edit comments
  • ixl: Get rid of files accidentally re-added during rebase.
  • ixl: Fix compile error
  • ixlv: Start converting driver
  • ixl: Update to 1.7.12; fix compile.
  • ixl: Change name to 700 series from just 7
  • ixlv: Convert more of driver
  • ixlv: VF driver still not fully converted, but now compiling
  • ixl: Bug fixes; label formatting in iflib
  • ixl: Fix bug where tx would stop working after ifconfig down && up
  • ixl: Random changes
  • ixl: Somehow fixed weird TXQ 0 bug supposedly fixed a couple commits ago
  • ixl: Change TODO comment from question to must-do
  • ixl: Start changes to support HW TX interrupts in iflib (like in legacy driver)
  • ixl: Fixes to get ixl building again, after iflib update.
  • ixl: Remove various comments and printfs
  • ixl: Updates.
  • ixl: Update reset handling; make some iflib functions non-static.
Apr 27 2017, 11:25 PM

Apr 19 2017

erj added a comment to D10425: net: Add new 10G and 25G media types to if_media.h.

I kind of want to bump __FreeBSD_version to make it easier for our drivers to see if there's support for these new media types.

Apr 19 2017, 5:52 PM · network
erj created D10425: net: Add new 10G and 25G media types to if_media.h.
Apr 19 2017, 12:18 AM · network

Apr 13 2017

erj added a comment to D10385: Remove many write-only variables from kernel.

@sbruno is it ok to remove "first" in igb_txrx.c? It looks like it might be a leftover from the pre-iflib converted version of the driver, but I don't know if it was intended to be used for something in the current version.

Apr 13 2017, 4:49 PM

Mar 24 2017

erj committed rS315916: ixgbe(4): Re-add mutex lock call that was dropped in a previous commit..
ixgbe(4): Re-add mutex lock call that was dropped in a previous commit.
Mar 24 2017, 6:29 PM

Mar 17 2017

erj committed rS315463: ixgbe(4): Fix build breakage when only compiling ix(4).
ixgbe(4): Fix build breakage when only compiling ix(4)
Mar 17 2017, 9:24 PM
erj closed D9310: ixgbe(4): Update to 3.2.11-k by committing rS315333: ixgbe(4): Update to 3.2.11-k.
Mar 17 2017, 12:48 PM · Intel Networking
erj committed rS315333: ixgbe(4): Update to 3.2.11-k.
ixgbe(4): Update to 3.2.11-k
Mar 17 2017, 12:48 PM

Mar 16 2017

erj committed rS315434: ixgbe(4): Fix VF build failure on i386 caused by r315333.
ixgbe(4): Fix VF build failure on i386 caused by r315333
Mar 16 2017, 11:19 PM

Mar 15 2017

erj updated the summary of D9310: ixgbe(4): Update to 3.2.11-k.
Mar 15 2017, 9:19 PM · Intel Networking

Mar 13 2017

erj planned changes to D7802: ixl(4)/ixlv(4): MFC 1.4.27-k and fixes to stable/10.

Better to MFC to 1.7.12 now...

Mar 13 2017, 10:09 PM · Intel Networking

Mar 8 2017

erj added a comment to D9851: ixgbe(4): Update HEAD to 3.2.12-k.
In D9851#204961, @smh wrote:

Massive amounts of changes in this so impossible to see if everything is good, however a number of style related bits highlighted, some of which are regressions.

Mar 8 2017, 10:06 PM

Feb 16 2017

erj committed rS313497: ixl(4): Update to 1.7.12-k.
ixl(4): Update to 1.7.12-k
Feb 16 2017, 12:28 AM
erj closed D9227: ixl(4): Update to 1.7.12-k.

Committed in rS313497.

Feb 16 2017, 12:24 AM
erj updated the diff for D5214: convert ixl to iflib.

ixl: Fix compile error

Feb 16 2017, 12:01 AM

Feb 15 2017

erj updated the diff for D5214: convert ixl to iflib.

Remove old D5213 files.

Feb 15 2017, 11:42 PM
erj updated the diff for D5214: convert ixl to iflib.

ixl: Get rid of files accidentally re-added during rebase.

Feb 15 2017, 11:38 PM
erj added a dependent revision for D5213: convert ixgbe to iflib: D5214: convert ixl to iflib.
Feb 15 2017, 10:54 PM
erj added a dependency for D5214: convert ixl to iflib: D5213: convert ixgbe to iflib.
Feb 15 2017, 10:54 PM
erj updated the diff for D5214: convert ixl to iflib.

Convert ixl-1.6.6-k (or at least the PF-non-IOV driver) to iflib

Feb 15 2017, 10:53 PM
erj commandeered D5214: convert ixl to iflib.
Feb 15 2017, 10:52 PM

Jan 19 2017

erj committed rS312427: e1000: Add support for Kaby Lake generation i219 (4) and i219 (5) devices.
e1000: Add support for Kaby Lake generation i219 (4) and i219 (5) devices
Jan 19 2017, 6:53 PM

Jan 18 2017

erj added a comment to D9227: ixl(4): Update to 1.7.12-k.

I'm going to wait for Jeff's team to give the okay before I commit it. I don't want to break more than I have to. :v

Jan 18 2017, 9:31 PM
erj updated the diff for D9227: ixl(4): Update to 1.7.12-k.
  • Add opt_ixl.h to ixlv Makefile for build
  • Add comment describing IXL_IW to GENERIC config
  • Default to disabling the iWARP client interface by setting tunable to 0
Jan 18 2017, 5:29 PM
erj added inline comments to D9227: ixl(4): Update to 1.7.12-k.
Jan 18 2017, 5:12 PM
erj updated D9227: ixl(4): Update to 1.7.12-k.
Jan 18 2017, 1:22 AM
erj updated D9227: ixl(4): Update to 1.7.12-k.
Jan 18 2017, 1:21 AM
erj updated D9227: ixl(4): Update to 1.7.12-k.
Jan 18 2017, 1:20 AM
erj retitled D9227: ixl(4): Update to 1.7.12-k from to ixl(4): Update to 1.7.12-k.
Jan 18 2017, 1:19 AM

Jan 13 2017

erj accepted D9164: Set ifm_cur to NULL in ifmedia_removeall..
Jan 13 2017, 7:23 PM

Jan 4 2017

erj added a comment to D5214: convert ixl to iflib.

I can attempt to update the iflib version of ixl with what he have internally, but would it be a better idea to base it off what's in the iflib version of ixgbe right now (D5213)?

Jan 4 2017, 6:23 PM
erj accepted D8544: Add accessor functions for the if_hw_tsomax* members of ifnet structure..

This matches the existing method for accessing fields in the rest of the if_t api, so I'm okay with it.

Jan 4 2017, 6:22 PM

Nov 7 2016

erj added a comment to D8399: igb driver to generate random MAC address for VF interface when none assigned.

I was late to commenting on it, but it looked fine to me. It looks like it's similar to the ixgbe code.

Nov 7 2016, 10:40 PM

Oct 19 2016

erj accepted D8282: Avoid some out-of-range DMA accesses with PCI intel ethernet adapters..
Oct 19 2016, 6:05 PM
erj requested changes to D8282: Avoid some out-of-range DMA accesses with PCI intel ethernet adapters..

I agree with @emaste's request for a comment.

Oct 19 2016, 5:37 PM

Sep 14 2016

erj added a comment to D7802: ixl(4)/ixlv(4): MFC 1.4.27-k and fixes to stable/10.

arc is failing to apply this, as it is trying to apply it to stable/10/sys/dev/ixl, but SHOULD be sys/dev/ixl. I had to apply it manually.

Sep 14 2016, 4:16 PM · Intel Networking
This is a test notification, sent at Wed, Sep 14, 9:06 AM.
Sep 14 2016, 4:06 PM

Sep 7 2016

erj added a comment to D7802: ixl(4)/ixlv(4): MFC 1.4.27-k and fixes to stable/10.

Which svn revisions is this going to MFC?

Did you have to change much from the original code for this MFC?

Sep 7 2016, 3:58 PM · Intel Networking
erj updated D7802: ixl(4)/ixlv(4): MFC 1.4.27-k and fixes to stable/10.
Sep 7 2016, 3:56 PM · Intel Networking

Sep 6 2016

erj updated the diff for D7802: ixl(4)/ixlv(4): MFC 1.4.27-k and fixes to stable/10.

Do arc command from repository root.

Sep 6 2016, 9:34 PM · Intel Networking
erj planned changes to D7802: ixl(4)/ixlv(4): MFC 1.4.27-k and fixes to stable/10.

I don't think the changelist looks right; this is supposed to apply to stable/10 and have mergeinfo, I think...

Sep 6 2016, 9:31 PM · Intel Networking
erj retitled D7802: ixl(4)/ixlv(4): MFC 1.4.27-k and fixes to stable/10 from to ixl(4)/ixlv(4): MFC 1.4.27-k and fixes to stable/10.
Sep 6 2016, 9:29 PM · Intel Networking

Sep 1 2016

erj committed rS305168: Fix linker warnings (errors on gcc) that resulted from r304510..
Fix linker warnings (errors on gcc) that resulted from r304510.
Sep 1 2016, 1:08 AM