Page MenuHomeFreeBSD

erj (Eric Joyner)
Network Software Engineer @ Intel

Projects

User Details

User Since
Jan 27 2015, 7:34 PM (283 w, 3 d)

Recent Activity

Fri, Jun 26

erj added a comment to D21122: Proof-of-concept hack: remove mp_ring from TX path.

Is someone else going to take over? Is this still something worthwhile to pursue? It seems like it based on the latest comments.

Fri, Jun 26, 2:53 PM

Thu, Jun 25

erj accepted D25408: dev.ixl.<N>.debug: mark as MPSAFE.

How did you find this? Do you have something automated that checks for this?

Thu, Jun 25, 7:58 PM

Fri, Jun 12

erj committed rS362080: MFC r361805: em(4): Add support for Comet Lake Mobile Platform.
MFC r361805: em(4): Add support for Comet Lake Mobile Platform
Fri, Jun 12, 12:42 AM

Thu, Jun 11

erj committed rS362063: em(4): Always reinit interface when adding/removing VLAN.
em(4): Always reinit interface when adding/removing VLAN
Thu, Jun 11, 4:00 PM

Wed, Jun 10

erj accepted D25222: Hard-code the ice_ddp firmware version..
Wed, Jun 10, 11:59 PM
erj closed D24564: ixl(4): Add FW recovery mode support.

I committed this in rS361992.

Wed, Jun 10, 4:10 PM

Tue, Jun 9

erj committed rS361992: ixl(4): Add FW recovery mode support and other things.
ixl(4): Add FW recovery mode support and other things
Tue, Jun 9, 10:43 PM
erj accepted D24564: ixl(4): Add FW recovery mode support.
Tue, Jun 9, 10:38 PM
erj accepted D24564: ixl(4): Add FW recovery mode support.

This description looks better; thanks.

Tue, Jun 9, 10:37 PM

Thu, Jun 4

erj committed rS361805: em(4): Add support for Comet Lake Mobile Platform, update shared code.
em(4): Add support for Comet Lake Mobile Platform, update shared code
Thu, Jun 4, 8:39 PM
erj closed D25035: em(4): Add support for Comet Lake Mobile Platform, update shared code.
Thu, Jun 4, 8:39 PM
erj accepted D25035: em(4): Add support for Comet Lake Mobile Platform, update shared code.
Thu, Jun 4, 8:36 PM
erj requested changes to D24564: ixl(4): Add FW recovery mode support.

Before I commit this, I'd like to have a better description of the changes that are going into this patch; I see there are changes around Recovery Mode support, but I'd like things like significant bugs or feature additions to be called out since this is pretty large.

Thu, Jun 4, 8:31 PM

May 28 2020

erj planned changes to D21944: pci_iov: Stop preventing VFs from allocating extra bus numbers.
May 28 2020, 2:54 PM
erj closed D21959: introduce new 'ice' driver for Intel E800 Ethernet controllers.

This was committed in rS361541.

May 28 2020, 2:52 PM
erj accepted D25035: em(4): Add support for Comet Lake Mobile Platform, update shared code.
May 28 2020, 2:50 PM

May 26 2020

erj committed rS361541: ice(4): Introduce new driver for Intel E800 Ethernet controllers.
ice(4): Introduce new driver for Intel E800 Ethernet controllers
May 26 2020, 11:35 PM

May 22 2020

erj added a comment to D21959: introduce new 'ice' driver for Intel E800 Ethernet controllers.

Any other comments before I commit this?

May 22 2020, 8:25 PM

May 21 2020

erj added inline comments to D21959: introduce new 'ice' driver for Intel E800 Ethernet controllers.
May 21 2020, 8:32 PM
erj updated the diff for D21959: introduce new 'ice' driver for Intel E800 Ethernet controllers.
  • ice: Update MAINTAINERS file
  • ice: Remove strange characters in ice_ddp README
May 21 2020, 8:32 PM

May 14 2020

erj updated the diff for D21959: introduce new 'ice' driver for Intel E800 Ethernet controllers.
  • ice: Add entries to arm64 NOTES file
May 14 2020, 10:31 PM
erj updated the diff for D21959: introduce new 'ice' driver for Intel E800 Ethernet controllers.
  • ice: Add support for building on arm64 targets
May 14 2020, 10:23 PM
erj committed rS361063: Partially MFC r354344: iflib: properly release memory allocated for DMA.
Partially MFC r354344: iflib: properly release memory allocated for DMA
May 14 2020, 9:59 PM
erj committed rS361061: MFC r356310: iflib: Prevent watchdog from resetting idle queues.
MFC r356310: iflib: Prevent watchdog from resetting idle queues
May 14 2020, 9:37 PM
erj committed rS361058: MFC r354207: iflib: cleanup memory leaks on driver detach.
MFC r354207: iflib: cleanup memory leaks on driver detach
May 14 2020, 8:44 PM
erj committed rS361057: Partially MFC r353967: iflib: call ether_ifdetach and netmap_detach before stop.
Partially MFC r353967: iflib: call ether_ifdetach and netmap_detach before stop
May 14 2020, 8:23 PM
erj committed rS361055: MFC r360398: iflib: Stop interface before (un)registering VLAN.
MFC r360398: iflib: Stop interface before (un)registering VLAN
May 14 2020, 8:07 PM
erj committed rS361053: MFC r360398 and r360902.
MFC r360398 and r360902
May 14 2020, 7:57 PM

May 13 2020

erj added a comment to D21959: introduce new 'ice' driver for Intel E800 Ethernet controllers.

Can we enable this in an unsupported state for other 64-bit archs (arm64. ppc64)? Just would like to see the files entry correct for such usage.

May 13 2020, 10:34 PM

May 12 2020

erj added a comment to D21959: introduce new 'ice' driver for Intel E800 Ethernet controllers.

Can we enable this in an unsupported state for other 64-bit archs (arm64. ppc64)? Just would like to see the files entry correct for such usage.

May 12 2020, 6:49 PM

May 11 2020

erj updated the diff for D21959: introduce new 'ice' driver for Intel E800 Ethernet controllers.
  • ice-ddp: Use "SRCTOP" instead of "S" in module Makefile
May 11 2020, 11:03 PM
erj closed D24659: em/ix/ixv/ixl/iavf: Implement ifdi_needs_restart iflib method.
May 11 2020, 5:42 PM
erj committed rS360902: em/ix/ixv/ixl/iavf: Implement ifdi_needs_restart iflib method.
em/ix/ixv/ixl/iavf: Implement ifdi_needs_restart iflib method
May 11 2020, 5:42 PM

May 6 2020

erj updated the diff for D24659: em/ix/ixv/ixl/iavf: Implement ifdi_needs_restart iflib method.
  • Add em_if_needs_restart to igb's iflib device method list
May 6 2020, 6:16 PM

May 1 2020

erj added a reviewer for D24659: em/ix/ixv/ixl/iavf: Implement ifdi_needs_restart iflib method: Intel Networking.
May 1 2020, 10:45 PM
erj requested review of D24659: em/ix/ixv/ixl/iavf: Implement ifdi_needs_restart iflib method.
May 1 2020, 10:44 PM

Apr 27 2020

erj committed rS360398: iflib: Stop interface before (un)registering VLAN.
iflib: Stop interface before (un)registering VLAN
Apr 27 2020, 10:03 PM
erj closed D22086: iflib: Stop interface before (un)registering VLAN.
Apr 27 2020, 10:03 PM

Apr 8 2020

erj updated the diff for D22086: iflib: Stop interface before (un)registering VLAN.
  • Use iflib_init_locked()
Apr 8 2020, 12:22 AM
erj updated the diff for D22086: iflib: Stop interface before (un)registering VLAN.

Fix incorrect type usage

Apr 8 2020, 12:20 AM
erj updated the diff for D22086: iflib: Stop interface before (un)registering VLAN.
  • Follow Drew's suggestion and create an iflib method for this
Apr 8 2020, 12:19 AM

Mar 30 2020

erj added a comment to D24214: Avoid switching CPUs in epoch_drain_callbacks()..

This doesn't apply anymore, at least in part because of rS359438

Mar 30 2020, 8:51 PM

Mar 27 2020

erj added reviewers for D21959: introduce new 'ice' driver for Intel E800 Ethernet controllers: adrian, np.

I'll add @adrian to see if I'm using the firmware(9) functionality correctly enough; it's similar to how it's used in the Wi-Fi drivers I think. Add other reviewers if you think it might be helpful.

Mar 27 2020, 9:43 PM
erj updated the diff for D21959: introduce new 'ice' driver for Intel E800 Ethernet controllers.
  • Add ddp to kernel and build process
  • ice: Use fancier ice module Makefile from OOT component
  • Move ice files.amd64 entries to appropriate place
  • ice: Update description in NOTES
Mar 27 2020, 9:38 PM

Mar 25 2020

erj added reviewers for D24179: ixl: Permit 802.1ad frames to pass though the chip: krzysztof.galazka_intel.com, erj.
Mar 25 2020, 11:26 PM

Mar 20 2020

erj updated the diff for D21959: introduce new 'ice' driver for Intel E800 Ethernet controllers.
  • Remove extraneous line breaks from files.amd64
  • ice: Fix spelling mistake caught by arcanist
Mar 20 2020, 7:12 PM
erj updated the diff for D21959: introduce new 'ice' driver for Intel E800 Ethernet controllers.
  • ice: Add missing includes to ice_iflib.h
  • ice: Correct filename used in Makefile
  • ice: Add files.amd64 entries for ice
  • ice: Add "device ice" as a kernel config option; add it to GENERIC
  • ice: Add ice module to sys/modules Makefile
  • ice: Remove SR-IOV files/option from Makefile
  • ice: Update ice driver code to a current version.
Mar 20 2020, 7:09 PM
erj commandeered D21959: introduce new 'ice' driver for Intel E800 Ethernet controllers.
Mar 20 2020, 7:08 PM

Mar 12 2020

erj accepted D23974: Enable ixl device on PowerPC64.

I'm generally okay with this, but with the caveat that we can't test to make sure any future changes we make will work on anything other than amd64.

Mar 12 2020, 12:23 AM · PowerPC

Mar 5 2020

erj requested changes to D23974: Enable ixl device on PowerPC64.

The driver is only intended to work on amd64; I can accept PowerPC64 but we don't want to support this driver on 32-bit architectures.

Mar 5 2020, 7:30 PM · PowerPC
erj accepted D23975: ixl: Add missing conversions from/to LE16.

Thanks for fixing the issue with IXL_DEBUG! The CPU_TO_LE16 changes look acceptable to me, but we can't guarantee we'll be vigilant about adding them to new code in the future since we only officially support amd64 for ixl.

Mar 5 2020, 7:18 PM · PowerPC

Mar 3 2020

erj added a comment to D23948: Remove refill budget from iflib.

So it sounds like you should keep the patch as-is, but then remove the limit sysctls and the arbitrary limit in a follow-on patch, possibly intended to be MFC'd in to 12.2?

Mar 3 2020, 8:03 PM
erj added a comment to D23943: Fix iflib freelist state corruption.

One driver that is subject to the above scenario is the ixl driver.

Mar 3 2020, 8:00 PM
erj accepted D23945: Fix iflib zero-length fragment handling.
Mar 3 2020, 7:59 PM
erj accepted D23947: Allow iflib drivers to specify the buffer size used for each receive queue.

I think this looks okay, but I don't think it'll apply to the Intel drivers, right?

Mar 3 2020, 7:59 PM
erj accepted D23951: Remove extraneous code from iflib.
Mar 3 2020, 7:45 PM

Feb 12 2020

erj added a comment to D23630: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N).

Is there a reason that these syctls would need "CTLFLAG_NEEDSGIANT", or does this patch default to that flag because it's a safe default if the contents of the sysctl are unknown? I'm aware of the previous review that added these flags, but I didn't get to look at it too closely.

Feb 12 2020, 2:18 AM

Jan 13 2020

erj added inline comments to D19433: [new driver] tn40xx(4): Tehuti networks tn40xx device driver..
Jan 13 2020, 7:23 PM

Jan 10 2020

erj committed rS356606: MFC r356309: ixl: prevent non-privileged access to NVM update interface.
MFC r356309: ixl: prevent non-privileged access to NVM update interface
Jan 10 2020, 6:32 PM
erj committed rS356605: MFC r356310: iflib: Prevent watchdog from resetting idle queues.
MFC r356310: iflib: Prevent watchdog from resetting idle queues
Jan 10 2020, 6:29 PM

Jan 3 2020

erj requested changes to D22214: factor out remove logic from if_delgroup and if_delgroups.

Can this get regenerated? It no longer applies cleanly.

Jan 3 2020, 5:53 PM
erj added a comment to D22245: route: remove extra reference on ifa in rtinit1..

It looks like this change was part of the recently committed D22912 / rS356107

Jan 3 2020, 5:46 PM

Jan 2 2020

erj closed D21712: iflib: Prevent watchdog from resetting idle queues.
Jan 2 2020, 11:35 PM
erj committed rS356310: iflib: Prevent watchdog from resetting idle queues.
iflib: Prevent watchdog from resetting idle queues
Jan 2 2020, 11:35 PM
erj accepted D21712: iflib: Prevent watchdog from resetting idle queues.
Jan 2 2020, 11:34 PM
erj committed rS356309: ixl: prevent non-privileged access to NVM update interface.
ixl: prevent non-privileged access to NVM update interface
Jan 2 2020, 11:25 PM
erj closed D22870: ixl: prevent non-privileged access to NVM update interface.
Jan 2 2020, 11:25 PM
erj accepted D22870: ixl: prevent non-privileged access to NVM update interface.
Jan 2 2020, 11:23 PM
erj committed rS356307: MFC r355055: Fix gcc build for bitstring_test by specifying "-fno-strict….
MFC r355055: Fix gcc build for bitstring_test by specifying "-fno-strict…
Jan 2 2020, 11:18 PM
erj committed rS356306: MFC r354977: bitstring: add functions to find contiguous set/unset bit sequences.
MFC r354977: bitstring: add functions to find contiguous set/unset bit sequences
Jan 2 2020, 11:16 PM
erj committed rS356304: MFC r354975: bitstring: exit early if _start is past size of the bitstring.
MFC r354975: bitstring: exit early if _start is past size of the bitstring
Jan 2 2020, 11:06 PM
erj committed rS356302: MFC isc_pause_frame field fixes to Intel ethernet drivers.
MFC isc_pause_frame field fixes to Intel ethernet drivers
Jan 2 2020, 10:57 PM
erj committed rS356299: MFC r354344: iflib: properly release memory allocated for DMA.
MFC r354344: iflib: properly release memory allocated for DMA
Jan 2 2020, 10:47 PM
erj committed rS356298: MFC r354207: iflib: cleanup memory leaks on driver detach.
MFC r354207: iflib: cleanup memory leaks on driver detach
Jan 2 2020, 10:44 PM
erj committed rS356297: MFC r353967: iflib: call ether_ifdetach and netmap_detach before stop.
MFC r353967: iflib: call ether_ifdetach and netmap_detach before stop
Jan 2 2020, 10:42 PM
erj committed rS356291: MFC r351153: net: Update SFF-8024 definitions and strings with values from rev….
MFC r351153: net: Update SFF-8024 definitions and strings with values from rev…
Jan 2 2020, 9:58 PM

Dec 19 2019

erj added a comment to D22870: ixl: prevent non-privileged access to NVM update interface.

IMO it makes slightly more sense to have the check in the ixl ioctl handler: it serves as a signal to anyone extending the ioctl handler that they should be careful, and doing so maintains the invariant that internal driver functions need not check for privileges. I am not the maintainer though so I don't insist on any particular approach.

Dec 19 2019, 4:44 AM

Dec 3 2019

erj accepted D22523: Avoid finding every bit transition in bit_ffs_area_at.
Dec 3 2019, 8:42 PM

Dec 2 2019

erj added a comment to D22523: Avoid finding every bit transition in bit_ffs_area_at.

Hmm. I think I understand the change.. but it seems less intuitive.

Do you have any example of how much this improves? I.e. a C program with a large enough test case to show measurable improvement?

Dec 2 2019, 9:26 PM

Nov 21 2019

erj committed rS354977: bitstring: add functions to find contiguous set/unset bit sequences.
bitstring: add functions to find contiguous set/unset bit sequences
Nov 21 2019, 7:58 PM
erj closed D22400: bitstring: add functions to find contiguous set/unset bit sequences.
Nov 21 2019, 7:58 PM
erj accepted D22400: bitstring: add functions to find contiguous set/unset bit sequences.
Nov 21 2019, 7:37 PM
erj committed rS354975: bitstring: exit early if _start is past size of the bitstring.
bitstring: exit early if _start is past size of the bitstring
Nov 21 2019, 7:36 PM
erj closed D22398: bitstring: exit early if _start is past size of the bitstring.
Nov 21 2019, 7:36 PM
erj accepted D22398: bitstring: exit early if _start is past size of the bitstring.
Nov 21 2019, 7:35 PM

Nov 5 2019

erj committed rS354345: net: add ETHER_IS_ZERO macro similar to ETHER_IS_BROADCAST.
net: add ETHER_IS_ZERO macro similar to ETHER_IS_BROADCAST
Nov 5 2019, 12:12 AM
erj closed D21240: net: add ETHER_IS_ZERO macro similar to ETHER_IS_BROADCAST.
Nov 5 2019, 12:12 AM
erj accepted D21240: net: add ETHER_IS_ZERO macro similar to ETHER_IS_BROADCAST.

Builds okay now.

Nov 5 2019, 12:09 AM

Nov 4 2019

erj committed rS354344: iflib: properly release memory allocated for DMA.
iflib: properly release memory allocated for DMA
Nov 4 2019, 11:07 PM
erj closed D22203: iflib: properly release memory allocated for DMA.
Nov 4 2019, 11:07 PM
erj accepted D22203: iflib: properly release memory allocated for DMA.
Nov 4 2019, 11:04 PM
erj closed D21239: net: prefer ETHER_ADDR_LEN over ETH_ADDR_LEN.
Nov 4 2019, 10:58 PM
erj committed rS354343: net: prefer ETHER_ADDR_LEN over ETH_ADDR_LEN.
net: prefer ETHER_ADDR_LEN over ETH_ADDR_LEN
Nov 4 2019, 10:58 PM
erj accepted D21239: net: prefer ETHER_ADDR_LEN over ETH_ADDR_LEN.
Nov 4 2019, 10:56 PM
erj updated the diff for D21239: net: prefer ETHER_ADDR_LEN over ETH_ADDR_LEN.

Don't remove the extra whitespace in if.c

Nov 4 2019, 10:54 PM
erj updated the diff for D21239: net: prefer ETHER_ADDR_LEN over ETH_ADDR_LEN.

Update patch to make it build on HEAD

Nov 4 2019, 10:05 PM
erj requested changes to D21240: net: add ETHER_IS_ZERO macro similar to ETHER_IS_BROADCAST.

I get a build error with this revision:

Nov 4 2019, 9:57 PM
erj accepted D21240: net: add ETHER_IS_ZERO macro similar to ETHER_IS_BROADCAST.
Nov 4 2019, 9:50 PM
erj added a reviewer for D21239: net: prefer ETHER_ADDR_LEN over ETH_ADDR_LEN: jpaetzel.

Adding @jpaetzel since he seemed to be the last person making updates to oce(4); is this change ok to make there? There's no functional change.

Nov 4 2019, 9:49 PM
erj added a reviewer for D21239: net: prefer ETHER_ADDR_LEN over ETH_ADDR_LEN: scottl.
Nov 4 2019, 9:48 PM