Digging through using git blame, it doesn't look like the cpu_id was ever even used in the first place...

FreeBSD 11 is EoL.

Is anyone else going to look at this? This does seem alright to me, though I don't know how to answer the autoneg_wait_to_complete question.

Checking internally, it looks like those variables can just be removed. I also don't see anything similar to the GLHMC_FCOEFMAX register in the hardware for the PE filters or contexts.

I'm going to go with just having all of the cpu_id code be axed. I added @krzysztof.galazka_intel.com to see if he has an opinion, but I can't recall or figure out what the cpu_id code is for. I guess it could've remained from an older version of the iflib api; I vaguely remember some softirq argument change where the cpu_id was removed.

Update with latest driver version's interface; now based on 1.34.2-k.

Fix spelling mistake caught by lint

Rebase on latest main; change version number to latest

If no one has any objections, then I'll update this patch with a new FreeBSD version number, upload that here, and commit it. Then, I can submit a follow-on ice(4) update that uses it.

Yeah, I don't think there's any hardware limitation that would prevent powerpc from working. We just can't test it or ensure that it works on those systems.

We're back, and I think I want to get this committed soon because we're about ready to start adding reviews for the ice(4) update that uses this, as well as upstreaming the FreeBSD RDMA driver. Maybe I'll have to worry about the DSCP changes after this patch.

Everyone here (at work) is mostly going to be on vacation for the next couple weeks, so we probably won't do much with this patch until people (and me) come back.

In D31485#756141, @kbowling wrote:

Either seems reasonable to me. I would bias toward including the if_pkt_info since it has fields for offload handling but I don't know much about other expected use cases, maybe @jhb has some thoughts from crypto and tcp offloads.

Bump __FreeBSD_version and define IFLIB_FEATURE_QUEUE_SELECT to that new version

Though, part of the problem with this patch is that I'm not entirely sure with what I want the parameters of ift_txq_select to be.

This has not been a great week for me in terms of writing correct commit messages. -_-

Rebase on main

Rebase on main

Rebase on main

I forgot to add the "Differential Revision" line to the commit R10:9cf1841c4aaf8fbab06132ab9f76094f34ad7c7b, so I'll manually close it.

• Rebase on main, add fix for a possible kernel panic on unload

Fix merge conflicts

Rebase on main

Rebase on main

• Rebase on main
• Fix compile errors

Rebase on main

Rebase on main

Fix spelling mistake

Make RXTX change and update commit message.