Page MenuHomeFreeBSD

erj (Eric Joyner)
Network Software Engineer @ Intel

Projects

User Details

User Since
Jan 27 2015, 7:34 PM (212 w, 3 d)

Recent Activity

Thu, Feb 21

erj accepted D19175: ix: Fix accessing wrong register.
Thu, Feb 21, 7:09 PM
erj accepted D19176: ix, ixv: Update link status with autonegotiated baudrate value.
Thu, Feb 21, 7:09 PM

Fri, Feb 15

erj committed rS344163: MFC r344132:.
MFC r344132:
Fri, Feb 15, 7:13 PM

Thu, Feb 14

erj committed rS344132: ixl: Fix panic caused by bug exposed by r344062.
ixl: Fix panic caused by bug exposed by r344062
Thu, Feb 14, 6:02 PM

Thu, Feb 7

erj added a comment to D18469: ix: Fix accessing wrong register, improve WoL support recognition ix, ixv: Update link status with autonegotiated baudrate value.

@piotr.pietruszewski_intel.com Are we going to abandon this for now?

Thu, Feb 7, 8:18 PM
erj accepted D19070: Fix em(4) tx interrupt routing.
Thu, Feb 7, 8:17 PM
erj added inline comments to D19108: Assorted fixes and cleanup for em(4).
Thu, Feb 7, 8:05 PM

Thu, Jan 31

erj committed rS343622: ix(4),ixv(4): Fix TSO offloads when TXCSUM is disabled.
ix(4),ixv(4): Fix TSO offloads when TXCSUM is disabled
Thu, Jan 31, 9:53 PM
erj closed D18470: ix(4),ixv(4): Fix TSO offloads when TXCSUM is disabled.
Thu, Jan 31, 9:53 PM
erj committed rS343621: ix(4): Run {mod,msf,mbx,fdir,phy}_task in if_update_admin_status.
ix(4): Run {mod,msf,mbx,fdir,phy}_task in if_update_admin_status
Thu, Jan 31, 9:44 PM
erj closed D18468: ix(4): Run {mod,msf,mbx,fdir,phy}_task in if_update_admin_status.
Thu, Jan 31, 9:44 PM
erj accepted D19041: Make iflib a loadable module..

Well, I would just have went with "PCI" but if you prefer to state all variants :)

Thu, Jan 31, 7:03 PM
erj accepted D18470: ix(4),ixv(4): Fix TSO offloads when TXCSUM is disabled.
Thu, Jan 31, 5:42 PM
erj added a comment to D19041: Make iflib a loadable module..

Would it be a good idea to group the iflib drivers together in the config files, so it's obvious there?

Thu, Jan 31, 12:09 AM

Tue, Jan 29

erj added a comment to D18402: netmap: ixgbe: add support for jumbo frames.

You're right. I realized that just now.

I guess I could try to modify iflib_netmap_txsync and iflib_netmap_rxsync.
This patch could still be useful for FreeBSD 11, where ixgbe does not use iflib (as far as I see from the code).

Tue, Jan 29, 6:29 PM
erj accepted D18984: ixl: remove unnecessary limitations related to netmap.

Having an invalid value for the head writeback value is problematic...I'll check out the PR.

Tue, Jan 29, 5:52 PM
erj added a comment to D18470: ix(4),ixv(4): Fix TSO offloads when TXCSUM is disabled.

@jeffrey.e.pieper_intel.com you should re-test this, now that Piotr has updated the patch.

Tue, Jan 29, 5:47 PM
erj added a comment to D18980: Stop iflib(4) from leaking MSI messages and along with drivers let it use the correct RIDs when releasing resources.

Ensure that iflib(4) and associated drivers pass correct RIDs to bus_release_resource(9) by obtaining the RIDs via rman_get_rid(9) on the corresponding resources instead of using the RIDs initially passed to bus_alloc_resource_any(9) as the latter function may change those RIDs. Solely bnxt(4) was using the correct RIDs by caching the ones returned by bus_alloc_resource_any(9).

Tue, Jan 29, 5:43 PM

Jan 24 2019

erj committed rS343372: ixl(4): Fix handling data passed with ioctl from NVM update tool.
ixl(4): Fix handling data passed with ioctl from NVM update tool
Jan 24 2019, 1:09 AM
erj closed D18817: ixl(4): Fix handling data passed with ioctl from NVM update tool.
Jan 24 2019, 1:09 AM
erj committed rS343369: intel iflib drivers: correct initialization of tx_cidx_processed.
intel iflib drivers: correct initialization of tx_cidx_processed
Jan 24 2019, 1:03 AM
erj closed D18545: intel: correct initialization of tx_cidx_processed.
Jan 24 2019, 1:03 AM
erj added inline comments to D18545: intel: correct initialization of tx_cidx_processed.
Jan 24 2019, 12:41 AM

Jan 18 2019

erj resigned from D13980: Fix ixl driver performance issue.
Jan 18 2019, 7:08 PM
erj added a comment to D18545: intel: correct initialization of tx_cidx_processed.

Should I be the one to commit this, then?

Jan 18 2019, 7:08 PM

Jan 11 2019

erj added a comment to D18817: ixl(4): Fix handling data passed with ioctl from NVM update tool.

Does anyone on this review know why this is necessary on 12.0+? I think we were supposed to be doing this in the first place, but I don't know why this stopped working.

Jan 11 2019, 6:49 PM

Dec 12 2018

erj added a comment to D18470: ix(4),ixv(4): Fix TSO offloads when TXCSUM is disabled.

The description should mention that this also affects/fixes ixv(4), too.

Dec 12 2018, 1:36 AM

Dec 6 2018

erj committed rS341636: MFC r340010.
MFC r340010
Dec 6 2018, 3:28 PM

Nov 8 2018

erj committed rS340263: MFC r340256: ixl/iavf(4): Fix TSO offloads when TXCSUM is disabled.
MFC r340256: ixl/iavf(4): Fix TSO offloads when TXCSUM is disabled
Nov 8 2018, 9:37 PM
erj committed rS340256: ixl/iavf(4): Fix TSO offloads when TXCSUM is disabled.
ixl/iavf(4): Fix TSO offloads when TXCSUM is disabled
Nov 8 2018, 7:10 PM
erj closed D17900: ixl/iavf: fix TSO offloads when TXCSUM is disabled.
Nov 8 2018, 7:10 PM
erj accepted D17900: ixl/iavf: fix TSO offloads when TXCSUM is disabled.

I'll commit this for Jake and try to get it into 12-RELEASE

Nov 8 2018, 6:53 PM

Nov 7 2018

erj added a comment to D17881: Fix rxcsum issue introduced in r338838.

@krzysztof.galazka_intel.com I think @shurd's version here is better in that it masks isc_capabilities before togging RXCSUM/RXCSUM_IPV6. Though I think if you had added that, they might be roughly similar.

Nov 7 2018, 10:16 PM

Nov 1 2018

erj committed rS340010: ixl/iavf(4): Update remaining references of "num_queues" to "num_rx_queues".
ixl/iavf(4): Update remaining references of "num_queues" to "num_rx_queues"
Nov 1 2018, 5:29 PM

Oct 23 2018

erj committed rS339662: Revert r339634..
Revert r339634.
Oct 23 2018, 5:06 PM
erj committed rS339634: iflib: drain enqueued tasks before detaching from taskqgroup.
iflib: drain enqueued tasks before detaching from taskqgroup
Oct 23 2018, 4:37 AM
erj closed D17404: iflib: drain enqueued tasks before detaching from taskqgroup.
Oct 23 2018, 4:37 AM

Oct 19 2018

erj accepted D17404: iflib: drain enqueued tasks before detaching from taskqgroup.

Looks like it does what it's supposed to.

Oct 19 2018, 4:50 PM

Oct 16 2018

erj added a comment to D17404: iflib: drain enqueued tasks before detaching from taskqgroup.

iflib_admin_intr_deferred() called with STATE_LOCK() in a few places.

I've moved STATE_UNLOCK before iflib_admin_intr_defereed call although releasing lock just to immediately grab it again makes me a bit uneasy. Maybe it would be better idea to use mtx_owned in iflib_in_detach to check if this lock is already aquired?

Oct 16 2018, 8:14 PM

Oct 15 2018

erj committed rS339362: iavf(4): Finish rename/rebrand internally.
iavf(4): Finish rename/rebrand internally
Oct 15 2018, 5:24 PM
erj closed D17544: iavf: Finish the rename/rebrand internally.
Oct 15 2018, 5:23 PM
erj added a comment to D17544: iavf: Finish the rename/rebrand internally.

Err, "arc patch" doesn't apply this cleanly to my svn tree -- it complains that it can't find the new files if_iavf.c, iavf_vc.c, and iavf.h to patch.

Oct 15 2018, 4:40 PM
erj added a comment to D17544: iavf: Finish the rename/rebrand internally.

@erj do you want to ask RE permission to commit this?

Oct 15 2018, 4:34 PM
erj accepted D17544: iavf: Finish the rename/rebrand internally.
Oct 15 2018, 4:29 PM

Oct 14 2018

erj committed rS339354: em/igb/ix(4): Port two Tx/Rx fixes made to ixl in r339338.
em/igb/ix(4): Port two Tx/Rx fixes made to ixl in r339338
Oct 14 2018, 5:09 AM

Oct 13 2018

erj accepted D17544: iavf: Finish the rename/rebrand internally.

My only nitpick is that ixlvc.c should probably be renamed to iavf_vc.c instead; it's supposed to contain the functions that communicate via the PF<->VF virtchannel.

Oct 13 2018, 7:58 PM

Oct 12 2018

erj abandoned D16428: iflib: Changes for ixlv(4) update.
Oct 12 2018, 10:59 PM · Intel Networking
erj committed rS339340: ixl/iavf: Update ixl(4) and iavf(4) [previously ixlv] man pages.
ixl/iavf: Update ixl(4) and iavf(4) [previously ixlv] man pages
Oct 12 2018, 10:58 PM
erj closed D15927: Update ixl(4) and ixlv(4) man pages.
Oct 12 2018, 10:58 PM
erj committed rS339338: ixl/iavf(4): Change ixlv to iavf and update it to use iflib(9).
ixl/iavf(4): Change ixlv to iavf and update it to use iflib(9)
Oct 12 2018, 10:41 PM
erj closed D16429: ixlv(4): Update to use iflib; change name to iavf(4).
Oct 12 2018, 10:41 PM · Intel Networking
erj removed a parent revision for D16429: ixlv(4): Update to use iflib; change name to iavf(4): D16428: iflib: Changes for ixlv(4) update.
Oct 12 2018, 5:28 PM · Intel Networking
erj removed a child revision for D16428: iflib: Changes for ixlv(4) update: D16429: ixlv(4): Update to use iflib; change name to iavf(4).
Oct 12 2018, 5:28 PM · Intel Networking

Oct 11 2018

erj added a comment to D16429: ixlv(4): Update to use iflib; change name to iavf(4).

Any last-minute assents or objections?

Oct 11 2018, 11:04 PM · Intel Networking
erj added a comment to D15927: Update ixl(4) and ixlv(4) man pages.

I'm going to try to get these committed, soon; I don't have any more planned changes.

Oct 11 2018, 10:40 PM

Oct 9 2018

erj added a comment to D17404: iflib: drain enqueued tasks before detaching from taskqgroup.

@krzysztof.galazka_intel.com , you need to re-upload this patch

Oct 9 2018, 6:20 PM

Oct 8 2018

erj added inline comments to D17443: net/intel-ix-kmod: New port for 10g Intel Ethernet Base Driver.
Oct 8 2018, 8:28 PM · Intel Networking
erj added a comment to D17473: fix PNP entries for if_ix and if_ixv.

I can't tell if this is right or not, but it looks like an ok change to me.

Oct 8 2018, 4:42 PM

Oct 5 2018

erj added a comment to D17404: iflib: drain enqueued tasks before detaching from taskqgroup.

Hrm, I don't think we can obtain CTX_LOCK() in those functions.

Oct 5 2018, 9:57 PM
erj added a comment to D17404: iflib: drain enqueued tasks before detaching from taskqgroup.

Wouldn't iflib_iov_intr_deferred() need it too?

Oct 5 2018, 9:38 PM
erj accepted D17442: Fix egregious magic number constants.

It's a reasonable change, but it's still kind of a surprise to me that em doesn't support IPv6 hardware offloads.

Oct 5 2018, 9:08 PM
erj requested changes to D17404: iflib: drain enqueued tasks before detaching from taskqgroup.

You're apparently not allowed to delete changesets, so this'll have to be updated with the old diff.

Oct 5 2018, 8:31 PM
erj removed an edge from rS339207: Fix igb corrupting checksums with BPF and VLAN: D17404: iflib: drain enqueued tasks before detaching from taskqgroup.
Oct 5 2018, 8:25 PM
erj removed 1 commit(s) for D17404: iflib: drain enqueued tasks before detaching from taskqgroup: rS339207: Fix igb corrupting checksums with BPF and VLAN.
Oct 5 2018, 8:25 PM
erj added 1 commit(s) for D17393: Attempt to fix PR231416 (UDP BPF VLAN checksum errors): rS339207: Fix igb corrupting checksums with BPF and VLAN.
Oct 5 2018, 8:24 PM
erj added an edge to rS339207: Fix igb corrupting checksums with BPF and VLAN: D17393: Attempt to fix PR231416 (UDP BPF VLAN checksum errors).
Oct 5 2018, 8:24 PM
erj added a child revision for D16429: ixlv(4): Update to use iflib; change name to iavf(4): D15927: Update ixl(4) and ixlv(4) man pages.
Oct 5 2018, 8:21 PM · Intel Networking
erj added a parent revision for D15927: Update ixl(4) and ixlv(4) man pages: D16429: ixlv(4): Update to use iflib; change name to iavf(4).
Oct 5 2018, 8:21 PM
erj added a child revision for D16428: iflib: Changes for ixlv(4) update: D16429: ixlv(4): Update to use iflib; change name to iavf(4).
Oct 5 2018, 8:21 PM · Intel Networking
erj added a parent revision for D16429: ixlv(4): Update to use iflib; change name to iavf(4): D16428: iflib: Changes for ixlv(4) update.
Oct 5 2018, 8:21 PM · Intel Networking
erj reopened D17404: iflib: drain enqueued tasks before detaching from taskqgroup.

rS339207 has the wrong Differential Revision, I think

Oct 5 2018, 8:20 PM
erj added a comment to D17404: iflib: drain enqueued tasks before detaching from taskqgroup.

Is there a reason not to do this in taskqgroup_detach()?

I don't see any obvious thing which prevents something being enqueued between the gtaskqueue_drain() and taskqgroup_detach() calls.

Oct 5 2018, 8:16 PM
erj updated the diff for D16429: ixlv(4): Update to use iflib; change name to iavf(4).
  • iavf(4): Move modules/Makefile entry so that it's in alphabetical order
  • iavf(4): Update MODULE_* macros with new "iavf" name
Oct 5 2018, 6:53 PM · Intel Networking
erj updated the diff for D15927: Update ixl(4) and ixlv(4) man pages.
  • Change name of ixlv(4) to iavf(4) and update Makefile
Oct 5 2018, 5:23 PM

Oct 4 2018

erj planned changes to D15927: Update ixl(4) and ixlv(4) man pages.

Sorry guys, ixlv(4) is getting a name change. :p

Oct 4 2018, 10:54 PM
erj retitled D16429: ixlv(4): Update to use iflib; change name to iavf(4) from ixlv(4): Update to use iflib to ixlv(4): Update to use iflib; change name to iavf(4).
Oct 4 2018, 10:31 PM · Intel Networking
erj updated the diff for D16429: ixlv(4): Update to use iflib; change name to iavf(4).
  • ixlv/iavf(4): Change "ixlv" driver name to "iavf"
Oct 4 2018, 10:29 PM · Intel Networking

Oct 3 2018

erj added a comment to D16429: ixlv(4): Update to use iflib; change name to iavf(4).

Ugh, rebasing changes the commit SHAs :(

Oct 3 2018, 8:14 PM · Intel Networking
erj updated the diff for D16429: ixlv(4): Update to use iflib; change name to iavf(4).

Rebased onto latest master, and added:

Oct 3 2018, 8:10 PM · Intel Networking
erj resigned from D6585: Avoid naming collisions between linuxkpi's struct device and FreeBSD's struct device .
Oct 3 2018, 5:22 PM
erj resigned from D4295: Add driver backpressure.
Oct 3 2018, 5:22 PM · transport
erj resigned from D12142: Don't start grouptaskqueue threads for unused grouptaskqueues.
Oct 3 2018, 5:21 PM
erj resigned from D12487: Combine LROed mbufs for a single call to if_input().
Oct 3 2018, 5:21 PM
erj removed a reviewer for D13858: 1 << 31 redux: Intel Networking.
Oct 3 2018, 5:20 PM

Oct 2 2018

erj updated the diff for D15927: Update ixl(4) and ixlv(4) man pages.

Fix incorrect use of .Fx macro

Oct 2 2018, 11:37 PM
erj updated the summary of D15927: Update ixl(4) and ixlv(4) man pages.
Oct 2 2018, 3:54 PM
erj updated the diff for D15927: Update ixl(4) and ixlv(4) man pages.
  • Fix style issues found by @0mp
Oct 2 2018, 3:53 PM
erj retitled D15927: Update ixl(4) and ixlv(4) man pages from Update ixl(4) man page to Update ixl(4) and ixlv(4) man pages.
Oct 2 2018, 6:03 AM
erj updated the diff for D15927: Update ixl(4) and ixlv(4) man pages.
  • ixl/ixlv(4): Update both manpages.
Oct 2 2018, 6:02 AM

Sep 27 2018

erj updated the diff for D16428: iflib: Changes for ixlv(4) update.
  • Revert "iflib: Free RX queue TCP LRO memory on unload"
Sep 27 2018, 12:57 AM · Intel Networking
erj updated the diff for D16429: ixlv(4): Update to use iflib; change name to iavf(4).
  • ixlv(4): Update driver version to 2.0.0-k
  • ixlv(4): Remove dynamic ITR code, since it's unused
  • ixlv(4): Set max number of queues used in iflib based on number VF receives from PF
  • ixlv(4): Code cleanup
  • ixlv(4): Don't sleep for a response to a VC msg if driver is in detach
  • ixl(4): Clear VF qtag queue flags when VF is being reinitialized
  • ixlv(4): Move queue disable to earlier in ixlv_if_init, and don't sleep for completion
  • ixlv(4): Modify debug prints, and stop printing out "Queue already enabled" warnings
  • ixl(4): Update version number to 2.1.0-k
Sep 27 2018, 12:56 AM · Intel Networking

Sep 25 2018

erj committed rD52304: Document FreeBSD version 1102503..
Document FreeBSD version 1102503.
Sep 25 2018, 7:59 PM
erj committed rS338931: Bump __FreeBSD_version after r338871 introduced new media types.
Bump __FreeBSD_version after r338871 introduced new media types
Sep 25 2018, 7:53 PM

Sep 21 2018

erj committed rS338873: Revert MFC of r334231 in r338871..
Revert MFC of r334231 in r338871.
Sep 21 2018, 11:54 PM
erj committed rS338871: MFC r334231, r334779, r335322, and r338208 to stable/11 from head.
MFC r334231, r334779, r335322, and r338208 to stable/11 from head
Sep 21 2018, 11:31 PM

Sep 20 2018

erj updated the diff for D16429: ixlv(4): Update to use iflib; change name to iavf(4).
  • ixl(4): Fix filter handling when SR-IOV is enabled
  • Revert "iflib: Free RX queue TCP LRO memory on unload"
Sep 20 2018, 5:40 PM · Intel Networking

Sep 19 2018

erj accepted D17242: Add IFCAP_TSO6 for igb.
Sep 19 2018, 6:14 PM

Sep 13 2018

erj updated the diff for D16429: ixlv(4): Update to use iflib; change name to iavf(4).
  • ixl(4): Fix compile error introduced by previous commit
Sep 13 2018, 11:10 PM · Intel Networking
erj updated the diff for D16429: ixlv(4): Update to use iflib; change name to iavf(4).
  • ixl(4): Configure promiscuous mode during driver init
Sep 13 2018, 11:00 PM · Intel Networking
erj updated the diff for D16429: ixlv(4): Update to use iflib; change name to iavf(4).
  • ixlv(4): Disable queues before initialization.
Sep 13 2018, 6:00 PM · Intel Networking