Page MenuHomeFreeBSD

andrew (Andrew Turner)
User

Projects

User Details

User Since
May 10 2014, 2:21 PM (284 w, 6 h)

Recent Activity

Wed, Oct 16

andrew committed rS353641: Use tables to store the information to decode the arm64 ID registers..
Use tables to store the information to decode the arm64 ID registers.
Wed, Oct 16, 1:30 PM
andrew closed D22020: Use tables to decode the arm64 ID registers.
Wed, Oct 16, 1:30 PM
andrew committed rS353640: Stop leaking information from the kernel through timespec.
Stop leaking information from the kernel through timespec
Wed, Oct 16, 1:21 PM
andrew added a comment to D21922: A preliminary patch for using ASIDs in the arm64 pmap.

I can boot with it on the dual package ThunderX in Sentex (2 x 48 cores). Unfortunately I was unable to test it as I hit an unrelated nfs locking issue.

Wed, Oct 16, 11:33 AM

Mon, Oct 14

andrew created D22020: Use tables to decode the arm64 ID registers.
Mon, Oct 14, 9:55 AM
andrew committed rS353487: Sort the id_aa64*_fields arrays to be in alphanumerical order..
Sort the id_aa64*_fields arrays to be in alphanumerical order.
Mon, Oct 14, 9:30 AM

Fri, Oct 11

andrew accepted D21947: gcore: Add aarch64 32-bit core support.
Fri, Oct 11, 7:27 AM

Wed, Oct 9

andrew added a comment to D21922: A preliminary patch for using ASIDs in the arm64 pmap.
In D21922#479571, @alc wrote:

How should I test for the affected CPUs?

Wed, Oct 9, 9:48 AM
andrew added inline comments to D21947: gcore: Add aarch64 32-bit core support.
Wed, Oct 9, 8:42 AM
andrew added inline comments to D21922: A preliminary patch for using ASIDs in the arm64 pmap.
Wed, Oct 9, 6:36 AM

Tue, Oct 8

andrew added a comment to D21922: A preliminary patch for using ASIDs in the arm64 pmap.

We have access to ThunxerX servers in Sentex with 48 and 96 cores, and @emaste has a ThubderX2 and eMAG server on his office.

Tue, Oct 8, 7:13 AM

Fri, Oct 4

andrew committed rS353104: MFS r353032:.
MFS r353032:
Fri, Oct 4, 2:11 PM

Thu, Oct 3

andrew committed rS353032: MFC r352796:.
MFC r352796:
Thu, Oct 3, 7:17 AM

Mon, Sep 30

andrew accepted D21841: Fix arm64's pmap_enter_quick_locked() .
Mon, Sep 30, 10:56 AM

Fri, Sep 27

andrew committed rS352796: Check the vfs option length is valid before accessing through.
Check the vfs option length is valid before accessing through
Fri, Sep 27, 4:22 PM

Mon, Sep 23

andrew accepted D21753: Eliminate redundant critical section from arm64's pmap_update_entry().
Mon, Sep 23, 11:41 AM

Sat, Sep 21

andrew accepted D21685: Try translating the fault address with pmap unlocked..
Sat, Sep 21, 10:11 AM

Fri, Sep 20

andrew added inline comments to D21685: Try translating the fault address with pmap unlocked..
Fri, Sep 20, 6:52 PM
andrew added a comment to D21685: Try translating the fault address with pmap unlocked..

@alc Can you commender this and update with that patch?

Fri, Sep 20, 9:14 AM

Sep 19 2019

andrew added a reviewer for D21694: Add 8 and 16 bit versions of atomic_cmpset and atomic_fcmpset for arm.: mjg.
Sep 19 2019, 7:31 AM

Sep 18 2019

andrew added inline comments to D21694: Add 8 and 16 bit versions of atomic_cmpset and atomic_fcmpset for arm..
Sep 18 2019, 8:49 AM

Sep 17 2019

andrew created D21685: Try translating the fault address with pmap unlocked..
Sep 17 2019, 10:47 AM
andrew committed rS352441: MFC r343042, r343875.
MFC r343042, r343875
Sep 17 2019, 10:10 AM
andrew committed rS352440: MFC r342552:.
MFC r342552:
Sep 17 2019, 10:01 AM

Sep 16 2019

andrew committed rS352405: MFC r342937:.
MFC r342937:
Sep 16 2019, 3:00 PM
andrew committed rS352403: MFC r340008, r340013.
MFC r340008, r340013
Sep 16 2019, 2:51 PM
andrew committed rS352402: MFC r339988:.
MFC r339988:
Sep 16 2019, 2:45 PM
andrew committed rS352401: MFC r339594:.
MFC r339594:
Sep 16 2019, 2:44 PM
andrew committed rS352400: MFC r341489:.
MFC r341489:
Sep 16 2019, 2:42 PM
andrew committed rS352399: MFC r339948:.
MFC r339948:
Sep 16 2019, 2:35 PM
andrew committed rS352398: MFC r339944:.
MFC r339944:
Sep 16 2019, 2:34 PM
andrew committed rS352397: MFC r348323:.
MFC r348323:
Sep 16 2019, 2:26 PM
andrew committed rS352396: MFC r343876:.
MFC r343876:
Sep 16 2019, 2:07 PM
andrew committed rS352395: MFC r346996:.
MFC r346996:
Sep 16 2019, 1:45 PM
andrew committed rS352394: MFC r339738, r339744, r339770, r339773, r339864-r339866, r339907-r339908….
MFC r339738, r339744, r339770, r339773, r339864-r339866, r339907-r339908…
Sep 16 2019, 1:41 PM

Sep 11 2019

andrew accepted D21439: Generic SMCCC.
Sep 11 2019, 4:37 PM

Sep 6 2019

andrew added a comment to D21439: Generic SMCCC.

Can you update the psci code to use the arm_smccc_* functions? We should only have one copy the functions to make smccc calls and you can consider psci to be based on it.

Sep 6 2019, 10:14 AM

Sep 3 2019

andrew created D21494: Use uintptr_t with pointer addition so overflow is defined.
Sep 3 2019, 3:48 PM

Sep 1 2019

andrew added inline comments to D21454: [new driver] Intel Stratix10 (S10) quad-core ARM64 and FPGA fabric..
Sep 1 2019, 7:42 PM
andrew added inline comments to D21439: Generic SMCCC.
Sep 1 2019, 7:41 PM
andrew added inline comments to D21439: Generic SMCCC.
Sep 1 2019, 7:24 PM

Aug 14 2019

andrew committed rS351034: MFC r350112, r350241, and r350242:.
MFC r350112, r350241, and r350242:
Aug 14 2019, 5:02 PM
andrew committed rS351032: MFC r345510:.
MFC r345510:
Aug 14 2019, 4:55 PM
andrew committed rS351031: MFC r339593:.
MFC r339593:
Aug 14 2019, 4:45 PM
andrew committed rS351029: MFC r339592:.
MFC r339592:
Aug 14 2019, 4:40 PM
andrew committed rS351027: Enable BSD_CRTBEGIN on powerpc.
Enable BSD_CRTBEGIN on powerpc
Aug 14 2019, 2:31 PM

Aug 13 2019

andrew added a comment to D21189: Driver for Broadcom PDC.

You can use __FreeBSD_version to toggle the non-xdma case. It looks like 1200020 is the first bump after xdma was added so you'd have:

#if __FreeBSD_version >= 1200020
/* XDMA code */
#else
/* Pre-XDMA code */
#endif
Aug 13 2019, 1:24 PM

Aug 9 2019

andrew added a comment to D19831: Add PT_GETREGSET.

Correct the man page, addr points at a struct iovec.

Aug 9 2019, 12:16 PM
andrew added a comment to D19831: Add PT_GETREGSET.

Add COMPAT32 and update the man page

Aug 9 2019, 12:02 PM

Aug 8 2019

andrew added inline comments to D21184: First pass at a LINT for arm64..
Aug 8 2019, 4:49 PM
andrew added a comment to D21189: Driver for Broadcom PDC.

Is there a reasion you're not using the xdma framework?

Aug 8 2019, 4:42 PM

Aug 7 2019

andrew accepted D21169: Handle concurrent pmap_kextract() and promotion/demotion on arm64.
Aug 7 2019, 4:22 PM
D21169: Handle concurrent pmap_kextract() and promotion/demotion on arm64 is now accepted and ready to land.
Aug 7 2019, 10:20 AM

Aug 5 2019

andrew added a comment to D21149: Enable superpage promotion within the kernel pmap on arm64.

Hasn't this opened a raise between promotion/demotion and pmap_kextract? pmap_kextract walks the page table so may find a zero entry from the break-before-make sequence.

Aug 5 2019, 8:59 AM

Aug 2 2019

D21126: Fixes to page table page mapping is now accepted and ready to land.
Aug 2 2019, 8:44 AM

Jul 31 2019

D21121: Use ATTR_DBM for ATTR_SW_DBM instead of a software bit. is now accepted and ready to land.
Jul 31 2019, 11:59 AM
andrew added a comment to D21121: Use ATTR_DBM for ATTR_SW_DBM instead of a software bit..
In D21121#458634, @alc wrote:

Do we have access to a machine with hardware DBM support?

Jul 31 2019, 11:57 AM

Jul 26 2019

andrew added inline comments to D21072: Remove support for kernel.tramp and kernel.tramp.gz.
Jul 26 2019, 8:49 AM

Jul 23 2019

andrew committed rS350242: As with r350241 use the new UL macro on the main register mask..
As with r350241 use the new UL macro on the main register mask.
Jul 23 2019, 2:52 PM
andrew committed rS350241: Ensure the arm64 ID register fields are 64 bit types..
Ensure the arm64 ID register fields are 64 bit types.
Jul 23 2019, 2:40 PM
andrew closed D20977: Ensure the ID register fields are 64 bit types..
Jul 23 2019, 2:40 PM

Jul 18 2019

andrew committed rS350112: Rename arm64 macros in preperation for a script to generate them..
Rename arm64 macros in preperation for a script to generate them.
Jul 18 2019, 1:58 PM
andrew closed D20976: Rename macros in preperation for a script to generate them..
Jul 18 2019, 1:58 PM

Jul 17 2019

andrew added a comment to D20977: Ensure the ID register fields are 64 bit types..
  • Fix the mane of ID_AA64MMFR0_PARange_1T
  • Restore ID_AA64PFR0_GIC_BITS
Jul 17 2019, 9:29 AM
andrew created D20977: Ensure the ID register fields are 64 bit types..
Jul 17 2019, 9:20 AM
andrew created D20976: Rename macros in preperation for a script to generate them..
Jul 17 2019, 8:48 AM

Jul 11 2019

andrew added inline comments to D20907: Implement software AF and DBM management for arm64..
Jul 11 2019, 3:03 PM

Jul 8 2019

andrew added a comment to D20848: Restructure cache_handle_range to avoid unnecessary barriers.

My guess is we are hitting the crossing point where the instruction cost of the loop is greater than the cost of invalidating the entire instruction cache. We might need to have an invalidate all version of arm64_icache_sync_range then switch between them in the macro based on the length of the memory.

Jul 8 2019, 10:16 AM

Jul 4 2019

D20848: Restructure cache_handle_range to avoid unnecessary barriers is now accepted and ready to land.
Jul 4 2019, 1:31 PM

Jun 26 2019

D20772: Provide protection against starvation of the ll/sc loops when accessing userpace. is now accepted and ready to land.

I'm happy with the arm and arm64 changes.

Jun 26 2019, 6:28 PM
andrew added a comment to D20770: arm64: Move "segments" array from bus_dma_tag to bus_dmamap..

Isn't this also a problem on amd64?

Jun 26 2019, 2:07 PM

Jun 16 2019

andrew accepted D20657: Three enhancements to arm64's pmap_protect().
Jun 16 2019, 12:53 PM

Jun 12 2019

andrew added a comment to D20585: Various arm64 pmap fixes (and one optimization).
In D20585#445331, @alc wrote:

Andrew, as I understand the current state of the pmap code, ATTR_AF is always preset (and never actually cleared) because pmap_fault() does not yet have the ability to set ATTR_AF. Is that correct?

Jun 12 2019, 3:40 PM

Jun 11 2019

andrew added a comment to D20562: The efifat files are no longer used: remove the code to build them..

I approve, this should go.
I'm aware of some out-of-tree build scripts that do something like:

mkimg -s gpt -b $ROOTDIR/boot/pmbr \
  -p efi:=$ROOTDIR/boot/boot1.efifat \
  -p freebsd-boot:=$ROOTDIR/boot/gptboot \
  -p freebsd-ufs:=ufs -p freebsd-swap::1G \
  -o $image

but really they need to just generate the EFI filesystem at the same time they generate the main (UFS in this case) filesystem.

Jun 11 2019, 11:01 AM
andrew added a comment to D20587: KCOV: Use arch-dependend data type for the PCs.

I've created https://github.com/google/syzkaller/pull/1229 to fix the bug in syzkaller.

Jun 11 2019, 10:35 AM
andrew added a comment to D20587: KCOV: Use arch-dependend data type for the PCs.

The size was set so a 32 bit tracing tool can trace a 64 bit kernel without loosing information.

Jun 11 2019, 10:28 AM
andrew added inline comments to D20585: Various arm64 pmap fixes (and one optimization).
Jun 11 2019, 10:14 AM

May 31 2019

andrew accepted D20454: arm64 gic: Drop unused GICV3_IVAR_REDIST_VADDR.
May 31 2019, 9:49 AM

May 30 2019

andrew added inline comments to D20454: arm64 gic: Drop unused GICV3_IVAR_REDIST_VADDR.
May 30 2019, 8:50 PM
andrew added a comment to D20416: acpi_iort: add some error handling.

How frequently is srat_resolve_its_pxm called?

May 30 2019, 9:28 AM
andrew added inline comments to D20454: arm64 gic: Drop unused GICV3_IVAR_REDIST_VADDR.
May 30 2019, 9:27 AM

May 29 2019

andrew accepted D19842: gic_v3: consolidate per-cpu redistributor information.
May 29 2019, 8:50 AM

May 28 2019

andrew committed rS348323: The alignment is passed into contigmalloc_domainset in the 7th argument..
The alignment is passed into contigmalloc_domainset in the 7th argument.
May 28 2019, 10:56 AM
andrew added inline comments to D19842: gic_v3: consolidate per-cpu redistributor information.
May 28 2019, 9:55 AM
andrew committed rS348322: Teach the kernel KUBSAN runtime about alignment_assumption.
Teach the kernel KUBSAN runtime about alignment_assumption
May 28 2019, 9:12 AM

May 27 2019

andrew accepted D19844: gicv3_its: do LPI init only once per CPU.
May 27 2019, 10:36 AM
andrew accepted D20418: arm64 gicv3_its: Fix a typo.
May 27 2019, 10:31 AM

May 26 2019

andrew accepted D20349: arm64: efi: Map memory IO region as device.
May 26 2019, 10:29 AM

May 22 2019

andrew requested changes to D20349: arm64: efi: Map memory IO region as device.

Having thought about it more I'm not sure this is correct. I think we should make the default case VM_MEMATTR_DEVICE. EFI_MD_ATTR_WC Is also wrong as it should be VM_MEMATTR_UNCACHEABLE so should be fixed at some stage.

May 22 2019, 12:19 PM
andrew accepted D20349: arm64: efi: Map memory IO region as device.
May 22 2019, 12:03 PM
andrew added inline comments to D20347: efirt: Add efi_memory_attribute.
May 22 2019, 11:13 AM

May 9 2019

andrew added a comment to D19831: Add PT_GETREGSET.

I also return the size when the base is NULL in PT_GETREGSET.

May 9 2019, 12:42 PM
andrew updated the diff for D19831: Add PT_GETREGSET.
  • Remove xsave. It will move to a new review.
  • Add PT_SETREGSET
  • Use goto out for error handling
  • Remove sys/_iovec.h from sys/ptrace.h
May 9 2019, 12:41 PM
andrew accepted D20144: ahci: Check if bus is cache-coherent.
May 9 2019, 11:49 AM

May 8 2019

andrew accepted D19986: Add support for USB 3.0 XHCI via ACPI.
May 8 2019, 1:59 PM · arm64, Contributor Reviews (base)

May 7 2019

andrew added a comment to D19831: Add PT_GETREGSET.
In D19831#425330, @jhb wrote:

Hmm, do you have plans for a PT_SETREGSET as well?

May 7 2019, 5:28 PM
andrew accepted D19986: Add support for USB 3.0 XHCI via ACPI.
May 7 2019, 8:23 AM · arm64, Contributor Reviews (base)

May 4 2019

andrew added inline comments to D20156: Add support for RK3399 emmc.
May 4 2019, 11:48 AM

May 3 2019

andrew abandoned D7941: Add support to strings(1) to run under capsicum.
May 3 2019, 1:54 PM

May 2 2019

andrew added a reviewer for D20144: ahci: Check if bus is cache-coherent: mav.
May 2 2019, 4:33 PM