Page MenuHomeFreeBSD

andrew (Andrew Turner)
User

Projects

User Details

User Since
May 10 2014, 2:21 PM (370 w, 6 d)

Recent Activity

Mon, Jun 14

andrew committed R10:15fa52a56494: Add more GIC and GICv3 registers (authored by andrew).
Add more GIC and GICv3 registers
Mon, Jun 14, 2:54 PM
andrew committed R10:e7f369b1c18c: Use the correct length when copying arm64 vfp registers (authored by andrew).
Use the correct length when copying arm64 vfp registers
Mon, Jun 14, 2:54 PM

Sun, Jun 13

andrew committed R10:2a8921c5d187: pciconf: Use VM_MEMATTR_DEVICE on supported architectures (authored by mw).
pciconf: Use VM_MEMATTR_DEVICE on supported architectures
Sun, Jun 13, 7:16 PM
andrew committed R10:ade8b810b02f: Create VM_MEMATTR_DEVICE on all architectures (authored by andrew).
Create VM_MEMATTR_DEVICE on all architectures
Sun, Jun 13, 7:16 PM

Sat, Jun 12

andrew committed R10:b96893a48979: Clean up early arm64 pmap code (authored by andrew).
Clean up early arm64 pmap code
Sat, Jun 12, 2:03 PM
andrew committed R10:abb9d448b32d: Update the EFI timer to be called once a second (authored by andrew).
Update the EFI timer to be called once a second
Sat, Jun 12, 2:03 PM
andrew committed R10:3699da67bf4d: Use '.arch_extension crc' in the arm64 crc32 code (authored by andrew).
Use '.arch_extension crc' in the arm64 crc32 code
Sat, Jun 12, 2:02 PM
andrew committed R10:48e4430ea5a1: Implement bus_map_resource on arm64 (authored by andrew).
Implement bus_map_resource on arm64
Sat, Jun 12, 2:02 PM
andrew committed R10:a0dd2317e8f5: Use if ... else when printing memory attributes (authored by andrew).
Use if ... else when printing memory attributes
Sat, Jun 12, 2:02 PM
andrew committed R10:2c89a8c9aae2: Clean up the style in the arm64 bus.h (authored by andrew).
Clean up the style in the arm64 bus.h
Sat, Jun 12, 2:02 PM

Fri, Jun 11

andrew committed R10:4b707591838d: Also enable IPIs on 32-bit arm (authored by andrew).
Also enable IPIs on 32-bit arm
Fri, Jun 11, 6:27 PM
andrew committed R10:fcfd3c7909ba: Enable IPIs on CPU 0 on arm and arm64 (authored by andrew).
Enable IPIs on CPU 0 on arm and arm64
Fri, Jun 11, 6:27 PM
andrew added inline comments to D30729: Introduce new driver for NXP ENETC Ethernet controller.
Fri, Jun 11, 5:41 PM

Wed, Jun 2

andrew committed R10:2422138952d8: Fix the KCSAN_ENABLED check when building modules (authored by andrew).
Fix the KCSAN_ENABLED check when building modules
Wed, Jun 2, 11:18 AM
andrew closed D30410: Use the arm virtual counter to get the time on arm64.
Wed, Jun 2, 11:18 AM
andrew committed R10:0a0d6ce34d6b: Use the arm virtual counter in the arm64 loader (authored by andrew).
Use the arm virtual counter in the arm64 loader
Wed, Jun 2, 11:18 AM
andrew accepted D30180: pci_host_generic_fdt.c: Add support for mapping dts nodes to PCI devices.
Wed, Jun 2, 10:16 AM
andrew added inline comments to D30601: hwpmc_arm64: fill kern.hwpmc.cpuid.
Wed, Jun 2, 10:15 AM
andrew accepted D30181: Add ofw interface support to PCI.
Wed, Jun 2, 10:13 AM
andrew added a comment to D30602: hwpmc_arm64: accept raw event codes for PMC_OP_PMCALLOCATE.

Is there a way to tell if a raw event or event code has been asked for on the syscall boundary? In current architecture the event space is 16bit so we can tell the difference, however we shouldn't assume this will never change.

Wed, Jun 2, 9:41 AM

Tue, Jun 1

andrew added inline comments to D30181: Add ofw interface support to PCI.
Tue, Jun 1, 7:47 AM
andrew added inline comments to D30180: pci_host_generic_fdt.c: Add support for mapping dts nodes to PCI devices.
Tue, Jun 1, 7:29 AM

Wed, May 26

andrew added inline comments to D30181: Add ofw interface support to PCI.
Wed, May 26, 6:14 PM
andrew accepted D30179: Remove ThunderX PCIe FDT quirks from pci_host_generic_fdt.c.
Wed, May 26, 6:01 PM
andrew added inline comments to D30180: pci_host_generic_fdt.c: Add support for mapping dts nodes to PCI devices.
Wed, May 26, 5:35 PM
andrew added inline comments to D30181: Add ofw interface support to PCI.
Wed, May 26, 4:35 PM

Mon, May 24

andrew added a comment to D30362: arm64: log vm_fault error for data_abort.

They are printing different trap frames. print_registers will print the fault frame while show reg will print a frame from a breakpoint within panic. The registers seen when debugger_on_trap is true should be identical to the version printed by print_registers.

Mon, May 24, 5:26 PM
andrew requested review of D30410: Use the arm virtual counter to get the time on arm64.
Mon, May 24, 10:12 AM
andrew committed R10:e779604f1d4e: Clean up early arm64 pmap code (authored by andrew).
Clean up early arm64 pmap code
Mon, May 24, 9:45 AM
andrew closed D30357: Clean up early arm64 pmap code.
Mon, May 24, 9:45 AM
andrew accepted D30362: arm64: log vm_fault error for data_abort.

We could drip printing frame->tf_elr as we already do so in print_registers

Mon, May 24, 8:31 AM

Thu, May 20

andrew added reviewers for D30357: Clean up early arm64 pmap code: markj, kib.
Thu, May 20, 9:38 AM
andrew requested review of D30357: Clean up early arm64 pmap code.
Thu, May 20, 9:38 AM

May 17 2021

andrew accepted D30226: Rename ofwpci.c to ofw_pcib.c.
May 17 2021, 11:11 AM
andrew added inline comments to D30288: mmc: Add mmc-pwrseq driver.
May 17 2021, 11:07 AM

May 12 2021

andrew committed R10:93f7be080f3a: Update the EFI timer to be called once a second (authored by andrew).
Update the EFI timer to be called once a second
May 12 2021, 4:37 PM
andrew closed D30227: Update the EFI timer to be called once a second.
May 12 2021, 4:37 PM
andrew retitled D30227: Update the EFI timer to be called once a second from Update the EIF timer to be called once a second to Update the EFI timer to be called once a second.
May 12 2021, 12:01 PM
andrew requested review of D30227: Update the EFI timer to be called once a second.
May 12 2021, 11:25 AM

May 10 2021

andrew added inline comments to D30179: Remove ThunderX PCIe FDT quirks from pci_host_generic_fdt.c.
May 10 2021, 12:34 PM
andrew requested changes to D30181: Add ofw interface support to PCI.

This should be a sub class of the existing pci driver, similar to how it's done in sys/dev/acpica/acpi_pci.c

May 10 2021, 12:11 PM

May 6 2021

andrew accepted D30126: KASAN: Disable the sanitizer in stack_capture().
May 6 2021, 3:16 PM
andrew committed R10:0ec3e991112d: Use '.arch_extension crc' in the arm64 crc32 code (authored by andrew).
Use '.arch_extension crc' in the arm64 crc32 code
May 6 2021, 10:07 AM

May 5 2021

andrew updated the diff for D30103: Add a simple-framebuffer vt driver.

Add more formats found in local dts files

May 5 2021, 8:59 AM
andrew retitled D30103: Add a simple-framebuffer vt driver from Add an simple-framebuffer vt driver to Add a simple-framebuffer vt driver.
May 5 2021, 8:58 AM
andrew added a comment to D30103: Add a simple-framebuffer vt driver.

We don't have a device_t to use this early so would need to create a driver to attach to the same node later in the boot. One of the problems is it's a child of /chosen so doesn't get probed. For testing I created a chosen driver we could use that attaches to the chosen node and adds any children it finds.

May 5 2021, 8:44 AM
andrew added a comment to D30103: Add a simple-framebuffer vt driver.

I can easily add more formats, although can't test the clocks as I don't have hardware that has the clocks property.

May 5 2021, 8:17 AM

May 4 2021

andrew requested review of D30103: Add a simple-framebuffer vt driver.
May 4 2021, 4:41 PM

May 3 2021

andrew committed R10:0ec205197b56: Also enable IPIs on 32-bit arm (authored by andrew).
Also enable IPIs on 32-bit arm
May 3 2021, 11:34 AM
andrew added a comment to D30079: Map arm64 pci config memory as non-posted.

This seemed to be the consensus when I asked how best to do it on IRC.

May 3 2021, 11:03 AM
andrew added inline comments to D29875: xen/arm64: add handling of Xen device-tree.
May 3 2021, 10:58 AM

May 2 2021

andrew requested review of D30079: Map arm64 pci config memory as non-posted.
May 2 2021, 12:34 PM
andrew closed D26975: Enable IPIs on CPU 0 on arm and arm64.
May 2 2021, 10:57 AM
andrew committed R10:2420f6aed9e3: Enable IPIs on CPU 0 on arm and arm64 (authored by andrew).
Enable IPIs on CPU 0 on arm and arm64
May 2 2021, 10:57 AM
andrew closed D29694: Implement bus_map_resource on arm64.
May 2 2021, 10:57 AM
andrew committed R10:fe3822497726: Implement bus_map_resource on arm64 (authored by andrew).
Implement bus_map_resource on arm64
May 2 2021, 10:57 AM

May 1 2021

andrew committed R10:f1957db43d28: Fix building sysctl(8) after c78ad20 (authored by andrew).
Fix building sysctl(8) after c78ad20
May 1 2021, 1:37 PM
andrew closed D29759: Switch the EFI virtual address to a uint64_t.
May 1 2021, 8:26 AM
andrew committed R10:c78ad207baed: Switch the EFI virtual address to a uint64_t (authored by andrew).
Switch the EFI virtual address to a uint64_t
May 1 2021, 8:26 AM
andrew closed D29722: Add a way to map arm64 non-posted device memory.
May 1 2021, 8:26 AM
andrew committed R10:2abd4f858146: Add a way to map arm64 non-posted device memory (authored by andrew).
Add a way to map arm64 non-posted device memory
May 1 2021, 8:26 AM

Apr 30 2021

andrew accepted D30033: gicv3_its: Flush cache after allocating ITT memory.
Apr 30 2021, 1:50 PM
andrew added inline comments to D30033: gicv3_its: Flush cache after allocating ITT memory.
Apr 30 2021, 9:41 AM

Apr 29 2021

andrew added a comment to D30033: gicv3_its: Flush cache after allocating ITT memory.

Does this need to be done in all cases, or just when the ITS is not cache-coherent?

Apr 29 2021, 3:44 PM

Apr 28 2021

andrew added a comment to D29694: Implement bus_map_resource on arm64.
In D29694#666735, @jhb wrote:

Hmm, I should post some of my reviews. I have a branch that does this for most architectures but I also added some helpers to reduce code duplication in activate/deactive_resource methods. I also tried to fix some layering violations that I should perhaps untangle as that made the branch larger. The helpers at least are probably useful so I'll try to resurrect those soon.

Apr 28 2021, 7:38 PM

Apr 21 2021

andrew added inline comments to D29874: xen/arm64: add xen early init.
Apr 21 2021, 10:58 AM

Apr 20 2021

andrew added a comment to D29792: 4K pages header added.

This is for iommu support because, as far as I can tell, the SMMU and Mali iommus only support 4k pages. I think we want to duplicate these macros entierly and give them a unique prefix, e.g. L0_SHIFT -> SMMU_L0_SHIFT. I would also put the header under sys/arm64/iommu as it's then not tied to arm64 (it could also be used on 32-bit arm).

Apr 20 2021, 7:15 AM
andrew added a comment to D29848: config: create a 'requires' keyword for files file processing.

Is there an update for config.5?

Apr 20 2021, 7:09 AM

Apr 16 2021

andrew abandoned D29723: Implement bus_map_resource on arm64.

Switch to D29694 as I seem to have put this up twice for review.

Apr 16 2021, 9:31 AM

Apr 14 2021

andrew added inline comments to D29731: Mali GPU pmap support.
Apr 14 2021, 7:27 PM
andrew retitled D29759: Switch the EFI virtual address to a uint64_t from Switch the EIF virtual address to a uint64_t to Switch the EFI virtual address to a uint64_t.
Apr 14 2021, 11:23 AM
andrew requested review of D29759: Switch the EFI virtual address to a uint64_t.
Apr 14 2021, 11:19 AM

Apr 12 2021

andrew added a comment to D29722: Add a way to map arm64 non-posted device memory.

It's needed by the Tegra PCIe driver as it maps its config space via bus_space_map. The other PCI drivers use bus_alloc_resource_any for their config space so can be updated to use RF_UNMAPPED and bus_map_resource.

Apr 12 2021, 4:19 PM
andrew updated the diff for D29722: Add a way to map arm64 non-posted device memory.
  • Teach vmstat about VM_MEMATTR_DEVICE_NP
  • Add a comment explaining why the device meory types are the same
Apr 12 2021, 1:43 PM
andrew added inline comments to D29722: Add a way to map arm64 non-posted device memory.
Apr 12 2021, 11:43 AM
andrew requested review of D29723: Implement bus_map_resource on arm64.
Apr 12 2021, 10:28 AM
andrew updated the diff for D29722: Add a way to map arm64 non-posted device memory.

Pass ma to pmap_mapdev_attr

Apr 12 2021, 9:35 AM
andrew requested review of D29722: Add a way to map arm64 non-posted device memory.
Apr 12 2021, 9:34 AM
andrew committed R10:3da598388943: Remove versatile support (authored by andrew).
Remove versatile support
Apr 12 2021, 8:42 AM
andrew committed R10:5d2d599d3f34: Create VM_MEMATTR_DEVICE on all architectures (authored by andrew).
Create VM_MEMATTR_DEVICE on all architectures
Apr 12 2021, 8:42 AM
andrew closed D29707: Remove versatile support.
Apr 12 2021, 8:41 AM
andrew closed D29692: Create VM_MEMATTR_DEVICE on all architectures.
Apr 12 2021, 8:41 AM

Apr 11 2021

andrew retitled D29707: Remove versatile support from Remove versitile support to Remove versatile support.
Apr 11 2021, 5:29 PM
andrew requested review of D29707: Remove versatile support.
Apr 11 2021, 4:00 PM
andrew updated the summary of D29692: Create VM_MEMATTR_DEVICE on all architectures.
Apr 11 2021, 1:48 PM
andrew updated the diff for D29692: Create VM_MEMATTR_DEVICE on all architectures.
  • Remove _KERNEL checks
  • Only use VM_MEMATTR_DEVICE in pciconf
Apr 11 2021, 1:47 PM
andrew committed R10:15221c552b3c: Use if ... else when printing memory attributes (authored by andrew).
Use if ... else when printing memory attributes
Apr 11 2021, 1:38 PM
andrew closed D29703: Use if ... else when printing memory attributes.
Apr 11 2021, 1:38 PM
andrew added inline comments to D29692: Create VM_MEMATTR_DEVICE on all architectures.
Apr 11 2021, 11:42 AM
andrew requested review of D29703: Use if ... else when printing memory attributes.
Apr 11 2021, 11:41 AM
andrew added inline comments to D29692: Create VM_MEMATTR_DEVICE on all architectures.
Apr 11 2021, 8:41 AM

Apr 10 2021

andrew requested review of D29694: Implement bus_map_resource on arm64.
Apr 10 2021, 1:05 PM
andrew requested review of D29692: Create VM_MEMATTR_DEVICE on all architectures.
Apr 10 2021, 12:47 PM

Apr 8 2021

andrew committed R10:5998328e55f8: Clean up the style in the arm64 bus.h (authored by andrew).
Clean up the style in the arm64 bus.h
Apr 8 2021, 12:51 PM
andrew committed R10:24b2f4ea4922: arm64: Fix finding the pmc event ID (authored by andrew).
arm64: Fix finding the pmc event ID
Apr 8 2021, 10:20 AM
andrew committed R10:4d9488674f3a: Remove the last users of ARM_TP_ADDRESS (authored by andrew).
Remove the last users of ARM_TP_ADDRESS
Apr 8 2021, 10:20 AM
andrew committed R10:d6a53211a716: Discard the arm64 VFP state before resetting it (authored by andrew).
Discard the arm64 VFP state before resetting it
Apr 8 2021, 10:20 AM
andrew closed D29624: Remove the last users of ARM_TP_ADDRESS.
Apr 8 2021, 10:20 AM
andrew closed D29600: arm64: Fix finding the pmc event ID.
Apr 8 2021, 10:20 AM
andrew closed D29401: Discard the arm64 VFP state before resetting it.
Apr 8 2021, 10:20 AM