Page MenuHomeFreeBSD

andrew (Andrew Turner)
User

Projects

User Details

User Since
May 10 2014, 2:21 PM (239 w, 2 d)

Recent Activity

Sun, Dec 9

andrew added a comment to D17137: arm64: Add HWCAP support.

There is no need to set the cpu affinity, the userspace register view is the same on each core.

Sun, Dec 9, 11:49 AM

Tue, Dec 4

andrew closed D18428: Only gnu/lib/csu when MK_BSD_CRTBEGIN is off.
Tue, Dec 4, 6:52 PM
andrew committed rS341489: Only gnu/lib/csu when MK_BSD_CRTBEGIN is off..
Only gnu/lib/csu when MK_BSD_CRTBEGIN is off.
Tue, Dec 4, 6:52 PM
andrew created D18428: Only gnu/lib/csu when MK_BSD_CRTBEGIN is off.
Tue, Dec 4, 10:56 AM

Mon, Dec 3

andrew committed rS341424: Disable the BSD CRT code on powerpc and sparc64, they need extra crt*.o.
Disable the BSD CRT code on powerpc and sparc64, they need extra crt*.o
Mon, Dec 3, 9:41 AM

Sat, Nov 24

andrew committed rS340911: Re-enable the dynamiclib tests. These should be fixed by r340910..
Re-enable the dynamiclib tests. These should be fixed by r340910.
Sat, Nov 24, 6:27 PM
andrew committed rS340910: Add the missing 0 at the end of the .jcr section..
Add the missing 0 at the end of the .jcr section.
Sat, Nov 24, 6:24 PM
andrew committed rS340881: Disable the dynamiclib test until a failure can be debugged.
Disable the dynamiclib test until a failure can be debugged
Sat, Nov 24, 4:06 PM

Fri, Nov 23

andrew committed rS340841: Enable the BSD crtbegin/crtend by default..
Enable the BSD crtbegin/crtend by default.
Fri, Nov 23, 4:45 PM
andrew committed rS340840: Mark the function called by the MIPS .init/.fini sequence with .local..
Mark the function called by the MIPS .init/.fini sequence with .local.
Fri, Nov 23, 4:33 PM
andrew added inline comments to D17938: Add a PWM subsystem.
Fri, Nov 23, 4:17 PM

Thu, Nov 15

andrew accepted D17793: pci_host_generic : move activate/release to generic code.
Thu, Nov 15, 6:07 PM
andrew accepted D17792: pci_host_generic, acpi_resource: drop unneeded code.
Thu, Nov 15, 6:06 PM
andrew accepted D17791: acpica, pci_host_generic_acpi: redo pci_host_generic_acpi.c.
Thu, Nov 15, 6:04 PM
andrew accepted D17790: acpica: rework INTRNG interrupt mapping.
Thu, Nov 15, 5:56 PM
andrew accepted D17981: arm64 pmap: Handle kernel mappings in pmap_remove_l2()..
Thu, Nov 15, 5:25 PM
andrew accepted D17981: arm64 pmap: Handle kernel mappings in pmap_remove_l2()..
Thu, Nov 15, 2:42 PM

Tue, Nov 13

andrew committed rS340395: Run __cxa_finalize in shared objects in the destructor path..
Run __cxa_finalize in shared objects in the destructor path.
Tue, Nov 13, 3:28 PM
andrew added a reviewer for D17943: arm64: add ACPI based NUMA support: markj.
Tue, Nov 13, 10:38 AM · arm64
andrew added a reviewer for D17942: acpica: support parsing of arm64 affinity in acpi_pxm.c: markj.
Tue, Nov 13, 10:38 AM
andrew added a reviewer for D17941: acpica : move SRAT/SLIT parsing to sys/dev/acpica: markj.
Tue, Nov 13, 10:38 AM
andrew added a reviewer for D17940: x86/acpica/srat.c: Add API for parsing proximity tables: markj.
Tue, Nov 13, 10:38 AM · arm64

Nov 7 2018

andrew committed rS340213: Add the (untested) mips and sparc64 .init call sequences..
Add the (untested) mips and sparc64 .init call sequences.
Nov 7 2018, 9:49 AM

Nov 6 2018

andrew added a comment to D14599: Implement kernel code coverage (kcov).

I don't see any reason why this would preclude SBCC based kernel coverage. The only issue may be if it uses the same device node to communicate with userspace.

Nov 6 2018, 6:33 PM
andrew committed rS340193: Add the KUBSAN options to the arm64 and amd64 GENERIC kernel config files..
Add the KUBSAN options to the arm64 and amd64 GENERIC kernel config files.
Nov 6 2018, 5:48 PM
andrew committed rS340191: Port the NetBSD ubsan runtime to the FreeBSD kernel..
Port the NetBSD ubsan runtime to the FreeBSD kernel.
Nov 6 2018, 5:32 PM
andrew committed rS340189: Import the NetBSD micro ubsan code for the kernel..
Import the NetBSD micro ubsan code for the kernel.
Nov 6 2018, 4:57 PM

Nov 5 2018

andrew accepted D17841: gitv3_its: fixes for multiple GIC ITS blocks.
Nov 5 2018, 11:47 AM

Nov 1 2018

andrew added inline comments to D17791: acpica, pci_host_generic_acpi: redo pci_host_generic_acpi.c.
Nov 1 2018, 7:04 PM
andrew committed rS340013: Add the ARMv8.3 SCTLR_EL1 fields..
Add the ARMv8.3 SCTLR_EL1 fields.
Nov 1 2018, 5:43 PM
andrew committed rS340008: Add the ARMv8.3 HCR_EL2 register fields..
Add the ARMv8.3 HCR_EL2 register fields.
Nov 1 2018, 5:05 PM
andrew accepted D17657: pci_host_generic*: basic implementation of bus range.
Nov 1 2018, 12:17 PM · ARM
andrew accepted D17655: pci_host_generic: remove unneeded ThunderX2 quirk.
Nov 1 2018, 12:15 PM
andrew committed rS339988: Use the correct offsets for the trap frame in fork_trampoline..
Use the correct offsets for the trap frame in fork_trampoline.
Nov 1 2018, 10:25 AM

Oct 31 2018

andrew committed rS339961: Always set the MP_QUIRK_CPULIST quirk under ACPI. This needs a run time.
Always set the MP_QUIRK_CPULIST quirk under ACPI. This needs a run time
Oct 31 2018, 5:42 PM
andrew committed rS339948: Use pmap_invalidate_all rather than invalidating 512 level 2 entries in.
Use pmap_invalidate_all rather than invalidating 512 level 2 entries in
Oct 31 2018, 12:00 PM
andrew committed rS339945: Remove function prototypes for functions removed in r339943..
Remove function prototypes for functions removed in r339943.
Oct 31 2018, 10:30 AM
andrew committed rS339944: Fix some style(9) issues in the arm64 pmap_mapbios/unmapbios. Split lines.
Fix some style(9) issues in the arm64 pmap_mapbios/unmapbios. Split lines
Oct 31 2018, 9:39 AM
andrew committed rS339943: Remove the unused arm64_cpu driver..
Remove the unused arm64_cpu driver.
Oct 31 2018, 9:25 AM

Oct 30 2018

andrew committed rS339916: Build the csu tests on all architectures..
Build the csu tests on all architectures.
Oct 30 2018, 2:44 PM
andrew committed rS339913: Disable the .preinit_array test in DSOs, ld.bfd fails to link objects with.
Disable the .preinit_array test in DSOs, ld.bfd fails to link objects with
Oct 30 2018, 11:19 AM
andrew committed rS339912: Fix the location of the static keyword..
Fix the location of the static keyword.
Oct 30 2018, 10:16 AM
andrew committed rS339908: Run the csu tests on a DSO. This builds the tests into a shared library,.
Run the csu tests on a DSO. This builds the tests into a shared library,
Oct 30 2018, 9:43 AM
andrew committed rS339907: The jcr argument to _Jv_RegisterClasses is used, stop marking it otherwise..
The jcr argument to _Jv_RegisterClasses is used, stop marking it otherwise.
Oct 30 2018, 9:36 AM

Oct 29 2018

andrew committed rS339866: Make the .ctors, .dtors, and .jcr markers as static. They shouldn't be.
Make the .ctors, .dtors, and .jcr markers as static. They shouldn't be
Oct 29 2018, 5:55 PM
andrew committed rS339865: Include the csu test directories in BSD.tests.dist.
Include the csu test directories in BSD.tests.dist
Oct 29 2018, 5:13 PM
andrew committed rS339864: Check __dso_handle is NULL in non-DSO objects. It should only be non-NULL.
Check __dso_handle is NULL in non-DSO objects. It should only be non-NULL
Oct 29 2018, 5:03 PM

Oct 27 2018

andrew added a comment to D17716: arm64 acpi: parse proximity domain for CPUs and GIC ITS blocks.

It looks like the mp_machdep.c change could be committed separately from the rest.

Oct 27 2018, 11:29 AM · ARM
andrew added inline comments to D17717: pci_host_generic_acpi: use NUMA node when allocating MSI/MSI-X.
Oct 27 2018, 11:11 AM · ARM

Oct 26 2018

andrew committed rS339773: Add __dso_handle to the BSD crtbegin. This is used to identify shared.
Add __dso_handle to the BSD crtbegin. This is used to identify shared
Oct 26 2018, 11:53 AM
andrew committed rS339770: Drop the csu tests WARNS to 5 to fix the powerpc64 build..
Drop the csu tests WARNS to 5 to fix the powerpc64 build.
Oct 26 2018, 8:12 AM

Oct 25 2018

andrew added inline comments to D17587: Implement a BSD licensed crtbegin/crtend.
Oct 25 2018, 9:10 PM
andrew committed rS339744: Add a missing include for src.opts.mk. Without it MK_TESTS isn't defined..
Add a missing include for src.opts.mk. Without it MK_TESTS isn't defined.
Oct 25 2018, 9:08 PM
andrew committed rS339739: Regen src.conf.5 to add WITH_BSD_CRTBEGIN.
Regen src.conf.5 to add WITH_BSD_CRTBEGIN
Oct 25 2018, 5:42 PM
andrew committed rS339738: Implement a BSD licensed crtbegin/crtend.
Implement a BSD licensed crtbegin/crtend
Oct 25 2018, 5:40 PM
andrew closed D17587: Implement a BSD licensed crtbegin/crtend.
Oct 25 2018, 5:40 PM

Oct 24 2018

andrew updated the diff for D17587: Implement a BSD licensed crtbegin/crtend.
  • Add a C++ test
  • Add missing break statements to the default case in the fini switches
Oct 24 2018, 5:59 PM
andrew added inline comments to D17587: Implement a BSD licensed crtbegin/crtend.
Oct 24 2018, 5:20 PM
andrew updated the diff for D17587: Implement a BSD licensed crtbegin/crtend.

Use .Pa

Oct 24 2018, 5:15 PM
andrew updated the diff for D17587: Implement a BSD licensed crtbegin/crtend.

Update based on feedback from emaste
Rework how the tests are built

Oct 24 2018, 5:02 PM
andrew updated the diff for D17587: Implement a BSD licensed crtbegin/crtend.

Add simple crtbegin/crtend tests

Oct 24 2018, 3:40 PM

Oct 23 2018

andrew updated the diff for D17587: Implement a BSD licensed crtbegin/crtend.
  • Add a tab before instructions in the .init section
  • Fix a logic inversion in an ifdef
Oct 23 2018, 4:31 PM
andrew updated the diff for D17587: Implement a BSD licensed crtbegin/crtend.
  • Add $FreeBSD$ to header files
  • Add WITH/WITHOUT descriptions
  • Remove HAVE_INITFINI_ARRAY and replace with HAVE_CTORS and CTORS_CONSTRUCTORS
Oct 23 2018, 4:18 PM
andrew updated the diff for D17587: Implement a BSD licensed crtbegin/crtend.
  • Update the license
  • Add i386 support
  • Add a build option to enable
Oct 23 2018, 3:40 PM
andrew added inline comments to D17657: pci_host_generic*: basic implementation of bus range.
Oct 23 2018, 9:14 AM · ARM
andrew accepted D17656: pci_host_generic: allocate resources against devices.
Oct 23 2018, 9:11 AM · ARM
andrew added a comment to D17655: pci_host_generic: remove unneeded ThunderX2 quirk.

Is there an easy way to tell which revision silicon we have? I'd like to check the TX2 I have access to.

Oct 23 2018, 9:10 AM
andrew added reviewers for D17659: acpica, pci_host_generic_acpi: redo pci_host_generic_acpi.c: jhb, rstone.
Oct 23 2018, 9:05 AM · ARM

Oct 22 2018

andrew committed rS339594: Stop advertising ARMv8.3 Pointer Authentication.
Stop advertising ARMv8.3 Pointer Authentication
Oct 22 2018, 3:19 PM
andrew committed rS339593: Fix the ID_AA64ISAR0_EL1 dot product field shift..
Fix the ID_AA64ISAR0_EL1 dot product field shift.
Oct 22 2018, 3:06 PM
andrew committed rS339592: Correctly set the DAIF bits in new threads.
Correctly set the DAIF bits in new threads
Oct 22 2018, 2:59 PM

Oct 21 2018

andrew committed rS339540: Split out the virtio mmio FDT attachment and add an ACPI attachment..
Split out the virtio mmio FDT attachment and add an ACPI attachment.
Oct 21 2018, 3:43 PM

Oct 18 2018

andrew added a comment to D17587: Implement a BSD licensed crtbegin/crtend.
In D17587#375979, @kib wrote:

But I do not object against providing the call to .ctors, I am confused by the platforms selection for such compatibility, and by the names (Andrew promised to fix the later).

Oct 18 2018, 9:58 PM
andrew added a comment to D17587: Implement a BSD licensed crtbegin/crtend.
In D17587#375744, @kib wrote:

After some investigation, I see that crtbegin/crtend.o are shipped with compilers, at least it does with gcc. So I do not see a reason to provide the .ctor fallback for e.g. amd64 or i386: in-tree compiler does not need it, and out-of-tree gcc should cope on its own.

Oct 18 2018, 11:42 AM

Oct 17 2018

andrew updated the diff for D17587: Implement a BSD licensed crtbegin/crtend.

Add the missing Makefile include for powerpc64

Oct 17 2018, 5:25 PM
andrew updated the diff for D17587: Implement a BSD licensed crtbegin/crtend.

Call register_classes from .init. When called from a constructor on ppc64
it will be added to the .ctors section, but before CTOR_LIST so won't
be called.

Oct 17 2018, 5:23 PM
andrew added inline comments to D17587: Implement a BSD licensed crtbegin/crtend.
Oct 17 2018, 4:21 PM
andrew updated the diff for D17587: Implement a BSD licensed crtbegin/crtend.

Use .pushsection & .popsection

Oct 17 2018, 12:07 PM
andrew added inline comments to D17587: Implement a BSD licensed crtbegin/crtend.
Oct 17 2018, 11:49 AM
andrew added inline comments to D14599: Implement kernel code coverage (kcov).
Oct 17 2018, 9:02 AM

Oct 16 2018

andrew added a reviewer for D17587: Implement a BSD licensed crtbegin/crtend: kib.
Oct 16 2018, 5:46 PM
andrew updated the diff for D17587: Implement a BSD licensed crtbegin/crtend.

Set the first item in .ctors/.dtors to all 1's

Oct 16 2018, 5:44 PM
andrew added inline comments to D17587: Implement a BSD licensed crtbegin/crtend.
Oct 16 2018, 4:33 PM
andrew created D17587: Implement a BSD licensed crtbegin/crtend.
Oct 16 2018, 4:31 PM

Oct 10 2018

andrew updated the diff for D17497: Correctly set the DAIF bits in new threads.

Fix the name of the source thread

Oct 10 2018, 8:06 AM
andrew created D17497: Correctly set the DAIF bits in new threads.
Oct 10 2018, 7:57 AM

Oct 6 2018

andrew added inline comments to D17439: Make it possible to disable NUMA support with a tunable..
Oct 6 2018, 9:34 AM

Oct 1 2018

andrew committed rS339074: Add kernel ifunc support on arm64..
Add kernel ifunc support on arm64.
Oct 1 2018, 6:51 PM
andrew closed D17370: Add kernel ifunc support on arm64.
Oct 1 2018, 6:51 PM
andrew added inline comments to D17370: Add kernel ifunc support on arm64.
Oct 1 2018, 5:47 PM
andrew added inline comments to D17370: Add kernel ifunc support on arm64.
Oct 1 2018, 3:15 PM
andrew updated the diff for D17370: Add kernel ifunc support on arm64.
  • Move link_elf_ireloc earlier in the boot
  • Include all the arguments in DEFINE_UIFUNC
Oct 1 2018, 3:15 PM
andrew committed rS339041: Add STT_GNU_IFUNC and R_AARCH64_IRELATIVE support on arm64..
Add STT_GNU_IFUNC and R_AARCH64_IRELATIVE support on arm64.
Oct 1 2018, 2:02 PM
andrew closed D17341: Add STT_GNU_IFUNC and R_AARCH64_IRELATIVE support on arm64..
Oct 1 2018, 2:02 PM
andrew created D17370: Add kernel ifunc support on arm64.
Oct 1 2018, 11:23 AM

Sep 28 2018

andrew updated the diff for D17341: Add STT_GNU_IFUNC and R_AARCH64_IRELATIVE support on arm64..

Pass in zeros to call_ifunc_resolver so we can change them later

Sep 28 2018, 2:22 PM
andrew committed rS338994: Export ID_AA64ISAR{0,1}_EL1 to userland..
Export ID_AA64ISAR{0,1}_EL1 to userland.
Sep 28 2018, 11:57 AM
andrew added inline comments to D17341: Add STT_GNU_IFUNC and R_AARCH64_IRELATIVE support on arm64..
Sep 28 2018, 11:22 AM
andrew updated the diff for D17341: Add STT_GNU_IFUNC and R_AARCH64_IRELATIVE support on arm64..

Remove break statements that shouldn't be there.

Sep 28 2018, 11:22 AM
andrew updated the diff for D17341: Add STT_GNU_IFUNC and R_AARCH64_IRELATIVE support on arm64..

Style

Sep 28 2018, 8:44 AM