andrew (Andrew Turner)
User

Projects

User Details

User Since
May 10 2014, 2:21 PM (214 w, 3 d)

Recent Activity

Yesterday

andrew added inline comments to D15141: Add support for ThunderX2 PCIe.
Tue, Jun 19, 4:58 PM
andrew committed rS335373: Move common GIC interrupt numbers to the common header. These are the same.
Move common GIC interrupt numbers to the common header. These are the same
Tue, Jun 19, 4:14 PM
andrew added inline comments to D15834: arm64 linuxulator: arm64 linux64 sysvec.
Tue, Jun 19, 1:48 PM
andrew accepted D15834: arm64 linuxulator: arm64 linux64 sysvec.
Tue, Jun 19, 8:10 AM

Mon, Jun 18

andrew accepted D15832: Stub arm64 linuxulator routines.
Mon, Jun 18, 5:06 PM

Fri, Jun 15

andrew added a comment to D15832: Stub arm64 linuxulator routines.

Should there be a license on these files?

Fri, Jun 15, 10:43 PM
andrew accepted D15237: linuxulator: do not include legacy syscalls on arm64.
Fri, Jun 15, 2:03 PM
andrew added a comment to D15237: linuxulator: do not include legacy syscalls on arm64.

How will this work if we decide to add linux32 on arm64? I expect we will need to implement the legacy syscalls there.

Fri, Jun 15, 1:21 PM
andrew created D15819: Implement the SSBD (CVE-2018-3639) workaround on arm64.
Fri, Jun 15, 10:08 AM

Wed, Jun 13

andrew added a comment to D15787: support for uart_dev_mu for RPI2, RPI-B.

Do you know why the kernel hangs with this?

Wed, Jun 13, 4:20 PM
andrew committed rS335065: Add ThunderX2 to the list of CPUs we need to apply the branch predictor.
Add ThunderX2 to the list of CPUs we need to apply the branch predictor
Wed, Jun 13, 3:58 PM
andrew committed rS335064: Switch to the SMCCC function for branch predictor hardening. The previous.
Switch to the SMCCC function for branch predictor hardening. The previous
Wed, Jun 13, 3:56 PM
andrew committed rS335063: Add the SMCCC return codes from ARM DEN 0070A..
Add the SMCCC return codes from ARM DEN 0070A.
Wed, Jun 13, 3:41 PM
andrew committed rS335062: Add support for the ARM SMC Calling Convention (SMCCC). This is a method.
Add support for the ARM SMC Calling Convention (SMCCC). This is a method
Wed, Jun 13, 3:32 PM
andrew committed rS335061: Move psci_call to a header file so we can use it in other files to.
Move psci_call to a header file so we can use it in other files to
Wed, Jun 13, 3:24 PM
andrew committed rS335056: Add a handler for the PSCI_FEATURES function. This needs PSCI 1.0, so.
Add a handler for the PSCI_FEATURES function. This needs PSCI 1.0, so
Wed, Jun 13, 12:34 PM
andrew committed rS335055: Find and cache the PSCI version on driver attach..
Find and cache the PSCI version on driver attach.
Wed, Jun 13, 12:32 PM
andrew committed rS335054: Add the PSCI_FEATURES function ID. This is found in PSCI 1.0 and is used.
Add the PSCI_FEATURES function ID. This is found in PSCI 1.0 and is used
Wed, Jun 13, 12:26 PM
andrew committed rS335052: Rename the ThunderX CPU identification macros to include the X. This is the.
Rename the ThunderX CPU identification macros to include the X. This is the
Wed, Jun 13, 12:17 PM
andrew committed rS335051: Add more Cavium CPU part numbers..
Add more Cavium CPU part numbers.
Wed, Jun 13, 11:59 AM

Tue, Jun 12

andrew committed rS334999: Rework PSCI so it only searches for the call function once..
Rework PSCI so it only searches for the call function once.
Tue, Jun 12, 2:54 PM
andrew closed D15745: Rework PSCI so it only searches for the call function once..
Tue, Jun 12, 2:54 PM
andrew updated the diff for D15745: Rework PSCI so it only searches for the call function once..

Remove unused variables

Tue, Jun 12, 1:49 PM

Sun, Jun 10

andrew updated the diff for D15745: Rework PSCI so it only searches for the call function once..

Stop exporting psci_find_callfn, it's not needed out of psci.c

Sun, Jun 10, 8:31 PM
andrew created D15745: Rework PSCI so it only searches for the call function once..
Sun, Jun 10, 8:26 PM
andrew committed rS334932: Remove the psci option from arm64. It is now a standard option as it is.
Remove the psci option from arm64. It is now a standard option as it is
Sun, Jun 10, 7:42 PM
andrew committed rS334926: Clean up handling of unexpected exceptions. Previously we would issue a.
Clean up handling of unexpected exceptions. Previously we would issue a
Sun, Jun 10, 4:21 PM
andrew accepted D15684: Add a driver for the BCM2835 Mini-UART.
Sun, Jun 10, 3:15 PM

Sat, Jun 9

andrew added inline comments to D15684: Add a driver for the BCM2835 Mini-UART.
Sat, Jun 9, 8:31 PM
andrew committed rS334880: In the ThunderX BGX network driver we were skipping the NULL terminator.
In the ThunderX BGX network driver we were skipping the NULL terminator
Sat, Jun 9, 2:48 PM

Thu, Jun 7

andrew added inline comments to D15684: Add a driver for the BCM2835 Mini-UART.
Thu, Jun 7, 12:24 AM

Thu, May 31

andrew committed rS334424: Move the code to print the EFI memory table to a new function and call it.
Move the code to print the EFI memory table to a new function and call it
Thu, May 31, 12:37 PM
andrew committed rS334421: Fix the early spelling of bootverbose..
Fix the early spelling of bootverbose.
Thu, May 31, 11:53 AM
andrew committed rS334420: Fix the memory attribute for EFI_MD_ATTR_UC on arm64..
Fix the memory attribute for EFI_MD_ATTR_UC on arm64.
Thu, May 31, 11:11 AM

Wed, May 30

andrew committed rS334387: Remove max_pa, it's unused..
Remove max_pa, it's unused.
Wed, May 30, 3:37 PM
andrew committed rS334385: Further limit when we call pmap_fault..
Further limit when we call pmap_fault.
Wed, May 30, 3:26 PM
andrew committed rS334382: Push down the locking in pmap_fault to just be around the calls to.
Push down the locking in pmap_fault to just be around the calls to
Wed, May 30, 2:18 PM

Tue, May 29

andrew committed rS334341: Increase the number of fdt memory regions we support to 16. Some SoCs have.
Increase the number of fdt memory regions we support to 16. Some SoCs have
Tue, May 29, 5:44 PM
andrew committed rS334329: On ThunderX2 we need to be careful to only map the memory the firmware.
On ThunderX2 we need to be careful to only map the memory the firmware
Tue, May 29, 1:52 PM

Mon, May 28

andrew committed rS334289: Create a new function to walk the EFI memory table & run a callback for.
Create a new function to walk the EFI memory table & run a callback for
Mon, May 28, 5:09 PM

Thu, May 24

andrew committed rS334164: Remove physmap from the arm64 machdep.h. This was missed in r334162..
Remove physmap from the arm64 machdep.h. This was missed in r334162.
Thu, May 24, 4:07 PM
andrew committed rS334162: Allow us to read the physmap data into our own array and use this to build.
Allow us to read the physmap data into our own array and use this to build
Thu, May 24, 3:33 PM
andrew committed rS334157: Print the physmem tables under a verbose boot..
Print the physmem tables under a verbose boot.
Thu, May 24, 3:08 PM
andrew accepted D15539: Don't implement break(2) at all on aarch64 and riscv..
Thu, May 24, 2:59 PM
andrew committed rS334155: Exclude memory from the /reserved-memory mappings with the no-map property.
Exclude memory from the /reserved-memory mappings with the no-map property
Thu, May 24, 2:56 PM

Tue, May 22

andrew committed rS334056: Handle reserved memory with the no-map property..
Handle reserved memory with the no-map property.
Tue, May 22, 4:04 PM
andrew closed D15518: Handle reserved memory with the no-map property.
Tue, May 22, 4:04 PM
andrew committed rS334052: Revert r334035 for now. It breaks the boot on some boards as er expect to.
Revert r334035 for now. It breaks the boot on some boards as er expect to
Tue, May 22, 3:52 PM
andrew committed rS334045: Pass the array length into regions_to_avail..
Pass the array length into regions_to_avail.
Tue, May 22, 2:27 PM
andrew committed rS334037: Only set realmem based on memory where the EXFLAG_NOALLOC is unset. This.
Only set realmem based on memory where the EXFLAG_NOALLOC is unset. This
Tue, May 22, 1:21 PM
andrew created D15518: Handle reserved memory with the no-map property.
Tue, May 22, 11:39 AM
andrew committed rS334035: On ThunderX2 we need to be careful to only map the memory the firmware.
On ThunderX2 we need to be careful to only map the memory the firmware
Tue, May 22, 11:27 AM
andrew committed rS334033: Stop using the DMAP region to map ACPI memory..
Stop using the DMAP region to map ACPI memory.
Tue, May 22, 11:16 AM
andrew closed D15059: Map ACPI memory in ARM64 pmap.
Tue, May 22, 11:16 AM
andrew committed rS334032: Switch arm64 to use the same physmem code as 32-bit arm..
Switch arm64 to use the same physmem code as 32-bit arm.
Tue, May 22, 11:07 AM
andrew committed rS334030: Allow the 32-bit arm physmem code to work on arm64..
Allow the 32-bit arm physmem code to work on arm64.
Tue, May 22, 10:31 AM
andrew committed rS334028: Coalesce adjacent physical mappings..
Coalesce adjacent physical mappings.
Tue, May 22, 10:14 AM
andrew closed D15477: Coalesce adjacent physical mappings.
Tue, May 22, 10:14 AM

Mon, May 21

andrew committed rS333985: Restrict the faulting addresses we call pmap_fault from to just those that.
Restrict the faulting addresses we call pmap_fault from to just those that
Mon, May 21, 4:15 PM

May 18 2018

andrew updated subscribers of D15477: Coalesce adjacent physical mappings.
May 18 2018, 1:58 PM
andrew created D15477: Coalesce adjacent physical mappings.
May 18 2018, 1:58 PM
andrew committed rS333786: Enable the Qualcomm MSM UART driver. This is needed for some Qualcomm.
Enable the Qualcomm MSM UART driver. This is needed for some Qualcomm
May 18 2018, 11:33 AM

May 15 2018

andrew committed rS333636: Increase the number of pages we allocate in the arm64 early boot. We are.
Increase the number of pages we allocate in the arm64 early boot. We are
May 15 2018, 4:44 PM

May 8 2018

andrew added a comment to D15359: DTrace aarch64: Avoid calling unwind_frame() in the probe context.

Why not just exclude it in fbt_provide_module_function? I'd prefer we keep the unwinding code together, maybe with a comment that it may be called from such a context.

May 8 2018, 9:15 PM · arm64, DTrace
andrew added a comment to D15059: Map ACPI memory in ARM64 pmap.

Can you update the proposed commit message. I'm happy with the change, other than we should be clearing the mapping in pmap_unmapbios.

May 8 2018, 1:35 PM

Apr 25 2018

andrew added inline comments to D15191: Export a breakpoint() function to userland..
Apr 25 2018, 5:09 PM
andrew accepted D15187: add arm64 linux syscall table.
Apr 25 2018, 5:01 PM
andrew added inline comments to D15191: Export a breakpoint() function to userland..
Apr 25 2018, 9:50 AM
andrew added a comment to D15187: add arm64 linux syscall table.

It looks like the syscalls starting at 1024 have been removed: https://github.com/torvalds/linux/commit/a0673fdbcd42105261646cd4f3447455b5854a32

Apr 25 2018, 8:36 AM

Apr 24 2018

andrew added a comment to D15141: Add support for ThunderX2 PCIe.

It is good idea to provide support using quirks, however pci_host_generic_acpi still needs some resource allocation changes. I have limited ability to check if it doesn't break another devices, so from my point of view it is safe to provide separate driver.

Apr 24 2018, 12:41 PM

Apr 20 2018

andrew added a reviewer for D15141: Add support for ThunderX2 PCIe: jhb.
Apr 20 2018, 2:42 PM
andrew requested changes to D15141: Add support for ThunderX2 PCIe.

You should restructure the pci_host_generic_acpi code to handle this so you don't need to copy and paste so much of it in this driver, or even better handle ThunderX2 in the existing driver with quirks.

Apr 20 2018, 2:42 PM

Apr 17 2018

andrew accepted D15102: Remove the unused fuwintr() and suiwintr() functions..
Apr 17 2018, 4:39 PM
andrew added a comment to D15102: Remove the unused fuwintr() and suiwintr() functions..

Do we need to add the removed MLINKS to ObsoleteFiles.inc?

Apr 17 2018, 7:54 AM
andrew accepted D15108: Remove unused implementations of copyoutstr..
Apr 17 2018, 7:51 AM

Apr 15 2018

andrew added a comment to D15067: spigen overlays for RPI-B, RPI-2 in base (was: possible new port for spigen overlay for Raspberry Pi).

Why a port and not put the overlay in the base system?

Apr 15 2018, 5:35 PM

Apr 13 2018

andrew added inline comments to D15059: Map ACPI memory in ARM64 pmap.
Apr 13 2018, 6:51 PM
andrew added a comment to D15059: Map ACPI memory in ARM64 pmap.

Can you provide more context. If you are uploading a patch via the web interface there are instructions on the wiki to ensure this is the case at https://wiki.freebsd.org/Phabricator#Create_a_Revision_via_Web_Interface

Apr 13 2018, 6:16 PM

Apr 8 2018

andrew committed rS332309: Replace calls to fdt_is_compatible with ofw_bus_node_is_compatible. These.
Replace calls to fdt_is_compatible with ofw_bus_node_is_compatible. These
Apr 8 2018, 10:07 PM
andrew committed rS332278: Revert r332277, it contained an unintended extra change.
Revert r332277, it contained an unintended extra change
Apr 8 2018, 3:21 PM
andrew committed rS332277: Replace calls to fdt_is_compatible with ofw_bus_node_is_compatible. These.
Replace calls to fdt_is_compatible with ofw_bus_node_is_compatible. These
Apr 8 2018, 3:12 PM
andrew committed rS332274: Move fdt_is_type to be a Marvell specific function. It's not used by any.
Move fdt_is_type to be a Marvell specific function. It's not used by any
Apr 8 2018, 12:20 PM

Apr 7 2018

andrew added a comment to D14989: Replace exect() with a portable version.

@andrew It is exposed in unistd.h and the documentation doesn't say it's specific to a particular platform.

Apr 7 2018, 6:42 AM

Apr 6 2018

andrew added a comment to D14989: Replace exect() with a portable version.

Doesn't this add it on architectures where it wasn't implemented? It doesn't seem to be implemented on arm, arm64, or riscv. It's implemented on mips, but is not in the Symbols.map file so will not be exposed in libc.so.7 and could be removed.

Apr 6 2018, 3:58 PM

Apr 4 2018

andrew committed rS332026: Remove fdt_pm_is_enabled as it's Marvell specific. Replace the only call to.
Remove fdt_pm_is_enabled as it's Marvell specific. Replace the only call to
Apr 4 2018, 1:38 PM

Apr 3 2018

andrew committed rS331925: Remove fdt_is_enabled, fdt_reg_to_rl, and fdt_get_unit. These are not used.
Remove fdt_is_enabled, fdt_reg_to_rl, and fdt_get_unit. These are not used
Apr 3 2018, 1:30 PM
andrew committed rS331924: Switch users of fdt_is_enabled to use ofw_bus_node_status_okay. These are.
Switch users of fdt_is_enabled to use ofw_bus_node_status_okay. These are
Apr 3 2018, 11:02 AM

Apr 2 2018

andrew committed rS331877: Add the missing header for malloc(9). It was pulled in through header.
Add the missing header for malloc(9). It was pulled in through header
Apr 2 2018, 1:37 PM

Mar 23 2018

andrew updated the diff for D5881: Allwinner USB DRD support (musb_otg).

Rebase

Mar 23 2018, 11:10 AM · ARM
andrew reopened D5881: Allwinner USB DRD support (musb_otg).
Mar 23 2018, 11:09 AM · ARM
andrew committed rS331421: If sc->sc_ep_max is already set use it to find the number of RX and TX.
If sc->sc_ep_max is already set use it to find the number of RX and TX
Mar 23 2018, 11:09 AM
andrew closed D5881: Allwinner USB DRD support (musb_otg).
Mar 23 2018, 11:09 AM · ARM
andrew updated the diff for D5881: Allwinner USB DRD support (musb_otg).

Fix an include

Mar 23 2018, 10:35 AM · ARM

Mar 22 2018

andrew updated the diff for D5881: Allwinner USB DRD support (musb_otg).

Rebase

Mar 22 2018, 6:52 PM · ARM
andrew created D14796: Set the correct endpoint in the EPINDEX register.
Mar 22 2018, 4:06 PM
andrew committed rS331361: Enter into the EFI environment before dereferencing the runtime services.
Enter into the EFI environment before dereferencing the runtime services
Mar 22 2018, 3:33 PM
andrew committed rS331360: Increase the size of the endpoint buffers. They are double buffered so.
Increase the size of the endpoint buffers. They are double buffered so
Mar 22 2018, 3:24 PM

Mar 21 2018

andrew added inline comments to D14744: Use PLATFORM for initializing Marvell ArmadaXP and Armada38X.
Mar 21 2018, 6:27 PM · ARM
andrew committed rS331306: Use a table to find the endpoint configuration.
Use a table to find the endpoint configuration
Mar 21 2018, 3:18 PM
andrew closed D14783: Use a table to find the endpoint configuration.
Mar 21 2018, 3:17 PM