Page MenuHomeFreeBSD

andrew (Andrew Turner)
User

Projects

User Details

User Since
May 10 2014, 2:21 PM (332 w, 5 d)

Recent Activity

Today

andrew committed rS366111: Clean up the arm64 bus_dma_run_filter.
Clean up the arm64 bus_dma_run_filter
Thu, Sep 24, 10:42 AM
andrew committed rS366110: Ensure arm64 DMA alignment is passed from parents to children.
Ensure arm64 DMA alignment is passed from parents to children
Thu, Sep 24, 10:41 AM
andrew committed rS366106: Bounce in more cases in the arm64 busdma.
Bounce in more cases in the arm64 busdma
Thu, Sep 24, 7:17 AM
andrew closed D26496: Bounce in more cases in the arm64 busdma.
Thu, Sep 24, 7:17 AM
andrew committed rS366105: Ensure we always align and size arm64 busdma allocations to a cacheline.
Ensure we always align and size arm64 busdma allocations to a cacheline
Thu, Sep 24, 7:13 AM
andrew closed D26495: Ensure we always align and size arm64 busdma allocations to a cacheline.
Thu, Sep 24, 7:13 AM
andrew committed rS366103: Add a coherent flag on the arm64 dma map struct.
Add a coherent flag on the arm64 dma map struct
Thu, Sep 24, 7:08 AM
andrew closed D26494: Add a coherent flag on the arm64 dma map struct.
Thu, Sep 24, 7:08 AM
andrew committed rS366102: Add bounce helpers to the arm64 busdma.
Add bounce helpers to the arm64 busdma
Thu, Sep 24, 7:03 AM
andrew closed D26493: Add bounce helpers to the arm64 busdma.
Thu, Sep 24, 7:03 AM

Yesterday

andrew updated the diff for D26496: Bounce in more cases in the arm64 busdma.

Remove debugging

Wed, Sep 23, 9:48 AM
andrew updated the diff for D26495: Ensure we always align and size arm64 busdma allocations to a cacheline.

Remove debugging

Wed, Sep 23, 9:47 AM
andrew added inline comments to D26495: Ensure we always align and size arm64 busdma allocations to a cacheline.
Wed, Sep 23, 9:41 AM
andrew updated the diff for D26496: Bounce in more cases in the arm64 busdma.

Update after more testing

Wed, Sep 23, 9:37 AM
andrew updated the diff for D26495: Ensure we always align and size arm64 busdma allocations to a cacheline.

Update after more testing

Wed, Sep 23, 9:36 AM
andrew updated the diff for D26494: Add a coherent flag on the arm64 dma map struct.

Update after more testing

Wed, Sep 23, 9:36 AM
andrew updated the diff for D26493: Add bounce helpers to the arm64 busdma.

Update after more testing

Wed, Sep 23, 9:36 AM

Mon, Sep 21

andrew accepted D26510: Weaken assertions in pmap_l1_to_l2() and pmap_l2_to_l3()..
Mon, Sep 21, 3:32 PM

Sun, Sep 20

andrew requested review of D26496: Bounce in more cases in the arm64 busdma.
Sun, Sep 20, 3:38 PM
andrew requested review of D26495: Ensure we always align and size arm64 busdma allocations to a cacheline.
Sun, Sep 20, 3:37 PM
andrew requested review of D26494: Add a coherent flag on the arm64 dma map struct.
Sun, Sep 20, 3:37 PM
andrew requested review of D26493: Add bounce helpers to the arm64 busdma.
Sun, Sep 20, 3:36 PM

Fri, Sep 18

andrew accepted D26465: Assert we are not traversing through superpages in the arm64 pmap..
Fri, Sep 18, 7:41 AM

Tue, Sep 15

andrew committed rS365750: Use ATTR_DEFAULT in the arm64 locore.S.
Use ATTR_DEFAULT in the arm64 locore.S
Tue, Sep 15, 2:15 PM

Mon, Sep 14

andrew added inline comments to D26399: [PowerPC64LE] Set up powerpc.powerpc64le architecture.
Mon, Sep 14, 7:52 PM · PowerPC
andrew committed rS365727: Cleanups for gprof:.
Cleanups for gprof:
Mon, Sep 14, 4:19 PM
andrew closed D26369: Clean up gprof.
Mon, Sep 14, 4:19 PM
andrew committed rS365726: Use MACHINE_CPUARCH when checking for arm64.
Use MACHINE_CPUARCH when checking for arm64
Mon, Sep 14, 4:12 PM
andrew closed D26370: Use MACHINE_CPUARCH when checking for arm64.
Mon, Sep 14, 4:12 PM
andrew committed rS365709: Allow for interrupts on pl061 children.
Allow for interrupts on pl061 children
Mon, Sep 14, 8:59 AM

Thu, Sep 10

andrew committed rS365579: Move the pl061 acpi attachment earlier.
Move the pl061 acpi attachment earlier
Thu, Sep 10, 2:59 PM
andrew added a comment to D24787: Link efi programs with -pie rather than -shared.

I've committed the arm64 fix in rS365578.

Thu, Sep 10, 2:14 PM
andrew committed rS365578: Ignore the .interp section in the arm64 EFI loader.
Ignore the .interp section in the arm64 EFI loader
Thu, Sep 10, 2:14 PM
andrew committed rS365559: Switch the name of the pl061 driver to gpio.
Switch the name of the pl061 driver to gpio
Thu, Sep 10, 9:51 AM
andrew committed rS365558: Only manage ofw gpio providers on ofw systems.
Only manage ofw gpio providers on ofw systems
Thu, Sep 10, 9:42 AM
andrew committed rS365557: Use the correct variable to check which interrupt mode to use.
Use the correct variable to check which interrupt mode to use
Thu, Sep 10, 9:37 AM

Wed, Sep 9

andrew added a comment to D26369: Clean up gprof.

I have no idea, although if we remove it I think it should be a second change that could be easily reverted if needed.

Wed, Sep 9, 8:26 PM
andrew updated the diff for D26369: Clean up gprof.

Only support i386 & amd64

Wed, Sep 9, 4:16 PM
andrew added inline comments to D26369: Clean up gprof.
Wed, Sep 9, 4:16 PM
andrew added a comment to D26360: PCI function address aliasing support.

Why is it in the pci code rather then iommu? I could imagine broken non-pci devices could also need a DMA alias.

Wed, Sep 9, 10:44 AM
andrew requested review of D26370: Use MACHINE_CPUARCH when checking for arm64.
Wed, Sep 9, 10:38 AM
andrew added reviewers for D26369: Clean up gprof: brooks, brett_gutste.in.
Wed, Sep 9, 10:34 AM
andrew updated the summary of D26369: Clean up gprof.
Wed, Sep 9, 10:26 AM
andrew requested review of D26369: Clean up gprof.
Wed, Sep 9, 10:24 AM

Tue, Sep 8

andrew committed rS365451: Move gpio and hwpmc to the correct place in files.arm64.
Move gpio and hwpmc to the correct place in files.arm64
Tue, Sep 8, 11:46 AM
andrew closed D24065: Add Arm pl061 GPIO driver.
Tue, Sep 8, 11:35 AM
andrew committed rS365450: Add a GPIO driver for the Arm pl061 controller.
Add a GPIO driver for the Arm pl061 controller
Tue, Sep 8, 11:35 AM
andrew added a comment to D26354: amd64: prevent KCSan false positives on LAPIC mapping.

Normally non-WB memory would be accessed via bus_space. KCSan will ignore these.

Tue, Sep 8, 10:41 AM
andrew accepted D26354: amd64: prevent KCSan false positives on LAPIC mapping.
Tue, Sep 8, 10:04 AM
andrew added inline comments to D26344: bcm2838_pci.c: Respect DMA limits of controller..
Tue, Sep 8, 8:11 AM

Mon, Sep 7

andrew updated the diff for D24065: Add Arm pl061 GPIO driver.

Remove a gpiokeys change

Mon, Sep 7, 3:38 PM
andrew updated the diff for D24065: Add Arm pl061 GPIO driver.
  • Style fixes
  • Split out the ACPI attachment
  • Add an FDT attachment
Mon, Sep 7, 3:36 PM
andrew commandeered D24065: Add Arm pl061 GPIO driver.

Grab as I have style fixes & FDT support

Mon, Sep 7, 3:36 PM

Sat, Sep 5

andrew added inline comments to D26338: Correct COMMENT of devel/*-elf-gcc.
Sat, Sep 5, 8:21 PM

Thu, Sep 3

andrew committed rS365296: Switch to an empty ttbr0 pagetable when the MMU is enabled.
Switch to an empty ttbr0 pagetable when the MMU is enabled
Thu, Sep 3, 10:11 AM
andrew closed D22606: Switch to an empty ttbr0 pagetable when the MMU is enabled.
Thu, Sep 3, 10:11 AM

Wed, Sep 2

andrew committed rS365247: When CPUTYPE is an architecture name use -march.
When CPUTYPE is an architecture name use -march
Wed, Sep 2, 11:53 AM
andrew committed rS365234: Partially revert r365069..
Partially revert r365069.
Wed, Sep 2, 9:04 AM

Tue, Sep 1

andrew committed rS365039: Ensure the tlbi has completed before setting SCTLR.
Ensure the tlbi has completed before setting SCTLR
Tue, Sep 1, 2:50 PM
andrew updated the diff for D22606: Switch to an empty ttbr0 pagetable when the MMU is enabled.

Invalidate the tlb after calling set_ttbr0

Tue, Sep 1, 2:31 PM
andrew updated the diff for D26083: Add support to switch the arm64 EL2 vector after boot.

Remove an unneeded dsb

Tue, Sep 1, 1:55 PM
andrew added inline comments to D26083: Add support to switch the arm64 EL2 vector after boot.
Tue, Sep 1, 1:53 PM
andrew added inline comments to D26066: Allow the creation of 3 level page tables.
Tue, Sep 1, 1:32 PM
andrew updated the diff for D26066: Allow the creation of 3 level page tables.
  • Store the ttbr address so we don't need to walk the page tables
  • Free pages in pmap_release
  • Update the wording of a comment in pmap_pinit_stage
Tue, Sep 1, 1:32 PM
andrew closed D26065: Support stage 2 arm64 pmap in more places.
Tue, Sep 1, 11:03 AM
andrew committed rS365031: Support stage 2 arm64 pmap in more places.
Support stage 2 arm64 pmap in more places
Tue, Sep 1, 11:03 AM

Aug 25 2020

andrew added inline comments to D26072: Add support for PMU on SMP systems for ARM64.
Aug 25 2020, 1:09 PM
andrew added inline comments to D24423: arm/pmu: add ACPI attachment, more FDT names.
Aug 25 2020, 8:56 AM · arm64
andrew accepted D26177: vchi: rename bitset macros to avoid collision with bitset(9).
Aug 25 2020, 8:44 AM

Aug 24 2020

andrew added inline comments to D26083: Add support to switch the arm64 EL2 vector after boot.
Aug 24 2020, 9:12 AM

Aug 21 2020

andrew accepted D26133: arm64/acpi: Give the real PA limit to ACPI.
Aug 21 2020, 9:55 AM
andrew updated the diff for D26083: Add support to switch the arm64 EL2 vector after boot.
  • Remove "All rights reserved"
  • Fix spelling
  • Use the argument to vector_tail
Aug 21 2020, 9:51 AM

Aug 20 2020

andrew added inline comments to D26083: Add support to switch the arm64 EL2 vector after boot.
Aug 20 2020, 8:02 PM
andrew added a comment to D26135: Introduce bus_dma_tag_create_device.

Not yet, I'm planning on that soon.

Aug 20 2020, 4:31 PM
andrew added a comment to D26135: Introduce bus_dma_tag_create_device.

I expect to commit this in multiple commits, but need to figure out where the best places to split are.

Aug 20 2020, 2:46 PM
andrew requested review of D26135: Introduce bus_dma_tag_create_device.
Aug 20 2020, 2:36 PM
andrew added a comment to D26133: arm64/acpi: Give the real PA limit to ACPI.

You should use get_kernel_reg to read the ID registers when we need a common version over all CPUs. It's not going to affect it here, but when use later in the boot it can as on a big.LITTLE system these ID registers can sometimes be different across the different core types.

Aug 20 2020, 7:49 AM
andrew accepted D26134: arm64: Increase dmap size to 95 TiB.

We only map physical memory that exists, so this shouldn't cause a problem on existing systems.

Aug 20 2020, 7:35 AM
andrew added reviewers for D26083: Add support to switch the arm64 EL2 vector after boot: mhorne, markj.
Aug 20 2020, 6:51 AM

Aug 19 2020

andrew accepted D26108: Add a man page for kcov..
Aug 19 2020, 4:31 PM
andrew committed rS364393: Mark COVERAGE and KCOV as part of KCSAN.
Mark COVERAGE and KCOV as part of KCSAN
Aug 19 2020, 2:11 PM
andrew added a comment to D26108: Add a man page for kcov..
In D26108#579497, @gbe wrote:

Good to go from manpages!

It would maybe feasible to include a notice about incompatibles about other kernel santinzing options.
I remember that I tried to build a kernel once with following options, which was not possible:

include GENERIC
ident GENERIC-SANTI
options		COVERAGE
options		KCOV
options		KCSAN
Aug 19 2020, 12:29 PM
andrew added inline comments to D19287: Check the index hasn't changed after writing the cmp entry.
Aug 19 2020, 11:20 AM
andrew added a comment to D26108: Add a man page for kcov..

Maybe you can mention that it is only supported on amd64 and arm64, possibly in the BUGS section.

Aug 19 2020, 11:17 AM

Aug 17 2020

andrew requested review of D26083: Add support to switch the arm64 EL2 vector after boot.
Aug 17 2020, 1:04 PM

Aug 15 2020

andrew accepted D26069: arm64: parse HWCAP values using user_cpu_desc.
Aug 15 2020, 8:54 AM
andrew added inline comments to D26072: Add support for PMU on SMP systems for ARM64.
Aug 15 2020, 8:53 AM

Aug 14 2020

andrew requested review of D26066: Allow the creation of 3 level page tables.
Aug 14 2020, 10:54 AM
andrew requested review of D26065: Support stage 2 arm64 pmap in more places.
Aug 14 2020, 10:32 AM

Aug 13 2020

andrew accepted D26029: arm64: update instruction set attribute register definitions.
Aug 13 2020, 4:22 PM
andrew added a comment to D25996: Check that the frame pointer is within the current stack..

On arm64 we have the following in fork_trampoline to stop unwinding past the top of the stack.

mov     fp, #0  /* Stack traceback stops here. */
Aug 13 2020, 8:44 AM

Aug 12 2020

andrew added inline comments to D26029: arm64: update instruction set attribute register definitions.
Aug 12 2020, 4:06 PM
andrew abandoned D25752: Add an ACPI attachment for if_smc.

Committed in rS363636

Aug 12 2020, 10:19 AM
andrew committed rS364153: Add support for Cortex-A76/Neoverse-N1 to hwpmc.
Add support for Cortex-A76/Neoverse-N1 to hwpmc
Aug 12 2020, 10:17 AM
andrew closed D25959: Add support for Cortex-A76/Neoverse-N1 to hwpmc.
Aug 12 2020, 10:17 AM
andrew added inline comments to D26029: arm64: update instruction set attribute register definitions.
Aug 12 2020, 9:56 AM
andrew added a comment to D26031: arm64: export new HWCAP features.

Do any of the new caps require kernel support before they can be used? If so we shouldn't report them to the user until that support is in place.

Aug 12 2020, 9:44 AM

Aug 9 2020

andrew added a comment to D26017: Enable interrupts while handling traps.

arm64 enables interrupts for userspace exceptions in do_el0_sync. It also needs to enable them in data_abort when not in the kernel debugger. See rS287961 and rS353920 for details.

Aug 9 2020, 6:23 PM

Aug 5 2020

andrew added a reviewer for D25959: Add support for Cortex-A76/Neoverse-N1 to hwpmc: pmc.
Aug 5 2020, 3:11 PM
andrew requested review of D25959: Add support for Cortex-A76/Neoverse-N1 to hwpmc.
Aug 5 2020, 3:10 PM