Page MenuHomeFreeBSD

andrew (Andrew Turner)
User

Projects (3)

User Details

User Since
May 10 2014, 2:21 PM (653 w, 4 d)

Recent Activity

Thu, Nov 12

andrew added a comment to D61193: arm64/vmm: Extend bhyve ID registers.

FEAT_UAO needs handling on exception entry

Thu, Nov 12, 3:28 PM
andrew added a comment to D61193: arm64/vmm: Extend bhyve ID registers.

Is the FEAT_DIT field missing?

Thu, Nov 12, 3:02 PM

Wed, Nov 11

andrew committed rGd4085297f4b5: arm64/gicv3: Expose the ACPI maintenance interrupt (authored by kajetan.puchalski_arm.com).
Wed, Nov 11, 4:49 PM
andrew committed rG6b4a47805731: arm64/vmm: vgic_v3: Register the maintenance interrupt (authored by kajetan.puchalski_arm.com).
Wed, Nov 11, 4:49 PM
andrew added inline comments to D60117: libvmmapi: Add Arm GICv5 support.
Wed, Nov 11, 2:35 PM
andrew accepted D60116: arm64: gicv5: Support attaching the vgicv5 driver.
Wed, Nov 11, 1:26 PM
andrew accepted D60115: arm64/vmm: Implement vgic_v5.
Wed, Nov 11, 1:25 PM
andrew accepted D60114: arm64: Add GICv5 ID fields to identcpu.
Wed, Nov 11, 1:14 PM
andrew accepted D60113: arm64: gicv5: Add GICv5 virtual machine support.
Wed, Nov 11, 1:13 PM
andrew added inline comments to D61391: sys/arm64: Add ttl parameter to pmap_invalidate_range().
Wed, Nov 11, 1:13 PM
andrew added a reviewer for D61391: sys/arm64: Add ttl parameter to pmap_invalidate_range(): alc.
Wed, Nov 11, 8:06 AM
andrew added a reviewer for D61390: sys/arm64: TTL fixes: alc.
Wed, Nov 11, 8:05 AM

Mon, Nov 9

andrew added a comment to D60114: arm64: Add GICv5 ID fields to identcpu.

Can you rebase past rGfb1fb7df9db5c133e36c09201fbedbddb32e37c5? This should use the new KERNEL_REG macro as it shouldn't be available to userspace.

Mon, Nov 9, 5:16 PM
andrew committed rGfb1fb7df9db5: arm64: Rename the user_regs struct and array.
Mon, Nov 9, 5:15 PM
andrew closed D60742: arm64: Rename the user_regs struct and array.
Mon, Nov 9, 5:15 PM
andrew accepted D60113: arm64: gicv5: Add GICv5 virtual machine support.
Mon, Nov 9, 4:51 PM

Fri, Nov 6

andrew closed D60653: arm64/acpica: Fix the IORT MSI xref type.
Fri, Nov 6, 3:40 PM
andrew committed rGe82b2913b780: arm64/acpica: Fix the IORT MSI xref type.
Fri, Nov 6, 3:40 PM
andrew closed D60090: arm64/pmap: Add support for FEAT_TTL.
Fri, Nov 6, 3:39 PM
andrew committed rGf0b589edc7a7: arm64/pmap: Add support for FEAT_TTL (authored by sarah.walker2_arm.com).
Fri, Nov 6, 3:39 PM
andrew added inline comments to D58533: arm64: Add FEAT_BRBE register fields.
Fri, Nov 6, 3:23 PM
andrew closed D60196: arm64/vmm: Disable fine grained trapping of range-based TLBI instructions.

Pushed as rG38ead08e27addad96223f7cc5b13f2863de2a6f6

Fri, Nov 6, 3:15 PM

Thu, Nov 5

andrew accepted D60090: arm64/pmap: Add support for FEAT_TTL.
Thu, Nov 5, 11:25 AM
andrew accepted D58533: arm64: Add FEAT_BRBE register fields.
Thu, Nov 5, 11:23 AM

Wed, Nov 4

andrew committed rG38ead08e27ad: arm64/vmm: Disable fine grained trapping of range-based TLBI instructions (authored by sarah.walker2_arm.com).
Wed, Nov 4, 4:57 PM
andrew committed rG7f2e6600acc4: arm64/vmm: Remove PMXEVCNTR_EL0 from the switcher (authored by kajetan.puchalski_arm.com).
Wed, Nov 4, 4:57 PM
andrew committed rGc90253b58cbb: arm64: pte.h: Correct S2 MEMATTR definitions (authored by kajetan.puchalski_arm.com).
Wed, Nov 4, 4:57 PM

Mon, Nov 2

andrew accepted D60982: arm64: Only enable CPU single-stepping for the current thread.
Mon, Nov 2, 4:28 PM
andrew requested changes to D61087: arm64: detect the GIC version from GICD_PIDR2 when the MADT omits it.

Can you include more context. If uploading from the web use git format-patch -U999999, see also https://wiki.freebsd.org/Phabricator

Mon, Nov 2, 1:19 PM
andrew requested changes to D61089: arm64: add virtio_console to std.virt.

This should be included with the other virtio devices, after virtio_blk

Mon, Nov 2, 1:16 PM
andrew added a comment to D61102: bhyve: Allow an arm64 kernel as the boot ROM.

We should remove FDT_BASE, but will need to update the u-boot port to use the correct fdt offset first.

Mon, Nov 2, 11:57 AM

Oct 15 2026

andrew added inline comments to D60655: acpica: Add a thread safe acpi_get_name.
Oct 15 2026, 1:58 PM
andrew requested review of D60742: arm64: Rename the user_regs struct and array.
Oct 15 2026, 1:31 PM

Oct 13 2026

andrew committed rG167d3567c4b9: arm64/vmm: Treat Rt=31 as xzr in reg & instr emul (authored by kajetan.puchalski_arm.com).
Oct 13 2026, 3:45 PM
andrew committed rGac64294143ff: arm64: Relax memory barriers around DMA operations.
Oct 13 2026, 3:45 PM
andrew closed D60407: arm64: Relax memory barriers around DMA operations.
Oct 13 2026, 3:45 PM
andrew added a comment to D60115: arm64/vmm: Implement vgic_v5.

I think we also need to handle IRS_IIDR and IRS_PE_*.

Oct 13 2026, 11:24 AM

Oct 12 2026

andrew added inline comments to D60114: arm64: Add GICv5 ID fields to identcpu.
Oct 12 2026, 5:00 PM
andrew added inline comments to D60113: arm64: gicv5: Add GICv5 virtual machine support.
Oct 12 2026, 4:37 PM
andrew accepted D60624: arm64: Fix midr_check_var_part_range().
Oct 12 2026, 4:26 PM
andrew added a reviewer for D60656: dpaa2: Pass the APCI name to acpi_iort_map_named_msi: dsl.
Oct 12 2026, 4:15 PM
andrew added reviewers for D60655: acpica: Add a thread safe acpi_get_name: jhb, markj, obiwac.
Oct 12 2026, 4:14 PM
andrew requested review of D60656: dpaa2: Pass the APCI name to acpi_iort_map_named_msi.
Oct 12 2026, 4:12 PM
andrew requested review of D60655: acpica: Add a thread safe acpi_get_name.
Oct 12 2026, 4:11 PM
andrew requested review of D60654: arm64/acpica: Support the SMMUv3 IORT table v5.
Oct 12 2026, 4:11 PM
andrew requested review of D60653: arm64/acpica: Fix the IORT MSI xref type.
Oct 12 2026, 4:11 PM

Oct 9 2026

andrew committed rG406a74f780ab: bhyve: Use the new spelling of MPIDR_Aff*.
Oct 9 2026, 3:00 PM
andrew committed rGaa4086951b4a: arm64/vmm: vgic_v3: Fix missing free of vgic_cpu->private_irqs (authored by kajetan.puchalski_arm.com).
Oct 9 2026, 12:09 PM
andrew committed rG7081201eb073: arm64/vmm: vgic_v3: Set EOI for level-triggered interrupts (authored by kajetan.puchalski_arm.com).
Oct 9 2026, 12:09 PM
andrew committed rGe8997a4e44c7: arm64: Use sysinsn.h to generate tlbi instructions.
Oct 9 2026, 12:08 PM
andrew committed rG6bf6fe1d70e7: arm64: Fix the MPIDR_EL1 field names.
Oct 9 2026, 12:08 PM
andrew committed rG3864fe931732: arm64: Add a header for system instructions.
Oct 9 2026, 12:08 PM
andrew closed D59148: arm64: Use sysinsn.h to generate tlbi instructions.
Oct 9 2026, 12:08 PM
andrew closed D59176: arm64: Fix the MPIDR_EL1 field names.
Oct 9 2026, 12:08 PM
andrew closed D59147: arm64: Add a header for system instructions.
Oct 9 2026, 12:08 PM

Oct 8 2026

andrew accepted D60090: arm64/pmap: Add support for FEAT_TTL.
Oct 8 2026, 3:52 PM

Oct 7 2026

andrew accepted D60417: arm64 pmap_fault: a local TLB invalidation suffices when enabling write access.
Oct 7 2026, 9:56 AM

Oct 6 2026

andrew accepted D60271: arm64: avoid full icache flushes on PIPT icaches.
Oct 6 2026, 5:08 PM
andrew added a comment to D60099: arm64: Use only required ordering for coherent dma.

I've created D60407 that should handle both coherent & non-coherent cases

Oct 6 2026, 1:45 PM
andrew requested review of D60407: arm64: Relax memory barriers around DMA operations.
Oct 6 2026, 1:43 PM

Oct 5 2026

andrew added a comment to D60271: arm64: avoid full icache flushes on PIPT icaches.
In D60271#1383040, @alc wrote:

@andrew, Is this what you were asking for?

Oct 5 2026, 4:09 PM
andrew committed rG412c3a037049: arm64/gicv5: Use ArmMpidr to find the correct CPU.
Oct 5 2026, 2:14 PM
andrew closed D59993: arm64/gicv5: Use ArmMpidr to find the correct CPU.
Oct 5 2026, 2:14 PM

Oct 2 2026

andrew added inline comments to D60097: arm64: enable ossl accelerated AES-GCM on arm64.
Oct 2 2026, 3:32 PM
andrew accepted D60098: arm64: Elide coherent busdma maps.
Oct 2 2026, 3:10 PM
andrew added a comment to D60243: sys/arm64: Add a driver for the Realm Services Interface.

There is a race if two threads are writing at the same time, or if one is reading while another is writing. We could add a flag that gets atomically set when handling the info struct & cleared when done.

Oct 2 2026, 2:18 PM
andrew added a comment to D60099: arm64: Use only required ordering for coherent dma.

I talked with the Arm Linux IOMMU/DMA maintainer about this & we concluded replacing the dsb's with dmb's are correct. I have HW & a local patch that I can test next week.

Oct 2 2026, 1:15 PM

Oct 1 2026

andrew accepted D60196: arm64/vmm: Disable fine grained trapping of range-based TLBI instructions.
Oct 1 2026, 12:50 PM

Sep 29 2026

andrew added inline comments to D60098: arm64: Elide coherent busdma maps.
Sep 29 2026, 8:51 PM
andrew added a comment to D60099: arm64: Use only required ordering for coherent dma.

You can replace the existing dsb calls in with the appropriate dmb from the map == NULL block.

Sep 29 2026, 8:35 PM
andrew added inline comments to D60118: bhyve: Add Arm GICv5 support.
Sep 29 2026, 3:25 PM
andrew added reviewers for D60115: arm64/vmm: Implement vgic_v5: bhyve, arm64.
Sep 29 2026, 3:23 PM
andrew added reviewers for D60113: arm64: gicv5: Add GICv5 virtual machine support: bhyve, arm64.
Sep 29 2026, 3:23 PM
andrew added inline comments to D60098: arm64: Elide coherent busdma maps.
Sep 29 2026, 2:23 PM
andrew added a comment to D60099: arm64: Use only required ordering for coherent dma.

I think the dmb instructions are correct even for the non-coherent case

Sep 29 2026, 1:58 PM
andrew added reviewers for D60090: arm64/pmap: Add support for FEAT_TTL: alc, markj, kib.
Sep 29 2026, 10:01 AM
andrew added a comment to D60090: arm64/pmap: Add support for FEAT_TTL.

I think these TLBI_TTL_UNKNOWN values can specify the level, but it would be useful for someone else to check

Sep 29 2026, 9:54 AM

Sep 25 2026

andrew added a comment to D59865: arm64 pmap: Avoid redundant icache synchronization using PGA_EXECUTABLE.

Do we have somewhere we can document the contract with userspace & when it needs to manage the cache? e.g. removing write & enabling execute on a page will cause the kernel to sync the cache, but having both together means userspace needs to perform a sync operation.

Sep 25 2026, 3:30 PM

Sep 24 2026

andrew requested review of D59993: arm64/gicv5: Use ArmMpidr to find the correct CPU.
Sep 24 2026, 4:45 PM

Sep 22 2026

andrew committed rGa856958cab80: arm64/smmu: Fix the SMMU-600 errata check.
Sep 22 2026, 2:29 PM
andrew committed rG334f81f41185: arm64/vmm: Fix translation regime in s2_tlbi_range (authored by kajetan.puchalski_arm.com).
Sep 22 2026, 1:33 PM

Sep 21 2026

andrew committed rG50e01b6351b1: arm64/smmu: Only MSI poll when cache-coherent.
Sep 21 2026, 3:28 PM
andrew committed rG0689a5ea451b: arm64/smmu: Support polling for sync completion.
Sep 21 2026, 3:28 PM
andrew closed D59489: arm64/smmu: Only MSI poll when cache-coherent.
Sep 21 2026, 3:27 PM
andrew closed D59488: arm64/smmu: Support polling for sync completion.
Sep 21 2026, 3:27 PM
andrew committed rG54393bf5361a: arm64/smmu: Split out waiting for sync completion.
Sep 21 2026, 3:27 PM
andrew committed rG6dca6e2aa89d: arm64/smmu: Start handling errata.
Sep 21 2026, 3:27 PM
andrew closed D59487: arm64/smmu: Split out waiting for sync completion.
Sep 21 2026, 3:27 PM
andrew closed D59486: arm64/smmu: Start handling errata.
Sep 21 2026, 3:27 PM
andrew committed rG0bcd0616ff86: arm64/smmu: Move smmu later.
Sep 21 2026, 3:27 PM
andrew closed D59485: arm64/smmu: Move smmu later.
Sep 21 2026, 3:27 PM
andrew closed D59482: arm64: Add a wfe function.
Sep 21 2026, 3:26 PM
andrew committed rGd95b62db76b9: arm64: Add a wfe function.
Sep 21 2026, 3:26 PM

Sep 17 2026

andrew committed rG67242cc4284e: arm64/vmm: vtimer: Read CNTPCT_EL0 through a dedicated macro (authored by kajetan.puchalski_arm.com).
Sep 17 2026, 9:57 AM
andrew committed rG43347e8c55f8: arm64: Fix definition of CCSIDR_EL1_op0 (authored by kajetan.puchalski_arm.com).
Sep 17 2026, 9:57 AM
andrew committed rG9556306213e1: arm64: Add ACPI support to GICv5 driver (authored by sarah.walker2_arm.com).
Sep 17 2026, 9:56 AM
andrew committed rG9f24c7d54222: dev: acpica: Add PCI device methods for aarch64 (authored by sarah.walker2_arm.com).
Sep 17 2026, 9:56 AM
andrew closed D59171: arm64: Add ACPI support to GICv5 driver.
Sep 17 2026, 9:56 AM
andrew closed D59169: dev: acpica: Add PCI device methods for aarch64.
Sep 17 2026, 9:56 AM

Sep 16 2026

andrew accepted D59171: arm64: Add ACPI support to GICv5 driver.
Sep 16 2026, 3:24 PM