- User Since
- May 10 2014, 2:21 PM (175 w, 3 d)
Fri, Sep 15
Thu, Sep 14
Wed, Sep 13
When uploading a diff through the website can you include context. There are commands you can use at https://wiki.freebsd.org/Phabricator#Create_a_Revision_via_Web_Interface
Tue, Sep 12
I have a slight concern about a non-current thread being run at the same time as this leading to a potential data race.
Mon, Sep 11
On ARM platforms I expect we'll need more bits. Linux already has AT_HWCAP2, it might pay to include it from the start.
Fri, Sep 8
Thu, Sep 7
Wed, Sep 6
Tue, Sep 5
Sun, Sep 3
Fri, Sep 1
Based on the Linux source the A73 value is 0xD09. It might pay to also add it at the same time.
Thu, Aug 31
Sat, Aug 26
Tue, Aug 22
Mon, Aug 21
Aug 19 2017
Aug 13 2017
Can you update this with more context.
Aug 12 2017
I think Semihalf was only interested in the kernel debugger when they added this.
Aug 11 2017
Yes. I'm not sure why I made the save KPI look like it does. I think curthread is correct at the point it's called in cpu_switch(), however it would pay to check that.
On arm64 if a thread has used the vfp unit we will store the state on context switch. This means we should only need to call vfp_save_state when we need access to the fpu registers from the current thread. I don't think fill_fpregs has been tested as lldb didn't have vfp support when we did the initial port.
Where is this being called from? I think the bug is calling vfp_save_state on a non-current thread.
Aug 10 2017
Aug 7 2017
There is now access to the platform object from outside of platform.c. You could add a method to platform_pl310_if.m to handle this. Each SoC can then implement this if needed.
My preference would be for it to be a quirk in the driver over a fixup. fdt_fixup_table breaks moving the mv code into GENERIC.
Aug 5 2017
What is the PL310 + UP bug?
Why not do the same as Linux and calculate it dynamically?
Aug 4 2017
Aug 3 2017
This looks good. I'm assuming the registers are correct.
Aug 2 2017
Can you pull out the sys/arm/arm/gic* and sys/arm/arm/generic_timer.c changes into two reviews? They are mostly independent of the rest of the review.
Jul 31 2017
Jul 27 2017
Jul 26 2017
Jul 25 2017
Jul 23 2017
Can you provide more context when uploading diffs. There are svn and git commands on https://wiki.freebsd.org/Phabricator#Create_a_Revision_via_Web_Interface
Jul 18 2017
Jul 17 2017
With this and a patch for www/qt4-webkit I can build 106 ports with a name containing qt4 and 1 failure. I don't see the error in any of the failure logs.