Page MenuHomeFreeBSD

andrew (Andrew Turner)
User

Projects

User Details

User Since
May 10 2014, 2:21 PM (249 w, 4 d)

Recent Activity

Yesterday

andrew committed rS344391: Unwire the kcov buffer when freeing the info struct..
Unwire the kcov buffer when freeing the info struct.
Wed, Feb 20, 10:41 PM
andrew closed D19252: Unwire pages when cleaning up the kcov state.
Wed, Feb 20, 10:41 PM
andrew reopened D19252: Unwire pages when cleaning up the kcov state.
Wed, Feb 20, 10:32 PM
andrew committed rS344390: Call pmap_qenter for each page when creating the kcov buffer..
Call pmap_qenter for each page when creating the kcov buffer.
Wed, Feb 20, 10:32 PM
andrew closed D19252: Unwire pages when cleaning up the kcov state.
Wed, Feb 20, 10:32 PM
andrew updated the diff for D19252: Unwire pages when cleaning up the kcov state.

pmap_qenter each page
Use vm_page_next

Wed, Feb 20, 6:02 PM
andrew added inline comments to D19252: Unwire pages when cleaning up the kcov state.
Wed, Feb 20, 4:33 PM
andrew added inline comments to D19252: Unwire pages when cleaning up the kcov state.
Wed, Feb 20, 3:51 PM
andrew updated the diff for D19252: Unwire pages when cleaning up the kcov state.

Use vm_page_lookup to find the page

Wed, Feb 20, 3:36 PM
andrew updated the diff for D19252: Unwire pages when cleaning up the kcov state.

Use vm_object_reference rather than manual tracking of the mmap state

Wed, Feb 20, 10:20 AM
andrew added inline comments to D19252: Unwire pages when cleaning up the kcov state.
Wed, Feb 20, 9:38 AM
andrew updated the diff for D19252: Unwire pages when cleaning up the kcov state.

Add a missing header

Wed, Feb 20, 9:37 AM

Tue, Feb 19

andrew updated the diff for D19252: Unwire pages when cleaning up the kcov state.

Use vm_page_unwire_noq

Tue, Feb 19, 8:04 PM
andrew created D19252: Unwire pages when cleaning up the kcov state.
Tue, Feb 19, 7:33 PM
andrew committed rS344279: Create a common function to handle freeing the kcov info struct..
Create a common function to handle freeing the kcov info struct.
Tue, Feb 19, 5:03 PM

Mon, Feb 11

andrew accepted D19135: Fix compiler flags related to kernel coverage.
Mon, Feb 11, 3:25 PM
andrew added inline comments to D19135: Fix compiler flags related to kernel coverage.
Mon, Feb 11, 1:51 PM
andrew added inline comments to D19135: Fix compiler flags related to kernel coverage.
Mon, Feb 11, 11:10 AM

Fri, Feb 8

andrew committed rS343913: Fix the spelling of cov_unregister_pc..
Fix the spelling of cov_unregister_pc.
Fri, Feb 8, 4:18 PM

Thu, Feb 7

andrew closed D19097: Add missing pmap dsb instructions.
Thu, Feb 7, 8:59 PM
andrew committed rS343876: Add missing data barriers after storeing a new valid pagetable entry..
Add missing data barriers after storeing a new valid pagetable entry.
Thu, Feb 7, 8:59 PM
andrew reopened D19097: Add missing pmap dsb instructions.
Thu, Feb 7, 8:51 PM
andrew committed rS343875: Add a missing data barrier to the start of arm64_tlb_flushID..
Add a missing data barrier to the start of arm64_tlb_flushID.
Thu, Feb 7, 8:51 PM
andrew closed D19097: Add missing pmap dsb instructions.
Thu, Feb 7, 8:51 PM
andrew added a comment to D19097: Add missing pmap dsb instructions.

Tested with overnight 'make -j 224 buildworld' without failures.

How long does that take?

Thu, Feb 7, 7:29 PM
andrew created D19097: Add missing pmap dsb instructions.
Thu, Feb 7, 9:53 AM

Wed, Feb 6

andrew accepted D18004: pci_host_generic_acpi: use IORT data for MSI/MSI-X.
Wed, Feb 6, 10:12 AM · ARM

Mon, Feb 4

andrew added inline comments to D19077: uart_dev_pl011: add EARLY_PRINTF support.
Mon, Feb 4, 9:03 PM
andrew accepted D19078: arm64: update early printf support.

I've been thinking about reserving a fixed VA on arm64 for this and reworking how we set the range for EARLY_PRINTF. The idea would be we only need to set the physical address, the virtual address base will be fixed, with the offset dependent on the physical address.

Mon, Feb 4, 8:58 PM
andrew added inline comments to D18004: pci_host_generic_acpi: use IORT data for MSI/MSI-X.
Mon, Feb 4, 5:26 PM · ARM
andrew accepted D18003: arm64 gicv3: add IORT and NUMA support.
Mon, Feb 4, 5:25 PM · ARM
andrew accepted D18002: arm64 acpi: Add support for IORT table.
Mon, Feb 4, 5:25 PM
andrew committed rS343746: Only enable trace-cmp on Clang and modern GCC..
Only enable trace-cmp on Clang and modern GCC.
Mon, Feb 4, 4:55 PM
andrew accepted D19073: arm, acpi: increase size of memory region arrays.
Mon, Feb 4, 9:17 AM · arm64

Sun, Feb 3

andrew committed rS343713: Enable COVERAGE and KCOV by default on arm64 and amd64..
Enable COVERAGE and KCOV by default on arm64 and amd64.
Sun, Feb 3, 12:46 PM

Thu, Jan 31

andrew added inline comments to D19046: Rockchip RK3399 PWM driver.
Thu, Jan 31, 7:24 PM · arm64

Tue, Jan 29

andrew committed rS343550: Extract the coverage sanitizer KPI to a new file..
Extract the coverage sanitizer KPI to a new file.
Tue, Jan 29, 11:04 AM
andrew closed D18955: Extract the coverage sanitizer KPI to a new file..
Tue, Jan 29, 11:04 AM

Mon, Jan 28

andrew updated the diff for D18955: Extract the coverage sanitizer KPI to a new file..

Remove a D_TRACKCLOSE that sneaked in

Mon, Jan 28, 11:04 AM
andrew updated the diff for D18955: Extract the coverage sanitizer KPI to a new file..

Update the kcov tracking to be based on the number of threads actively
being traced.

Mon, Jan 28, 11:03 AM

Fri, Jan 25

andrew created D18955: Extract the coverage sanitizer KPI to a new file..
Fri, Jan 25, 4:47 PM

Jan 15 2019

andrew committed rS343042: Ensure the I-Cache is correctly handled in arm64_icache_sync_range.
Ensure the I-Cache is correctly handled in arm64_icache_sync_range
Jan 15 2019, 9:48 AM
andrew closed D18838: Ensure the I-Cache is correctly handled in arm64_icache_sync_range.
Jan 15 2019, 9:48 AM

Jan 14 2019

andrew created D18838: Ensure the I-Cache is correctly handled in arm64_icache_sync_range.
Jan 14 2019, 10:19 AM

Jan 12 2019

andrew accepted D18826: Create crtsavres.o for powerpc builds.
Jan 12 2019, 8:44 PM
andrew committed rS342973: Fix the check for the offset of td_frame and td_emuldata in struct thread..
Fix the check for the offset of td_frame and td_emuldata in struct thread.
Jan 12 2019, 8:42 PM
andrew committed rS342963: Temporarily disable the kcov tests. Not all architectures have.
Temporarily disable the kcov tests. Not all architectures have
Jan 12 2019, 11:50 AM
andrew committed rS342962: Add support for the Clang Coverage Sanitizer in the kernel (KCOV)..
Add support for the Clang Coverage Sanitizer in the kernel (KCOV).
Jan 12 2019, 11:21 AM
andrew closed D14599: Implement kernel code coverage (kcov).
Jan 12 2019, 11:21 AM
andrew added inline comments to D18826: Create crtsavres.o for powerpc builds.
Jan 12 2019, 10:12 AM
andrew added a comment to D18826: Create crtsavres.o for powerpc builds.

You should remove crtsavres.o from gnu/lib/csu/Makefile

Jan 12 2019, 10:10 AM

Jan 11 2019

andrew committed rS342937: Fix the location of td->td_frame at the top of the kernel stack..
Fix the location of td->td_frame at the top of the kernel stack.
Jan 11 2019, 11:33 AM

Jan 10 2019

andrew committed rS342919: Fix a comment, pushed onto is two words..
Fix a comment, pushed onto is two words.
Jan 10 2019, 4:31 PM
andrew updated the diff for D14599: Implement kernel code coverage (kcov).

Fix the spelling of KCOV_ENTRY_SIZE

Jan 10 2019, 1:45 PM
andrew updated the diff for D14599: Implement kernel code coverage (kcov).

Add KCOV_ENTRIY_SIZE
While here update the header copyright

Jan 10 2019, 12:55 PM

Jan 9 2019

andrew updated the diff for D14599: Implement kernel code coverage (kcov).

Simplify the locking in kcov_mmap_cleanup
Update the comments to describe the state machine
Add access requirements to struct kcov_info

Jan 9 2019, 1:55 PM

Jan 8 2019

andrew added inline comments to D14599: Implement kernel code coverage (kcov).
Jan 8 2019, 10:24 AM

Jan 7 2019

andrew added inline comments to D14599: Implement kernel code coverage (kcov).
Jan 7 2019, 10:32 PM
andrew updated the diff for D14599: Implement kernel code coverage (kcov).

Rework the cleanup code:

  • Use barriers to ensure ordering between info->state and other info data.
  • Check if a thread is using the info struct now we don't enter DYING on thread exit
Jan 7 2019, 10:10 PM
andrew added inline comments to D14599: Implement kernel code coverage (kcov).
Jan 7 2019, 8:25 PM
andrew updated the diff for D14599: Implement kernel code coverage (kcov).

Add a missing atomic_thread_fence_seq_cst call to get_kinfo

Jan 7 2019, 7:57 PM
andrew added inline comments to D14599: Implement kernel code coverage (kcov).
Jan 7 2019, 7:56 PM
andrew added inline comments to D14599: Implement kernel code coverage (kcov).
Jan 7 2019, 6:48 PM
andrew updated the diff for D14599: Implement kernel code coverage (kcov).

Remove the kcov_thread_exit prototype from <sys/kcov.h>

Jan 7 2019, 5:57 PM
andrew added inline comments to D14599: Implement kernel code coverage (kcov).
Jan 7 2019, 5:52 PM
andrew updated the diff for D14599: Implement kernel code coverage (kcov).
  • Fix a comment
  • Remove unneeded code from kern_thread.c
  • Fix a typo in a test
Jan 7 2019, 5:52 PM
andrew added a comment to D14599: Implement kernel code coverage (kcov).

Also Andrew, I saw you mention in another thread that you had a man page started but not quite ready. If you'd like help reviewing or finishing it let me know, as I had started a basic one locally myself.

Jan 7 2019, 5:00 PM
andrew updated the diff for D14599: Implement kernel code coverage (kcov).

Update based on feedback:

  • Remove duplicate code from kern.pre.mk
  • Switch to number of entries when setting the buffer size
  • Remove the unneeded kcov_thread_exit
  • Return to KCOV_STATE_READY on thread exit to allow other threads to use the fd
Jan 7 2019, 4:56 PM

Dec 27 2018

andrew added a comment to D14599: Implement kernel code coverage (kcov).

I was trying to use this patch with syzkaller, but couldn't get it running. To figure out what is going on, I created a small test program,

, which results in a reboot of the system. When changing the code such that the ioctl(fd, KIODISABLE, mode) command is executed, to reboot happens. I think the system should not reboot...

Dec 27 2018, 3:58 PM
andrew committed rS342552: Pass VM_PROT_EXECUTE to vm_fault for instruction faults..
Pass VM_PROT_EXECUTE to vm_fault for instruction faults.
Dec 27 2018, 2:15 PM
andrew closed D18511: Pass VM_PROT_EXECUTE to vm_fault for instruction faults.
Dec 27 2018, 2:15 PM
andrew updated the diff for D14599: Implement kernel code coverage (kcov).

Add tests and fix the code based on issues found by these

Dec 27 2018, 2:08 PM

Dec 11 2018

andrew added inline comments to D18511: Pass VM_PROT_EXECUTE to vm_fault for instruction faults.
Dec 11 2018, 11:15 AM
andrew committed rS341814: Only read the ACPI proximity tabled on arm64 when we are booting from.
Only read the ACPI proximity tabled on arm64 when we are booting from
Dec 11 2018, 11:13 AM
andrew created D18511: Pass VM_PROT_EXECUTE to vm_fault for instruction faults.
Dec 11 2018, 10:58 AM

Dec 9 2018

andrew added a comment to D17137: arm64: Add HWCAP support.

There is no need to set the cpu affinity, the userspace register view is the same on each core.

Dec 9 2018, 11:49 AM

Dec 4 2018

andrew closed D18428: Only gnu/lib/csu when MK_BSD_CRTBEGIN is off.
Dec 4 2018, 6:52 PM
andrew committed rS341489: Only gnu/lib/csu when MK_BSD_CRTBEGIN is off..
Only gnu/lib/csu when MK_BSD_CRTBEGIN is off.
Dec 4 2018, 6:52 PM
andrew created D18428: Only gnu/lib/csu when MK_BSD_CRTBEGIN is off.
Dec 4 2018, 10:56 AM

Dec 3 2018

andrew committed rS341424: Disable the BSD CRT code on powerpc and sparc64, they need extra crt*.o.
Disable the BSD CRT code on powerpc and sparc64, they need extra crt*.o
Dec 3 2018, 9:41 AM

Nov 24 2018

andrew committed rS340911: Re-enable the dynamiclib tests. These should be fixed by r340910..
Re-enable the dynamiclib tests. These should be fixed by r340910.
Nov 24 2018, 6:27 PM
andrew committed rS340910: Add the missing 0 at the end of the .jcr section..
Add the missing 0 at the end of the .jcr section.
Nov 24 2018, 6:24 PM
andrew committed rS340881: Disable the dynamiclib test until a failure can be debugged.
Disable the dynamiclib test until a failure can be debugged
Nov 24 2018, 4:06 PM

Nov 23 2018

andrew committed rS340841: Enable the BSD crtbegin/crtend by default..
Enable the BSD crtbegin/crtend by default.
Nov 23 2018, 4:45 PM
andrew committed rS340840: Mark the function called by the MIPS .init/.fini sequence with .local..
Mark the function called by the MIPS .init/.fini sequence with .local.
Nov 23 2018, 4:33 PM
andrew added inline comments to D17938: Add a PWM subsystem.
Nov 23 2018, 4:17 PM

Nov 15 2018

andrew accepted D17793: pci_host_generic : move activate/release to generic code.
Nov 15 2018, 6:07 PM
andrew accepted D17792: pci_host_generic, acpi_resource: drop unneeded code.
Nov 15 2018, 6:06 PM
andrew accepted D17791: acpica, pci_host_generic_acpi: redo pci_host_generic_acpi.c.
Nov 15 2018, 6:04 PM
andrew accepted D17790: acpica: rework INTRNG interrupt mapping.
Nov 15 2018, 5:56 PM
andrew accepted D17981: arm64 pmap: Handle kernel mappings in pmap_remove_l2()..
Nov 15 2018, 5:25 PM
andrew accepted D17981: arm64 pmap: Handle kernel mappings in pmap_remove_l2()..
Nov 15 2018, 2:42 PM

Nov 13 2018

andrew committed rS340395: Run __cxa_finalize in shared objects in the destructor path..
Run __cxa_finalize in shared objects in the destructor path.
Nov 13 2018, 3:28 PM
andrew added a reviewer for D17943: arm64: add ACPI based NUMA support: markj.
Nov 13 2018, 10:38 AM · arm64
andrew added a reviewer for D17942: acpica: support parsing of arm64 affinity in acpi_pxm.c: markj.
Nov 13 2018, 10:38 AM
andrew added a reviewer for D17941: acpica : move SRAT/SLIT parsing to sys/dev/acpica: markj.
Nov 13 2018, 10:38 AM
andrew added a reviewer for D17940: x86/acpica/srat.c: Add API for parsing proximity tables: markj.
Nov 13 2018, 10:38 AM · arm64

Nov 7 2018

andrew committed rS340213: Add the (untested) mips and sparc64 .init call sequences..
Add the (untested) mips and sparc64 .init call sequences.
Nov 7 2018, 9:49 AM

Nov 6 2018

andrew added a comment to D14599: Implement kernel code coverage (kcov).

I don't see any reason why this would preclude SBCC based kernel coverage. The only issue may be if it uses the same device node to communicate with userspace.

Nov 6 2018, 6:33 PM
andrew committed rS340193: Add the KUBSAN options to the arm64 and amd64 GENERIC kernel config files..
Add the KUBSAN options to the arm64 and amd64 GENERIC kernel config files.
Nov 6 2018, 5:48 PM