andrew (Andrew Turner)
User

Projects

User Details

User Since
May 10 2014, 2:21 PM (150 w, 5 d)

Recent Activity

Yesterday

andrew added a reviewer for D10201: ARM PrimeCell PL330 DMA engine driver: ARM.

Looks good, however I think a few comments would be useful, e.g. in pl330_channel_submit_sg, and it seems to be missing the build glue.

Thu, Mar 30, 3:42 PM

Tue, Mar 28

andrew added a comment to D8616: Cleanup INTRNG internals to prepare for ACPI support.
In D8616#210013, @skra wrote:

(1) The staff around PIC and xref was implemented with concrete idea. You are trying to change it. So, it's not cleanup, it's an implementation of new idea. And I don't see why this change would be better.

Tue, Mar 28, 4:29 PM

Mon, Mar 27

andrew added a comment to D8616: Cleanup INTRNG internals to prepare for ACPI support.

Ping? I'd like to commit this soon.

Mon, Mar 27, 3:45 PM

Wed, Mar 22

andrew added a comment to D10041: Stop building assym.o in modules.

@bdrewery Can you commit your change. It works for me building for arm64 with no external binutils.

Wed, Mar 22, 2:59 PM
andrew created D10094: Move the code to exit hyp to hypervisor-stub.S.
Wed, Mar 22, 2:46 PM
andrew committed rS315712: Add the early hypervisor code needed on 32-bit ARMv7. This will be used.
Add the early hypervisor code needed on 32-bit ARMv7. This will be used
Wed, Mar 22, 2:30 PM
andrew closed D10045: ARMv7 handle hyp-mode by committing rS315712: Add the early hypervisor code needed on 32-bit ARMv7. This will be used.
Wed, Mar 22, 2:30 PM · ARM

Mon, Mar 20

andrew added a comment to D10045: ARMv7 handle hyp-mode.

Can you check the diff you uploaded didn't replace tabs with spaces. It's not applying to my svn checkout.

Mon, Mar 20, 7:46 PM · ARM
andrew accepted D10045: ARMv7 handle hyp-mode.
Mon, Mar 20, 7:28 PM · ARM
andrew committed rS315650: Use tc_priv to find the softc in the i.MX timer driver..
Use tc_priv to find the softc in the i.MX timer driver.
Mon, Mar 20, 7:25 PM
andrew added inline comments to D10045: ARMv7 handle hyp-mode.
Mon, Mar 20, 10:41 AM · ARM

Sat, Mar 18

andrew added inline comments to D10045: ARMv7 handle hyp-mode.
Sat, Mar 18, 5:11 PM · ARM

Fri, Mar 17

andrew committed rS315452: Mark the EFI PE header as allocated. While ld.bfd doesn't seem to care.
Mark the EFI PE header as allocated. While ld.bfd doesn't seem to care
Fri, Mar 17, 1:31 PM
andrew committed rS315451: Remove code for Marvell SoCs that lack a kernel config..
Remove code for Marvell SoCs that lack a kernel config.
Fri, Mar 17, 12:59 PM
andrew closed D7166: Remove code for Marvell SoCs that lack a kernel config by committing rS315451: Remove code for Marvell SoCs that lack a kernel config..
Fri, Mar 17, 12:59 PM
andrew committed rS315450: Make the default FDT implementation of platform_mp_setmaxid use the cpu.
Make the default FDT implementation of platform_mp_setmaxid use the cpu
Fri, Mar 17, 12:46 PM
andrew closed D9827: Update platform_default_mp_setmaxid to walk the device tree by committing rS315450: Make the default FDT implementation of platform_mp_setmaxid use the cpu.
Fri, Mar 17, 12:46 PM
andrew committed rS315448: Move the IMX6 kernels to use PLATFORM_SMP. This is the last SMP config to.
Move the IMX6 kernels to use PLATFORM_SMP. This is the last SMP config to
Fri, Mar 17, 12:35 PM
andrew closed D9907: Port i.MX6 to PLATFORM_SMP by committing rS315448: Move the IMX6 kernels to use PLATFORM_SMP. This is the last SMP config to.
Fri, Mar 17, 12:35 PM
andrew created D10041: Stop building assym.o in modules.
Fri, Mar 17, 11:10 AM

Thu, Mar 16

andrew committed rS315421: If ofw_bus_msimap fails don't try to use the invalid MSI/MSI-X parent node..
If ofw_bus_msimap fails don't try to use the invalid MSI/MSI-X parent node.
Thu, Mar 16, 5:49 PM

Mon, Mar 6

andrew retitled D9907: Port i.MX6 to PLATFORM_SMP from to Port i.MX6 to PLATFORM_SMP.
Mon, Mar 6, 5:04 PM
andrew added a comment to D9863: Rework BGX detection to support both new and old firmware.

The BGX interface is unconnected in the ThunderX units in the netperf cluster

Mon, Mar 6, 12:46 PM

Fri, Mar 3

andrew added a comment to D9864: Enable L1 Dcache prefetch for Cortex A9 CPUs.

There is the PLATFORM code to handle differences between different ARM based SoCs.

Fri, Mar 3, 8:09 PM

Thu, Mar 2

andrew added a comment to D9866: Enabling all DTrace fbt probes (fbt::: {}) hangs on the system on ARM platforms.

Can you rebase this on top of rS309785?

Thu, Mar 2, 4:04 PM

Feb 28 2017

andrew accepted D9836: add SOC_ALTERA_* kernel options.

Looks good

Feb 28 2017, 4:08 PM
andrew added a reviewer for D9827: Update platform_default_mp_setmaxid to walk the device tree: ARM.
Feb 28 2017, 2:01 PM
andrew updated the diff for D9827: Update platform_default_mp_setmaxid to walk the device tree.
  • Move the FDT bits to a FDT specific file
Feb 28 2017, 1:57 PM

Feb 27 2017

andrew retitled D9827: Update platform_default_mp_setmaxid to walk the device tree from to Update platform_default_mp_setmaxid to walk the device tree.
Feb 27 2017, 6:19 PM

Feb 21 2017

andrew accepted D8819: Enable FIFO on pl011 uart.
Feb 21 2017, 5:05 PM
andrew added inline comments to D9701: Errors caused by DTrace are not correctly handled by ARMv6 abort_handler().
Feb 21 2017, 2:01 PM · ARM, DTrace
andrew added inline comments to D8616: Cleanup INTRNG internals to prepare for ACPI support.
Feb 21 2017, 1:49 PM
andrew added a reviewer for D9701: Errors caused by DTrace are not correctly handled by ARMv6 abort_handler(): ARM.
Feb 21 2017, 12:19 PM · ARM, DTrace

Feb 16 2017

andrew added a reviewer for D9633: Fix broken visibility for symbols declared by DEFINE_AEABI_FUNCTION_ALIAS().: emaste.

This should be sent upstream

Feb 16 2017, 1:25 PM

Feb 15 2017

andrew committed rS313772: Load the new sp_el0 with interrupts disabled in fork_trampoline. If an.
Load the new sp_el0 with interrupts disabled in fork_trampoline. If an
Feb 15 2017, 2:57 PM
andrew closed D9593: Load the new sp_el0 with interrupts disabled in fork_trampoline by committing rS313772: Load the new sp_el0 with interrupts disabled in fork_trampoline. If an.
Feb 15 2017, 2:57 PM
andrew abandoned D8548: Add a driver for the network device in the AMD Opteron A1100.

Committed as rS313767 and rS313768

Feb 15 2017, 2:17 PM
andrew committed rS313768: Port the Linux AMX 10G network driver to FreeBSD as axgbe. It is unlikely.
Port the Linux AMX 10G network driver to FreeBSD as axgbe. It is unlikely
Feb 15 2017, 1:56 PM
andrew closed D8549: Port the Linux AMD xgbe driver to FreeBSD as axgbe by committing rS313768: Port the Linux AMX 10G network driver to FreeBSD as axgbe. It is unlikely.
Feb 15 2017, 1:56 PM
andrew committed rS313767: Import the AMD 10G ethernet driver for the AMD Opteron A1100..
Import the AMD 10G ethernet driver for the AMD Opteron A1100.
Feb 15 2017, 1:37 PM

Feb 14 2017

andrew retitled D9593: Load the new sp_el0 with interrupts disabled in fork_trampoline from to Load the new sp_el0 with interrupts disabled in fork_trampoline.
Feb 14 2017, 4:55 PM
andrew updated the diff for D8616: Cleanup INTRNG internals to prepare for ACPI support.

Add an XREF_INVALID macro

Feb 14 2017, 12:05 PM
andrew added inline comments to D8616: Cleanup INTRNG internals to prepare for ACPI support.
Feb 14 2017, 12:03 PM
andrew updated the diff for D8549: Port the Linux AMD xgbe driver to FreeBSD as axgbe.

Remove dead code

Feb 14 2017, 11:14 AM
andrew added inline comments to D8549: Port the Linux AMD xgbe driver to FreeBSD as axgbe.
Feb 14 2017, 11:14 AM
andrew added inline comments to D9575: Boot-time Key Intake Metadata.
Feb 14 2017, 9:49 AM

Feb 9 2017

andrew closed D9511: Add support for the em device in one of the netperf ThunderXs by committing rS313476: Add support for the Intel 82572EI back to em(4), it seems it was dropped.
Feb 9 2017, 5:48 PM
andrew committed rS313476: Add support for the Intel 82572EI back to em(4), it seems it was dropped.
Add support for the Intel 82572EI back to em(4), it seems it was dropped
Feb 9 2017, 5:48 PM
andrew updated the diff for D8549: Port the Linux AMD xgbe driver to FreeBSD as axgbe.
  • Move xgbe.c to if_axgbe.c
  • Use sx_xlock/sx_xunlock directly
  • Add a license to xgbe_osdep.h
  • Support the new devicetree layout as documented in Linux
Feb 9 2017, 5:26 PM
andrew retitled D9511: Add support for the em device in one of the netperf ThunderXs from to Add support for the em device in one of the netperf ThunderXs.
Feb 9 2017, 1:11 PM

Feb 7 2017

andrew committed rS313396: Push reading of ESR_EL1 to assembly. Among other uses this will allow us.
Push reading of ESR_EL1 to assembly. Among other uses this will allow us
Feb 7 2017, 6:19 PM
andrew committed rS313385: Add support for PLATFORM and PLATFORM_SMP to the Altera SOCFPGA SoC. This.
Add support for PLATFORM and PLATFORM_SMP to the Altera SOCFPGA SoC. This
Feb 7 2017, 12:04 PM
andrew closed D9461: Add SOCFPGA PLATFORM support by committing rS313385: Add support for PLATFORM and PLATFORM_SMP to the Altera SOCFPGA SoC. This.
Feb 7 2017, 12:04 PM

Feb 6 2017

andrew committed rS313347: Remove arm64_tlb_flushID_SE, it's unused and may be wrong..
Remove arm64_tlb_flushID_SE, it's unused and may be wrong.
Feb 6 2017, 5:50 PM
andrew retitled D9461: Add SOCFPGA PLATFORM support from to Add SOCFPGA PLATFORM support.
Feb 6 2017, 4:17 PM
andrew committed rS313344: Temporary disable gicv3_its.c when FDT is missing from the kernel until.
Temporary disable gicv3_its.c when FDT is missing from the kernel until
Feb 6 2017, 3:25 PM
andrew committed rS313342: Only build the ACPI PCI drivers on x86, they are unlikely to be used on.
Only build the ACPI PCI drivers on x86, they are unlikely to be used on
Feb 6 2017, 2:41 PM
andrew abandoned D8606: Split out the FDT parts of the GIC softc.

rS309323

Feb 6 2017, 2:33 PM
andrew updated the diff for D8616: Cleanup INTRNG internals to prepare for ACPI support.

Rebase

Feb 6 2017, 2:31 PM
andrew committed rS313339: Only allow the pic type to be either a PIC or MSI type. All interrupt.
Only allow the pic type to be either a PIC or MSI type. All interrupt
Feb 6 2017, 1:09 PM

Feb 3 2017

andrew committed rS313146: Fix the comment showing the meaning of the first argument to sigprocmask..
Fix the comment showing the meaning of the first argument to sigprocmask.
Feb 3 2017, 11:51 AM
andrew committed rS313145: Remove an old use of _ARM_ARCH_6, we are moving to using the standard.
Remove an old use of _ARM_ARCH_6, we are moving to using the standard
Feb 3 2017, 11:48 AM
andrew committed rS313141: Only define atomic_fcmpset_long in the kernel. We may include.
Only define atomic_fcmpset_long in the kernel. We may include
Feb 3 2017, 10:04 AM

Jan 26 2017

andrew committed rS312813: Make fdt_pm_mask_table internal to the Marvell code, it's unued anywhere.
Make fdt_pm_mask_table internal to the Marvell code, it's unued anywhere
Jan 26 2017, 1:04 PM

Jan 25 2017

andrew committed rS312764: Pull the R_AARCH64_TLSDESC code out into a common function and use them in.
Pull the R_AARCH64_TLSDESC code out into a common function and use them in
Jan 25 2017, 5:35 PM

Jan 24 2017

andrew committed rS312703: Fix the error value we write in cerror. __error returns an int *, however.
Fix the error value we write in cerror. __error returns an int *, however
Jan 24 2017, 6:56 PM

Jan 18 2017

andrew committed rS312378: Use the kernel stack in the ARM FBT DTrace provider. This is used to find.
Use the kernel stack in the ARM FBT DTrace provider. This is used to find
Jan 18 2017, 1:27 PM
andrew closed D9229: Corrected handling of fifth parameter in DTrace's FBT provider for ARM by committing rS312378: Use the kernel stack in the ARM FBT DTrace provider. This is used to find.
Jan 18 2017, 1:27 PM
andrew accepted D9229: Corrected handling of fifth parameter in DTrace's FBT provider for ARM .
Jan 18 2017, 12:02 PM
andrew added a comment to D9218: Expand OpenFirmware API with ofw_bus_node_status_okay method.

fdt_is_enabled is deprecated and should be removed as soon as there is an appropriate OpenFirmware function.

Jan 18 2017, 8:54 AM

Jan 17 2017

andrew added reviewers for D9218: Expand OpenFirmware API with ofw_bus_node_status_okay method: nwhitehorn, jhibbits.
Jan 17 2017, 5:16 PM
andrew added a comment to D9223: Add AHCI device to arm/mv/files.mv.

Why is this not part of D9222?

Jan 17 2017, 5:14 PM
andrew added a reviewer for D9221: Enable optional soft reset in AHCI: mav.
Jan 17 2017, 5:14 PM

Jan 10 2017

andrew committed rS311875: Add acpi_if.h to SRCS so we have it when building ahci_generic.c with ACPI..
Add acpi_if.h to SRCS so we have it when building ahci_generic.c with ACPI.
Jan 10 2017, 1:36 PM
andrew closed D8852: Add an ACPI attachement to the ahci_generic driver by committing rS311874: Add an ACPI attachment to the existing ahci_generic driver. This is used.
Jan 10 2017, 10:56 AM
andrew committed rS311874: Add an ACPI attachment to the existing ahci_generic driver. This is used.
Add an ACPI attachment to the existing ahci_generic driver. This is used
Jan 10 2017, 10:56 AM
andrew accepted D9108: Fix UEFI support for ARM.

Looks good, although it might pay to split into a few commits. We should also look at removing relocation_offset from the EFI code in a follow up.

Jan 10 2017, 9:25 AM

Jan 9 2017

andrew added inline comments to D9108: Fix UEFI support for ARM.
Jan 9 2017, 11:45 PM
andrew added inline comments to D9108: Fix UEFI support for ARM.
Jan 9 2017, 9:45 PM

Dec 19 2016

andrew retitled D8852: Add an ACPI attachement to the ahci_generic driver from to Add an ACPI attachement to the ahci_generic driver.
Dec 19 2016, 1:41 PM

Dec 16 2016

andrew committed rS310154: Add support to read the _CLS entry if it's present. It is used by.
Add support to read the _CLS entry if it's present. It is used by
Dec 16 2016, 10:40 AM
andrew closed D8721: Add ACPI support for _CLS by committing rS310154: Add support to read the _CLS entry if it's present. It is used by.
Dec 16 2016, 10:40 AM
andrew committed rS310153: All armv6 platforms have the same implementation of platform_lastaddr..
All armv6 platforms have the same implementation of platform_lastaddr.
Dec 16 2016, 10:31 AM
andrew closed D8806: Add a defualt handler for platform_lastaddr by committing rS310153: All armv6 platforms have the same implementation of platform_lastaddr..
Dec 16 2016, 10:31 AM

Dec 15 2016

andrew committed rS310124: Add -fPIC to the ubldr build. Without this the self relocation code will.
Add -fPIC to the ubldr build. Without this the self relocation code will
Dec 15 2016, 5:37 PM
andrew committed rS310113: Directly include openfirm.h rather than through fdt_common.h as none of the.
Directly include openfirm.h rather than through fdt_common.h as none of the
Dec 15 2016, 1:32 PM
andrew retitled D8806: Add a defualt handler for platform_lastaddr from to Add a defualt handler for platform_lastaddr.
Dec 15 2016, 1:16 PM
andrew updated the diff for D8721: Add ACPI support for _CLS.

Return 0xff if _CLS is missing

Dec 15 2016, 10:42 AM

Dec 14 2016

andrew added inline comments to D8794: Add support for cd-gpios for mmc.
Dec 14 2016, 6:20 PM · ARM
andrew added inline comments to D8794: Add support for cd-gpios for mmc.
Dec 14 2016, 2:40 PM · ARM

Dec 13 2016

andrew committed rS310022: Use the platform_*_t typedefs to help check the platform function types are.
Use the platform_*_t typedefs to help check the platform function types are
Dec 13 2016, 1:46 PM
andrew committed rS310021: Add the missing void to function signatures in much of the arm code..
Add the missing void to function signatures in much of the arm code.
Dec 13 2016, 1:43 PM
andrew committed rS310020: Use platform_*_t to check the platform function signatures are correct in.
Use platform_*_t to check the platform function signatures are correct in
Dec 13 2016, 1:07 PM
andrew accepted D8769: Switch Rockchip RK3188 SoC to use the platform code.

Consider my comments as suggestions for future improvements.

Dec 13 2016, 11:16 AM

Dec 12 2016

andrew updated the diff for D8721: Add ACPI support for _CLS.

Read _CLS once

Dec 12 2016, 6:23 PM
andrew committed rS309903: Enable ACPI on arm64. It's not yet functional, but it will help keeping the.
Enable ACPI on arm64. It's not yet functional, but it will help keeping the
Dec 12 2016, 6:13 PM
andrew retitled D8767: ACPI for PCIe on arm64 from to ACPI for PCIe on arm64.
Dec 12 2016, 5:43 PM
andrew committed rS309895: On non-Intel platforms don't ignore the PCI root bridge mapping in.
On non-Intel platforms don't ignore the PCI root bridge mapping in
Dec 12 2016, 4:54 PM

Dec 7 2016

andrew committed rS309675: Add ACPI support to the arm64 mp code. We use the Multiple APIC Description.
Add ACPI support to the arm64 mp code. We use the Multiple APIC Description
Dec 7 2016, 2:35 PM
andrew committed rS309674: Add ACPI support to the PSCI driver. This checks the Fixed ACPI Description.
Add ACPI support to the PSCI driver. This checks the Fixed ACPI Description
Dec 7 2016, 2:25 PM