andrew (Andrew Turner)
User

Projects

User Details

User Since
May 10 2014, 2:21 PM (167 w, 3 d)

Recent Activity

Yesterday

andrew added a comment to D11732: Always set the receive mask in loader.efi.

Are there some specific examples about systems needing this?

Tue, Jul 25, 4:10 PM
andrew created D11732: Always set the receive mask in loader.efi.
Tue, Jul 25, 4:02 PM
andrew committed rS321462: Build the 32-bit ARM libstand and loader parts with -fPIC. Many of them are.
Build the 32-bit ARM libstand and loader parts with -fPIC. Many of them are
Tue, Jul 25, 10:41 AM

Sun, Jul 23

andrew added a comment to D11703: Fix TEX index acquisition using L2 attributes.

Can you provide more context when uploading diffs. There are svn and git commands on https://wiki.freebsd.org/Phabricator#Create_a_Revision_via_Web_Interface

Sun, Jul 23, 5:17 PM · ARM

Tue, Jul 18

andrew committed rS321131: Add support for passing FPU_KERN_NOCTX to fpu_kern_enter on arm64. This.
Add support for passing FPU_KERN_NOCTX to fpu_kern_enter on arm64. This
Tue, Jul 18, 4:36 PM

Mon, Jul 17

andrew added a comment to D11622: Port devel/qt4-dbus to arm64.

With this and a patch for www/qt4-webkit I can build 106 ports with a name containing qt4 and 1 failure. I don't see the error in any of the failure logs.

Mon, Jul 17, 4:21 PM
andrew created D11622: Port devel/qt4-dbus to arm64.
Mon, Jul 17, 3:44 PM

Wed, Jul 12

andrew created D11564: Add i.MX6 and Xilinx to GENERIC.
Wed, Jul 12, 11:24 AM

Tue, Jul 11

andrew committed rS320894: Add external PLATFORM access on arm, and use it in the pl310 driver..
Add external PLATFORM access on arm, and use it in the pl310 driver.
Tue, Jul 11, 4:30 PM
andrew closed D11546: Add external PLATFORM access, and use it in the pl310 driver. by committing rS320894: Add external PLATFORM access on arm, and use it in the pl310 driver..
Tue, Jul 11, 4:30 PM

Mon, Jul 10

andrew committed rS320873: Start to move the arm *_mp.h to be names *_machdep.h. These will be used.
Start to move the arm *_mp.h to be names *_machdep.h. These will be used
Mon, Jul 10, 3:28 PM

Sun, Jul 9

andrew created D11546: Add external PLATFORM access, and use it in the pl310 driver..
Sun, Jul 9, 12:26 PM

Fri, Jul 7

andrew committed rS320777: Remove the MULTIDELAY option from arm. It's now enabled when PLATFORM is.
Remove the MULTIDELAY option from arm. It's now enabled when PLATFORM is
Fri, Jul 7, 1:55 PM

Wed, Jul 5

andrew committed rS320669: Make MULTIDELAY a requirement in the MPCore Timer driver when using.
Make MULTIDELAY a requirement in the MPCore Timer driver when using
Wed, Jul 5, 10:29 AM
andrew committed rS320668: Require the ARM Generic Timer driver is built for MULTIDELAY on 32bit arm..
Require the ARM Generic Timer driver is built for MULTIDELAY on 32bit arm.
Wed, Jul 5, 9:27 AM

Tue, Jul 4

andrew committed rS320651: Move the simple armv6 only timer drivers to require MULTIDELAY to help.
Move the simple armv6 only timer drivers to require MULTIDELAY to help
Tue, Jul 4, 6:07 PM
andrew committed rS320648: Add a delay count to the last few places. This will help make MULTIDELAY.
Add a delay count to the last few places. This will help make MULTIDELAY
Tue, Jul 4, 5:15 PM
andrew committed rS320647: Remove PLATFORM_SMP. It's unneeded as all configs with both PLATFORM and.
Remove PLATFORM_SMP. It's unneeded as all configs with both PLATFORM and
Tue, Jul 4, 4:53 PM
andrew committed rS320643: Add PLATFORM and PLATFORM_SMP support to the ALPINE kernel configuration..
Add PLATFORM and PLATFORM_SMP support to the ALPINE kernel configuration.
Tue, Jul 4, 12:27 PM
andrew committed rS320642: Teach VERSATILEPB about PLATFORM. This will help move it into the GENERIC.
Teach VERSATILEPB about PLATFORM. This will help move it into the GENERIC
Tue, Jul 4, 12:18 PM
andrew committed rS320641: MFC r320403, r320497.
MFC r320403, r320497
Tue, Jul 4, 10:54 AM

Sun, Jul 2

andrew committed rS320571: In the arm64 pmap_remove, when removing a full superpage there is no need.
In the arm64 pmap_remove, when removing a full superpage there is no need
Sun, Jul 2, 8:52 AM

Sat, Jul 1

andrew committed rS320529: Remove all calls to cpu_dcache_wb_range from the arm64 pmap code. These.
Remove all calls to cpu_dcache_wb_range from the arm64 pmap code. These
Sat, Jul 1, 9:39 AM

Fri, Jun 30

andrew committed rS320497: Remove a blank line accidentally added in r320403..
Remove a blank line accidentally added in r320403.
Fri, Jun 30, 2:46 PM
andrew created D11422: math/R: Build on arm64.
Fri, Jun 30, 9:44 AM
andrew committed rP444704: www/node: Build on arm64.
www/node: Build on arm64
Fri, Jun 30, 9:20 AM

Thu, Jun 29

andrew committed rS320482: As with arm64 mark the EFI PE header as allocated on arm. This is needed.
As with arm64 mark the EFI PE header as allocated on arm. This is needed
Thu, Jun 29, 10:09 PM
andrew committed rS320470: Start to remove _libc_arm_fpu_present checks. We don't support the VFP on.
Start to remove _libc_arm_fpu_present checks. We don't support the VFP on
Thu, Jun 29, 2:00 PM
andrew closed D11393: Start to remove _libc_arm_fpu_present checks by committing rS320470: Start to remove _libc_arm_fpu_present checks. We don't support the VFP on.
Thu, Jun 29, 2:00 PM

Wed, Jun 28

andrew retitled D11393: Start to remove _libc_arm_fpu_present checks from Start to remote _libc_arm_fpu_present checks to Start to remove _libc_arm_fpu_present checks.
Wed, Jun 28, 2:13 PM
andrew created D11393: Start to remove _libc_arm_fpu_present checks.
Wed, Jun 28, 1:38 PM

Tue, Jun 27

andrew committed rS320411: Add parentheses missed in r320388.
Add parentheses missed in r320388
Tue, Jun 27, 4:30 PM
andrew committed rS320403: Some of the atomic_clear_* functions were incorrectly defined to be an.
Some of the atomic_clear_* functions were incorrectly defined to be an
Tue, Jun 27, 10:45 AM

Mon, Jun 26

andrew committed rS320388: In _bswap16 and _bswap32 cast constant values to the appropriate type. This is.
In _bswap16 and _bswap32 cast constant values to the appropriate type. This is
Mon, Jun 26, 10:33 PM
andrew accepted D11364: Fix a comment post-r320347.

I was going to suggest the same change.

Mon, Jun 26, 4:24 PM

Jun 25 2017

andrew committed rS320328: Stop calling cpu_dcache_wb_range from PTE_SYNC..
Stop calling cpu_dcache_wb_range from PTE_SYNC.
Jun 25 2017, 1:23 PM

Jun 22 2017

andrew accepted D9145: Fix MSI IRQ allocation for ARM GIC.
Jun 22 2017, 3:55 PM
andrew added a comment to D11301: EFI boot: made 32 bit pad more explicit on EFI_MEMORY_DESCRIPTOR.

On 32-bit ARM there will be implicit padding as EFI_PHYSICAL_ADDRESS is a 64-bit type so will be 64-bit aligned.

Jun 22 2017, 2:28 PM

Jun 15 2017

andrew accepted D10899: Enhance Armada 38x SoC identification string.
Jun 15 2017, 11:14 PM · ARM

Jun 9 2017

andrew committed rS319753: Allow the arm64 machine/vfp.h to be included without first including.
Allow the arm64 machine/vfp.h to be included without first including
Jun 9 2017, 3:47 PM
andrew committed rS319752: Store the read-only thread pointer when scheduling a new thread. This is.
Store the read-only thread pointer when scheduling a new thread. This is
Jun 9 2017, 3:37 PM

Jun 8 2017

andrew accepted D10909: Add detection of CPU class for ARMv6/v7.
Jun 8 2017, 1:35 PM · ARM
andrew added inline comments to D10729: Cleanup MD pollution of MI busdma header.
Jun 8 2017, 10:04 AM

Jun 5 2017

andrew added inline comments to D10706: Introduce Armada 38x/XP network controller support.
Jun 5 2017, 8:24 AM · ARM

Jun 4 2017

andrew committed rS319569: Start to rename files with common or generic names to be SoC specific. The.
Start to rename files with common or generic names to be SoC specific. The
Jun 4 2017, 9:11 AM

Jun 3 2017

andrew committed rS319554: Port the Vybrid code to PLATFORM to help move it into GENERIC..
Port the Vybrid code to PLATFORM to help move it into GENERIC.
Jun 3 2017, 8:15 PM
andrew committed rS319553: Port the Samsung ARM code to use PLATFORM and PLATFORM_SMP. This will help.
Port the Samsung ARM code to use PLATFORM and PLATFORM_SMP. This will help
Jun 3 2017, 8:02 PM
andrew committed rS319552: Port the Xilinx code to use PLATFORM and PLATFORM_SMP. This will help move.
Port the Xilinx code to use PLATFORM and PLATFORM_SMP. This will help move
Jun 3 2017, 7:11 PM
andrew committed rS319541: Stop making cpu_initclocks weak when using event timers. A weak symbol.
Stop making cpu_initclocks weak when using event timers. A weak symbol
Jun 3 2017, 4:24 PM
andrew committed rS319538: Add MULTIDELAY support to the mpcore timer driver. This is needed when.
Add MULTIDELAY support to the mpcore timer driver. This is needed when
Jun 3 2017, 3:57 PM
andrew committed rS319537: Add MULTIDELAY support to the sp804 driver..
Add MULTIDELAY support to the sp804 driver.
Jun 3 2017, 3:48 PM
andrew committed rS319536: Add MULTIDELAY to the Beaglebone kenrel config to help moving it to GENERIC..
Add MULTIDELAY to the Beaglebone kenrel config to help moving it to GENERIC.
Jun 3 2017, 3:40 PM
andrew committed rS319535: Enable MULTIDELAY in the i.MX5 kernel configs. This will help adding them.
Enable MULTIDELAY in the i.MX5 kernel configs. This will help adding them
Jun 3 2017, 3:39 PM
andrew committed rS319522: Remove RT1310 from universe as it fails to build..
Remove RT1310 from universe as it fails to build.
Jun 3 2017, 2:46 PM
andrew added a comment to D11034: tsan: set noexec stack on aarch64.

Note that this is only needed for bfd, lld sets the noexec flag by default.

Jun 3 2017, 2:29 PM
andrew committed rS319515: Make it an error to build armv6 without INTRNG enabled. Most kernel configs.
Make it an error to build armv6 without INTRNG enabled. Most kernel configs
Jun 3 2017, 10:41 AM
andrew committed rS319514: Mark the non-INTRNG armv6 configs with NO_UNIVERSE to prepare for INTRNG.
Mark the non-INTRNG armv6 configs with NO_UNIVERSE to prepare for INTRNG
Jun 3 2017, 10:39 AM

Jun 2 2017

andrew requested changes to D10706: Introduce Armada 38x/XP network controller support.

You shouldn't use fdt_ functions here.

Jun 2 2017, 6:07 PM · ARM
andrew closed D6846: Fix device lookup of for the stdout-path chosen property by committing rS319494: Fix device lookup of for the stdout-path chosen property..
Jun 2 2017, 2:01 PM
andrew committed rS319494: Fix device lookup of for the stdout-path chosen property..
Fix device lookup of for the stdout-path chosen property.
Jun 2 2017, 2:01 PM

May 30 2017

andrew committed rS319213: MFC r307334, r318252: Support write-through caches on arm64.
MFC r307334, r318252: Support write-through caches on arm64
May 30 2017, 1:56 PM
andrew committed rS319210: MFC r317824:.
MFC r317824:
May 30 2017, 1:36 PM
andrew committed rS319207: MFC r317361:.
MFC r317361:
May 30 2017, 1:26 PM
andrew committed rS319206: MFC r317197:.
MFC r317197:
May 30 2017, 1:21 PM
andrew committed rS319205: MFC r317192:.
MFC r317192:
May 30 2017, 1:16 PM
andrew committed rS319204: MFC r313396:.
MFC r313396:
May 30 2017, 1:02 PM
andrew committed rS319203: MFC r316734, r316761: Support Execute-Never bit in the arm64 pmap..
MFC r316734, r316761: Support Execute-Never bit in the arm64 pmap.
May 30 2017, 12:44 PM
andrew committed rS319202: MFC r316732, r316756: Enable Privileged Access Never on arm64..
MFC r316732, r316756: Enable Privileged Access Never on arm64.
May 30 2017, 12:26 PM
andrew committed rS319196: MFC r316755:.
MFC r316755:
May 30 2017, 11:03 AM
andrew committed rS319195: MFC r312703:.
MFC r312703:
May 30 2017, 10:50 AM

May 26 2017

andrew requested changes to D10909: Add detection of CPU class for ARMv6/v7.

You should add cpu_class to sys/arm/identcpu-v6.c and set it in identify_arm_cpu.

May 26 2017, 1:36 PM · ARM
andrew added a reviewer for D10910: Fix HWPMC interrupt handling in Counting Mode: bz.
May 26 2017, 1:16 PM · ARM
andrew added a reviewer for D10909: Add detection of CPU class for ARMv6/v7: bz.
May 26 2017, 1:15 PM · ARM
andrew added a comment to D10899: Enhance Armada 38x SoC identification string.

I would like it if rather than using __weak_reference we were to architect the code properly.

May 26 2017, 1:08 PM · ARM

May 18 2017

andrew accepted D10793: MFC LLD changes and enable LLD as /usr/bin/ld on arm64 by default.
May 18 2017, 3:20 PM

May 15 2017

andrew added a comment to D10682: Introduce platform CPU init for ARM.
In D10682#222298, @zbb wrote:

Also if we use platform_late_init there would be a need to rework all late_init implementations so that they could be used in the init_secondary.

May 15 2017, 12:46 PM
andrew created D10733: Run platform_late_init on all cpus..
May 15 2017, 12:45 PM

May 14 2017

andrew added inline comments to D10716: Fix MPIC mask/unmask.
May 14 2017, 8:28 AM · ARM

May 13 2017

andrew committed rS318253: Allocate a cacheline when reading or writing to write through memory. The.
Allocate a cacheline when reading or writing to write through memory. The
May 13 2017, 1:03 PM
andrew committed rS318252: Add the VM_MEMATTR_WRITE_THROUGH memory type to arm64 and use it to support.
Add the VM_MEMATTR_WRITE_THROUGH memory type to arm64 and use it to support
May 13 2017, 1:01 PM

May 12 2017

andrew added a comment to D10218: Implement workaround for Armada 38X family HW issue between CPU and devices.
In D10218#221537, @skra wrote:

Note that pmap_remap_vm_attr() calls pmap_set_tex() which assumes that all caches are disabled (see last two lines in this function).

May 12 2017, 10:46 AM
andrew added inline comments to D9864: Enable L1 Dcache prefetch for Cortex A9 CPUs.
May 12 2017, 10:40 AM

May 11 2017

andrew added inline comments to D9864: Enable L1 Dcache prefetch for Cortex A9 CPUs.
May 11 2017, 6:13 PM
andrew added a comment to D10682: Introduce platform CPU init for ARM.

For the cases I have seen where this is used I would think would be better served by calling platform_late_init late in init_secondary.

May 11 2017, 6:08 PM
andrew requested changes to D10682: Introduce platform CPU init for ARM.

This won't work in the PLATFORM case. You are trying to dereference the platform object too early in the boot.

May 11 2017, 5:53 PM
andrew added inline comments to D10218: Implement workaround for Armada 38X family HW issue between CPU and devices.
May 11 2017, 5:47 PM

May 5 2017

andrew committed rS317824: Add reclaim_pv_chunk on arm64. This is based on the amd64 code so should.
Add reclaim_pv_chunk on arm64. This is based on the amd64 code so should
May 5 2017, 10:02 AM
andrew closed D10574: Implement reclaim_pv_chunk on arm64 by committing rS317824: Add reclaim_pv_chunk on arm64. This is based on the amd64 code so should.
May 5 2017, 10:01 AM

May 4 2017

andrew updated the diff for D10574: Implement reclaim_pv_chunk on arm64.

Remove another unneeded pmap_invalidate_all

May 4 2017, 4:54 PM
andrew updated the diff for D10574: Implement reclaim_pv_chunk on arm64.

Clean up and bug fixes based on reviews and testing:

May 4 2017, 1:25 PM

May 3 2017

andrew added inline comments to D10574: Implement reclaim_pv_chunk on arm64.
May 3 2017, 11:36 PM
andrew added a comment to D10574: Implement reclaim_pv_chunk on arm64.

Further testing has found a few bugs in the code.

May 3 2017, 3:58 PM
andrew committed rS317738: Print all virtual addresses in the show vtop ddb command. The results may.
Print all virtual addresses in the show vtop ddb command. The results may
May 3 2017, 12:24 PM

May 2 2017

andrew added inline comments to D10573: arch.7: add table of initial FreeBSD version to support each arch.
May 2 2017, 5:07 PM
andrew created D10574: Implement reclaim_pv_chunk on arm64.
May 2 2017, 4:31 PM
andrew added inline comments to D10573: arch.7: add table of initial FreeBSD version to support each arch.
May 2 2017, 4:28 PM

Apr 27 2017

andrew accepted D10499: Add support for optional CRC32c instructions on armv8.
Apr 27 2017, 7:50 AM

Apr 26 2017

andrew added inline comments to D10499: Add support for optional CRC32c instructions on armv8.
Apr 26 2017, 8:49 AM
andrew added a comment to D9145: Fix MSI IRQ allocation for ARM GIC.

Are the irq -> end_irq changes still relevant? They appear so.

Apr 26 2017, 8:41 AM

Apr 24 2017

andrew committed rS317377: MFC r302788, r303026, r305471.
MFC r302788, r303026, r305471
Apr 24 2017, 4:49 PM