- User Since
- May 10 2014, 2:21 PM (258 w, 16 h)
Tue, Apr 16
If you think more flags will be needed later you can make it a u_int with a per-flag macro. If not just make it a bool.
Sat, Apr 13
I'm happy with the quirk, however I'm not sure about the PCI part. It may pay to split that out into a new review as there are two independent changes in this.
Wed, Apr 10
Do we need something similar to intr_pic_init_secondary to also disable the timers on non-boot CPUs?
Sat, Apr 6
Fri, Apr 5
Wed, Apr 3
Tue, Apr 2
From looking at the Linux PL011 driver it seems registers always start on a 32b boundary so *shiftp should always be 2. The simplest would be to add a quirk to the PL011 acpi_uart_compat_data entries to force a shift of 2. It would also be cleaner than checking for specific interface types in what should become machine independent code. Later on we may be able to use cd_regshft and cd_regiowidth to override the SPCR details, however it looks like the ns8250 driver may need some careful clean up first.
Fri, Mar 29
I wonder if there is a way to make this generic as the dprintf or similar macro seems to be common in arm code.
Thu, Mar 28
Mon, Mar 25
Mar 21 2019
Mar 8 2019
Could you use spcr->SerialPort.AccessWidth to find this? It's set to 1 in the copy of the spcr table I have indicating byte access.
Mar 7 2019
I'm fine with breaking from the ABI in the kernel & modules as long as it's just for optimisation and we don't require the breakage to allow the kernel to still work after being built with, for example, gcc & linked with bfd.
Mar 3 2019
Feb 28 2019
Split out the header
Enable clocks, etc
Feb 27 2019
Feb 25 2019
Is there a reason to limit this to arm and arm64?
Feb 21 2019
Feb 20 2019
pmap_qenter each page
Use vm_page_lookup to find the page
Use vm_object_reference rather than manual tracking of the mmap state
Add a missing header
Feb 19 2019
Feb 11 2019
Feb 8 2019
Feb 7 2019
How long does that take?
Feb 6 2019
Feb 4 2019
I've been thinking about reserving a fixed VA on arm64 for this and reworking how we set the range for EARLY_PRINTF. The idea would be we only need to set the physical address, the virtual address base will be fixed, with the offset dependent on the physical address.
Feb 3 2019
Jan 31 2019
Jan 29 2019
Jan 28 2019
Remove a D_TRACKCLOSE that sneaked in
Update the kcov tracking to be based on the number of threads actively
Jan 25 2019
Jan 15 2019
Jan 14 2019
Jan 12 2019
You should remove crtsavres.o from gnu/lib/csu/Makefile
Jan 11 2019
Jan 10 2019
Fix the spelling of KCOV_ENTRY_SIZE
While here update the header copyright
Jan 9 2019
Simplify the locking in kcov_mmap_cleanup
Update the comments to describe the state machine
Add access requirements to struct kcov_info
Jan 8 2019
Jan 7 2019
Rework the cleanup code:
- Use barriers to ensure ordering between info->state and other info data.
- Check if a thread is using the info struct now we don't enter DYING on thread exit
Add a missing atomic_thread_fence_seq_cst call to get_kinfo
Remove the kcov_thread_exit prototype from <sys/kcov.h>