andrew (Andrew Turner)
User

Projects

User Details

User Since
May 10 2014, 2:21 PM (206 w, 2 d)

Recent Activity

Fri, Apr 20

andrew added a reviewer for D15141: Add support for ThunderX2 PCIe: jhb.
Fri, Apr 20, 2:42 PM
andrew requested changes to D15141: Add support for ThunderX2 PCIe.

You should restructure the pci_host_generic_acpi code to handle this so you don't need to copy and paste so much of it in this driver, or even better handle ThunderX2 in the existing driver with quirks.

Fri, Apr 20, 2:42 PM

Tue, Apr 17

andrew accepted D15102: Remove the unused fuwintr() and suiwintr() functions..
Tue, Apr 17, 4:39 PM
andrew added a comment to D15102: Remove the unused fuwintr() and suiwintr() functions..

Do we need to add the removed MLINKS to ObsoleteFiles.inc?

Tue, Apr 17, 7:54 AM
andrew accepted D15108: Remove unused implementations of copyoutstr..
Tue, Apr 17, 7:51 AM

Sun, Apr 15

andrew added a comment to D15067: possible new port for spigen overlay for Raspberry Pi.

Why a port and not put the overlay in the base system?

Sun, Apr 15, 5:35 PM

Fri, Apr 13

andrew added inline comments to D15059: Create L2 DMAP pages on ARM64.
Fri, Apr 13, 6:51 PM
andrew added a comment to D15059: Create L2 DMAP pages on ARM64.

Can you provide more context. If you are uploading a patch via the web interface there are instructions on the wiki to ensure this is the case at https://wiki.freebsd.org/Phabricator#Create_a_Revision_via_Web_Interface

Fri, Apr 13, 6:16 PM

Sun, Apr 8

andrew committed rS332309: Replace calls to fdt_is_compatible with ofw_bus_node_is_compatible. These.
Replace calls to fdt_is_compatible with ofw_bus_node_is_compatible. These
Sun, Apr 8, 10:07 PM
andrew committed rS332278: Revert r332277, it contained an unintended extra change.
Revert r332277, it contained an unintended extra change
Sun, Apr 8, 3:21 PM
andrew committed rS332277: Replace calls to fdt_is_compatible with ofw_bus_node_is_compatible. These.
Replace calls to fdt_is_compatible with ofw_bus_node_is_compatible. These
Sun, Apr 8, 3:12 PM
andrew committed rS332274: Move fdt_is_type to be a Marvell specific function. It's not used by any.
Move fdt_is_type to be a Marvell specific function. It's not used by any
Sun, Apr 8, 12:20 PM

Sat, Apr 7

andrew added a comment to D14989: Replace exect() with a portable version.

@andrew It is exposed in unistd.h and the documentation doesn't say it's specific to a particular platform.

Sat, Apr 7, 6:42 AM

Fri, Apr 6

andrew added a comment to D14989: Replace exect() with a portable version.

Doesn't this add it on architectures where it wasn't implemented? It doesn't seem to be implemented on arm, arm64, or riscv. It's implemented on mips, but is not in the Symbols.map file so will not be exposed in libc.so.7 and could be removed.

Fri, Apr 6, 3:58 PM

Wed, Apr 4

andrew committed rS332026: Remove fdt_pm_is_enabled as it's Marvell specific. Replace the only call to.
Remove fdt_pm_is_enabled as it's Marvell specific. Replace the only call to
Wed, Apr 4, 1:38 PM

Tue, Apr 3

andrew committed rS331925: Remove fdt_is_enabled, fdt_reg_to_rl, and fdt_get_unit. These are not used.
Remove fdt_is_enabled, fdt_reg_to_rl, and fdt_get_unit. These are not used
Tue, Apr 3, 1:30 PM
andrew committed rS331924: Switch users of fdt_is_enabled to use ofw_bus_node_status_okay. These are.
Switch users of fdt_is_enabled to use ofw_bus_node_status_okay. These are
Tue, Apr 3, 11:02 AM

Mon, Apr 2

andrew committed rS331877: Add the missing header for malloc(9). It was pulled in through header.
Add the missing header for malloc(9). It was pulled in through header
Mon, Apr 2, 1:37 PM

Mar 23 2018

andrew updated the diff for D5881: Allwinner USB DRD support (musb_otg).

Rebase

Mar 23 2018, 11:10 AM · ARM
andrew reopened D5881: Allwinner USB DRD support (musb_otg).
Mar 23 2018, 11:09 AM · ARM
andrew committed rS331421: If sc->sc_ep_max is already set use it to find the number of RX and TX.
If sc->sc_ep_max is already set use it to find the number of RX and TX
Mar 23 2018, 11:09 AM
andrew closed D5881: Allwinner USB DRD support (musb_otg).
Mar 23 2018, 11:09 AM · ARM
andrew updated the diff for D5881: Allwinner USB DRD support (musb_otg).

Fix an include

Mar 23 2018, 10:35 AM · ARM

Mar 22 2018

andrew updated the diff for D5881: Allwinner USB DRD support (musb_otg).

Rebase

Mar 22 2018, 6:52 PM · ARM
andrew created D14796: Set the correct endpoint in the EPINDEX register.
Mar 22 2018, 4:06 PM
andrew committed rS331361: Enter into the EFI environment before dereferencing the runtime services.
Enter into the EFI environment before dereferencing the runtime services
Mar 22 2018, 3:33 PM
andrew committed rS331360: Increase the size of the endpoint buffers. They are double buffered so.
Increase the size of the endpoint buffers. They are double buffered so
Mar 22 2018, 3:24 PM

Mar 21 2018

andrew added inline comments to D14744: Use PLATFORM for initializing Marvell ArmadaXP and Armada38X.
Mar 21 2018, 6:27 PM · ARM
andrew committed rS331306: Use a table to find the endpoint configuration.
Use a table to find the endpoint configuration
Mar 21 2018, 3:18 PM
andrew closed D14783: Use a table to find the endpoint configuration.
Mar 21 2018, 3:17 PM
andrew added inline comments to D5881: Allwinner USB DRD support (musb_otg).
Mar 21 2018, 3:13 PM · ARM
andrew updated the diff for D14783: Use a table to find the endpoint configuration.

sc_eb_cfg -> sc_ep_cfg from D5881

Mar 21 2018, 3:12 PM
andrew accepted D14735: Make Marvell mv_pci.c driver generic.
Mar 21 2018, 1:50 PM · ARM
andrew updated the diff for D5881: Allwinner USB DRD support (musb_otg).

Include D14783 to allow us to set our own endpoint config

Mar 21 2018, 1:42 PM · ARM
andrew accepted D14737: Make validation in Marvell mv_common.c generic.
Mar 21 2018, 1:01 PM · ARM
andrew accepted D14736: Split get_sar_value function for Marvell ArmadaXP and Armada38X.
Mar 21 2018, 12:59 PM · ARM
andrew added inline comments to D14735: Make Marvell mv_pci.c driver generic.
Mar 21 2018, 12:57 PM · ARM
andrew created D14783: Use a table to find the endpoint configuration.
Mar 21 2018, 12:19 PM
andrew accepted D14758: Support for gpioled on ARMADA38X based boards.
Mar 21 2018, 11:40 AM · ARM
andrew added a comment to D14781: regulator: Disable unused regulator.

It would pay to add a comment to explain what the function is for.

Mar 21 2018, 11:31 AM
andrew added a comment to D14756: Update mv_gpio driver to new FreeBSD API.
In D14756#310616, @mw wrote:

@manu I se you NACKed the patch, but don't see the actual remarks

Mar 21 2018, 11:28 AM · ARM
andrew accepted D14734: ArmadaXP use INTRNG interrupt controller..
Mar 21 2018, 11:27 AM · ARM
andrew added inline comments to D14741: Make Marvell AmadaXP timer driver more generic.
Mar 21 2018, 10:32 AM · ARM

Mar 20 2018

andrew committed rS331242: Remove the entry about loader.efi needing to be updated before the kernel..
Remove the entry about loader.efi needing to be updated before the kernel.
Mar 20 2018, 1:40 PM
andrew committed rS331241: Check if the gettime runtime service is valid..
Check if the gettime runtime service is valid.
Mar 20 2018, 1:35 PM
andrew closed D14759: Check if the gettime runtime service is valid.
Mar 20 2018, 1:35 PM

Mar 19 2018

andrew added inline comments to D14759: Check if the gettime runtime service is valid.
Mar 19 2018, 11:51 PM
andrew added inline comments to D14744: Use PLATFORM for initializing Marvell ArmadaXP and Armada38X.
Mar 19 2018, 6:38 PM · ARM
andrew added a reviewer for D14748: Add support of PCI_RES_BUS to Marvell PCI driver: jhb.
Mar 19 2018, 6:28 PM · ARM
andrew added inline comments to D14747: Add Marvell ArmadaXP and Armada38X to GENERIC config.
Mar 19 2018, 6:27 PM · ARM
andrew added a comment to D14759: Check if the gettime runtime service is valid.

With this I can boot a new kernel with an old loader.efi on a sopine with U-Boot. It should also allow us to boot with efi_disable_vmap set.

Mar 19 2018, 6:19 PM
andrew created D14759: Check if the gettime runtime service is valid.
Mar 19 2018, 6:15 PM

Mar 15 2018

andrew added a comment to D14599: Implement kernel code coverage (kcov).

Have you considered writing some tests for this? They could be integrated into the existing test suite

Mar 15 2018, 1:38 PM

Mar 9 2018

andrew committed rS330687: Use the correct address to write back to memory in the GICv3 ITS driver..
Use the correct address to write back to memory in the GICv3 ITS driver.
Mar 9 2018, 10:35 AM

Mar 8 2018

andrew added inline comments to D14618: ARM Coresight support.
Mar 8 2018, 2:30 PM
andrew added a reviewer for D14599: Implement kernel code coverage (kcov): andrew.

How does this compare with the Linux kcov? It seems they only allow the use to mmap the file, then have an agreed ABI on this. This has the advantage where accessing the buffer doesn't change it as is the case with calling read on it.

Mar 8 2018, 11:46 AM

Mar 7 2018

andrew updated the diff for D5881: Allwinner USB DRD support (musb_otg).

We don't have sc in awusbdrd_bs_r_1 to check

Mar 7 2018, 4:47 PM · ARM
andrew updated the diff for D5881: Allwinner USB DRD support (musb_otg).

Update to catch up with changed KPI and work on arm64 on the sopine.
This is untested on 32-bit arm.

Mar 7 2018, 4:47 PM · ARM
andrew updated the diff for D5881: Allwinner USB DRD support (musb_otg).

Handle missing CONFDATA register on some platforms

Mar 7 2018, 4:42 PM · ARM
andrew added a comment to D5881: Allwinner USB DRD support (musb_otg).

It doesn't seem to quite work on the Allwinner A64. I'm getting the following when I try to use a wifi dongle:

...
musbotg_channel_alloc: No available channels. Mask: 0000
musbotg_channel_alloc: No available channels. Mask: 0000
musbotg_channel_alloc: No available channels. Mask: 0000
musbotg_channel_alloc: No available channels. Mask: 0000
musbotg_channel_alloc: No available channels. Mask: 0001
musbotg_channel_alloc: No available channels. Mask: 0001
musbotg_channel_alloc: No available channels. Mask: 0001
musbotg_channel_alloc: No available channels. Mask: 0000
musbotg_channel_alloc: No available channels. Mask: 0000
musbotg_channel_alloc: No available channels. Mask: 0000
musbotg_channel_alloc: No available channels. Mask: 0000
...
Mar 7 2018, 4:42 PM · ARM
andrew commandeered D5881: Allwinner USB DRD support (musb_otg).
Mar 7 2018, 4:42 PM · ARM
andrew added inline comments to D14565: Use EFI RTC capablities info when registering, add bootverbose diagnostics..
Mar 7 2018, 2:59 PM
andrew committed rS330593: Bump MAXCPUS on arm64. We are starting to see hardware with more than 96.
Bump MAXCPUS on arm64. We are starting to see hardware with more than 96
Mar 7 2018, 1:54 PM
andrew committed rS330582: Create macros for the ACPI interrupt cross references. This is considered a.
Create macros for the ACPI interrupt cross references. This is considered a
Mar 7 2018, 1:16 PM
andrew committed rS330575: Add an acpi attachment to the pci_host_generic driver and have the ACPI.
Add an acpi attachment to the pci_host_generic driver and have the ACPI
Mar 7 2018, 10:47 AM
andrew closed D8767: ACPI for PCIe on arm64.
Mar 7 2018, 10:47 AM
andrew committed rS330574: Restrict the arm64 DMAP region to the 1G blocks where we have at least.
Restrict the arm64 DMAP region to the 1G blocks where we have at least
Mar 7 2018, 9:58 AM

Mar 6 2018

andrew added inline comments to D12875: HWPMC tracing support (1) -- main.
Mar 6 2018, 4:25 PM

Mar 5 2018

andrew committed rS330489: Register each GICv3 ITS driver with a useful cross reference. We currently.
Register each GICv3 ITS driver with a useful cross reference. We currently
Mar 5 2018, 10:11 AM
andrew committed rS330488: In the ACPI GICv3 attach function call device_get_children to get the list.
In the ACPI GICv3 attach function call device_get_children to get the list
Mar 5 2018, 10:09 AM

Mar 3 2018

andrew committed rS330337: Move setting the IRQ base and length into the common GICv3 ITS attach.
Move setting the IRQ base and length into the common GICv3 ITS attach
Mar 3 2018, 1:20 PM
andrew committed rS330336: Add the missing GICv3 dev info struct to the ACPI dev info.Previously we.
Add the missing GICv3 dev info struct to the ACPI dev info.Previously we
Mar 3 2018, 1:19 PM

Mar 2 2018

andrew committed rS330276: Count the number of children in the GICv3 ACPI attachment. This is needed.
Count the number of children in the GICv3 ACPI attachment. This is needed
Mar 2 2018, 1:04 PM

Feb 28 2018

andrew committed rS330120: Allow releasing APs to take more time, as long as we are making progress..
Allow releasing APs to take more time, as long as we are making progress.
Feb 28 2018, 4:04 PM
andrew committed rS330114: Count the number of GIC redistributors in the ACPI tables. The GICv3 driver.
Count the number of GIC redistributors in the ACPI tables. The GICv3 driver
Feb 28 2018, 3:26 PM
andrew committed rS330113: Only check the ProducerConsumer flag on extended memory. As per the ACPI.
Only check the ProducerConsumer flag on extended memory. As per the ACPI
Feb 28 2018, 3:18 PM
andrew closed D14516: Only check the ProducerConsumer flag on extended memory.
Feb 28 2018, 3:18 PM
andrew committed rS330111: The Arm pl011 driver assumes it's running a devicetree based system..
The Arm pl011 driver assumes it's running a devicetree based system.
Feb 28 2018, 3:02 PM
andrew closed D14515: Support both FDT and ACPI on arm64 in the pl011 driver.
Feb 28 2018, 3:02 PM
andrew added a reviewer for D14541: Make Raspberry Pi RNG compatible with upstream DTBs: secteam.
Feb 28 2018, 1:04 PM

Feb 26 2018

andrew created D14516: Only check the ProducerConsumer flag on extended memory.
Feb 26 2018, 9:37 AM
andrew created D14515: Support both FDT and ACPI on arm64 in the pl011 driver.
Feb 26 2018, 8:59 AM
andrew committed rS330016: Check all entries in the ACPI uart compat table and not just the first..
Check all entries in the ACPI uart compat table and not just the first.
Feb 26 2018, 8:45 AM

Feb 25 2018

andrew committed rS329991: Teach the Arm pl011 driver to attach to a SBSA uart. This is defined in.
Teach the Arm pl011 driver to attach to a SBSA uart. This is defined in
Feb 25 2018, 7:43 PM
andrew committed rS329990: Rename the FDT compat_data array to a bus-specific name..
Rename the FDT compat_data array to a bus-specific name.
Feb 25 2018, 7:33 PM

Feb 24 2018

andrew committed rS329906: Correctly set the 16kB page size field in the ITS BASER register. Some.
Correctly set the 16kB page size field in the ITS BASER register. Some
Feb 24 2018, 10:33 AM

Feb 22 2018

andrew added a comment to D14465: Create sysctl hw.model on ARM.

Why aren't you using the model property from the device tree?

Feb 22 2018, 9:19 AM · ARM

Feb 16 2018

andrew closed D14343: Put the rootfs on the correct partition.
Feb 16 2018, 4:22 PM
andrew committed rS329382: Put the pine64 root filesystem on teh correct partition..
Put the pine64 root filesystem on teh correct partition.
Feb 16 2018, 4:22 PM

Feb 14 2018

andrew committed rD51423: Move to a new pgp key.
Move to a new pgp key
Feb 14 2018, 9:30 AM

Feb 13 2018

andrew updated the diff for D14343: Put the rootfs on the correct partition.

Update MD_ARGS

Feb 13 2018, 6:32 PM
andrew added a reviewer for D14343: Put the rootfs on the correct partition: releng.
Feb 13 2018, 9:35 AM
andrew created D14343: Put the rootfs on the correct partition.
Feb 13 2018, 9:35 AM

Feb 9 2018

andrew added inline comments to D14062: Make memory mapped via pmap_qenter() non-executable for amd64/i386..
Feb 9 2018, 9:33 PM

Feb 1 2018

andrew added inline comments to D14104: Implement pinctl functionality for Raspberr Pi platform.
Feb 1 2018, 4:16 PM
andrew committed rS328662: Disable EARLY_PRINTF from the Armada 3700 uart, it breaks when we want.
Disable EARLY_PRINTF from the Armada 3700 uart, it breaks when we want
Feb 1 2018, 3:05 PM
andrew committed rS328658: Only promote userspace mappings to superpages. This was dropped in r328510,.
Only promote userspace mappings to superpages. This was dropped in r328510,
Feb 1 2018, 2:26 PM

Jan 30 2018

andrew added inline comments to D14104: Implement pinctl functionality for Raspberr Pi platform.
Jan 30 2018, 11:43 AM

Jan 24 2018

andrew added a comment to D14033: uefi.8: clarify history and drop AUTHORS.
In D14033#294754, @manu wrote:

armv7 isn't really supported, status goes on and off at each u-boot or loader.efi changes, I'm trying to keep it working but sometimes it fails. (also we don't install loader.efi or boot1.efi for arm RELEASE/SNAPSHOT images).

Jan 24 2018, 11:50 PM
andrew accepted D14023: BPF: Switch to 32 bit compatible mode only when thread is 32 bit.
Jan 24 2018, 5:55 PM