Page MenuHomeFreeBSD

andrew (Andrew Turner)
User

Projects

User Details

User Since
May 10 2014, 2:21 PM (532 w, 6 d)

Recent Activity

Yesterday

andrew added a comment to D46151: buf_ring: Keep the full head and tail values.
In D46151#1052139, @kib wrote:

Am I right that this revision does not fix the issue, but covers it with more bits from the unused space in the head index? It is still possible that head wraps around, just less likely now that full 2^32 iterations needs to occur under it?

Fri, Jul 26, 7:16 PM
andrew added a comment to D46149: buf_ring: Support DEBUG_BUFRING in userspace.

The mtx code appears to be a check that the correct mutex is being held by the kernel so only one thread can access the single-consumer functions at a time. In userspace the tests I wrote don't use a mutex as only one consumer thread is created when testing these functions.

Fri, Jul 26, 7:04 PM
andrew added a comment to D46159: arm64: Expand the use of Armv8.1-A atomics.
In D46159#1052031, @imp wrote:

Do we care about Arm 8.0? Or will __ARM_FEATURE_ATOMICS not be defined there?

Fri, Jul 26, 5:02 PM
andrew requested review of D46159: arm64: Expand the use of Armv8.1-A atomics.
Fri, Jul 26, 9:19 AM
andrew requested review of D46158: buf_ring: Add a threaded test.
Fri, Jul 26, 9:18 AM
andrew requested review of D46157: buf_ring: Add an Arm copyright.
Fri, Jul 26, 8:57 AM
andrew requested review of D46156: tests: Add buf_ring overflow checks.
Fri, Jul 26, 8:57 AM
andrew requested review of D46155: buf_ring: Ensure correct ordering of loads.
Fri, Jul 26, 8:56 AM
andrew requested review of D46154: buf_ring: Use atomic operations with br_prod_tail.
Fri, Jul 26, 8:56 AM
andrew requested review of D46153: buf_ring: Remove old arm-only dequeue code.
Fri, Jul 26, 8:56 AM
andrew requested review of D46152: buf_ring: Use atomic operations with br_cons_tail.
Fri, Jul 26, 8:56 AM
andrew requested review of D46151: buf_ring: Keep the full head and tail values.
Fri, Jul 26, 8:56 AM
andrew requested review of D46150: buf_ring: Consistently use atomic_*_32.
Fri, Jul 26, 8:56 AM
andrew requested review of D46149: buf_ring: Support DEBUG_BUFRING in userspace.
Fri, Jul 26, 8:56 AM
andrew requested review of D46148: buf_ring: Remove PREFETCH_DEFINED.
Fri, Jul 26, 8:55 AM
andrew requested review of D46147: tests: Add a buf_ring test.
Fri, Jul 26, 8:55 AM

Wed, Jul 24

andrew accepted D46094: arm64/gicv3: Skip programming vPE GITS_BASERs to avoid a boot crash..

We don't use the vPE table so it's safe to ignore.

Wed, Jul 24, 1:30 PM

Tue, Jul 23

andrew added a comment to D46060: ELF auxargs: reserve a slot for CheriABI use.

It looks like HardenedBSD uses #define AT_PAXFLAGS 35. I assume they stopped merging changes to this list as they didn't have AT_USRSTACK* in their copy of this file.

Tue, Jul 23, 12:47 PM
andrew requested review of D46087: arm64: Boot into VHE mode when able.
Tue, Jul 23, 11:22 AM
andrew requested review of D46085: arm64/vmm: Allow vmm when in VHE.
Tue, Jul 23, 11:22 AM
andrew requested review of D46086: arm64: Remove the E2H check from has_hyp.
Tue, Jul 23, 11:21 AM
andrew requested review of D46084: arm64/vmm: Convert the handlers into ifuncs.
Tue, Jul 23, 11:21 AM
andrew requested review of D46083: arm64/vmm: Add the VHE exception and switcher files.
Tue, Jul 23, 11:21 AM
andrew requested review of D46082: arm64/vmm: Hide non-VHE exception code from VHE.
Tue, Jul 23, 11:21 AM
andrew requested review of D46081: arm64/vmm: Update exception vectors around a guest.
Tue, Jul 23, 11:21 AM
andrew requested review of D46080: arm64/vmm: Support tlbi from VHE.
Tue, Jul 23, 11:20 AM
andrew requested review of D46079: arm64/vmm: Only store the guest par_el1.
Tue, Jul 23, 11:20 AM
andrew requested review of D46077: arm64/vmm: Restore hcr_el2 earlier.
Tue, Jul 23, 11:20 AM
andrew requested review of D46078: arm64/vmm: Teach the switcher about new registers.
Tue, Jul 23, 11:20 AM
andrew requested review of D46076: arm64/vmm: Teach vmm_arm.c about VHE.
Tue, Jul 23, 11:20 AM
andrew requested review of D46075: arm64/vmm: Create functions to call into EL2.
Tue, Jul 23, 11:20 AM
andrew requested review of D46074: arm64/vmm: Teach the vtimer about VHE.
Tue, Jul 23, 11:19 AM
andrew requested review of D46073: arm64/vmm: Move nVHE-only code to the new file.
Tue, Jul 23, 11:19 AM
andrew requested review of D46072: arm64/vmm: Start to extract code not needed by VHE.
Tue, Jul 23, 11:19 AM
andrew requested review of D46071: arm64: Add counter timer registers to armreg.h.
Tue, Jul 23, 11:19 AM
andrew committed rG9840598aa31f: dev/uart: Add APMC0D08 as found in the Intel E2100 (authored by andrew).
dev/uart: Add APMC0D08 as found in the Intel E2100
Tue, Jul 23, 9:52 AM
andrew committed rG034c83fd7d85: arm64: Ensure sctlr and pstate are in known states (authored by andrew).
arm64: Ensure sctlr and pstate are in known states
Tue, Jul 23, 9:52 AM
andrew committed rG57ef7935eb11: arm64: Fix the gicv3 check in locore.S (authored by andrew).
arm64: Fix the gicv3 check in locore.S
Tue, Jul 23, 9:52 AM
andrew committed rG997511dffe65: arm64: Support counter access with E2H (authored by andrew).
arm64: Support counter access with E2H
Tue, Jul 23, 9:52 AM
andrew closed D45834: dev/uart: Add APMC0D08 as found in the Intel E2100.
Tue, Jul 23, 9:52 AM
andrew closed D45528: arm64: Ensure sctlr and pstate are in known states.
Tue, Jul 23, 9:52 AM
andrew committed rG47361851bc2e: arm64: Add EL1 and EL12 register alt names (authored by andrew).
arm64: Add EL1 and EL12 register alt names
Tue, Jul 23, 9:52 AM
andrew closed D45530: arm64: Fix the gicv3 check in locore.S.
Tue, Jul 23, 9:52 AM
andrew closed D45529: arm64: Support counter access with E2H.
Tue, Jul 23, 9:52 AM
andrew closed D45525: arm64: Add EL1 and EL12 register alt names.
Tue, Jul 23, 9:52 AM

Wed, Jul 17

andrew accepted D32955: Retire unused non-PCI_RES_BUS code.
Wed, Jul 17, 5:29 PM
andrew accepted D32954: Retire non-NEW_PCIB code and remove config option.
Wed, Jul 17, 2:35 PM

Mon, Jul 15

andrew committed rGf9878b9c8efa: arm64: Add the TCR_EL2.PS mask (authored by andrew).
arm64: Add the TCR_EL2.PS mask
Mon, Jul 15, 12:45 PM
andrew committed rG41c730459831: arm64: Disable outling atomics (authored by andrew).
arm64: Disable outling atomics
Mon, Jul 15, 12:44 PM
andrew committed rG1320b22f49b2: dev/psci: Check all compat strings (authored by andrew).
dev/psci: Check all compat strings
Mon, Jul 15, 12:44 PM
andrew committed rG5b1f4e679dea: arm64: Disable outling atomics (authored by andrew).
arm64: Disable outling atomics
Mon, Jul 15, 12:41 PM
andrew committed rG19349d339406: binmiscctl.8: Change the example to armv7 (authored by andrew).
binmiscctl.8: Change the example to armv7
Mon, Jul 15, 12:41 PM
andrew committed rG833ccd66dac6: cdefs: Add __writeonly to mark write only vars (authored by andrew).
cdefs: Add __writeonly to mark write only vars
Mon, Jul 15, 12:41 PM
andrew committed rG77d05874de8e: ibcore: Mark write-only variables (authored by andrew).
ibcore: Mark write-only variables
Mon, Jul 15, 12:41 PM
andrew committed rG258672fe62af: arm64: Fix indentation to be consistent (authored by andrew).
arm64: Fix indentation to be consistent
Mon, Jul 15, 12:40 PM
andrew committed rG8971fe25a80b: stats: Fix the build under gcc (authored by andrew).
stats: Fix the build under gcc
Mon, Jul 15, 12:40 PM
andrew committed rG2b2c134337ff: arm64: add PMBSR_MSS_{BSC,FSC} status code field (authored by zachary.leaf_arm.com).
arm64: add PMBSR_MSS_{BSC,FSC} status code field
Mon, Jul 15, 12:40 PM
andrew committed rG8ecef12113ad: sys: Build arm64 per-thread SSP with GCC (authored by andrew).
sys: Build arm64 per-thread SSP with GCC
Mon, Jul 15, 12:40 PM
andrew committed rGdfd26e29dd43: dev/hwpmc: Fix the dmc620 MD4 macro (authored by andrew).
dev/hwpmc: Fix the dmc620 MD4 macro
Mon, Jul 15, 12:40 PM
andrew committed rGd8a9e188f279: arm64: make SPE regs use ALT_NAME macro (authored by zachary.leaf_arm.com).
arm64: make SPE regs use ALT_NAME macro
Mon, Jul 15, 12:40 PM
andrew committed rG0496539fe32d: pci: Fix pci_host_generic_acpi with gcc (authored by andrew).
pci: Fix pci_host_generic_acpi with gcc
Mon, Jul 15, 12:40 PM
andrew committed rG0fdc0f361482: arm64/rockchip: Fix the build with GCC (authored by andrew).
arm64/rockchip: Fix the build with GCC
Mon, Jul 15, 12:40 PM
andrew committed rG2d72da2720db: arm64: Add the pointer auth registers to armreg.h (authored by andrew).
arm64: Add the pointer auth registers to armreg.h
Mon, Jul 15, 12:40 PM
andrew committed rG81e973eaf95e: arm64: Use the pointer auth register defines (authored by andrew).
arm64: Use the pointer auth register defines
Mon, Jul 15, 12:40 PM
andrew committed rGe63ac0eb580b: sys/sys: Fix __builtin_is_aligned fallback (authored by andrew).
sys/sys: Fix __builtin_is_aligned fallback
Mon, Jul 15, 12:40 PM
andrew committed rG98740a0ef56f: arm64: Use the UL macro in TCR_EL1 defines (authored by andrew).
arm64: Use the UL macro in TCR_EL1 defines
Mon, Jul 15, 12:40 PM
andrew committed rG71f04a360965: csu: Find the main pointer through the GOT (authored by andrew).
csu: Find the main pointer through the GOT
Mon, Jul 15, 12:40 PM
andrew committed rG21f3f3e87edd: stand/kboot: Fix the linker script OUTPUT_FORMAT (authored by andrew).
stand/kboot: Fix the linker script OUTPUT_FORMAT
Mon, Jul 15, 12:40 PM
andrew committed rG2bd50014977a: stand/efi: Fix for binutils when targeting arm64 (authored by andrew).
stand/efi: Fix for binutils when targeting arm64
Mon, Jul 15, 12:40 PM
andrew committed rG25eae8989139: arm: Add a missing interrupt to the generic timer (authored by andrew).
arm: Add a missing interrupt to the generic timer
Mon, Jul 15, 12:40 PM
andrew committed rG09a830be9485: arm64: Add MRS_REG_ALT_NAME ID register macros (authored by andrew).
arm64: Add MRS_REG_ALT_NAME ID register macros
Mon, Jul 15, 12:40 PM
andrew committed rGdd701489c80c: arm64: Use the _REG macros to read ID registers (authored by andrew).
arm64: Use the _REG macros to read ID registers
Mon, Jul 15, 12:40 PM
andrew committed rG2f54bff74a4b: arm64/gicv3: Check if the hardware supports LPIs (authored by andrew).
arm64/gicv3: Check if the hardware supports LPIs
Mon, Jul 15, 12:40 PM
andrew committed rGc2e0dea93f71: rtld: Add MD_OBJ_ENTRY to extend Struct_Obj_Entry (authored by andrew).
rtld: Add MD_OBJ_ENTRY to extend Struct_Obj_Entry
Mon, Jul 15, 12:40 PM
andrew committed rGab44e45862e0: dev/psci: Check all compat strings (authored by andrew).
dev/psci: Check all compat strings
Mon, Jul 15, 12:40 PM
andrew committed rG27e9c833bb8f: arm64: Add EL1 hardware breakpoint exceptions (authored by andrew).
arm64: Add EL1 hardware breakpoint exceptions
Mon, Jul 15, 12:40 PM
andrew committed rG5909ac43709a: am64: Allow cpu.h to be included from assembly (authored by andrew).
am64: Allow cpu.h to be included from assembly
Mon, Jul 15, 12:40 PM
andrew committed rG276355b8fdd3: elf_common.h: Add STO_AARCH64_VARIANT_PCS (authored by andrew).
elf_common.h: Add STO_AARCH64_VARIANT_PCS
Mon, Jul 15, 12:40 PM
andrew committed rGcf5be947352b: arm64: Use a switch to decide when to enable debug (authored by andrew).
arm64: Use a switch to decide when to enable debug
Mon, Jul 15, 12:40 PM
andrew committed rG64b0acf87c97: arm64: Mask non-debug exceptions when single stepping (authored by andrew).
arm64: Mask non-debug exceptions when single stepping
Mon, Jul 15, 12:40 PM
andrew committed rGc3d86d27c3aa: arm64: Always set the debug control and value regs (authored by andrew).
arm64: Always set the debug control and value regs
Mon, Jul 15, 12:40 PM
andrew committed rGcfba49ca49f6: arm64: Rename drop_to_el1 to enter_kernel_el (authored by andrew).
arm64: Rename drop_to_el1 to enter_kernel_el
Mon, Jul 15, 12:40 PM
andrew committed rG1ac1e83f189f: arm64: Return all registers to gdb when able (authored by andrew).
arm64: Return all registers to gdb when able
Mon, Jul 15, 12:40 PM
andrew committed rG526ad0a15765: arm64: Add TF_LR, it will be used by bhyve asm (authored by andrew).
arm64: Add TF_LR, it will be used by bhyve asm
Mon, Jul 15, 12:40 PM
andrew committed rGc7c27e9ebfdb: arm64: Add a macro to find a VM fault address (authored by andrew).
arm64: Add a macro to find a VM fault address
Mon, Jul 15, 12:40 PM
andrew committed rG0ea3e76c4bae: arm64: Add ISS_MSR_REG for ESR_ELx.ISS values (authored by andrew).
arm64: Add ISS_MSR_REG for ESR_ELx.ISS values
Mon, Jul 15, 12:40 PM
andrew committed rG9f575dadfe14: arm64: Add CurrentEL register definitions (authored by andrew).
arm64: Add CurrentEL register definitions
Mon, Jul 15, 12:40 PM
andrew committed rGc9dc783efbab: aarch64: fix branch target indications in arm64cpuid.pl and keccak1600 (authored by Tom Cosgrove <tom.cosgrove@arm.com>).
aarch64: fix branch target indications in arm64cpuid.pl and keccak1600
Mon, Jul 15, 12:40 PM
andrew committed rG98768d6870cc: ossl: Rebuild the openssl asm (authored by andrew).
ossl: Rebuild the openssl asm
Mon, Jul 15, 12:40 PM
andrew committed rG39ae01d39b55: arm64: Add more spsr_el1 register values (authored by andrew).
arm64: Add more spsr_el1 register values
Mon, Jul 15, 12:40 PM
andrew committed rGc06a19447954: aarch64: support BTI and pointer authentication in assembly (authored by Russ Butler <russ.butler@arm.com>).
aarch64: support BTI and pointer authentication in assembly
Mon, Jul 15, 12:39 PM
andrew committed rG64542285a832: binmiscctl.8: Change the example to armv7 (authored by andrew).
binmiscctl.8: Change the example to armv7
Mon, Jul 15, 12:39 PM
andrew committed rG4de39679dc35: ibcore: Mark write-only variables (authored by andrew).
ibcore: Mark write-only variables
Mon, Jul 15, 12:39 PM
andrew committed rG066069197864: cdefs: Add __writeonly to mark write only vars (authored by andrew).
cdefs: Add __writeonly to mark write only vars
Mon, Jul 15, 12:39 PM
andrew committed rGc73d1e81b68e: arm64: Fix indentation to be consistent (authored by andrew).
arm64: Fix indentation to be consistent
Mon, Jul 15, 12:39 PM
andrew committed rGfa84eb9cfb7e: sys: Build arm64 per-thread SSP with GCC (authored by andrew).
sys: Build arm64 per-thread SSP with GCC
Mon, Jul 15, 12:39 PM
andrew committed rGafdd32f39ff1: stats: Fix the build under gcc (authored by andrew).
stats: Fix the build under gcc
Mon, Jul 15, 12:39 PM
andrew committed rG3414984c3aff: arm64: add PMBSR_MSS_{BSC,FSC} status code field (authored by zachary.leaf_arm.com).
arm64: add PMBSR_MSS_{BSC,FSC} status code field
Mon, Jul 15, 12:39 PM
andrew committed rG750fbcc0603f: arm64: make SPE regs use ALT_NAME macro (authored by zachary.leaf_arm.com).
arm64: make SPE regs use ALT_NAME macro
Mon, Jul 15, 12:39 PM
andrew committed rGaedbe2058290: pci: Fix pci_host_generic_acpi with gcc (authored by andrew).
pci: Fix pci_host_generic_acpi with gcc
Mon, Jul 15, 12:39 PM