Page MenuHomeFreeBSD

andrew (Andrew Turner)
User

Projects

User Details

User Since
May 10 2014, 2:21 PM (626 w, 3 d)

Recent Activity

Yesterday

andrew committed rGa6add87b5e17: arm64: Load SOCDEV_PA as a literal rather than an immediate (authored by sarah.walker2_arm.com).
arm64: Load SOCDEV_PA as a literal rather than an immediate
Tue, May 12, 4:56 PM
andrew committed rG76a2904c352b: arm64: Add RSI detection for CCA (authored by sarah.walker2_arm.com).
arm64: Add RSI detection for CCA
Tue, May 12, 4:56 PM
andrew committed rG56abdbc5f709: arm64: VM/PMAP changes for CCA guest support (authored by sarah.walker2_arm.com).
arm64: VM/PMAP changes for CCA guest support
Tue, May 12, 4:56 PM
andrew committed rGf9ba99eaa24f: physmem: Add a way to read all memory (authored by sarah.walker2_arm.com).
physmem: Add a way to read all memory
Tue, May 12, 4:56 PM
andrew committed rGcd2512eaab5c: vm: Add flags for unprotected allocations (authored by sarah.walker2_arm.com).
vm: Add flags for unprotected allocations
Tue, May 12, 4:56 PM
andrew closed D56600: arm64: Load SOCDEV_PA as a literal rather than an immediate.
Tue, May 12, 4:56 PM
andrew closed D56598: arm64: Add RSI detection for CCA.
Tue, May 12, 4:56 PM
andrew closed D56599: arm64: VM/PMAP changes for CCA guest support.
Tue, May 12, 4:56 PM
andrew closed D56518: vm: Add flags for unprotected allocations.
Tue, May 12, 4:55 PM
andrew added a comment to D56691: virtio_net: Set rx/tx busdma alignment to 1 byte.

This can be closed? It's been merged into th re-opened D55492

Tue, May 12, 9:19 AM
andrew added inline comments to D55492: virtio_net: Use bus_dma for rxq/txq buffers.
Tue, May 12, 9:19 AM · network

Fri, May 8

andrew accepted D56598: arm64: Add RSI detection for CCA.
Fri, May 8, 2:51 PM
andrew accepted D56855: arm64/vmm: Enforce a data barrier before tlbi for non-VHE.
Fri, May 8, 8:38 AM

Tue, May 5

andrew accepted D56599: arm64: VM/PMAP changes for CCA guest support.
Tue, May 5, 2:03 PM
andrew added a comment to D56598: arm64: Add RSI detection for CCA.

Just style

Tue, May 5, 2:00 PM
andrew accepted D56519: busdma_bounce: Allocate bounce buffers as unprotected.
Tue, May 5, 10:05 AM
andrew added a reverting change for rGc16c95192f01: virtio_net: Use bus_dma for rxq/txq buffers: rGdc00f118405e: Revert "virtio_net: Use bus_dma for rxq/txq buffers".
Tue, May 5, 9:34 AM
andrew added a reverting change for rGb5bad6df467c: virtio_net: Use bus_dma for command/ack buffers: rGc8167ebb742c: Revert "virtio_net: Use bus_dma for command/ack buffers".
Tue, May 5, 9:34 AM
andrew committed rGdc00f118405e: Revert "virtio_net: Use bus_dma for rxq/txq buffers" (authored by andrew).
Revert "virtio_net: Use bus_dma for rxq/txq buffers"
Tue, May 5, 9:34 AM
andrew committed rGc8167ebb742c: Revert "virtio_net: Use bus_dma for command/ack buffers" (authored by andrew).
Revert "virtio_net: Use bus_dma for command/ack buffers"
Tue, May 5, 9:34 AM
andrew added a reverting change for D55492: virtio_net: Use bus_dma for rxq/txq buffers: rGdc00f118405e: Revert "virtio_net: Use bus_dma for rxq/txq buffers".
Tue, May 5, 9:33 AM · network
andrew added a reverting change for D55564: virtio_net: Use bus_dma for command/ack buffers: rGc8167ebb742c: Revert "virtio_net: Use bus_dma for command/ack buffers".
Tue, May 5, 9:33 AM

Thu, Apr 30

andrew added inline comments to D56740: dhclient: Improve server and filename validation.
Thu, Apr 30, 11:14 AM

Wed, Apr 29

andrew committed rG01ff0fa77d33: arm64: Support some per-thread sctlr_el1 fields (authored by andrew).
arm64: Support some per-thread sctlr_el1 fields
Wed, Apr 29, 11:40 AM
andrew committed rG2783fb7e7321: arm64: Fix a MTE check (authored by andrew).
arm64: Fix a MTE check
Wed, Apr 29, 11:40 AM
andrew closed D55950: arm64: Support some per-thread sctlr_el1 fields.
Wed, Apr 29, 11:40 AM

Tue, Apr 28

andrew added a reviewer for D56691: virtio_net: Set rx/tx busdma alignment to 1 byte: markj.
Tue, Apr 28, 1:44 PM
andrew added a comment to D56551: arm64/vmm: Use the VNCR_EL2 memory page to store guest registers.

It looks like the two capability registers this change affects are elr_el1 and vbar_el1. Both of these have at least 128 bits of space before the next register, so storage shouldn't be a problem for Morello.

sp_el0, tpidr_el0, tpidrro_el0, and tpidr_el1 could be split into a new capability array when they are managed in a later change.

Also sp_el1 and tpidr_el2 in the VNCR space (why is tpidr_el2 even in there? I don't know if I want to know...). I would really like to not land this patch before it's clear there's an *easy* path to making this work on Morello. Breaking bhyve on Morello would be really quite unfortunate and hostile towards CheriBSD.

Tue, Apr 28, 10:43 AM

Mon, Apr 27

andrew accepted D56601: arm64: Ditch arm64-specific unsound PCPU optimisation.
Mon, Apr 27, 11:42 AM
andrew committed rGb5bad6df467c: virtio_net: Use bus_dma for command/ack buffers (authored by sarah.walker2_arm.com).
virtio_net: Use bus_dma for command/ack buffers
Mon, Apr 27, 11:39 AM
andrew committed rGc16c95192f01: virtio_net: Use bus_dma for rxq/txq buffers (authored by sarah.walker2_arm.com).
virtio_net: Use bus_dma for rxq/txq buffers
Mon, Apr 27, 11:39 AM
andrew committed rG04e4268f60e4: arm64: Remove cpu_tlb_flushID now it's unused (authored by andrew).
arm64: Remove cpu_tlb_flushID now it's unused
Mon, Apr 27, 11:39 AM
andrew committed rG4bdbb6f7f7c6: arm64: Stop using cpu_tlb_flushID in kexec (authored by andrew).
arm64: Stop using cpu_tlb_flushID in kexec
Mon, Apr 27, 11:39 AM
andrew committed rGe63eee84cad5: libgcc_s: Add a linker script to link to libgcc (authored by andrew).
libgcc_s: Add a linker script to link to libgcc
Mon, Apr 27, 11:39 AM
andrew closed D52185: arm64: Remove cpu_tlb_flushID now it's unused.
Mon, Apr 27, 11:39 AM
andrew closed D45268: libgcc_s: Add a linker script to link to libgcc.
Mon, Apr 27, 11:39 AM
andrew closed D55564: virtio_net: Use bus_dma for command/ack buffers.
Mon, Apr 27, 11:39 AM
andrew closed D55492: virtio_net: Use bus_dma for rxq/txq buffers.
Mon, Apr 27, 11:39 AM · network
andrew accepted D55564: virtio_net: Use bus_dma for command/ack buffers.
Mon, Apr 27, 10:52 AM
andrew accepted D55492: virtio_net: Use bus_dma for rxq/txq buffers.
Mon, Apr 27, 10:51 AM · network

Thu, Apr 23

andrew added inline comments to D56598: arm64: Add RSI detection for CCA.
Thu, Apr 23, 4:12 PM
andrew added inline comments to D56551: arm64/vmm: Use the VNCR_EL2 memory page to store guest registers.
Thu, Apr 23, 4:08 PM
andrew added reviewers for D56599: arm64: VM/PMAP changes for CCA guest support: alc, markj, kib.
Thu, Apr 23, 3:49 PM
andrew accepted D56600: arm64: Load SOCDEV_PA as a literal rather than an immediate.
Thu, Apr 23, 3:24 PM
andrew added a comment to D56551: arm64/vmm: Use the VNCR_EL2 memory page to store guest registers.

It looks like the two capability registers this change affects are elr_el1 and vbar_el1. Both of these have at least 128 bits of space before the next register, so storage shouldn't be a problem for Morello.

Thu, Apr 23, 10:00 AM
andrew added a comment to D56520: arm64: Add CCA guest support.

I think we can split out the pmap and busdma parts into 2 new revisions (i.e. one for pmap, one for busdma)

Thu, Apr 23, 9:36 AM
andrew added a comment to D56518: vm: Add flags for unprotected allocations.
In D56518#1295709, @alc wrote:

Just out of curiosity, where are the pmap changes?

Thu, Apr 23, 7:05 AM

Wed, Apr 22

andrew accepted D56550: arm64/vmm: Add FEAT_NV2 definitions.
Wed, Apr 22, 2:25 PM

Tue, Apr 21

andrew added a comment to D56551: arm64/vmm: Use the VNCR_EL2 memory page to store guest registers.

We will need to handle accessing different sized registers to support FEAT_D128, e.g. VTTBR_EL2 will be 128 bit there.

Tue, Apr 21, 2:13 PM
andrew added inline comments to D56550: arm64/vmm: Add FEAT_NV2 definitions.
Tue, Apr 21, 1:25 PM
andrew added a comment to D55947: arm64: mte: handle synchronous tag check faults.

I can move them to something like 200/201. I think the Arm Permission Overlay Extension (FEAT_S1POE) could then reuse SEGV_PKUERR as it is similar.

Tue, Apr 21, 7:47 AM

Mon, Apr 20

andrew added reviewers for D56518: vm: Add flags for unprotected allocations: kib, alc, markj, andrew.
Mon, Apr 20, 1:23 PM

Thu, Apr 16

andrew committed rG6f9e9eba984f: arm64: mte: handle synchronous tag check faults (authored by harry.moulton_arm.com).
arm64: mte: handle synchronous tag check faults
Thu, Apr 16, 2:23 PM
andrew committed rGaa2d89cb4263: arm64: mte: add tagged memory attribute (authored by harry.moulton_arm.com).
arm64: mte: add tagged memory attribute
Thu, Apr 16, 2:23 PM
andrew closed D55948: arm64: mte: add tagged memory attribute.
Thu, Apr 16, 2:23 PM
andrew closed D55947: arm64: mte: handle synchronous tag check faults.
Thu, Apr 16, 2:23 PM
andrew updated the diff for D55950: arm64: Support some per-thread sctlr_el1 fields.

Stop switching sctlr user bits for kernel threads

Thu, Apr 16, 2:10 PM
andrew added a comment to D45268: libgcc_s: Add a linker script to link to libgcc.

Was it decided if this was an acceptable approach? I found the sanitizer runtimes also need this to work correctly, so would like to push to fix them

Thu, Apr 16, 1:46 PM
andrew added a comment to D55492: virtio_net: Use bus_dma for rxq/txq buffers.

Does anyone have any more testing they would like to do, or shall I push this to main?

Thu, Apr 16, 1:38 PM · network

Wed, Apr 15

andrew accepted D56403: arm64: Define the .iplt section placement..
Wed, Apr 15, 10:14 AM

Tue, Apr 14

andrew updated the diff for D55947: arm64: mte: handle synchronous tag check faults.

Change the SEGV_MTE* values

Tue, Apr 14, 9:32 AM

Mon, Apr 13

andrew updated subscribers of D55947: arm64: mte: handle synchronous tag check faults.
Mon, Apr 13, 2:28 PM
andrew updated the diff for D55949: arm64: Support changing the DMAP memory type.

Update comments

Mon, Apr 13, 2:26 PM
andrew committed rG58de79153622: arm64: mte: configure initial state for system registers (authored by harry.moulton_arm.com).
arm64: mte: configure initial state for system registers
Mon, Apr 13, 2:25 PM
andrew committed rGaa555b6004d6: arm64: mte: add system register definitions (authored by harry.moulton_arm.com).
arm64: mte: add system register definitions
Mon, Apr 13, 2:25 PM
andrew committed rG7e718b9a8eec: arm64: mte: cleanup cache register definitions (authored by harry.moulton_arm.com).
arm64: mte: cleanup cache register definitions
Mon, Apr 13, 2:25 PM
andrew closed D55945: arm64: mte: add system register definitions.
Mon, Apr 13, 2:24 PM
andrew closed D55946: arm64: mte: configure initial state for system registers.
Mon, Apr 13, 2:24 PM
andrew committed rG580958427536: arm64: Handle changing self-referential DMAP pages (authored by andrew).
arm64: Handle changing self-referential DMAP pages
Mon, Apr 13, 2:24 PM
andrew committed rGc208439cdb58: arm64: Add a cmap page to pmap (authored by andrew).
arm64: Add a cmap page to pmap
Mon, Apr 13, 2:24 PM
andrew closed D55944: arm64: mte: cleanup cache register definitions.
Mon, Apr 13, 2:24 PM
andrew closed D55943: arm64: Handle changing self-referential DMAP pages.
Mon, Apr 13, 2:24 PM
andrew closed D56306: arm64: Add a cmap page to pmap.
Mon, Apr 13, 2:24 PM
andrew added inline comments to D55949: arm64: Support changing the DMAP memory type.
Mon, Apr 13, 2:13 PM
andrew accepted D55946: arm64: mte: configure initial state for system registers.
Mon, Apr 13, 11:54 AM
andrew accepted D55945: arm64: mte: add system register definitions.
Mon, Apr 13, 11:53 AM
andrew accepted D55944: arm64: mte: cleanup cache register definitions.
Mon, Apr 13, 11:53 AM

Apr 13 2026

andrew closed D56156: virtio_blk: Fix initialisation of dump request structure.

Committed in rGf54209510b1b30b1445792db7d33401f7c7a97d6 with the wrong tag

Apr 13 2026, 10:37 AM

Apr 10 2026

andrew updated the diff for D55943: arm64: Handle changing self-referential DMAP pages.

Update after D56306 changes

Apr 10 2026, 2:23 PM
andrew updated the summary of D56306: arm64: Add a cmap page to pmap.
Apr 10 2026, 2:11 PM
andrew updated the diff for D56306: arm64: Add a cmap page to pmap.

Remove per-cpu pointers

Apr 10 2026, 2:10 PM
andrew added a comment to D56333: tests/sys: Fix the build on non-arm64.

In the meantime this commit should be reverted as it it's not possible to run tests right now.

It looks like this was fixed independently by commit 8672683ec80a6767b1aa12dedeed94d20ec57911.

Apr 10 2026, 1:57 PM
andrew updated the diff for D56333: tests/sys: Fix the build on non-arm64.

Set TESTSDIR to install the Kyuafile in the correct place

Apr 10 2026, 1:48 PM
andrew added a comment to D56333: tests/sys: Fix the build on non-arm64.

I'm not sure how that can happen as by including bsd.test.mk a Kyuafile should be created, e.g.

$ cat /usr/obj/.../amd64.amd64/tests/sys/arch/Kyuafile
-- Automatically generated by bsd.test.mk.
Apr 10 2026, 9:52 AM

Apr 9 2026

andrew updated the diff for D56333: tests/sys: Fix the build on non-arm64.

Move to Makefile.inc

Apr 9 2026, 4:25 PM
andrew added inline comments to D56333: tests/sys: Fix the build on non-arm64.
Apr 9 2026, 4:23 PM
andrew committed rGf54209510b1b: virtio_blk: Fix initialisation of dump request structure (authored by sarah.walker2_arm.com).
virtio_blk: Fix initialisation of dump request structure
Apr 9 2026, 2:15 PM
andrew requested review of D56333: tests/sys: Fix the build on non-arm64.
Apr 9 2026, 2:11 PM

Apr 8 2026

andrew committed rG0ddaa4c86d68: arm64: Add arm64 SVE tests (authored by andrew).
arm64: Add arm64 SVE tests
Apr 8 2026, 2:22 PM
andrew closed D43311: arm64: Add arm64 SVE tests.
Apr 8 2026, 2:21 PM
andrew committed rG920f5f6e10a0: arm64: Treat the PMUVer field of ID_AA64DFR0 as unsigned (authored by kajetan.puchalski_arm.com).
arm64: Treat the PMUVer field of ID_AA64DFR0 as unsigned
Apr 8 2026, 2:02 PM
andrew committed rGf6f5d927bf75: arm64: Have a common call to userret (authored by andrew).
arm64: Have a common call to userret
Apr 8 2026, 2:02 PM
andrew committed rGb608ec429777: arm64: Add MOPS implementations of copyin/copyout (authored by sarah.walker2_arm.com).
arm64: Add MOPS implementations of copyin/copyout
Apr 8 2026, 2:02 PM
andrew committed rGcf9949fa6c00: arm64: Optimise the repeated TLBI workaround (authored by andrew).
arm64: Optimise the repeated TLBI workaround
Apr 8 2026, 2:02 PM
andrew committed rGe40964f7123e: arm64: Add MOPS implementation of pagezero() (authored by sarah.walker2_arm.com).
arm64: Add MOPS implementation of pagezero()
Apr 8 2026, 2:02 PM
andrew committed rGedc0dd0445b7: arm64: Enable MOPS usage in the kernel (authored by sarah.walker2_arm.com).
arm64: Enable MOPS usage in the kernel
Apr 8 2026, 2:02 PM
andrew committed rG1d4a619667ea: arm64/vmm: Support PMU v3p9 (authored by andrew).
arm64/vmm: Support PMU v3p9
Apr 8 2026, 2:02 PM
andrew committed rG44d6e17c86cf: arm64: Add MOPS implementations of memset(), memcpy() and memmove() (authored by sarah.walker2_arm.com).
arm64: Add MOPS implementations of memset(), memcpy() and memmove()
Apr 8 2026, 2:02 PM
andrew committed rGffaa67ef59ab: arm64: Add more HWCAP values (authored by andrew).
arm64: Add more HWCAP values
Apr 8 2026, 2:02 PM
andrew committed rG767f1aa9fb64: arm64: Fix the ESR_ELx_EC_MASK definition (authored by andrew).
arm64: Fix the ESR_ELx_EC_MASK definition
Apr 8 2026, 2:02 PM