Page MenuHomeFreeBSD

andrew (Andrew Turner)
User

Projects

User Details

User Since
May 10 2014, 2:21 PM (266 w, 2 d)

Recent Activity

Yesterday

andrew accepted D20657: Three enhancements to arm64's pmap_protect().
Sun, Jun 16, 12:53 PM

Wed, Jun 12

andrew added a comment to D20585: Various arm64 pmap fixes (and one optimization).
In D20585#445331, @alc wrote:

Andrew, as I understand the current state of the pmap code, ATTR_AF is always preset (and never actually cleared) because pmap_fault() does not yet have the ability to set ATTR_AF. Is that correct?

Wed, Jun 12, 3:40 PM

Tue, Jun 11

andrew added a comment to D20562: The efifat files are no longer used: remove the code to build them..

I approve, this should go.
I'm aware of some out-of-tree build scripts that do something like:

mkimg -s gpt -b $ROOTDIR/boot/pmbr \
  -p efi:=$ROOTDIR/boot/boot1.efifat \
  -p freebsd-boot:=$ROOTDIR/boot/gptboot \
  -p freebsd-ufs:=ufs -p freebsd-swap::1G \
  -o $image

but really they need to just generate the EFI filesystem at the same time they generate the main (UFS in this case) filesystem.

Tue, Jun 11, 11:01 AM
andrew added a comment to D20587: KCOV: Use arch-dependend data type for the PCs.

I've created https://github.com/google/syzkaller/pull/1229 to fix the bug in syzkaller.

Tue, Jun 11, 10:35 AM
andrew added a comment to D20587: KCOV: Use arch-dependend data type for the PCs.

The size was set so a 32 bit tracing tool can trace a 64 bit kernel without loosing information.

Tue, Jun 11, 10:28 AM
andrew added inline comments to D20585: Various arm64 pmap fixes (and one optimization).
Tue, Jun 11, 10:14 AM

Fri, May 31

andrew accepted D20454: arm64 gic: Drop unused GICV3_IVAR_REDIST_VADDR.
Fri, May 31, 9:49 AM

Thu, May 30

andrew added inline comments to D20454: arm64 gic: Drop unused GICV3_IVAR_REDIST_VADDR.
Thu, May 30, 8:50 PM
andrew added a comment to D20416: acpi_iort: add some error handling.

How frequently is srat_resolve_its_pxm called?

Thu, May 30, 9:28 AM
andrew added inline comments to D20454: arm64 gic: Drop unused GICV3_IVAR_REDIST_VADDR.
Thu, May 30, 9:27 AM

Wed, May 29

andrew accepted D19842: gic_v3: consolidate per-cpu redistributor information.
Wed, May 29, 8:50 AM

Tue, May 28

andrew committed rS348323: The alignment is passed into contigmalloc_domainset in the 7th argument..
The alignment is passed into contigmalloc_domainset in the 7th argument.
Tue, May 28, 10:56 AM
andrew added inline comments to D19842: gic_v3: consolidate per-cpu redistributor information.
Tue, May 28, 9:55 AM
andrew committed rS348322: Teach the kernel KUBSAN runtime about alignment_assumption.
Teach the kernel KUBSAN runtime about alignment_assumption
Tue, May 28, 9:12 AM

Mon, May 27

andrew accepted D19844: gicv3_its: do LPI init only once per CPU.
Mon, May 27, 10:36 AM
andrew accepted D20418: arm64 gicv3_its: Fix a typo.
Mon, May 27, 10:31 AM

Sun, May 26

andrew accepted D20349: arm64: efi: Map memory IO region as device.
Sun, May 26, 10:29 AM

Wed, May 22

andrew requested changes to D20349: arm64: efi: Map memory IO region as device.

Having thought about it more I'm not sure this is correct. I think we should make the default case VM_MEMATTR_DEVICE. EFI_MD_ATTR_WC Is also wrong as it should be VM_MEMATTR_UNCACHEABLE so should be fixed at some stage.

Wed, May 22, 12:19 PM
andrew accepted D20349: arm64: efi: Map memory IO region as device.
Wed, May 22, 12:03 PM
andrew added inline comments to D20347: efirt: Add efi_memory_attribute.
Wed, May 22, 11:13 AM

May 9 2019

andrew added a comment to D19831: Add PT_GETREGSET.

I also return the size when the base is NULL in PT_GETREGSET.

May 9 2019, 12:42 PM
andrew updated the diff for D19831: Add PT_GETREGSET.
  • Remove xsave. It will move to a new review.
  • Add PT_SETREGSET
  • Use goto out for error handling
  • Remove sys/_iovec.h from sys/ptrace.h
May 9 2019, 12:41 PM
andrew accepted D20144: ahci: Check if bus is cache-coherent.
May 9 2019, 11:49 AM

May 8 2019

andrew accepted D19986: Add support for USB 3.0 XHCI via ACPI.
May 8 2019, 1:59 PM · arm64, Contributor Reviews (base)

May 7 2019

andrew added a comment to D19831: Add PT_GETREGSET.
In D19831#425330, @jhb wrote:

Hmm, do you have plans for a PT_SETREGSET as well?

May 7 2019, 5:28 PM
andrew accepted D19986: Add support for USB 3.0 XHCI via ACPI.
May 7 2019, 8:23 AM · arm64, Contributor Reviews (base)

May 4 2019

andrew added inline comments to D20156: Add support for RK3399 emmc.
May 4 2019, 11:48 AM

May 3 2019

andrew abandoned D7941: Add support to strings(1) to run under capsicum.
May 3 2019, 1:54 PM

May 2 2019

andrew added a reviewer for D20144: ahci: Check if bus is cache-coherent: mav.
May 2 2019, 4:33 PM

May 1 2019

andrew committed rS346996: Restore x18 in efi_arch_leave..
Restore x18 in efi_arch_leave.
May 1 2019, 5:13 PM
andrew closed D20127: Restore x18 in efi_arch_leave.
May 1 2019, 5:13 PM
andrew updated the diff for D20127: Restore x18 in efi_arch_leave.

Move loading x18 before we use it.

May 1 2019, 4:23 PM
andrew created D20127: Restore x18 in efi_arch_leave.
May 1 2019, 4:04 PM
andrew accepted D20123: Add a hw.model sysctl oid for arm64.

How does this work in a big.LITTLE SoC?

May 1 2019, 12:41 PM

Apr 25 2019

andrew added inline comments to D19986: Add support for USB 3.0 XHCI via ACPI.
Apr 25 2019, 9:55 PM · arm64, Contributor Reviews (base)
andrew added inline comments to D20054: Document the UEFI boot loading process.
Apr 25 2019, 2:49 PM

Apr 16 2019

andrew added a comment to D19844: gicv3_its: do LPI init only once per CPU.

If you think more flags will be needed later you can make it a u_int with a per-flag macro. If not just make it a bool.

Apr 16 2019, 7:58 AM

Apr 13 2019

andrew accepted D19507: Add quirk for ignoring SPCR AccessWidth values on the PL011 UART.
Apr 13 2019, 11:17 AM · arm64
andrew accepted D19843: gicv3_its: refactor LPI init to new function.
Apr 13 2019, 10:31 AM
andrew added inline comments to D19844: gicv3_its: do LPI init only once per CPU.
Apr 13 2019, 10:26 AM
andrew added a comment to D19507: Add quirk for ignoring SPCR AccessWidth values on the PL011 UART.

I'm happy with the quirk, however I'm not sure about the PCI part. It may pay to split that out into a new review as there are two independent changes in this.

Apr 13 2019, 10:17 AM · arm64

Apr 10 2019

andrew added a comment to D19871: Only set up the interrupts that will actually be used in arm generic_timer..

Do we need something similar to intr_pic_init_secondary to also disable the timers on non-boot CPUs?

Apr 10 2019, 8:36 AM

Apr 6 2019

andrew added inline comments to D19507: Add quirk for ignoring SPCR AccessWidth values on the PL011 UART.
Apr 6 2019, 9:07 AM · arm64

Apr 5 2019

andrew created D19831: Add PT_GETREGSET.
Apr 5 2019, 12:36 PM
andrew created D19830: Create sys/reg.h for the common code previously in machine/reg.h.
Apr 5 2019, 12:35 PM

Apr 3 2019

andrew added inline comments to D19814: Use 'phy-handle' in FDT to find PHY address.
Apr 3 2019, 4:22 PM

Apr 2 2019

andrew added a comment to D19507: Add quirk for ignoring SPCR AccessWidth values on the PL011 UART.

From looking at the Linux PL011 driver it seems registers always start on a 32b boundary so *shiftp should always be 2. The simplest would be to add a quirk to the PL011 acpi_uart_compat_data entries to force a shift of 2. It would also be cleaner than checking for specific interface types in what should become machine independent code. Later on we may be able to use cd_regshft and cd_regiowidth to override the SPCR details, however it looks like the ns8250 driver may need some careful clean up first.

Apr 2 2019, 8:55 PM · arm64

Mar 29 2019

andrew accepted D19745: Improve debugging options in bcm2835_sdhci.c.

I wonder if there is a way to make this generic as the dprintf or similar macro seems to be common in arm code.

Mar 29 2019, 11:39 AM

Mar 28 2019

andrew added inline comments to D19287: Check the index hasn't changed after writing the cmp entry.
Mar 28 2019, 8:49 AM

Mar 25 2019

andrew committed rS345510: Sort printing of the ID registers on arm64 to be identical to the.
Sort printing of the ID registers on arm64 to be identical to the
Mar 25 2019, 6:02 PM

Mar 21 2019

andrew added inline comments to D16892: add pci support at rt1310.
Mar 21 2019, 10:20 AM

Mar 8 2019

andrew added a comment to D19507: Add quirk for ignoring SPCR AccessWidth values on the PL011 UART.

Could you use spcr->SerialPort.AccessWidth to find this? It's set to 1 in the copy of the spcr table I have indicating byte access.

Mar 8 2019, 2:30 PM · arm64

Mar 7 2019

andrew accepted D17392: Add arm64 kernel support for -z ifunc-noplt.

I'm fine with breaking from the ABI in the kernel & modules as long as it's just for optimisation and we don't require the breakage to allow the kernel to still work after being built with, for example, gcc & linked with bfd.

Mar 7 2019, 2:04 PM

Mar 3 2019

andrew added inline comments to D19036: Update mvneta/e6000sw for new style Distributed Switch Architecture Device Tree Bindings.
Mar 3 2019, 3:45 PM · network, ARM, arm64
andrew accepted D19432: arm64 nexus: remove incorrect warning.
Mar 3 2019, 12:18 PM

Feb 28 2019

andrew committed rS344659: Add the hw.ncpu tunable to arm64..
Add the hw.ncpu tunable to arm64.
Feb 28 2019, 2:41 PM
andrew closed D19404: Add hw.ncpu to arm64.
Feb 28 2019, 2:41 PM
andrew created D19404: Add hw.ncpu to arm64.
Feb 28 2019, 1:36 PM
andrew updated the diff for D19389: Split out the attachment from the generic-ehci driver.

Split out the header
Enable clocks, etc

Feb 28 2019, 1:10 PM

Feb 27 2019

andrew added inline comments to D19389: Split out the attachment from the generic-ehci driver.
Feb 27 2019, 4:58 PM
andrew created D19389: Split out the attachment from the generic-ehci driver.
Feb 27 2019, 4:55 PM

Feb 25 2019

andrew added a comment to D19351: Allow kernel config to specify DTS/DTSO to build, and out-of-tree support.

Is there a reason to limit this to arm and arm64?

Feb 25 2019, 4:35 PM
andrew committed rS344517: Check the index hasn't changed after writing the cmp entry..
Check the index hasn't changed after writing the cmp entry.
Feb 25 2019, 1:15 PM
andrew closed D19287: Check the index hasn't changed after writing the cmp entry.
Feb 25 2019, 1:15 PM

Feb 21 2019

andrew created D19287: Check the index hasn't changed after writing the cmp entry.
Feb 21 2019, 8:55 PM
andrew added inline comments to D19036: Update mvneta/e6000sw for new style Distributed Switch Architecture Device Tree Bindings.
Feb 21 2019, 3:49 PM · network, ARM, arm64
andrew committed rS344432: Allow the kcov buffer to be mmaped multiple times..
Allow the kcov buffer to be mmaped multiple times.
Feb 21 2019, 10:11 AM
andrew committed rS344429: Use KCOV_ENTRY_SIZE for the entry size..
Use KCOV_ENTRY_SIZE for the entry size.
Feb 21 2019, 9:43 AM

Feb 20 2019

andrew committed rS344391: Unwire the kcov buffer when freeing the info struct..
Unwire the kcov buffer when freeing the info struct.
Feb 20 2019, 10:41 PM
andrew closed D19252: Unwire pages when cleaning up the kcov state.
Feb 20 2019, 10:41 PM
andrew reopened D19252: Unwire pages when cleaning up the kcov state.
Feb 20 2019, 10:32 PM
andrew committed rS344390: Call pmap_qenter for each page when creating the kcov buffer..
Call pmap_qenter for each page when creating the kcov buffer.
Feb 20 2019, 10:32 PM
andrew closed D19252: Unwire pages when cleaning up the kcov state.
Feb 20 2019, 10:32 PM
andrew updated the diff for D19252: Unwire pages when cleaning up the kcov state.

pmap_qenter each page
Use vm_page_next

Feb 20 2019, 6:02 PM
andrew added inline comments to D19252: Unwire pages when cleaning up the kcov state.
Feb 20 2019, 4:33 PM
andrew added inline comments to D19252: Unwire pages when cleaning up the kcov state.
Feb 20 2019, 3:51 PM
andrew updated the diff for D19252: Unwire pages when cleaning up the kcov state.

Use vm_page_lookup to find the page

Feb 20 2019, 3:36 PM
andrew updated the diff for D19252: Unwire pages when cleaning up the kcov state.

Use vm_object_reference rather than manual tracking of the mmap state

Feb 20 2019, 10:20 AM
andrew added inline comments to D19252: Unwire pages when cleaning up the kcov state.
Feb 20 2019, 9:38 AM
andrew updated the diff for D19252: Unwire pages when cleaning up the kcov state.

Add a missing header

Feb 20 2019, 9:37 AM

Feb 19 2019

andrew updated the diff for D19252: Unwire pages when cleaning up the kcov state.

Use vm_page_unwire_noq

Feb 19 2019, 8:04 PM
andrew created D19252: Unwire pages when cleaning up the kcov state.
Feb 19 2019, 7:33 PM
andrew committed rS344279: Create a common function to handle freeing the kcov info struct..
Create a common function to handle freeing the kcov info struct.
Feb 19 2019, 5:03 PM

Feb 11 2019

andrew accepted D19135: Fix compiler flags related to kernel coverage.
Feb 11 2019, 3:25 PM
andrew added inline comments to D19135: Fix compiler flags related to kernel coverage.
Feb 11 2019, 1:51 PM
andrew added inline comments to D19135: Fix compiler flags related to kernel coverage.
Feb 11 2019, 11:10 AM

Feb 8 2019

andrew committed rS343913: Fix the spelling of cov_unregister_pc..
Fix the spelling of cov_unregister_pc.
Feb 8 2019, 4:18 PM

Feb 7 2019

andrew closed D19097: Add missing pmap dsb instructions.
Feb 7 2019, 8:59 PM
andrew committed rS343876: Add missing data barriers after storeing a new valid pagetable entry..
Add missing data barriers after storeing a new valid pagetable entry.
Feb 7 2019, 8:59 PM
andrew reopened D19097: Add missing pmap dsb instructions.
Feb 7 2019, 8:51 PM
andrew committed rS343875: Add a missing data barrier to the start of arm64_tlb_flushID..
Add a missing data barrier to the start of arm64_tlb_flushID.
Feb 7 2019, 8:51 PM
andrew closed D19097: Add missing pmap dsb instructions.
Feb 7 2019, 8:51 PM
andrew added a comment to D19097: Add missing pmap dsb instructions.

Tested with overnight 'make -j 224 buildworld' without failures.

How long does that take?

Feb 7 2019, 7:29 PM
andrew created D19097: Add missing pmap dsb instructions.
Feb 7 2019, 9:53 AM

Feb 6 2019

andrew accepted D18004: pci_host_generic_acpi: use IORT data for MSI/MSI-X.
Feb 6 2019, 10:12 AM · ARM

Feb 4 2019

andrew added inline comments to D19077: uart_dev_pl011: add EARLY_PRINTF support.
Feb 4 2019, 9:03 PM
andrew accepted D19078: arm64: update early printf support.

I've been thinking about reserving a fixed VA on arm64 for this and reworking how we set the range for EARLY_PRINTF. The idea would be we only need to set the physical address, the virtual address base will be fixed, with the offset dependent on the physical address.

Feb 4 2019, 8:58 PM
andrew added inline comments to D18004: pci_host_generic_acpi: use IORT data for MSI/MSI-X.
Feb 4 2019, 5:26 PM · ARM
andrew accepted D18003: arm64 gicv3: add IORT and NUMA support.
Feb 4 2019, 5:25 PM · ARM
andrew accepted D18002: arm64 acpi: Add support for IORT table.
Feb 4 2019, 5:25 PM