Page MenuHomeFreeBSD

andrew (Andrew Turner)
User

Projects

User Details

User Since
May 10 2014, 2:21 PM (446 w, 5 d)

Recent Activity

Wed, Nov 23

andrew added a comment to D37419: arm: support for VFP in kernel.

Therefore, in context switch any additional call to vfp_save_state should cause storing vfp state in temporary &ctx->state. Is it a case you were referring to?

Wed, Nov 23, 12:04 PM
andrew added a comment to D37419: arm: support for VFP in kernel.

I'm not sure this is correct in the case we have a userspace thread calling into the kernel when the kernel uses the VFP.

Wed, Nov 23, 8:28 AM
andrew added a comment to D37441: param: increase KSTACK for hash context.

Why do you need 8 pages? That's a large increase from the 2 currently used on arm.

Wed, Nov 23, 8:14 AM

Fri, Nov 18

andrew accepted D37438: arm64/pmap: freed only used for PV_STATS.
Fri, Nov 18, 5:01 PM

Thu, Nov 17

andrew requested review of D37428: Import the kernel parts of bhyve/arm64.
Thu, Nov 17, 6:15 PM
andrew requested review of D37427: Support adding child devices to the genreic timer.
Thu, Nov 17, 6:12 PM
andrew requested review of D37426: Create a proper subclass for the arm generic timer.
Thu, Nov 17, 6:11 PM
andrew requested review of D37425: Enable all timer interrupts.
Thu, Nov 17, 6:11 PM
andrew requested review of D37424: Keep per-timer interrupt data together.
Thu, Nov 17, 6:11 PM
andrew committed rGc15085278cb5: arm64 pmap: implement per-superpage locks (authored by andrew).
arm64 pmap: implement per-superpage locks
Thu, Nov 17, 5:13 PM
andrew closed D36310: arm64 pmap: implement per-superpage locks.
Thu, Nov 17, 5:13 PM
andrew updated the diff for D37399: Support the arm64 pmap_remove_write for stage 2.

Fix the check before calling vm_page_dirty

Thu, Nov 17, 12:17 PM
andrew added inline comments to D37254: Support arm64 stage2 TLB invalidation.
Thu, Nov 17, 12:12 PM

Wed, Nov 16

andrew accepted D37394: usb/dwc3: Only force USB2 based on the PHY register and IP version.
Wed, Nov 16, 9:51 AM

Tue, Nov 15

andrew requested review of D37399: Support the arm64 pmap_remove_write for stage 2.
Tue, Nov 15, 6:07 PM
andrew updated the diff for D37254: Support arm64 stage2 TLB invalidation.

Add stage 2 TLB invalidation to pmap_enter

Tue, Nov 15, 6:04 PM
andrew committed rG8a2adde1e4b3: Split out the arm64 EL2 exception vectors (authored by andrew).
Split out the arm64 EL2 exception vectors
Tue, Nov 15, 5:32 PM
andrew committed rG2468c61958f5: Add more arm64 hypervisor registers (authored by andrew).
Add more arm64 hypervisor registers
Tue, Nov 15, 5:32 PM
andrew committed rGae43a817d33d: Put the arm64 vttbr_el2 register into a state (authored by andrew).
Put the arm64 vttbr_el2 register into a state
Tue, Nov 15, 5:32 PM
andrew committed rG80ba994bfacd: Add the arch field to the arm64 MIDR macros (authored by andrew).
Add the arch field to the arm64 MIDR macros
Tue, Nov 15, 5:32 PM
andrew accepted D37392: dwc3: Handle optional clocks.
Tue, Nov 15, 3:28 PM
andrew added inline comments to D37392: dwc3: Handle optional clocks.
Tue, Nov 15, 3:12 PM
andrew added inline comments to D37394: usb/dwc3: Only force USB2 based on the PHY register and IP version.
Tue, Nov 15, 3:07 PM
andrew accepted D37393: usb/dwc3: Read the full IDs/version.
Tue, Nov 15, 2:47 PM
andrew added inline comments to D37393: usb/dwc3: Read the full IDs/version.
Tue, Nov 15, 2:03 PM
andrew requested changes to D34646: Check alignment of `fp` in `unwind_frame`.

I think you either want __is_aligned or to define is_aligned in FreeBSD. I only see is_aligned in CheriBSD.

Tue, Nov 15, 12:40 PM
andrew reopened D34646: Check alignment of `fp` in `unwind_frame`.

Reverted as it breaks the build.

Tue, Nov 15, 12:39 PM
andrew committed rG386a5e3ae63f: Rename the arm64 pmap_invalidate_* functions (authored by andrew).
Rename the arm64 pmap_invalidate_* functions
Tue, Nov 15, 12:39 PM
andrew closed D37302: Rename the arm64 pmap_invalidate_* functions.
Tue, Nov 15, 12:39 PM
andrew closed D37299: Disable superpage use for stage 2 arm64 mappings.
Tue, Nov 15, 12:39 PM
andrew committed rG0b976be033c2: Disable superpage use for stage 2 arm64 mappings (authored by andrew).
Disable superpage use for stage 2 arm64 mappings
Tue, Nov 15, 12:39 PM
andrew added a reverting change for rG40e0fa10f58d: Check alignment of fp in unwind_frame: rGba2bbac4c15a: Revert "Check alignment of fp in unwind_frame".
Tue, Nov 15, 12:39 PM
andrew committed rGba2bbac4c15a: Revert "Check alignment of fp in unwind_frame" (authored by andrew).
Revert "Check alignment of fp in unwind_frame"
Tue, Nov 15, 12:38 PM
andrew added a reverting change for D34646: Check alignment of `fp` in `unwind_frame`: rGba2bbac4c15a: Revert "Check alignment of fp in unwind_frame".
Tue, Nov 15, 12:38 PM

Fri, Nov 11

andrew updated the diff for D37357: Add support for an array of hwresets.

Remove unneeded NULL check

Fri, Nov 11, 9:51 AM
andrew added inline comments to D37357: Add support for an array of hwresets.
Fri, Nov 11, 9:49 AM
andrew requested review of D37358: Use hwreset_array in the Rockchip tsadc driver.
Fri, Nov 11, 9:44 AM
andrew requested review of D37357: Add support for an array of hwresets.
Fri, Nov 11, 9:28 AM
andrew committed rG9142f3a8852c: Fix a rk356x pinctrl register offset (authored by andrew).
Fix a rk356x pinctrl register offset
Fri, Nov 11, 8:51 AM

Thu, Nov 10

andrew added a comment to D37316: SCMI support.

I think the extres changes should be split out to a new file.

Thu, Nov 10, 8:55 AM

Mon, Nov 7

andrew added inline comments to D37254: Support arm64 stage2 TLB invalidation.
Mon, Nov 7, 4:20 PM
andrew updated the diff for D37254: Support arm64 stage2 TLB invalidation.
  • Rebase on D37302
  • Remove an extra space
  • Create a common entry point for stage 1 and 2 invalidation functions
  • Implement stage 2 page invalidation with a range callback
Mon, Nov 7, 4:19 PM
andrew requested review of D37302: Rename the arm64 pmap_invalidate_* functions.
Mon, Nov 7, 4:15 PM
andrew requested review of D37299: Disable superpage use for stage 2 arm64 mappings.
Mon, Nov 7, 11:32 AM

Fri, Nov 4

andrew accepted D37255: arm64: Disable per-thread stack-smashing protection in data_abort().
Fri, Nov 4, 5:22 PM
andrew added inline comments to D37255: arm64: Disable per-thread stack-smashing protection in data_abort().
Fri, Nov 4, 4:19 PM
andrew added a comment to D37254: Support arm64 stage2 TLB invalidation.

Most of it is in the kernel. Only the virtual machine switcher, stage 2 tlb handling, cache handling, and support to read a few EL2 registers needs to live in EL2.

Fri, Nov 4, 10:38 AM

Thu, Nov 3

andrew requested review of D37254: Support arm64 stage2 TLB invalidation.
Thu, Nov 3, 6:56 PM
andrew committed rGb6a72a9f90c7: Enable hyperv in the arm64 NOTES (authored by andrew).
Enable hyperv in the arm64 NOTES
Thu, Nov 3, 3:55 PM
andrew committed rGd98911f69062: Hyper-V depends on ACPI, mark as such in files.arm64 (authored by andrew).
Hyper-V depends on ACPI, mark as such in files.arm64
Thu, Nov 3, 3:54 PM
andrew committed rG4343f4019f2c: Place the hyperv files with other dev files (authored by andrew).
Place the hyperv files with other dev files
Thu, Nov 3, 3:54 PM
andrew committed rGf98c118e2edf: Clean up "optional hyperv" indentation in files.arm64 (authored by andrew).
Clean up "optional hyperv" indentation in files.arm64
Thu, Nov 3, 3:54 PM
andrew added a reverting change for rGfe36346a8904: Disable Hyper-V on arm64: rG7046ff4974b1: Revert "Disable Hyper-V on arm64".
Thu, Nov 3, 3:00 PM
andrew committed rG7046ff4974b1: Revert "Disable Hyper-V on arm64" (authored by andrew).
Revert "Disable Hyper-V on arm64"
Thu, Nov 3, 3:00 PM
andrew committed rG402c04af1bc8: Add more SOC options to the arm64 NOTES file (authored by andrew).
Add more SOC options to the arm64 NOTES file
Thu, Nov 3, 10:17 AM
andrew committed rG4c52da33a2bd: Mark ar64 drivers that depend on fdt as such (authored by andrew).
Mark ar64 drivers that depend on fdt as such
Thu, Nov 3, 10:17 AM
andrew committed rG81bdc9ebe3d5: Include sys/malloc.h directly in the qoriq clock (authored by andrew).
Include sys/malloc.h directly in the qoriq clock
Thu, Nov 3, 10:17 AM
andrew committed rGcc72012d423c: Make all options lower case in files.arm64 (authored by andrew).
Make all options lower case in files.arm64
Thu, Nov 3, 10:17 AM
andrew committed rG19db791d6b70: Mark soc_intel_stratix10 drivers as needing FDT (authored by andrew).
Mark soc_intel_stratix10 drivers as needing FDT
Thu, Nov 3, 10:17 AM
andrew committed rG2222b0e7133e: Sort the SOC options in the arm64 NOTES config (authored by andrew).
Sort the SOC options in the arm64 NOTES config
Thu, Nov 3, 10:17 AM

Wed, Nov 2

andrew accepted D37231: arm64: Handle translation faults for thread structures.
Wed, Nov 2, 5:23 PM
andrew added inline comments to D37231: arm64: Handle translation faults for thread structures.
Wed, Nov 2, 4:24 PM

Nov 1 2022

andrew added inline comments to D37231: arm64: Handle translation faults for thread structures.
Nov 1 2022, 9:27 PM
andrew accepted D37222: FreeBSD enablement for ARM64 in Hyper-V: making INTR MP Safe.
Nov 1 2022, 2:18 PM

Oct 31 2022

andrew accepted D37219: FreeBSD enablement for ARM64 in Hyper-V: fixing hung issue during Hyper-V initialization.
Oct 31 2022, 11:51 AM
andrew added a comment to D37219: FreeBSD enablement for ARM64 in Hyper-V: fixing hung issue during Hyper-V initialization.

This should be 4 commits, one for each file.

Oct 31 2022, 9:01 AM

Oct 28 2022

andrew added a comment to D36744: FreeBSD enablement for ARM64 in Hyper-V.

after bisecting it seems this commit causes RPI4b (early model) to hang on (pxe-)boot short before starting CPUs :

Oct 28 2022, 9:23 PM
andrew committed rGfe36346a8904: Disable Hyper-V on arm64 (authored by andrew).
Disable Hyper-V on arm64
Oct 28 2022, 9:19 PM
andrew committed rG16c10e99b878: Remove the hyperv option from std.dev (authored by andrew).
Remove the hyperv option from std.dev
Oct 28 2022, 9:19 PM
andrew committed rG78e60ba04ab3: Only include phydev_if.h when needed (authored by andrew).
Only include phydev_if.h when needed
Oct 28 2022, 5:33 PM
andrew committed rG01aaff6d1c6e: Fix the includes in regulator_fixed.c (authored by andrew).
Fix the includes in regulator_fixed.c
Oct 28 2022, 5:33 PM
andrew committed rG227046a4d2ea: Enable more extres options when FDT is missing (authored by andrew).
Enable more extres options when FDT is missing
Oct 28 2022, 5:33 PM
andrew committed rG5566f84822bf: Only include regdev_if.h when it's needed (authored by andrew).
Only include regdev_if.h when it's needed
Oct 28 2022, 5:33 PM
andrew committed rG83de69579188: Remove unneeded headers from clk_link.c (authored by andrew).
Remove unneeded headers from clk_link.c
Oct 28 2022, 5:33 PM
andrew committed rG754358108c1f: Include sys/systm.h in phy_usb.c for KASSERT (authored by andrew).
Include sys/systm.h in phy_usb.c for KASSERT
Oct 28 2022, 5:33 PM
andrew committed rG8724dd26d49f: Allow clk_fixed.c to be built without FDT (authored by andrew).
Allow clk_fixed.c to be built without FDT
Oct 28 2022, 5:33 PM
andrew added a comment to D36431: arm64: Add support to vchiq and bcm2835_audio (plus some fixes).

Did you just apply these changes, or reimplement them? The license on at least some of the files has changed there so we can't just use the changes directly.

Oct 28 2022, 11:22 AM

Oct 27 2022

andrew committed rG49750143c1e1: Add a LINT-ACPI arm64 config (authored by andrew).
Add a LINT-ACPI arm64 config
Oct 27 2022, 6:00 PM
andrew closed D37178: Stop building FDT-only modules in an ACPI only kernel.
Oct 27 2022, 6:00 PM
andrew committed rG701ab6dba4a2: Stop building FDT-only modules in an ACPI only kernel (authored by andrew).
Stop building FDT-only modules in an ACPI only kernel
Oct 27 2022, 6:00 PM
andrew retitled D37178: Stop building FDT-only modules in an ACPI only kernel from Stop buolding FDT-only modules in an ACPI only kernel to Stop building FDT-only modules in an ACPI only kernel.
Oct 27 2022, 5:09 PM
andrew requested review of D37178: Stop building FDT-only modules in an ACPI only kernel.
Oct 27 2022, 5:06 PM
andrew committed rGff270fce1631: Make sure error is defined in dpaa2 (authored by andrew).
Make sure error is defined in dpaa2
Oct 27 2022, 5:04 PM
andrew committed rG64c3edc237a5: Allow the extres regulator code to build without FDT (authored by andrew).
Allow the extres regulator code to build without FDT
Oct 27 2022, 4:32 PM
andrew committed rG91e2614a7105: Fix xdma_if.m in an ACPI only kernel (authored by andrew).
Fix xdma_if.m in an ACPI only kernel
Oct 27 2022, 4:24 PM
andrew committed rG16625cabab86: Only build if_mvneta.c when FDT is defined (authored by andrew).
Only build if_mvneta.c when FDT is defined
Oct 27 2022, 4:24 PM
andrew committed rG7ddba690f8ae: Remove an unneeded cpu_dcache_wb_range from arm64 (authored by andrew).
Remove an unneeded cpu_dcache_wb_range from arm64
Oct 27 2022, 4:12 PM
andrew committed rG7b43fba03a9c: Mark FDT only drivers as such (authored by andrew).
Mark FDT only drivers as such
Oct 27 2022, 4:12 PM
andrew closed D37037: Remove an unneeded cpu_dcache_wb_range from arm64.
Oct 27 2022, 4:12 PM
andrew added a comment to D36744: FreeBSD enablement for ARM64 in Hyper-V.

Can you rebase this on a recent main? I'm getting conflicts while trying to apply it.

Oct 27 2022, 1:49 PM

Oct 20 2022

andrew accepted D37069: arm: Remove useless armv6/armv7 options.
Oct 20 2022, 3:31 PM

Oct 18 2022

andrew added a comment to D37032: acpi_ged: New driver to ACPI generic event device.

I've tested on Parallels on a m1 Mac & do see an event. I guess it still needs something to turn that into a shutdown command?

Oct 18 2022, 4:51 PM
andrew requested review of D37037: Remove an unneeded cpu_dcache_wb_range from arm64.
Oct 18 2022, 4:47 PM
andrew accepted D37031: ofw: add BUS_GET_DEVICE_PATH interface to openfirm/fdt, somewhat incomplete..

It might be better to name the selector "OFW" to be consistant with the directory name, ofwdump, etc.

Oct 18 2022, 7:14 AM

Oct 17 2022

andrew committed rG69474c060d7c: Use DEFINE_CLASS_0 in the arm generic timer (authored by andrew).
Use DEFINE_CLASS_0 in the arm generic timer
Oct 17 2022, 10:40 AM
andrew committed rG85194e20d047: Create macros for the Arm timer IRQ indexes (authored by andrew).
Create macros for the Arm timer IRQ indexes
Oct 17 2022, 10:40 AM

Oct 14 2022

andrew added inline comments to D36638: Initial DPAA2 support.
Oct 14 2022, 11:39 AM · arm64

Oct 11 2022

andrew committed rG82860bcb6441: Add more Arm CPUs to the arm64 cpu ident (authored by andrew).
Add more Arm CPUs to the arm64 cpu ident
Oct 11 2022, 1:03 PM
andrew committed rG12c1c65d8a66: Mark 64-bit arm64 hypervisor registers with UL (authored by andrew).
Mark 64-bit arm64 hypervisor registers with UL
Oct 11 2022, 1:02 PM

Oct 10 2022

andrew accepted D36926: hwpmc: Define full set of Armv8.0 events.

It might pay to also add a comment somewhere to say Armv8.1 adds events 0x0400-0xffff

Oct 10 2022, 4:30 PM