Page MenuHomeFreeBSD

andrew (Andrew Turner)
User

Projects

User Details

User Since
May 10 2014, 2:21 PM (258 w, 16 h)

Recent Activity

Tue, Apr 16

andrew added a comment to D19844: gicv3_its: do LPI init only once per CPU.

If you think more flags will be needed later you can make it a u_int with a per-flag macro. If not just make it a bool.

Tue, Apr 16, 7:58 AM

Sat, Apr 13

andrew accepted D19507: Add quirk for ignoring SPCR AccessWidth values on the PL011 UART.
Sat, Apr 13, 11:17 AM · arm64
andrew accepted D19843: gicv3_its: refactor LPI init to new function.
Sat, Apr 13, 10:31 AM
andrew added inline comments to D19844: gicv3_its: do LPI init only once per CPU.
Sat, Apr 13, 10:26 AM
andrew added a comment to D19507: Add quirk for ignoring SPCR AccessWidth values on the PL011 UART.

I'm happy with the quirk, however I'm not sure about the PCI part. It may pay to split that out into a new review as there are two independent changes in this.

Sat, Apr 13, 10:17 AM · arm64

Wed, Apr 10

andrew added a comment to D19871: Only set up the interrupts that will actually be used in arm generic_timer..

Do we need something similar to intr_pic_init_secondary to also disable the timers on non-boot CPUs?

Wed, Apr 10, 8:36 AM

Sat, Apr 6

andrew added inline comments to D19507: Add quirk for ignoring SPCR AccessWidth values on the PL011 UART.
Sat, Apr 6, 9:07 AM · arm64

Fri, Apr 5

andrew added a child revision for D19830: Create sys/reg.h for the common code previously in machine/reg.h: D19831: Add PT_GETREGSET.
Fri, Apr 5, 12:37 PM
andrew added a parent revision for D19831: Add PT_GETREGSET: D19830: Create sys/reg.h for the common code previously in machine/reg.h.
Fri, Apr 5, 12:37 PM
andrew created D19831: Add PT_GETREGSET.
Fri, Apr 5, 12:36 PM
andrew created D19830: Create sys/reg.h for the common code previously in machine/reg.h.
Fri, Apr 5, 12:35 PM

Wed, Apr 3

andrew added inline comments to D19814: Use 'phy-handle' in FDT to find PHY address.
Wed, Apr 3, 4:22 PM

Tue, Apr 2

andrew added a comment to D19507: Add quirk for ignoring SPCR AccessWidth values on the PL011 UART.

From looking at the Linux PL011 driver it seems registers always start on a 32b boundary so *shiftp should always be 2. The simplest would be to add a quirk to the PL011 acpi_uart_compat_data entries to force a shift of 2. It would also be cleaner than checking for specific interface types in what should become machine independent code. Later on we may be able to use cd_regshft and cd_regiowidth to override the SPCR details, however it looks like the ns8250 driver may need some careful clean up first.

Tue, Apr 2, 8:55 PM · arm64

Fri, Mar 29

andrew accepted D19745: Improve debugging options in bcm2835_sdhci.c.

I wonder if there is a way to make this generic as the dprintf or similar macro seems to be common in arm code.

Fri, Mar 29, 11:39 AM

Thu, Mar 28

andrew added inline comments to D19287: Check the index hasn't changed after writing the cmp entry.
Thu, Mar 28, 8:49 AM

Mon, Mar 25

andrew committed rS345510: Sort printing of the ID registers on arm64 to be identical to the.
Sort printing of the ID registers on arm64 to be identical to the
Mon, Mar 25, 6:02 PM

Mar 21 2019

andrew added inline comments to D16892: add pci support at rt1310.
Mar 21 2019, 10:20 AM

Mar 8 2019

andrew added a comment to D19507: Add quirk for ignoring SPCR AccessWidth values on the PL011 UART.

Could you use spcr->SerialPort.AccessWidth to find this? It's set to 1 in the copy of the spcr table I have indicating byte access.

Mar 8 2019, 2:30 PM · arm64

Mar 7 2019

andrew accepted D17392: Add arm64 kernel support for -z ifunc-noplt.

I'm fine with breaking from the ABI in the kernel & modules as long as it's just for optimisation and we don't require the breakage to allow the kernel to still work after being built with, for example, gcc & linked with bfd.

Mar 7 2019, 2:04 PM

Mar 3 2019

andrew added inline comments to D19036: Update mvneta/e6000sw for new style Distributed Switch Architecture Device Tree Bindings.
Mar 3 2019, 3:45 PM · network, ARM, arm64
andrew accepted D19432: arm64 nexus: remove incorrect warning.
Mar 3 2019, 12:18 PM

Feb 28 2019

andrew committed rS344659: Add the hw.ncpu tunable to arm64..
Add the hw.ncpu tunable to arm64.
Feb 28 2019, 2:41 PM
andrew closed D19404: Add hw.ncpu to arm64.
Feb 28 2019, 2:41 PM
andrew created D19404: Add hw.ncpu to arm64.
Feb 28 2019, 1:36 PM
andrew updated the diff for D19389: Split out the attachment from the generic-ehci driver.

Split out the header
Enable clocks, etc

Feb 28 2019, 1:10 PM

Feb 27 2019

andrew added inline comments to D19389: Split out the attachment from the generic-ehci driver.
Feb 27 2019, 4:58 PM
andrew created D19389: Split out the attachment from the generic-ehci driver.
Feb 27 2019, 4:55 PM

Feb 25 2019

andrew added a comment to D19351: Allow kernel config to specify DTS/DTSO to build, and out-of-tree support.

Is there a reason to limit this to arm and arm64?

Feb 25 2019, 4:35 PM
andrew committed rS344517: Check the index hasn't changed after writing the cmp entry..
Check the index hasn't changed after writing the cmp entry.
Feb 25 2019, 1:15 PM
andrew closed D19287: Check the index hasn't changed after writing the cmp entry.
Feb 25 2019, 1:15 PM

Feb 21 2019

andrew created D19287: Check the index hasn't changed after writing the cmp entry.
Feb 21 2019, 8:55 PM
andrew added inline comments to D19036: Update mvneta/e6000sw for new style Distributed Switch Architecture Device Tree Bindings.
Feb 21 2019, 3:49 PM · network, ARM, arm64
andrew committed rS344432: Allow the kcov buffer to be mmaped multiple times..
Allow the kcov buffer to be mmaped multiple times.
Feb 21 2019, 10:11 AM
andrew committed rS344429: Use KCOV_ENTRY_SIZE for the entry size..
Use KCOV_ENTRY_SIZE for the entry size.
Feb 21 2019, 9:43 AM

Feb 20 2019

andrew committed rS344391: Unwire the kcov buffer when freeing the info struct..
Unwire the kcov buffer when freeing the info struct.
Feb 20 2019, 10:41 PM
andrew closed D19252: Unwire pages when cleaning up the kcov state.
Feb 20 2019, 10:41 PM
andrew reopened D19252: Unwire pages when cleaning up the kcov state.
Feb 20 2019, 10:32 PM
andrew committed rS344390: Call pmap_qenter for each page when creating the kcov buffer..
Call pmap_qenter for each page when creating the kcov buffer.
Feb 20 2019, 10:32 PM
andrew closed D19252: Unwire pages when cleaning up the kcov state.
Feb 20 2019, 10:32 PM
andrew updated the diff for D19252: Unwire pages when cleaning up the kcov state.

pmap_qenter each page
Use vm_page_next

Feb 20 2019, 6:02 PM
andrew added inline comments to D19252: Unwire pages when cleaning up the kcov state.
Feb 20 2019, 4:33 PM
andrew added inline comments to D19252: Unwire pages when cleaning up the kcov state.
Feb 20 2019, 3:51 PM
andrew updated the diff for D19252: Unwire pages when cleaning up the kcov state.

Use vm_page_lookup to find the page

Feb 20 2019, 3:36 PM
andrew updated the diff for D19252: Unwire pages when cleaning up the kcov state.

Use vm_object_reference rather than manual tracking of the mmap state

Feb 20 2019, 10:20 AM
andrew added inline comments to D19252: Unwire pages when cleaning up the kcov state.
Feb 20 2019, 9:38 AM
andrew updated the diff for D19252: Unwire pages when cleaning up the kcov state.

Add a missing header

Feb 20 2019, 9:37 AM

Feb 19 2019

andrew updated the diff for D19252: Unwire pages when cleaning up the kcov state.

Use vm_page_unwire_noq

Feb 19 2019, 8:04 PM
andrew created D19252: Unwire pages when cleaning up the kcov state.
Feb 19 2019, 7:33 PM
andrew committed rS344279: Create a common function to handle freeing the kcov info struct..
Create a common function to handle freeing the kcov info struct.
Feb 19 2019, 5:03 PM

Feb 11 2019

andrew accepted D19135: Fix compiler flags related to kernel coverage.
Feb 11 2019, 3:25 PM
andrew added inline comments to D19135: Fix compiler flags related to kernel coverage.
Feb 11 2019, 1:51 PM
andrew added inline comments to D19135: Fix compiler flags related to kernel coverage.
Feb 11 2019, 11:10 AM

Feb 8 2019

andrew committed rS343913: Fix the spelling of cov_unregister_pc..
Fix the spelling of cov_unregister_pc.
Feb 8 2019, 4:18 PM

Feb 7 2019

andrew closed D19097: Add missing pmap dsb instructions.
Feb 7 2019, 8:59 PM
andrew committed rS343876: Add missing data barriers after storeing a new valid pagetable entry..
Add missing data barriers after storeing a new valid pagetable entry.
Feb 7 2019, 8:59 PM
andrew reopened D19097: Add missing pmap dsb instructions.
Feb 7 2019, 8:51 PM
andrew committed rS343875: Add a missing data barrier to the start of arm64_tlb_flushID..
Add a missing data barrier to the start of arm64_tlb_flushID.
Feb 7 2019, 8:51 PM
andrew closed D19097: Add missing pmap dsb instructions.
Feb 7 2019, 8:51 PM
andrew added a comment to D19097: Add missing pmap dsb instructions.

Tested with overnight 'make -j 224 buildworld' without failures.

How long does that take?

Feb 7 2019, 7:29 PM
andrew created D19097: Add missing pmap dsb instructions.
Feb 7 2019, 9:53 AM

Feb 6 2019

andrew accepted D18004: pci_host_generic_acpi: use IORT data for MSI/MSI-X.
Feb 6 2019, 10:12 AM · ARM

Feb 4 2019

andrew added inline comments to D19077: uart_dev_pl011: add EARLY_PRINTF support.
Feb 4 2019, 9:03 PM
andrew accepted D19078: arm64: update early printf support.

I've been thinking about reserving a fixed VA on arm64 for this and reworking how we set the range for EARLY_PRINTF. The idea would be we only need to set the physical address, the virtual address base will be fixed, with the offset dependent on the physical address.

Feb 4 2019, 8:58 PM
andrew added inline comments to D18004: pci_host_generic_acpi: use IORT data for MSI/MSI-X.
Feb 4 2019, 5:26 PM · ARM
andrew accepted D18003: arm64 gicv3: add IORT and NUMA support.
Feb 4 2019, 5:25 PM · ARM
andrew accepted D18002: arm64 acpi: Add support for IORT table.
Feb 4 2019, 5:25 PM
andrew committed rS343746: Only enable trace-cmp on Clang and modern GCC..
Only enable trace-cmp on Clang and modern GCC.
Feb 4 2019, 4:55 PM
andrew accepted D19073: arm, acpi: increase size of memory region arrays.
Feb 4 2019, 9:17 AM · arm64

Feb 3 2019

andrew committed rS343713: Enable COVERAGE and KCOV by default on arm64 and amd64..
Enable COVERAGE and KCOV by default on arm64 and amd64.
Feb 3 2019, 12:46 PM

Jan 31 2019

andrew added inline comments to D19046: Rockchip RK3399 PWM driver.
Jan 31 2019, 7:24 PM · arm64

Jan 29 2019

andrew committed rS343550: Extract the coverage sanitizer KPI to a new file..
Extract the coverage sanitizer KPI to a new file.
Jan 29 2019, 11:04 AM
andrew closed D18955: Extract the coverage sanitizer KPI to a new file..
Jan 29 2019, 11:04 AM

Jan 28 2019

andrew updated the diff for D18955: Extract the coverage sanitizer KPI to a new file..

Remove a D_TRACKCLOSE that sneaked in

Jan 28 2019, 11:04 AM
andrew updated the diff for D18955: Extract the coverage sanitizer KPI to a new file..

Update the kcov tracking to be based on the number of threads actively
being traced.

Jan 28 2019, 11:03 AM

Jan 25 2019

andrew created D18955: Extract the coverage sanitizer KPI to a new file..
Jan 25 2019, 4:47 PM

Jan 15 2019

andrew committed rS343042: Ensure the I-Cache is correctly handled in arm64_icache_sync_range.
Ensure the I-Cache is correctly handled in arm64_icache_sync_range
Jan 15 2019, 9:48 AM
andrew closed D18838: Ensure the I-Cache is correctly handled in arm64_icache_sync_range.
Jan 15 2019, 9:48 AM

Jan 14 2019

andrew created D18838: Ensure the I-Cache is correctly handled in arm64_icache_sync_range.
Jan 14 2019, 10:19 AM

Jan 12 2019

andrew accepted D18826: Create crtsavres.o for powerpc builds.
Jan 12 2019, 8:44 PM
andrew committed rS342973: Fix the check for the offset of td_frame and td_emuldata in struct thread..
Fix the check for the offset of td_frame and td_emuldata in struct thread.
Jan 12 2019, 8:42 PM
andrew committed rS342963: Temporarily disable the kcov tests. Not all architectures have.
Temporarily disable the kcov tests. Not all architectures have
Jan 12 2019, 11:50 AM
andrew committed rS342962: Add support for the Clang Coverage Sanitizer in the kernel (KCOV)..
Add support for the Clang Coverage Sanitizer in the kernel (KCOV).
Jan 12 2019, 11:21 AM
andrew closed D14599: Implement kernel code coverage (kcov).
Jan 12 2019, 11:21 AM
andrew added inline comments to D18826: Create crtsavres.o for powerpc builds.
Jan 12 2019, 10:12 AM
andrew added a comment to D18826: Create crtsavres.o for powerpc builds.

You should remove crtsavres.o from gnu/lib/csu/Makefile

Jan 12 2019, 10:10 AM

Jan 11 2019

andrew committed rS342937: Fix the location of td->td_frame at the top of the kernel stack..
Fix the location of td->td_frame at the top of the kernel stack.
Jan 11 2019, 11:33 AM

Jan 10 2019

andrew committed rS342919: Fix a comment, pushed onto is two words..
Fix a comment, pushed onto is two words.
Jan 10 2019, 4:31 PM
andrew updated the diff for D14599: Implement kernel code coverage (kcov).

Fix the spelling of KCOV_ENTRY_SIZE

Jan 10 2019, 1:45 PM
andrew updated the diff for D14599: Implement kernel code coverage (kcov).

Add KCOV_ENTRIY_SIZE
While here update the header copyright

Jan 10 2019, 12:55 PM

Jan 9 2019

andrew updated the diff for D14599: Implement kernel code coverage (kcov).

Simplify the locking in kcov_mmap_cleanup
Update the comments to describe the state machine
Add access requirements to struct kcov_info

Jan 9 2019, 1:55 PM

Jan 8 2019

andrew added inline comments to D14599: Implement kernel code coverage (kcov).
Jan 8 2019, 10:24 AM

Jan 7 2019

andrew added inline comments to D14599: Implement kernel code coverage (kcov).
Jan 7 2019, 10:32 PM
andrew updated the diff for D14599: Implement kernel code coverage (kcov).

Rework the cleanup code:

  • Use barriers to ensure ordering between info->state and other info data.
  • Check if a thread is using the info struct now we don't enter DYING on thread exit
Jan 7 2019, 10:10 PM
andrew added inline comments to D14599: Implement kernel code coverage (kcov).
Jan 7 2019, 8:25 PM
andrew updated the diff for D14599: Implement kernel code coverage (kcov).

Add a missing atomic_thread_fence_seq_cst call to get_kinfo

Jan 7 2019, 7:57 PM
andrew added inline comments to D14599: Implement kernel code coverage (kcov).
Jan 7 2019, 7:56 PM
andrew added inline comments to D14599: Implement kernel code coverage (kcov).
Jan 7 2019, 6:48 PM
andrew updated the diff for D14599: Implement kernel code coverage (kcov).

Remove the kcov_thread_exit prototype from <sys/kcov.h>

Jan 7 2019, 5:57 PM
andrew added inline comments to D14599: Implement kernel code coverage (kcov).
Jan 7 2019, 5:52 PM
andrew updated the diff for D14599: Implement kernel code coverage (kcov).
  • Fix a comment
  • Remove unneeded code from kern_thread.c
  • Fix a typo in a test
Jan 7 2019, 5:52 PM