Page MenuHomeFreeBSD

andrew (Andrew Turner)
User

Projects

User Details

User Since
May 10 2014, 2:21 PM (629 w, 6 d)

Recent Activity

Yesterday

andrew committed rG0b862a795a35: arm64: Expose ESR in mcontext (authored by Alex Arslan <ararslan@comcast.net>).
arm64: Expose ESR in mcontext
Fri, Jun 5, 4:16 PM
andrew committed rG5cc3fa098856: arm64: Add exception flag for ksiginfo_t and set in trapsignal (authored by Alex Arslan <ararslan@comcast.net>).
arm64: Add exception flag for ksiginfo_t and set in trapsignal
Fri, Jun 5, 4:16 PM

Thu, Jun 4

andrew added inline comments to D56556: arm64/vmm: Make remaining registers use hypctx_*_sys_reg.
Thu, Jun 4, 2:53 PM
andrew added a comment to D56555: arm64/vmm: Move host-side EL2 regs into sys_regs.

I looks like some lines might be wider than 80 characters

Thu, Jun 4, 2:48 PM
andrew accepted D56554: arm64/vmm: Move vttbr_el2 & vtimer into struct hypctx.
Thu, Jun 4, 2:46 PM
andrew accepted D56553: arm64/vmm: Refactor vmm_hyp.c.
Thu, Jun 4, 2:45 PM
andrew added inline comments to D56552: arm64/vmm: Store non-VNCR registers in an array.
Thu, Jun 4, 2:34 PM

Wed, Jun 3

andrew accepted D56551: arm64/vmm: Use the VNCR_EL2 memory page to store guest registers.
Wed, Jun 3, 1:32 PM
andrew accepted D56896: pci: pci_host_generic: provide cleanup methods outside of detach.
Wed, Jun 3, 10:44 AM
andrew accepted D56897: pci: bcm2838: cleanup on attach failure to fix devmatch panic.
Wed, Jun 3, 10:44 AM
andrew accepted D56895: kern: ofw: provide ofw_bus_destroy_iinfo to teardown interrupt-map.
Wed, Jun 3, 10:40 AM

Fri, May 29

andrew committed rGf6911b941f14: sys: Renumber MTE SEGV codes (authored by andrew).
sys: Renumber MTE SEGV codes
Fri, May 29, 4:07 PM
andrew added a reviewer for D55957: vm: Support swapping arm64 MTE tags: cheri.

Is this something cheri could use too?

Fri, May 29, 1:49 PM

Wed, May 27

andrew committed rG7bb6b62394d3: arm64: mte: copy/save tags on copy-on-write (authored by harry.moulton_arm.com).
arm64: mte: copy/save tags on copy-on-write
Wed, May 27, 3:25 PM
andrew committed rGbb9497a2d462: arm64: Add vm_page_t MTE flags (authored by harry.moulton_arm.com).
arm64: Add vm_page_t MTE flags
Wed, May 27, 3:25 PM
andrew closed D55953: arm64: Add support for per-page flags.
Wed, May 27, 3:25 PM
andrew committed rGd63a62fb3504: arm64: Add support for per-page flags (authored by andrew).
arm64: Add support for per-page flags
Wed, May 27, 3:25 PM
andrew committed rG5a6ae4230b04: arm64: Manage the MTE state like pointer auth (authored by andrew).
arm64: Manage the MTE state like pointer auth
Wed, May 27, 3:25 PM
andrew closed D55955: arm64: mte: copy/save tags on copy-on-write.
Wed, May 27, 3:24 PM
andrew committed rG5cb511e62763: arm64: Check for MTE tag failures on kernel entry (authored by andrew).
arm64: Check for MTE tag failures on kernel entry
Wed, May 27, 3:24 PM
andrew closed D55954: arm64: Add vm_page_t MTE flags.
Wed, May 27, 3:24 PM
andrew committed rGa780d21eab97: arm64: Support changing the DMAP memory type (authored by andrew).
arm64: Support changing the DMAP memory type
Wed, May 27, 3:24 PM
andrew closed D55951: arm64: Manage the MTE state like pointer auth.
Wed, May 27, 3:24 PM
andrew committed rG48da01ad0b16: arm64: Add a comment about HWCAP values (authored by andrew).
arm64: Add a comment about HWCAP values
Wed, May 27, 3:24 PM
andrew closed D55952: arm64: Check for MTE tag failures on kernel entry.
Wed, May 27, 3:24 PM
andrew closed D55949: arm64: Support changing the DMAP memory type.
Wed, May 27, 3:24 PM

Mon, May 18

andrew added inline comments to D56556: arm64/vmm: Make remaining registers use hypctx_*_sys_reg.
Mon, May 18, 1:47 PM
andrew added inline comments to D56553: arm64/vmm: Refactor vmm_hyp.c.
Mon, May 18, 1:30 PM
andrew added a comment to D56552: arm64/vmm: Store non-VNCR registers in an array.

It looks like a few lines passed 80 characters so will need to be split.

Mon, May 18, 1:05 PM
andrew added a comment to D56551: arm64/vmm: Use the VNCR_EL2 memory page to store guest registers.

We should name __hypctx_vncr_sysreg to __hypctx_vncr_sysreg_64 or similar to indicate it supports 64-bit registers (and the other accessors). CHERI could add a version to indicate it handles capabiliries (or it handles pointer-like registers).

Mon, May 18, 1:01 PM

Fri, May 15

andrew updated the diff for D54250: arm64: Add an initial GICv5 driver.

Use D57017 to build the instructions

Fri, May 15, 2:31 PM
andrew requested review of D57017: arm64: Support building sys/sysl instructions.
Fri, May 15, 2:30 PM

Thu, May 14

andrew updated the diff for D54252: arm64: Add an initial GICv5 IWB driver.
  • Remove the unneeded bind handler
  • Cleanup better on attach failure
Thu, May 14, 4:51 PM
andrew updated the diff for D54251: arm64: Add an initial GICv5 ITS driver.
  • Clean up table size/alignment handling
  • Read the table PA range from the register
  • Support 2 level device tables
  • Support a non-coherent ITS
  • Cleanup better on attach failure
  • Implement more functions
Thu, May 14, 4:51 PM
andrew updated the diff for D54250: arm64: Add an initial GICv5 driver.
  • Clean up table size/alignment handling
  • Read the table PA range from the register
  • Handle IPIs without having to change common code
Thu, May 14, 4:51 PM
andrew committed rGb8606c3406ea: arm64: Fix the includes for rsi.c (authored by andrew).
arm64: Fix the includes for rsi.c
Thu, May 14, 9:48 AM

Tue, May 12

andrew committed rGa6add87b5e17: arm64: Load SOCDEV_PA as a literal rather than an immediate (authored by sarah.walker2_arm.com).
arm64: Load SOCDEV_PA as a literal rather than an immediate
Tue, May 12, 4:56 PM
andrew committed rG76a2904c352b: arm64: Add RSI detection for CCA (authored by sarah.walker2_arm.com).
arm64: Add RSI detection for CCA
Tue, May 12, 4:56 PM
andrew committed rG56abdbc5f709: arm64: VM/PMAP changes for CCA guest support (authored by sarah.walker2_arm.com).
arm64: VM/PMAP changes for CCA guest support
Tue, May 12, 4:56 PM
andrew committed rGf9ba99eaa24f: physmem: Add a way to read all memory (authored by sarah.walker2_arm.com).
physmem: Add a way to read all memory
Tue, May 12, 4:56 PM
andrew committed rGcd2512eaab5c: vm: Add flags for unprotected allocations (authored by sarah.walker2_arm.com).
vm: Add flags for unprotected allocations
Tue, May 12, 4:56 PM
andrew closed D56600: arm64: Load SOCDEV_PA as a literal rather than an immediate.
Tue, May 12, 4:56 PM
andrew closed D56598: arm64: Add RSI detection for CCA.
Tue, May 12, 4:56 PM
andrew closed D56599: arm64: VM/PMAP changes for CCA guest support.
Tue, May 12, 4:56 PM
andrew closed D56518: vm: Add flags for unprotected allocations.
Tue, May 12, 4:55 PM
andrew added a comment to D56691: virtio_net: Set rx/tx busdma alignment to 1 byte.

This can be closed? It's been merged into th re-opened D55492

Tue, May 12, 9:19 AM
andrew added inline comments to D55492: virtio_net: Use bus_dma for rxq/txq buffers.
Tue, May 12, 9:19 AM · network

Fri, May 8

andrew accepted D56598: arm64: Add RSI detection for CCA.
Fri, May 8, 2:51 PM
andrew accepted D56855: arm64/vmm: Enforce a data barrier before tlbi for non-VHE.
Fri, May 8, 8:38 AM

May 5 2026

andrew accepted D56599: arm64: VM/PMAP changes for CCA guest support.
May 5 2026, 2:03 PM
andrew added a comment to D56598: arm64: Add RSI detection for CCA.

Just style

May 5 2026, 2:00 PM
andrew accepted D56519: busdma_bounce: Allocate bounce buffers as unprotected.
May 5 2026, 10:05 AM
andrew added a reverting change for rGc16c95192f01: virtio_net: Use bus_dma for rxq/txq buffers: rGdc00f118405e: Revert "virtio_net: Use bus_dma for rxq/txq buffers".
May 5 2026, 9:34 AM
andrew added a reverting change for rGb5bad6df467c: virtio_net: Use bus_dma for command/ack buffers: rGc8167ebb742c: Revert "virtio_net: Use bus_dma for command/ack buffers".
May 5 2026, 9:34 AM
andrew committed rGdc00f118405e: Revert "virtio_net: Use bus_dma for rxq/txq buffers" (authored by andrew).
Revert "virtio_net: Use bus_dma for rxq/txq buffers"
May 5 2026, 9:34 AM
andrew committed rGc8167ebb742c: Revert "virtio_net: Use bus_dma for command/ack buffers" (authored by andrew).
Revert "virtio_net: Use bus_dma for command/ack buffers"
May 5 2026, 9:34 AM
andrew added a reverting change for D55492: virtio_net: Use bus_dma for rxq/txq buffers: rGdc00f118405e: Revert "virtio_net: Use bus_dma for rxq/txq buffers".
May 5 2026, 9:33 AM · network
andrew added a reverting change for D55564: virtio_net: Use bus_dma for command/ack buffers: rGc8167ebb742c: Revert "virtio_net: Use bus_dma for command/ack buffers".
May 5 2026, 9:33 AM

Apr 30 2026

andrew added inline comments to D56740: dhclient: Improve server and filename validation.
Apr 30 2026, 11:14 AM

Apr 29 2026

andrew committed rG01ff0fa77d33: arm64: Support some per-thread sctlr_el1 fields (authored by andrew).
arm64: Support some per-thread sctlr_el1 fields
Apr 29 2026, 11:40 AM
andrew committed rG2783fb7e7321: arm64: Fix a MTE check (authored by andrew).
arm64: Fix a MTE check
Apr 29 2026, 11:40 AM
andrew closed D55950: arm64: Support some per-thread sctlr_el1 fields.
Apr 29 2026, 11:40 AM

Apr 28 2026

andrew added a reviewer for D56691: virtio_net: Set rx/tx busdma alignment to 1 byte: markj.
Apr 28 2026, 1:44 PM
andrew added a comment to D56551: arm64/vmm: Use the VNCR_EL2 memory page to store guest registers.

It looks like the two capability registers this change affects are elr_el1 and vbar_el1. Both of these have at least 128 bits of space before the next register, so storage shouldn't be a problem for Morello.

sp_el0, tpidr_el0, tpidrro_el0, and tpidr_el1 could be split into a new capability array when they are managed in a later change.

Also sp_el1 and tpidr_el2 in the VNCR space (why is tpidr_el2 even in there? I don't know if I want to know...). I would really like to not land this patch before it's clear there's an *easy* path to making this work on Morello. Breaking bhyve on Morello would be really quite unfortunate and hostile towards CheriBSD.

Apr 28 2026, 10:43 AM

Apr 27 2026

andrew accepted D56601: arm64: Ditch arm64-specific unsound PCPU optimisation.
Apr 27 2026, 11:42 AM
andrew committed rGb5bad6df467c: virtio_net: Use bus_dma for command/ack buffers (authored by sarah.walker2_arm.com).
virtio_net: Use bus_dma for command/ack buffers
Apr 27 2026, 11:39 AM
andrew committed rGc16c95192f01: virtio_net: Use bus_dma for rxq/txq buffers (authored by sarah.walker2_arm.com).
virtio_net: Use bus_dma for rxq/txq buffers
Apr 27 2026, 11:39 AM
andrew committed rG04e4268f60e4: arm64: Remove cpu_tlb_flushID now it's unused (authored by andrew).
arm64: Remove cpu_tlb_flushID now it's unused
Apr 27 2026, 11:39 AM
andrew committed rG4bdbb6f7f7c6: arm64: Stop using cpu_tlb_flushID in kexec (authored by andrew).
arm64: Stop using cpu_tlb_flushID in kexec
Apr 27 2026, 11:39 AM
andrew committed rGe63eee84cad5: libgcc_s: Add a linker script to link to libgcc (authored by andrew).
libgcc_s: Add a linker script to link to libgcc
Apr 27 2026, 11:39 AM
andrew closed D52185: arm64: Remove cpu_tlb_flushID now it's unused.
Apr 27 2026, 11:39 AM
andrew closed D45268: libgcc_s: Add a linker script to link to libgcc.
Apr 27 2026, 11:39 AM
andrew closed D55564: virtio_net: Use bus_dma for command/ack buffers.
Apr 27 2026, 11:39 AM
andrew closed D55492: virtio_net: Use bus_dma for rxq/txq buffers.
Apr 27 2026, 11:39 AM · network
andrew accepted D55564: virtio_net: Use bus_dma for command/ack buffers.
Apr 27 2026, 10:52 AM
andrew accepted D55492: virtio_net: Use bus_dma for rxq/txq buffers.
Apr 27 2026, 10:51 AM · network

Apr 23 2026

andrew added inline comments to D56598: arm64: Add RSI detection for CCA.
Apr 23 2026, 4:12 PM
andrew added inline comments to D56551: arm64/vmm: Use the VNCR_EL2 memory page to store guest registers.
Apr 23 2026, 4:08 PM
andrew added reviewers for D56599: arm64: VM/PMAP changes for CCA guest support: alc, markj, kib.
Apr 23 2026, 3:49 PM
andrew accepted D56600: arm64: Load SOCDEV_PA as a literal rather than an immediate.
Apr 23 2026, 3:24 PM
andrew added a comment to D56551: arm64/vmm: Use the VNCR_EL2 memory page to store guest registers.

It looks like the two capability registers this change affects are elr_el1 and vbar_el1. Both of these have at least 128 bits of space before the next register, so storage shouldn't be a problem for Morello.

Apr 23 2026, 10:00 AM
andrew added a comment to D56520: arm64: Add CCA guest support.

I think we can split out the pmap and busdma parts into 2 new revisions (i.e. one for pmap, one for busdma)

Apr 23 2026, 9:36 AM
andrew added a comment to D56518: vm: Add flags for unprotected allocations.
In D56518#1295709, @alc wrote:

Just out of curiosity, where are the pmap changes?

Apr 23 2026, 7:05 AM

Apr 22 2026

andrew accepted D56550: arm64/vmm: Add FEAT_NV2 definitions.
Apr 22 2026, 2:25 PM

Apr 21 2026

andrew added a comment to D56551: arm64/vmm: Use the VNCR_EL2 memory page to store guest registers.

We will need to handle accessing different sized registers to support FEAT_D128, e.g. VTTBR_EL2 will be 128 bit there.

Apr 21 2026, 2:13 PM
andrew added inline comments to D56550: arm64/vmm: Add FEAT_NV2 definitions.
Apr 21 2026, 1:25 PM
andrew added a comment to D55947: arm64: mte: handle synchronous tag check faults.

I can move them to something like 200/201. I think the Arm Permission Overlay Extension (FEAT_S1POE) could then reuse SEGV_PKUERR as it is similar.

Apr 21 2026, 7:47 AM

Apr 20 2026

andrew added reviewers for D56518: vm: Add flags for unprotected allocations: kib, alc, markj, andrew.
Apr 20 2026, 1:23 PM

Apr 16 2026

andrew committed rG6f9e9eba984f: arm64: mte: handle synchronous tag check faults (authored by harry.moulton_arm.com).
arm64: mte: handle synchronous tag check faults
Apr 16 2026, 2:23 PM
andrew committed rGaa2d89cb4263: arm64: mte: add tagged memory attribute (authored by harry.moulton_arm.com).
arm64: mte: add tagged memory attribute
Apr 16 2026, 2:23 PM
andrew closed D55948: arm64: mte: add tagged memory attribute.
Apr 16 2026, 2:23 PM
andrew closed D55947: arm64: mte: handle synchronous tag check faults.
Apr 16 2026, 2:23 PM
andrew updated the diff for D55950: arm64: Support some per-thread sctlr_el1 fields.

Stop switching sctlr user bits for kernel threads

Apr 16 2026, 2:10 PM
andrew added a comment to D45268: libgcc_s: Add a linker script to link to libgcc.

Was it decided if this was an acceptable approach? I found the sanitizer runtimes also need this to work correctly, so would like to push to fix them

Apr 16 2026, 1:46 PM
andrew added a comment to D55492: virtio_net: Use bus_dma for rxq/txq buffers.

Does anyone have any more testing they would like to do, or shall I push this to main?

Apr 16 2026, 1:38 PM · network

Apr 15 2026

andrew accepted D56403: arm64: Define the .iplt section placement..
Apr 15 2026, 10:14 AM

Apr 14 2026

andrew updated the diff for D55947: arm64: mte: handle synchronous tag check faults.

Change the SEGV_MTE* values

Apr 14 2026, 9:32 AM

Apr 13 2026

andrew updated subscribers of D55947: arm64: mte: handle synchronous tag check faults.
Apr 13 2026, 2:28 PM
andrew updated the diff for D55949: arm64: Support changing the DMAP memory type.

Update comments

Apr 13 2026, 2:26 PM
andrew committed rG58de79153622: arm64: mte: configure initial state for system registers (authored by harry.moulton_arm.com).
arm64: mte: configure initial state for system registers
Apr 13 2026, 2:25 PM