Page MenuHomeFreeBSD
Feed Advanced Search

Yesterday

andrew requested review of D44914: arm64/gicv3: Check if the hardware supports LPIs.
Tue, Apr 23, 2:58 PM
andrew requested review of D44913: dev/psci: Check all compat strings.
Tue, Apr 23, 2:58 PM
andrew added a comment to D44868: elf_common.h: Add STO_AARCH64_VARIANT_PCS.

Do we need to add support to e.g. ELF Tool Chain readelf and nm to decode these values?

Tue, Apr 23, 9:24 AM
andrew added a comment to D44868: elf_common.h: Add STO_AARCH64_VARIANT_PCS.

A flag. https://github.com/ARM-software/abi-aa/blob/main/aaelf64/aaelf64.rst#st_other-values lists it under Processor specific st_other flags.

Tue, Apr 23, 9:19 AM

Fri, Apr 19

andrew added inline comments to D44869: rtld: Add support for arm64 variant pcs.
Fri, Apr 19, 4:22 PM
andrew updated the diff for D44869: rtld: Add support for arm64 variant pcs.
  • Fix a comment
  • Remove debugging
Fri, Apr 19, 4:21 PM
andrew retitled D44869: rtld: Add support for arm64 variant pcs from rtld: Add suport for arm64 variant pcs to rtld: Add support for arm64 variant pcs.
Fri, Apr 19, 3:56 PM
andrew added a comment to D44740: bhyve: Add arm64 support to the gdb stub.

Given it's a single instruction being written we could just ignore DIC & IDC, I expect the overhead would be less than a system call & this is an uncommon operation. We wouldn't even need to read ctr_el0 as the smallest cacheline size is the same as the instruction size.

Fri, Apr 19, 3:55 PM
andrew requested review of D44870: rtld: Add arm64 variant pcs tests.
Fri, Apr 19, 3:37 PM
andrew requested review of D44869: rtld: Add support for arm64 variant pcs.
Fri, Apr 19, 3:37 PM
andrew requested review of D44868: elf_common.h: Add STO_AARCH64_VARIANT_PCS.
Fri, Apr 19, 3:37 PM

Thu, Apr 18

andrew updated the diff for D42596: arm64: Allow userspace to be built with PAC and BTI.

Add missing WITH/WITHOUT files

Thu, Apr 18, 4:40 PM
andrew updated the diff for D42596: arm64: Allow userspace to be built with PAC and BTI.

Rebase and disable until we can check all relavant toolchains support it

Thu, Apr 18, 4:34 PM
andrew requested review of D44838: showconfig: Set MACHINE for src.opts.mk.
Thu, Apr 18, 4:16 PM
andrew added a comment to D43047: vtscmi: Add a virtio-scmi driver.

It's not very useful as a module as it provides infrastructure other devices need, e.g. their clock, or a reset line. If it was a module these drivers would fail to attach if they were built into the kernel.

Thu, Apr 18, 12:27 PM

Wed, Apr 17

andrew added inline comments to D44825: misc: Add a map of FreeBSD IDs to GitHub IDs.
Wed, Apr 17, 9:05 PM
andrew added a comment to D44677: arm64: Check DMAP address is valid in PHYS_IN_DMAP.

We could look at that as a follow up, however I'm unlikely to have time to make such a change and have it ready and well tested for 14.1 given it's due to be branched in just over 2 weeks.

Wed, Apr 17, 4:23 PM
andrew added inline comments to D44823: Enable L1SS handling on RPI4 pcib.
Wed, Apr 17, 2:51 PM ยท arm64

Tue, Apr 16

andrew added a comment to D43306: arm64: Initial SVE support.

Functions that take an SVE register as an argument, or use one for the return value are marked with STO_AARCH64_VARIANT_PCS [1]. In glibc it looks like they avoid lazy resolution for all variant pcs functions. As there are more reasons than just SVE for a function to be marked as a variant, and more reasons could be added in the future I think it's the only safe option.

Tue, Apr 16, 4:57 PM
andrew updated the diff for D43307: arm64: Add the SVE registers to the signal frame.

Rebase and check the SVE registers are only set once

Tue, Apr 16, 3:49 PM
andrew updated the diff for D43306: arm64: Initial SVE support.

Rework to not guarentee the SVE registers are saved over a syscall other than sigreturn.
The ABI doesn't require SVE registers to be saved on a function call so extend this to a system call.
As dropping the SVE state on all system calls could get expensive only do it on context switch when in one.

Tue, Apr 16, 3:47 PM
andrew requested review of D44807: arm64: Clear td_frame when returning to userspace.
Tue, Apr 16, 3:43 PM
andrew updated the diff for D44677: arm64: Check DMAP address is valid in PHYS_IN_DMAP.

Rename to PHYS_IN_DMAP_RANGE

Tue, Apr 16, 8:48 AM

Mon, Apr 15

andrew requested review of D44799: arm64/vmm: Ensure the tlbi has completed.
Mon, Apr 15, 5:24 PM

Fri, Apr 12

andrew closed D39452: Support BTI in rtld.
Fri, Apr 12, 2:31 PM
andrew committed rGd8925a5f42b5: Support BTI in rtld (authored by andrew).
Support BTI in rtld
Fri, Apr 12, 2:31 PM
andrew added a comment to D43307: arm64: Add the SVE registers to the signal frame.

I don't think we need to store the SCE registers in getcontextx. It's a function call that doesn't take an SVE register as an argument so the ABI doesn't require the upper bits of SVE registers to be preserved. We could restore the SVE registers in setcontextx if they are in the list of registers.

Fri, Apr 12, 1:33 PM
andrew committed rGf242c47ee278: arm64: Support hardware breakpoints (authored by andrew).
arm64: Support hardware breakpoints
Fri, Apr 12, 9:39 AM
andrew closed D44355: arm64: Support hardware breakpoints.
Fri, Apr 12, 9:38 AM
andrew committed rG0adc959a3730: sys/gdb: Support hardware breakpoints (authored by andrew).
sys/gdb: Support hardware breakpoints
Fri, Apr 12, 9:38 AM
andrew closed D44354: sys/gdb: Support hardware breakpoints.
Fri, Apr 12, 9:38 AM
andrew closed D22191: sys/ddb: Add hardware breakpoint support to ddb.
Fri, Apr 12, 9:38 AM
andrew committed rG076b64e83ac9: sys/ddb: Add hardware breakpoint support to ddb (authored by andrew).
sys/ddb: Add hardware breakpoint support to ddb
Fri, Apr 12, 9:38 AM
andrew closed D44461: ddb: Start to generalise breakpoints.
Fri, Apr 12, 9:38 AM
andrew committed rGf4a6036a3a0d: ddb: Start to generalise breakpoints (authored by andrew).
ddb: Start to generalise breakpoints
Fri, Apr 12, 9:38 AM

Thu, Apr 11

andrew committed rGe1c4c8dd8d2d: vtscmi: Add a virtio-scmi driver (authored by cristian.marussi_arm.com).
vtscmi: Add a virtio-scmi driver
Thu, Apr 11, 10:01 AM
andrew committed rGa87dd74125d2: scmi: Add an SCMI VirtIO transport driver (authored by cristian.marussi_arm.com).
scmi: Add an SCMI VirtIO transport driver
Thu, Apr 11, 10:01 AM
andrew committed rG3595f18fc78b: scmi: Add SCMI message tracking and centralize tx/rx logic (authored by cristian.marussi_arm.com).
scmi: Add SCMI message tracking and centralize tx/rx logic
Thu, Apr 11, 10:01 AM
andrew committed rG35f93203963f: scmi: Introduce a new SCMI API and port CLK SCMI driver to it (authored by cristian.marussi_arm.com).
scmi: Introduce a new SCMI API and port CLK SCMI driver to it
Thu, Apr 11, 10:01 AM
andrew committed rG403ca28c28bd: scmi: Add new SCMI interfaces for init and message processing (authored by cristian.marussi_arm.com).
scmi: Add new SCMI interfaces for init and message processing
Thu, Apr 11, 10:00 AM
andrew committed rGa0ba2a97fd19: scmi: Protect SCMI/SMT channels from concurrent transmissions (authored by cristian.marussi_arm.com).
scmi: Protect SCMI/SMT channels from concurrent transmissions
Thu, Apr 11, 10:00 AM
andrew committed rGcbcfdff05678: scmi: Fix SCMI mailbox polling mechanism (authored by cristian.marussi_arm.com).
scmi: Fix SCMI mailbox polling mechanism
Thu, Apr 11, 10:00 AM
andrew committed rGd220b1cf02ce: scmi: Extend and refactor SCMI shmem support (authored by cristian.marussi_arm.com).
scmi: Extend and refactor SCMI shmem support
Thu, Apr 11, 10:00 AM
andrew closed D43047: vtscmi: Add a virtio-scmi driver.
Thu, Apr 11, 10:00 AM
andrew closed D43048: scmi: Add an SCMI VirtIO transport driver.
Thu, Apr 11, 10:00 AM
andrew committed rGecd8cc84dcee: scmi: Implement scmi_clknode_recalc_freq method (authored by cristian.marussi_arm.com).
scmi: Implement scmi_clknode_recalc_freq method
Thu, Apr 11, 10:00 AM
andrew closed D43046: scmi: Introduce a new SCMI API and port CLK SCMI driver to it.
Thu, Apr 11, 10:00 AM
andrew closed D43045: scmi: Add SCMI message tracking and centralize tx/rx logic.
Thu, Apr 11, 10:00 AM
andrew closed D43044: scmi: Add new SCMI interfaces for init and message processing.
Thu, Apr 11, 10:00 AM
andrew committed rGd46f01fd590e: scmi: Split out the SCMI mailbox to a new file (authored by andrew).
scmi: Split out the SCMI mailbox to a new file
Thu, Apr 11, 10:00 AM
andrew committed rG5ea251c4ed6e: scmi: Add an SCMI SMC transport driver (authored by andrew).
scmi: Add an SCMI SMC transport driver
Thu, Apr 11, 10:00 AM
andrew closed D43043: scmi: Protect SCMI/SMT channels from concurrent transmissions.
Thu, Apr 11, 10:00 AM
andrew closed D43041: scmi: Extend and refactor SCMI shmem support.
Thu, Apr 11, 10:00 AM
andrew closed D43042: scmi: Fix SCMI mailbox polling mechanism.
Thu, Apr 11, 10:00 AM
andrew closed D43039: scmi: Split out the SCMI mailbox to a new file.
Thu, Apr 11, 10:00 AM
andrew closed D43040: scmi: Add an SCMI SMC transport driver.
Thu, Apr 11, 10:00 AM
andrew closed D43038: scmi: Implement scmi_clknode_recalc_freq method.
Thu, Apr 11, 10:00 AM

Wed, Apr 10

andrew added a comment to D44740: bhyve: Add arm64 support to the gdb stub.

It looks like the icache handling is missing after writing the brk instruction. I think this could be done from userspace as VPIPT i-cache has been removed from the architecture [1].

Wed, Apr 10, 7:37 PM

Mon, Apr 8

andrew requested review of D44677: arm64: Check DMAP address is valid in PHYS_IN_DMAP.
Mon, Apr 8, 1:17 PM
andrew committed rG35f6b83049da: Update the Arm Optimized Routine library to v24.01 (authored by andrew).
Update the Arm Optimized Routine library to v24.01
Mon, Apr 8, 1:16 PM

Thu, Apr 4

andrew accepted D44630: arm64: Separate serror handler to EL1H and EL0 versions..
Thu, Apr 4, 1:27 PM
andrew accepted D44535: arm64: Add a CPU reset hook instead of expecting PSCI.
Thu, Apr 4, 11:10 AM

Tue, Apr 2

andrew added a comment to D44575: arm64 pmap: Add ATTR_CONTIGUOUS support [Part 2].

I do, however, want to point out that a good portion of the reduction in buildworld time is coming from performing a smaller number of icache flushes when creating executable mappings.

Tue, Apr 2, 8:31 AM

Thu, Mar 28

andrew requested changes to D44530: arm64: Add SError handler registration.

This is dangerous to do. It is imlpementation defined if an SError is a precise or imprecise exception. If it is imprecise the instruction stream may be out of sync, e.g. instructions before ELR haven't executed and instructions after it have completed (see "Definition of a precise exception and imprecise exception" from the Arm Architecture Reference Manual for the full definition). Because we have to assume an SError is imprecise we can't handle them in do_serror.

Thu, Mar 28, 3:28 PM
andrew added a comment to D44535: arm64: Add a CPU reset hook instead of expecting PSCI.

Is there a reason to not have cpu_reset_hook = psci_reset by default so we can remove the NULL check?

Thu, Mar 28, 2:33 PM

Mar 21 2024

andrew updated the diff for D44355: arm64: Support hardware breakpoints.

Rebase

Mar 21 2024, 4:23 PM
andrew updated the diff for D22191: sys/ddb: Add hardware breakpoint support to ddb.

Add missing HAS_HW_BREAKPOINT check

Mar 21 2024, 3:52 PM
andrew updated the diff for D44354: sys/gdb: Support hardware breakpoints.

Rebase

Mar 21 2024, 3:51 PM
andrew updated the diff for D22191: sys/ddb: Add hardware breakpoint support to ddb.

Rebase on D44461

Mar 21 2024, 3:45 PM
andrew added inline comments to D22191: sys/ddb: Add hardware breakpoint support to ddb.
Mar 21 2024, 3:44 PM
andrew requested review of D44461: ddb: Start to generalise breakpoints.
Mar 21 2024, 3:43 PM
andrew committed rGc802b486ddfd: arm64: Add EL1 hardware breakpoint exceptions (authored by andrew).
arm64: Add EL1 hardware breakpoint exceptions
Mar 21 2024, 10:15 AM
andrew committed rGd93b3a65f769: arm64: Use a switch to decide when to enable debug (authored by andrew).
arm64: Use a switch to decide when to enable debug
Mar 21 2024, 10:15 AM
andrew committed rG2e2c983d5234: arm64: Always set the debug control and value regs (authored by andrew).
arm64: Always set the debug control and value regs
Mar 21 2024, 10:15 AM
andrew committed rGed3c6cd76de8: arm64: Mask non-debug exceptions when single stepping (authored by andrew).
arm64: Mask non-debug exceptions when single stepping
Mar 21 2024, 10:15 AM
andrew committed rG12257233e8fd: arm64: Split out a savectx version of vfp_save_state (authored by andrew).
arm64: Split out a savectx version of vfp_save_state
Mar 21 2024, 10:15 AM
andrew closed D44352: arm64: Use a switch to decide when to enable debug.
Mar 21 2024, 10:15 AM
andrew closed D44353: arm64: Add EL1 hardware breakpoint exceptions.
Mar 21 2024, 10:15 AM
andrew committed rG5202ca77aaf5: libc/aarch64: Add a non-trivial getcontextx (authored by andrew).
libc/aarch64: Add a non-trivial getcontextx
Mar 21 2024, 10:15 AM
andrew closed D44351: arm64: Always set the debug control and value regs.
Mar 21 2024, 10:14 AM
andrew closed D44350: arm64: Mask non-debug exceptions when single stepping.
Mar 21 2024, 10:14 AM
andrew closed D43304: arm64: Split out a savectx version of vfp_save_state.
Mar 21 2024, 10:14 AM
andrew closed D44255: libc/aarch64: Add a non-trivial getcontextx.
Mar 21 2024, 10:14 AM
andrew closed D44254: libc/aarch64: Copy the trivial getcontextx.
Mar 21 2024, 10:14 AM
andrew committed rGfd6b1cc34e41: libc/aarch64: Copy the trivial getcontextx (authored by andrew).
libc/aarch64: Copy the trivial getcontextx
Mar 21 2024, 10:14 AM
andrew closed D43302: arm64: Support passing more registers to signals.
Mar 21 2024, 10:14 AM
andrew committed rG7e6437c08415: arm64: Support passing more registers to signals (authored by andrew).
arm64: Support passing more registers to signals
Mar 21 2024, 10:14 AM

Mar 18 2024

andrew committed rG0a5f7918fc0e: arm64: Return all registers to gdb when able (authored by andrew).
arm64: Return all registers to gdb when able
Mar 18 2024, 4:39 PM
andrew closed D44360: arm64: Return all registers to gdb when able.
Mar 18 2024, 4:38 PM
andrew committed rGa931b85a0966: uart: Add uart_cpu_acpi_setup to setup the uart (authored by andrew).
uart: Add uart_cpu_acpi_setup to setup the uart
Mar 18 2024, 4:38 PM
andrew committed rG473c0b44ae8c: uart: Split out initilisation of the acpi devinfo (authored by andrew).
uart: Split out initilisation of the acpi devinfo
Mar 18 2024, 4:38 PM
andrew closed D44358: uart: Add uart_cpu_acpi_setup to setup the uart.
Mar 18 2024, 4:38 PM
andrew closed D44357: uart: Split out initilisation of the acpi devinfo.
Mar 18 2024, 4:38 PM
andrew committed rG801160f4c0a3: arm64: Rename drop_to_el1 to enter_kernel_el (authored by andrew).
arm64: Rename drop_to_el1 to enter_kernel_el
Mar 18 2024, 4:38 PM
andrew closed D43976: arm64: Rename drop_to_el1 to enter_kernel_el.
Mar 18 2024, 4:38 PM

Mar 14 2024

andrew added inline comments to D44357: uart: Split out initilisation of the acpi devinfo.
Mar 14 2024, 5:59 PM
andrew requested review of D44360: arm64: Return all registers to gdb when able.
Mar 14 2024, 5:41 PM
andrew requested review of D44359: uart: DBG2 support to find the debug uart.
Mar 14 2024, 4:50 PM
andrew requested review of D44358: uart: Add uart_cpu_acpi_setup to setup the uart.
Mar 14 2024, 4:50 PM
andrew requested review of D44357: uart: Split out initilisation of the acpi devinfo.
Mar 14 2024, 4:49 PM