There's also a copy in if_detach_internal that should be resized, this should have tripped a _Static_assert there. (No opinion on the literal)

Address @markj comments.

Im also gonna have to manually fix the formatting issues because clang-format isn't gonna work for this as near as I can tell (at least not with this .clang-format file in /usr/src..) @kp I dont want to live in the comments too much so I've kinda taken to discord to try to find some help getting the diff sorted out but if I can't find the answer I'm looking for there then I'll pick through the docs a little more and eventually resort to submitting diff 3 to cancel diff 1 & 2 if I gotta and I'll be sure to get that one right. Hoping to at least have some tests up here by the end of this weekend (I'll try to anyway)

In D58784#1349467, @dteske wrote:

Tested dbus integration with working pause/play, rewind, and fast-forward integration, and screensaver inhibit all working regardless of whether WM is bus-less or not. In a bus-less WM session, it brings its own bus run that tears down on browser exit

Address @kevans 's comment

Plenty of other file systems have the same check. If you're convinced that it's unnecessary I would suggest you post a patch that removes it from all of them, not just tarfs, and circulate it more widely.

Use netlink/route/interface.h

Works here on a custom host at -CURRENT.

Maps every IFLAF_VF_* presence bit to the stable public IFCONFIG_VF_F_* flags

Removed now unneeded ifr_nv_* churn, use IFLAF_VF_* numbers directly (and in subordinate reviews), add some clarity around extensions.

I was thinking of rcorder(8) for kernel. Of course run at compilation time, not an startup.

I'm not taking this task :) I just want to make kernel -Werror-assing-enum clean.

I mean that the backing file's permissions have already been checked since it has been successfully opened at that point, and the calling process's privilege to mount is checked elsewhere. Isn't that already checked in sys/kern/vfs_mount.c:vfs_domount()?

In D58776#1350103, @melifaro wrote:

LGTM (modulo removing nvlist helpers); left some comments in the diff.

Could you elaborate on the " This allows drivers to add information without expanding a central enumeration." a bit?
If the only concern is central enumeration, then it can be addressed differently - by having per-driver attributes.
Linux does it the following way: inside IFLA_LINKINFO attribute it stores IFLA_INFO_KIND attribute with the driver type and IFLA_INFO_DATA where any customer driver-specific structures can be stored.
I should have implemented something like that but never managed to (there are some bits and pieces in if_vlan.c that can serve as a simple example for the GET requests)

Implement per-arch hooks akin to mdthread; no arch ifdefs in common code

I noticed when I was doing the most recent update that this section is very stale. Sebastian -- upstream maintainer for 10+ years -- suggested this wording when I asked him.

The num namespaces changes should be separate

LGTM (modulo removing nvlist helpers); left some comments in the diff.