The only thing that I worry about in moving this parsing earlier is side effects from env variables taking effect before we have the efi partition list, so things like currdev=disk3p4: stop working. Is that the case?

In D59910#1376490, @kib wrote:

What do you mean by inconsistency? Do you want _MNTPOINT when fhstat("/")?

Report SFBSD_MNTPOINT for root on fhstat()

Tested Diff 187278 on an AMD Ryzen 5 5600X (Zen 3, Family 19h,
Model 21h, Stepping 0, Id 0xa20f10, 12 threads), FreeBSD
16.0-CURRENT at 10a3562a019b, kernel and world in sync.

The sysexit parts of this are too churny. Can't we exit 2 or 3 or whatever to indicate signing issues instead?

Yes, I'm referring to a prison I don't hold a reference to, without allprison_lock held. My bad. This look good, with the common path not adding any extra steps.

What do you mean by inconsistency? Do you want _MNTPOINT when stat("/")?

I would not encode the bit position in the name, for instance how it was done for OBJ_PAGEPRIV1/2.

OK from manpages. Good work!

I wasn't familiar with __diagused. Yes, this is all cleaner.

I hate to request a bunch of rework on this, but IMO a lot of this is churn that isn't really needed.

This diff implement it , the watchdog change is already here.

sysexits(3) states

This interface has been deprecated and is retained only for compatibility. Its use is discouraged.

In D59910#1376450, @olce wrote:

EDIT: Mmm... but this shouldn't be a problem inasmuch as our specific flags are not sent over NFS.

In D59910#1376391, @markj wrote:

No, you can get a handle with getfh() and friends, and if you're using NFS, you don't even need to be root to obtain one.

You need PRIV_VFS_GETFH in any case, so I don't see how this is true.

s/MNTROOT/MNTPOINT/g

In D59910#1376175, @olce wrote:

So I'd much prefer that we offer something with consistent observable behavior to users.

In D59932#1376355, @markj wrote:

Does bufbdflush() need to be updated? I am not sure if it is ever called with a devvp.

• Please import all supported firmwares. See rtlbt_fw.cc for the list.
• Install firmwares to /usr/share/firmware/rtlbt rather than to /usr/share/firmware to not produce mess.
• Add LICENSE file from rtwn

Tests moved to D59990