Found more issues related - fix while at it.

This allows audio/murmur to build again.

Not supporting .ctors could be a problem when linking objects created with different compilers, e.g. a static library built with gcc, but linked through clang.

In D17604#375736, @kib wrote:

I definitely agree with the genoffset.sh changes.

On the other hand, I am not sure that we need to restore volatile qualifiers in the thread_lite, instead of removing them in the struct thread. The manipulations of the critnest level and pin count should use barriers, and I believe that the thread_lite patch and some of its follow-ups just did that. Volatile relied on the compiler-specific semantic to get similar effect.

Can you extract the helpers functions into separate review ?

This patch fixes a kernel panic we are seeing when unloading iavf while passing traffic.

The reason I hadn't changed the other instances is that while trivial, they are somewhat harder to test, and I've been bitten by trivial changes to rarely excercised branches in the past.

Ok, let's put this on hold. More careful benchmarking shows there's something seriously weird wrt performance going on.

kev-ws-aurora% portlint -A
WARN: /usr/home/kev009/c/fbsd-rw/ports-head/emulators/linux-power9-functional-sim/pkg-descr: includes lines that exceed 80 characters.
0 fatal errors and 1 warning found.

Update as per kib's suggestion.

Heh, I clearly remember looking at the output.c, which uses OUTBUFSIZ, and thinking "ok, let's follow the convention here". I guess I followed it a bit too closely.

:-D

In D17587#375744, @kib wrote:

After some investigation, I see that crtbegin/crtend.o are shipped with compilers, at least it does with gcc. So I do not see a reason to provide the .ctor fallback for e.g. amd64 or i386: in-tree compiler does not need it, and out-of-tree gcc should cope on its own.

Again, please upoad the context.

After some investigation, I see that crtbegin/crtend.o are shipped with compilers, at least it does with gcc. So I do not see a reason to provide the .ctor fallback for e.g. amd64 or i386: in-tree compiler does not need it, and out-of-tree gcc should cope on its own.

Patch with full context.

Can you reupload the diff with full context ?

I definitely agree with the genoffset.sh changes.

I also don't see any issue now, but as it's not the first time ordering question arise - do you run portlint when preparing (new) ports? If so, can you, please, also provide it's output?

Drop unneeded argument to vm_map_entry_link. Drop unnecessary calls to vm_map_entry_resize_free from vm_map_simplify_entry, by setting start/end fields before removing neighbor. Reduce number of uses of 'prev' member when iterating through consecutive map entries.

Looks good. I'll commit it once the freeze is over

@marc.priggemeyer_gmail.com hello sir can you be so kind to help me out, when I try to kldload acpi_iichid.ko it says 'parent is not attached', what should I kldload beforehand or something should be done?

no debug printfs

LGTM.

Wow Amezing job! Thank you for working on that!

OUTBUFSIZ is somewhat of a strange name given that these buffers contain shell input.

I like this

I still feel it would be nice to make kmem_ and malloc_ take a policy possibly with an inline that converts a number into a preferred policy. There is likely no reason that kmem_ allocations should fail if the requested domain is unavailable.

Thanks!
Do not hesitate to take maintainership if you want.