LGTM.

Add missing opt_ipfilter.h.

No objection.

committed in #1371b0ba8c

Just so we know this pulls in:

@olce I think exposing the epp setting interface only in only cpu0 makes sence and therefore I make some changes. @markj Please also help me review it when you have time, thanks! Also, I remember that it is better to send ipi instead of binding the CPU, but I forget the url of your sample code. Could you please provide it in here?

Expose the epp interface in only cpu 0 and modify all cpu value.

Renamed IPFS to IPFILTER_IPFS.

Ok, I guess. This is assuming nobody's going to try to assign special semantics to fsync() on a non-blocking file descriptor, but that ship has probably sailed...

Added xo_options(7) to gpart manpage.

This seems to work now. The change turned out to be surprisingly small.

• Use cdev destructor to clean up the mount point instead of a .d_close method

ack your review comments, I have a couple changes I need to bring out of a stash commit before I address your comments. My local commit log is getting pretty messy from all the suspend debugging stuff I'm trying ;)

Fix DSM call ordering

Hmmm, I wonder if 0 is the right thing vs something like 0xdeadc0de. We have a few explicit IVAR handlers that intentionally return a default value (e.g. acpi_get_handle()) and those do tend to be zero (and in those cases we don't KASSERT). I have a patch in a branch to add a new one like that for ThunderBolt PCI bridges even. 0 is probably fine as a default, but @imp might also have an opinion.

local and indentation

Make sense to me.

I've been traveling and haven't yet had time to review the latest changes, but last I looked it was moving in the right direction. Just give me a few more days.

Verified

phylosophically this interface more like L2 loopback, right?
can be emulated by ng_ether somehow?