Page MenuHomeFreeBSD
Feed All Stories

Today

markj added a comment to D40468: crypto: Advance the correct pointer in crypto_cursor_copydata().

Test case for this and the other cursor bug fix: https://reviews.freebsd.org/D40469

Wed, Jun 7, 9:33 PM
markj requested review of D40469: geli tests: Add a regression test for PR 271766.
Wed, Jun 7, 9:32 PM
markj requested review of D40468: crypto: Advance the correct pointer in crypto_cursor_copydata().
Wed, Jun 7, 9:32 PM
kib added inline comments to D40443: linux(4): In preparation for xsave refactor fxsave code on amd64.
Wed, Jun 7, 9:21 PM · Linux Emulation
jrm updated the diff for D40445: ndp: Prepare for pending tcpdump update.

Revert back to function with no arguments. Fix typo and formatting.

Wed, Jun 7, 8:53 PM
emaste committed R9:d190a55610dd: Remove obsolete www.amd64.org URL (authored by emaste).
Remove obsolete www.amd64.org URL
Wed, Jun 7, 8:46 PM
rene committed R11:23f5575119fa: x11/radare-cutter: Remove expired port (authored by rene).
x11/radare-cutter: Remove expired port
Wed, Jun 7, 8:44 PM
oleg_mamontov.net updated the diff for D39868: [NEW PORT] www/angie: patch also includes new related ports for dynamic modules.

Thank you for suggestion.
I've re-worked patch with MASTERDIR approach and shortened the patch to only angie and angie-module-geoip2 ports for ease of review process. If we can agree on this method, I'm ready to introduce all the others.
Thank you in advance!

Wed, Jun 7, 8:44 PM
rcm_rcm.sh added a member for vbox: rcm_rcm.sh.
Wed, Jun 7, 8:22 PM
rcm_rcm.sh added a member for pfsense: rcm_rcm.sh.
Wed, Jun 7, 8:20 PM
gusev.vitaliy_gmail.com updated the summary of D40105: bhyve: [snapshot] Simplify restore kernel structs.
Wed, Jun 7, 8:09 PM · bhyve
gusev.vitaliy_gmail.com updated the summary of D40106: bhyve: [snapshot] Rename 'user_dev' with 'devices'.
Wed, Jun 7, 8:08 PM · bhyve
gusev.vitaliy_gmail.com updated the summary of D40107: bhyve: pci_devinst.pi_name should contain bus, slot, func.
Wed, Jun 7, 8:07 PM · bhyve
gusev.vitaliy_gmail.com updated the summary of D40105: bhyve: [snapshot] Simplify restore kernel structs.
Wed, Jun 7, 8:05 PM · bhyve
gusev.vitaliy_gmail.com added a comment to D40105: bhyve: [snapshot] Simplify restore kernel structs.
In D40105#921197, @jhb wrote:

Can you provide more description of what this change is doing? From what I can tell it uses err directly to abort quicker if it fails to restore an in-kernel structure, it inlines vm_restore_kern_struct into the loop in vm_restore_kern_structs. It renames vm_snapshot_kern_structs which is somewhat gratuitous IMO as it now no longer matches the other function names like vm_snapshot_user_devs. But I think the big change is not using lookup_struct and instead using meta->dev_name instead of meta->dev_req as the main key for the JSON for a given kernel struct? I think this means you can avoid lookup_struct because now instead of a flat array of all kernel structures they are separate objects with unique names? Can you expand on that more perhaps maybe with some examples of before/after JSON snippets? I would also suggest perhaps only doing the JSON change in this commit and not mixing in the other changes that I think obscure the real change you are making (e.g. the function rename, or inlining the function).

Wed, Jun 7, 8:04 PM · bhyve
jhb committed rG653738e895ba: ptrace: Clear TDB_BORN during PT_DETACH. (authored by jhb).
ptrace: Clear TDB_BORN during PT_DETACH.
Wed, Jun 7, 7:29 PM
jhb closed D39856: ptrace: Clear TDB_BORN during PT_DETACH..
Wed, Jun 7, 7:29 PM
arrowd committed R11:cbbff3b6c21b: x11/hs-xmobar: Actually unbreak the port. (authored by arrowd).
x11/hs-xmobar: Actually unbreak the port.
Wed, Jun 7, 7:02 PM
arrowd committed R11:d14c324e9492: Haskell ports: Fix dependency on GHC 9.2 after its upgrade. (authored by arrowd).
Haskell ports: Fix dependency on GHC 9.2 after its upgrade.
Wed, Jun 7, 7:02 PM
bz requested changes to D37612: ofw: Add a ofw_firmware driver.
Wed, Jun 7, 7:02 PM
jhb added a comment to D40445: ndp: Prepare for pending tcpdump update.

Nit: s/npd/ndp/ in commit log

Wed, Jun 7, 6:56 PM
jhb accepted D40428: opencrypto: Handle end-of-cursor conditions in crypto_cursor_segment().

Humm, I had originally considered this a break of the API contract FWIW that callers shouldn't try to use a cursor after advancing past the end (though perhaps I broke that contract myself). Hmm, reading swcr_encdec, it might indeed be a bit annoying to avoid calling crypto_cursor_segment for this case.

Wed, Jun 7, 6:52 PM
jhb added a comment to D40105: bhyve: [snapshot] Simplify restore kernel structs.

Can you provide more description of what this change is doing? From what I can tell it uses err directly to abort quicker if it fails to restore an in-kernel structure, it inlines vm_restore_kern_struct into the loop in vm_restore_kern_structs. It renames vm_snapshot_kern_structs which is somewhat gratuitous IMO as it now no longer matches the other function names like vm_snapshot_user_devs. But I think the big change is not using lookup_struct and instead using meta->dev_name instead of meta->dev_req as the main key for the JSON for a given kernel struct? I think this means you can avoid lookup_struct because now instead of a flat array of all kernel structures they are separate objects with unique names? Can you expand on that more perhaps maybe with some examples of before/after JSON snippets? I would also suggest perhaps only doing the JSON change in this commit and not mixing in the other changes that I think obscure the real change you are making (e.g. the function rename, or inlining the function).

Wed, Jun 7, 6:44 PM · bhyve
jhb accepted D40040: bhyve: read OpRegion address and size for GVT-d.
Wed, Jun 7, 6:35 PM
jhb added a comment to D40038: bhyve: add empty GVT-d emulation.

It might be nicer to have the logic of which devices pci-gvt_d.c supports be a bit more self-contained, e.g.:

Wed, Jun 7, 6:33 PM
ngie updated the diff for D40366: devel/apr1: support building DBM with BDB 1.85.

Respond to comments from @rfyu28uyeg_snkmail.com:

  • fix licensing (lib/libc/db is BSD 3-clause, not 4-clause).
  • remove unnecessary "dual licensing" logic for the BDB1 option.
Wed, Jun 7, 6:27 PM
ngie added a comment to D40366: devel/apr1: support building DBM with BDB 1.85.

@rfyu28uyeg_snkmail.com: thank you for the input about the licensing. You're right -- I'm updating the patch now.

Wed, Jun 7, 6:26 PM
jhb accepted D40409: makesyscall: Stop generating $FreeBSD$.
Wed, Jun 7, 6:15 PM
jrm updated the diff for D40445: ndp: Prepare for pending tcpdump update.

Assert that the value stored in tm->tm_gmtoff will fit in a int32_t.

Wed, Jun 7, 6:07 PM
jhb committed rGaee3611fecba: pmcstat: Tweak typo fix. (authored by jhb).
pmcstat: Tweak typo fix.
Wed, Jun 7, 6:05 PM
emaste added a comment to D40467: ld(1): Correctly define .init_array and .fini_array for all platforms..

Looks like these are in amd64 via rG:8ba66bb849129

Wed, Jun 7, 5:45 PM
zirias committed R11:43d4e8d205e7: devel/poser: Update to 1.1 (authored by zirias).
devel/poser: Update to 1.1
Wed, Jun 7, 5:37 PM
yuri committed R11:7927e409c43a: science/polytope: Update 0.7.0 → 0.7.3 (authored by yuri).
science/polytope: Update 0.7.0 → 0.7.3
Wed, Jun 7, 5:04 PM
emaste accepted D40445: ndp: Prepare for pending tcpdump update.

This seems OK as a minimal change.

Wed, Jun 7, 4:48 PM
madpilot committed R11:8dcb92f39a5b: net/ntopng: Update to latest upstream snapshot (authored by madpilot).
net/ntopng: Update to latest upstream snapshot
Wed, Jun 7, 4:40 PM
madpilot committed R11:47bbc085264b: net/ndpi: Update to latest upstream stable snapshot. (authored by madpilot).
net/ndpi: Update to latest upstream stable snapshot.
Wed, Jun 7, 4:40 PM
rcm_rcm.sh retitled D40442: wpa_supplicant: Enable receiving priority tagged (VID 0) frames from wip: wpa_supplicant: Enable receiving priority tagged (VID 0) frames to wpa_supplicant: Enable receiving priority tagged (VID 0) frames.
Wed, Jun 7, 4:38 PM · pfsense
melifaro accepted D40445: ndp: Prepare for pending tcpdump update.
Wed, Jun 7, 4:36 PM
rcm_rcm.sh updated the diff for D40442: wpa_supplicant: Enable receiving priority tagged (VID 0) frames.

This revision narrows the scope of change to only focus on FreeBSD related L2 packet handling in wpa_supplican. The previous revision updated all occurrences of the filter program, however failed to account for packet and length offsets when handling encapsulated frames. Someone else can pick up the torch and provide patches for other platforms upstream as-needed.

Wed, Jun 7, 4:31 PM · pfsense
andrew added inline comments to D40433: arm64: Malloc the cpu_desc array.
Wed, Jun 7, 4:28 PM
lwhsu committed R11:6388df40a1bb: devel/jenkins: Update to 2.409 (authored by lwhsu).
devel/jenkins: Update to 2.409
Wed, Jun 7, 4:24 PM
jrm added reviewers for D40445: ndp: Prepare for pending tcpdump update: jhb, melifaro.
Wed, Jun 7, 4:22 PM
jrm updated the diff for D40445: ndp: Prepare for pending tcpdump update.

Make utc_offset() argument match gmt2local() and make it a static function.

Wed, Jun 7, 4:20 PM
andrew added a comment to D40466: HWT draft.

This looks like a kernel with HWT_HOOKS but not HWT wouldn't link as, for example, hwt_switch_in will be missing. HWPMC handles this by adding a function pointer and protects it with an epoch.

Wed, Jun 7, 4:20 PM
arichardson requested changes to D40467: ld(1): Correctly define .init_array and .fini_array for all platforms..

This will sort by name not priority. Ld.lld will sort by priority automatically if you omit init_array from the linker script but for bfd you need SORT_BY_INIT_PRIORITY

Wed, Jun 7, 4:18 PM
cy committed R11:99cfa51b52be: shells/ksh-devel: update to the latest ksh93/ksh github commit (authored by cy).
shells/ksh-devel: update to the latest ksh93/ksh github commit
Wed, Jun 7, 4:08 PM
fluffy committed R11:384cd105eb90: devel/kio-extras: Add option to hande AFC (Apple File Conduit) KIO worker (+) (authored by fluffy).
devel/kio-extras: Add option to hande AFC (Apple File Conduit) KIO worker (+)
Wed, Jun 7, 4:06 PM
cy committed R11:141cb5d09e5f: shells/ksh: Update 1.0.4 --> 1.0.5 (authored by cy).
shells/ksh: Update 1.0.4 --> 1.0.5
Wed, Jun 7, 3:55 PM
markj accepted D40285: libtacplus: Allow additional AV pairs to be configured..
Wed, Jun 7, 3:49 PM
andrew updated subscribers of D40466: HWT draft.
Wed, Jun 7, 3:48 PM
emaste added inline comments to D40466: HWT draft.
Wed, Jun 7, 3:46 PM
hselasky added a comment to D40467: ld(1): Correctly define .init_array and .fini_array for all platforms..

@emaste : You added something similar a while back for amd64. Adding you for review.

Wed, Jun 7, 3:17 PM
hselasky added a reviewer for D40467: ld(1): Correctly define .init_array and .fini_array for all platforms.: emaste.
Wed, Jun 7, 3:17 PM
hselasky added a comment to D40463: kernel: Use the compiler supported constructor and destructor attributes to register sysinits..

Oh also linker_file_lookup_set with a section name like that won't work on anything other than amd64, since link_elf relies on the start/stop symbols, not the section name.

Wed, Jun 7, 3:16 PM
hselasky requested review of D40467: ld(1): Correctly define .init_array and .fini_array for all platforms..
Wed, Jun 7, 3:14 PM
dchagin added inline comments to D40443: linux(4): In preparation for xsave refactor fxsave code on amd64.
Wed, Jun 7, 3:14 PM · Linux Emulation
br updated the diff for D40466: HWT draft.

remove debug printfs

Wed, Jun 7, 3:08 PM
AMDmi3 committed R11:5948df8b32c3: devel/py-sexpdata: update 1.0.0 → 1.0.1 (authored by AMDmi3).
devel/py-sexpdata: update 1.0.0 → 1.0.1
Wed, Jun 7, 3:05 PM
yuri committed R11:da22e4b8a489: science/jmol: Update 14.32.79 → 16.1.11 (authored by yuri).
science/jmol: Update 14.32.79 → 16.1.11
Wed, Jun 7, 3:05 PM
yuri committed R11:3d03b90dbeae: science/qbox: Update 1_75_1 → 1_76_0 (authored by yuri).
science/qbox: Update 1_75_1 → 1_76_0
Wed, Jun 7, 3:05 PM
yuri committed R11:8c0205d889b7: science/smoldyn: Update 2.69 → 2.71 (authored by yuri).
science/smoldyn: Update 2.69 → 2.71
Wed, Jun 7, 3:05 PM
br requested review of D40466: HWT draft.
Wed, Jun 7, 3:02 PM
otis committed R11:7a9f4f25e79b: net-mgmt/unifi7: Update to 7.4.156 (authored by otis).
net-mgmt/unifi7: Update to 7.4.156
Wed, Jun 7, 2:59 PM
fluffy committed R11:53f1204ea69f: x11/cinnamon: fix packaging (+) (authored by fluffy).
x11/cinnamon: fix packaging (+)
Wed, Jun 7, 2:45 PM
ehaupt committed R11:c40a6642500f: sysutils/sake: Add new port (authored by ehaupt).
sysutils/sake: Add new port
Wed, Jun 7, 2:33 PM
jrtc27 committed rG296a0987be59: pmcstat: Update manpage date (authored by jrtc27).
pmcstat: Update manpage date
Wed, Jun 7, 2:26 PM
jrtc27 committed rG7a706aad8349: hwpmc: Update manpage date (authored by jrtc27).
hwpmc: Update manpage date
Wed, Jun 7, 2:26 PM
jrtc27 committed rG21f7397a61f7: libpmc: Handle PMCALLOCATE log with PMC code on PMU event system (authored by jrtc27).
libpmc: Handle PMCALLOCATE log with PMC code on PMU event system
Wed, Jun 7, 2:26 PM
jrtc27 closed D39592: libpmc: Handle PMCALLOCATE log with PMC code on PMU event system.
Wed, Jun 7, 2:26 PM
franco_opnsense.org abandoned D40465: test for phabircator.
Wed, Jun 7, 2:09 PM
madpilot committed R11:1a029bf5bbdc: mail/mailpit: Update to 1.6.17 (authored by madpilot).
mail/mailpit: Update to 1.6.17
Wed, Jun 7, 2:08 PM
franco_opnsense.org updated the diff for D40465: test for phabircator.

sorry

Wed, Jun 7, 2:07 PM
franco_opnsense.org updated the diff for D40465: test for phabircator.

a small update

Wed, Jun 7, 2:07 PM
kib added inline comments to D40443: linux(4): In preparation for xsave refactor fxsave code on amd64.
Wed, Jun 7, 2:05 PM · Linux Emulation
franco_opnsense.org requested review of D40465: test for phabircator.
Wed, Jun 7, 2:03 PM
emaste accepted D40446: od(1): Fix skip value handling.
Wed, Jun 7, 1:53 PM
jrtc27 added a comment to D40463: kernel: Use the compiler supported constructor and destructor attributes to register sysinits..

Oh also linker_file_lookup_set with a section name like that won't work on anything other than amd64, since link_elf relies on the start/stop symbols, not the section name.

Wed, Jun 7, 1:50 PM
jrm abandoned D39511: graphics/feh: Update to 3.10 (+).
Wed, Jun 7, 1:45 PM
cc added a comment to D40436: tcp: Update cubic CC module variable names to align with RFC8312bis.

Is this patch targeted at FreeBSD15 head, after FreeBSD 14 is branched? Is this patch just for early review and is not planned to commit until FreeBSD 15 becomes the head?

Wed, Jun 7, 1:42 PM
hselasky updated the diff for D40463: kernel: Use the compiler supported constructor and destructor attributes to register sysinits..

Change from .ctors to .init_array and .dtors to .fini_array . This is what the default FreeBSD kernel toolchain currently outputs. Also noted by @jrtc27 .

Wed, Jun 7, 1:40 PM
rcm_rcm.sh retitled D40442: wpa_supplicant: Enable receiving priority tagged (VID 0) frames from wpa_supplicant: Enable receiving priority tagged (VID 0) frames to wip: wpa_supplicant: Enable receiving priority tagged (VID 0) frames.
Wed, Jun 7, 1:31 PM · pfsense
jrtc27 added a comment to D40463: kernel: Use the compiler supported constructor and destructor attributes to register sysinits..

Yes, I read the code, thank you for asking

Wed, Jun 7, 1:27 PM
hselasky added a comment to D40463: kernel: Use the compiler supported constructor and destructor attributes to register sysinits..

Finally, I'm highly unconvinced that it makes sense to dynamically register each sysinit individually.

Wed, Jun 7, 1:22 PM
hselasky added inline comments to D40463: kernel: Use the compiler supported constructor and destructor attributes to register sysinits..
Wed, Jun 7, 1:18 PM
hselasky added a comment to D40463: kernel: Use the compiler supported constructor and destructor attributes to register sysinits..

MFC after: 1 week

There is no way this can be MFC'ed, it is a big pile of KBI break.

Wed, Jun 7, 1:15 PM
zachary.leaf_arm.com accepted D40392: arm64: Reduce the direct use of cpu_desc.
Wed, Jun 7, 1:06 PM
fuz added a reviewer for D39868: [NEW PORT] www/angie: patch also includes new related ports for dynamic modules: wen.
Wed, Jun 7, 1:06 PM
hselasky updated the summary of D40463: kernel: Use the compiler supported constructor and destructor attributes to register sysinits..
Wed, Jun 7, 1:05 PM
hselasky added a comment to D40464: Use proper pointer type when initialising and uninitialising mutexes..

What do you think about this change?

Wed, Jun 7, 1:01 PM
wen committed R11:5313258935e4: www/angie: New port (authored by wen).
www/angie: New port
Wed, Jun 7, 1:01 PM
hselasky requested review of D40464: Use proper pointer type when initialising and uninitialising mutexes..
Wed, Jun 7, 1:00 PM
jrtc27 added a comment to D40463: kernel: Use the compiler supported constructor and destructor attributes to register sysinits..

MFC after: 1 week

Wed, Jun 7, 12:50 PM
hselasky updated the diff for D40463: kernel: Use the compiler supported constructor and destructor attributes to register sysinits..

Keep "struct __hack" to force semicolon after SYSINIT() and SYSUNINIT().

Wed, Jun 7, 12:48 PM
hselasky abandoned D40193: kernel: Add automation to sort all constructors and destructors at compile time..

This revision is abandoned in favor of D40463 .

Wed, Jun 7, 12:38 PM
hselasky added a comment to D39916: mi_startup: sort sysinit array using qsort instead of bubble sort.

FYI: Here is my second take on the issue D40463 . Please have a look if you are interested.

Wed, Jun 7, 12:37 PM
hselasky requested review of D40463: kernel: Use the compiler supported constructor and destructor attributes to register sysinits..
Wed, Jun 7, 12:36 PM
trasz abandoned D25501: Autochroot prototype.

Implemented as https://reviews.freebsd.org/D38933.

Wed, Jun 7, 12:29 PM
wen committed R11:e278b8a02907: graphics/py-mcomix: Update to 2.1.0 (authored by Stefan Ehmann <shoesoft@gmx.net>).
graphics/py-mcomix: Update to 2.1.0
Wed, Jun 7, 12:26 PM
wen committed R11:ef61ab98c66f: devel/liblouis: Update to 3.26.0 (authored by wen).
devel/liblouis: Update to 3.26.0
Wed, Jun 7, 12:26 PM
hselasky updated the diff for D40450: kernel: Change SYSINITs and SYSUNINITs to pass callback arguments AS-IS.

Removed some VNET related changes (not related to this change).

Wed, Jun 7, 12:19 PM