Page MenuHomeFreeBSD

lwhsu (Li-Wen Hsu)
UserAdministrator

Projects

User Details

User Since
May 10 2014, 3:58 PM (266 w, 2 d)
Roles
Administrator

Recent Activity

Sun, Jun 16

lwhsu committed rP504280: - Update to 1.1.1.
- Update to 1.1.1
Sun, Jun 16, 4:38 AM
lwhsu committed rP504279: - Update to 1.0.4.
- Update to 1.0.4
Sun, Jun 16, 4:38 AM

Thu, Jun 13

lwhsu committed rS349024: MFC r346160:.
MFC r346160:
Thu, Jun 13, 8:16 PM
lwhsu committed rS349008: Fix gcc build by removing redeclaration.
Fix gcc build by removing redeclaration
Thu, Jun 13, 3:49 AM
lwhsu closed D20622: Fix gcc build.
Thu, Jun 13, 3:49 AM

Wed, Jun 12

lwhsu created D20622: Fix gcc build.
Wed, Jun 12, 1:30 PM
lwhsu committed rP503999: - Update to 2.180.
- Update to 2.180
Wed, Jun 12, 1:00 AM

Fri, May 31

lwhsu committed rS348454: Remove tests for the deprecated algorithms in r348206.
Remove tests for the deprecated algorithms in r348206
Fri, May 31, 4:29 AM

Thu, May 30

lwhsu closed D20428: ixl(4): fix the code not guarded by the guarded by the if clause.
Thu, May 30, 8:42 PM
lwhsu committed rS348445: Add the missing braces to fix the code not guarded by the if clause and has.
Add the missing braces to fix the code not guarded by the if clause and has
Thu, May 30, 8:42 PM

Wed, May 29

lwhsu committed rS348366: Add the likely missing braces in ips(4). This is found by gcc warning that.
Add the likely missing braces in ips(4). This is found by gcc warning that
Wed, May 29, 6:11 PM
lwhsu closed D20427: ips(4): add missing braces.
Wed, May 29, 6:11 PM

Tue, May 28

lwhsu added inline comments to D20447: Add natural scrolling support to psm..
Tue, May 28, 9:38 PM
lwhsu added inline comments to D20447: Add natural scrolling support to psm..
Tue, May 28, 7:16 PM
lwhsu added a reviewer for D20447: Add natural scrolling support to psm.: wulf.
Tue, May 28, 5:34 PM
lwhsu committed rD53071: Add Waterloo Hackathon 2019 to events.
Add Waterloo Hackathon 2019 to events
Tue, May 28, 2:41 PM
lwhsu closed D20432: Add Waterloo Hackathon 2019 to events.
Tue, May 28, 2:41 PM
lwhsu committed rP502858: Add PORTREVISION back.
Add PORTREVISION back
Tue, May 28, 6:15 AM
lwhsu committed rP502857: Turn lang/julia to metaport & introduce JULIA_DEFAULT to bsd.default-versions.mk.
Turn lang/julia to metaport & introduce JULIA_DEFAULT to bsd.default-versions.mk
Tue, May 28, 6:13 AM
lwhsu committed rP502856: Enable lang/julia06, lang/julia07 to be installed simultaneously.
Enable lang/julia06, lang/julia07 to be installed simultaneously
Tue, May 28, 6:08 AM
lwhsu committed rP502855: Copy lang/julia10 to lang/julia11 and update to 1.1.0.
Copy lang/julia10 to lang/julia11 and update to 1.1.0
Tue, May 28, 6:01 AM
lwhsu committed rP502854: Copy lang/julia to lang/julia10.
Copy lang/julia to lang/julia10
Tue, May 28, 5:59 AM

Mon, May 27

lwhsu updated the diff for D20428: ixl(4): fix the code not guarded by the guarded by the if clause.

Add explicit braces to avoid dangling else (-Werror,-Wdangling-else of clang)

Mon, May 27, 10:13 PM
lwhsu created D20432: Add Waterloo Hackathon 2019 to events.
Mon, May 27, 8:49 PM
lwhsu created D20428: ixl(4): fix the code not guarded by the guarded by the if clause.
Mon, May 27, 3:02 PM
lwhsu added a reviewer for D20427: ips(4): add missing braces: scottl.
Mon, May 27, 2:51 PM
lwhsu created D20427: ips(4): add missing braces.
Mon, May 27, 2:50 PM
lwhsu committed rP502799: - Update to 2.179.
- Update to 2.179
Mon, May 27, 2:34 PM
lwhsu updated subscribers of D20344: Add deprecation warnings for weaker algorithms to geli(4)..
In D20344#440836, @ngie wrote:

A change related to this broke CI (example):

...
Fail: incorrect exit status: 1, expected: 0
stdout:
stderr:
geli: The 3DES-CBC encryption algorithm is deprecated.

I'm looking through to figure out what exactly caused this.
CC: @lwhsu

Mon, May 27, 5:03 AM
lwhsu added a comment to D19298: AESNI version of CCM+CBC-MAC.
In D19298#440809, @cem wrote:
In D19298#440806, @ngie wrote:
  1. This broke the build with gcc:

I just noticed the same thing :-). Should be fixed in r348293.

Mon, May 27, 1:19 AM

Sat, May 25

lwhsu committed rS348284: Remove an uneeded indentation introduced in r223637 to silence gcc warnging.
Remove an uneeded indentation introduced in r223637 to silence gcc warnging
Sat, May 25, 11:58 PM
lwhsu committed rS348282: Remove an uneeded indentation introduced in r286196 to silence gcc warnging.
Remove an uneeded indentation introduced in r286196 to silence gcc warnging
Sat, May 25, 9:57 PM

Fri, May 24

lwhsu committed rS348231: Correct the argument passed to g_eli_algo2str().
Correct the argument passed to g_eli_algo2str()
Fri, May 24, 6:50 AM

Thu, May 23

lwhsu committed rP502357: - Update to 6.2.4.
- Update to 6.2.4
Thu, May 23, 9:08 PM

Wed, May 22

lwhsu added a comment to D17512: Fix dpcpu and vnet panics with complex types at the end of the section.

Tested this in Waterloo Hackathon 2019, this fixes bug230857 and bug238012.

Wed, May 22, 6:27 PM
lwhsu committed rP502272: - Update to 2.178.
- Update to 2.178
Wed, May 22, 2:44 PM

Mon, May 20

lwhsu committed rS347999: Install missing data file for.
Install missing data file for
Mon, May 20, 6:08 PM

May 14 2019

lwhsu committed rP501660: - Update to 2.177.
- Update to 2.177
May 14 2019, 1:51 PM

May 10 2019

lwhsu committed rP501201: Mark deprecated, the development has been moved to the upstream.
Mark deprecated, the development has been moved to the upstream
May 10 2019, 10:55 PM

May 8 2019

lwhsu closed D20188: Fix tests after rS347207.
May 8 2019, 6:46 PM
lwhsu committed rS347359: Fix expected output after r347207.
Fix expected output after r347207
May 8 2019, 6:46 PM
lwhsu accepted D19985: [new port] devel/zanata-platform: web-based translation platform.
May 8 2019, 5:54 AM

May 7 2019

lwhsu added a comment to D20188: Fix tests after rS347207.

@phil do you want me to commit this first (if you haven't had fix yet) to stop the failure warnings?

May 7 2019, 10:04 PM
lwhsu added a comment to D20188: Fix tests after rS347207.
In D20188#434976, @phil wrote:

Strange error; libtool related. On some platforms it seems to remove the ".test" extension. I'll add a fix to libxo to force removal of the extension (using xo_program() to set it to the basename), but for now, the fix here will be fine.

Thanks!

May 7 2019, 10:02 PM
lwhsu added a comment to D20188: Fix tests after rS347207.
In D20188#434976, @phil wrote:

Strange error; libtool related. On some platforms it seems to remove the ".test" extension. I'll add a fix to libxo to force removal of the extension (using xo_program() to set it to the basename), but for now, the fix here will be fine.

May 7 2019, 9:59 PM
lwhsu added a comment to D20188: Fix tests after rS347207.

@phil or do you want me to have a PR in github?

May 7 2019, 8:52 PM
lwhsu retitled D20188: Fix tests after rS347207 from Fix tests after r347207 to Fix tests after rS347207.
May 7 2019, 8:51 PM
lwhsu created D20188: Fix tests after rS347207.
May 7 2019, 8:35 PM
lwhsu accepted D20092: [new port] devel/linux-ltp: Linux Test Project (openSUSE Leap 42.3).

Please don't forget the license field :)

May 7 2019, 3:32 PM

May 6 2019

lwhsu committed rP500921: - Update to 2.176.
- Update to 2.176
May 6 2019, 6:27 PM

May 4 2019

lwhsu added inline comments to D19985: [new port] devel/zanata-platform: web-based translation platform.
May 4 2019, 9:21 PM

May 3 2019

lwhsu added inline comments to D19985: [new port] devel/zanata-platform: web-based translation platform.
May 3 2019, 6:37 PM

May 2 2019

lwhsu accepted D19985: [new port] devel/zanata-platform: web-based translation platform.

I haven't had time to setup a server to test myself, but this port looks good to me. Thanks for the work!

May 2 2019, 8:21 PM
lwhsu committed rP500669: Clean up trailing spaces.
Clean up trailing spaces
May 2 2019, 4:09 PM

Apr 30 2019

lwhsu added a comment to D20092: [new port] devel/linux-ltp: Linux Test Project (openSUSE Leap 42.3).
In D20092#432902, @tijl wrote:

Please keep the same style as the other Linux ports. RPMVERSION should really be up there with PORTVERSION so it's easy to check the version. It was only moved down because portlint complains so loudly about that. To move it even further down simply because of style goes against common sense though.

Apr 30 2019, 9:11 PM

Apr 29 2019

lwhsu added a comment to D20092: [new port] devel/linux-ltp: Linux Test Project (openSUSE Leap 42.3).

portlint -abct gives:

FATAL: /usr/home/lwhsu/freebsd-ports/benchmarks/linux-ltp/pkg-plist.amd64: [6685]: Man pages must be installed into ``man'' not ``share/man''.
FATAL: /usr/home/lwhsu/freebsd-ports/benchmarks/linux-ltp/pkg-plist.amd64: [6686]: Man pages must be installed into ``man'' not ``share/man''.
FATAL: /usr/home/lwhsu/freebsd-ports/benchmarks/linux-ltp/pkg-plist.amd64: [6687]: Man pages must be installed into ``man'' not ``share/man''.
FATAL: /usr/home/lwhsu/freebsd-ports/benchmarks/linux-ltp/pkg-plist.amd64: [6688]: Man pages must be installed into ``man'' not ``share/man''.
FATAL: /usr/home/lwhsu/freebsd-ports/benchmarks/linux-ltp/pkg-plist.amd64: [6689]: Man pages must be installed into ``man'' not ``share/man''.
FATAL: /usr/home/lwhsu/freebsd-ports/benchmarks/linux-ltp/pkg-plist.amd64: [6690]: Man pages must be installed into ``man'' not ``share/man''.
FATAL: /usr/home/lwhsu/freebsd-ports/benchmarks/linux-ltp/pkg-plist.amd64: [6691]: Man pages must be installed into ``man'' not ``share/man''.
FATAL: /usr/home/lwhsu/freebsd-ports/benchmarks/linux-ltp/pkg-plist.amd64: [6692]: Man pages must be installed into ``man'' not ``share/man''.
FATAL: /usr/home/lwhsu/freebsd-ports/benchmarks/linux-ltp/pkg-plist.amd64: [6693]: Man pages must be installed into ``man'' not ``share/man''.
FATAL: /usr/home/lwhsu/freebsd-ports/benchmarks/linux-ltp/pkg-plist.amd64: [6694]: Man pages must be installed into ``man'' not ``share/man''.
FATAL: /usr/home/lwhsu/freebsd-ports/benchmarks/linux-ltp/pkg-plist.amd64: [6695]: Man pages must be installed into ``man'' not ``share/man''.
FATAL: /usr/home/lwhsu/freebsd-ports/benchmarks/linux-ltp/pkg-plist.amd64: [6696]: Man pages must be installed into ``man'' not ``share/man''.
WARN: Makefile: Consider defining LICENSE.
WARN: Makefile: extra item placed in the USES/USE_x section, for example, "RPMVERSION".
12 fatal errors and 2 warnings found.

Do you think it makes sense to move these manpage files?

Not sure. Quick 'grep 'man/' */linux*/pkg-plist.amd64 | less' seems to suggest that 'share/man' is the norm for Linux packages.

Apr 29 2019, 8:14 PM
lwhsu added a comment to D20096: Enable build/install DTrace tests on amd64.

Agree, I am not intended to commit it immediately. But I think it's time to start to discuss turning this on by default. :-)

Apr 29 2019, 4:03 PM
lwhsu added a comment to D20096: Enable build/install DTrace tests on amd64.

Looks fine to me, but I think we need to fix the flaky tests first.

Rather, if the intention is to skip flaky tests, we should let the DTrace job for some time to ensure that we can identify them all. I know of one, for which you submitted a PR, but I believe there are others.

Apr 29 2019, 3:59 PM
lwhsu created D20096: Enable build/install DTrace tests on amd64.
Apr 29 2019, 3:44 PM
lwhsu committed rP500378: - Update to 2.175.
- Update to 2.175
Apr 29 2019, 5:26 AM
lwhsu added a comment to D20086: Replace ncat by a perl script for running an SCTP discard server.

Yes, you are right. Not sure what I was looking at. Should I add the trailing empty line to get things consistent?

Apr 29 2019, 3:51 AM
lwhsu committed rS346873: Add a trailing empty line to match the test code output.
Add a trailing empty line to match the test code output
Apr 29 2019, 3:50 AM

Apr 28 2019

lwhsu added a comment to D20086: Replace ncat by a perl script for running an SCTP discard server.

Just to double check: tst.ipv4localsctp.ksh.out and tst.localsctpstate.ksh.out both contain a single empty line at the end. Do you want me to add another one to tst.localsctpstate.ksh.out. This would make them inconsistent...

Apr 28 2019, 7:20 PM
lwhsu accepted D20086: Replace ncat by a perl script for running an SCTP discard server.
Apr 28 2019, 6:50 PM
lwhsu added a comment to D20092: [new port] devel/linux-ltp: Linux Test Project (openSUSE Leap 42.3).
FATAL: /usr/home/lwhsu/freebsd-ports/benchmarks/linux-ltp/pkg-plist.amd64: [6685]: Man pages must be installed into ``man'' not ``share/man''.
FATAL: /usr/home/lwhsu/freebsd-ports/benchmarks/linux-ltp/pkg-plist.amd64: [6686]: Man pages must be installed into ``man'' not ``share/man''.
FATAL: /usr/home/lwhsu/freebsd-ports/benchmarks/linux-ltp/pkg-plist.amd64: [6687]: Man pages must be installed into ``man'' not ``share/man''.
FATAL: /usr/home/lwhsu/freebsd-ports/benchmarks/linux-ltp/pkg-plist.amd64: [6688]: Man pages must be installed into ``man'' not ``share/man''.
FATAL: /usr/home/lwhsu/freebsd-ports/benchmarks/linux-ltp/pkg-plist.amd64: [6689]: Man pages must be installed into ``man'' not ``share/man''.
FATAL: /usr/home/lwhsu/freebsd-ports/benchmarks/linux-ltp/pkg-plist.amd64: [6690]: Man pages must be installed into ``man'' not ``share/man''.
FATAL: /usr/home/lwhsu/freebsd-ports/benchmarks/linux-ltp/pkg-plist.amd64: [6691]: Man pages must be installed into ``man'' not ``share/man''.
FATAL: /usr/home/lwhsu/freebsd-ports/benchmarks/linux-ltp/pkg-plist.amd64: [6692]: Man pages must be installed into ``man'' not ``share/man''.
FATAL: /usr/home/lwhsu/freebsd-ports/benchmarks/linux-ltp/pkg-plist.amd64: [6693]: Man pages must be installed into ``man'' not ``share/man''.
FATAL: /usr/home/lwhsu/freebsd-ports/benchmarks/linux-ltp/pkg-plist.amd64: [6694]: Man pages must be installed into ``man'' not ``share/man''.
FATAL: /usr/home/lwhsu/freebsd-ports/benchmarks/linux-ltp/pkg-plist.amd64: [6695]: Man pages must be installed into ``man'' not ``share/man''.
FATAL: /usr/home/lwhsu/freebsd-ports/benchmarks/linux-ltp/pkg-plist.amd64: [6696]: Man pages must be installed into ``man'' not ``share/man''.
WARN: Makefile: Consider defining LICENSE.
WARN: Makefile: extra item placed in the USES/USE_x section, for example, "RPMVERSION".
12 fatal errors and 2 warnings found.
Apr 28 2019, 6:40 PM
lwhsu requested changes to D20086: Replace ncat by a perl script for running an SCTP discard server.

I've tested test in my development environment and testvm images from artifact.ci.freebsd.org, for making these two tests passing, we also need to modify tst.localsctpstate.ksh.out to added an extra blank line at the end of the file. I think it's acceptable for now, and other .out files also have this line. I would like to check that extra blank line is generated by the test driver or these ksh test scripts later, and fix them all together.

Apr 28 2019, 6:25 PM

Apr 25 2019

lwhsu added inline comments to D19985: [new port] devel/zanata-platform: web-based translation platform.
Apr 25 2019, 6:39 AM

Apr 23 2019

lwhsu added a comment to D20017: Expect *localsctp* to fail.

ncat is from nmap port and has nothing to do with nc, their names are similar but they are different things.

Apr 23 2019, 11:59 PM
lwhsu committed rP499770: Really make the previous patch apply in build.
Really make the previous patch apply in build
Apr 23 2019, 5:08 PM
lwhsu committed rP499714: - Update to 2019.1.
- Update to 2019.1
Apr 23 2019, 4:39 AM
lwhsu committed rP499712: - Update to 2.174.
- Update to 2.174
Apr 23 2019, 3:06 AM
lwhsu abandoned D18495: Fix sys.kern.coredump_phnum_test.coredump_phnum on i386.

Suppressed by D20005.

Apr 23 2019, 2:58 AM
lwhsu requested changes to D20017: Expect *localsctp* to fail.

I'd prefer let's fix these test cases.

Apr 23 2019, 1:07 AM
lwhsu added a comment to D20017: Expect *localsctp* to fail.

OK, I just check we have nmap in the test vm image and it does the work: https://github.com/freebsd/freebsd-ci/commit/689e19c8c71e1892f476c9ef9392f6b443d0ed15
The other failures are due to some perl stuff which I haven't had time on it: https://ci.freebsd.org/job/FreeBSD-head-amd64-dtrace_test/lastCompletedBuild/testReport/common.ip/t_dtrace_contrib/tst_ipv4localsctp_ksh/

Apr 23 2019, 1:06 AM
lwhsu added a comment to D20017: Expect *localsctp* to fail.

It looks these tests require ncat but not netcat. I'll check if the test image has this port installed.
Also, I think the test case requires external tools to execute would be better to be marked as SKIP (with a message states the lacking requirements) instead of being marked EXFAIL.

Apr 23 2019, 1:00 AM
lwhsu updated subscribers of D20017: Expect *localsctp* to fail.
Apr 23 2019, 12:40 AM

Apr 22 2019

lwhsu accepted D20005: Fix sys.kern.coredump_phnum_test.coredump_phnum on i386.

Thanks for the better fix. BTW, I still think these checks would be better to be rewritten as getting the real number and compare with 65535.

Apr 22 2019, 11:15 AM
lwhsu added a comment to D19985: [new port] devel/zanata-platform: web-based translation platform.

BTW, there seems a leading white space in each line of your draft commit message.

Apr 22 2019, 4:18 AM
lwhsu requested changes to D19985: [new port] devel/zanata-platform: web-based translation platform.

Overall this looks good, please check my comments. Thanks for working on this!

Apr 22 2019, 4:17 AM

Apr 20 2019

lwhsu committed rP499456: - Update to 6.2.3.
- Update to 6.2.3
Apr 20 2019, 4:01 PM
lwhsu committed rS346431: Specify using Python2, these .py files have not been converted to use Python3.
Specify using Python2, these .py files have not been converted to use Python3
Apr 20 2019, 7:32 AM

Apr 18 2019

lwhsu committed rP499307: Add a patch from upstream which solves the interface name may not end by digit.
Add a patch from upstream which solves the interface name may not end by digit
Apr 18 2019, 6:51 PM
lwhsu committed rP499235: - Update to 0.4.2.
- Update to 0.4.2
Apr 18 2019, 5:52 AM
lwhsu committed rP499234: Update to 1.0.9.
Update to 1.0.9
Apr 18 2019, 5:44 AM

Apr 16 2019

lwhsu added a reviewer for D19838: Fix a memory leak in pw when invoked with -V or -R: kristof.
Apr 16 2019, 11:33 AM
lwhsu committed rP499071: - Update to 2.173.
- Update to 2.173
Apr 16 2019, 3:43 AM

Apr 15 2019

lwhsu added a comment to D19192: lang/elixir: update to 1.8.1 and use OTP-21 shim.

I haven't been using elixir for a while, and I haven't tested this patch. It looks good to me, but I don't think I would explicitly "review" it as I haven't tried it yet.

Apr 15 2019, 10:39 AM
lwhsu removed 1 blocking reviewer(s) for D19192: lang/elixir: update to 1.8.1 and use OTP-21 shim: lwhsu.
Apr 15 2019, 10:36 AM

Apr 12 2019

lwhsu committed rP498738: MFH: r498576.
MFH: r498576
Apr 12 2019, 6:47 PM
lwhsu committed rP498737: MFH: r498571.
MFH: r498571
Apr 12 2019, 6:44 PM
lwhsu committed rS346160: Suppress old gcc warning about null format string.
Suppress old gcc warning about null format string
Apr 12 2019, 6:35 PM

Apr 10 2019

lwhsu committed rS346087: Fix build in sys/modules/nfscommon.
Fix build in sys/modules/nfscommon
Apr 10 2019, 4:48 PM
lwhsu committed rP498576: - Update to 2.164.2.
- Update to 2.164.2
Apr 10 2019, 3:46 PM
lwhsu committed rP498571: - Update to 2.172.
- Update to 2.172
Apr 10 2019, 3:40 PM
lwhsu committed rP498569: Document Jenkins Security Advisory 2019-04-10.
Document Jenkins Security Advisory 2019-04-10
Apr 10 2019, 3:30 PM
lwhsu committed rP498565: - Update to 3.4.9.
- Update to 3.4.9
Apr 10 2019, 2:31 PM
lwhsu committed rP498564: - Update to 1.5.5.
- Update to 1.5.5
Apr 10 2019, 2:03 PM
lwhsu committed rP498563: - Update to 2.10.0.
- Update to 2.10.0
Apr 10 2019, 2:00 PM

Apr 7 2019

lwhsu committed rP498291: - Update to 2.171.
- Update to 2.171
Apr 7 2019, 4:36 PM

Apr 1 2019

lwhsu committed rP497479: - Update to 2.170.
- Update to 2.170
Apr 1 2019, 12:52 PM