Page MenuHomeFreeBSD

br (Ruslan Bukin)
User

Projects

User Details

User Since
Nov 27 2014, 10:57 AM (325 w, 6 d)

Recent Activity

Tue, Feb 23

br added a comment to D28535: Increase SMMU timeout.

Sadly but this failed testing even if I put DELAY(100).
I'll need to find out which request failed exactly.

Tue, Feb 23, 7:48 PM
br accepted D28890: Use pmap_qenter in the N1SDP PCIe driver.

Booted fine. All my PCI cards work fine.

Tue, Feb 23, 6:30 PM

Mon, Feb 8

br updated the summary of D28535: Increase SMMU timeout.
Mon, Feb 8, 12:30 PM
br updated the summary of D28535: Increase SMMU timeout.
Mon, Feb 8, 12:29 PM
br requested review of D28535: Increase SMMU timeout.
Mon, Feb 8, 12:27 PM

Jan 11 2021

br accepted D28091: Add -NODEBUG variant of GENERIC-MMCCAM kernel configuration..
Jan 11 2021, 2:33 PM

Nov 27 2020

br closed D27399: Move IOMMU option.
Nov 27 2020, 9:38 PM
br committed rS368113: o Move options IOMMU from Debugging section back to the Bus section.
o Move options IOMMU from Debugging section back to the Bus section
Nov 27 2020, 9:38 PM
br updated the summary of D27399: Move IOMMU option.
Nov 27 2020, 8:08 PM
br updated the diff for D27399: Move IOMMU option.

o Place IOMMU to exact place where ACPI_DMAR was
o Remove IOMMU from i386/MINIMAL as we don't have it in i386/GENERIC

Nov 27 2020, 8:06 PM
br requested review of D27399: Move IOMMU option.
Nov 27 2020, 7:31 PM

Nov 16 2020

br closed D24618: ARM SMMU v3.2 support.
Nov 16 2020, 9:56 PM
br committed rS367736: Introduce IOMMU support for arm64 platform..
Introduce IOMMU support for arm64 platform.
Nov 16 2020, 9:56 PM
br updated the diff for D24618: ARM SMMU v3.2 support.

Remove unused headers

Nov 16 2020, 4:20 PM
br closed D27235: bug fix: iommu_gas_fini_domain().
Nov 16 2020, 3:37 PM
br committed rS367726: Fix a bug in assertion: entry flags also includes IOMMU_MAP_ENTRY_UNMAPPED..
Fix a bug in assertion: entry flags also includes IOMMU_MAP_ENTRY_UNMAPPED.
Nov 16 2020, 3:37 PM
br closed D27229: Add dev member to struct iommu.
Nov 16 2020, 3:30 PM
br committed rS367725: Add device_t member to struct iommu..
Add device_t member to struct iommu.
Nov 16 2020, 3:30 PM
br updated the diff for D24618: ARM SMMU v3.2 support.

More style fixes:
o Rename header protection variables
o Make variables consistent:

struct smmu_unit is unit
struct smmu_domain is domain
struct smmu_ctx is ctx
struct iommu_unit is iommu
struct iommu_domain is iodom
struct iommu_ctx is ioctx

o Add locking around smmu_ctx_lookup() method
o ctx_free and domain_free methods return void
o Call to iommu_gas_fini_domain() and iommu_domain_fini() on domain deinitialization (iommu_domain_free())

Nov 16 2020, 3:09 PM
br added inline comments to D27235: bug fix: iommu_gas_fini_domain().
Nov 16 2020, 12:34 PM
br updated the diff for D27235: bug fix: iommu_gas_fini_domain().

Fix indentation

Nov 16 2020, 12:34 PM
br requested review of D27235: bug fix: iommu_gas_fini_domain().
Nov 16 2020, 11:37 AM
br updated the diff for D24618: ARM SMMU v3.2 support.

Address mmel's comments.

Nov 16 2020, 12:03 AM

Nov 15 2020

br requested review of D27229: Add dev member to struct iommu.
Nov 15 2020, 11:00 PM

Nov 11 2020

br updated the diff for D24618: ARM SMMU v3.2 support.

Rework the arm64 iommu interface so it could be used on other IOMMU engines in arm64 world, not only SMMU.
(Requested by mmel)

Nov 11 2020, 4:47 PM

Nov 8 2020

br added inline comments to D27139: rk_i2c bug fix.
Nov 8 2020, 2:09 PM
br requested review of D27139: rk_i2c bug fix.
Nov 8 2020, 1:26 PM

Nov 3 2020

br updated the diff for D24618: ARM SMMU v3.2 support.

update copyright for smmu_quircks.c

Nov 3 2020, 11:29 AM

Nov 2 2020

br closed D26877: SMMU pmap routines added.
Nov 2 2020, 7:57 PM
br committed rS367282: Add routines for ARM System MMU (SMMU) pmap management..
Add routines for ARM System MMU (SMMU) pmap management.
Nov 2 2020, 7:57 PM

Nov 1 2020

br added inline comments to D26877: SMMU pmap routines added.
Nov 1 2020, 11:04 AM
br updated the diff for D26877: SMMU pmap routines added.

Manage resident count for L3 pages of SMMU pmap

Nov 1 2020, 10:38 AM

Oct 29 2020

br updated the diff for D24618: ARM SMMU v3.2 support.

Set domain.end address (max guest addr + 1) to the VM_MAXUSER_ADDR

Oct 29 2020, 3:22 PM

Oct 28 2020

br updated the diff for D26877: SMMU pmap routines added.

Fix comment

Oct 28 2020, 10:12 AM

Oct 27 2020

br updated the diff for D24618: ARM SMMU v3.2 support.

Rename iommu_smmu.c to smmu_iommu.c

Oct 27 2020, 5:28 PM
br updated the diff for D24618: ARM SMMU v3.2 support.

The final patch to review

Oct 27 2020, 4:42 PM
br committed rS367085: o Add the domain member to the struct bus_dma_tag_common as required by.
o Add the domain member to the struct bus_dma_tag_common as required by
Oct 27 2020, 3:30 PM
br closed D26904: gicv3_its_release_irqsrc() locking.
Oct 27 2020, 3:18 PM
br committed rS367084: Take the ITS device lock around gicv3_its_release_irqsrc() since that.
Take the ITS device lock around gicv3_its_release_irqsrc() since that
Oct 27 2020, 3:18 PM
br updated the diff for D26877: SMMU pmap routines added.

Address markj@ queries

Oct 27 2020, 3:06 PM
br added inline comments to D26877: SMMU pmap routines added.
Oct 27 2020, 3:06 PM

Oct 25 2020

br closed D26878: IOMMU support for GICv3 ITS.
Oct 25 2020, 10:09 AM
br committed rS367037: Add IOMMU support to GICv3 Interrupt Translation Service (ITS) driver..
Add IOMMU support to GICv3 Interrupt Translation Service (ITS) driver.
Oct 25 2020, 10:09 AM

Oct 24 2020

br abandoned D25974: map_msi for IOMMU.
Oct 24 2020, 8:11 PM
br closed D26906: iommu_unmap_msi() added.
Oct 24 2020, 8:09 PM
br committed rS367016: o Add iommu de-initialization method for MSI interface..
o Add iommu de-initialization method for MSI interface.
Oct 24 2020, 8:09 PM
br updated the diff for D26906: iommu_unmap_msi() added.

Add default implementations of iommu_init/deinit

Oct 24 2020, 11:18 AM

Oct 23 2020

br updated the diff for D26878: IOMMU support for GICv3 ITS.

gicv3_iommu_deinit() added

Oct 23 2020, 10:29 PM
br updated the diff for D26906: iommu_unmap_msi() added.

o Check if entry is not NULL, otherwise return early
o Remove gicv3_its.c changes from this diff. They are moved to https://reviews.freebsd.org/D26878

Oct 23 2020, 10:27 PM
br closed D26887: Add bus_dma_iommu_set_buswide() stubs.
Oct 23 2020, 9:28 PM
br committed rS366980: Move the iommu stubs to a generic place, so they are available on all the.
Move the iommu stubs to a generic place, so they are available on all the
Oct 23 2020, 9:28 PM
br updated the diff for D26887: Add bus_dma_iommu_set_buswide() stubs.

Move iommu stubs to subr_bus_dma.c

Oct 23 2020, 2:35 PM
br added a comment to D26887: Add bus_dma_iommu_set_buswide() stubs.

Would it make sense to move these to subr_bus_dma.c in the non-IOMMU case?

Oct 23 2020, 8:37 AM

Oct 22 2020

br requested review of D26906: iommu_unmap_msi() added.
Oct 22 2020, 5:04 PM
br requested review of D26904: gicv3_its_release_irqsrc() locking.
Oct 22 2020, 4:20 PM
br added inline comments to D26877: SMMU pmap routines added.
Oct 22 2020, 3:45 PM
br updated the diff for D26877: SMMU pmap routines added.

o Rename pmap_sremove_all() to pmap_sremove_pages()
o Remove unneeded check for L2_BLOCK in pmap_sremove_pages()

Oct 22 2020, 3:40 PM

Oct 21 2020

br requested review of D26887: Add bus_dma_iommu_set_buswide() stubs.
Oct 21 2020, 11:37 AM

Oct 20 2020

br added inline comments to D26878: IOMMU support for GICv3 ITS.
Oct 20 2020, 11:15 AM
br requested review of D26878: IOMMU support for GICv3 ITS.
Oct 20 2020, 9:55 AM
br requested review of D26877: SMMU pmap routines added.
Oct 20 2020, 9:52 AM

Oct 19 2020

br committed rS366865: Fix build: only set iommu buswide flag if IOMMU code is included..
Fix build: only set iommu buswide flag if IOMMU code is included.
Oct 19 2020, 10:32 PM
br closed D26857: IOMMU quirks added.
Oct 19 2020, 9:27 PM
br committed rS366863: Add IOMMU_BUSWIDE ahci quirk..
Add IOMMU_BUSWIDE ahci quirk.
Oct 19 2020, 9:27 PM
br updated the diff for D26857: IOMMU quirks added.

Add IOMMU quirks for all the devices listed in linux

Oct 19 2020, 7:03 PM
br updated the diff for D26857: IOMMU quirks added.

Update AHCI quirk bitstring

Oct 19 2020, 3:59 PM
br closed D26859: Assign MSI entry to x86.
Oct 19 2020, 3:51 PM
br committed rS366835: Assign the reserved apic region (GAS entry) to the iommu domain msi_entry..
Assign the reserved apic region (GAS entry) to the iommu domain msi_entry.
Oct 19 2020, 3:51 PM
br updated the diff for D26857: IOMMU quirks added.

Move the quirk to ahci driver

Oct 19 2020, 3:27 PM
br requested review of D26859: Assign MSI entry to x86.
Oct 19 2020, 2:08 PM
br requested review of D26857: IOMMU quirks added.
Oct 19 2020, 1:35 PM
br closed D26705: Manage MSI iommu pages.
Oct 19 2020, 1:10 PM
br committed rS366833: Manage MSI iommu pages..
Manage MSI iommu pages.
Oct 19 2020, 1:10 PM
br added inline comments to D26705: Manage MSI iommu pages.
Oct 19 2020, 1:09 PM
br added inline comments to D26705: Manage MSI iommu pages.
Oct 19 2020, 10:22 AM
br updated the diff for D26705: Manage MSI iommu pages.

o Add a KASSERT
o Mark MSI fields in the iommu_domain as arch-specific

Oct 19 2020, 10:20 AM

Oct 18 2020

br updated the diff for D26705: Manage MSI iommu pages.

Regenerate

Oct 18 2020, 8:42 PM
br updated the diff for D26705: Manage MSI iommu pages.

o Move iommu_get_ctx_domain(), iommu_get_dev_ctx() to iommu.h

Oct 18 2020, 8:40 PM
br added a comment to D26705: Manage MSI iommu pages.
In D26705#598296, @kib wrote:

I am curious. There is no arch restriction on the value of MSI base address ? System can map MSI page anywhere, and just programming the correct address into MSI address register would make it work ?

This is very non-x86ish.

Oct 18 2020, 8:39 PM
br updated the diff for D26705: Manage MSI iommu pages.

o Put Andrew's copyright
o Remove ifdef IOMMU

Oct 18 2020, 8:29 PM

Oct 16 2020

br accepted D26813: Add an entry to RELNOTES about renaming ACPI_DMAR to IOMMU.

We could also note that the amd64's IOMMU subsystem was splitted-out from amd64 DMAR support and is now generic, i.e. could be used by all architectures

Oct 16 2020, 10:06 AM

Oct 15 2020

br added inline comments to D26705: Manage MSI iommu pages.
Oct 15 2020, 4:01 PM
br updated the diff for D26705: Manage MSI iommu pages.

Regenerate

Oct 15 2020, 2:08 PM
br committed rS366724: Split-out Guest Address Space (GAS) macroses to a separate header..
Split-out Guest Address Space (GAS) macroses to a separate header.
Oct 15 2020, 1:48 PM

Oct 14 2020

br updated the diff for D26705: Manage MSI iommu pages.

Address kibs's notes

Oct 14 2020, 9:53 PM
br closed D26780: Add iommu_types.h.
Oct 14 2020, 9:22 PM
br committed rS366710: Split-out iommu type definitions to a separate header..
Split-out iommu type definitions to a separate header.
Oct 14 2020, 9:22 PM
br closed D26722: Add a per-arch macro for unload sleep.
Oct 14 2020, 2:51 PM
br committed rS366704: Add a per-each macro IOMMU_DOMAIN_UNLOAD_SLEEP which allows to sleep.
Add a per-each macro IOMMU_DOMAIN_UNLOAD_SLEEP which allows to sleep
Oct 14 2020, 2:51 PM
br requested review of D26780: Add iommu_types.h.
Oct 14 2020, 2:16 PM
br committed rS366702: Add iommu_get_ctx_domain() that allows to get iommu domain for a given.
Add iommu_get_ctx_domain() that allows to get iommu domain for a given
Oct 14 2020, 2:12 PM
br committed rS366701: Rename a header protection macro..
Rename a header protection macro.
Oct 14 2020, 1:39 PM

Oct 13 2020

br updated the diff for D26705: Manage MSI iommu pages.

Address kib's notes:

  • add iommu_types.h
  • add md macro IOMMU_UNLOAD_SLEEP
Oct 13 2020, 1:14 PM

Oct 9 2020

br requested review of D26722: Add a per-arch macro for unload sleep.
Oct 9 2020, 2:08 PM
br committed rS366571: Add iommu_get_dev_ctx() helper that allows to instantiate an iommu context.
Add iommu_get_dev_ctx() helper that allows to instantiate an iommu context
Oct 9 2020, 1:11 PM

Oct 8 2020

br updated the diff for D26705: Manage MSI iommu pages.

context added

Oct 8 2020, 3:19 PM
br added a comment to D26705: Manage MSI iommu pages.
In D26705#595414, @br wrote:
In D26705#595261, @kib wrote:

So would adding a header iommu_msi.h with just msi-related prototypes enough ? I suspect that x86/msi.c can also get rid of iommu.h then.

I will try and see if it works

Oct 8 2020, 2:54 PM
br updated the diff for D26705: Manage MSI iommu pages.

Manage MSI iommu pages

Oct 8 2020, 2:53 PM
br added a comment to D26705: Manage MSI iommu pages.
In D26705#595261, @kib wrote:

So would adding a header iommu_msi.h with just msi-related prototypes enough ? I suspect that x86/msi.c can also get rid of iommu.h then.

Oct 8 2020, 11:54 AM

Oct 7 2020

br added a comment to D26705: Manage MSI iommu pages.
In D26705#595130, @kib wrote:

Convention for var.h is not suitable for your case IMO. We have signal.h and signalvar.h, where signal.h is usable by userspace and signalvar.h is for kernel private stuff.

Can you provide some enumeration of stuff you want to keep in iommu.h, and an explanation of why ?

Oct 7 2020, 7:34 PM