Page MenuHomeFreeBSD

br (Ruslan Bukin)
User

Projects

User Details

User Since
Nov 27 2014, 10:57 AM (273 w, 19 h)

Recent Activity

Tue, Feb 11

br committed rS357762: Add PCI Express driver for the ARM Neoverse N1 System Development.
Add PCI Express driver for the ARM Neoverse N1 System Development
Tue, Feb 11, 3:12 PM
br closed D23349: arm64 N1SDP PCI root complex driver.
Tue, Feb 11, 3:12 PM

Mon, Feb 10

br updated the diff for D23349: arm64 N1SDP PCI root complex driver.

The pcie_discovery_data is device specific, move it to the softc.
Move the root memory to the softc and switch it to use bus_space.
While here create a common function to get the correct bus_space
details for a given bus/slot/func/reg combination.

Mon, Feb 10, 5:56 PM
br updated the diff for D23349: arm64 N1SDP PCI root complex driver.

Move the driver to dev/pci/controller/

Mon, Feb 10, 1:51 PM
br added a comment to D23349: arm64 N1SDP PCI root complex driver.

what about dev/pci/controller/? linux does that.
We have a similar subdirectory for MMC drivers: dev/mmc/host/ that works well and keeps dev/mmc/ clean

Mon, Feb 10, 1:21 PM

Sat, Feb 8

br committed rS357686: Enter the network epoch in the xdma interrupt handler if required.
Enter the network epoch in the xdma interrupt handler if required
Sat, Feb 8, 11:07 PM
br committed rS357682: Fix a KASSERT since chained mbufs are accepted by the xdma bounce.
Fix a KASSERT since chained mbufs are accepted by the xdma bounce
Sat, Feb 8, 9:02 PM

Fri, Feb 7

br committed rS357653: Fix xae(4) driver attachement on the Government Furnished Equipment (GFE).
Fix xae(4) driver attachement on the Government Furnished Equipment (GFE)
Fri, Feb 7, 2:36 PM
br updated the diff for D23349: arm64 N1SDP PCI root complex driver.

move the driver by request from jhb@

Fri, Feb 7, 12:50 PM

Thu, Feb 6

br added a comment to D23349: arm64 N1SDP PCI root complex driver.
In D23349#516026, @jhb wrote:

As with the xilinx driver, can we please not put MD and chipset-specific code in sys/dev/pci?

Thu, Feb 6, 12:56 PM

Wed, Feb 5

br accepted D23513: Use the context created in makectx() for stack traces..
Wed, Feb 5, 11:55 PM
br accepted D23508: Fix DDB to unwind across exception frames..
Wed, Feb 5, 11:53 PM
br accepted D23509: Remove stale workaround for the htif console..
Wed, Feb 5, 5:52 PM
br accepted D23507: Read the breakpoint instruction to determine its length in BKPT_SKIP..
Wed, Feb 5, 5:50 PM

Mon, Feb 3

br accepted D23436: Set the LMA of the riscv kernel to the OpenSBI jump target by default.
Mon, Feb 3, 1:55 PM
br awarded D23436: Set the LMA of the riscv kernel to the OpenSBI jump target by default a Like token.
Mon, Feb 3, 1:49 PM

Sat, Feb 1

br updated the test plan for D23349: arm64 N1SDP PCI root complex driver.
Sat, Feb 1, 9:25 PM
br added a reviewer for D23349: arm64 N1SDP PCI root complex driver: mmel.
Sat, Feb 1, 9:24 PM

Thu, Jan 30

br updated the diff for D23349: arm64 N1SDP PCI root complex driver.

o Address mmel's comment.
o Don't override MSI methods since Andrew has fixed a bug in the ITS driver

Thu, Jan 30, 6:19 PM
br added inline comments to D23349: arm64 N1SDP PCI root complex driver.
Thu, Jan 30, 6:10 PM
br updated the diff for D23349: arm64 N1SDP PCI root complex driver.

Include pcI_n1sdp to the build

Thu, Jan 30, 1:13 PM

Wed, Jan 29

br committed rS357258: Add driver for Xilinx XDMA PCIe Bridge found in the U.S. Government.
Add driver for Xilinx XDMA PCIe Bridge found in the U.S. Government
Wed, Jan 29, 4:52 PM
br closed D23337: Xilinx XDMA PCIe Controller driver.
Wed, Jan 29, 4:52 PM
br updated the diff for D23349: arm64 N1SDP PCI root complex driver.

Add comment for MSI/MSIx

Wed, Jan 29, 3:03 PM
br updated the diff for D23349: arm64 N1SDP PCI root complex driver.

Override MSI/MSIx pcib methods so MSI allocation fail and INTx are used.
MSI/MSIx don't work for now

Wed, Jan 29, 2:54 PM

Tue, Jan 28

br accepted D23402: Fix definition of SSTATUS_SD.
Tue, Jan 28, 8:52 PM
br accepted D23407: cgem: Add another compat string for the SiFive fu540.
Tue, Jan 28, 8:51 PM
br updated the diff for D23349: arm64 N1SDP PCI root complex driver.

Address Andrew's comments: use kva_alloc/pmap_enter for non-device memory

Tue, Jan 28, 1:26 PM
br accepted D23395: Remove unused fields from struct pcb..

Looks good

Tue, Jan 28, 11:53 AM
br accepted D23394: Trim duplicate CSR swaps from user exceptions..

nice catch!

Tue, Jan 28, 11:39 AM

Mon, Jan 27

br added inline comments to D23349: arm64 N1SDP PCI root complex driver.
Mon, Jan 27, 2:38 PM

Fri, Jan 24

br created D23349: arm64 N1SDP PCI root complex driver.
Fri, Jan 24, 5:24 PM
br committed rS357087: Include the PCI stack to the riscv GENERIC kernel..
Include the PCI stack to the riscv GENERIC kernel.
Fri, Jan 24, 5:10 PM
br committed rS357086: Enable NEW_PCIB on riscv..
Enable NEW_PCIB on riscv.
Fri, Jan 24, 4:50 PM
br committed rS357085: o Move the software context struct to a header file..
o Move the software context struct to a header file.
Fri, Jan 24, 4:44 PM
br committed rS357083: Move the ECAM macroses to the header file..
Move the ECAM macroses to the header file.
Fri, Jan 24, 4:08 PM

Thu, Jan 23

br updated the diff for D23337: Xilinx XDMA PCIe Controller driver.

Rename the driver to dev/xilinx/xlnx_pcib.[ch] per request from jhb@

Thu, Jan 23, 5:38 PM
br added a member for PCI: br.
Thu, Jan 23, 5:36 PM
br created D23337: Xilinx XDMA PCIe Controller driver.
Thu, Jan 23, 5:03 PM

Jan 17 2020

br accepted D23218: Save and restore floating point registers in get/set_mcontext()..
Jan 17 2020, 4:57 PM
br committed rS356834: Use unsigned loads in fubyte, fuword16, generic_bs_r_1, generic_bs_r_2.
Use unsigned loads in fubyte, fuword16, generic_bs_r_1, generic_bs_r_2
Jan 17 2020, 4:48 PM
br closed D23236: fix riscv load/stores.
Jan 17 2020, 4:48 PM
br created D23236: fix riscv load/stores.
Jan 17 2020, 4:12 PM

Dec 30 2019

br committed rS356205: Don't hard-code field offsets of struct riscv_bootparams..
Don't hard-code field offsets of struct riscv_bootparams.
Dec 30 2019, 5:19 PM
br closed D22970: RISC-V: Don't hard-code field offsets of struct riscv_bootparams.
Dec 30 2019, 5:19 PM
br added inline comments to D22970: RISC-V: Don't hard-code field offsets of struct riscv_bootparams.
Dec 30 2019, 4:35 PM
br committed rS356203: Don't hard-code size of struct riscv_bootparams..
Don't hard-code size of struct riscv_bootparams.
Dec 30 2019, 2:38 PM
br closed D22968: RISC-V: Don't hard-code size of struct riscv_bootparams.
Dec 30 2019, 2:38 PM
br accepted D22968: RISC-V: Don't hard-code size of struct riscv_bootparams.
Dec 30 2019, 2:36 PM
br committed rS356202: Round the kernel stack allocation up as required..
Round the kernel stack allocation up as required.
Dec 30 2019, 1:29 PM
br closed D22961: RISC-V: Ensure kernel stack is aligned.
Dec 30 2019, 1:29 PM

Dec 29 2019

br accepted D22961: RISC-V: Ensure kernel stack is aligned.

Looks good. Thank you!

Dec 29 2019, 11:48 PM

Dec 4 2019

br accepted D22658: Use "far" calls and branches so that lld uses valid relocations..
Dec 4 2019, 2:42 PM
br accepted D22656: Use a single 'ld' to read the jmpbuf magic values instead of 'la; ld'..
Dec 4 2019, 2:40 PM

Nov 14 2019

br accepted D21928: plic: support irq distribution.
Nov 14 2019, 3:22 PM

Nov 11 2019

br accepted D21927: plic: fix context calculation.

Looks good.

Nov 11 2019, 2:22 PM
br added inline comments to D21928: plic: support irq distribution.
Nov 11 2019, 2:19 PM

Nov 4 2019

br accepted D21927: plic: fix context calculation.

Looks good

Nov 4 2019, 1:30 PM

Oct 28 2019

br added a comment to D21928: plic: support irq distribution.

I also have a comment from jhb@:
@br typically we only route device interrupts to a single core since interrupt handlers generally assume they are not run concurrently (interrupt filters, ithreads will be single-threaded even if the interrupt is broadcast)
as Andy noted, you want to handle interrupt binding requests, but you also need to do something for the “default” case.
Not sure what INTRNG does, but on x86 we round-robin interrupts among CPUs when they are first setup.

Oct 28 2019, 7:00 PM
br added a comment to D21928: plic: support irq distribution.
In D21928#484089, @br wrote:

Why do we need to enable interrupts for all CPUs and not only current cpu?
where an interrupt will be signaled in that case?

PIC_ENABLE_INTR is called very seldomly, often only once while setting up the PIC during intr_setup_irq by the BSP. Since it is not called per-cpu, this function should handle enabling the interrupt for all active CPUs.
BBL sets all PLIC enable bits to 1 by default, whereas OpenSBI sets them to 0, which is how I noticed that APs weren't having their interrupts enabled.

Oct 28 2019, 6:33 PM

Oct 25 2019

br added a comment to D21927: plic: fix context calculation.

looks good!

Oct 25 2019, 8:27 AM
br added a comment to D21928: plic: support irq distribution.

Why do we need to enable interrupts for all CPUs and not only current cpu?
where an interrupt will be signaled in that case?

Oct 25 2019, 8:18 AM

Oct 15 2019

br committed rS353575: Fix dwmmc(4) driver attachment when ext_resources are not present..
Fix dwmmc(4) driver attachment when ext_resources are not present.
Oct 15 2019, 5:24 PM
br closed D22043: Fix dwmmc(4) attachment.
Oct 15 2019, 5:24 PM
br created D22043: Fix dwmmc(4) attachment.
Oct 15 2019, 5:09 PM

Oct 14 2019

br committed rS353493: Fix the driver attachment in cases when the external resource devices.
Fix the driver attachment in cases when the external resource devices
Oct 14 2019, 3:53 PM

Oct 11 2019

br accepted D21975: RISC-V: Call devmap_bootstrap().
Oct 11 2019, 3:15 PM
br committed rS353431: Install the libopencsd version header (other headers now depend on it)..
Install the libopencsd version header (other headers now depend on it).
Oct 11 2019, 9:19 AM

Oct 10 2019

br committed rS353394: Remove a stale file left after merging..
Remove a stale file left after merging.
Oct 10 2019, 1:44 PM
br committed rS353393: Update ARM CoreSight trace decoder library..
Update ARM CoreSight trace decoder library.
Oct 10 2019, 1:30 PM
br committed rS353392: Update opencsd tag..
Update opencsd tag.
Oct 10 2019, 1:23 PM
br committed rS353391: Import OpenCSD -- an ARM CoreSight Trace Decode library..
Import OpenCSD -- an ARM CoreSight Trace Decode library.
Oct 10 2019, 1:19 PM
br committed rS353390: Update Intel Processor Trace decoder library..
Update Intel Processor Trace decoder library.
Oct 10 2019, 12:47 PM
br committed rS353389: Import Intel Processor Trace library..
Import Intel Processor Trace library.
Oct 10 2019, 12:20 PM

Oct 8 2019

br added a comment to D21927: plic: fix context calculation.

Are these example of PLIC contexts?

interrupts-extended = <
				&cpu0_intc 0xffffffff
				&cpu1_intc 0xffffffff &cpu1_intc 9
				&cpu2_intc 0xffffffff &cpu2_intc 9
				&cpu3_intc 0xffffffff &cpu3_intc 9
				&cpu4_intc 0xffffffff &cpu4_intc 9>;
Oct 8 2019, 6:02 PM
br updated the summary of D12875: HWPMC tracing support (1) -- main.
Oct 8 2019, 3:45 PM
br updated the diff for D15092: HWPMC tracing support (6) -- pmctrace main.
  • Infer the tracing device based on compiler architecture (PT on amd64, Coresight on aarch64)
  • Document all the pmctrace usage flags
Oct 8 2019, 3:36 PM
br added a comment to D21927: plic: fix context calculation.

I was looking at Linux driver before writing this one. Why don't they do the same ?

Oct 8 2019, 1:38 PM
br added a comment to D21940: plic: handle renumbered harts.

hart ID is recorded to pcpup->pc_hart. Could it be used ? i.e. PCPU_GET(hart) or pcpu_find(cpu)->pc_hart

Oct 8 2019, 1:34 PM
br accepted D21926: RISC-V: Fix an alignment warning in libthr.
Oct 8 2019, 1:01 PM

Oct 7 2019

br added inline comments to D15091: HWPMC tracing support (5) -- Intel PT.
Oct 7 2019, 4:28 PM
br updated the summary of D12875: HWPMC tracing support (1) -- main.
Oct 7 2019, 4:22 PM
br created D21920: HWPMC tracing support (9) -- libpmcstat.
Oct 7 2019, 4:20 PM
br updated the diff for D15095: HWPMC tracing support (8) -- pmctrace ARM Coresight.

Regenerate patch.

Oct 7 2019, 4:17 PM
br updated the diff for D15094: HWPMC tracing support (7) -- pmctrace Intel PT.

Regenerate patch.

Oct 7 2019, 4:17 PM
br updated the diff for D15092: HWPMC tracing support (6) -- pmctrace main.

Regenerate patch.

Oct 7 2019, 4:17 PM
br updated the diff for D15091: HWPMC tracing support (5) -- Intel PT.

Regenerate patch.

Oct 7 2019, 4:17 PM
br updated the diff for D15090: HWPMC tracing support (4) -- ARM Coresight.

Regenerate patch.

Oct 7 2019, 4:16 PM
br updated the diff for D15088: HWPMC tracing support (3) -- libpmc.

Regenerate patch.

Oct 7 2019, 4:16 PM
br updated the diff for D15089: HWPMC tracing support (2) -- VM.

Regenerate patch.

Oct 7 2019, 4:16 PM
br updated the diff for D12875: HWPMC tracing support (1) -- main.

Regenerate patch.

Oct 7 2019, 4:15 PM

Sep 27 2019

br accepted D21684: Fix compiler_rt definition for RISC-V.

Thanks!

Sep 27 2019, 1:11 PM

Sep 18 2019

br committed rS352487: Add support for BERI statcounters..
Add support for BERI statcounters.
Sep 18 2019, 4:13 PM

Sep 13 2019

br committed rS352302: Add support for Intel Stratix 10 platform..
Add support for Intel Stratix 10 platform.
Sep 13 2019, 4:51 PM
br closed D21454: [new driver] Intel Stratix10 (S10) quad-core ARM64 and FPGA fabric..
Sep 13 2019, 4:51 PM
br committed rS352301: Add generic arm/arm64 secure-monitor SMCCC interface and switch.
Add generic arm/arm64 secure-monitor SMCCC interface and switch
Sep 13 2019, 3:56 PM
br closed D21439: Generic SMCCC.
Sep 13 2019, 3:56 PM

Sep 9 2019

br accepted D21537: csu: Add the riscv .init call sequence.
Sep 9 2019, 4:19 PM

Sep 7 2019

br accepted D21538: riscv: Ensure that BSS is 8-byte aligned.

I discussed with James Clarke jrtc27, it is fine

Sep 7 2019, 2:24 PM

Sep 6 2019

br added a comment to D21439: Generic SMCCC.

Can you update the psci code to use the arm_smccc_* functions? We should only have one copy the functions to make smccc calls and you can consider psci to be based on it.

Sep 6 2019, 3:13 PM