Page MenuHomeFreeBSD

br (Ruslan Bukin)
User

Projects

User Details

User Since
Nov 27 2014, 10:57 AM (443 w, 3 d)

Recent Activity

Apr 14 2023

br accepted D39557: netlink: make netlink work correctly on CHERI..
Apr 14 2023, 3:40 PM

Apr 11 2023

br accepted D39496: Remove the riscv64sf architecture..
Apr 11 2023, 11:07 AM

Mar 27 2023

br committed rG27c8d4851c15: Include Embedded Trace Extensions (ETE) source code to the OpenCSD build. (authored by br).
Include Embedded Trace Extensions (ETE) source code to the OpenCSD build.
Mar 27 2023, 4:11 PM
br committed rG46e6e290975f: Import OpenCSD v.1.4.0. (authored by br).
Import OpenCSD v.1.4.0.
Mar 27 2023, 4:05 PM
br committed rG974000f192f9: Update OpenCSD to v1.4.0. (authored by br).
Update OpenCSD to v1.4.0.
Mar 27 2023, 3:46 PM
br requested review of D39286: update opencsd.
Mar 27 2023, 11:17 AM

Mar 17 2023

br accepted D39088: arm: Remove SOCFPGA specific kernel configs.

Well one of these boards are still on my desk, but I guess I could have a local config for it as we are using it for development only

Mar 17 2023, 12:32 PM

Feb 15 2023

br updated the summary of D38606: coresight update.
Feb 15 2023, 2:05 PM
br requested review of D38606: coresight update.
Feb 15 2023, 2:04 PM

Feb 6 2023

br added a comment to D37797: Mechanically convert if_xae(4) to DrvAPI.

I am fine with mechanical convert of APIs in this driver

Feb 6 2023, 8:19 PM

Jan 5 2023

br accepted D37953: arm64: Move device scmi to std.arm.
Jan 5 2023, 11:21 AM

Dec 21 2022

br committed rGdc08d52d1ed9: smmu: fix FDT and !FDT builds. (authored by br).
smmu: fix FDT and !FDT builds.
Dec 21 2022, 3:55 PM
br closed D37762: Fix arm64 iommu build.
Dec 21 2022, 3:55 PM
br closed D37756: IOMMU guest VA space fix.
Dec 21 2022, 3:54 PM
br committed rG4b4e8cb53abc: smmu: set guest address space range to 48-bit, which is a hardware (authored by br).
smmu: set guest address space range to 48-bit, which is a hardware
Dec 21 2022, 3:54 PM
br updated the diff for D37762: Fix arm64 iommu build.

context

Dec 21 2022, 2:41 PM
br updated the diff for D37762: Fix arm64 iommu build.

fix !FDT build

Dec 21 2022, 2:41 PM
br updated the summary of D37756: IOMMU guest VA space fix.
Dec 21 2022, 2:38 PM
br updated the diff for D37756: IOMMU guest VA space fix.

Use 48-bit address space regardless of VAX bit

Dec 21 2022, 2:38 PM

Dec 20 2022

br requested review of D37762: Fix arm64 iommu build.
Dec 20 2022, 8:25 PM
br updated the diff for D37756: IOMMU guest VA space fix.

set maxaddr correctly in tag and domain->end

Dec 20 2022, 8:23 PM
br updated the summary of D37756: IOMMU guest VA space fix.
Dec 20 2022, 7:40 PM
br added a comment to D37756: IOMMU guest VA space fix.

it does not seem to work with 52 bit

+       if (sc->features & SMMU_FEATURE_VAX)
+               iodom->end = MAXADDR_52BIT;
+       else
+               iodom->end = MAXADDR_48BIT;
Dec 20 2022, 4:29 PM
br requested review of D37756: IOMMU guest VA space fix.
Dec 20 2022, 11:28 AM

Dec 19 2022

br committed rG54b96380f577: Add support for ARM System Control and Management Interface (SCMI) v3.1. (authored by br).
Add support for ARM System Control and Management Interface (SCMI) v3.1.
Dec 19 2022, 10:31 PM
br closed D37316: SCMI support.
Dec 19 2022, 10:31 PM
br updated the diff for D37316: SCMI support.

ARM Doorbell:

Dec 19 2022, 9:17 PM
br updated the diff for D37316: SCMI support.

Forgot to re-generate patch

Dec 19 2022, 8:58 PM
br updated the diff for D37316: SCMI support.

Address Manu's comments on ARM Doorbell:
o Release resources on detach
o Free cells in error paths
o Remove unneeded M_DOORBELL

Dec 19 2022, 8:56 PM
br updated the diff for D37316: SCMI support.

Move MMIO-SRAM device to dev/sram. Add SCMI related devices to config.

Dec 19 2022, 8:30 PM

Dec 14 2022

br added a comment to D37316: SCMI support.
In D37316#857228, @manu wrote:

Still thinks that mmio_sram should be elsewhere, it's not firmware related and not arm (tm) specific.

Dec 14 2022, 1:57 PM
br updated the diff for D37316: SCMI support.

Fix "optional" arguments.

Dec 14 2022, 1:54 PM

Dec 13 2022

br updated the diff for D37316: SCMI support.

Address @manu's comments. Thanks!

Dec 13 2022, 5:27 PM
br added a comment to D37316: SCMI support.
In D37316#856924, @br wrote:
In D37316#855385, @manu wrote:

I don't think that this should live under sys/arm64/scmi.
I have sys/dev/firmware/xilinx coming soon-ish, and I think that all firmware related drivers should be under sys/dev/firmware so maybe put this under sys/dev/firmware/arm/

That directory contains 23-25 y.o. source code and a README file for FreeBSD 5x.
@andrew what do you think where SCMI code should live ?

Dec 13 2022, 4:53 PM
br added a comment to D37316: SCMI support.
In D37316#855385, @manu wrote:

I don't think that this should live under sys/arm64/scmi.
I have sys/dev/firmware/xilinx coming soon-ish, and I think that all firmware related drivers should be under sys/dev/firmware so maybe put this under sys/dev/firmware/arm/

Dec 13 2022, 4:52 PM

Dec 6 2022

br added a comment to D37613: arm64: intel: Remove firmware driver.

The stratix10 drivers has to be updated to use ofw_firmware bus instead of firmware bus in DRIVER_MODULE macroses.

Dec 6 2022, 1:56 PM
br updated the diff for D37316: SCMI support.

o Fix length check;
o Switch to ofw_firmware bus.

Dec 6 2022, 1:55 PM
br added a comment to D37612: ofw: Add a ofw_firmware driver.

Seems to work fine on ARM Morello:

Dec 6 2022, 1:52 PM
br added inline comments to D37316: SCMI support.
Dec 6 2022, 1:05 PM
br updated the diff for D37316: SCMI support.

o Make in_buf const;
o Remove unneeded casts;
o use len from OF_getencprop_alloc_multi().
o Remove firmware.c changes due to new firmware driver.

Dec 6 2022, 1:05 PM

Dec 5 2022

br updated the diff for D37316: SCMI support.

Restore firmware.c change.

Dec 5 2022, 5:27 PM
br updated the diff for D37316: SCMI support.

Change in/out buf data types.
Remove unrelated code from files.arm64.

Dec 5 2022, 5:26 PM

Nov 29 2022

br updated the summary of D37316: SCMI support.
Nov 29 2022, 3:16 PM
br updated the diff for D37316: SCMI support.

o Remove perf protocol for now.
o Rewrite protocols.h.
o Rename doorbell.c to arm_doorbell.c, mmio.c to mmio_sram.c

Nov 29 2022, 3:13 PM

Nov 22 2022

br added a comment to D37325: Add clk_list_freq() methods.
In D37325#849561, @mmel wrote:

I don't think this feature is appropriate for a generic layer. Practically no physical clock can implement it. A PLL can typically produce trillions of discrete frequencies, which makes it practically impossible to enumerate.

IMHO you should add it to scmi_clknode_methods as a custom function (with an appropriate prefix ) Simply create an .m file for the method definition and add this new method to the method table.

Nov 22 2022, 5:00 PM

Nov 10 2022

br added inline comments to D37316: SCMI support.
Nov 10 2022, 1:59 PM
br added a comment to D37316: SCMI support.

I think the extres changes should be split out to a new file.

Can you add scmi_ to the start of all the scmi files. The build system puts all the .o files in the same directory so we need to make sure the source files have a unique name.

Nov 10 2022, 1:58 PM
br requested review of D37325: Add clk_list_freq() methods.
Nov 10 2022, 1:30 PM
br updated the diff for D37316: SCMI support.

Use MAX_SETTINGS macro from cpu.h.
Split-out extres/clk changes.

Nov 10 2022, 1:26 PM

Nov 9 2022

br updated the diff for D37316: SCMI support.

add a check

Nov 9 2022, 4:49 PM
br requested review of D37316: SCMI support.
Nov 9 2022, 4:43 PM

Aug 30 2022

br added a comment to D36394: Include USB mouse driver.
In D36394#826604, @manu wrote:
In D36394#826540, @br wrote:

We don't have ums on amd64 either

I don't have any objection but it should be loaded automatically when a USB mouse is found?

My situation was that I have updated kernel, then noticed mouse is not working anymore.
I spent a day looking for a bug in DRM and purecap user graphical stack. Eventually found that my kernel driver module for mouse is not compatible with new kernel.

Because you didn't recompiled the modules perhaps ?
This is expected on current for any modules.
I don't see why we should include ums in GENERIC, we already have too much stuff.

Aug 30 2022, 10:42 PM
br added a comment to D36394: Include USB mouse driver.

We don't have ums on amd64 either

I don't have any objection but it should be loaded automatically when a USB mouse is found?

Aug 30 2022, 12:34 PM
br requested review of D36394: Include USB mouse driver.
Aug 30 2022, 11:52 AM

Jul 6 2022

br added a comment to D35130: check if ctx created.

Will this be RFC'ed?

Jul 6 2022, 8:34 AM

Jun 24 2022

br accepted D35579: arm64/amd64: add options IOMMU to LINT.
Jun 24 2022, 9:11 AM

Jun 14 2022

br accepted D35487: iommu_gas: eliminate unneeded wrappers.
In D35487#804790, @alc wrote:
In D35487#804780, @br wrote:

The idea of these wrappers was to abstract function names, i.e. make them looking generic by removing name "gas". I'm not sure what "gas" stands for, but there is no such thing on arm64.

I believe that it stood for "guest address space".

I also considered renaming iommu_gas_map, etc. to iommu_map, etc., but that entailed more changes. Nonetheless, I would be happy to take that approach.

Jun 14 2022, 8:08 PM
br added a comment to D35487: iommu_gas: eliminate unneeded wrappers.

so with this I can use iommu_map() in my ARM Komeda display controller driver (part of cheribsd), not confusing anyone with 'gas'

Jun 14 2022, 7:12 PM
br added a comment to D35487: iommu_gas: eliminate unneeded wrappers.

The idea of these wrappers was to abstract function names, i.e. make them looking generic by removing name "gas". I'm not sure what "gas" stands for, but there is no such thing on arm64.

Jun 14 2022, 7:09 PM

Jun 10 2022

br added a comment to D35424: iommu_gas: pass size without page alignment.
In D35424#803934, @alc wrote:

Do we need the offset? We just need a mapping for the physical page the vm_page_t points to.

From what you've written, I would say, "No." We can simply pass 0 as the offset. Can you verify that the current patch works?

Jun 10 2022, 9:45 AM

May 18 2022

br committed rG41ce5498f8e6: Add OFW support to arm64's IOMMU framework. (authored by br).
Add OFW support to arm64's IOMMU framework.
May 18 2022, 1:19 PM
br committed rG182a69328da2: Fix stream table entry (STE) initialization and removal. (authored by br).
Fix stream table entry (STE) initialization and removal.
May 18 2022, 12:53 PM

May 10 2022

br committed rG1cb8e38e4b39: Code deduplication: use SID-getting functions in smmu_find(). (authored by br).
Code deduplication: use SID-getting functions in smmu_find().
May 10 2022, 3:21 PM

May 9 2022

br committed rGb7fca06bbf3f: Split-out SID-getting code to a separate functions. (authored by br).
Split-out SID-getting code to a separate functions.
May 9 2022, 7:14 PM
br committed rGf224006fe1b3: Allocate resources selectively. (authored by br).
Allocate resources selectively.
May 9 2022, 12:35 PM
br committed rG0a8e88fa7303: Change __unused to __diagused. (authored by br).
Change __unused to __diagused.
May 9 2022, 10:28 AM

May 7 2022

br committed rGa5ec261a7c57: Add FDT attachment driver for ARM System MMU v3.2 controller. (authored by br).
Add FDT attachment driver for ARM System MMU v3.2 controller.
May 7 2022, 10:21 AM
br committed rG7d0bbf43fd3b: Change iommu list lock to SX as we need a sleepable lock so we (authored by br).
Change iommu list lock to SX as we need a sleepable lock so we
May 7 2022, 10:21 AM
br committed rG59446e8ac008: Fix !INVARIANTS build. (authored by br).
Fix !INVARIANTS build.
May 7 2022, 9:46 AM
br closed D35130: check if ctx created.
May 7 2022, 9:29 AM
br committed rG8b8e56dd5bc7: Check if iommu ctx is valid before passing it to functions. (authored by br).
Check if iommu ctx is valid before passing it to functions.
May 7 2022, 9:29 AM
br committed rG6ff004272a1e: Return error code from IOMMU_MAP and fix build. (authored by br).
Return error code from IOMMU_MAP and fix build.
May 7 2022, 9:26 AM
br closed D35129: Add a PCI method for mapping IOMMU.
May 7 2022, 9:22 AM
br committed rGb7672a70256b: Add OFW_IOMMU id type for pci_get_id() so we can ask parent IOMMU (authored by br).
Add OFW_IOMMU id type for pci_get_id() so we can ask parent IOMMU
May 7 2022, 9:22 AM

May 6 2022

br updated the diff for D35129: Add a PCI method for mapping IOMMU.

rename PCI_ID_IOMMU to PCI_ID_OWF_IOMMU

May 6 2022, 6:54 PM
br updated the diff for D35129: Add a PCI method for mapping IOMMU.

remove committed part

May 6 2022, 6:35 PM
br committed rG0c0bfa0f6f2f: Fix ofw_bus_iommu_map() since there is no limit on amount of maps (authored by br).
Fix ofw_bus_iommu_map() since there is no limit on amount of maps
May 6 2022, 5:11 PM
br committed rG0b6bacc7874f: Add ofw_bus_iommu_map() that maps PCI requester ID to an IOMMU (authored by br).
Add ofw_bus_iommu_map() that maps PCI requester ID to an IOMMU
May 6 2022, 3:52 PM
br updated the diff for D35129: Add a PCI method for mapping IOMMU.

Reuse pci_get_id() method, just add IOMMU id type.

May 6 2022, 10:03 AM

May 5 2022

br added a reviewer for D35129: Add a PCI method for mapping IOMMU: PCI.
May 5 2022, 11:13 AM
br requested review of D35130: check if ctx created.
May 5 2022, 10:57 AM
br updated the diff for D35129: Add a PCI method for mapping IOMMU.

context added

May 5 2022, 10:57 AM
br requested review of D35129: Add a PCI method for mapping IOMMU.
May 5 2022, 10:50 AM

Mar 10 2022

br requested review of D34519: rman resource kvaddr_t.
Mar 10 2022, 6:02 PM

Feb 25 2022

br added inline comments to D34370: graphics/mesa-dri: Add panfrost driver for arm64.
Feb 25 2022, 7:52 PM

Feb 15 2022

br updated the summary of D34262: Import DRM for ARM and ARM64.
Feb 15 2022, 10:02 AM

Feb 14 2022

br updated the diff for D34262: Import DRM for ARM and ARM64.

Remove cdns_i2c from files

Feb 14 2022, 3:05 PM
br updated the summary of D34262: Import DRM for ARM and ARM64.
Feb 14 2022, 12:52 PM
br added reviewers for D34262: Import DRM for ARM and ARM64: mmel, manu.
Feb 14 2022, 12:49 PM
br added a comment to D34262: Import DRM for ARM and ARM64.

Where did this come from? (i.e. which git tree).

Are we expecting to continue development in FreeBSD, or should it be considered contrib code & be a vendor import?

Feb 14 2022, 12:48 PM

Feb 13 2022

br updated the test plan for D34262: Import DRM for ARM and ARM64.
Feb 13 2022, 8:19 PM
br requested review of D34262: Import DRM for ARM and ARM64.
Feb 13 2022, 8:12 PM

Nov 5 2021

br added inline comments to D32691: GIC: add IRQ ranges.
Nov 5 2021, 5:43 PM
br accepted D32854: hwpmc: initialize arm64 counter/interrupt state.

good job

Nov 5 2021, 5:14 PM

Nov 2 2021

br closed D24423: arm/pmu: add ACPI attachment.
Nov 2 2021, 7:51 PM · arm64
br committed rG4bb6991531b5: arm/pmu: add ACPI attachment. (authored by br).
arm/pmu: add ACPI attachment.
Nov 2 2021, 7:51 PM
br updated the diff for D24423: arm/pmu: add ACPI attachment.

Fix typo.

Nov 2 2021, 7:30 PM · arm64

Oct 27 2021

br updated the diff for D24423: arm/pmu: add ACPI attachment.

Collect all PPIs since they indeed could be different on different CPUs

Oct 27 2021, 8:13 PM · arm64
br updated the diff for D24423: arm/pmu: add ACPI attachment.

Fix bug: Initialize cpuid to -1.
Also for PPI we need just one resource, so stop iteration over ACPI tables if PMU PPI interrupt found.

Oct 27 2021, 7:53 PM · arm64
br added a comment to D24423: arm/pmu: add ACPI attachment.

Was it intentional you reverted MAX_RLEN back to 8?

Oct 27 2021, 12:19 PM · arm64