- User Since
- Jun 19 2014, 6:57 AM (247 w, 5 d)
Thu, Mar 14
And again now that I've joined iflib...
Thu, Feb 28
Fri, Feb 22
Feb 15 2019
Feb 14 2019
FILTER_SCHEDULE_THREAD is a flag, not a discrete value. If it's set, schedule the
gtask and return FILTER_HANDLED.
Return FILTER_HANDLED rather than FILTER_SCHEDULE_THREAD when gtask (potentially) scheduled
Some bits of the upstream patch didn't paply cleanly... added manually.
Put the result variable back in. *facepalm*
Unpack the conditional for easier reading.
Remove unrelated stuff.
Looks good to me.
Feb 5 2019
Feb 4 2019
I love everything about this. If you plan to use the summary as the commit message though you should modify "change the M_NOWAIT from malloc(9) calls into M_NOWAIT." bit to mention M_WAITOK.
Jan 28 2019
Looks good. This may also fix where bar == -1 && pci_msix_count(dev) == 0 (or break it less... or something)
I think that the inability to map an MSI-X table should likely not be bootverbose... this is an allocation failure which will significantly impact device performance. While the user should know that MSI-X is disabled, I'm not sure the user should be expected to know that the allocation will fail.
Jan 25 2019
No objections, though I do agree with cem@ in principle regarding putting it in the GENERICs. When 3rd-party drivers start relying on it, it would violate POLA removing Intel NICs from the kernel would break a 3rd-party driver. For now it's likely "fine".
Jan 18 2019
Jan 17 2019
So the basic goal is to have the test at sys/net/if_ethersubr.c:583 see a consistent state of the changes from the /* Change the interface type */ line to the lagg_proto_addport() line.
Jan 16 2019
RLOCK() before setting ifp->if_type
Jan 15 2019
Jan 14 2019
Jan 11 2019
Jan 8 2019
Jan 7 2019
My only concern here is making IFLIB_MAX_RX_SEGS available to the driver...
Looks good, only a tiny nitpick on the fail label.
Dec 27 2018
Dec 20 2018
In addition to trying to keep the TXQ full, use a mp_ring size that's half the
number of descriptors. Previously, the mp_ring was a fixed size which happened
to be twice the default size of the txq for my em devices.
Dec 18 2018
Dec 14 2018
Remove the drain limit completely and instead try to fill the TX queue on each drain.
Dec 12 2018
Dec 11 2018
Dec 5 2018
I didn't think this code was still in use... AFAIK, ixgbe uses the iflib netmap support now.
Dec 3 2018
Nov 28 2018
Nov 21 2018
Nov 19 2018
Nov 14 2018
Nov 13 2018
Nov 12 2018
Nov 9 2018
Nov 8 2018
Restore setting ip_csum to zero for TSO when IFLIB_TSO_INIT_IP is set.
There is an upcoming patch that will make the IXL_CSUM_IPV4 macro obsolete, but better to fix it at both ends anyway.
Nov 7 2018
Nov 6 2018
Nov 2 2018
Move setting CSUM_IP_TCP into the correct block. Also set CSUM_IP.
Nov 1 2018
Oct 29 2018
Oct 24 2018
Add missing semi-colon.
Add gtaskqueue_drain_locked() to hold common code for gtaskqueue_drain()
Oct 23 2018
Oct 22 2018
Oct 18 2018
Oct 17 2018
My opinion is that mtx_owned() would just make this all more complex. Releasing a lock for a short period isn't a problem at all.
Oct 11 2018
iflib_admin_intr_deferred() called with STATE_LOCK() in a few places.
Oct 9 2018
Oct 5 2018
Hrm, I don't think we can obtain CTX_LOCK() in those functions.
"Abandoning" because I put the wrong URL in the commit message.
Bah, sorry... looks like I just grabbed whatever URL I had open at the time. :(