shurd (Stephen Hurd)
User

Projects

User Details

User Since
Jun 19 2014, 6:57 AM (212 w, 4 d)

Recent Activity

Wed, Jul 11

shurd committed rP474421: Update to latest release, use preferred OpenSSL libs..
Update to latest release, use preferred OpenSSL libs.
Wed, Jul 11, 4:18 AM

Jun 11 2018

shurd added a comment to D15720: Assorted TSO fixes for em(4)/iflib(9) and dead code removal from em(4).

On the bottom line, a front-end driver has to supply both the maximum TSO size and the maximum DMA transfer size to iflib(9). The cleanest approach for that would be to have a separate member for the maximum DMA transfer size in struct if_softc_ctx.

Jun 11 2018, 11:27 PM
shurd committed rP472215: Much better way to ensure a UTF-8 CODESET in the locale.
Much better way to ensure a UTF-8 CODESET in the locale
Jun 11 2018, 10:57 PM
shurd committed rP472212: Fix unicode for 'C' locale..
Fix unicode for 'C' locale.
Jun 11 2018, 10:21 PM
shurd added a comment to D15720: Assorted TSO fixes for em(4)/iflib(9) and dead code removal from em(4).

I think that if the size of the DMA tag needs to be larger than the MACs max, iflib should handle that itself rather than have every driver need to add a non-obvious value for non-obvious reasons.

Jun 11 2018, 6:00 PM

Jun 8 2018

shurd committed rS334862: Remove tx task spinning added in r333686.
Remove tx task spinning added in r333686
Jun 8 2018, 9:49 PM

Jun 7 2018

shurd committed rP471932: Update to latest release.
Update to latest release
Jun 7 2018, 4:25 PM
shurd committed rP471931: Update to latest release..
Update to latest release.
Jun 7 2018, 4:24 PM

May 29 2018

shurd committed rS334358: iflib: mark irq allocation name parameter as constant.
iflib: mark irq allocation name parameter as constant
May 29 2018, 9:57 PM
shurd closed D15343: iflib: mark irq allocation name parameter as constant.
May 29 2018, 9:57 PM
shurd accepted D15343: iflib: mark irq allocation name parameter as constant.

Looks good.

May 29 2018, 9:52 PM
shurd accepted D15558: iflib: Record TCP checksum info in iflib for ixl(4).

lgtm

May 29 2018, 4:42 PM · Intel Networking

May 25 2018

shurd added a comment to D15558: iflib: Record TCP checksum info in iflib for ixl(4).

Looks good, but not forcing CSUM_TCP_IPV6 for TSO6 may need a closer look.

May 25 2018, 7:34 PM · Intel Networking

May 24 2018

shurd added inline comments to D15558: iflib: Record TCP checksum info in iflib for ixl(4).
May 24 2018, 7:13 PM · Intel Networking
shurd committed rS334178: MFC: r333792.
MFC: r333792
May 24 2018, 6:53 PM

May 16 2018

shurd committed rS333686: Work around lack of TX IRQs in iflib for netmap.
Work around lack of TX IRQs in iflib for netmap
May 16 2018, 9:03 PM
shurd closed D15455: Work around lack of TX queues in iflib for netmap.
May 16 2018, 9:03 PM
shurd created D15455: Work around lack of TX queues in iflib for netmap.
May 16 2018, 4:36 PM

May 15 2018

shurd committed rS333637: Check that ifma_protospec != NULL in inm_lookup.
Check that ifma_protospec != NULL in inm_lookup
May 15 2018, 4:55 PM
shurd closed D15440: Check that ifma_protospec != NULL in inm_lookup.
May 15 2018, 4:55 PM
shurd created D15440: Check that ifma_protospec != NULL in inm_lookup.
May 15 2018, 2:14 AM

May 14 2018

shurd committed rS333612: Replace rmlock with epoch in lagg.
Replace rmlock with epoch in lagg
May 14 2018, 8:06 PM
shurd closed D15355: lagg: Remove redundant rmlock.
May 14 2018, 8:06 PM
shurd updated the diff for D15355: lagg: Remove redundant rmlock.

Update patch to latest head

May 14 2018, 6:28 PM

May 11 2018

shurd closed D15393: Fix LORs in in*_leave_group().
May 11 2018, 9:42 PM
shurd committed rS333505: Fix LORs in in6?_leave_group().
Fix LORs in in6?_leave_group()
May 11 2018, 9:42 PM
shurd closed D15354: MFC iflib bugfixes.
May 11 2018, 8:40 PM
shurd committed rS333503: MFC r333329, r333366, r333373.
MFC r333329, r333366, r333373
May 11 2018, 8:40 PM
shurd committed rS333501: Fix mld6query(8) and add a new -g option.
Fix mld6query(8) and add a new -g option
May 11 2018, 7:37 PM
shurd closed D15384: Fix mld6query(8) and add a new -g option.
May 11 2018, 7:37 PM
shurd accepted D15347: Add support for cloning pseudo interfaces.

lgtm

May 11 2018, 7:26 PM
shurd updated the diff for D15393: Fix LORs in in*_leave_group().

Remove lagg fix

May 11 2018, 6:48 PM
shurd created D15393: Fix LORs in in*_leave_group().
May 11 2018, 6:47 PM

May 10 2018

shurd updated the diff for D15355: lagg: Remove redundant rmlock.

Use the new epoch based reclamation API. Now the hot paths will not
block at all, and the sx lock is used for the softc data.

May 10 2018, 7:48 PM
shurd updated the diff for D15384: Fix mld6query(8) and add a new -g option.

Leave the same group we joined.

May 10 2018, 5:23 PM
shurd added a reviewer for D15384: Fix mld6query(8) and add a new -g option: ume.

Add ume since he's the last one to actually touch this code (14 years ago).

May 10 2018, 5:09 PM
shurd created D15384: Fix mld6query(8) and add a new -g option.
May 10 2018, 5:06 PM

May 9 2018

shurd accepted D15365: simple preempt safe epoch API.
May 9 2018, 10:30 PM
shurd added a comment to D15365: simple preempt safe epoch API.

stlgtm

May 9 2018, 10:21 PM
shurd updated the diff for D15355: lagg: Remove redundant rmlock.

Destroy rm lock, clean up spurious changes.

May 9 2018, 9:49 PM
shurd added inline comments to D15355: lagg: Remove redundant rmlock.
May 9 2018, 9:41 PM
shurd updated the diff for D15355: lagg: Remove redundant rmlock.

Address feedback.

May 9 2018, 9:39 PM
shurd accepted D15365: simple preempt safe epoch API.

lgtm

May 9 2018, 7:39 PM
shurd added inline comments to D15365: simple preempt safe epoch API.
May 9 2018, 6:45 PM
shurd updated the diff for D15355: lagg: Remove redundant rmlock.

Use bool and true/false rather than _Bool and 1/0

May 9 2018, 5:26 PM

May 8 2018

shurd updated the diff for D15355: lagg: Remove redundant rmlock.

Protect against multiple slowpath entries.

May 8 2018, 10:43 PM
shurd updated the diff for D15355: lagg: Remove redundant rmlock.

Ressurect the rwlock, but only to protect the new sc_slowpath boolean.
If the slowpath is currently running, DELAY(1) until it's not. Still a
bit of a hack, but now it doesn't (shouldn't) cause LORs.

May 8 2018, 10:36 PM
shurd added a comment to D15355: lagg: Remove redundant rmlock.

Yeah, all the LAGG_RLOCK -> LAGG_SLOCK conversions need to be fixed up... right now it's a LOR generator for sure.

May 8 2018, 8:00 PM
shurd updated the diff for D15355: lagg: Remove redundant rmlock.

Rather than remove LAGG_WLOCK_ASSERT()s, convert to LAGG_XLOCK_ASSERT()

May 8 2018, 7:12 PM
shurd created D15355: lagg: Remove redundant rmlock.
May 8 2018, 6:55 PM
shurd added inline comments to D15347: Add support for cloning pseudo interfaces.
May 8 2018, 5:53 PM
shurd requested changes to D15343: iflib: mark irq allocation name parameter as constant.

Are there some bits missing from the review?


/usr/home/shurd/src/fbsd/sys/net/iflib.c:5308:92: error: passing 'const char *' to parameter of type 'char *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
err = iflib_irq_set_affinity(ctx, rman_get_start(irq->ii_res), type, qid, gtask, tqg, q, name);
^~~~
/usr/home/shurd/src/fbsd/sys/net/iflib.c:5215:72: note: passing argument to parameter 'name' here
struct grouptask *gtask, struct taskqgroup *tqg, void *uniq, char *name)
^
/usr/home/shurd/src/fbsd/sys/net/iflib.c:5356:72: error: passing 'const char *' to parameter of type 'char *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
err = iflib_irq_set_affinity(ctx, irq_num, type, qid, gtask, tqg, q, name);
^~~~
/usr/home/shurd/src/fbsd/sys/net/iflib.c:5215:72: note: passing argument to parameter 'name' here
struct grouptask *gtask, struct taskqgroup *tqg, void *uniq, char *name)
^
/usr/home/shurd/src/fbsd/sys/net/iflib.c:5376:1: error: conflicting types for 'iflib_legacy_setup'
iflib_legacy_setup(if_ctx_t ctx, driver_filter_t filter, void *filter_arg, int *rid, const char *name)
^
/usr/home/shurd/src/fbsd/sys/net/iflib.c:723:12: note: previous declaration is here
static int iflib_legacy_setup(if_ctx_t ctx, driver_filter_t filter, void *filterarg, int *rid, char *str);
^

May 8 2018, 5:24 PM
shurd closed D15300: iflib: print message when iflib_tx_structures_setup fails.
May 8 2018, 5:15 PM
shurd updated the diff for D15354: MFC iflib bugfixes.

Add r333373

May 8 2018, 5:15 PM
shurd committed rS333373: iflib: print message when iflib_tx_structures_setup fails.
iflib: print message when iflib_tx_structures_setup fails
May 8 2018, 5:15 PM
shurd added a reviewer for D15354: MFC iflib bugfixes: jacob.e.keller_intel.com.

Add Jacob Keller.333366

May 8 2018, 4:57 PM
shurd updated the diff for D15354: MFC iflib bugfixes.

Add r333366

May 8 2018, 4:56 PM
shurd committed rS333366: iflib: cleanup queues when iflib_device_register fail.
iflib: cleanup queues when iflib_device_register fail
May 8 2018, 4:56 PM
shurd closed D15299: iflib: cleanup queues when iflib_device_register fail.
May 8 2018, 4:56 PM
shurd updated subscribers of D15354: MFC iflib bugfixes.

Add erj@ as a subscriber as he's asked about MFCs.

May 8 2018, 4:37 PM
shurd created D15354: MFC iflib bugfixes.
May 8 2018, 4:36 PM
shurd resigned from D12487: Combine LROed mbufs for a single call to if_input().

There doesn't seem to be any will to move this forward, leaving review.

May 8 2018, 4:27 PM
shurd committed rS333364: MFC: r308728, r314369, r315243, r316026, r316581, r316616, r318359,.
MFC: r308728, r314369, r315243, r316026, r316581, r316616, r318359,
May 8 2018, 4:27 PM
shurd closed D15143: MFC bnxt changes to 11-STABLE.

committed as r333364.

May 8 2018, 4:25 PM
shurd added inline comments to D15347: Add support for cloning pseudo interfaces.
May 8 2018, 4:23 PM

May 7 2018

shurd committed rS333341: MFC r333253-r333254.
MFC r333253-r333254
May 7 2018, 11:10 PM
shurd committed rS333340: Direct commit to stable/11 to fix botched r333338.
Direct commit to stable/11 to fix botched r333338
May 7 2018, 10:33 PM
shurd committed rS333338: Merge iflib changes to 11-STABLE.
Merge iflib changes to 11-STABLE
May 7 2018, 9:42 PM
shurd closed D15142: Merge iflib to 11-STABLE.
May 7 2018, 9:42 PM

May 4 2018

shurd committed rS333254: iflib: fix invalid free during queue allocation failure.
iflib: fix invalid free during queue allocation failure
May 4 2018, 3:20 PM
shurd closed D15285: iflib: fix invalid free during queue allocation failure.
May 4 2018, 3:20 PM
shurd closed D15284: iflib: remove unused brscp pointer from iflib_queues_alloc.
May 4 2018, 3:11 PM
shurd committed rS333253: iflib: remove unused brscp pointer from iflib_queues_alloc.
iflib: remove unused brscp pointer from iflib_queues_alloc
May 4 2018, 3:11 PM

May 3 2018

shurd added a comment to D12142: Don't start grouptaskqueue threads for unused grouptaskqueues.

May as well abandon it until/unless there's interest. I don't think there's much gain for the added complexity.

May 3 2018, 5:11 PM
shurd accepted D15218: Update iflibdd.9 to reflect the replacement of ifdi_queues_alloc with ifdi_{tx,rx}_queues_alloc.

lgtm

May 3 2018, 5:08 PM
shurd committed rS333218: Allow iflib NIC drivers to sleep rather than busy wait.
Allow iflib NIC drivers to sleep rather than busy wait
May 3 2018, 5:02 PM
shurd closed D14983: Allow NIC drivers to sleep rather than busy wait.
May 3 2018, 5:02 PM

May 2 2018

shurd added a comment to D14969: separate out list manipulation locking from state change in multicast.

Changes committed did not make it into this review due to issues updating Phabricator from a git source. See rS333175 for final version.

May 2 2018, 7:38 PM
shurd committed rS333175: Separate list manipulation locking from state change in multicast.
Separate list manipulation locking from state change in multicast
May 2 2018, 7:36 PM
shurd closed D14969: separate out list manipulation locking from state change in multicast.
May 2 2018, 7:36 PM
shurd accepted D15262: Add netdump hooks for iflib..

lgtm

May 2 2018, 5:11 PM
shurd added a comment to D14969: separate out list manipulation locking from state change in multicast.

SPARC and PowerPC get this:

May 2 2018, 4:11 PM
shurd added a comment to D14969: separate out list manipulation locking from state change in multicast.

Arm ports fail as well:


--- kernel.full ---
linking kernel.full
in_mcast.o: In function `inm_init':
/usr/home/admin/src/freebsd-base/sys/netinet/in_mcast.c:236: undefined reference to `iflib_config_gtask_init'
in6_mcast.o: In function `in6m_init':
/usr/home/admin/src/freebsd-base/sys/netinet6/in6_mcast.c:557: undefined reference to `iflib_config_gtask_init'
*** [kernel.full] Error code 1

May 2 2018, 6:17 AM
shurd requested changes to D14969: separate out list manipulation locking from state change in multicast.

Some universe build failures...

May 2 2018, 5:57 AM

May 1 2018

shurd accepted D14969: separate out list manipulation locking from state change in multicast.

LGTM

May 1 2018, 9:39 PM
shurd added inline comments to D15262: Add netdump hooks for iflib..
May 1 2018, 6:50 PM
shurd added inline comments to D15262: Add netdump hooks for iflib..
May 1 2018, 6:18 PM

Apr 30 2018

shurd accepted D15219: Add a manual page for iflib.9 so that man iflib is useful.

Looks good to me, waiting on @manpages approval.

Apr 30 2018, 3:52 PM

Apr 25 2018

shurd updated the diff for D15143: MFC bnxt changes to 11-STABLE.

Pull in man page changes as well.

Apr 25 2018, 9:48 PM

Apr 20 2018

shurd added a dependent revision for D15142: Merge iflib to 11-STABLE: D15143: MFC bnxt changes to 11-STABLE.
Apr 20 2018, 4:41 PM
shurd added a dependency for D15143: MFC bnxt changes to 11-STABLE: D15142: Merge iflib to 11-STABLE.
Apr 20 2018, 4:41 PM
shurd created D15143: MFC bnxt changes to 11-STABLE.
Apr 20 2018, 4:40 PM
shurd updated the diff for D15142: Merge iflib to 11-STABLE.

netmap nm_intr changes have not been MFCd to 11-STABLE yet

Apr 20 2018, 4:10 PM
shurd updated the diff for D15142: Merge iflib to 11-STABLE.

Looks like I missed r324318 in last update

Apr 20 2018, 3:57 PM
shurd updated the diff for D15142: Merge iflib to 11-STABLE.

Add unmerged bits of 312698 into iflib.c

Apr 20 2018, 3:31 PM
shurd created D15142: Merge iflib to 11-STABLE.
Apr 20 2018, 2:06 PM

Apr 18 2018

shurd committed rS332734: MFC r332388:.
MFC r332388:
Apr 18 2018, 6:45 PM
shurd committed rS332729: iflib: Fix queue distribution when there are no threads.
iflib: Fix queue distribution when there are no threads
Apr 18 2018, 3:34 PM
shurd closed D15120: Fix queue distribution when there are no threads.
Apr 18 2018, 3:34 PM

Apr 17 2018

shurd added a comment to D15120: Fix queue distribution when there are no threads.

Patch updated.

Apr 17 2018, 9:41 PM