Page MenuHomeFreeBSD

adrian (Adrian Chadd)
User

Projects

User Details

User Since
May 14 2014, 7:57 AM (354 w, 5 d)

Recent Activity

Today

adrian accepted D25999: lib80211: Start adding 11ac ETSI bits to regdomain.xml.

Yeah, you're right, I've been neck deep in linux and internal OS regulatory domain stuff too much recently :(

Mon, Mar 1, 4:09 PM

Yesterday

adrian added a comment to D25999: lib80211: Start adding 11ac ETSI bits to regdomain.xml.

Let's look at the maxpower more carefully!

Sun, Feb 28, 10:43 PM

Thu, Feb 25

adrian committed R10:547739cc003a: [ar71xx] Fix routerstation / routerstation pro redboot FIS probing (authored by adrian).
[ar71xx] Fix routerstation / routerstation pro redboot FIS probing
Thu, Feb 25, 9:16 PM

Jan 22 2021

adrian added a comment to R10:d5bd29ed505f: Revert "[mips] revert r366664 - flip mips back from -O2 to -O".

err? ok, let me go and re-revisit this again.

Jan 22 2021, 3:33 PM

Jan 14 2021

adrian committed R10:bd72252aace3: [mips] revert r366664 - flip mips back from -O2 to -O (authored by adrian).
[mips] revert r366664 - flip mips back from -O2 to -O
Jan 14 2021, 7:04 AM
adrian closed D28122: [mips] revert r366664 - flip mips back from -O2 to -O.
Jan 14 2021, 7:04 AM

Jan 13 2021

adrian added a comment to D28122: [mips] revert r366664 - flip mips back from -O2 to -O.

Seems fine to me, but I do wonder if this means that we have some UB that clang could also exploit in the future and generate crashing code. Any idea which function the first crash is inside?

Jan 13 2021, 5:18 PM
adrian accepted D28119: libifconfig: Add a symbol map.
Jan 13 2021, 1:01 AM
adrian updated the diff for D28122: [mips] revert r366664 - flip mips back from -O2 to -O.
  • Update to only do this with GCC
  • Add comment
Jan 13 2021, 12:47 AM
adrian closed D27958: [wpa] Add support for hostapd/wpa_supplicant when WITHOUT_CRYPT=YES is enabled..
Jan 13 2021, 12:44 AM
adrian committed R10:7c5a624afae4: [wpa] Add support for hostapd/wpa_supplicant when WITHOUT_CRYPT=YES (authored by adrian).
[wpa] Add support for hostapd/wpa_supplicant when WITHOUT_CRYPT=YES
Jan 13 2021, 12:44 AM

Jan 12 2021

adrian added a comment to D27958: [wpa] Add support for hostapd/wpa_supplicant when WITHOUT_CRYPT=YES is enabled..

(I haven't forgotten about this; I only just got mips32 to boot again...)

Jan 12 2021, 9:20 PM
adrian added a reviewer for D28122: [mips] revert r366664 - flip mips back from -O2 to -O: arichardson.
Jan 12 2021, 9:17 PM
adrian requested review of D28122: [mips] revert r366664 - flip mips back from -O2 to -O.
Jan 12 2021, 9:17 PM

Jan 4 2021

adrian added a reviewer for D27958: [wpa] Add support for hostapd/wpa_supplicant when WITHOUT_CRYPT=YES is enabled.: emaste.
Jan 4 2021, 8:48 PM
adrian requested review of D27958: [wpa] Add support for hostapd/wpa_supplicant when WITHOUT_CRYPT=YES is enabled..
Jan 4 2021, 8:48 PM

Jan 3 2021

adrian added a comment to D27778: emulators/qemu: Enable user networking by default.

hi!

In D27778#620891, @bofh wrote:

Also Question: do any of the other qemu-* ports need to have this change made too, or do they all inherit/child port off the main one (I haven't looked)

All qemu-* ports needs to be updated.

Can I just try to land this one first, and worry about the others later? I'd at least like to see a working qemu port with user networking available for other freebsd users to test with.

Sure, let's just follow this changeset up in a timely manner so all ports are consistent

Re PORTLINT output, these ones at least should be addressed:

WARN: Makefile: you may want directory for dependency sphinx-build to be textproc/py-sphinx@${PY_FLAVOR}
WARN: Makefile: "ONLY_FOR_ARCHS" has to appear earlier.
WARN: Makefile: "USES" has to appear earlier.
Jan 3 2021, 1:06 AM
adrian added a comment to D27778: emulators/qemu: Enable user networking by default.

Portlint output:

Jan 3 2021, 12:54 AM
adrian added a comment to D27778: emulators/qemu: Enable user networking by default.
In D27778#620891, @bofh wrote:

Also Question: do any of the other qemu-* ports need to have this change made too, or do they all inherit/child port off the main one (I haven't looked)

All qemu-* ports needs to be updated.

Jan 3 2021, 12:53 AM

Dec 30 2020

adrian closed D27814: [vale] Fix valectl to compile on a 32-bit platform.
Dec 30 2020, 6:44 PM
adrian committed R10:697684325da8: [vale] Fix valectl to compile on a 32-bit platform (authored by adrian).
[vale] Fix valectl to compile on a 32-bit platform
Dec 30 2020, 6:44 PM

Dec 29 2020

adrian added a reviewer for D27814: [vale] Fix valectl to compile on a 32-bit platform: rlibby.

ryan - I'll push this later today, but i figured you would want to see it as well :-)

Dec 29 2020, 11:18 PM
adrian added a reviewer for D27814: [vale] Fix valectl to compile on a 32-bit platform: vmaffione.
Dec 29 2020, 6:27 PM
adrian requested review of D27814: [vale] Fix valectl to compile on a 32-bit platform.
Dec 29 2020, 6:26 PM
adrian committed R10:66585c3fe278: [wlanwatch] fix compiler warnings-as-errors on gcc-6.4 mips (authored by adrian).
[wlanwatch] fix compiler warnings-as-errors on gcc-6.4 mips
Dec 29 2020, 6:26 PM
adrian committed R10:1fef838b913a: [wlanwds] Fix compiler warnings-as-errors on freebsd gcc-6.4 mips (authored by adrian).
[wlanwds] Fix compiler warnings-as-errors on freebsd gcc-6.4 mips
Dec 29 2020, 6:26 PM
adrian committed R10:ff7c2c5a3bc3: [wlanstats] Fix warnings-as-errors on gcc-6.4 on mips (authored by adrian).
[wlanstats] Fix warnings-as-errors on gcc-6.4 on mips
Dec 29 2020, 6:26 PM

Dec 27 2020

adrian updated the diff for D27778: emulators/qemu: Enable user networking by default.

Add portrevision

Dec 27 2020, 12:57 AM

Dec 26 2020

adrian requested review of D27778: emulators/qemu: Enable user networking by default.
Dec 26 2020, 10:58 PM

Dec 14 2020

adrian added a comment to D27608: [contrib/bc] Only use fallthrough on GCC's that support it.
In D27608#616994, @imp wrote:

Can you get this accepted upstream?

Dec 14 2020, 8:09 PM
adrian requested review of D27608: [contrib/bc] Only use fallthrough on GCC's that support it.
Dec 14 2020, 4:51 PM

Dec 13 2020

adrian committed R9:f550dea96441: Reviewed by: asmodai (authored by adrian).
Reviewed by: asmodai
Dec 13 2020, 7:44 PM
adrian committed R9:194a3a1bce6f: Removing myself from the Contributors section, and adding myself (authored by adrian).
Removing myself from the Contributors section, and adding myself
Dec 13 2020, 7:44 PM
adrian committed R9:7f10aed2b4d6: Move myself from alumni back into developers. (authored by adrian).
Move myself from alumni back into developers.
Dec 13 2020, 6:02 PM

Dec 10 2020

adrian accepted D26545: net80211: split up ieee80211_probereq().
Dec 10 2020, 12:59 PM

Dec 9 2020

adrian added a comment to D27505: Fix subinterface vlan creation..

@melifaro : Did you have any more time to look at this? I guess we need to be backwards compatible and possible need to have a pool allocation for all interface names starting with "vlan" only? Other interface names are excluded from the unit management.

Dec 9 2020, 9:09 PM

Dec 8 2020

adrian committed rS368451: [ath] also remove the magic size value here for the transmit antenna statistics..
[ath] also remove the magic size value here for the transmit antenna statistics.
Dec 8 2020, 5:28 PM
adrian committed rS368450: [ath] Don't use hard-coded values in the sanity check..
[ath] Don't use hard-coded values in the sanity check.
Dec 8 2020, 5:27 PM
adrian committed rS368449: [ath] replace the hard-coded magic values in if_athioctl.h with constant defines.
[ath] replace the hard-coded magic values in if_athioctl.h with constant defines
Dec 8 2020, 5:26 PM

Dec 3 2020

adrian closed D26839: [axgbe] fix compiler warnings when compiling using gcc-6.4.
Dec 3 2020, 4:55 PM
adrian committed rS368305: [axgbe] Fix compiler warnings in gcc-6.3; perhaps fix a PHY issue.
[axgbe] Fix compiler warnings in gcc-6.3; perhaps fix a PHY issue
Dec 3 2020, 4:55 PM

Nov 17 2020

adrian closed D26791: [nvmecontrol] Fix type signedness warning-to-error on gcc-6.4.
Nov 17 2020, 5:13 PM
adrian committed rS367771: [nvmecontrol] Fix type signedness warning-to-error on gcc-6.4.
[nvmecontrol] Fix type signedness warning-to-error on gcc-6.4
Nov 17 2020, 5:13 PM
adrian closed D27240: [zfs] Fix LZ4 function definitions to not trip up the compile.
Nov 17 2020, 5:11 PM
adrian committed rS367770: [cddl] Fix lz4 function definitions to not tri pup compile..
[cddl] Fix lz4 function definitions to not tri pup compile.
Nov 17 2020, 5:11 PM

Nov 16 2020

adrian requested review of D27240: [zfs] Fix LZ4 function definitions to not trip up the compile.
Nov 16 2020, 4:43 PM
adrian added a reviewer for D26791: [nvmecontrol] Fix type signedness warning-to-error on gcc-6.4: imp.
Nov 16 2020, 2:45 AM

Nov 13 2020

adrian updated the diff for D26791: [nvmecontrol] Fix type signedness warning-to-error on gcc-6.4.

Whoops, remove another cast

Nov 13 2020, 6:59 PM
adrian updated the diff for D26791: [nvmecontrol] Fix type signedness warning-to-error on gcc-6.4.

Updated to reduce casting and use better variable types

Nov 13 2020, 6:56 PM
adrian closed D26792: [tests] Fix "unused variable" warning-to-error on gcc-6.4.
Nov 13 2020, 6:50 PM
adrian committed rS367647: [tests] Fix unused variable warning in gcc.
[tests] Fix unused variable warning in gcc
Nov 13 2020, 6:50 PM
adrian updated the diff for D26792: [tests] Fix "unused variable" warning-to-error on gcc-6.4.

Update from markj

Nov 13 2020, 6:32 PM
adrian added inline comments to D26792: [tests] Fix "unused variable" warning-to-error on gcc-6.4.
Nov 13 2020, 5:53 PM
adrian added reviewers for D26792: [tests] Fix "unused variable" warning-to-error on gcc-6.4: kib, markj.
Nov 13 2020, 5:48 PM
adrian closed D27183: [malloc] quieten -Werror=missing-braces with malloc.h wth gcc-6.4.
Nov 13 2020, 1:54 AM
adrian committed rS367629: [malloc] quieten -Werror=missing-braces with malloc.h wth gcc-6.4.
[malloc] quieten -Werror=missing-braces with malloc.h wth gcc-6.4
Nov 13 2020, 1:54 AM

Nov 12 2020

adrian updated the diff for D27183: [malloc] quieten -Werror=missing-braces with malloc.h wth gcc-6.4.

update based on comment from brooks@

Nov 12 2020, 10:48 PM

Nov 11 2020

adrian requested review of D27183: [malloc] quieten -Werror=missing-braces with malloc.h wth gcc-6.4.
Nov 11 2020, 10:45 PM

Nov 4 2020

adrian added a comment to D27088: Add .cfi_{start,end}proc annotations for MIPS assembly.

Hm, wanna see if it compiles using gcc-6 instead? mips32 SHOULD compile now, as long as you disable ZFS.

Nov 4 2020, 8:06 PM
adrian added a comment to D27088: Add .cfi_{start,end}proc annotations for MIPS assembly.

Hm, how's this work on mips32? Has anyone spun this up in qemu on malta+mips32?

Nov 4 2020, 6:47 PM

Nov 2 2020

adrian closed D26790: [libnetmap] Fix 32 bit compilation on gcc-6.3.
Nov 2 2020, 3:01 PM
adrian committed rS367273: [libnetmap] Fix 32 bit compilation under gcc-6.4.
[libnetmap] Fix 32 bit compilation under gcc-6.4
Nov 2 2020, 3:01 PM
adrian updated the diff for D26790: [libnetmap] Fix 32 bit compilation on gcc-6.3.

Update with imp's comments

Nov 2 2020, 1:07 AM

Nov 1 2020

adrian closed D27046: fix compile issues on gcc-6.4.
Nov 1 2020, 9:18 PM
adrian committed rS367257: [ctld] Fix compilation under gcc-6.4.
[ctld] Fix compilation under gcc-6.4
Nov 1 2020, 9:18 PM
adrian added reviewers for D27046: fix compile issues on gcc-6.4: imp, trasz, rscheff.
Nov 1 2020, 8:57 PM
adrian requested review of D27046: fix compile issues on gcc-6.4.
Nov 1 2020, 8:57 PM
adrian closed D27036: [iscsictl] Fix compiler issues on gcc-6.4.
Nov 1 2020, 3:57 PM
adrian committed rS367248: [iscsictl] Fix compile issues that creep up with gcc-6.4.
[iscsictl] Fix compile issues that creep up with gcc-6.4
Nov 1 2020, 3:57 PM
adrian updated the diff for D27036: [iscsictl] Fix compiler issues on gcc-6.4.

Fix!

Nov 1 2020, 3:45 AM
adrian added a comment to D27036: [iscsictl] Fix compiler issues on gcc-6.4.

whoops brb

Nov 1 2020, 3:42 AM
adrian added reviewers for D27036: [iscsictl] Fix compiler issues on gcc-6.4: imp, trasz, rscheff.

hi! please lemme know what you think!

Nov 1 2020, 2:32 AM
adrian requested review of D27036: [iscsictl] Fix compiler issues on gcc-6.4.
Nov 1 2020, 2:31 AM

Oct 18 2020

adrian closed D26846: [zfs] don't include a non-existent include directory.
Oct 18 2020, 10:38 PM
adrian committed rS366818: [zfs] Remove a non-existent directory in the build infra.
[zfs] Remove a non-existent directory in the build infra
Oct 18 2020, 10:38 PM
adrian added reviewers for D26846: [zfs] don't include a non-existent include directory: kevans, imp.
Oct 18 2020, 9:39 PM
adrian requested review of D26846: [zfs] don't include a non-existent include directory.
Oct 18 2020, 9:38 PM
adrian added a comment to D26839: [axgbe] fix compiler warnings when compiling using gcc-6.4.

who has test hardware that can test this and report back?

Oct 18 2020, 9:34 PM
adrian added a comment to D25793: 10Gigabit Ethernet driver for AMD SoC.

I've fixed the warnings here - https://reviews.freebsd.org/D26839

Oct 18 2020, 6:22 PM
adrian added reviewers for D26839: [axgbe] fix compiler warnings when compiling using gcc-6.4: manu, network.
Oct 18 2020, 6:21 PM
adrian added reviewers for D26839: [axgbe] fix compiler warnings when compiling using gcc-6.4: kevans, andrew.
Oct 18 2020, 5:35 PM
adrian requested review of D26839: [axgbe] fix compiler warnings when compiling using gcc-6.4.
Oct 18 2020, 5:35 PM
adrian closed D26774: [llvm] Use 32 bit atomic on freebsd mips.
Oct 18 2020, 5:31 PM
adrian committed rS366814: [libcxx] Fix atomic type for mips32 on gcc to work w/out needing libatomic.
[libcxx] Fix atomic type for mips32 on gcc to work w/out needing libatomic
Oct 18 2020, 5:31 PM

Oct 16 2020

adrian accepted D26712: net80211: update for (more) VHT160 support.
Oct 16 2020, 6:48 PM
adrian closed D26804: [gnuregex] Fix size demotion rounding errors that have crept up with later gcc.
Oct 16 2020, 2:28 PM
adrian committed rS366765: This fixes some fun type size truncation that shows up giving errors like.
This fixes some fun type size truncation that shows up giving errors like
Oct 16 2020, 2:28 PM

Oct 15 2020

adrian updated the diff for D26804: [gnuregex] Fix size demotion rounding errors that have crept up with later gcc.
  1. Updating D26804: [gnuregex] Fix size demotion rounding errors that have crept up with later gcc #
  2. Enter a brief description of the changes included in this update.
  3. The first line is used as subject, next lines as comment.
Oct 15 2020, 8:06 PM
adrian requested review of D26804: [gnuregex] Fix size demotion rounding errors that have crept up with later gcc.
Oct 15 2020, 8:00 PM
adrian added inline comments to D26794: [openzfs] Fix compilation under gcc for freebsd.
Oct 15 2020, 3:06 PM
adrian added a comment to D26790: [libnetmap] Fix 32 bit compilation on gcc-6.3.
  • it fails on 32 bit compilations and we don't special case libnetmap to only compile on 64 bit platforms
  • it fails on 64 bit platforms when compiling lib32, which blocks the amd64 buildworld
  • since nr_options is a uint64_t and we're using it as a pointer type, we really should not be assuming pointer == sizeof(int type) like this
Oct 15 2020, 3:01 PM
adrian closed D26795: [pfctl_tests] Add missing void to empty function declaration.
Oct 15 2020, 2:57 PM
adrian committed rS366728: [pfctl_tests] Add missing void to empty function declaration.
[pfctl_tests] Add missing void to empty function declaration
Oct 15 2020, 2:57 PM
adrian closed D26789: [tests] Fix itimer test warning-errors on gcc-6.4.
Oct 15 2020, 2:55 PM
adrian committed rS366727: [tests] Fix itimer test warning-errors on gcc-6.4.
[tests] Fix itimer test warning-errors on gcc-6.4
Oct 15 2020, 2:55 PM
adrian requested review of D26795: [pfctl_tests] Add missing void to empty function declaration.
Oct 15 2020, 4:52 AM
adrian retitled D26793: [posixshm_test] Fix unused variable errors and unsigned check errors on gcc-6.4 from [posixshm_test] add missing void in function decl to [posixshm_test] Fix unused variable errors and unsigned check errors on gcc-6.4.
Oct 15 2020, 4:52 AM
adrian requested review of D26794: [openzfs] Fix compilation under gcc for freebsd.
Oct 15 2020, 4:49 AM
adrian requested review of D26793: [posixshm_test] Fix unused variable errors and unsigned check errors on gcc-6.4.
Oct 15 2020, 4:47 AM
adrian requested review of D26792: [tests] Fix "unused variable" warning-to-error on gcc-6.4.
Oct 15 2020, 4:46 AM