Page MenuHomeFreeBSD

adrian (Adrian Chadd)
User

Projects

User Details

User Since
May 14 2014, 7:57 AM (581 w, 3 d)

Recent Activity

Yesterday

adrian accepted D51163: net80211: regdomain: ETSI: add missing 11a and 11na entries.
Sat, Jul 5, 3:20 AM

Wed, Jun 25

adrian accepted D50608: uftdi.4: Makeover!.
Wed, Jun 25, 5:07 AM

Tue, Jun 24

adrian accepted D50503: bridge: add vlan filtering support.
Tue, Jun 24, 5:38 AM

Fri, Jun 20

adrian accepted D50944: bsdinstall: Emit a warning if the system has too little memory.
Fri, Jun 20, 6:54 PM

Thu, Jun 19

adrian accepted D50944: bsdinstall: Emit a warning if the system has too little memory.

oh and heh, maybe add what the minimum should be in the dialog, so people don't have to guess?

Thu, Jun 19, 8:19 PM
adrian added a comment to D50944: bsdinstall: Emit a warning if the system has too little memory.

I'd at least put a comment into here as to why we've chosen this. Eg, what I just asked about in IRC and you said "pkgbase OOM's on 256mb RAM".

Thu, Jun 19, 7:51 PM
adrian accepted D50542: mtw: fix display of the MAC revision.
Thu, Jun 19, 4:18 AM

Wed, Jun 18

adrian accepted D50923: net80211: in ieee80211_sta_join() only do_ht if HT is avail.
Wed, Jun 18, 10:10 PM
adrian added a comment to D50923: net80211: in ieee80211_sta_join() only do_ht if HT is avail.

Heh we've both hit a couple of fun paths into this (see https://reviews.freebsd.org/D50794 as well)

Wed, Jun 18, 10:10 PM

Wed, Jun 11

adrian added a reviewer for D50794: net80211: don't dereference a NULL HTINFO IE if it's presented: wireless.
Wed, Jun 11, 6:20 PM · wireless
adrian requested review of D50794: net80211: don't dereference a NULL HTINFO IE if it's presented.
Wed, Jun 11, 6:19 PM · wireless
adrian accepted D50789: wlan_gcmp.4: add man page.
Wed, Jun 11, 3:30 PM
adrian added a reviewer for D50787: net80211: fix VHT node setup in hostap mode: wireless.
Wed, Jun 11, 5:08 AM · wireless
adrian requested review of D50787: net80211: fix VHT node setup in hostap mode.
Wed, Jun 11, 5:06 AM · wireless

Tue, Jun 10

adrian requested review of D50772: net80211: convert the rest of the native net80211 drivers to SEQNO_OFFLOAD.
Tue, Jun 10, 4:26 AM
adrian requested review of D50771: usb: update wifi drivers to use IEEE80211_FEXT_SEQNO_OFFLOAD.
Tue, Jun 10, 4:25 AM

Mon, Jun 9

adrian added inline comments to D50691: net80211: update ieee80211_output_seqno_assign() to 802.11-2020.
Mon, Jun 9, 2:25 AM · wireless
adrian added a reviewer for D50747: run: enable seqno offload: wireless.
Mon, Jun 9, 2:18 AM · wireless
adrian added a reviewer for D50749: rsu: enable seqno offload: wireless.
Mon, Jun 9, 2:18 AM · wireless
adrian added a reviewer for D50748: rsu: implement A-MPDU TX; add TODO items for further work: wireless.
Mon, Jun 9, 2:17 AM · wireless
adrian requested review of D50749: rsu: enable seqno offload.
Mon, Jun 9, 2:14 AM · wireless
adrian requested review of D50748: rsu: implement A-MPDU TX; add TODO items for further work.
Mon, Jun 9, 2:13 AM · wireless
adrian requested review of D50747: run: enable seqno offload.
Mon, Jun 9, 2:13 AM · wireless
adrian updated the diff for D50691: net80211: update ieee80211_output_seqno_assign() to 802.11-2020.

re-add missing multicast check, thanks bz!

Mon, Jun 9, 12:16 AM · wireless
adrian added inline comments to D50691: net80211: update ieee80211_output_seqno_assign() to 802.11-2020.
Mon, Jun 9, 12:04 AM · wireless

Sun, Jun 8

adrian accepted D50677: net80211: LinuxKPI: migrate HE defines to net80211, put correct values.
Sun, Jun 8, 11:29 PM
adrian accepted D50676: net80211: LinuxKPI: migrate HE IE structs from LinuxKPI to net80211.
Sun, Jun 8, 11:28 PM
adrian added inline comments to D50691: net80211: update ieee80211_output_seqno_assign() to 802.11-2020.
Sun, Jun 8, 11:09 PM · wireless
adrian updated the diff for D50691: net80211: update ieee80211_output_seqno_assign() to 802.11-2020.

fix the seqno update routines to wrap things appropriately.
This bit me when doing some work on if_rsu

Sun, Jun 8, 12:41 AM · wireless

Sat, Jun 7

adrian accepted D50678: ifconfig: 802.11: decode more information elements (IEs).
Sat, Jun 7, 2:44 PM
adrian accepted D50675: ifconfig: 802.11: decode RSNXE IE.
Sat, Jun 7, 2:44 PM
adrian accepted D50555: ifconfig: 802.11: factor out keyix printing.
Sat, Jun 7, 2:43 PM
adrian accepted D50554: ifconfig: 802.11: print node unicast key (PTK) if available in STA mode.
Sat, Jun 7, 2:42 PM
adrian accepted D50553: ifconfig: 802.11: also print IEEE80211_CIPHER_AES_GCM_128 information.
Sat, Jun 7, 2:42 PM

Fri, Jun 6

adrian updated the diff for D50694: iwx: enable seqno offload.

Address bz's comment - yup, this works with seqno offload and
with it just not populated in the driver encap path. Neat!

Fri, Jun 6, 9:25 PM · wireless
adrian accepted D50690: sound: Retire SND_DEV_*.

I assume it just works fine? :-)

Fri, Jun 6, 3:08 PM

Jun 5 2025

adrian closed D50644: net80211: migrate direct printf() to ieee80211_printf().
Jun 5 2025, 6:48 PM · wireless
adrian added inline comments to D50694: iwx: enable seqno offload.
Jun 5 2025, 2:34 PM · wireless
adrian added a comment to D50692: net80211: add support for sequence number offloading.

Note: my hope is to eventually delete the TX lock entirely; this sets the ground work to first experiment and test various drivers in this stack.

Jun 5 2025, 4:43 AM · wireless
adrian added a reviewer for D50694: iwx: enable seqno offload: thj.
Jun 5 2025, 4:42 AM · wireless
adrian added a reviewer for D50694: iwx: enable seqno offload: wireless.
Jun 5 2025, 4:41 AM · wireless
adrian requested review of D50694: iwx: enable seqno offload.
Jun 5 2025, 3:51 AM · wireless
adrian added a reviewer for D50693: rtwn: enable seqno offload: wireless.
Jun 5 2025, 12:49 AM · wireless
adrian requested review of D50693: rtwn: enable seqno offload.
Jun 5 2025, 12:48 AM · wireless
adrian added a reviewer for D50692: net80211: add support for sequence number offloading: wireless.
Jun 5 2025, 12:20 AM · wireless
adrian requested review of D50692: net80211: add support for sequence number offloading.
Jun 5 2025, 12:19 AM · wireless

Jun 4 2025

adrian added a reviewer for D50691: net80211: update ieee80211_output_seqno_assign() to 802.11-2020: wireless.
Jun 4 2025, 9:51 PM · wireless
adrian requested review of D50691: net80211: update ieee80211_output_seqno_assign() to 802.11-2020.
Jun 4 2025, 9:50 PM · wireless
adrian accepted D50621: mman: Reserve two PROT_ for CHERI use.
Jun 4 2025, 4:22 PM
adrian committed rGa233c71650a1: net80211: remove if_private.h from code that doesn't require it (authored by adrian).
net80211: remove if_private.h from code that doesn't require it
Jun 4 2025, 3:45 AM
adrian committed rG2a1beace07f1: net80211: convert ieee80211_mesh.c to not require if_private.h (authored by adrian).
net80211: convert ieee80211_mesh.c to not require if_private.h
Jun 4 2025, 3:45 AM
adrian closed D50645: net80211: convert ieee80211_mesh.c to not require if_private.h.
Jun 4 2025, 3:45 AM · wireless
adrian committed rG674362e27015: net80211: migrate direct printf() to net80211_printf() (authored by adrian).
net80211: migrate direct printf() to net80211_printf()
Jun 4 2025, 3:45 AM
adrian committed rG1a3c03d88aaf: net80211: migrate if_printf() -> net80211_vap_printf() (authored by adrian).
net80211: migrate if_printf() -> net80211_vap_printf()
Jun 4 2025, 3:45 AM
adrian closed D50646: net80211: remove if_private.h from code that doesn't require it.
Jun 4 2025, 3:45 AM · wireless
adrian committed rG0861daf511dc: net80211: create net80211_vap_printf() / net80211_ic_printf() for printing (authored by adrian).
net80211: create net80211_vap_printf() / net80211_ic_printf() for printing
Jun 4 2025, 3:44 AM
adrian closed D50643: net80211: migrate if_printf() -> ieee80211_vap_printf().
Jun 4 2025, 3:44 AM · wireless
adrian closed D50642: net80211: create ieee80211_vap_printf() / ieee80211_ic_printf() for printing.
Jun 4 2025, 3:44 AM · wireless
adrian accepted D50674: net80211: add the beginning of the extfield information elements (IE ext).
Jun 4 2025, 12:21 AM

Jun 3 2025

adrian added inline comments to D50674: net80211: add the beginning of the extfield information elements (IE ext).
Jun 3 2025, 10:34 PM
adrian accepted D50671: net80211: add more information elements (IEs) definitions.
Jun 3 2025, 10:23 PM
adrian committed rG36fcd52c2bd5: net80211: fix TKIP trailer trimming w/ no rx parameters given (authored by adrian).
net80211: fix TKIP trailer trimming w/ no rx parameters given
Jun 3 2025, 12:12 AM
adrian closed D50638: net80211: fix TKIP trailer trimming w/ no rx parameters given.
Jun 3 2025, 12:12 AM · wireless

Jun 2 2025

adrian updated the diff for D50644: net80211: migrate direct printf() to ieee80211_printf().

migrate prefix to net80211_

Jun 2 2025, 11:43 PM · wireless
adrian updated the diff for D50643: net80211: migrate if_printf() -> ieee80211_vap_printf().

rename prefix to net80211_

Jun 2 2025, 11:43 PM · wireless
adrian updated the diff for D50642: net80211: create ieee80211_vap_printf() / ieee80211_ic_printf() for printing.

use net80211_ prefix

Jun 2 2025, 11:42 PM · wireless
adrian updated the diff for D50638: net80211: fix TKIP trailer trimming w/ no rx parameters given.

update commit message (locally)

Jun 2 2025, 11:32 PM · wireless
adrian added a comment to D50642: net80211: create ieee80211_vap_printf() / ieee80211_ic_printf() for printing.
In D50642#1156201, @bz wrote:

So i was thinking if we can start using ieee80211 for standards things and use a net80211 prefix for our own stuff (at least for anything new or we change)?

Jun 2 2025, 9:17 PM · wireless
adrian added a reviewer for D50646: net80211: remove if_private.h from code that doesn't require it: wireless.
Jun 2 2025, 2:42 AM · wireless
adrian added a reviewer for D50645: net80211: convert ieee80211_mesh.c to not require if_private.h: wireless.
Jun 2 2025, 2:41 AM · wireless
adrian added a reviewer for D50644: net80211: migrate direct printf() to ieee80211_printf(): wireless.
Jun 2 2025, 2:41 AM · wireless
adrian added a reviewer for D50643: net80211: migrate if_printf() -> ieee80211_vap_printf(): wireless.
Jun 2 2025, 2:41 AM · wireless
adrian added a reviewer for D50642: net80211: create ieee80211_vap_printf() / ieee80211_ic_printf() for printing: wireless.
Jun 2 2025, 2:40 AM · wireless
adrian requested review of D50646: net80211: remove if_private.h from code that doesn't require it.
Jun 2 2025, 2:34 AM · wireless
adrian requested review of D50645: net80211: convert ieee80211_mesh.c to not require if_private.h.
Jun 2 2025, 2:34 AM · wireless
adrian requested review of D50644: net80211: migrate direct printf() to ieee80211_printf().
Jun 2 2025, 2:11 AM · wireless
adrian requested review of D50643: net80211: migrate if_printf() -> ieee80211_vap_printf().
Jun 2 2025, 2:11 AM · wireless
adrian requested review of D50642: net80211: create ieee80211_vap_printf() / ieee80211_ic_printf() for printing.
Jun 2 2025, 2:11 AM · wireless
adrian added a comment to D50638: net80211: fix TKIP trailer trimming w/ no rx parameters given.
In D50638#1156017, @bz wrote:

Need to check all the other places which may have changed implicit behaviour too and they all need the same comment,

Jun 2 2025, 2:09 AM · wireless
adrian updated the diff for D50638: net80211: fix TKIP trailer trimming w/ no rx parameters given.

update from bz; matches what's in CCMP

Jun 2 2025, 2:08 AM · wireless
adrian added a reviewer for D50638: net80211: fix TKIP trailer trimming w/ no rx parameters given: wireless.
Jun 2 2025, 12:17 AM · wireless
adrian requested review of D50638: net80211: fix TKIP trailer trimming w/ no rx parameters given.
Jun 2 2025, 12:15 AM · wireless

Jun 1 2025

adrian accepted D50597: ipfw: prefixlen segfault bugfix in nptv6.
Jun 1 2025, 3:35 AM
adrian added a comment to D50597: ipfw: prefixlen segfault bugfix in nptv6.

I think this looks fine. I'm personally not too worried about breaking things in ipfw to make them much cleaner/clearer/less error prone, as long as we document it in UPDATING.

Jun 1 2025, 3:34 AM

May 30 2025

adrian accepted D50602: kern: unix: raise POLLIN when the remote end has shutdown writes.
May 30 2025, 2:44 AM

May 29 2025

adrian accepted D50488: sound: Terminate stream properly when closing vchans.

tested on my MSI GE76 raider that was exhibiting this w/ firefox/pulseaudio; it no longer happens. Thanks!

May 29 2025, 1:58 AM

May 28 2025

adrian accepted D50576: if_vlan_var.h: fix value of DOT1Q_VID_MAX.
May 28 2025, 4:10 PM
adrian accepted D50386: snd_dummy: Make callout stopping more robust.
May 28 2025, 3:20 PM
adrian accepted D50462: if_iwx: use net80211 suspend and resume methods.

It's better than the status quo in -HEAD, so let's get it in and then churn some more on making it recover better!

May 28 2025, 3:29 AM

May 27 2025

adrian added a comment to D50555: ifconfig: 802.11: factor out keyix printing.

technically (cry) ucast will eventually be keyix 0 and keyix 1, but not the WEP/global slots. Aiee. :-)

May 27 2025, 9:34 PM
adrian added a comment to D50462: if_iwx: use net80211 suspend and resume methods.

This doesn't apply cleanly on -head, it requires D49827 first

May 27 2025, 12:15 AM

May 26 2025

adrian accepted D35694: Add ts(1) command.
May 26 2025, 9:31 PM
adrian added a comment to D50462: if_iwx: use net80211 suspend and resume methods.

I'm finally updating my GE76 w/ AX210 to test iwx and iwlwifi in -head out, so I'll have to apply this to actually get it to pass a suspend/resume pass. stay tuned!

May 26 2025, 3:21 AM

May 25 2025

adrian added a comment to D50483: Extended errors from kernel.

I'm still not a big fan of putting the strings in the kernel syscall ABI (as i guarantee someone's gonna end up writing stuff that depends upon the content of the strings!), but I /am/ a fan of how the kernel source is being updated with errors. We can at least grep for the macro use to see what they're doing, and they're a no-op if it's not compiled in.

May 25 2025, 5:46 PM
adrian accepted D50513: net80211: make sure to not start a BGSCAN if not enabled.
May 25 2025, 5:00 PM
adrian committed rG249f14c87fd5: net80211: remove direct references to ifp->if_xname (authored by adrian).
net80211: remove direct references to ifp->if_xname
May 25 2025, 3:25 PM
adrian committed rGed987e16887b: net80211: migrate if_flags, if_drvflags out of most source files (authored by adrian).
net80211: migrate if_flags, if_drvflags out of most source files
May 25 2025, 3:25 PM
adrian committed rGa278d11a60e0: net80211: refactor out ifp->if_broadcastaddr into ieee80211_freebsd.c (authored by adrian).
net80211: refactor out ifp->if_broadcastaddr into ieee80211_freebsd.c
May 25 2025, 3:25 PM
adrian committed rG3f6a84ffbf39: net80211: refactor the if_input call into ieee80211_vap_deliver_data() (authored by adrian).
net80211: refactor the if_input call into ieee80211_vap_deliver_data()
May 25 2025, 3:25 PM
adrian closed D50407: net80211: remove direct references to ifp->if_xname.
May 25 2025, 3:25 PM · wireless