Page MenuHomeFreeBSD

adrian (Adrian Chadd)
User

Projects (15)

User Details

User Since
May 14 2014, 7:57 AM (634 w, 6 d)

Recent Activity

Today

adrian added a comment to D58096: netinet6: fix ND link-layer address option layout for IPoIB.

@vinicius_ferrao.net.br I do not have IB devices so not able to test. Would you please test against stable/15 after I commit it ?

Hi @zlei, I've double checked and yes, everythinig was working. I was able to replicate the issue without the patch and them checking the fix after applying it and rebuilding the kernel.

Tue, Jul 14, 5:19 PM · network

Yesterday

adrian added inline comments to D58201: firewire: per-unit-directory child device support.
Mon, Jul 13, 2:20 AM · drivers, firewire

Sun, Jul 12

adrian added inline comments to D58201: firewire: per-unit-directory child device support.
Sun, Jul 12, 10:26 PM · drivers, firewire
adrian committed rGad91d47db306: bluetooth: signal devd on netgraph device events (authored by guest-charlesrocket).
bluetooth: signal devd on netgraph device events
Sun, Jul 12, 6:48 PM
adrian accepted D58196: usbdump: add -t to omit timestamps.
Sun, Jul 12, 5:42 PM
adrian committed rG4085d1991e2a: hidwacom: Add Wacom ExpressKey Remote driver (authored by guest-seuros).
hidwacom: Add Wacom ExpressKey Remote driver
Sun, Jul 12, 5:26 PM
adrian closed D56729: hidwacom: Add Wacom ExpressKey Remote driver.
Sun, Jul 12, 5:25 PM · USB
adrian accepted D56729: hidwacom: Add Wacom ExpressKey Remote driver.
Sun, Jul 12, 5:05 PM · USB
adrian added a comment to D56729: hidwacom: Add Wacom ExpressKey Remote driver.

It is fine as-is, we can rename it later if needs be.

Sun, Jul 12, 5:05 PM · USB
adrian committed rG23a6997e3071: fwdv: add AV/C DV capture driver for FireWire camcorders (authored by guest-seuros).
fwdv: add AV/C DV capture driver for FireWire camcorders
Sun, Jul 12, 3:36 PM
adrian committed rG7aa34e12c9e1: rge: fix multicast add/removal by using if_getdrvflags() (authored by adrian).
rge: fix multicast add/removal by using if_getdrvflags()
Sun, Jul 12, 3:36 PM
adrian closed D58122: fwdv: add AV/C DV capture driver for FireWire camcorders.
Sun, Jul 12, 3:36 PM · drivers, firewire
adrian accepted D58122: fwdv: add AV/C DV capture driver for FireWire camcorders.
Sun, Jul 12, 3:23 PM · drivers, firewire
adrian added a comment to D51865: libusb: capsicumize libusb.

So why are a whole lot of functions getting an fd added to them?

Sun, Jul 12, 3:08 PM
adrian added a comment to D52166: bhyve: implement single USB device passthrough support.

I wouldn't over-index on trying to get everything perfect and upstreamed before landing stuff here.

Sun, Jul 12, 2:49 PM
adrian accepted D58179: containers: Extend and improve the firewall section.
Sun, Jul 12, 12:08 AM

Sat, Jul 11

adrian added a comment to D58136: aq(4): drop errored RX frames instead of resetting the interface.

Good catch; I think we should add a TODO somewhere to extend iflib to handle temporary errors rather than the big hammer it has right now.

Sat, Jul 11, 6:40 PM · drivers
adrian added a reviewer for D58136: aq(4): drop errored RX frames instead of resetting the interface: drivers.
Sat, Jul 11, 6:39 PM · drivers
adrian accepted D58145: aq(4): expand and correct offloads, fix VLAN/multicast filtering.
Sat, Jul 11, 6:38 PM · drivers

Fri, Jul 10

adrian accepted D58104: FDT: implement fdt_ether_get_addr().
Fri, Jul 10, 2:39 PM
adrian added inline comments to D57862: containers: Add most of what normal users will need.
Fri, Jul 10, 1:23 AM

Thu, Jul 9

adrian accepted D58027: x86: add AMD RAPL MSR definitions to specialreg.h.
Thu, Jul 9, 6:43 PM
adrian added a comment to D58096: netinet6: fix ND link-layer address option layout for IPoIB.

we can merge it into stable/15 before its cut and/or ask the release manager to merge it from stable/15 to the release branch after its cut but before its released.

Thu, Jul 9, 2:35 PM · network
adrian added inline comments to D58109: fwisound: add Apple FireWire audio driver.
Thu, Jul 9, 2:17 PM · audio, drivers, firewire
adrian committed rGcd7b65080f2f: fwisound: add Apple FireWire audio driver (authored by guest-seuros).
fwisound: add Apple FireWire audio driver
Thu, Jul 9, 2:55 AM
adrian committed rGd128ddf32e87: fwcam: retry ISO enable after re-powering camera (authored by guest-seuros).
fwcam: retry ISO enable after re-powering camera
Thu, Jul 9, 2:55 AM
adrian committed rG56d4dee82de1: fwcam: defer ISO streaming to first read (authored by guest-seuros).
fwcam: defer ISO streaming to first read
Thu, Jul 9, 2:55 AM
adrian closed D58109: fwisound: add Apple FireWire audio driver.
Thu, Jul 9, 2:55 AM · audio, drivers, firewire
adrian closed D58101: fwcam: retry ISO enable after re-powering camera.
Thu, Jul 9, 2:55 AM · drivers, firewire
adrian closed D58100: fwcam: defer ISO streaming to first read.
Thu, Jul 9, 2:54 AM · drivers, firewire
adrian added inline comments to D58109: fwisound: add Apple FireWire audio driver.
Thu, Jul 9, 12:59 AM · audio, drivers, firewire
adrian added a project to D58109: fwisound: add Apple FireWire audio driver: audio.
Thu, Jul 9, 12:58 AM · audio, drivers, firewire
adrian accepted D58109: fwisound: add Apple FireWire audio driver.
Thu, Jul 9, 12:57 AM · audio, drivers, firewire
adrian accepted D58101: fwcam: retry ISO enable after re-powering camera.
Thu, Jul 9, 12:56 AM · drivers, firewire
adrian accepted D58100: fwcam: defer ISO streaming to first read.
Thu, Jul 9, 12:56 AM · drivers, firewire

Wed, Jul 8

adrian accepted D58106: ofw_pcib: add support for reading 'dma-ranges' property.
Wed, Jul 8, 9:03 PM
adrian accepted D58096: netinet6: fix ND link-layer address option layout for IPoIB.
Wed, Jul 8, 3:17 PM · network
adrian added a comment to D58096: netinet6: fix ND link-layer address option layout for IPoIB.

Oh this is a good catch! I was just about to put some cx6 NICs in some boxes here to test.

Wed, Jul 8, 6:04 AM · network
adrian added a reviewer for D58098: net80211: update drivers to allocate sequence numbers in the raw path: wireless.
Wed, Jul 8, 5:55 AM · wireless
adrian requested review of D58098: net80211: update drivers to allocate sequence numbers in the raw path.
Wed, Jul 8, 5:54 AM · wireless
adrian committed rG94f24c0ee239: fwcamctl: add control utility for fwcam(4) IIDC FireWire cameras (authored by guest-seuros).
fwcamctl: add control utility for fwcam(4) IIDC FireWire cameras
Wed, Jul 8, 5:43 AM
adrian committed rG84044a77a620: fwcam: write video mode registers before enabling ISO streaming (authored by guest-seuros).
fwcam: write video mode registers before enabling ISO streaming
Wed, Jul 8, 5:43 AM
adrian committed rG4e0fc4d44dc1: fwcam: set ISO speed from device link speed (authored by guest-seuros).
fwcam: set ISO speed from device link speed
Wed, Jul 8, 5:43 AM
adrian committed rGf4825e91cf77: fwcam: add dynamic resolution and frame rate support (authored by guest-seuros).
fwcam: add dynamic resolution and frame rate support
Wed, Jul 8, 5:43 AM
adrian committed rG4b3d03566821: fwohci: fix LPS delay, PHY_INT storm, and SID timeout recovery (authored by guest-seuros).
fwohci: fix LPS delay, PHY_INT storm, and SID timeout recovery
Wed, Jul 8, 5:43 AM
adrian closed D57914: fwcamctl: add control utility for fwcam(4) IIDC FireWire cameras.
Wed, Jul 8, 5:42 AM · firewire
adrian closed D58092: fwcam: write video mode registers before enabling ISO streaming.
Wed, Jul 8, 5:42 AM · drivers, firewire
adrian closed D58091: fwcam: set ISO speed from device link speed.
Wed, Jul 8, 5:42 AM · drivers, firewire
adrian closed D58090: fwcam: add dynamic resolution and frame rate support.
Wed, Jul 8, 5:42 AM · firewire, drivers
adrian closed D58033: fwohci: fix LPS delay, PHY_INT storm, and SID timeout recovery.
Wed, Jul 8, 5:42 AM · firewire, drivers

Tue, Jul 7

adrian accepted D57914: fwcamctl: add control utility for fwcam(4) IIDC FireWire cameras.
Tue, Jul 7, 8:45 PM · firewire
adrian accepted D58091: fwcam: set ISO speed from device link speed.

accepted; tested!

Tue, Jul 7, 8:44 PM · drivers, firewire
adrian accepted D58090: fwcam: add dynamic resolution and frame rate support.

tested; my camera only announces VGA resolution though!

Tue, Jul 7, 8:44 PM · firewire, drivers
adrian accepted D58033: fwohci: fix LPS delay, PHY_INT storm, and SID timeout recovery.

approved; tested locally

Tue, Jul 7, 8:42 PM · firewire, drivers
adrian added inline comments to D58092: fwcam: write video mode registers before enabling ISO streaming.
Tue, Jul 7, 8:41 PM · drivers, firewire
adrian added a project to D57914: fwcamctl: add control utility for fwcam(4) IIDC FireWire cameras: firewire.
Tue, Jul 7, 7:21 AM · firewire

Sun, Jul 5

adrian added a project to D58047: acpi: parse resources of not-present devices that are kept enabled: drivers.
Sun, Jul 5, 8:52 PM · drivers
adrian committed rG22ddc9eb1d7a: fwip: Fix M_PKTHDR loss in fwip_async_output broadcast path (authored by guest-seuros).
fwip: Fix M_PKTHDR loss in fwip_async_output broadcast path
Sun, Jul 5, 6:35 PM
adrian closed D57495: fwip: Fix M_PKTHDR loss in fwip_async_output broadcast path.
Sun, Jul 5, 6:34 PM · drivers, firewire

Fri, Jul 3

adrian committed rG830f690eb676: iwn: assign sequence number to raw transmit frames (authored by adrian).
iwn: assign sequence number to raw transmit frames
Fri, Jul 3, 11:13 PM
adrian added a comment to D58020: net80211: don't do_ht in sta_recv_mgmt without htcap/htinfo.

ugh ok why's do_ht being set when there's no htcap/htinfo fields.

Fri, Jul 3, 7:08 PM · wireless
adrian added reviewers for D58020: net80211: don't do_ht in sta_recv_mgmt without htcap/htinfo: wireless, bz.
Fri, Jul 3, 3:14 PM · wireless
adrian added a comment to D58020: net80211: don't do_ht in sta_recv_mgmt without htcap/htinfo.

oh good catch, I thought I had found all of these!

Fri, Jul 3, 3:14 PM · wireless
adrian added a comment to D52166: bhyve: implement single USB device passthrough support.

Hey, any further traction on this? What's left before it can be landed?

Fri, Jul 3, 12:01 AM

Wed, Jul 1

adrian accepted D57777: pmc: pmc record command.
Wed, Jul 1, 9:10 PM
adrian accepted D57776: pmc: new pmc log processing framework.
Wed, Jul 1, 9:10 PM
adrian accepted D57775: pmc: console configuration and table rendering for new PMC tools.
Wed, Jul 1, 9:10 PM
adrian accepted D57712: acpi: ignore wake button press replayed by firmware on resume.
Wed, Jul 1, 2:00 AM
adrian closed D57799: net80211: fix CCMP/GCMP AAD for MFP frames.
Wed, Jul 1, 12:21 AM · wireless
adrian committed rG126f82a3eb61: asmc: deduplicate sensor converters and cause sysctls (authored by guest-seuros).
asmc: deduplicate sensor converters and cause sysctls
Wed, Jul 1, 12:21 AM
adrian committed rGa2d087b67e14: net80211: fix CCMP/GCMP AAD for MFP frames (authored by adrian).
net80211: fix CCMP/GCMP AAD for MFP frames
Wed, Jul 1, 12:21 AM
adrian closed D57854: asmc: deduplicate sensor converters and cause sysctls.
Wed, Jul 1, 12:21 AM · drivers, apple (x86)
adrian committed rG6a1bd5212f29: asmc: add system state and board identity sysctls (authored by guest-seuros).
asmc: add system state and board identity sysctls
Wed, Jul 1, 12:21 AM
adrian closed D57853: asmc: add system state and board identity sysctls.
Wed, Jul 1, 12:20 AM · drivers, apple (x86)
adrian closed D57844: asmc: try PIO before MMIO to avoid false T2 detection.
Wed, Jul 1, 12:20 AM · apple (x86), drivers
adrian committed rGbb1e071be47f: asmc: try PIO before MMIO to avoid false T2 detection (authored by guest-seuros).
asmc: try PIO before MMIO to avoid false T2 detection
Wed, Jul 1, 12:20 AM
adrian accepted D57850: powerpc64le: define missing msun functions.
Wed, Jul 1, 12:17 AM · PowerPC

Tue, Jun 30

adrian added a member for pmc: adrian.
Tue, Jun 30, 6:30 PM
adrian accepted D57775: pmc: console configuration and table rendering for new PMC tools.
Tue, Jun 30, 6:29 PM
adrian accepted D57780: pmc: enable the new pmc commands.
Tue, Jun 30, 5:49 PM
adrian accepted D57779: pmc: pmc frontend stall analysis based on IBS.
Tue, Jun 30, 5:49 PM
adrian accepted D57778: pmc: pmc info command.
Tue, Jun 30, 5:40 PM
adrian added inline comments to D57777: pmc: pmc record command.
Tue, Jun 30, 5:40 PM
adrian added inline comments to D57776: pmc: new pmc log processing framework.
Tue, Jun 30, 5:35 PM
adrian added inline comments to D57775: pmc: console configuration and table rendering for new PMC tools.
Tue, Jun 30, 3:37 PM
adrian added a comment to D57850: powerpc64le: define missing msun functions.

ah i see, its from what steve kargl replied to the email thread with.

Tue, Jun 30, 1:39 AM · PowerPC

Mon, Jun 29

adrian added a comment to D57850: powerpc64le: define missing msun functions.

hm, have you done a universe build with these? whats the LDBL_MANT_DIG supposed to indicate? (eg is this ppc64le only or is this any platform wanting to do 128 bit long float?)

Mon, Jun 29, 11:13 PM · PowerPC

Sat, Jun 27

adrian accepted D57854: asmc: deduplicate sensor converters and cause sysctls.
Sat, Jun 27, 11:39 PM · drivers, apple (x86)
adrian accepted D57853: asmc: add system state and board identity sysctls.

looks good, will compile test it later before landing, thanks!

Sat, Jun 27, 11:11 PM · drivers, apple (x86)
adrian added inline comments to D57853: asmc: add system state and board identity sysctls.
Sat, Jun 27, 10:12 PM · drivers, apple (x86)
adrian added reviewers for D57853: asmc: add system state and board identity sysctls: apple (x86), drivers.
Sat, Jun 27, 8:31 PM · drivers, apple (x86)
adrian accepted D57844: asmc: try PIO before MMIO to avoid false T2 detection.
Sat, Jun 27, 8:30 PM · apple (x86), drivers
adrian added a comment to D57762: Reporting/debug path changed to display VHT80 and VHT160.

I think we should just create a function to return a static channel description for this. something like

Sat, Jun 27, 6:17 PM · wireless
adrian added inline comments to D57756: ixgbe: restore missed-packet accounting so input drops are visible.
Sat, Jun 27, 3:28 AM · drivers
adrian added a comment to D57850: powerpc64le: define missing msun functions.
In D57850#1327349, @fuz wrote:

This is a consequence of @pkubaj's PPC ABI change most likely.

Sat, Jun 27, 12:41 AM · PowerPC
adrian added a project to D57850: powerpc64le: define missing msun functions: PowerPC.
Sat, Jun 27, 12:39 AM · PowerPC

Fri, Jun 26

adrian accepted D57854: asmc: deduplicate sensor converters and cause sysctls.
Fri, Jun 26, 10:40 PM · drivers, apple (x86)
adrian added inline comments to D57853: asmc: add system state and board identity sysctls.
Fri, Jun 26, 10:40 PM · drivers, apple (x86)
adrian added inline comments to D57844: asmc: try PIO before MMIO to avoid false T2 detection.
Fri, Jun 26, 10:35 PM · apple (x86), drivers
adrian accepted D57662: CHERI: add mem{cpy,move}_data.
Fri, Jun 26, 2:45 PM