Page MenuHomeFreeBSD

adrian (Adrian Chadd)
User

Projects

User Details

User Since
May 14 2014, 7:57 AM (473 w, 7 h)

Recent Activity

Wed, May 31

adrian added a comment to D40356: netlink: use custom uma zone for the mbuf storage.

nice!

Wed, May 31, 9:17 PM
adrian accepted D40356: netlink: use custom uma zone for the mbuf storage.
Wed, May 31, 9:17 PM
adrian added a comment to D40348: netlink: retry mbuf allocation in different pool on failure.

I think having a separate dedicated allocator for netlink messages is the better call. Don't make your control plane reliant on your data plane's memory management.

Wed, May 31, 4:11 PM

Fri, May 26

adrian added a comment to D31119: games/lwjgl3: Lightweight Java Game Library 3.

ping! what's left before we can have a lwjgl3 port landed?

Fri, May 26, 3:46 AM

Apr 13 2023

adrian added a comment to D39476: net80211: wrong transmit MCS set in HT Capabilities IE.

oh wait err, i recall when bernard and i were debugging this in 2010/2011 time we found that "what the spec said" and "what devices actually needed because of bugs" were very different. so let's be careful with these.

(gosh I wish we had all of that in the commit logs or bug report logs somewhere..)

I think that adjusting to bugs of some devices in cost of contradicting to the standard for every device around is counter-productive, especially considering time which has passed since 2010.

What were consequences of these bugs and what were the vendors?

Apr 13 2023, 4:15 AM

Apr 12 2023

adrian added a comment to D39476: net80211: wrong transmit MCS set in HT Capabilities IE.

oh wait err, i recall when bernard and i were debugging this in 2010/2011 time we found that "what the spec said" and "what devices actually needed because of bugs" were very different. so let's be careful with these.

Apr 12 2023, 4:04 AM

Apr 10 2023

adrian added a comment to D39476: net80211: wrong transmit MCS set in HT Capabilities IE.

oh hm! good catch, let's see!

Apr 10 2023, 2:47 PM

Mar 24 2023

adrian accepted D39247: WPA: revert wpa_poststart.
Mar 24 2023, 2:38 PM

Mar 21 2023

adrian accepted D39192: ifconfig: ifieee80211: print bssid name.
Mar 21 2023, 9:41 PM

Mar 5 2023

adrian accepted D38893: net: unify mtu update code.
Mar 5 2023, 6:58 PM

Mar 3 2023

adrian added a comment to D38854: rtwn: Fix RTL8192EU cannot associate in STA mode.

i understand the fix, but the whole code layout for rtwn is to avoid the HW code knowing too much about the bus/transport.

Mar 3 2023, 1:44 AM

Feb 28 2023

adrian accepted D38832: net80211: define mask for ss_flags rather than using hardcoded 0xfff.
Feb 28 2023, 11:32 PM

Feb 18 2023

adrian accepted D38660: net80211: ieee80211_swscan_bg_scan() track return variable under lock.
Feb 18 2023, 5:17 PM

Feb 15 2023

adrian added a comment to D38508: net80211(4): fix the connection-fail problem in wpa_supplicant(8).

(also I thought we had a program somewhere in tools/tools/net80211 that would listen to the routing socket for all net80211 messages, to make debugging this easier? if not, we should write one :-)

Feb 15 2023, 5:16 PM · wireless
adrian added a comment to D38508: net80211(4): fix the connection-fail problem in wpa_supplicant(8).

iirc, and don't quote me on this, the "scan done + restart" stuff can happen when the software scanner is doing things like background scans (which break softmac 11n/11ac/etc devices, sigh, someone needs to employ me for 6 months to properly fix that for softmac devices already) it can start and stop a scan, push up scan results, but not complete it. background scans can be interrupted by active traffic, which means it'll try to do a piecemeal scan before pushing things up.

Feb 15 2023, 5:15 PM · wireless

Feb 8 2023

adrian committed rG2e9d05fd6848: asmc: Add support for 10 byte light sensor payloads; MacBookAir6,1 (authored by adrian).
asmc: Add support for 10 byte light sensor payloads; MacBookAir6,1
Feb 8 2023, 4:09 AM
adrian closed D38365: asmc: add support for 10 byte light sensor payloads.
Feb 8 2023, 4:09 AM

Feb 7 2023

adrian added a comment to D38365: asmc: add support for 10 byte light sensor payloads.

ok, try this one!

Feb 7 2023, 1:13 AM
adrian updated the diff for D38365: asmc: add support for 10 byte light sensor payloads.

oops

Feb 7 2023, 1:13 AM
adrian updated the diff for D38365: asmc: add support for 10 byte light sensor payloads.

corrections!

Feb 7 2023, 1:12 AM

Feb 3 2023

adrian added inline comments to D38365: asmc: add support for 10 byte light sensor payloads.
Feb 3 2023, 6:12 AM

Feb 2 2023

adrian updated the summary of D38365: asmc: add support for 10 byte light sensor payloads.
Feb 2 2023, 11:37 PM
adrian added a reviewer for D38365: asmc: add support for 10 byte light sensor payloads: markj.
Feb 2 2023, 11:30 PM
adrian requested review of D38365: asmc: add support for 10 byte light sensor payloads.
Feb 2 2023, 11:29 PM

Jan 21 2023

adrian committed rGffc58e2ca365: asmc: Add MacbookAir6,2 (authored by adrian).
asmc: Add MacbookAir6,2
Jan 21 2023, 4:44 AM
adrian closed D38073: [asmc] Add Macbook 6,2.
Jan 21 2023, 4:44 AM

Jan 19 2023

adrian updated the diff for D38073: [asmc] Add Macbook 6,2.

addressed nits

Jan 19 2023, 2:50 AM

Jan 16 2023

adrian added a reviewer for D38073: [asmc] Add Macbook 6,2: markj.
Jan 16 2023, 4:31 PM
adrian requested review of D38073: [asmc] Add Macbook 6,2.
Jan 16 2023, 5:37 AM

Dec 29 2022

adrian accepted D37900: asmc: Add support for MacBook5,5.

amusingly I'm actually neck deep in figuring it out for my macbook air, so sure. Why not. ;)

Dec 29 2022, 5:17 PM

Dec 27 2022

adrian added a comment to D37882: QCOM: various bits.

Thanks for the cleanup!

Dec 27 2022, 5:55 PM

Nov 29 2022

adrian accepted D37529: net80211: try to fix IEEE80211_DEBUG_REFCNT builds.
Nov 29 2022, 12:57 AM

Sep 27 2022

adrian added inline comments to D36615: net80211: clean up / add more macros to check the frame types.
Sep 27 2022, 12:39 AM

Sep 26 2022

adrian accepted D36733: net80211: move IEEE80211_F_WME check to vap for consistency.
Sep 26 2022, 9:49 PM

Sep 24 2022

adrian added inline comments to D36615: net80211: clean up / add more macros to check the frame types.
Sep 24 2022, 1:22 AM

Sep 22 2022

adrian added inline comments to D36615: net80211: clean up / add more macros to check the frame types.
Sep 22 2022, 3:18 AM

Sep 21 2022

adrian added inline comments to D36615: net80211: clean up / add more macros to check the frame types.
Sep 21 2022, 5:05 PM
adrian added a comment to D36615: net80211: clean up / add more macros to check the frame types.

They're all used in the ath10k driver port I'm working on. They're available in the linuxkpi for liinux drivers too :-)

Sep 21 2022, 2:40 PM
adrian accepted D36501: lio: Remove unneeded include..
Sep 21 2022, 5:18 AM

Sep 18 2022

adrian added a reviewer for D36615: net80211: clean up / add more macros to check the frame types: cy.
Sep 18 2022, 12:30 AM
adrian added reviewers for D36615: net80211: clean up / add more macros to check the frame types: wireless, bz.
Sep 18 2022, 12:29 AM
adrian requested review of D36615: net80211: clean up / add more macros to check the frame types.
Sep 18 2022, 12:29 AM

Sep 13 2022

adrian committed rG633d178c63be: qcom_qup: compilation fixes (authored by adrian).
qcom_qup: compilation fixes
Sep 13 2022, 3:11 AM
adrian committed rG82302a49fde3: qcom_tlmm: use return code instead of always returning true. (authored by adrian).
qcom_tlmm: use return code instead of always returning true.
Sep 13 2022, 3:11 AM
adrian committed rG3d9bd8252205: qcom_clk: compilation fixes (authored by adrian).
qcom_clk: compilation fixes
Sep 13 2022, 3:11 AM
adrian committed rGf060362adeb4: ipq4018: remove write-only variables in USB ehci/xhci bus glue (authored by adrian).
ipq4018: remove write-only variables in USB ehci/xhci bus glue
Sep 13 2022, 3:11 AM
adrian committed rGf05b3c9f4741: qcom_gcc: fix the parent clock to work again (authored by adrian).
qcom_gcc: fix the parent clock to work again
Sep 13 2022, 3:11 AM
adrian closed D36535: qcom_qup: compilation fixes.
Sep 13 2022, 3:11 AM
adrian closed D36534: qcom_tlmm: fix compiler errors, return error code.
Sep 13 2022, 3:11 AM
adrian closed D36533: qcom_clk: compilation fixes.
Sep 13 2022, 3:11 AM
adrian closed D36532: ipq4018: fix USB ehci/xhci bus glue to compile again.
Sep 13 2022, 3:11 AM
adrian closed D36531: qcom_gcc: fix the parent clock to work again.
Sep 13 2022, 3:11 AM

Sep 12 2022

adrian accepted D36543: stand: Stop support booting 4.x and earlier kernels.

i think it's fine to nuke it?

Sep 12 2022, 11:50 PM
adrian updated the diff for D36535: qcom_qup: compilation fixes.

update

Sep 12 2022, 6:31 PM
adrian updated the diff for D36534: qcom_tlmm: fix compiler errors, return error code.

update

Sep 12 2022, 6:31 PM
adrian updated the diff for D36533: qcom_clk: compilation fixes.

update

Sep 12 2022, 6:31 PM
adrian updated the diff for D36532: ipq4018: fix USB ehci/xhci bus glue to compile again.

update

Sep 12 2022, 6:31 PM
adrian updated the diff for D36531: qcom_gcc: fix the parent clock to work again.

update

Sep 12 2022, 6:31 PM
adrian updated the diff for D36535: qcom_qup: compilation fixes.

address comments from imp

Sep 12 2022, 6:28 PM
adrian updated the diff for D36531: qcom_gcc: fix the parent clock to work again.

update

Sep 12 2022, 6:28 PM
adrian requested review of D36535: qcom_qup: compilation fixes.
Sep 12 2022, 6:37 AM
adrian requested review of D36534: qcom_tlmm: fix compiler errors, return error code.
Sep 12 2022, 6:37 AM
adrian requested review of D36533: qcom_clk: compilation fixes.
Sep 12 2022, 6:37 AM
adrian requested review of D36532: ipq4018: fix USB ehci/xhci bus glue to compile again.
Sep 12 2022, 6:37 AM
adrian requested review of D36531: qcom_gcc: fix the parent clock to work again.
Sep 12 2022, 6:37 AM
adrian committed rG7d0e83c60bed: arm: add dwc3/xhci as build options for ARM (authored by adrian).
arm: add dwc3/xhci as build options for ARM
Sep 12 2022, 2:37 AM
adrian closed D36530: arm: add dwc3/xhci as build options for ARM.
Sep 12 2022, 2:37 AM
adrian requested review of D36530: arm: add dwc3/xhci as build options for ARM.
Sep 12 2022, 12:01 AM

Sep 3 2022

adrian accepted D36410: net80211: update (parts of) frame types and subtypes and annotate.
Sep 3 2022, 9:18 PM

Aug 17 2022

adrian accepted D36250: net80211: LinuxKPI 802.11: harmonize IEEE80211_VHT_MCS_*.
Aug 17 2022, 10:24 PM
adrian accepted D36249: net80211: consistently use the IEEE80211_M_ memory related options.
Aug 17 2022, 6:50 PM
adrian accepted D36245: net80211: ieee80211_ies_expand() add extra length check.

nice catch!

Aug 17 2022, 4:54 PM

Aug 15 2022

adrian accepted D35841: wtap(4): Implement IBSS mode on wtap(4).
Aug 15 2022, 12:34 AM · wireless
adrian added inline comments to D35841: wtap(4): Implement IBSS mode on wtap(4).
Aug 15 2022, 12:34 AM · wireless

Aug 14 2022

adrian added a comment to D35841: wtap(4): Implement IBSS mode on wtap(4).

hi! I think this looks ready to land, right?

Aug 14 2022, 9:02 PM · wireless
adrian closed D36183: net80211: add an IEEE80211_IS_PROTECTED() macro.
Aug 14 2022, 4:49 PM
adrian committed rG2889cbe29e30: net80211: add an IEEE80211_IS_PROTECTED() macro (authored by adrian).
net80211: add an IEEE80211_IS_PROTECTED() macro
Aug 14 2022, 4:49 PM

Aug 13 2022

adrian added a comment to D36183: net80211: add an IEEE80211_IS_PROTECTED() macro.

Presumably this results in identical object code?

Aug 13 2022, 2:53 AM

Aug 12 2022

adrian updated the diff for D36183: net80211: add an IEEE80211_IS_PROTECTED() macro.

Rebase

Aug 12 2022, 9:19 PM
adrian added reviewers for D36183: net80211: add an IEEE80211_IS_PROTECTED() macro: wireless, bz, cy.
Aug 12 2022, 9:01 PM
adrian requested review of D36183: net80211: add an IEEE80211_IS_PROTECTED() macro.
Aug 12 2022, 9:00 PM

Jul 29 2022

adrian accepted D35977: Series of small net80211 commits, mostly for VHT.

looks good!

Jul 29 2022, 1:41 AM
adrian added inline comments to D35977: Series of small net80211 commits, mostly for VHT.
Jul 29 2022, 1:40 AM

Jul 25 2022

adrian added a comment to D35841: wtap(4): Implement IBSS mode on wtap(4).

nice work!

Jul 25 2022, 3:16 PM · wireless

Jul 8 2022

adrian accepted D35751: wtap(4): Rename physical interface.

I wonder if this is how it used to be in the deep, distant past. ok, this is right!

Jul 8 2022, 3:42 PM · wireless
adrian accepted D35752: wtap(4): Fix bug in wtap_node_write() and wtap_vap_create().
Jul 8 2022, 3:41 PM · wireless
adrian added a comment to D35751: wtap(4): Rename physical interface.

why? it's designed to be used as an emulator / virtual 802.11 interface for building tests. :-) So it should be wlanX.

Jul 8 2022, 5:21 AM · wireless

Jul 7 2022

adrian accepted D35747: rc.subr: Make sure oomprotect protects existing children.

hey nice catch!

Jul 7 2022, 9:36 PM

May 6 2022

adrian added a comment to D34893: net80211: remove (optional) RSN from preobereq.

I think it's okay to remove it. Just make sure it doesn't break adhoc mode 11n rate "negotiation" stuff.

May 6 2022, 1:53 PM
adrian accepted D35135: net80211: simplify code after STA/AP VAPs traffic hang fix.
May 6 2022, 2:04 AM

Apr 22 2022

adrian committed rGe8de31caceaa: net80211: Fix traffic hang on STA/AP VAPs on a multi-VAP interface (authored by adrian).
net80211: Fix traffic hang on STA/AP VAPs on a multi-VAP interface
Apr 22 2022, 5:49 AM
adrian closed D34920: net80211: Fix traffic hang on STA/AP VAPs on a multi-VAP interface.
Apr 22 2022, 5:49 AM

Apr 17 2022

adrian added a comment to D34920: net80211: Fix traffic hang on STA/AP VAPs on a multi-VAP interface.

hi! see if those comment/commit updates help!

Apr 17 2022, 5:09 AM
adrian updated the diff for D34920: net80211: Fix traffic hang on STA/AP VAPs on a multi-VAP interface.

Take on comments from bz@

Apr 17 2022, 5:08 AM

Apr 15 2022

adrian added a comment to D34920: net80211: Fix traffic hang on STA/AP VAPs on a multi-VAP interface.
In D34920#791558, @bz wrote:

Was there a PR for this somewhere? If so, please mention that.

Apr 15 2022, 8:45 PM

Apr 14 2022

adrian updated the diff for D34920: net80211: Fix traffic hang on STA/AP VAPs on a multi-VAP interface.

link

Apr 14 2022, 7:41 PM
adrian added reviewers for D34920: net80211: Fix traffic hang on STA/AP VAPs on a multi-VAP interface: wireless, bz, imp.
Apr 14 2022, 7:40 PM
adrian requested review of D34920: net80211: Fix traffic hang on STA/AP VAPs on a multi-VAP interface.
Apr 14 2022, 7:39 PM

Mar 11 2022

adrian accepted D34531: teken: color #3 is yellow not brown - use TC_YELLOW as the name.
Mar 11 2022, 11:02 PM

Mar 9 2022

adrian accepted D34496: kern: net80211: export sta assoc/disassoc via devctl.
Mar 9 2022, 3:05 AM