Yeah, if we ever support pushing a list of receive frames into the net80211 stack, complete with rx status in the mbuf tags, then I think we can do this in net80211 quite nicely. :-)

I'm not a huge fan of this cause honestly we should be doing the epoch enter/exit around a batch.

ignore the pmc related bits, it's not relevant for this fix

Lol, who did that? :-)

Thanks! There's another _b.c file that isn't linked into the build yet that needs similar treatment.

The MS-SM stuff being defined half way through the code is left over from sam-days.

Oh yeah, good catch! We should also replace this with a define so we know how many max mcs streams is supported.

.. next to the existing node one

Let's make it more generic - and I thought it was - oh yeah! Look at ieee80211_get_node_txpower().

i like it! *ship*

Cool! Just fix the typo that idwer pointed out, but nice work

In D25630#569426, @imp wrote:

In D25630#569409, @neel_neelc.org wrote:

I think this broke the build on r363327 with if_an.

Maybe we should just retire wi and an? They are no longer relevant.

Updated from feedback

Take on comments from bz

the GPIO/i2c bits at first glance look ok.

In D25478#562806, @phk wrote:

Yeah, that's clearly an oversight.

In the original application this code came from, the write error propagated up and was used to register how many times the flash had been written.

That code did not become part of the fifolog_writer(1) program, which silently ignores the errors from fifolog_write_record_poll().

Wrapping in the lib code probably makes most sense in this stand alone usage of the code, but fifolog_writer(1) should also report write errors back.

I noticed we were off by one; the file size ended up being one record
longer than specified. This fixes it.

Oops - update comment. Thanks jude!

looks fine to me, other OSes won't use it but it won't matter. Land it!

ugh, only look at ieee80211_ht.c ; ignore the crypto changes. Whoops.

i remember there was some concern in the past where there were very bad rss key choices out there. is there a reason for actually pushing for a random rss key?