Page MenuHomeFreeBSD

adrian (Adrian Chadd)
User

Projects

User Details

User Since
May 14 2014, 7:57 AM (375 w, 4 d)

Recent Activity

Thu, Jul 22

adrian added a comment to D31263: bpf: Add an ioctl to set the VLAN Priority on packets sent by bpf.

net80211 has a whole chunk of things you can set when raw tx'ing frames via BPF. I think this is fine!

Thu, Jul 22, 6:32 AM

Mon, Jul 19

adrian accepted D31215: led: call led state functions in a context with no locks held.
In D31215#702999, @avg wrote:

@adrian , in my opinion two things guarantee correct operation:

  • the current element can never be removed (thanks to in_use)
  • an iteration is always done with the lock held

So, whatever perturbations might happen while the lock is dropped, they should settle down before the next iteration.

Mon, Jul 19, 7:54 PM
adrian added a comment to D31215: led: call led state functions in a context with no locks held.
In D31215#702973, @avg wrote:

@adrian , I thought that I took care of that via the in_use flag.
Could you please look again?

Mon, Jul 19, 6:19 PM
adrian added a comment to D31215: led: call led state functions in a context with no locks held.

in general I agree with "push it into a thread", especially since we want to support LED blinking on things like behind an i2c bus, but the unlock;func;lock thing without checking the list has changed or the LED itself has been deleted is problematic to me. Yes, sure, the race is tiny and it only affects things if we're modifying the list at the same time we're doing some work, but surely we can handle that case. :-) That's why it was locked in the first place!

Mon, Jul 19, 5:10 PM

Sat, Jul 3

adrian added a comment to D14290: gpiospi no delay support.

Oh I get it. DELAY(1) is delaying for one microsecond, which is too slow for what we're doing here.

Sat, Jul 3, 12:43 AM

Jun 18 2021

adrian accepted D30814: rtwn: make sure to not write in upper bits of txdseq.

Good catch!

Jun 18 2021, 4:11 PM
adrian accepted D30813: net80211: ieee80211_probereq_ie fix length calculation for hw scans.
Jun 18 2021, 2:01 PM

Jun 7 2021

adrian accepted D30678: an: Deprecate the driver.

nuke iiit

Jun 7 2021, 5:01 PM

Jun 5 2021

adrian accepted D30654: net80211: add a TX mbufq to ieee80211_node to be managed by drivers.
Jun 5 2021, 5:24 PM
adrian added a comment to D30654: net80211: add a TX mbufq to ieee80211_node to be managed by drivers.

Yeah, I was thinking the same thing. It gets a bit unfun when we start looking at how we drain this versus direct dispatch, but let's tackle that later.

Jun 5 2021, 5:23 PM
adrian accepted D30641: net80211/LinuxKPI: add more radiotap definitions.
Jun 5 2021, 1:37 AM

May 23 2021

adrian committed R10:c50346bcf5c5: ath: bump the default node queue size to 128 frames, not 64 (authored by adrian).
ath: bump the default node queue size to 128 frames, not 64
May 23 2021, 4:26 AM

May 22 2021

adrian committed R10:f858e9281c60: [ath] Handle STA + AP beacon programming without stomping over HW AP beacon… (authored by adrian).
[ath] Handle STA + AP beacon programming without stomping over HW AP beacon…
May 22 2021, 11:44 PM
adrian committed R10:079bd2e750ad: [athstats] Add some (but not all, sigh) missing statistics. (authored by adrian).
[athstats] Add some (but not all, sigh) missing statistics.
May 22 2021, 11:34 PM
adrian committed R10:da7f6e67901b: [athstats] Add a tag to listen for beacon stuff (authored by adrian).
[athstats] Add a tag to listen for beacon stuff
May 22 2021, 11:34 PM
adrian committed R10:1ca399682822: [ath] Add ast_tsfoor to the sysctl statistics array. (authored by adrian).
[ath] Add ast_tsfoor to the sysctl statistics array.
May 22 2021, 11:34 PM
adrian committed R10:114f4b17d5b6: [ar71xx] During reset, don't spin, just keep trying (authored by adrian).
[ar71xx] During reset, don't spin, just keep trying
May 22 2021, 10:54 PM

May 18 2021

adrian closed D1638: Add witness warning to callout_drain().
May 18 2021, 5:18 PM
adrian added a comment to D1638: Add witness warning to callout_drain().

Nah, this already landed a long long time ago.

May 18 2021, 5:18 PM
adrian added a comment to D1638: Add witness warning to callout_drain().

lol! this is old!

May 18 2021, 4:40 PM

Apr 20 2021

adrian accepted D29800: iwnstats: fix build with clang and allow install under /usr/local/sbin.
Apr 20 2021, 4:44 PM

Apr 19 2021

adrian committed R10:61c83c4e8b6f: [ath] Add ath_hal_getnav and ath_hal_setnav so the driver layer (authored by adrian).
[ath] Add ath_hal_getnav and ath_hal_setnav so the driver layer
Apr 19 2021, 6:00 AM
adrian committed R10:bed90bf8ed5c: [ath_hal] Add get/set NAV functions (authored by adrian).
[ath_hal] Add get/set NAV functions
Apr 19 2021, 5:54 AM
adrian committed R10:dead34f82219: [ath_hal] ar9300: save TSF across full chip reset (authored by adrian).
[ath_hal] ar9300: save TSF across full chip reset
Apr 19 2021, 5:50 AM

Mar 26 2021

adrian committed R10:b6fd00791f2b: [iwn] Flip over to use VAP flags rather than ic flags for things (authored by adrian).
[iwn] Flip over to use VAP flags rather than ic flags for things
Mar 26 2021, 1:27 AM
adrian closed D29379: [iwn] Flip over to use VAP flags rather than ic flags for things.
Mar 26 2021, 1:26 AM

Mar 24 2021

adrian accepted D29335: net80211: prefix get_random_bytes() with net80211_.
Mar 24 2021, 2:46 AM

Mar 23 2021

adrian accepted D29393: ifconfig: 80211, add line break after key info.
Mar 23 2021, 3:46 PM

Mar 22 2021

adrian added reviewers for D29379: [iwn] Flip over to use VAP flags rather than ic flags for things: bz, wireless.
Mar 22 2021, 4:54 PM
adrian requested review of D29379: [iwn] Flip over to use VAP flags rather than ic flags for things.
Mar 22 2021, 4:53 PM
adrian closed D29320: Add log() style versions of device_printf() and if_printf().
Mar 22 2021, 12:03 AM
adrian committed R10:25bfa448602c: Add device and ifnet logging methods, similar to device_printf / if_printf (authored by adrian).
Add device and ifnet logging methods, similar to device_printf / if_printf
Mar 22 2021, 12:03 AM

Mar 18 2021

adrian requested review of D29320: Add log() style versions of device_printf() and if_printf().
Mar 18 2021, 6:46 AM

Mar 14 2021

adrian accepted D29033: wlandebug.8: remove Xref for missing manpages.

i mean, ok, until i move them into base proper :-P

Mar 14 2021, 6:17 PM

Mar 13 2021

adrian committed R10:fb3edd4f3ff8: [ath] do a cold reset if TSFOOR triggers (authored by adrian).
[ath] do a cold reset if TSFOOR triggers
Mar 13 2021, 7:36 AM
adrian committed R10:51dfae383bf6: [ath] validate ts_antenna before updating tx statistics (authored by adrian).
[ath] validate ts_antenna before updating tx statistics
Mar 13 2021, 1:34 AM

Mar 1 2021

adrian accepted D25999: lib80211: Start adding 11ac ETSI bits to regdomain.xml.

Yeah, you're right, I've been neck deep in linux and internal OS regulatory domain stuff too much recently :(

Mar 1 2021, 4:09 PM

Feb 28 2021

adrian added a comment to D25999: lib80211: Start adding 11ac ETSI bits to regdomain.xml.

Let's look at the maxpower more carefully!

Feb 28 2021, 10:43 PM

Feb 25 2021

adrian committed R10:547739cc003a: [ar71xx] Fix routerstation / routerstation pro redboot FIS probing (authored by adrian).
[ar71xx] Fix routerstation / routerstation pro redboot FIS probing
Feb 25 2021, 9:16 PM

Jan 22 2021

adrian added a comment to R10:d5bd29ed505f: Revert "[mips] revert r366664 - flip mips back from -O2 to -O".

err? ok, let me go and re-revisit this again.

Jan 22 2021, 3:33 PM

Jan 14 2021

adrian committed R10:bd72252aace3: [mips] revert r366664 - flip mips back from -O2 to -O (authored by adrian).
[mips] revert r366664 - flip mips back from -O2 to -O
Jan 14 2021, 7:04 AM
adrian closed D28122: [mips] revert r366664 - flip mips back from -O2 to -O.
Jan 14 2021, 7:04 AM

Jan 13 2021

adrian added a comment to D28122: [mips] revert r366664 - flip mips back from -O2 to -O.

Seems fine to me, but I do wonder if this means that we have some UB that clang could also exploit in the future and generate crashing code. Any idea which function the first crash is inside?

Jan 13 2021, 5:18 PM
adrian accepted D28119: libifconfig: Add a symbol map.
Jan 13 2021, 1:01 AM
adrian updated the diff for D28122: [mips] revert r366664 - flip mips back from -O2 to -O.
  • Update to only do this with GCC
  • Add comment
Jan 13 2021, 12:47 AM
adrian closed D27958: [wpa] Add support for hostapd/wpa_supplicant when WITHOUT_CRYPT=YES is enabled..
Jan 13 2021, 12:44 AM
adrian committed R10:7c5a624afae4: [wpa] Add support for hostapd/wpa_supplicant when WITHOUT_CRYPT=YES (authored by adrian).
[wpa] Add support for hostapd/wpa_supplicant when WITHOUT_CRYPT=YES
Jan 13 2021, 12:44 AM

Jan 12 2021

adrian added a comment to D27958: [wpa] Add support for hostapd/wpa_supplicant when WITHOUT_CRYPT=YES is enabled..

(I haven't forgotten about this; I only just got mips32 to boot again...)

Jan 12 2021, 9:20 PM
adrian added a reviewer for D28122: [mips] revert r366664 - flip mips back from -O2 to -O: arichardson.
Jan 12 2021, 9:17 PM
adrian requested review of D28122: [mips] revert r366664 - flip mips back from -O2 to -O.
Jan 12 2021, 9:17 PM

Jan 4 2021

adrian added a reviewer for D27958: [wpa] Add support for hostapd/wpa_supplicant when WITHOUT_CRYPT=YES is enabled.: emaste.
Jan 4 2021, 8:48 PM
adrian requested review of D27958: [wpa] Add support for hostapd/wpa_supplicant when WITHOUT_CRYPT=YES is enabled..
Jan 4 2021, 8:48 PM

Jan 3 2021

adrian added a comment to D27778: emulators/qemu: Enable user networking by default.

hi!

In D27778#620891, @bofh wrote:

Also Question: do any of the other qemu-* ports need to have this change made too, or do they all inherit/child port off the main one (I haven't looked)

All qemu-* ports needs to be updated.

Can I just try to land this one first, and worry about the others later? I'd at least like to see a working qemu port with user networking available for other freebsd users to test with.

Sure, let's just follow this changeset up in a timely manner so all ports are consistent

Re PORTLINT output, these ones at least should be addressed:

WARN: Makefile: you may want directory for dependency sphinx-build to be textproc/py-sphinx@${PY_FLAVOR}
WARN: Makefile: "ONLY_FOR_ARCHS" has to appear earlier.
WARN: Makefile: "USES" has to appear earlier.
Jan 3 2021, 1:06 AM
adrian added a comment to D27778: emulators/qemu: Enable user networking by default.

Portlint output:

Jan 3 2021, 12:54 AM
adrian added a comment to D27778: emulators/qemu: Enable user networking by default.
In D27778#620891, @bofh wrote:

Also Question: do any of the other qemu-* ports need to have this change made too, or do they all inherit/child port off the main one (I haven't looked)

All qemu-* ports needs to be updated.

Jan 3 2021, 12:53 AM

Dec 30 2020

adrian closed D27814: [vale] Fix valectl to compile on a 32-bit platform.
Dec 30 2020, 6:44 PM
adrian committed R10:697684325da8: [vale] Fix valectl to compile on a 32-bit platform (authored by adrian).
[vale] Fix valectl to compile on a 32-bit platform
Dec 30 2020, 6:44 PM

Dec 29 2020

adrian added a reviewer for D27814: [vale] Fix valectl to compile on a 32-bit platform: rlibby.

ryan - I'll push this later today, but i figured you would want to see it as well :-)

Dec 29 2020, 11:18 PM
adrian added a reviewer for D27814: [vale] Fix valectl to compile on a 32-bit platform: vmaffione.
Dec 29 2020, 6:27 PM
adrian requested review of D27814: [vale] Fix valectl to compile on a 32-bit platform.
Dec 29 2020, 6:26 PM
adrian committed R10:66585c3fe278: [wlanwatch] fix compiler warnings-as-errors on gcc-6.4 mips (authored by adrian).
[wlanwatch] fix compiler warnings-as-errors on gcc-6.4 mips
Dec 29 2020, 6:26 PM
adrian committed R10:1fef838b913a: [wlanwds] Fix compiler warnings-as-errors on freebsd gcc-6.4 mips (authored by adrian).
[wlanwds] Fix compiler warnings-as-errors on freebsd gcc-6.4 mips
Dec 29 2020, 6:26 PM
adrian committed R10:ff7c2c5a3bc3: [wlanstats] Fix warnings-as-errors on gcc-6.4 on mips (authored by adrian).
[wlanstats] Fix warnings-as-errors on gcc-6.4 on mips
Dec 29 2020, 6:26 PM

Dec 27 2020

adrian updated the diff for D27778: emulators/qemu: Enable user networking by default.

Add portrevision

Dec 27 2020, 12:57 AM

Dec 26 2020

adrian requested review of D27778: emulators/qemu: Enable user networking by default.
Dec 26 2020, 10:58 PM

Dec 14 2020

adrian added a comment to D27608: [contrib/bc] Only use fallthrough on GCC's that support it.
In D27608#616994, @imp wrote:

Can you get this accepted upstream?

Dec 14 2020, 8:09 PM
adrian requested review of D27608: [contrib/bc] Only use fallthrough on GCC's that support it.
Dec 14 2020, 4:51 PM

Dec 13 2020

adrian committed R9:f550dea96441: Reviewed by: asmodai (authored by adrian).
Reviewed by: asmodai
Dec 13 2020, 7:44 PM
adrian committed R9:194a3a1bce6f: Removing myself from the Contributors section, and adding myself (authored by adrian).
Removing myself from the Contributors section, and adding myself
Dec 13 2020, 7:44 PM
adrian committed R9:7f10aed2b4d6: Move myself from alumni back into developers. (authored by adrian).
Move myself from alumni back into developers.
Dec 13 2020, 6:02 PM

Dec 10 2020

adrian accepted D26545: net80211: split up ieee80211_probereq().
Dec 10 2020, 12:59 PM

Dec 9 2020

adrian added a comment to D27505: Fix subinterface vlan creation..

@melifaro : Did you have any more time to look at this? I guess we need to be backwards compatible and possible need to have a pool allocation for all interface names starting with "vlan" only? Other interface names are excluded from the unit management.

Dec 9 2020, 9:09 PM

Dec 8 2020

adrian committed rS368451: [ath] also remove the magic size value here for the transmit antenna statistics..
[ath] also remove the magic size value here for the transmit antenna statistics.
Dec 8 2020, 5:28 PM
adrian committed rS368450: [ath] Don't use hard-coded values in the sanity check..
[ath] Don't use hard-coded values in the sanity check.
Dec 8 2020, 5:27 PM
adrian committed rS368449: [ath] replace the hard-coded magic values in if_athioctl.h with constant defines.
[ath] replace the hard-coded magic values in if_athioctl.h with constant defines
Dec 8 2020, 5:26 PM

Dec 3 2020

adrian closed D26839: [axgbe] fix compiler warnings when compiling using gcc-6.4.
Dec 3 2020, 4:55 PM
adrian committed rS368305: [axgbe] Fix compiler warnings in gcc-6.3; perhaps fix a PHY issue.
[axgbe] Fix compiler warnings in gcc-6.3; perhaps fix a PHY issue
Dec 3 2020, 4:55 PM

Nov 17 2020

adrian closed D26791: [nvmecontrol] Fix type signedness warning-to-error on gcc-6.4.
Nov 17 2020, 5:13 PM
adrian committed rS367771: [nvmecontrol] Fix type signedness warning-to-error on gcc-6.4.
[nvmecontrol] Fix type signedness warning-to-error on gcc-6.4
Nov 17 2020, 5:13 PM
adrian closed D27240: [zfs] Fix LZ4 function definitions to not trip up the compile.
Nov 17 2020, 5:11 PM
adrian committed rS367770: [cddl] Fix lz4 function definitions to not tri pup compile..
[cddl] Fix lz4 function definitions to not tri pup compile.
Nov 17 2020, 5:11 PM

Nov 16 2020

adrian requested review of D27240: [zfs] Fix LZ4 function definitions to not trip up the compile.
Nov 16 2020, 4:43 PM
adrian added a reviewer for D26791: [nvmecontrol] Fix type signedness warning-to-error on gcc-6.4: imp.
Nov 16 2020, 2:45 AM

Nov 13 2020

adrian updated the diff for D26791: [nvmecontrol] Fix type signedness warning-to-error on gcc-6.4.

Whoops, remove another cast

Nov 13 2020, 6:59 PM
adrian updated the diff for D26791: [nvmecontrol] Fix type signedness warning-to-error on gcc-6.4.

Updated to reduce casting and use better variable types

Nov 13 2020, 6:56 PM
adrian closed D26792: [tests] Fix "unused variable" warning-to-error on gcc-6.4.
Nov 13 2020, 6:50 PM
adrian committed rS367647: [tests] Fix unused variable warning in gcc.
[tests] Fix unused variable warning in gcc
Nov 13 2020, 6:50 PM
adrian updated the diff for D26792: [tests] Fix "unused variable" warning-to-error on gcc-6.4.

Update from markj

Nov 13 2020, 6:32 PM
adrian added inline comments to D26792: [tests] Fix "unused variable" warning-to-error on gcc-6.4.
Nov 13 2020, 5:53 PM
adrian added reviewers for D26792: [tests] Fix "unused variable" warning-to-error on gcc-6.4: kib, markj.
Nov 13 2020, 5:48 PM
adrian closed D27183: [malloc] quieten -Werror=missing-braces with malloc.h wth gcc-6.4.
Nov 13 2020, 1:54 AM
adrian committed rS367629: [malloc] quieten -Werror=missing-braces with malloc.h wth gcc-6.4.
[malloc] quieten -Werror=missing-braces with malloc.h wth gcc-6.4
Nov 13 2020, 1:54 AM

Nov 12 2020

adrian updated the diff for D27183: [malloc] quieten -Werror=missing-braces with malloc.h wth gcc-6.4.

update based on comment from brooks@

Nov 12 2020, 10:48 PM

Nov 11 2020

adrian requested review of D27183: [malloc] quieten -Werror=missing-braces with malloc.h wth gcc-6.4.
Nov 11 2020, 10:45 PM

Nov 4 2020

adrian added a comment to D27088: Add .cfi_{start,end}proc annotations for MIPS assembly.

Hm, wanna see if it compiles using gcc-6 instead? mips32 SHOULD compile now, as long as you disable ZFS.

Nov 4 2020, 8:06 PM
adrian added a comment to D27088: Add .cfi_{start,end}proc annotations for MIPS assembly.

Hm, how's this work on mips32? Has anyone spun this up in qemu on malta+mips32?

Nov 4 2020, 6:47 PM

Nov 2 2020

adrian closed D26790: [libnetmap] Fix 32 bit compilation on gcc-6.3.
Nov 2 2020, 3:01 PM
adrian committed rS367273: [libnetmap] Fix 32 bit compilation under gcc-6.4.
[libnetmap] Fix 32 bit compilation under gcc-6.4
Nov 2 2020, 3:01 PM
adrian updated the diff for D26790: [libnetmap] Fix 32 bit compilation on gcc-6.3.

Update with imp's comments

Nov 2 2020, 1:07 AM

Nov 1 2020

adrian closed D27046: fix compile issues on gcc-6.4.
Nov 1 2020, 9:18 PM