This looks good to me. I'm glad we finally have this heh. :-)

just land it!

Well we should land /something/ here. Can we just land this as-is and worry about how to describe them for next year? and get that figured out in advance?

In D59920#1386951, @ziaee wrote:

should we coordinate with bz? i thought he removed all the wifi firmware from base and spent several release cycles building that out so it works well enough.

right; we shouldn't need to update rval from the rate table again, as it's already been looked up earlier.

@imp do we need anything else from srcmgr? any ideas?

hi! @imp @olce ping!

ok, from my reading, they SHOULD be the same thing for CCK and OFDM. This particular bit of code is pretty terrible though - it doesn't support HT or VHT in this path; I have no idea how static rate HT would work for management frames here (ie, the path that isn't going via firmware rate control), and VHT just isn't hooked up.

i like it. @jhibbits what do you think?

In D60054#1385402, @pkubaj wrote:

0107-tests-sys-kern-stress-test-for-FP-registers-across-s.patch11 KBDownload

Here's the test converted to in-tree ATF. Do you want me to create a next review with it?

@oleglelchuk_gmail.com did you test https://reviews.freebsd.org/D59883 instead of this diff? did it help at all?

Do you have a test program you can check in somewhere as a stress test? would be good to catch this if it creeps up again.

hm, whats left before we can land this?

ah ok it's for lining up logs between host and target. Sounds good.

@imp ping?

This looks good to me. I'll go poke srcmgr@ about it directly just for the final OK.

ok, i'll wait for @markj to do a final review, and then i'll stamp it. Thanks!

more fixes - i needed to change the sta add and sta rm to
also use the DQA queues or else I get firmware assertions!

oops, this actually DOES now work on the 7260/9260.
I had a whole bunch of little stupid things to fix here.

nice catch! thanks!

In D60080#1379601, @vexeduxr wrote:

For some more info, the laptop is a dell latitude e7440.

hw rev 0x140, fw ver 17.352738.0

I'm just noticing that it also fails to load the firmware:

iwm7260fw: could not load firmware image, error 8

So maybe my problem is just outdated firmware?

i think is this conceptually just fine. I'd like some other networking-y people to review it and ok it too!

a reported problem on irc:

@mmel and @wulf hey, this stack looks .. interesting to go and dig into as part of some other upcoming work. Would you mind taking a quick look at it and see what you think?
Thanks!

oh, nice catch! remind me again why they're all ending up in one group here?