Page MenuHomeFreeBSD

adrian (Adrian Chadd)
User

Projects

User Details

User Since
May 14 2014, 7:57 AM (527 w, 3 d)

Recent Activity

Tue, Jun 18

adrian updated the diff for D45619: net80211: separate out the net80211 ioctl key size from the kernel definition.

update

Tue, Jun 18, 8:43 PM · wireless
adrian updated the diff for D45629: net80211: add maximum key length for each cipher.

oops, fix compile

Tue, Jun 18, 7:42 PM
adrian updated the diff for D45629: net80211: add maximum key length for each cipher.

update url

Tue, Jun 18, 7:31 PM
adrian requested review of D45629: net80211: add maximum key length for each cipher.
Tue, Jun 18, 7:29 PM
adrian updated the diff for D45619: net80211: separate out the net80211 ioctl key size from the kernel definition.

more updates

Tue, Jun 18, 6:53 PM · wireless

Mon, Jun 17

adrian updated the diff for D45619: net80211: separate out the net80211 ioctl key size from the kernel definition.

address comments from bz@

Mon, Jun 17, 11:49 PM · wireless
adrian added inline comments to D45516: net80211: migrate the group/unicast key check into inline functions.
Mon, Jun 17, 11:38 PM · wireless

Sun, Jun 16

adrian added a reviewer for D45619: net80211: separate out the net80211 ioctl key size from the kernel definition: wireless.
Sun, Jun 16, 11:32 PM · wireless
adrian updated the diff for D45619: net80211: separate out the net80211 ioctl key size from the kernel definition.

add url

Sun, Jun 16, 11:32 PM · wireless
adrian requested review of D45619: net80211: separate out the net80211 ioctl key size from the kernel definition.
Sun, Jun 16, 11:31 PM · wireless
adrian updated the test plan for D45516: net80211: migrate the group/unicast key check into inline functions.
Sun, Jun 16, 11:21 PM · wireless

Thu, Jun 6

adrian added a reviewer for D45516: net80211: migrate the group/unicast key check into inline functions: wireless.

Note - I'm landing this as a standalone diff for review, but it hasn't yet had any thorough testing. Stay tuned.

Thu, Jun 6, 5:34 PM · wireless
adrian updated the diff for D45516: net80211: migrate the group/unicast key check into inline functions.

add differential url

Thu, Jun 6, 5:33 PM · wireless
adrian requested review of D45516: net80211: migrate the group/unicast key check into inline functions.
Thu, Jun 6, 5:32 PM · wireless
adrian added inline comments to D44936: wlan: update drivers to use ieee80211_set_hardware_ciphers().
Thu, Jun 6, 5:26 PM · wireless

Wed, Jun 5

adrian updated the diff for D44936: wlan: update drivers to use ieee80211_set_hardware_ciphers().

rename field, from cc@

Wed, Jun 5, 11:36 PM · wireless
adrian added a comment to D45508: LinuxKPI: 802.11: make sure we can send DISASSOC or DEAUTH frames.

The comlock is also a problem. But we shouldn't need to hold the lock whilst we do things like transmit; we're only required to do that because of how the state changes happen. The early net80211 drivers had almost no locking outside of ieee80211com. I've seen what vendors have done to net80211 to "fix locking" by changing the lock types, making some sleepable, etc ... it's just terrible.

Wed, Jun 5, 11:33 PM
adrian accepted D45508: LinuxKPI: 802.11: make sure we can send DISASSOC or DEAUTH frames.

Ah, crap. This stuff. Yeah, I hit this in ath(4) and iwn(4) way back when. It's a pain in the butt. I even think ath(4) has a workaround to drop frames in this instance because of exactly what you found.

Wed, Jun 5, 11:14 PM
adrian accepted D45505: net80211: fix IEEE80211_FHT_BITS.

whoops! nice catch.

Wed, Jun 5, 11:06 PM
adrian accepted D45506: LinuxKPI: 802.11: Fix definition of IEEE80211_HT_CAP_RX_STBC.
Wed, Jun 5, 11:06 PM
adrian added a comment to D45506: LinuxKPI: 802.11: Fix definition of IEEE80211_HT_CAP_RX_STBC.

Yeah, I remember hitting namespace clashes when trying to do this with some earlier linux driver ports. :(

Wed, Jun 5, 11:05 PM
adrian added inline comments to D44936: wlan: update drivers to use ieee80211_set_hardware_ciphers().
Wed, Jun 5, 2:11 AM · wireless

Sat, Jun 1

adrian updated the diff for D45397: net80211: Add crypto module support for AES-GCMP 128 and 256 bit..

add the modules Makefile

Sat, Jun 1, 6:41 AM · wireless

Fri, May 31

adrian added inline comments to D44964: net80211: add IEEE80211_IOC_DEVCAPS2, include versioned responses.
Fri, May 31, 1:30 AM · wireless
adrian added inline comments to D44964: net80211: add IEEE80211_IOC_DEVCAPS2, include versioned responses.
Fri, May 31, 1:01 AM · wireless

Thu, May 30

adrian accepted D45418: WPA: Allow CLOCK_BOOTTIME and CLOCK_MONOTONIC to #define the same.
Thu, May 30, 9:06 PM
adrian added a comment to D44920: net80211: bump maximum key size to 384 bits.

The real problem isn't the ABI key size, it's that the current net80211 API routine expects the ioctl size is fixed. If that size check wasn't there and we relied on the key request key size and verified it fit inside the ioctl buffer size then we'd be fine.

Thu, May 30, 7:31 PM · wireless

Wed, May 29

adrian updated the summary of D45397: net80211: Add crypto module support for AES-GCMP 128 and 256 bit..
Wed, May 29, 12:55 AM · wireless
adrian added a reviewer for D45397: net80211: Add crypto module support for AES-GCMP 128 and 256 bit.: wireless.
Wed, May 29, 12:51 AM · wireless
adrian updated the summary of D45397: net80211: Add crypto module support for AES-GCMP 128 and 256 bit..
Wed, May 29, 12:51 AM · wireless
adrian requested review of D45397: net80211: Add crypto module support for AES-GCMP 128 and 256 bit..
Wed, May 29, 12:49 AM · wireless

May 18 2024

adrian added a comment to D44920: net80211: bump maximum key size to 384 bits.

Can we decouple userland use in ifconfig? i.e., have ifconfig support 384 bits now

May 18 2024, 4:59 AM · wireless

May 15 2024

adrian added a comment to D42391: ethernet: Remove FCS bit.

I'm sure I've seen FCSes in 802.11 bpf traces? Maybe that's happening at the 802.11 radiotap level?

May 15 2024, 2:41 AM

May 14 2024

adrian committed rGc7f5f140bfdd: net80211: add initial key management suites from 802.11-2016, APIs to register… (authored by adrian).
net80211: add initial key management suites from 802.11-2016, APIs to register…
May 14 2024, 9:40 PM
adrian committed rGdcf6ab2f2e38: net80211: allow a single wlan crypto module to register for >1 cipher (authored by adrian).
net80211: allow a single wlan crypto module to register for >1 cipher
May 14 2024, 9:40 PM
adrian committed rG98e8df90b5cc: net80211: add placeholder module names for the new ciphers (authored by adrian).
net80211: add placeholder module names for the new ciphers
May 14 2024, 9:40 PM
adrian closed D44919: net80211: add initial key management suites from 802.11-2016, APIs to register them.
May 14 2024, 9:40 PM · wireless
adrian closed D44901: net80211: allow a single wlan crypto module to register for >1 cipher.
May 14 2024, 9:40 PM · wireless
adrian committed rG05540e62e75f: net80211: add the 802.11-2016 cipher list to the crypto array set. (authored by adrian).
net80211: add the 802.11-2016 cipher list to the crypto array set.
May 14 2024, 9:40 PM
adrian closed D44900: net80211: add placeholder module names for the new ciphers.
May 14 2024, 9:40 PM · wireless
adrian closed D44899: net80211: add the 802.11-2016 cipher list to the crypto array set..
May 14 2024, 9:40 PM · wireless

May 13 2024

adrian added a comment to D45179: mt7601U.

oh, interesting! does 11n work on this driver in openbsd? I see some 11n stuff is commented out here.

May 13 2024, 5:56 PM

May 12 2024

adrian added inline comments to D44921: net80211: add 256 bit CCMP support.
May 12 2024, 10:35 PM · wireless
adrian added inline comments to D44921: net80211: add 256 bit CCMP support.
May 12 2024, 10:32 PM · wireless
adrian updated the summary of D44919: net80211: add initial key management suites from 802.11-2016, APIs to register them.
May 12 2024, 10:28 PM · wireless
adrian updated the diff for D44919: net80211: add initial key management suites from 802.11-2016, APIs to register them.

remove the VAP keymgmt flags for now; will reintroduce it and change the
ioctl API to use that instead when it's necessary.

May 12 2024, 10:28 PM · wireless
adrian added inline comments to D44919: net80211: add initial key management suites from 802.11-2016, APIs to register them.
May 12 2024, 10:25 PM · wireless
adrian added inline comments to D44899: net80211: add the 802.11-2016 cipher list to the crypto array set..
May 12 2024, 10:21 PM · wireless
adrian updated the diff for D44899: net80211: add the 802.11-2016 cipher list to the crypto array set..

remove NONE, from bz@

May 12 2024, 10:20 PM · wireless

May 9 2024

adrian committed rGc2a005a0a97d: net80211: add new ciphers and RSN flags (authored by adrian).
net80211: add new ciphers and RSN flags
May 9 2024, 12:50 AM
adrian committed rGe9961ea16496: net80211: add driver / crypto methods to set the hardware / software cipher… (authored by adrian).
net80211: add driver / crypto methods to set the hardware / software cipher…
May 9 2024, 12:50 AM
adrian committed rG491938d7435f: wpa: Remove the now not-needed local logic to hard-code cipher support (authored by adrian).
wpa: Remove the now not-needed local logic to hard-code cipher support
May 9 2024, 12:50 AM
adrian closed D44864: net80211: add new ciphers and RSN flags.
May 9 2024, 12:50 AM · wireless
adrian committed rG1116e8b95c60: net80211: add a new field specifically for announcing specific ciphers (authored by adrian).
net80211: add a new field specifically for announcing specific ciphers
May 9 2024, 12:50 AM
adrian closed D44827: net80211: add driver / crypto methods to set the hardware / software cipher suites.
May 9 2024, 12:50 AM · wireless
adrian closed D44821: wpa: Remove the now not-needed local logic to hard-code cipher support.
May 9 2024, 12:50 AM · wireless
adrian closed D44820: net80211: add a new field specifically for announcing specific ciphers.
May 9 2024, 12:50 AM · wireless

May 3 2024

adrian added a comment to D44920: net80211: bump maximum key size to 384 bits.

OK, I rebuilt world and found where this breaks userland.

May 3 2024, 6:30 PM · wireless
adrian added inline comments to D44864: net80211: add new ciphers and RSN flags.
May 3 2024, 4:45 PM · wireless
adrian added a comment to D44827: net80211: add driver / crypto methods to set the hardware / software cipher suites.
In D44827#1027553, @bz wrote:

This still has changes not marked "done".
Is there a change in the stack which does change the drivers to use this?

May 3 2024, 4:41 PM · wireless
adrian added a comment to D44820: net80211: add a new field specifically for announcing specific ciphers.
In D44820#1027551, @bz wrote:

Can you please update the commit message? Apart from that it seems fine-ish with what cc@ said.

May 3 2024, 4:39 PM · wireless

May 1 2024

adrian added inline comments to D44864: net80211: add new ciphers and RSN flags.
May 1 2024, 10:16 PM · wireless
adrian updated the diff for D44864: net80211: add new ciphers and RSN flags.

address comments from cc@

May 1 2024, 2:19 AM · wireless
adrian updated the diff for D44827: net80211: add driver / crypto methods to set the hardware / software cipher suites.

address comments by cc@

May 1 2024, 12:37 AM · wireless

Apr 30 2024

adrian added a comment to D44920: net80211: bump maximum key size to 384 bits.

Can we decouple userland use in ifconfig? i.e., have ifconfig support 384 bits now

Apr 30 2024, 4:55 PM · wireless
adrian added inline comments to D44820: net80211: add a new field specifically for announcing specific ciphers.
Apr 30 2024, 1:38 PM · wireless

Apr 29 2024

adrian added a comment to D44919: net80211: add initial key management suites from 802.11-2016, APIs to register them.

I just removed the hw caps for now, i'll chase that up later when this stuff has landed and we've had a chance to think about how to support full supplicant/mlme management (like VERY fullmac) NICs.

Apr 29 2024, 3:03 AM · wireless
adrian updated the diff for D44820: net80211: add a new field specifically for announcing specific ciphers.

push update

Apr 29 2024, 3:02 AM · wireless
adrian updated the diff for D44919: net80211: add initial key management suites from 802.11-2016, APIs to register them.

address comments

Apr 29 2024, 3:01 AM · wireless
adrian updated the diff for D44964: net80211: add IEEE80211_IOC_DEVCAPS2, include versioned responses.

address comments

Apr 29 2024, 3:01 AM · wireless

Apr 28 2024

adrian removed a reviewer for D44919: net80211: add initial key management suites from 802.11-2016, APIs to register them: bz.
Apr 28 2024, 11:40 PM · wireless
adrian added inline comments to D44901: net80211: allow a single wlan crypto module to register for >1 cipher.
Apr 28 2024, 11:28 PM · wireless
adrian updated the diff for D44921: net80211: add 256 bit CCMP support.

update to compile w/ stack changes

Apr 28 2024, 11:25 PM · wireless
adrian updated the diff for D44901: net80211: allow a single wlan crypto module to register for >1 cipher.

address comments

Apr 28 2024, 11:24 PM · wireless

Apr 27 2024

adrian updated the diff for D44864: net80211: add new ciphers and RSN flags.

comments!

Apr 27 2024, 1:57 AM · wireless
adrian added inline comments to D44827: net80211: add driver / crypto methods to set the hardware / software cipher suites.
Apr 27 2024, 1:53 AM · wireless
adrian updated the diff for D44820: net80211: add a new field specifically for announcing specific ciphers.

address feedback

Apr 27 2024, 1:51 AM · wireless

Apr 26 2024

adrian added inline comments to D36469: wtap(4): implement monitor mode and handle radiotap.
Apr 26 2024, 6:42 PM · wireless
adrian added a reviewer for D44964: net80211: add IEEE80211_IOC_DEVCAPS2, include versioned responses: wireless.
Apr 26 2024, 5:15 AM · wireless
adrian added a reviewer for D44965: wpa: add IEEE80211_IOC_DEVCAPS2 ioctl support: wireless.
Apr 26 2024, 5:14 AM · wireless
adrian updated the diff for D44965: wpa: add IEEE80211_IOC_DEVCAPS2 ioctl support.

update diff url

Apr 26 2024, 5:13 AM · wireless
adrian updated the diff for D44964: net80211: add IEEE80211_IOC_DEVCAPS2, include versioned responses.

update diff url

Apr 26 2024, 5:13 AM · wireless
adrian requested review of D44965: wpa: add IEEE80211_IOC_DEVCAPS2 ioctl support.
Apr 26 2024, 5:11 AM · wireless
adrian requested review of D44964: net80211: add IEEE80211_IOC_DEVCAPS2, include versioned responses.
Apr 26 2024, 5:11 AM · wireless

Apr 25 2024

adrian added a comment to D44944: daemon: Add -C (--restart-count) option.

lgtm, whats this addressing? Whats the system behaviour when the count limit is hit?

Apr 25 2024, 2:35 PM
adrian added a reviewer for D44937: wlan: add some calls to ieee80211_set_driver_keymgmt_suites(): wireless.
Apr 25 2024, 4:45 AM · wireless
adrian updated the diff for D44937: wlan: add some calls to ieee80211_set_driver_keymgmt_suites().

update diff url

Apr 25 2024, 4:44 AM · wireless
adrian requested review of D44937: wlan: add some calls to ieee80211_set_driver_keymgmt_suites().
Apr 25 2024, 4:44 AM · wireless
adrian added a comment to D44827: net80211: add driver / crypto methods to set the hardware / software cipher suites.
In D44827#1024357, @cc wrote:
In D44827#1023209, @bz wrote:

eg ath(4) would do something like:

How do you want to implement ath_settkipmic() "nicely" without exposing the field?

oops my bad. it'll be a flag for hardware encryption support! I fixed the code snippet.

I don't get it. Without exposing the field ic_cryptocaps? And where is the "fixed the code snippet"?

Apr 25 2024, 4:18 AM · wireless
adrian added a comment to D44827: net80211: add driver / crypto methods to set the hardware / software cipher suites.
In D44827#1024561, @bz wrote:

Are you going to change the few drivers which need change to get rid of the public exposure as well? Otherwise this is a dead code before added.

Apr 25 2024, 4:17 AM · wireless
adrian updated the summary of D44820: net80211: add a new field specifically for announcing specific ciphers.
Apr 25 2024, 4:16 AM · wireless
adrian updated the diff for D44820: net80211: add a new field specifically for announcing specific ciphers.

address comments from cc@

Apr 25 2024, 4:16 AM · wireless
adrian added a reviewer for D44936: wlan: update drivers to use ieee80211_set_hardware_ciphers(): wireless.
Apr 25 2024, 4:11 AM · wireless
adrian updated the diff for D44936: wlan: update drivers to use ieee80211_set_hardware_ciphers().

update w/ diff url

Apr 25 2024, 4:09 AM · wireless
adrian requested review of D44936: wlan: update drivers to use ieee80211_set_hardware_ciphers().
Apr 25 2024, 4:08 AM · wireless

Apr 24 2024

adrian updated the diff for D44921: net80211: add 256 bit CCMP support.

add missing RSN parsing stuff for hostapd

Apr 24 2024, 7:18 PM · wireless
adrian added a project to D44920: net80211: bump maximum key size to 384 bits: wireless.
Apr 24 2024, 12:01 AM · wireless
adrian added a reviewer for D44920: net80211: bump maximum key size to 384 bits: wireless.
Apr 24 2024, 12:01 AM · wireless
adrian added a reviewer for D44921: net80211: add 256 bit CCMP support: wireless.
Apr 24 2024, 12:01 AM · wireless
adrian added reviewers for D44922: wpa: add cipher flag support for the new ciphers: wireless, cy.
Apr 24 2024, 12:00 AM