Page MenuHomeFreeBSD

adrian (Adrian Chadd)
User

Projects (15)

User Details

User Since
May 14 2014, 7:57 AM (636 w, 1 d)

Recent Activity

Today

adrian accepted D58414: News: Announce 2026 ports freeze.
Thu, Jul 23, 3:34 PM

Yesterday

adrian accepted D26018: Methodize the TX power limit retrival in ieee80211_ioctl_get80211().
Wed, Jul 22, 3:43 AM · wireless

Tue, Jul 21

adrian abandoned D45397: net80211: Add crypto module support for AES-GCMP 128 and 256 bit..

Landed via another review (https://reviews.freebsd.org/D49161)

Tue, Jul 21, 8:01 PM · wireless
adrian abandoned D49419: net80211: bump crypto keysize to 384 bits.

I've been working in this in another stack (https://reviews.freebsd.org/D58384 as an example) to do a lot of needed API cleanup before we can bump this without breaking the current ioctls.

Tue, Jul 21, 8:00 PM · wireless
adrian added a reviewer for D58384: net80211: migrate the ioctl API to a 128 bit specific API + use key API: wireless.
Tue, Jul 21, 7:59 PM · wireless
adrian requested review of D58384: net80211: migrate the ioctl API to a 128 bit specific API + use key API.
Tue, Jul 21, 7:57 PM · wireless
adrian added a comment to D26018: Methodize the TX power limit retrival in ieee80211_ioctl_get80211().

oh damn i missed this, I think it's worth refactoring it so we do have a specific place to pull the TX power from.

Tue, Jul 21, 7:50 PM · wireless
adrian added a comment to D54296: PR 291774: expand range of errors reported by libusb_open(3).

usbconfig stopped reporting my webcam and fingerprint reader. Instead I get 'usbconfig: could not open device: Bad file descriptor'. Problem goes away when these changes are reverted.

Tue, Jul 21, 5:13 PM · USB

Mon, Jul 20

adrian committed rGe7efe2f059a4: firewire: remove deprecation notice from manual page (authored by guest-seuros).
firewire: remove deprecation notice from manual page
Mon, Jul 20, 10:51 PM
adrian committed rGdd56711e8353: firewire: replace magic numbers with named constants (authored by guest-seuros).
firewire: replace magic numbers with named constants
Mon, Jul 20, 10:51 PM
adrian committed rG8a765654f937: firewire: remove dead code across the subsystem (authored by guest-seuros).
firewire: remove dead code across the subsystem
Mon, Jul 20, 10:51 PM
adrian committed rG23ea903f6801: firewire: force root change when root node is not cycle master capable (authored by guest-seuros).
firewire: force root change when root node is not cycle master capable
Mon, Jul 20, 10:51 PM
adrian committed rG5b7449ad47be: firewire: drain pending xfers after callout stop in detach (authored by guest-seuros).
firewire: drain pending xfers after callout stop in detach
Mon, Jul 20, 10:51 PM
adrian committed rGd3259935f778: firewire: add warn-only CRC validation for CSR ROM directories (authored by guest-seuros).
firewire: add warn-only CRC validation for CSR ROM directories
Mon, Jul 20, 10:51 PM
adrian closed D58267: firewire: remove deprecation notice from manual page.
Mon, Jul 20, 10:50 PM · drivers, firewire
adrian closed D58311: firewire: replace magic numbers with named constants.
Mon, Jul 20, 10:50 PM · firewire
adrian committed rG4a4bcdc6aa3e: net80211: update drivers to allocate sequence numbers in the raw path (authored by adrian).
net80211: update drivers to allocate sequence numbers in the raw path
Mon, Jul 20, 10:50 PM
adrian closed D58310: firewire: remove dead code across the subsystem.
Mon, Jul 20, 10:50 PM
adrian closed D58309: firewire: force root change when root node is not cycle master capable.
Mon, Jul 20, 10:50 PM · firewire
adrian closed D58308: firewire: drain pending xfers after callout stop in detach.
Mon, Jul 20, 10:50 PM · firewire
adrian closed D58098: net80211: update drivers to allocate sequence numbers in the raw path.
Mon, Jul 20, 10:50 PM · wireless
adrian closed D58307: firewire: add warn-only CRC validation for CSR ROM directories.
Mon, Jul 20, 10:50 PM · firewire
adrian accepted D58310: firewire: remove dead code across the subsystem.

I'll think about this a bit more tomorrow. A lot of dead code is just dead code, but I do wonder what the #if 0 register programming was trying to do and what weird issues happened twenty years ago :P

Mon, Jul 20, 6:34 AM
adrian accepted D58309: firewire: force root change when root node is not cycle master capable.
Mon, Jul 20, 6:27 AM · firewire
adrian accepted D58308: firewire: drain pending xfers after callout stop in detach.
Mon, Jul 20, 6:27 AM · firewire
adrian accepted D58307: firewire: add warn-only CRC validation for CSR ROM directories.
Mon, Jul 20, 6:27 AM · firewire

Sun, Jul 19

adrian accepted D58343: hwpmc: add regression tests for detaching a live process-mode PMC.
Sun, Jul 19, 7:37 PM · pmc
adrian accepted D58342: hwpmc: drain a process-mode PMC's runcount when a live target detaches.
Sun, Jul 19, 7:36 PM · pmc
adrian accepted D58341: hwpmc: add regression tests for counting-PMC counter wraparound.
Sun, Jul 19, 7:35 PM · pmc
adrian committed rGb0c14eae1060: re(4): add hw.re.aspm_disable loader tunable (authored by jeremie_jourdin.org).
re(4): add hw.re.aspm_disable loader tunable
Sun, Jul 19, 6:52 PM
adrian committed rG42f3088bd980: re(4): harden re_watchdog() recovery and log controller state (authored by jeremie_jourdin.org).
re(4): harden re_watchdog() recovery and log controller state
Sun, Jul 19, 6:52 PM
adrian committed rGd11f124e932b: re(4): recover Tx completions whose MSI was swallowed in re_intr_msi() (authored by jeremie_jourdin.org).
re(4): recover Tx completions whose MSI was swallowed in re_intr_msi()
Sun, Jul 19, 6:52 PM
adrian committed rG4bff6b9f5cef: re(4): re-arm the Tx doorbell when re_txeof() leaves a non-empty ring (authored by jeremie_jourdin.org).
re(4): re-arm the Tx doorbell when re_txeof() leaves a non-empty ring
Sun, Jul 19, 6:52 PM
adrian committed rG38187938f522: re(4): quiesce RTL8168G+ and reset before freeing buffers in re_stop() (authored by jeremie_jourdin.org).
re(4): quiesce RTL8168G+ and reset before freeing buffers in re_stop()
Sun, Jul 19, 6:51 PM
adrian added a comment to D58144: aq(4): document the Atlantic 2 (AQC113/114/115/116) devices.

@ziaee i landed everything up to but not including this diff. Let's chat with nick to finalise things.

Sun, Jul 19, 6:34 PM · drivers
adrian accepted D58340: hwpmc: handle counter wraparound for process-mode counting PMCs.

oh good catch! (I've found/fixed these width bugs in the deep past, they can be a pain to find as not every counter is the damned same... :-) )

Sun, Jul 19, 4:55 PM · pmc
adrian committed rGc325b4024d61: aq(4): correct Atlantic 2 register access (authored by nick_spun.io).
aq(4): correct Atlantic 2 register access
Sun, Jul 19, 4:50 PM
adrian committed rGdc5c0fc51cf4: aq(4): add Atlantic 2 (AQC113) device support (authored by nick_spun.io).
aq(4): add Atlantic 2 (AQC113) device support
Sun, Jul 19, 4:50 PM
adrian committed rG418e7fd13b5a: aq(4): program the Atlantic 2 multiqueue datapath (authored by nick_spun.io).
aq(4): program the Atlantic 2 multiqueue datapath
Sun, Jul 19, 4:50 PM
adrian committed rGf1796e8781ca: aq(4): remove dead code and tidy macros, diagnostics, and naming (authored by nick_spun.io).
aq(4): remove dead code and tidy macros, diagnostics, and naming
Sun, Jul 19, 4:50 PM
adrian committed rG557866b899b6: aq(4): harden the attach, detach, and reset error paths (authored by nick_spun.io).
aq(4): harden the attach, detach, and reset error paths
Sun, Jul 19, 4:50 PM
adrian committed rG65fd3b4165ef: aq(4): harden the interrupt and MAC-statistics paths (authored by nick_spun.io).
aq(4): harden the interrupt and MAC-statistics paths
Sun, Jul 19, 4:50 PM
adrian committed rG9b4585afd313: aq(4): honor the kernel RSS policy and add a TX traffic-class helper (authored by nick_spun.io).
aq(4): honor the kernel RSS policy and add a TX traffic-class helper
Sun, Jul 19, 4:50 PM
adrian committed rG73cd4048807d: aq(4): drop errored RX frames instead of resetting the interface (authored by nick_spun.io).
aq(4): drop errored RX frames instead of resetting the interface
Sun, Jul 19, 4:50 PM
adrian committed rGdcede1ec9de3: aq(4): expand and correct offloads, fix VLAN/multicast filtering (authored by nick_spun.io).
aq(4): expand and correct offloads, fix VLAN/multicast filtering
Sun, Jul 19, 4:50 PM
adrian closed D58143: aq(4): correct Atlantic 2 register access.
Sun, Jul 19, 4:50 PM · drivers
adrian closed D58141: aq(4): add Atlantic 2 (AQC113) device support.
Sun, Jul 19, 4:50 PM · drivers
adrian closed D58142: aq(4): program the Atlantic 2 multiqueue datapath.
Sun, Jul 19, 4:50 PM · drivers
adrian closed D58140: aq(4): remove dead code and tidy macros, diagnostics, and naming.
Sun, Jul 19, 4:50 PM · drivers
adrian closed D58138: aq(4): harden the attach, detach, and reset error paths.
Sun, Jul 19, 4:50 PM · drivers
adrian closed D58139: aq(4): harden the interrupt and MAC-statistics paths.
Sun, Jul 19, 4:50 PM · drivers
adrian closed D58137: aq(4): honor the kernel RSS policy and add a TX traffic-class helper.
Sun, Jul 19, 4:49 PM · drivers
adrian closed D58136: aq(4): drop errored RX frames instead of resetting the interface.
Sun, Jul 19, 4:49 PM · drivers
adrian closed D58145: aq(4): expand and correct offloads, fix VLAN/multicast filtering.
Sun, Jul 19, 4:49 PM · drivers
adrian committed rGdc12e3e0e72a: dpaa2: Apply if_flags and MAC filters in dpaa2_ni_init() (authored by nick_spun.io).
dpaa2: Apply if_flags and MAC filters in dpaa2_ni_init()
Sun, Jul 19, 3:10 AM
adrian closed D58330: dpaa2: Apply if_flags and MAC filters in dpaa2_ni_init().
Sun, Jul 19, 3:10 AM · drivers
adrian created P713 (An Untitled Masterwork).
Sun, Jul 19, 3:06 AM · ZFS, PowerPC

Sat, Jul 18

adrian updated subscribers of D58330: dpaa2: Apply if_flags and MAC filters in dpaa2_ni_init().
Sat, Jul 18, 9:51 PM · drivers

Fri, Jul 17

adrian accepted D58311: firewire: replace magic numbers with named constants.
Fri, Jul 17, 5:38 PM · firewire
adrian added a comment to D58286: krb5: Install profile.h again.

I'm pretty sure this header needs to be in /usr/include due, well, its seniority status among headers (ie, what software expects.)

Fri, Jul 17, 2:57 PM
adrian committed rGdd9fac5e4f00: firewire: remove SPL calls (authored by guest-seuros).
firewire: remove SPL calls
Fri, Jul 17, 4:10 AM
adrian committed rG2b9ed8da552c: fwdv: match unit directories instead of IDENTIFY (authored by guest-seuros).
fwdv: match unit directories instead of IDENTIFY
Fri, Jul 17, 4:10 AM
adrian committed rGc402d2e4b700: fwisound: match unit directories instead of IDENTIFY (authored by guest-seuros).
fwisound: match unit directories instead of IDENTIFY
Fri, Jul 17, 4:10 AM
adrian committed rG58bd89647617: fwcam: match unit directories, defer probe to first open (authored by guest-seuros).
fwcam: match unit directories, defer probe to first open
Fri, Jul 17, 4:10 AM
adrian committed rG21143476a576: firewire: per-unit-directory child device support (authored by guest-seuros).
firewire: per-unit-directory child device support
Fri, Jul 17, 4:10 AM
adrian closed D58210: firewire: remove SPL calls.
Fri, Jul 17, 4:09 AM · drivers, firewire
adrian closed D58204: fwdv: match unit directories instead of IDENTIFY.
Fri, Jul 17, 4:09 AM · drivers, firewire
adrian closed D58203: fwisound: match unit directories instead of IDENTIFY.
Fri, Jul 17, 4:09 AM · drivers, firewire
adrian closed D58202: fwcam: match unit directories, defer probe to first open.
Fri, Jul 17, 4:09 AM · drivers, firewire
adrian closed D58201: firewire: per-unit-directory child device support.
Fri, Jul 17, 4:09 AM · drivers, firewire
adrian accepted D58204: fwdv: match unit directories instead of IDENTIFY.

yes i tested this!

Fri, Jul 17, 4:06 AM · drivers, firewire
adrian accepted D58203: fwisound: match unit directories instead of IDENTIFY.

yes i tested this!

Fri, Jul 17, 4:06 AM · drivers, firewire
adrian accepted D58202: fwcam: match unit directories, defer probe to first open.

yes i tested this!

Fri, Jul 17, 4:05 AM · drivers, firewire
adrian accepted D58201: firewire: per-unit-directory child device support.

yes i tested this!

Fri, Jul 17, 4:05 AM · drivers, firewire
adrian committed rG9da8f0e0b4bd: kern: fix compilation (authored by adrian).
kern: fix compilation
Fri, Jul 17, 4:02 AM

Wed, Jul 15

adrian accepted D58144: aq(4): document the Atlantic 2 (AQC113/114/115/116) devices.

ziaee, any other updates? wanna poke nprice on irc and get this finished up so I can land the stack? Thanks!

Wed, Jul 15, 8:26 PM · drivers
adrian accepted D58143: aq(4): correct Atlantic 2 register access.
Wed, Jul 15, 8:24 PM · drivers
adrian accepted D58142: aq(4): program the Atlantic 2 multiqueue datapath.
Wed, Jul 15, 8:24 PM · drivers
adrian accepted D58141: aq(4): add Atlantic 2 (AQC113) device support.
Wed, Jul 15, 8:23 PM · drivers
adrian accepted D58140: aq(4): remove dead code and tidy macros, diagnostics, and naming.
Wed, Jul 15, 8:22 PM · drivers
adrian accepted D58139: aq(4): harden the interrupt and MAC-statistics paths.
Wed, Jul 15, 8:13 PM · drivers
adrian accepted D58138: aq(4): harden the attach, detach, and reset error paths.
Wed, Jul 15, 8:12 PM · drivers
adrian accepted D58137: aq(4): honor the kernel RSS policy and add a TX traffic-class helper.
Wed, Jul 15, 8:12 PM · drivers
adrian accepted D58136: aq(4): drop errored RX frames instead of resetting the interface.
Wed, Jul 15, 8:11 PM · drivers
adrian accepted D58145: aq(4): expand and correct offloads, fix VLAN/multicast filtering.
Wed, Jul 15, 8:11 PM · drivers
adrian added reviewers for D58248: libgcc_s: export the IEEE-128 long double runtime on powerpc64le: jrtc27, imp.

We should loop jrtc27 and maybe someone from srcmgr into this

Wed, Jul 15, 5:52 AM

Tue, Jul 14

adrian added a comment to D58096: netinet6: fix ND link-layer address option layout for IPoIB.

@vinicius_ferrao.net.br I do not have IB devices so not able to test. Would you please test against stable/15 after I commit it ?

Hi @zlei, I've double checked and yes, everythinig was working. I was able to replicate the issue without the patch and them checking the fix after applying it and rebuilding the kernel.

Tue, Jul 14, 5:19 PM · network

Mon, Jul 13

adrian added inline comments to D58201: firewire: per-unit-directory child device support.
Mon, Jul 13, 2:20 AM · drivers, firewire

Sun, Jul 12

adrian added inline comments to D58201: firewire: per-unit-directory child device support.
Sun, Jul 12, 10:26 PM · drivers, firewire
adrian committed rGad91d47db306: bluetooth: signal devd on netgraph device events (authored by guest-charlesrocket).
bluetooth: signal devd on netgraph device events
Sun, Jul 12, 6:48 PM
adrian accepted D58196: usbdump: add -t to omit timestamps.
Sun, Jul 12, 5:42 PM
adrian committed rG4085d1991e2a: hidwacom: Add Wacom ExpressKey Remote driver (authored by guest-seuros).
hidwacom: Add Wacom ExpressKey Remote driver
Sun, Jul 12, 5:26 PM
adrian closed D56729: hidwacom: Add Wacom ExpressKey Remote driver.
Sun, Jul 12, 5:25 PM · USB
adrian accepted D56729: hidwacom: Add Wacom ExpressKey Remote driver.
Sun, Jul 12, 5:05 PM · USB
adrian added a comment to D56729: hidwacom: Add Wacom ExpressKey Remote driver.

It is fine as-is, we can rename it later if needs be.

Sun, Jul 12, 5:05 PM · USB
adrian committed rG23a6997e3071: fwdv: add AV/C DV capture driver for FireWire camcorders (authored by guest-seuros).
fwdv: add AV/C DV capture driver for FireWire camcorders
Sun, Jul 12, 3:36 PM
adrian committed rG7aa34e12c9e1: rge: fix multicast add/removal by using if_getdrvflags() (authored by adrian).
rge: fix multicast add/removal by using if_getdrvflags()
Sun, Jul 12, 3:36 PM
adrian closed D58122: fwdv: add AV/C DV capture driver for FireWire camcorders.
Sun, Jul 12, 3:36 PM · drivers, firewire
adrian accepted D58122: fwdv: add AV/C DV capture driver for FireWire camcorders.
Sun, Jul 12, 3:23 PM · drivers, firewire
adrian added a comment to D51865: libusb: capsicumize libusb.

So why are a whole lot of functions getting an fd added to them?

Sun, Jul 12, 3:08 PM