Page MenuHomeFreeBSD

adrian (Adrian Chadd)
User

Projects (16)

User Details

User Since
May 14 2014, 7:57 AM (642 w, 1 d)

Recent Activity

Today

adrian added a project to D59355: pmc: avoid illegal flexible array member: pmc.

oh i see what's going on here. ugh. :-) I'm ok with this, but gosh we need a less cpu specific way of doing all of this!

Thu, Sep 3, 8:33 PM · pmc
adrian accepted D57465: LinuxKPI: Create `linux/util_macros.h`.
Thu, Sep 3, 6:51 PM · linuxkpi
adrian added a comment to D57465: LinuxKPI: Create `linux/util_macros.h`.

yeah just remove the - at that first comment line and then i'll be good to go

Thu, Sep 3, 2:47 PM · linuxkpi
adrian added a comment to D58075: LinuxKPI: Added jiffies64_to_msecs for amdkfd compatibility..

lgtm

Thu, Sep 3, 2:46 PM · linuxkpi

Tue, Sep 1

adrian accepted D59205: rtwn: add support for the RTL8723BU.

boot tested on this laptop; associated and works. Getting 10mbit down and 6mbit up on speedtest.net speedtest on my busy 2GHz air. It looks like it hovers around MCS3/MCS4 here but that's likely distance/busy air.

Tue, Sep 1, 7:41 PM
adrian accepted D59153: nvme: name the Create I/O queue cdw11 fields, use Medium QPRIO.
Tue, Sep 1, 7:27 PM
adrian accepted D59311: powerpc/radix: take the pmap lock in mmu_radix_sync_icache().
Tue, Sep 1, 6:52 PM
adrian accepted D59156: nvme: drop the S3X single-outstanding-I/O quirk.
Tue, Sep 1, 6:40 PM

Mon, Aug 31

adrian accepted D58337: umtx: use a distribution-fair multiplier for the chain hash.
Mon, Aug 31, 11:44 PM
adrian accepted D58587: bxe(4): don't feed a zero page size to ilog2 during ILT init.
Mon, Aug 31, 6:41 PM · network
adrian added a comment to D59267: name: add cni-dnsname.

Would it be more suitable to be in dns category?

Mon, Aug 31, 2:44 AM

Sun, Aug 30

adrian added a comment to D58337: umtx: use a distribution-fair multiplier for the chain hash.

oh, before I remove it - go update the comments - they need to be a bits horter and there's no longer a kernel config option for it.

Sun, Aug 30, 10:27 PM
adrian added a project to D59277: inetd: only declare and use the mapped-address netconfig under INET6: Contributor Reviews (src).

I'm not sure who to route this to for review. I'll go poke around!

Sun, Aug 30, 10:25 PM · Contributor Reviews (src)

Sat, Aug 29

adrian added projects to D59264: vt_simplefb: support armv7 and U-Boot-placed framebuffer nodes: drivers, ARM.
Sat, Aug 29, 7:34 PM · ARM, drivers
adrian abandoned D59268: name: add cni-dnsname.

dupe

Sat, Aug 29, 7:31 PM
adrian requested review of D59268: name: add cni-dnsname.
Sat, Aug 29, 7:31 PM
adrian requested review of D59267: name: add cni-dnsname.
Sat, Aug 29, 7:29 PM
adrian accepted D59263: gpioled: defer gpio pin writes to a taskqueue.
Sat, Aug 29, 6:37 PM
adrian added inline comments to D59263: gpioled: defer gpio pin writes to a taskqueue.
Sat, Aug 29, 6:31 PM
adrian added inline comments to D59263: gpioled: defer gpio pin writes to a taskqueue.
Sat, Aug 29, 3:56 PM

Fri, Aug 28

adrian added projects to D58867: acpi_apple: Apple platform ACPI driver,: drivers, apple (x86).
Fri, Aug 28, 3:10 PM · apple (x86), drivers

Thu, Aug 27

adrian added inline comments to D59205: rtwn: add support for the RTL8723BU.
Thu, Aug 27, 7:37 PM
adrian added a comment to D59205: rtwn: add support for the RTL8723BU.

i'm pretty sure we can check in binary files nowdays; i won't do it as part of this commit but I'll go review moving the uuencoded firmware files to binary files in a separate diff.

Thu, Aug 27, 7:27 PM
adrian accepted D59208: video: bump __FreeBSD_version for V4L2 cropping and overlay symbols.
Thu, Aug 27, 5:36 PM · drivers
adrian added a project to D59208: video: bump __FreeBSD_version for V4L2 cropping and overlay symbols: drivers.
Thu, Aug 27, 4:03 PM · drivers
adrian accepted D59208: video: bump __FreeBSD_version for V4L2 cropping and overlay symbols.

add a note to UPDATING too explaining what the version bump is for.

Thu, Aug 27, 4:03 PM · drivers
adrian accepted D59203: video: add V4L2 cropping, control menu and overlay symbols.

make sure you do a "make universe" on a beefy enough machine to try and capture any of the weird kernel variants having different sizes.

Thu, Aug 27, 4:02 PM · drivers

Wed, Aug 26

adrian accepted D58863: intel: add hfsts debug-probe driver for Intel ME/HECI firmware status.
Wed, Aug 26, 9:31 PM · drivers

Mon, Aug 24

adrian committed rG417d6470cbd4: nvme: limit visible namespaces on Apple S3X (authored by seuros).
nvme: limit visible namespaces on Apple S3X
Mon, Aug 24, 5:05 PM
adrian closed D58844: nvme: limit visible namespaces on Apple S3X.
Mon, Aug 24, 5:04 PM
adrian committed rG68323f0a0304: nvme: fix Apple S3X controller panic (authored by seuros).
nvme: fix Apple S3X controller panic
Mon, Aug 24, 5:04 PM
adrian closed D58821: nvme: fix Apple S3X controller panic.
Mon, Aug 24, 5:04 PM

Sun, Aug 23

adrian added a comment to D59129: git-arc: Handle -h on subcommands and align usage with the man page.

thanks! @markj what do you think?

Sun, Aug 23, 6:52 PM · Src Committers
adrian committed rG481314f620ac: rtwn: allow non-zero interface indexes (authored by vexeduxr).
rtwn: allow non-zero interface indexes
Sun, Aug 23, 4:50 PM
adrian committed rG006920b63c03: rtwn: add rtwn_efuse_preread (authored by vexeduxr).
rtwn: add rtwn_efuse_preread
Sun, Aug 23, 4:50 PM
adrian closed D59107: rtwn: allow non-zero interface indexes.
Sun, Aug 23, 4:49 PM · wireless, drivers
adrian closed D59106: rtwn: add rtwn_efuse_preread.
Sun, Aug 23, 4:49 PM
adrian accepted D59106: rtwn: add rtwn_efuse_preread.
Sun, Aug 23, 4:46 PM
adrian accepted D59107: rtwn: allow non-zero interface indexes.
Sun, Aug 23, 4:46 PM · wireless, drivers
adrian added a comment to D59107: rtwn: allow non-zero interface indexes.

Tested on RTL8192CU and RTL8188CUS as well. Probe/attach is fine for these two diffs.

Sun, Aug 23, 4:45 PM · wireless, drivers
adrian added a comment to D59107: rtwn: allow non-zero interface indexes.

Locally tested on RTL8821AU . We should test it on a few more just to make sure it's okay.

Sun, Aug 23, 4:41 PM · wireless, drivers
adrian added a comment to D58337: umtx: use a distribution-fair multiplier for the chain hash.

So hm, yay or nay on this?

Sun, Aug 23, 5:38 AM
adrian added a comment to D59107: rtwn: allow non-zero interface indexes.

same a the previous one; what devices have you tested this with?
It'd be good to know that it doesn't break any of the current rtwn USB devices.
(I'll try it myself locally tonight.)

Sun, Aug 23, 1:48 AM · wireless, drivers
adrian added projects to D59107: rtwn: allow non-zero interface indexes: drivers, wireless.

which devices have you tested this on? You should add that list to the commit message.

Sun, Aug 23, 1:48 AM · wireless, drivers

Sat, Aug 22

adrian committed rGbe503dd912a1: intelspi: add Lunar Lake SPI controller IDs (authored by seuros).
intelspi: add Lunar Lake SPI controller IDs
Sat, Aug 22, 2:46 AM
adrian committed rGca1a2bf39614: intelspi: add Arrow Lake SPI controller IDs (authored by seuros).
intelspi: add Arrow Lake SPI controller IDs
Sat, Aug 22, 2:46 AM
adrian committed rG6d4b45ac5c6c: intelspi: add Meteor Lake SPI controller IDs (authored by seuros).
intelspi: add Meteor Lake SPI controller IDs
Sat, Aug 22, 2:45 AM
adrian committed rGa6d84d04b3f2: intelspi: add Raptor Lake SPI controller IDs (authored by seuros).
intelspi: add Raptor Lake SPI controller IDs
Sat, Aug 22, 2:45 AM
adrian closed D59010: intelspi: add Lunar Lake SPI controller IDs.
Sat, Aug 22, 2:45 AM · drivers
adrian committed rG2dd4027c07e9: intelspi: add Alder Lake SPI controller IDs (authored by seuros).
intelspi: add Alder Lake SPI controller IDs
Sat, Aug 22, 2:45 AM
adrian closed D59009: intelspi: add Arrow Lake SPI controller IDs.
Sat, Aug 22, 2:45 AM · drivers
adrian closed D59008: intelspi: add Meteor Lake SPI controller IDs.
Sat, Aug 22, 2:45 AM · drivers
adrian closed D59007: intelspi: add Raptor Lake SPI controller IDs.
Sat, Aug 22, 2:45 AM · drivers
adrian committed rGbdda595a8ea3: intelspi: add Elkhart Lake SPI controller IDs (authored by seuros).
intelspi: add Elkhart Lake SPI controller IDs
Sat, Aug 22, 2:45 AM
adrian closed D59006: intelspi: add Alder Lake SPI controller IDs.
Sat, Aug 22, 2:44 AM · drivers
adrian committed rG3ff56f81a1a5: intelspi: add Tiger Lake SPI controller IDs (authored by seuros).
intelspi: add Tiger Lake SPI controller IDs
Sat, Aug 22, 2:44 AM
adrian closed D59005: intelspi: add Elkhart Lake SPI controller IDs.
Sat, Aug 22, 2:44 AM · drivers
adrian committed rGe7db9fa2e104: intelspi: add Jasper Lake SPI controller IDs (authored by seuros).
intelspi: add Jasper Lake SPI controller IDs
Sat, Aug 22, 2:44 AM
adrian closed D59004: intelspi: add Tiger Lake SPI controller IDs.
Sat, Aug 22, 2:44 AM · drivers
adrian closed D59003: intelspi: add Jasper Lake SPI controller IDs.
Sat, Aug 22, 2:44 AM · drivers
adrian committed rG88919d5ab6c4: intelspi: add Ice Lake SPI controller IDs (authored by seuros).
intelspi: add Ice Lake SPI controller IDs
Sat, Aug 22, 2:44 AM
adrian closed D59002: intelspi: add Ice Lake SPI controller IDs.
Sat, Aug 22, 2:44 AM · drivers
adrian committed rG0b4ff3e1def9: intelspi: add Lakefield SPI controller IDs (authored by seuros).
intelspi: add Lakefield SPI controller IDs
Sat, Aug 22, 2:44 AM
adrian closed D59001: intelspi: add Lakefield SPI controller IDs.
Sat, Aug 22, 2:43 AM · drivers

Fri, Aug 21

adrian committed rG26b921d8bd86: intelspi: add Cannon Lake SPI controller IDs (authored by seuros).
intelspi: add Cannon Lake SPI controller IDs
Fri, Aug 21, 5:45 PM
adrian committed rG9fb03dd2f759: intelspi: add Comet Lake SPI controller IDs (authored by seuros).
intelspi: add Comet Lake SPI controller IDs
Fri, Aug 21, 5:45 PM
adrian committed rG4c998ff28471: intelspi: add Apollo Lake SPI controller IDs (authored by seuros).
intelspi: add Apollo Lake SPI controller IDs
Fri, Aug 21, 5:45 PM
adrian committed rGa3489cc47083: intelspi: add Broxton SPI controller IDs (authored by seuros).
intelspi: add Broxton SPI controller IDs
Fri, Aug 21, 5:45 PM
adrian committed rG728775442c62: intelspi: sort PCI ID table by device ID (authored by seuros).
intelspi: sort PCI ID table by device ID
Fri, Aug 21, 5:45 PM
adrian closed D59000: intelspi: add Comet Lake SPI controller IDs.
Fri, Aug 21, 5:44 PM · drivers
adrian closed D58999: intelspi: add Cannon Lake SPI controller IDs.
Fri, Aug 21, 5:44 PM · drivers
adrian closed D58998: intelspi: add Apollo Lake SPI controller IDs.
Fri, Aug 21, 5:44 PM · drivers
adrian closed D58997: intelspi: add Broxton SPI controller IDs.
Fri, Aug 21, 5:44 PM · drivers
adrian closed D58996: intelspi: sort PCI ID table by device ID.
Fri, Aug 21, 5:44 PM · drivers
adrian accepted D59013: intelspi: add Nova Lake SPI controller IDs.
Fri, Aug 21, 4:01 PM · drivers
adrian accepted D59012: intelspi: add Panther Lake SPI controller IDs.
Fri, Aug 21, 4:00 PM · drivers
adrian accepted D59011: intelspi: add Wildcat Lake SPI controller IDs.
Fri, Aug 21, 4:00 PM · drivers
adrian accepted D59010: intelspi: add Lunar Lake SPI controller IDs.
Fri, Aug 21, 4:00 PM · drivers
adrian accepted D59009: intelspi: add Arrow Lake SPI controller IDs.
Fri, Aug 21, 4:00 PM · drivers
adrian accepted D59008: intelspi: add Meteor Lake SPI controller IDs.
Fri, Aug 21, 4:00 PM · drivers
adrian accepted D59007: intelspi: add Raptor Lake SPI controller IDs.
Fri, Aug 21, 4:00 PM · drivers
adrian accepted D59006: intelspi: add Alder Lake SPI controller IDs.
Fri, Aug 21, 3:59 PM · drivers
adrian accepted D59005: intelspi: add Elkhart Lake SPI controller IDs.
Fri, Aug 21, 3:59 PM · drivers
adrian accepted D59004: intelspi: add Tiger Lake SPI controller IDs.
Fri, Aug 21, 3:59 PM · drivers
adrian accepted D59003: intelspi: add Jasper Lake SPI controller IDs.
Fri, Aug 21, 3:59 PM · drivers
adrian accepted D59002: intelspi: add Ice Lake SPI controller IDs.
Fri, Aug 21, 3:59 PM · drivers
adrian accepted D59001: intelspi: add Lakefield SPI controller IDs.
Fri, Aug 21, 3:58 PM · drivers
adrian accepted D59000: intelspi: add Comet Lake SPI controller IDs.
Fri, Aug 21, 3:58 PM · drivers
adrian accepted D58999: intelspi: add Cannon Lake SPI controller IDs.
Fri, Aug 21, 3:58 PM · drivers
adrian accepted D58998: intelspi: add Apollo Lake SPI controller IDs.
Fri, Aug 21, 3:58 PM · drivers
adrian accepted D58997: intelspi: add Broxton SPI controller IDs.
Fri, Aug 21, 3:58 PM · drivers

Thu, Aug 20

adrian accepted D58627: powerpc/dma: Fix accounting and loading large segments.

build / boot tested on g5 powermac, ran a buildworld on it. all good so far.

Thu, Aug 20, 8:00 PM
adrian added a comment to D59019: git-arc: -t tag support for create to set Phabricator project tags.

devin, let's split the 'handle -h and provide better help' change from the tag handling change.

Thu, Aug 20, 4:31 PM · Src Committers
adrian added inline comments to D54211: libusb: change callback register handler to int.
Thu, Aug 20, 4:22 PM
adrian added a reviewer for D58996: intelspi: sort PCI ID table by device ID: wulf.

@wulf are these IDs (and the others in the stack) ok to you?

Thu, Aug 20, 3:20 PM · drivers
adrian added a comment to D58889: vchiq: Import two commits from upstream.

please at least test this with actual audio output (eg mpg123 with an mp3 into speakers.)

Thu, Aug 20, 2:35 PM
adrian added a comment to D58821: nvme: fix Apple S3X controller panic.

is there anything else needed for this?

Thu, Aug 20, 6:58 AM

Wed, Aug 19

adrian added a comment to D50174: mtw(4) Cleanup. No functional changes.

ooh crap how'd i forget about this? Let me go and re-test this and then get it landed.

Wed, Aug 19, 2:41 PM · wireless
adrian committed rG8ddc54f923ae: intelspi: add Gemini Lake SPI controller PCI IDs (authored by seuros).
intelspi: add Gemini Lake SPI controller PCI IDs
Wed, Aug 19, 2:08 AM
adrian committed rG99fda13f1c4a: net80211: migrate the ioctl API to a 128 bit specific API + use key API (authored by adrian).
net80211: migrate the ioctl API to a 128 bit specific API + use key API
Wed, Aug 19, 2:08 AM