Page MenuHomeFreeBSD

adrian (Adrian Chadd)
User

Projects (16)

User Details

User Since
May 14 2014, 7:57 AM (653 w, 10 h)

Recent Activity

Today

adrian accepted D61704: rge.4: Polish.
Wed, Nov 18, 4:06 PM
adrian added a comment to D60989: rng90: Microchip RNG90 I2C random number generator driver.

@ziaee anything else before I land this?

Wed, Nov 18, 6:30 AM
adrian accepted D61123: iwx: unbreak monitor mode support.

ok this looks fine then.

Wed, Nov 18, 2:21 AM · wireless

Mon, Nov 16

adrian accepted D59261: boot/powerpc: Add CAS support for native XIVE enable.

looks fine, please list what you've tested it on.

Mon, Nov 16, 9:25 PM
adrian accepted D59260: powerpc64/powernv: Migrate to PIC_AP_INIT.

Looks fine, please list what you've tested it on in the commit message.

Mon, Nov 16, 9:25 PM
adrian added a comment to D59259: powerpc/pseries: Add XIVE native mode to pseries.

first glance it looks fine - what did you test it on? would you mind listing in the commit what you've tested it on?

Mon, Nov 16, 9:24 PM
adrian added a comment to D61615: arm64: Fix EFI runtime lookups with efi_disable_vmap.

@imp any thoughts on this?

Mon, Nov 16, 3:05 PM · ARM, Contributor Reviews (src)
adrian added a project to D61615: arm64: Fix EFI runtime lookups with efi_disable_vmap: ARM.
Mon, Nov 16, 3:04 PM · ARM, Contributor Reviews (src)
adrian added a project to D61618: clk_fixed: Look up the parent of fixed-factor clocks in attach: ARM.
Mon, Nov 16, 3:04 PM · ARM, Contributor Reviews (src)
adrian added a project to D61619: arm64/gicv3: Honor redistributor-stride: ARM.
Mon, Nov 16, 3:04 PM · ARM, Contributor Reviews (src)
adrian added a project to D61614: arm64: Add the Qualcomm Oryon CPU part: ARM.
Mon, Nov 16, 3:04 PM · ARM, Contributor Reviews (src)
adrian added a comment to D61330: linux: Move the machine-dependent ioctl bits into per-arch headers.

i think this is fine, ty!

Mon, Nov 16, 12:54 AM

Sun, Nov 15

adrian added a comment to D61331: powerpc64: give processes a 48-bit address space by default.

shouldn't the userland tools be separate commits in a stack of commits?

Sun, Nov 15, 7:26 PM · PowerPC
adrian added a comment to D61594: ether_gen_addr(9): widen generated-OUI pool from 16 to 20 bits.

Are you only worried about the collisions inside a specific jail host, or does this include all the other freebsd machines an an L2 domain that may be bridging jails with virtual interfaces?

As far as I understand the implementation the issue is limited to the (jail) host only because the host uuid is taken into account. I would expect that there no two nodes on the network with the same host uuid.

Sun, Nov 15, 6:24 PM
adrian added a comment to D61594: ether_gen_addr(9): widen generated-OUI pool from 16 to 20 bits.

Are you only worried about the collisions inside a specific jail host, or does this include all the other freebsd machines an an L2 domain that may be bridging jails with virtual interfaces?

Sun, Nov 15, 6:05 PM
adrian accepted D61329: linux: Add a LINUX_TODO() macro.
Sun, Nov 15, 6:02 PM
adrian accepted D61489: asmc: do not report absent sensors as a temperature.

Accepted; please next time add some examples of what apple laptop models announce absent temp sensors via ASMC.

Sun, Nov 15, 5:59 PM

Sat, Nov 14

adrian added a project to D61462: net: traverse interface groups under the network epoch: network.
Sat, Nov 14, 7:05 PM · network
adrian added a comment to D61462: net: traverse interface groups under the network epoch.

This .. I think this requires a bit more net group digging. @glebius ?

Sat, Nov 14, 7:05 PM · network
adrian added a comment to D61463: tmpfs: drop the covered vnode lock around vflush.
In D61463#1409296, @kib wrote:

No this is wrong. The LoR reported is really a limitation of the witness and not the real exploitable LoR. It happens with any type of filesystem.

That said, the covered vnode must be locked for remounts and unmounts to prevent lookup from descending into the destroyed mount point.

Sat, Nov 14, 7:05 PM
adrian accepted D61538: asmc: rename asmcmmio.{c,h} to asmc_mmio.{c,h}.

thanks for renaming stuff.

Sat, Nov 14, 7:04 PM
adrian accepted D61537: asmc: make asmc_sysctl_add_system() void.
Sat, Nov 14, 7:03 PM
adrian accepted D61525: powerpc: fix the VSCR save and restore on little endian.
Sat, Nov 14, 3:40 AM

Fri, Nov 13

adrian added a comment to D61449: hwpmc: Fix use-after-free races between PMC release and context switches.

Yeah, maybe update the comment before quiesce_all_cpus() to be a bit clearer - something that summarises what your commit message says.
Maybe:

Fri, Nov 13, 5:04 PM
adrian added a comment to D61449: hwpmc: Fix use-after-free races between PMC release and context switches.

Hm, now that I'm looking at it .. is there really no way to make the pmc_process_csw_in() / pmc_process_csw_out() routines order things in a way that would avoid this?
I don't mind using a big hammer like this right now if there's no neater semantics to fix the refcount vs PMC alloc/dealloc logic, but I do wonder if some better lifecycle definition would make this less costly.

Fri, Nov 13, 3:34 PM
adrian accepted D60837: powerpc: don't drop FPU and VMX ownership in grab_mcontext().

@jhibbits what dou you think?

Fri, Nov 13, 3:02 PM

Thu, Nov 12

adrian accepted D61449: hwpmc: Fix use-after-free races between PMC release and context switches.
Thu, Nov 12, 7:38 PM
adrian accepted D59849: gre(4): Add full support for gre key.
Thu, Nov 12, 5:57 PM

Wed, Nov 11

adrian accepted D58924: pmc: Display a program level breakdown of performance data.
Wed, Nov 11, 11:16 PM
adrian accepted D58923: pmc: Display system level breakdown of performance data.
Wed, Nov 11, 11:15 PM
adrian added inline comments to D61447: pmc: Fix a few bugs and usability improvements to the pmc command.
Wed, Nov 11, 11:15 PM · pmc
adrian added a project to D61447: pmc: Fix a few bugs and usability improvements to the pmc command: pmc.
Wed, Nov 11, 11:12 PM · pmc
adrian accepted D59631: nvme: honor CRTO for the controller ready timeout.
Wed, Nov 11, 8:42 PM · drivers
adrian accepted D60989: rng90: Microchip RNG90 I2C random number generator driver.

this looks fine to me!

Wed, Nov 11, 5:27 PM
adrian accepted D59636: nvme: enforce the Abort Command Limit.
Wed, Nov 11, 5:19 PM

Tue, Nov 10

adrian accepted D60827: acpi_video: dim the internal panel while the lid is closed.
Tue, Nov 10, 7:05 PM · drivers
adrian accepted D60826: acpi_video: fall back to _BCL when _DOD matches no output.
Tue, Nov 10, 7:05 PM · drivers
adrian accepted D61383: asmc: do not enable the sudden motion sensor on the MMIO backend.

oops ;-p

Tue, Nov 10, 3:46 PM
adrian updated subscribers of D61331: powerpc64: give processes a 48-bit address space by default.

@kib do you have any thoughts?

Tue, Nov 10, 4:51 AM · PowerPC
adrian added a project to D61331: powerpc64: give processes a 48-bit address space by default: PowerPC.
Tue, Nov 10, 4:50 AM · PowerPC

Mon, Nov 9

adrian accepted D59596: intel/intel_pmc: Add support for Cannon Lake through Meteor Lake.
Mon, Nov 9, 7:16 PM · drivers

Sun, Nov 8

adrian added a comment to D61330: linux: Move the machine-dependent ioctl bits into per-arch headers.

looks good to me. what do others think?

Sun, Nov 8, 11:46 PM
adrian added a comment to D61320: if_firewire: Be more robust while checking the frame size.

is m_len / m_pktlen ever supposed to be negative?

They should not be negative. But buggy driver / net stack logic may lead to. Here is an example 6429199a2113 (llan: byte swap the receive queue entries) .

Sun, Nov 8, 6:26 PM · firewire
adrian added a comment to D61320: if_firewire: Be more robust while checking the frame size.

is m_len / m_pktlen ever supposed to be negative?

Sun, Nov 8, 5:14 PM · firewire
adrian added a reviewer for D61320: if_firewire: Be more robust while checking the frame size: seuros.
Sun, Nov 8, 4:47 PM · firewire
adrian added a comment to D61300: asmc: split the sysctl layer into asmcsysctl.c.

i wish i had caught it earlier; what do you think about separating out the new filenames with underscores? ie asmc_sysctl.c ?

Sun, Nov 8, 7:31 AM

Sat, Nov 7

adrian added a comment to D60760: linux: Bound native getdents and getdents64 batches.

@kevans ok so is this ready to merge into -head? do we want to get this quickly into the next -15 release? Cause now's the time.

Sat, Nov 7, 6:24 PM
adrian accepted D61303: asmc: compare integer results to zero explicitly.
Sat, Nov 7, 5:24 PM
adrian accepted D61283: asmc: factor out the PIO data port byte loops.

fiiiiiine

Sat, Nov 7, 5:17 PM
adrian added inline comments to D61293: asmc: move the sysctl registration loops next to their tables.
Sat, Nov 7, 5:13 PM
adrian accepted D61293: asmc: move the sysctl registration loops next to their tables.
Sat, Nov 7, 5:10 PM
adrian accepted D61292: asmc: make the raw key debug state unconditional.
Sat, Nov 7, 5:10 PM
adrian accepted D61291: asmc: move the backlight control level into the softc.
Sat, Nov 7, 5:10 PM
adrian accepted D61290: asmc: correct the copyright address in asmcmmio.
Sat, Nov 7, 5:10 PM
adrian accepted D61289: asmc: scan every sensor range through one helper.
Sat, Nov 7, 5:09 PM
adrian accepted D61288: asmc: table-drive the system state and board identity sysctls.
Sat, Nov 7, 5:09 PM
adrian accepted D61287: asmc: collapse the SMS axis and light sensor sysctl handlers.
Sat, Nov 7, 5:08 PM
adrian accepted D61286: asmc: collapse the per-fan speed sysctl handlers.
Sat, Nov 7, 5:08 PM
adrian accepted D61285: asmc: share the getinfo and getbyindex PIO transactions.
Sat, Nov 7, 5:07 PM
adrian accepted D61284: asmc: rebuild asmc_key_dump on the by-index helper.
Sat, Nov 7, 5:07 PM
adrian added a comment to D61283: asmc: factor out the PIO data port byte loops.

all the examples in style(9) check for equality or non equality of zero. I think we should do the same here.

Sat, Nov 7, 5:05 PM
adrian added inline comments to D61283: asmc: factor out the PIO data port byte loops.
Sat, Nov 7, 5:05 PM
adrian accepted D61278: xhci: only set the slot context parent hub fields on xHCI 1.2.
Sat, Nov 7, 4:32 AM · drivers, USB

Fri, Nov 6

adrian added a comment to D61278: xhci: only set the slot context parent hub fields on xHCI 1.2.

This looks fine to me. I wonder who else we should tag. @aokblast ?

Fri, Nov 6, 11:19 PM · drivers, USB
adrian added projects to D61278: xhci: only set the slot context parent hub fields on xHCI 1.2: USB, drivers.
Fri, Nov 6, 11:18 PM · drivers, USB
adrian accepted D61260: asmc: notify the SMC of shutdown and restart.
Fri, Nov 6, 9:34 PM
adrian added a comment to D61260: asmc: notify the SMC of shutdown and restart.

Approved; please add a Tested section listing some of the hardware you tested it on and what happened before/after.

Fri, Nov 6, 5:10 PM
adrian added a comment to D60767: hwpmc: add PMC_OP_GETCPUMASK.

In general this looks fine. Are these search/mask routines being called during any hot paths or only when setup/teardown/userland stuff is being called?

Fri, Nov 6, 3:44 PM

Thu, Nov 5

adrian accepted D61110: pci: restore resizable BAR sizes in pci_cfg_restore().
Thu, Nov 5, 6:29 PM

Wed, Nov 4

adrian closed D61125: LinuxKPI: set pci_dev msi_cap and msix_cap.
Wed, Nov 4, 10:50 PM · linuxkpi
adrian committed rG0ecbb75c33d3: LinuxKPI: set pci_dev msi_cap and msix_cap (authored by quentin.thebault_defenso.fr).
Wed, Nov 4, 10:50 PM
adrian added a reviewer for D58560: Adding libxo support to ifconfig (XML / JSON output): phil.
Wed, Nov 4, 7:35 PM
adrian committed rGe9e4115a0bb4: cp2112: Check status errors and bound I2C waits (authored by ptudor_ptudor.net).
Wed, Nov 4, 7:12 PM
adrian closed D61065: cp2112: Check status errors and bound I2C waits.
Wed, Nov 4, 7:12 PM · USB, drivers
adrian accepted D61065: cp2112: Check status errors and bound I2C waits.
Wed, Nov 4, 6:13 PM · USB, drivers

Tue, Nov 3

adrian added a comment to D61065: cp2112: Check status errors and bound I2C waits.

This /looks/ fine to me, but there's too much commenting for what's really self evident stuff.

Tue, Nov 3, 5:56 PM · USB, drivers
adrian accepted D60972: introduce MSEC_TO_NSEC().

In general it's okay, but i would like there to be a doxygen comment explaining what the call does and its expected behaviour.
(eg calling out its overflow -> clamp behaviour.)

Tue, Nov 3, 5:16 PM
adrian accepted D60988: sdiob: copy vendor/device IDs from card common CIS.

feel free to commit it. nice catch!

Tue, Nov 3, 4:30 PM
adrian accepted D61008: ppp: drop config packets whose options overrun the packet.
Tue, Nov 3, 4:30 PM · secteam
adrian added a reviewer for D61125: LinuxKPI: set pci_dev msi_cap and msix_cap: adrian.
Tue, Nov 3, 4:18 PM · linuxkpi

Mon, Nov 2

adrian added reviewers for D61148: mei: add a driver for the Intel Management Engine Interface: x86, ziaee.

Tag @ziaee for docs

Mon, Nov 2, 9:31 PM · x86
adrian accepted D60984: jail: return a new descriptor from jail_get(JAIL_USE_DESC | JAIL_GET_DESC).
Mon, Nov 2, 6:02 PM
adrian accepted D61006: linux: do not truncate the listxattr() size.
Mon, Nov 2, 4:40 PM · secteam
adrian added a comment to D58132: netinet6: Fix ND link-layer address option layout for IPoIB (stable/15).

ok, thats landed! if you need anything else vinicius then reach out to rick and i, we'll figure it out and make it happen!

Mon, Nov 2, 3:54 PM
adrian committed rGc4b6df9a7cc9: netinet6: Fix ND link-layer address option layout for IPoIB (stable/15) (authored by vinicius_ferrao.net.br).
Mon, Nov 2, 3:50 PM
adrian closed D58132: netinet6: Fix ND link-layer address option layout for IPoIB (stable/15).
Mon, Nov 2, 3:50 PM
adrian added a comment to D58132: netinet6: Fix ND link-layer address option layout for IPoIB (stable/15).

oh is this not yet landed into stable/15 ? I can go do that. oops!

Mon, Nov 2, 3:42 PM
adrian added a comment to D60984: jail: return a new descriptor from jail_get(JAIL_USE_DESC | JAIL_GET_DESC).

This looks fine to me. @jamie one final pass?

Mon, Nov 2, 3:21 PM
adrian added a project to D61125: LinuxKPI: set pci_dev msi_cap and msix_cap: linuxkpi.

nice catch! bz, what do you think?

Mon, Nov 2, 5:05 AM · linuxkpi
adrian added a reviewer for D61123: iwx: unbreak monitor mode support: wireless.
Mon, Nov 2, 5:04 AM · wireless
adrian added a comment to D61123: iwx: unbreak monitor mode support.

oh these are good catches! I'll test them on my iwx laptop tomorrow and get back to you!

Mon, Nov 2, 5:04 AM · wireless

Sun, Nov 1

adrian added a comment to D59481: LinuxKPI: preserve shmem backing ownership for managed PFN mappings.

@oleglelchuk_gmail.com did you test https://reviews.freebsd.org/D59883 instead of this diff? did it help at all?

I thought the D59883 approach was still in its early stages of development. If no changes are made to the D59883 patch in the coming weeks, I will test it.

Sun, Nov 1, 6:15 PM

Sat, Oct 31

adrian added a reviewer for D61065: cp2112: Check status errors and bound I2C waits: wulf.

@wulf any comments re: i2c'ness?

Sat, Oct 31, 9:08 PM · USB, drivers
adrian committed rGa7a4583702f4: rge: Preserve replacement mbufs after defragmentation (authored by Andrew Griffiths <andrew@calif.io>).
Sat, Oct 31, 9:05 PM
adrian committed rG5211e4330fb8: rge: Fix 32-bit powerpc build (authored by jhibbits).
Sat, Oct 31, 8:25 PM
adrian committed rG9971ac5cdd01: rge: fix VLAN hardware tagging (authored by • john.darrah09_gmail.com).
Sat, Oct 31, 8:25 PM
adrian committed rG4f624f85cd3a: rge: add the Intel Killer E5000 PCI ID (authored by kevans).
Sat, Oct 31, 8:25 PM
adrian committed rG99d566e8f63a: rge: add Wake-on-LAN support for magic packet (authored by longros).
Sat, Oct 31, 8:25 PM
adrian committed rG75a29ec97714: rge: add disable_aspm tunable for PCIe power management (authored by longros).
Sat, Oct 31, 8:25 PM
adrian committed rG424339c7d300: rge: fix multicast add/removal by using if_getdrvflags().
Sat, Oct 31, 8:25 PM