Page MenuHomeFreeBSD

adrian (Adrian Chadd)
User

Projects

User Details

User Since
May 14 2014, 7:57 AM (332 w, 5 d)

Recent Activity

Sat, Sep 26

adrian accepted D26554: rtwn: narrow the epoch area.
Sat, Sep 26, 7:17 PM

Fri, Sep 25

adrian added a comment to D26554: rtwn: narrow the epoch area.

Yeah, if we ever support pushing a list of receive frames into the net80211 stack, complete with rx status in the mbuf tags, then I think we can do this in net80211 quite nicely. :-)

Fri, Sep 25, 4:59 PM
adrian added a comment to D26554: rtwn: narrow the epoch area.

I'm not a huge fan of this cause honestly we should be doing the epoch enter/exit around a batch.

Fri, Sep 25, 4:48 PM

Thu, Sep 24

adrian accepted D26539: Provide MS() and SM() macros for 80211..
Thu, Sep 24, 3:01 AM
adrian accepted D26541: net80211: factor out the priv(9) checks into OS specifc code..
Thu, Sep 24, 3:00 AM

Mon, Sep 21

adrian committed rS365957: [rcorder] [crunch] Fix C function declarations to include void.
[rcorder] [crunch] Fix C function declarations to include void
Mon, Sep 21, 6:00 PM
adrian closed D26504: fix compiler warnings-as-errors on gcc6 in rcorder/crunchgen.
Mon, Sep 21, 6:00 PM
adrian added a comment to D26504: fix compiler warnings-as-errors on gcc6 in rcorder/crunchgen.

ignore the pmc related bits, it's not relevant for this fix

Mon, Sep 21, 6:35 AM
adrian requested review of D26504: fix compiler warnings-as-errors on gcc6 in rcorder/crunchgen.
Mon, Sep 21, 6:33 AM

Mon, Aug 31

adrian accepted D26258: libifconfig now depends on libm due to usage of log10()..

Lol, who did that? :-)

Mon, Aug 31, 10:59 PM
adrian accepted D26256: Fix the build of scandir_b with GCC..

Thanks! There's another _b.c file that isn't linked into the build yet that needs similar treatment.

Mon, Aug 31, 8:05 PM

Aug 24 2020

adrian accepted D26091: net80211: enhance getflags*() and ieee80211_add_channel*().
Aug 24 2020, 12:59 AM

Aug 23 2020

adrian accepted D26088: net80211: set_vht_extchan() reverse order to always return best.
Aug 23 2020, 4:43 PM
adrian accepted D26089: net80211: improve media information for VHT5GHZ.
Aug 23 2020, 4:41 PM

Aug 18 2020

adrian added a comment to D26091: net80211: enhance getflags*() and ieee80211_add_channel*().

The MS-SM stuff being defined half way through the code is left over from sam-days.

Aug 18 2020, 9:27 PM

Aug 17 2020

adrian accepted D26087: net80211: VHT correct NSS Set loop boundary.

Oh yeah, good catch! We should also replace this with a define so we know how many max mcs streams is supported.

Aug 17 2020, 5:45 PM
adrian accepted D26090: net80211: replace magic number by define.
Aug 17 2020, 5:43 PM

Aug 16 2020

adrian accepted D26002: 80211: consistently order 160 and 80+80.
Aug 16 2020, 1:18 AM
adrian accepted D26001: 80211: consistently spell 80P80.
Aug 16 2020, 1:17 AM
adrian accepted D26000: net80211 / ifconfig: cleanup the use of IEEE80211_FVHT_USEVHT*.
Aug 16 2020, 1:17 AM

Aug 9 2020

adrian added a comment to D26018: Methodize the TX power limit retrival in ieee80211_ioctl_get80211().

.. next to the existing node one

Aug 9 2020, 7:26 PM · wireless
adrian added a comment to D26018: Methodize the TX power limit retrival in ieee80211_ioctl_get80211().

Let's make it more generic - and I thought it was - oh yeah! Look at ieee80211_get_node_txpower().

Aug 9 2020, 7:25 PM · wireless

Aug 5 2020

adrian added a comment to D25964: emulators/sdltrs.

i like it! *ship*

Aug 5 2020, 6:31 PM

Jul 27 2020

adrian accepted D25832: net80211/ifconfig: print hardware device name for wlan interfaces.

Cool! Just fix the typo that idwer pointed out, but nice work

Jul 27 2020, 3:13 PM

Jul 19 2020

adrian added a comment to D25630: [net0211] Add new capabilities; restrict what can be done in a jail..
In D25630#569426, @imp wrote:

I think this broke the build on r363327 with if_an.

Maybe we should just retire wi and an? They are no longer relevant.

Jul 19 2020, 6:18 PM
adrian committed rS363328: [if_an] unbreak!.
[if_an] unbreak!
Jul 19 2020, 5:28 PM
adrian closed D25723: if_an: Unbreak build with PRIV_NET80211_MANAGE->PRIV_NET80211_VAP_MANAGE rename.
Jul 19 2020, 5:28 PM
adrian accepted D25723: if_an: Unbreak build with PRIV_NET80211_MANAGE->PRIV_NET80211_VAP_MANAGE rename.
Jul 19 2020, 5:27 PM
adrian committed rS363327: [net80211] missing from last commit, le whoops.
[net80211] missing from last commit, le whoops
Jul 19 2020, 4:08 PM
adrian committed rS363325: [net80211] Add new privileges; restrict what can be done in a jail..
[net80211] Add new privileges; restrict what can be done in a jail.
Jul 19 2020, 3:16 PM
adrian closed D25630: [net0211] Add new capabilities; restrict what can be done in a jail..
Jul 19 2020, 3:16 PM
adrian added a comment to D25630: [net0211] Add new capabilities; restrict what can be done in a jail..

Updated from feedback

Jul 19 2020, 5:55 AM
adrian updated the diff for D25630: [net0211] Add new capabilities; restrict what can be done in a jail..

Take on comments from bz

Jul 19 2020, 5:54 AM
adrian added inline comments to D25630: [net0211] Add new capabilities; restrict what can be done in a jail..
Jul 19 2020, 5:53 AM

Jul 15 2020

adrian committed rS363236: [ar71xx] fix watchdog to work on subsequent SoCs.
[ar71xx] fix watchdog to work on subsequent SoCs
Jul 15 2020, 7:34 PM

Jul 14 2020

adrian requested review of D25670: [usb] Break out the USB controller and IO bus parts into separate modules.
Jul 14 2020, 7:57 PM
adrian added inline comments to D25359: cp2112: driver for the namesake GPIO and I2C master gadget.
Jul 14 2020, 6:17 AM
adrian accepted D25359: cp2112: driver for the namesake GPIO and I2C master gadget.

the GPIO/i2c bits at first glance look ok.

Jul 14 2020, 6:15 AM
adrian committed rS363176: [pmc] whoops, remove spurious #'s.
[pmc] whoops, remove spurious #'s
Jul 14 2020, 5:33 AM
adrian committed rS363174: [hwpmc] Compile 'pmc' only if we have C++11..
[hwpmc] Compile 'pmc' only if we have C++11.
Jul 14 2020, 5:10 AM
adrian committed rS363173: [ipfw] quieten maybe-uninitialized errors in ipfw when compiled under mips-gcc….
[ipfw] quieten maybe-uninitialized errors in ipfw when compiled under mips-gcc…
Jul 14 2020, 5:07 AM
adrian committed rS363172: [bc] Fix a "maybe uninitialized" compiler warning under mips-gcc-6.3.0..
[bc] Fix a "maybe uninitialized" compiler warning under mips-gcc-6.3.0.
Jul 14 2020, 5:02 AM
adrian committed rS363171: [flex] Fix compilation issue under mips-gcc-6.4.
[flex] Fix compilation issue under mips-gcc-6.4
Jul 14 2020, 5:00 AM

Jul 12 2020

adrian added a reviewer for D25630: [net0211] Add new capabilities; restrict what can be done in a jail.: wireless.
Jul 12 2020, 4:40 AM
adrian requested review of D25630: [net0211] Add new capabilities; restrict what can be done in a jail..
Jul 12 2020, 3:18 AM

Jul 5 2020

adrian accepted D23461: netgraph: Add RFC 6598/Carrier Grade NAT support to ng_nat.
Jul 5 2020, 5:26 PM · network

Jul 4 2020

adrian accepted D23356: natd: Add support for RFC 6598/Carrier Grade NAT subnets via libalias.
Jul 4 2020, 10:43 PM · network

Jul 1 2020

adrian committed rS362816: [net80211] Commit files missing in the previous commit.
[net80211] Commit files missing in the previous commit
Jul 1 2020, 12:25 AM
adrian committed rS362815: [net80211] Migrate HT/legacy protection mode and preamble calculation to per….
[net80211] Migrate HT/legacy protection mode and preamble calculation to per…
Jul 1 2020, 12:24 AM

Jun 28 2020

adrian committed rS362718: [fifolog] wrap the recno when we hit the end of the provided file size..
[fifolog] wrap the recno when we hit the end of the provided file size.
Jun 28 2020, 6:53 AM
adrian closed D25478: [fifolog] Wrap to the beginning of the file once the end of the file is reached.
Jun 28 2020, 6:53 AM

Jun 27 2020

adrian added a comment to D25478: [fifolog] Wrap to the beginning of the file once the end of the file is reached.
In D25478#562806, @phk wrote:

Yeah, that's clearly an oversight.

In the original application this code came from, the write error propagated up and was used to register how many times the flash had been written.

That code did not become part of the fifolog_writer(1) program, which silently ignores the errors from fifolog_write_record_poll().

Wrapping in the lib code probably makes most sense in this stand alone usage of the code, but fifolog_writer(1) should also report write errors back.

Jun 27 2020, 5:07 PM
adrian committed rS362671: [ath_hal] Add KeyMiss for AR5212/AR5416 series chips..
[ath_hal] Add KeyMiss for AR5212/AR5416 series chips.
Jun 27 2020, 3:00 AM
adrian updated the diff for D25478: [fifolog] Wrap to the beginning of the file once the end of the file is reached.

I noticed we were off by one; the file size ended up being one record
longer than specified. This fixes it.

Jun 27 2020, 12:11 AM

Jun 26 2020

adrian updated the diff for D25478: [fifolog] Wrap to the beginning of the file once the end of the file is reached.

Oops - update comment. Thanks jude!

Jun 26 2020, 11:26 PM
adrian added inline comments to D25478: [fifolog] Wrap to the beginning of the file once the end of the file is reached.
Jun 26 2020, 11:25 PM
adrian added a reviewer for D25478: [fifolog] Wrap to the beginning of the file once the end of the file is reached: phk.
Jun 26 2020, 9:23 PM
adrian requested review of D25478: [fifolog] Wrap to the beginning of the file once the end of the file is reached.
Jun 26 2020, 9:23 PM

Jun 23 2020

adrian closed D25113: [iwn] add mpdu density and ampdu rx max..
Jun 23 2020, 3:21 AM
adrian closed D25108: [run] Set the number of rx/tx streams according to hw register.
Jun 23 2020, 3:21 AM · wireless
adrian requested review of D25113: [iwn] add mpdu density and ampdu rx max..
Jun 23 2020, 3:20 AM
adrian requested review of D25060: [iwn] Add rxampdu density and size.
Jun 23 2020, 3:20 AM
adrian accepted D24733: teach ena driver about RSS kernel option.
Jun 23 2020, 1:03 AM

Jun 19 2020

adrian accepted D25312: Relax the rule against declaring variables in nested scopes..
Jun 19 2020, 4:05 PM

Jun 17 2020

adrian committed rS362256: [run] mention that some 11n functionality is now available..
[run] mention that some 11n functionality is now available.
Jun 17 2020, 3:28 AM

Jun 16 2020

adrian committed rS362216: [ifconfig] add UAPSD and LPDC flags.
[ifconfig] add UAPSD and LPDC flags
Jun 16 2020, 4:17 AM
adrian committed rS362213: [rsu] Update wme ie API use..
[rsu] Update wme ie API use.
Jun 16 2020, 1:11 AM
adrian committed rS362212: [net80211] Add missing commit to previous-1 uapsd commit..
[net80211] Add missing commit to previous-1 uapsd commit.
Jun 16 2020, 12:28 AM
adrian committed rS362211: [net80211] Add uapsd option to ifconfig.
[net80211] Add uapsd option to ifconfig
Jun 16 2020, 12:28 AM
adrian committed rS362210: [net80211] Add initial U-APSD negotiation support..
[net80211] Add initial U-APSD negotiation support.
Jun 16 2020, 12:27 AM

Jun 14 2020

adrian committed rS362162: [net80211] Treat frames without an rx status as not a decap'ed A-MSDU..
[net80211] Treat frames without an rx status as not a decap'ed A-MSDU.
Jun 14 2020, 12:23 AM
adrian committed rS362161: [net80211] Also convert the ddb path.
[net80211] Also convert the ddb path
Jun 14 2020, 12:22 AM

Jun 13 2020

adrian committed rS362157: [net80211] Handle offloaded AMSDU in AMPDU reordering..
[net80211] Handle offloaded AMSDU in AMPDU reordering.
Jun 13 2020, 11:35 PM
adrian committed rS362156: [net80211] separate out node allocation and node initialisation..
[net80211] separate out node allocation and node initialisation.
Jun 13 2020, 10:20 PM

Jun 12 2020

adrian added a comment to D17308: net80211: Enable netdump support.

looks fine to me, other OSes won't use it but it won't matter. Land it!

Jun 12 2020, 7:40 PM
adrian committed rS362085: [wlanstats] Add the per-node amsdu hardware decap'ed receive stats..
[wlanstats] Add the per-node amsdu hardware decap'ed receive stats.
Jun 12 2020, 6:10 AM
adrian committed rS362084: [net80211] First part of A-MSDU offload handling - don't bump A-MPDU reordering….
[net80211] First part of A-MSDU offload handling - don't bump A-MPDU reordering…
Jun 12 2020, 4:19 AM

Jun 11 2020

adrian added a comment to D25236: [net80211] First part of A-MSDU offload handling - don't bump A-MPDU reordering seqno.

ugh, only look at ieee80211_ht.c ; ignore the crypto changes. Whoops.

Jun 11 2020, 6:12 PM
adrian requested review of D25236: [net80211] First part of A-MSDU offload handling - don't bump A-MPDU reordering seqno.
Jun 11 2020, 6:11 PM

Jun 10 2020

adrian committed rS362016: [net80211] ok ok if_xname won't ever be NULL..
[net80211] ok ok if_xname won't ever be NULL.
Jun 10 2020, 7:00 PM

Jun 7 2020

adrian committed rS361886: [if_ath] Don't update the beacon bits from beacon frames in hostapd mode..
[if_ath] Don't update the beacon bits from beacon frames in hostapd mode.
Jun 7 2020, 5:08 AM
adrian committed rS361885: [net80211] Add a method to return the vap's ifname..
[net80211] Add a method to return the vap's ifname.
Jun 7 2020, 4:58 AM

Jun 6 2020

adrian committed rS361878: [net80211] Flip on A-MPDU, A-MSDU, A-MPDU+A-MSDU and Fast frames options..
[net80211] Flip on A-MPDU, A-MSDU, A-MPDU+A-MSDU and Fast frames options.
Jun 6 2020, 10:25 PM
adrian committed rS361864: [net80211] Fix this typo!.
[net80211] Fix this typo!
Jun 6 2020, 6:18 AM
adrian committed rS361863: [net80211] Fix typo..
[net80211] Fix typo.
Jun 6 2020, 5:46 AM

Jun 5 2020

adrian committed rS361834: [net80211] Don't call ic_updateslot if it's not set..
[net80211] Don't call ic_updateslot if it's not set.
Jun 5 2020, 2:17 PM
adrian committed rS361826: [net80211] print out node A-MSDU state..
[net80211] print out node A-MSDU state.
Jun 5 2020, 7:39 AM
adrian committed rS361825: [net80211] Add initial A-MSDU in A-MPDU negotation support..
[net80211] Add initial A-MSDU in A-MPDU negotation support.
Jun 5 2020, 7:38 AM
adrian committed rS361822: [net80211] Migrate short slot time configuration into per-vap and deferred….
[net80211] Migrate short slot time configuration into per-vap and deferred…
Jun 5 2020, 6:21 AM
adrian committed rS361821: [net80211] Add some TODOs around A-MSDU in A-MPDU negotiation..
[net80211] Add some TODOs around A-MSDU in A-MPDU negotiation.
Jun 5 2020, 6:07 AM
adrian committed rS361820: [iwn] Set default ampdu parameters..
[iwn] Set default ampdu parameters.
Jun 5 2020, 4:25 AM
adrian committed rS361819: [net80211] Add field definition for A-MSDU inside A-MPDU..
[net80211] Add field definition for A-MSDU inside A-MPDU.
Jun 5 2020, 4:05 AM
adrian committed rS361813: [net80211] Add some more debugging during scanning.
[net80211] Add some more debugging during scanning
Jun 5 2020, 12:17 AM
adrian committed rS361812: [net80211] Print out a bad PN in both hex and decimal..
[net80211] Print out a bad PN in both hex and decimal.
Jun 5 2020, 12:14 AM
adrian committed rS361811: [net80211] Send a probe request after IBSS node discovery.
[net80211] Send a probe request after IBSS node discovery
Jun 5 2020, 12:11 AM
adrian closed D24979: [net80211] Send a probe request after IBSS node discovery.
Jun 5 2020, 12:11 AM

Jun 3 2020

adrian added a comment to D24989: netinet: Generate a random RSS key on boot..

i remember there was some concern in the past where there were very bad rss key choices out there. is there a reason for actually pushing for a random rss key?

Jun 3 2020, 11:10 PM · csprng, network
adrian committed rS361778: [run] Fix up tx/rx frame size..
[run] Fix up tx/rx frame size.
Jun 3 2020, 10:30 PM
adrian committed rS361768: [otus] enable 802.11n for 2GHz and 5GHz..
[otus] enable 802.11n for 2GHz and 5GHz.
Jun 3 2020, 8:25 PM
adrian added a reviewer for D25113: [iwn] add mpdu density and ampdu rx max.: wireless.
Jun 3 2020, 7:34 AM