User Details
- User Since
- May 14 2014, 7:57 AM (653 w, 10 h)
Today
@ziaee anything else before I land this?
ok this looks fine then.
Mon, Nov 16
looks fine, please list what you've tested it on.
Looks fine, please list what you've tested it on in the commit message.
first glance it looks fine - what did you test it on? would you mind listing in the commit what you've tested it on?
@imp any thoughts on this?
i think this is fine, ty!
Sun, Nov 15
shouldn't the userland tools be separate commits in a stack of commits?
Are you only worried about the collisions inside a specific jail host, or does this include all the other freebsd machines an an L2 domain that may be bridging jails with virtual interfaces?
Accepted; please next time add some examples of what apple laptop models announce absent temp sensors via ASMC.
Sat, Nov 14
This .. I think this requires a bit more net group digging. @glebius ?
thanks for renaming stuff.
Fri, Nov 13
Yeah, maybe update the comment before quiesce_all_cpus() to be a bit clearer - something that summarises what your commit message says.
Maybe:
Hm, now that I'm looking at it .. is there really no way to make the pmc_process_csw_in() / pmc_process_csw_out() routines order things in a way that would avoid this?
I don't mind using a big hammer like this right now if there's no neater semantics to fix the refcount vs PMC alloc/dealloc logic, but I do wonder if some better lifecycle definition would make this less costly.
@jhibbits what dou you think?
Thu, Nov 12
Wed, Nov 11
this looks fine to me!
Tue, Nov 10
oops ;-p
@kib do you have any thoughts?
Mon, Nov 9
Sun, Nov 8
looks good to me. what do others think?
is m_len / m_pktlen ever supposed to be negative?
i wish i had caught it earlier; what do you think about separating out the new filenames with underscores? ie asmc_sysctl.c ?
Sat, Nov 7
@kevans ok so is this ready to merge into -head? do we want to get this quickly into the next -15 release? Cause now's the time.
all the examples in style(9) check for equality or non equality of zero. I think we should do the same here.
Fri, Nov 6
This looks fine to me. I wonder who else we should tag. @aokblast ?
Approved; please add a Tested section listing some of the hardware you tested it on and what happened before/after.
In general this looks fine. Are these search/mask routines being called during any hot paths or only when setup/teardown/userland stuff is being called?
Thu, Nov 5
Wed, Nov 4
Tue, Nov 3
This /looks/ fine to me, but there's too much commenting for what's really self evident stuff.
In general it's okay, but i would like there to be a doxygen comment explaining what the call does and its expected behaviour.
(eg calling out its overflow -> clamp behaviour.)
feel free to commit it. nice catch!
Mon, Nov 2
Tag @ziaee for docs
ok, thats landed! if you need anything else vinicius then reach out to rick and i, we'll figure it out and make it happen!
oh is this not yet landed into stable/15 ? I can go do that. oops!
This looks fine to me. @jamie one final pass?
nice catch! bz, what do you think?
oh these are good catches! I'll test them on my iwx laptop tomorrow and get back to you!
Sun, Nov 1
Sat, Oct 31
@wulf any comments re: i2c'ness?
