Page MenuHomeFreeBSD

thj (Tom Jones)
User

Projects

User Details

User Since
Jan 7 2016, 3:15 PM (192 w, 3 d)

Recent Activity

Sun, Aug 18

thj added inline comments to D21305: Add set ToS test for ipfw and pf.
Sun, Aug 18, 6:05 PM
D21276: Move pft_ping.py and sniffer.py to the common test directory is now accepted and ready to land.
Sun, Aug 18, 5:57 PM

Aug 17 2019

thj committed rS351166: Reduce size of EFI_STAGING_SIZE to 32 on arm.
Reduce size of EFI_STAGING_SIZE to 32 on arm
Aug 17 2019, 6:48 AM
thj closed D21016: Reduce size of EFI_STAGING_SIZE to 32 on arm.
Aug 17 2019, 6:48 AM
thj committed rS351165: Add basic NAT test for pf, ipf and ipfw.
Add basic NAT test for pf, ipf and ipfw
Aug 17 2019, 6:44 AM
thj closed D21199: NAT basic test for pf, ipfw (both in-kernel and userspace) and ipf.
Aug 17 2019, 6:44 AM

Aug 14 2019

D21199: NAT basic test for pf, ipfw (both in-kernel and userspace) and ipf is now accepted and ready to land.
Aug 14 2019, 12:17 PM
thj retitled D21016: Reduce size of EFI_STAGING_SIZE to 32 on arm from Reduce size of EFI_STAGING_SIZE to 32 to Reduce size of EFI_STAGING_SIZE to 32 on arm.
Aug 14 2019, 9:03 AM

Aug 10 2019

thj added inline comments to D21199: NAT basic test for pf, ipfw (both in-kernel and userspace) and ipf.
Aug 10 2019, 1:39 PM

Aug 8 2019

thj added inline comments to D21179: Add header definition for RFC4340, Datagram Congestion Control Protocol.
Aug 8 2019, 3:25 PM
thj added a comment to D21016: Reduce size of EFI_STAGING_SIZE to 32 on arm.

Remove accidentally added file

Aug 8 2019, 12:57 PM
thj retitled D21016: Reduce size of EFI_STAGING_SIZE to 32 on arm from Reduce size of EFI_STAGING_SIZE to 32 This allows loader to start on the 256MB NanoPi-NEOLTS model to Reduce size of EFI_STAGING_SIZE to 32.
  • Only reduce staging size on arm
Aug 8 2019, 12:57 PM
thj closed D21178: Rename IPPROTO 33 from SEP to DCCP.
Aug 8 2019, 11:43 AM
thj committed rS350749: Rename IPPROTO 33 from SEP to DCCP.
Rename IPPROTO 33 from SEP to DCCP
Aug 8 2019, 11:43 AM
thj added a reviewer for D18908: Added SOCKS5 support to libfetch: thj.
Aug 8 2019, 8:07 AM

Aug 7 2019

thj added a comment to D21179: Add header definition for RFC4340, Datagram Congestion Control Protocol.

Extend the sequence number field to include a reserved byte in the long header.

Aug 7 2019, 4:44 PM
thj created D21180: Add Parameter Problem type for Incomplete Header Chain.
Aug 7 2019, 2:02 PM
thj added a comment to D21179: Add header definition for RFC4340, Datagram Congestion Control Protocol.

Add comment to explain the seq field is sized to hold either the short or the long sequence number

Aug 7 2019, 1:32 PM
thj added inline comments to D21179: Add header definition for RFC4340, Datagram Congestion Control Protocol.
Aug 7 2019, 12:20 PM
thj created D21179: Add header definition for RFC4340, Datagram Congestion Control Protocol.
Aug 7 2019, 11:46 AM
thj created D21178: Rename IPPROTO 33 from SEP to DCCP.
Aug 7 2019, 11:19 AM

Aug 5 2019

thj committed rS350586: Add common firewall test suite.
Add common firewall test suite
Aug 5 2019, 11:47 AM
thj closed D21065: Pass/Block test for three firewalls (pf, ipfw, ipf).
Aug 5 2019, 11:47 AM · GSoC Students

Aug 4 2019

D21065: Pass/Block test for three firewalls (pf, ipfw, ipf) is now accepted and ready to land.

All the tests seem to work on r350568

Aug 4 2019, 8:33 PM · GSoC Students

Jul 28 2019

D21086: pf: Remove partial RFC2675 support is now accepted and ready to land.
Jul 28 2019, 8:01 PM
thj added inline comments to D21086: pf: Remove partial RFC2675 support.
Jul 28 2019, 4:49 PM

Jul 27 2019

thj updated subscribers of D21065: Pass/Block test for three firewalls (pf, ipfw, ipf).
Jul 27 2019, 6:53 PM · GSoC Students

Jul 21 2019

thj created D21016: Reduce size of EFI_STAGING_SIZE to 32 on arm.
Jul 21 2019, 7:15 PM
thj added inline comments to D16851: Add support for header chain validation on IPv6 Fragments (RFC7112).
Jul 21 2019, 10:06 AM

Jul 20 2019

thj added a reviewer for D5881: Allwinner USB DRD support (musb_otg): thj.
Jul 20 2019, 2:43 PM · ARM

Jul 16 2019

thj added reviewers for D13293: Don't return IIC_Exxxxx status values to userspace: jtl, bz.
Jul 16 2019, 6:06 PM

Jul 10 2019

thj added a comment to D19047: TCP Dynamic Burst Limit.

I have been digging and I think I have all the background for why this was
removed in r87145.

Jul 10 2019, 2:42 PM

Jul 4 2019

thj added a reviewer for D19047: TCP Dynamic Burst Limit: thj.
Jul 4 2019, 2:24 PM

Jul 3 2019

thj added inline comments to D20655: Make use of stats(3) in the TCP stack.
Jul 3 2019, 8:19 AM

Jun 19 2019

thj added inline comments to D20655: Make use of stats(3) in the TCP stack.
Jun 19 2019, 10:18 AM

May 26 2019

thj edited P261 Masterwork From Distant Lands.
May 26 2019, 8:47 AM

May 23 2019

thj updated the diff for D16851: Add support for header chain validation on IPv6 Fragments (RFC7112).

Respond to review comments

May 23 2019, 1:51 PM

May 9 2019

thj updated the diff for D16851: Add support for header chain validation on IPv6 Fragments (RFC7112).

Address review comments

May 9 2019, 8:04 AM

May 8 2019

thj added a comment to D19960: Remove support for RFC2675.

We wrote an ID:

May 8 2019, 1:01 PM

Apr 23 2019

thj accepted D20011: ip6_randomflowlabel: Avoid blocking if random(4) is not available.
Apr 23 2019, 7:47 AM

Apr 21 2019

thj added a comment to D19973: ip6_id: Avoid blocking if random(4) is not available.

I think we can just use zero for the label if enough entropy is not available. A flow label of zero indicates no flow label "treatment" in the network. On my test machine most early packets are already have a flow label of zero. From RFC 6437

Apr 21 2019, 8:09 PM

Apr 19 2019

thj committed rS346398: Add stat counter for ipv6 atomic fragments.
Add stat counter for ipv6 atomic fragments
Apr 19 2019, 5:06 PM
thj closed D17511: Add stat counter for ipv6 atomic fragments.
Apr 19 2019, 5:06 PM
thj accepted D19966: Improve input validation for IPPROTO_IPV6 level socket option IPV6_CHECKSUM.

Looks good to me

Apr 19 2019, 4:39 PM
thj added a comment to D19960: Remove support for RFC2675.

I am okay with Jonathan's suggested plan.

Apr 19 2019, 6:57 AM

Apr 18 2019

thj updated the diff for D19960: Remove support for RFC2675.

Diff against correct tree

Apr 18 2019, 5:13 PM
thj created D19960: Remove support for RFC2675.
Apr 18 2019, 5:05 PM
thj closed D19952: Add a bugs section to pflog man page.
Apr 18 2019, 11:07 AM
thj committed rS346348: Add a bugs section to pflog man page.
Add a bugs section to pflog man page
Apr 18 2019, 11:07 AM
thj created D19952: Add a bugs section to pflog man page.
Apr 18 2019, 10:34 AM

Apr 16 2019

thj closed D19861: Update and clarify pflog man page.
Apr 16 2019, 1:31 PM
thj committed rS346274: Update and clarify pflog man page.
Update and clarify pflog man page
Apr 16 2019, 1:31 PM

Apr 9 2019

thj added reviewers for D19861: Update and clarify pflog man page: kristof, manpages, jtl, bz.
Apr 9 2019, 12:23 PM
thj created D19861: Update and clarify pflog man page.
Apr 9 2019, 12:22 PM

Feb 26 2019

thj added inline comments to D16851: Add support for header chain validation on IPv6 Fragments (RFC7112).
Feb 26 2019, 8:20 PM

Feb 21 2019

thj closed D17521: Correct accounting when dropping fragment queues.

typo in the commit message stopped this being closed automatically

Feb 21 2019, 2:21 PM
thj closed D18354: Fix style nit.

typo in the commit message stopped this being closed automatically

Feb 21 2019, 2:20 PM

Feb 19 2019

thj committed rS344301: When dropping a fragment queue count the number of fragments in the queue.
When dropping a fragment queue count the number of fragments in the queue
Feb 19 2019, 7:58 PM
thj committed rS344292: Fix style after r340832.
Fix style after r340832
Feb 19 2019, 7:05 PM

Nov 27 2018

thj created D18354: Fix style nit.
Nov 27 2018, 10:47 AM

Nov 26 2018

thj created D18343: test.
Nov 26 2018, 3:06 PM
thj abandoned D18343: test.
Nov 26 2018, 3:06 PM

Nov 23 2018

thj committed rS340832: Add support for none ACPI battery method batteries.
Add support for none ACPI battery method batteries
Nov 23 2018, 12:03 PM
thj closed D17434: Add support for none ACPI battery method batteries.
Nov 23 2018, 12:03 PM

Oct 25 2018

thj accepted D17703: Add a note about the Aberdeen hackathon to the event list for 2019..
Oct 25 2018, 5:13 PM
thj added inline comments to D17703: Add a note about the Aberdeen hackathon to the event list for 2019..
Oct 25 2018, 4:59 PM

Oct 11 2018

thj created D17521: Correct accounting when dropping fragment queues.
Oct 11 2018, 3:25 PM

Oct 10 2018

thj added a reviewer for D17511: Add stat counter for ipv6 atomic fragments: transport.
Oct 10 2018, 8:16 PM
thj created D17511: Add stat counter for ipv6 atomic fragments.
Oct 10 2018, 8:15 PM

Oct 8 2018

thj updated the diff for D16851: Add support for header chain validation on IPv6 Fragments (RFC7112).
  • Do pullup per protcol that requires it
Oct 8 2018, 8:28 PM
thj updated the diff for D16851: Add support for header chain validation on IPv6 Fragments (RFC7112).
  • Use (ip+exthdr len) + length when pulling up mbuf
Oct 8 2018, 7:34 PM

Oct 6 2018

thj edited P227 Masterwork From Distant Lands.
Oct 6 2018, 8:16 PM
thj updated the diff for D16851: Add support for header chain validation on IPv6 Fragments (RFC7112).
  • Teach netinet/in.h about dccp
  • Make sure length bytes are in the first mbuf
Oct 6 2018, 6:07 PM
thj added inline comments to D16851: Add support for header chain validation on IPv6 Fragments (RFC7112).
Oct 6 2018, 5:00 PM
thj added inline comments to D16851: Add support for header chain validation on IPv6 Fragments (RFC7112).
Oct 6 2018, 4:41 PM
thj updated the diff for D16851: Add support for header chain validation on IPv6 Fragments (RFC7112).
  • Correctly locate structs in mbuf chain
Oct 6 2018, 4:07 PM
thj updated the diff for D16851: Add support for header chain validation on IPv6 Fragments (RFC7112).
  • Add support for ipv4 in ipv6, gre and dccp fragments
  • Unstatic definition
  • address language issues in comments
Oct 6 2018, 1:09 PM

Oct 5 2018

thj created D17434: Add support for none ACPI battery method batteries.
Oct 5 2018, 2:54 PM
thj closed D17357: Convert UDP length to host byte order.
Oct 5 2018, 12:52 PM
thj committed rS339195: Convert UDP length to host byte order.
Convert UDP length to host byte order
Oct 5 2018, 12:51 PM

Oct 1 2018

thj added a reviewer for D17357: Convert UDP length to host byte order: transport.
Oct 1 2018, 11:41 AM

Sep 29 2018

thj added a reviewer for D17357: Convert UDP length to host byte order: jtl.
Sep 29 2018, 5:04 PM
thj created D17357: Convert UDP length to host byte order.
Sep 29 2018, 5:04 PM

Sep 27 2018

thj edited P224 Masterwork From Distant Lands.
Sep 27 2018, 8:17 PM

Sep 26 2018

thj edited P223 Masterwork From Distant Lands.
Sep 26 2018, 7:20 PM

Sep 21 2018

thj edited P222 Masterwork From Distant Lands.
Sep 21 2018, 9:01 AM

Sep 12 2018

thj edited P219 Masterwork From Distant Lands.
Sep 12 2018, 11:45 AM

Aug 23 2018

thj added a comment to D16851: Add support for header chain validation on IPv6 Fragments (RFC7112).
In D16851#359110, @ae wrote:
In D16851#359108, @ae wrote:

Also, I think ipfw/pf needs an additional look to correctly handle this too.

What you think, if we make non-static ip6_checkfirstfrag() function, that can also be used by ipfw/pf/ipfil etc.?

Aug 23 2018, 11:00 AM

Aug 22 2018

thj added reviewers for D16851: Add support for header chain validation on IPv6 Fragments (RFC7112): jtl, transport.
Aug 22 2018, 7:09 PM
thj updated the test plan for D16851: Add support for header chain validation on IPv6 Fragments (RFC7112).
Aug 22 2018, 7:08 PM
thj created D16851: Add support for header chain validation on IPv6 Fragments (RFC7112).
Aug 22 2018, 7:07 PM

Aug 19 2018

thj edited P213 Masterwork From Distant Lands.
Aug 19 2018, 6:33 PM
thj edited P212 Masterwork From Distant Lands.
Aug 19 2018, 6:31 PM
thj created P211 Test.
Aug 19 2018, 6:30 PM

Jun 8 2018

thj added a reviewer for D15692: Adding rtl8188ee driver to rtwn(4): thj.
Jun 8 2018, 7:45 AM · Src Committers

Jun 6 2018

thj committed rS334705: Use UDP len when calculating UDP checksums.
Use UDP len when calculating UDP checksums
Jun 6 2018, 7:05 AM
thj closed D15222: Use UDP len when calculating UDP checksums.
Jun 6 2018, 7:05 AM

May 23 2018

thj added a member for transport: thj.
May 23 2018, 6:37 AM

May 17 2018

thj updated the diff for D15222: Use UDP len when calculating UDP checksums.
  • Check if udp header is in first mbuf, if not copy in udp len. Address style issues
May 17 2018, 1:58 PM
thj added inline comments to D15222: Use UDP len when calculating UDP checksums.
May 17 2018, 1:57 PM