Page MenuHomeFreeBSD

thj (Tom Jones)
User

Projects

User Details

User Since
Jan 7 2016, 3:15 PM (431 w, 2 d)

Recent Activity

Thu, Apr 11

thj added a comment to D44736: netmap: Add field for carrying packet meta data.

Thanks both for the comments, I didn't think this would be the correct approach, but it seemed easier to create a review for how I would like this to work.

Thu, Apr 11, 3:57 PM
thj added inline comments to D44736: netmap: Add field for carrying packet meta data.
Thu, Apr 11, 8:23 AM

Wed, Apr 10

thj requested review of D44736: netmap: Add field for carrying packet meta data.
Wed, Apr 10, 2:37 PM

Tue, Apr 2

thj abandoned D36860: diff: Import new diff algorithms from libdiff.
Tue, Apr 2, 8:00 AM

Wed, Mar 27

thj accepted D44302: diff: Integrate libdiff from OpenBSD GoT..
Wed, Mar 27, 9:41 AM
thj added a comment to D44302: diff: Integrate libdiff from OpenBSD GoT..

Please fix the man page typo, but otherwise looks good to me

Wed, Mar 27, 9:40 AM
thj accepted D44301: libdiff: Improve function prototype detection..
Wed, Mar 27, 9:27 AM

Tue, Mar 26

thj closed D44371: netmap: Address errors on memory free in netmap_generic.
Tue, Mar 26, 9:57 AM
thj committed rG73fdbfb91121: netmap: Address errors on memory free in netmap_generic (authored by thj).
netmap: Address errors on memory free in netmap_generic
Tue, Mar 26, 9:57 AM

Mon, Mar 25

thj updated the diff for D44371: netmap: Address errors on memory free in netmap_generic.
  • access ext_arg1 via the accessor
Mon, Mar 25, 2:37 PM

Thu, Mar 21

thj added a comment to D44371: netmap: Address errors on memory free in netmap_generic.

updated

Thu, Mar 21, 10:48 AM
thj updated the diff for D44371: netmap: Address errors on memory free in netmap_generic.
  • swap order of arguments for destructor
  • replace an m_freem with m_free
Thu, Mar 21, 10:46 AM

Wed, Mar 20

thj updated the diff for D44041: lldb lua: Add some helper functions to deal with netinet.
  • Correct copyright statement
  • Move then for if statements onto the same line
Wed, Mar 20, 1:59 PM
thj added a comment to D44371: netmap: Address errors on memory free in netmap_generic.

Any additional tests with pkt-gen in TX or RX mode over iflib interfaces and virtio-net ones?
E.g. two VMs/machines connected back to back with one transmitting and the other receiving, to stress test it?
Setting the sys.dev.netmap.admode sysctl to 2 will force emulated netmap even if the interface has native support.

Wed, Mar 20, 1:10 PM
thj updated the diff for D44371: netmap: Address errors on memory free in netmap_generic.
  • Add a macro for getting netmap adapter from ext_arg1
Wed, Mar 20, 10:45 AM

Tue, Mar 19

thj updated the diff for D44371: netmap: Address errors on memory free in netmap_generic.
  • - use SET_MBUF_DESTRUCTOR to set ext_arg1
Tue, Mar 19, 1:49 PM

Mon, Mar 18

thj updated the diff for D44371: netmap: Address errors on memory free in netmap_generic.
  • - Don't remove the pool lock until we have removed all mbufs
Mon, Mar 18, 1:27 PM
thj added inline comments to D44371: netmap: Address errors on memory free in netmap_generic.
Mon, Mar 18, 11:46 AM
thj updated the diff for D44371: netmap: Address errors on memory free in netmap_generic.
  • - if the reference has gone after taking the lock don't free the mbuf
Mon, Mar 18, 11:44 AM

Fri, Mar 15

thj requested review of D44371: netmap: Address errors on memory free in netmap_generic.
Fri, Mar 15, 12:00 PM

Feb 26 2024

thj updated the diff for D44041: lldb lua: Add some helper functions to deal with netinet.

Address review comments

Feb 26 2024, 9:52 AM
thj added inline comments to D44041: lldb lua: Add some helper functions to deal with netinet.
Feb 26 2024, 9:49 AM

Feb 23 2024

thj committed rG3db693f7da8a: pf: Correct SPDX identifier (authored by thj).
pf: Correct SPDX identifier
Feb 23 2024, 3:59 PM
thj requested review of D44041: lldb lua: Add some helper functions to deal with netinet.
Feb 23 2024, 2:18 PM
thj committed rGb9870ba93ea9: pf: Add a TCP rdr test on IPv6 (authored by thj).
pf: Add a TCP rdr test on IPv6
Feb 23 2024, 1:48 PM
thj closed D42105: Add a TCP rdr test on IPv6.
Feb 23 2024, 1:48 PM

Oct 6 2023

thj updated the diff for D42105: Add a TCP rdr test on IPv6.

Add to Makefile

Oct 6 2023, 3:00 PM
thj updated the diff for D42105: Add a TCP rdr test on IPv6.

add call to pft_init

Oct 6 2023, 2:58 PM
thj updated the diff for D42105: Add a TCP rdr test on IPv6.

Use immediate mode for tcpdump
enhance comments

Oct 6 2023, 2:18 PM
thj updated the diff for D42105: Add a TCP rdr test on IPv6.

Fix tcpdump test

Oct 6 2023, 2:01 PM
thj requested review of D42105: Add a TCP rdr test on IPv6.
Oct 6 2023, 1:24 PM

Oct 4 2023

thj abandoned D37437: if_tun: Enable tun devices to be used with netmap.
Oct 4 2023, 2:47 PM

Jun 13 2023

thj accepted D40376: nss_tacplus: Support setting the login class..
Jun 13 2023, 9:15 AM

Apr 18 2023

thj accepted D39650: renice: Factor out common code in tests..
Apr 18 2023, 12:22 PM

Feb 10 2023

thj accepted D38489: wc: Drop <err.h> and report an error if xo_finish() fails..
Feb 10 2023, 4:57 PM

Feb 7 2023

thj added a reviewer for D38413: ahci: increase timout: Klara.
Feb 7 2023, 1:21 PM

Jan 30 2023

thj added a reviewer for D17884: efifb: add a tunable to select the framebuffer cache attribute: Klara.
Jan 30 2023, 9:24 AM
thj added a reviewer for D17883: cxgbe netmap: Directly flushes batches of 64 packets in lazy_tx_credit_flush: Klara.
Jan 30 2023, 9:24 AM

Jan 17 2023

thj committed rGfe701c39e8aa: if_tun: Add basic connectivity test with nc tun support (authored by thj).
if_tun: Add basic connectivity test with nc tun support
Jan 17 2023, 10:07 AM
thj committed rGcef7ab70ff44: netcat: Allow nc to be an if_tun tunnel broker (authored by thj).
netcat: Allow nc to be an if_tun tunnel broker
Jan 17 2023, 10:07 AM
thj closed D37435: Allow netcat to be a tun tunnel broker.
Jan 17 2023, 10:07 AM

Jan 16 2023

thj added reviewers for D38066: bridge: Add support for emulated netmap mode: Klara, murat_sunnyvalley.io, franco_opnsense.org.
Jan 16 2023, 1:45 PM
thj added reviewers for D38065: netmap: Fix queue stalls on generic interfaces: Klara, murat_sunnyvalley.io, franco_opnsense.org.
Jan 16 2023, 1:45 PM

Jan 13 2023

thj committed rG110ce09c90dc: if_lagg: Allow lagg interfaces to be used with netmap (authored by thj).
if_lagg: Allow lagg interfaces to be used with netmap
Jan 13 2023, 3:34 PM
thj closed D37436: if_lagg: Allow lagg interfaces to be used with NetMap.
Jan 13 2023, 3:33 PM

Jan 12 2023

thj added a reviewer for D37435: Allow netcat to be a tun tunnel broker: manpages.
Jan 12 2023, 10:25 AM
thj updated the diff for D37435: Allow netcat to be a tun tunnel broker.

Address Kyles review comments

Jan 12 2023, 10:25 AM

Dec 8 2022

thj committed rG308d3d6be6da: acpi: Tell SMM we will handle CPPC notifications (authored by thj).
acpi: Tell SMM we will handle CPPC notifications
Dec 8 2022, 8:04 PM

Dec 7 2022

thj accepted D37624: ppp: improve MSS clamping.
Dec 7 2022, 10:16 PM
thj added inline comments to D37624: ppp: improve MSS clamping.
Dec 7 2022, 8:19 PM

Dec 2 2022

thj changed the visibility for D37195: Remote stack corruption in ping (Embargoed).
Dec 2 2022, 8:36 AM

Nov 18 2022

thj requested review of D37437: if_tun: Enable tun devices to be used with netmap.
Nov 18 2022, 4:37 PM
thj retitled D37435: Allow netcat to be a tun tunnel broker from Allow netcat to be a tun tunnel broker Add tests with this new functionality to test that tun devices can pass packets. to Allow netcat to be a tun tunnel broker.
Nov 18 2022, 4:35 PM
thj added a reviewer for D37436: if_lagg: Allow lagg interfaces to be used with NetMap: Klara.
Nov 18 2022, 4:28 PM
thj requested review of D37436: if_lagg: Allow lagg interfaces to be used with NetMap.
Nov 18 2022, 4:28 PM
thj requested review of D37435: Allow netcat to be a tun tunnel broker.
Nov 18 2022, 4:16 PM
thj accepted D37433: tftp: cleanup.
Nov 18 2022, 3:52 PM
thj accepted D37423: tftpd: Plug memory leaks in option handling code..
Nov 18 2022, 3:52 PM

Nov 14 2022

thj updated the diff for D37195: Remote stack corruption in ping (Embargoed).
  • Address further comments from Mark
Nov 14 2022, 4:15 PM

Nov 2 2022

thj updated the diff for D37195: Remote stack corruption in ping (Embargoed).
  • Remove asan from makefiles
Nov 2 2022, 10:52 AM
thj updated the diff for D37195: Remote stack corruption in ping (Embargoed).
  • Ensure there are enough bytes following the icmp header
Nov 2 2022, 10:49 AM

Oct 30 2022

thj updated subscribers of D37195: Remote stack corruption in ping (Embargoed).
Oct 30 2022, 8:39 AM

Oct 28 2022

thj updated subscribers of D37195: Remote stack corruption in ping (Embargoed).
Oct 28 2022, 1:51 PM
thj requested review of D37195: Remote stack corruption in ping (Embargoed).
Oct 28 2022, 1:17 PM

Oct 27 2022

thj accepted D37177: script: Use size_t / ssize_t where needed. script: Further usage string nits..
Oct 27 2022, 7:49 PM

Oct 23 2022

thj committed rG15bd2f366d3e: acpi: Create cppc_notify sysctl before it is checked (authored by thj).
acpi: Create cppc_notify sysctl before it is checked
Oct 23 2022, 9:12 AM
thj closed D37081: acpi: Create cppc_notify sysctl before it is checked.
Oct 23 2022, 9:11 AM

Oct 21 2022

thj requested review of D37081: acpi: Create cppc_notify sysctl before it is checked.
Oct 21 2022, 3:57 PM
thj requested review of D37079: diff: Fix matching of CRLF when ignoring white space.
Oct 21 2022, 12:39 PM

Oct 11 2022

thj committed rGeee0f7aea425: acpi: Put CPPC workaround behind i386/amd64 if def (authored by thj).
acpi: Put CPPC workaround behind i386/amd64 if def
Oct 11 2022, 8:33 AM

Oct 10 2022

thj updated the diff for D36860: diff: Import new diff algorithms from libdiff.
  • move libdiff into contrib
Oct 10 2022, 3:11 PM
thj committed rG67f2a563bfca: acpi: Tell SMM we will handle CPPC notifications (authored by thj).
acpi: Tell SMM we will handle CPPC notifications
Oct 10 2022, 1:54 PM
thj closed D36699: acpi: Tell SMM we will handle CPPC notifications.
Oct 10 2022, 1:54 PM

Oct 7 2022

thj updated the diff for D36699: acpi: Tell SMM we will handle CPPC notifications.
  • use a RDTUN sysctl rather than a hint
  • Use a global control for cppc notifications
Oct 7 2022, 2:49 PM

Oct 6 2022

thj updated the diff for D36699: acpi: Tell SMM we will handle CPPC notifications.
  • Simplify hint name
Oct 6 2022, 2:05 PM

Oct 5 2022

thj updated the diff for D36699: acpi: Tell SMM we will handle CPPC notifications.
  • Add a hint to disable the workaround
Oct 5 2022, 11:11 AM

Oct 3 2022

thj updated the test plan for D36860: diff: Import new diff algorithms from libdiff.
Oct 3 2022, 9:36 AM
thj requested review of D36860: diff: Import new diff algorithms from libdiff.
Oct 3 2022, 9:35 AM

Sep 25 2022

thj requested review of D36699: acpi: Tell SMM we will handle CPPC notifications.
Sep 25 2022, 3:27 PM

Sep 2 2022

thj added inline comments to D16851: Add support for header chain validation on IPv6 Fragments (RFC7112).
Sep 2 2022, 1:23 PM

Aug 29 2022

thj updated the diff for D16851: Add support for header chain validation on IPv6 Fragments (RFC7112).

Update to building version

Aug 29 2022, 3:17 PM

Aug 2 2022

thj committed rGc0e6ccb12ab9: diff3: Use ranges for the old and new diffedits in A scripts (authored by thj).
diff3: Use ranges for the old and new diffedits in A scripts
Aug 2 2022, 1:39 PM
thj committed rG264a559ac827: diff3: Simplify startmark calculation in Ascript (authored by thj).
diff3: Simplify startmark calculation in Ascript
Aug 2 2022, 1:39 PM
thj committed rG190c4c2499e6: diff3: Use ranges for new and old diffedits in ed scripts (authored by thj).
diff3: Use ranges for new and old diffedits in ed scripts
Aug 2 2022, 1:39 PM
thj added inline comments to D34343: libc: iconv: push option ignore into citrus_iconv_open().
Aug 2 2022, 12:32 PM
thj added inline comments to D34344: libc: iconv: add mb_cur_min for encoder traits.
Aug 2 2022, 12:19 PM
thj accepted D34342: iconv: only conditionally use ICONV_SET_DISCARD_ILSEQ.

Looks good to me

Aug 2 2022, 12:17 PM

Aug 1 2022

thj committed rGca53a8445ab3: diff3: Replace literal marker with variable (authored by thj).
diff3: Replace literal marker with variable
Aug 1 2022, 1:57 PM
thj committed rG2c4276aaa2d0: diff3: Use variables for old and new in A scripts (authored by thj).
diff3: Use variables for old and new in A scripts
Aug 1 2022, 1:57 PM
thj committed rG85d92faf434a: diff3: Fix indentation (authored by thj).
diff3: Fix indentation
Aug 1 2022, 1:16 PM

Jul 20 2022

thj committed rGdc2e12abb22a: Unlock inp when handling TCP_MD5SIG socket options (authored by Claudio Jeker <claudio@openbsd.org>).
Unlock inp when handling TCP_MD5SIG socket options
Jul 20 2022, 3:26 PM

Jul 5 2022

thj committed rG1e692b938e37: xargs: fix description of strnsubst return value (authored by thj).
xargs: fix description of strnsubst return value
Jul 5 2022, 3:31 PM
thj committed rGf058359ba5e0: xargs: terminate if line replacement cannot be constructed (authored by thj).
xargs: terminate if line replacement cannot be constructed
Jul 5 2022, 3:19 PM
thj closed D35574: xargs: terminate if line replacement cannot be constructed.
Jul 5 2022, 3:18 PM
thj updated the diff for D35574: xargs: terminate if line replacement cannot be constructed.
  • make strnsubst return a bool indicating if truncation occured
Jul 5 2022, 3:01 PM
thj committed rGd458eb8de12c: diff3: make the eflag logic easier to follow (authored by thj).
diff3: make the eflag logic easier to follow
Jul 5 2022, 11:37 AM
thj closed D35324: Try to make eflag easier to follow.
Jul 5 2022, 11:37 AM
thj updated the diff for D35324: Try to make eflag easier to follow.

simplfy the eflag based on suggestions by dim

Jul 5 2022, 11:29 AM

Jul 1 2022

thj added a comment to D35676: Catch up with 2004 and improve markup..

LGTM, please check with igor to be sure I am not a great mdoc parser.

Jul 1 2022, 8:03 AM

Jun 23 2022

thj abandoned D34421: diff3: Add support for -A and -m.
Jun 23 2022, 3:16 PM