Page MenuHomeFreeBSD

thj (Tom Jones)
User

Projects

User Details

User Since
Jan 7 2016, 3:15 PM (289 w, 5 d)

Recent Activity

Mar 15 2021

thj added a reviewer for D29274: VNETify dummynet: ae.

Andrey, I didn't get your reply when I asked about conflicts, but kp has forwarded it.
If this generates conflicts I am happy to work around your work in progress,
VNETed dummynet is what I want.

Mar 15 2021, 8:20 PM
thj added a comment to D29274: VNETify dummynet.

I will merge https://reviews.freebsd.org/D29246 but I wanted to post the diff so kp@ and I can coordinate

Mar 15 2021, 8:11 PM
thj requested review of D29274: VNETify dummynet.
Mar 15 2021, 8:10 PM

Mar 10 2021

thj abandoned D28967: Trim leading/trailing white space in dummynet Tidy up the leading and trailing white space issues highlighted by vim. Avoid touching whitespace that is used for layout and the functions which are entirely space aligned..
Mar 10 2021, 10:08 PM

Mar 2 2021

thj added a comment to D28967: Trim leading/trailing white space in dummynet Tidy up the leading and trailing white space issues highlighted by vim. Avoid touching whitespace that is used for layout and the functions which are entirely space aligned..

I figure that a sweep is better than peicemeal changes to whitespace. A lot of these are extra spaces after braces.

Mar 2 2021, 10:02 AM

Feb 27 2021

thj requested review of D28967: Trim leading/trailing white space in dummynet Tidy up the leading and trailing white space issues highlighted by vim. Avoid touching whitespace that is used for layout and the functions which are entirely space aligned..
Feb 27 2021, 3:24 PM

Feb 12 2021

thj added inline comments to D28622: handbook/config: Add section on configuring IPv6.
Feb 12 2021, 6:10 PM

Sep 19 2020

thj added inline comments to D26483: Add necessary include dirs & clean up style.
Sep 19 2020, 9:06 PM
thj added a reviewer for D26483: Add necessary include dirs & clean up style: network.
Sep 19 2020, 8:53 PM
thj created P427 Command-Line Input.
Sep 19 2020, 7:59 PM

Sep 1 2020

thj added a comment to D26272: Correct section reference for examples in RFC3542.

for me it was six and two threes, updated to refer to section 22.

Sep 1 2020, 1:48 PM
thj updated the diff for D26272: Correct section reference for examples in RFC3542.

Refer to all of section 22

Sep 1 2020, 1:47 PM
thj added reviewers for D26272: Correct section reference for examples in RFC3542: bz, jtl, manpages, network.
Sep 1 2020, 1:19 PM
thj requested review of D26273: inet6_option_space is deprecated, refer directly to inet6_opt_init.
Sep 1 2020, 1:19 PM
thj requested review of D26272: Correct section reference for examples in RFC3542.
Sep 1 2020, 1:12 PM

Aug 28 2020

thj updated the diff for D21180: Add Parameter Problem type for Incomplete Header Chain.
  • Address review comments
Aug 28 2020, 10:07 AM
thj added a comment to D21180: Add Parameter Problem type for Incomplete Header Chain.

Updated diff coming I changed the netstat line to "no or incomplete upper layer header in first fragment" which did not wrap until there were 10 figures of packets.

Aug 28 2020, 10:06 AM

Aug 21 2020

thj added inline comments to D26078: Add libroute and basic librarification of route utility.
Aug 21 2020, 3:29 PM

Aug 18 2020

thj added a comment to D26078: Add libroute and basic librarification of route utility.

Please make sure to check for failure after memory allocation. You need to add the paths to report these errors and the socket errors that kp@ pointed out too.
Other than these there are some minor nits, reading style will probably flag these up.

Aug 18 2020, 6:49 PM

Jul 22 2020

thj committed rS363417: Add tests for "add", "change" and "delete" functionality of /sbin/route..
Add tests for "add", "change" and "delete" functionality of /sbin/route.
Jul 22 2020, 1:50 PM
thj closed D25220: Add tests for "add", "change" and "delete" functionality of /sbin/route..
Jul 22 2020, 1:50 PM
thj committed rS363414: MFC r363141:.
MFC r363141:
Jul 22 2020, 10:00 AM
thj accepted D25220: Add tests for "add", "change" and "delete" functionality of /sbin/route..
Jul 22 2020, 6:49 AM
thj committed rS363413: MFC r350749, r362275.
MFC r350749, r362275
Jul 22 2020, 6:48 AM
thj committed rS363412: MFC r362541:.
MFC r362541:
Jul 22 2020, 6:45 AM

Jul 13 2020

thj added inline comments to D25220: Add tests for "add", "change" and "delete" functionality of /sbin/route..
Jul 13 2020, 7:58 PM
thj closed D25619: Don't print VNET pointer when starting up.
Jul 13 2020, 1:36 PM
thj committed rS363141: Don't print VNET pointer when initializing dummynet.
Don't print VNET pointer when initializing dummynet
Jul 13 2020, 1:36 PM

Jul 11 2020

thj requested review of D25619: Don't print VNET pointer when starting up.
Jul 11 2020, 4:38 PM

Jul 2 2020

thj committed rS362899: MFC r362379:.
MFC r362379:
Jul 2 2020, 6:42 PM
thj committed rS362898: MFC r362379:.
MFC r362379:
Jul 2 2020, 6:40 PM

Jun 23 2020

thj committed rS362541: pkg: Provide a friendlier message when bootstrap fails due to address resolution.
pkg: Provide a friendlier message when bootstrap fails due to address resolution
Jun 23 2020, 3:15 PM
thj closed D25323: Provide a friendlier message when bootstrap fails due to address resolution.
Jun 23 2020, 3:15 PM
thj requested review of D25357: Fix typo.
Jun 23 2020, 3:22 AM
thj requested review of D25323: Provide a friendlier message when bootstrap fails due to address resolution.
Jun 23 2020, 3:22 AM
thj closed D25357: Fix typo.
Jun 23 2020, 3:15 AM

Jun 21 2020

thj accepted D25220: Add tests for "add", "change" and "delete" functionality of /sbin/route..
Jun 21 2020, 10:33 AM

Jun 19 2020

thj committed rS362379: Fix typo in apic.4.
Fix typo in apic.4
Jun 19 2020, 1:09 PM

Jun 18 2020

thj closed D21179: Add header definition for RFC4340, Datagram Congestion Control Protocol.
Jun 18 2020, 9:19 AM
thj added a comment to D21336: Make dummynet kernel module independent from IPFW.

Is this still relevant to your porting work? If I get an ack I will add this to my list to look at.

Jun 18 2020, 9:18 AM

May 25 2020

thj edited P389 Masterwork From Distant Lands.
May 25 2020, 5:14 PM

Mar 15 2020

thj edited P375 Masterwork From Distant Lands.
Mar 15 2020, 10:46 AM

Dec 14 2019

thj edited P344 Masterwork From Distant Lands.
Dec 14 2019, 6:51 PM

Nov 30 2019

thj accepted D20655: Make use of stats(3) in the TCP stack.

When kern.hz is 100 timer resolution below 10ms is disgarded. You can see clearly in
the RTT measurement, on a path with 15ms delay TCP stats will report an rtt of 20ms.
It also seems to be the case that all sub 10ms delay paths report a minimum delay of
10ms. This does not present if I boot with kern.hz set to 1000.

Nov 30 2019, 1:13 PM
thj added a comment to D21324: Add stats(3) support to nc(1).

I get inconsistent results for TXPB, you can see this with the test script here:
https://gist.github.com/adventureloop/fb68d805696aeaf03c227f08cbe87947

Nov 30 2019, 1:04 PM

Nov 16 2019

thj updated the diff for D16851: Add support for header chain validation on IPv6 Fragments (RFC7112).

updated

Nov 16 2019, 2:06 PM

Nov 4 2019

thj edited P333 Masterwork From Distant Lands.
Nov 4 2019, 10:27 PM

Oct 8 2019

thj created D21939: Enter chroot before looking up user or group to change to.
Oct 8 2019, 8:35 AM

Oct 6 2019

thj updated the diff for D21179: Add header definition for RFC4340, Datagram Congestion Control Protocol.
  • Use named union and struct in header definition
Oct 6 2019, 4:20 PM

Sep 28 2019

thj updated the diff for D21179: Add header definition for RFC4340, Datagram Congestion Control Protocol.

Fix struct so that will build, last rev I seem to have updated the review from
the wrong tree.

Sep 28 2019, 8:03 AM

Sep 20 2019

thj added a reviewer for D21180: Add Parameter Problem type for Incomplete Header Chain: gallatin.
Sep 20 2019, 8:58 AM
thj added a reviewer for D21179: Add header definition for RFC4340, Datagram Congestion Control Protocol: gallatin.
Sep 20 2019, 8:53 AM
thj abandoned D21727: Fix white space around the union.

Arcanist tricked me and created this instead of updating an existing review

Sep 20 2019, 8:52 AM
thj updated the diff for D21179: Add header definition for RFC4340, Datagram Congestion Control Protocol.

Remove extra white space around union

Sep 20 2019, 8:52 AM
thj created D21727: Fix white space around the union.
Sep 20 2019, 8:51 AM

Aug 18 2019

thj added inline comments to D21305: Add set ToS test for ipfw and pf.
Aug 18 2019, 6:05 PM
D21276: Move pft_ping.py and sniffer.py to the common test directory is now accepted and ready to land.
Aug 18 2019, 5:57 PM

Aug 17 2019

thj committed rS351166: Reduce size of EFI_STAGING_SIZE to 32 on arm.
Reduce size of EFI_STAGING_SIZE to 32 on arm
Aug 17 2019, 6:48 AM
thj closed D21016: Reduce size of EFI_STAGING_SIZE to 32 on arm.
Aug 17 2019, 6:48 AM
thj committed rS351165: Add basic NAT test for pf, ipf and ipfw.
Add basic NAT test for pf, ipf and ipfw
Aug 17 2019, 6:44 AM
thj closed D21199: NAT basic test for pf, ipfw (both in-kernel and userspace) and ipf.
Aug 17 2019, 6:44 AM

Aug 14 2019

D21199: NAT basic test for pf, ipfw (both in-kernel and userspace) and ipf is now accepted and ready to land.
Aug 14 2019, 12:17 PM
thj retitled D21016: Reduce size of EFI_STAGING_SIZE to 32 on arm from Reduce size of EFI_STAGING_SIZE to 32 to Reduce size of EFI_STAGING_SIZE to 32 on arm.
Aug 14 2019, 9:03 AM

Aug 10 2019

thj added inline comments to D21199: NAT basic test for pf, ipfw (both in-kernel and userspace) and ipf.
Aug 10 2019, 1:39 PM

Aug 8 2019

thj added inline comments to D21179: Add header definition for RFC4340, Datagram Congestion Control Protocol.
Aug 8 2019, 3:25 PM
thj added a comment to D21016: Reduce size of EFI_STAGING_SIZE to 32 on arm.

Remove accidentally added file

Aug 8 2019, 12:57 PM
thj retitled D21016: Reduce size of EFI_STAGING_SIZE to 32 on arm from Reduce size of EFI_STAGING_SIZE to 32 This allows loader to start on the 256MB NanoPi-NEOLTS model to Reduce size of EFI_STAGING_SIZE to 32.
  • Only reduce staging size on arm
Aug 8 2019, 12:57 PM
thj closed D21178: Rename IPPROTO 33 from SEP to DCCP.
Aug 8 2019, 11:43 AM
thj committed rS350749: Rename IPPROTO 33 from SEP to DCCP.
Rename IPPROTO 33 from SEP to DCCP
Aug 8 2019, 11:43 AM
thj added a reviewer for D18908: Added SOCKS5 support to libfetch: thj.
Aug 8 2019, 8:07 AM

Aug 7 2019

thj added a comment to D21179: Add header definition for RFC4340, Datagram Congestion Control Protocol.

Extend the sequence number field to include a reserved byte in the long header.

Aug 7 2019, 4:44 PM
thj created D21180: Add Parameter Problem type for Incomplete Header Chain.
Aug 7 2019, 2:02 PM
thj added a comment to D21179: Add header definition for RFC4340, Datagram Congestion Control Protocol.

Add comment to explain the seq field is sized to hold either the short or the long sequence number

Aug 7 2019, 1:32 PM
thj added inline comments to D21179: Add header definition for RFC4340, Datagram Congestion Control Protocol.
Aug 7 2019, 12:20 PM
thj created D21179: Add header definition for RFC4340, Datagram Congestion Control Protocol.
Aug 7 2019, 11:46 AM
thj created D21178: Rename IPPROTO 33 from SEP to DCCP.
Aug 7 2019, 11:19 AM

Aug 5 2019

thj committed rS350586: Add common firewall test suite.
Add common firewall test suite
Aug 5 2019, 11:47 AM
thj closed D21065: Pass/Block test for three firewalls (pf, ipfw, ipf).
Aug 5 2019, 11:47 AM · GSoC Students

Aug 4 2019

D21065: Pass/Block test for three firewalls (pf, ipfw, ipf) is now accepted and ready to land.

All the tests seem to work on r350568

Aug 4 2019, 8:33 PM · GSoC Students

Jul 28 2019

D21086: pf: Remove partial RFC2675 support is now accepted and ready to land.
Jul 28 2019, 8:01 PM
thj added inline comments to D21086: pf: Remove partial RFC2675 support.
Jul 28 2019, 4:49 PM

Jul 27 2019

thj updated subscribers of D21065: Pass/Block test for three firewalls (pf, ipfw, ipf).
Jul 27 2019, 6:53 PM · GSoC Students

Jul 21 2019

thj created D21016: Reduce size of EFI_STAGING_SIZE to 32 on arm.
Jul 21 2019, 7:15 PM
thj added inline comments to D16851: Add support for header chain validation on IPv6 Fragments (RFC7112).
Jul 21 2019, 10:06 AM

Jul 20 2019

thj added a reviewer for D5881: Allwinner USB DRD support (musb_otg): thj.
Jul 20 2019, 2:43 PM · ARM

Jul 16 2019

thj added reviewers for D13293: Don't return IIC_Exxxxx status values to userspace: jtl, bz.
Jul 16 2019, 6:06 PM

Jul 10 2019

thj added a comment to D19047: TCP Dynamic Burst Limit.

I have been digging and I think I have all the background for why this was
removed in r87145.

Jul 10 2019, 2:42 PM

Jul 4 2019

thj added a reviewer for D19047: TCP Dynamic Burst Limit: thj.
Jul 4 2019, 2:24 PM

Jul 3 2019

thj added inline comments to D20655: Make use of stats(3) in the TCP stack.
Jul 3 2019, 8:19 AM

Jun 19 2019

thj added inline comments to D20655: Make use of stats(3) in the TCP stack.
Jun 19 2019, 10:18 AM

May 26 2019

thj edited P261 Masterwork From Distant Lands.
May 26 2019, 8:47 AM

May 23 2019

thj updated the diff for D16851: Add support for header chain validation on IPv6 Fragments (RFC7112).

Respond to review comments

May 23 2019, 1:51 PM

May 9 2019

thj updated the diff for D16851: Add support for header chain validation on IPv6 Fragments (RFC7112).

Address review comments

May 9 2019, 8:04 AM

May 8 2019

thj added a comment to D19960: Remove support for RFC2675.

We wrote an ID:

May 8 2019, 1:01 PM

Apr 23 2019

thj accepted D20011: ip6_randomflowlabel: Avoid blocking if random(4) is not available.
Apr 23 2019, 7:47 AM

Apr 21 2019

thj added a comment to D19973: ip6_id: Avoid blocking if random(4) is not available.

I think we can just use zero for the label if enough entropy is not available. A flow label of zero indicates no flow label "treatment" in the network. On my test machine most early packets are already have a flow label of zero. From RFC 6437

Apr 21 2019, 8:09 PM

Apr 19 2019

thj committed rS346398: Add stat counter for ipv6 atomic fragments.
Add stat counter for ipv6 atomic fragments
Apr 19 2019, 5:06 PM
thj closed D17511: Add stat counter for ipv6 atomic fragments.
Apr 19 2019, 5:06 PM
thj accepted D19966: Improve input validation for IPPROTO_IPV6 level socket option IPV6_CHECKSUM.

Looks good to me

Apr 19 2019, 4:39 PM
thj added a comment to D19960: Remove support for RFC2675.

I am okay with Jonathan's suggested plan.

Apr 19 2019, 6:57 AM