Page MenuHomeFreeBSD

thj (Tom Jones)
User

Projects

User Details

User Since
Jan 7 2016, 3:15 PM (331 w, 3 d)

Recent Activity

Thu, May 5

thj added a reviewer for D35117: netinet6: streamline scope6 checks for loopback traffic in ip6_output().: thj.
Thu, May 5, 3:09 PM

Mon, May 2

thj committed R10:c1c381eb7f82: diff3: Remove test case that references non existent test files (authored by thj).
diff3: Remove test case that references non existent test files
Mon, May 2, 3:03 PM

Wed, Apr 27

thj committed R10:5acfa48bb258: if_bnxt: Allow bnxt interfaces to use vlans (authored by Misho <misho@elwix.org>).
if_bnxt: Allow bnxt interfaces to use vlans
Wed, Apr 27, 1:56 PM
thj committed R10:e54505277c39: if_bnxt: Allow bnxt interfaces to use vlans (authored by Misho <misho@elwix.org>).
if_bnxt: Allow bnxt interfaces to use vlans
Wed, Apr 27, 1:17 PM

Tue, Apr 26

thj accepted D35066: tcp: Rack idle reduce not working..

Looks good to me

Tue, Apr 26, 12:48 PM

Fri, Apr 22

thj updated the diff for D34762: ctld: Fix coverity raised issues.
  • Revert "ctld: Only use strtoul when str is not NULL"
Fri, Apr 22, 1:51 PM
thj added inline comments to D34762: ctld: Fix coverity raised issues.
Fri, Apr 22, 1:47 PM
thj added a comment to D34762: ctld: Fix coverity raised issues.

Hits coverity id: 1474355 in our coverity

Fri, Apr 22, 1:43 PM

Thu, Apr 21

thj closed D34824: if_bnxt: Allow bnxt interfaces to use vlans with promisc mode.
Thu, Apr 21, 8:33 AM
thj committed R10:0c6a2fa33e36: if_bnxt: Allow bnxt interfaces to use vlans (authored by Misho <misho@elwix.org>).
if_bnxt: Allow bnxt interfaces to use vlans
Thu, Apr 21, 8:32 AM

Tue, Apr 19

thj committed R10:034dd2d54f2e: diff3: Add support for -m (authored by thj).
diff3: Add support for -m
Tue, Apr 19, 3:25 PM
thj committed R10:9ab079c5e810: diff3: Add support for -A (authored by thj).
diff3: Add support for -A
Tue, Apr 19, 2:55 PM
thj committed R10:df092859b478: diff3: seperate old and new markers from file markers (authored by thj).
diff3: seperate old and new markers from file markers
Tue, Apr 19, 2:41 PM
thj committed R10:2184ca3f191d: diff3: Clean up printing of ranges for edscript output (authored by thj).
diff3: Clean up printing of ranges for edscript output
Tue, Apr 19, 1:52 PM
thj closed D34941: diff3: Clean up printing of ranges for edscript output.
Tue, Apr 19, 1:52 PM
thj closed D34674: etcupdate: remove redundant diff3 flag.
Tue, Apr 19, 7:41 AM
thj accepted D34952: prometheus_sysctl_exporter: fix metric aliasing.
Tue, Apr 19, 7:39 AM

Mon, Apr 18

thj added inline comments to D34941: diff3: Clean up printing of ranges for edscript output.
Mon, Apr 18, 3:09 PM
thj updated the diff for D34941: diff3: Clean up printing of ranges for edscript output.
  • Don't free line buffer in getline loop
Mon, Apr 18, 3:09 PM
thj requested review of D34941: diff3: Clean up printing of ranges for edscript output.
Mon, Apr 18, 1:23 PM

Apr 15 2022

thj closed D34912: diff3: allow diff3 ed scripts to generate deletions.
Apr 15 2022, 2:02 PM
thj committed R10:7c03df6855f4: diff3: allow diff3 ed scripts to generate deletions (authored by thj).
diff3: allow diff3 ed scripts to generate deletions
Apr 15 2022, 2:02 PM
thj updated the diff for D34912: diff3: allow diff3 ed scripts to generate deletions.
  • pass bool into prange in change
Apr 15 2022, 1:56 PM
thj updated the diff for D34912: diff3: allow diff3 ed scripts to generate deletions.
  • Only end ed input stream if we aren't issuing a delete
Apr 15 2022, 8:44 AM
thj updated the diff for D34912: diff3: allow diff3 ed scripts to generate deletions.
  • Make delete bool
Apr 15 2022, 8:01 AM

Apr 14 2022

thj added inline comments to D34912: diff3: allow diff3 ed scripts to generate deletions.
Apr 14 2022, 4:01 PM
thj requested review of D34912: diff3: allow diff3 ed scripts to generate deletions.
Apr 14 2022, 3:28 PM

Apr 13 2022

thj committed R10:016bfb0a974a: etcupdate: remove redundant diff3 flag (authored by thj).
etcupdate: remove redundant diff3 flag
Apr 13 2022, 3:06 PM
thj accepted D30043: tcp: Whitespace cleanup in brr and rack.

I don't see any functional changes and rrs blocking review has landed, so this looks fine to land to me.

Apr 13 2022, 9:16 AM

Apr 12 2022

thj updated the diff for D34824: if_bnxt: Allow bnxt interfaces to use vlans with promisc mode.

With just misho's patch from bz

Apr 12 2022, 4:47 PM
thj committed R10:1ea833a57290: kdb: set kdb_why when entered via reboot and panic (authored by thj).
kdb: set kdb_why when entered via reboot and panic
Apr 12 2022, 9:35 AM
thj closed D34551: kdb: set kdb_why when entered via reboot and panic.
Apr 12 2022, 9:35 AM

Apr 7 2022

thj added a reviewer for D34824: if_bnxt: Allow bnxt interfaces to use vlans with promisc mode: rpokala.
Apr 7 2022, 4:54 PM
thj added a reviewer for D34824: if_bnxt: Allow bnxt interfaces to use vlans with promisc mode: mav.
Apr 7 2022, 4:50 PM
thj requested review of D34824: if_bnxt: Allow bnxt interfaces to use vlans with promisc mode.
Apr 7 2022, 4:35 PM
thj committed R10:1241e8e7aed5: siftr: expose t_flags2 in siftr output (authored by thj).
siftr: expose t_flags2 in siftr output
Apr 7 2022, 9:18 AM
thj closed D34672: siftr: expose t_flags2 in siftr output.
Apr 7 2022, 9:18 AM
thj added inline comments to D34672: siftr: expose t_flags2 in siftr output.
Apr 7 2022, 9:10 AM

Apr 6 2022

thj updated the diff for D34672: siftr: expose t_flags2 in siftr output.
  • Remove extra format specifier
Apr 6 2022, 10:00 AM

Apr 4 2022

thj requested review of D34762: ctld: Fix coverity raised issues.
Apr 4 2022, 11:06 AM

Apr 2 2022

thj abandoned D34048: Capture return values when registering waits.
Apr 2 2022, 7:40 PM

Mar 30 2022

thj updated the diff for D34672: siftr: expose t_flags2 in siftr output.
  • Update field sizes to match tcpcb
  • Update format string
Mar 30 2022, 12:36 PM

Mar 25 2022

thj requested review of D34674: etcupdate: remove redundant diff3 flag.
Mar 25 2022, 4:20 PM
thj added inline comments to D34551: kdb: set kdb_why when entered via reboot and panic.
Mar 25 2022, 3:27 PM
thj requested review of D34672: siftr: expose t_flags2 in siftr output.
Mar 25 2022, 2:51 PM

Mar 15 2022

thj added a comment to D34421: diff3: Add support for -A and -m.

There doesn't seem to be any specification of the diff3 behavior, so I spent some time looking for some test cases. GNU doesn't provide much directly in the source (https://git.savannah.gnu.org/cgit/diffutils.git/plain/tests/diff3) and also the mailing list isn't rich in corner cases relating to diff3. I've found some test cases for git's implementation (https://github.com/git/git/search?l=Shell&q=diff3) but I only skimmed that so I don't know how useful they are.

Mar 15 2022, 10:19 AM
thj committed R10:81e0e7b9e36d: bsnmp: Use mkstemp when creating clients local socket (authored by thj).
bsnmp: Use mkstemp when creating clients local socket
Mar 15 2022, 8:21 AM
thj closed D34550: bsnmp: Use mkstemp when creating clients local socket.
Mar 15 2022, 8:21 AM

Mar 14 2022

thj requested review of D34551: kdb: set kdb_why when entered via reboot and panic.
Mar 14 2022, 5:05 PM
thj added a comment to D34550: bsnmp: Use mkstemp when creating clients local socket.

I am not sure if FreeBSD is upstream here, it might be harti's own private tree, it isn't 100% clear to me.

Mar 14 2022, 3:41 PM
thj requested review of D34550: bsnmp: Use mkstemp when creating clients local socket.
Mar 14 2022, 3:39 PM

Mar 10 2022

thj committed R10:93b7af1d854d: diff: Re-add void argument to usage (authored by thj).
diff: Re-add void argument to usage
Mar 10 2022, 4:26 PM
thj committed R10:8cf449db88b2: diff: add support for --help and --version (authored by thj).
diff: add support for --help and --version
Mar 10 2022, 4:19 PM
thj closed D34508: diff: add support for --help and --version.
Mar 10 2022, 4:18 PM
thj added a comment to D34508: diff: add support for --help and --version.

Yeah, wrong diff point with arc diff, I am sure arcanist wasn't this much trouble to use before

Mar 10 2022, 2:38 PM
thj updated the diff for D34508: diff: add support for --help and --version.

Add back the code changes

Mar 10 2022, 2:38 PM
thj updated the diff for D34508: diff: add support for --help and --version.

Update based on man page feedback

Mar 10 2022, 1:31 PM

Mar 9 2022

thj requested review of D34508: diff: add support for --help and --version.
Mar 9 2022, 11:20 AM
thj committed R10:7e64519a479a: diff: set cflag when passed to diff (authored by thj).
diff: set cflag when passed to diff
Mar 9 2022, 9:35 AM
thj closed D34481: diff: set cflag when passed to diff.
Mar 9 2022, 9:35 AM

Mar 8 2022

thj requested review of D34481: diff: set cflag when passed to diff.
Mar 8 2022, 5:00 PM

Mar 4 2022

thj added a comment to D34421: diff3: Add support for -A and -m.

From the summary: "Add tests, first using the original provided 1.txt, 2.txt, 3.txt, but also add
lao tzu tao tests from the gnu diff3 how to guide and finally some manually
written tests which excised other cases."

Unless you really mean "precisely or surgically cut off with a sharp knife" (literally or figuratively), that should be "exercised".

Since (per https://reviews.freebsd.org/D34411#change-nX1rdgK113Nt) mg was explicitely put in the public domain, you could use it instead of lao tzu and tao.

Mar 4 2022, 9:16 AM

Mar 3 2022

thj updated the test plan for D34421: diff3: Add support for -A and -m.
Mar 3 2022, 10:31 AM
thj requested review of D34421: diff3: Add support for -A and -m.
Mar 3 2022, 10:30 AM

Mar 1 2022

thj committed R10:4be7d087c2b5: diff: Use start of change when searching for function (authored by thj).
diff: Use start of change when searching for function
Mar 1 2022, 1:28 PM
thj closed D34328: diff: Use change start when searching for function names.
Mar 1 2022, 1:28 PM

Feb 21 2022

thj requested review of D34328: diff: Use change start when searching for function names.
Feb 21 2022, 11:19 AM

Feb 18 2022

thj committed R10:3931c072c63d: diff: fix failed compare when ignoring file case (authored by thj).
diff: fix failed compare when ignoring file case
Feb 18 2022, 3:56 PM
thj closed D34201: Fix ignore case when diffing recursively.
Feb 18 2022, 3:55 PM
thj committed R10:cffebd1e8fed: Remove surplus check for which diff is being tested (authored by thj).
Remove surplus check for which diff is being tested
Feb 18 2022, 3:51 PM
thj committed R10:f4be3645a14d: diff: add --no-dereference flag (authored by thj).
diff: add --no-dereference flag
Feb 18 2022, 3:19 PM
thj closed D34203: Add support of --no-dereference.
Feb 18 2022, 3:18 PM
thj committed R10:8f79bd9b8571: diff: Detect Objective-C methods (authored by thj).
diff: Detect Objective-C methods
Feb 18 2022, 3:13 PM
thj closed D34202: Search for objective c method definitions.
Feb 18 2022, 3:13 PM

Feb 11 2022

thj updated the diff for D34201: Fix ignore case when diffing recursively.
  • Add tests for ignore case
  • Correct path passed to diffit when using Nflag or Pflag
Feb 11 2022, 1:20 PM

Feb 10 2022

thj updated the diff for D34202: Search for objective c method definitions.
  • Add tests for finding function names
Feb 10 2022, 3:18 PM
thj updated the diff for D34203: Add support of --no-dereference.

Update correctly

Feb 10 2022, 2:15 PM
thj updated the diff for D34203: Add support of --no-dereference.

fix a return issue and add tests

Feb 10 2022, 2:13 PM

Feb 8 2022

thj added a comment to D34204: sleepqueue: Address a lock order reversal.

This seems to fix the panic I was hitting. Before I could reliably panic by doing buildworld with -j 16 in a bhyve guest with 16 cores.

Feb 8 2022, 7:56 PM
thj requested review of D34203: Add support of --no-dereference.
Feb 8 2022, 2:08 PM
thj requested review of D34202: Search for objective c method definitions.
Feb 8 2022, 1:51 PM
thj updated the test plan for D34201: Fix ignore case when diffing recursively.
Feb 8 2022, 1:46 PM
thj added reviewers for D34201: Fix ignore case when diffing recursively: Klara, bapt.
Feb 8 2022, 1:46 PM
thj requested review of D34201: Fix ignore case when diffing recursively.
Feb 8 2022, 1:45 PM

Jan 28 2022

thj updated the diff for D34075: Fix wording in comments.

I didn't read the entire comment, correct english is
"fd did not allow write"
"fd allowed write"

Jan 28 2022, 10:50 AM
thj abandoned D34077: Fix wording in comments.
Jan 28 2022, 10:49 AM
thj requested review of D34077: Fix wording in comments.
Jan 28 2022, 10:48 AM
thj requested review of D34075: Fix wording in comments.
Jan 28 2022, 10:22 AM

Jan 27 2022

thj committed R10:4669f23ef76b: Remove SMALL conditionals from gzip (authored by thj).
Remove SMALL conditionals from gzip
Jan 27 2022, 5:28 PM
thj closed D34047: Remove SMALL conditionals from gzip.
Jan 27 2022, 5:28 PM
thj committed R10:21c966a6b9f2: Fix test output when gzip is run with -tlv (authored by thj).
Fix test output when gzip is run with -tlv
Jan 27 2022, 5:21 PM
thj closed D34046: Fix test output when gzip is run with -tlv.
Jan 27 2022, 5:21 PM
thj committed R10:f0ec0fda01c3: bsdinstall: Add quotes around error message argument (authored by thj).
bsdinstall: Add quotes around error message argument
Jan 27 2022, 5:16 PM
thj closed D33918: bsdinstall: Add quotes around error message argument.
Jan 27 2022, 5:15 PM
thj abandoned D21939: Enter chroot before looking up user or group to change to.

I actually thought I had abandoned this, If I remember gnu chroot looks up the user before and after the chroot so it can use the correct user id. I was told when creating the diff that this is an awful idea and I should use other tools.

Jan 27 2022, 10:01 AM

Jan 26 2022

thj requested review of D34048: Capture return values when registering waits.
Jan 26 2022, 4:09 PM
thj updated the test plan for D34046: Fix test output when gzip is run with -tlv.
Jan 26 2022, 2:29 PM
thj requested review of D34047: Remove SMALL conditionals from gzip.
Jan 26 2022, 2:26 PM
thj requested review of D34046: Fix test output when gzip is run with -tlv.
Jan 26 2022, 11:48 AM

Jan 17 2022

thj updated the test plan for D33918: bsdinstall: Add quotes around error message argument.
Jan 17 2022, 4:55 PM