Address Kyles review comments

• Address further comments from Mark

• Remove asan from makefiles

• Ensure there are enough bytes following the icmp header

• move libdiff into contrib

• use a RDTUN sysctl rather than a hint
• Use a global control for cppc notifications

• Simplify hint name

• Add a hint to disable the workaround

Update to building version

Looks good to me

• make strnsubst return a bool indicating if truncation occured

simplfy the eflag based on suggestions by dim

LGTM, please check with igor to be sure I am not a great mdoc parser.

• Correct copyright

• Add test cases for getsockopt

In D35531#805896, @markj wrote:

There are some other thresholds that are derived from the free target. zfs_arc_free_target, vmd_pageout_wakeup_thresh and vmd_background_launder_target, at least. It's not obvious to me that the system will behave sanely if those values are left unchanged. Though, today it's possible to modify the per-domain free targets, and the sysctl handler doesn't take any of this into account.

• Don't user diff3 and Nm
• bump date

In D35325#800913, @pauamma_gundo.com wrote:

Is it worth saying whether diff3 --help and diff3 --version output to stdout or stderr?

GNU diff3 has -v as a --version alias. Does the replacement want/have that? If so, should be added to the manual page.

Looks good to me

• Revert "ctld: Only use strtoul when str is not NULL"

Hits coverity id: 1474355 in our coverity