Page MenuHomeFreeBSD

thj (Tom Jones)
User

Projects

User Details

User Since
Jan 7 2016, 3:15 PM (175 w, 4 d)

Recent Activity

Thu, May 9

thj updated the diff for D16851: Add support for header chain validation on IPv6 Fragments (RFC7112).

Address review comments

Thu, May 9, 8:04 AM

Wed, May 8

thj added a comment to D19960: Remove support for RFC2675.

We wrote an ID:

Wed, May 8, 1:01 PM

Tue, Apr 23

thj accepted D20011: ip6_randomflowlabel: Avoid blocking if random(4) is not available.
Tue, Apr 23, 7:47 AM

Sun, Apr 21

thj added a comment to D19973: ip6_id: Avoid blocking if random(4) is not available.

I think we can just use zero for the label if enough entropy is not available. A flow label of zero indicates no flow label "treatment" in the network. On my test machine most early packets are already have a flow label of zero. From RFC 6437

Sun, Apr 21, 8:09 PM

Apr 19 2019

thj committed rS346398: Add stat counter for ipv6 atomic fragments.
Add stat counter for ipv6 atomic fragments
Apr 19 2019, 5:06 PM
thj closed D17511: Add stat counter for ipv6 atomic fragments.
Apr 19 2019, 5:06 PM
thj accepted D19966: Improve input validation for IPPROTO_IPV6 level socket option IPV6_CHECKSUM.

Looks good to me

Apr 19 2019, 4:39 PM
thj added a comment to D19960: Remove support for RFC2675.

I am okay with Jonathan's suggested plan.

Apr 19 2019, 6:57 AM

Apr 18 2019

thj updated the diff for D19960: Remove support for RFC2675.

Diff against correct tree

Apr 18 2019, 5:13 PM
thj created D19960: Remove support for RFC2675.
Apr 18 2019, 5:05 PM
thj closed D19952: Add a bugs section to pflog man page.
Apr 18 2019, 11:07 AM
thj committed rS346348: Add a bugs section to pflog man page.
Add a bugs section to pflog man page
Apr 18 2019, 11:07 AM
thj created D19952: Add a bugs section to pflog man page.
Apr 18 2019, 10:34 AM

Apr 16 2019

thj closed D19861: Update and clarify pflog man page.
Apr 16 2019, 1:31 PM
thj committed rS346274: Update and clarify pflog man page.
Update and clarify pflog man page
Apr 16 2019, 1:31 PM

Apr 9 2019

thj added reviewers for D19861: Update and clarify pflog man page: kristof, manpages, jtl, bz.
Apr 9 2019, 12:23 PM
thj created D19861: Update and clarify pflog man page.
Apr 9 2019, 12:22 PM

Feb 26 2019

thj added inline comments to D16851: Add support for header chain validation on IPv6 Fragments (RFC7112).
Feb 26 2019, 8:20 PM

Feb 21 2019

thj closed D17521: Correct accounting when dropping fragment queues.

typo in the commit message stopped this being closed automatically

Feb 21 2019, 2:21 PM
thj closed D18354: Fix style nit.

typo in the commit message stopped this being closed automatically

Feb 21 2019, 2:20 PM

Feb 19 2019

thj committed rS344301: When dropping a fragment queue count the number of fragments in the queue.
When dropping a fragment queue count the number of fragments in the queue
Feb 19 2019, 7:58 PM
thj committed rS344292: Fix style after r340832.
Fix style after r340832
Feb 19 2019, 7:05 PM

Nov 27 2018

thj created D18354: Fix style nit.
Nov 27 2018, 10:47 AM

Nov 26 2018

thj created D18343: test.
Nov 26 2018, 3:06 PM
thj abandoned D18343: test.
Nov 26 2018, 3:06 PM

Nov 23 2018

thj committed rS340832: Add support for none ACPI battery method batteries.
Add support for none ACPI battery method batteries
Nov 23 2018, 12:03 PM
thj closed D17434: Add support for none ACPI battery method batteries.
Nov 23 2018, 12:03 PM

Oct 25 2018

thj accepted D17703: Add a note about the Aberdeen hackathon to the event list for 2019..
Oct 25 2018, 5:13 PM
thj added inline comments to D17703: Add a note about the Aberdeen hackathon to the event list for 2019..
Oct 25 2018, 4:59 PM

Oct 11 2018

thj created D17521: Correct accounting when dropping fragment queues.
Oct 11 2018, 3:25 PM

Oct 10 2018

thj added a reviewer for D17511: Add stat counter for ipv6 atomic fragments: transport.
Oct 10 2018, 8:16 PM
thj created D17511: Add stat counter for ipv6 atomic fragments.
Oct 10 2018, 8:15 PM

Oct 8 2018

thj updated the diff for D16851: Add support for header chain validation on IPv6 Fragments (RFC7112).
  • Do pullup per protcol that requires it
Oct 8 2018, 8:28 PM
thj updated the diff for D16851: Add support for header chain validation on IPv6 Fragments (RFC7112).
  • Use (ip+exthdr len) + length when pulling up mbuf
Oct 8 2018, 7:34 PM

Oct 6 2018

thj edited P227 Masterwork From Distant Lands.
Oct 6 2018, 8:16 PM
thj updated the diff for D16851: Add support for header chain validation on IPv6 Fragments (RFC7112).
  • Teach netinet/in.h about dccp
  • Make sure length bytes are in the first mbuf
Oct 6 2018, 6:07 PM
thj added inline comments to D16851: Add support for header chain validation on IPv6 Fragments (RFC7112).
Oct 6 2018, 5:00 PM
thj added inline comments to D16851: Add support for header chain validation on IPv6 Fragments (RFC7112).
Oct 6 2018, 4:41 PM
thj updated the diff for D16851: Add support for header chain validation on IPv6 Fragments (RFC7112).
  • Correctly locate structs in mbuf chain
Oct 6 2018, 4:07 PM
thj updated the diff for D16851: Add support for header chain validation on IPv6 Fragments (RFC7112).
  • Add support for ipv4 in ipv6, gre and dccp fragments
  • Unstatic definition
  • address language issues in comments
Oct 6 2018, 1:09 PM

Oct 5 2018

thj created D17434: Add support for none ACPI battery method batteries.
Oct 5 2018, 2:54 PM
thj closed D17357: Convert UDP length to host byte order.
Oct 5 2018, 12:52 PM
thj committed rS339195: Convert UDP length to host byte order.
Convert UDP length to host byte order
Oct 5 2018, 12:51 PM

Oct 1 2018

thj added a reviewer for D17357: Convert UDP length to host byte order: transport.
Oct 1 2018, 11:41 AM

Sep 29 2018

thj added a reviewer for D17357: Convert UDP length to host byte order: jtl.
Sep 29 2018, 5:04 PM
thj created D17357: Convert UDP length to host byte order.
Sep 29 2018, 5:04 PM

Sep 27 2018

thj edited P224 Masterwork From Distant Lands.
Sep 27 2018, 8:17 PM

Sep 26 2018

thj edited P223 Masterwork From Distant Lands.
Sep 26 2018, 7:20 PM

Sep 21 2018

thj edited P222 Masterwork From Distant Lands.
Sep 21 2018, 9:01 AM

Sep 12 2018

thj edited P219 Masterwork From Distant Lands.
Sep 12 2018, 11:45 AM

Aug 23 2018

thj added a comment to D16851: Add support for header chain validation on IPv6 Fragments (RFC7112).
In D16851#359110, @ae wrote:
In D16851#359108, @ae wrote:

Also, I think ipfw/pf needs an additional look to correctly handle this too.

What you think, if we make non-static ip6_checkfirstfrag() function, that can also be used by ipfw/pf/ipfil etc.?

Aug 23 2018, 11:00 AM

Aug 22 2018

thj added reviewers for D16851: Add support for header chain validation on IPv6 Fragments (RFC7112): jtl, transport.
Aug 22 2018, 7:09 PM
thj updated the test plan for D16851: Add support for header chain validation on IPv6 Fragments (RFC7112).
Aug 22 2018, 7:08 PM
thj created D16851: Add support for header chain validation on IPv6 Fragments (RFC7112).
Aug 22 2018, 7:07 PM

Aug 19 2018

thj edited P213 Masterwork From Distant Lands.
Aug 19 2018, 6:33 PM
thj edited P212 Masterwork From Distant Lands.
Aug 19 2018, 6:31 PM
thj created P211 Test.
Aug 19 2018, 6:30 PM

Jun 8 2018

thj added a reviewer for D15692: Adding rtl8188ee driver to rtwn(4): thj.
Jun 8 2018, 7:45 AM · Src Committers

Jun 6 2018

thj committed rS334705: Use UDP len when calculating UDP checksums.
Use UDP len when calculating UDP checksums
Jun 6 2018, 7:05 AM
thj closed D15222: Use UDP len when calculating UDP checksums.
Jun 6 2018, 7:05 AM

May 23 2018

thj added a member for transport: thj.
May 23 2018, 6:37 AM

May 17 2018

thj updated the diff for D15222: Use UDP len when calculating UDP checksums.
  • Check if udp header is in first mbuf, if not copy in udp len. Address style issues
May 17 2018, 1:58 PM
thj added inline comments to D15222: Use UDP len when calculating UDP checksums.
May 17 2018, 1:57 PM

May 10 2018

thj added a comment to D15358: Address memory leak in new reno cc module.

@wollman Many thanks for the historical and standards related context - greatly appreciated. I realised that I probably need to update getsockopt(2)/setsockopt(2) as well...
@thj Ok, well in the interest of expediency given the severity of the bug, I guess proceeding before confirming ABE functionality would be a good idea. Would you like to exercise your newly minted commit bit for this or should I commit?

May 10 2018, 10:05 AM
thj added a comment to D15358: Address memory leak in new reno cc module.
In D15358#323834, @thj wrote:

Still to be tested, but I think something like this would address the leak and change memory allocation to being conditional on need: newreno_plugleak_v1.diff

This reads okay.
I ran through a loop with netcat and didn't doesn't leak(of course it wouldn't!) and tested setting the abe beta values via set sockopt with a modified netcat (https://people.freebsd.org/~thj/diffs/ncabe.diff). This also doesn't leak.

@thj Cool. Did you also verify that ABE does in fact work as expected in the presence of ECN marks?

May 10 2018, 9:50 AM

May 9 2018

thj added a comment to D15358: Address memory leak in new reno cc module.

Still to be tested, but I think something like this would address the leak and change memory allocation to being conditional on need: newreno_plugleak_v1.diff

May 9 2018, 11:13 AM

May 8 2018

thj added reviewers for D15358: Address memory leak in new reno cc module: lstewart, jtl, network.
May 8 2018, 8:03 PM
thj created D15358: Address memory leak in new reno cc module.
May 8 2018, 8:02 PM

Apr 28 2018

thj added reviewers for D15222: Use UDP len when calculating UDP checksums: jtl, network.
Apr 28 2018, 3:57 PM
thj created D15222: Use UDP len when calculating UDP checksums.
Apr 28 2018, 3:55 PM

Apr 11 2018

thj updated the diff for D15043: Add Tom Jones (thj) as a new src committer..

Make the indentation in for "event" blocks news.xml match. It was equal number of spaces to tabs, now is tabs.

Apr 11 2018, 8:28 PM
thj updated the diff for D15043: Add Tom Jones (thj) as a new src committer..

Move my entries to above mjoras

Apr 11 2018, 5:29 PM
thj created D15043: Add Tom Jones (thj) as a new src committer..
Apr 11 2018, 3:05 PM
thj created D15042: Add myself to committers-src.dot.
Apr 11 2018, 2:59 PM

Mar 16 2018

thj updated the diff for D11616: Add support for TCP ABE draft-khademi-tcpm-alternativebackoff-ecn.

Fix merge conflict

Mar 16 2018, 3:00 PM

Nov 29 2017

thj updated the diff for D13293: Don't return IIC_Exxxxx status values to userspace.

Wrap calls with iic2errno converter

Nov 29 2017, 3:13 PM
thj updated the diff for D13293: Don't return IIC_Exxxxx status values to userspace.

Recreate diff using svn diff --diff-cmd=diff -x -U999999 > change.diff

Nov 29 2017, 2:42 PM
thj created D13293: Don't return IIC_Exxxxx status values to userspace.
Nov 29 2017, 2:34 PM
thj added a reviewer for D13086: Add chvgpio driver for gpio present of Intel z8000 series (Cherry View) SOC: gavin.
Nov 29 2017, 11:47 AM

Nov 17 2017

thj updated the diff for D13086: Add chvgpio driver for gpio present of Intel z8000 series (Cherry View) SOC.

Add leading 'The'

Nov 17 2017, 8:11 PM
thj updated the diff for D13086: Add chvgpio driver for gpio present of Intel z8000 series (Cherry View) SOC.

Remove #if 0'd code.

Nov 17 2017, 6:48 PM
thj added a comment to D13086: Add chvgpio driver for gpio present of Intel z8000 series (Cherry View) SOC.

Is the name correct?
https://ark.intel.com/search?q=Cherry+View -- nothing found.
https://ark.intel.com/search?q=Atom+Z8 -- finds several "Processor X Series" chips; click one, and it lists the codename as "Cherry Trail".

Nov 17 2017, 10:04 AM

Nov 16 2017

thj added a reviewer for D13086: Add chvgpio driver for gpio present of Intel z8000 series (Cherry View) SOC: gonzo.
Nov 16 2017, 7:35 AM

Nov 14 2017

thj added a reviewer for D13086: Add chvgpio driver for gpio present of Intel z8000 series (Cherry View) SOC: manpages.
Nov 14 2017, 2:59 PM
thj created D13086: Add chvgpio driver for gpio present of Intel z8000 series (Cherry View) SOC.
Nov 14 2017, 2:53 PM

Sep 12 2017

thj updated the diff for D11616: Add support for TCP ABE draft-khademi-tcpm-alternativebackoff-ecn.

add hook for cb_destroy to recover struct newreno allocation in cb_init

Sep 12 2017, 1:30 PM
thj updated the diff for D11616: Add support for TCP ABE draft-khademi-tcpm-alternativebackoff-ecn.

Capture the struct newreno point in cc_var.

Sep 12 2017, 12:55 PM

Aug 17 2017

thj updated the diff for D11616: Add support for TCP ABE draft-khademi-tcpm-alternativebackoff-ecn.

Fix changes cause by r321480

Aug 17 2017, 12:40 PM

Aug 3 2017

thj created D11850: Document usb verbosity levels.
Aug 3 2017, 5:22 PM

Aug 2 2017

thj updated the diff for D11616: Add support for TCP ABE draft-khademi-tcpm-alternativebackoff-ecn.

Address nit comments.

Aug 2 2017, 12:04 PM

Jul 27 2017

thj updated the diff for D11616: Add support for TCP ABE draft-khademi-tcpm-alternativebackoff-ecn.

Update tcp(4) and cc_newreno(4)

Jul 27 2017, 2:48 PM
thj updated the diff for D11616: Add support for TCP ABE draft-khademi-tcpm-alternativebackoff-ecn.

Make sysctl comments clearer.

Jul 27 2017, 11:11 AM

Jul 20 2017

thj updated the diff for D11616: Add support for TCP ABE draft-khademi-tcpm-alternativebackoff-ecn.

Address potential overflow when computing cwnd.

Jul 20 2017, 4:39 PM

Jul 18 2017

thj updated the diff for D11616: Add support for TCP ABE draft-khademi-tcpm-alternativebackoff-ecn.

Address Copyright comment. Bump Swinburne copyright year, keep the comment from Grenville about changes.

Jul 18 2017, 6:27 AM

Jul 17 2017

thj created D11616: Add support for TCP ABE draft-khademi-tcpm-alternativebackoff-ecn.
Jul 17 2017, 4:48 AM