I have been digging and I think I have all the background for why this was
removed in r87145.

Respond to review comments

Address review comments

We wrote an ID:

I think we can just use zero for the label if enough entropy is not available. A flow label of zero indicates no flow label "treatment" in the network. On my test machine most early packets are already have a flow label of zero. From RFC 6437

Looks good to me

I am okay with Jonathan's suggested plan.

Diff against correct tree

typo in the commit message stopped this being closed automatically

typo in the commit message stopped this being closed automatically

• Do pullup per protcol that requires it

• Use (ip+exthdr len) + length when pulling up mbuf

• Teach netinet/in.h about dccp
• Make sure length bytes are in the first mbuf

• Correctly locate structs in mbuf chain

• Add support for ipv4 in ipv6, gre and dccp fragments
• Unstatic definition
• address language issues in comments

In D16851#359110, @ae wrote:

In D16851#359108, @ae wrote:

Also, I think ipfw/pf needs an additional look to correctly handle this too.

What you think, if we make non-static ip6_checkfirstfrag() function, that can also be used by ipfw/pf/ipfil etc.?

• Check if udp header is in first mbuf, if not copy in udp len. Address style issues

In D15358#324176, @lstewart wrote:

@wollman Many thanks for the historical and standards related context - greatly appreciated. I realised that I probably need to update getsockopt(2)/setsockopt(2) as well...
@thj Ok, well in the interest of expediency given the severity of the bug, I guess proceeding before confirming ABE functionality would be a good idea. Would you like to exercise your newly minted commit bit for this or should I commit?

In D15358#324097, @lstewart wrote:

In D15358#323834, @thj wrote:

In D15358#323759, @lstewart wrote:

Still to be tested, but I think something like this would address the leak and change memory allocation to being conditional on need: newreno_plugleak_v1.diff

This reads okay.
I ran through a loop with netcat and didn't doesn't leak(of course it wouldn't!) and tested setting the abe beta values via set sockopt with a modified netcat (https://people.freebsd.org/~thj/diffs/ncabe.diff). This also doesn't leak.

@thj Cool. Did you also verify that ABE does in fact work as expected in the presence of ECN marks?

In D15358#323759, @lstewart wrote:

Still to be tested, but I think something like this would address the leak and change memory allocation to being conditional on need: newreno_plugleak_v1.diff

Make the indentation in for "event" blocks news.xml match. It was equal number of spaces to tabs, now is tabs.

Move my entries to above mjoras

Fix merge conflict

Wrap calls with iic2errno converter

Recreate diff using svn diff --diff-cmd=diff -x -U999999 > change.diff

Add leading 'The'

Remove #if 0'd code.

In D13086#272907, @rpokala wrote:

Is the name correct?
https://ark.intel.com/search?q=Cherry+View -- nothing found.
https://ark.intel.com/search?q=Atom+Z8 -- finds several "Processor X Series" chips; click one, and it lists the codename as "Cherry Trail".

add hook for cb_destroy to recover struct newreno allocation in cb_init

Capture the struct newreno point in cc_var.

Fix changes cause by r321480

Address nit comments.

Update tcp(4) and cc_newreno(4)