• fix build
• add support selecting atom c2000 processors and their weird register
• rename driver and export names to 'intel_rapl'
• fix modules build

Deduplicate, rearrange and add MSR for Atom C2000 power

In D56791#1305613, @thj wrote:

In D56791#1301900, @adrian wrote:

what's the earliest chipset this supports? (eg the Atom C2xxx / C3xxx ones?)

The earliest hardware supported by the first version of this driver is 6th generation. I have used the models from the SDM vol4 table "models in 6th-13th gen plus some other assorted stuff" chapter.

In D56791#1301900, @adrian wrote:

what's the earliest chipset this supports? (eg the Atom C2xxx / C3xxx ones?)

Handle ip block names being different on model 0x70 cpus

Address review comments

Fix some build regressions and rebase

Add missing files highlighted by @jrm's stage-qa

Thanks, I've updated the other review.

I said I would help Aymeric with this review, from a quick read it seems fine. I haven't thrown it at hardware and I'm not really that familiar with the TB/USB4 side of things.

Remove PORTREVISION
Add full context diff

Incorporate feedback from @jrm

@jrm last time you generated the plist for me, but I don't remember how you got everything picked up correctly. Can you help?

I think we should probably have tests check we do the correct things when we get a jumbogram. If these tests aren't run they don't really help with that.

Address review comments

This looks ok, but I will have to admit that diff3 was always a bit of a mystery box. Please update the comment, but assuming tests don't start failing I'm willing to bet this is an improvement.

Address review comments

rebase

remove sleeps

remove fifo configuration and delays

• correct NMM clock sizes to be 8 rather than 7 bits

In D9157#1257822, @bms wrote:

In D9157#1203022, @lwhsu wrote:

For more information, check D51299 and https://people.allbsd.org/~hrs/FreeBSD/udbc/

I can't seem to access this udbc URL you have quoted above, and it's not in the Wayback Machine either. If it matters, I route all my traffic via Mullvad VPN and I'm based in a semi-rural area of Scotland at the moment.

I'm in touch with a German vendor for DbC cables, Lauterbach. Importing the cables into UK will be difficult post-Brexit. Microsoft's suggested vendor, DataPro.net, will not accept orders below 200USD for non-VAT registered entities.

I have a limited company formation pending, so I may be able to obtain a small batch for UK-based committers to work with at cost.

P.S. I was very sorry to learn of Hans' passing, albeit belatedly. I just regained Phabricator access after a nearly 8 year hiatus due to health issues and family bereavement. Long story. I have contacted core-secretary@ about this.

Thanks for the heads up I'll update those too.

• address review comments

Rebase (well manually port) changes up to CURRENT from 7 years ago.