- User Since
- Jun 15 2015, 5:39 PM (328 w, 6 h)
Thanks for the find! Looks reasonable to bring in. I will try to get more test coverage from our users, though feedback was low on this particular hang ;(
Wed, Sep 15
Added motivation for checking for untagged priority to the filter program comments.
add comment about need to test for VID 0 presence
Tue, Sep 14
Not sure about omitting the match on a NAT rule, but doing it inside the log code was definitely wrong.
void REASON_SET by directly passing PFRES_MATCH
Wed, Sep 8
But to be fair both rules are matching accounting-wise unless we assume that only "pass" can account for "match".
Thu, Sep 2
There is an older discussion about it here https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=224961
Aug 19 2021
- skip to end on vlanid != 0 and add comments
Aug 18 2021
Correct. Here is the test:
- lease declaration skip fixes
Use EVL_VLID_MASK as suggested
OpenBSD added the single htons() while adding write filter, but nowhere else. I suspect the fragmentation check is mostly correct so this doesn't matter in the real world.
constify filters and avoid static length variables
Appreciate the reviews :) Unfortunately I'm not a committer so is someone willing to help out? Thanks in advance.
Aug 17 2021
fixed partial length on tx
Another one refactored
Aug 16 2021
Aug 14 2021
That would be great, thanks!
Aug 13 2021
The only other script is the DNS script and it looks like -u already does append the sender address to that script's data.
now avoids raw access to ntopbuf from scripts call
Aug 12 2021
Merged into https://reviews.freebsd.org/D31501
Much nicer, thanks! Added Stephan as reviewer who originally worked on this to give it a go.
Aug 11 2021
Apr 23 2021
On second thought: maybe I'm mixing up hardware. I'm not sure, but in either case 12.x does seem not exhibit this issue judging from the complete lack of user reports.
@kbowling for us https://cgit.freebsd.org/src/commit/?id=0aa7d3ff9ea resolved the issue back then and has not come back. Is this meant to replace it or to be applied on top? I can test it on the specific hardware, but unsure if this will be inconclusive for the mentioned reason
Sep 10 2020
Thanks for the update :)
Oct 24 2018
Oct 22 2018
@skozlov feel free to take maintainership of net/intel-em-kmod and thanks for working on these modules! :)
Oct 21 2018
"if:0" and "(if:0)" have separate implementations. the one for "if:0" is missing, see ifa_lookup() in sbin/pfctl/pfctl_parser.c
Oct 12 2018
Oct 7 2018
Looks good, thanks!
Jul 23 2018
We all invest time so thank you for the offer. Yes, I am OK with that.
I do not wish to acknowledge the advertising in the commit message.
I'm sorry, I'm playing by the rules that FreeBSD imposes on its external contributors.
There's a PR here https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=229904
Feb 13 2018
Any news on this? :)
Jan 31 2018
Seeing this after migration...
Aug 29 2017
this one is stable, thank you @ale
Aug 22 2017
No, I'm not asking for support that would take a few weeks of ping pong in a bug tracker, if any. This is real world feedback for this review. Take it or leave it. :)
Thanks, but we've narrowed it down to this commit.
We do seem to have a persistent problem with this patch in some PPPoE environments that will cause a crash in ng_pppoe_rcvdata_ether():
Jul 13 2017
Nevermind, now it displays correctly. Please commit. :)
can you rebase this patch? it looks off with the update to 3.2.2 and no OPTIONS_DEFINE like it was already applied
Jun 16 2017
So FWIW I stand by the approval of the previous version that does not use REDIS_CONFIGURE_ENABLE.
Jun 14 2017
Jun 13 2017
Jun 12 2017
Jun 11 2017
looks good, will accept after typo fix :)
Apr 9 2017
Jan 2 2017
Dec 26 2016
- correctly build against GENERIC
Dec 22 2016
I've updated the TUNNELBLICK patch to work with 2.4, it was just a clash with the new code formatting. Looks good so far, runtime test is pending.
Dec 21 2016
- omit empty reads for ip_get_fwdtag
- error out safely on failure
- use else if
- complete conversion
- requested changes