Page MenuHomeFreeBSD

franco_opnsense.org (Franco Fichtner)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 15 2015, 5:39 PM (362 w, 7 h)

Recent Activity

Thu, May 12

franco_opnsense.org accepted D35178: Add end to end tests for dhclient.

LGTM, thanks!

Thu, May 12, 6:26 AM

Feb 28 2022

franco_opnsense.org updated the diff for D34393: debugnet: remove spurious message on boot.

update as mentioned

Feb 28 2022, 6:32 PM
franco_opnsense.org abandoned D34397: debugnet: remove spurious message on boot.

created new review instead of update

Feb 28 2022, 6:31 PM
franco_opnsense.org requested review of D34397: debugnet: remove spurious message on boot.
Feb 28 2022, 6:30 PM
franco_opnsense.org updated the summary of D34393: debugnet: remove spurious message on boot.
Feb 28 2022, 11:34 AM
franco_opnsense.org added a reviewer for D34393: debugnet: remove spurious message on boot: cem.
Feb 28 2022, 11:33 AM
franco_opnsense.org requested review of D34393: debugnet: remove spurious message on boot.
Feb 28 2022, 11:33 AM

Feb 21 2022

franco_opnsense.org added inline comments to D34329: stand: add EFI support for mmio serial consoles.
Feb 21 2022, 4:49 PM
franco_opnsense.org added inline comments to D34329: stand: add EFI support for mmio serial consoles.
Feb 21 2022, 3:59 PM
franco_opnsense.org added a reviewer for D34329: stand: add EFI support for mmio serial consoles: imp.
Feb 21 2022, 2:02 PM
franco_opnsense.org requested review of D34329: stand: add EFI support for mmio serial consoles.
Feb 21 2022, 2:01 PM

Feb 14 2022

franco_opnsense.org added a comment to D31515: dhclient: support VID 0 (no vlan) decapsulation.

thanks a lot :)

Feb 14 2022, 7:21 PM
franco_opnsense.org added a comment to D31515: dhclient: support VID 0 (no vlan) decapsulation.

Sorry for the delay. I have no objections to the change and the implementation looks fine. I am a little wary of committing it without some wider approval: could I ask you to post a short note to freebsd-net@ linking this diff and soliciting opinions? If there are no objections after a week or so I will commit this.

Feb 14 2022, 11:16 AM
franco_opnsense.org added a reviewer for D34266: pf: fix set_prio after nv conversion: kp.
Feb 14 2022, 8:33 AM
franco_opnsense.org requested review of D34266: pf: fix set_prio after nv conversion.
Feb 14 2022, 8:32 AM

Jan 31 2022

franco_opnsense.org added a comment to D29075: Hyper-V: hn: Enable vSwitch RSC support in hn netvsc driver.

We have multiple reports that this causes throughput regressions when in use on 13-STABLE as opposed to 13.0-RELEASE where it is not present. We have had this commit reverted and speeds are back to normal for our OPNsense users. For more info see https://forum.opnsense.org/index.php?topic=26364.0

Jan 31 2022, 6:44 AM

Jan 27 2022

franco_opnsense.org abandoned D33432: dummynet: remove locks causing panics during callout.
Jan 27 2022, 11:13 AM
franco_opnsense.org added a comment to D34053: dummynet: use atomics to maintain pie_desc.ref_count.

fqpie_callout_cleanup() should exhibit the same issue

Jan 27 2022, 9:45 AM

Jan 4 2022

franco_opnsense.org added a comment to D33432: dummynet: remove locks causing panics during callout.
In D33432#755856, @kp wrote:

I was thinking the same at first but the locking introduced in https://cgit.freebsd.org/src/commit/sys/netpfil/ipfw/dn_aqm_pie.c?id=12be18c7d594 looks arbitrary and isn't anywhere else in those two files. It was added to "protect" the ref_count manipulation, but if you look at the other ref_count modification in that file these are also done without (obvious) locks.

Maybe these ref_count modifications should receive atomic updates without locks to avoid the locking overhead completely?

Perhaps, yes.

Although it looks like the ref_count is only read in unload_dn_aqm(), under the sched_mtx lock. That lock lives only in ip_dummynet.c, so I wonder if we shouldn't just move the updating of the reference count to dn_aqm_ref()/dn_aqm_unref() and protect it with the sched_mtx lock. That doesn't need vnet, so we don't have to worry about setting the context (because it's about a global setting, so using a vnet-ed lock is wrong anyway) and we actually clean the locking up a little.

Jan 4 2022, 9:23 AM

Dec 14 2021

franco_opnsense.org added a comment to D33432: dummynet: remove locks causing panics during callout.

I was thinking the same at first but the locking introduced in https://cgit.freebsd.org/src/commit/sys/netpfil/ipfw/dn_aqm_pie.c?id=12be18c7d594 looks arbitrary and isn't anywhere else in those two files. It was added to "protect" the ref_count manipulation, but if you look at the other ref_count modification in that file these are also done without (obvious) locks.

Dec 14 2021, 1:09 PM
franco_opnsense.org added a comment to D33432: dummynet: remove locks causing panics during callout.
In D33432#755816, @kp wrote:

Do you have a description on how to trigger this panic?

Dec 14 2021, 10:21 AM
franco_opnsense.org added a reviewer for D33429: dummynet: drop unused definitions: kp.
Dec 14 2021, 9:39 AM
franco_opnsense.org added a reviewer for D33432: dummynet: remove locks causing panics during callout: kp.
Dec 14 2021, 9:38 AM
franco_opnsense.org requested review of D33432: dummynet: remove locks causing panics during callout.
Dec 14 2021, 9:37 AM
franco_opnsense.org requested review of D33429: dummynet: drop unused definitions.
Dec 14 2021, 8:06 AM

Dec 10 2021

franco_opnsense.org added a comment to D8877: netinet[6]: KPI for opaque fwd_tag handling for PFIL consumers.
In D8877#754326, @mjg wrote:

what's the fate of this patch?

Dec 10 2021, 7:36 AM

Nov 18 2021

franco_opnsense.org added a comment to D33020: Remove "options PCBGROUP".

Just as a comment: With all these ties to RSS defines I'm not sure where that leaves the RSS feature with regard to its multiple hardware/software use cases but there's no point in blocking this with no visible consumers. I'll make sure to give this a test once it hits main.

Nov 18 2021, 6:47 AM
franco_opnsense.org accepted D33019: Allow to compile RSS without PCBGROUP..
Nov 18 2021, 6:36 AM

Oct 28 2021

franco_opnsense.org added a comment to D32585: SMR protection for inpcbs.
In D32585#737015, @np wrote:

Note. This change requires PCBGROUP to be retired.

Have you circulated this proposal in the wider -net and -vendor community? I know of one downstream that uses this feature.

It looks like opnsense is trying to make use of pcbgroups/rss, might want to check with @franco_opnsense.org

I don't see much history here https://github.com/opnsense/src/commits/master/sys/netinet/in_pcbgroup.c
Anyway, adding Franco as reviewer.

Oct 28 2021, 9:20 AM

Sep 27 2021

franco_opnsense.org accepted D32087: e1000: Re-arm link changes.

Thanks for the find! Looks reasonable to bring in. I will try to get more test coverage from our users, though feedback was low on this particular hang ;(

Sep 27 2021, 7:35 AM

Sep 15 2021

franco_opnsense.org added a comment to D31515: dhclient: support VID 0 (no vlan) decapsulation.

Added motivation for checking for untagged priority to the filter program comments.

Sep 15 2021, 8:12 AM
franco_opnsense.org updated the diff for D31515: dhclient: support VID 0 (no vlan) decapsulation.

add comment about need to test for VID 0 presence

Sep 15 2021, 8:07 AM

Sep 14 2021

franco_opnsense.org added a comment to D31504: pf: always log nat rule and do it pre-rewrite.

Not sure about omitting the match on a NAT rule, but doing it inside the log code was definitely wrong.

Sep 14 2021, 12:05 PM
franco_opnsense.org updated the diff for D31504: pf: always log nat rule and do it pre-rewrite.

void REASON_SET by directly passing PFRES_MATCH

Sep 14 2021, 12:04 PM

Sep 8 2021

franco_opnsense.org added a comment to D31504: pf: always log nat rule and do it pre-rewrite.

But to be fair both rules are matching accounting-wise unless we assume that only "pass" can account for "match".

Sep 8 2021, 1:03 PM
franco_opnsense.org added inline comments to D31504: pf: always log nat rule and do it pre-rewrite.
Sep 8 2021, 1:00 PM

Sep 2 2021

franco_opnsense.org added a comment to D31515: dhclient: support VID 0 (no vlan) decapsulation.

There is an older discussion about it here https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=224961

Sep 2 2021, 8:40 AM

Aug 19 2021

franco_opnsense.org added inline comments to D31515: dhclient: support VID 0 (no vlan) decapsulation.
Aug 19 2021, 7:22 PM
franco_opnsense.org updated the diff for D31515: dhclient: support VID 0 (no vlan) decapsulation.
  • skip to end on vlanid != 0 and add comments
Aug 19 2021, 7:18 PM

Aug 18 2021

franco_opnsense.org added a comment to D31527: dhclient: skip_to_semi() consumes semicolon already.

Correct. Here is the test:

Aug 18 2021, 9:09 PM
franco_opnsense.org updated the diff for D31527: dhclient: skip_to_semi() consumes semicolon already.
  • lease declaration skip fixes
Aug 18 2021, 9:05 PM
franco_opnsense.org added inline comments to D31515: dhclient: support VID 0 (no vlan) decapsulation.
Aug 18 2021, 8:22 PM
franco_opnsense.org updated the diff for D31515: dhclient: support VID 0 (no vlan) decapsulation.

Use EVL_VLID_MASK as suggested

Aug 18 2021, 8:21 PM
franco_opnsense.org added a comment to D31502: dhclient: remove the need to patch static values.

OpenBSD added the single htons() while adding write filter, but nowhere else. I suspect the fragmentation check is mostly correct so this doesn't matter in the real world.

Aug 18 2021, 7:59 PM
franco_opnsense.org updated the diff for D31502: dhclient: remove the need to patch static values.

constify filters and avoid static length variables

Aug 18 2021, 7:58 PM
franco_opnsense.org updated the summary of D31550: iflib: emulate counters in netmap mode.
Aug 18 2021, 7:16 AM
franco_opnsense.org added a comment to D31550: iflib: emulate counters in netmap mode.

Appreciate the reviews :) Unfortunately I'm not a committer so is someone willing to help out? Thanks in advance.

Aug 18 2021, 7:00 AM
franco_opnsense.org added reviewers for D31515: dhclient: support VID 0 (no vlan) decapsulation: kevans, markj.
Aug 18 2021, 6:55 AM
franco_opnsense.org updated the summary of D31503: dhclient: support supersede statement for option 54.
Aug 18 2021, 6:54 AM
franco_opnsense.org added reviewers for D31527: dhclient: skip_to_semi() consumes semicolon already: markj, kevans.
Aug 18 2021, 6:48 AM
franco_opnsense.org added reviewers for D31502: dhclient: remove the need to patch static values: kevans, markj.
Aug 18 2021, 6:41 AM

Aug 17 2021

franco_opnsense.org added inline comments to D31584: gre: simplify RSS ifdefs.
Aug 17 2021, 11:48 AM
franco_opnsense.org added inline comments to D31550: iflib: emulate counters in netmap mode.
Aug 17 2021, 11:44 AM
franco_opnsense.org updated the diff for D31550: iflib: emulate counters in netmap mode.

fixed partial length on tx

Aug 17 2021, 11:42 AM
franco_opnsense.org requested review of D31584: gre: simplify RSS ifdefs.
Aug 17 2021, 9:43 AM
franco_opnsense.org retitled D31583: netinet: simplify RSS ifdef statements from netinet: simplify the RSS if statement to netinet: simplify RSS ifdef statements.
Aug 17 2021, 9:24 AM
franco_opnsense.org updated the diff for D31583: netinet: simplify RSS ifdef statements.

Another one refactored

Aug 17 2021, 9:22 AM
franco_opnsense.org requested review of D31583: netinet: simplify RSS ifdef statements.
Aug 17 2021, 9:15 AM

Aug 16 2021

franco_opnsense.org added a reviewer for D31550: iflib: emulate counters in netmap mode: vmaffione.
Aug 16 2021, 7:59 AM
franco_opnsense.org requested review of D31550: iflib: emulate counters in netmap mode.
Aug 16 2021, 7:53 AM
franco_opnsense.org accepted D31501: e1000: always enable PCSD when RSS hashing is used.
Aug 16 2021, 6:41 AM

Aug 14 2021

franco_opnsense.org added a comment to D31518: rtsold: pass sending router address to other and managed script.

That would be great, thanks!

Aug 14 2021, 1:18 PM

Aug 13 2021

franco_opnsense.org added a comment to D31518: rtsold: pass sending router address to other and managed script.

The only other script is the DNS script and it looks like -u already does append the sender address to that script's data.

Aug 13 2021, 7:21 PM
franco_opnsense.org requested review of D31527: dhclient: skip_to_semi() consumes semicolon already.
Aug 13 2021, 11:13 AM
franco_opnsense.org added inline comments to D31518: rtsold: pass sending router address to other and managed script.
Aug 13 2021, 6:22 AM
franco_opnsense.org updated the diff for D31518: rtsold: pass sending router address to other and managed script.

now avoids raw access to ntopbuf from scripts call

Aug 13 2021, 6:18 AM

Aug 12 2021

franco_opnsense.org added inline comments to D31518: rtsold: pass sending router address to other and managed script.
Aug 12 2021, 6:48 PM
franco_opnsense.org added a reviewer for D31518: rtsold: pass sending router address to other and managed script: markj.
Aug 12 2021, 8:48 AM
franco_opnsense.org requested review of D31518: rtsold: pass sending router address to other and managed script.
Aug 12 2021, 8:48 AM
franco_opnsense.org added a reviewer for D31517: rtsold: auto-probe point to point interfaces: markj.
Aug 12 2021, 8:40 AM
franco_opnsense.org requested review of D31517: rtsold: auto-probe point to point interfaces.
Aug 12 2021, 8:39 AM
franco_opnsense.org requested review of D31515: dhclient: support VID 0 (no vlan) decapsulation.
Aug 12 2021, 8:14 AM
franco_opnsense.org retitled D31501: e1000: always enable PCSD when RSS hashing is used from e1000: do not check for multiqueue when setting non-RSS features to e1000: always enable PCSD when RSS hashing is used.
Aug 12 2021, 7:14 AM
franco_opnsense.org abandoned D31499: e1000: always enable PCSD when RSS hashing is used.

Merged into https://reviews.freebsd.org/D31501

Aug 12 2021, 7:08 AM
franco_opnsense.org accepted D31501: e1000: always enable PCSD when RSS hashing is used.

Much nicer, thanks! Added Stephan as reviewer who originally worked on this to give it a go.

Aug 12 2021, 7:05 AM
franco_opnsense.org added a reviewer for D31501: e1000: always enable PCSD when RSS hashing is used: stephan.dewt_yahoo.co.uk.
Aug 12 2021, 6:59 AM

Aug 11 2021

franco_opnsense.org updated the summary of D31499: e1000: always enable PCSD when RSS hashing is used.
Aug 11 2021, 9:10 AM
franco_opnsense.org added a reviewer for D31504: pf: always log nat rule and do it pre-rewrite: kp.
Aug 11 2021, 8:26 AM
franco_opnsense.org requested review of D31504: pf: always log nat rule and do it pre-rewrite.
Aug 11 2021, 8:24 AM
franco_opnsense.org requested review of D31503: dhclient: support supersede statement for option 54.
Aug 11 2021, 8:12 AM
franco_opnsense.org requested review of D31502: dhclient: remove the need to patch static values.
Aug 11 2021, 7:40 AM
franco_opnsense.org added a reviewer for D31501: e1000: always enable PCSD when RSS hashing is used: kbowling.
Aug 11 2021, 7:26 AM
franco_opnsense.org requested review of D31501: e1000: always enable PCSD when RSS hashing is used.
Aug 11 2021, 7:25 AM
franco_opnsense.org updated the summary of D31499: e1000: always enable PCSD when RSS hashing is used.
Aug 11 2021, 7:25 AM
franco_opnsense.org requested review of D31499: e1000: always enable PCSD when RSS hashing is used.
Aug 11 2021, 7:13 AM

Apr 23 2021

franco_opnsense.org added a comment to D29943: e1000: enable "other" interrupt on 82574.

On second thought: maybe I'm mixing up hardware. I'm not sure, but in either case 12.x does seem not exhibit this issue judging from the complete lack of user reports.

Apr 23 2021, 9:44 AM
franco_opnsense.org added a comment to D29943: e1000: enable "other" interrupt on 82574.

@kbowling for us https://cgit.freebsd.org/src/commit/?id=0aa7d3ff9ea resolved the issue back then and has not come back. Is this meant to replace it or to be applied on top? I can test it on the specific hardware, but unsure if this will be inconclusive for the mentioned reason

Apr 23 2021, 9:17 AM

Sep 10 2020

franco_opnsense.org accepted D26383: net/intel-em-kmod: Update to 7.7.8.

Thanks for the update :)

Sep 10 2020, 8:03 AM

Oct 24 2018

franco_opnsense.org accepted D17633: pf: Make ':0' ignore link-local v6 addresses too.
Oct 24 2018, 5:34 AM

Oct 22 2018

franco_opnsense.org accepted D17646: net/intel-{ix,em}-kmod: freeze PORTREVISION and PORTEPOCH.

@skozlov feel free to take maintainership of net/intel-em-kmod and thanks for working on these modules! :)

Oct 22 2018, 11:31 AM · Intel Networking

Oct 21 2018

franco_opnsense.org requested changes to D17633: pf: Make ':0' ignore link-local v6 addresses too.

"if:0" and "(if:0)" have separate implementations. the one for "if:0" is missing, see ifa_lookup() in sbin/pfctl/pfctl_parser.c

Oct 21 2018, 4:16 PM

Oct 12 2018

franco_opnsense.org accepted D17533: net/intel-ixl-kmod: Remove -Werror from CFLAGS.
Oct 12 2018, 2:41 PM · Intel Networking

Oct 7 2018

franco_opnsense.org accepted D17440: net/intel-em-kmod: Update to 7.7.4, enable netmap on 11.

Looks good, thanks!

Oct 7 2018, 1:07 PM · Intel Networking

Jul 23 2018

franco_opnsense.org accepted D16366: Update security/suricata to 4.0.5.

We all invest time so thank you for the offer. Yes, I am OK with that.

Jul 23 2018, 2:58 PM
franco_opnsense.org added a comment to D16366: Update security/suricata to 4.0.5.

I do not wish to acknowledge the advertising in the commit message.

Jul 23 2018, 2:47 PM
franco_opnsense.org added a comment to D16366: Update security/suricata to 4.0.5.

I'm sorry, I'm playing by the rules that FreeBSD imposes on its external contributors.

Jul 23 2018, 2:34 PM
franco_opnsense.org added a comment to D16366: Update security/suricata to 4.0.5.

There's a PR here https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=229904

Jul 23 2018, 2:18 PM

Feb 13 2018

franco_opnsense.org added a comment to D9270: Add support for user-supplied Host-Uniq tag and handle PADM messages in Netgraph PPPoE.

Any news on this? :)

Feb 13 2018, 4:36 PM

Jan 31 2018

franco_opnsense.org added a comment to D13825: Rename php-xdebug to pecl-xdebug.

Seeing this after migration...

Jan 31 2018, 8:07 AM

Aug 29 2017

franco_opnsense.org accepted D9270: Add support for user-supplied Host-Uniq tag and handle PADM messages in Netgraph PPPoE.

this one is stable, thank you @ale

Aug 29 2017, 3:44 PM