Page MenuHomeFreeBSD

franco_opnsense.org (Franco Fichtner)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 15 2015, 5:39 PM (328 w, 6 h)

Recent Activity

Today

franco_opnsense.org accepted D32087: e1000: Re-arm link changes.

Thanks for the find! Looks reasonable to bring in. I will try to get more test coverage from our users, though feedback was low on this particular hang ;(

Mon, Sep 27, 7:35 AM

Wed, Sep 15

franco_opnsense.org added a comment to D31515: dhclient: support VID 0 (no vlan) decapsulation.

Added motivation for checking for untagged priority to the filter program comments.

Wed, Sep 15, 8:12 AM
franco_opnsense.org updated the diff for D31515: dhclient: support VID 0 (no vlan) decapsulation.

add comment about need to test for VID 0 presence

Wed, Sep 15, 8:07 AM

Tue, Sep 14

franco_opnsense.org added a comment to D31504: pf: always log nat rule and do it pre-rewrite.

Not sure about omitting the match on a NAT rule, but doing it inside the log code was definitely wrong.

Tue, Sep 14, 12:05 PM
franco_opnsense.org updated the diff for D31504: pf: always log nat rule and do it pre-rewrite.

void REASON_SET by directly passing PFRES_MATCH

Tue, Sep 14, 12:04 PM

Wed, Sep 8

franco_opnsense.org added a comment to D31504: pf: always log nat rule and do it pre-rewrite.

But to be fair both rules are matching accounting-wise unless we assume that only "pass" can account for "match".

Wed, Sep 8, 1:03 PM
franco_opnsense.org added inline comments to D31504: pf: always log nat rule and do it pre-rewrite.
Wed, Sep 8, 1:00 PM

Thu, Sep 2

franco_opnsense.org added a comment to D31515: dhclient: support VID 0 (no vlan) decapsulation.

There is an older discussion about it here https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=224961

Thu, Sep 2, 8:40 AM

Aug 19 2021

franco_opnsense.org added inline comments to D31515: dhclient: support VID 0 (no vlan) decapsulation.
Aug 19 2021, 7:22 PM
franco_opnsense.org updated the diff for D31515: dhclient: support VID 0 (no vlan) decapsulation.
  • skip to end on vlanid != 0 and add comments
Aug 19 2021, 7:18 PM

Aug 18 2021

franco_opnsense.org added a comment to D31527: dhclient: skip_to_semi() consumes semicolon already.

Correct. Here is the test:

Aug 18 2021, 9:09 PM
franco_opnsense.org updated the diff for D31527: dhclient: skip_to_semi() consumes semicolon already.
  • lease declaration skip fixes
Aug 18 2021, 9:05 PM
franco_opnsense.org added inline comments to D31515: dhclient: support VID 0 (no vlan) decapsulation.
Aug 18 2021, 8:22 PM
franco_opnsense.org updated the diff for D31515: dhclient: support VID 0 (no vlan) decapsulation.

Use EVL_VLID_MASK as suggested

Aug 18 2021, 8:21 PM
franco_opnsense.org added a comment to D31502: dhclient: remove the need to patch static values.

OpenBSD added the single htons() while adding write filter, but nowhere else. I suspect the fragmentation check is mostly correct so this doesn't matter in the real world.

Aug 18 2021, 7:59 PM
franco_opnsense.org updated the diff for D31502: dhclient: remove the need to patch static values.

constify filters and avoid static length variables

Aug 18 2021, 7:58 PM
franco_opnsense.org updated the summary of D31550: iflib: emulate counters in netmap mode.
Aug 18 2021, 7:16 AM
franco_opnsense.org added a comment to D31550: iflib: emulate counters in netmap mode.

Appreciate the reviews :) Unfortunately I'm not a committer so is someone willing to help out? Thanks in advance.

Aug 18 2021, 7:00 AM
franco_opnsense.org added reviewers for D31515: dhclient: support VID 0 (no vlan) decapsulation: kevans, markj.
Aug 18 2021, 6:55 AM
franco_opnsense.org updated the summary of D31503: dhclient: support supersede statement for option 54.
Aug 18 2021, 6:54 AM
franco_opnsense.org added reviewers for D31527: dhclient: skip_to_semi() consumes semicolon already: markj, kevans.
Aug 18 2021, 6:48 AM
franco_opnsense.org added reviewers for D31502: dhclient: remove the need to patch static values: kevans, markj.
Aug 18 2021, 6:41 AM

Aug 17 2021

franco_opnsense.org added inline comments to D31584: gre: simplify RSS ifdefs.
Aug 17 2021, 11:48 AM
franco_opnsense.org added inline comments to D31550: iflib: emulate counters in netmap mode.
Aug 17 2021, 11:44 AM
franco_opnsense.org updated the diff for D31550: iflib: emulate counters in netmap mode.

fixed partial length on tx

Aug 17 2021, 11:42 AM
franco_opnsense.org requested review of D31584: gre: simplify RSS ifdefs.
Aug 17 2021, 9:43 AM
franco_opnsense.org retitled D31583: netinet: simplify RSS ifdef statements from netinet: simplify the RSS if statement to netinet: simplify RSS ifdef statements.
Aug 17 2021, 9:24 AM
franco_opnsense.org updated the diff for D31583: netinet: simplify RSS ifdef statements.

Another one refactored

Aug 17 2021, 9:22 AM
franco_opnsense.org requested review of D31583: netinet: simplify RSS ifdef statements.
Aug 17 2021, 9:15 AM

Aug 16 2021

franco_opnsense.org added a reviewer for D31550: iflib: emulate counters in netmap mode: vmaffione.
Aug 16 2021, 7:59 AM
franco_opnsense.org requested review of D31550: iflib: emulate counters in netmap mode.
Aug 16 2021, 7:53 AM
franco_opnsense.org accepted D31501: e1000: always enable PCSD when RSS hashing is used.
Aug 16 2021, 6:41 AM

Aug 14 2021

franco_opnsense.org added a comment to D31518: rtsold: pass sending router address to other and managed script.

That would be great, thanks!

Aug 14 2021, 1:18 PM

Aug 13 2021

franco_opnsense.org added a comment to D31518: rtsold: pass sending router address to other and managed script.

The only other script is the DNS script and it looks like -u already does append the sender address to that script's data.

Aug 13 2021, 7:21 PM
franco_opnsense.org requested review of D31527: dhclient: skip_to_semi() consumes semicolon already.
Aug 13 2021, 11:13 AM
franco_opnsense.org added inline comments to D31518: rtsold: pass sending router address to other and managed script.
Aug 13 2021, 6:22 AM
franco_opnsense.org updated the diff for D31518: rtsold: pass sending router address to other and managed script.

now avoids raw access to ntopbuf from scripts call

Aug 13 2021, 6:18 AM

Aug 12 2021

franco_opnsense.org added inline comments to D31518: rtsold: pass sending router address to other and managed script.
Aug 12 2021, 6:48 PM
franco_opnsense.org added a reviewer for D31518: rtsold: pass sending router address to other and managed script: markj.
Aug 12 2021, 8:48 AM
franco_opnsense.org requested review of D31518: rtsold: pass sending router address to other and managed script.
Aug 12 2021, 8:48 AM
franco_opnsense.org added a reviewer for D31517: rtsold: auto-probe point to point interfaces: markj.
Aug 12 2021, 8:40 AM
franco_opnsense.org requested review of D31517: rtsold: auto-probe point to point interfaces.
Aug 12 2021, 8:39 AM
franco_opnsense.org requested review of D31515: dhclient: support VID 0 (no vlan) decapsulation.
Aug 12 2021, 8:14 AM
franco_opnsense.org retitled D31501: e1000: always enable PCSD when RSS hashing is used from e1000: do not check for multiqueue when setting non-RSS features to e1000: always enable PCSD when RSS hashing is used.
Aug 12 2021, 7:14 AM
franco_opnsense.org abandoned D31499: e1000: always enable PCSD when RSS hashing is used.

Merged into https://reviews.freebsd.org/D31501

Aug 12 2021, 7:08 AM
franco_opnsense.org accepted D31501: e1000: always enable PCSD when RSS hashing is used.

Much nicer, thanks! Added Stephan as reviewer who originally worked on this to give it a go.

Aug 12 2021, 7:05 AM
franco_opnsense.org added a reviewer for D31501: e1000: always enable PCSD when RSS hashing is used: stephan.dewt_yahoo.co.uk.
Aug 12 2021, 6:59 AM

Aug 11 2021

franco_opnsense.org updated the summary of D31499: e1000: always enable PCSD when RSS hashing is used.
Aug 11 2021, 9:10 AM
franco_opnsense.org added a reviewer for D31504: pf: always log nat rule and do it pre-rewrite: kp.
Aug 11 2021, 8:26 AM
franco_opnsense.org requested review of D31504: pf: always log nat rule and do it pre-rewrite.
Aug 11 2021, 8:24 AM
franco_opnsense.org requested review of D31503: dhclient: support supersede statement for option 54.
Aug 11 2021, 8:12 AM
franco_opnsense.org requested review of D31502: dhclient: remove the need to patch static values.
Aug 11 2021, 7:40 AM
franco_opnsense.org added a reviewer for D31501: e1000: always enable PCSD when RSS hashing is used: kbowling.
Aug 11 2021, 7:26 AM
franco_opnsense.org requested review of D31501: e1000: always enable PCSD when RSS hashing is used.
Aug 11 2021, 7:25 AM
franco_opnsense.org updated the summary of D31499: e1000: always enable PCSD when RSS hashing is used.
Aug 11 2021, 7:25 AM
franco_opnsense.org requested review of D31499: e1000: always enable PCSD when RSS hashing is used.
Aug 11 2021, 7:13 AM

Apr 23 2021

franco_opnsense.org added a comment to D29943: e1000: enable "other" interrupt on 82574.

On second thought: maybe I'm mixing up hardware. I'm not sure, but in either case 12.x does seem not exhibit this issue judging from the complete lack of user reports.

Apr 23 2021, 9:44 AM
franco_opnsense.org added a comment to D29943: e1000: enable "other" interrupt on 82574.

@kbowling for us https://cgit.freebsd.org/src/commit/?id=0aa7d3ff9ea resolved the issue back then and has not come back. Is this meant to replace it or to be applied on top? I can test it on the specific hardware, but unsure if this will be inconclusive for the mentioned reason

Apr 23 2021, 9:17 AM

Sep 10 2020

franco_opnsense.org accepted D26383: net/intel-em-kmod: Update to 7.7.8.

Thanks for the update :)

Sep 10 2020, 8:03 AM

Oct 24 2018

franco_opnsense.org accepted D17633: pf: Make ':0' ignore link-local v6 addresses too.
Oct 24 2018, 5:34 AM

Oct 22 2018

franco_opnsense.org accepted D17646: net/intel-{ix,em}-kmod: freeze PORTREVISION and PORTEPOCH.

@skozlov feel free to take maintainership of net/intel-em-kmod and thanks for working on these modules! :)

Oct 22 2018, 11:31 AM · Intel Networking

Oct 21 2018

franco_opnsense.org requested changes to D17633: pf: Make ':0' ignore link-local v6 addresses too.

"if:0" and "(if:0)" have separate implementations. the one for "if:0" is missing, see ifa_lookup() in sbin/pfctl/pfctl_parser.c

Oct 21 2018, 4:16 PM

Oct 12 2018

franco_opnsense.org accepted D17533: net/intel-ixl-kmod: Remove -Werror from CFLAGS.
Oct 12 2018, 2:41 PM · Intel Networking

Oct 7 2018

franco_opnsense.org accepted D17440: net/intel-em-kmod: Update to 7.7.4, enable netmap on 11.

Looks good, thanks!

Oct 7 2018, 1:07 PM · Intel Networking

Jul 23 2018

franco_opnsense.org accepted D16366: Update security/suricata to 4.0.5.

We all invest time so thank you for the offer. Yes, I am OK with that.

Jul 23 2018, 2:58 PM
franco_opnsense.org added a comment to D16366: Update security/suricata to 4.0.5.

I do not wish to acknowledge the advertising in the commit message.

Jul 23 2018, 2:47 PM
franco_opnsense.org added a comment to D16366: Update security/suricata to 4.0.5.

I'm sorry, I'm playing by the rules that FreeBSD imposes on its external contributors.

Jul 23 2018, 2:34 PM
franco_opnsense.org added a comment to D16366: Update security/suricata to 4.0.5.

There's a PR here https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=229904

Jul 23 2018, 2:18 PM

Feb 13 2018

franco_opnsense.org added a comment to D9270: Add support for user-supplied Host-Uniq tag and handle PADM messages in Netgraph PPPoE.

Any news on this? :)

Feb 13 2018, 4:36 PM

Jan 31 2018

franco_opnsense.org added a comment to D13825: Rename php-xdebug to pecl-xdebug.

Seeing this after migration...

Jan 31 2018, 8:07 AM

Aug 29 2017

franco_opnsense.org accepted D9270: Add support for user-supplied Host-Uniq tag and handle PADM messages in Netgraph PPPoE.

this one is stable, thank you @ale

Aug 29 2017, 3:44 PM

Aug 22 2017

franco_opnsense.org added a comment to D9270: Add support for user-supplied Host-Uniq tag and handle PADM messages in Netgraph PPPoE.

No, I'm not asking for support that would take a few weeks of ping pong in a bug tracker, if any. This is real world feedback for this review. Take it or leave it. :)

Aug 22 2017, 8:18 AM
franco_opnsense.org added a comment to D9270: Add support for user-supplied Host-Uniq tag and handle PADM messages in Netgraph PPPoE.

Thanks, but we've narrowed it down to this commit.

Aug 22 2017, 8:09 AM
franco_opnsense.org added a comment to D9270: Add support for user-supplied Host-Uniq tag and handle PADM messages in Netgraph PPPoE.

We do seem to have a persistent problem with this patch in some PPPoE environments that will cause a crash in ng_pppoe_rcvdata_ether():

Aug 22 2017, 4:39 AM

Jul 13 2017

franco_opnsense.org accepted D11139: security/suricata: Add REDIS option.

Nevermind, now it displays correctly. Please commit. :)

Jul 13 2017, 3:44 PM
franco_opnsense.org added a comment to D11139: security/suricata: Add REDIS option.

can you rebase this patch? it looks off with the update to 3.2.2 and no OPTIONS_DEFINE like it was already applied

Jul 13 2017, 3:43 PM

Jun 16 2017

franco_opnsense.org added a comment to D11139: security/suricata: Add REDIS option.

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=220025
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=220026

Jun 16 2017, 5:09 AM
franco_opnsense.org added a comment to D11139: security/suricata: Add REDIS option.

So FWIW I stand by the approval of the previous version that does not use REDIS_CONFIGURE_ENABLE.

Jun 16 2017, 4:50 AM

Jun 14 2017

franco_opnsense.org added inline comments to D11139: security/suricata: Add REDIS option.
Jun 14 2017, 4:49 AM

Jun 13 2017

franco_opnsense.org requested changes to D11139: security/suricata: Add REDIS option.
Jun 13 2017, 10:01 AM

Jun 12 2017

franco_opnsense.org added inline comments to D11139: security/suricata: Add REDIS option.
Jun 12 2017, 12:27 PM
franco_opnsense.org added inline comments to D11139: security/suricata: Add REDIS option.
Jun 12 2017, 12:01 PM
franco_opnsense.org accepted D11139: security/suricata: Add REDIS option.
Jun 12 2017, 4:36 AM

Jun 11 2017

franco_opnsense.org added a comment to D11139: security/suricata: Add REDIS option.

looks good, will accept after typo fix :)

Jun 11 2017, 8:42 AM

Apr 9 2017

franco_opnsense.org added inline comments to D10327: Implement basic flavors.
Apr 9 2017, 4:07 PM
franco_opnsense.org added inline comments to D10327: Implement basic flavors.
Apr 9 2017, 3:52 PM
franco_opnsense.org added inline comments to D10327: Implement basic flavors.
Apr 9 2017, 3:36 PM
franco_opnsense.org added inline comments to D10327: Implement basic flavors.
Apr 9 2017, 3:25 PM
franco_opnsense.org added inline comments to D10327: Implement basic flavors.
Apr 9 2017, 3:16 PM

Jan 2 2017

franco_opnsense.org added a reviewer for D8299: Convert igb(4), em(4) and lem(4) to iflib: franco_opnsense.org.
Jan 2 2017, 4:30 PM

Dec 26 2016

franco_opnsense.org updated the diff for D8877: netinet[6]: KPI for opaque fwd_tag handling for PFIL consumers.
  • correctly build against GENERIC
Dec 26 2016, 10:21 AM

Dec 22 2016

franco_opnsense.org added a comment to D8813: OpenVPN 2.4 preview.

I've updated the TUNNELBLICK patch to work with 2.4, it was just a clash with the new code formatting. Looks good so far, runtime test is pending.

Dec 22 2016, 7:39 AM

Dec 21 2016

franco_opnsense.org added inline comments to D8877: netinet[6]: KPI for opaque fwd_tag handling for PFIL consumers.
Dec 21 2016, 2:41 PM
franco_opnsense.org updated the diff for D8877: netinet[6]: KPI for opaque fwd_tag handling for PFIL consumers.
  • omit empty reads for ip[6]_get_fwdtag
  • error out safely on failure
Dec 21 2016, 2:39 PM
franco_opnsense.org added inline comments to D8877: netinet[6]: KPI for opaque fwd_tag handling for PFIL consumers.
Dec 21 2016, 2:05 PM
franco_opnsense.org updated the diff for D8877: netinet[6]: KPI for opaque fwd_tag handling for PFIL consumers.
  • use else if
Dec 21 2016, 1:58 PM
franco_opnsense.org added inline comments to D8877: netinet[6]: KPI for opaque fwd_tag handling for PFIL consumers.
Dec 21 2016, 1:54 PM
franco_opnsense.org updated the diff for D8877: netinet[6]: KPI for opaque fwd_tag handling for PFIL consumers.
  • complete conversion
Dec 21 2016, 1:47 PM
franco_opnsense.org updated the diff for D8877: netinet[6]: KPI for opaque fwd_tag handling for PFIL consumers.
  • requested changes
Dec 21 2016, 12:06 PM
franco_opnsense.org added a reviewer for D8877: netinet[6]: KPI for opaque fwd_tag handling for PFIL consumers: ae.
Dec 21 2016, 8:34 AM