Page MenuHomeFreeBSD

franco_opnsense.org (Franco Fichtner)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 15 2015, 5:39 PM (415 w, 6 d)

Recent Activity

Apr 20 2023

franco_opnsense.org added a comment to D39689: if: store original ifname.

Yes, 1:1 alias name assignment would be desirable and sidestep constraints with interface name length for descriptive interfaces (QinQ is too much actually) as well as avoid renaming interfaces when a VLAN ID changes for example. Just change alias and done (possibly with more character support).

Apr 20 2023, 9:39 AM
franco_opnsense.org added a comment to D39689: if: store original ifname.

Sure. The only thing actually used in if_mib in base is exactly this IFDATA_DRIVERNAME functionality. It is undocumented (and wrong for tunap/epair/soem other devices). I'm going to deprecate the module by providing this missing piece of functionality via Netlink ( D39659 ).

Apr 20 2023, 9:33 AM
franco_opnsense.org added a comment to D39689: if: store original ifname.

I wonder why adding a new field is needed when IFDATA_DRIVERNAME via if_dname/if_dunit exists? It's also exposed via libifconfig but sadly not via ifconfig command. I only noticed recently by looking at ifinfo command which we use in OPNsense because it provides better interface overview than ifconfig, but is not built in the base system.

Apr 20 2023, 6:48 AM

Apr 5 2023

franco_opnsense.org added a comment to D39426: netmap: Handle packet batches in generic mode.

Could this be the same as https://reviews.freebsd.org/D38065#875109 eventually resulting in:

Apr 5 2023, 7:57 PM

Mar 29 2023

franco_opnsense.org added a comment to D39015: tuntap: Add netmap support for both tap(4) and tun(4) interfaces.

The use case: a number of VPN software solutions like OpenVPN use this driver so the idea was to be able to grab traffic off of the interface before encryption/after decryption. It looks like tun may not be worth the effort, but it could work for tap mode without further constraints?

Mar 29 2023, 6:09 AM

Feb 9 2023

franco_opnsense.org added a comment to D38065: netmap: Fix queue stalls on generic interfaces.

Can I ask what kind of tests you performed? I guess you have set sysctl dev.netmap.admode=2 (see netmap(4)) and tried on a vtnet0 interface.
If not done yet, could you please perform some tests on an em0 interface (e.g. emulated by qemu or bhyve)?

Feb 9 2023, 7:15 AM

Jan 19 2023

franco_opnsense.org added a comment to D38066: bridge: Add support for emulated netmap mode.

For this to make sense from the user perspective attaching to a bridge should capture all packets associated with the bridge as e.g. seen by bpf (although here for now bpf might be circumvented). The reason for that is we don't want to modify user programs and restart and instead simply reconfigure bridge device akin to how lagg netmap works now.

Jan 19 2023, 8:39 AM

Dec 14 2022

franco_opnsense.org added a comment to D36259: rc: also run NAME_setup on NAME_reload.

@oshogbo I've updated the documentation and also described the caveats with the current implementation of restart_precmd which is pretty dangerous when not using restart_cmd ... but running the setup there prior to running it again during start seems silly just to pass a potential failure of restart_precmd. A number of ports seem to be using this override but a "proper" config file should be present if we assume that start was ran successfully first?

Dec 14 2022, 10:47 AM · rc
franco_opnsense.org updated the diff for D36259: rc: also run NAME_setup on NAME_reload.
  • update documentation on internals and caveats
Dec 14 2022, 10:40 AM · rc

Oct 18 2022

franco_opnsense.org updated the diff for D36259: rc: also run NAME_setup on NAME_reload.

merge issue

Oct 18 2022, 11:43 AM · rc
franco_opnsense.org updated the diff for D36259: rc: also run NAME_setup on NAME_reload.

change setup/precmd order so when precmd checks config file it won't fail

Oct 18 2022, 11:35 AM · rc

Oct 10 2022

franco_opnsense.org added a comment to D34449: Allow em(4) to particpate in auto-negotiation for fixed 100b or 10b configuration.

I don't have any intention to debug this as I don't have a setup at hand that causes this. It should, however, be considered to revert the commit before 13.2 or 14.0 is released with it for the sole purpose of fixing a theoretical issue vs. breaking existing setups.

Oct 10 2022, 8:05 AM

Oct 5 2022

franco_opnsense.org added a comment to D34449: Allow em(4) to particpate in auto-negotiation for fixed 100b or 10b configuration.

From what we can tell if the other end prohibits auto-negotiation forcing a particular media setting the NIC ends up in "no carrier" status with this patch, see https://www.reddit.com/r/opnsense/comments/xw4oiz/comment/ir4mxb0/?utm_source=reddit&utm_medium=web2x&context=3 and https://forum.opnsense.org/index.php?topic=30274

Oct 5 2022, 10:03 AM

Sep 1 2022

franco_opnsense.org updated the diff for D36259: rc: also run NAME_setup on NAME_reload.

rc: extend NAME_setup, redefining commands escapes all structure

Sep 1 2022, 6:40 AM · rc

Aug 19 2022

franco_opnsense.org added reviewers for D36259: rc: also run NAME_setup on NAME_reload: oshogbo, 0mp.
Aug 19 2022, 6:25 AM · rc
franco_opnsense.org requested review of D36259: rc: also run NAME_setup on NAME_reload.
Aug 19 2022, 6:24 AM · rc

Aug 17 2022

franco_opnsense.org added a comment to D36210: rc: add a manual entry for ${name}_setup.

I reverted the change in question although I don't agree with the rationale. NAME_prepend remains a fragile construct, not being used in visible code in ports/src and prepending command(s) would imply that either ";" or "&&" is being used by default to separate the argument, which the user will not know because the documentation is not complete or the concept involved is not well-designed.

Aug 17 2022, 2:09 PM · rc
franco_opnsense.org updated the diff for D36210: rc: add a manual entry for ${name}_setup.
  • revert prepend wording
Aug 17 2022, 2:06 PM · rc

Aug 16 2022

franco_opnsense.org added a reviewer for D36210: rc: add a manual entry for ${name}_setup: oshogbo.
Aug 16 2022, 8:11 AM · rc
franco_opnsense.org closed D36006: rc: add ${name}_setup script support.
Aug 16 2022, 8:10 AM · rc
franco_opnsense.org requested review of D36210: rc: add a manual entry for ${name}_setup.
Aug 16 2022, 8:10 AM · rc

Aug 8 2022

franco_opnsense.org added a comment to D35429: pf: stop resolving hosts as dns that use ":" modifier.

Updated revision to address requirement to only skip known modifiers. Minimal code change, but more convoluted with the cont pointer being passed down additionally.

Aug 8 2022, 10:10 AM
franco_opnsense.org updated the diff for D35429: pf: stop resolving hosts as dns that use ":" modifier.
  • Revert "pf: stop resolving hosts as dns that use ":" modifier"
  • pfctl: stop resolving hosts as DNS that use internal ":" modifiers
Aug 8 2022, 10:06 AM

Aug 5 2022

franco_opnsense.org requested review of D36050: pfctl: fix FOM_ICMP/POM_STICKYADDRESS clash.
Aug 5 2022, 11:41 AM

Aug 2 2022

franco_opnsense.org added a comment to D36006: rc: add ${name}_setup script support.

@oshogbo I don't have the means to commit so if you would pick that up when you have some time that'd be highly appreciated

Aug 2 2022, 6:43 AM · rc

Aug 1 2022

franco_opnsense.org added a reviewer for D36006: rc: add ${name}_setup script support: oshogbo.
Aug 1 2022, 9:38 AM · rc
franco_opnsense.org requested review of D36006: rc: add ${name}_setup script support.
Aug 1 2022, 9:36 AM · rc

Jun 10 2022

franco_opnsense.org abandoned D35430: netinet6: prevent a crash on empty ifp.

D35117 looks reasonable, let me abandon this then :)

Jun 10 2022, 9:06 AM
franco_opnsense.org added a comment to D35430: netinet6: prevent a crash on empty ifp.

I don't have a crash core and this only happened once on a customer device in FreeBSD 12.

Jun 10 2022, 7:49 AM

Jun 8 2022

franco_opnsense.org added a comment to D35429: pf: stop resolving hosts as dns that use ":" modifier.

Something like "ovpnc0:network" is hardly a domain name as one user noted seeing these pop up and chasing it to lookups in pfctl. host_if() implements these special markers and we could argue that pfctl-specific markers have priority and shouldn't be handled elsewhere.

Jun 8 2022, 4:34 PM
franco_opnsense.org added a comment to D34393: debugnet: remove spurious message on boot.

Since I don't have a commit bit... anyone willing to commit this? Thanks in advance.

Jun 8 2022, 12:42 PM
franco_opnsense.org updated the summary of D35430: netinet6: prevent a crash on empty ifp.
Jun 8 2022, 12:08 PM
franco_opnsense.org requested review of D35430: netinet6: prevent a crash on empty ifp.
Jun 8 2022, 12:03 PM
franco_opnsense.org requested review of D35429: pf: stop resolving hosts as dns that use ":" modifier.
Jun 8 2022, 7:14 AM

Jun 2 2022

franco_opnsense.org updated the test plan for D35385: pf: still one leak in here so switch all to M_NVLIST.
Jun 2 2022, 12:58 PM
franco_opnsense.org requested review of D35385: pf: still one leak in here so switch all to M_NVLIST.
Jun 2 2022, 12:54 PM

May 12 2022

franco_opnsense.org accepted D35178: Add end to end tests for dhclient.

LGTM, thanks!

May 12 2022, 6:26 AM

Feb 28 2022

franco_opnsense.org updated the diff for D34393: debugnet: remove spurious message on boot.

update as mentioned

Feb 28 2022, 6:32 PM
franco_opnsense.org abandoned D34397: debugnet: remove spurious message on boot.

created new review instead of update

Feb 28 2022, 6:31 PM
franco_opnsense.org requested review of D34397: debugnet: remove spurious message on boot.
Feb 28 2022, 6:30 PM
franco_opnsense.org updated the summary of D34393: debugnet: remove spurious message on boot.
Feb 28 2022, 11:34 AM
franco_opnsense.org added a reviewer for D34393: debugnet: remove spurious message on boot: cem.
Feb 28 2022, 11:33 AM
franco_opnsense.org requested review of D34393: debugnet: remove spurious message on boot.
Feb 28 2022, 11:33 AM

Feb 21 2022

franco_opnsense.org added inline comments to D34329: stand: add EFI support for mmio serial consoles.
Feb 21 2022, 4:49 PM
franco_opnsense.org added inline comments to D34329: stand: add EFI support for mmio serial consoles.
Feb 21 2022, 3:59 PM
franco_opnsense.org added a reviewer for D34329: stand: add EFI support for mmio serial consoles: imp.
Feb 21 2022, 2:02 PM
franco_opnsense.org requested review of D34329: stand: add EFI support for mmio serial consoles.
Feb 21 2022, 2:01 PM

Feb 14 2022

franco_opnsense.org added a comment to D31515: dhclient: support VID 0 (no vlan) decapsulation.

thanks a lot :)

Feb 14 2022, 7:21 PM
franco_opnsense.org added a comment to D31515: dhclient: support VID 0 (no vlan) decapsulation.

Sorry for the delay. I have no objections to the change and the implementation looks fine. I am a little wary of committing it without some wider approval: could I ask you to post a short note to freebsd-net@ linking this diff and soliciting opinions? If there are no objections after a week or so I will commit this.

Feb 14 2022, 11:16 AM
franco_opnsense.org added a reviewer for D34266: pf: fix set_prio after nv conversion: kp.
Feb 14 2022, 8:33 AM
franco_opnsense.org requested review of D34266: pf: fix set_prio after nv conversion.
Feb 14 2022, 8:32 AM

Jan 31 2022

franco_opnsense.org added a comment to D29075: Hyper-V: hn: Enable vSwitch RSC support in hn netvsc driver.

We have multiple reports that this causes throughput regressions when in use on 13-STABLE as opposed to 13.0-RELEASE where it is not present. We have had this commit reverted and speeds are back to normal for our OPNsense users. For more info see https://forum.opnsense.org/index.php?topic=26364.0

Jan 31 2022, 6:44 AM

Jan 27 2022

franco_opnsense.org abandoned D33432: dummynet: remove locks causing panics during callout.
Jan 27 2022, 11:13 AM
franco_opnsense.org added a comment to D34053: dummynet: use atomics to maintain pie_desc.ref_count.

fqpie_callout_cleanup() should exhibit the same issue

Jan 27 2022, 9:45 AM

Jan 4 2022

franco_opnsense.org added a comment to D33432: dummynet: remove locks causing panics during callout.
In D33432#755856, @kp wrote:

I was thinking the same at first but the locking introduced in https://cgit.freebsd.org/src/commit/sys/netpfil/ipfw/dn_aqm_pie.c?id=12be18c7d594 looks arbitrary and isn't anywhere else in those two files. It was added to "protect" the ref_count manipulation, but if you look at the other ref_count modification in that file these are also done without (obvious) locks.

Maybe these ref_count modifications should receive atomic updates without locks to avoid the locking overhead completely?

Perhaps, yes.

Although it looks like the ref_count is only read in unload_dn_aqm(), under the sched_mtx lock. That lock lives only in ip_dummynet.c, so I wonder if we shouldn't just move the updating of the reference count to dn_aqm_ref()/dn_aqm_unref() and protect it with the sched_mtx lock. That doesn't need vnet, so we don't have to worry about setting the context (because it's about a global setting, so using a vnet-ed lock is wrong anyway) and we actually clean the locking up a little.

Jan 4 2022, 9:23 AM

Dec 14 2021

franco_opnsense.org added a comment to D33432: dummynet: remove locks causing panics during callout.

I was thinking the same at first but the locking introduced in https://cgit.freebsd.org/src/commit/sys/netpfil/ipfw/dn_aqm_pie.c?id=12be18c7d594 looks arbitrary and isn't anywhere else in those two files. It was added to "protect" the ref_count manipulation, but if you look at the other ref_count modification in that file these are also done without (obvious) locks.

Dec 14 2021, 1:09 PM
franco_opnsense.org added a comment to D33432: dummynet: remove locks causing panics during callout.
In D33432#755816, @kp wrote:

Do you have a description on how to trigger this panic?

Dec 14 2021, 10:21 AM
franco_opnsense.org added a reviewer for D33429: dummynet: drop unused definitions: kp.
Dec 14 2021, 9:39 AM
franco_opnsense.org added a reviewer for D33432: dummynet: remove locks causing panics during callout: kp.
Dec 14 2021, 9:38 AM
franco_opnsense.org requested review of D33432: dummynet: remove locks causing panics during callout.
Dec 14 2021, 9:37 AM
franco_opnsense.org requested review of D33429: dummynet: drop unused definitions.
Dec 14 2021, 8:06 AM

Dec 10 2021

franco_opnsense.org added a comment to D8877: netinet[6]: KPI for opaque fwd_tag handling for PFIL consumers.
In D8877#754326, @mjg wrote:

what's the fate of this patch?

Dec 10 2021, 7:36 AM

Nov 18 2021

franco_opnsense.org added a comment to D33020: Remove "options PCBGROUP".

Just as a comment: With all these ties to RSS defines I'm not sure where that leaves the RSS feature with regard to its multiple hardware/software use cases but there's no point in blocking this with no visible consumers. I'll make sure to give this a test once it hits main.

Nov 18 2021, 6:47 AM
franco_opnsense.org accepted D33019: Allow to compile RSS without PCBGROUP..
Nov 18 2021, 6:36 AM

Oct 28 2021

franco_opnsense.org added a comment to D32585: SMR protection for inpcbs.
In D32585#737015, @np wrote:

Note. This change requires PCBGROUP to be retired.

Have you circulated this proposal in the wider -net and -vendor community? I know of one downstream that uses this feature.

It looks like opnsense is trying to make use of pcbgroups/rss, might want to check with @franco_opnsense.org

I don't see much history here https://github.com/opnsense/src/commits/master/sys/netinet/in_pcbgroup.c
Anyway, adding Franco as reviewer.

Oct 28 2021, 9:20 AM

Sep 27 2021

franco_opnsense.org accepted D32087: e1000: Re-arm link changes.

Thanks for the find! Looks reasonable to bring in. I will try to get more test coverage from our users, though feedback was low on this particular hang ;(

Sep 27 2021, 7:35 AM

Sep 15 2021

franco_opnsense.org added a comment to D31515: dhclient: support VID 0 (no vlan) decapsulation.

Added motivation for checking for untagged priority to the filter program comments.

Sep 15 2021, 8:12 AM
franco_opnsense.org updated the diff for D31515: dhclient: support VID 0 (no vlan) decapsulation.

add comment about need to test for VID 0 presence

Sep 15 2021, 8:07 AM

Sep 14 2021

franco_opnsense.org added a comment to D31504: pf: always log nat rule and do it pre-rewrite.

Not sure about omitting the match on a NAT rule, but doing it inside the log code was definitely wrong.

Sep 14 2021, 12:05 PM
franco_opnsense.org updated the diff for D31504: pf: always log nat rule and do it pre-rewrite.

void REASON_SET by directly passing PFRES_MATCH

Sep 14 2021, 12:04 PM

Sep 8 2021

franco_opnsense.org added a comment to D31504: pf: always log nat rule and do it pre-rewrite.

But to be fair both rules are matching accounting-wise unless we assume that only "pass" can account for "match".

Sep 8 2021, 1:03 PM
franco_opnsense.org added inline comments to D31504: pf: always log nat rule and do it pre-rewrite.
Sep 8 2021, 1:00 PM

Sep 2 2021

franco_opnsense.org added a comment to D31515: dhclient: support VID 0 (no vlan) decapsulation.

There is an older discussion about it here https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=224961

Sep 2 2021, 8:40 AM

Aug 19 2021

franco_opnsense.org added inline comments to D31515: dhclient: support VID 0 (no vlan) decapsulation.
Aug 19 2021, 7:22 PM
franco_opnsense.org updated the diff for D31515: dhclient: support VID 0 (no vlan) decapsulation.
  • skip to end on vlanid != 0 and add comments
Aug 19 2021, 7:18 PM

Aug 18 2021

franco_opnsense.org added a comment to D31527: dhclient: skip_to_semi() consumes semicolon already.

Correct. Here is the test:

Aug 18 2021, 9:09 PM
franco_opnsense.org updated the diff for D31527: dhclient: skip_to_semi() consumes semicolon already.
  • lease declaration skip fixes
Aug 18 2021, 9:05 PM
franco_opnsense.org added inline comments to D31515: dhclient: support VID 0 (no vlan) decapsulation.
Aug 18 2021, 8:22 PM
franco_opnsense.org updated the diff for D31515: dhclient: support VID 0 (no vlan) decapsulation.

Use EVL_VLID_MASK as suggested

Aug 18 2021, 8:21 PM
franco_opnsense.org added a comment to D31502: dhclient: remove the need to patch static values.

OpenBSD added the single htons() while adding write filter, but nowhere else. I suspect the fragmentation check is mostly correct so this doesn't matter in the real world.

Aug 18 2021, 7:59 PM
franco_opnsense.org updated the diff for D31502: dhclient: remove the need to patch static values.

constify filters and avoid static length variables

Aug 18 2021, 7:58 PM
franco_opnsense.org updated the summary of D31550: iflib: emulate counters in netmap mode.
Aug 18 2021, 7:16 AM
franco_opnsense.org added a comment to D31550: iflib: emulate counters in netmap mode.

Appreciate the reviews :) Unfortunately I'm not a committer so is someone willing to help out? Thanks in advance.

Aug 18 2021, 7:00 AM
franco_opnsense.org added reviewers for D31515: dhclient: support VID 0 (no vlan) decapsulation: kevans, markj.
Aug 18 2021, 6:55 AM
franco_opnsense.org updated the summary of D31503: dhclient: support supersede statement for option 54.
Aug 18 2021, 6:54 AM
franco_opnsense.org added reviewers for D31527: dhclient: skip_to_semi() consumes semicolon already: markj, kevans.
Aug 18 2021, 6:48 AM
franco_opnsense.org added reviewers for D31502: dhclient: remove the need to patch static values: kevans, markj.
Aug 18 2021, 6:41 AM

Aug 17 2021

franco_opnsense.org added inline comments to D31584: gre: simplify RSS ifdefs.
Aug 17 2021, 11:48 AM
franco_opnsense.org added inline comments to D31550: iflib: emulate counters in netmap mode.
Aug 17 2021, 11:44 AM
franco_opnsense.org updated the diff for D31550: iflib: emulate counters in netmap mode.

fixed partial length on tx

Aug 17 2021, 11:42 AM
franco_opnsense.org requested review of D31584: gre: simplify RSS ifdefs.
Aug 17 2021, 9:43 AM
franco_opnsense.org retitled D31583: netinet: simplify RSS ifdef statements from netinet: simplify the RSS if statement to netinet: simplify RSS ifdef statements.
Aug 17 2021, 9:24 AM
franco_opnsense.org updated the diff for D31583: netinet: simplify RSS ifdef statements.

Another one refactored

Aug 17 2021, 9:22 AM
franco_opnsense.org requested review of D31583: netinet: simplify RSS ifdef statements.
Aug 17 2021, 9:15 AM

Aug 16 2021

franco_opnsense.org added a reviewer for D31550: iflib: emulate counters in netmap mode: vmaffione.
Aug 16 2021, 7:59 AM
franco_opnsense.org requested review of D31550: iflib: emulate counters in netmap mode.
Aug 16 2021, 7:53 AM
franco_opnsense.org accepted D31501: e1000: always enable PCSD when RSS hashing is used.
Aug 16 2021, 6:41 AM

Aug 14 2021

franco_opnsense.org added a comment to D31518: rtsold: pass sending router address to other and managed script.

That would be great, thanks!

Aug 14 2021, 1:18 PM

Aug 13 2021

franco_opnsense.org added a comment to D31518: rtsold: pass sending router address to other and managed script.

The only other script is the DNS script and it looks like -u already does append the sender address to that script's data.

Aug 13 2021, 7:21 PM
franco_opnsense.org requested review of D31527: dhclient: skip_to_semi() consumes semicolon already.
Aug 13 2021, 11:13 AM