Page MenuHomeFreeBSD

kp (Kristof Provost)
Troubleshooter

Projects

User Details

User Since
Sep 28 2014, 7:22 PM (336 w, 8 h)

Recent Activity

Sat, Mar 6

kp closed D29078: pf tests: Test tos/dscp matching.
Sat, Mar 6, 10:21 AM
kp committed R10:9d3b2bcf7610: pf tests: Test tos/dscp matching (authored by kp).
pf tests: Test tos/dscp matching
Sat, Mar 6, 10:20 AM
kp closed D29069: pfctl: Add missing 'va' code point name.
Sat, Mar 6, 10:20 AM
kp committed R10:b4e3f3c2de6e: pfctl: Add missing 'va' code point name (authored by kp).
pfctl: Add missing 'va' code point name
Sat, Mar 6, 10:20 AM

Fri, Mar 5

kp updated the diff for D29069: pfctl: Add missing 'va' code point name.

Reduce patch to only add the missing voice-admit code point.

Fri, Mar 5, 1:43 PM
kp requested review of D29078: pf tests: Test tos/dscp matching.
Fri, Mar 5, 12:29 PM
kp added a comment to D29069: pfctl: Add missing 'va' code point name.

Given the issues I would rather NOT add dscp support at all, until these issues can be addressed from down/upstream? The current situation, both in pfsense and freebsd is poor at best and may actually be one of the sources of issues we are seeing in our ECN data collection work. We know for a fact people are being told to use these ancient and obsolete TOS values by looking for them in blog posts and how-to's. Using the pry bar that is "reduce diffs between" as a reason to add a bad situation is an ever worse situation!

Fri, Mar 5, 11:36 AM
kp added a comment to D29069: pfctl: Add missing 'va' code point name.

I suggest to rework the parser in such a way, that the named DSCP codepoints can only be used with the DSCP keyword, and the legacy TOS values only with the keyword TOS. And the parser can deal with the necessary left-shift (the DSCP input value should be 0..63).

Fri, Mar 5, 10:23 AM
kp added a comment to D29069: pfctl: Add missing 'va' code point name.

I have a concern here, some of which goes beyond just this change, about aliasing DSCP to TOS. We (a small congestion control research group) have found that due to ambigious manual pages, headers and other factors, some present in PF it appears are causing mismarked traffic on the internet. DSCP is shifted left by the 2 ECN bits, the manual pages and any other documentation MUST be made explicity clear about this fact as to if your supplying the values as specified in the RFC"s on DSCP (unshifted) or are you applying TOS bits that may or may not have the ECN bits masked out.

Fri, Mar 5, 9:08 AM
kp committed R10:29698ed90473: pf: Mark struct pf_pdesc as kernel only (authored by kp).
pf: Mark struct pf_pdesc as kernel only
Fri, Mar 5, 8:22 AM

Thu, Mar 4

kp requested review of D29069: pfctl: Add missing 'va' code point name.
Thu, Mar 4, 8:04 PM
kp committed R10:448732b8e2d9: altq: Increase maximum number of CBQ and HFSC classes (authored by kp).
altq: Increase maximum number of CBQ and HFSC classes
Thu, Mar 4, 7:59 PM
kp closed D29034: altq: Increase maximum number of CBQ and HFSC classes.
Thu, Mar 4, 7:59 PM
kp closed D29048: pf: Retrieve DSCP value from the IPv6 header.
Thu, Mar 4, 7:58 PM
kp committed R10:bb4a7d94b99f: net: Introduce IPV6_DSCP(), IPV6_ECN() and IPV6_TRAFFIC_CLASS() macros (authored by kp).
net: Introduce IPV6_DSCP(), IPV6_ECN() and IPV6_TRAFFIC_CLASS() macros
Thu, Mar 4, 7:57 PM
kp committed R10:f19323847ca8: pf: Retrieve DSCP value from the IPv6 header (authored by kp).
pf: Retrieve DSCP value from the IPv6 header
Thu, Mar 4, 7:57 PM
kp closed D29056: net: Introduce IPV6_DSCP(), IPV6_ECN() and IPV6_TRAFFIC_CLASS() macros.
Thu, Mar 4, 7:57 PM
kp accepted D29064: riscv: fix errors in some atomic type aliases.

Seems like a fairly obvious thing to fix, yes.

Thu, Mar 4, 7:23 PM
kp added a comment to D29056: net: Introduce IPV6_DSCP(), IPV6_ECN() and IPV6_TRAFFIC_CLASS() macros.

perhaps replace those with
iptos = IPV6_DSCP(ip6) | IPV6_ECN(ipv6);
in this patch too?

Thu, Mar 4, 1:21 PM
kp updated the diff for D29056: net: Introduce IPV6_DSCP(), IPV6_ECN() and IPV6_TRAFFIC_CLASS() macros.
Thu, Mar 4, 1:19 PM
kp retitled D29056: net: Introduce IPV6_DSCP(), IPV6_ECN() and IPV6_TRAFFIC_CLASS() macros from net: Introduce IPV6_DSCP() and IPV6_ECN() macros to net: Introduce IPV6_DSCP(), IPV6_ECN() and IPV6_TRAFFIC_CLASS() macros.
Thu, Mar 4, 1:18 PM
kp requested review of D29056: net: Introduce IPV6_DSCP(), IPV6_ECN() and IPV6_TRAFFIC_CLASS() macros.
Thu, Mar 4, 12:33 PM
kp updated the diff for D29048: pf: Retrieve DSCP value from the IPv6 header.

Simplify retrieving the DSCP bits

Thu, Mar 4, 10:01 AM
kp committed R10:9c744d299243: bridge tests: Test that we also forward on some interfaces (authored by kp).
bridge tests: Test that we also forward on some interfaces
Thu, Mar 4, 9:34 AM
kp committed R10:772b39d6309b: bridgestp: Ensure we send STP on VLAN interfaces (authored by kp).
bridgestp: Ensure we send STP on VLAN interfaces
Thu, Mar 4, 9:34 AM
kp committed R10:eb4221b9fb91: bridge tests: Test that we also forward on some interfaces (authored by kp).
bridge tests: Test that we also forward on some interfaces
Thu, Mar 4, 9:34 AM
kp committed R10:e7705585fed8: bridgestp: Ensure we send STP on VLAN interfaces (authored by kp).
bridgestp: Ensure we send STP on VLAN interfaces
Thu, Mar 4, 9:34 AM
kp added inline comments to D29048: pf: Retrieve DSCP value from the IPv6 header.
Thu, Mar 4, 8:52 AM

Wed, Mar 3

kp requested review of D29048: pf: Retrieve DSCP value from the IPv6 header.
Wed, Mar 3, 8:41 PM
kp added a comment to D29034: altq: Increase maximum number of CBQ and HFSC classes.

How common is this requirement?

Wed, Mar 3, 1:55 PM
kp accepted D29030: sbin/ifconfig: Get media status with libifconfig.
Wed, Mar 3, 1:27 PM
kp accepted D29029: libifconfig: Overhaul ifconfig_media_* interfaces.
Wed, Mar 3, 12:34 PM
kp requested review of D29034: altq: Increase maximum number of CBQ and HFSC classes.
Wed, Mar 3, 11:07 AM
kp accepted D29022: sbin/ifconfig: Minor housekeeping.
Wed, Mar 3, 9:27 AM

Tue, Mar 2

kp committed R10:81d747ace024: bridge tests: Test STP on top of VLAN devices (authored by kp).
bridge tests: Test STP on top of VLAN devices
Tue, Mar 2, 3:20 PM
kp committed R10:fd5828b62bdb: bridge tests: Avoid building a switching loop (authored by kp).
bridge tests: Avoid building a switching loop
Tue, Mar 2, 3:20 PM
kp committed R10:1b73cd3d0a7c: bridge tests: Test for #216510 (authored by kp).
bridge tests: Test for #216510
Tue, Mar 2, 3:19 PM
kp committed R10:e11329536494: bridge tests: Ensure that bridges in different jails get different MAC addresses (authored by kp).
bridge tests: Ensure that bridges in different jails get different MAC addresses
Tue, Mar 2, 3:19 PM
kp committed R10:e180cc2fb9c5: bridge tests: Test deleting a bridge with members (authored by kp).
bridge tests: Test deleting a bridge with members
Tue, Mar 2, 3:19 PM
kp committed R10:c4bf12b43711: bridge tests: Basic span test (authored by kp).
bridge tests: Basic span test
Tue, Mar 2, 3:19 PM
kp committed R10:51ddfd32cc99: bridge test: adding and removing static addresses (authored by kp).
bridge test: adding and removing static addresses
Tue, Mar 2, 3:19 PM
kp committed R10:5b8932427605: bridge test: spanning tree (authored by kp).
bridge test: spanning tree
Tue, Mar 2, 3:19 PM
kp committed R10:791f370cb5d6: bridge: Basic test case (authored by kp).
bridge: Basic test case
Tue, Mar 2, 3:19 PM
kp committed R10:40fc07a85577: bridge tests: Remove unneeded 'All rights reserved.' (authored by kp).
bridge tests: Remove unneeded 'All rights reserved.'
Tue, Mar 2, 3:19 PM
kp committed R10:2d1773f32319: bridge/stp: Ensure we enter NET_EPOCH whenever we can send traffic (authored by kp).
bridge/stp: Ensure we enter NET_EPOCH whenever we can send traffic
Tue, Mar 2, 3:19 PM
kp committed R10:a285c84d517f: arp/nd: Cope with late calls to iflladdr_event (authored by kp).
arp/nd: Cope with late calls to iflladdr_event
Tue, Mar 2, 3:19 PM
kp committed R10:6a0355a0fe75: bridge: Remove members when assigned to a new vnet (authored by kp).
bridge: Remove members when assigned to a new vnet
Tue, Mar 2, 3:19 PM
kp committed R10:2c19b99c2f1c: bridge tests: Test STP on top of VLAN devices (authored by kp).
bridge tests: Test STP on top of VLAN devices
Tue, Mar 2, 3:19 PM
kp committed R10:02a34c9198d2: bridge: Support STP on VLAN devices (authored by kp).
bridge: Support STP on VLAN devices
Tue, Mar 2, 3:19 PM
kp committed R10:eaba3fe1483f: bridge/stp: Ensure we enter NET_EPOCH whenever we can send traffic (authored by kp).
bridge/stp: Ensure we enter NET_EPOCH whenever we can send traffic
Tue, Mar 2, 3:19 PM
kp committed R10:05ac80ac0f3a: arp/nd: Cope with late calls to iflladdr_event (authored by kp).
arp/nd: Cope with late calls to iflladdr_event
Tue, Mar 2, 3:18 PM
kp committed R10:a20033be9ed8: bridge: Remove members when assigned to a new vnet (authored by kp).
bridge: Remove members when assigned to a new vnet
Tue, Mar 2, 3:18 PM
kp committed R10:c3438a8438fe: bridge: Support STP on VLAN devices (authored by kp).
bridge: Support STP on VLAN devices
Tue, Mar 2, 3:18 PM

Mon, Mar 1

kp accepted D28990: sbin/ifconfig: Use a global handle for libifconfig.
Mon, Mar 1, 7:24 AM
kp committed R10:a7926435c12e: pf: Fix incorrect fragment handling (authored by kp).
pf: Fix incorrect fragment handling
Mon, Mar 1, 7:06 AM

Sun, Feb 28

kp accepted D28991: libifconfig: Add a function to get down reason.
Sun, Feb 28, 9:30 PM
kp committed R10:5f5a45463ea0: pf: Fix incorrect fragment handling (authored by kp).
pf: Fix incorrect fragment handling
Sun, Feb 28, 4:06 PM
kp committed R10:555726fda685: pf: Fix build if INVARIANTS is not set (authored by kp).
pf: Fix build if INVARIANTS is not set
Sun, Feb 28, 4:06 PM
kp committed R10:8de214ad4d22: pf: Limit the fragment entry queue length to 64 per bucket. (authored by kp).
pf: Limit the fragment entry queue length to 64 per bucket.
Sun, Feb 28, 4:05 PM
kp committed R10:11bf4f2fbb3c: pf: Split the fragment reassembly queue into smaller parts (authored by kp).
pf: Split the fragment reassembly queue into smaller parts
Sun, Feb 28, 4:05 PM
kp committed R10:1d6a2a742c1b: pf: Count holes rather than fragments for reassembly (authored by kp).
pf: Count holes rather than fragments for reassembly
Sun, Feb 28, 4:05 PM
kp committed R10:f520c87f3a09: Revert "pf: Limit the maximum number of fragments per packet" (authored by kp).
Revert "pf: Limit the maximum number of fragments per packet"
Sun, Feb 28, 4:04 PM
kp accepted D28954: sbin/ifconfig: Use libifconfig to get bridge status.
Sun, Feb 28, 4:01 PM
kp accepted D28965: sbin/ifconfig: Use libifconfig to get groups.
Sun, Feb 28, 3:59 PM
kp committed R10:86ebf4d3e12c: pf: Fix incorrect fragment handling (authored by kp).
pf: Fix incorrect fragment handling
Sun, Feb 28, 3:57 PM

Sat, Feb 27

kp accepted D28955: sbin/ifconfig: Use libifconfig to get carp status.
Sat, Feb 27, 4:48 PM
kp accepted D28961: sbin/ifconfig: Use libifconfig to get lagg status.
Sat, Feb 27, 4:45 PM
kp added a comment to D28967: Trim leading/trailing white space in dummynet Tidy up the leading and trailing white space issues highlighted by vim. Avoid touching whitespace that is used for layout and the functions which are entirely space aligned..

I think I'd prefer that we didn't do this.

Sat, Feb 27, 4:30 PM
kp added inline comments to D28965: sbin/ifconfig: Use libifconfig to get groups.
Sat, Feb 27, 4:26 PM
kp accepted D28964: libifconfig: Fix handling of malloc fail in ifconfig_get_groups.
Sat, Feb 27, 4:07 PM
kp added inline comments to D28954: sbin/ifconfig: Use libifconfig to get bridge status.
Sat, Feb 27, 4:02 PM

Thu, Feb 25

kp committed R10:5f1b1f184b7f: pf: Fix incorrect fragment handling (authored by kp).
pf: Fix incorrect fragment handling
Thu, Feb 25, 10:45 PM
kp added a member for Jails: kp.
Thu, Feb 25, 3:28 PM
kp closed D28917: bridge tests: Test that we also forward on some interfaces.
Thu, Feb 25, 12:33 PM
kp committed R10:7a4dbffa4205: bridge tests: Test that we also forward on some interfaces (authored by kp).
bridge tests: Test that we also forward on some interfaces
Thu, Feb 25, 12:33 PM
kp closed D28916: bridgestp: Ensure we send STP on VLAN interfaces.
Thu, Feb 25, 12:32 PM
kp committed R10:f5537cd0693c: bridgestp: Ensure we send STP on VLAN interfaces (authored by kp).
bridgestp: Ensure we send STP on VLAN interfaces
Thu, Feb 25, 12:32 PM
kp closed D28918: net: remove legacy in_addmulti().
Thu, Feb 25, 12:32 PM
kp committed R10:f3245be3499b: net: remove legacy in_addmulti() (authored by kp).
net: remove legacy in_addmulti()
Thu, Feb 25, 12:32 PM

Wed, Feb 24

kp added a comment to D28918: net: remove legacy in_addmulti().

That would be my assumption.

Wed, Feb 24, 5:38 PM
kp requested review of D28918: net: remove legacy in_addmulti().
Wed, Feb 24, 5:16 PM
kp requested review of D28917: bridge tests: Test that we also forward on some interfaces.
Wed, Feb 24, 5:15 PM
kp requested review of D28916: bridgestp: Ensure we send STP on VLAN interfaces.
Wed, Feb 24, 5:15 PM
kp committed R10:98e40918a6fa: pf tests: Explicitly ask for python3 (authored by kp).
pf tests: Explicitly ask for python3
Wed, Feb 24, 1:02 PM
kp committed R10:720206821fe7: pf: Assert that pfil_link() calls succeed (authored by kp).
pf: Assert that pfil_link() calls succeed
Wed, Feb 24, 1:02 PM
kp committed R10:ef160e5cb919: pf: Remove unused return value from (de)hook_pf() (authored by kp).
pf: Remove unused return value from (de)hook_pf()
Wed, Feb 24, 1:02 PM

Tue, Feb 23

kp accepted D28903: tests/sys/netpfil/pf: Add missing python3 requirements.

Thanks for the fixes.

Tue, Feb 23, 6:59 PM
kp added inline comments to D28903: tests/sys/netpfil/pf: Add missing python3 requirements.
Tue, Feb 23, 6:21 PM
kp accepted D28894: tests/sys/netgraph: Tell kyua that perl is required.

It'd be nice to make ng_macfilter_test use atf-sh, but this is progress.

Tue, Feb 23, 4:59 PM
kp committed R10:26492ba2716f: bridge tests: Test STP on top of VLAN devices (authored by kp).
bridge tests: Test STP on top of VLAN devices
Tue, Feb 23, 1:57 PM
kp closed D28860: arp/nd: Cope with late calls to iflladdr_event.
Tue, Feb 23, 1:56 PM
kp closed D28861: bridge tests: Test STP on top of VLAN devices.
Tue, Feb 23, 1:56 PM
kp committed R10:c139b3c19b52: arp/nd: Cope with late calls to iflladdr_event (authored by kp).
arp/nd: Cope with late calls to iflladdr_event
Tue, Feb 23, 1:56 PM
kp committed R10:38c0951386d8: bridge: Remove members when assigned to a new vnet (authored by kp).
bridge: Remove members when assigned to a new vnet
Tue, Feb 23, 1:56 PM
kp closed D28859: bridge: Remove members when assigned to a new vnet.
Tue, Feb 23, 1:56 PM
kp committed R10:89fa9c34d76b: bridge/stp: Ensure we enter NET_EPOCH whenever we can send traffic (authored by kp).
bridge/stp: Ensure we enter NET_EPOCH whenever we can send traffic
Tue, Feb 23, 1:56 PM
kp closed D28858: bridge/stp: Ensure we enter NET_EPOCH whenever we can send traffic.
Tue, Feb 23, 1:56 PM
kp closed D28857: bridge: Support STP on VLAN devices.
Tue, Feb 23, 1:56 PM
kp committed R10:711ed156b945: bridge: Support STP on VLAN devices (authored by kp).
bridge: Support STP on VLAN devices
Tue, Feb 23, 1:55 PM
kp committed R10:04535d6a572a: pf tests: Test unicast reverse path forwarding check (authored by kp).
pf tests: Test unicast reverse path forwarding check
Tue, Feb 23, 11:51 AM