Page MenuHomeFreeBSD

kp (Kristof Provost)
User

Projects

User Details

User Since
Sep 28 2014, 7:22 PM (282 w, 1 d)

Recent Activity

Today

kp added a comment to D23808: bridge: Move locking defines into if_bridge.c.
In D23808#523738, @ae wrote:

It seems some of these macros should be fixed to respect style(9) and use tab instead of space after #define.

Tue, Feb 25, 11:29 AM

Yesterday

kp accepted D23813: Remove -DMACHINE_ARCH hack from Makefile.riscv.

With this patch both riscv64 and riscv64sf TARGET_ARCH build result in something that can build ports. They both report the expected hw.machine_arch, and both have the correct MACHINE_ARCH set in bmake.

Mon, Feb 24, 9:01 PM
kp added a comment to D23812: Add a soft-float riscv kernel config.

I've also had to apply this patch, but that's an issue that was already present:

Mon, Feb 24, 12:10 PM
kp added a comment to D23813: Remove -DMACHINE_ARCH hack from Makefile.riscv.
In D23813#523305, @imp wrote:

I can't test-boot this change, however... I'm not sure about the lp64->lp64d for mabi.

Mon, Feb 24, 10:43 AM
kp added a comment to D23813: Remove -DMACHINE_ARCH hack from Makefile.riscv.
In D23813#523305, @imp wrote:

I can't test-boot this change, however... I'm not sure about the lp64->lp64d for mabi.

Mon, Feb 24, 7:36 AM

Sun, Feb 23

kp created D23808: bridge: Move locking defines into if_bridge.c.
Sun, Feb 23, 5:31 PM
kp added a comment to D23741: riscv: Set MACHINE_ARCH define based on TARGET_ARCH.

There's certainly still something missing. When I build with make TARGET_ARCH=riscv64sf it builds with MACHINE_ARCH = riscv64, and that breaks ports builds (because we set the wrong flags).

Sun, Feb 23, 5:28 PM

Sat, Feb 22

kp committed rS358247: riscv: Set MACHINE_ARCH correctly.
riscv: Set MACHINE_ARCH correctly
Sat, Feb 22, 1:23 PM
kp closed D23741: riscv: Set MACHINE_ARCH define based on TARGET_ARCH.
Sat, Feb 22, 1:23 PM

Fri, Feb 21

kp accepted D23634: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N).
Fri, Feb 21, 8:42 AM

Thu, Feb 20

kp added a comment to D23741: riscv: Set MACHINE_ARCH define based on TARGET_ARCH.

I found the following excerpt in bsd.cpu.mk:

.if ${MACHINE_CPUARCH} == "riscv"
.if ${MACHINE_ARCH:Mriscv*sf}
CFLAGS += -march=rv64imac -mabi=lp64
.else
CFLAGS += -march=rv64imafdc -mabi=lp64d
.endif
.endif

So we could instead check for the presence of hardware floating extensions using the following check in param.h:
#if defined(__riscv_flen) && __riscv_flen != 0

https://github.com/riscv/riscv-toolchain-conventions defines __riscv_float_abi_soft as well, so I don't know if that helps us.
It's also not explicit about what the value will set to if neither F nor D extensions are present (although yes, I'd expect it to be unset or 0).

Thu, Feb 20, 9:37 PM
kp updated the diff for D23741: riscv: Set MACHINE_ARCH define based on TARGET_ARCH.

The previous version was an incomple fix.
It did ensure that the hw.machine_arch was correct, but bmake uses the
MACHINE_ARCH define if it exists. As it includes sys/params.h this was the
case. In other words: we need to ensure that MACHINE_ARCH is set correctly for
userspace builds as well.

Thu, Feb 20, 8:51 PM
kp committed rS358178: virtio: Pass the interrupt type in mmio mode.
virtio: Pass the interrupt type in mmio mode
Thu, Feb 20, 5:26 PM

Wed, Feb 19

kp committed rS358124: bridge tests: Remove unneeded 'All rights reserved.'.
bridge tests: Remove unneeded 'All rights reserved.'
Wed, Feb 19, 4:44 PM

Tue, Feb 18

kp created D23741: riscv: Set MACHINE_ARCH define based on TARGET_ARCH.
Tue, Feb 18, 12:58 PM

Mon, Feb 17

kp added a comment to D23634: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N).

I'm not sure why we care about CTLFLAG_MPSAFE on nodes with no handler (pf, pfsync), but I have no objections.

Mon, Feb 17, 9:28 AM

Sun, Feb 16

kp committed rS357998: bridge: Basic test case.
bridge: Basic test case
Sun, Feb 16, 1:16 PM
kp closed D23697: bridge: Basic test case.
Sun, Feb 16, 1:16 PM
kp updated the diff for D23697: bridge: Basic test case.
  • sort test list in Makefile
  • rename test case
Sun, Feb 16, 10:41 AM

Sat, Feb 15

kp created D23697: bridge: Basic test case.
Sat, Feb 15, 5:29 PM

Thu, Feb 13

kp committed rS357857: tests: Enable net tests.
tests: Enable net tests
Thu, Feb 13, 2:09 PM

Wed, Feb 5

kp accepted D23498: mixer: the cleanup function is not called and not needed.
Wed, Feb 5, 4:05 PM

Tue, Feb 4

kp added a comment to D23498: mixer: the cleanup function is not called and not needed.

Hmm. I wonder if it's not better the actually add the cleanup call to the atf_test_case definition.
It's not needed if the test passes, but perhaps it makes sense to try to restore the volume if the test should fail.

Tue, Feb 4, 4:28 PM
kp committed rS357490: MFC r357234, r357365, r357375:.
MFC r357234, r357365, r357375:
Tue, Feb 4, 4:30 AM
kp committed rS357489: MFC r357234, r357365, r357375:.
MFC r357234, r357365, r357375:
Tue, Feb 4, 4:30 AM

Sat, Feb 1

kp committed rS357375: tests: epair: Don't fail if we load if_epair.
tests: epair: Don't fail if we load if_epair
Sat, Feb 1, 7:40 PM
kp committed rS357365: tests: epair: Don't fail if the if_epair module is already loaded.
tests: epair: Don't fail if the if_epair module is already loaded
Sat, Feb 1, 11:32 AM
kp accepted D23406: prci: register tlclk as a fixed clock.
Sat, Feb 1, 8:05 AM

Fri, Jan 31

kp committed rS357356: vlan: Fix panic when vnet jail with a vlan interface is destroyed.
vlan: Fix panic when vnet jail with a vlan interface is destroyed
Fri, Jan 31, 10:55 PM
kp committed rS357325: MFC r357233:.
MFC r357233:
Fri, Jan 31, 10:34 AM
kp committed rS357326: MFC r357233:.
MFC r357233:
Fri, Jan 31, 10:34 AM

Thu, Jan 30

kp committed rS357290: MFC r356816:.
MFC r356816:
Thu, Jan 30, 9:57 AM
kp committed rS357289: MFC r356816:.
MFC r356816:
Thu, Jan 30, 9:57 AM

Wed, Jan 29

kp accepted D23404: prci: register the DDR and GEMGX PLLs.

This patch series is happy on my SiFive FU540 board, and I'm happy with the patches.

Wed, Jan 29, 2:47 PM
kp added inline comments to D23406: prci: register tlclk as a fixed clock.
Wed, Jan 29, 2:47 PM
kp accepted D23405: prci: fix up compat.

I'm inferring that this driver was written using this device tree, as this is what is passed by the FSBL. If there is a different one that was used please point me to it.

Wed, Jan 29, 2:44 PM
kp added a comment to D23404: prci: register the DDR and GEMGX PLLs.
In D23404#513349, @kp wrote:

At first glance this looks good.
I have a SiFive FU540 I can test with tomorrow.
I only implemented the core clock because it feeds the SPI / UART / I2C clocks. The DDR and gigabit ethernet clocks were not relevant.

Thanks. They will still be unused/irrelevant at present, but my thinking is that it is useful to have so we can eventually set the cgem's reference clock.

Wed, Jan 29, 2:15 PM
kp accepted D23407: cgem: Add another compat string for the SiFive fu540.
Wed, Jan 29, 2:10 PM

Tue, Jan 28

kp committed rS357234: tests: Test for an epair panic.
tests: Test for an epair panic
Tue, Jan 28, 10:47 PM
kp committed rS357233: epair: Do not abuse params to register the second interface.
epair: Do not abuse params to register the second interface
Tue, Jan 28, 10:44 PM
kp added a comment to D23404: prci: register the DDR and GEMGX PLLs.

At first glance this looks good.
I have a SiFive FU540 I can test with tomorrow.

Tue, Jan 28, 8:05 PM

Mon, Jan 27

kp added a comment to D23316: Add basic tests for IPDIVERT write functionality..

However, I'm not sure what is the best way of telling the framework/wrapper that ipfw/ipdivert has to be loaded in advance, so we actually run these tests :-)

Mon, Jan 27, 3:53 PM
kp added a comment to D23316: Add basic tests for IPDIVERT write functionality..

While other test cases haven't done this yet, but I'd like to see the new tests can restore the system as much as they can, if it doesn't bring too much complexity:

  1. Can ipfw and ipdivert be unloaded safely after test?

Unloading the IPFW module seems like a bad idea. The netpfil/common tests rely on the module being loaded to run IPFW tests.
I believe the module is loaded because the test/build scripts explicitly load it, just like pf.

Mon, Jan 27, 1:13 PM

Jan 25 2020

kp committed rS357113: tests: Routing tests overwrote net tests.
tests: Routing tests overwrote net tests
Jan 25 2020, 10:52 AM

Jan 23 2020

kp added a comment to D23254: pf: Apply kif flags to new group members.

Thanks for the review.

Jan 23 2020, 10:14 PM
kp committed rS357061: pf: Apply kif flags to new group members.
pf: Apply kif flags to new group members
Jan 23 2020, 10:14 PM
kp closed D23254: pf: Apply kif flags to new group members.
Jan 23 2020, 10:14 PM

Jan 22 2020

kp committed rS356995: pfsync: Ensure we enter network epoch before calling ip_output.
pfsync: Ensure we enter network epoch before calling ip_output
Jan 22 2020, 9:01 PM

Jan 18 2020

kp created D23254: pf: Apply kif flags to new group members.
Jan 18 2020, 8:28 PM

Jan 7 2020

kp added a comment to D23073: vtnet: Pre-allocate debugnet data immediately.
In D23073#505713, @cem wrote:

This seems fine to me, although I'm not super familiar with vtnet / mbufs / uma. I think it might also be reasonable for uma_zone_reserve / uma_prealloc to work on zones that have already been allocated from? Maybe I misunderstand how they work.

uma_zone_reserve() asserts that the keg is cold (no allocations done from it). I can only assume there's a good reason for that, but I can't say that I know why.

Jan 7 2020, 10:46 PM
kp added reviewers for D23073: vtnet: Pre-allocate debugnet data immediately: cem, markj.
Jan 7 2020, 10:09 PM
kp created D23073: vtnet: Pre-allocate debugnet data immediately.
Jan 7 2020, 10:06 PM

Dec 25 2019

kp added a comment to D22920: For riscv kernel builds, add -N to LDFLAGS instead of replacing the SYSTEM_LD variable..
In D22920#502031, @ian wrote:

Does anyone know why riscv needs writable text segments? Or if it really does?

Dec 25 2019, 12:42 PM

Dec 13 2019

kp added a comment to D22691: ifnet: drain+halt ioctl/vmove operations on detach.

With all three of these patches I now see this panic running the pf tests:

Dec 13 2019, 4:58 PM
kp accepted D22783: if_detach_internal: defer reading of vnet_shutdown until needed.
Dec 13 2019, 12:57 AM

Dec 12 2019

kp accepted D22780: if_vmove: return proper error status.
Dec 12 2019, 8:14 PM
kp added a comment to D22780: if_vmove: return proper error status.

There's another call to if_vmove() in vnet_if_return(). We probably can't handle errors there (and I expect that D22691 will ensure it can't fail), but we should at least assert that it succeeded.

Dec 12 2019, 7:12 PM
kp added a comment to D22691: ifnet: drain+halt ioctl/vmove operations on detach.

Still haven't looked at it, but it seems to fix PR 238870. No more panics (in a couple of runs of) pf:names / pf:synproxy tests, so as far as I'm concerned this cannot get merged quickly enough.

Dec 12 2019, 1:48 AM
kp added a comment to D22691: ifnet: drain+halt ioctl/vmove operations on detach.

This seems to break the build:

Dec 12 2019, 12:19 AM

Dec 11 2019

kp updated the diff for D22733: pfctl: Warn users when they run into kernel limits.

Improve error messages

Dec 11 2019, 5:02 AM

Dec 10 2019

kp added a comment to D22737: pf: Make request_maxcount runtime adjustable.

This affects the number of items (not just tables) that can be processed in a single ioctl() operation, not the number of entries we allow in a table.
pfctl by and large only works on a single table at a time, but might try to add/delete/modify/... multiple IP addresses at a time. It's generally possible to do this in multiple requests, so having more items in a table than the request_maxcount isn't a critical problem.

Dec 10 2019, 4:14 PM

Dec 9 2019

kp added a comment to D22733: pfctl: Warn users when they run into kernel limits.

Reporting an "error too many tables" is useful for adding a new table.
It's wrong for deleting and misleading for obtaining statistics.

Dec 9 2019, 8:41 PM
kp created D22737: pf: Make request_maxcount runtime adjustable.
Dec 9 2019, 7:39 PM
kp created D22733: pfctl: Warn users when they run into kernel limits.
Dec 9 2019, 5:18 AM

Dec 4 2019

kp added a comment to D20468: Port if_vether from OpenBSD.

Could you please supply use case? Why do we need another virtual ethernet interface? We already have many kinds of them.

As it says in the review body -- bridge(4) regression testing was/is the first candidate for use. My initial plan for testing was to spawn up a bridge and stick N of these in it in different configurations. This review has been sitting long enough now that I don't recall if I decided that wasn't feasible in the meantime (or if @kp had already had other plans), but if it is it'd be more convenient than epair -- with this, you have the absolute bare minimum needed to get a packet from bridge to userspace in 329 total lines of file without also pair management in between.

I have plans (and minor in-progress work) to do bridge tests with if_epair. I've not really found if_epair to be burdensome to write test withs (aside from its tendency to expose locking issues in the network stack).

Dec 4 2019, 7:36 PM

Dec 3 2019

kp accepted D22462: ip6_input: remove redundant v4mapped check.
Dec 3 2019, 4:19 AM

Nov 19 2019

kp accepted D22443: Reduce the vnet_set module size of ip_mroute to allow loading as a module..
Nov 19 2019, 2:38 PM
kp added inline comments to D22443: Reduce the vnet_set module size of ip_mroute to allow loading as a module..
Nov 19 2019, 2:02 PM

Nov 13 2019

kp accepted D22327: RISC-V: Print SBI info at startup.
Nov 13 2019, 10:05 AM
kp accepted D22326: RISC-V: add support for SBI spec v0.2.
Nov 13 2019, 10:04 AM

Nov 12 2019

kp requested changes to D22326: RISC-V: add support for SBI spec v0.2.
Nov 12 2019, 12:12 PM
kp added inline comments to D22327: RISC-V: Print SBI info at startup.
Nov 12 2019, 11:54 AM
kp accepted D22325: RISC-V: pass arg6 in sbi_call.
Nov 12 2019, 10:43 AM

Oct 25 2019

kp accepted D22151: RISC-V: skip cpu-map when parsing elf_hwcap.
Oct 25 2019, 3:11 PM

Oct 17 2019

pi renamed kp from kristof to kp.
Oct 17 2019, 4:18 AM

Oct 15 2019

kp added a reviewer for D22035: Generalize ARM specific comments in devmap: manu.
Oct 15 2019, 12:51 AM

Oct 13 2019

kp added inline comments to D22003: Add lle_event handler to ARP.
Oct 13 2019, 6:06 PM

Oct 12 2019

kp added inline comments to D22003: Add lle_event handler to ARP.
Oct 12 2019, 8:22 PM
kp accepted D21998: RISC-V: Call devmap_print_table() on bootverbose.

Minor nit: Mention where this is mentioned (i.e. the comments to the function).
Other than that this looks like a good idea to me.

Oct 12 2019, 5:39 PM

Oct 5 2019

kp abandoned D18679: libxo: Fix XML output if a container name is a number.
Oct 5 2019, 1:21 PM

Oct 4 2019

kp added a comment to D21897: mountroot: Run statfs after mounting devfs.

This happens on a riscv machine, running from an mdroot (although I'm not sure if that's relevant to trigger it), not running devd during the aio_test:md_waitcomplete regression test.
That test opens /dev/mdX and tries to perform an aio write on it, which ends up failing. I'm not sure I fully understand the intent behind the test, but it revealed that the aio code considered that to be an unsafe. The safety check code thinks that mp->mnt_stat.f_iosize is relevant, and because of the lack of VFS_STATFS call that was still set to 0 for devfs.

Oct 4 2019, 7:16 PM
kp created D21897: mountroot: Run statfs after mounting devfs.
Oct 4 2019, 5:18 PM

Sep 25 2019

kp accepted D21772: Style cleanup in elf_machdep.c.
Sep 25 2019, 9:05 AM

Sep 11 2019

kp accepted D21576: Small fix to CPU Compatibility Identification.
Sep 11 2019, 4:13 PM

Sep 8 2019

kp added a comment to D20568: Add a section to blacklistd to the PF chapter of the handbook.

Other than the typo this looks good to me.

Sep 8 2019, 2:54 AM

Sep 5 2019

kp created D21538: riscv: Ensure that BSS is 8-byte aligned.
Sep 5 2019, 7:09 PM
kp created D21537: csu: Add the riscv .init call sequence.
Sep 5 2019, 7:05 PM

Sep 4 2019

kp accepted D21521: pkgbase: pfctl: tests: Put tests files in the FreeBSD-tests package.
Sep 4 2019, 3:53 PM

Aug 16 2019

D21276: Move pft_ping.py and sniffer.py to the common test directory is now accepted and ready to land.
Aug 16 2019, 2:03 PM
kp added a comment to D21276: Move pft_ping.py and sniffer.py to the common test directory.

This probably also wants this:

Aug 16 2019, 9:29 AM

Aug 15 2019

D21267: pf tests: Fix accidental duplication of content is now accepted and ready to land.
Aug 15 2019, 11:24 AM

Aug 14 2019

kp accepted D21199: NAT basic test for pf, ipfw (both in-kernel and userspace) and ipf.
Aug 14 2019, 12:21 PM

Aug 12 2019

kp added a comment to D21199: NAT basic test for pf, ipfw (both in-kernel and userspace) and ipf.

And this is wrong, or at least very confusing, in firewall_init():

Aug 12 2019, 2:41 PM

Aug 11 2019

kp added a comment to D21199: NAT basic test for pf, ipfw (both in-kernel and userspace) and ipf.

I seem to run into issues running the ipfw_basic test:

Aug 11 2019, 5:01 PM

Jul 31 2019

kp added inline comments to D21065: Pass/Block test for three firewalls (pf, ipfw, ipf).
Jul 31 2019, 8:37 AM · GSoC Students

Jul 29 2019

D21065: Pass/Block test for three firewalls (pf, ipfw, ipf) is now accepted and ready to land.

I think I'm happy with this.
I'll give Tom a bit of time to add any more remarks he might have, but I think we can commit this soon.

Jul 29 2019, 8:39 PM · GSoC Students
kp added a comment to D21100: riscv: Fix copyin/copyout.

Full context.

Jul 29 2019, 1:57 PM
kp added a comment to D21086: pf: Remove partial RFC2675 support.
In D21086#457948, @ae wrote:

Does this mean that you concluded in the IETF mailing list to drop this support?

Jul 29 2019, 1:55 PM
kp created D21100: riscv: Fix copyin/copyout.
Jul 29 2019, 12:58 PM

Jul 28 2019

kp added a comment to D21086: pf: Remove partial RFC2675 support.

Remove more bits, as suggested by thj

Jul 28 2019, 7:44 PM