Page MenuHomeFreeBSD

dummymbuf: Fix code style
ClosedPublic

Authored by igoro on Oct 5 2024, 10:03 AM.
Tags
None
Referenced Files
F132540712: D46958.id144327.diff
Fri, Oct 17, 7:50 PM
F132540709: D46958.id.diff
Fri, Oct 17, 7:50 PM
F132540707: D46958.id144299.diff
Fri, Oct 17, 7:50 PM
F132501200: D46958.diff
Fri, Oct 17, 10:52 AM
Unknown Object (File)
Wed, Oct 15, 5:59 AM
Unknown Object (File)
Sun, Oct 12, 3:53 AM
Unknown Object (File)
Thu, Sep 25, 12:37 AM
Unknown Object (File)
Wed, Sep 17, 10:02 PM

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

igoro requested review of this revision.Oct 5 2024, 10:03 AM

Approved.

I was going to suggest not capitalising 'Fix', but apparently I am wrong about what our convention is there. See https://freebsdfoundation.org/wp-content/uploads/2020/11/Writing-Commit-Messages.pdf where Ed explicitly recommends "Capitalize the first letter of the subject", and I'm not going to argue with Ed.

I might include a 'No functional change' in the commit message, just to be doubly explicit about that, but the first line already heavily implies it.

This revision is now accepted and ready to land.Oct 5 2024, 1:39 PM
This revision was automatically updated to reflect the committed changes.