Page MenuHomeFreeBSD

dummymbuf: Fix code style
ClosedPublic

Authored by igoro on Oct 5 2024, 10:03 AM.
Tags
None
Referenced Files
F103134091: D46958.id144299.diff
Thu, Nov 21, 11:09 AM
Unknown Object (File)
Mon, Nov 11, 11:19 PM
Unknown Object (File)
Wed, Nov 6, 8:38 PM
Unknown Object (File)
Wed, Nov 6, 6:40 PM
Unknown Object (File)
Wed, Nov 6, 10:05 AM
Unknown Object (File)
Fri, Nov 1, 2:27 AM
Unknown Object (File)
Sat, Oct 26, 10:50 AM
Unknown Object (File)
Sat, Oct 26, 10:50 AM

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

igoro requested review of this revision.Oct 5 2024, 10:03 AM

Approved.

I was going to suggest not capitalising 'Fix', but apparently I am wrong about what our convention is there. See https://freebsdfoundation.org/wp-content/uploads/2020/11/Writing-Commit-Messages.pdf where Ed explicitly recommends "Capitalize the first letter of the subject", and I'm not going to argue with Ed.

I might include a 'No functional change' in the commit message, just to be doubly explicit about that, but the first line already heavily implies it.

This revision is now accepted and ready to land.Oct 5 2024, 1:39 PM
This revision was automatically updated to reflect the committed changes.