Page MenuHomeFreeBSD

ae (Andrey V. Elsukov)
User

Projects

User Details

User Since
Jun 4 2014, 7:25 AM (328 w, 2 d)

Recent Activity

Tue, Sep 15

ae committed rS365746: MFC r365449:.
MFC r365449:
Tue, Sep 15, 8:54 AM
ae committed rS365745: MFC r365449:.
MFC r365449:
Tue, Sep 15, 8:53 AM

Fri, Sep 11

ae added a comment to D26358: ipfw: fix compatibility with frag and older rule sets.

Committed as rS365628.

Fri, Sep 11, 10:15 AM
ae committed rS365628: Fix compatibility regression after r364117..
Fix compatibility regression after r364117.
Fri, Sep 11, 10:07 AM

Thu, Sep 10

ae added a comment to D26358: ipfw: fix compatibility with frag and older rule sets.

I think this patch is too complicated. Can you properly test this patch instead? https://people.freebsd.org/~ae/ipfw_frag.diff

Thu, Sep 10, 10:09 AM

Tue, Sep 8

ae closed D25389: Add loop visualization and parallel execution support into rcorder.
Tue, Sep 8, 10:36 AM
ae committed rS365449: Add a few features to rcorder:.
Add a few features to rcorder:
Tue, Sep 8, 10:36 AM

Aug 12 2020

ae committed rS364163: MFC r363906:.
MFC r363906:
Aug 12 2020, 12:12 PM
ae committed rS364162: MFC r363888:.
MFC r363888:
Aug 12 2020, 12:08 PM
ae committed rS364161: MFC r363900:.
MFC r363900:
Aug 12 2020, 12:07 PM
ae committed rS364160: MFC r363904:.
MFC r363904:
Aug 12 2020, 12:06 PM
ae committed rS364159: MFC r363906:.
MFC r363906:
Aug 12 2020, 11:49 AM
ae committed rS364158: MFC r363888:.
MFC r363888:
Aug 12 2020, 11:48 AM
ae committed rS364157: MFC r363900:.
MFC r363900:
Aug 12 2020, 11:43 AM
ae committed rS364156: MFC r363904:.
MFC r363904:
Aug 12 2020, 11:43 AM

Aug 11 2020

ae accepted D26021: ipfw: improve matching on IPv4 fragments.

LGTM.

Aug 11 2020, 9:13 AM

Aug 5 2020

ae committed rS363908: Synchronize definitions in mbuf.d with values from mbuf.h.
Synchronize definitions in mbuf.d with values from mbuf.h
Aug 5 2020, 11:54 AM
ae committed rS363906: Add m__getjcl SDT probe..
Add m__getjcl SDT probe.
Aug 5 2020, 11:39 AM
ae closed D25734: ipfw nat64 improve prefix length checks.
Aug 5 2020, 11:27 AM
ae committed rS363904: Fix SIGSEGV in ipfw(8) when NAT64 prefix length is omitted..
Fix SIGSEGV in ipfw(8) when NAT64 prefix length is omitted.
Aug 5 2020, 11:27 AM
ae closed D25932: net.inet6.icmp6.nodeinfo typo fix.
Aug 5 2020, 10:27 AM
ae committed rS363900: Fix typo..
Fix typo.
Aug 5 2020, 10:27 AM
ae committed rS363888: Handle delayed checksums if needed in NAT64..
Handle delayed checksums if needed in NAT64.
Aug 5 2020, 9:16 AM

Aug 3 2020

ae added a comment to D25789: NAT64: compute checksum for locally generated packets.

I sent a more generic patch in the reply to your email a week ago, can you check your spam folder and test it?

Aug 3 2020, 8:39 AM

Jul 30 2020

ae accepted D25887: ip6_output(): Check the return value of in6_getlinkifnet()..

LGTM.

Jul 30 2020, 7:45 AM

Jul 27 2020

ae added a comment to D25789: NAT64: compute checksum for locally generated packets.

I think it should be possible solve the problem without introducing extra configuration parameter. I'll take a look.

Jul 27 2020, 8:02 AM

Jul 13 2020

ae accepted D25456: ipfw(8): Fix most warnings with the default WARNS level..

LGTM.

Jul 13 2020, 7:07 AM

Jun 25 2020

ae accepted D25444: Enter and exit the network epoch for async IPsec callbacks..

LGTM.

Jun 25 2020, 10:25 AM
ae added inline comments to D25445: Complete the fib<4|6>_lookup_nh_<basic|ext> -> fib<4|6>_lookup() transition.
Jun 25 2020, 6:41 AM · network

Jun 10 2020

ae committed rS362009: MFC r361749:.
MFC r361749:
Jun 10 2020, 1:06 PM

Jun 9 2020

ae added inline comments to D25192: Add rib_action() and make rtsock use it..
Jun 9 2020, 9:49 AM

Jun 5 2020

ae committed rS361832: MFC r361624:.
MFC r361624:
Jun 5 2020, 9:59 AM
ae committed rS361831: MFC r361624:.
MFC r361624:
Jun 5 2020, 9:57 AM

Jun 3 2020

ae committed rS361749: Add if_reassing method to all tunneling interfaces..
Add if_reassing method to all tunneling interfaces.
Jun 3 2020, 1:02 PM

Jun 1 2020

ae added a comment to D24989: netinet: Generate a random RSS key on boot..
In D24989#552576, @avg wrote:

I have a vague memory, maybe wrong, that commonly used fixed RSS keys were selected because they had some property (-ies).
So, maybe just being random is not good enough?
I think that hypothetical rss_isbadkey was mentioned for a reason?

Jun 1 2020, 11:44 AM · csprng, network
ae accepted D25067: add new rib manipulation functions..

LGTM.

Jun 1 2020, 8:47 AM
ae added a comment to D25070: Add rib subscription API..

How many subscribers do you expect? I think you will replace some existing. Maybe it would be better to have separate list for each subscription type?

Jun 1 2020, 8:07 AM

May 29 2020

ae added a comment to D25029: Introduce ifconfig -a -[gG] groupname.

You can just use another option name to specify excludes.

May 29 2020, 12:49 PM
ae committed rS361624: Fix O_IP_FLOW_LOOKUP opcode handling..
Fix O_IP_FLOW_LOOKUP opcode handling.
May 29 2020, 10:38 AM

May 26 2020

ae accepted D24978: Switch gif(4) path verification to use fib[46]_check_urfp().
May 26 2020, 10:48 AM

May 25 2020

ae accepted D24976: Switch ip_output/icmp_reflect rt lookup calls with fib4_lookup..
May 25 2020, 8:46 AM
ae accepted D24973: Replace fib6_lookup_nh_<ext|basic> calls with fib6_lookup..
May 25 2020, 8:37 AM

May 22 2020

ae added a comment to D24939: geom(4): Kill GEOM_PART_EBR_COMPAT option.

I have no objection against this. Just one test case to test - create several EBR partitions (e.g. s5, s6, s7), then remove one from the middle (i.e. s6), then create two smaller in this free space (and then optionally reboot, and see what we will have after reboot).

May 22 2020, 2:04 PM
ae added a reviewer for D24939: geom(4): Kill GEOM_PART_EBR_COMPAT option: marcel.
May 22 2020, 12:21 PM

May 20 2020

ae added a comment to D22444: Add UDP encapsulation of ESP in IPv6.

I'll try to test this and commit with small modifications after weekend. Thanks!

May 20 2020, 11:28 AM

May 14 2020

ae added a reviewer for D22444: Add UDP encapsulation of ESP in IPv6: network.
May 14 2020, 11:38 AM
ae added inline comments to D22444: Add UDP encapsulation of ESP in IPv6.
May 14 2020, 11:38 AM

May 6 2020

ae added a comment to D24669: Embed dest sockaddr into rtentry and remove counter.

It seems rt_pktsent is already unused in head/, thus its removal is reasonable. According to your calculations for offsets, this change can give some performance boost, and I'll try to measure it in the lab, but I'm not sure this will happen very soon. Also maybe is it worth to add some explicit alignment requirements to rtentry structure or some of its fields? We can use __aligned(CACHE_LINE_SIZE)

May 6 2020, 2:30 PM
ae added a comment to D24724: Hide forward messages in nd6log().

I also agree that these messages should be removed. But moving them to nd6 debugging seems wrong.

May 6 2020, 9:18 AM
ae added inline comments to D24731: Add rib_lookup() sockaddr lookup wrapper and make ifa_ifwithroute use it..
May 6 2020, 9:07 AM
ae added a comment to D24427: ipfw: use SLIST_REMOVE_HEAD and SLIST_REMOVE_AFTER for the first and subsequent respective states.

JFYI, this code will be removed when refactoring to the epoch(9) will be finished.

May 6 2020, 7:17 AM · network

Apr 23 2020

ae added a comment to D24061: Hyper-V socket implementation for FreeBSD guest.

Do you have performance test results for already existing linux implementation?
From a quick look it seems to me there will be bottleneck regarding locking that seems can be reduced using CK and epoch. But this task can be done in future, if you plan support this code.

Apr 23 2020, 12:15 PM

Apr 16 2020

ae accepted D24440: Add nhop parameter to rti_filter callback..
Apr 16 2020, 11:34 AM

Apr 14 2020

ae accepted D24404: Reorganise nd6 notification code to avoid direct rtentry field access..
Apr 14 2020, 10:15 AM
ae accepted D24245: Convert IP/IPv6 forwarding and ICMP processing to the new routing KPI..
Apr 14 2020, 10:01 AM
ae accepted D24334: Convert ip6_forward() to the new routing KPI..
Apr 14 2020, 9:55 AM

Apr 13 2020

ae added inline comments to D24245: Convert IP/IPv6 forwarding and ICMP processing to the new routing KPI..
Apr 13 2020, 9:57 AM
ae added inline comments to D24334: Convert ip6_forward() to the new routing KPI..
Apr 13 2020, 9:27 AM

Apr 11 2020

ae added a comment to D24232: Stage 1: Introduce nexhop objects and new routing kpi.

I'm going to commit it on Sunday, April 12 unless anyone has any objection.

Apr 11 2020, 9:52 AM
ae committed rS359803: MFC r359498:.
MFC r359498:
Apr 11 2020, 9:37 AM
ae committed rS359802: MFC r359498:.
MFC r359498:
Apr 11 2020, 9:36 AM

Apr 9 2020

ae committed rS359740: MFC r359327,359328:.
MFC r359327,359328:
Apr 9 2020, 7:15 AM
ae committed rS359739: MFC r359327,359328:.
MFC r359327,359328:
Apr 9 2020, 7:12 AM

Apr 7 2020

ae added inline comments to D24232: Stage 1: Introduce nexhop objects and new routing kpi.
Apr 7 2020, 1:12 PM

Apr 6 2020

ae committed rS359649: MFC r359271:.
MFC r359271:
Apr 6 2020, 6:39 AM
ae committed rS359648: MFC r359271:.
MFC r359271:
Apr 6 2020, 6:35 AM

Apr 2 2020

ae accepted D24244: Use interface fib for proxyarp checks..

LGTM.

Apr 2 2020, 11:47 AM
ae accepted D24249: bridge: Change lists to CK_LIST as a peparation for epochification.
Apr 2 2020, 8:41 AM

Apr 1 2020

ae committed rS359498: Ignore ND6 neighbor advertisement received for static link-layer entries..
Ignore ND6 neighbor advertisement received for static link-layer entries.
Apr 1 2020, 2:13 AM

Mar 31 2020

ae added inline comments to D24232: Stage 1: Introduce nexhop objects and new routing kpi.
Mar 31 2020, 7:28 AM

Mar 26 2020

ae committed rS359328: Fix typo..
Fix typo.
Mar 26 2020, 12:00 PM
ae closed D23468: Property-based filters for syslogd.
Mar 26 2020, 11:54 AM
ae committed rS359327: Add property-based filters for syslogd..
Add property-based filters for syslogd.
Mar 26 2020, 11:54 AM

Mar 24 2020

ae committed rS359271: Use IP_FW_NAT44_DESTROY opcode for IP_FW3 socket option to destroy.
Use IP_FW_NAT44_DESTROY opcode for IP_FW3 socket option to destroy
Mar 24 2020, 12:27 PM

Mar 20 2020

ae added a comment to D24134: ipsec: Use in6p_zoneid on local link IPv6 addresses in ipsec_setsockaddrs_inpcb().

how did you test this change?

Mar 20 2020, 12:42 PM · network

Feb 28 2020

ae added a comment to D23872: fib6_rte_to_nh_*: correctly return a link-local gw address:.

Looks good to me. But I'd wait for @melifaro, there are several places where this KPI is used and I didn't check how it can affect it :)

Feb 28 2020, 12:18 PM
ae added a comment to D23872: fib6_rte_to_nh_*: correctly return a link-local gw address:.

This code, probably, was written with hope of depreciation of scope embedding into addresses.
If you plan to remove these, please leave the comment that returned address has embedded scope.
Also you will probably want to remove related XXX hack from fast forwarding code.

Feb 28 2020, 11:41 AM

Feb 25 2020

ae added a comment to D23808: bridge: Move locking defines into if_bridge.c.

It seems some of these macros should be fixed to respect style(9) and use tab instead of space after #define.

Feb 25 2020, 11:20 AM

Feb 19 2020

ae added a comment to D23737: nat64: Get the IPv4 address from a NAT64 address when comparing addresses in a ICMP translate.

Also, how did test your changes? :)
NAT64 currently is not widely used, thus changes here can break something and you will know about breakage when it will be not so easy to fix, e.g. after release.

Feb 19 2020, 11:28 AM · network
ae added a comment to D23737: nat64: Get the IPv4 address from a NAT64 address when comparing addresses in a ICMP translate.

Here, I also compare the destination addresses. Is this what you want?

Feb 19 2020, 11:26 AM · network

Feb 18 2020

ae requested changes to D23737: nat64: Get the IPv4 address from a NAT64 address when comparing addresses in a ICMP translate.

The patch is not correct. IPv4 address can be embedded in different places depending from configuration.

Feb 18 2020, 8:15 AM · network

Feb 10 2020

ae accepted D23599: Add missing EPOCH(9) wrapper in ipfw.
Feb 10 2020, 10:26 AM

Feb 3 2020

ae added a reviewer for D23468: Property-based filters for syslogd: eugen_grosbein.net.
Feb 3 2020, 8:34 AM

Jan 23 2020

ae added a reviewer for D21812: ipfw(8): When checking for IPv4 in add_src() and add_dat(), don't assume !IPv6 is IPv4: melifaro.
Jan 23 2020, 12:10 PM

Dec 26 2019

ae committed rS356093: MFC r355650:.
MFC r355650:
Dec 26 2019, 6:05 PM

Dec 23 2019

ae committed rS356036: MFC r355712:.
MFC r355712:
Dec 23 2019, 10:06 AM
ae committed rS356035: MFC r355712:.
MFC r355712:
Dec 23 2019, 10:03 AM

Dec 18 2019

ae added a comment to D22865: Remove dead code from in6_rmx.c.

I meant this thread: https://lists.freebsd.org/pipermail/freebsd-net/2019-October/054632.html

Dec 18 2019, 11:44 AM
ae accepted D22865: Remove dead code from in6_rmx.c.

We removed this code two years ago, since it adds big penalty for routers where are tens of thousands IPv6 routes.
However, someone in the mail list recently complained that we have not a method for route expiring, probably we can rework this code to implement such feature.

Dec 18 2019, 11:36 AM

Dec 17 2019

ae committed rS355851: MFC r355581:.
MFC r355581:
Dec 17 2019, 10:26 AM
ae committed rS355850: MFC r350413:.
MFC r350413:
Dec 17 2019, 10:23 AM
ae committed rS355849: MFC r355581:.
MFC r355581:
Dec 17 2019, 10:00 AM
ae committed rS355848: MFC r350413:.
MFC r350413:
Dec 17 2019, 9:46 AM

Dec 13 2019

ae closed D22749: Make TCP options parsing stricter.

Commited in rS355712.

Dec 13 2019, 11:49 AM
ae committed rS355712: Make TCP options parsing stricter..
Make TCP options parsing stricter.
Dec 13 2019, 11:48 AM

Dec 12 2019

ae committed rS355650: Follow RFC 4443 p2.2 and always use own addresses for reflected ICMPv6.
Follow RFC 4443 p2.2 and always use own addresses for reflected ICMPv6
Dec 12 2019, 1:29 PM
ae closed D22631: Use IPv6 SAS algorithm for reflected ICMPv6 datagrams in NAT64.
Dec 12 2019, 1:29 PM

Dec 10 2019

ae updated the diff for D22631: Use IPv6 SAS algorithm for reflected ICMPv6 datagrams in NAT64.

Update the patch.

Dec 10 2019, 1:19 PM
ae created D22749: Make TCP options parsing stricter.
Dec 10 2019, 12:43 PM
ae committed rS355581: Avoid access to stale ip pointer and call UPDATE_POINTERS() after.
Avoid access to stale ip pointer and call UPDATE_POINTERS() after
Dec 10 2019, 10:35 AM