Page MenuHomeFreeBSD

ae (Andrey V. Elsukov)
User

Projects

User Details

User Since
Jun 4 2014, 7:25 AM (245 w, 3 d)

Recent Activity

Wed, Feb 13

ae committed rS344103: In r335015 PCB destroing was made deferred using epoch_call()..
In r335015 PCB destroing was made deferred using epoch_call().
Wed, Feb 13, 3:46 PM

Mon, Feb 11

ae committed rS344018: Remove `set' field from state structure and use set from parent rule..
Remove `set' field from state structure and use set from parent rule.
Mon, Feb 11, 6:11 PM

Sat, Feb 9

ae committed rS343931: MFC r342908:.
MFC r342908:
Sat, Feb 9, 11:05 AM

Sat, Feb 2

ae committed rS343687: MFC r341472:.
MFC r341472:
Sat, Feb 2, 5:42 PM
ae committed rS343686: MFC r341471:.
MFC r341471:
Sat, Feb 2, 5:40 PM

Thu, Jan 31

ae added inline comments to D18951: New pfil(9).
Thu, Jan 31, 11:26 AM

Wed, Jan 30

ae added inline comments to D18951: New pfil(9).
Wed, Jan 30, 1:04 PM
ae added inline comments to D18951: New pfil(9).
Wed, Jan 30, 11:16 AM

Tue, Jan 29

ae committed rS343551: Fix the bug introduced in r342908, that causes problems with dynamic.
Fix the bug introduced in r342908, that causes problems with dynamic
Tue, Jan 29, 11:19 AM

Mon, Jan 28

ae added a comment to D18904: Make arp return errors.

arprequest_internal would be better.

Mon, Jan 28, 11:06 AM

Thu, Jan 24

ae accepted D18919: In ifconfig(8), don't build, sort and search all system addresses when performing a non-status action on a single interface.
Thu, Jan 24, 8:33 AM

Fri, Jan 18

ae committed rS343142: MFC 342925:.
MFC 342925:
Fri, Jan 18, 9:57 AM
ae committed rS343141: MFC r342925:.
MFC r342925:
Fri, Jan 18, 9:54 AM

Thu, Jan 17

ae added a comment to D18861: Attempt to address lagg race in PR234864.

Can you explain your goal? Not sure what you are trying to solve with this rlock. Please, note that LAGG_RLOCK() is epoch_enter() and it seem used to make safe lagg_port reclamation using epoch_call().

Thu, Jan 17, 11:28 AM

Jan 11 2019

ae committed rS342925: Relax requirement to packet size of CARP protocol and remove version check..
Relax requirement to packet size of CARP protocol and remove version check.
Jan 11 2019, 1:54 AM

Jan 10 2019

ae committed rS342909: Fix the build with INVARIANTS..
Fix the build with INVARIANTS.
Jan 10 2019, 2:01 AM
ae committed rS342908: Reduce the size of struct ip_fw_args from 240 to 128 bytes on amd64..
Reduce the size of struct ip_fw_args from 240 to 128 bytes on amd64.
Jan 10 2019, 1:48 AM
ae closed D18690: Reduce overhead of per-packet processing by ipfw(4).
Jan 10 2019, 1:48 AM

Jan 9 2019

ae added a comment to D18769: Fix broken IPv6 scope ID checks in outgoing direction.

Ah, yes, I remembered, this problem was introduced with route caching.

Jan 9 2019, 12:45 PM
ae added a comment to D18769: Fix broken IPv6 scope ID checks in outgoing direction.

So, why you think that this is wrong and shouldn't happen?

Because then TCP loopback on non-lo0 link-local addresses won't work.

Jan 9 2019, 11:03 AM

Jan 7 2019

ae added a comment to D18769: Fix broken IPv6 scope ID checks in outgoing direction.

The current code would drop packets which are designated for loopback which use a link-local scope ID in the destination address or source address, because they won't match the lo0's scope ID.

Jan 7 2019, 6:14 PM

Jan 1 2019

ae updated the diff for D18690: Reduce overhead of per-packet processing by ipfw(4).
  • reordered some fields and reduced the size of hopstore6, now ip_fw_args fits into 128 bytes.
  • the fwd code adjusted to use new hopstore6.
Jan 1 2019, 9:41 AM

Dec 31 2018

ae added a comment to D18690: Reduce overhead of per-packet processing by ipfw(4).

I really like collapsing all those pointers, and making the NULL checks flags. Great work.

I wonder if more collapsing could be done. For example, it seems like src_ip and dst_ip could share unions with src_ip6 and dst_ip6 in struct ipfw_flow_id(). That would take us down to 136 bytes. Only 8 more bytes and it would fit in 2 64 byte cachelines.

Dec 31 2018, 3:30 PM

Dec 30 2018

ae updated the summary of D18690: Reduce overhead of per-packet processing by ipfw(4).
Dec 30 2018, 6:26 PM
ae created D18690: Reduce overhead of per-packet processing by ipfw(4).
Dec 30 2018, 6:10 PM

Dec 28 2018

ae committed rS342571: MFC r342298:.
MFC r342298:
Dec 28 2018, 10:10 AM
ae committed rS342570: MFC r342298:.
MFC r342298:
Dec 28 2018, 10:09 AM

Dec 21 2018

ae committed rS342298: Allow use underscores and dots in service names without escaping..
Allow use underscores and dots in service names without escaping.
Dec 21 2018, 10:41 AM

Dec 20 2018

ae committed rS342277: MFC r342030:.
MFC r342030:
Dec 20 2018, 8:33 AM
ae committed rS342276: MFC r342030:.
MFC r342030:
Dec 20 2018, 8:29 AM

Dec 17 2018

ae created D18581: Add ability to forward IPv4 packets trough IPv6 only router.
Dec 17 2018, 11:43 AM
ae committed rS342164: MFC r341798:.
MFC r341798:
Dec 17 2018, 10:43 AM
ae committed rS342163: MFC r341798:.
MFC r341798:
Dec 17 2018, 10:42 AM

Dec 13 2018

ae committed rS342030: Plug memory leak for AES_*_NIST_GMAC algorithms..
Plug memory leak for AES_*_NIST_GMAC algorithms.
Dec 13 2018, 9:00 AM

Dec 12 2018

ae committed rS341843: MFC r340360:.
MFC r340360:
Dec 12 2018, 9:05 AM
ae committed rS341842: MFC r341469:.
MFC r341469:
Dec 12 2018, 8:59 AM
ae committed rS341841: MFC r341469:.
MFC r341469:
Dec 12 2018, 8:58 AM

Dec 10 2018

ae committed rS341799: Rework how protocol number is tracked in rule. Save it when O_PROTO.
Rework how protocol number is tracked in rule. Save it when O_PROTO
Dec 10 2018, 4:23 PM
ae committed rS341798: Use correct size for IPv4 address in gethostbyaddr()..
Use correct size for IPv4 address in gethostbyaddr().
Dec 10 2018, 3:42 PM

Dec 7 2018

ae committed rS341678: MFC r341008:.
MFC r341008:
Dec 7 2018, 9:42 AM
ae committed rS341677: MFC r341008:.
MFC r341008:
Dec 7 2018, 9:39 AM

Dec 6 2018

ae added a comment to D18420: add a method to defer destruction of if_softc to if_destroy.

How would you merge it without breaking the ifnet KBI? We've got 3rd party network interfaces in ports, etc...

Dec 6 2018, 8:09 PM
ae accepted D18420: add a method to defer destruction of if_softc to if_destroy.

I think such method can be useful. Do you plan to merge it?

Dec 6 2018, 11:59 AM

Dec 4 2018

ae committed rS341472: Add ability to request listing and deleting only for dynamic states..
Add ability to request listing and deleting only for dynamic states.
Dec 4 2018, 4:13 PM
ae closed D17532: Implement net.inet.ip.fw.dyn_keep_states for all rule actions, not just for default_to_accept case.
Dec 4 2018, 4:03 PM
ae committed rS341471: Reimplement how net.inet.ip.fw.dyn_keep_states works..
Reimplement how net.inet.ip.fw.dyn_keep_states works.
Dec 4 2018, 4:03 PM
ae committed rS341469: Add assertion to check that named object has correct type..
Add assertion to check that named object has correct type.
Dec 4 2018, 3:13 PM
ae added a comment to D18420: add a method to defer destruction of if_softc to if_destroy.

I'm inclined to agree. For tunneling interfaces I used global per-driver sx lock to prevent concurrent ioctl invocation. I think these drivers are not affected by this problem.

Dec 4 2018, 11:25 AM
ae added a comment to D18420: add a method to defer destruction of if_softc to if_destroy.

Looking at your description here, it seems if_bridge can be affected by this issue.

Dec 4 2018, 10:56 AM
ae added a comment to D18420: add a method to defer destruction of if_softc to if_destroy.

Can you provide an example, what another driver needs such method? Maybe it is enough to fix the problem locally in if_lagg for first time?

Dec 4 2018, 10:47 AM
ae committed rS341462: MFC r341073:.
MFC r341073:
Dec 4 2018, 9:20 AM
ae committed rS341461: MFC r341073:.
MFC r341073:
Dec 4 2018, 9:17 AM

Nov 30 2018

ae committed rS341336: MFC r340477:.
MFC r340477:
Nov 30 2018, 11:19 AM
ae committed rS341334: Adapt the fix in r341008 to correctly work with EBR..
Adapt the fix in r341008 to correctly work with EBR.
Nov 30 2018, 10:37 AM

Nov 27 2018

ae committed rS341073: Do not limit the mbuf queue length for keepalive packets..
Do not limit the mbuf queue length for keepalive packets.
Nov 27 2018, 4:53 PM
ae committed rS341057: MFC r340689:.
MFC r340689:
Nov 27 2018, 2:05 PM
ae committed rS341056: MFC r340689:.
MFC r340689:
Nov 27 2018, 2:02 PM
ae committed rS341008: Fix possible panic during ifnet detach in rtsock..
Fix possible panic during ifnet detach in rtsock.
Nov 27 2018, 9:04 AM
ae closed D18338: Fix possible panic during ifnet detach in rtsock .
Nov 27 2018, 9:04 AM

Nov 26 2018

ae added inline comments to D18338: Fix possible panic during ifnet detach in rtsock .
Nov 26 2018, 9:25 PM
ae updated the diff for D18338: Fix possible panic during ifnet detach in rtsock .

Added IFNET_RLOCK_NOSLEEP_ASSERT(). Removed whitespace changes.

Nov 26 2018, 9:25 PM
ae created D18338: Fix possible panic during ifnet detach in rtsock .
Nov 26 2018, 11:37 AM
ae accepted D18333: Fix routing sysctl leaks..

LGTM.

Nov 26 2018, 8:48 AM

Nov 20 2018

ae committed rS340689: Make multiline APPLY_MASK() macro to be function-like..
Make multiline APPLY_MASK() macro to be function-like.
Nov 20 2018, 6:38 PM

Nov 19 2018

ae added a comment to D16147: Create a macro for the static modifier with VNET.

Hi, Andrew, do you plan to merge this into stable/11? It would be nice to have these macros to be able make MFC.

Nov 19 2018, 9:50 AM

Nov 18 2018

ae committed rS340544: Revert r340541. It requires VNET_DEFINE_STATIC() macro that is not yet.
Revert r340541. It requires VNET_DEFINE_STATIC() macro that is not yet
Nov 18 2018, 1:05 AM
ae committed rS340542: MFC r339544:.
MFC r339544:
Nov 18 2018, 12:35 AM
ae committed rS340541: MFC r339542:.
MFC r339542:
Nov 18 2018, 12:34 AM
ae committed rS340540: MFC r339533:.
MFC r339533:
Nov 18 2018, 12:31 AM
ae committed rS340539: MFC r339539:.
MFC r339539:
Nov 18 2018, 12:29 AM
ae committed rS340538: MFC r339545:.
MFC r339545:
Nov 18 2018, 12:28 AM
ae committed rS340537: MFC r339535:.
MFC r339535:
Nov 18 2018, 12:26 AM
ae committed rS340536: MFC r339554:.
MFC r339554:
Nov 18 2018, 12:22 AM
ae committed rS340535: MFC r339551:.
MFC r339551:
Nov 18 2018, 12:17 AM
ae committed rS340533: MFC r339550,339556:.
MFC r339550,339556:
Nov 18 2018, 12:09 AM
ae committed rS340532: MFC r339537:.
MFC r339537:
Nov 18 2018, 12:04 AM
ae committed rS340531: MFC r339544:.
MFC r339544:
Nov 18 2018, 12:00 AM

Nov 17 2018

ae committed rS340530: MFC r339545:.
MFC r339545:
Nov 17 2018, 11:59 PM
ae committed rS340529: MFC r339539:.
MFC r339539:
Nov 17 2018, 11:58 PM
ae committed rS340528: MFC r339535:.
MFC r339535:
Nov 17 2018, 11:56 PM
ae committed rS340527: MFC r339533:.
MFC r339533:
Nov 17 2018, 11:54 PM
ae committed rS340526: MFC r339542:.
MFC r339542:
Nov 17 2018, 11:53 PM

Nov 16 2018

ae committed rS340477: Allow configuration of several ipsec interfaces with the same tunnel.
Allow configuration of several ipsec interfaces with the same tunnel
Nov 16 2018, 2:22 PM

Nov 13 2018

ae updated the summary of D17532: Implement net.inet.ip.fw.dyn_keep_states for all rule actions, not just for default_to_accept case.
Nov 13 2018, 1:06 PM
ae updated the diff for D17532: Implement net.inet.ip.fw.dyn_keep_states for all rule actions, not just for default_to_accept case.

added verbose mode for listing dynamic states
added ability to delete only dynamic states

Nov 13 2018, 1:04 PM

Nov 12 2018

ae closed D17765: Add ability to use dynamic external prefix in ipfw_nptv6 module.
Nov 12 2018, 11:21 AM
ae committed rS340360: Add ability to use dynamic external prefix in ipfw_nptv6 module..
Add ability to use dynamic external prefix in ipfw_nptv6 module.
Nov 12 2018, 11:21 AM

Nov 10 2018

ae added a comment to D17898: in6_ifattach_linklocal: handle immediate removal of the new LLA.
In D17898#382455, @bz wrote:

To me this change seems wrong. The only caller for this function is exactly for the situation when the link-local address is missing.
If we are in the progress of "configuring" the interface and someone is already de-configuring it to me that sounds like a concurrency problem elsewhere.
This entire function seems to be based on the idea that there's a lock held around it and it's the only actor (which might very well still be coming from &Giant days of FreeBSD 4).
Rather than changing the behaviour, why don't we fix the problem and hold the appropriate lock (if possible) or make sure (otherwise) that the concurrency problem is solved?

Nov 10 2018, 9:29 AM

Nov 9 2018

ae committed rS340278: MFC r340100:.
MFC r340100:
Nov 9 2018, 8:16 AM
ae committed rS340277: MFC r340100:.
MFC r340100:
Nov 9 2018, 8:15 AM

Nov 6 2018

ae added a comment to D17843: Fix Chelsio T6 drop statistics.
In D17843#381487, @np wrote:

Does the tcpdump put the card in promiscuous mode or are you using -p? Anything seen by tcpdump should show up in a netstat that's running at the same time.

Nov 6 2018, 6:11 PM
ae committed rS340175: Do not print "ip6" keyword in print_icmp6types() for O_ICMP6TYPE opcode..
Do not print "ip6" keyword in print_icmp6types() for O_ICMP6TYPE opcode.
Nov 6 2018, 7:42 AM

Nov 5 2018

ae added a comment to D17843: Fix Chelsio T6 drop statistics.

Hi, I have a report, that cxgbe driver doesn't take into account packets, that are received from mirrored port. So, when you run netstat -hw 1 -I cxl0 you will see no packets, but tcpdump will show them. It seems a bit confusing. I didn't checked this, so I might be wrong.

Nov 5 2018, 6:08 PM

Nov 3 2018

ae committed rS340100: Do not use bzero() for the O_ICMP6TYPE opcode..
Do not use bzero() for the O_ICMP6TYPE opcode.
Nov 3 2018, 8:06 PM

Oct 30 2018

ae created D17765: Add ability to use dynamic external prefix in ipfw_nptv6 module.
Oct 30 2018, 7:50 PM

Oct 28 2018

ae committed rS339842: MFC r339740:.
MFC r339740:
Oct 28 2018, 6:23 PM
ae committed rS339841: MFC r339740:.
MFC r339740:
Oct 28 2018, 6:21 PM

Oct 26 2018

ae committed rS339772: MFC r339532 (by glebius):.
MFC r339532 (by glebius):
Oct 26 2018, 10:20 AM

Oct 25 2018

ae committed rS339740: Use correct format specificator to print setdscp action..
Use correct format specificator to print setdscp action.
Oct 25 2018, 6:06 PM

Oct 24 2018

ae accepted D17594: rip6_input() inp validation after epoch(9).
Oct 24 2018, 6:22 AM