Page MenuHomeFreeBSD

ae (Andrey V. Elsukov)
User

Projects

User Details

User Since
Jun 4 2014, 7:25 AM (235 w, 5 d)

Recent Activity

Fri, Dec 7

ae committed rS341678: MFC r341008:.
MFC r341008:
Fri, Dec 7, 9:42 AM
ae committed rS341677: MFC r341008:.
MFC r341008:
Fri, Dec 7, 9:39 AM

Thu, Dec 6

ae added a comment to D18420: add a method to defer destruction of if_softc to if_destroy.

How would you merge it without breaking the ifnet KBI? We've got 3rd party network interfaces in ports, etc...

Thu, Dec 6, 8:09 PM
ae accepted D18420: add a method to defer destruction of if_softc to if_destroy.

I think such method can be useful. Do you plan to merge it?

Thu, Dec 6, 11:59 AM

Tue, Dec 4

ae committed rS341472: Add ability to request listing and deleting only for dynamic states..
Add ability to request listing and deleting only for dynamic states.
Tue, Dec 4, 4:13 PM
ae closed D17532: Implement net.inet.ip.fw.dyn_keep_states for all rule actions, not just for default_to_accept case.
Tue, Dec 4, 4:03 PM
ae committed rS341471: Reimplement how net.inet.ip.fw.dyn_keep_states works..
Reimplement how net.inet.ip.fw.dyn_keep_states works.
Tue, Dec 4, 4:03 PM
ae committed rS341469: Add assertion to check that named object has correct type..
Add assertion to check that named object has correct type.
Tue, Dec 4, 3:13 PM
ae added a comment to D18420: add a method to defer destruction of if_softc to if_destroy.

I'm inclined to agree. For tunneling interfaces I used global per-driver sx lock, to prevent concurrent ioctl invocation. I think these drivers are not affected by this problem.

Tue, Dec 4, 11:25 AM
ae added a comment to D18420: add a method to defer destruction of if_softc to if_destroy.

Looking at your description here, it seems if_bridge can be affected by this issue.

Tue, Dec 4, 10:56 AM
ae added a comment to D18420: add a method to defer destruction of if_softc to if_destroy.

Can you provide an example, what another driver needs such method? Maybe it is enough to fix the problem locally in if_lagg for first time?

Tue, Dec 4, 10:47 AM
ae committed rS341462: MFC r341073:.
MFC r341073:
Tue, Dec 4, 9:20 AM
ae committed rS341461: MFC r341073:.
MFC r341073:
Tue, Dec 4, 9:17 AM

Fri, Nov 30

ae committed rS341336: MFC r340477:.
MFC r340477:
Fri, Nov 30, 11:19 AM
ae committed rS341334: Adapt the fix in r341008 to correctly work with EBR..
Adapt the fix in r341008 to correctly work with EBR.
Fri, Nov 30, 10:37 AM

Tue, Nov 27

ae committed rS341073: Do not limit the mbuf queue length for keepalive packets..
Do not limit the mbuf queue length for keepalive packets.
Tue, Nov 27, 4:53 PM
ae committed rS341057: MFC r340689:.
MFC r340689:
Tue, Nov 27, 2:05 PM
ae committed rS341056: MFC r340689:.
MFC r340689:
Tue, Nov 27, 2:02 PM
ae committed rS341008: Fix possible panic during ifnet detach in rtsock..
Fix possible panic during ifnet detach in rtsock.
Tue, Nov 27, 9:04 AM
ae closed D18338: Fix possible panic during ifnet detach in rtsock .
Tue, Nov 27, 9:04 AM

Mon, Nov 26

ae added inline comments to D18338: Fix possible panic during ifnet detach in rtsock .
Mon, Nov 26, 9:25 PM
ae updated the diff for D18338: Fix possible panic during ifnet detach in rtsock .

Added IFNET_RLOCK_NOSLEEP_ASSERT(). Removed whitespace changes.

Mon, Nov 26, 9:25 PM
ae created D18338: Fix possible panic during ifnet detach in rtsock .
Mon, Nov 26, 11:37 AM
ae accepted D18333: Fix routing sysctl leaks..

LGTM.

Mon, Nov 26, 8:48 AM

Tue, Nov 20

ae committed rS340689: Make multiline APPLY_MASK() macro to be function-like..
Make multiline APPLY_MASK() macro to be function-like.
Tue, Nov 20, 6:38 PM

Mon, Nov 19

ae added a comment to D16147: Create a macro for the static modifier with VNET.

Hi, Andrew, do you plan to merge this into stable/11? It would be nice to have these macros to be able make MFC.

Mon, Nov 19, 9:50 AM

Sun, Nov 18

ae committed rS340544: Revert r340541. It requires VNET_DEFINE_STATIC() macro that is not yet.
Revert r340541. It requires VNET_DEFINE_STATIC() macro that is not yet
Sun, Nov 18, 1:05 AM
ae committed rS340542: MFC r339544:.
MFC r339544:
Sun, Nov 18, 12:35 AM
ae committed rS340541: MFC r339542:.
MFC r339542:
Sun, Nov 18, 12:34 AM
ae committed rS340540: MFC r339533:.
MFC r339533:
Sun, Nov 18, 12:31 AM
ae committed rS340539: MFC r339539:.
MFC r339539:
Sun, Nov 18, 12:29 AM
ae committed rS340538: MFC r339545:.
MFC r339545:
Sun, Nov 18, 12:28 AM
ae committed rS340537: MFC r339535:.
MFC r339535:
Sun, Nov 18, 12:26 AM
ae committed rS340536: MFC r339554:.
MFC r339554:
Sun, Nov 18, 12:22 AM
ae committed rS340535: MFC r339551:.
MFC r339551:
Sun, Nov 18, 12:17 AM
ae committed rS340533: MFC r339550,339556:.
MFC r339550,339556:
Sun, Nov 18, 12:09 AM
ae committed rS340532: MFC r339537:.
MFC r339537:
Sun, Nov 18, 12:04 AM
ae committed rS340531: MFC r339544:.
MFC r339544:
Sun, Nov 18, 12:00 AM

Sat, Nov 17

ae committed rS340530: MFC r339545:.
MFC r339545:
Sat, Nov 17, 11:59 PM
ae committed rS340529: MFC r339539:.
MFC r339539:
Sat, Nov 17, 11:58 PM
ae committed rS340528: MFC r339535:.
MFC r339535:
Sat, Nov 17, 11:56 PM
ae committed rS340527: MFC r339533:.
MFC r339533:
Sat, Nov 17, 11:54 PM
ae committed rS340526: MFC r339542:.
MFC r339542:
Sat, Nov 17, 11:53 PM

Fri, Nov 16

ae committed rS340477: Allow configuration of several ipsec interfaces with the same tunnel.
Allow configuration of several ipsec interfaces with the same tunnel
Fri, Nov 16, 2:22 PM

Tue, Nov 13

ae updated the summary of D17532: Implement net.inet.ip.fw.dyn_keep_states for all rule actions, not just for default_to_accept case.
Tue, Nov 13, 1:06 PM
ae updated the diff for D17532: Implement net.inet.ip.fw.dyn_keep_states for all rule actions, not just for default_to_accept case.

added verbose mode for listing dynamic states
added ability to delete only dynamic states

Tue, Nov 13, 1:04 PM

Mon, Nov 12

ae closed D17765: Add ability to use dynamic external prefix in ipfw_nptv6 module.
Mon, Nov 12, 11:21 AM
ae committed rS340360: Add ability to use dynamic external prefix in ipfw_nptv6 module..
Add ability to use dynamic external prefix in ipfw_nptv6 module.
Mon, Nov 12, 11:21 AM

Nov 10 2018

ae added a comment to D17898: in6_ifattach_linklocal: handle immediate removal of the new LLA.
In D17898#382455, @bz wrote:

To me this change seems wrong. The only caller for this function is exactly for the situation when the link-local address is missing.
If we are in the progress of "configuring" the interface and someone is already de-configuring it to me that sounds like a concurrency problem elsewhere.
This entire function seems to be based on the idea that there's a lock held around it and it's the only actor (which might very well still be coming from &Giant days of FreeBSD 4).
Rather than changing the behaviour, why don't we fix the problem and hold the appropriate lock (if possible) or make sure (otherwise) that the concurrency problem is solved?

Nov 10 2018, 9:29 AM

Nov 9 2018

ae committed rS340278: MFC r340100:.
MFC r340100:
Nov 9 2018, 8:16 AM
ae committed rS340277: MFC r340100:.
MFC r340100:
Nov 9 2018, 8:15 AM

Nov 6 2018

ae added a comment to D17843: Fix Chelsio T6 drop statistics.
In D17843#381487, @np wrote:

Does the tcpdump put the card in promiscuous mode or are you using -p? Anything seen by tcpdump should show up in a netstat that's running at the same time.

Nov 6 2018, 6:11 PM
ae committed rS340175: Do not print "ip6" keyword in print_icmp6types() for O_ICMP6TYPE opcode..
Do not print "ip6" keyword in print_icmp6types() for O_ICMP6TYPE opcode.
Nov 6 2018, 7:42 AM

Nov 5 2018

ae added a comment to D17843: Fix Chelsio T6 drop statistics.

Hi, I have a report, that cxgbe driver doesn't take into account packets, that are received from mirrored port. So, when you run netstat -hw 1 -I cxl0 you will see no packets, but tcpdump will show them. It seems a bit confusing. I didn't checked this, so I might be wrong.

Nov 5 2018, 6:08 PM

Nov 3 2018

ae committed rS340100: Do not use bzero() for the O_ICMP6TYPE opcode..
Do not use bzero() for the O_ICMP6TYPE opcode.
Nov 3 2018, 8:06 PM

Oct 30 2018

ae created D17765: Add ability to use dynamic external prefix in ipfw_nptv6 module.
Oct 30 2018, 7:50 PM

Oct 28 2018

ae committed rS339842: MFC r339740:.
MFC r339740:
Oct 28 2018, 6:23 PM
ae committed rS339841: MFC r339740:.
MFC r339740:
Oct 28 2018, 6:21 PM

Oct 26 2018

ae committed rS339772: MFC r339532 (by glebius):.
MFC r339532 (by glebius):
Oct 26 2018, 10:20 AM

Oct 25 2018

ae committed rS339740: Use correct format specificator to print setdscp action..
Use correct format specificator to print setdscp action.
Oct 25 2018, 6:06 PM

Oct 24 2018

ae accepted D17594: rip6_input() inp validation after epoch(9).
Oct 24 2018, 6:22 AM

Oct 23 2018

ae committed rS339649: Add the check that current VNET is ready and access to srchash is allowed..
Add the check that current VNET is ready and access to srchash is allowed.
Oct 23 2018, 1:12 PM
ae committed rS339646: Add the check that current VNET is ready and access to srchash is.
Add the check that current VNET is ready and access to srchash is
Oct 23 2018, 1:03 PM
ae committed rS339642: Remove softc from idhash when interface is destroyed..
Remove softc from idhash when interface is destroyed.
Oct 23 2018, 12:50 PM

Oct 22 2018

ae accepted D17647: Resolve deadlock between epoch(9) and various network interface SX-locks.

Looks good to me.

Oct 22 2018, 11:39 AM
ae added a comment to D16654: IPv6 transport for bsnmp.

Hi, Harti, it is good time to commit the IPv6 support into head/ :)

Oct 22 2018, 9:59 AM
ae committed rS339580: MFC r339357:.
MFC r339357:
Oct 22 2018, 7:04 AM

Oct 21 2018

ae committed rS339556: Include <sys/eventhandler.h> to fix the build..
Include <sys/eventhandler.h> to fix the build.
Oct 21 2018, 6:39 PM
ae accepted D17625: tcpdump: Log uid on pflog interfaces.

LGTM

Oct 21 2018, 6:33 PM
ae committed rS339555: Follow the fix in r339532 (by glebius):.
Follow the fix in r339532 (by glebius):
Oct 21 2018, 6:30 PM
ae committed rS339554: Rework if_ipsec(4) to use epoch(9) instead of rmlock..
Rework if_ipsec(4) to use epoch(9) instead of rmlock.
Oct 21 2018, 6:24 PM
ae closed D17190: Rework if_ipsec(4) to use epoch(9)-based locking model..
Oct 21 2018, 6:24 PM
ae committed rS339553: Add handling for appearing/disappearing of ingress addresses to if_me(4)..
Add handling for appearing/disappearing of ingress addresses to if_me(4).
Oct 21 2018, 6:18 PM
ae committed rS339552: Add handling for appearing/disappearing of ingress addresses to if_gre(4)..
Add handling for appearing/disappearing of ingress addresses to if_gre(4).
Oct 21 2018, 6:14 PM
ae closed D17214: Add handling for appearing/disappearing of ingress address for if_gre(4).
Oct 21 2018, 6:13 PM
ae committed rS339551: Add handling for appearing/disappearing of ingress addresses to if_gif(4)..
Add handling for appearing/disappearing of ingress addresses to if_gif(4).
Oct 21 2018, 6:06 PM
ae committed rS339550: Add KPI that can be used by tunneling interfaces to handle IP addresses.
Add KPI that can be used by tunneling interfaces to handle IP addresses
Oct 21 2018, 5:55 PM
ae closed D17134: Implement handling for appearing/disappearing of ingress address for tunneling interfaces.
Oct 21 2018, 5:55 PM
ae committed rS339545: Do not decrement RST life time if keep_alive is not turned on..
Do not decrement RST life time if keep_alive is not turned on.
Oct 21 2018, 4:45 PM
ae committed rS339544: Call inet_ntop() only when its result is needed..
Call inet_ntop() only when its result is needed.
Oct 21 2018, 4:38 PM
ae committed rS339542: Retire IPFIREWALL_NAT64_DIRECT_OUTPUT kernel option. And add ability.
Retire IPFIREWALL_NAT64_DIRECT_OUTPUT kernel option. And add ability
Oct 21 2018, 4:29 PM
ae closed D16647: Add ability to switch the output method for NAT64 in run-time .
Oct 21 2018, 4:29 PM
ae committed rS339539: Add IPFW_RULE_JUSTOPTS flag, that is used by ipfw(8) to mark rule,.
Add IPFW_RULE_JUSTOPTS flag, that is used by ipfw(8) to mark rule,
Oct 21 2018, 3:11 PM
ae closed D17373: Add ability to show ipfw rules, that were added using new rule format (without generic rule body, just rule options).
Oct 21 2018, 3:11 PM
ae committed rS339537: Add ifaddr_event_ext event. It is similar to ifaddr_event, but the.
Add ifaddr_event_ext event. It is similar to ifaddr_event, but the
Oct 21 2018, 3:02 PM
ae closed D17100: Extend ifaddr_event to pass ifaddr and event type to handler.
Oct 21 2018, 3:02 PM
ae committed rS339536: Fix grammar..
Fix grammar.
Oct 21 2018, 2:48 PM
ae closed D17171: Do not allow use `create` keyword as hostname when ifconfig(8) invoked for already existing interface.
Oct 21 2018, 2:41 PM
ae committed rS339535: Do not allow use `create` keyword as hostname when ifconfig(8) is invoked.
Do not allow use `create` keyword as hostname when ifconfig(8) is invoked
Oct 21 2018, 2:41 PM
ae abandoned D17079: Add sadb_x_sa2 extension header to SADB_ACQUIRE request.

Committed in r339533.

Oct 21 2018, 2:33 PM
ae committed rS339533: Add sadb_x_sa2 extension to SADB_ACQUIRE requests..
Add sadb_x_sa2 extension to SADB_ACQUIRE requests.
Oct 21 2018, 2:19 PM

Oct 15 2018

ae committed rS339357: Add extra parentheses to fix "versrcreach" opcode, (oif != NULL) should.
Add extra parentheses to fix "versrcreach" opcode, (oif != NULL) should
Oct 15 2018, 10:26 AM

Oct 12 2018

ae updated the diff for D17532: Implement net.inet.ip.fw.dyn_keep_states for all rule actions, not just for default_to_accept case.

Correct the size of allocated buffer to keep bitmask

Oct 12 2018, 12:20 PM
ae created D17532: Implement net.inet.ip.fw.dyn_keep_states for all rule actions, not just for default_to_accept case.
Oct 12 2018, 12:13 PM

Oct 8 2018

ae added reviewers for D17394: Fix lock order reversal when calling defrouter_remove() from nd6_na_input(). nd6_na_input() can take lle lock before nd6 lock in certain cases.: markj, network.
Oct 8 2018, 8:58 AM

Oct 7 2018

ae accepted D17450: Fix three epoch leaks.
Oct 7 2018, 5:54 PM

Oct 4 2018

ae accepted D17406: Fix ips_localout counter for SCTP.

Looking at the how IP_FORWARDING flag is used, I think gif/gre/me interfaces should not use this flag. What you think?

Oct 4 2018, 2:00 PM

Oct 3 2018

ae committed rS339123: MFC r338947:.
MFC r338947:
Oct 3 2018, 12:48 PM

Oct 1 2018

ae added a reviewer for D17373: Add ability to show ipfw rules, that were added using new rule format (without generic rule body, just rule options): melifaro.
Oct 1 2018, 3:48 PM
ae created D17373: Add ability to show ipfw rules, that were added using new rule format (without generic rule body, just rule options).
Oct 1 2018, 3:44 PM