Page MenuHomeFreeBSD

ae (Andrey V. Elsukov)
User

Projects

User Details

User Since
Jun 4 2014, 7:25 AM (392 w, 2 h)

Recent Activity

Thu, Dec 2

ae accepted D33226: tcpmd5: return ENOENT when security association not found.
Thu, Dec 2, 5:51 AM

Wed, Nov 24

ae added a comment to D33100: ipsec: fix a panic with INVARIANTS.

This looks like leftover from D33100.

Wed, Nov 24, 10:47 AM
ae added a reviewer for D33100: ipsec: fix a panic with INVARIANTS: wma.
Wed, Nov 24, 10:45 AM

Sat, Nov 13

ae accepted D32827: ipsec: fix edge case detection in key_getnewspid.
Sat, Nov 13, 9:15 AM
ae accepted D32828: ipsec: make sure the lock allocated in key_newsav does not false-share.
Sat, Nov 13, 9:10 AM

Fri, Nov 12

ae committed R10:80be188a8160: Fix the build after b3c1846830af71ee197dcfbdd9a6bea5980cbbdd (authored by ae).
Fix the build after b3c1846830af71ee197dcfbdd9a6bea5980cbbdd
Fri, Nov 12, 1:00 PM
ae committed R10:b3c1846830af: ip_divert: calculate delayed checksum for IPv6 adress family (authored by ae).
ip_divert: calculate delayed checksum for IPv6 adress family
Fri, Nov 12, 12:22 PM
ae committed R10:faba420cb9b1: ip_divert: calculate delayed checksum for IPv6 adress family (authored by ae).
ip_divert: calculate delayed checksum for IPv6 adress family
Fri, Nov 12, 12:21 PM

Nov 3 2021

ae accepted D32826: ipsec: serialize SPI allocation.
Nov 3 2021, 6:10 PM
ae added inline comments to D32826: ipsec: serialize SPI allocation.
Nov 3 2021, 5:02 PM
ae committed R10:4a9e95286cac: ip_divert: calculate delayed checksum for IPv6 adress family (authored by ae).
ip_divert: calculate delayed checksum for IPv6 adress family
Nov 3 2021, 12:25 PM
ae closed D32807: Calculate delayed csums for IPv6 adress family in divert_packet.
Nov 3 2021, 12:25 PM
ae added a comment to D32810: Relase LLE table resources before ND6..
In D32810#740413, @bz wrote:

This leads to a lot of questions:
(a) can we check for the NULL pointer and gracefully handle it? Or at least add a KASSERT to document it?

Nov 3 2021, 6:45 AM

Nov 2 2021

ae published D32811: Add nd6_ifinfo() function to do basic checks to avoid NULL pointer dereference for review.
Nov 2 2021, 11:05 PM
ae added a reviewer for D32807: Calculate delayed csums for IPv6 adress family in divert_packet: donner.
Nov 2 2021, 10:17 PM
ae added reviewers for D32810: Relase LLE table resources before ND6.: network, melifaro.
Nov 2 2021, 10:13 PM
ae requested review of D32810: Relase LLE table resources before ND6..
Nov 2 2021, 10:13 PM
ae accepted D32719: udp_input: remove a BSD stack relict.
Nov 2 2021, 7:17 PM
ae published D32807: Calculate delayed csums for IPv6 adress family in divert_packet for review.
Nov 2 2021, 5:08 PM
ae published D32806: Do not fragment forwarded IPv6 datagrams that were send by dummynet for review.
Nov 2 2021, 4:57 PM

Oct 29 2021

ae added a comment to D32719: udp_input: remove a BSD stack relict.

It isn't write only variable. At line 501 original IP header can be changed, this variable keeps its copy.

Oct 29 2021, 8:25 PM

Oct 20 2021

ae added a comment to D32563: net: Allow binding of unspecified address without address existance.
In D32563#735219, @bz wrote:

Has anyone checked what this was before the epoch work came in?

Oct 20 2021, 10:23 AM
ae accepted D32563: net: Allow binding of unspecified address without address existance.
Oct 20 2021, 8:29 AM
ae accepted D32561: bpf: Fix the write filter.

LGTM.

Oct 20 2021, 7:57 AM

Oct 1 2021

ae accepted D31967: Allow the BPF to be select for EVFILT_WRITE with kqueue..
Oct 1 2021, 8:03 AM

Sep 21 2021

ae accepted D32007: ipsec: enter epoch before calling into ipsec_run_hhooks.

LGTM.

Sep 21 2021, 2:47 PM
ae added inline comments to D32007: ipsec: enter epoch before calling into ipsec_run_hhooks.
Sep 21 2021, 12:58 PM

Sep 17 2021

ae added inline comments to D31967: Allow the BPF to be select for EVFILT_WRITE with kqueue..
Sep 17 2021, 8:53 AM

Sep 10 2021

ae accepted D31890: ipsec: Validate the protocol identifier in ipsec4_ctlinput().
Sep 10 2021, 12:24 PM
ae committed R10:fa9c65c7aa72: dtrace: fix ipfw_rule_info_t translator (authored by ae).
dtrace: fix ipfw_rule_info_t translator
Sep 10 2021, 10:41 AM
ae committed R10:a83a49502989: dtrace: fix ipfw_rule_info_t translator (authored by ae).
dtrace: fix ipfw_rule_info_t translator
Sep 10 2021, 10:36 AM

Sep 6 2021

ae accepted D31824: lltable: do not require prefix lookup when checking lle allocation rules..
Sep 6 2021, 9:31 AM

Sep 3 2021

ae committed R10:26302099fb91: ipfw_nat64: fix direct output mode (authored by ae).
ipfw_nat64: fix direct output mode
Sep 3 2021, 6:40 AM

Sep 2 2021

ae accepted D31785: DTrace ipfw: Follow struct ip_fw field change.

Ah, sorry, I committed the fix already..

Sep 2 2021, 1:43 PM
ae committed R10:5c8e8e82aeaf: dtrace: fix ipfw_rule_info_t translator (authored by ae).
dtrace: fix ipfw_rule_info_t translator
Sep 2 2021, 1:41 PM

Aug 26 2021

ae closed D31680: Fix NAT64 direct output..
Aug 26 2021, 10:57 AM
ae committed R10:da3a09d8941d: ipfw_nat64: fix direct output mode (authored by ae).
ipfw_nat64: fix direct output mode
Aug 26 2021, 10:57 AM

Aug 25 2021

ae published D31680: Fix NAT64 direct output. for review.
Aug 25 2021, 7:24 PM

Aug 24 2021

ae committed R10:8d0ced747a02: ipfw: fix possible data race between jump cache reading and updating. (authored by ae).
ipfw: fix possible data race between jump cache reading and updating.
Aug 24 2021, 3:00 PM
ae committed R10:304d3f32ba3b: ipfw: fix possible data race between jump cache reading and updating. (authored by ae).
ipfw: fix possible data race between jump cache reading and updating.
Aug 24 2021, 2:59 PM

Aug 17 2021

ae committed R10:322e5efda857: ipfw: fix possible data race between jump cache reading and updating. (authored by ae).
ipfw: fix possible data race between jump cache reading and updating.
Aug 17 2021, 8:35 AM
ae closed D31484: Fix data race in jump cache read/update.
Aug 17 2021, 8:35 AM

Aug 13 2021

ae committed R10:6144be57c0ab: Fix panic in IPv6 multicast code. (authored by ae).
Fix panic in IPv6 multicast code.
Aug 13 2021, 7:39 AM
ae committed R10:40ec2323e689: Fix panic in IPv6 multicast code. (authored by ae).
Fix panic in IPv6 multicast code.
Aug 13 2021, 7:33 AM

Aug 6 2021

ae committed R10:d477a7feed17: Fix panic in IPv6 multicast code. (authored by ae).
Fix panic in IPv6 multicast code.
Aug 6 2021, 10:01 AM
ae closed D31420: Fix panic in IPv6 multicast code.
Aug 6 2021, 10:01 AM

Aug 5 2021

ae published D31420: Fix panic in IPv6 multicast code for review.
Aug 5 2021, 9:00 AM

Jul 16 2021

ae accepted D31196: crypto: Constify all transform descriptors.
Jul 16 2021, 7:42 AM

Jul 15 2021

ae accepted D30992: ipsec: Handle ICMP NEEDFRAG message..
Jul 15 2021, 10:27 AM

Jul 5 2021

ae added inline comments to D30993: Check PMTU before sending a frame..
Jul 5 2021, 8:59 AM

Jun 28 2021

ae accepted D30916: ipsec: globalize lft zone and zero out buffers at allocation time.

I have no objection.

Jun 28 2021, 6:29 AM

Jun 16 2021

ae added a comment to D30764: ipfw: Update the pfil mbuf pointer in ipfw_check_frame().

p is a union of struct mbuf ** and void *. So wouldn't setting *p.m do the wrong thing if the packet is passed with PFIL_MEMPTR?

Jun 16 2021, 10:18 AM

Jun 15 2021

ae accepted D30764: ipfw: Update the pfil mbuf pointer in ipfw_check_frame().

I think we can set *p.m unconditionally, like we do in ipfw_check_packet().

Jun 15 2021, 11:21 AM

Jun 11 2021

ae abandoned D12041: direct vlan handling in mlx5en.

The intent of this review was show how we can reduce vlan handling call path. It is not targeted to be included in main stream.

Jun 11 2021, 2:49 PM

May 21 2021

ae added a comment to D29274: VNETify dummynet.
In D29274#682376, @kp wrote:

The locking Tom cites does still need to be fixed, but I think it's mostly okay. The only missing part is the protection of schedlist and aqmlist, and those will probably be better served by NET_EPOCH than by a separate lock. (Because taking the lock in find_sched_type() doesn't protect the struct dn_alg we return from being removed after we release the lock. Being inside NET_EPOCH and waiting to complete the unload until after NET_EPOCH_WAIT should be fine.)

I'll try to post a patch for that later today.

May 21 2021, 12:01 PM

May 17 2021

ae accepted D30313: dummynet: Remove unused code.

Just want to note, I'm sorry for long delay, I moved temporary to another project and dummynet overhaul is not done yet. But I plan to publish the code somewhere on guthub.

May 17 2021, 2:32 PM

May 11 2021

ae accepted D30208: sbin/ipfw: Allow tablearg as hostname.
May 11 2021, 8:41 AM
ae added a comment to D30164: sbin/ipfw: Fix parsing error in table based forward.

I meant the case fwd tableargs.home.lan:8000.

May 11 2021, 7:28 AM

May 10 2021

ae added a comment to D30164: sbin/ipfw: Fix parsing error in table based forward.

Replacing _substrcmp() with strncmp(,,8) breaks the case, when "tablearg" is part of hostname:port syntax.

May 10 2021, 9:51 PM

May 2 2021

ae accepted D30046: sbin/ipfw: Fix null pointer deference when printing counters.
May 2 2021, 12:54 PM

Apr 30 2021

ae accepted D30042: traceroute6: Properly calculate UDP checksum.
Apr 30 2021, 10:33 AM

Apr 28 2021

ae committed R10:5ebfa80f7543: ipfw: do not use sleepable malloc in callout context. (authored by ae).
ipfw: do not use sleepable malloc in callout context.
Apr 28 2021, 10:08 AM
ae committed R10:29246f2cb0c5: ipfw: do not use sleepable malloc in callout context. (authored by ae).
ipfw: do not use sleepable malloc in callout context.
Apr 28 2021, 10:06 AM

Apr 20 2021

ae accepted D29838: Add more checking for unmapped mbufs.
Apr 20 2021, 4:48 AM

Apr 19 2021

ae added a comment to D29378: pf: Handle unmapped mbufs when computing checksums.

I see a call in ipfw, I guess that needs to be updated too. Seems time to introduce a new subroutine to handle this.

Apr 19 2021, 11:03 AM

Apr 16 2021

ae added inline comments to D29772: ipfw: do not use sleepable malloc in callout context..
Apr 16 2021, 8:23 AM
ae committed R10:9bacbf1ae243: ipfw: do not use sleepable malloc in callout context. (authored by ae).
ipfw: do not use sleepable malloc in callout context.
Apr 16 2021, 7:25 AM
ae closed D29772: ipfw: do not use sleepable malloc in callout context..
Apr 16 2021, 7:25 AM

Apr 15 2021

ae updated the diff for D29772: ipfw: do not use sleepable malloc in callout context..
  • Fix copy/paste bug.
Apr 15 2021, 12:40 PM
ae published D29772: ipfw: do not use sleepable malloc in callout context. for review.
Apr 15 2021, 12:37 PM

Apr 6 2021

ae committed R10:38c299fe8562: ipdivert: check that PCB is still valid after taking INPCB_RLOCK. (authored by ae).
ipdivert: check that PCB is still valid after taking INPCB_RLOCK.
Apr 6 2021, 6:51 AM
ae committed R10:6b8c65318e81: ipdivert: check that PCB is still valid after taking INPCB_RLOCK. (authored by ae).
ipdivert: check that PCB is still valid after taking INPCB_RLOCK.
Apr 6 2021, 6:50 AM

Apr 5 2021

ae added a comment to D29576: First take on syn-rlock..
In D29576#663187, @ae wrote:

Imagine, you have two or more identical SYNs, now you use INP_RLOCK(), this means they all can be handled in parallel "in the same time". This means, syncache_add() in some cases can determine that there are no corresponding entries yet - syncache_lookup() returns NULL, we still hold SCH_LOCK(), then we allocate syncache entry, populate all its fields and do SCH_UNLOCK(). Imagine, now the same things will be done by the another thread, and another. In the end we will have several the same entries added by the syncache_insert().
Is this impossible?

In this case the second thread will wait in SCH_LOCK and then, once it acquires the lock, syncache_lookup will return entry created by the first thread.

Apr 5 2021, 4:19 PM
ae added a comment to D29576: First take on syn-rlock..
In D29576#663155, @ae wrote:

I doubt that it is enough to just do s/wlock/rlock/ in the syncache code. Usually we need to add the extra check that an entry was not already linked by another thread in such cases.

Nothing changes in the syncache hash locking with this patch. The patch changes to rlock of the listening socket PCB.

Apr 5 2021, 1:53 PM
ae added a comment to D29576: First take on syn-rlock..

I doubt that it is enough to just do s/wlock/rlock/ in the syncache code. Usually we need to add the extra check that an entry was not already linked by another thread in such cases.

Apr 5 2021, 11:38 AM

Apr 1 2021

ae accepted D29515: tcp: Use jenkins_hash32() in hostcache.
Apr 1 2021, 7:32 AM
ae added inline comments to D29515: tcp: Use jenkins_hash32() in hostcache.
Apr 1 2021, 7:31 AM

Mar 30 2021

ae closed D29420: ip_divert: check that PCB is still valid after INP_RLOCK taking.
Mar 30 2021, 9:43 AM
ae committed R10:c80a4b76ceac: ipdivert: check that PCB is still valid after taking INPCB_RLOCK. (authored by ae).
ipdivert: check that PCB is still valid after taking INPCB_RLOCK.
Mar 30 2021, 9:43 AM

Mar 25 2021

ae published D29420: ip_divert: check that PCB is still valid after INP_RLOCK taking for review.
Mar 25 2021, 8:58 AM

Mar 19 2021

ae added a reviewer for D29320: Add log() style versions of device_printf() and if_printf(): network.
Mar 19 2021, 8:56 AM

Mar 16 2021

ae added a comment to D29274: VNETify dummynet.

I think when my work will be ready, I will commit it as separate implementation. Thus you can commit your changes to go forward with your work.

Mar 16 2021, 9:22 AM

Mar 9 2021

ae committed R10:fb827e006cec: ipfw: add IPv6 support for sockarg opcode. (authored by ae).
ipfw: add IPv6 support for sockarg opcode.
Mar 9 2021, 8:54 AM
ae committed R10:f5183ef429ef: ipfw: add IPv6 support for sockarg opcode. (authored by ae).
ipfw: add IPv6 support for sockarg opcode.
Mar 9 2021, 8:52 AM

Mar 4 2021

ae accepted D29056: net: Introduce IPV6_DSCP(), IPV6_ECN() and IPV6_TRAFFIC_CLASS() macros.

LGTM.

Mar 4 2021, 12:43 PM
ae committed R10:952ad2822359: ipfw: make algo name argument optional for some table types (authored by ae).
ipfw: make algo name argument optional for some table types
Mar 4 2021, 9:25 AM
ae committed R10:f8317f3a4c7d: ipfw: make algo name argument optional for some table types (authored by ae).
ipfw: make algo name argument optional for some table types
Mar 4 2021, 9:22 AM
ae committed R10:8d0f1438b0d7: ipfw: make algo name argument optional for some table types (authored by ae).
ipfw: make algo name argument optional for some table types
Mar 4 2021, 9:21 AM
ae added inline comments to D29048: pf: Retrieve DSCP value from the IPv6 header.
Mar 4 2021, 8:55 AM

Mar 3 2021

ae added a comment to D27837: Add an implementation of CHACHA20_POLY1035 to cryptosoft..

Hi John,

Mar 3 2021, 11:07 AM

Mar 2 2021

ae added a comment to D28967: Trim leading/trailing white space in dummynet Tidy up the leading and trailing white space issues highlighted by vim. Avoid touching whitespace that is used for layout and the functions which are entirely space aligned..

I'm working on this code and I think all this changes will be lost in the future, or they will take away my desire to merge changes.

Mar 2 2021, 9:57 AM
ae committed R10:a9f7eba95971: ipfw: add IPv6 support for sockarg opcode. (authored by ae).
ipfw: add IPv6 support for sockarg opcode.
Mar 2 2021, 9:49 AM

Feb 26 2021

ae added a reviewer for D28933: wireguard: allow to set IPv6 endpoint: network.
Feb 26 2021, 6:44 AM

Feb 25 2021

ae committed R10:13ad237a19b7: ipfw: make algo name argument optional for some table types (authored by ae).
ipfw: make algo name argument optional for some table types
Feb 25 2021, 2:07 PM

Feb 18 2021

ae accepted D28773: mbuf: add a way to mark flowid as calculated from the internal headers.
Feb 18 2021, 2:46 PM

Feb 16 2021

ae committed R10:6666b1d45a1b: [udp6] fix possible panic due to lack of locking. (authored by ae).
[udp6] fix possible panic due to lack of locking.
Feb 16 2021, 10:08 PM

Feb 15 2021

ae committed R10:8cb4c3631630: [udp6] fix possible panic due to lack of locking. (authored by ae).
[udp6] fix possible panic due to lack of locking.
Feb 15 2021, 10:52 AM
ae committed R10:9f46322cad47: [udp] fix possible mbuf and lock leak in udp_input(). (authored by ae).
[udp] fix possible mbuf and lock leak in udp_input().
Feb 15 2021, 10:51 AM

Feb 11 2021

ae committed R10:c6ded47d0bae: [udp] fix possible mbuf and lock leak in udp_input(). (authored by ae).
[udp] fix possible mbuf and lock leak in udp_input().
Feb 11 2021, 9:25 AM
ae committed R10:3c782d9c9166: [udp6] fix possible panic due to lack of locking. (authored by ae).
[udp6] fix possible panic due to lack of locking.
Feb 11 2021, 9:25 AM