Page MenuHomeFreeBSD

ae (Andrey V. Elsukov)
User

Projects

User Details

User Since
Jun 4 2014, 7:25 AM (303 w, 3 d)

Recent Activity

Thu, Mar 26

ae committed rS359328: Fix typo..
Fix typo.
Thu, Mar 26, 12:00 PM
ae closed D23468: Property-based filters for syslogd.
Thu, Mar 26, 11:54 AM
ae committed rS359327: Add property-based filters for syslogd..
Add property-based filters for syslogd.
Thu, Mar 26, 11:54 AM

Tue, Mar 24

ae committed rS359271: Use IP_FW_NAT44_DESTROY opcode for IP_FW3 socket option to destroy.
Use IP_FW_NAT44_DESTROY opcode for IP_FW3 socket option to destroy
Tue, Mar 24, 12:27 PM

Fri, Mar 20

ae added a comment to D24134: ipsec: Use in6p_zoneid on local link IPv6 addresses in ipsec_setsockaddrs_inpcb().

how did you test this change?

Fri, Mar 20, 12:42 PM · network

Fri, Feb 28

ae added a comment to D23872: fib6_rte_to_nh_*: correctly return a link-local gw address:.

Looks good to me. But I'd wait for @melifaro, there are several places where this KPI is used and I didn't check how it can affect it :)

Fri, Feb 28, 12:18 PM
ae added a comment to D23872: fib6_rte_to_nh_*: correctly return a link-local gw address:.

This code, probably, was written with hope of depreciation of scope embedding into addresses.
If you plan to remove these, please leave the comment that returned address has embedded scope.
Also you will probably want to remove related XXX hack from fast forwarding code.

Fri, Feb 28, 11:41 AM

Feb 25 2020

ae added a comment to D23808: bridge: Move locking defines into if_bridge.c.

It seems some of these macros should be fixed to respect style(9) and use tab instead of space after #define.

Feb 25 2020, 11:20 AM

Feb 19 2020

ae added a comment to D23737: nat64: Get the IPv4 address from a NAT64 address when comparing addresses in a ICMP translate.

Also, how did test your changes? :)
NAT64 currently is not widely used, thus changes here can break something and you will know about breakage when it will be not so easy to fix, e.g. after release.

Feb 19 2020, 11:28 AM · network
ae added a comment to D23737: nat64: Get the IPv4 address from a NAT64 address when comparing addresses in a ICMP translate.

Here, I also compare the destination addresses. Is this what you want?

Feb 19 2020, 11:26 AM · network

Feb 18 2020

ae requested changes to D23737: nat64: Get the IPv4 address from a NAT64 address when comparing addresses in a ICMP translate.

The patch is not correct. IPv4 address can be embedded in different places depending from configuration.

Feb 18 2020, 8:15 AM · network

Feb 10 2020

ae accepted D23599: Add missing EPOCH(9) wrapper in ipfw.
Feb 10 2020, 10:26 AM

Feb 3 2020

ae added a reviewer for D23468: Property-based filters for syslogd: eugen_grosbein.net.
Feb 3 2020, 8:34 AM

Jan 23 2020

ae added a reviewer for D21812: ipfw(8): When checking for IPv4 in add_src() and add_dat(), don't assume !IPv6 is IPv4: melifaro.
Jan 23 2020, 12:10 PM

Dec 26 2019

ae committed rS356093: MFC r355650:.
MFC r355650:
Dec 26 2019, 6:05 PM

Dec 23 2019

ae committed rS356036: MFC r355712:.
MFC r355712:
Dec 23 2019, 10:06 AM
ae committed rS356035: MFC r355712:.
MFC r355712:
Dec 23 2019, 10:03 AM

Dec 18 2019

ae added a comment to D22865: Remove dead code from in6_rmx.c.

I meant this thread: https://lists.freebsd.org/pipermail/freebsd-net/2019-October/054632.html

Dec 18 2019, 11:44 AM
ae accepted D22865: Remove dead code from in6_rmx.c.

We removed this code two years ago, since it adds big penalty for routers where are tens of thousands IPv6 routes.
However, someone in the mail list recently complained that we have not a method for route expiring, probably we can rework this code to implement such feature.

Dec 18 2019, 11:36 AM

Dec 17 2019

ae committed rS355851: MFC r355581:.
MFC r355581:
Dec 17 2019, 10:26 AM
ae committed rS355850: MFC r350413:.
MFC r350413:
Dec 17 2019, 10:23 AM
ae committed rS355849: MFC r355581:.
MFC r355581:
Dec 17 2019, 10:00 AM
ae committed rS355848: MFC r350413:.
MFC r350413:
Dec 17 2019, 9:46 AM

Dec 13 2019

ae closed D22749: Make TCP options parsing stricter.

Commited in rS355712.

Dec 13 2019, 11:49 AM
ae committed rS355712: Make TCP options parsing stricter..
Make TCP options parsing stricter.
Dec 13 2019, 11:48 AM

Dec 12 2019

ae committed rS355650: Follow RFC 4443 p2.2 and always use own addresses for reflected ICMPv6.
Follow RFC 4443 p2.2 and always use own addresses for reflected ICMPv6
Dec 12 2019, 1:29 PM
ae closed D22631: Use IPv6 SAS algorithm for reflected ICMPv6 datagrams in NAT64.
Dec 12 2019, 1:29 PM

Dec 10 2019

ae updated the diff for D22631: Use IPv6 SAS algorithm for reflected ICMPv6 datagrams in NAT64.

Update the patch.

Dec 10 2019, 1:19 PM
ae created D22749: Make TCP options parsing stricter.
Dec 10 2019, 12:43 PM
ae committed rS355581: Avoid access to stale ip pointer and call UPDATE_POINTERS() after.
Avoid access to stale ip pointer and call UPDATE_POINTERS() after
Dec 10 2019, 10:35 AM

Dec 8 2019

ae committed rS355529: MFC r355129:.
MFC r355129:
Dec 8 2019, 3:24 PM
ae committed rS355528: MFC r355129:.
MFC r355129:
Dec 8 2019, 3:22 PM

Dec 6 2019

ae added a reviewer for D22691: ifnet: drain+halt ioctl/vmove operations on detach: avg.
Dec 6 2019, 6:50 AM

Dec 2 2019

ae created D22631: Use IPv6 SAS algorithm for reflected ICMPv6 datagrams in NAT64.
Dec 2 2019, 11:39 AM
ae added inline comments to D22445: Add ESP TFC padding support.
Dec 2 2019, 8:15 AM

Nov 27 2019

ae committed rS355129: Add support for dummy ESP packets with next header field equal to.
Add support for dummy ESP packets with next header field equal to
Nov 27 2019, 10:25 AM
ae closed D22557: Add ESP dummy frames support.
Nov 27 2019, 10:24 AM
ae accepted D22557: Add ESP dummy frames support.
Nov 27 2019, 12:45 AM

Nov 26 2019

ae added inline comments to D22557: Add ESP dummy frames support.
Nov 26 2019, 3:51 PM
ae committed rS355105: MFC r354858:.
MFC r354858:
Nov 26 2019, 2:50 AM

Nov 22 2019

ae accepted D22370: Trigger soft lifetime expiration on sequence number.
Nov 22 2019, 1:42 PM
ae added a comment to D22370: Trigger soft lifetime expiration on sequence number.

Since replay field is optional, I think you need add the check that it is not NULL.

Nov 22 2019, 4:20 AM

Nov 19 2019

ae committed rS354858: Fix the byte order of IPv4 address parsed from begemotSnmpdTransInetStatus.
Fix the byte order of IPv4 address parsed from begemotSnmpdTransInetStatus
Nov 19 2019, 4:30 PM

Nov 18 2019

ae accepted D22366: Add SADB_SAFLAGS_ESN flag.

I think there is no need in such comment.

Nov 18 2019, 11:53 AM
ae accepted D22427: bsnmp: Fix operator precedence in error check in table_check_response.

LGTM.

Nov 18 2019, 11:46 AM

Nov 14 2019

ae accepted D22334: netinet6: Remove PULLDOWN_TESTs..
Nov 14 2019, 1:54 PM
ae committed rS354706: MFC r354443:.
MFC r354443:
Nov 14 2019, 12:15 PM
ae committed rS354705: MFC r354443:.
MFC r354443:
Nov 14 2019, 12:08 PM

Nov 13 2019

ae added a comment to D22334: netinet6: Remove PULLDOWN_TESTs..

The most of code that uses m_pullup() does check first, that the call is needed. Do you think that now it is considered as light enough, to do not check this?

Nov 13 2019, 10:32 AM

Nov 7 2019

ae committed rS354443: Enqueue lladdr_task to update link level address of vlan, when its parent.
Enqueue lladdr_task to update link level address of vlan, when its parent
Nov 7 2019, 3:01 PM
ae closed D22243: Schedule link address update when vlan's parent interface is changed.
Nov 7 2019, 3:01 PM

Nov 6 2019

ae updated the diff for D22243: Schedule link address update when vlan's parent interface is changed.

Make address copying also conditional for consistency.
Add comment describing the goal of condition.

Nov 6 2019, 9:29 AM

Nov 5 2019

ae added a comment to D22243: Schedule link address update when vlan's parent interface is changed.

If copying the LL addr is happening every time a parent interface is added (bcopy) , why not schedule the update too unconditionally?
It will only happen on changing the parent interface anyway.

Nov 5 2019, 4:53 PM
ae updated the summary of D22243: Schedule link address update when vlan's parent interface is changed.
Nov 5 2019, 4:07 PM
ae created D22243: Schedule link address update when vlan's parent interface is changed.
Nov 5 2019, 4:07 PM

Oct 21 2019

ae committed rS353797: MFC r353545:.
MFC r353545:
Oct 21 2019, 2:34 PM

Oct 18 2019

ae committed rS353723: MFC r353545:.
MFC r353545:
Oct 18 2019, 9:09 AM

Oct 15 2019

ae committed rS353545: Explicitly initialize the memory buffer to store O_ICMP6TYPE opcode..
Explicitly initialize the memory buffer to store O_ICMP6TYPE opcode.
Oct 15 2019, 9:50 AM

Oct 1 2019

ae added a comment to D21853: Check for ipv6_zoneid in tcp_hc_lookup() alongside inc6_faddr.

I'm agree with the change, but I have doubts that we have fixed all places in the kernel, where zone id is checked and properly initialized. Usually we keep zone id embedded in the address. Do you have some tests to check this code?

Oct 1 2019, 1:11 PM

Aug 26 2019

ae committed rS351507: MFC r351214:.
MFC r351214:
Aug 26 2019, 9:29 AM

Aug 23 2019

ae committed rS351420: MFC r350974:.
MFC r350974:
Aug 23 2019, 10:12 AM
ae committed rS351419: MFC r350974:.
MFC r350974:
Aug 23 2019, 10:11 AM

Aug 22 2019

ae committed rS351387: MFC r351071:.
MFC r351071:
Aug 22 2019, 8:49 AM
ae committed rS351386: MFC r351071:.
MFC r351071:
Aug 22 2019, 8:47 AM

Aug 19 2019

ae committed rS351214: Use TAILQ_FOREACH_SAFE() macro to avoid use after free in soclose()..
Use TAILQ_FOREACH_SAFE() macro to avoid use after free in soclose().
Aug 19 2019, 12:42 PM
ae added reviewers for D21306: Document IPFW's in-kernel NAT: eugen_grosbein.net, lev.
Aug 19 2019, 12:13 PM

Aug 16 2019

ae committed rS351117: MFC r350816:.
MFC r350816:
Aug 16 2019, 12:28 PM
ae committed rS351116: MFC r350816:.
MFC r350816:
Aug 16 2019, 12:27 PM

Aug 15 2019

ae committed rS351071: Fix rule truncation on external action module unloading..
Fix rule truncation on external action module unloading.
Aug 15 2019, 1:44 PM

Aug 13 2019

ae committed rS350974: Save ip_ttl value and restore it after checksum calculation..
Save ip_ttl value and restore it after checksum calculation.
Aug 13 2019, 12:48 PM

Aug 11 2019

ae added a comment to D21209: Wrap a vlan's parent's if_output in a separate function..

If you know that the problem occurs only with BPF, bpfwrite() invokes if_output() already in epoch section.

Aug 11 2019, 9:45 AM

Aug 9 2019

ae committed rS350816: Add missing new line in several log messages..
Add missing new line in several log messages.
Aug 9 2019, 8:58 AM

Aug 5 2019

ae committed rS350583: MFC r350417:.
MFC r350417:
Aug 5 2019, 7:50 AM
ae committed rS350582: MFC r350417:.
MFC r350417:
Aug 5 2019, 7:49 AM

Aug 2 2019

D21128: ipfw: fix jail option is now accepted and ready to land.
Aug 2 2019, 8:32 AM

Jul 29 2019

ae committed rS350417: dd ipfw_get_action() function to get the pointer to action opcode..
dd ipfw_get_action() function to get the pointer to action opcode.
Jul 29 2019, 3:09 PM
ae committed rS350413: Avoid possible lock leaking..
Avoid possible lock leaking.
Jul 29 2019, 12:56 PM
ae added a comment to D21086: pf: Remove partial RFC2675 support.

Does this mean that you concluded in the IETF mailing list to drop this support?

Jul 29 2019, 10:21 AM

Jul 23 2019

ae committed rS350240: Eliminate rmlock from ipfw's BPF code..
Eliminate rmlock from ipfw's BPF code.
Jul 23 2019, 12:53 PM

Jul 19 2019

ae committed rS350138: MFC r349940:.
MFC r349940:
Jul 19 2019, 3:24 PM
ae committed rS350137: MFC r349940:.
MFC r349940:
Jul 19 2019, 3:18 PM

Jul 12 2019

ae added inline comments to D20936: Fix a race in udp6_output.
Jul 12 2019, 1:46 PM
ae committed rS349941: Do not modify cmd pointer if it is already last opcode in the rule..
Do not modify cmd pointer if it is already last opcode in the rule.
Jul 12 2019, 9:59 AM
ae committed rS349940: Correctly truncate the rule in case when it has several action opcodes..
Correctly truncate the rule in case when it has several action opcodes.
Jul 12 2019, 9:48 AM
ae added inline comments to D20936: Fix a race in udp6_output.
Jul 12 2019, 9:40 AM
ae added inline comments to D20936: Fix a race in udp6_output.
Jul 12 2019, 9:37 AM

Jul 7 2019

ae added a comment to D20868: epair: Fix shutdown race.

What happens ifp->if_softc will become NULL just after this 'if (sc == NULL)' check? It looks like epair_remove_ifp_from_draining(ifp) also uses if_softc field.

Jul 7 2019, 10:57 AM

Jul 3 2019

ae committed rS349648: MFC r349366:.
MFC r349366:
Jul 3 2019, 9:52 AM
ae committed rS349647: MFC r349365:.
MFC r349365:
Jul 3 2019, 9:49 AM
ae committed rS349646: MFC r349364:.
MFC r349364:
Jul 3 2019, 9:48 AM
ae committed rS349644: MFC r349366:.
MFC r349366:
Jul 3 2019, 9:46 AM
ae committed rS349643: MFC r349365:.
MFC r349365:
Jul 3 2019, 9:45 AM
ae committed rS349642: MFC r349364:.
MFC r349364:
Jul 3 2019, 9:43 AM

Jul 1 2019

ae committed rS349575: MFC r348235:.
MFC r348235:
Jul 1 2019, 10:16 AM
ae committed rS349574: MFC r348774:.
MFC r348774:
Jul 1 2019, 10:09 AM
ae committed rS349573: MFC r349267:.
MFC r349267:
Jul 1 2019, 10:03 AM
ae committed rS349572: MFC r349267:.
MFC r349267:
Jul 1 2019, 10:01 AM

Jun 26 2019

ae committed rS349429: Merge from stable/11:.
Merge from stable/11:
Jun 26 2019, 5:21 PM
ae committed rS349411: Fix the uninitialized use of source IPv6 address in NAT64LSN..
Fix the uninitialized use of source IPv6 address in NAT64LSN.
Jun 26 2019, 12:27 PM

Jun 25 2019

ae committed rS349366: Follow the RFC 3128 and drop short TCP fragments with offset = 1..
Follow the RFC 3128 and drop short TCP fragments with offset = 1.
Jun 25 2019, 11:40 AM