Page MenuHomeFreeBSD

ae (Andrey V. Elsukov)
User

Projects

User Details

User Since
Jun 4 2014, 7:25 AM (345 w, 5 d)

Recent Activity

Today

ae added reviewers for D28200: Set MAC to broadcast when pinging 255.255.255.255 as noted in RFC919: tuexen, bz.
Mon, Jan 18, 1:55 PM
ae added a comment to D28200: Set MAC to broadcast when pinging 255.255.255.255 as noted in RFC919.

We already have IP_SENDONES flag for ip_output, that should serve for this purpose. Maybe is it not safe enough to allow this feature for all protocols?

Mon, Jan 18, 1:54 PM

Sat, Jan 16

ae added a comment to D28160: netipsec: Fix handling of unmapped mbufs.

I think the patch in D28187 is better. You need to release reference to SP when error occurs before ipsec4_process_packet().

Sat, Jan 16, 11:54 AM
ae added a comment to D28187: Convert unmapped mbufs before computing checksums in IPsec..

It seems part of this is already in D28160

Sat, Jan 16, 11:28 AM

Dec 13 2020

ae committed R9:54777b84dc86: - Add myself to authors.ent (authored by ae).
- Add myself to authors.ent
Dec 13 2020, 5:45 PM
ae committed R9:a14af1ca1caa: - Add myself to developers.sgml (authored by ae).
- Add myself to developers.sgml
Dec 13 2020, 5:32 PM

Nov 18 2020

ae committed rS367790: MFC r367594:.
MFC r367594:
Nov 18 2020, 2:05 PM

Nov 16 2020

ae added a comment to D27213: Fix dtrace symbol resolution in the face of bitfields.

It seems I found how to reproduce it on test system:

  1. Load systemt without any unneeded modules
  2. kldload dtraceall
  3. Run
# dtrace -n 'fbt::ip_input:entry { printf("%s", stringof(args[0]->m_pkthdr.rcvif->if_xname)); }'
dtrace: description 'fbt::ip_input:entry ' matched 1 probe
CPU     ID                    FUNCTION:NAME
  2  49220                   ip_input:entry ix0
  2  49220                   ip_input:entry ix0
  6  49220                   ip_input:entry ix0
^C
# kldunload dtraceall
# kldload ipfw
# kldload dtraceall
# dtrace -n 'fbt::ip_input:entry { printf("%s", stringof(args[0]->m_pkthdr.rcvif->if_xname)); }'
dtrace: invalid probe specifier fbt::ip_input:entry { printf("%s", stringof(args[0]->m_pkthdr.rcvif->if_xname)); }: in action list: m_pkthdr is not a member of struct mbuf
Nov 16 2020, 6:58 PM
ae added a comment to D27213: Fix dtrace symbol resolution in the face of bitfields.

Recently I faced with this problem on some machines:

# dtrace -n 'fbt::ip_input:entry { printf("%s", stringof(args[0]->m_pkthdr.rcvif->if_xname)); }'
dtrace: invalid probe specifier fbt::ip_input:entry { printf("%s", stringof(args[0]->m_pkthdr.rcvif->if_xname)); }: in action list: m_pkthdr is not a member of struct mbuf
Nov 16 2020, 12:53 PM
ae added inline comments to D27221: ipfw(8): Improve divert, forward and addr descriptions.
Nov 16 2020, 10:41 AM

Nov 13 2020

ae added inline comments to D27166: Add redirects to the fast forwarding path.
Nov 13 2020, 9:13 AM

Nov 12 2020

ae added inline comments to D27166: Add redirects to the fast forwarding path.
Nov 12 2020, 12:51 PM

Nov 11 2020

ae committed rS367594: Fix possible NULL pointer dereference..
Fix possible NULL pointer dereference.
Nov 11 2020, 6:56 PM

Nov 10 2020

ae committed rS367554: MFC r366695:.
MFC r366695:
Nov 10 2020, 12:46 PM
ae committed rS367553: MFC r366908 (modified for stable/12 KBI):.
MFC r366908 (modified for stable/12 KBI):
Nov 10 2020, 12:13 PM

Oct 29 2020

ae accepted D26611: Add a macro to check for IPv6 multicast MAC addresses.
Oct 29 2020, 4:05 PM

Oct 21 2020

ae closed D26879: Add ipfw SDT probe..
Oct 21 2020, 3:02 PM
ae committed rS366908: Add dtrace SDT probe ipfw:::rule-matched..
Add dtrace SDT probe ipfw:::rule-matched.
Oct 21 2020, 3:02 PM
ae added a comment to D26879: Add ipfw SDT probe..
In D26879#599390, @gnn wrote:

I like the idea of this change but I believe that a new file should be created in netpfil/ipfw to contain the code that's been put into in_kdtrace.[ch] in this review.

Oct 21 2020, 2:31 PM
ae updated the diff for D26879: Add ipfw SDT probe..

Move provider and probe definitions into ipfw2.c

Oct 21 2020, 2:29 PM

Oct 20 2020

ae added reviewers for D26879: Add ipfw SDT probe.: network, glebius.
Oct 20 2020, 3:26 PM
ae added a comment to D26879: Add ipfw SDT probe..
In D26879#599390, @gnn wrote:

I like the idea of this change but I believe that a new file should be created in netpfil/ipfw to contain the code that's been put into in_kdtrace.[ch] in this review.

Oct 20 2020, 3:22 PM
ae added a reviewer for D26879: Add ipfw SDT probe.: melifaro.
Oct 20 2020, 3:12 PM
ae updated the summary of D26879: Add ipfw SDT probe..
Oct 20 2020, 3:12 PM
ae requested review of D26879: Add ipfw SDT probe..
Oct 20 2020, 2:42 PM
ae committed rS366894: MFC 366682:.
MFC 366682:
Oct 20 2020, 11:50 AM
ae committed rS366893: MFC r366682:.
MFC r366682:
Oct 20 2020, 11:45 AM
ae committed rS366892: MFC r366681:.
MFC r366681:
Oct 20 2020, 11:41 AM

Oct 17 2020

ae accepted D26827: Fix sleepq_add panic happening with too wide net epoch..
Oct 17 2020, 5:01 PM
ae added a comment to D26523: Enable multipath for outbound connections.

LGTM. However it would be nice, if you consider my comments :)

Oct 17 2020, 3:17 PM
ae added a comment to D26827: Fix sleepq_add panic happening with too wide net epoch..

It seems the only solution here is taking ifnet reference. I'm not sure about PCB, probably it can not disappear here.

Oct 17 2020, 12:34 PM

Oct 16 2020

ae committed rS366747: MFC r366568:.
MFC r366568:
Oct 16 2020, 8:56 AM

Oct 14 2020

ae closed D26636: Implement SIOCGIFALIAS.
Oct 14 2020, 9:23 AM
ae committed rS366695: Implement SIOCGIFALIAS..
Implement SIOCGIFALIAS.
Oct 14 2020, 9:23 AM

Oct 13 2020

ae closed D26757: Fix to join AllHost mcast group again when adding an existing IP address.
Oct 13 2020, 7:35 PM
ae committed rS366682: Join to AllHosts multicast group again when adding an existing IPv4 address..
Join to AllHosts multicast group again when adding an existing IPv4 address.
Oct 13 2020, 7:34 PM
ae closed D26758: Add IPv4 fragments reassembling to NAT64LSN.
Oct 13 2020, 6:58 PM
ae committed rS366681: Add IPv4 fragments reassembling to NAT64LSN..
Add IPv4 fragments reassembling to NAT64LSN.
Oct 13 2020, 6:57 PM
ae added reviewers for D26758: Add IPv4 fragments reassembling to NAT64LSN: network, melifaro.
Oct 13 2020, 10:35 AM
ae requested review of D26758: Add IPv4 fragments reassembling to NAT64LSN.
Oct 13 2020, 10:33 AM
ae accepted D26757: Fix to join AllHost mcast group again when adding an existing IP address.

Looks correct to me.

Oct 13 2020, 8:41 AM

Oct 12 2020

ae added a comment to D26719: setkey(8): Improve directions descriptions.

The code refers what you named "processing actions" as "policy levels". Take a look at netipsec/ipsec.h

Oct 12 2020, 7:09 AM

Oct 9 2020

ae added inline comments to D26523: Enable multipath for outbound connections.
Oct 9 2020, 12:01 PM
ae committed rS366568: Fix EINVAL message when CPU binding information is requested for IRQ..
Fix EINVAL message when CPU binding information is requested for IRQ.
Oct 9 2020, 11:24 AM

Oct 8 2020

ae accepted D26636: Implement SIOCGIFALIAS.
Oct 8 2020, 9:38 PM
ae added inline comments to D26636: Implement SIOCGIFALIAS.
Oct 8 2020, 4:27 PM

Oct 5 2020

ae added a comment to D26672: [RFC] Implement sticky SO_REUSEPORT_LB socket option.

Yes. But I don't think the patch is heavy. Lets try to look from a different point.
SO_REUSEPORT_LB was introduced in D11003 with several fixes later, it has the same purpose - extend scalability of user space programs, that was used for example by DNS server.
The kernel should provide useful features for applications. Your app can use simple sockets API to send data, but also it can use more productive sendfile(2) syscall, etc.
OpenVPN is free opensource application that is widely used and supports different OSes. When all employee in your company are going work remotely, you can buy some hardware and thousands of licenses or can just use relatively small patch. This patch helps to extend scalability of OpenVPN for us, but it can be used for another apps that we don't use. I'm not forcing to commit it into base system, just share our experience and ask for comments.

Oct 5 2020, 5:54 PM
ae published D26672: [RFC] Implement sticky SO_REUSEPORT_LB socket option for review.
Oct 5 2020, 2:10 PM
ae added inline comments to D26636: Implement SIOCGIFALIAS.
Oct 5 2020, 10:36 AM

Oct 2 2020

ae added a comment to D26636: Implement SIOCGIFALIAS.

I think IF_ADDR_WLOCK() is not required for this ioctl. It is enough to use NET_EPOCH_ENTER().

Oct 2 2020, 1:21 PM

Sep 23 2020

ae added a comment to D26523: Enable multipath for outbound connections.

It seems you missed hash calculation for udp[6]_output(), when socket isn't connected and destination address is specified by caller.

Sep 23 2020, 1:38 PM

Sep 15 2020

ae committed rS365746: MFC r365449:.
MFC r365449:
Sep 15 2020, 8:54 AM
ae committed rS365745: MFC r365449:.
MFC r365449:
Sep 15 2020, 8:53 AM

Sep 11 2020

ae added a comment to D26358: ipfw: fix compatibility with frag and older rule sets.

Committed as rS365628.

Sep 11 2020, 10:15 AM
ae committed rS365628: Fix compatibility regression after r364117..
Fix compatibility regression after r364117.
Sep 11 2020, 10:07 AM

Sep 10 2020

ae added a comment to D26358: ipfw: fix compatibility with frag and older rule sets.

I think this patch is too complicated. Can you properly test this patch instead? https://people.freebsd.org/~ae/ipfw_frag.diff

Sep 10 2020, 10:09 AM

Sep 8 2020

ae closed D25389: Add loop visualization and parallel execution support into rcorder.
Sep 8 2020, 10:36 AM
ae committed rS365449: Add a few features to rcorder:.
Add a few features to rcorder:
Sep 8 2020, 10:36 AM

Aug 12 2020

ae committed rS364163: MFC r363906:.
MFC r363906:
Aug 12 2020, 12:12 PM
ae committed rS364162: MFC r363888:.
MFC r363888:
Aug 12 2020, 12:08 PM
ae committed rS364161: MFC r363900:.
MFC r363900:
Aug 12 2020, 12:07 PM
ae committed rS364160: MFC r363904:.
MFC r363904:
Aug 12 2020, 12:06 PM
ae committed rS364159: MFC r363906:.
MFC r363906:
Aug 12 2020, 11:49 AM
ae committed rS364158: MFC r363888:.
MFC r363888:
Aug 12 2020, 11:48 AM
ae committed rS364157: MFC r363900:.
MFC r363900:
Aug 12 2020, 11:43 AM
ae committed rS364156: MFC r363904:.
MFC r363904:
Aug 12 2020, 11:43 AM

Aug 11 2020

ae accepted D26021: ipfw: improve matching on IPv4 fragments.

LGTM.

Aug 11 2020, 9:13 AM

Aug 5 2020

ae committed rS363908: Synchronize definitions in mbuf.d with values from mbuf.h.
Synchronize definitions in mbuf.d with values from mbuf.h
Aug 5 2020, 11:54 AM
ae committed rS363906: Add m__getjcl SDT probe..
Add m__getjcl SDT probe.
Aug 5 2020, 11:39 AM
ae closed D25734: ipfw nat64 improve prefix length checks.
Aug 5 2020, 11:27 AM
ae committed rS363904: Fix SIGSEGV in ipfw(8) when NAT64 prefix length is omitted..
Fix SIGSEGV in ipfw(8) when NAT64 prefix length is omitted.
Aug 5 2020, 11:27 AM
ae closed D25932: net.inet6.icmp6.nodeinfo typo fix.
Aug 5 2020, 10:27 AM
ae committed rS363900: Fix typo..
Fix typo.
Aug 5 2020, 10:27 AM
ae committed rS363888: Handle delayed checksums if needed in NAT64..
Handle delayed checksums if needed in NAT64.
Aug 5 2020, 9:16 AM

Aug 3 2020

ae added a comment to D25789: NAT64: compute checksum for locally generated packets.

I sent a more generic patch in the reply to your email a week ago, can you check your spam folder and test it?

Aug 3 2020, 8:39 AM

Jul 30 2020

ae accepted D25887: ip6_output(): Check the return value of in6_getlinkifnet()..

LGTM.

Jul 30 2020, 7:45 AM

Jul 27 2020

ae added a comment to D25789: NAT64: compute checksum for locally generated packets.

I think it should be possible solve the problem without introducing extra configuration parameter. I'll take a look.

Jul 27 2020, 8:02 AM

Jul 13 2020

ae accepted D25456: ipfw(8): Fix most warnings with the default WARNS level..

LGTM.

Jul 13 2020, 7:07 AM

Jun 25 2020

ae accepted D25444: Enter and exit the network epoch for async IPsec callbacks..

LGTM.

Jun 25 2020, 10:25 AM
ae added inline comments to D25445: Complete the fib<4|6>_lookup_nh_<basic|ext> -> fib<4|6>_lookup() transition.
Jun 25 2020, 6:41 AM · network

Jun 10 2020

ae committed rS362009: MFC r361749:.
MFC r361749:
Jun 10 2020, 1:06 PM

Jun 9 2020

ae added inline comments to D25192: Add rib_action() and make rtsock use it..
Jun 9 2020, 9:49 AM

Jun 5 2020

ae committed rS361832: MFC r361624:.
MFC r361624:
Jun 5 2020, 9:59 AM
ae committed rS361831: MFC r361624:.
MFC r361624:
Jun 5 2020, 9:57 AM

Jun 3 2020

ae committed rS361749: Add if_reassing method to all tunneling interfaces..
Add if_reassing method to all tunneling interfaces.
Jun 3 2020, 1:02 PM

Jun 1 2020

ae added a comment to D24989: netinet: Generate a random RSS key on boot..
In D24989#552576, @avg wrote:

I have a vague memory, maybe wrong, that commonly used fixed RSS keys were selected because they had some property (-ies).
So, maybe just being random is not good enough?
I think that hypothetical rss_isbadkey was mentioned for a reason?

Jun 1 2020, 11:44 AM · csprng, network
ae accepted D25067: add new rib manipulation functions..

LGTM.

Jun 1 2020, 8:47 AM
ae added a comment to D25070: Add rib subscription API..

How many subscribers do you expect? I think you will replace some existing. Maybe it would be better to have separate list for each subscription type?

Jun 1 2020, 8:07 AM

May 29 2020

ae added a comment to D25029: Introduce ifconfig -a -[gG] groupname.

You can just use another option name to specify excludes.

May 29 2020, 12:49 PM
ae committed rS361624: Fix O_IP_FLOW_LOOKUP opcode handling..
Fix O_IP_FLOW_LOOKUP opcode handling.
May 29 2020, 10:38 AM

May 26 2020

ae accepted D24978: Switch gif(4) path verification to use fib[46]_check_urfp().
May 26 2020, 10:48 AM

May 25 2020

ae accepted D24976: Switch ip_output/icmp_reflect rt lookup calls with fib4_lookup..
May 25 2020, 8:46 AM
ae accepted D24973: Replace fib6_lookup_nh_<ext|basic> calls with fib6_lookup..
May 25 2020, 8:37 AM

May 22 2020

ae added a comment to D24939: geom(4): Kill GEOM_PART_EBR_COMPAT option.

I have no objection against this. Just one test case to test - create several EBR partitions (e.g. s5, s6, s7), then remove one from the middle (i.e. s6), then create two smaller in this free space (and then optionally reboot, and see what we will have after reboot).

May 22 2020, 2:04 PM
ae added a reviewer for D24939: geom(4): Kill GEOM_PART_EBR_COMPAT option: marcel.
May 22 2020, 12:21 PM

May 20 2020

ae added a comment to D22444: Add UDP encapsulation of ESP in IPv6.

I'll try to test this and commit with small modifications after weekend. Thanks!

May 20 2020, 11:28 AM

May 14 2020

ae added a reviewer for D22444: Add UDP encapsulation of ESP in IPv6: network.
May 14 2020, 11:38 AM
ae added inline comments to D22444: Add UDP encapsulation of ESP in IPv6.
May 14 2020, 11:38 AM

May 6 2020

ae added a comment to D24669: Embed dest sockaddr into rtentry and remove counter.

It seems rt_pktsent is already unused in head/, thus its removal is reasonable. According to your calculations for offsets, this change can give some performance boost, and I'll try to measure it in the lab, but I'm not sure this will happen very soon. Also maybe is it worth to add some explicit alignment requirements to rtentry structure or some of its fields? We can use __aligned(CACHE_LINE_SIZE)

May 6 2020, 2:30 PM
ae added a comment to D24724: Hide forward messages in nd6log().

I also agree that these messages should be removed. But moving them to nd6 debugging seems wrong.

May 6 2020, 9:18 AM