Page MenuHomeFreeBSD

inpcb: Factor out parts of in6_pcbbind() and in_pcbbind_setup()
ClosedPublic

Authored by markj on Nov 15 2024, 3:55 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 2, 10:06 PM
Unknown Object (File)
Tue, Sep 23, 9:53 AM
Unknown Object (File)
Wed, Sep 17, 4:18 AM
Unknown Object (File)
Sep 10 2025, 2:12 AM
Unknown Object (File)
Sep 7 2025, 8:34 PM
Unknown Object (File)
Sep 7 2025, 7:31 PM
Unknown Object (File)
Aug 31 2025, 3:45 PM
Unknown Object (File)
Aug 26 2025, 6:18 PM
Subscribers

Details

Summary

A large portion of these functions just determines whether the inpcb can
bind to the address/port. This portion has no side effects, so is a
good candidate to move into its own helper function. This patch does
so, making the callers less complicated and reducing indentation.

While moving this code, also make some changes:

  • Load socket options (SO_REUSEADDR etc.) only once. There is nothing preventing another thread from toggling the socket options, so make this function easier to reason about by avoiding races.
  • When checking whether the bind address is an interface address, make a separate sockaddr rather than temporarily modifying the one passed to in_pcbbind().

No functional change intended.

Sponsored by: Klara, Inc.
Sponsored by: Stormshield

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable