Page MenuHomeFreeBSD

melifaro (Alexander V. Chernikov)
User

Projects

User Details

User Since
May 27 2014, 9:32 AM (382 w, 13 h)

Recent Activity

Mon, Sep 13

melifaro added a comment to D31903: dummynet: Does not depend on ipfw.
In D31903#720341, @kp wrote:

May this cause an unwanted effect on automatic module loading?
So may somebody depend on this dependency in the local setup?

Yes, that's a concern. Especially for merging it back to stable/13 and stable/12.
I'm planning to MFC pf/dummynet , but perhaps users in 12 and 13 are just going to have to live with the dummynet module autoloading ipfw. It's something to think about.

With default to deny it might be not exactly the desired outcome. Do you think that a separate module w/ dummynet-for-pf (for 12/13) is too much of a hassle? Especially given ae@‘s plan to change dummynet for ipfw?

Mon, Sep 13, 12:09 PM

Fri, Sep 10

melifaro accepted D31861: Change lowest address on subnet (host 0) not to broadcast by default..
Fri, Sep 10, 8:33 PM

Thu, Sep 9

melifaro accepted D31889: net: Enter a net epoch around protocol if_up/down notifications.
Thu, Sep 9, 9:01 PM

Tue, Sep 7

melifaro closed D31868: routing: fix source address selection rules for IPv4 over IPv6..
Tue, Sep 7, 9:44 PM
melifaro committed R10:4b631fc832ac: routing: fix source address selection rules for IPv4 over IPv6. (authored by melifaro).
routing: fix source address selection rules for IPv4 over IPv6.
Tue, Sep 7, 9:44 PM
melifaro committed R10:e8df60a69a0e: routing: Allow using IPv6 next-hops for IPv4 routes (RFC 5549). (authored by zlei.huang_gmail.com).
routing: Allow using IPv6 next-hops for IPv4 routes (RFC 5549).
Tue, Sep 7, 9:31 PM
melifaro committed R10:f3d69003374a: routing: Bring back the ability to specify transmit interface via its name. (authored by melifaro).
routing: Bring back the ability to specify transmit interface via its name.
Tue, Sep 7, 9:31 PM
melifaro committed R10:0e77fc2a79ed: routing: Fix newly-added rt_get_inet[6]_parent() api. (authored by melifaro).
routing: Fix newly-added rt_get_inet[6]_parent() api.
Tue, Sep 7, 9:15 PM
melifaro committed R10:8c73907c66a7: routing: simplify malloc flags in alloc_nhgrp(). (authored by melifaro).
routing: simplify malloc flags in alloc_nhgrp().
Tue, Sep 7, 9:15 PM
melifaro committed R10:e86f5d4fcba8: routing: Disallow zero nexthop weights in nexthop groups. (authored by melifaro).
routing: Disallow zero nexthop weights in nexthop groups.
Tue, Sep 7, 9:15 PM
melifaro committed R10:48f38f47b105: lltable: Add support for "child" LLEs holding encap for IPv4oIPv6 entries. (authored by melifaro).
lltable: Add support for "child" LLEs holding encap for IPv4oIPv6 entries.
Tue, Sep 7, 9:15 PM
melifaro committed R10:4e97cbba1c79: lltable: fix crash introduced in c541bd368f86. (authored by melifaro).
lltable: fix crash introduced in c541bd368f86.
Tue, Sep 7, 9:15 PM
melifaro committed R10:5007bc4e1390: routing: Fix crashes with dpdk_lpm[46] algo. (authored by melifaro).
routing: Fix crashes with dpdk_lpm[46] algo.
Tue, Sep 7, 9:15 PM
melifaro committed R10:b17ecfd3a7e7: routing: add IPv6 fib validation procedure. (authored by melifaro).
routing: add IPv6 fib validation procedure.
Tue, Sep 7, 9:15 PM
melifaro committed R10:5b35ba2be36d: routing: Use process fib instead of fib 0 when conducting tests. (authored by melifaro).
routing: Use process fib instead of fib 0 when conducting tests.
Tue, Sep 7, 9:15 PM
melifaro committed R10:10e097610309: Simplify nhop operations in ip_output(). (authored by melifaro).
Simplify nhop operations in ip_output().
Tue, Sep 7, 9:15 PM
melifaro committed R10:4151d8ccdc64: [lltable] Restructure nd6 code. (authored by melifaro).
[lltable] Restructure nd6 code.
Tue, Sep 7, 9:15 PM
melifaro committed R10:0ea561762ba5: Use lltable calculated header when sending lle holdchain after successful lle… (authored by melifaro).
Use lltable calculated header when sending lle holdchain after successful lle…
Tue, Sep 7, 9:15 PM
melifaro committed R10:280201438072: [lltable] Unify datapath feedback mechamism. (authored by melifaro).
[lltable] Unify datapath feedback mechamism.
Tue, Sep 7, 9:15 PM
melifaro committed R10:0f7162e0cd46: Fix typo in rib_unsibscribe<_locked>(). (authored by melifaro).
Fix typo in rib_unsibscribe<_locked>().
Tue, Sep 7, 9:15 PM
melifaro committed R10:36854c4e1e86: [netflow] fix gateway reporting in ng_netflow (authored by melifaro).
[netflow] fix gateway reporting in ng_netflow
Tue, Sep 7, 9:15 PM
melifaro committed R10:a27813e1301d: Enforce check for using the return result for ifa?_try_ref(). (authored by melifaro).
Enforce check for using the return result for ifa?_try_ref().
Tue, Sep 7, 9:14 PM
melifaro committed R10:311cf25c240b: Simplify ifa/ifp refcounting in the routing stack. (authored by melifaro).
Simplify ifa/ifp refcounting in the routing stack.
Tue, Sep 7, 9:14 PM
melifaro committed R10:efa8c43ed6b5: Rename variables inside nexhtop group consider_resize() code. (authored by melifaro).
Rename variables inside nexhtop group consider_resize() code.
Tue, Sep 7, 9:14 PM
melifaro committed R10:04e967d7270e: Add if_try_ref() to simplify refcount handling inside epoch. (authored by melifaro).
Add if_try_ref() to simplify refcount handling inside epoch.
Tue, Sep 7, 9:14 PM
melifaro added a comment to D31871: Fix 802.1ad handling bug in input processing of ethernet frames..

Could you describe the actual problem with ng_vlan? Without the problem statement, it's not exactly clear what can/should be done here.
This diff breaks QinQ processing, so it doesn't look like a path forward.

Tue, Sep 7, 8:51 PM

Mon, Sep 6

melifaro added a reviewer for D31868: routing: fix source address selection rules for IPv4 over IPv6.: zlei.huang_gmail.com.
Mon, Sep 6, 10:38 PM
melifaro updated the test plan for D31868: routing: fix source address selection rules for IPv4 over IPv6..
Mon, Sep 6, 10:38 PM
melifaro requested review of D31868: routing: fix source address selection rules for IPv4 over IPv6..
Mon, Sep 6, 10:29 PM
melifaro closed D31824: lltable: do not require prefix lookup when checking lle allocation rules..
Mon, Sep 6, 9:27 PM
melifaro committed R10:936f4a42fa2a: lltable: do not require prefix lookup when checking lle allocation rules. (authored by melifaro).
lltable: do not require prefix lookup when checking lle allocation rules.
Mon, Sep 6, 9:27 PM

Fri, Sep 3

melifaro updated the summary of D31824: lltable: do not require prefix lookup when checking lle allocation rules..
Fri, Sep 3, 12:36 PM
melifaro requested review of D31824: lltable: do not require prefix lookup when checking lle allocation rules..
Fri, Sep 3, 12:25 PM

Thu, Sep 2

melifaro accepted D31785: DTrace ipfw: Follow struct ip_fw field change.
Thu, Sep 2, 1:26 PM

Wed, Sep 1

melifaro added inline comments to D31770: ipsec: If no PMTU in hostcache assume it's equal to link's MTU.
Wed, Sep 1, 10:39 PM
melifaro committed R10:0a3a377aee9b: routing: Disallow zero nexthop weights in nexthop groups. (authored by melifaro).
routing: Disallow zero nexthop weights in nexthop groups.
Wed, Sep 1, 7:20 AM

Tue, Aug 31

melifaro committed R10:639d7abec6cd: routing: simplify malloc flags in alloc_nhgrp(). (authored by melifaro).
routing: simplify malloc flags in alloc_nhgrp().
Tue, Aug 31, 8:15 AM

Mon, Aug 30

melifaro committed R10:f84c30106e8b: routing: Fix newly-added rt_get_inet[6]_parent() api. (authored by melifaro).
routing: Fix newly-added rt_get_inet[6]_parent() api.
Mon, Aug 30, 9:14 PM

Sun, Aug 29

melifaro committed R10:d98954e22981: routing: Bring back the ability to specify transmit interface via its name. (authored by melifaro).
routing: Bring back the ability to specify transmit interface via its name.
Sun, Aug 29, 8:14 PM

Thu, Aug 26

melifaro accepted D31680: Fix NAT64 direct output..
Thu, Aug 26, 9:46 AM

Aug 22 2021

melifaro committed R10:62e1a437f328: routing: Allow using IPv6 next-hops for IPv4 routes (RFC 5549). (authored by zlei.huang_gmail.com).
routing: Allow using IPv6 next-hops for IPv4 routes (RFC 5549).
Aug 22 2021, 10:59 PM
melifaro closed D30398: Route IPv4 packets via IPv6 next-hops.
Aug 22 2021, 10:59 PM · network
melifaro added a comment to D31630: Correct nh_family.

I'd rather not touch it now - there is something WIP that will change this part of the code anyway.

Aug 22 2021, 3:34 PM · network
melifaro committed R10:f8c1b1a92966: lltable: fix crash introduced in c541bd368f86. (authored by melifaro).
lltable: fix crash introduced in c541bd368f86.
Aug 22 2021, 8:50 AM

Aug 21 2021

melifaro added a comment to D31630: Correct nh_family.

It's a bit more complex than that.
For the interface routes (e.g. ones w/o the gateway), you may end up with AF_LINK family in RTAX_GATEWAY.
So, you need to check if RTF_GATEWAY is set prior to using RTAX_GATEWAY.

Aug 21 2021, 6:33 PM · network
melifaro committed R10:c541bd368f86: lltable: Add support for "child" LLEs holding encap for IPv4oIPv6 entries. (authored by melifaro).
lltable: Add support for "child" LLEs holding encap for IPv4oIPv6 entries.
Aug 21 2021, 5:35 PM
melifaro closed D31379: [lltable] Add support for "child" LLEs holding encap for IPv4oIPv6 entries..
Aug 21 2021, 5:35 PM

Aug 20 2021

melifaro added a reviewer for D31379: [lltable] Add support for "child" LLEs holding encap for IPv4oIPv6 entries.: network.
Aug 20 2021, 10:38 PM
melifaro accepted D30398: Route IPv4 packets via IPv6 next-hops.
Aug 20 2021, 9:39 PM · network
melifaro added reviewers for D30398: Route IPv4 packets via IPv6 next-hops: network, ae, olivier, hselasky.
Aug 20 2021, 9:38 PM · network
melifaro added a comment to D30398: Route IPv4 packets via IPv6 next-hops.

Also: will you write a commit message, or do you prefer me doing it?

Aug 20 2021, 8:09 AM · network
melifaro added a comment to D30398: Route IPv4 packets via IPv6 next-hops.

You also need to add a bit of family wrapping logic inside fill_nhop_from_info(), so we get a proper family for the nexthop.

Aug 20 2021, 8:07 AM · network

Aug 19 2021

melifaro updated the summary of D31379: [lltable] Add support for "child" LLEs holding encap for IPv4oIPv6 entries..
Aug 19 2021, 10:42 PM
melifaro updated the summary of D31379: [lltable] Add support for "child" LLEs holding encap for IPv4oIPv6 entries..
Aug 19 2021, 10:39 PM
melifaro updated the diff for D31379: [lltable] Add support for "child" LLEs holding encap for IPv4oIPv6 entries..

.

Aug 19 2021, 10:22 PM
melifaro updated the diff for D31379: [lltable] Add support for "child" LLEs holding encap for IPv4oIPv6 entries..

.

Aug 19 2021, 10:21 PM

Aug 18 2021

melifaro updated the diff for D31595: Route IPv4 packets via IPv6 next-hops - D30398 variation..

Update diff to reflect underlying changes.

Aug 18 2021, 8:32 AM
melifaro updated the diff for D31379: [lltable] Add support for "child" LLEs holding encap for IPv4oIPv6 entries..

Fix missed AF_INET6 in nd6_resolve_slow().

Aug 18 2021, 8:25 AM
melifaro added a comment to D30398: Route IPv4 packets via IPv6 next-hops.

@melifaro Sorry for late response ;)

I removed the LLE part, it should be easy to apply D31379 .

It should be the other way round :-) e.g. D31379 is a pre-requisite.
Could you try to apply it first, build on top and test?

Aug 18 2021, 8:19 AM · network
melifaro added inline comments to D30398: Route IPv4 packets via IPv6 next-hops.
Aug 18 2021, 8:18 AM · network
melifaro accepted D31584: gre: simplify RSS ifdefs.
Aug 18 2021, 7:57 AM
melifaro added inline comments to D30398: Route IPv4 packets via IPv6 next-hops.
Aug 18 2021, 7:56 AM · network
melifaro added inline comments to D30398: Route IPv4 packets via IPv6 next-hops.
Aug 18 2021, 7:51 AM · network

Aug 17 2021

melifaro edited reviewers for D31595: Route IPv4 packets via IPv6 next-hops - D30398 variation., added: olivier; removed: cy.
Aug 17 2021, 10:58 PM
melifaro updated the summary of D31595: Route IPv4 packets via IPv6 next-hops - D30398 variation..
Aug 17 2021, 10:58 PM
melifaro updated the summary of D31595: Route IPv4 packets via IPv6 next-hops - D30398 variation..
Aug 17 2021, 10:55 PM
melifaro requested review of D31595: Route IPv4 packets via IPv6 next-hops - D30398 variation..
Aug 17 2021, 10:53 PM
melifaro updated the diff for D31379: [lltable] Add support for "child" LLEs holding encap for IPv4oIPv6 entries..

.

Aug 17 2021, 9:51 PM
melifaro committed R10:406a4b37a24e: [multipath][nhops] Fix random crashes with high route churn rate. (authored by melifaro).
[multipath][nhops] Fix random crashes with high route churn rate.
Aug 17 2021, 9:15 PM
melifaro committed R10:36e15b717eec: routing: Fix crashes with dpdk_lpm[46] algo. (authored by melifaro).
routing: Fix crashes with dpdk_lpm[46] algo.
Aug 17 2021, 9:12 PM
melifaro closed D31546: routing: Fix crashes with dpdk_lpm algo..
Aug 17 2021, 9:12 PM
melifaro added inline comments to D31584: gre: simplify RSS ifdefs.
Aug 17 2021, 11:20 AM

Aug 16 2021

melifaro committed R10:cbfba56c45ab: routing: add IPv6 fib validation procedure. (authored by melifaro).
routing: add IPv6 fib validation procedure.
Aug 16 2021, 11:09 PM
melifaro updated the diff for D31546: routing: Fix crashes with dpdk_lpm algo..

.

Aug 16 2021, 8:53 PM

Aug 15 2021

melifaro added reviewers for D31546: routing: Fix crashes with dpdk_lpm algo.: network, ae.
Aug 15 2021, 10:39 PM
melifaro requested review of D31546: routing: Fix crashes with dpdk_lpm algo..
Aug 15 2021, 10:38 PM
melifaro committed R10:4a77a9b64910: routing: Use process fib instead of fib 0 when conducting tests. (authored by melifaro).
routing: Use process fib instead of fib 0 when conducting tests.
Aug 15 2021, 10:24 PM

Aug 13 2021

melifaro accepted D31484: Fix data race in jump cache read/update.
Aug 13 2021, 10:35 AM
melifaro added a comment to D31484: Fix data race in jump cache read/update.

Generally LGTM, please see a comment on the code structure above.

Aug 13 2021, 8:20 AM

Aug 10 2021

melifaro added inline comments to D31484: Fix data race in jump cache read/update.
Aug 10 2021, 8:23 AM

Aug 8 2021

melifaro added inline comments to D30398: Route IPv4 packets via IPv6 next-hops.
Aug 8 2021, 9:43 AM · network
melifaro closed D31451: Simplify nhop operations in ip_output()..
Aug 8 2021, 9:22 AM
melifaro committed R10:9748eb742791: Simplify nhop operations in ip_output(). (authored by melifaro).
Simplify nhop operations in ip_output().
Aug 8 2021, 9:21 AM

Aug 7 2021

melifaro added a comment to D31455: Introduce m_get3().

Q: why can’t we extend m_get2 to not fail for 9..16k packets?

Aug 7 2021, 8:27 PM
melifaro updated the summary of D31451: Simplify nhop operations in ip_output()..
Aug 7 2021, 11:25 AM
melifaro requested review of D31451: Simplify nhop operations in ip_output()..
Aug 7 2021, 11:24 AM
melifaro added inline comments to D30398: Route IPv4 packets via IPv6 next-hops.
Aug 7 2021, 11:05 AM · network
melifaro committed R10:0b79b007ebfc: [lltable] Restructure nd6 code. (authored by melifaro).
[lltable] Restructure nd6 code.
Aug 7 2021, 10:07 AM
melifaro closed D31432: [lltable] Restructure nd6 code.
Aug 7 2021, 10:06 AM

Aug 6 2021

melifaro added a comment to D30398: Route IPv4 packets via IPv6 next-hops.

I've updated the aforementioned D31379 to reflect the committed parts.
If you could update this review to use the new functionality (e.g. nd6_resolve() returning lle with the proper encap) , that would be awesome.

Aug 6 2021, 11:12 PM · network
melifaro updated the diff for D31379: [lltable] Add support for "child" LLEs holding encap for IPv4oIPv6 entries..

.

Aug 6 2021, 11:08 PM
melifaro updated the diff for D31379: [lltable] Add support for "child" LLEs holding encap for IPv4oIPv6 entries..

.

Aug 6 2021, 10:32 PM
melifaro accepted D31420: Fix panic in IPv6 multicast code.
Aug 6 2021, 9:43 AM
melifaro retitled D31432: [lltable] Restructure nd6 code from Restructure nd6 code to [lltable] Restructure nd6 code.
Aug 6 2021, 8:34 AM
melifaro updated the summary of D31432: [lltable] Restructure nd6 code.
Aug 6 2021, 8:31 AM
melifaro requested review of D31432: [lltable] Restructure nd6 code.
Aug 6 2021, 8:27 AM
melifaro added inline comments to D31379: [lltable] Add support for "child" LLEs holding encap for IPv4oIPv6 entries..
Aug 6 2021, 6:57 AM

Aug 5 2021

melifaro committed R10:8482aa77481a: Use lltable calculated header when sending lle holdchain after successful lle… (authored by melifaro).
Use lltable calculated header when sending lle holdchain after successful lle…
Aug 5 2021, 8:46 PM
melifaro closed D31391: [lltable] Use lltable calculated header when sending lle holdchain after successful lle resolution..
Aug 5 2021, 8:45 PM
melifaro updated the diff for D31391: [lltable] Use lltable calculated header when sending lle holdchain after successful lle resolution..

.

Aug 5 2021, 9:20 AM