- User Since
- May 27 2014, 9:32 AM (382 w, 13 h)
Mon, Sep 13
With default to deny it might be not exactly the desired outcome. Do you think that a separate module w/ dummynet-for-pf (for 12/13) is too much of a hassle? Especially given ae@‘s plan to change dummynet for ipfw?
Fri, Sep 10
Thu, Sep 9
Tue, Sep 7
Could you describe the actual problem with ng_vlan? Without the problem statement, it's not exactly clear what can/should be done here.
This diff breaks QinQ processing, so it doesn't look like a path forward.
Mon, Sep 6
Fri, Sep 3
Thu, Sep 2
Wed, Sep 1
Tue, Aug 31
Mon, Aug 30
Sun, Aug 29
Thu, Aug 26
Aug 22 2021
I'd rather not touch it now - there is something WIP that will change this part of the code anyway.
Aug 21 2021
It's a bit more complex than that.
For the interface routes (e.g. ones w/o the gateway), you may end up with AF_LINK family in RTAX_GATEWAY.
So, you need to check if RTF_GATEWAY is set prior to using RTAX_GATEWAY.
Aug 20 2021
Also: will you write a commit message, or do you prefer me doing it?
You also need to add a bit of family wrapping logic inside fill_nhop_from_info(), so we get a proper family for the nexthop.
Aug 19 2021
Aug 18 2021
Update diff to reflect underlying changes.
Fix missed AF_INET6 in nd6_resolve_slow().
It should be the other way round :-) e.g. D31379 is a pre-requisite.
Could you try to apply it first, build on top and test?
Aug 17 2021
Aug 16 2021
Aug 15 2021
Aug 13 2021
Generally LGTM, please see a comment on the code structure above.
Aug 10 2021
Aug 8 2021
Aug 7 2021
Q: why can’t we extend m_get2 to not fail for 9..16k packets?
Aug 6 2021
I've updated the aforementioned D31379 to reflect the committed parts.
If you could update this review to use the new functionality (e.g. nd6_resolve() returning lle with the proper encap) , that would be awesome.