Page MenuHomeFreeBSD

melifaro (Alexander V. Chernikov)
User

Projects

User Details

User Since
May 27 2014, 9:32 AM (319 w, 5 d)

Recent Activity

Today

melifaro closed D25615: Switch inet6 default route subscription to the new rib subscription api..
Sun, Jul 12, 11:24 AM
melifaro committed rS363128: Switch inet6 default route subscription to the new rib subscription api..
Switch inet6 default route subscription to the new rib subscription api.
Sun, Jul 12, 11:24 AM
melifaro closed D25614: Add destructor for the rib subscription system to simplify users code..
Sun, Jul 12, 11:18 AM
melifaro committed rS363127: Add destructor for the rib subscription system to simplify users code..
Add destructor for the rib subscription system to simplify users code.
Sun, Jul 12, 11:18 AM
melifaro accepted D25619: Don't print VNET pointer when starting up.
Sun, Jul 12, 11:02 AM

Yesterday

melifaro updated the diff for D25615: Switch inet6 default route subscription to the new rib subscription api..

Add forgotten in6_rmx.c

Sat, Jul 11, 11:34 AM
melifaro retitled D25615: Switch inet6 default route subscription to the new rib subscription api. from <<Replace this line with your revision title> Switch inet6 default route subscription to the new rib subscription api. to Switch inet6 default route subscription to the new rib subscription api..
Sat, Jul 11, 10:52 AM
melifaro requested review of D25615: Switch inet6 default route subscription to the new rib subscription api..
Sat, Jul 11, 10:49 AM
melifaro updated the summary of D25614: Add destructor for the rib subscription system to simplify users code..
Sat, Jul 11, 10:07 AM
melifaro requested review of D25614: Add destructor for the rib subscription system to simplify users code..
Sat, Jul 11, 10:01 AM

Mon, Jul 6

melifaro accepted D25535: Introduce nhop_ref_locked_object()..
Mon, Jul 6, 8:48 PM
melifaro added a comment to D25535: Introduce nhop_ref_locked_object()..

Introduce nhop_try_ref_object() instead.

I note that we also have nhop_ref_any() and nhop_free_any() as well,
but they are unused.

That's the route multipath part, which will be introduced soon.

Mon, Jul 6, 8:43 PM
melifaro added a comment to D25567: PR247718 - incorrectly drops IPv6 packets looping back on p2p interface.

Let's wait half a week to make sure we all agree on this one :-)

Mon, Jul 6, 8:42 PM
melifaro added a comment to D25567: PR247718 - incorrectly drops IPv6 packets looping back on p2p interface.

@bz: any objects on removal of this one?

Mon, Jul 6, 7:43 AM
melifaro added a reviewer for D25567: PR247718 - incorrectly drops IPv6 packets looping back on p2p interface: bz.
Mon, Jul 6, 7:42 AM
melifaro accepted D25567: PR247718 - incorrectly drops IPv6 packets looping back on p2p interface.

I don't believe we need specific processing here either.

  1. Kernel shouldn't try to be "smart" and decide whether user-configured routing is correct or not. It can't fix the issue anyway.
  2. Even when the route configuration is incorrect, TTL will still kick in
Mon, Jul 6, 7:42 AM

Sat, Jul 4

melifaro added a comment to D23461: netgraph: Add RFC 6598/Carrier Grade NAT support to ng_nat.

Can you please add "TESTING" section?

Sat, Jul 4, 8:36 AM · network

Fri, Jul 3

melifaro committed rS362909: Fix IPv6 regression introduced by r362900..
Fix IPv6 regression introduced by r362900.
Fri, Jul 3, 8:06 AM

Thu, Jul 2

melifaro closed D25445: Complete the fib<4|6>_lookup_nh_<basic|ext> -> fib<4|6>_lookup() transition.
Thu, Jul 2, 9:04 PM · network
melifaro committed rS362900: Complete conversions from fib<4|6>_lookup_nh_<basic|ext> to fib<4|6>_lookup()..
Complete conversions from fib<4|6>_lookup_nh_<basic|ext> to fib<4|6>_lookup().
Thu, Jul 2, 9:04 PM
melifaro added a comment to D25535: Introduce nhop_ref_locked_object()..

Thank you for raising this diff! Was going to do the same, but you managed to do it faster :-)
LGTM, please see the naming comment :-)

Thu, Jul 2, 7:32 AM

Wed, Jul 1

melifaro accepted D25312: Relax the rule against declaring variables in nested scopes..
Wed, Jul 1, 9:34 PM

Tue, Jun 30

melifaro accepted D25445: Complete the fib<4|6>_lookup_nh_<basic|ext> -> fib<4|6>_lookup() transition.

There are still some things outstanding ( epoch entry in multicast code and probably a couple other ones ), but generally looks good.
Thank you for working on this!
I'll commit the change tomorrow.

Tue, Jun 30, 10:18 PM · network
melifaro accepted D25519: ip_forward(): Fix a possible next-hop refcount leak..

Re nhop_ref_object(): indeed, in many cases we acquire refcount under radix read or write lock, which implies that some routes are pointing to that nhop -> it has non-zero count.
In some corner cases we want to do it without holding radix lock and in that scenario we need to check whether we were able to acquire reference or not.

Tue, Jun 30, 9:44 PM

Mon, Jun 29

melifaro added a comment to D25494: libifconfig: Add functionality for querying SFP modules.

Also: thank you for working on this! Access to to all of the sfp attributes in structured form is a long-waited stuff.

Mon, Jun 29, 8:27 AM
melifaro added inline comments to D25445: Complete the fib<4|6>_lookup_nh_<basic|ext> -> fib<4|6>_lookup() transition.
Mon, Jun 29, 8:06 AM · network
melifaro added a comment to D25494: libifconfig: Add functionality for querying SFP modules.

What is the plan of switching ifconfig to use it? SFF standards are evolving, the code is not trivial, we regularly need to update either defines or the actual code. Also, I guess QSFP-DD / OSFP might require separate handling. I'd really prefer not to have 2 different kind of headers and 2 code implementations for that in base.

Mon, Jun 29, 7:57 AM

Sun, Jun 28

melifaro accepted D25460: libifconfig: Add function to get bridge status.
Sun, Jun 28, 5:26 PM
melifaro accepted D25460: libifconfig: Add function to get bridge status.

Thanks for making the changes!
LGTM.

Sun, Jun 28, 3:58 PM
melifaro added a comment to D25460: libifconfig: Add function to get bridge status.

Thank you for adding the bridge support!
Please see some minor comments inline.

Sun, Jun 28, 12:26 PM
melifaro added inline comments to D25460: libifconfig: Add function to get bridge status.
Sun, Jun 28, 11:54 AM
melifaro added a comment to D25181: Introduce net.inet6.icmp6.reply_from_interface and net.inet6.icmp6.reply_src sysctls.

Unfortunately, I was unable to get test cases working. For some reason ICMP does not work in Kyua VNET jails. This is also why the other IPv6 forward/redirect tests fail as well.

Do they fail on your setup?
Can you share the logs of failing forwarding/redirect tests?

This could just be my dev box (AMD Ryzen-based HP "Omen" desktop) running 13-CURRENT.

My (failing test is here: https://gist.github.com/neelchauhan/e830f9cab71f79c81a258b8bdbc295d4

Ipv6 stack on the interface does not become available immediatelt, as the LL addresses have to go through TENTATIVE state. Other tests typically include test&sleep cycle after address assignment to address it.

These sysctls do work, when testing via a bhyve VM.

Sun, Jun 28, 8:37 AM

Sat, Jun 27

melifaro added a comment to D25181: Introduce net.inet6.icmp6.reply_from_interface and net.inet6.icmp6.reply_src sysctls.

Generally LGTM, I'd be happy to commit it once there are some tests.

Sat, Jun 27, 9:35 PM
melifaro added inline comments to D25445: Complete the fib<4|6>_lookup_nh_<basic|ext> -> fib<4|6>_lookup() transition.
Sat, Jun 27, 6:12 PM · network
melifaro added a comment to D25181: Introduce net.inet6.icmp6.reply_from_interface and net.inet6.icmp6.reply_src sysctls.

Generally looks like a nice feature to have.
Would it be possible to add tests validating this behaviour?

Sat, Jun 27, 6:11 PM
melifaro accepted D25389: Add loop visualization and parallel execution support into rcorder.

LGTM.

Sat, Jun 27, 5:54 PM

Thu, Jun 25

melifaro added a comment to D25445: Complete the fib<4|6>_lookup_nh_<basic|ext> -> fib<4|6>_lookup() transition.

Also: maybe worth splitting the review in 2-3 smaller ones to speedup the process?

Thu, Jun 25, 9:19 PM · network
melifaro added a reviewer for D25445: Complete the fib<4|6>_lookup_nh_<basic|ext> -> fib<4|6>_lookup() transition: network.
Thu, Jun 25, 9:17 PM · network
melifaro added inline comments to D25445: Complete the fib<4|6>_lookup_nh_<basic|ext> -> fib<4|6>_lookup() transition.
Thu, Jun 25, 8:31 AM · network

Mon, Jun 22

melifaro added a comment to D25389: Add loop visualization and parallel execution support into rcorder.

LGTM, please see some comments inline.

Mon, Jun 22, 7:33 PM
melifaro closed D24975: Switch cxgbe interface lookup to use fibX_lookup() from older fibX_lookup_nh_ext()..
Mon, Jun 22, 7:35 AM
melifaro committed rS362487: Switch cxgbe interface lookup to use fibX_lookup() from older.
Switch cxgbe interface lookup to use fibX_lookup() from older
Mon, Jun 22, 7:35 AM
melifaro added a comment to D25325: Fix panic induced by ndp -P.

Any chance a test can be added to verify the desired behaviour? IT shouldn't be too hard, there are multiple examples of tests creating 2 vnet jails for the simular purposes in netinet6/.

Mon, Jun 22, 7:16 AM
melifaro added inline comments to D25389: Add loop visualization and parallel execution support into rcorder.
Mon, Jun 22, 12:01 AM

Sun, Jun 21

melifaro accepted D25348: net.link.generic.ifdata.<ifindex>.linkspecific: rework handler.
Sun, Jun 21, 5:51 PM

Wed, Jun 17

melifaro accepted D25312: Relax the rule against declaring variables in nested scopes..

awesome to have some of style(9) rules reviewed and relaxed!

Wed, Jun 17, 6:54 AM

Sun, Jun 14

melifaro added a comment to D24975: Switch cxgbe interface lookup to use fibX_lookup() from older fibX_lookup_nh_ext()..
In D24975#555169, @np wrote:

I will try this and let you know how it went by June 10.

That would be awesome!

Sun, Jun 14, 8:16 AM

Jun 10 2020

melifaro closed D25192: Add rib_action() and make rtsock use it..
Jun 10 2020, 7:46 AM
melifaro committed rS362007: Switch rtsock code to using newly-create rib_action() KPI call..
Switch rtsock code to using newly-create rib_action() KPI call.
Jun 10 2020, 7:46 AM

Jun 8 2020

melifaro updated the diff for D25192: Add rib_action() and make rtsock use it..

Make field order consistent across rib* functions.

Jun 8 2020, 8:37 PM
melifaro updated the summary of D25192: Add rib_action() and make rtsock use it..
Jun 8 2020, 8:06 PM
melifaro requested review of D25192: Add rib_action() and make rtsock use it..
Jun 8 2020, 8:00 PM

Jun 1 2020

melifaro committed rS361708: Add rib subscription API..
Add rib subscription API.
Jun 1 2020, 9:52 PM
melifaro closed D25070: Add rib subscription API..
Jun 1 2020, 9:52 PM
melifaro committed rS361707: Finish r361706: add sys/net/route/route_ctl.h, missed in previous commit..
Finish r361706: add sys/net/route/route_ctl.h, missed in previous commit.
Jun 1 2020, 9:51 PM
melifaro committed rS361706: * Add rib_<add|del|change>_route() functions to manipulate the routing table..
* Add rib_<add|del|change>_route() functions to manipulate the routing table.
Jun 1 2020, 8:49 PM
melifaro committed rS361705: Revert r361704, it accidentally committed merged D25067 and D25070..
Revert r361704, it accidentally committed merged D25067 and D25070.
Jun 1 2020, 8:41 PM
melifaro closed D25067: add new rib manipulation functions..
Jun 1 2020, 8:32 PM
melifaro committed rS361704: * Add rib_<add|del|change>_route() functions to manipulate the routing table..
* Add rib_<add|del|change>_route() functions to manipulate the routing table.
Jun 1 2020, 8:32 PM
melifaro accepted D25084: bridge tests: Avoid building a switching loop.

Minor nit: any chance jails a and b can be named bridge_stp_a and bridge_stp_b to avoid potential clashes with other tests?

Jun 1 2020, 3:51 PM
melifaro updated the diff for D24600: Use newly-created accessor function for reading rt prefix in ipfw..

Export IPv6 addresses in "normal" form.

Jun 1 2020, 10:31 AM
melifaro added a comment to D25070: Add rib subscription API..
In D25070#552529, @ae wrote:

How many subscribers do you expect? I think you will replace some existing. Maybe it would be better to have separate list for each subscription type?

Currently there is only one - ND6 default route checker. With the modular lookup engine, there will be 1 more for rtables where lookup engine is attached.
With that in mind, idea is to start with the simplest implementation and then enhance it if/when needed.

Jun 1 2020, 8:11 AM

May 31 2020

melifaro updated the diff for D25070: Add rib subscription API..

Add forgottech epoch reclamation.

May 31 2020, 7:40 AM

May 30 2020

melifaro updated the summary of D25070: Add rib subscription API..
May 30 2020, 2:56 PM
melifaro updated the summary of D25070: Add rib subscription API..
May 30 2020, 2:55 PM
melifaro requested review of D25070: Add rib subscription API..
May 30 2020, 2:47 PM
melifaro updated the diff for D25067: add new rib manipulation functions..

Fix fields description.

May 30 2020, 2:09 PM
melifaro abandoned D25069: add new rib manipulation functions.

Abandoning, arc created a new revision instead of updating an old one.

May 30 2020, 2:08 PM
melifaro requested review of D25069: add new rib manipulation functions.
May 30 2020, 2:07 PM
melifaro updated the summary of D25067: add new rib manipulation functions..
May 30 2020, 2:03 PM
melifaro requested review of D25067: add new rib manipulation functions..
May 30 2020, 1:26 PM

May 28 2020

melifaro committed rS361584: Fix NOINET6 build broken by r361575..
Fix NOINET6 build broken by r361575.
May 28 2020, 9:55 AM
melifaro closed D24974: Use fib[46]_lookup() in mtu calculations..
May 28 2020, 8:01 AM
melifaro committed rS361576: Use fib[46]_lookup() in mtu calculations..
Use fib[46]_lookup() in mtu calculations.
May 28 2020, 8:01 AM
melifaro closed D24977: Make NFS address selection use fib4_lookup()..
May 28 2020, 7:35 AM
melifaro committed rS361575: Make NFS address selection use fib4_lookup()..
Make NFS address selection use fib4_lookup().
May 28 2020, 7:35 AM
melifaro committed rS361574: Switch ip_output/icmp_reflect rt lookup calls with fib4_lookup..
Switch ip_output/icmp_reflect rt lookup calls with fib4_lookup.
May 28 2020, 7:32 AM
melifaro closed D24976: Switch ip_output/icmp_reflect rt lookup calls with fib4_lookup..
May 28 2020, 7:32 AM
melifaro committed rS361573: Replace ip6_ouput fib6_lookup_nh_<ext|basic> calls with fib6_lookup()..
Replace ip6_ouput fib6_lookup_nh_<ext|basic> calls with fib6_lookup().
May 28 2020, 7:30 AM
melifaro closed D24973: Replace fib6_lookup_nh_<ext|basic> calls with fib6_lookup..
May 28 2020, 7:30 AM
melifaro closed D24978: Switch gif(4) path verification to use fib[46]_check_urfp().
May 28 2020, 7:26 AM
melifaro committed rS361572: Switch gif(4) path verification to fib[46]_check_urfp()..
Switch gif(4) path verification to fib[46]_check_urfp().
May 28 2020, 7:26 AM
melifaro committed rS361571: Unlock rtentry before calling for epoch(9) destruction as the destruction.
Unlock rtentry before calling for epoch(9) destruction as the destruction
May 28 2020, 7:23 AM

May 25 2020

melifaro added a comment to D24991: netinet: make ifa_ifwithaddr() and ifa_ifwithaddr_check() fib-aware.

Can you please fill in the testing section?

May 25 2020, 10:08 PM · network
melifaro added inline comments to D24989: netinet: Generate a random RSS key on boot..
May 25 2020, 10:04 PM · csprng, network

May 23 2020

melifaro committed rS361421: Move <add|del|change>_route() functions to route_ctl.c in preparation of.
Move <add|del|change>_route() functions to route_ctl.c in preparation of
May 23 2020, 7:07 PM
melifaro closed D24870: Move <add|del|change>_route to route_ctl.c.
May 23 2020, 7:07 PM
melifaro requested review of D24978: Switch gif(4) path verification to use fib[46]_check_urfp().
May 23 2020, 5:36 PM
melifaro requested review of D24977: Make NFS address selection use fib4_lookup()..
May 23 2020, 5:12 PM
melifaro retitled D24975: Switch cxgbe interface lookup to use fibX_lookup() from older fibX_lookup_nh_ext(). from Switch cxgbe interface lookup to use fibX_lookup() from older fibX_lookup_nh_ext(). to Switch cxgbe interface lookup to use fibX_lookup() from older fibX_lookup_nh_ext()..
May 23 2020, 2:12 PM
melifaro updated the diff for D24975: Switch cxgbe interface lookup to use fibX_lookup() from older fibX_lookup_nh_ext()..

Include tom changes as well.

May 23 2020, 2:11 PM
melifaro requested review of D24976: Switch ip_output/icmp_reflect rt lookup calls with fib4_lookup..
May 23 2020, 1:38 PM
melifaro requested review of D24975: Switch cxgbe interface lookup to use fibX_lookup() from older fibX_lookup_nh_ext()..
May 23 2020, 1:20 PM
melifaro requested review of D24974: Use fib[46]_lookup() in mtu calculations..
May 23 2020, 1:10 PM
melifaro requested review of D24973: Replace fib6_lookup_nh_<ext|basic> calls with fib6_lookup..
May 23 2020, 1:07 PM
melifaro closed D24867: Remove refcounting from rtentry..
May 23 2020, 12:16 PM
melifaro committed rS361415: Remove refcounting from rtentry..
Remove refcounting from rtentry.
May 23 2020, 12:16 PM
melifaro committed rS361409: Use epoch(9) for rtentries to simplify control plane operations..
Use epoch(9) for rtentries to simplify control plane operations.
May 23 2020, 10:22 AM
melifaro closed D24866: Use epoch(9) for rtentries to simplify control plane operations..
May 23 2020, 10:22 AM

May 22 2020

melifaro accepted D24925: net80211: post RTM_IFINFO notification after toggling IFF_DRV_RUNNING.
May 22 2020, 7:58 AM