Page MenuHomeFreeBSD

melifaro (Alexander V. Chernikov)
User

Projects

User Details

User Since
May 27 2014, 9:32 AM (359 w, 19 h)

Recent Activity

Yesterday

melifaro updated the diff for D29588: [FIB algo] Add support for the batched updates..

Fix case with small number of updates.

Tue, Apr 13, 10:00 PM

Mon, Apr 12

melifaro committed R10:9abc85d17d05: Fix vlan creation for the older ifconfig(8) binaries. (authored by melifaro).
Fix vlan creation for the older ifconfig(8) binaries.
Mon, Apr 12, 10:19 PM
melifaro closed D29704: Fixup formatting for the routing work..
Mon, Apr 12, 8:55 PM
melifaro committed R9:fced49eafc86: Fixup formatting for the routing work. (authored by melifaro).
Fixup formatting for the routing work.
Mon, Apr 12, 8:55 PM
melifaro committed R10:afbb64f1d85b: Fix vlan creation for the older ifconfig(8) binaries. (authored by melifaro).
Fix vlan creation for the older ifconfig(8) binaries.
Mon, Apr 12, 3:49 AM

Sun, Apr 11

melifaro added reviewers for D29704: Fixup formatting for the routing work.: debdrup, gjb.
Sun, Apr 11, 2:01 PM
melifaro requested review of D29704: Fixup formatting for the routing work..
Sun, Apr 11, 2:01 PM

Sat, Apr 10

melifaro committed R10:7f5f3fcc32bf: Fix direct route installation with net/bird. (authored by melifaro).
Fix direct route installation with net/bird.
Sat, Apr 10, 3:54 PM
melifaro committed R10:63dceebe6856: Appease -Wsign-compare in radix.c (authored by melifaro).
Appease -Wsign-compare in radix.c
Sat, Apr 10, 1:51 PM
melifaro closed D29661: Appease -Wsign-compare in radix.c.
Sat, Apr 10, 1:50 PM
melifaro committed R10:caf2f62765f9: Allow to specify debugnet fib in sysctl/tunable. (authored by melifaro).
Allow to specify debugnet fib in sysctl/tunable.
Sat, Apr 10, 1:48 PM
melifaro committed R10:c3a456defaf2: Always use inp fib in the inp_lookup_mcast_ifp(). (authored by melifaro).
Always use inp fib in the inp_lookup_mcast_ifp().
Sat, Apr 10, 1:48 PM
melifaro closed D29593: Allow to specify debugnet fib in sysctl/tunable..
Sat, Apr 10, 1:48 PM
melifaro closed D29594: Always use inp fib in the inp_lookup_mcast_ifp()..
Sat, Apr 10, 1:48 PM
melifaro committed R9:a88e73dd3566: Add routing work description (authored by melifaro).
Add routing work description
Sat, Apr 10, 12:50 PM
melifaro closed D29275: Relnotes/13.0: Add routing work description.
Sat, Apr 10, 12:50 PM
melifaro updated the diff for D29275: Relnotes/13.0: Add routing work description.

Remove rev-named in favor of currently existing macro, as it's too late to change the rest of the release notes.

Sat, Apr 10, 12:38 PM
melifaro added a comment to D29275: Relnotes/13.0: Add routing work description.

.

Sat, Apr 10, 11:58 AM
melifaro updated the diff for D29275: Relnotes/13.0: Add routing work description.

Address comments.

Sat, Apr 10, 11:55 AM

Fri, Apr 9

melifaro updated the diff for D29588: [FIB algo] Add support for the batched updates..

Update to reflect the committed parts, address comments.

Fri, Apr 9, 9:31 PM
melifaro committed R10:ee2cf2b3609e: Implement better rebuild-delay fib algo policy. (authored by melifaro).
Implement better rebuild-delay fib algo policy.
Fri, Apr 9, 8:40 PM
melifaro accepted D29661: Appease -Wsign-compare in radix.c.
Fri, Apr 9, 6:36 PM

Thu, Apr 8

melifaro committed R10:c3254131a4af: Fix fib algo rebuild delay calculation. (authored by melifaro).
Fix fib algo rebuild delay calculation.
Thu, Apr 8, 8:39 PM
melifaro closed D29504: Enforce check for using the return result for ifa?_try_ref()..
Thu, Apr 8, 8:25 PM
melifaro committed R10:9e5243d7b659: Enforce check for using the return result for ifa?_try_ref(). (authored by melifaro).
Enforce check for using the return result for ifa?_try_ref().
Thu, Apr 8, 8:25 PM

Mon, Apr 5

melifaro updated the summary of D29594: Always use inp fib in the inp_lookup_mcast_ifp()..
Mon, Apr 5, 8:04 PM
melifaro updated the diff for D29594: Always use inp fib in the inp_lookup_mcast_ifp()..

update comments.

Mon, Apr 5, 8:00 PM
melifaro requested review of D29594: Always use inp fib in the inp_lookup_mcast_ifp()..
Mon, Apr 5, 7:59 PM
melifaro requested review of D29593: Allow to specify debugnet fib in sysctl/tunable..
Mon, Apr 5, 7:49 PM
melifaro retitled D29592: Use interface fib instead of RT_DEFAULT_FIB in nd6_ns_output(). from Use interface fib in nd6_ns_output(). to Use interface fib instead of RT_DEFAULT_FIB in nd6_ns_output()..
Mon, Apr 5, 7:32 PM
melifaro requested review of D29592: Use interface fib instead of RT_DEFAULT_FIB in nd6_ns_output()..
Mon, Apr 5, 7:28 PM
melifaro retitled D29588: [FIB algo] Add support for the batched updates. from Add support for the batched update. Update delay policy to support both small and large-scale changes.` to [FIB algo] Add support for the batched updates. .
Mon, Apr 5, 5:00 PM
melifaro requested review of D29588: [FIB algo] Add support for the batched updates..
Mon, Apr 5, 4:41 PM

Sun, Apr 4

melifaro accepted D29556: libnv: Allow use in non-sleepable contexts.
Sun, Apr 4, 2:55 PM
melifaro committed R10:1260724822b5: Fix `netstat -rs` reporting. (authored by melifaro).
Fix `netstat -rs` reporting.
Sun, Apr 4, 8:45 AM

Wed, Mar 31

melifaro committed R10:4084b1ab0413: Fix `netstat -rs` reporting. (authored by melifaro).
Fix `netstat -rs` reporting.
Wed, Mar 31, 8:59 PM
melifaro committed R10:0e7f02a1a996: Zero `struct weightened_nhop` fields in nhgrp_get_addition_group(). (authored by melifaro).
Zero `struct weightened_nhop` fields in nhgrp_get_addition_group().
Wed, Mar 31, 8:10 PM
melifaro committed R10:b7fbdb5042c6: Fix nexhtop group index array scaling. (authored by melifaro).
Fix nexhtop group index array scaling.
Wed, Mar 31, 8:10 PM

Tue, Mar 30

melifaro added a reviewer for D29504: Enforce check for using the return result for ifa?_try_ref().: hselasky.
Tue, Mar 30, 10:12 PM
melifaro requested review of D29504: Enforce check for using the return result for ifa?_try_ref()..
Tue, Mar 30, 10:11 PM
melifaro committed R10:b8598e2ff65a: Add IPv4 fib lookup performance tests with uniform keys. (authored by melifaro).
Add IPv4 fib lookup performance tests with uniform keys.
Tue, Mar 30, 9:40 PM
melifaro committed R10:145ca12d22a4: Put bandaid for nhgrp_dump_sysctl() malloc KASSERT(). (authored by melifaro).
Put bandaid for nhgrp_dump_sysctl() malloc KASSERT().
Tue, Mar 30, 8:02 AM
melifaro committed R10:923e7f7e1267: Fix nexhtop group index array scaling. (authored by melifaro).
Fix nexhtop group index array scaling.
Tue, Mar 30, 8:02 AM

Mon, Mar 29

melifaro committed R10:0c2a0e038002: Fix typo in the 9fa8d1582b44b4850d40699c9adb104732328b7d. (authored by melifaro).
Fix typo in the 9fa8d1582b44b4850d40699c9adb104732328b7d.
Mon, Mar 29, 11:44 PM
melifaro committed R10:9fa8d1582b44: Put bandaid for nhgrp_dump_sysctl() malloc KASSERT(). (authored by melifaro).
Put bandaid for nhgrp_dump_sysctl() malloc KASSERT().
Mon, Mar 29, 11:16 PM
melifaro committed R10:9095dc7da4cf: Fix nexhtop group index array scaling. (authored by melifaro).
Fix nexhtop group index array scaling.
Mon, Mar 29, 11:08 PM
melifaro committed R10:0f30a36dedef: Rename variables inside nexhtop group consider_resize() code. (authored by melifaro).
Rename variables inside nexhtop group consider_resize() code.
Mon, Mar 29, 11:08 PM

Sun, Mar 28

melifaro committed R10:411cbdb1f298: Plug nexthop group refcount leak. (authored by melifaro).
Plug nexthop group refcount leak.
Sun, Mar 28, 8:51 PM
melifaro committed R10:3765afa4dacf: Fix panic when destroying interface with ECMP routes. (authored by melifaro).
Fix panic when destroying interface with ECMP routes.
Sun, Mar 28, 8:51 PM
melifaro committed R10:589d5d28a811: Fix kassert panic when inserting multipath routes from multiple threads. (authored by melifaro).
Fix kassert panic when inserting multipath routes from multiple threads.
Sun, Mar 28, 8:51 PM
melifaro committed R10:6f4f8a441aaa: Flush remaining routes from the routing table during VNET shutdown. (authored by melifaro).
Flush remaining routes from the routing table during VNET shutdown.
Sun, Mar 28, 8:51 PM
melifaro committed R10:367fcd5bce34: Fix blackhole/reject routes. (authored by melifaro).
Fix blackhole/reject routes.
Sun, Mar 28, 8:51 PM
melifaro committed R10:823a80f4f903: Zero `struct weightened_nhop` fields in nhgrp_get_addition_group(). (authored by melifaro).
Zero `struct weightened_nhop` fields in nhgrp_get_addition_group().
Sun, Mar 28, 8:42 PM
melifaro accepted D29464: Fix panic when using BOOTP to resolve root path..
Sun, Mar 28, 1:00 AM · network, PowerPC

Sat, Mar 27

melifaro committed R10:6f43c72b472e: Zero `struct weightened_nhop` fields in nhgrp_get_addition_group(). (authored by melifaro).
Zero `struct weightened_nhop` fields in nhgrp_get_addition_group().
Sat, Mar 27, 9:18 AM

Thu, Mar 25

melifaro committed R10:af85312e8a6f: Fix panic when destroying interface with ECMP routes. (authored by melifaro).
Fix panic when destroying interface with ECMP routes.
Thu, Mar 25, 8:27 PM
melifaro committed R10:47c00a983592: Plug nexthop group refcount leak. (authored by melifaro).
Plug nexthop group refcount leak.
Thu, Mar 25, 8:27 PM
melifaro committed R10:42f997d9b721: Fix kassert panic when inserting multipath routes from multiple threads. (authored by melifaro).
Fix kassert panic when inserting multipath routes from multiple threads.
Thu, Mar 25, 8:27 PM
melifaro committed R10:24cd2796cf10: Fix !VNET build broken by 66f138563becf12d5c21924f816d2a45c3a1ed7a. (authored by melifaro).
Fix !VNET build broken by 66f138563becf12d5c21924f816d2a45c3a1ed7a.
Thu, Mar 25, 12:32 AM

Wed, Mar 24

melifaro committed R10:66f138563bec: Plug nexthop group refcount leak. (authored by melifaro).
Plug nexthop group refcount leak.
Wed, Mar 24, 11:53 PM

Tue, Mar 23

melifaro committed R10:c00e2f573b50: Fix build for non-vnet non-multipath kernels broken by (authored by melifaro).
Fix build for non-vnet non-multipath kernels broken by
Tue, Mar 23, 11:37 PM
melifaro committed R10:a0308e48ec12: Fix panic when destroying interface with ECMP routes. (authored by melifaro).
Fix panic when destroying interface with ECMP routes.
Tue, Mar 23, 10:13 PM

Sun, Mar 21

melifaro accepted D29320: Add log() style versions of device_printf() and if_printf().

That's a nice addition we should long have.
Please see some minor comments inside.

Sun, Mar 21, 6:52 PM
melifaro committed R10:2476178e6b09: Fix kassert panic when inserting multipath routes from multiple threads. (authored by melifaro).
Fix kassert panic when inserting multipath routes from multiple threads.
Sun, Mar 21, 6:18 PM

Wed, Mar 17

melifaro added a comment to D28886: Update rtsock_l3 test after 2fe5a79425c79f7b828acd91da66d97230925fc8.

Sorry for the belated reply, will look into it today/tomorrow

Wed, Mar 17, 12:08 PM

Mon, Mar 15

melifaro committed R10:e4ac3f746377: Fix fib algo rebuild delay calculation. (authored by melifaro).
Fix fib algo rebuild delay calculation.
Mon, Mar 15, 9:26 PM
melifaro added inline comments to D29275: Relnotes/13.0: Add routing work description.
Mon, Mar 15, 8:58 PM
melifaro retitled D29275: Relnotes/13.0: Add routing work description from Add routing work description to Relnotes/13.0: Add routing work description.
Mon, Mar 15, 8:41 PM
melifaro updated the diff for D29275: Relnotes/13.0: Add routing work description.

.

Mon, Mar 15, 8:41 PM
melifaro requested review of D29275: Relnotes/13.0: Add routing work description.
Mon, Mar 15, 8:39 PM

Mar 13 2021

melifaro committed R10:8aafa7a02763: Flush remaining routes from the routing table during VNET shutdown. (authored by melifaro).
Flush remaining routes from the routing table during VNET shutdown.
Mar 13 2021, 8:26 PM
melifaro committed R10:d81b3bb4b19d: Fix various NOINET* builds broken by 145bf6c0af48. (authored by melifaro).
Fix various NOINET* builds broken by 145bf6c0af48.
Mar 13 2021, 8:26 PM
melifaro committed R10:3489286a5f36: Fix blackhole/reject routes. (authored by melifaro).
Fix blackhole/reject routes.
Mar 13 2021, 8:26 PM

Mar 11 2021

melifaro committed R10:d4803b958cff: Fix 'in6_purgeaddr: err=65, destination address delete failed' message. (authored by melifaro).
Fix 'in6_purgeaddr: err=65, destination address delete failed' message.
Mar 11 2021, 9:45 PM
melifaro committed R10:83cedad13972: Fix 'in6_purgeaddr: err=65, destination address delete failed' message. (authored by melifaro).
Fix 'in6_purgeaddr: err=65, destination address delete failed' message.
Mar 11 2021, 8:37 AM
melifaro added a comment to D29190: pf: Simplify cleanup.
In D29190#653711, @kp wrote:

Can counter ptr really be NULL is these cases? If yes, I'd rather retain the existing checks as they indicate that this a valid possibility.

It can happen, but really only if we fail to allocate memory (see line 520-521).

Also, counter(9) man page says nothing about the free(NULL) use case.

Until D29189 it couldn't handle that. This commit builds on top of that.

Yep :-) What I'm saying is that the man page should also be updated to reflect the code changes.

Mar 11 2021, 8:30 AM
melifaro committed R10:2d227a6ec371: Fix dst/netmask handling in routing socket code. (authored by melifaro).
Fix dst/netmask handling in routing socket code.
Mar 11 2021, 8:27 AM
melifaro committed R10:19fdc2029768: Fix dpdk/ldradix fib lookup algorithm preference calculation. (authored by melifaro).
Fix dpdk/ldradix fib lookup algorithm preference calculation.
Mar 11 2021, 8:27 AM
melifaro committed R10:dba80ca2cfb0: Make in_localip_more() fib-aware. (authored by melifaro).
Make in_localip_more() fib-aware.
Mar 11 2021, 8:27 AM

Mar 10 2021

melifaro committed R10:9cd7f222d5c9: Enforce net epoch in in6_selectsrc(). (authored by melifaro).
Enforce net epoch in in6_selectsrc().
Mar 10 2021, 10:29 PM
melifaro committed R10:8a25d3f6ce34: Fix dpdk/ldradix fib lookup algorithm preference calculation. (authored by melifaro).
Fix dpdk/ldradix fib lookup algorithm preference calculation.
Mar 10 2021, 10:29 PM
melifaro committed R10:5b64694c8a55: Fix setting static entries for arp/ndp. (authored by melifaro).
Fix setting static entries for arp/ndp.
Mar 10 2021, 10:29 PM
melifaro committed R10:22f24233ba2a: Fix arp/ndp deletion broken by 2fe5a79425c7. (authored by melifaro).
Fix arp/ndp deletion broken by 2fe5a79425c7.
Mar 10 2021, 10:29 PM
melifaro committed R10:e1bdecd9f60a: Fix dst/netmask handling in routing socket code. (authored by melifaro).
Fix dst/netmask handling in routing socket code.
Mar 10 2021, 10:29 PM
melifaro committed R10:6c3f613b6e65: Fix NOINET6 build broken by 2fe5a79425c7. (authored by melifaro).
Fix NOINET6 build broken by 2fe5a79425c7.
Mar 10 2021, 10:29 PM
melifaro committed R10:d9bcd8e7a2dd: Add ifa_try_ref() to simplify ifa handling inside epoch. (authored by melifaro).
Add ifa_try_ref() to simplify ifa handling inside epoch.
Mar 10 2021, 10:29 PM
melifaro committed R10:f67641675958: Make in_localip_more() fib-aware. (authored by melifaro).
Make in_localip_more() fib-aware.
Mar 10 2021, 10:29 PM
melifaro committed R10:3f241e7aac2e: Remove per-packet ifa refcounting from IPv6 fast path. (authored by melifaro).
Remove per-packet ifa refcounting from IPv6 fast path.
Mar 10 2021, 10:28 PM
melifaro committed R10:4904fbfc7201: Remove now-unused RTF_RNH_LOCKED route flag. (authored by melifaro).
Remove now-unused RTF_RNH_LOCKED route flag.
Mar 10 2021, 10:28 PM
melifaro committed R10:3cff9b2ccfd0: Do not reference returned ifa in in6_ifawithifp(). (authored by melifaro).
Do not reference returned ifa in in6_ifawithifp().
Mar 10 2021, 10:28 PM
melifaro closed D29116: Flush remaining routes from the routing table during VNET shutdown..
Mar 10 2021, 9:29 PM
melifaro committed R10:b1d63265ac39: Flush remaining routes from the routing table during VNET shutdown. (authored by melifaro).
Flush remaining routes from the routing table during VNET shutdown.
Mar 10 2021, 9:29 PM
melifaro accepted D29195: pf: Remove redundant kif != NULL checks.
Mar 10 2021, 8:57 PM
melifaro accepted D29194: pf: Factor out pf_krule_free().
Mar 10 2021, 8:55 PM
melifaro added a comment to D29190: pf: Simplify cleanup.

Can counter ptr really be NULL is these cases? If yes, I'd rather retain the existing checks as they indicate that this a valid possibility.

Mar 10 2021, 8:54 PM

Mar 9 2021

melifaro accepted D29146: kern: pull pru_sockaddr call out into sosockaddr().
Mar 9 2021, 8:33 PM
melifaro updated the summary of D29116: Flush remaining routes from the routing table during VNET shutdown..
Mar 9 2021, 8:07 AM

Mar 8 2021

melifaro updated the diff for D29116: Flush remaining routes from the routing table during VNET shutdown..

Implement a cleaner fix.

Mar 8 2021, 11:21 PM
melifaro committed R10:7634919e15f1: Fix 'in6_purgeaddr: err=65, destination address delete failed' message. (authored by melifaro).
Fix 'in6_purgeaddr: err=65, destination address delete failed' message.
Mar 8 2021, 9:29 PM
melifaro closed D29121: Fix 'in6_purgeaddr: err=65, destination address delete failed' message..
Mar 8 2021, 9:29 PM