melifaro (Alexander V. Chernikov)
User

Projects

User Details

User Since
May 27 2014, 9:32 AM (190 w, 2 d)

Recent Activity

Dec 1 2017

melifaro accepted D13286: ifconfig(8): Display extended compliance code for SFP transceivers.
Dec 1 2017, 7:11 AM

Mar 3 2017

melifaro accepted D9873: Fix ipfw tables related PR 217262 and 217292.
Mar 3 2017, 7:14 PM

Jan 26 2017

melifaro committed rP432479: Apply sysdep-bsd-sysio.h patch by default..
Apply sysdep-bsd-sysio.h patch by default.
Jan 26 2017, 10:04 AM

Jan 22 2017

melifaro committed rP432152: Update to 1.6.3..
Update to 1.6.3.
Jan 22 2017, 3:22 PM

Aug 30 2016

melifaro added a comment to D7695: Add GARP retransmit capability.

Could you please explain why this should be done in kernel?

Aug 30 2016, 10:12 AM

Aug 14 2016

melifaro committed rP420204: Finally, bump net/bird revision to account patches added in r420203..
Finally, bump net/bird revision to account patches added in r420203.
Aug 14 2016, 11:31 PM
melifaro committed rP420203: Fix net/bird r420176 update: really add bugfixes from git..
Fix net/bird r420176 update: really add bugfixes from git.
Aug 14 2016, 11:08 PM
melifaro committed rP420176: Update net/bird,net/bird6 to 1.6.0.
Update net/bird,net/bird6 to 1.6.0
Aug 14 2016, 6:25 AM

Jun 5 2016

melifaro committed rS301440: Fix 4-byte overflow in ipv6_writemask..
Fix 4-byte overflow in ipv6_writemask.
Jun 5 2016, 10:34 AM

Feb 10 2016

melifaro accepted D5240: sfxge: implement SIOCGI2C to read infromation from phy modules.

Great news, thanks for implementing that!

Feb 10 2016, 12:10 PM

Feb 2 2016

melifaro added a comment to D5163: MFC r272514 Switch ipfw to use rmlock for runtime locking..

Please take a look on -HEAD ipfw version.
Along with some architectural changes, there are several performance oriented ones: rmlock for fast path, per-cpu rule counters, more compact rule structure and faster tables.
It could be merged to 10 (in fact, we even run in on 9/ in several places)

Feb 2 2016, 5:10 AM

Jan 26 2016

melifaro requested changes to D1986: Teach lagg(4) to change MTU.

Sorry for taking that long.

Jan 26 2016, 7:04 AM

Jan 25 2016

melifaro committed rS294712: Convert TCP mtu checks to the new routing KPI..
Convert TCP mtu checks to the new routing KPI.
Jan 25 2016, 10:07 AM
melifaro committed rS294710: Fix flowtable part missed in r294706..
Fix flowtable part missed in r294706.
Jan 25 2016, 9:31 AM
melifaro committed rS294706: MFP r287070,r287073: split radix implementation and route table structure..
MFP r287070,r287073: split radix implementation and route table structure.
Jan 25 2016, 6:33 AM
melifaro committed rS294704: Remove unused radix_mpath definitions..
Remove unused radix_mpath definitions.
Jan 25 2016, 5:28 AM

Jan 21 2016

melifaro added a reviewer for D4962: Pass addresses instead of sockaddr for lltable lookup. Introduce new light-weight versions of lookup functions.: network.
Jan 21 2016, 11:42 PM
melifaro added a reviewer for D5009: Convert fastworwarding output path to the new routing KPI.: network.
Jan 21 2016, 11:42 PM
melifaro added a reviewer for D5010: Convert IPv6 forwarding to the new routing KPI.: network.
Jan 21 2016, 11:42 PM
melifaro committed rS294525: Fix panic on table/table entry delete. The panic could have happened.
Fix panic on table/table entry delete. The panic could have happened
Jan 21 2016, 6:21 PM
melifaro retitled D5010: Convert IPv6 forwarding to the new routing KPI. from to Convert IPv6 forwarding to the new routing KPI..
Jan 21 2016, 8:12 AM
melifaro retitled D5009: Convert fastworwarding output path to the new routing KPI. from to Convert fastworwarding output path to the new routing KPI..
Jan 21 2016, 8:09 AM

Jan 20 2016

melifaro committed rS294411: Fix rte refcount leak in ip6_forward()..
Fix rte refcount leak in ip6_forward().
Jan 20 2016, 11:25 AM

Jan 19 2016

melifaro added a comment to D1986: Teach lagg(4) to change MTU.

Sorry for the delay. Will try to review today/tomorrow.

Jan 19 2016, 11:22 AM

Jan 17 2016

melifaro retitled D4962: Pass addresses instead of sockaddr for lltable lookup. Introduce new light-weight versions of lookup functions. from to Pass addresses instead of sockaddr for lltable lookup. Introduce new light-weight versions of lookup functions..
Jan 17 2016, 8:20 AM
melifaro committed rS294203: MFC r288297 (userland part)..
MFC r288297 (userland part).
Jan 17 2016, 6:03 AM
melifaro committed rS294202: MFC r292831: Add SFF-8024 Extended Specification Compliance..
MFC r292831: Add SFF-8024 Extended Specification Compliance.
Jan 17 2016, 5:38 AM

Jan 16 2016

melifaro added a comment to D1986: Teach lagg(4) to change MTU.

Please allow me one more day to review the changes.

Jan 16 2016, 7:16 AM

Jan 15 2016

melifaro committed rS294089: Clean up original route path selection logic a bit..
Clean up original route path selection logic a bit.
Jan 15 2016, 1:47 PM
melifaro committed rS294084: Make nfscl_getmyip() use new routing KPI..
Make nfscl_getmyip() use new routing KPI.
Jan 15 2016, 9:05 AM

Jan 14 2016

melifaro committed rS294020: Fix panic in IP redirect. Panic was introduced in r293466..
Fix panic in IP redirect. Panic was introduced in r293466.
Jan 14 2016, 4:31 PM
melifaro committed rS293914: Make ng_netflow(9) use new routing KPI..
Make ng_netflow(9) use new routing KPI.
Jan 14 2016, 1:14 PM
melifaro committed rS293886: Remove now-unused wrappers for various routing functions..
Remove now-unused wrappers for various routing functions.
Jan 14 2016, 8:55 AM

Jan 13 2016

melifaro committed rS293829: Remove RTF_RNH_LOCKED support from rtalloc1_fib()..
Remove RTF_RNH_LOCKED support from rtalloc1_fib().
Jan 13 2016, 2:33 PM

Jan 11 2016

melifaro committed rS293657: Bring RADIX_MPATH support to new routing KPI to ease migration..
Bring RADIX_MPATH support to new routing KPI to ease migration.
Jan 11 2016, 8:45 AM
melifaro committed rS293656: Do not rewrite all ro_flags..
Do not rewrite all ro_flags.
Jan 11 2016, 8:00 AM

Jan 10 2016

melifaro committed rS293633: Split in6_selectsrc() into in6_selectsrc_addr() and in6_selectsrc_socket()..
Split in6_selectsrc() into in6_selectsrc_addr() and in6_selectsrc_socket().
Jan 10 2016, 1:41 PM
melifaro committed rS293632: Do not hold ifaddr reference for the whole icmp6_reflect() exec time..
Do not hold ifaddr reference for the whole icmp6_reflect() exec time.
Jan 10 2016, 12:00 PM
melifaro committed rS293630: Initialize error value ta_lookup_kfib() by default to please compiler..
Initialize error value ta_lookup_kfib() by default to please compiler.
Jan 10 2016, 8:37 AM
melifaro committed rS293628: Convert ipfilter to the new routing KPI..
Convert ipfilter to the new routing KPI.
Jan 10 2016, 7:51 AM
melifaro closed D4764: Convert ipfilter to use new routing API. by committing rS293628: Convert ipfilter to the new routing KPI..
Jan 10 2016, 7:51 AM
melifaro committed rS293626: Make ipfw addr:kfib lookup algo use new routing KPI..
Make ipfw addr:kfib lookup algo use new routing KPI.
Jan 10 2016, 6:44 AM
melifaro committed rS293625: Use already pre-calculated number of entries instead of tc->count..
Use already pre-calculated number of entries instead of tc->count.
Jan 10 2016, 12:29 AM

Jan 9 2016

melifaro committed rS293611: Fix userland build broken by r293470..
Fix userland build broken by r293470.
Jan 9 2016, 6:42 PM
melifaro committed rS293544: Finish r275196: do not dereference rtentry in if_output() routines..
Finish r275196: do not dereference rtentry in if_output() routines.
Jan 9 2016, 4:34 PM
melifaro committed rS293471: Remove prefix check from in6_addroute()..
Remove prefix check from in6_addroute().
Jan 9 2016, 11:41 AM
melifaro committed rS293470: Remove sys/eventhandler.h from net/route.h.
Remove sys/eventhandler.h from net/route.h
Jan 9 2016, 9:35 AM
melifaro committed rS293466: (Temporarily) remove route_redirect_event eventhandler..
(Temporarily) remove route_redirect_event eventhandler.
Jan 9 2016, 6:26 AM
melifaro committed rS293465: Please Coverity by removing unneccessary check (rt_key() is always set)..
Please Coverity by removing unneccessary check (rt_key() is always set).
Jan 9 2016, 5:39 AM

Jan 8 2016

melifaro committed rS293424: Do more fine-grained locking in rtrequest1_fib()..
Do more fine-grained locking in rtrequest1_fib().
Jan 8 2016, 4:25 PM

Jan 7 2016

melifaro committed rS293315: Do not use 'struct route_in6' inside hash6_insert()..
Do not use 'struct route_in6' inside hash6_insert().
Jan 7 2016, 12:22 PM
melifaro committed rS293311: Convert pf(4) to the new routing API..
Convert pf(4) to the new routing API.
Jan 7 2016, 10:20 AM
melifaro closed D4763: Convert pf(4) to use new routing API. by committing rS293311: Convert pf(4) to the new routing API..
Jan 7 2016, 10:20 AM
melifaro updated the diff for D4763: Convert pf(4) to use new routing API..

Do pre-commit sync: fix NOINET case.

Jan 7 2016, 10:09 AM
melifaro added a comment to D4605: Properly stop timer before freeing link level entries for IPv4 and IPv6.

Ping - any reviewers active on this one?

sorry, will take a look today.

Jan 7 2016, 9:29 AM
melifaro committed rS293309: Convert cxgb/cxgbe to the new routing API..
Convert cxgb/cxgbe to the new routing API.
Jan 7 2016, 8:07 AM

Jan 5 2016

melifaro added a comment to D4794: Remove per-ifa outgoing packet accounting from ip[6]_output..
In D4794#101759, @bz wrote:

People had been asking for this for IPv4 and I did the patch but never committed it as the penalty was noticeable. We should not lose these features in favour of simplicity but make them perform well when designing things. Having had per-address counters has been very valuable in the last years for IPv6 to debug and account various things.

I've updated the patch.
IPv6 accounting for most common case (non-fragmented packets) should be slightly better (no ifa ref/unref cost). It is still costy, however, due to IF_ADDR_RLOCK() which is rwlock.
Sending frags is also accounted the same way which may degrade performance for that path.

Jan 5 2016, 1:18 PM
melifaro updated the diff for D4794: Remove per-ifa outgoing packet accounting from ip[6]_output..

Update IPv6 part (add precise accounting using newly-added in6_accountoifa()) per bz@ comments.

Jan 5 2016, 1:10 PM
melifaro added a comment to D4794: Remove per-ifa outgoing packet accounting from ip[6]_output..
In D4794#101759, @bz wrote:

This is a straight reject to the idea from my view. Sorry.
People had been asking for this for IPv4 and I did the patch but never committed it as the penalty was noticeable. We should not lose these features in favour of simplicity but make them perform well when designing things. Having had per-address counters has been very valuable in the last years for IPv6 to debug and account various things. And sorry, using a firewall is not a solution.

I thought it won't be easy but I had to start with something :)
Okay. So for IPv6 situation is not that complicated:
function like inc_ia6_countrers(ifp, addr, opackets, obytes) which internally finds appropriate ifa under ifaddr lock and increments pcpu counters under that lock, w/o the need to do heavy refcounting. It would both improve the performance and increase accuracy.

Jan 5 2016, 10:53 AM
melifaro updated D4794: Remove per-ifa outgoing packet accounting from ip[6]_output..
Jan 5 2016, 6:58 AM
melifaro retitled D4794: Remove per-ifa outgoing packet accounting from ip[6]_output. from to Remove per-ifa outgoing packet accounting from ip[6]_output..
Jan 5 2016, 6:51 AM

Jan 4 2016

melifaro committed rS293169: Finish r293098: make ip6_getpmtu() and ip6_getpmtu_ctl() use new routing API.
Finish r293098: make ip6_getpmtu() and ip6_getpmtu_ctl() use new routing API
Jan 4 2016, 6:32 PM
melifaro committed rS293167: Fix route lookup condition: do IPv6 route lookup for source based on.
Fix route lookup condition: do IPv6 route lookup for source based on
Jan 4 2016, 5:25 PM
melifaro committed rS293166: Maintain consistent behavior: make fib4_lookup_nh_ext() return.
Maintain consistent behavior: make fib4_lookup_nh_ext() return
Jan 4 2016, 5:23 PM
melifaro committed rS293159: Add rib_lookup_info() to provide API for retrieving individual route.
Add rib_lookup_info() to provide API for retrieving individual route
Jan 4 2016, 3:03 PM

Jan 3 2016

melifaro added reviewers for D4764: Convert ipfilter to use new routing API.: cy, network.
Jan 3 2016, 4:32 PM
melifaro retitled D4764: Convert ipfilter to use new routing API. from to Convert ipfilter to use new routing API..
Jan 3 2016, 4:31 PM
melifaro committed rS293108: Fix fib4_lookup_nh_ext() flags/flowid order messed up while merging..
Fix fib4_lookup_nh_ext() flags/flowid order messed up while merging.
Jan 3 2016, 4:13 PM
melifaro added reviewers for D4763: Convert pf(4) to use new routing API.: kristof, glebius, network.
Jan 3 2016, 1:37 PM
melifaro updated D4763: Convert pf(4) to use new routing API..
Jan 3 2016, 1:35 PM
melifaro retitled D4763: Convert pf(4) to use new routing API. from to Convert pf(4) to use new routing API..
Jan 3 2016, 1:33 PM
melifaro committed rS293101: Remove 'struct route_int6' argument from in6_selectsrc() and.
Remove 'struct route_int6' argument from in6_selectsrc() and
Jan 3 2016, 10:43 AM
melifaro committed rS293098: Handle IPV6_PATHMTU option by spliting ip6_getpmtu_ctl() from ip6_getpmtu()..
Handle IPV6_PATHMTU option by spliting ip6_getpmtu_ctl() from ip6_getpmtu().
Jan 3 2016, 9:54 AM

Jan 1 2016

melifaro added a reviewer for D4751: Move all af-dependent lltable code to separate files. Move lltable internal definitions to if_lltable_var.h.: network.
Jan 1 2016, 1:52 PM
melifaro updated D4751: Move all af-dependent lltable code to separate files. Move lltable internal definitions to if_lltable_var.h..
Jan 1 2016, 1:50 PM
melifaro retitled D4751: Move all af-dependent lltable code to separate files. Move lltable internal definitions to if_lltable_var.h. from to Move all af-dependent lltable code to separate files. Move lltable internal definitions to if_lltable_var.h..
Jan 1 2016, 1:49 PM
melifaro committed rS293038: Use lltable_get_ifp() instead of direct access to lltable fields..
Use lltable_get_ifp() instead of direct access to lltable fields.
Jan 1 2016, 12:35 PM
melifaro committed rS293035: Remove second EVENTHANDLER_REGISTER slipped in r292978..
Remove second EVENTHANDLER_REGISTER slipped in r292978.
Jan 1 2016, 10:15 AM

Dec 31 2015

melifaro committed rS292978: Implement interface link header precomputation API..
Implement interface link header precomputation API.
Dec 31 2015, 5:04 AM
melifaro closed D4102: Add link header precomputation for ethernet/infiniband. Make arp/ndp/bpf/flowtable use it. by committing rS292978: Implement interface link header precomputation API..
Dec 31 2015, 5:04 AM
melifaro updated the diff for D4102: Add link header precomputation for ethernet/infiniband. Make arp/ndp/bpf/flowtable use it..

Do pre-commit sync.

Dec 31 2015, 4:58 AM

Dec 28 2015

melifaro added a comment to D4666: Add SFF-8024 Extended Specification Compliance.

Sorry, I totally missed the point that I have to commit it myself :)

Dec 28 2015, 9:27 AM
melifaro committed rS292831: Add SFF-8024 Extended Specification Compliance.
Add SFF-8024 Extended Specification Compliance
Dec 28 2015, 9:26 AM
melifaro closed D4666: Add SFF-8024 Extended Specification Compliance by committing rS292831: Add SFF-8024 Extended Specification Compliance.
Dec 28 2015, 9:26 AM

Dec 23 2015

melifaro added inline comments to D4102: Add link header precomputation for ethernet/infiniband. Make arp/ndp/bpf/flowtable use it..
Dec 23 2015, 1:12 PM
melifaro updated the diff for D4102: Add link header precomputation for ethernet/infiniband. Make arp/ndp/bpf/flowtable use it..

Update once again to clarify arp_fillheader() behavior.

Dec 23 2015, 1:01 PM
melifaro added inline comments to D4102: Add link header precomputation for ethernet/infiniband. Make arp/ndp/bpf/flowtable use it..
Dec 23 2015, 11:40 AM
melifaro updated the diff for D4102: Add link header precomputation for ethernet/infiniband. Make arp/ndp/bpf/flowtable use it..

Finally fix ip_arpintr() reply error handling.

Dec 23 2015, 11:36 AM
melifaro updated the diff for D4102: Add link header precomputation for ethernet/infiniband. Make arp/ndp/bpf/flowtable use it..

Address glebius@ comments and sync to recent HEAD.

Dec 23 2015, 11:26 AM

Dec 21 2015

melifaro accepted D4666: Add SFF-8024 Extended Specification Compliance.
Dec 21 2015, 1:09 PM
melifaro accepted D4666: Add SFF-8024 Extended Specification Compliance.

Mark, big thanks for adding QSFP28 stuff.
Looks OK to me (minor comment below).

Dec 21 2015, 10:20 AM

Dec 17 2015

melifaro added inline comments to D1986: Teach lagg(4) to change MTU.
Dec 17 2015, 10:16 PM

Dec 16 2015

melifaro committed rS292333: Provide additional lle data in IPv6 lltable dump used by ndp(8)..
Provide additional lle data in IPv6 lltable dump used by ndp(8).
Dec 16 2015, 10:14 AM
melifaro committed rS292331: Convert if_stf(4) to new routing api..
Convert if_stf(4) to new routing api.
Dec 16 2015, 9:18 AM
melifaro committed rS292329: Fix ARP reply handling changed in r286955..
Fix ARP reply handling changed in r286955.
Dec 16 2015, 9:16 AM

Dec 14 2015

melifaro accepted D4522: inet6: Do not assume every interface has ip6 enabled.
Dec 14 2015, 9:25 AM · network

Dec 13 2015

melifaro added a comment to D4102: Add link header precomputation for ethernet/infiniband. Make arp/ndp/bpf/flowtable use it..
In D4102#95769, @mike-karels.net wrote:

I haven't reviewed this as closely as I should. However, if I read this correctly, this is a new caching mechanism that:

  • is not currently used for caching

Mike,
Thanks for the comments.
I probably should have written more detailed summary. Let me try to rephrase it.

Dec 13 2015, 9:09 PM
melifaro updated the diff for D4102: Add link header precomputation for ethernet/infiniband. Make arp/ndp/bpf/flowtable use it..

Update patch to reflect recent netinet6/ lltable changes.

Dec 13 2015, 7:49 PM
melifaro committed rS292163: Fix PINNED routes handling..
Fix PINNED routes handling.
Dec 13 2015, 4:37 PM
melifaro committed rS292155: Remove LLE read lock from IPv6 fast path..
Remove LLE read lock from IPv6 fast path.
Dec 13 2015, 7:40 AM