Page MenuHomeFreeBSD

melifaro (Alexander V. Chernikov)
User

Projects

User Details

User Since
May 27 2014, 9:32 AM (400 w, 5 h)

Recent Activity

Mon, Jan 17

melifaro committed R10:779fd0534466: ifconfig: improve vlan options parsing (authored by melifaro).
ifconfig: improve vlan options parsing
Mon, Jan 17, 9:37 AM
melifaro closed D33794: gitignore: ignore vim swap files & .rej/.orig.
Mon, Jan 17, 9:37 AM
melifaro committed R10:b1f7154cb125: gitignore: ignore vim swap files & .rej/.orig (authored by melifaro).
gitignore: ignore vim swap files & .rej/.orig
Mon, Jan 17, 9:37 AM
melifaro closed D33792: linux: add sysctl to pass untranslated interface names.
Mon, Jan 17, 9:36 AM
melifaro committed R10:1f70a85b4cbc: linux: add sysctl to pass untranslated interface names (authored by melifaro).
linux: add sysctl to pass untranslated interface names
Mon, Jan 17, 9:36 AM
melifaro closed D33790: linux: fix linux_recvmsg() flag handling.
Mon, Jan 17, 9:36 AM
melifaro committed R10:96c524d8b2c9: linux: fix linux_recvmsg() MSG_PEEK flag handling (authored by melifaro).
linux: fix linux_recvmsg() MSG_PEEK flag handling
Mon, Jan 17, 9:36 AM

Wed, Jan 12

melifaro added a comment to D33872: dummynet: store current vnet when scheduling fqpie_callout_cleanup.

Dhould we remove the packets in those queues on vnet destruction?

Wed, Jan 12, 8:31 PM
melifaro accepted D33859: tests/netinet: add test for IPv6 NS and CARP.
Wed, Jan 12, 8:09 AM

Tue, Jan 11

melifaro added a comment to D33854: Add a regression test for TCP socket setting DSCP..

It's great we'll get DSCP tests!
Nit: maybe it's worth trying to have it encoded with python-scapy? It has both sending and receiving support for all kind of packets.
Happy to chat more on that.

Tue, Jan 11, 9:57 PM

Sat, Jan 8

melifaro updated the summary of D33794: gitignore: ignore vim swap files & .rej/.orig.
Sat, Jan 8, 4:18 PM
melifaro requested review of D33794: gitignore: ignore vim swap files & .rej/.orig.
Sat, Jan 8, 4:15 PM
melifaro updated the diff for D33792: linux: add sysctl to pass untranslated interface names.

remove if_dl.h

Sat, Jan 8, 4:00 PM
melifaro updated the test plan for D33792: linux: add sysctl to pass untranslated interface names.
Sat, Jan 8, 3:55 PM
melifaro updated the summary of D33792: linux: add sysctl to pass untranslated interface names.
Sat, Jan 8, 3:53 PM
melifaro requested review of D33792: linux: add sysctl to pass untranslated interface names.
Sat, Jan 8, 3:42 PM
melifaro retitled D33790: linux: fix linux_recvmsg() flag handling from linux: fix linux_recvmsg() MSG_PEEK flag handling to linux: fix linux_recvmsg() flag handling.
Sat, Jan 8, 2:01 PM
melifaro created P534 linux_msg_peek.c.
Sat, Jan 8, 1:47 PM
melifaro requested review of D33790: linux: fix linux_recvmsg() flag handling.
Sat, Jan 8, 1:44 PM

Wed, Jan 5

melifaro accepted D33717: route: remove write-only struct hostent from getaddr().
Wed, Jan 5, 5:03 PM
melifaro accepted D33718: Fix kernel build if neither INET or INET6 is enabled.
Wed, Jan 5, 12:05 PM

Sat, Jan 1

melifaro added inline comments to D33710: route: silence Clang set but not used warning under WITHOUT_INET.
Sat, Jan 1, 5:46 PM

Wed, Dec 29

melifaro committed R10:63f7f3921bdc: routing: Add unified level-based logging support for the routing subsystem. (authored by melifaro).
routing: Add unified level-based logging support for the routing subsystem.
Wed, Dec 29, 9:31 PM
melifaro committed R10:823a08d7403c: nhops: split nh_family into nh_upper_family and nh_neigh_family. (authored by melifaro).
nhops: split nh_family into nh_upper_family and nh_neigh_family.
Wed, Dec 29, 9:31 PM
melifaro committed R10:ff3a85d32411: [lltable] Add per-family lltable getters. (authored by melifaro).
[lltable] Add per-family lltable getters.
Wed, Dec 29, 9:31 PM
melifaro closed D33664: routing: Add unified level-based logging support for the routing subsystem..
Wed, Dec 29, 9:31 PM
melifaro closed D33663: nhops: split nh_family into nh_upper_family and nh_neigh_family..
Wed, Dec 29, 9:31 PM
melifaro closed D33660: [lltable] Add per-family lltable getters.
Wed, Dec 29, 9:31 PM

Mon, Dec 27

melifaro added a comment to D31871: Fix 802.1ad handling bug in input processing of ethernet frames..

Rebase to main.

@melifaro may you please point me to the problem with QinQ processing?
How can the processing work, if the ethertype information is lost?

Regardless of what encap is (vlan or qinq) the vlan code effectively does the same - pullups the header and record the tag.
If NIC does not support QINIQ tag removal (or vlanhwtag is explicitly turned off), such frames will be dropped after the change, which is the breakage I'm talking about

Mon, Dec 27, 4:09 PM
melifaro accepted D33537: protocols: init with standard SYSINIT(9) or VNET_SYSINIT.

Really good simplification!

Mon, Dec 27, 2:47 PM

Sun, Dec 26

melifaro added a comment to D33662: vnet: make VNET_IS_SHUTTING_DOWN macro global..
In D33662#760509, @bz wrote:

Can you please tell what you need it for.
The bandaid is very specific for if.c and should really never be needed anywhere else.

Sure!
Let me start with my view on the generic situation first.
When we teardown VNET, we need to gradually shut down all virtualized subsystems. This shutdown is by no way atomic, which means that certain subsystems shut down faster than the others.
Some are coupled either explicitly with the others (like PCBs referencing nhops and lles) or implicitly (by passing mbufs up or down the stack). Furthermore, the problem is made harder by the fact that certain entities like nhops or LLEs are epoch-protected and can extend the subsystem lifespan requirement non-deterministically. Such couplings present two contradicting requirements for a subsystem: (1) try to die early to make progress and (2) try to keep the necessary datastuctures alive as long as possible so the other subsystems don't crash. That said, having the ability to "close the incoming gate" for the subsystem is important - as it allows to wipe all state after the "gate" is closed (e.g. nothing can cause the addition of a new state) and keep the minimal amount of datastructures, that can die close to the end of teardown.

Sun, Dec 26, 8:15 PM
melifaro retitled D33658: Pre-calculate L2 prepends for routes with gateway and avoid arp/nd lookup from [WIP] Pre-calculate L2 prepends for routes with gateway and avoid arp/nd lookup to Pre-calculate L2 prepends for routes with gateway and avoid arp/nd lookup.
Sun, Dec 26, 7:11 PM
melifaro updated the diff for D33658: Pre-calculate L2 prepends for routes with gateway and avoid arp/nd lookup.

.

Sun, Dec 26, 7:06 PM
melifaro requested review of D33664: routing: Add unified level-based logging support for the routing subsystem..
Sun, Dec 26, 6:43 PM
melifaro updated the diff for D33663: nhops: split nh_family into nh_upper_family and nh_neigh_family..

add nhop_get_fibnum().

Sun, Dec 26, 6:18 PM
melifaro requested review of D33663: nhops: split nh_family into nh_upper_family and nh_neigh_family..
Sun, Dec 26, 6:12 PM

Dec 26 2021

melifaro added reviewers for D33662: vnet: make VNET_IS_SHUTTING_DOWN macro global.: network, bz.
Dec 26 2021, 3:21 PM
melifaro requested review of D33662: vnet: make VNET_IS_SHUTTING_DOWN macro global..
Dec 26 2021, 3:21 PM
melifaro updated the diff for D33658: Pre-calculate L2 prepends for routes with gateway and avoid arp/nd lookup.

.

Dec 26 2021, 3:07 PM
melifaro committed R10:731bfa9f1803: netstat: fix nhop prepend printing. (authored by melifaro).
netstat: fix nhop prepend printing.
Dec 26 2021, 3:07 PM
melifaro closed D33270: tcp: virtualise net.inet.tcp.msl sysctl..
Dec 26 2021, 3:06 PM
melifaro committed R10:c2c8e360d8c0: tcp: virtualise net.inet.tcp.msl sysctl. (authored by melifaro).
tcp: virtualise net.inet.tcp.msl sysctl.
Dec 26 2021, 3:06 PM
melifaro updated the diff for D33658: Pre-calculate L2 prepends for routes with gateway and avoid arp/nd lookup.

.

Dec 26 2021, 1:01 PM
melifaro updated the summary of D33660: [lltable] Add per-family lltable getters.
Dec 26 2021, 12:43 PM
melifaro requested review of D33660: [lltable] Add per-family lltable getters.
Dec 26 2021, 12:39 PM
melifaro retitled D33658: Pre-calculate L2 prepends for routes with gateway and avoid arp/nd lookup from fff to [WIP] Pre-calculate L2 prepends for routes with gateway and avoid arp/nd lookup.
Dec 26 2021, 12:52 AM
melifaro requested review of D33658: Pre-calculate L2 prepends for routes with gateway and avoid arp/nd lookup.
Dec 26 2021, 12:19 AM

Dec 19 2021

melifaro accepted D33274: IPv4: fix redirect sending conditions.
Dec 19 2021, 11:07 PM

Dec 16 2021

melifaro added a comment to D33501: net: make ethernet.h self-contained.

Could you by any chance add the rationale to the diff description?

Dec 16 2021, 7:41 PM

Dec 14 2021

melifaro accepted D33274: IPv4: fix redirect sending conditions.
Dec 14 2021, 12:43 AM

Dec 13 2021

melifaro added inline comments to D33274: IPv4: fix redirect sending conditions.
Dec 13 2021, 11:59 PM

Dec 10 2021

melifaro abandoned D31595: Route IPv4 packets via IPv6 next-hops - D30398 variation..
Dec 10 2021, 10:22 PM
melifaro added a comment to D18581: Add ability to forward IPv4 packets trough IPv6 only router.

A slightly different version landed in D30398.

Dec 10 2021, 9:47 PM
melifaro closed D28602: Fix interface route addition with net/bird..

Committed as 8170a7d43835047f9c1548a081eea45116473995.

Dec 10 2021, 9:44 PM
melifaro added a comment to D33380: unix: Increase the default datagram recv buffer size.

Q: Speaking of 256k - do we want to create different defaults for low-memory and high-memory systems?

Dec 10 2021, 9:34 PM
melifaro closed D28629: Fix ifa refcount leak during route addition..

Landed as a375ec52a7b423133f66878ecf002efc3b6e9fca .

Dec 10 2021, 9:17 PM
melifaro added inline comments to D33274: IPv4: fix redirect sending conditions.
Dec 10 2021, 9:06 PM

Dec 5 2021

melifaro updated the diff for D33270: tcp: virtualise net.inet.tcp.msl sysctl..

Remove NEEDGIANT.

Dec 5 2021, 10:47 PM
melifaro added inline comments to D33274: IPv4: fix redirect sending conditions.
Dec 5 2021, 10:08 PM

Dec 4 2021

melifaro added inline comments to D33264: ifnet: make V_if_index static to if.c.
Dec 4 2021, 11:47 PM
melifaro accepted D33263: ifnet_byindex() actually requires network epoch.
Dec 4 2021, 11:41 PM
melifaro accepted D33261: ifnet: initial if_grow() shall always succeed.
Dec 4 2021, 10:52 PM
melifaro accepted D33262: ifnet: merge ifindex_alloc(), ifnet_setbyindex(), if_grow() and call magic.
Dec 4 2021, 10:44 PM
melifaro updated the test plan for D33270: tcp: virtualise net.inet.tcp.msl sysctl..
Dec 4 2021, 10:26 PM
melifaro updated the test plan for D33270: tcp: virtualise net.inet.tcp.msl sysctl..
Dec 4 2021, 10:26 PM
melifaro updated the diff for D33270: tcp: virtualise net.inet.tcp.msl sysctl..

.

Dec 4 2021, 10:14 PM
melifaro requested review of D33270: tcp: virtualise net.inet.tcp.msl sysctl..
Dec 4 2021, 10:09 PM
melifaro committed R10:6ef62def6096: routing: Use the same index space for both nexthop and nexthop groups. (authored by melifaro).
routing: Use the same index space for both nexthop and nexthop groups.
Dec 4 2021, 7:16 PM
melifaro committed R10:b9772822a6b3: routing: fix source address selection rules for IPv4 over IPv6. (authored by melifaro).
routing: fix source address selection rules for IPv4 over IPv6.
Dec 4 2021, 7:16 PM
melifaro committed R10:e72b873b7c3b: lltable: do not require prefix lookup when checking lle allocation rules. (authored by melifaro).
lltable: do not require prefix lookup when checking lle allocation rules.
Dec 4 2021, 7:16 PM

Nov 11 2021

melifaro accepted D32951: kernel: partially revert e9efb1125a1584338640ec796c315318c66ef7d7.
Nov 11 2021, 10:26 PM
melifaro added a comment to D32710: mbuf: introduce m_clear_tags().

I’d say generally we want to protect from endless loops in our networking configuration, be it lagg/bridge/vlan/gre/tun or any other logical interface moving mbufs to the next interface. It is possible to perform control plane loop-check for some combinations, but not for all. Maybe it’s worth approaching it similarly to IP - by having a TTL budget of, say, 16 hops and simply decreasing it on every *logical interface* traversal? Can be 4 bits in the mbuf or a common tag, not cleaned until the mbuf gets destroyed. Thoughts?

Nov 11 2021, 9:33 AM
melifaro accepted D32914: Add net.inet.ip.source_address_validation.
Nov 11 2021, 9:23 AM
melifaro accepted D32915: Add net.inet6.ip6.source_address_validation.
Nov 11 2021, 9:22 AM
melifaro accepted D32933: Add in_localip_fib(), in6_localip_fib()..
Nov 11 2021, 9:21 AM

Nov 10 2021

melifaro accepted D32913: ip_input: packet filters shall not modify m_pkthdr.rcvif.
Nov 10 2021, 10:03 AM
melifaro requested changes to D32915: Add net.inet6.ip6.source_address_validation.
Nov 10 2021, 9:59 AM

Nov 4 2021

melifaro added inline comments to D32811: Add nd6_ifinfo() function to do basic checks to avoid NULL pointer dereference.
Nov 4 2021, 8:34 AM
melifaro accepted D32820: vxlan: Add support for socket ioctls SIOC[SG]TUNFIB.

LGTM, ty!
Any chance you can fill in the "testing" section?

Nov 4 2021, 8:25 AM · network

Oct 23 2021

melifaro accepted D32615: route: avoid overlapping strcpy.
Oct 23 2021, 7:36 PM

Oct 20 2021

melifaro accepted D32584: Use network epoch to protect local IPv4 addresses hash..
Oct 20 2021, 10:16 PM

Oct 13 2021

melifaro added a comment to D32352: net: collect LLE cache statistics.

Would it be possible to describe a use case for the feature?

NetApp uses it downstream for validation and testing -- we could stash it off behind a config option if you'd feel better about that?

I have some changes related to linking nhops with llentries, so the datapath avoids looking up / referencing llentries for routes with gateway. Per-lle counters may be a bit hard to support in that scenario.
Are other methods of getting the counters (dtrace, ipfw counters) out of the table?

Oct 13 2021, 4:26 PM

Oct 12 2021

melifaro accepted D32434: The IPv4 address list has enough protection from the network epoch. An IPv4 address is embedded into an ifaddr which is freed via epoch. The in_ifaddrhead is already a CK list. Next step would be to CK-ify the in_addr hash and get rid of the....
Oct 12 2021, 11:16 PM

Oct 8 2021

melifaro committed R10:7e64580b5f47: routing: Use the same index space for both nexthop and nexthop groups. (authored by melifaro).
routing: Use the same index space for both nexthop and nexthop groups.
Oct 8 2021, 7:59 AM
melifaro closed D32342: [routing] Use the same space for both nexthop and nhgroup indices..
Oct 8 2021, 7:59 AM

Oct 7 2021

melifaro added inline comments to D32356: Add support for TLS RX via IFNET.
Oct 7 2021, 4:09 PM · network
melifaro added a comment to D32352: net: collect LLE cache statistics.

Would it be possible to describe a use case for the feature?

Oct 7 2021, 7:55 AM

Oct 6 2021

melifaro requested review of D32342: [routing] Use the same space for both nexthop and nhgroup indices..
Oct 6 2021, 7:46 PM

Oct 1 2021

melifaro updated the diff for D32240: arp: bring back reject/discard functionalify for arp entries..

Reflect glebius@ comments.

Oct 1 2021, 7:58 PM

Sep 30 2021

melifaro retitled D32240: arp: bring back reject/discard functionalify for arp entries. from arp: bring back reject/blackhole functionalify for arp entries. to arp: bring back reject/discard functionalify for arp entries..
Sep 30 2021, 11:01 PM
melifaro updated the diff for D32240: arp: bring back reject/discard functionalify for arp entries..

update terminology.

Sep 30 2021, 11:00 PM
melifaro updated the summary of D32240: arp: bring back reject/discard functionalify for arp entries..
Sep 30 2021, 10:02 PM
melifaro requested review of D32240: arp: bring back reject/discard functionalify for arp entries..
Sep 30 2021, 9:37 PM

Sep 13 2021

melifaro added a comment to D31903: dummynet: Does not depend on ipfw.
In D31903#720341, @kp wrote:

May this cause an unwanted effect on automatic module loading?
So may somebody depend on this dependency in the local setup?

Yes, that's a concern. Especially for merging it back to stable/13 and stable/12.
I'm planning to MFC pf/dummynet , but perhaps users in 12 and 13 are just going to have to live with the dummynet module autoloading ipfw. It's something to think about.

With default to deny it might be not exactly the desired outcome. Do you think that a separate module w/ dummynet-for-pf (for 12/13) is too much of a hassle? Especially given ae@‘s plan to change dummynet for ipfw?

Sep 13 2021, 12:09 PM

Sep 10 2021

melifaro accepted D31861: Change lowest address on subnet (host 0) not to broadcast by default..
Sep 10 2021, 8:33 PM

Sep 9 2021

melifaro accepted D31889: net: Enter a net epoch around protocol if_up/down notifications.
Sep 9 2021, 9:01 PM

Sep 7 2021

melifaro closed D31868: routing: fix source address selection rules for IPv4 over IPv6..
Sep 7 2021, 9:44 PM
melifaro committed R10:4b631fc832ac: routing: fix source address selection rules for IPv4 over IPv6. (authored by melifaro).
routing: fix source address selection rules for IPv4 over IPv6.
Sep 7 2021, 9:44 PM
melifaro committed R10:e8df60a69a0e: routing: Allow using IPv6 next-hops for IPv4 routes (RFC 5549). (authored by zlei.huang_gmail.com).
routing: Allow using IPv6 next-hops for IPv4 routes (RFC 5549).
Sep 7 2021, 9:31 PM
melifaro committed R10:f3d69003374a: routing: Bring back the ability to specify transmit interface via its name. (authored by melifaro).
routing: Bring back the ability to specify transmit interface via its name.
Sep 7 2021, 9:31 PM