netlink: convert to IfAPI.

[melifaro]

Summary

Convert to IfAPI everything except IF_AFDATA_WLOCK usage in neigh.c.

I don't think it's a good idea to to expose locking as function-based API. I'd prefer to leave neigh.c with access to a private header for some time.
I two options here: 1) move actual LLE insertion code inside if_lltable.c

2. refactoring IF_AFDATA locking in general to have per-af lock instead of a global one.

Currently I'm leaning for the first option, which is fairly simple.

[jhibbits]

I agree with option 1, moving the LLE insertion code to if_llatbl.c

sys/netlink/route/neigh.c

43

I'm fine with including the private header for now, let's make sure "for now" doesn't become "forever", though :)

[melifaro]

In D40577#923867, @jhibbits wrote:

I agree with option 1, moving the LLE insertion code to if_llatbl.c

Yep. I drafted something, but I need to think about the desired KPI a bit more, as I want to accommodate child LLE inclusion (IPv4 over IPv6 LLEs ATM). Probably I'll come up with something in the next couple of days.

sys/netlink/route/neigh.c

43

Sure. I'd really love to reduce the if_private.h inclusion to the bare minimum everywhere.