bz (Bjoern A. Zeeb)
User

Projects

User Details

User Since
Aug 29 2014, 12:11 PM (203 w, 9 h)

Recent Activity

Today

bz accepted D16147: Create a macro for the static modifier with VNET.
Fri, Jul 20, 1:07 PM

Mon, Jul 16

bz accepted D16145: Don't use static on DPCPU data in arm64 modules.
Mon, Jul 16, 4:47 PM

Wed, Jul 11

bz updated the diff for D15865: Provide process space virtualisation functionality for jails..
  • Merge branch 'p2' into p3
Wed, Jul 11, 3:50 PM
bz updated the diff for D15906: Implement "global" process (and zombie) lists loops iterating over all vps instances and all processes in each..
  • Looks like there was an unlock lost during the merge.
Wed, Jul 11, 3:48 PM
bz resigned from D16205: Create three helper functions for parsing boot args..
Wed, Jul 11, 3:15 PM
bz added a comment to D16205: Create three helper functions for parsing boot args..
In D16205#344159, @imp wrote:
In D16205#344062, @bz wrote:

Given this is multiple architectures, how are you dealing with colliding/different values? Hmm I see you don't touch that part.

There are no such values. RB_* are 100% the same everywhere.

Wed, Jul 11, 3:14 PM
bz updated the diff for D15906: Implement "global" process (and zombie) lists loops iterating over all vps instances and all processes in each..
  • Merge branch 'p1' into p2
Wed, Jul 11, 2:54 PM
bz updated the diff for D15570: Virtualization of basic variables and locks for jail+vps..
  • Merge branch 'p0' into p1
  • Maintanance on new code; add virtualisation where needed.
Wed, Jul 11, 1:45 PM
bz added a comment to D16205: Create three helper functions for parsing boot args..

Given this is multiple architectures, how are you dealing with colliding/different values? Hmm I see you don't touch that part.
How are you dealing with architecture specific ones (not #defined but now part of the switch statement)?
I guess what I am saying is: if we clean this up, can we also break everything and cleanup the #defines along somehow to only have one set of those as well?

Wed, Jul 11, 11:43 AM

Tue, Jul 10

bz updated the diff for D15556: Initial vps (virtual process space) framework for jails..
Update to more recent head.
Tue, Jul 10, 9:02 AM
bz added a reviewer for D16202: libradius(3) IPv6 support: hrs.
Tue, Jul 10, 12:19 AM
bz added a comment to D16202: libradius(3) IPv6 support.

This feels like a 15 year old patch I've seen before.

Tue, Jul 10, 12:15 AM

Mon, Jul 9

bz added a comment to D16145: Don't use static on DPCPU data in arm64 modules.

Please also incorporate the one line subject summary into the description for the commit message.

Mon, Jul 9, 11:43 PM

Sat, Jul 7

bz accepted D16147: Create a macro for the static modifier with VNET.

If you can sort out the pf_ioctl.c volatile issue first, and add the comment as you suggested this look good to me.

Sat, Jul 7, 2:17 PM

Thu, Jul 5

bz committed rS336003: Split up deadlkres() to make it more readable in anticipation of.
Split up deadlkres() to make it more readable in anticipation of
Thu, Jul 5, 5:07 PM
bz closed D15914: Split up deadlkres() to make it more readable..
Thu, Jul 5, 5:07 PM
bz added a comment to D15914: Split up deadlkres() to make it more readable..

Thanks for the review!

Thu, Jul 5, 5:03 PM
bz updated the diff for D15914: Split up deadlkres() to make it more readable..

Addressed all the comments; not unlocking for panic also
allowed us to remove the tryl variable and just return.

Thu, Jul 5, 4:42 PM
bz accepted D16140: Create a new macro for static DPCPU data.

do whatever you want with the comment and commit

Thu, Jul 5, 4:39 PM
bz committed rS335993: With the introduction of reapers and reaplists in r275800,.
With the introduction of reapers and reaplists in r275800,
Thu, Jul 5, 4:16 PM
bz closed D15924: Fix circular reaper dependency after r275800..
Thu, Jul 5, 4:16 PM
bz accepted D16140: Create a new macro for static DPCPU data.

Happy with those bits if you do the man page as you say :)

Thu, Jul 5, 3:36 PM
bz updated the diff for D15924: Fix circular reaper dependency after r275800..
  • Set P_TREE_REAPER on proc0 given it is the reaper for init now.
Thu, Jul 5, 3:28 PM
bz added a comment to D15914: Split up deadlkres() to make it more readable..

For the other comments it's basically the same; I moved the former inline code into sub-functions. I'll make the changes and upload a new patch.

Thu, Jul 5, 2:36 PM
bz added a comment to D16140: Create a new macro for static DPCPU data.

What about (what do others think):

Thu, Jul 5, 2:25 PM
bz added reviewers for D16140: Create a new macro for static DPCPU data: emaste, markj.

Add you two for the DPCPU (and later VNET) static file local load relative issue (1st step) solution.

Thu, Jul 5, 1:56 PM

Jun 20 2018

bz committed rS335441: Instead of using hand-rolled loops where not needed switch them.
Instead of using hand-rolled loops where not needed switch them
Jun 20 2018, 11:42 AM
bz closed D15916: More consistently use FOREACH_PROC_IN_SYSTEM()..
Jun 20 2018, 11:42 AM
bz committed rS335437: Sometimes it is helpful to get the path for a vnode..
Sometimes it is helpful to get the path for a vnode.
Jun 20 2018, 8:34 AM
bz closed D14898: Implement DDB show vpath.
Jun 20 2018, 8:34 AM
bz created D15924: Fix circular reaper dependency after r275800..
Jun 20 2018, 8:14 AM

Jun 19 2018

bz added a comment to D15865: Provide process space virtualisation functionality for jails..

Follow-up on comments to @jamie

Jun 19 2018, 11:46 PM
bz created D15916: More consistently use FOREACH_PROC_IN_SYSTEM()..
Jun 19 2018, 11:36 PM
bz created D15914: Split up deadlkres() to make it more readable..
Jun 19 2018, 11:21 PM
bz added a comment to D15570: Virtualization of basic variables and locks for jail+vps..
In D15570#336006, @kib wrote:
Jun 19 2018, 4:41 PM
bz added a comment to D15906: Implement "global" process (and zombie) lists loops iterating over all vps instances and all processes in each..

I'll try to get some of the whitespace changes (using sub-functions for highly indented code, etc) out of this patch and into head separately to make it easier to review this one.

Jun 19 2018, 4:38 PM
bz added a dependent revision for D15906: Implement "global" process (and zombie) lists loops iterating over all vps instances and all processes in each.: D15865: Provide process space virtualisation functionality for jails..
Jun 19 2018, 4:37 PM
bz edited dependencies for D15865: Provide process space virtualisation functionality for jails., added: 1; removed: 1.
Jun 19 2018, 4:37 PM
bz removed a dependent revision for D15570: Virtualization of basic variables and locks for jail+vps.: D15865: Provide process space virtualisation functionality for jails..
Jun 19 2018, 4:37 PM
bz added a dependency for D15906: Implement "global" process (and zombie) lists loops iterating over all vps instances and all processes in each.: D15570: Virtualization of basic variables and locks for jail+vps..
Jun 19 2018, 4:36 PM
bz added a dependent revision for D15570: Virtualization of basic variables and locks for jail+vps.: D15906: Implement "global" process (and zombie) lists loops iterating over all vps instances and all processes in each..
Jun 19 2018, 4:36 PM
bz created D15906: Implement "global" process (and zombie) lists loops iterating over all vps instances and all processes in each..
Jun 19 2018, 4:36 PM

Jun 18 2018

bz added a comment to D15570: Virtualization of basic variables and locks for jail+vps..
In D15570#335980, @kib wrote:
In D15570#335888, @bz wrote:
In D15570#328824, @kib wrote:
Jun 18 2018, 6:03 PM
bz added a comment to D15570: Virtualization of basic variables and locks for jail+vps..
In D15570#328824, @kib wrote:

I have no idea about the global plan and most of the implementation details, so I am replying from the common sense PoV. I am completely not sure about the split of the allproc_lock and proctree_lock into per-VPS locks. For often need to iterate over all processes in the tree, e.g. to make a decision about the global memory subsystem state. In this case, the global process list and the global allproc_lock are right, but per-VPS lists and locks are not. Of course, unless you also partition the physical memory (but I doubt that it makes sense).

In other words, there still must be a global lock, and there probably should be per-container locks. But this requires initial architectural discussion and agreement on the major points, which would allow to make such decisions later without much reconsiderations.

Jun 18 2018, 3:27 PM
bz added a dependency for D15865: Provide process space virtualisation functionality for jails.: D15570: Virtualization of basic variables and locks for jail+vps..
Jun 18 2018, 3:24 PM
bz added a dependent revision for D15570: Virtualization of basic variables and locks for jail+vps.: D15865: Provide process space virtualisation functionality for jails..
Jun 18 2018, 3:24 PM
bz added a comment to D15556: Initial vps (virtual process space) framework for jails..

Moved the VPS check for attach into do_jail_attach()

Jun 18 2018, 3:21 PM
bz updated the diff for D15556: Initial vps (virtual process space) framework for jails..
Prevent attaching to a jail both from jail_attach() and from
jaiL_set() by moving the check into the first thing of
do_jail_attach().
Jun 18 2018, 3:20 PM

Jun 17 2018

bz created D15865: Provide process space virtualisation functionality for jails..
Jun 17 2018, 2:55 PM

Jun 14 2018

bz added a comment to D15789: Switch RIB and RADIX_NODE_HEAD lock from rwlock(9) to rmlock(9).

It's a forwarding setup and I'm using only 2 static routes on my benches

Jun 14 2018, 10:09 PM
bz added a comment to D15789: Switch RIB and RADIX_NODE_HEAD lock from rwlock(9) to rmlock(9).

Macro shipit:

Jun 14 2018, 9:45 PM

May 25 2018

bz committed rS334209: Extend show proc with reaper, sigparent, and vmspace information.
Extend show proc with reaper, sigparent, and vmspace information
May 25 2018, 2:00 PM
bz added a dependency for D15570: Virtualization of basic variables and locks for jail+vps.: D15556: Initial vps (virtual process space) framework for jails..
May 25 2018, 11:07 AM
bz added a dependent revision for D15556: Initial vps (virtual process space) framework for jails.: D15570: Virtualization of basic variables and locks for jail+vps..
May 25 2018, 11:07 AM
bz added a comment to D15570: Virtualization of basic variables and locks for jail+vps..
May 25 2018, 11:06 AM
bz created D15570: Virtualization of basic variables and locks for jail+vps..
May 25 2018, 11:05 AM
bz added a comment to D15556: Initial vps (virtual process space) framework for jails..

What does this buy us? What I can come up with is:

May 25 2018, 9:21 AM

May 24 2018

bz updated the diff for D15556: Initial vps (virtual process space) framework for jails..
  • Update the static asserts to match again.
  • Merge branch 'master' into p0
May 24 2018, 5:37 PM
bz added a comment to D15556: Initial vps (virtual process space) framework for jails..

I have already committed the noise to HEAD. Seems the git export was too slow to pick it up and merge it out.

May 24 2018, 4:53 PM
bz created D15556: Initial vps (virtual process space) framework for jails..
May 24 2018, 4:45 PM
bz committed rS334163: Add Peraso Technologies, Inc. to the list..
Add Peraso Technologies, Inc. to the list.
May 24 2018, 3:47 PM
bz committed rS334161: Try to be consistent and spell "vnet" lower case like all the.
Try to be consistent and spell "vnet" lower case like all the
May 24 2018, 3:31 PM
bz committed rS334160: Improve the KASSERT to also have the prison pointer..
Improve the KASSERT to also have the prison pointer.
May 24 2018, 3:28 PM

May 6 2018

bz added a comment to D15329: Improvement for MAC address uniqueness of if_epair(4).

Apart from the style issue, I think this can be fine.

May 6 2018, 9:40 PM

Apr 19 2018

bz added a comment to D15136: Shuffle of tcpcb to optimize cache line efficiencies in main tcp_input/output paths..

Did you ever measure (apart from VTune) any difference. What does this change do to VIMAGE kernels given td_vnet gets down to the cold side of the structure?

Apr 19 2018, 3:38 PM

Apr 17 2018

bz added a comment to D15112: In snmp_mibII module assume that virtual interfaces can work at maximum speed available in the system.

Hmm I tried to add syrinx but she's not on Phab it seems.

Apr 17 2018, 1:21 PM

Apr 12 2018

bz committed rS332433: Fix a typo..
Fix a typo.
Apr 12 2018, 2:57 PM

Apr 9 2018

bz updated the diff for D14898: Implement DDB show vpath.

Fix the _ts stuff by not doing it anymore.

Apr 9 2018, 2:32 PM

Apr 4 2018

bz added inline comments to D14898: Implement DDB show vpath.
Apr 4 2018, 3:36 PM

Mar 29 2018

bz created D14898: Implement DDB show vpath.
Mar 29 2018, 5:30 PM

Mar 22 2018

bz accepted D10940: Static analysis: Remove unused variables in IPv6 code.

Seems good to me.

Mar 22 2018, 2:14 PM

Mar 20 2018

bz accepted D14763: Set the proper vnet in IPSec callback functions..

Sounds good to me. I think if the vnet disappears between before the callback we have entirely different problems.

Mar 20 2018, 3:56 PM

Mar 16 2018

bz added a comment to D13514: Fix netstat reporting of accepted TCP/IPv6 connections when net.inet6.ip6.v6only=0.

https://tools.ietf.org/html/rfc6890 table 20 these days disallows v4-mapped addresses on the wire; yiipppiiie!

Mar 16 2018, 2:25 PM
bz accepted D13514: Fix netstat reporting of accepted TCP/IPv6 connections when net.inet6.ip6.v6only=0.

Based on the F2F discussion:
get this one in and we'll sort the problem of https://tools.ietf.org/html/draft-itojun-v6ops-v4mapped-harmful-02 (still being true or not) out at a later time.

Mar 16 2018, 1:44 PM

Mar 12 2018

bz abandoned D14635: libsysdecode; mktable fix vmresult table, enhance sigbuscode table.
Mar 12 2018, 1:47 PM
bz committed rS330795: The vmresult table was missing most of the values apart from two due to.
The vmresult table was missing most of the values apart from two due to
Mar 12 2018, 1:33 PM
bz added a comment to D14635: libsysdecode; mktable fix vmresult table, enhance sigbuscode table.

Thanks for the feedback; I'll get the one-liner in and leave the rest of the cleanup to you.

Mar 12 2018, 1:30 PM

Mar 9 2018

bz created D14635: libsysdecode; mktable fix vmresult table, enhance sigbuscode table.
Mar 9 2018, 9:39 PM

Feb 6 2018

bz committed rS328945: Remove a trailing whitspace..
Remove a trailing whitspace.
Feb 6 2018, 7:14 PM

Jan 30 2018

bz accepted D14129: Export tcp_always_keepalive for use by the Chelsio TOM module..

LGTM (not checked but assume you caught all places)

Jan 30 2018, 12:00 PM

Jan 25 2018

bz added a comment to D4154: Clean up unused bandwidth entry in the TCP hostcache.
Jan 25 2018, 8:11 PM

Jan 23 2018

bz added a comment to D13514: Fix netstat reporting of accepted TCP/IPv6 connections when net.inet6.ip6.v6only=0.

Ok, so I think this is not the complete fix.
The tcp6_usr_bind() code you reference has the additional bits to make this right-er.

Jan 23 2018, 11:05 PM

Jan 14 2018

bz committed rS327968: Remove trailing whitespace..
Remove trailing whitespace.
Jan 14 2018, 3:01 PM

Jan 11 2018

bz accepted D13652: Set vnet when calling pru_sockaddr and pru_peeraddr.

Seems this came in in r271976 with D775 after VIMAGE was in the tree.
You don't need to set the CURVNET() that early (only after the switch) it seems but it shouldn't matter.
Looks OK to me.

Jan 11 2018, 6:06 PM
bz created D13865: Improve comment in socketvar.h.
Jan 11 2018, 5:00 PM

Dec 31 2017

bz committed rS327436: MFC r327435:.
MFC r327435:
Dec 31 2017, 4:52 PM
bz committed rS327435: Happy New Year 2018 my friends!.
Happy New Year 2018 my friends!
Dec 31 2017, 4:48 PM

Dec 17 2017

bz added a comment to D13514: Fix netstat reporting of accepted TCP/IPv6 connections when net.inet6.ip6.v6only=0.

Reading the comment I though "oh so it was actually a bug in netstat" and might squid be doing. Then I saw the patch. This needs a way better description for the commit message! Also a reference to the commit that changed the original behaviour now making this necessary.

Dec 17 2017, 6:51 PM

Dec 7 2017

bz committed rS326665: Use correct field in the description for the lock after r319722..
Use correct field in the description for the lock after r319722.
Dec 7 2017, 7:41 PM

Dec 5 2017

bz accepted D13366: vnic: apply hardware L3 checksum only for IPv4.

LGTM

Dec 5 2017, 9:53 PM

Nov 14 2017

bz committed rS325813: Unbreak IPv6..
Unbreak IPv6.
Nov 14 2017, 4:47 PM

Oct 20 2017

bz added a comment to D12639: Enable VIMAGE by default.

21.10.2017 4:41, bz (Bjoern A. Zeeb) пишет:

+# The `bpf' device enables the Berkeley Packet Filter.
+# Be aware of the administrative consequences of enabling this!
+# Note that 'bpf' is required for DHCP.
+device bpf # Berkeley packet filter

Was this `bpf' chunk committed intentionally?

Oct 20 2017, 10:04 PM
bz committed rS324810: With r181803 on 2008-08-17 23:27:27Z the first VIMAGE commit went into.
With r181803 on 2008-08-17 23:27:27Z the first VIMAGE commit went into
Oct 20 2017, 9:41 PM
bz closed D12639: Enable VIMAGE by default.
Oct 20 2017, 9:41 PM

Oct 12 2017

bz closed D12645: arm: add "rev16" to dissasembly.
Oct 12 2017, 3:54 PM
bz committed rS324562: Add rev16 instruction to the disassembler..
Add rev16 instruction to the disassembler.
Oct 12 2017, 3:54 PM
bz created D12645: arm: add "rev16" to dissasembly.
Oct 12 2017, 3:07 PM
bz committed rS324549: Previously there was a VIRT kernel to which I had added these options..
Previously there was a VIRT kernel to which I had added these options.
Oct 12 2017, 2:33 PM
bz closed D12566: arm: add virtio_pci support for other virtualization environments to GENERIC.
Oct 12 2017, 2:32 PM · ARM
bz added a comment to D12639: Enable VIMAGE by default.
In D12639#262566, @jtl wrote:

I remain concerned about the performance overhead of activating this where not needed. However, I have no performance information to either alleviate or confirm my fears. Has someone done the work to gather performance information to compare a non-VIMAGE kernel to a VIMAGE kernel with a single VNET?

Oct 12 2017, 9:49 AM