- User Since
- Aug 29 2014, 12:11 PM (402 w, 4 d)
Indeed, this review packs two distinct changes. It targets the deterministic cache/lookup result, exactly as you suggested, so all cached/uncached always performs in same fashion. After untangling the ifp/originifp complexities, it resulted in empty if` condition after /* Check for valid scope ID. */, which made me think of simplifying the scope checks code as well. I'll split this diff into two, to simplify reviewing.
Mon, May 16
I am not sure if I currently can review this technically in full but we fixed a similar issue by the code you are currently changing in ef0111fdf364e4e87b522025b13aad69067c3fe6 .
Sat, May 14
I still do not like the idea that layer specifics are inside mbuf structs; I have not committed the @rrs approved https://reviews.freebsd.org/D34298 for reasons that I thought it'll need more discussions.
Wed, May 11
Do we need to bump the FreeBSD version for this - no?
I'd probably say "Dragonfly via drm-kmod" as you obtained it from drm-kmod?
Tue, May 10
Makes more code compile for me too. Thank you!
I'll give this a try tonight as well and have a closer look.
It's one of two missing pieces I need; in theory kfifo is the other one but I think that is used so little that I might simply change the code?
Fri, May 6
Any comment on this one?
Thu, May 5
Wed, May 4
Sat, Apr 30
Wed, Apr 27
Mon, Apr 25
Mon, Apr 18
Apr 15 2022
Apr 14 2022
Was there a PR for this somewhere? If so, please mention that.
While your description is verbose and expressive I still found it a bit hard to follow; if I get it correctly wakeupwaiting calls hostap_newstate in your case; that updates INIT->RUN, calls ieee80211_create_ibss() which in turn ends up in ieee80211_sta_join1() which then triggers the deferred callback for the AP vap where we only see RUN->RUN (and funnily enough calls back into hostap_newstate again which only hits the debug printf.
Apr 12 2022
Apr 11 2022
I trust you to get this right.
I understand the tiny race; I am pondering if it might be worth mentioning it in the comment?
Apr 8 2022
Apr 7 2022
Apr 5 2022
Apr 4 2022
Ignoring all the other things going on now .. do you plan to commit this w/ or w/o the spares to stable/13 within the next 24 hours?
Apr 3 2022
I can confirm that an amd64 releng/13.1 kernel with this does load the i915kms and drm and I get the drmn0 line as well after a short flicker on the screen; I have no X on external USB drive to further test it but the "silent error" seems gone.
Apr 2 2022
Add x11 to subscribers so they know how things proceed.
Can this be two independent changes please?
So after MFCing this drm-kmod binary packages on FreeBSD stable/13 and 13.1-RC1 broke; as per MFC rules I appended the field to the end of the struct. https://cgit.freebsd.org/src/commit/?h=releng/13.1&id=c325d9edeff568d3d38891b2916bd5bd0e9bf8e3 However probe will not run if there is something there which is > 0 and we'll treat it as a probe error.
Apr 1 2022
Mar 31 2022
Okay, tested on my arm64 with 64G of main memory loading if_rtw88:
Mar 30 2022
Add the ability under compat.linuxkpi.debug to also dump the stack in case
of a single-segment mapping error to see the originating driver part
as suggested by @hselasky.