Page MenuHomeFreeBSD

bz (Bjoern A. Zeeb)
User

Projects (12)

User Details

User Since
Aug 29 2014, 12:11 PM (535 w, 4 d)

Recent Activity

Today

bz added inline comments to D47751: rtwn: use ieee80211_ht_check_tx_shortgi_20() and ieee80211_ht_check_tx_shortgi_40().
Tue, Dec 3, 5:16 PM · wireless
bz requested changes to D47751: rtwn: use ieee80211_ht_check_tx_shortgi_20() and ieee80211_ht_check_tx_shortgi_40().
Tue, Dec 3, 2:22 PM · wireless

Yesterday

bz accepted D47747: net80211: add helper functions for determining 11n transmit parameters - AMPDU density/size, short-GI.

Thanks a lot for all the patience and improvements. I like the changes of the last iteration!

Mon, Dec 2, 2:39 AM · wireless
bz committed rGa0e45db6f6eb: contrib/wpa: pass IFM_IEEE80211_VHT5G if vht_enabled on the channel (authored by bz).
contrib/wpa: pass IFM_IEEE80211_VHT5G if vht_enabled on the channel
Mon, Dec 2, 1:57 AM
bz closed D35978: wpa: pass IFM_IEEE80211_VHT5G if vht_enabled on the channel.
Mon, Dec 2, 1:57 AM

Sun, Dec 1

bz committed rG243f6925bf81: net80211: 11ac: add options to manage VHT STBC (authored by bz).
net80211: 11ac: add options to manage VHT STBC
Sun, Dec 1, 10:04 PM
bz closed D47838: net80211: 11ac: add options to manage VHT STBC.
Sun, Dec 1, 10:04 PM
bz committed rG116102101a56: net80211: name IEEE80211_VHTCAP_SUPP_CHAN_WIDTH_{NONE -> NO160} (authored by bz).
net80211: name IEEE80211_VHTCAP_SUPP_CHAN_WIDTH_{NONE -> NO160}
Sun, Dec 1, 9:58 PM
bz closed D47837: net80211: name IEEE80211_VHTCAP_SUPP_CHAN_WIDTH_{NONE -> NO160}.
Sun, Dec 1, 9:58 PM
bz requested review of D47858: net80211: HT: add missing bit descriptions for IEEE80211_AGGR_BITS.
Sun, Dec 1, 8:26 PM
bz requested review of D47857: net80211: HT: check for feature support in ht_recv_action_ht_txchwidth().
Sun, Dec 1, 8:21 PM
bz committed rG4294f1cac153: net80211: add missing reference for struct ieee80211_vht_mcs_info (authored by bz).
net80211: add missing reference for struct ieee80211_vht_mcs_info
Sun, Dec 1, 7:59 PM
bz closed D47836: net80211: add missing reference for struct ieee80211_vht_mcs_info.
Sun, Dec 1, 7:59 PM
bz committed rG943a19c666d6: LinuxKPI: 802.11: make HT compile again (authored by bz).
LinuxKPI: 802.11: make HT compile again
Sun, Dec 1, 7:58 PM
bz committed rG30d2f84ef2cb: LinuxKPI: firmware: change order filenames trying to load firmware (authored by bz).
LinuxKPI: firmware: change order filenames trying to load firmware
Sun, Dec 1, 7:45 PM
bz closed D47682: LinuxKPI: firmware: change order filenames trying to load firmware.
Sun, Dec 1, 7:45 PM
bz accepted D47852: 14.2/relnotes: Add a few more notes about FreeBSD Foundation work.
Sun, Dec 1, 1:43 PM
bz added inline comments to D47747: net80211: add helper functions for determining 11n transmit parameters - AMPDU density/size, short-GI.
Sun, Dec 1, 1:40 AM · wireless
bz added inline comments to D47852: 14.2/relnotes: Add a few more notes about FreeBSD Foundation work.
Sun, Dec 1, 12:58 AM
bz added a comment to D47852: 14.2/relnotes: Add a few more notes about FreeBSD Foundation work.

(also dropped you an email which I had sent to re@) I think but firmware/fwget you covered the FreeBSD Foundation bits.

Sun, Dec 1, 12:25 AM
bz added inline comments to D47852: 14.2/relnotes: Add a few more notes about FreeBSD Foundation work.
Sun, Dec 1, 12:23 AM

Sat, Nov 30

bz accepted D47748: ath: use the new net80211 methods for AMPDU density/limit, short-GI.
Sat, Nov 30, 11:39 PM · wireless
bz requested changes to D47747: net80211: add helper functions for determining 11n transmit parameters - AMPDU density/size, short-GI.
Sat, Nov 30, 11:37 PM · wireless

Fri, Nov 29

bz added inline comments to D47838: net80211: 11ac: add options to manage VHT STBC.
Fri, Nov 29, 12:28 AM
bz requested review of D47838: net80211: 11ac: add options to manage VHT STBC.
Fri, Nov 29, 12:27 AM
bz requested review of D47837: net80211: name IEEE80211_VHTCAP_SUPP_CHAN_WIDTH_{NONE -> NO160}.
Fri, Nov 29, 12:25 AM
bz requested review of D47836: net80211: add missing reference for struct ieee80211_vht_mcs_info.
Fri, Nov 29, 12:24 AM

Thu, Nov 28

bz updated subscribers of D47562: rtwn: Fix RTL8188EU & RTL8192EU cannot associate in STA mode.
Thu, Nov 28, 1:25 AM
bz added inline comments to D47747: net80211: add helper functions for determining 11n transmit parameters - AMPDU density/size, short-GI.
Thu, Nov 28, 1:24 AM · wireless
bz added a comment to D47776: rtwn: enable receiving AMSDU in AMPDU.

Likely fine but should make sure that all the different devices/firmware really can do that.

Thu, Nov 28, 1:15 AM · wireless
bz added a comment to D47775: rtwn: enable FCS in the recive config to work around truncated frames.

Likely fine. But likely also needs testing with a large variety of devices/firmware.

Thu, Nov 28, 1:14 AM · wireless
bz requested changes to D47774: rtwn: fix rtl8812/rtl8821 vht definitions, add VHT calibration/rate control.
Thu, Nov 28, 1:11 AM · wireless
bz requested changes to D47766: rtwn: use ieee80211_ht_get_node_ampdu_density(), fix programming MAX_AGG.
Thu, Nov 28, 1:00 AM · wireless
bz accepted D47755: iwn: use ieee80211_ht_check_tx_ht().
Thu, Nov 28, 12:57 AM · wireless
bz accepted D47754: amrr: remove duplicate logic, use ieee80211_ht_check_tx_ht().
Thu, Nov 28, 12:56 AM · wireless
bz added a comment to D47751: rtwn: use ieee80211_ht_check_tx_shortgi_20() and ieee80211_ht_check_tx_shortgi_40().

Staying tuned; please indicate when done.

Thu, Nov 28, 12:54 AM · wireless
bz accepted D47750: iwn: use ieee80211_ht_check_tx_shortgi_20() and ieee80211_ht_check_tx_shortgi_40().
Thu, Nov 28, 12:53 AM · wireless
bz requested changes to D47748: ath: use the new net80211 methods for AMPDU density/limit, short-GI.
Thu, Nov 28, 12:52 AM · wireless
bz requested changes to D47747: net80211: add helper functions for determining 11n transmit parameters - AMPDU density/size, short-GI.
Thu, Nov 28, 12:48 AM · wireless

Tue, Nov 26

bz added a comment to D47751: rtwn: use ieee80211_ht_check_tx_shortgi_20() and ieee80211_ht_check_tx_shortgi_40().

looking at these, i'm wondering whether the better move is to be doing the channel check inside the helper functions as well. i remember the node channel being .. weirdly sketchy thought. i'll go do some more deep diving on this before it lands.

Tue, Nov 26, 12:29 AM · wireless

Mon, Nov 25

bz added a comment to D35978: wpa: pass IFM_IEEE80211_VHT5G if vht_enabled on the channel.
# ifconfig wlan0
wlan0: flags=8843<UP,BROADCAST,RUNNING,SIMPLEX,MULTICAST> metric 0 mtu 1500
        options=0
        ether 74:13:ea:6e:de:c1
        inet6 fe80::7613:eaff:fe6e:dec1%wlan0 prefixlen 64 scopeid 0x3
        groups: wlan
        ssid abc channel 36 (5180 MHz 11a vht/80+) bssid 9a:9d:7e:76:6f:fa
        regdomain ETSI country DE authmode WPA2/802.11i privacy ON
        deftxkey UNDEF AES-CCM 2:128-bit txpower 23 bmiss 7 mcastrate 6
        mgmtrate 6 scanvalid 60 ampdulimit 64k -amsdutx amsdurx shortgi
        -ldpctx ldpcrx -uapsd vht vht40 vht80 vht160 -vht80p80 wme
        roaming MANUAL
        parent interface: iwlwifi0
        media: IEEE 802.11 Wireless Ethernet autoselect mode 11ac
        status: associated
        nd6 options=23<PERFORMNUD,ACCEPT_RTADV,AUTO_LINKLOCAL>
Mon, Nov 25, 3:22 PM
bz accepted D47716: rc.conf: Update commented examples for lo0 to use CIDR.
Mon, Nov 25, 12:57 PM
bz added a comment to D35978: wpa: pass IFM_IEEE80211_VHT5G if vht_enabled on the channel.

Seems 656d0e8fa92ad72626808479d0935814425ee78d fixed what is reported back back on channel.

Mon, Nov 25, 2:29 AM

Sun, Nov 24

bz added a comment to D35978: wpa: pass IFM_IEEE80211_VHT5G if vht_enabled on the channel.

it's not entirely required because net80211 actually does the HT and VHT upgrade for us. I'll go check it first though to make sure it doesn't cause drama!

Sun, Nov 24, 10:10 PM

Sat, Nov 23

bz added a reviewer for D35978: wpa: pass IFM_IEEE80211_VHT5G if vht_enabled on the channel: wireless.

Adding wireless given @adrian is also working on VHT currently and will need this soon.

Sat, Nov 23, 5:30 PM
bz added a comment to D47380: bsd.licenses.mk: install multi-license with their filename.

How should this proceed?

Sat, Nov 23, 5:27 PM
bz added a reviewer for D47716: rc.conf: Update commented examples for lo0 to use CIDR: emaste.
Sat, Nov 23, 5:25 PM

Fri, Nov 22

bz added a comment to D47682: LinuxKPI: firmware: change order filenames trying to load firmware.
In D47682#1087414, @bz wrote:

I would love that but @manu or @wulf or someone would have to fix the gpu-firmware bits for this. I noticed yesterday that it's still shipping .ko files.

13-STABLE still sticks to *.ko. We have to wait for 13-EOL

Fri, Nov 22, 2:15 PM

Thu, Nov 21

bz committed rG42d33f929925: release: Don't break if firmware install fails (authored by cperciva).
release: Don't break if firmware install fails
Thu, Nov 21, 11:27 PM
bz committed rGc5b8ed13c9ef: release: install wireless firmware onto disc1 and dvd (authored by bz).
release: install wireless firmware onto disc1 and dvd
Thu, Nov 21, 11:27 PM
bz committed rG03c07bdc8b31: bsdinstall: add menu to install firmware (authored by bz).
bsdinstall: add menu to install firmware
Thu, Nov 21, 11:27 PM
bz committed rGcce4df8b3cbc: bsdinstall: wlanconfig: fix interface UP on (re-)starting wpa_supplicant (authored by bz).
bsdinstall: wlanconfig: fix interface UP on (re-)starting wpa_supplicant
Thu, Nov 21, 11:27 PM
bz committed rG15f6edf20e4e: bsdinstall: add menu to install firmware (authored by bz).
bsdinstall: add menu to install firmware
Thu, Nov 21, 12:06 AM
bz committed rG7d0c12e1f907: bsdinstall: wlanconfig: fix interface UP on (re-)starting wpa_supplicant (authored by bz).
bsdinstall: wlanconfig: fix interface UP on (re-)starting wpa_supplicant
Thu, Nov 21, 12:06 AM
bz committed rGb62012538e96: release: install wireless firmware onto disc1 and dvd (authored by bz).
release: install wireless firmware onto disc1 and dvd
Thu, Nov 21, 12:06 AM

Wed, Nov 20

bz updated subscribers of D47682: LinuxKPI: firmware: change order filenames trying to load firmware.

LGTM

Can we simplify this eventually and standardize on only the first case?

Wed, Nov 20, 2:34 PM
bz added a comment to D47409: release: factor out common code from make-memstick.sh.

Thanks for the review; this was based on an earlier attempt to look at release (April this year?) for firmware and trying to figure out how things are put together.
I'll let it sit until at least RC1 is out in case other changes need to be done to avoid conflicts.

Wed, Nov 20, 2:31 PM
bz added inline comments to D47682: LinuxKPI: firmware: change order filenames trying to load firmware.
Wed, Nov 20, 2:27 PM
bz updated the diff for D47682: LinuxKPI: firmware: change order filenames trying to load firmware.

Update comment as pointed out by @emaste.

Wed, Nov 20, 2:27 PM
bz requested review of D47682: LinuxKPI: firmware: change order filenames trying to load firmware.
Wed, Nov 20, 1:17 PM
bz committed rGbbe2a1da2df6: bsdinstall: add menu to install firmware (authored by bz).
bsdinstall: add menu to install firmware
Wed, Nov 20, 1:11 PM
bz closed D47491: bsdinstall: add menu to install firmware.
Wed, Nov 20, 1:11 PM
bz committed rG7e2996c1f5b4: release: install wireless firmware onto disc1 and dvd (authored by bz).
release: install wireless firmware onto disc1 and dvd
Wed, Nov 20, 1:06 PM
bz closed D47407: release: install wireless firmware onto disc1 and dvd.
Wed, Nov 20, 1:06 PM
bz updated the diff for D47407: release: install wireless firmware onto disc1 and dvd.

"cleanup" the PKGCMD bits as requested by @jrtc27 .
I have not tested NO_ROOT again.

Wed, Nov 20, 3:14 AM
bz added inline comments to D47491: bsdinstall: add menu to install firmware.
Wed, Nov 20, 2:23 AM
bz updated the diff for D47491: bsdinstall: add menu to install firmware.

Implement --pause with a 5 second delay as suggested by @jrtc27.

Wed, Nov 20, 2:22 AM
bz added inline comments to D47491: bsdinstall: add menu to install firmware.
Wed, Nov 20, 1:46 AM
bz added inline comments to D47491: bsdinstall: add menu to install firmware.
Wed, Nov 20, 1:21 AM
bz added inline comments to D47491: bsdinstall: add menu to install firmware.
Wed, Nov 20, 12:38 AM
bz updated the diff for D47407: release: install wireless firmware onto disc1 and dvd.

Remove the bits about the broken NO_ROOT bit.

Wed, Nov 20, 12:36 AM

Tue, Nov 19

bz accepted D47666: dpaa2: Fix kernel built with ACPI_DEBUG.
Tue, Nov 19, 3:07 PM
bz committed rG5252ae96ad2d: man4: wifi manuals: revise .Sh HARDWARE + polish some (authored by concussious.bugzilla_runbox.com).
man4: wifi manuals: revise .Sh HARDWARE + polish some
Tue, Nov 19, 12:40 AM
bz committed rGdc647e4df990: fwget: add -q for quiet output (authored by bz).
fwget: add -q for quiet output
Tue, Nov 19, 12:39 AM
bz committed rG8c6df7ead19c: release: add wifi-firmware-kmod@release to ship as package (authored by bz).
release: add wifi-firmware-kmod@release to ship as package
Tue, Nov 19, 12:39 AM
bz committed rGde5496958c86: LinuxKPI: lockdep fix #includes (authored by bz).
LinuxKPI: lockdep fix #includes
Tue, Nov 19, 12:39 AM
bz added a comment to D47666: dpaa2: Fix kernel built with ACPI_DEBUG.
In D47666#1086828, @dsl wrote:

I can build a kernel with ACPI_DEBUG without any troubles, but my Honeycomb has to be revived. Could you give it a try @phk @bz ?

Tue, Nov 19, 12:19 AM
bz updated the summary of D47491: bsdinstall: add menu to install firmware.
Tue, Nov 19, 12:11 AM
bz updated the diff for D47491: bsdinstall: add menu to install firmware.

The wlanconfig change got committed as 5399052c63a7a3d2f54615d31bfd092ab887a600
and the description was locally removed from the commit message.

Tue, Nov 19, 12:11 AM
bz reopened D47491: bsdinstall: add menu to install firmware.
Tue, Nov 19, 12:11 AM
bz closed D47491: bsdinstall: add menu to install firmware.
Tue, Nov 19, 12:08 AM
bz committed rG5399052c63a7: bsdinstall: wlanconfig: fix interface UP on (re-)starting wpa_supplicant (authored by bz).
bsdinstall: wlanconfig: fix interface UP on (re-)starting wpa_supplicant
Tue, Nov 19, 12:08 AM

Mon, Nov 18

bz added inline comments to D47491: bsdinstall: add menu to install firmware.
Mon, Nov 18, 6:37 PM
bz added inline comments to D47491: bsdinstall: add menu to install firmware.
Mon, Nov 18, 6:37 PM
bz added inline comments to D47491: bsdinstall: add menu to install firmware.
Mon, Nov 18, 5:59 PM
bz added a comment to D47407: release: install wireless firmware onto disc1 and dvd.

Unless releng has any objections I'll commit this around Tue 19.11. afternoon UTC.
I would still hope releng to comment on it before if not at least by accepting or requesting changes.

Mon, Nov 18, 10:05 AM
bz added a comment to D47491: bsdinstall: add menu to install firmware.

Unless there'll be any comments I'll commit this around Tue 19.11. afternoon UTC

Mon, Nov 18, 10:03 AM
bz added a comment to D47500: net80211: migrate FC0_TYPE_MASK / FC0_SUBTYPE_MASK frame type checks to macros.

landed

Mon, Nov 18, 10:01 AM · wireless
bz added a comment to D47655: uath: flush data/commands to the firmware before changing channel / state.

I don't know what your nice 8 core laptop is but again I am also not sure why it matters. Please write a proper commit message.

Mon, Nov 18, 9:59 AM · wireless
bz requested changes to D47654: usb: fix the ID for the dual-band Wistron AR5523 USB NIC.

Can you please write a normal descriptive commit message.

Mon, Nov 18, 9:56 AM · wireless

Sun, Nov 17

bz added inline comments to D47645: net80211: add IEEE80211_IS_QOS_NULL().
Sun, Nov 17, 6:00 PM · wireless

Thu, Nov 14

bz added a comment to D47407: release: install wireless firmware onto disc1 and dvd.

Do we still want this (and the accompanying bsdinstall change) in 14.2-R or not? As otherwise I'll have to add rtw89 firmware at least there.

Thu, Nov 14, 9:11 PM
bz added a comment to D47491: bsdinstall: add menu to install firmware.

In case you know anyone else who could review this please add them!

Thu, Nov 14, 9:10 PM
bz added a comment to D47562: rtwn: Fix RTL8188EU & RTL8192EU cannot associate in STA mode.

Can this be simplified to simply check if uc_delay_us is > 0? Otherwise from scrolling through uc_write_delay would be a bool or are we expecting more values?

Thu, Nov 14, 2:48 AM
bz added inline comments to D47522: rtwn: change the USB TX transfers to only do one pending transfer per endpoint.
Thu, Nov 14, 2:09 AM · wireless
bz committed rG6c140ba1266b: man4: wifi manuals: revise .Sh HARDWARE + polish some (authored by concussious.bugzilla_runbox.com).
man4: wifi manuals: revise .Sh HARDWARE + polish some
Thu, Nov 14, 1:54 AM
bz committed rG7ff741003780: iwlwifi: script to extract firmware details (authored by bz).
iwlwifi: script to extract firmware details
Thu, Nov 14, 1:54 AM
bz committed rGa27b3695d123: LinuxKPI: 802.11: improvements to (*ampdu_action)() callers (authored by bz).
LinuxKPI: 802.11: improvements to (*ampdu_action)() callers
Thu, Nov 14, 1:54 AM
bz committed rGce5b0b7b991f: LinuxKPI: 802.11: hookup net80211 callbacks dependent on (*ampdu_action)() (authored by bz).
LinuxKPI: 802.11: hookup net80211 callbacks dependent on (*ampdu_action)()
Thu, Nov 14, 1:54 AM
bz committed rG8d9b4e219f5a: LinuxKPI: 802.11: improve lladdr change to not use ifnet internals (authored by bz).
LinuxKPI: 802.11: improve lladdr change to not use ifnet internals
Thu, Nov 14, 1:54 AM