- User Since
- Aug 29 2014, 12:11 PM (285 w, 4 d)
Mon, Feb 17
Use a macros to check if the vnet is shutting down in if.c.
Sun, Feb 16
Any comments on this? I'd love to get the change out of my tree soon..
I am also interested in "this is what we were thinking of" comments.
Anyone any further comments on this? I'd love to commit it the next days.
Fri, Feb 14
Wed, Jan 29
Update the change factoring out the fdt logic to resemble the USB one.
Is this what you were thinking of?
Address reviewer comments.
Tue, Jan 28
In general I like the idea. Still need to touch network drivers but changing a single macro seems way better to me. It's also easily grep-able.
I have a follow-up question to all this stuff which I do not understand yet:
Fri, Jan 24
Wed, Jan 22
One small nit on a comment.
Tue, Jan 21
It's extremely hard in Phabricator to follow the changes between the last round and this so I am not sure I found all the changes fixed and comments done.
Can you please update the diff? I doen't apply cleanly to head (anymore):
Jan 17 2020
Hi Glebius, I have a patch which tried to remove recursions within netinet6. I was down to one in December and since new ones have shown up. I am not sure if I'll be able to look at this one before next week but I'll try to upload my current work in progress in case that'll help you. I have EPOCH calls around all ip6_output() calls which this one equally adds, so most of my changes should be "downstream" from yours.
Jan 12 2020
Jan 11 2020
Jan 10 2020
I'll be happy to have a look (probably next week and once the redirect stuff is in)
I've not looked at the test cases (yet) in particular detail.
There's 2 or 3 functional questions, most is just comments and whitespace.
Jan 9 2020
The AF can be set in in6_inithead() already but I understand if you want to do all in the callers together; sounds like a good compromise for an MFC :-) Thanks!
Thank you so much for splitting this out. It really helps a lot! спасибо большой!
Jan 8 2020
For @hselasky: this does not yet fix the vnet0 issue. That'll be sorted out after this.
Jan 7 2020
I've a patch with this + the LLVM changes running on arm64 for a bit:
Jan 5 2020
I'll go ahead and commit it anyway; I think the is no need to refine the review again.
Jan 3 2020
Seems this needs someone to commit it; I'll try to do this afternoon (timezone unspecified ;-)).
Jan 2 2020
I have a very annoying question: how much extra work would it be to split this up into: (a) adding rib_fibnum, rib_family and rib_vnet fields and changing the KPI for them by adding them to the current calls and then (b) adding the new functionality (and changing the support function logic beyond just passing the extra fields around)?
It would make the change history much more clear and also make it easier to review things.
Dec 18 2019
The v6 change looks ok to me for as much as I still understand the code.
I was wondering if we can have a man page along with this as my first question was "what kind of driver is this?" Sadly the description of this review doesn't say much.
Dec 17 2019
Dec 6 2019
I'l split this up into a couple of chunks so we can more easily do the base infrastructure for the llatbl changes for IPv6 and the IPv4.
The rtr and prefix parts are unrelated to that.