bz (Bjoern A. Zeeb)
User

Projects

User Details

User Since
Aug 29 2014, 12:11 PM (177 w, 1 d)

Recent Activity

Sun, Jan 14

bz committed rS327968: Remove trailing whitespace..
Remove trailing whitespace.
Sun, Jan 14, 3:01 PM

Thu, Jan 11

bz accepted D13652: Set vnet when calling pru_sockaddr and pru_peeraddr.

Seems this came in in r271976 with D775 after VIMAGE was in the tree.
You don't need to set the CURVNET() that early (only after the switch) it seems but it shouldn't matter.
Looks OK to me.

Thu, Jan 11, 6:06 PM
bz created D13865: Improve comment in socketvar.h.
Thu, Jan 11, 5:00 PM

Sun, Dec 31

bz committed rS327436: MFC r327435:.
MFC r327435:
Sun, Dec 31, 4:52 PM
bz committed rS327435: Happy New Year 2018 my friends!.
Happy New Year 2018 my friends!
Sun, Dec 31, 4:48 PM

Dec 17 2017

bz added a comment to D13514: Fix netstat reporting of accepted TCP/IPv6 connections when net.inet6.ip6.v6only=0.

Reading the comment I though "oh so it was actually a bug in netstat" and might squid be doing. Then I saw the patch. This needs a way better description for the commit message! Also a reference to the commit that changed the original behaviour now making this necessary.

Dec 17 2017, 6:51 PM

Dec 7 2017

bz committed rS326665: Use correct field in the description for the lock after r319722..
Use correct field in the description for the lock after r319722.
Dec 7 2017, 7:41 PM

Dec 5 2017

bz accepted D13366: vnic: apply hardware L3 checksum only for IPv4.

LGTM

Dec 5 2017, 9:53 PM

Nov 14 2017

bz committed rS325813: Unbreak IPv6..
Unbreak IPv6.
Nov 14 2017, 4:47 PM

Oct 20 2017

bz added a comment to D12639: Enable VIMAGE by default.

21.10.2017 4:41, bz (Bjoern A. Zeeb) пишет:

+# The `bpf' device enables the Berkeley Packet Filter.
+# Be aware of the administrative consequences of enabling this!
+# Note that 'bpf' is required for DHCP.
+device bpf # Berkeley packet filter

Was this `bpf' chunk committed intentionally?

Oct 20 2017, 10:04 PM
bz committed rS324810: With r181803 on 2008-08-17 23:27:27Z the first VIMAGE commit went into.
With r181803 on 2008-08-17 23:27:27Z the first VIMAGE commit went into
Oct 20 2017, 9:41 PM
bz closed D12639: Enable VIMAGE by default.
Oct 20 2017, 9:41 PM

Oct 12 2017

bz closed D12645: arm: add "rev16" to dissasembly.
Oct 12 2017, 3:54 PM
bz committed rS324562: Add rev16 instruction to the disassembler..
Add rev16 instruction to the disassembler.
Oct 12 2017, 3:54 PM
bz created D12645: arm: add "rev16" to dissasembly.
Oct 12 2017, 3:07 PM
bz committed rS324549: Previously there was a VIRT kernel to which I had added these options..
Previously there was a VIRT kernel to which I had added these options.
Oct 12 2017, 2:33 PM
bz closed D12566: arm: add virtio_pci support for other virtualization environments to GENERIC.
Oct 12 2017, 2:32 PM · ARM
bz added a comment to D12639: Enable VIMAGE by default.
In D12639#262566, @jtl wrote:

I remain concerned about the performance overhead of activating this where not needed. However, I have no performance information to either alleviate or confirm my fears. Has someone done the work to gather performance information to compare a non-VIMAGE kernel to a VIMAGE kernel with a single VNET?

Oct 12 2017, 9:49 AM

Oct 11 2017

bz created D12639: Enable VIMAGE by default.
Oct 11 2017, 4:22 PM

Oct 6 2017

bz added a comment to D12615: Mbuf external storage improvements..

Just from the proposed commit message this smells like it should be at least two or three individual changes and commits, e.g., mb_dupcl() sounds like it's a standalone change?

Oct 6 2017, 8:35 PM

Oct 2 2017

bz created D12566: arm: add virtio_pci support for other virtualization environments to GENERIC.
Oct 2 2017, 12:55 PM · ARM

Sep 25 2017

bz resigned from D12487: Combine LROed mbufs for a single call to if_input().

I think chaining mbufs together after doing LRO re-assembly is asking for too much.
It took a while to get all the different HW LRO cases sorted out; this is likely just going to add extra delay?

Sep 25 2017, 9:50 PM
bz requested changes to D12492: Ensure strict error handling of tcp_usr_send.

Just asking for the whitespace changes ;)

Sep 25 2017, 9:46 PM
bz accepted D12430: tcp: Don't "negotiate" MSS..
Sep 25 2017, 11:14 AM

Aug 13 2017

bz accepted D11782: bpf: Fix incorrect cleanup.

I'd say go ahead for now; seems to make life better at least.

Aug 13 2017, 12:13 PM · network

Jul 30 2017

bz added a comment to D11782: bpf: Fix incorrect cleanup.

I think your description could be a bit more clear as I got confused. I think after re-reading it I now understand what you mean. Can you try to describe the sequence of events step by step here on how this gets triggered (especially how the new entry appears before we set it to NULL overwriting a new one?)?

Jul 30 2017, 9:54 PM · network
bz added a comment to D11782: bpf: Fix incorrect cleanup.

Is this a consequence of https://svnweb.freebsd.org/base?view=revision&revision=297816 or independent of it?

Jul 30 2017, 4:22 PM · network

Jul 27 2017

bz committed rS321618: After inpcb route caching was put back in place there is no need for.
After inpcb route caching was put back in place there is no need for
Jul 27 2017, 1:04 PM
bz closed D11448: Remove flowtable from ^head by committing rS321618: After inpcb route caching was put back in place there is no need for.
Jul 27 2017, 1:04 PM

Jul 21 2017

bz abandoned D10067: X86 pmap_qenter needs to always invalidate.

Close for now; still need to track down but ETIME currently.

Jul 21 2017, 8:39 AM

Jul 2 2017

bz created D11448: Remove flowtable from ^head.
Jul 2 2017, 11:40 AM

Jun 14 2017

bz updated subscribers of D11111: Hide struct unpcb under #ifdef _KERNEL..

I am very much with @jhb in this case. Having written DDB and netstat support to easily, quickly, and without the need to think debug problems without having to switch the tool I normally use for system administration is a big plus.

Jun 14 2017, 1:17 AM

Jun 10 2017

bz requested changes to D11111: Hide struct unpcb under #ifdef _KERNEL..

Well a python script won't help me with a base system crashdump on boot if it's not installed.

Jun 10 2017, 3:00 PM

Jun 9 2017

bz added a comment to D11111: Hide struct unpcb under #ifdef _KERNEL..

if you drop support from netstat what's the alternative to get this information out of crashdumps then?

Jun 9 2017, 7:52 AM

Jun 8 2017

bz added a comment to D10910: Fix HWPMC interrupt handling in Counting Mode.

Thanks for the #define !

Jun 8 2017, 1:17 PM · ARM
bz added a comment to D10909: Add detection of CPU class for ARMv6/v7.

Hmm I wonder if the entire struct can be exposed rather than just the class as not all "CPU_CLASS_CORTEXA" are the same and hwpmc will want to choose depending on .. hmm never mind; it's reading that directly from a register, so this will be fine. Thanks for doing it!

Jun 8 2017, 1:16 PM · ARM

May 26 2017

bz requested changes to D10936: Fix static analysis errors in IPv6 code.

Can you make a first patch which is just "Remove unused variables"? That way removing the functional changes is a lot easier.
Also when you have to go back in 5 years and wonder what this all was.

May 26 2017, 3:18 PM
bz resigned from D10910: Fix HWPMC interrupt handling in Counting Mode.

The 0xff should probably a #define somewhere but that's unrelated. I think we've done something similar for the timer code in the past; not sure in which review or tree that ended up.

May 26 2017, 1:31 PM · ARM
bz added a comment to D10909: Add detection of CPU class for ARMv6/v7.

I have had the same diff in my local tree for ages. I am sure I mentioned it somewhere (bug report, follow-up to the commit, or just IRC).

May 26 2017, 1:29 PM · ARM

May 19 2017

bz accepted D9163: Fix connect() when used fro TCP sockets in combination with IPv4-mapped IPv6 addresses.

Go!

May 19 2017, 5:34 PM

May 18 2017

bz added a comment to D10686: Improve layout of struct inpcb.

Did the other changes get in already or are they in a different review? I will try to see what this one does in a different setup during the next days (I hope).

May 18 2017, 4:42 PM
bz requested changes to D10776: Make Capsicum obligatory..

I really don't like the idea of losing the #ifdefs.
There are people how are trying to figure out the costs of these things (like me, possibly for CAPSICUM) and having the ifdef really helps.

May 18 2017, 4:37 PM

May 12 2017

bz requested changes to D10686: Improve layout of struct inpcb.

Could this please be multiple individual changes.
The function argument change is completely independent of the struct reordering.

May 12 2017, 12:57 PM
bz committed rS318237: MFC r318015:.
MFC r318015:
May 12 2017, 11:41 AM

May 9 2017

bz committed rS318015: Adjust a comment..
Adjust a comment.
May 9 2017, 8:30 AM

May 7 2017

bz added a comment to D9163: Fix connect() when used fro TCP sockets in combination with IPv4-mapped IPv6 addresses.

Have you tested this for various combinations, including unbound sockets?
I think in case of unbound sockets this will no longer work, as I don't think INP_IPV[46] would be set at that point yet, are they?

May 7 2017, 3:19 PM

May 5 2017

bz added a comment to D9163: Fix connect() when used fro TCP sockets in combination with IPv4-mapped IPv6 addresses.

So, looking at http://fxr.watson.org/fxr/source/netinet/tcp_usrreq.c#L317 (tcp6_usr_bind) I see we clearly set INP_IPV[46] depending on whether (a) it's IPv6 only, (b) it's a v4mapped address on an IPv6 socket, or (c) worst case to check it's an IPv6 socket with an unspecified address (in which case we (unless people use BINDANY (case I did not check) will always bind to an IPv6 address).

May 5 2017, 3:50 PM

May 4 2017

bz added a comment to D9163: Fix connect() when used fro TCP sockets in combination with IPv4-mapped IPv6 addresses.

Does udp6_connect() have a similar problem to tcp6_usr_connect()? Looks like it.

May 4 2017, 4:56 PM

Apr 27 2017

bz added a comment to D10499: Add support for optional CRC32c instructions on armv8.

I am confused by the description of "with checksum offloading disabled" on a loopback interface. Did you mean to say that you force it to calculate the checksums on loopback rather than just setting the flag that checksums are ok as would be the default? I think it would be good to re-phrase this as there is no "offloading" on loopback.

Apr 27 2017, 12:56 PM

Apr 6 2017

bz added a comment to D10272: Improve handling of syncookies.

@tuexen right, assume you run with syn-cookies only, how do you mitigate the replay; I thought that is the actual problem we are looking at (whether or not there is a syn-cache in use).

Apr 6 2017, 10:06 PM
bz added a comment to D10272: Improve handling of syncookies.

Question: do we add time dependent bits somewhere so we could simply check if the syn-cookie itself is outside a possible replay-window? I know this does not entirely close the race, but I don't see how this would differ from the proposed "global" solution but would be working independent on whether a syn-cache is also used or not. Am I completely missing a point here? I think 4987 mentioned something along these lines but it's been ages since I last looked at SYN problems.

Apr 6 2017, 9:38 PM

Mar 21 2017

bz added a comment to D10067: X86 pmap_qenter needs to always invalidate.

See reference [1]

Mar 21 2017, 8:15 PM

Mar 20 2017

bz added a comment to D10067: X86 pmap_qenter needs to always invalidate.

This is on a single CPU. Can you please give me a reference for "the page walks must be coherent" as my understanding from the cited pages and the blog post referenced is that they must not be.

Mar 20 2017, 9:12 PM
bz added a comment to D10067: X86 pmap_qenter needs to always invalidate.

@kib ok, this may be a secondary problem; change my sentence to "Analysing what happened we found that with the out-of-order CPU model we would kick off the page table walker and find the 0 pte entry." The problem remains that the store has not been committed yet and a speculative walk will only see the old (zero) pte.

Mar 20 2017, 8:32 PM
bz updated subscribers of D10067: X86 pmap_qenter needs to always invalidate.

Add Robert to Cc:

Mar 20 2017, 8:13 PM
bz created D10067: X86 pmap_qenter needs to always invalidate.
Mar 20 2017, 8:12 PM

Mar 18 2017

bz created D10046: tunefs: fix error message and catch additional error.
Mar 18 2017, 3:51 PM

Mar 17 2017

bz accepted D10040: pf: Fix memory leak on vnet shutdown or unload.

It is unclear to me why I had chosen the different order in r302156 but on a quick glance this looks OK.

Mar 17 2017, 10:19 PM

Mar 1 2017

bz added a reviewer for D9649: Enable VNET operations for ifconfig and route: jamie.
Mar 1 2017, 11:56 PM · network

Feb 28 2017

bz committed rS314396: Properly indent a default: label and avoid crashing when running.
Properly indent a default: label and avoid crashing when running
Feb 28 2017, 6:10 PM

Feb 14 2017

bz committed rS313714: Use %s __func__ to print the actual function name (been looking at.
Use %s __func__ to print the actual function name (been looking at
Feb 14 2017, 1:20 AM

Feb 10 2017

bz committed rS313557: Allow Dtrace to be compiled into the kernel again after r313177..
Allow Dtrace to be compiled into the kernel again after r313177.
Feb 10 2017, 4:06 PM

Jan 27 2017

bz added a reviewer for D9356: solisten: separate listening sockets from data flow sockets: rwatson.

Just on principle. Too bad Sam 's not here.

Jan 27 2017, 7:40 AM

Jan 23 2017

bz committed rS312668: Remove a static function declaration for a function not implemented..
Remove a static function declaration for a function not implemented.
Jan 23 2017, 4:40 PM

Jan 19 2017

bz committed rS312413: MFC r311950:.
MFC r311950:
Jan 19 2017, 3:28 PM

Jan 14 2017

bz added a comment to D9163: Fix connect() when used fro TCP sockets in combination with IPv4-mapped IPv6 addresses.

https://tools.ietf.org/html/rfc4291#section-2.5.5

Jan 14 2017, 3:29 PM
bz added a comment to D9163: Fix connect() when used fro TCP sockets in combination with IPv4-mapped IPv6 addresses.

I should add that I used the "request changes" because I want clarification first. You will notice that just swapping out the macros will not really make sense in both cases.

Jan 14 2017, 3:28 PM
bz requested changes to D9163: Fix connect() when used fro TCP sockets in combination with IPv4-mapped IPv6 addresses.

Stupid question; why are you using the COMPAT macro and not the IN6_IS_ADDR_V4MAPPED()?
Seems you are talking one thing but testing another?

Jan 14 2017, 3:26 PM

Jan 13 2017

bz accepted D9150: Add kevent EVFILT_EMPTY for notification when a client has received all data.
Jan 13 2017, 10:35 PM
bz added a reviewer for D9163: Fix connect() when used fro TCP sockets in combination with IPv4-mapped IPv6 addresses: hrs.
Jan 13 2017, 1:32 AM

Jan 12 2017

bz requested changes to D9150: Add kevent EVFILT_EMPTY for notification when a client has received all data.

otherwise looks good.

Jan 12 2017, 10:07 PM
bz committed rS311950: Get rid of a compiler warning which I saw too often..
Get rid of a compiler warning which I saw too often.
Jan 12 2017, 12:01 AM

Jan 11 2017

bz accepted D9149: readelf: add S390 relocation types.

Thanks! :)

Jan 11 2017, 10:47 PM
bz accepted D9053: Remove writability requirement for single-mbuf, contiguous-range m_pulldown().

I'd say get it in and @rwatson and I can figure out the other bits...

Jan 11 2017, 8:13 PM

Jan 10 2017

bz committed rS311876: Teach crunchide about EM_S390 to make bootstrapping from future.
Teach crunchide about EM_S390 to make bootstrapping from future
Jan 10 2017, 2:40 PM

Jan 7 2017

bz added a comment to D9053: Remove writability requirement for single-mbuf, contiguous-range m_pulldown().

Ok, just for my understanding, can you confirm that the commit message really means "if m_pullup does not have to do anything, then the mbuf does not need to be writeable"? Or in other words "if the requested memory region is already contiguous and nothing needs to change, the mbuf does not need to be writeable"?

Jan 7 2017, 9:17 PM

Jan 5 2017

bz accepted D9047: sysctl net.inet.tcp.hostcache.list in a jail can see connections from other jails and the host. Proposed patch fixes that..

You can also just use Submitted by: bz

Jan 5 2017, 8:21 AM

Dec 11 2016

bz accepted D8527: Implement ip6_tryforward().

I've not read in detail through the ip6_fastfwd.c code but I am fine with the other changes.

Dec 11 2016, 8:47 PM

Dec 10 2016

bz added a comment to D8737: TSO handling in IPv6 when ip options are present..

I guess it's just my way of seeing things:
(1) fixing the check on options which is wrong
(2) as a consequence fixing possible TSO problems that might currently occur.

Dec 10 2016, 12:56 PM

Dec 9 2016

bz accepted D8737: TSO handling in IPv6 when ip options are present..

Seems like this is a more conservative solution to avoid possible offload problems.

Dec 9 2016, 3:20 PM

Dec 5 2016

bz added inline comments to D8527: Implement ip6_tryforward().
Dec 5 2016, 3:26 PM
bz requested changes to D8527: Implement ip6_tryforward().

This is multiple independent changes. The "rcvif" statistics changes are all non-functional noise to my understanding and should be factored out and committed separately. It'll help to review the functional changes a lot easier.

Dec 5 2016, 1:59 PM

Nov 17 2016

bz committed rS308748: Writing out the L2TP control packet requires 12 bytes of.
Writing out the L2TP control packet requires 12 bytes of
Nov 17 2016, 2:03 PM

Sep 28 2016

bz added a comment to D8053: Properly preserve ip_tos bits for IPv4 packets.

Just a random comment...

Sep 28 2016, 12:26 PM

Sep 14 2016

bz committed rS305811: Try to fix LINT builds after r305807. Seems to be a simple s&r error.
Try to fix LINT builds after r305807. Seems to be a simple s&r error
Sep 14 2016, 4:08 PM

Aug 31 2016

bz committed rS305119: After r305113, try to properly replace the magic numbers with.
After r305113, try to properly replace the magic numbers with
Aug 31 2016, 10:45 AM

Aug 28 2016

bz committed rS304956: Back out r304907, Ed had fixed it apparently earlier in the cloudabi*.
Back out r304907, Ed had fixed it apparently earlier in the cloudabi*
Aug 28 2016, 12:05 PM

Aug 27 2016

bz committed rS304907: Do not try to build cloudabi32 for pc98..
Do not try to build cloudabi32 for pc98.
Aug 27 2016, 12:41 PM

Aug 21 2016

bz committed rS304572: Remove the kernel optoion for IPSEC_FILTERTUNNEL, which was deprecated.
Remove the kernel optoion for IPSEC_FILTERTUNNEL, which was deprecated
Aug 21 2016, 6:55 PM

Aug 18 2016

bz committed rS304378: Try to fix gcc compilation errors (which are right)..
Try to fix gcc compilation errors (which are right).
Aug 18 2016, 10:26 AM

Aug 16 2016

bz added a comment to D7493: INTRNG: Rework handling with resources, partially revert r301453. .

I did not review the change but for arm64 things seem to be working again:

Aug 16 2016, 1:53 PM
bz added a comment to D7493: INTRNG: Rework handling with resources, partially revert r301453. .

I downloaded the raw diff in the best way I could and applying it to HEAD I get:

Aug 16 2016, 10:19 AM

Aug 11 2016

bz committed rS303963: Revert r303890 for now here as camdd fails to build on powerpc*.
Revert r303890 for now here as camdd fails to build on powerpc*
Aug 11 2016, 3:06 PM

Jul 30 2016

bz committed rS303560: Rename devname to udevname after including stdlib.h in r303445.
Rename devname to udevname after including stdlib.h in r303445
Jul 30 2016, 8:39 PM
bz committed rS303559: Try to declare _hw_pci for all sysctl cases needed after r303497..
Try to declare _hw_pci for all sysctl cases needed after r303497.
Jul 30 2016, 8:31 PM

Jul 26 2016

bz accepted D7272: Rework IPv6 TCP path MTU discovery to match IPv4.

Given I am only asking for an extra comment, this seems to look OK to me. I have not tested or applied the patch.

Jul 26 2016, 12:55 PM
bz added inline comments to D7272: Rework IPv6 TCP path MTU discovery to match IPv4.
Jul 26 2016, 12:53 PM

Jul 17 2016

bz requested changes to D7227: Fix unlocked access to ifnet address list.

If I am not mistaken the function calls are for modules (especially 3rd party) while we should use the macros in the kernel (unless I misremember something here)?

Jul 17 2016, 6:52 PM

Jul 14 2016

bz added a comment to D7209: [Bug 211031] [panic] in ng_uncallout when argument is NULL.

Is this sudden problem possibly related to glebius' callout changes? I am not properly tracking things but if invariants changed and weren't reflected in the callers, that might explain.

Jul 14 2016, 11:47 PM

Jul 6 2016

bz committed rS302370: Only set the ipfilter running state to 'not running' if we are.
Only set the ipfilter running state to 'not running' if we are
Jul 6 2016, 10:29 AM