Page MenuHomeFreeBSD

bz (Bjoern A. Zeeb)
User

Projects (8)

User Details

User Since
Aug 29 2014, 12:11 PM (517 w, 19 h)

Recent Activity

Yesterday

bz committed rG1f7df7570174: LinuxKPI: move __kmalloc from slab.h to slab.c (authored by bz).
LinuxKPI: move __kmalloc from slab.h to slab.c
Fri, Jul 26, 11:52 AM
bz closed D45815: LinuxKPI: move __kmalloc from slab.h to slab.c.
Fri, Jul 26, 11:52 AM
bz updated the diff for D45815: LinuxKPI: move __kmalloc from slab.h to slab.c.

Updating for reference after rebase; also changed linuxkpi_ to lkpi_
as per recent discussions until we have a README.

Fri, Jul 26, 11:33 AM
bz added a comment to D45815: LinuxKPI: move __kmalloc from slab.h to slab.c.

If no one replies this will go in on Monday.

Fri, Jul 26, 11:16 AM
bz committed rG9776aba34576: net80211: scan/internal: change boolean argument from int to bool (authored by bz).
net80211: scan/internal: change boolean argument from int to bool
Fri, Jul 26, 11:10 AM
bz closed D45816: net80211: scan/internal: change boolean argument from int to bool.
Fri, Jul 26, 11:09 AM
bz committed rGc179937b986e: libc/getnameinfo: stop adding NI_NUMERICHOST where inappropriate (authored by bz).
libc/getnameinfo: stop adding NI_NUMERICHOST where inappropriate
Fri, Jul 26, 11:05 AM
bz closed D45547: libc/getnameinfo: stop adding NI_NUMERICHOST where inappropriate.
Fri, Jul 26, 11:05 AM
bz committed rG5668c22a13c6: LinuxKPI/lindebugfs: stop panicing in lindebugfs, fix simple_read_from_buffer (authored by bz).
LinuxKPI/lindebugfs: stop panicing in lindebugfs, fix simple_read_from_buffer
Fri, Jul 26, 10:57 AM
bz closed D45755: LinuxKPI/lindebugfs: stop panicing in lindebugfs, fix simple_read_from_buffer.
Fri, Jul 26, 10:57 AM
bz closed D46099: Deprecate contigfree(9) in favour of free(9).

No idea why auto-close did not work.

Fri, Jul 26, 10:52 AM
bz closed D46101: kern_malloc: fold free and zfree together into one __always_inline func.
Fri, Jul 26, 10:48 AM
bz committed rG4fab5f005482: kern_malloc: fold free and zfree together into one __always_inline func (authored by bz).
kern_malloc: fold free and zfree together into one __always_inline func
Fri, Jul 26, 10:48 AM
bz committed rGd1bdc2821fcd: Deprecate contigfree(9) in favour of free(9) (authored by bz).
Deprecate contigfree(9) in favour of free(9)
Fri, Jul 26, 10:47 AM
bz added a comment to D45755: LinuxKPI/lindebugfs: stop panicing in lindebugfs, fix simple_read_from_buffer.
In D45755#1050226, @bz wrote:

Anyone? Anyone who can test the Intel debug on drm code?

I just compiled with this patch and read/wrote to a bunch of debugfs files that I verified working in the past. I found no unexpected errors. Looks good to me.

Fri, Jul 26, 10:38 AM
bz added a reviewer for D46145: linuxkpi: Small tweaks to _ONCE macros: linuxkpi.

Please see 046d8d89ed1956944b12ec4f0580c30bc202bbfb . Seems you are reverting that.

Fri, Jul 26, 10:37 AM

Thu, Jul 25

bz accepted D46136: netinet6 tests: Add a regression test for default router handling.

Only scrolled through but looks good

Thu, Jul 25, 8:52 PM
bz closed D46121: LinuxKPI: 802.11: support manual lladdr changes.
Thu, Jul 25, 6:44 PM
bz committed rG4aff4048f5b1: LinuxKPI: 802.11: support manual lladdr changes (authored by bz).
LinuxKPI: 802.11: support manual lladdr changes
Thu, Jul 25, 6:44 PM
bz closed D45817: arm64: turn on IEEE80211 debugging and IEEE80211_SUPPORT_MESH too.
Thu, Jul 25, 4:43 PM
bz committed rGe8fe3b9e731d: arm64: turn on IEEE80211 debugging and IEEE80211_SUPPORT_MESH too (authored by bz).
arm64: turn on IEEE80211 debugging and IEEE80211_SUPPORT_MESH too
Thu, Jul 25, 4:43 PM
bz committed rG59d262fe969a: LinuxKPI: 802.11 compile in debugging based on IEEE80211 debugging (authored by bz).
LinuxKPI: 802.11 compile in debugging based on IEEE80211 debugging
Thu, Jul 25, 4:22 PM
bz closed D45820: LinuxKPI: 802.11 compile in debugging based on IEEE80211 debugging.
Thu, Jul 25, 4:21 PM
bz added a comment to D46099: Deprecate contigfree(9) in favour of free(9).
In D46099#1051506, @pho wrote:

I ran stress tests for 10 hours with D46099.141332.patch. I did not observe any issues.

Thu, Jul 25, 3:05 PM
bz committed rGdb8b3578627b: LinuxKPI: 802.11: implement ieee80211_sn_*() (authored by bz).
LinuxKPI: 802.11: implement ieee80211_sn_*()
Thu, Jul 25, 3:05 PM
bz closed D45819: LinuxKPI: 802.11: implement ieee80211_sn_*().
Thu, Jul 25, 3:05 PM
bz committed rGbd206a6f4a87: LinuxKPI: 802.11: consistently spell TRACE-RX: as such (authored by bz).
LinuxKPI: 802.11: consistently spell TRACE-RX: as such
Thu, Jul 25, 1:54 PM
bz closed D45818: LinuxKPI: 802.11: consistently spell TRACE-RX: as such.
Thu, Jul 25, 1:54 PM
bz accepted D46020: nd6: Fix the routing table subscription.

I am happy with it for now.
If someone wants to refine it (and write a regression test for it) then I think they can in main afterwards.

Thu, Jul 25, 1:01 PM
bz updated the diff for D46101: kern_malloc: fold free and zfree together into one __always_inline func.

Remove kasan_mark calls as per @markj

Thu, Jul 25, 12:55 PM
bz committed rG4d8c65b466fc: LinuxKPI: remove dummy kstrtox.h (authored by bz).
LinuxKPI: remove dummy kstrtox.h
Thu, Jul 25, 12:44 PM
bz added inline comments to D46124: net/wifi-firmware-*: build framework and license hack cleanup.
Thu, Jul 25, 12:12 PM
bz added a comment to D45369: net/wifi-firmware-kmod: [WIP] Attempt to simplify wifi-firmware ports.

Hi Joe,

Thu, Jul 25, 12:10 PM
bz requested review of D46124: net/wifi-firmware-*: build framework and license hack cleanup.
Thu, Jul 25, 12:09 PM
bz requested review of D46121: LinuxKPI: 802.11: support manual lladdr changes.
Thu, Jul 25, 8:09 AM
bz added inline comments to D46020: nd6: Fix the routing table subscription.
Thu, Jul 25, 7:18 AM

Wed, Jul 24

bz updated the diff for D46099: Deprecate contigfree(9) in favour of free(9).

Address comments from @kib and @imp

Wed, Jul 24, 9:05 PM
bz added a comment to D46099: Deprecate contigfree(9) in favour of free(9).

@kib @imp I removed the BURN_BRIDGES (will come with the other changes in a few minutes); almost want an attribute __deprecated. I wonder how (other) big projects annotate deprecated APIs to yield warnings on use...

Wed, Jul 24, 9:00 PM
bz updated the diff for D46101: kern_malloc: fold free and zfree together into one __always_inline func.

u_long -> uintptr_t

Wed, Jul 24, 4:23 PM
bz added a comment to D46101: kern_malloc: fold free and zfree together into one __always_inline func.

Done locally.

Wed, Jul 24, 4:21 PM
bz updated the diff for D46099: Deprecate contigfree(9) in favour of free(9).

Address comments from @kib (I left the bridges alone but I agree a better name would be appreciated)

Wed, Jul 24, 4:15 PM
bz added inline comments to D46099: Deprecate contigfree(9) in favour of free(9).
Wed, Jul 24, 4:15 PM
bz requested review of D46101: kern_malloc: fold free and zfree together into one __always_inline func.
Wed, Jul 24, 3:59 PM
bz added a comment to D46099: Deprecate contigfree(9) in favour of free(9).

I've run a make tinderbox and I tried to remove any variables only used to hold the length for contigfree but nothing else; I did punt at one point (vmci code) and did not track all callers of vmci_free_kernel_mem().

Wed, Jul 24, 3:17 PM
bz requested review of D46099: Deprecate contigfree(9) in favour of free(9).
Wed, Jul 24, 3:16 PM
bz added inline comments to D45981: sys: Stop requiring nested parentheses for KASSERT.
Wed, Jul 24, 2:25 PM
bz committed rGc0df224ba5b1: kern_malloc: remove '.' and '\n' from KASSERT/panic (authored by bz).
kern_malloc: remove '.' and '\n' from KASSERT/panic
Wed, Jul 24, 10:20 AM
bz closed D46093: kern_malloc: remove '.' and '\n' from KASSERT/panic.
Wed, Jul 24, 10:20 AM
bz committed rG9e6544dd6e02: malloc(9): extend contigmalloc(9) by a "slab cookie" (authored by bz).
malloc(9): extend contigmalloc(9) by a "slab cookie"
Wed, Jul 24, 10:20 AM
bz closed D45812: malloc(9): extend contigmalloc(9) by a "slab cookie".
Wed, Jul 24, 10:20 AM

Tue, Jul 23

bz requested review of D46093: kern_malloc: remove '.' and '\n' from KASSERT/panic.
Tue, Jul 23, 6:29 PM
bz added a comment to D45812: malloc(9): extend contigmalloc(9) by a "slab cookie".

If this version is still good it would be great to just get that checkbox again and I'll put the 3 suggested follow-up changes out as well.

Tue, Jul 23, 6:25 PM
bz added inline comments to D45812: malloc(9): extend contigmalloc(9) by a "slab cookie".
Tue, Jul 23, 4:29 PM
bz updated the diff for D45812: malloc(9): extend contigmalloc(9) by a "slab cookie".

Address comments from @markj and @kib

Tue, Jul 23, 4:29 PM
bz added inline comments to D45812: malloc(9): extend contigmalloc(9) by a "slab cookie".
Tue, Jul 23, 12:22 PM
bz updated the diff for D45812: malloc(9): extend contigmalloc(9) by a "slab cookie".

Try to address all the comments from @markj

Tue, Jul 23, 11:05 AM

Mon, Jul 22

bz added a comment to D45812: malloc(9): extend contigmalloc(9) by a "slab cookie".

I've locally implemented all the suggestions (Thanks a lot!).

Mon, Jul 22, 8:33 PM
bz added a comment to D45756: net80211: IEEE80211_FEXT_SCAN_OFFLOAD conditions for bgscan.
In D45756#1050213, @bz wrote:

if you wait n channels * 300ms or so (say 10s), does a follow-up scan then still work or work again if you were to type scan once a second?

It remains FAIL-BUSY on a few tries over 60+ seconds.

Mon, Jul 22, 7:23 PM
bz added a comment to D45815: LinuxKPI: move __kmalloc from slab.h to slab.c.

Anyone?

Mon, Jul 22, 7:19 PM
bz planned changes to D45812: malloc(9): extend contigmalloc(9) by a "slab cookie".

Mark state to address Mark's comments.

Mon, Jul 22, 7:19 PM
bz added a comment to D45755: LinuxKPI/lindebugfs: stop panicing in lindebugfs, fix simple_read_from_buffer.

Anyone? Anyone who can test the Intel debug on drm code?

Mon, Jul 22, 7:18 PM
bz added a comment to D45756: net80211: IEEE80211_FEXT_SCAN_OFFLOAD conditions for bgscan.

I got:

> scan
OK

(a moment later)

> scan
FAIL-BUSY
Mon, Jul 22, 7:02 PM

Tue, Jul 16

bz added a comment to D45756: net80211: IEEE80211_FEXT_SCAN_OFFLOAD conditions for bgscan.

Is there anything specific you'd like to see for testing this?

Tue, Jul 16, 9:35 PM

Fri, Jul 12

bz added a comment to D45888: loader: Bump all versions to 3.0.
In D45888#1047565, @imp wrote:
In D45888#1047564, @bz wrote:
In D45888#1047563, @imp wrote:
In D45888#1047562, @bz wrote:

Can we please make sure pxeboot is small enough (again) before doing that bump so that we know that was a usable version at least

This won't change that... last i checked we were good with the text only loader as the payload for sure and the full graphics loader looked to be small enough.

I was just saying given whatever we currently install as pxeboot barfed on a Supermicro X10SRG-F (mercat) in the TestCluster a few days ago and I had to revert to an old version lying around somewhere again.

Ah. This is orthogonal... at worst you’ll get a this boot loader needs to be updated message.. it's harmless...

The other issue may be worth pursuing elsewhere though

Fri, Jul 12, 4:03 AM
bz added a comment to D45888: loader: Bump all versions to 3.0.
In D45888#1047563, @imp wrote:
In D45888#1047562, @bz wrote:

Can we please make sure pxeboot is small enough (again) before doing that bump so that we know that was a usable version at least

This won't change that... last i checked we were good with the text only loader as the payload for sure and the full graphics loader looked to be small enough.

Fri, Jul 12, 2:37 AM
bz added a comment to D45888: loader: Bump all versions to 3.0.

Can we please make sure pxeboot is small enough (again) before doing that bump so that we know that was a usable version at least?

Fri, Jul 12, 2:06 AM

Tue, Jul 9

bz added inline comments to D45813: LinuxKPI: skbuff: adjust to updated malloc/contigmalloc and free(9)..
Tue, Jul 9, 5:27 PM
bz accepted D45905: LinuxKPI: Fix resource leak on pci_iounmap-ing of PCI BAR.
Tue, Jul 9, 12:12 PM
bz accepted D45906: LinuxKPI: Automatically enable drm support for devices named "drmn".

Is the plan to remove linux_pci_[un]register_drm_driver() then in the future?

Tue, Jul 9, 12:10 PM
bz accepted D45904: LinuxKPI: Add pci_iomap_range function.
Tue, Jul 9, 11:54 AM

Sun, Jun 30

bz updated the diff for D45547: libc/getnameinfo: stop adding NI_NUMERICHOST where inappropriate.

Update based on 'The Open Group Base Specifications Issue 7, 2018 edition'
as per updated link in the description.

Sun, Jun 30, 10:47 PM
bz requested review of D45820: LinuxKPI: 802.11 compile in debugging based on IEEE80211 debugging.
Sun, Jun 30, 9:36 PM
bz requested review of D45819: LinuxKPI: 802.11: implement ieee80211_sn_*().
Sun, Jun 30, 9:34 PM
bz requested review of D45818: LinuxKPI: 802.11: consistently spell TRACE-RX: as such.
Sun, Jun 30, 9:31 PM
bz requested review of D45817: arm64: turn on IEEE80211 debugging and IEEE80211_SUPPORT_MESH too.
Sun, Jun 30, 9:28 PM
bz requested review of D45816: net80211: scan/internal: change boolean argument from int to bool.
Sun, Jun 30, 9:22 PM
bz requested review of D45815: LinuxKPI: move __kmalloc from slab.h to slab.c.
Sun, Jun 30, 8:49 PM
bz added inline comments to D45813: LinuxKPI: skbuff: adjust to updated malloc/contigmalloc and free(9)..
Sun, Jun 30, 8:32 PM
bz updated the summary of D45813: LinuxKPI: skbuff: adjust to updated malloc/contigmalloc and free(9)..
Sun, Jun 30, 8:09 PM
bz requested review of D45813: LinuxKPI: skbuff: adjust to updated malloc/contigmalloc and free(9)..
Sun, Jun 30, 7:52 PM
bz requested review of D45812: malloc(9): extend contigmalloc(9) by a "slab cookie".
Sun, Jun 30, 7:27 PM

Thu, Jun 27

bz requested review of D45756: net80211: IEEE80211_FEXT_SCAN_OFFLOAD conditions for bgscan.
Thu, Jun 27, 12:46 PM
bz requested review of D45755: LinuxKPI/lindebugfs: stop panicing in lindebugfs, fix simple_read_from_buffer.
Thu, Jun 27, 12:29 PM

Jun 22 2024

bz accepted D45613: LinuxKPI: Add linux/nodemask.h.
Jun 22 2024, 5:37 PM
bz accepted D45692: LinuxKPI: Remove linux/sched.h include from linux/kernel.h header.
Jun 22 2024, 5:37 PM

Jun 19 2024

bz added a comment to D45646: sys/arm: Remove armv6 kernel configs.

Thanks for doing all this finding all bittlies and places!

Jun 19 2024, 8:51 PM

Jun 18 2024

bz added inline comments to D45369: net/wifi-firmware-kmod: [WIP] Attempt to simplify wifi-firmware ports.
Jun 18 2024, 9:15 AM

Jun 17 2024

bz added inline comments to D45516: net80211: migrate the group/unicast key check into inline functions.
Jun 17 2024, 11:46 PM · wireless
bz planned changes to D45547: libc/getnameinfo: stop adding NI_NUMERICHOST where inappropriate.
Jun 17 2024, 2:11 PM
bz added inline comments to D45547: libc/getnameinfo: stop adding NI_NUMERICHOST where inappropriate.
Jun 17 2024, 2:03 PM
bz added a reviewer for D45547: libc/getnameinfo: stop adding NI_NUMERICHOST where inappropriate: emaste.

Add Ed for the OpenSSH dependency (problem).

Jun 17 2024, 2:02 PM
bz added inline comments to D45547: libc/getnameinfo: stop adding NI_NUMERICHOST where inappropriate.
Jun 17 2024, 2:02 PM
bz requested changes to D45516: net80211: migrate the group/unicast key check into inline functions.
Jun 17 2024, 9:54 AM · wireless
bz added inline comments to D45613: LinuxKPI: Add linux/nodemask.h.
Jun 17 2024, 9:45 AM
bz requested changes to D45616: LinuxKPI: Add kvrealloc to linux/slab.h.
Jun 17 2024, 9:44 AM
bz added inline comments to D45613: LinuxKPI: Add linux/nodemask.h.
Jun 17 2024, 9:38 AM
bz accepted D45612: LinuxKPI: Add header polution to compile linux/numa.h.
Jun 17 2024, 9:36 AM
bz requested changes to D45613: LinuxKPI: Add linux/nodemask.h.
Jun 17 2024, 9:34 AM

Jun 14 2024

bz committed rG07da0ad63aa5: LinuxKPI: 802.11: make sure we can send DISASSOC or DEAUTH frames (authored by bz).
LinuxKPI: 802.11: make sure we can send DISASSOC or DEAUTH frames
Jun 14 2024, 6:43 PM
bz committed rGcafefba48125: LinuxKPI: 802.11: close race lkpi_sta_scan_to_auth()/(*iv_update_bss)() (authored by bz).
LinuxKPI: 802.11: close race lkpi_sta_scan_to_auth()/(*iv_update_bss)()
Jun 14 2024, 6:43 PM