Page MenuHomeFreeBSD

bz (Bjoern A. Zeeb)
User

Projects (10)

User Details

User Since
Aug 29 2014, 12:11 PM (340 w, 1 d)

Recent Activity

Yesterday

bz updated the summary of D26545: net80211: split up ieee80211_probereq().
Sat, Mar 6, 9:25 PM
bz added a reviewer for D26545: net80211: split up ieee80211_probereq(): philip.
Sat, Mar 6, 9:24 PM
bz updated the diff for D26545: net80211: split up ieee80211_probereq().

No longer exporting _len(); seems we do not need that publicly.
Add a bool option to alloc the ie space which we may need for
other uses (such as LinuxKPI).
Cleanup.

Sat, Mar 6, 9:24 PM

Sun, Feb 28

bz added inline comments to D25999: lib80211: Start adding 11ac ETSI bits to regdomain.xml.
Sun, Feb 28, 11:19 PM
bz committed R10:a9cc796fa73d: net80211: rx_stats add 160Mhz channel width. (authored by bz).
net80211: rx_stats add 160Mhz channel width.
Sun, Feb 28, 7:37 PM

Wed, Feb 24

bz accepted D28918: net: remove legacy in_addmulti().

Looks ok to me; Do we assume that no kmods from port would still use this?

Wed, Feb 24, 5:30 PM
bz edited reviewers for D25999: lib80211: Start adding 11ac ETSI bits to regdomain.xml, added: philip; removed: wireless.
Wed, Feb 24, 2:50 PM

Feb 2 2021

bz committed R9:32e2174cf3cf: Document my bump for 1300139 and try to document mjg's missing one. (authored by bz).
Document my bump for 1300139 and try to document mjg's missing one.
Feb 2 2021, 12:25 PM
bz committed R10:4d85bfa41202: __FreeBSD_version: update the references to the doc tree (authored by bz).
__FreeBSD_version: update the references to the doc tree
Feb 2 2021, 12:04 PM
bz committed R10:91a07ed50ffc: Bump __FreeBSD_version for multiple LinuxKPI updates conflicting (authored by bz).
Bump __FreeBSD_version for multiple LinuxKPI updates conflicting
Feb 2 2021, 12:04 PM
bz committed R10:ff119f7c4a38: LinuxKPI: implement devres() framework parts and two examples (authored by bz).
LinuxKPI: implement devres() framework parts and two examples
Feb 2 2021, 12:03 PM
bz committed R10:3ac9e87b762c: LinuxKPI: enhance PCI bits for DRM (authored by bz).
LinuxKPI: enhance PCI bits for DRM
Feb 2 2021, 12:03 PM
bz committed R10:ec06521ee872: LinuxKPI: upstream a collection of drm-kmod conflicting changes (authored by bz).
LinuxKPI: upstream a collection of drm-kmod conflicting changes
Feb 2 2021, 12:03 PM
bz committed R10:ffd05df71796: LinuxKPI: add firmware loading support (authored by bz).
LinuxKPI: add firmware loading support
Feb 2 2021, 12:02 PM

Feb 1 2021

bz committed R10:b760436e1381: firmware(9): extend firmware_get() by a "no warn" flag. (authored by bz).
firmware(9): extend firmware_get() by a "no warn" flag.
Feb 1 2021, 7:23 AM

Jan 30 2021

bz committed R10:4a26380ba6dc: LinuxKPI: add module dependency on firmware(9) (authored by bz).
LinuxKPI: add module dependency on firmware(9)
Jan 30 2021, 6:03 PM
bz added a comment to D27876: jail: Add pr_state to struct prison.

In general looks ok to me; didn't entirely review it. "Glanced-at-by: bz"

Jan 30 2021, 11:50 AM

Jan 29 2021

bz added a comment to D28419: Require allprison_lock and prison mutex when to free last prison reference.

Oki doki. Continue as you want. "Glanced-at-by: bz"

Jan 29 2021, 9:34 PM
bz added a comment to D28419: Require allprison_lock and prison mutex when to free last prison reference.

I haven't fully checked all cases but in general LGTM.

Jan 29 2021, 9:08 PM
bz added a comment to D26598: linuxkpi: upstream drm-kmod conflicting changes.

Thanks for pointing this out!

Jan 29 2021, 12:23 PM
bz committed R10:abd619045a54: __FreeBSD_version: update the references to the doc tree (authored by bz).
__FreeBSD_version: update the references to the doc tree
Jan 29 2021, 11:08 AM

Jan 28 2021

bz committed R9:df4fdb99eb0b: Document __FreeBSD_version 1400003 (authored by bz).
Document __FreeBSD_version 1400003
Jan 28 2021, 5:33 PM
bz committed R10:fa765ca73e55: LinuxKPI: implement devres() framework parts and two examples (authored by bz).
LinuxKPI: implement devres() framework parts and two examples
Jan 28 2021, 4:48 PM
bz committed R10:d386f3a3c32f: Bump __FreeBSD_version for multiple LinuxKPI updates conflicting (authored by bz).
Bump __FreeBSD_version for multiple LinuxKPI updates conflicting
Jan 28 2021, 4:48 PM
bz closed D28189: LinuxKPI: implement devres() framework parts and two examples.
Jan 28 2021, 4:48 PM
bz closed D28188: linuxkpi: enhance various PCI bits.
Jan 28 2021, 4:47 PM
bz committed R10:1fac2cb4d6e5: LinuxKPI: enhance PCI bits for DRM (authored by bz).
LinuxKPI: enhance PCI bits for DRM
Jan 28 2021, 4:47 PM
bz closed D26598: linuxkpi: upstream drm-kmod conflicting changes.
Jan 28 2021, 4:47 PM
bz committed R10:4abbf816bf06: LinuxKPI: upstream a collection of drm-kmod conflicting changes (authored by bz).
LinuxKPI: upstream a collection of drm-kmod conflicting changes
Jan 28 2021, 4:47 PM
bz closed D27414: linuxkpi: add firmware loading support.
Jan 28 2021, 4:47 PM
bz committed R10:a6c2507d1bae: LinuxKPI: add firmware loading support (authored by bz).
LinuxKPI: add firmware loading support
Jan 28 2021, 4:47 PM
bz added inline comments to D28150: jail: Don't allow resurrection of dead jails.
Jan 28 2021, 1:27 PM

Jan 27 2021

bz added inline comments to D28150: jail: Don't allow resurrection of dead jails.
Jan 27 2021, 10:56 PM
bz added a comment to D28150: jail: Don't allow resurrection of dead jails.

I am not sure I like the idea of making jid's a first-class citizen just because our mgmt interface once did and we kept it for historic purpose and backward compat and habits are hard to change.

Jan 27 2021, 9:17 PM
bz committed R10:6f65b505468a: firmware(9): extend firmware_get() by a "no warn" flag. (authored by bz).
firmware(9): extend firmware_get() by a "no warn" flag.
Jan 27 2021, 2:01 PM
bz closed D27413: firmware(9): extend firmware_get () by a "no warn" flag..
Jan 27 2021, 2:01 PM
bz updated the diff for D26598: linuxkpi: upstream drm-kmod conflicting changes.

Use 0/1 instead of false/true for the IS_*() macros so that prepocessor
directives (#if) are more happy.

Jan 27 2021, 1:39 PM

Jan 26 2021

bz added a comment to D26598: linuxkpi: upstream drm-kmod conflicting changes.

@hselasky I think the only way to avoid this problem in the future is to audit Makefiles for everything and then insist on all of the option being defined and then I'd be happy to come back to your suggestion and enforce it.

Jan 26 2021, 8:46 PM
bz added inline comments to D26598: linuxkpi: upstream drm-kmod conflicting changes.
Jan 26 2021, 3:49 PM
bz added a comment to D26598: linuxkpi: upstream drm-kmod conflicting changes.
Jan 26 2021, 3:47 PM
bz added a comment to D26598: linuxkpi: upstream drm-kmod conflicting changes.

Thanks @hselasky . Can you clarify on this one a bit more?

Jan 26 2021, 12:14 AM

Jan 25 2021

bz added a comment to D27413: firmware(9): extend firmware_get () by a "no warn" flag..

Thanks @markj ! Does it look good now?

Jan 25 2021, 10:53 PM
bz updated the diff for D27413: firmware(9): extend firmware_get () by a "no warn" flag..

Address comments from @markj.
Bump .Dd date in man page to tomorrow.

Jan 25 2021, 10:51 PM

Jan 22 2021

bz added a reviewer for D26598: linuxkpi: upstream drm-kmod conflicting changes: linuxkpi.

Anyone any last comments; I'd love to commit this before Monday.

Jan 22 2021, 1:21 PM
bz added a comment to D28188: linuxkpi: enhance various PCI bits.

Anyone any last comments; I'd love to commit this before Monday.

Jan 22 2021, 1:20 PM
bz added a comment to D27414: linuxkpi: add firmware loading support.

Anyone any last comments; I'd love to commit this before Monday.

Jan 22 2021, 1:20 PM
bz added a reviewer for D27413: firmware(9): extend firmware_get () by a "no warn" flag.: network.

Anyone any last comments; I'd love to commit this before Monday.

Jan 22 2021, 1:20 PM

Jan 16 2021

bz updated the diff for D28189: LinuxKPI: implement devres() framework parts and two examples.

Moved devres framework and k*alloc release function into its own implementation
file as requested. For now leave headers as they are; may reconsider when
bringing in more devres consumers.

Jan 16 2021, 9:49 PM
bz added inline comments to D28189: LinuxKPI: implement devres() framework parts and two examples.
Jan 16 2021, 10:59 AM
bz retitled D28188: linuxkpi: enhance various PCI bits from linuxkpi: ehance various PCI bits to linuxkpi: enhance various PCI bits.
Jan 16 2021, 12:05 AM
bz updated the diff for D26598: linuxkpi: upstream drm-kmod conflicting changes.

In addition to firmware changes, also the PCI and devres changes
got factored out into the respective child reviews now.

Jan 16 2021, 12:02 AM

Jan 15 2021

bz requested review of D28189: LinuxKPI: implement devres() framework parts and two examples.
Jan 15 2021, 11:58 PM
bz requested review of D28188: linuxkpi: enhance various PCI bits.
Jan 15 2021, 11:44 PM
bz added a comment to D26598: linuxkpi: upstream drm-kmod conflicting changes.
In D26598#629837, @manu wrote:

TBH this is to big for me to review, if you could split the review based on the commits (as I hope you didn't commit this whole thing in one commit) that would be easier to review.

Jan 15 2021, 7:38 PM
bz added a comment to D27414: linuxkpi: add firmware loading support.

@manu works for Intel.

Jan 15 2021, 7:23 PM
bz updated the diff for D27414: linuxkpi: add firmware loading support.

Changes since last:

  • add request_firmware_direct() needed by DRM.
Jan 15 2021, 7:21 PM
bz updated the diff for D26598: linuxkpi: upstream drm-kmod conflicting changes.

Changes since the last one:

  • I hope I addressed all comments some way
  • firmware changes are in D27414 now (update in a few minutes)
  • Cleaned up some PCI bits migrated more parts into lkpifill_pci_dev()
  • That plus a dev release function allows DRM to also work with "dev/kobj" magic and get the proper cleanup; the current code is still a short-cut but one I think we can live with. pci_dev_put() seems to do the right thing and I can still unload i915kms.ko.
  • Implemented the devres bits we need for devm_k*alloc() and devm_kasprintf() and the DRM parts (I do have more devres cleanup in my local tree but that's unrelated to DRM so will come later to keep this one smaller).
Jan 15 2021, 7:12 PM

Jan 14 2021

bz added a reviewer for D27414: linuxkpi: add firmware loading support: manu.

@manu, did we come to the conclusion last year that currently doing this all natively was not always working and we are going with this one as the next (first) step? I'd love to commit this as soon as firmware(9) changes are in and D26598 is updated and accepted, so that we don't have to update DRM ports too often.

Jan 14 2021, 7:37 PM
bz updated the diff for D27413: firmware(9): extend firmware_get () by a "no warn" flag..

Update reveting the check @markj pointed out.
Also updating date of man page for tomorrow.

Jan 14 2021, 7:07 PM
bz added a comment to D27413: firmware(9): extend firmware_get () by a "no warn" flag..

I'll get @markj's request in. Anything else as I'd like to commit it the next days (once I have all my workspaces and branches over to main).

Jan 14 2021, 6:20 PM
bz added a comment to D27876: jail: Add pr_state to struct prison.

In theory I like this change. Can you please upload it with full context either using arc or if doing diff file upload using -U10000?

Jan 14 2021, 12:34 PM

Jan 7 2021

bz added a comment to D22012: Import dhcpcd(8) version 8.1.0 into FreeBSD base..

I think it might help the discussion to update the review here to the latest version?

Jan 7 2021, 4:56 PM

Jan 6 2021

bz accepted D27960: linuxkpi: handle ARI.

Looks ok to me; I don't particularly like the special cases but it seems fine.

Jan 6 2021, 10:16 PM

Jan 2 2021

bz accepted D27728: linuxkpi: Add shrinker support.

Looks good scrolling through now.

Jan 2 2021, 1:56 PM

Dec 30 2020

bz accepted D27850: rsu: Don't modify read-only firmware block..
Dec 30 2020, 10:00 PM

Dec 28 2020

bz added inline comments to D26735: Improve loading of multipage aligned buffers..
Dec 28 2020, 3:03 PM
bz reopened D26735: Improve loading of multipage aligned buffers..
Dec 28 2020, 1:30 PM

Dec 22 2020

bz added inline comments to D27550: linuxkpi: Add more pci functions needed by DRM.
Dec 22 2020, 7:26 PM
bz added inline comments to D27728: linuxkpi: Add shrinker support.
Dec 22 2020, 7:12 PM

Dec 17 2020

bz added inline comments to D26598: linuxkpi: upstream drm-kmod conflicting changes.
Dec 17 2020, 9:39 PM
bz added inline comments to D27631: Streamline infiniband code according to ethernet code.
Dec 17 2020, 7:30 PM
bz added inline comments to D27631: Streamline infiniband code according to ethernet code.
Dec 17 2020, 1:41 PM

Dec 13 2020

bz committed R9:a7616bc14729: Conventions and Traditions commit (authored by bz).
Conventions and Traditions commit
Dec 13 2020, 6:43 PM
bz committed R9:8c408947e9fe: Conventions and Traditions commit (authored by bz).
Conventions and Traditions commit
Dec 13 2020, 6:43 PM
bz committed R9:2a14a9f59032: Update to me new key which has been around for a while now. (authored by bz).
Update to me new key which has been around for a while now.
Dec 13 2020, 6:12 PM
bz committed R9:e0b695590ac6: Document bump of __FreeBSD_version after multi-IPv6/v6/no-IP jail commit. (authored by bz).
Document bump of __FreeBSD_version after multi-IPv6/v6/no-IP jail commit.
Dec 13 2020, 6:09 PM
bz committed R9:d869ce57049c: __FreeBSD_version updates: (authored by bz).
__FreeBSD_version updates:
Dec 13 2020, 6:02 PM
bz committed R9:992aca449ba9: Correct typo: s,enmabling,enabling, (authored by bz).
Correct typo: s,enmabling,enabling,
Dec 13 2020, 6:02 PM
bz committed R9:4b7b7c902d8b: Revert 800097 and fold it into 800096 as we decremented it again in HEAD (authored by bz).
Revert 800097 and fold it into 800096 as we decremented it again in HEAD
Dec 13 2020, 6:01 PM
bz committed R9:25ef6de04cef: Document __FreeBSD_version 800044. (authored by bz).
Document __FreeBSD_version 800044.
Dec 13 2020, 5:47 PM
bz committed R9:364a2cc186fd: Document bump of __FreeBSD_version after multi-IPv4/v6/no-IP jail merge (authored by bz).
Document bump of __FreeBSD_version after multi-IPv4/v6/no-IP jail merge
Dec 13 2020, 5:42 PM
bz committed R9:e9b37499f508: Updates from __FreeBSD_version: (authored by bz).
Updates from __FreeBSD_version:
Dec 13 2020, 5:39 PM
bz committed R9:221a08c59933: Document __FreeBSD_version 800098 - 800100. (authored by bz).
Document __FreeBSD_version 800098 - 800100.
Dec 13 2020, 5:39 PM
bz committed R9:16dc041744da: Add dates for 8.1-RELEASE: Released on July 23, 2010, EoL on July 31, 2012. (authored by bz).
Add dates for 8.1-RELEASE: Released on July 23, 2010, EoL on July 31, 2012.
Dec 13 2020, 5:29 PM
bz committed R9:aea8993bdc00: Happy New Year 2011. (authored by bz).
Happy New Year 2011.
Dec 13 2020, 5:25 PM

Dec 11 2020

bz accepted D27550: linuxkpi: Add more pci functions needed by DRM.

I haven't tested it but this looks good, and thank you for harmonising the alloc! Much appreciated!
I think you may want to wait for @hselasky or @kib for the mlx[45] changes as well. (I mention as neither of them is a linuxkpi member yet from what I can see).

Dec 11 2020, 3:05 PM

Dec 10 2020

bz added inline comments to D27550: linuxkpi: Add more pci functions needed by DRM.
Dec 10 2020, 10:30 PM
bz added inline comments to D27550: linuxkpi: Add more pci functions needed by DRM.
Dec 10 2020, 7:38 PM
bz added a reviewer for D26545: net80211: split up ieee80211_probereq(): martin_NetBSD.org.
Dec 10 2020, 12:42 PM

Dec 7 2020

bz added a watcher for cam: bz.
Dec 7 2020, 12:36 PM

Dec 4 2020

bz abandoned D27436: linuxkpi: pci check for resource disabled to avoid probing.

While we should review the drivers doing this thing in probe requests, I'll go with the tunable, which sounds fine to me for now.
Thanks a lot for the discussion.

Dec 4 2020, 11:43 PM

Dec 2 2020

bz updated subscribers of D27436: linuxkpi: pci check for resource disabled to avoid probing.

So why do you need that? This hasn't come up in 20 odd years, so we should understand why first...

We've never provided anything like that, nor has it been needed... so I'd like to understand the use case.

devctl can do it after the fact, of course...

I wrote something that lets you change the PNP info for a device to allow it to masquerade as an old device. But never completely fixed it...

But you are asking for something new. Something drivers should know nothing about. You are asking really for the ability to tie a device to a driver in some way. There are many issues with this since most drivers can only attach to specific cards.

Dec 2 2020, 9:00 PM

Dec 1 2020

bz edited reviewers for D27436: linuxkpi: pci check for resource disabled to avoid probing, added: imp, grehan, jhb; removed: linuxkpi.

The topic has shifted so shift audience a bit as well.

Dec 1 2020, 10:40 PM
bz added a comment to D27436: linuxkpi: pci check for resource disabled to avoid probing.

Do we have any way of doing that user-controlled (and not by probe priority as that's not user controlled and you cannot just toggle left or right) [when you need both drivers attached to different devices]?

Dec 1 2020, 10:38 PM
bz added a comment to D27436: linuxkpi: pci check for resource disabled to avoid probing.
In D27436#613059, @imp wrote:

The reason it needs to be in attach, and not probe, is that we set the device to the next available unit in probe. If we reject this device, the unit isn't consumed so the next time we have a device with the same name / unit we'll reject it too and never claim any. This makes it hard to disable only the first one, for example...

Dec 1 2020, 10:02 PM
bz closed D27434: umass: add quirk to not probe.
Dec 1 2020, 6:24 PM
bz committed rS368246: USB umass: add quirk to not probe.
USB umass: add quirk to not probe
Dec 1 2020, 6:24 PM
bz requested review of D27436: linuxkpi: pci check for resource disabled to avoid probing.
Dec 1 2020, 1:11 PM
bz added a comment to D27434: umass: add quirk to not probe.

The order of the enumeration list doesn't matter. It is exported to user-space as strings.

Dec 1 2020, 11:46 AM
bz added a comment to D27434: umass: add quirk to not probe.

I am not sure if I can sort the new quirk type into the middle of the enum list or if I should rather add it to the end?

Dec 1 2020, 9:38 AM