Page MenuHomeFreeBSD

bz (Bjoern A. Zeeb)
User

Projects (8)

User Details

User Since
Aug 29 2014, 12:11 PM (508 w, 4 d)

Recent Activity

Yesterday

bz requested review of D45386: LinuxKPI: remove extern from function declarations.
Mon, May 27, 8:03 PM

Sun, May 26

bz added a comment to D45369: net/wifi-firmware-kmod: [WIP] Attempt to simplify wifi-firmware ports.

Thanks a lot for doing it and taking the time. It was last year and the this year hard for anything to step up despite that I had asked at some point on wireless (interested parties) and added ports committers as subscribers.

Sun, May 26, 4:42 PM
bz added a comment to D45369: net/wifi-firmware-kmod: [WIP] Attempt to simplify wifi-firmware ports.

I compared this to a pre-flavor version I had (which never was in Phab).
Flavors were an after-though for this revision after manu requested the firmware to be broken up in D44918.

Sun, May 26, 4:42 PM

Sat, May 25

bz added inline comments to D45179: mt7601U.
Sat, May 25, 1:00 AM
bz added inline comments to D45358: LinuxKPI: pm: add SET_SYSTEM_SLEEP_PM_OPS() and device_can_wakeup().
Sat, May 25, 12:09 AM
bz requested review of D45358: LinuxKPI: pm: add SET_SYSTEM_SLEEP_PM_OPS() and device_can_wakeup().
Sat, May 25, 12:08 AM

Fri, May 24

bz added a comment to D44865: linuxkpi: Allow ida_destroy and idr_destroy to be called multiple times.
In D44865#1034261, @imp wrote:

git arc patch -c might work too

Fri, May 24, 12:19 AM
bz added inline comments to D43967: LinuxKPI: 802.11: close race lkpi_sta_scan_to_auth()/(*iv_update_bss)().
Fri, May 24, 12:05 AM
bz updated the diff for D43967: LinuxKPI: 802.11: close race lkpi_sta_scan_to_auth()/(*iv_update_bss)().

Update comments as suggested by @cc

Fri, May 24, 12:05 AM

Thu, May 23

bz closed D43966: LinuxKPI: 802.11: lock MO tx/wake_tx_queue() downcalls.
Thu, May 23, 11:46 PM
bz committed rG45bce6fa306f: LinuxKPI: 802.11: lock MO tx/wake_tx_queue() downcalls (authored by bz).
LinuxKPI: 802.11: lock MO tx/wake_tx_queue() downcalls
Thu, May 23, 11:46 PM
bz added a comment to D44865: linuxkpi: Allow ida_destroy and idr_destroy to be called multiple times.

Do you have this staged somewhere in git I can pull it from?

Thu, May 23, 11:25 PM
bz committed rGd33f5a0afa54: fwget: update wireless IDs for rtw88/89, ath1xk, mt76 and add iwlwifi (authored by bz).
fwget: update wireless IDs for rtw88/89, ath1xk, mt76 and add iwlwifi
Thu, May 23, 10:29 PM
bz closed D44918: fwget: update wireless IDs for rtw88/89, ath1xk, mt76 and add iwlwifi.
Thu, May 23, 10:29 PM
bz closed D44945: net/wifi-firmware-*kmod: improve build logic, add flavors, update version.
Thu, May 23, 10:20 PM
bz committed R11:80f50c9eb66d: net/wifi-firmware-*kmod: improve build logic, add flavors, update fw version (authored by bz).
net/wifi-firmware-*kmod: improve build logic, add flavors, update fw version
Thu, May 23, 10:20 PM
bz added inline comments to D44920: net80211: bump maximum key size to 384 bits.
Thu, May 23, 12:47 AM · wireless
bz requested changes to D44964: net80211: add IEEE80211_IOC_DEVCAPS2, include versioned responses.
Thu, May 23, 12:41 AM · wireless
bz added inline comments to D45278: Update set of packages for DVDs.
Thu, May 23, 12:18 AM

Wed, May 22

bz committed rGd1af434d9994: LinuxKPI: 802.11: rename chanctx_conf for consistency (authored by bz).
LinuxKPI: 802.11: rename chanctx_conf for consistency
Wed, May 22, 9:10 PM
bz closed D45185: LinuxKPI: 802.11: rename chanctx_conf for consistency.
Wed, May 22, 9:10 PM
bz committed rG5a4d24610fc6: LinuxKPI: 802.11: change teardown order to avoid iwlwifi firmware crashes (authored by bz).
LinuxKPI: 802.11: change teardown order to avoid iwlwifi firmware crashes
Wed, May 22, 9:08 PM
bz closed D45293: LinuxKPI: 802.11: change teardown order to avoid iwlwifi firmware crashes.
Wed, May 22, 9:08 PM
bz added a comment to D45293: LinuxKPI: 802.11: change teardown order to avoid iwlwifi firmware crashes.
In D45293#1033438, @bz wrote:
In D45293#1033418, @bz wrote:

There may be another code path which can still trigger this (or another) problem leading to a FW crash with the old 8xxx/9xxx cards (leading to follow-up KASSERT triggers on GENERIC).

I'll have a look tomorrow; in case you see anything but

iwlwifi0: lkpi_sta_scan_to_auth:1310: mo_sta_state(NONE) failed: -5
iwlwifi0: lkpi_iv_newstate: error -1 during state transition 5 (RUN) -> 2 (AUTH)

after a firmware crash, please follow up here or on the PR and let me know.

Doh! https://reviews.freebsd.org/D43967 never made it; the description needs updating etc. but the change should go into main as well; it's likely I hit that race. Grrr decade old net80211 problems everyone ignored.

Wed, May 22, 5:08 AM
bz added a comment to D45293: LinuxKPI: 802.11: change teardown order to avoid iwlwifi firmware crashes.
In D45293#1033443, @imp wrote:

Taerdown -> teardown in commit message.

Wed, May 22, 4:06 AM
bz retitled D45293: LinuxKPI: 802.11: change teardown order to avoid iwlwifi firmware crashes from LinuxKPI: 802.11: change taerdown order to avoid iwlwifi firmware crashes to LinuxKPI: 802.11: change teardown order to avoid iwlwifi firmware crashes.
Wed, May 22, 4:05 AM
bz added a comment to D45293: LinuxKPI: 802.11: change teardown order to avoid iwlwifi firmware crashes.
In D45293#1033418, @bz wrote:

There may be another code path which can still trigger this (or another) problem leading to a FW crash with the old 8xxx/9xxx cards (leading to follow-up KASSERT triggers on GENERIC).

I'll have a look tomorrow; in case you see anything but

iwlwifi0: lkpi_sta_scan_to_auth:1310: mo_sta_state(NONE) failed: -5
iwlwifi0: lkpi_iv_newstate: error -1 during state transition 5 (RUN) -> 2 (AUTH)

after a firmware crash, please follow up here or on the PR and let me know.

Wed, May 22, 3:24 AM
bz planned changes to D45294: [WIP] LinuxKPI: add missing bus_dmamap_sync() calls.

I'll try to deal with the "pr_debug" marked instances the next days.

Wed, May 22, 3:22 AM
bz requested review of D45294: [WIP] LinuxKPI: add missing bus_dmamap_sync() calls.
Wed, May 22, 3:22 AM
bz added a comment to D45293: LinuxKPI: 802.11: change teardown order to avoid iwlwifi firmware crashes.
In D45293#1033422, @imp wrote:

"Tear"

Wed, May 22, 3:13 AM
bz added a comment to D45293: LinuxKPI: 802.11: change teardown order to avoid iwlwifi firmware crashes.

There may be another code path which can still trigger this (or another) problem leading to a FW crash with the old 8xxx/9xxx cards (leading to follow-up KASSERT triggers on GENERIC).

Wed, May 22, 2:58 AM
bz requested review of D45293: LinuxKPI: 802.11: change teardown order to avoid iwlwifi firmware crashes.
Wed, May 22, 2:31 AM

Tue, May 21

bz closed D45180: LinuxKPI: add FIELD_PREP_CONST().
Tue, May 21, 11:28 PM
bz committed rGbb025df25738: LinuxKPI: add FIELD_PREP_CONST() (authored by bz).
LinuxKPI: add FIELD_PREP_CONST()
Tue, May 21, 11:28 PM
bz added a comment to D45278: Update set of packages for DVDs.

So silly question: what are we trying to solve with these packages in first place?
Historic value to have a copy of the packages saved before they disappear?
Give users a graphical desktop (unlikely with this list)?
Because we always did?
...?

Tue, May 21, 11:23 PM
bz added a comment to D44332: pca963x: add support for the PCA9633 4-bit Fm+ I2C-bus LED driver.

Anyone any comments? Otherwise I'll put that in soon.

Tue, May 21, 10:19 PM
bz added a comment to D45180: LinuxKPI: add FIELD_PREP_CONST().

Anyone? As otherwise this will go in within 24h.

Tue, May 21, 10:18 PM
bz added a comment to D45185: LinuxKPI: 802.11: rename chanctx_conf for consistency.

Anyone? Otherwise this will go in within 24h.

Tue, May 21, 10:17 PM
bz committed rG8e4b8e9d807a: LinuxKPI: add kvmemdup() (authored by bz).
LinuxKPI: add kvmemdup()
Tue, May 21, 10:16 PM
bz closed D45181: LinuxKPI: add kvmemdup().
Tue, May 21, 10:15 PM
bz committed rG69b6c4a6ec66: LinuxKPI: 802.11: fix for_each_sta_active_link() (authored by bz).
LinuxKPI: 802.11: fix for_each_sta_active_link()
Tue, May 21, 10:13 PM
bz added a reviewer for D45289: arm64: Fixed IOMMU compilation errors: jhb.
Tue, May 21, 10:11 PM · arm64
bz added a comment to D44945: net/wifi-firmware-*kmod: improve build logic, add flavors, update version.

@jrm given I am not a ports committer how do I proceed? I assume I need an Approved by: line from someone?

Tue, May 21, 7:35 PM
bz added inline comments to D45235: libkern: add ilog2 helpers.
Tue, May 21, 2:12 PM

Fri, May 17

bz added inline comments to D45235: libkern: add ilog2 helpers.
Fri, May 17, 7:57 PM

Thu, May 16

bz added a comment to D44918: fwget: update wireless IDs for rtw88/89, ath1xk, mt76 and add iwlwifi.

@manu if you are (still) happy with the updated versions, the ports/packages are coming as well (see D44945).
I think we are getting more "stable" now in between supported versions and "noise".
Also while this adds forward matching at least for Intel (the firmware flavor for sc does not exist as the firmware is not public yet), shipping it like this means that after a release we can add the firmware package and the driver and fwget will already support it.

Thu, May 16, 9:59 PM
bz updated the diff for D44918: fwget: update wireless IDs for rtw88/89, ath1xk, mt76 and add iwlwifi.

Re-genertae them based on updated scripts.

Thu, May 16, 9:56 PM
bz updated the diff for D44945: net/wifi-firmware-*kmod: improve build logic, add flavors, update version.

Update firmware to 20240513 (I have locally updated the commit message).
Also sort out some iwlwifi bits (we try to find the best supported
firmware version if the latest does not exist; may not have made a difference
to the lastet review version?)

Thu, May 16, 9:44 PM
bz updated subscribers of D45213: vm: pair up conversion macros.
Thu, May 16, 1:32 PM

Wed, May 15

bz added a comment to D45205: linuxkpi: spinlock: Simplify code.

The main reason for this change is that now struct mtx and spinlock_t are 100% interchangeable in code which is a first step to share structures between linuxkpi driver and native ones.

Wed, May 15, 5:24 PM
bz accepted D45207: linuxkpi: refcount: Use atomic_t directly.
Wed, May 15, 5:22 PM
bz accepted D45206: linuxkpi: rwlock: Simplify code.

Funny enough we have no way to destroy this; thankfully witness doesn't track it...

Wed, May 15, 5:19 PM
bz accepted D45205: linuxkpi: spinlock: Simplify code.
Wed, May 15, 5:18 PM
bz requested changes to D45120: Add bhyve uart raw tcp backend.
Wed, May 15, 4:54 PM

Tue, May 14

bz updated the diff for D45181: LinuxKPI: add kvmemdup().

Duplicate the implmentation and add a comment for kvmalloc/kvfree in slab.h

Tue, May 14, 11:01 PM
bz added a comment to D45181: LinuxKPI: add kvmemdup().

Do we have our approach documented somewhere? This looks acceptable given that we already #define kvfree(arg) kfree(arg) but it would be good to have that mentioned somewhere.

Tue, May 14, 9:43 PM

Mon, May 13

bz requested review of D45185: LinuxKPI: 802.11: rename chanctx_conf for consistency.
Mon, May 13, 9:08 PM
bz accepted D44306: linuxkpi: Provide a non-NULL value for THIS_MODULE.

Apart from the () I am fine. if @jhb doesn't commit it I can.

Mon, May 13, 6:10 PM
bz added a comment to D45179: mt7601U.

I'll add the back reference to the PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=247545

Mon, May 13, 6:07 PM
bz requested review of D45181: LinuxKPI: add kvmemdup().
Mon, May 13, 5:44 PM
bz requested review of D45180: LinuxKPI: add FIELD_PREP_CONST().
Mon, May 13, 5:42 PM

Tue, May 7

bz added inline comments to D44463: LinuxKPI: LKPI_80211_HW_CRYPTO: add basic multi-keys support.
Tue, May 7, 9:43 AM
bz accepted D45109: Add support for Realtek RTL8211F-VD PHY.

Should be fine; otherwise we'll deal with it as needed; do we know what mii_mpd_rev 7 is/was?

Tue, May 7, 9:24 AM

Sat, May 4

bz added a comment to D44774: carp: support VRRPv3.
In D44774#1027883, @kp wrote:
In D44774#1027778, @bz wrote:

I'll reply here rather than the email--one well two major concerns (and I didn't mean legal) with the "can of worms" are:
(1) You are adding VRRP version 3... someone will come next and ask "and what about VRRP version 2"?

Right now the answer is "We don't have v2, and we have no plans to support v2 either.".
If someone does ever want to add VRRPv2 support they get to deal with the fallout. I'm not inclined to copy/paste chunks of code on the off chance that maybe it'll be slightly helpful in the future.
We're not making choices that'll make that impossible to do in the future.

(2) We are adding to but not fixing the problem of the conflicting version number; it's easy to say I can add v3 but ... see (1).

As in carpv3? That seems entirely unlikely to ever happen, given that carp's entire reason for existing is now moot.

Sat, May 4, 12:32 AM

Fri, May 3

bz added inline comments to D44774: carp: support VRRPv3.
Fri, May 3, 12:42 AM
bz requested changes to D44774: carp: support VRRPv3.

I'll reply here rather than the email--one well two major concerns (and I didn't mean legal) with the "can of worms" are:
(1) You are adding VRRP version 3... someone will come next and ask "and what about VRRP version 2"?
(2) We are adding to but not fixing the problem of the conflicting version number; it's easy to say I can add v3 but ... see (1).

Fri, May 3, 12:36 AM

Thu, May 2

bz committed rGeadd4eae929b: bsdinstall: update comment related to pkg (authored by bz).
bsdinstall: update comment related to pkg
Thu, May 2, 9:10 PM
bz added a comment to D44919: net80211: add initial key management suites from 802.11-2016, APIs to register them.

Is there any implementation for these new functions, i.e., something which updates the drivers or is this just dead wood swimming down the river?

Thu, May 2, 7:54 PM · wireless
bz accepted D44901: net80211: allow a single wlan crypto module to register for >1 cipher.

Would be great if the commit message would mention IEEE80211_CRYPTO_MODULE() somehow so one can find this in the future more easily.

Thu, May 2, 7:48 PM · wireless
bz added a comment to D44900: net80211: add placeholder module names for the new ciphers.

In theory I am fine with this once these modules actually exist. I would also fantastic if the annoying printf instead of loading them could be fixed. reverse order.

Thu, May 2, 7:44 PM · wireless
bz requested changes to D44899: net80211: add the 802.11-2016 cipher list to the crypto array set..
Thu, May 2, 7:40 PM · wireless
bz added a comment to D44864: net80211: add new ciphers and RSN flags.

Most of the comments were marked "done" and changed some since the original comments but the "RSN AKM suite element" table still has a mix of #define suffixes and comments for the "256" cases? Is this on purpose for some reason beyond this file? At least the TDLS case I had originally asked for _256? I just wonder why not? Can you explain?

Thu, May 2, 7:34 PM · wireless
bz added a comment to D44827: net80211: add driver / crypto methods to set the hardware / software cipher suites.

This still has changes not marked "done".
Is there a change in the stack which does change the drivers to use this?

Thu, May 2, 7:29 PM · wireless
bz added a comment to D44821: wpa: Remove the now not-needed local logic to hard-code cipher support.

You didn't answer my previous question?

Thu, May 2, 7:27 PM · wireless
bz added a comment to D44820: net80211: add a new field specifically for announcing specific ciphers.

Can you please update the commit message? Apart from that it seems fine-ish with what cc@ said.

Thu, May 2, 7:27 PM · wireless

Tue, Apr 30

bz updated the diff for D44945: net/wifi-firmware-*kmod: improve build logic, add flavors, update version.

fold the three $MKDIR into one as suggested by @jrm.

Tue, Apr 30, 6:37 PM
bz added inline comments to D44945: net/wifi-firmware-*kmod: improve build logic, add flavors, update version.
Tue, Apr 30, 6:36 PM

Sun, Apr 28

bz added inline comments to D44945: net/wifi-firmware-*kmod: improve build logic, add flavors, update version.
Sun, Apr 28, 9:14 PM
bz updated the diff for D44945: net/wifi-firmware-*kmod: improve build logic, add flavors, update version.

Rebuild all the wifi-firmware flavors from scripts, this time hopefully with lower case names.

Sun, Apr 28, 9:11 PM
bz updated the diff for D44918: fwget: update wireless IDs for rtw88/89, ath1xk, mt76 and add iwlwifi.

Update one more time to (hopefully) have all ports/pkackage flavors in lower case.
Also the new files are all script generated.
The scripts will be pushed to github with the next update there before going into main.

Sun, Apr 28, 9:09 PM

Apr 27 2024

bz accepted D44979: in6.h: expose s6_addr* definitions to user level.
Apr 27 2024, 8:21 PM
bz added inline comments to D44979: in6.h: expose s6_addr* definitions to user level.
Apr 27 2024, 4:59 PM

Apr 26 2024

bz accepted D44925: linuxkpi: Add linuxkpi_video module.
Apr 26 2024, 5:17 AM
bz added a comment to D44925: linuxkpi: Add linuxkpi_video module.

Otherwise I am really happy to see the linuxkpi_*.c file in common/src given I keep meaning to say that we should rename them all away from linux_?

I can do the rename.

Apr 26 2024, 5:16 AM

Apr 25 2024

bz accepted D44926: linuxkpi: hdmi: Split the module declaration to a new file.
Apr 25 2024, 10:50 PM
bz added a comment to D44925: linuxkpi: Add linuxkpi_video module.

What is going to happen to sys/modules/linuxkpi_hdmi then? They both compile in linux_hdmi.c (okay, saw the other revision) We do not get symbol clashes?

Apr 25 2024, 10:48 PM
bz planned changes to D44918: fwget: update wireless IDs for rtw88/89, ath1xk, mt76 and add iwlwifi.
Apr 25 2024, 8:38 PM
bz planned changes to D44945: net/wifi-firmware-*kmod: improve build logic, add flavors, update version.
Apr 25 2024, 8:37 PM
bz added a comment to D44960: network.subr: Remove extraneous checkyesno synchronous_dhclient.

Why not? Is that not just passing the result back to the caller at the end of the shell function?
Given I have to ask this, I am probably not the right one to review...

Apr 25 2024, 8:29 PM
bz committed rGad31d4764255: bsdinstall: update comment related to pkg (authored by bz).
bsdinstall: update comment related to pkg
Apr 25 2024, 5:45 PM
bz closed D44946: bsdinstall: update comment related to pkg.
Apr 25 2024, 5:45 PM
bz requested review of D44946: bsdinstall: update comment related to pkg.
Apr 25 2024, 2:52 PM
bz added a comment to D44918: fwget: update wireless IDs for rtw88/89, ath1xk, mt76 and add iwlwifi.

Ports change part I here: https://reviews.freebsd.org/D44945

Apr 25 2024, 2:40 PM
bz requested review of D44945: net/wifi-firmware-*kmod: improve build logic, add flavors, update version.
Apr 25 2024, 2:39 PM
bz retitled D44918: fwget: update wireless IDs for rtw88/89, ath1xk, mt76 and add iwlwifi from fwget: update wireless IDs for rtw88/89 and mt76 and add iwlwifi to fwget: update wireless IDs for rtw88/89, ath1xk, mt76 and add iwlwifi.
Apr 25 2024, 1:10 PM
bz updated the diff for D44918: fwget: update wireless IDs for rtw88/89, ath1xk, mt76 and add iwlwifi.
  • Fix the two QCA entries which depend on two packages
  • Update the comments on Intel iwlwifi removing some initial logic in favor of a script (it is currently two but I'll try to clean it up and add it either to src or ports to generate both the fwget case pattern and the ports flavor->firmware files list generation)
Apr 25 2024, 1:08 PM
bz added a comment to D44918: fwget: update wireless IDs for rtw88/89, ath1xk, mt76 and add iwlwifi.

Looks better now, thanks a lot.

Apr 25 2024, 12:55 PM
bz added a comment to D44918: fwget: update wireless IDs for rtw88/89, ath1xk, mt76 and add iwlwifi.
In D44918#1024544, @imp wrote:

I don't suppose that yhese could be generated automatically? It's a huge table to maintain by hand...

Apr 25 2024, 3:47 AM
bz added a comment to D44821: wpa: Remove the now not-needed local logic to hard-code cipher support.

Is is likely mis-sorted in the stack as this should go after D44922?

Apr 25 2024, 3:36 AM · wireless
bz added a comment to D44827: net80211: add driver / crypto methods to set the hardware / software cipher suites.

Are you going to change the few drivers which need change to get rid of the public exposure as well? Otherwise this is a dead code before added.

Apr 25 2024, 3:35 AM · wireless