Page MenuHomeFreeBSD

bz (Bjoern A. Zeeb)
User

Projects (6)

User Details

User Since
Aug 29 2014, 12:11 PM (242 w, 1 d)

Recent Activity

Yesterday

bz requested changes to D19622: Fix panic in network stack due memory use after free in relation to fragmented packets.
Sat, Apr 20, 2:33 PM
bz added a comment to D19973: ip6_id: Avoid blocking if random(4) is not available.

Is there a notification for when we are fully seeded the first time and entropy is available? FlowIDs are a controversial subject as to what they mean and what they are good to use for (see various RFCs and drafts, especially from Brian Carpenter in the last years). BSD enable random flowids by default but we could equally, if not set by application, leave them 0 for the first few packets.

Sat, Apr 20, 7:40 AM

Fri, Apr 19

bz accepted D19969: Don't send ICMPv6 packets when the checksum is wrong.
Fri, Apr 19, 5:52 PM
bz committed rS346404: MFC 344740:.
MFC 344740:
Fri, Apr 19, 5:29 PM
bz committed rS346403: MFC r344740:.
MFC r344740:
Fri, Apr 19, 5:28 PM
bz added inline comments to D19969: Don't send ICMPv6 packets when the checksum is wrong.
Fri, Apr 19, 5:22 PM
bz accepted D19969: Don't send ICMPv6 packets when the checksum is wrong.

Again, can you you please mention rip6_input() in the commit message?

Fri, Apr 19, 5:20 PM
bz accepted D19968: Improve checksum computation via IPV6_CHECKSUM for received packets.

Again can you please mention "... in rip6_input() ..." in the commit message.

Fri, Apr 19, 5:06 PM
bz accepted D19967: Don't overwrite buffer when computing checksum via IPV6_CHECKSUM.

Can you please improve the description before committing stating that it's related to rip6_output().

Fri, Apr 19, 4:58 PM
bz accepted D19966: Improve input validation for IPPROTO_IPV6 level socket option IPV6_CHECKSUM.
Fri, Apr 19, 4:52 PM
bz added a comment to D19965: Fix various IPV6_CHECKSUM issues.
Fri, Apr 19, 4:12 PM
bz requested changes to D19921: Add GRE-in-UDP encapsulation support.
Fri, Apr 19, 4:10 PM
bz requested changes to D19965: Fix various IPV6_CHECKSUM issues.

This seems like four different issues and it's kind of hard to keep them apart in a single change. For the sake of having a readable history and easily seeing/understanding each problem, can you please split them up?

Fri, Apr 19, 4:03 PM
bz committed rS346397: MFC r345757:.
MFC r345757:
Fri, Apr 19, 3:54 PM
bz committed rS346396: MFC r345757:.
MFC r345757:
Fri, Apr 19, 3:53 PM
bz committed rS346395: MFC r345372:.
MFC r345372:
Fri, Apr 19, 3:52 PM
bz committed rS346394: MFC r345370:.
MFC r345370:
Fri, Apr 19, 3:51 PM
bz committed rS346393: MFC r344959:.
MFC r344959:
Fri, Apr 19, 3:49 PM
bz committed rS346392: MFC r344700:.
MFC r344700:
Fri, Apr 19, 3:46 PM
bz committed rS346391: MFC r344700:.
MFC r344700:
Fri, Apr 19, 3:46 PM
bz committed rS346389: MFC r340494:.
MFC r340494:
Fri, Apr 19, 3:34 PM
bz committed rS346388: MFC r340494:.
MFC r340494:
Fri, Apr 19, 3:34 PM

Thu, Apr 18

bz added a comment to D19960: Remove support for RFC2675.

That said, there are vendors who list it (maybe not on the forwarding plane) but as RFC compliance supporting it:
https://www.juniper.net/documentation/en_US/junos/topics/reference/standards/ipv6.html

Thu, Apr 18, 9:40 PM
bz added a comment to D19960: Remove support for RFC2675.

Maybe a very short ID to move RFC 2675 to historic... See RFC7805 for a ,much more complex example of such a document.

Thu, Apr 18, 9:37 PM
bz added a comment to D19960: Remove support for RFC2675.
In D19960#429029, @jtl wrote:

I agree with @bz about ideal process. I also agree with @kristof about the practical implications of this feature. :-)
Might a valid way forward be to write a draft, propose it, and see if anyone complains by the next IETF (July) before purging this?

Thu, Apr 18, 8:17 PM
bz added a comment to D19960: Remove support for RFC2675.

Burn it with fire! This code is not used, and pretty much can't be used, so let's get rid of it.

Thu, Apr 18, 8:16 PM
bz resigned from D19960: Remove support for RFC2675.

I'l resign as a reviewer from this as removing valid RFC support seems counter-intuitive to me just because currently to your best knowledge no device supporting it exists. Someone should write the draft first to deprecate this and see if people stand up and then remove it.

Thu, Apr 18, 5:18 PM
bz accepted D19952: Add a bugs section to pflog man page.
Thu, Apr 18, 10:55 AM

Mon, Apr 15

bz added a comment to D19622: Fix panic in network stack due memory use after free in relation to fragmented packets.

Sorry, I withdraw my approval. The more I think about this, the more I dislike it. What the patch does - it fixes the panic in a most straightforward way. But let's look at it from standpoint of network engineer, not kernel developer.

Mon, Apr 15, 10:43 PM
bz accepted D19587: net: adjust randomized address bits.

I think this looks fine now. I haven't given it a full read-down or test again (just going by the diff of changes and last comments).

Mon, Apr 15, 10:24 PM

Sat, Apr 13

bz accepted D19861: Update and clarify pflog man page.

lgtm

Sat, Apr 13, 8:51 PM
bz added inline comments to D19587: net: adjust randomized address bits.
Sat, Apr 13, 2:03 PM
bz accepted D19839: add INET6 support to nfsdumpstate for the client callback address.

I only scrolled through and what I saw looked ok to me.

Sat, Apr 13, 1:14 PM

Sat, Apr 6

bz accepted D19218: fix nfsuserd to find a mapped "localhost" ip address and to use INET6 when INET isn't available.

Scrolling through the kernel changes it looks good to me; not done an in-detail review on them.

Sat, Apr 6, 9:20 PM
bz accepted D19832: Add some CMD53-related definitions.
Sat, Apr 6, 8:53 PM
bz accepted D19779: Add new fields to mmc_data in preparation to SDIO CMD53 block mode support.

OK, this seems fine to me.

Sat, Apr 6, 8:51 PM · ARM

Wed, Apr 3

bz added a comment to D4794: Remove per-ifa outgoing packet accounting from ip[6]_output..

After I spent sometime around this code, I support melifaro@'s suggestion.

Wed, Apr 3, 9:16 PM

Tue, Apr 2

bz added inline comments to D19779: Add new fields to mmc_data in preparation to SDIO CMD53 block mode support.
Tue, Apr 2, 4:12 PM · ARM

Mon, Apr 1

bz accepted D19783: Implement CMD53 block mode support for SDHCI and AllWinner-based boards.

The descriptions needs slightly rewording "is requested". I'd be a bit more verbose maybe explaining distinct use of block_size and block_count?

Mon, Apr 1, 9:14 PM
bz requested changes to D19779: Add new fields to mmc_data in preparation to SDIO CMD53 block mode support.

This is missing files I think. The mmcreg.h structure changes are missing from this one. This won't compile.

Mon, Apr 1, 8:59 PM · ARM

Sun, Mar 31

bz requested changes to D19587: net: adjust randomized address bits.
Sun, Mar 31, 10:09 PM
bz accepted D19740: Push down INP_WLOCK slightly in tcp_ctloutput..

LGTM

Sun, Mar 31, 7:36 PM
bz updated the diff for D19746: Introduce sim_dev and cam_sim_alloc_dev()..

Use the correct field `sim_dev`` not `sim``.
Last minute cleanup changes are never a good idea without compiling/booting them,

Sun, Mar 31, 7:31 PM
bz closed D19745: Improve debugging options in bcm2835_sdhci.c.
Sun, Mar 31, 7:28 PM
bz committed rS345757: Improve debugging options in bcm2835_sdhci.c.
Improve debugging options in bcm2835_sdhci.c
Sun, Mar 31, 7:28 PM
bz added a comment to D19749: Add a CAM-Newbus SDIO support module..

@imp if you can confirm that the two changes (usdbdevs.awk -> sdiodevs.awk) and the disclaimers should be added I'll be happy to go ahead.

Sun, Mar 31, 7:19 PM

Fri, Mar 29

bz added a comment to D19745: Improve debugging options in bcm2835_sdhci.c.

I wonder if there is a way to make this generic as the dprintf or similar macro seems to be common in arm code.

Fri, Mar 29, 11:51 AM
bz added a comment to D19749: Add a CAM-Newbus SDIO support module..

Just adding three comments to point out the not-so-obvious obvious apart from the fact that
(a) unloading is not yet supported.
(b) a man page is missing.

Fri, Mar 29, 11:49 AM
bz created D19749: Add a CAM-Newbus SDIO support module..
Fri, Mar 29, 11:37 AM
bz created D19748: Improve error/debug messages in sdhci.c.
Fri, Mar 29, 9:52 AM
bz created D19747: Improve sdhci slot_printf() debug printing..
Fri, Mar 29, 9:51 AM
bz updated subscribers of D19745: Improve debugging options in bcm2835_sdhci.c.
Fri, Mar 29, 9:47 AM
bz created D19746: Introduce sim_dev and cam_sim_alloc_dev()..
Fri, Mar 29, 9:46 AM
bz added a reviewer for D19745: Improve debugging options in bcm2835_sdhci.c: manu.
Fri, Mar 29, 9:42 AM
bz created D19745: Improve debugging options in bcm2835_sdhci.c.
Fri, Mar 29, 9:42 AM
bz abandoned D19669: Add more field offsets for SDIO.

Will be handled as part of kibab's D19674 .

Fri, Mar 29, 9:39 AM

Thu, Mar 28

bz added inline comments to D19674: Implement CMD53 support for byte mode and block mode.
Thu, Mar 28, 12:02 PM
bz added a comment to D19674: Implement CMD53 support for byte mode and block mode.

Can we break this up into 2-3 changes please?
(1) Adding block_size and block_count to mmcreg.h and fixing the initialiers with memset or = 0; these changes are by themselves and undisputed and could get out of this.
(2) The change to the #defines in mmcreg.h can go in as well; they are not all strictly related to blk count from what I can see, so keeping them on their own would be nice.

Thu, Mar 28, 11:57 AM
bz added a comment to D19674: Implement CMD53 support for byte mode and block mode.

The interrupt issues I am still seeing on CRC DAT errors seem specific to the broadcom chip on the RPi. I found other references. I have not been able to track down a solution yet but I'd suggest we ignore that for the moment.

Thu, Mar 28, 11:47 AM
bz requested changes to D19674: Implement CMD53 support for byte mode and block mode.

I've got three proposed changes. The first two hunks remove a timeout interrupt here (unsurprisingly) by using a correct block size.

Thu, Mar 28, 11:46 AM

Wed, Mar 27

bz accepted D19652: iflib: return ENETDOWN when the network device is down.

Seems fine to me. I keep running into that at boot and have yet to figure out why transmit is not possible at that point yet; it kills the first IPv6 RS/IPv4 DHCP packet (but that's for another review).

Wed, Mar 27, 11:06 AM

Fri, Mar 22

bz added inline comments to D19674: Implement CMD53 support for byte mode and block mode.
Fri, Mar 22, 11:48 PM
bz added a comment to D19674: Implement CMD53 support for byte mode and block mode.

For your information; sdhci_data_irq() needs more love. Currently it runs into the CRC error case which is wrong when I am trying to blk_count = 511 (yes I am avoiding blk_count = 0 for infinite). I haven't looked into it yet, but it'll be next; here's a short debug trace:

DBG: brcmf_sdiod_ramrw:283: write 32768/600487 bytes at offset 0x00000000 in window  0x00198000
sdhci_bcm0-slot0: Got XPT_MMC_IO
sdhci_bcm0-slot0: CMD53 arg 0x9d0001ff flags 0x35 dlen 32704 dflags 0x9 blksz=64 blkcnt=511
sdhci_bcm0-slot0: SDIO Custom block params: blksz:       0x40, blk cnt:      0x1ff
sdhci_bcm0-slot0: Blk size: 0x00000040 | Blk cnt:  0x000001ff
sdhci_bcm0-slot0: Starting command opcode 0x35 flags 0x3a
sdhci_bcm0-slot0: Interrupt 0x11
sdhci_bcm0-slot0: sdhci_finish_command: called, err 0 flags 0x35
Resp: 0x1000 0000 0000 0000
sdhci_bcm0-slot0: Interrupt 0x208010
sdhci_bcm0-slot0: sdhci_data_irq:2174 set error 0x02 intmask 0x200010
                                                     ^^^^^^^^^^^^^^^^^^
Fri, Mar 22, 9:03 PM
bz added a comment to D19674: Implement CMD53 support for byte mode and block mode.

I haven't convinced myself yet that these two extra fields are actually needed but meanwhile this is needed (independently). I'll put it into a proper review later tonight.

Fri, Mar 22, 8:51 PM

Mar 21 2019

bz added a comment to D19622: Fix panic in network stack due memory use after free in relation to fragmented packets.

I think that while in flight problem can be fixed with epoch,

Mar 21 2019, 5:29 PM
bz committed rS345372: Whitespace cleanup in sdhci.c.
Whitespace cleanup in sdhci.c
Mar 21 2019, 10:50 AM
bz updated the summary of D19669: Add more field offsets for SDIO.
Mar 21 2019, 10:40 AM
bz created D19669: Add more field offsets for SDIO.
Mar 21 2019, 10:34 AM
bz committed rS345370: Align struct sdhci_slot MMCCAM members..
Align struct sdhci_slot MMCCAM members.
Mar 21 2019, 10:23 AM
bz added a comment to D15955: Discover cards on boot.
In D15955#420988, @manu wrote:
In D15955#357900, @manu wrote:

Quoting myself :

The correct solution is implementing proper card insertion detection. This is, however, out of scope for this change. I'm just replicating the way it's implemented for mmc(4) in this driver, for now.

Yes and that's what I don't like, this is not the correct solution for this problem.

Mar 21 2019, 9:00 AM
bz added a comment to D19622: Fix panic in network stack due memory use after free in relation to fragmented packets.

Do you have a quick overview of what all gets completely flushed this way? Hmm IP (reassmbly), frag6, sctp, and tcp is what I can spot, are there others?

Mar 21 2019, 8:51 AM

Mar 20 2019

bz added inline comments to D15912: sys/cam/mmc/mmc_da.c: Refactor error handling.
Mar 20 2019, 8:20 AM

Mar 19 2019

bz added a comment to D19622: Fix panic in network stack due memory use after free in relation to fragmented packets.

While this solves the immediate problem you were experiencing at some collateral damage for all other interfaces, it doesn't solve the underlying issues for all places, like the netisr queue.

Mar 19 2019, 3:20 PM

Mar 17 2019

bz committed rS345241: Fix legacy IP autoconfiguration..
Fix legacy IP autoconfiguration.
Mar 17 2019, 9:31 AM
bz added a comment to D19488: Enhance IPv6 autoconf startup scripts.
In D19488#419791, @bz wrote:

I think I see how this can happen; I'll send another patch later today for testing.

Mar 17 2019, 12:36 AM
bz added a comment to D19488: Enhance IPv6 autoconf startup scripts.
Mar 17 2019, 12:29 AM

Mar 16 2019

bz added a comment to D19488: Enhance IPv6 autoconf startup scripts.

This breaks ifconfig_DEFAULT="DHCP" somehow. It works with either SYNCDHCP or this commit reverted.

Mar 16 2019, 3:27 PM

Mar 15 2019

bz updated subscribers of D19587: net: adjust randomized address bits.
Mar 15 2019, 5:42 PM
bz created D19594: Fix udp_output() locking strategy in one case.
Mar 15 2019, 4:10 PM
bz added a comment to D19587: net: adjust randomized address bits.

Sorry Kyle, that the full discussion on this is now done on this review. Thanks for starting to consolidate all the "random" uses.
Let's take this slowly and try to get it righter and with rough consensus into something which will (a) sort the various individual implementations, and (b) solve problems for our users.

Mar 15 2019, 10:02 AM
bz added a comment to D19587: net: adjust randomized address bits.
In D19587#419396, @imp wrote:

OUI spaces aren't for randomly assigning address bits that change from boot to boot. They are for more permanent allocations according to the standards that I read a few years ago. The local administrative space is for things like random assignment of MAC addresses.

Mar 15 2019, 9:44 AM

Mar 14 2019

bz added a member for iflib: bz.
Mar 14 2019, 5:29 PM
bz accepted D19581: firmware(9): remove uuencoded example.

Die CVS die!

Mar 14 2019, 1:46 PM

Mar 13 2019

bz committed rS345088: Enhance IPv6 autoconf startup..
Enhance IPv6 autoconf startup.
Mar 13 2019, 5:00 PM
bz closed D19488: Enhance IPv6 autoconf startup scripts.
Mar 13 2019, 5:00 PM

Mar 9 2019

bz committed rS344959: Add two more products found inside a T480 to usbdevs..
Add two more products found inside a T480 to usbdevs.
Mar 9 2019, 3:15 AM
bz committed rS344956: Try to improve comment for socket state bits..
Try to improve comment for socket state bits.
Mar 9 2019, 1:37 AM
bz closed D13865: Improve comment in socketvar.h.
Mar 9 2019, 1:37 AM
bz committed rS344954: Improve ARP logging..
Improve ARP logging.
Mar 9 2019, 1:13 AM
bz closed D19490: Improve ARP logging.
Mar 9 2019, 1:13 AM

Mar 7 2019

bz updated the diff for D19490: Improve ARP logging.

Re-sort the struct fields to not change the expected order and use a spare field in-place. That will help netstat to continue working when updating from 12->13 without shuffling the values around.

Mar 7 2019, 11:18 PM
bz updated the diff for D19488: Enhance IPv6 autoconf startup scripts.

Remove the RTSOL interface pseudo-option and run rtsol unconditionally on accept_rtadv (if it is installed).

Mar 7 2019, 11:14 PM
bz closed D19487: EXPERIMENTAL: clear IPv6-Only flag on interface if link-state goes down.
Mar 7 2019, 11:03 PM
bz committed rS344904: Update for IETF draft-ietf-6man-ipv6only-flag..
Update for IETF draft-ietf-6man-ipv6only-flag.
Mar 7 2019, 11:03 PM
bz added a comment to D19487: EXPERIMENTAL: clear IPv6-Only flag on interface if link-state goes down.
In D19487#417291, @hrs wrote:

Agreed. I meant logging upon a state toggle by RA, not each time receiving an RA.

Mar 7 2019, 8:58 PM
bz added inline comments to D19490: Improve ARP logging.
Mar 7 2019, 10:39 AM
bz added a comment to D19488: Enhance IPv6 autoconf startup scripts.
In D19488#417164, @hrs wrote:

For (2), I think the old version unconditionally runs rtsol (w/o "d") when rtsold_enable="NO", and does not when rtsold_enable="YES" because rtsold (w/ "d") will be invoked later by rc.d/rtsold should handle it. In short, the condition which determines if rtsol is invoked or not depends only on "accept_rtadv" flag. Isn't it enough?

Mar 7 2019, 10:36 AM
bz added a comment to D19487: EXPERIMENTAL: clear IPv6-Only flag on interface if link-state goes down.
In D19487#417158, @hrs wrote:

Looks good to me. We might want to put an INFO log line when ND6_IFF_IPV6_ONLY flag is changed by receiving RA or link-down event so that the sysadmin can know what is going on.

Mar 7 2019, 10:24 AM
bz added a comment to D19487: EXPERIMENTAL: clear IPv6-Only flag on interface if link-state goes down.
In D19487#417165, @hrs wrote:

One more comment: immediate change of the flag just after a link-down event may be problematic when the link is unstable. In such a situation, IPv4 packets can be allowed after a link-up and before another RA arrives even if the all of advertising routers keep sending ipv6only flag. We can assume that the interface should be configured to accept RA when the machine moves from a network to another, so sending a RS after a link-up then clearing ND6_IFF_IPV6_ONLY only when no RA arrives in a few seconds looks a more reasonable behavior. If at least one RA arrives after the RS, the normal handling of ipv6only flag works.

Mar 7 2019, 10:21 AM
bz added a comment to D19490: Improve ARP logging.

Should add: X-MFC: never.

Mar 7 2019, 12:28 AM