Page MenuHomeFreeBSD

bz (Bjoern A. Zeeb)
User

Projects (9)

User Details

User Since
Aug 29 2014, 12:11 PM (456 w, 5 d)

Recent Activity

Yesterday

bz accepted D40268: inpcb: Properly handle rewrites of classic jail socket source addresses.
Tue, May 30, 12:21 AM

Sat, May 27

bz added a comment to D40300: setkey(8): NAT-T manual configuration support.
In D40300#917683, @kib wrote:
In D40300#917678, @bz wrote:

Can you please add details (a proposed commit message) as that might shed light onto why you may think this is needed/useful?

This is needed to properly test IPSEC+NAT-T hardware offload. (I do not think that mentioning this in commit message is too useful).

Sat, May 27, 9:50 PM
bz added a comment to D40300: setkey(8): NAT-T manual configuration support.

Can you please add details (a proposed commit message) as that might shed light onto why you may think this is needed/useful?

Sat, May 27, 9:26 PM
bz added a comment to D40268: inpcb: Properly handle rewrites of classic jail socket source addresses.

Jailed sockets with a wildcard local address should have lower priority than non-jailed sockets with a wildcard local address.

Sat, May 27, 9:22 PM

Wed, May 24

bz committed rGad513b4dba3e: LinuxKPI: add utsname for init_utsname() with release (authored by bz).
LinuxKPI: add utsname for init_utsname() with release
Wed, May 24, 8:51 AM
bz closed D40248: LinuxKPI: add utsname for init_utsname() with release.
Wed, May 24, 8:50 AM
bz added a comment to D40246: LinuxKPI: add ktime_get_real_ts64().

I'm not sure if this one needs to be the non-get version, could be getnanotime?

Wed, May 24, 8:41 AM
bz committed rGc1b6e9121e88: LinuxKPI: uuid: add guid_gen() and guid_copy() (authored by bz).
LinuxKPI: uuid: add guid_gen() and guid_copy()
Wed, May 24, 8:35 AM
bz closed D40249: LinuxKPI: uuid: add guid_gen() and guid_copy().
Wed, May 24, 8:35 AM
bz added inline comments to D40250: LinuxKPI: add page pool skeleton.
Wed, May 24, 8:31 AM
bz updated the diff for D40250: LinuxKPI: add page pool skeleton.

Make function argument const as suggested by @emaste

Wed, May 24, 8:31 AM

Tue, May 23

bz committed rG0be82d56b44f: fwget: update pci_network_mediatek for mt7996 (authored by bz).
fwget: update pci_network_mediatek for mt7996
Tue, May 23, 11:42 PM
bz committed rG6a1c5037363a: LinuxKPI: add thermal.h to dummy files for now (authored by bz).
LinuxKPI: add thermal.h to dummy files for now
Tue, May 23, 11:24 PM
bz requested review of D40250: LinuxKPI: add page pool skeleton.
Tue, May 23, 11:23 PM
bz requested review of D40249: LinuxKPI: uuid: add guid_gen() and guid_copy().
Tue, May 23, 11:22 PM
bz requested review of D40248: LinuxKPI: add utsname for init_utsname() with release.
Tue, May 23, 11:21 PM
bz requested review of D40247: LinuxKPI: pci: add PCI_COMMAND_MEMORY.
Tue, May 23, 11:20 PM
bz requested review of D40246: LinuxKPI: add ktime_get_real_ts64().
Tue, May 23, 11:20 PM
bz committed rG1213a6bea8a1: LinuxKPI: skbuff: add napi_build_skb() and skb_mark_for_recycle() (authored by bz).
LinuxKPI: skbuff: add napi_build_skb() and skb_mark_for_recycle()
Tue, May 23, 11:19 PM

Sun, May 21

bz committed rG046d8d89ed19: LinuxKPI: fix WRITE_ONCE(), remove ACCESS_ONCE() (authored by bz).
LinuxKPI: fix WRITE_ONCE(), remove ACCESS_ONCE()
Sun, May 21, 11:15 PM
bz closed D40084: LinuxKPI: fix WRITE_ONCE().
Sun, May 21, 11:15 PM
bz committed rG525dd4acaacc: LinuxKPI: implement pci_rescan_bus() (authored by bz).
LinuxKPI: implement pci_rescan_bus()
Sun, May 21, 12:32 AM
bz closed D40122: LinuxKPI: implement pci_rescan_bus().
Sun, May 21, 12:32 AM
bz added a comment to D33168: gpart: add options to move the primary and secondary GPT partition tables.
In D33168#914780, @bcr wrote:

Can we get an update on the status of this review?

Sun, May 21, 12:29 AM

Sat, May 20

bz committed rG5138ffa87716: fwget: remove logging redirects (authored by bz).
fwget: remove logging redirects
Sat, May 20, 11:22 AM
bz closed D40077: fwget: remove logging redirects.
Sat, May 20, 11:21 AM
bz committed rGdd8a74e74d99: fwget: add support for various WiFi NICs (authored by bz).
fwget: add support for various WiFi NICs
Sat, May 20, 11:20 AM
bz closed D40073: fwget: add support for various WiFi NICs.
Sat, May 20, 11:20 AM
bz committed rG17cec33e750f: fwget: improve the pci base script (authored by bz).
fwget: improve the pci base script
Sat, May 20, 11:18 AM
bz closed D40072: fwget: improve the pci base script.
Sat, May 20, 11:18 AM
bz committed rG10aa369afd99: fwget: simplify adding firmware images to pkg to install (authored by bz).
fwget: simplify adding firmware images to pkg to install
Sat, May 20, 11:15 AM
bz closed D40071: fwget: simplify adding firmware images to pkg to install.
Sat, May 20, 11:15 AM
bz committed rGae1e336e0517: LinuxKPI: add put_unaligned_le16() and get_unaligned_be64() (authored by bz).
LinuxKPI: add put_unaligned_le16() and get_unaligned_be64()
Sat, May 20, 11:12 AM
bz closed D40174: LinuxKPI: add put_unaligned_le16() and get_unaligned_be64().
Sat, May 20, 11:12 AM
bz updated the diff for D40176: LinuxKPI: add dummy rhashtable implementation.

Update types as suggested by @emaste

Sat, May 20, 11:09 AM
bz requested review of D40176: LinuxKPI: add dummy rhashtable implementation.
Sat, May 20, 1:04 AM
bz requested review of D40175: LinuxKPI: pci: update struct msi_desc.
Sat, May 20, 1:03 AM
bz requested review of D40174: LinuxKPI: add put_unaligned_le16() and get_unaligned_be64().
Sat, May 20, 1:02 AM
bz requested review of D40173: LinuxKPI: add devm_ioremap().
Sat, May 20, 1:02 AM
bz committed rGb7afaf8a411a: LinuxKPI: add further dummy header files (authored by bz).
LinuxKPI: add further dummy header files
Sat, May 20, 1:02 AM
bz committed rG369264acf7d2: LinuxKPI: skbuff: add skb_get_hash() (authored by bz).
LinuxKPI: skbuff: add skb_get_hash()
Sat, May 20, 1:01 AM
bz committed rG047298203fc3: LinuxKPI: qcom: update qmi and mhi (authored by bz).
LinuxKPI: qcom: update qmi and mhi
Sat, May 20, 1:01 AM
bz committed rG6153bef9ec96: LinuxKPI: netdevice: add dev_set_threaded() (authored by bz).
LinuxKPI: netdevice: add dev_set_threaded()
Sat, May 20, 1:01 AM
bz committed rG63231f4d5bae: net80211: Radiotap: update for defines (authored by bz).
net80211: Radiotap: update for defines
Sat, May 20, 1:01 AM
bz added a comment to D40077: fwget: remove logging redirects.

ping6?

Sat, May 20, 12:59 AM
bz added a comment to D40071: fwget: simplify adding firmware images to pkg to install.

ping6?

Sat, May 20, 12:59 AM

Thu, May 18

bz closed D40137: ifconfig: improve trimming off interface number at end.
Thu, May 18, 3:26 PM
bz committed rG2e6756b752e0: ifconfig: improve trimming off interface number at end (authored by bz).
ifconfig: improve trimming off interface number at end
Thu, May 18, 3:25 PM
bz added a comment to D40120: LinuxKPI: implement mul_u64_u64_div_u64().

@bz : Another thing coming to mind, is to apply the greatest common divisor between x,y,z. This computation is pretty cheap. When you have exact fractions, it doesn't look so good seeing rounding errors.

Is this function being used for clock computations?

Thu, May 18, 3:21 PM
bz accepted D40141: rc.d/netif: Don't DAD if lo0 is the only IPv6 IF.

From a quick glance looks good to me

Thu, May 18, 3:11 PM

Wed, May 17

bz requested review of D40138: LinuxKPI: add struct_group(...).
Wed, May 17, 10:23 PM
bz requested review of D40137: ifconfig: improve trimming off interface number at end.
Wed, May 17, 8:46 PM
bz added a comment to D37428: Import the kernel parts of bhyve/arm64.

Hooray!!!!! THANK YOU! I'll give it a try the next days.

Wed, May 17, 5:58 PM
bz committed rG71fde8e5070c: LinuxKPI: add ns_to_timespec64() (authored by bz).
LinuxKPI: add ns_to_timespec64()
Wed, May 17, 10:23 AM
bz closed D40123: LinuxKPI: add ns_to_timespec64().
Wed, May 17, 10:23 AM
bz added a comment to D40120: LinuxKPI: implement mul_u64_u64_div_u64().

Please don't implement integers like floating point!

I think you need to do something exactly like below. I just quickly sketched this up. Can you verify it?

Wed, May 17, 10:21 AM

Tue, May 16

bz updated the diff for D40121: LinuxKPI: implement get_random_u32_inclusive().

Change function argument names to floor/ceil as suggested by @emaste.

Tue, May 16, 11:49 PM
bz committed rG972bf40b62f7: LinuxKPI: add ptp_clock_kernel.h (authored by bz).
LinuxKPI: add ptp_clock_kernel.h
Tue, May 16, 9:28 PM
bz committed rG262c5e81937f: LinuxKPI: skbuff.h: add skb_hwtstamps(), implement *mac_header() (authored by bz).
LinuxKPI: skbuff.h: add skb_hwtstamps(), implement *mac_header()
Tue, May 16, 9:28 PM
bz requested review of D40124: LinuxKPI: implement timer_{delete,shutdown}_sync().
Tue, May 16, 9:11 PM
bz requested review of D40123: LinuxKPI: add ns_to_timespec64().
Tue, May 16, 9:10 PM
bz requested review of D40122: LinuxKPI: implement pci_rescan_bus().
Tue, May 16, 9:09 PM
bz requested review of D40121: LinuxKPI: implement get_random_u32_inclusive().
Tue, May 16, 9:09 PM
bz requested review of D40120: LinuxKPI: implement mul_u64_u64_div_u64().
Tue, May 16, 9:07 PM
bz committed rG7232e6dcc89b: net80211: Radiotap: update for newer standards (add EHT, U-SIG) (authored by bz).
net80211: Radiotap: update for newer standards (add EHT, U-SIG)
Tue, May 16, 4:07 PM

Sat, May 13

bz requested review of D40084: LinuxKPI: fix WRITE_ONCE().
Sat, May 13, 3:37 PM

Fri, May 12

bz added inline comments to D40071: fwget: simplify adding firmware images to pkg to install.
Fri, May 12, 2:01 PM
bz updated the diff for D40071: fwget: simplify adding firmware images to pkg to install.

Fix dedup as reported by @bapt.

Fri, May 12, 2:00 PM
bz added inline comments to D40071: fwget: simplify adding firmware images to pkg to install.
Fri, May 12, 1:50 PM
bz added inline comments to D40071: fwget: simplify adding firmware images to pkg to install.
Fri, May 12, 1:36 PM
bz closed D40014: net/wifi-firmware-*: use metaport for "base" and switch to Makefile.inc.
Fri, May 12, 11:58 AM
bz committed R11:6247964e51aa: net/wifi-firmware-*: use metaport for "base" and switch to Makefile.inc (authored by bz).
net/wifi-firmware-*: use metaport for "base" and switch to Makefile.inc
Fri, May 12, 11:58 AM
bz added a comment to D40014: net/wifi-firmware-*: use metaport for "base" and switch to Makefile.inc.

Thanks to you two!

Fri, May 12, 11:53 AM
bz requested review of D40077: fwget: remove logging redirects.
Fri, May 12, 11:51 AM
bz added a comment to D40014: net/wifi-firmware-*: use metaport for "base" and switch to Makefile.inc.

Can you "Approve" this change as well given I am not a ports committer?

Fri, May 12, 11:23 AM
bz committed rGdd4f32ae6242: ath11k: import ath11k driver (authored by bz).
ath11k: import ath11k driver
Fri, May 12, 11:22 AM
bz committed rGd544b53cb0b6: LinuxKPI: add dummy hash.h and kernel_connect() (authored by bz).
LinuxKPI: add dummy hash.h and kernel_connect()
Fri, May 12, 11:22 AM
bz committed rG721b44ba5f3f: amd64: pmap.h put a guard around a pcpu.h function (authored by bz).
amd64: pmap.h put a guard around a pcpu.h function
Fri, May 12, 11:18 AM
bz added a comment to D40071: fwget: simplify adding firmware images to pkg to install.
In D40071#912590, @manu wrote:

In that case we can also remove all the shell redirection since we do not echo anymore and the log functions can just echo directly.
Otherwise lgtm

Fri, May 12, 11:04 AM
bz added a comment to D40014: net/wifi-firmware-*: use metaport for "base" and switch to Makefile.inc.
In D40014#912660, @jrm wrote:

One minor nit. portclippy/portfmt have a few suggestions.

Fri, May 12, 10:46 AM
bz updated the diff for D40014: net/wifi-firmware-*: use metaport for "base" and switch to Makefile.inc.

Move RUN_DEPENDS before USES

Fri, May 12, 10:44 AM
bz added a comment to D40014: net/wifi-firmware-*: use metaport for "base" and switch to Makefile.inc.

Looks good to me.

Fri, May 12, 9:57 AM

Thu, May 11

bz committed rG910a83438358: LinuxKPI: 802.11: fix IEEE80211_TX_INFO_DRIVER_DATA_SIZE (authored by bz).
LinuxKPI: 802.11: fix IEEE80211_TX_INFO_DRIVER_DATA_SIZE
Thu, May 11, 9:38 PM
bz added a comment to D40014: net/wifi-firmware-*: use metaport for "base" and switch to Makefile.inc.

Anyone?

Thu, May 11, 8:51 PM
bz added a comment to D40073: fwget: add support for various WiFi NICs.

Here's an example of how this could look (sorts out a duplicate, applies two fixups based on previous reviews)

Thu, May 11, 8:50 PM
bz requested review of D40073: fwget: add support for various WiFi NICs.
Thu, May 11, 8:47 PM
bz added a comment to D40072: fwget: improve the pci base script.

I am really not too keen on adding the "pci_fixup_class" bit but the alternative is splattering semi-empty files including another file for silly silicon.
This also remains one of the concerns I raised on the original review. It feels like something needs to change to avoid adding hacks early on...

Thu, May 11, 8:47 PM
bz requested review of D40072: fwget: improve the pci base script.
Thu, May 11, 8:45 PM
bz requested review of D40071: fwget: simplify adding firmware images to pkg to install.
Thu, May 11, 8:44 PM

Tue, May 9

bz accepted D40028: linuxkpi: Handle direct-mapped addresses in linux_free_kmem().
Tue, May 9, 8:50 PM
bz added a comment to D39946: dpaa2: Simplify addresses translation with PHYS_TO_DMAP.

Great. I am doing a rebuild now.

Tue, May 9, 10:23 AM

Mon, May 8

bz requested review of D40014: net/wifi-firmware-*: use metaport for "base" and switch to Makefile.inc.
Mon, May 8, 9:02 PM

Fri, May 5

bz added a comment to D39946: dpaa2: Simplify addresses translation with PHYS_TO_DMAP.

And if @mhorne is okay as well, feel free to commit.
Approved by: bz (mentor)

Fri, May 5, 12:50 PM
bz accepted D39946: dpaa2: Simplify addresses translation with PHYS_TO_DMAP.

All the changes I pointed out seem of more cosmetic nature. I'll leave it up to you if you want to do them.

Fri, May 5, 10:08 AM

Apr 29 2023

bz added a comment to D39825: fwget: Introduce new utility.

Can we do "bus"_"class"_"drivername" at least then -- though that doesn't work on the search parts so easily as you have to iterate over all the matching bus_class_* files.

That's what's done here no ?

Apr 29 2023, 10:11 AM

Apr 28 2023

bz added a comment to D39825: fwget: Introduce new utility.
In D39825#907514, @manu wrote:
In D39825#907512, @bz wrote:

I understand the idea. There's several drawback here for wifi:

(1) class information is (at times) useless for wifi cards - on one machine I see (for various vendors):

1 class=0x000280
3 class=0x028000
1 class=0xff0000

I don't see any problems here with intel cards.

Apr 28 2023, 11:17 PM
bz committed R11:f0bc8dadb0f7: net/wifi-firmware-base: fix make index entry (authored by bz).
net/wifi-firmware-base: fix make index entry
Apr 28 2023, 10:50 PM
bz added a comment to D39825: fwget: Introduce new utility.

I understand the idea. There's several drawback here for wifi:

Apr 28 2023, 10:42 AM

Apr 23 2023

bz committed rGe51be73a60d2: ath10k: add man page (authored by bz).
ath10k: add man page
Apr 23 2023, 9:35 PM
bz committed rGda8fa4e37a0c: ath10k: import ath10k driver (authored by bz).
ath10k: import ath10k driver
Apr 23 2023, 9:34 PM