Page MenuHomeFreeBSD

bz (Bjoern A. Zeeb)
User

Projects (6)

User Details

User Since
Aug 29 2014, 12:11 PM (285 w, 4 d)

Recent Activity

Yesterday

bz created D23740: ip6_output: improve extension header handling.
Tue, Feb 18, 12:05 PM
bz committed rS358071: ip6_output: update comments..
ip6_output: update comments.
Tue, Feb 18, 11:28 AM

Mon, Feb 17

bz added inline comments to D23726: Make RSS kernels compile again.
Mon, Feb 17, 4:05 PM
bz added inline comments to D23726: Make RSS kernels compile again.
Mon, Feb 17, 11:52 AM
bz created D23726: Make RSS kernels compile again.
Mon, Feb 17, 11:49 AM
bz committed rD53908: Update for __FreeBSD_version 1300078 after src r358020 changing.
Update for __FreeBSD_version 1300078 after src r358020 changing
Mon, Feb 17, 11:15 AM
bz closed D23097: Revert VNET change and expand VNET structure..
Mon, Feb 17, 11:09 AM
bz committed rS358020: Partially revert VNET change and expand VNET structure..
Partially revert VNET change and expand VNET structure.
Mon, Feb 17, 11:09 AM
bz updated the diff for D23097: Revert VNET change and expand VNET structure..

Use a macros to check if the vnet is shutting down in if.c.

Mon, Feb 17, 10:34 AM
bz added a comment to D23145: dwc(4) Ethernet MAC address setting/generating.
In D23145#520806, @bz wrote:

Any comments on this? I'd love to get the change out of my tree soon..
I am also interested in "this is what we were thinking of" comments.

I did wonder if the common fdt method should guarantee a MAC address and call ether_gen_addr() itself if it couldn't find an applicable fdt prop, maybe with an ENOENT to indicate that it was generated rather than found (0)- this would avoid drivers having to then call ether_gen_addr() themselves if it fails, which I kind of suspect might be the common case. I'm unsure, though.

Mon, Feb 17, 9:07 AM

Sun, Feb 16

bz added a comment to D23145: dwc(4) Ethernet MAC address setting/generating.

Any comments on this? I'd love to get the change out of my tree soon..
I am also interested in "this is what we were thinking of" comments.

Sun, Feb 16, 4:54 PM
bz added inline comments to D23097: Revert VNET change and expand VNET structure..
Sun, Feb 16, 4:54 PM
bz added a comment to D23097: Revert VNET change and expand VNET structure..

Anyone any further comments on this? I'd love to commit it the next days.

Sun, Feb 16, 4:53 PM

Fri, Feb 14

bz accepted D23674: Change smarter epoch support for NIC drivers to opt-in..
Fri, Feb 14, 5:46 PM

Wed, Jan 29

bz added inline comments to D23408: epoch support for taskqueues.
Wed, Jan 29, 8:30 PM
bz updated the diff for D23145: dwc(4) Ethernet MAC address setting/generating.

Update the change factoring out the fdt logic to resemble the USB one.
Is this what you were thinking of?

Wed, Jan 29, 5:48 PM
bz added a reviewer for D23097: Revert VNET change and expand VNET structure.: network.
Wed, Jan 29, 5:01 PM
bz updated the diff for D23097: Revert VNET change and expand VNET structure..

Address reviewer comments.

Wed, Jan 29, 4:59 PM

Tue, Jan 28

bz added a comment to D23408: epoch support for taskqueues.

In general I like the idea. Still need to touch network drivers but changing a single macro seems way better to me. It's also easily grep-able.

Tue, Jan 28, 10:08 PM
bz committed rS357210: MFC r356527-356528:.
MFC r356527-356528:
Tue, Jan 28, 6:09 PM
bz committed rS357207: MFC r356662:.
MFC r356662:
Tue, Jan 28, 5:48 PM
bz committed rS357206: MFC r353026,353030,354244 (glebius), r356386:.
MFC r353026,353030,354244 (glebius), r356386:
Tue, Jan 28, 5:39 PM
bz added a comment to D23348: Widen EPOCH(9) usage in network drivers (as a pre-step for D23347).

I have a follow-up question to all this stuff which I do not understand yet:

Tue, Jan 28, 5:14 PM

Fri, Jan 24

bz added a comment to D23097: Revert VNET change and expand VNET structure..

I mean that vnet0 behaves like any other vnet regarding shutdown and state fields.

Fri, Jan 24, 9:16 PM
bz added a comment to D23097: Revert VNET change and expand VNET structure..

Ping - is this patch still relevant?

Fri, Jan 24, 4:18 PM

Wed, Jan 22

bz committed rS356986: Fix NOINET kernels after r356983..
Fix NOINET kernels after r356983.
Wed, Jan 22, 3:07 PM
bz accepted D23242: Enter network epoch for network interrupts.

One small nit on a comment.

Wed, Jan 22, 2:59 PM
bz added a reviewer for D23317: Fix epoch-related panic in ipdivert & refactor div_output.: glebius.
Wed, Jan 22, 2:50 PM

Tue, Jan 21

bz accepted D23075: Bring back redirect route expiration..

It's extremely hard in Phabricator to follow the changes between the last round and this so I am not sure I found all the changes fixed and comments done.

Tue, Jan 21, 10:16 PM
bz added a comment to D23242: Enter network epoch for network interrupts.

Can you please update the diff? I doen't apply cleanly to head (anymore):

Tue, Jan 21, 10:14 AM

Jan 17 2020

bz added a comment to D23187: Widen epoch coverage (step 2) + refactor PCB info locking (step 2)..

Hi Glebius, I have a patch which tried to remove recursions within netinet6. I was down to one in December and since new ones have shown up. I am not sure if I'll be able to look at this one before next week but I'll try to upload my current work in progress in case that'll help you. I have EPOCH calls around all ip6_output() calls which this one equally adds, so most of my changes should be "downstream" from yours.

Jan 17 2020, 6:30 PM

Jan 12 2020

bz committed rS356662: nd6_rtr: constantly use __func__ for nd6log().
nd6_rtr: constantly use __func__ for nd6log()
Jan 12 2020, 5:41 PM
bz committed rS356661: nd6_rtr: make nd6_prefix_onlink() static.
nd6_rtr: make nd6_prefix_onlink() static
Jan 12 2020, 4:58 PM
bz added a comment to D23145: dwc(4) Ethernet MAC address setting/generating.
In D23145#507260, @manu wrote:

The bindings (https://github.com/torvalds/linux/blob/master/Documentation/devicetree/bindings/net/ethernet-controller.yaml#L16) seems to indicate
that mac-address should be used if it exists and is prefered to local-mac-address.
Maybe change dwc_get_hwaddr_fdt to handle that and make it a generic helper ?

Jan 12 2020, 4:30 PM
bz created D23145: dwc(4) Ethernet MAC address setting/generating.
Jan 12 2020, 3:03 PM

Jan 11 2020

bz committed rS356638: in6_mcast: make in6_joingroup_locked() static.
in6_mcast: make in6_joingroup_locked() static
Jan 11 2020, 6:55 PM
bz committed rS356625: MFC 346398 (by thj):.
MFC 346398 (by thj):
Jan 11 2020, 1:57 AM
bz committed rS356623: MFC r354643:.
MFC r354643:
Jan 11 2020, 1:15 AM
bz committed rS356622: MFC r355449,355466:.
MFC r355449,355466:
Jan 11 2020, 12:11 AM
bz committed rS356621: MFC r354857:.
MFC r354857:
Jan 11 2020, 12:08 AM

Jan 10 2020

bz committed rS356620: MFC r354726,354755:.
MFC r354726,354755:
Jan 10 2020, 11:52 PM
bz committed rS356619: MFC r354462,354643,354680,354731,354748-354750,354757,354831-354832,.
MFC r354462,354643,354680,354731,354748-354750,354757,354831-354832,
Jan 10 2020, 11:46 PM
bz committed rS356616: MFC r354542:.
MFC r354542:
Jan 10 2020, 10:10 PM
bz added inline comments to D23097: Revert VNET change and expand VNET structure..
Jan 10 2020, 3:23 PM
bz added a reviewer for D23051: Allow address lookups in rn_match().: bz.

I'll be happy to have a look (probably next week and once the redirect stuff is in)

Jan 10 2020, 3:02 PM
bz added inline comments to D23075: Bring back redirect route expiration..
Jan 10 2020, 1:41 PM
bz requested changes to D23075: Bring back redirect route expiration..

I've not looked at the test cases (yet) in particular detail.
There's 2 or 3 functional questions, most is just comments and whitespace.

Jan 10 2020, 12:20 PM

Jan 9 2020

bz added a comment to D23047: Add fibnum, family and vnet pointer to each rib head..

The AF can be set in in6_inithead() already but I understand if you want to do all in the callers together; sounds like a good compromise for an MFC :-) Thanks!

Jan 9 2020, 4:10 PM
bz accepted D23047: Add fibnum, family and vnet pointer to each rib head..

Thank you so much for splitting this out. It really helps a lot! спасибо большой!

Jan 9 2020, 1:08 PM

Jan 8 2020

bz added a comment to D23097: Revert VNET change and expand VNET structure..

For @hselasky: this does not yet fix the vnet0 issue. That'll be sorted out after this.

Jan 8 2020, 11:47 PM
bz created D23097: Revert VNET change and expand VNET structure..
Jan 8 2020, 11:46 PM
bz committed rS356529: Remove duplicate kernel.h include which came back with 356524 due to.
Remove duplicate kernel.h include which came back with 356524 due to
Jan 8 2020, 11:39 PM
bz committed rS356528: Run netoptions startup script in vnet jails..
Run netoptions startup script in vnet jails.
Jan 8 2020, 11:35 PM
bz committed rS356527: vnet: virtualise more network stack sysctls..
vnet: virtualise more network stack sysctls.
Jan 8 2020, 11:30 PM
bz committed rS356524: MFC r346535 (by hselasky):.
MFC r346535 (by hselasky):
Jan 8 2020, 10:59 PM
bz committed rS356497: MFC r348671:.
MFC r348671:
Jan 8 2020, 5:06 PM
bz committed rS356496: MFC r348861:.
MFC r348861:
Jan 8 2020, 5:04 PM
bz committed rS356495: MFC r354747:.
MFC r354747:
Jan 8 2020, 5:03 PM
bz committed rS356493: MFC r354357-354358,354390,354395:.
MFC r354357-354358,354390,354395:
Jan 8 2020, 4:32 PM
bz committed rS356492: MFC r354092:.
MFC r354092:
Jan 8 2020, 4:16 PM
bz committed rS356491: MFC r350748,353792-353794,353963,353965-353966,354016-354017,.
MFC r350748,353792-353794,353963,353965-353966,354016-354017,
Jan 8 2020, 4:14 PM
bz committed rS356490: MFC r344301 (by thj):.
MFC r344301 (by thj):
Jan 8 2020, 3:51 PM
bz committed rS356489: MFC r353635 (by hselasky):.
MFC r353635 (by hselasky):
Jan 8 2020, 3:41 PM

Jan 7 2020

bz added a reviewer for D21163: Make p_vaddr % p_align == p_offset % p_align for TLS segments.: dim.

I've a patch with this + the LLVM changes running on arm64 for a bit:

Jan 7 2020, 6:18 PM
bz committed rS356456: MFC r355070:.
MFC r355070:
Jan 7 2020, 5:03 PM
bz committed rS356455: MFC r355070:.
MFC r355070:
Jan 7 2020, 4:59 PM
bz committed rS356454: MFC r354639:.
MFC r354639:
Jan 7 2020, 4:55 PM
bz committed rS356453: MFC r354639:.
MFC r354639:
Jan 7 2020, 4:55 PM
bz committed rS356451: MFC r354572:.
MFC r354572:
Jan 7 2020, 4:52 PM
bz committed rS356450: MFC r354572:.
MFC r354572:
Jan 7 2020, 4:52 PM
bz committed rS356449: MFC r354416:.
MFC r354416:
Jan 7 2020, 4:50 PM
bz committed rS356448: MFC r354416:.
MFC r354416:
Jan 7 2020, 4:50 PM
bz committed rS356447: MFC r351329:.
MFC r351329:
Jan 7 2020, 4:47 PM
bz committed rS356446: MFC r351327:.
MFC r351327:
Jan 7 2020, 4:44 PM

Jan 5 2020

bz committed rS356386: netgraph/ng_bridge: Reestablish old ABI.
netgraph/ng_bridge: Reestablish old ABI
Jan 5 2020, 7:14 PM
bz closed D21961: netgraph/ng_bridge: Reestablish old ABI.
Jan 5 2020, 7:14 PM
bz requested changes to D21961: netgraph/ng_bridge: Reestablish old ABI.

I'll go ahead and commit it anyway; I think the is no need to refine the review again.

Jan 5 2020, 5:06 PM

Jan 3 2020

bz requested changes to D21961: netgraph/ng_bridge: Reestablish old ABI.
Jan 3 2020, 10:44 PM
bz requested changes to D21961: netgraph/ng_bridge: Reestablish old ABI.
Jan 3 2020, 1:46 PM
bz added a reviewer for D21961: netgraph/ng_bridge: Reestablish old ABI: bz.

Seems this needs someone to commit it; I'll try to do this afternoon (timezone unspecified ;-)).

Jan 3 2020, 11:51 AM

Jan 2 2020

bz added a comment to D22988: Bring back redirect route expiration..
Jan 2 2020, 10:29 PM
bz added a comment to D22988: Bring back redirect route expiration..

I have a very annoying question: how much extra work would it be to split this up into: (a) adding rib_fibnum, rib_family and rib_vnet fields and changing the KPI for them by adding them to the current calls and then (b) adding the new functionality (and changing the support function logic beyond just passing the extra fields around)?
It would make the change history much more clear and also make it easier to review things.

Jan 2 2020, 9:50 PM
bz accepted D22780: if_vmove: return proper error status.

Looks good to me.

Jan 2 2020, 10:34 AM

Dec 18 2019

bz accepted D22865: Remove dead code from in6_rmx.c.
In D22865#500609, @ae wrote:
Dec 18 2019, 11:51 AM
bz committed rS355880: MFC r350532-350536,350559,350584-350585,350746-350747:.
MFC r350532-350536,350559,350584-350585,350746-350747:
Dec 18 2019, 11:49 AM
bz added a comment to D22865: Remove dead code from in6_rmx.c.
In D22865#500605, @ae wrote:

We removed this code two years ago, since it adds big penalty for routers where are tens of thousands IPv6 routes.
However, someone in the mail list recently complained that we have not a method for route expiring, probably we can rework this code to implement such feature.

Dec 18 2019, 11:39 AM
bz accepted D22848: Leave multicast group before reaping and committing state.

The v6 change looks ok to me for as much as I still understand the code.

Dec 18 2019, 11:31 AM
bz added a comment to D18856: new driver: Tehuti networks tn40xx device driver..

I was wondering if we can have a man page along with this as my first question was "what kind of driver is this?" Sadly the description of this review doesn't say much.

Dec 18 2019, 11:21 AM
bz committed rS355870: MFC r350531:.
MFC r350531:
Dec 18 2019, 12:12 AM

Dec 17 2019

bz committed rS355869: MFC r350522:.
MFC r350522:
Dec 17 2019, 11:45 PM
bz committed rS355868: MFC r350522:.
MFC r350522:
Dec 17 2019, 11:45 PM

Dec 6 2019

bz committed rS355466: Remove the extra epoch tracker change sneaked into r355449 and was not part.
Remove the extra epoch tracker change sneaked into r355449 and was not part
Dec 6 2019, 10:20 PM
bz created D22713: Implement optional table entry limits of if_llatbl..
Dec 6 2019, 10:14 PM
bz created D22712: Add Router and Prefix table limits..
Dec 6 2019, 9:58 PM
bz created D22711: Add new ICMPv6 counters for Anti-DoS limits.
Dec 6 2019, 9:54 PM
bz added a comment to D22447: Implement NDP resource limits..

I'l split this up into a couple of chunks so we can more easily do the base infrastructure for the llatbl changes for IPv6 and the IPv4.
The rtr and prefix parts are unrelated to that.

Dec 6 2019, 7:12 PM
bz committed rS355452: Update comment..
Update comment.
Dec 6 2019, 4:53 PM
bz closed D22462: ip6_input: remove redundant v4mapped check.
Dec 6 2019, 4:43 PM
bz committed rS355450: ip6_input: remove redundant v4mapped check.
ip6_input: remove redundant v4mapped check
Dec 6 2019, 4:43 PM
bz committed rS355449: carp: replace caddr_t with char *.
carp: replace caddr_t with char *
Dec 6 2019, 4:36 PM