Updated version at https://reviews.freebsd.org/D58320

REbase in the hope that with this the stack applies cleanly as well.

In D58306#1337381, @bnovkov wrote:

In D58306#1337245, @bz wrote:

Please see the wireless mailing list where I sent a patch for test and did not get feedback. Changing the driver is the wrong thing to do (not that it works well currently).

https://lists.freebsd.org/archives/freebsd-wireless/2026-July/004328.html

Ah, I wasn't aware of your patch, thanks for pointing this out.
FWIW your patch fixes the message spam on my machine.
I'll abandon this revision so please feel free to commit the patch you proposed.

Please see the wireless mailing list where I sent a patch for test and did not get feedback. Changing the driver is the wrong thing to do (not that it works well currently).

Properly nest calls.

In D58298#1337045, @kib wrote:

For the discussion, I am still somewhat surprised that so much of the FreeBSD symbols are leaked into linuxkpi headers, Most amusing and dangerous is PAGE_MASK (AFAIR).

In D58298#1337032, @markj wrote:

Fine, but this introduces a dependency on sys/param.h wherever these macros are used. Is it ok to include that file into Linux sources in general?

I can confirm that having the same local PtP (Point-to-Point, in contrast to P2P peer-2-peer) address has been a working feature since the 90s, when people were still operating modem banks.
I am pretty sure I used to have two outgoing connections for most of the 2000s with the same feature (and no need for it to be on loopback but also didn't care about the [icmp] error cases in that setup).

See https://reviews.freebsd.org/D57465 , which you approved before.

In D58211#1335366, @pouria wrote:

It helps, but not much. it might increase ifi->timer.tv_sec to PROBE_INTERVAL which is 60s.

I think the only thing I'd love to see is to tell users in the commit message how to apply this as it seems this needs to be done manually.

@emaste had a comment for you here. Can you update?

Rebase and this time actually update the review.

Apply fixes as pointed out. Thanks a lot for the review!

I have https://reviews.freebsd.org/D58169 open in case you want to see a pr_debug() example file with a lot more stubbed only functions.

Modulo LINT and LKPI_PAGE changes for older branches: master, 6.12-lts, 6.6-lts and 6.1-lts seemed fine

The duplicate was suppoed to be a pm_runtime_resume(); re-add.

Remove duplicate pm_runtime_put().

In D47379#1333680, @jbo wrote:

I just came across this diff. Apparently no activity since November 2024 - is this still relevant?

I am currently trying to compile as many drm-kmod branches on main as I can to make sure this does not break any.

P2S: also pr_debug("TODO: %s\n", func); for all the empty functions?

Post-commit review: the upstream file is MIT. We may consider just pulling that in (in parts) and reflect that in the license?

https://reviews.freebsd.org/D58104 will do the general bits for us. For the others none of the HW I still have will see an update anymore; only powered off and gone.

Anyone? Otherwise I'll commit this the next days.

Anyone? Otherwise I'll commit this the next days.

Anyone? Otherwise I'll commit this the next days.

I'll be happy if this lands as I'll finally be able to ditch (updated versions) of https://reviews.freebsd.org/D23145 out of my tree. Thank you!

In D58020#1330655, @adrian wrote:

ugh ok why's do_ht being set when there's no htcap/htinfo fields.

OH, hilarious, it's because you have VHT parameters but not HT parameters? That's problematic. Would you mind doing an "ifconfig -v wlan0 list scan" to capture what's being seen in the scan, find the entry that has VHT parameters and not HT parameters, and including it in here?

Would you mind adding a note what this will be good for in the future to the proposed commit message?