Page MenuHomeFreeBSD

bz (Bjoern A. Zeeb)
User

Projects (6)

User Details

User Since
Aug 29 2014, 12:11 PM (275 w, 3 d)

Recent Activity

Fri, Dec 6

bz committed rS355466: Remove the extra epoch tracker change sneaked into r355449 and was not part.
Remove the extra epoch tracker change sneaked into r355449 and was not part
Fri, Dec 6, 10:20 PM
bz created D22713: Implement optional table entry limits of if_llatbl..
Fri, Dec 6, 10:14 PM
bz created D22712: Add Router and Prefix table limits..
Fri, Dec 6, 9:58 PM
bz created D22711: Add new ICMPv6 counters for Anti-DoS limits.
Fri, Dec 6, 9:54 PM
bz added a comment to D22447: Implement NDP resource limits..

I'l split this up into a couple of chunks so we can more easily do the base infrastructure for the llatbl changes for IPv6 and the IPv4.
The rtr and prefix parts are unrelated to that.

Fri, Dec 6, 7:12 PM
bz committed rS355452: Update comment..
Update comment.
Fri, Dec 6, 4:53 PM
bz closed D22462: ip6_input: remove redundant v4mapped check.
Fri, Dec 6, 4:43 PM
bz committed rS355450: ip6_input: remove redundant v4mapped check.
ip6_input: remove redundant v4mapped check
Fri, Dec 6, 4:43 PM
bz committed rS355449: carp: replace caddr_t with char *.
carp: replace caddr_t with char *
Fri, Dec 6, 4:36 PM
bz closed D22399: carp: replace caddr_t with char *.
Fri, Dec 6, 4:36 PM
bz committed rS355448: Improve EPOCH_TRACE.
Improve EPOCH_TRACE
Fri, Dec 6, 4:34 PM
bz closed D22641: Improve EPOCH_TRACE.
Fri, Dec 6, 4:34 PM

Tue, Dec 3

bz committed rS355327: Make icmp6_reflect() static..
Make icmp6_reflect() static.
Tue, Dec 3, 2:47 PM
bz added a comment to D22399: carp: replace caddr_t with char *.

In case I don't hear from you I'll go ahead and commit this the next days.

Tue, Dec 3, 2:07 PM
bz created D22641: Improve EPOCH_TRACE.
Tue, Dec 3, 2:05 PM

Mon, Dec 2

bz added a comment to D22447: Implement NDP resource limits..

Thanks a lot for the feedback. let me know what you think about the suggestion to move the basic functionality into llatbl?

Mon, Dec 2, 9:08 PM
bz added inline comments to D22447: Implement NDP resource limits..
Mon, Dec 2, 4:30 PM
bz updated the diff for D22447: Implement NDP resource limits..

Address variable naming.
Address conditional checks.

Mon, Dec 2, 4:28 PM

Sun, Dec 1

bz committed rS355254: Fix m_pullup() problem after removing PULLDOWN_TESTs and KAME EXT_*macros..
Fix m_pullup() problem after removing PULLDOWN_TESTs and KAME EXT_*macros.
Sun, Dec 1, 12:22 AM

Mon, Nov 25

bz added a comment to D22447: Implement NDP resource limits..

Ignoring the one maximum value, is anyone interest in actually reviewing this?

Mon, Nov 25, 11:00 PM
bz added inline comments to D22447: Implement NDP resource limits..
Mon, Nov 25, 11:00 PM

Sun, Nov 24

bz committed rS355070: Allow kernel to compile without BPF..
Allow kernel to compile without BPF.
Sun, Nov 24, 11:22 PM
bz updated the diff for D22487: [WIP] Add IPv6 NFS Root support.

inet_pton() stroes network byte order, so lose the original (now extra)
htonl() and unbreak IPv4 support.

Sun, Nov 24, 10:56 PM
bz added inline comments to D22447: Implement NDP resource limits..
Sun, Nov 24, 10:42 PM

Fri, Nov 22

bz added a comment to D22487: [WIP] Add IPv6 NFS Root support.

Trying to understand your bootp comment in summary. Are you pointing at no support yet for https://tools.ietf.org/html/rfc5970 or that there just isn't a ipv6 option for defining boot info like bootp had?

Fri, Nov 22, 12:21 AM

Thu, Nov 21

bz created D22487: [WIP] Add IPv6 NFS Root support.
Thu, Nov 21, 8:45 PM

Wed, Nov 20

bz added inline comments to D22447: Implement NDP resource limits..
Wed, Nov 20, 9:45 PM
bz created D22462: ip6_input: remove redundant v4mapped check.
Wed, Nov 20, 6:32 PM

Tue, Nov 19

bz created D22447: Implement NDP resource limits..
Tue, Nov 19, 10:51 PM
bz committed rS354865: in6: move include.
in6: move include
Tue, Nov 19, 9:14 PM
bz committed rS354863: nd6: sysctl.
nd6: sysctl
Tue, Nov 19, 9:08 PM
bz committed rS354862: nd6: make nd6_timer_ch static.
nd6: make nd6_timer_ch static
Tue, Nov 19, 8:54 PM
bz committed rS354861: nd6_rtr: re-sort functions.
nd6_rtr: re-sort functions
Tue, Nov 19, 8:34 PM
bz closed D22443: Reduce the vnet_set module size of ip_mroute to allow loading as a module..
Tue, Nov 19, 3:39 PM
bz committed rS354857: Reduce the vnet_set module size of ip_mroute to allow loading as a module..
Reduce the vnet_set module size of ip_mroute to allow loading as a module.
Tue, Nov 19, 3:39 PM
bz committed rS354855: mld: fix epoch assertion.
mld: fix epoch assertion
Tue, Nov 19, 2:53 PM
bz added a comment to D21179: Add header definition for RFC4340, Datagram Congestion Control Protocol.

Approved by: bz (co-mentor)

Tue, Nov 19, 2:29 PM
bz requested changes to D21180: Add Parameter Problem type for Incomplete Header Chain.
Tue, Nov 19, 2:28 PM
bz added inline comments to D22443: Reduce the vnet_set module size of ip_mroute to allow loading as a module..
Tue, Nov 19, 2:14 PM
bz updated the diff for D22443: Reduce the vnet_set module size of ip_mroute to allow loading as a module..

Address kp's catch of the SYSCTL_OPAQUE size.

Tue, Nov 19, 2:13 PM
bz created D22443: Reduce the vnet_set module size of ip_mroute to allow loading as a module..
Tue, Nov 19, 1:53 PM

Mon, Nov 18

bz committed rS354832: icmpv6: Fix mbuf change in mld.
icmpv6: Fix mbuf change in mld
Mon, Nov 18, 10:00 PM
bz committed rS354831: ipv6 tests.
ipv6 tests
Mon, Nov 18, 9:54 PM

Sat, Nov 16

bz created D22399: carp: replace caddr_t with char *.
Sat, Nov 16, 12:35 AM
bz committed rS354758: nd6: retire defrouter_select(), use _fib() variant..
nd6: retire defrouter_select(), use _fib() variant.
Sat, Nov 16, 12:17 AM
bz committed rS354757: nd6_rtr:.
nd6_rtr:
Sat, Nov 16, 12:02 AM

Fri, Nov 15

bz committed rS354755: if_llatbl: change htable_unlink_entry() to early exist if no work to do.
if_llatbl: change htable_unlink_entry() to early exist if no work to do
Fri, Nov 15, 11:12 PM
bz committed rS354751: Remove now unused IPv6 macros and update docs..
Remove now unused IPv6 macros and update docs.
Fri, Nov 15, 9:55 PM
bz committed rS354750: IP6_EXTHDR_CHECK(): remove the last instances.
IP6_EXTHDR_CHECK(): remove the last instances
Fri, Nov 15, 9:51 PM
bz committed rS354749: netinet*: replace IP6_EXTHDR_GET().
netinet*: replace IP6_EXTHDR_GET()
Fri, Nov 15, 9:44 PM
bz closed D22335: netinet*: replace IP6_EXTHDR_GET().
Fri, Nov 15, 9:44 PM
bz closed D22334: netinet6: Remove PULLDOWN_TESTs..
Fri, Nov 15, 9:41 PM
bz committed rS354748: netinet6: Remove PULLDOWN_TESTs..
netinet6: Remove PULLDOWN_TESTs.
Fri, Nov 15, 9:40 PM
bz added a comment to D22334: netinet6: Remove PULLDOWN_TESTs..

Thanks a lot for reviewing! Much appreciated!

Fri, Nov 15, 9:37 PM
bz committed rS354747: Allow per-file lex and yacc options..
Allow per-file lex and yacc options.
Fri, Nov 15, 9:19 PM
bz closed D22337: Allow per-file lex and yacc options..
Fri, Nov 15, 9:19 PM
bz committed rS354731: nd6: simplify code.
nd6: simplify code
Fri, Nov 15, 1:45 PM
bz committed rS354726: if_llatbl: cleanup.
if_llatbl: cleanup
Fri, Nov 15, 11:00 AM

Wed, Nov 13

bz committed rS354682: nd6: remove unused structs and defines.
nd6: remove unused structs and defines
Wed, Nov 13, 2:28 PM
bz committed rS354681: nd6: make nd6_alloc() file static.
nd6: make nd6_alloc() file static
Wed, Nov 13, 1:53 PM
bz committed rS354680: nd6 defrouter: consolidate nd_defrouter manipulations in nd6_rtr.c.
nd6 defrouter: consolidate nd_defrouter manipulations in nd6_rtr.c
Wed, Nov 13, 12:06 PM
bz committed rS354679: lltabl: remove dead code.
lltabl: remove dead code
Wed, Nov 13, 11:21 AM
bz added a comment to D22334: netinet6: Remove PULLDOWN_TESTs..
In D22334#488613, @ae wrote:

The most of code that uses m_pullup() does check first, that the call is needed. Do you think that now it is considered as light enough, to do not check this?

Wed, Nov 13, 11:17 AM

Tue, Nov 12

bz updated the diff for D22337: Allow per-file lex and yacc options..

Rename FOO_<> to FOO.<> as requested by @imp.

Tue, Nov 12, 11:39 PM
bz added inline comments to D22337: Allow per-file lex and yacc options..
Tue, Nov 12, 11:20 PM
bz created D22337: Allow per-file lex and yacc options..
Tue, Nov 12, 10:01 PM
bz created D22335: netinet*: replace IP6_EXTHDR_GET().
Tue, Nov 12, 6:05 PM
bz created D22334: netinet6: Remove PULLDOWN_TESTs..
Tue, Nov 12, 5:44 PM
bz committed rS354643: netinet*: update *mp to pass the proper value back.
netinet*: update *mp to pass the proper value back
Tue, Nov 12, 3:46 PM
bz committed rS354639: netstat: igmp stats, error on unexpected information, not only warn.
netstat: igmp stats, error on unexpected information, not only warn
Tue, Nov 12, 1:57 PM

Mon, Nov 11

bz accepted D22311: Fix netstat -gs with ip_mroute module and/or vnet.

libkvm does know about VNETs (see kvm_private.c / kvm_vnet.c) as much as it knows about DPCPU. I seem to remember however it needs something selected, such as a PID or curthread from the dump, as it gets VNET information from there. This is probably something that should be generally fixed for netstat and not just for mrouting, though I am sure I tested that on a core dump back then. People may have broken it or the netstat parts were never merged.

Mon, Nov 11, 4:48 PM

Sat, Nov 9

bz committed rS354572: libipsec: correct a typo.
libipsec: correct a typo
Sat, Nov 9, 9:59 PM

Nov 8 2019

bz closed D22155: frag6: properly handle atomic fragments according to RFCs..
Nov 8 2019, 2:37 PM
bz committed rS354542: frag6: properly handle atomic fragments according to RFCs..
frag6: properly handle atomic fragments according to RFCs.
Nov 8 2019, 2:37 PM

Nov 7 2019

bz added a comment to D22155: frag6: properly handle atomic fragments according to RFCs..

I'd like to commit the main part of the change with(out) the two changes I commented on the next 24 hours.
Does anyone want to have a look?

Nov 7 2019, 6:34 PM
bz committed rS354462: netinet*: variable cleanup.
netinet*: variable cleanup
Nov 7 2019, 6:30 PM

Nov 6 2019

bz committed rS354416: m_pulldown(): Change an if () panic() into a KASSERT()..
m_pulldown(): Change an if () panic() into a KASSERT().
Nov 6 2019, 10:40 PM
bz committed rS354395: IPv6 tests: test case for scapy bpf parsing bug.
IPv6 tests: test case for scapy bpf parsing bug
Nov 6 2019, 2:43 PM
bz committed rS354390: ipv6 tests: cleanup.
ipv6 tests: cleanup
Nov 6 2019, 2:31 PM

Nov 5 2019

bz committed rS354358: ip6 tests: Add very simplistic extension header tests.
ip6 tests: Add very simplistic extension header tests
Nov 5 2019, 10:59 AM
bz committed rS354357: frag6 tests: set end to catch timeout as error.
frag6 tests: set end to catch timeout as error
Nov 5 2019, 10:54 AM

Nov 4 2019

bz added a comment to D22197: Refactor PCB hash read lock (the epoch).

In general I really like the changes. I've not looked into the large chunks of sysctls / UDP / TCP in too much detail. I'll try to do them based on their individual git changes the next days (at least sysctl and UDP). Hope someone else will do the TCP bits.

Nov 4 2019, 6:53 PM

Oct 30 2019

bz added a comment to D22191: Add hardware breakpoint support to ddb.

All your "stub functions" return (0), when in fact they probably should return an error? Or what happens if someone tries to set a (hw)breakpoint on these architectures?

Oct 30 2019, 1:23 PM

Oct 28 2019

bz added inline comments to D22155: frag6: properly handle atomic fragments according to RFCs..
Oct 28 2019, 9:53 PM

Oct 26 2019

bz committed rS354121: Upgrade (scapy) py2 tests to work on py3..
Upgrade (scapy) py2 tests to work on py3.
Oct 26 2019, 9:20 PM

Oct 25 2019

bz created D22155: frag6: properly handle atomic fragments according to RFCs..
Oct 25 2019, 8:13 PM
bz committed rS354092: Properly set VNET when nuking recvif from fragment queues..
Properly set VNET when nuking recvif from fragment queues.
Oct 25 2019, 6:54 PM
bz closed D22153: Properly set VNET when nuking recvif from fragment queues.
Oct 25 2019, 6:54 PM
bz committed rS354084: frag6-test: update for r354046, conform to 8200 for overlapping fragments.
frag6-test: update for r354046, conform to 8200 for overlapping fragments
Oct 25 2019, 5:41 PM
bz created D22153: Properly set VNET when nuking recvif from fragment queues.
Oct 25 2019, 4:44 PM
bz committed rS354081: frag6: do not leak counter in error cases.
frag6: do not leak counter in error cases
Oct 25 2019, 4:29 PM

Oct 24 2019

bz committed rS354053: frag6: prevent overwriting initial fragoff=0 packet meta-data..
frag6: prevent overwriting initial fragoff=0 packet meta-data.
Oct 24 2019, 10:08 PM
bz committed rS354046: frag6: handling of overlapping fragments to conform to RFC 8200.
frag6: handling of overlapping fragments to conform to RFC 8200
Oct 24 2019, 8:23 PM
bz committed rS354045: frag6 test cases: check more counters, wait for expiry.
frag6 test cases: check more counters, wait for expiry
Oct 24 2019, 8:08 PM
bz committed rS354042: frag6: export another counter read-only by sysctl.
frag6: export another counter read-only by sysctl
Oct 24 2019, 8:00 PM
bz committed rS354040: frag6: fix counter leak in error case and optimise code.
frag6: fix counter leak in error case and optimise code
Oct 24 2019, 7:57 PM
bz committed rS354037: frag6.c: do not leak packet queue entry in error case.
frag6.c: do not leak packet queue entry in error case
Oct 24 2019, 7:47 PM
bz committed rS354020: frag6: leave a note about upper layer header checks TBD.
frag6: leave a note about upper layer header checks TBD
Oct 24 2019, 12:16 PM
bz committed rS354019: frag6: check global limits before hash and lock.
frag6: check global limits before hash and lock
Oct 24 2019, 11:58 AM
bz committed rS354017: frag6: small improvements.
frag6: small improvements
Oct 24 2019, 8:15 AM