Page MenuHomeFreeBSD

bz (Bjoern A. Zeeb)
User

Projects (13)

User Details

User Since
Aug 29 2014, 12:11 PM (637 w, 5 d)

Recent Activity

Wed, Nov 11

bz added a comment to D59883: linuxkpi: lkpi_vmf_insert_special_pte_locked().
In D59883#1408254, @kib wrote:

There should be two 'files' created by the detected hang:

	debugfs_create_file("i915_error_state", 0644, minor->debugfs_root, i915,
			    &i915_error_state_fops);
	debugfs_create_file("i915_gpu_info", 0644, minor->debugfs_root, i915,
			    &i915_gpu_info_fops);

Is debugfs converted to sysctls on FreeBSD? Anyway, these are the things to look at, they were the useful source of data when I debugged i915 in drm2 times.

Wed, Nov 11, 5:25 PM

Sun, Nov 8

bz added inline comments to D61217: LinuxKPI: Add mapping_gfp_mask() and four more folio/pagemap helpers.
Sun, Nov 8, 7:12 PM

Mon, Nov 2

bz added a comment to D61125: LinuxKPI: set pci_dev msi_cap and msix_cap.

I'd suggest to reduce it to this.
The ath11k explanation in the commit message is for ath11k but not generic LinuxKPI. There's a further issue if the commit message is correct to be dealt with as the native PCI stack, I believe tracks MSI state (also for resume) and may not be able to do so?

Mon, Nov 2, 9:53 PM · linuxkpi
bz edited reviewers for D61125: LinuxKPI: set pci_dev msi_cap and msix_cap, added: dumbbell; removed: adrian.

Adding @dumbbell as msix will change behaviour for amdgpu I believe; msi is indeed ath11k only currently. I'll deal with this as soon as I have stable internet again (as one notices as the submit didn't work the first time).

Mon, Nov 2, 9:32 PM · linuxkpi

Sat, Oct 31

bz added a comment to D61079: dpaa2: Avoid DPMAC link toggling.

You'll have to explain WHY this is possibly fixing the problem. Usually deferred contexts are not the right solutions to fix ordering problems (if that's what it would be)?

Sat, Oct 31, 6:29 PM

Fri, Oct 30

bz added a reviewer for D59436: linuxkpi: honor the prot argument in vmap: manu.
Fri, Oct 30, 7:59 PM
bz added a comment to D60795: graphics/drm-*-kmod, graphics/nvidia-drm*-kmod*: fix build after src commit 9820afb99e6f on main branch.

is this still necessary? it seems like the causal commit was reverted

Fri, Oct 30, 1:32 PM

Tue, Oct 20

bz committed rGd2145e9b9644: LinuxKPI: restore several hard coded return values for the CONFIG_PM case.
Tue, Oct 20, 11:25 PM
bz closed D60878: LinuxKPI: restore several hard coded return values for the CONFIG_PM case.
Tue, Oct 20, 11:24 PM · linuxkpi
bz accepted D60921: mmccam: Add a helper to change the host settings.
Tue, Oct 20, 5:47 PM
bz added a comment to D60878: LinuxKPI: restore several hard coded return values for the CONFIG_PM case.

Thanks for the feedback. I'll wait for @markj

Tue, Oct 20, 5:00 PM · linuxkpi
bz added a comment to D60884: mmccam: Add HS200 support for eMMC.

Would it be too much if I asked to do the factoring out of sdda_set_host_ios() upfront?

Tue, Oct 20, 1:41 PM

Mon, Oct 19

bz requested changes to D60874: linuxkpi: do not call link_sta_rc_update before the sta is added.

I'll have to go and look; I wonder if there was a mis-merge somewhere. Due to other generic LinuxKPI changes which were in review for quite a long time I had to rebase the entire code back then to get it in and only the recent changes (which were backed out as they broke drm-kmod as we know) would actually make all the lock assertions work again on a GENERIC kernel.

Mon, Oct 19, 9:52 PM
bz added a comment to D59883: linuxkpi: lkpi_vmf_insert_special_pte_locked().

(Still working on testing this. If I test drm-6.12 on my laptop, I get a corrupted display with or without this patch. After retesting drm-6.6 it seems there is some recent regression in main, as I now see similar symptoms there too, so I am bisecting that instead, hopefully will figure it out soon.)

Mon, Oct 19, 9:44 PM
bz requested review of D60878: LinuxKPI: restore several hard coded return values for the CONFIG_PM case.
Mon, Oct 19, 9:40 PM · linuxkpi

Oct 19 2026

bz added a comment to D58320: LinuxKPI: Add PAGE_IS_LKPI_PAGE for Linux struct page instead of vm_page.

Sorry for saying it that way:

Oct 19 2026, 12:12 PM

Oct 17 2026

bz accepted D59586: networking.7: Scope netif to wlan0.
Oct 17 2026, 6:38 PM
bz closed D60604: Status/2026Q3: LinuxKPI based wireless driver update.
Oct 17 2026, 12:56 PM
bz committed R9:e050e65347c6: Status/2026Q3: LinuxKPI based wireless driver update.
Oct 17 2026, 12:56 PM
bz added a reverting change for rG9820afb99e6f: LinuxKPI: introduce LINUXKPI_DEBUG to enable LinuxKPI debugging: rG6866177454ac: Revert LinuxKPI: LINUXKPI_DEBUG changes to allow drm-kmod to build.
Oct 17 2026, 9:26 AM
bz added a reverting change for rGbbfd52dcbeb7: LinuxKPI: use LINUXKPI_DEBUG to determine on witness lock tracing: rG6866177454ac: Revert LinuxKPI: LINUXKPI_DEBUG changes to allow drm-kmod to build.
Oct 17 2026, 9:26 AM
bz committed rG6866177454ac: Revert LinuxKPI: LINUXKPI_DEBUG changes to allow drm-kmod to build.
Oct 17 2026, 9:26 AM
bz added a reverting change for D54060: LinuxKPI: introduce LINUXKPI_DEBUG to enable LinuxKPI debugging: rG6866177454ac: Revert LinuxKPI: LINUXKPI_DEBUG changes to allow drm-kmod to build.
Oct 17 2026, 9:26 AM · linuxkpi
bz added a reverting change for D59231: LinuxKPI: use LINUXKPI_DEBUG to determine on witness lock tracing: rG6866177454ac: Revert LinuxKPI: LINUXKPI_DEBUG changes to allow drm-kmod to build.
Oct 17 2026, 9:26 AM · linuxkpi

Oct 14 2026

bz requested changes to D59920: rtlbtfw: add firmware to base.

Firmware goes to ports these days. Use fwget to install it.

Oct 14 2026, 1:58 PM

Oct 13 2026

bz added inline comments to D60208: linuxkpi.4: extend for compilation and tracking consumers.
Oct 13 2026, 10:47 PM
bz requested review of D60716: LinuxKPI: add field_get() and FIELD_GET_SIGNED().
Oct 13 2026, 10:23 PM · linuxkpi
bz requested review of D60715: LinuxKPI: adjust return value of __ffs64.
Oct 13 2026, 10:19 PM · linuxkpi
bz added a comment to D60208: linuxkpi.4: extend for compilation and tracking consumers.

This seems to be the "final" version to review given the parent review is accepted.

Oct 13 2026, 9:43 PM

Oct 12 2026

bz requested review of D60687: LinuxKPI: pci: implement pci_clear_and_set_config_dword().
Oct 12 2026, 10:08 PM · linuxkpi
bz updated subscribers of D60207: LinuxKPI: rework module build options to use LINUXKPI_FEATURES.

Adding @dumbbell given the recent drm-kmod build issues after my changes to LinuxKPI as this will be interesting there (though a lot harder to introduce given drm-kmod also needs to compile on older branches).

Oct 12 2026, 11:23 AM · linuxkpi
bz added a project to D60245: LinuxKPI: rework cleanup.h to use CLASS: linuxkpi.
Oct 12 2026, 1:25 AM · linuxkpi
bz added a project to D60207: LinuxKPI: rework module build options to use LINUXKPI_FEATURES: linuxkpi.
Oct 12 2026, 1:24 AM · linuxkpi
bz requested review of D60632: LinuxKPI: add SPACEMIT PCI IDs.
Oct 12 2026, 12:48 AM · linuxkpi
bz requested review of D60631: LinuxKPI: add spinlock_bh guard support.
Oct 12 2026, 12:36 AM · linuxkpi
bz retitled D60630: LinuxKPI: firmware: ensure name stays valid from LinuxKPI: firmware: ensure name stay valid
Oct 12 2026, 12:22 AM · linuxkpi
bz requested review of D60630: LinuxKPI: firmware: ensure name stays valid.
Oct 12 2026, 12:21 AM · linuxkpi

Oct 11 2026

bz added inline comments to D60208: linuxkpi.4: extend for compilation and tracking consumers.
Oct 11 2026, 11:21 PM
bz updated the diff for D60208: linuxkpi.4: extend for compilation and tracking consumers.

Thankfully apply suggestions from @ziaee .
Given the changes in D60207 update the section of the man page to match the reality of the stack.

Oct 11 2026, 11:21 PM
bz added inline comments to D43720: LinuxKPI: dev_coredump implementation (NOT FOR COMMIT AS-IS).
Oct 11 2026, 8:49 PM
bz updated the diff for D60207: LinuxKPI: rework module build options to use LINUXKPI_FEATURES.

Adjust the code to LINUXKPI_FEATURES+= and add futher support.
Needless to say this makes the feature options also nicly grep-able.

Oct 11 2026, 3:16 PM · linuxkpi
bz retitled D60207: LinuxKPI: rework module build options to use LINUXKPI_FEATURES from LinuxKPI: rework module build options to use CFLAGS_LINUXKPI=
Oct 11 2026, 3:15 PM · linuxkpi
bz committed rG7c9ee41f4fe4: LinuxKPI: pci: first round of file cleanup.
Oct 11 2026, 1:52 PM
bz committed rGe2bef7e30aa7: LinuxKPI: pci: make internal variables file local.
Oct 11 2026, 1:52 PM
bz committed rG9d82546ac2de: LinuxKPI: pci: cleanup lkpinew_pci_dev_release().
Oct 11 2026, 1:52 PM
bz closed D57433: LinuxKPI: pci: first round of file cleanup.
Oct 11 2026, 1:51 PM · linuxkpi
bz closed D57432: LinuxKPI: pci: make internal variables file local.
Oct 11 2026, 1:51 PM · linuxkpi
bz closed D57431: LinuxKPI: pci: cleanup lkpinew_pci_dev_release().
Oct 11 2026, 1:51 PM · linuxkpi
bz requested review of D60604: Status/2026Q3: LinuxKPI based wireless driver update.
Oct 11 2026, 12:22 AM

Oct 10 2026

bz committed rGbbfd52dcbeb7: LinuxKPI: use LINUXKPI_DEBUG to determine on witness lock tracing.
Oct 10 2026, 6:29 PM
bz committed rG863fe7ae5152: LinuxKPI: re-implement pm_runtime.h.
Oct 10 2026, 6:29 PM
bz committed rG9820afb99e6f: LinuxKPI: introduce LINUXKPI_DEBUG to enable LinuxKPI debugging.
Oct 10 2026, 6:29 PM
bz committed rG53beb6950f94: LinuxKPI; factor out parts of device.h into device/devres.h.
Oct 10 2026, 6:29 PM
bz committed rG3521cce445d4: lindebugfs: implement debugfs_create_devm_seqfile().
Oct 10 2026, 6:29 PM
bz committed rG33901f0d6f7b: ng_ubt: ignore further MediaTek USB BT devices.
Oct 10 2026, 6:29 PM
bz closed D59231: LinuxKPI: use LINUXKPI_DEBUG to determine on witness lock tracing.
Oct 10 2026, 6:29 PM · linuxkpi
bz closed D58169: LinuxKPI: re-implement pm_runtime.h.
Oct 10 2026, 6:29 PM · linuxkpi
bz closed D54060: LinuxKPI: introduce LINUXKPI_DEBUG to enable LinuxKPI debugging.
Oct 10 2026, 6:29 PM · linuxkpi
bz closed D60279: ng_ubt: ignore further MediaTek USB BT devices.
Oct 10 2026, 6:29 PM
bz closed D60213: LinuxKPI; factor out parts of device.h into device/devres.h.
Oct 10 2026, 6:29 PM
bz closed D57524: lindebugfs: implement debugfs_create_devm_seqfile().
Oct 10 2026, 6:29 PM · linuxkpi

Oct 9 2026

bz added a comment to D60207: LinuxKPI: rework module build options to use LINUXKPI_FEATURES.
In D60207#1387495, @kib wrote:

Might be LINUXKPI_FEATURES then? It is more aligned with the feature list that the variable takes.

Oct 9 2026, 12:24 AM · linuxkpi

Oct 8 2026

bz added a comment to D60207: LinuxKPI: rework module build options to use LINUXKPI_FEATURES.
In D60207#1387061, @kib wrote:
Oct 8 2026, 2:35 PM · linuxkpi

Oct 6 2026

bz added a comment to D60207: LinuxKPI: rework module build options to use LINUXKPI_FEATURES.

What if I'll change it one step further and call it LINUXKPI_ADD and we add GENSRC to that too along with INCLUDES?

Oct 6 2026, 9:19 PM · linuxkpi
bz updated the diff for D60279: ng_ubt: ignore further MediaTek USB BT devices.

Add the one from @emaste (thanks!) while still here.

Oct 6 2026, 6:47 PM
bz added a comment to D60279: ng_ubt: ignore further MediaTek USB BT devices.
In D60279#1385571, @imp wrote:

Just curious: What would it take to add support for these?

Oct 6 2026, 6:43 PM
bz added a comment to D60279: ng_ubt: ignore further MediaTek USB BT devices.

@emaste what's your VID combination?

Oct 6 2026, 1:51 PM
bz updated the diff for D60279: ng_ubt: ignore further MediaTek USB BT devices.

Add another user supplied entry.

Oct 6 2026, 11:41 AM

Oct 4 2026

bz added a comment to D58451: linux_firmware: remove `enoentok` logic in `*firmware_request(..)`.

Alos please change the first line of the commit message to

LinuxKPI: firmware: ....
Oct 4 2026, 9:39 PM
bz accepted D58451: linux_firmware: remove `enoentok` logic in `*firmware_request(..)`.

I've done the due diligence and it seems for all LinuxKPI versions we care about we can apply this.

Oct 4 2026, 7:31 PM

Oct 3 2026

bz requested review of D60279: ng_ubt: ignore further MediaTek USB BT devices.
Oct 3 2026, 5:52 PM

Oct 2 2026

bz added inline comments to D60254: linuxkpi_wlan.4: migrate more details into the common man page.
Oct 2 2026, 7:42 PM
bz added a comment to D60254: linuxkpi_wlan.4: migrate more details into the common man page.

This is not ideal yet and I hope you can help me to get it polished and move things in the right place but it feels a lot better (at least to me) having one source of truth rather than (n+1) man pages with a copy of the (longer) text.

Oct 2 2026, 7:40 PM
bz requested review of D60254: linuxkpi_wlan.4: migrate more details into the common man page.
Oct 2 2026, 7:38 PM
bz requested review of D60245: LinuxKPI: rework cleanup.h to use CLASS.
Oct 2 2026, 11:53 AM · linuxkpi
bz added a comment to D60208: linuxkpi.4: extend for compilation and tracking consumers.

Some of this is stuff that we would normally keep on the wiki, I really like them being here in the tree instead. I think it's easier to see and maintain atomically.

Oct 2 2026, 11:43 AM

Oct 1 2026

bz requested review of D60213: LinuxKPI; factor out parts of device.h into device/devres.h.
Oct 1 2026, 11:13 PM
bz added a comment to D60199: linuxkpi: add uuid_t and helpers.

Careful! We already have a native uuid_t! Someone should check if (a) we can use that and (b) possible conflict potential.

Oct 1 2026, 8:28 PM
bz updated subscribers of D60038: LinuxKPI: Add PCI method for transferring framebuffer parameters.

If you mark the requested change "done" I am am fine if @emaste or @dumbbell are fine too; I assume they know what the fb_getinfo is supposed to do and how it is supposed to be used.

Oct 1 2026, 6:48 PM
bz added a comment to D60207: LinuxKPI: rework module build options to use LINUXKPI_FEATURES.

The logic seems sound but somehow CFLAGS_LINUXKPI is odd to me, like CFLAGS_* should contain flags rather than be a boolean. E.g. we have CFLAGS_NO_SIMD= -mno-mmx -mno-sse...
Hrm, but we also have e.g. SSP_CFLAGS?= -fstack-protector-strong -fstack-clash-protection and that form is more common.
ADD_LINUXKPI_CFLAGS?

Oct 1 2026, 6:43 PM · linuxkpi
bz updated subscribers of D60208: linuxkpi.4: extend for compilation and tracking consumers.
Oct 1 2026, 6:07 PM
bz added a comment to D60208: linuxkpi.4: extend for compilation and tracking consumers.

Please note there are a lot of commented out parts in there for drivers, etc. which do use LinuxKPI, which are in the tree, but not yet hooked up to the build.

Oct 1 2026, 6:03 PM
bz requested review of D60208: linuxkpi.4: extend for compilation and tracking consumers.
Oct 1 2026, 6:02 PM
bz requested review of D60207: LinuxKPI: rework module build options to use LINUXKPI_FEATURES.
Oct 1 2026, 6:01 PM · linuxkpi
bz added a comment to D59231: LinuxKPI: use LINUXKPI_DEBUG to determine on witness lock tracing.

I found out why this was not really working. I'll put a review up for fixing LINUXKPI_INCLUDES as soon as I put down linuxkpi.9 to document it.

Oct 1 2026, 1:43 PM · linuxkpi

Sep 30 2026

bz added a comment to D58169: LinuxKPI: re-implement pm_runtime.h.

Anyone on this fairly simple review?

Sep 30 2026, 11:04 AM · linuxkpi
bz abandoned D57430: LinuxKPI: pci: cleanup the error path in linux_pci_attach_device().

Superseded by D59913

Sep 30 2026, 11:03 AM · linuxkpi
bz abandoned D47409: release: factor out common code from make-memstick.sh.
Sep 30 2026, 11:02 AM
bz added a comment to D59748: Jail init process and virtual reboot.

I have an old (non-stack) stack open (I believe from 2018) of which you would have been a reviewer:

Sep 30 2026, 8:32 AM

Sep 26 2026

bz added a comment to D54060: LinuxKPI: introduce LINUXKPI_DEBUG to enable LinuxKPI debugging.

Ok, very last call. It's not been December in almost a year soon and May is also gone for a while. 48 hours.

Sep 26 2026, 7:47 PM · linuxkpi
bz added a comment to D60046: LinuxKPI: account for delayed work cancelled after taskqueue dequeue.

Can you please upload this with either arc or a patch from git diff -U9999 so context is available.

Sep 26 2026, 4:59 PM
bz added inline comments to D60038: LinuxKPI: Add PCI method for transferring framebuffer parameters.
Sep 26 2026, 11:00 AM

Sep 24 2026

bz accepted D59952: linuxkpi: avoid false KMSAN report.
Sep 24 2026, 7:01 AM

Sep 23 2026

bz added a comment to D59883: linuxkpi: lkpi_vmf_insert_special_pte_locked().

So let me ask: is this related to the "fictitious pages" mentioned in D58320? If so, how is the LinuxKPI part to be written/work in the future world order with a real 'struct page'?

Sep 23 2026, 3:44 PM
bz added a comment to D59913: linuxkpi: Fix double-cleanup in linux_pci_attach_device() error path.

Oh, I wonder how you can trigger this from the semi-native driver? What was @gallatin 's error case?

Sep 23 2026, 1:19 PM
bz accepted D59913: linuxkpi: Fix double-cleanup in linux_pci_attach_device() error path.

You should add something like:
Originally reported (and tested with D57430): Mark Millard <marklmi@yahoo.com> (current@ July 25 2026)

Sep 23 2026, 1:16 PM

Sep 22 2026

bz added a comment to D59913: linuxkpi: Fix double-cleanup in linux_pci_attach_device() error path.

I have a full stack up for review for ages for PCI.

Sep 22 2026, 7:23 PM

Sep 19 2026

bz committed rG9b0e73723f80: LinuxKPI: 802.11: Always lock around lkpi_80211_mo_{remove_interface,stop}() (authored by temcbun_gmail.com).
Sep 19 2026, 2:41 PM
bz committed rG4c6e74a7e582: UPDATING: bump __FreeBSD_version to 1501503 for LinuxKPI changes.
Sep 19 2026, 2:41 PM
bz committed rG28ca279559d3: LinuxKPI: add can_wakeup option and accessor functions.
Sep 19 2026, 2:41 PM