Page MenuHomeFreeBSD

bz (Bjoern A. Zeeb)
User

Projects (9)

User Details

User Since
Aug 29 2014, 12:11 PM (402 w, 4 d)

Recent Activity

Yesterday

bz committed R10:892b1874ace0: net80211: remove (optional) RSN from preobereq (authored by bz).
net80211: remove (optional) RSN from preobereq
Tue, May 17, 10:37 PM
bz closed D34893: net80211: remove (optional) RSN from preobereq.
Tue, May 17, 10:37 PM
bz added a comment to D35117: netinet6: streamline scope6 checks for loopback traffic in ip6_output()..

Indeed, this review packs two distinct changes. It targets the deterministic cache/lookup result, exactly as you suggested, so all cached/uncached always performs in same fashion. After untangling the ifp/originifp complexities, it resulted in empty if` condition after /* Check for valid scope ID. */, which made me think of simplifying the scope checks code as well. I'll split this diff into two, to simplify reviewing.

Tue, May 17, 9:59 AM
bz requested review of D35227: iwlwifi: Update man pages with card list.
Tue, May 17, 1:47 AM

Mon, May 16

bz added a comment to D35117: netinet6: streamline scope6 checks for loopback traffic in ip6_output()..

I am not sure if I currently can review this technically in full but we fixed a similar issue by the code you are currently changing in ef0111fdf364e4e87b522025b13aad69067c3fe6 .

Mon, May 16, 10:43 PM
bz committed R10:88a15f72cf6b: iwlwifi: import two fixes from linux v5.18-rc7 (authored by bz).
iwlwifi: import two fixes from linux v5.18-rc7
Mon, May 16, 6:13 PM
bz committed R10:275172b519e8: iwlwifi: update firmware (authored by bz).
iwlwifi: update firmware
Mon, May 16, 6:13 PM
bz committed R10:fac1f5938411: iwlwifi: update driver from iwlwifi-next (authored by bz).
iwlwifi: update driver from iwlwifi-next
Mon, May 16, 6:13 PM
bz committed R10:05d6f4d6968a: LinuxKPI: 802.11 add rfkill_soft_blocked() (authored by bz).
LinuxKPI: 802.11 add rfkill_soft_blocked()
Mon, May 16, 6:12 PM

Sat, May 14

bz updated subscribers of D35199: mbuf: unionize globally declared uses of PH_per and PH_loc.

I still do not like the idea that layer specifics are inside mbuf structs; I have not committed the @rrs approved https://reviews.freebsd.org/D34298 for reasons that I thought it'll need more discussions.

Sat, May 14, 4:22 PM

Wed, May 11

bz added a comment to D35162: LinuxKPI: Implement linux/hashtable.h for FreeBSD..

Do we need to bump the FreeBSD version for this - no?

Wed, May 11, 12:27 PM
bz accepted D35162: LinuxKPI: Implement linux/hashtable.h for FreeBSD..
Wed, May 11, 11:56 AM
bz added a comment to D35162: LinuxKPI: Implement linux/hashtable.h for FreeBSD..

I'd probably say "Dragonfly via drm-kmod" as you obtained it from drm-kmod?

Wed, May 11, 11:55 AM

Tue, May 10

bz added a comment to D35162: LinuxKPI: Implement linux/hashtable.h for FreeBSD..

Makes more code compile for me too. Thank you!

Tue, May 10, 11:09 PM
bz added a comment to D35162: LinuxKPI: Implement linux/hashtable.h for FreeBSD..

I'll give this a try tonight as well and have a closer look.
It's one of two missing pieces I need; in theory kfifo is the other one but I think that is used so little that I might simply change the code?

Tue, May 10, 1:11 PM

Fri, May 6

bz committed R10:464907ce1cf9: net80211: simplify code after STA/AP VAPs traffic hang fix (authored by bz).
net80211: simplify code after STA/AP VAPs traffic hang fix
Fri, May 6, 9:37 AM
bz closed D35135: net80211: simplify code after STA/AP VAPs traffic hang fix.
Fri, May 6, 9:37 AM
bz added a comment to D34893: net80211: remove (optional) RSN from preobereq.

Any comment on this one?

Fri, May 6, 9:36 AM

Thu, May 5

bz requested review of D35135: net80211: simplify code after STA/AP VAPs traffic hang fix.
Thu, May 5, 10:28 PM
bz committed R10:0881eb9665db: rtw88: update man page for loader tunable for >4GB of main memory (authored by bz).
rtw88: update man page for loader tunable for >4GB of main memory
Thu, May 5, 9:20 PM
bz committed R10:6a50157090f2: LinuxKPI: skbuff: add memlimit tunable for 64bit systems (authored by bz).
LinuxKPI: skbuff: add memlimit tunable for 64bit systems
Thu, May 5, 8:58 PM

Wed, May 4

bz committed R10:596167005078: LinuxKPI: 802.11: fill in two more TODOs (authored by bz).
LinuxKPI: 802.11: fill in two more TODOs
Wed, May 4, 3:18 PM
bz committed R10:1a86fec11b00: LinuxKPI: 802.11: use ieee80211_beacon_miss() (authored by bz).
LinuxKPI: 802.11: use ieee80211_beacon_miss()
Wed, May 4, 3:18 PM
bz committed R10:d5e65e74ebe7: LinuxKPI: 802.11 ieee80211_sn_sub() fix (authored by bz).
LinuxKPI: 802.11 ieee80211_sn_sub() fix
Wed, May 4, 3:18 PM

Sat, Apr 30

bz committed R10:00614c9c2ddc: LinuxKPI: 802.11: fill in two more TODOs (authored by bz).
LinuxKPI: 802.11: fill in two more TODOs
Sat, Apr 30, 8:04 AM
bz committed R10:3540911bfdd8: LinuxKPI: 802.11: use ieee80211_beacon_miss() (authored by bz).
LinuxKPI: 802.11: use ieee80211_beacon_miss()
Sat, Apr 30, 8:04 AM

Wed, Apr 27

bz committed R10:e140d551b786: rtw88: deal with debug messages (authored by bz).
rtw88: deal with debug messages
Wed, Apr 27, 3:26 PM

Mon, Apr 25

bz committed R10:b3e7f403a509: LinuxKPI: 802.11 ieee80211_sn_sub() fix (authored by bz).
LinuxKPI: 802.11 ieee80211_sn_sub() fix
Mon, Apr 25, 11:39 AM

Mon, Apr 18

bz committed R10:f71daf6a11b7: LinuxKPI: 802.11: start adding rate control to ieee80211_tx_status() (authored by bz).
LinuxKPI: 802.11: start adding rate control to ieee80211_tx_status()
Mon, Apr 18, 9:35 AM
bz committed R10:e4e2ad470e6b: LinuxKPI: 802.11: implement ieee80211_probereq_get() (authored by bz).
LinuxKPI: 802.11: implement ieee80211_probereq_get()
Mon, Apr 18, 9:35 AM
bz committed R10:c39947cdd369: LinuxKPI: skbuff: start implementing skb_copy() (authored by bz).
LinuxKPI: skbuff: start implementing skb_copy()
Mon, Apr 18, 9:35 AM
bz committed R10:3c1373110f80: LinuxKPI: 802.11: improve hw_scan (authored by bz).
LinuxKPI: 802.11: improve hw_scan
Mon, Apr 18, 9:35 AM
bz committed R10:bfa2e8f84086: LinuxKPI: skbuff: dev_kfree_skb_irq() and improvements (authored by bz).
LinuxKPI: skbuff: dev_kfree_skb_irq() and improvements
Mon, Apr 18, 9:34 AM
bz committed R10:4b63d8489ecf: LinuxKPI: 802.11: use an sx lock to protect the list of vifs (authored by bz).
LinuxKPI: 802.11: use an sx lock to protect the list of vifs
Mon, Apr 18, 9:34 AM

Apr 15 2022

bz committed R10:d9945d7821b9: LinuxKPI: 802.11: improve hw_scan (authored by bz).
LinuxKPI: 802.11: improve hw_scan
Apr 15 2022, 3:58 PM
bz committed R10:8891c45563f8: LinuxKPI: 802.11: use an sx lock to protect the list of vifs (authored by bz).
LinuxKPI: 802.11: use an sx lock to protect the list of vifs
Apr 15 2022, 3:58 PM
bz committed R10:383b3e8f509f: LinuxKPI: 802.11: start adding rate control to ieee80211_tx_status() (authored by bz).
LinuxKPI: 802.11: start adding rate control to ieee80211_tx_status()
Apr 15 2022, 3:58 PM
bz committed R10:ade774b19f9a: LinuxKPI: 802.11: implement ieee80211_probereq_get() (authored by bz).
LinuxKPI: 802.11: implement ieee80211_probereq_get()
Apr 15 2022, 3:57 PM
bz committed R10:349b042b9005: LinuxKPI: skbuff: start implementing skb_copy() (authored by bz).
LinuxKPI: skbuff: start implementing skb_copy()
Apr 15 2022, 3:57 PM
bz committed R10:952643ea4526: LinuxKPI: skbuff: dev_kfree_skb_irq() and improvements (authored by bz).
LinuxKPI: skbuff: dev_kfree_skb_irq() and improvements
Apr 15 2022, 3:57 PM

Apr 14 2022

bz added a comment to D34920: net80211: Fix traffic hang on STA/AP VAPs on a multi-VAP interface.

Was there a PR for this somewhere? If so, please mention that.

Apr 14 2022, 10:19 PM
bz added a comment to D34920: net80211: Fix traffic hang on STA/AP VAPs on a multi-VAP interface.

While your description is verbose and expressive I still found it a bit hard to follow; if I get it correctly wakeupwaiting calls hostap_newstate in your case; that updates INIT->RUN, calls ieee80211_create_ibss() which in turn ends up in ieee80211_sta_join1() which then triggers the deferred callback for the AP vap where we only see RUN->RUN (and funnily enough calls back into hostap_newstate again which only hits the debug printf.

Apr 14 2022, 10:19 PM
bz committed R10:94b9567f7568: LinuxKPI: add ALIGN_DOWN() (authored by bz).
LinuxKPI: add ALIGN_DOWN()
Apr 14 2022, 6:03 PM
bz committed R10:797188ba9a16: LinuxKPI: 802.11: add ieee80211_beacon_get_tim(), ieee80211_sn_sub() (authored by bz).
LinuxKPI: 802.11: add ieee80211_beacon_get_tim(), ieee80211_sn_sub()
Apr 14 2022, 6:03 PM
bz committed R10:fcc5031c9c51: LinuxKPI: 802.11: further fix RSSI calculations (authored by bz).
LinuxKPI: 802.11: further fix RSSI calculations
Apr 14 2022, 6:03 PM
bz committed R10:48e84cceac14: LinuxKPI: skbuff: handle dev_alloc_skb() correctly (authored by bz).
LinuxKPI: skbuff: handle dev_alloc_skb() correctly
Apr 14 2022, 6:02 PM
bz committed R10:46d08fd085dc: LinuxKPI: PCI: add counter for linux_dma_map_phys_common() errors (authored by bz).
LinuxKPI: PCI: add counter for linux_dma_map_phys_common() errors
Apr 14 2022, 6:02 PM
bz added inline comments to D28280: bhyve: set lpc IDs to physical values.
Apr 14 2022, 4:10 PM · bhyve

Apr 12 2022

bz requested review of D34893: net80211: remove (optional) RSN from preobereq.
Apr 12 2022, 10:05 PM

Apr 11 2022

bz added a comment to D34845: IPv4 multicast: fix LOR in shutdown path.

I trust you to get this right.

Apr 11 2022, 7:37 PM
bz accepted D34845: IPv4 multicast: fix LOR in shutdown path.
Apr 11 2022, 6:58 PM
bz added a comment to D34845: IPv4 multicast: fix LOR in shutdown path.

I understand the tiny race; I am pondering if it might be worth mentioning it in the comment?

Apr 11 2022, 1:45 PM

Apr 8 2022

bz committed R10:978f25e840fe: LinuxKPI: 802.11: add ieee80211_beacon_get_tim(), ieee80211_sn_sub() (authored by bz).
LinuxKPI: 802.11: add ieee80211_beacon_get_tim(), ieee80211_sn_sub()
Apr 8 2022, 9:06 PM
bz committed R10:97f2e93a66a8: LinuxKPI: add ALIGN_DOWN() (authored by bz).
LinuxKPI: add ALIGN_DOWN()
Apr 8 2022, 6:30 PM
bz closed D34844: LinuxKPI: add ALIGN_DOWN().
Apr 8 2022, 6:29 PM
bz updated the diff for D34844: LinuxKPI: add ALIGN_DOWN().

Rmeove extra () ().

Apr 8 2022, 4:16 PM
bz requested review of D34844: LinuxKPI: add ALIGN_DOWN().
Apr 8 2022, 3:32 PM
bz committed R10:3443476ca9e7: rtw88: downgrade rtw8822c firmware to 9.9.10 (authored by bz).
rtw88: downgrade rtw8822c firmware to 9.9.10
Apr 8 2022, 11:17 AM
bz committed R10:170acccf1e19: LinuxKPI: 802.11: further fix RSSI calculations (authored by bz).
LinuxKPI: 802.11: further fix RSSI calculations
Apr 8 2022, 11:16 AM

Apr 7 2022

bz accepted D34832: net: Fix memory leaks in lltable_calc_llheader() error paths.
Apr 7 2022, 9:00 PM
bz accepted D34831: net: Fix LLE lock leaks.
Apr 7 2022, 8:58 PM
bz committed R10:9df5f29caf1a: LinuxKPI: skbuff: handle dev_alloc_skb() correctly (authored by bz).
LinuxKPI: skbuff: handle dev_alloc_skb() correctly
Apr 7 2022, 8:57 PM
bz committed R10:7354782698f1: net80211: improve error handling from ieee80211_parse_beacon() (authored by bz).
net80211: improve error handling from ieee80211_parse_beacon()
Apr 7 2022, 8:56 PM

Apr 5 2022

bz committed R10:871bfac8b260: LinuxKPI: 802.11: fix RSSI (and NF) (authored by bz).
LinuxKPI: 802.11: fix RSSI (and NF)
Apr 5 2022, 7:13 PM
bz committed R10:a7352cbd4d67: net80211: correct types for nf and rssi (authored by bz).
net80211: correct types for nf and rssi
Apr 5 2022, 7:13 PM
bz committed R10:681b6a95f728: LinuxKPI: 802.11: fix compat code for i386 (authored by bz).
LinuxKPI: 802.11: fix compat code for i386
Apr 5 2022, 7:12 PM
bz committed R10:7b9d8e33bc4e: LinuxKPI: 802.11: fix RSSI (and NF) (authored by bz).
LinuxKPI: 802.11: fix RSSI (and NF)
Apr 5 2022, 3:41 PM
bz committed R10:7311128e69b8: net80211: correct types for nf and rssi (authored by bz).
net80211: correct types for nf and rssi
Apr 5 2022, 3:40 PM
bz committed R10:2a8e509ba30c: LinuxKPI: 802.11: fix compat code for i386 (authored by bz).
LinuxKPI: 802.11: fix compat code for i386
Apr 5 2022, 3:40 PM

Apr 4 2022

bz added a comment to D34754: linuxkpi: Restore the KBI for struct pci_driver.

Ignoring all the other things going on now .. do you plan to commit this w/ or w/o the spares to stable/13 within the next 24 hours?

Apr 4 2022, 7:25 PM
bz accepted D34763: Fix a coherent bus check in the arm64 busdma.
Apr 4 2022, 1:08 PM

Apr 3 2022

bz committed R10:e86707418c8e: LinuxKPI: PCI: add counter for linux_dma_map_phys_common() errors (authored by bz).
LinuxKPI: PCI: add counter for linux_dma_map_phys_common() errors
Apr 3 2022, 11:07 PM
bz closed D34715: LinuxKPI: PCI: add counter for linux_dma_map_phys_common() errors.
Apr 3 2022, 11:07 PM
bz accepted D34754: linuxkpi: Restore the KBI for struct pci_driver.
Apr 3 2022, 6:26 PM
bz added a comment to D34754: linuxkpi: Restore the KBI for struct pci_driver.

I can confirm that an amd64 releng/13.1 kernel with this does load the i915kms and drm and I get the drmn0 line as well after a short flicker on the screen; I have no X on external USB drive to further test it but the "silent error" seems gone.

Apr 3 2022, 4:36 PM
bz added a comment to D34754: linuxkpi: Restore the KBI for struct pci_driver.
In D34754#787676, @imp wrote:
Apr 3 2022, 4:10 PM
bz added a comment to D34754: linuxkpi: Restore the KBI for struct pci_driver.
In D34754#787677, @imp wrote:

I'm happy to put, btw, spares in other structures as well, but I'm not familiar enough with the code to know good candidates. I can also to the Static_assert for those as well... Got any suggestions?

Apr 3 2022, 4:04 PM

Apr 2 2022

bz updated subscribers of D34754: linuxkpi: Restore the KBI for struct pci_driver.

Add x11 to subscribers so they know how things proceed.

Apr 2 2022, 9:55 PM
bz abandoned D33915: LinuxKPI: allow a driver to override the default pci probe result.

Closing again in favour of @imp's D34754 .

Apr 2 2022, 9:44 PM
bz added a comment to D34754: linuxkpi: Restore the KBI for struct pci_driver.

Can this be two independent changes please?

Apr 2 2022, 9:41 PM
bz added a comment to D33915: LinuxKPI: allow a driver to override the default pci probe result.
In D33915#787591, @imp wrote:

...

Apr 2 2022, 6:22 PM
bz added a comment to D33915: LinuxKPI: allow a driver to override the default pci probe result.
In D33915#787592, @imp wrote:

I know my diff isn't great for stable/13, but for the release it likely suffices until we can fix the KBI in stable/13 and may be less risk for the release than a bigger fix.

Apr 2 2022, 6:19 PM
bz reopened D33915: LinuxKPI: allow a driver to override the default pci probe result.

So after MFCing this drm-kmod binary packages on FreeBSD stable/13 and 13.1-RC1 broke; as per MFC rules I appended the field to the end of the struct. https://cgit.freebsd.org/src/commit/?h=releng/13.1&id=c325d9edeff568d3d38891b2916bd5bd0e9bf8e3 However probe will not run if there is something there which is > 0 and we'll treat it as a probe error.

Apr 2 2022, 5:19 PM

Apr 1 2022

bz added inline comments to D34715: LinuxKPI: PCI: add counter for linux_dma_map_phys_common() errors.
Apr 1 2022, 11:05 PM
bz committed R10:60970a328e28: LinuxKPI: 802.11: fix RSSI (and NF) (authored by bz).
LinuxKPI: 802.11: fix RSSI (and NF)
Apr 1 2022, 10:42 PM
bz committed R10:4a22cd6c4e5f: net80211: correct types for nf and rssi (authored by bz).
net80211: correct types for nf and rssi
Apr 1 2022, 10:41 PM
bz committed R10:20eeed6844e2: rtw88: add man pages and hook up to build (authored by bz).
rtw88: add man pages and hook up to build
Apr 1 2022, 12:33 AM
bz committed R10:73d4ebea3567: rtw88: import firmware for Realtek's rtw88 supported chipsets. (authored by bz).
rtw88: import firmware for Realtek's rtw88 supported chipsets.
Apr 1 2022, 12:33 AM
bz committed R10:2774f206809b: rtw88: import Realtek's rtw88 driver (authored by bz).
rtw88: import Realtek's rtw88 driver
Apr 1 2022, 12:33 AM

Mar 31 2022

bz added a comment to D34715: LinuxKPI: PCI: add counter for linux_dma_map_phys_common() errors.

Okay, tested on my arm64 with 64G of main memory loading if_rtw88:
compat.linuxkpi.lkpi_pci_nseg1_fail: 2

Mar 31 2022, 6:11 PM
bz committed R10:86220d3cbd50: LinuxKPI: 802.11: fix compat code for i386 (authored by bz).
LinuxKPI: 802.11: fix compat code for i386
Mar 31 2022, 5:36 PM

Mar 30 2022

bz updated the diff for D34715: LinuxKPI: PCI: add counter for linux_dma_map_phys_common() errors.

Add the ability under compat.linuxkpi.debug to also dump the stack in case
of a single-segment mapping error to see the originating driver part
as suggested by @hselasky.

Mar 30 2022, 7:17 PM
bz committed R10:331335c1b846: Fix kernel build without INET or INET6 (authored by emaste).
Fix kernel build without INET or INET6
Mar 30 2022, 7:08 PM
bz added a comment to D34715: LinuxKPI: PCI: add counter for linux_dma_map_phys_common() errors.

Why not print the stack backtrace when debug.linuxkpi.debug is set?

Mar 30 2022, 6:28 PM
bz committed R10:85f3c0a1c376: Fix kernel build without INET6 (authored by emaste).
Fix kernel build without INET6
Mar 30 2022, 5:52 PM
bz committed R10:1c487a5d3dac: Fix kernel build without INET and INET6 (authored by emaste).
Fix kernel build without INET and INET6
Mar 30 2022, 5:52 PM
bz requested review of D34715: LinuxKPI: PCI: add counter for linux_dma_map_phys_common() errors.
Mar 30 2022, 5:46 PM
bz committed R10:ecb691143d2e: LinuxKPI: 802.11: various updates for iwlwifi stability and upcoming rtw (authored by bz).
LinuxKPI: 802.11: various updates for iwlwifi stability and upcoming rtw
Mar 30 2022, 3:50 PM
bz committed R10:63ec5947474a: LinuxKPI: allow bsddriver name to be set for PCI (authored by bz).
LinuxKPI: allow bsddriver name to be set for PCI
Mar 30 2022, 3:50 PM
bz committed R10:fef73ef9c2e0: LinuxKPI: skbuff: fix skb_queue_splice_init() (authored by bz).
LinuxKPI: skbuff: fix skb_queue_splice_init()
Mar 30 2022, 3:50 PM