Page MenuHomeFreeBSD

bz (Bjoern A. Zeeb)
User

Projects (9)

User Details

User Since
Aug 29 2014, 12:11 PM (321 w, 3 d)

Recent Activity

Tue, Oct 20

bz added inline comments to D26735: Improve loading of multipage aligned buffers..
Tue, Oct 20, 6:29 AM

Mon, Oct 19

bz requested review of D26874: mmc: pwrseq add a "simple" implementation.
Mon, Oct 19, 9:51 PM
bz requested review of D26872: mmc: implement mmc-pwrseq.
Mon, Oct 19, 9:37 PM
bz requested review of D26870: arm64: rockchip, implement the two rk808 clocks.
Mon, Oct 19, 8:55 PM
bz added a comment to D26334: cxgbe: Apply more checks for INET and INET6.
In D26334#598980, @np wrote:

okay, I'll take care of this.

Mon, Oct 19, 7:54 PM
bz added a comment to D26334: cxgbe: Apply more checks for INET and INET6.

It seems by now there is also needs_inner_tcp_csum() ?
Can you possibly incorporate this in your next driver update and do it yourself @np ?

Mon, Oct 19, 6:30 PM

Sun, Oct 18

bz removed a reviewer for D26847: Add driver for RK3399 non-secure efuse.: bz.
Sun, Oct 18, 11:22 PM
bz closed D26541: net80211: factor out the priv(9) checks into OS specifc code..
Sun, Oct 18, 9:34 PM
bz committed rS366817: net80211: factor out the priv(9) checks into OS specifc code..
net80211: factor out the priv(9) checks into OS specifc code.
Sun, Oct 18, 9:34 PM
bz added inline comments to D26541: net80211: factor out the priv(9) checks into OS specifc code..
Sun, Oct 18, 5:29 PM
bz closed D26712: net80211: update for (more) VHT160 support.
Sun, Oct 18, 12:27 AM
bz committed rS366800: net80211: update for (more) VHT160 support.
net80211: update for (more) VHT160 support
Sun, Oct 18, 12:27 AM

Sat, Oct 17

bz committed rS366799: clk: fix indentation.
clk: fix indentation
Sat, Oct 17, 11:43 PM
bz committed rS366798: ddb: add show sysinit command.
ddb: add show sysinit command
Sat, Oct 17, 10:47 PM

Fri, Oct 16

bz updated subscribers of D26712: net80211: update for (more) VHT160 support.

Anyone interested in reviewing this? I'd love to get it in no later than Monday.

Fri, Oct 16, 6:47 PM

Wed, Oct 14

bz added a comment to D26782: Allow PING(8) in jails without raw socket access permissions.

I have a couple of comments for this:
(a) ICMP access is not just echo requests; this will alllow jails to send other things out which might not be a great idea, so if you do, default off.
(b) I'd love to have an ICMPv6 equivalent; ICMPv6 is even worse as to what people can do; see (a)
(c) I don't think this is a good idea.
(d) Even with this there'll be other issues (as are with raw sockets), such as source address selection, which was once was discussed in 2011 [ https://people.freebsd.org/~bz/20120407-01-ping-source-addr.diff ]; probably on freebsd-net or -jails back then.
(e) lastly we do have full network stacks these days, and even if they are not always needed the tradeoff to adding more hacks on top of classic IP-jails is questionable.

Wed, Oct 14, 11:16 PM
bz added inline comments to D26755: Add hash table lookup for IPv6 raw sockets..
Wed, Oct 14, 7:43 PM

Tue, Oct 13

bz accepted D26578: nd6: Count packets dropped due to an invalid hop limit.
Tue, Oct 13, 8:27 PM

Sun, Oct 11

bz accepted D26728: linuxkpi: Move timer related functions in its own file..

I haven't tried it but scrolling through it looks ok to me.

Sun, Oct 11, 8:19 PM
bz committed rS366623: ip_mroute: fix the viftable export sysctl.
ip_mroute: fix the viftable export sysctl
Sun, Oct 11, 12:01 AM

Sat, Oct 10

bz added a comment to D26727: linuxkpi: Move kobject related function in its own file.
In D26727#595888, @manu wrote:
In D26727#595874, @bz wrote:

Can you quickly elaborate what "drmkpi" is? Is that what we know as drm.ko? If that's it then is the reason that you basically have a freebsd module implementation there and just an internal glue to the linux device?

See D23085 (Or https://github.com/evadot/freebsd/tree/drm_base_v5.6-20201007 for a more up to date version).

Sat, Oct 10, 9:14 AM
bz added a comment to D26727: linuxkpi: Move kobject related function in its own file.

Can you quickly elaborate what "drmkpi" is? Is that what we know as drm.ko? If that's it then is the reason that you basically have a freebsd module implementation there and just an internal glue to the linux device?

Sat, Oct 10, 12:45 AM

Thu, Oct 8

bz added inline comments to D26598: linuxkpi: upstream drm-kmod conflicting changes.
Thu, Oct 8, 9:45 PM

Wed, Oct 7

bz updated the diff for D26712: net80211: update for (more) VHT160 support.
  • Update comment about ieee80211_add_channel_cbw() now supporting HT40/VHT80/..
Wed, Oct 7, 11:21 PM
bz updated the diff for D26712: net80211: update for (more) VHT160 support.
  • Remove debug printfs from here as well.
  • Remove the whitespace from regdomain.
Wed, Oct 7, 11:10 PM
bz committed rS366525: net80211: whitespace.
net80211: whitespace
Wed, Oct 7, 10:52 PM
bz added inline comments to D26712: net80211: update for (more) VHT160 support.
Wed, Oct 7, 10:48 PM
bz requested review of D26712: net80211: update for (more) VHT160 support.
Wed, Oct 7, 10:44 PM
bz committed rS366524: 80211: ifconfig replace MS() with _IEEE80211_MASKSHIFT().
80211: ifconfig replace MS() with _IEEE80211_MASKSHIFT()
Wed, Oct 7, 10:29 PM
bz closed D26708: LinuxKPI: A bitfield.h implementation..
Wed, Oct 7, 10:07 PM
bz committed rS366523: LinuxKPI: add a bitfield.h implementation..
LinuxKPI: add a bitfield.h implementation.
Wed, Oct 7, 10:07 PM
bz committed rS366522: 80211: non-functional changes.
80211: non-functional changes
Wed, Oct 7, 9:57 PM
bz added a comment to D26708: LinuxKPI: A bitfield.h implementation..

manu, if you are okay with it, either commit it yourself or let me know when so that you can deal with the drm-kmod bits as well

Wed, Oct 7, 9:05 PM
bz updated the diff for D26708: LinuxKPI: A bitfield.h implementation..
  • Rename f_mul to ___lsb as suggested by hselasky.
Wed, Oct 7, 8:43 PM
bz added inline comments to D26708: LinuxKPI: A bitfield.h implementation..
Wed, Oct 7, 6:42 PM
bz added a comment to D26681: linuxkpi: Add bitfield.h.
In D26681#594681, @manu wrote:
Wed, Oct 7, 6:09 PM
bz added inline comments to D26708: LinuxKPI: A bitfield.h implementation..
Wed, Oct 7, 6:07 PM
bz set the repository for D26708: LinuxKPI: A bitfield.h implementation. to rS FreeBSD src repository.
Wed, Oct 7, 6:06 PM
bz requested review of D26708: LinuxKPI: A bitfield.h implementation..
Wed, Oct 7, 6:05 PM

Tue, Oct 6

bz added inline comments to D26578: nd6: Count packets dropped due to an invalid hop limit.
Tue, Oct 6, 10:43 PM

Mon, Oct 5

bz added inline comments to D26675: linuxkpi: Add hash.h.
Mon, Oct 5, 10:19 PM
bz accepted D26676: linuxkpi: Add numa.h: Only contain NUMA_NO_NODE needed by drm.
Mon, Oct 5, 10:15 PM
bz accepted D26677: linuxkpi: Add prefetch.h.
Mon, Oct 5, 10:10 PM
bz accepted D26678: linuxkpi: Add trylock_page and unlock_page.
Mon, Oct 5, 10:08 PM
bz accepted D26679: linuxkpi: Add power_supply.h.

Apart from the line break it's fine. No need for a new version; can commit with the change if you want.

Mon, Oct 5, 10:06 PM
bz accepted D26680: linuxkpi: Add pagemap.h.
Mon, Oct 5, 9:59 PM
bz added a comment to D26681: linuxkpi: Add bitfield.h.

Can I ask you to drop this one?

Mon, Oct 5, 9:51 PM
bz accepted D26674: linuxkpi: Add gcd function.
Mon, Oct 5, 9:17 PM
bz updated subscribers of D26651: linuxkpi: MODULE_DEVICE_TABLE to MODULE_PNP_INFO.
Mon, Oct 5, 5:49 PM

Sun, Oct 4

bz accepted D26657: linuxkpi: populate the acquire context field of a ww_mutex.

Looks okay to me as well. The two minor things may be ignored.

Sun, Oct 4, 2:41 PM · linuxkpi
bz updated the diff for D26651: linuxkpi: MODULE_DEVICE_TABLE to MODULE_PNP_INFO.

Use DEVMETHOD_END.
Include subvendor/subdevice as V32 to deal with the -1 wildcard.
Add the bus name to the name filed in the driver_t.

Sun, Oct 4, 2:36 PM

Sat, Oct 3

bz added a comment to D26651: linuxkpi: MODULE_DEVICE_TABLE to MODULE_PNP_INFO.

I'd still love to update this so that we can have the full set but I need to find the bug first that prevents this (with the comments) from working. You can still see how this turns out (just with less columns):

Sat, Oct 3, 6:14 PM
bz requested review of D26651: linuxkpi: MODULE_DEVICE_TABLE to MODULE_PNP_INFO.
Sat, Oct 3, 6:12 PM

Fri, Oct 2

bz added inline comments to D26598: linuxkpi: upstream drm-kmod conflicting changes.
Fri, Oct 2, 7:15 PM

Thu, Oct 1

bz added inline comments to D26598: linuxkpi: upstream drm-kmod conflicting changes.
Thu, Oct 1, 2:47 PM
bz added inline comments to D26598: linuxkpi: upstream drm-kmod conflicting changes.
Thu, Oct 1, 2:01 PM
bz added a member for linuxkpi: bz.
Thu, Oct 1, 1:58 PM
bz updated the diff for D26598: linuxkpi: upstream drm-kmod conflicting changes.

Address comments from kib mostly.

Thu, Oct 1, 1:38 PM
bz added a comment to D26598: linuxkpi: upstream drm-kmod conflicting changes.

I'll wait to see what @manu or others in case of kobject_uevent_env() say and then upload the final diff. Interim version coming in a minute.

Thu, Oct 1, 1:36 PM

Tue, Sep 29

bz abandoned D26277: linuxkpi: firmware.

Abandon in favour of D26598

Tue, Sep 29, 10:37 PM
bz requested review of D26598: linuxkpi: upstream drm-kmod conflicting changes.
Tue, Sep 29, 10:20 PM
bz committed rS366268: rtwn: narrow the epoch area.
rtwn: narrow the epoch area
Tue, Sep 29, 8:46 PM
bz closed D26554: rtwn: narrow the epoch area.
Tue, Sep 29, 8:46 PM

Mon, Sep 28

bz added a reviewer for D26578: nd6: Count packets dropped due to an invalid hop limit: hrs.

While I agree on the counter I am not yet sure I entirely want to lose all these messages.
Some are helpful in that they tell us things. If you are on multiple network as most of my devices are it can become a pain otherwise to retroactively debug.
Given none of them are logged by default (nd6_debug = 0 unless -DND6_DEBUG is used at compile time and nd6.h:#define nd6log(x) do { if (V_nd6_debug) log x; } while (/*CONSTCOND*/ 0) ) can we not just do both?

Mon, Sep 28, 5:43 PM

Sun, Sep 27

bz updated the summary of D26554: rtwn: narrow the epoch area.
Sun, Sep 27, 11:59 AM

Sat, Sep 26

bz updated the summary of D26554: rtwn: narrow the epoch area.
Sat, Sep 26, 7:00 PM
bz updated the diff for D26554: rtwn: narrow the epoch area.

Rework as suggested by adrian.

Sat, Sep 26, 6:58 PM

Sep 25 2020

bz accepted D26548: ng_l2tp: Fix callout synchronization in the RACK timeout handler.
Sep 25 2020, 6:26 PM
bz added a reviewer for D26541: net80211: factor out the priv(9) checks into OS specifc code.: martin_NetBSD.org.
Sep 25 2020, 5:01 PM
bz added a comment to D26554: rtwn: narrow the epoch area.

I'm not a huge fan of this cause honestly we should be doing the epoch enter/exit around a batch.

What I was hoping to do was to create a list of frames from calls to rtwn_rx_frame and then push them up to the stack in a second pass under (a) no lock, avoiding the relock, and (b) being done in NET_EPOCH.

Wanna do that or should I?

Sep 25 2020, 4:54 PM
bz requested review of D26554: rtwn: narrow the epoch area.
Sep 25 2020, 10:36 AM

Sep 24 2020

bz requested changes to D26548: ng_l2tp: Fix callout synchronization in the RACK timeout handler.
Sep 24 2020, 9:59 PM
bz requested review of D26545: net80211: split up ieee80211_probereq().
Sep 24 2020, 12:49 PM
bz accepted D26537: devfs.rules: unhide pf in vnet jails.

We'll probably want to add more of these in the future for vnets, so happy we start to lay the grounds.
Will you work on jail/jail.conf to also pick the right set for devfs depending on whether the vnet option is given? If not you should given @jamie a ping6.

Sep 24 2020, 11:42 AM
bz added a comment to D26537: devfs.rules: unhide pf in vnet jails.
In D26537#591051, @kp wrote:
In D26537#590825, @bz wrote:

Did we ever fix this one?

https://www.openbsd.org/errata48.html
005: SECURITY FIX: December 17, 2010 All architectures
Insufficent initialization of the pf rule structure in the ioctl handler may allow userland to modify kernel memory. By default root privileges are needed to add or modify pf rules.

https://ftp.openbsd.org/pub/OpenBSD/patches/4.8/common/005_pf.patch

I believe you did: https://svnweb.freebsd.org/base?view=revision&revision=302117

Sep 24 2020, 11:40 AM
bz closed D26539: Provide MS() and SM() macros for 80211..

This landed by accident in head as https://svnweb.freebsd.org/changeset/base/366112 (not sure why the review wasn't automatically closed either).

Sep 24 2020, 11:02 AM
bz added a comment to D26539: Provide MS() and SM() macros for 80211..

Arg. Sorry, used the wrong alias and pushed the change into head instead of here. Please do a post-commit review in head then.

Sep 24 2020, 10:59 AM
bz committed rS366112: Provide MS() and SM() macros for 80211 and wireless drivers..
Provide MS() and SM() macros for 80211 and wireless drivers.
Sep 24 2020, 10:58 AM

Sep 23 2020

bz added a comment to D26539: Provide MS() and SM() macros for 80211..

I am mostly interested if the names are okay. I did not want to use _IEEE80211_MS() as that might be confused with some time operation MS_TO_xxx. If the names are okay, I'll wrap the lines and upload a new version for actual review.

Sep 23 2020, 10:09 PM
bz set the repository for D26541: net80211: factor out the priv(9) checks into OS specifc code. to rS FreeBSD src repository.
Sep 23 2020, 10:07 PM
bz updated the summary of D26539: Provide MS() and SM() macros for 80211..
Sep 23 2020, 10:07 PM
bz requested review of D26541: net80211: factor out the priv(9) checks into OS specifc code..
Sep 23 2020, 10:06 PM
bz requested review of D26539: Provide MS() and SM() macros for 80211..
Sep 23 2020, 10:02 PM
bz added a comment to D26537: devfs.rules: unhide pf in vnet jails.

Did we ever fix this one?

Sep 23 2020, 8:38 PM

Sep 12 2020

bz committed rS365673: MFS r365630 (markj, bz).
MFS r365630 (markj, bz)
Sep 12 2020, 9:50 PM
bz committed rS365670: MFS r365608:.
MFS r365608:
Sep 12 2020, 7:34 PM

Sep 11 2020

bz committed rS365633: iwm: fix regression from r365419 (ieee80211_media_change()).
iwm: fix regression from r365419 (ieee80211_media_change())
Sep 11 2020, 2:18 PM
bz committed rS365630: MFC r342788,354926,364771 (markj, bz).
MFC r342788,354926,364771 (markj, bz)
Sep 11 2020, 12:36 PM

Sep 10 2020

bz committed rD54474: Document __FreeBSD_version 1201526 after merging net80211 incl priv(9).
Document __FreeBSD_version 1201526 after merging net80211 incl priv(9)
Sep 10 2020, 9:40 PM
bz committed rS365608: MFC r344749-344750,344841-344843,345284,346405,346470,347140-347141,348331,.
MFC r344749-344750,344841-344843,345284,346405,346470,347140-347141,348331,
Sep 10 2020, 7:01 PM

Sep 7 2020

bz added reviewers for D26344: bcm2838_pci.c: Respect DMA limits of controller.: ARM, arm64.
Sep 7 2020, 4:35 PM
bz committed rS365419: WiFi: fix ieee80211_media_change() callers.
WiFi: fix ieee80211_media_change() callers
Sep 7 2020, 3:36 PM
bz committed rS365416: MFC r364466:.
MFC r364466:
Sep 7 2020, 2:22 PM

Sep 5 2020

bz closed D26331: bbr: remove unused static function.
Sep 5 2020, 12:20 AM
bz committed rS365350: bbr: remove unused static function.
bbr: remove unused static function
Sep 5 2020, 12:20 AM
bz committed rS365349: uipc_ktls: remove unused static function.
uipc_ktls: remove unused static function
Sep 5 2020, 12:20 AM
bz closed D26330: uipc_ktls: remove unused static function.
Sep 5 2020, 12:20 AM
bz requested review of D26334: cxgbe: Apply more checks for INET and INET6.
Sep 5 2020, 12:18 AM

Sep 4 2020

bz requested review of D26331: bbr: remove unused static function.
Sep 4 2020, 6:35 PM
bz requested review of D26330: uipc_ktls: remove unused static function.
Sep 4 2020, 6:32 PM