- User Since
- Aug 29 2014, 12:11 PM (456 w, 5 d)
Sat, May 27
Can you please add details (a proposed commit message) as that might shed light onto why you may think this is needed/useful?
Jailed sockets with a wildcard local address should have lower priority than non-jailed sockets with a wildcard local address.
Wed, May 24
Make function argument const as suggested by @emaste
Tue, May 23
Sun, May 21
Sat, May 20
Update types as suggested by @emaste
Thu, May 18
From a quick glance looks good to me
Wed, May 17
Hooray!!!!! THANK YOU! I'll give it a try the next days.
Tue, May 16
Change function argument names to floor/ceil as suggested by @emaste.
Sat, May 13
Fri, May 12
Fix dedup as reported by @bapt.
Thanks to you two!
Can you "Approve" this change as well given I am not a ports committer?
Move RUN_DEPENDS before USES
Thu, May 11
Here's an example of how this could look (sorts out a duplicate, applies two fixups based on previous reviews)
I am really not too keen on adding the "pci_fixup_class" bit but the alternative is splattering semi-empty files including another file for silly silicon.
This also remains one of the concerns I raised on the original review. It feels like something needs to change to avoid adding hacks early on...
Tue, May 9
Great. I am doing a rebuild now.
Mon, May 8
Fri, May 5
And if @mhorne is okay as well, feel free to commit.
Approved by: bz (mentor)
All the changes I pointed out seem of more cosmetic nature. I'll leave it up to you if you want to do them.
Apr 29 2023
Can we do "bus"_"class"_"drivername" at least then -- though that doesn't work on the search parts so easily as you have to iterate over all the matching bus_class_* files.
That's what's done here no ?
Apr 28 2023
I understand the idea. There's several drawback here for wifi: