Page MenuHomeFreeBSD

bz (Bjoern A. Zeeb)
User

Projects (8)

User Details

User Since
Aug 29 2014, 12:11 PM (498 w, 3 d)

Recent Activity

Fri, Mar 15

bz added inline comments to D44306: linuxkpi: Provide a non-NULL value for THIS_MODULE.
Fri, Mar 15, 7:14 PM

Tue, Mar 12

bz closed D44208: LinuxKPI: 802.11: return proper value for IEEE80211_CRYPTO_AES_CCM.
Tue, Mar 12, 11:01 PM
bz committed rG906521f8176b: LinuxKPI: 802.11: return proper value for IEEE80211_CRYPTO_AES_CCM (authored by bz).
LinuxKPI: 802.11: return proper value for IEEE80211_CRYPTO_AES_CCM
Tue, Mar 12, 11:01 PM
bz committed rGf254aad33dfb: ath_hal/ar9300: allow JUPITER cards to read eeprom (authored by bz).
ath_hal/ar9300: allow JUPITER cards to read eeprom
Tue, Mar 12, 9:59 PM
bz closed D44328: ath_hal/ar9300: allow JUPITER cards to read eeprom.
Tue, Mar 12, 9:59 PM
bz added a comment to D44328: ath_hal/ar9300: allow JUPITER cards to read eeprom.

oh, you have a jupiter card with eeprom, rather than just OTP? ooer. Good catch! I likely only have OTP AR9462s :(

Tue, Mar 12, 9:56 PM
bz requested review of D44332: pca963x: add support for the PCA9633 4-bit Fm+ I2C-bus LED driver.
Tue, Mar 12, 9:42 PM
bz requested review of D44328: ath_hal/ar9300: allow JUPITER cards to read eeprom.
Tue, Mar 12, 9:23 PM
bz added inline comments to D44310: inpcb: remove unused KPIs to manipulate inpcbs.
Tue, Mar 12, 3:37 PM
bz added a comment to D44219: ipsec_accel: kernel infrastructure.
In D44219#1008810, @kib wrote:
Tue, Mar 12, 9:18 AM
bz accepted D44310: inpcb: remove unused KPIs to manipulate inpcbs.

Otherwise looks good to me.

Tue, Mar 12, 9:16 AM
bz added inline comments to D44310: inpcb: remove unused KPIs to manipulate inpcbs.
Tue, Mar 12, 9:16 AM
bz added inline comments to D44306: linuxkpi: Provide a non-NULL value for THIS_MODULE.
Tue, Mar 12, 9:13 AM
bz added a reviewer for D44306: linuxkpi: Provide a non-NULL value for THIS_MODULE: linuxkpi.
Tue, Mar 12, 9:09 AM

Wed, Mar 6

bz requested changes to D44260: LinuxKPI: LKPI_80211_HW_CRYPTO: add crypto debug flag in LinuxKPI.
Wed, Mar 6, 10:56 PM
bz added inline comments to D43648: LinuxKPI: 802.11: hardware crypto offload improvements.
Wed, Mar 6, 7:56 PM
bz added a comment to D44020: Splitting the existing Vybrid I2C Controller Driver to Add ACPI Support.
In D44020#1009469, @bz wrote:

This may not be based on your latest version but the general idea is: call i2c_update_div_val() before taking the lock, get the div_reg value back (maybe you can avoid passing it as pointer and checking for error by simply checking for sc->freq == UINT32_MAX in the caller (reset function) afterwards to see if you should change anything or not (just came to my mind, haven't checked all code paths). Then do the register writes all together under lock.

My assumption here is that it is the reset function is not called twice at the same time in parallel from the bus.

What you describe is what I do in the latest version, but it does not work, since without the lock, i2c_get_div_val gets executed before the attach function has the chance to set the variables that are used by i2c_get_div_val. So I need to delay the call to i2c_get_div_val until the attach function completes. Without that I end up with the wrong divider value. Note that this problem seems to only occur at boot time and not if I load the driver as a module after booting.

Wed, Mar 6, 7:34 PM · arm64, ARM
bz added a comment to D44020: Splitting the existing Vybrid I2C Controller Driver to Add ACPI Support.

This may not be based on your latest version but the general idea is: call i2c_update_div_val() before taking the lock, get the div_reg value back (maybe you can avoid passing it as pointer and checking for error by simply checking for sc->freq == UINT32_MAX in the caller (reset function) afterwards to see if you should change anything or not (just came to my mind, haven't checked all code paths). Then do the register writes all together under lock.

Wed, Mar 6, 7:14 PM · arm64, ARM
bz added a comment to D44020: Splitting the existing Vybrid I2C Controller Driver to Add ACPI Support.

Ok I think I know how this could be fixed. I should create a sc->initialized_freq flag which is set by the attach function once sc->freq has been set. The reset function should check the status of this flag after locking sc->mutex, and if it is not the case, it should cv_wait for a condition from attach. The attach function should cv_signal this condition after setting the flag. Does it look like the best strategy to you?

Wed, Mar 6, 7:05 PM · arm64, ARM

Tue, Mar 5

bz added a comment to D44020: Splitting the existing Vybrid I2C Controller Driver to Add ACPI Support.

We'll need to adjust that slightly in a different direction ...
@manu can you lend a hand? Probably a lot easier for you than for me.

Tue, Mar 5, 10:36 PM · arm64, ARM
bz requested changes to D44021: Revamping the existing Vybrid I2C Controller Driver to Include Support for the QorIQ LX2160A Controller.
Tue, Mar 5, 6:49 PM · arm64, ARM

Mon, Mar 4

bz requested review of D44208: LinuxKPI: 802.11: return proper value for IEEE80211_CRYPTO_AES_CCM.
Mon, Mar 4, 11:08 PM
bz added a comment to D43634: net80211: crypto: fix check for driver having done decryption.

Aha i remember now. Ok, so.

ath10k does HW decrypt AND strips the MIC/IV on successful decrypts. So I wasn't seeing that ccmp_decrypt() path being called.

Checking for IEEE80211_RX_F_DECRYPTED too is likely fine.

Thing is, why's IEEE80211_KEY_SWDECRYPT set if the HW is doing decrypt? You shouldn't have that set if the HW is doing decrypt and you've programmed keys into the HW at this point?

Mon, Mar 4, 11:08 PM
bz accepted D44204: ip6_output: Reduce cache misses on pktopts.

Initially I thought we should name some better but the original structs have the same names so all good.
I have not checked if you got all the places but it looks good.

Mon, Mar 4, 10:49 PM

Sat, Mar 2

bz accepted D44192: linuxkpi: Queue skbuffs at tail in skb_queue_tail.

Great catch! I wonder what else that will help for the other (unconnected) drivers. Thanks!

Sat, Mar 2, 8:10 PM · linuxkpi
bz added a comment to D43994: iwm: lower probe priority.

Here's a second one showing the NONEXIST problem with older firmware https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=277432
I think it would be good to sort that before moving people from iwm to iwlwifi by default -- or at least being prepared to handle the fallout.

Sat, Mar 2, 10:54 AM

Thu, Feb 29

bz added a comment to D43634: net80211: crypto: fix check for driver having done decryption.

err, lemme double check this first. SWDECRYPT is not related to hardware encryption offload; it's an earlier thing where you could have RX STA keys in the hardware (to accelerate knowing which STA it belongs to) but it still passes it through untouched requiring one to do encrypt/decrypt in software.

For the ath NICs, the keycache served both as a encryption/decryption key cache and also as a way of marking known STAs in hardware for doing things like auto-ACK, block-ACK tracking, hardware antenna diversity in the older NICs, etc. It doesn't /have/ to contain encryption keys - that's why SWDECRYPT is a thing.

Is IEEE80211_KEY_SWDECRYPT being set somewhere in the linux kpi layer?

Thu, Feb 29, 8:37 PM

Tue, Feb 27

bz updated subscribers of D43994: iwm: lower probe priority.

Another thing (apart from man pages) we should probably make sure works out of the box is suspend/resume as that's the other missing bit (and ideally without workarounds). I need to go back and see if @hrs has some USB-DEBUG serial console code (I think he gave a presentation about it a while ago at Euro? but I lost track) and assume he doesn't have any time currently.

Tue, Feb 27, 9:53 PM
bz added a comment to D44020: Splitting the existing Vybrid I2C Controller Driver to Add ACPI Support.

Thank you for all the changes. I think we are getting pretty close to getting this in.

Tue, Feb 27, 6:27 PM · arm64, ARM

Mon, Feb 26

bz requested changes to D44020: Splitting the existing Vybrid I2C Controller Driver to Add ACPI Support.
Mon, Feb 26, 7:08 AM · arm64, ARM

Sat, Feb 24

bz added inline comments to D44020: Splitting the existing Vybrid I2C Controller Driver to Add ACPI Support.
Sat, Feb 24, 6:10 PM · arm64, ARM
bz added a comment to D44021: Revamping the existing Vybrid I2C Controller Driver to Include Support for the QorIQ LX2160A Controller.

WOW. Having looked at that logic probably a year ago this is good work; also good catches on the missing unlock and NOACK for the 1 byte!

Sat, Feb 24, 7:38 AM · arm64, ARM
bz added a comment to D44020: Splitting the existing Vybrid I2C Controller Driver to Add ACPI Support.

Sorry this looks a lot but is mostly just white space.

Sat, Feb 24, 7:25 AM · arm64, ARM

Thu, Feb 22

bz committed rG759a996d610d: LinuxKPI: 802.11: implement a deferred RX path (authored by bz).
LinuxKPI: 802.11: implement a deferred RX path
Thu, Feb 22, 10:50 PM
bz closed D43968: LinuxKPI: 802.11: implement a deferred RX path.
Thu, Feb 22, 10:49 PM
bz committed rG46a968ecfb57: dev/uart: name uart_class_set DATA_SET macro UART_CLASS() (authored by bz).
dev/uart: name uart_class_set DATA_SET macro UART_CLASS()
Thu, Feb 22, 10:45 PM
bz closed D43981: dev/uart: name uart_class_set DATA_SET macro UART_CLASS().
Thu, Feb 22, 10:45 PM
bz committed rG89c1e54a71cc: ath(4): always enable 11n (authored by bz).
ath(4): always enable 11n
Thu, Feb 22, 10:40 PM
bz closed D43964: ath(4): always enable 11n.
Thu, Feb 22, 10:39 PM

Wed, Feb 21

bz committed rGc81df1c11262: iicbus/mux/pca954x: add support for PCA9546 I2C Switch (authored by bz).
iicbus/mux/pca954x: add support for PCA9546 I2C Switch
Wed, Feb 21, 4:47 PM
bz closed D44009: iicbus/mux/pca954x: add support for PCA9546 I2C Switch.
Wed, Feb 21, 4:47 PM
bz added a comment to D44009: iicbus/mux/pca954x: add support for PCA9546 I2C Switch.

I just skimmed them:

Wed, Feb 21, 4:43 PM
bz added a comment to D43811: Revamping the existing Vybrid I2C Controller Driver to Include Support for the QorIQ LX2160A Controller.

One comment: I tested this on a LS1088 in FDT mode and it makes me super happy as I can scan bits (and flawlessly read) now I had problems with on another board (which I should test as well once I can again).

Wed, Feb 21, 4:14 PM · arm64, ARM
bz added a comment to D44009: iicbus/mux/pca954x: add support for PCA9546 I2C Switch.
In D44009#1004004, @imp wrote:

The change itself looks great.

There's other pca954x parts:

..

Seems like it would be easy to add them while you're in the neighborhood? Again, not a request, per se, but if you had a minute...

Wed, Feb 21, 3:43 PM
bz requested review of D44009: iicbus/mux/pca954x: add support for PCA9546 I2C Switch.
Wed, Feb 21, 9:16 AM

Tue, Feb 20

bz added a comment to D43994: iwm: lower probe priority.

I'm now running with this change on my daily driver, which has:

Feb 20 15:53:33 nazar kernel: iwlwifi0: Detected Intel(R) Wireless-AC 9560 160MHz, REV=0x312
Tue, Feb 20, 9:35 PM
bz added inline comments to D43811: Revamping the existing Vybrid I2C Controller Driver to Include Support for the QorIQ LX2160A Controller.
Tue, Feb 20, 9:29 PM · arm64, ARM
bz added a comment to D43746: Adding Support for QorIQ LX2160A I2C Controller.

Merging the code with the existing driver in D43811. This differential is now obsolete.

Tue, Feb 20, 9:28 PM · arm64, ARM
bz added inline comments to D43746: Adding Support for QorIQ LX2160A I2C Controller.
Tue, Feb 20, 9:18 PM · arm64, ARM
bz added a comment to D43994: iwm: lower probe priority.

Have you tested on a pre-22000 card 8xxx/9xxx recently?
I know we have to 2 PRs (well one now, two people) on those and given they use different interfaces within iwlwifi it's possible they do behave different.

Tue, Feb 20, 9:09 PM
bz added a comment to D43811: Revamping the existing Vybrid I2C Controller Driver to Include Support for the QorIQ LX2160A Controller.

Really looking forward to this. Also a step towards getting SFP+ support going..

Tue, Feb 20, 6:58 PM · arm64, ARM
bz added a comment to D37973: wtapctl(8): Introduce new tool for wtap(4).

I'll just pick the first review given they all live in a window here; last time I checked and asked if they were ready for review I was told to hold off for further changes? Have they been addressed, as in, is the stack of wtap changes ready for review?

Tue, Feb 20, 5:46 PM · wireless
bz added a comment to D43968: LinuxKPI: 802.11: implement a deferred RX path.
In D43968#1003463, @cc wrote:

Initial test shows this error when I changed the channel number in AP. Looks like a reproduce of PR 277100 without LKPI_80211_HW_CRYPTO enabled, or a separate issue?

Tue, Feb 20, 5:44 PM

Mon, Feb 19

bz requested review of D43981: dev/uart: name uart_class_set DATA_SET macro UART_CLASS().
Mon, Feb 19, 8:47 PM
bz added inline comments to D43945: LinuxKPI w/ LKPI_80211_HW_CRYPTO: fix non-sleepable mutex use..
Mon, Feb 19, 6:40 PM
bz committed R9:5d4b90791c98: Document __FreeBSD_version 13.3 bumps for net80211 internal changes. (authored by bz).
Document __FreeBSD_version 13.3 bumps for net80211 internal changes.
Mon, Feb 19, 4:27 PM
bz committed rG401dbf9cfc0c: LinuxKPI: 802.11: lsta txq locking cleanup (authored by bz).
LinuxKPI: 802.11: lsta txq locking cleanup
Mon, Feb 19, 4:11 PM
bz committed rG9b2da4bc5a68: LinuxKPI: 802.11: update the ni/lsta reference cycle (authored by bz).
LinuxKPI: 802.11: update the ni/lsta reference cycle
Mon, Feb 19, 4:11 PM
bz committed rGa75a3d7afcc8: Bump __FreeBSD_version for net80211 'struct ieee80211vap' changes (authored by bz).
Bump __FreeBSD_version for net80211 'struct ieee80211vap' changes
Mon, Feb 19, 4:11 PM
bz committed rGd4b4efc6db6c: LinuxKPI: 802.11: band-aid for invalid state changes after (*iv_update_bss) (authored by bz).
LinuxKPI: 802.11: band-aid for invalid state changes after (*iv_update_bss)
Mon, Feb 19, 4:11 PM
bz committed rG9b998db87c28: net80211: deal with lost state transitions (authored by bz).
net80211: deal with lost state transitions
Mon, Feb 19, 4:11 PM
bz committed rGeecf453c0e56: net80211: make sure calls to (*iv_update_bss)() are locked (authored by bz).
net80211: make sure calls to (*iv_update_bss)() are locked
Mon, Feb 19, 4:11 PM
bz committed rGf7c8d5448446: net80211: fix a NULL deref in ieee80211_sta_join1() (authored by bz).
net80211: fix a NULL deref in ieee80211_sta_join1()
Mon, Feb 19, 4:11 PM
bz committed rG5463d4cd99f3: LinuxKPI: 802.11: fix field order in ieee80211_key_conf (authored by bz).
LinuxKPI: 802.11: fix field order in ieee80211_key_conf
Mon, Feb 19, 4:11 PM
bz committed rGf93d06ac87f4: net80211: improve logging about state transitions lost (authored by bz).
net80211: improve logging about state transitions lost
Mon, Feb 19, 4:11 PM
bz committed rG804a4c1c7b8f: LinuxKPI: 802.11: more TXQ implementation and locking (authored by bz).
LinuxKPI: 802.11: more TXQ implementation and locking
Mon, Feb 19, 4:10 PM
bz committed rG7d781b891eed: iwlwififw: add firmware for the Bz/B200 chipset (authored by bz).
iwlwififw: add firmware for the Bz/B200 chipset
Mon, Feb 19, 4:10 PM
bz committed rG4a646242c37f: wpa: ctrl_iface set sendbuf size (authored by bz).
wpa: ctrl_iface set sendbuf size
Mon, Feb 19, 4:10 PM
bz committed rGdc50f981e17c: bwn: remove unused ic_headroom (authored by Frank Hilgendorf <frank.hilgendorf@posteo.de>).
bwn: remove unused ic_headroom
Mon, Feb 19, 4:10 PM
bz committed rG763b10806cd4: LinuxKPI: 802.11: lsta txq locking cleanup (authored by bz).
LinuxKPI: 802.11: lsta txq locking cleanup
Mon, Feb 19, 8:10 AM
bz committed rG184ccc414686: LinuxKPI: 802.11: band-aid for invalid state changes after (*iv_update_bss) (authored by bz).
LinuxKPI: 802.11: band-aid for invalid state changes after (*iv_update_bss)
Mon, Feb 19, 8:10 AM
bz committed rG223edc1a3c2f: LinuxKPI: 802.11: update the ni/lsta reference cycle (authored by bz).
LinuxKPI: 802.11: update the ni/lsta reference cycle
Mon, Feb 19, 8:10 AM
bz committed rGa7e1fc7f620d: net80211: deal with lost state transitions (authored by bz).
net80211: deal with lost state transitions
Mon, Feb 19, 8:10 AM
bz committed rG7e5dc3c1fdc0: LinuxKPI: 802.11: correct HT protection fields (authored by bz).
LinuxKPI: 802.11: correct HT protection fields
Mon, Feb 19, 8:10 AM
bz committed rG6a56d8553b55: iwlwifi: improve error message (authored by bz).
iwlwifi: improve error message
Mon, Feb 19, 8:09 AM
bz committed rG5427cefd1d03: net80211: fix checks for (*iv_preamble_update)/(*iv_ht_protmode_update) (authored by bz).
net80211: fix checks for (*iv_preamble_update)/(*iv_ht_protmode_update)
Mon, Feb 19, 8:09 AM
bz committed rG755a04671dd4: net80211: fix a NULL deref in ieee80211_sta_join1() (authored by bz).
net80211: fix a NULL deref in ieee80211_sta_join1()
Mon, Feb 19, 8:09 AM
bz committed rGf8ec03794357: net80211: make sure calls to (*iv_update_bss)() are locked (authored by bz).
net80211: make sure calls to (*iv_update_bss)() are locked
Mon, Feb 19, 8:09 AM
bz committed rG3da00e4c110f: iwlwifi: add the d3 (PM) bits to the Makefile (disabled) (authored by bz).
iwlwifi: add the d3 (PM) bits to the Makefile (disabled)
Mon, Feb 19, 8:09 AM
bz committed rGbbf3fc5b00b8: iwlwifi: adjust to make d3.c compile (authored by bz).
iwlwifi: adjust to make d3.c compile
Mon, Feb 19, 8:09 AM
bz committed rGb42f8328250a: LinuxKPI: 802.11: extend ieee80211_key_seq and WLAN_KEY_LEN_* defines (authored by bz).
LinuxKPI: 802.11: extend ieee80211_key_seq and WLAN_KEY_LEN_* defines
Mon, Feb 19, 8:09 AM
bz committed rG1cf1f094680f: LinuxKPI: 802.11: fix field order in ieee80211_key_conf (authored by bz).
LinuxKPI: 802.11: fix field order in ieee80211_key_conf
Mon, Feb 19, 8:09 AM
bz committed rG9d5aef293d90: net80211: adjust more VHT structures/fields (authored by bz).
net80211: adjust more VHT structures/fields
Mon, Feb 19, 8:09 AM
bz committed rGa2764047702d: net80211: improve logging about state transitions lost (authored by bz).
net80211: improve logging about state transitions lost
Mon, Feb 19, 8:09 AM
bz committed rG3df959638baa: LinuxKPI: 802.11: more TXQ implementation and locking (authored by bz).
LinuxKPI: 802.11: more TXQ implementation and locking
Mon, Feb 19, 8:09 AM
bz committed rG0f032804b6ec: bwn: remove unused ic_headroom (authored by Frank Hilgendorf <frank.hilgendorf@posteo.de>).
bwn: remove unused ic_headroom
Mon, Feb 19, 8:09 AM
bz committed rG135f22ad82f6: tools/net80211: add mlme_assoc (authored by bz).
tools/net80211: add mlme_assoc
Mon, Feb 19, 8:09 AM
bz committed rG3fe19437797b: LinuxKPI: 802.11: bring in some HT code (authored by bz).
LinuxKPI: 802.11: bring in some HT code
Mon, Feb 19, 8:09 AM
bz committed rG97186b5cf5aa: wpa: ctrl_iface set sendbuf size (authored by bz).
wpa: ctrl_iface set sendbuf size
Mon, Feb 19, 8:09 AM
bz committed rGd1d5dbcf2539: iwlwififw: add firmware for the Bz/B200 chipset (authored by bz).
iwlwififw: add firmware for the Bz/B200 chipset
Mon, Feb 19, 8:09 AM
bz committed rG71383e75eae9: net80211: ieee80211_dump_node() check for channel to be set (authored by bz).
net80211: ieee80211_dump_node() check for channel to be set
Mon, Feb 19, 8:09 AM
bz committed rG1ff23eeab2ef: rtw89: improve debugging and fix a sleep issue (authored by bz).
rtw89: improve debugging and fix a sleep issue
Mon, Feb 19, 8:09 AM
bz committed rG90aaf46d5208: LinuxKPI: reduce impact of large MAXCPU (authored by bz).
LinuxKPI: reduce impact of large MAXCPU
Mon, Feb 19, 8:09 AM
bz committed rG1bd05bae9252: LinuxKPI: implement memset_after() (authored by bz).
LinuxKPI: implement memset_after()
Mon, Feb 19, 8:09 AM
bz committed rG2477106d5d0f: LinuxKPI: sort dev_<loglevel>() functions (authored by bz).
LinuxKPI: sort dev_<loglevel>() functions
Mon, Feb 19, 8:09 AM

Sun, Feb 18

bz added a comment to D43968: LinuxKPI: 802.11: implement a deferred RX path.

Notes:
(1) (*ic_ampdu_rx_start)() MO dowcalls in LinuxKPI need to unlock the ic lock and lock the LHW lock as done in the state machine updates given the MO calls can sleep.
(2) there may be further work on the node_cleanup -> ieee80211_ht_node_cleanup -> lkpi_ic_ampdu_rx_stop path needed if (1) is not sufficient
(3) A separate change ieee80211_sn_*() is to come.
(4) Need to go and see about packets and rates now likely as well as the RX packets after the BA response is out will not show up with 11n for me, but I can see the first packet (and retry) in monitor mode. I'd need a "sane" AP to test with.

Sun, Feb 18, 10:20 PM
bz requested review of D43968: LinuxKPI: 802.11: implement a deferred RX path.
Sun, Feb 18, 10:15 PM
bz requested review of D43967: LinuxKPI: 802.11: close race lkpi_sta_scan_to_auth()/(*iv_update_bss)().
Sun, Feb 18, 10:09 PM
bz requested review of D43966: LinuxKPI: 802.11: lock MO tx/wake_tx_queue() downcalls.
Sun, Feb 18, 10:03 PM
bz requested review of D43965: LinuxKPI: 802.11: remove unneeded re-lookup in lkpi_80211_txq_tx_one().
Sun, Feb 18, 9:59 PM