Page MenuHomeFreeBSD

bz (Bjoern A. Zeeb)
User

Projects

User Details

User Since
Aug 29 2014, 12:11 PM (223 w, 3 d)

Recent Activity

Thu, Dec 6

bz added a comment to D18420: add a method to defer destruction of if_softc to if_destroy.
In D18420#392922, @ae wrote:

I think such method can be useful. Do you plan to merge it?

Thu, Dec 6, 4:37 PM

Mon, Dec 3

bz requested changes to D18420: add a method to defer destruction of if_softc to if_destroy.

Sorry but my understanding is that this could possibly free the softc even before lagg_clone_destroy() has finished, couldn't it?

Mon, Dec 3, 4:14 PM

Thu, Nov 29

bz accepted D18366: Limit option_len for the TCP_CCALGOOPT option.
Thu, Nov 29, 5:22 PM

Tue, Nov 27

bz accepted D18338: Fix possible panic during ifnet detach in rtsock .
Tue, Nov 27, 12:06 AM

Mon, Nov 26

bz accepted D18340: Do not install GNU ld if lld is /usr/bin/ld.
Mon, Nov 26, 3:30 PM
bz added inline comments to D18338: Fix possible panic during ifnet detach in rtsock .
Mon, Nov 26, 2:14 PM

Sat, Nov 24

bz added a comment to D12467: Add sdio(4) peripheral device.

@imp could you please comment on your architectural views (or wish-list) while there is still time? Otherwise I might have to sort it out after the facts; I am expecting to be at a point when I need to make a driver talk to some SDIO in about a week and that means I'll work on any middle-glue-code I'll see fit.

Sat, Nov 24, 3:52 PM

Sat, Nov 17

bz committed rS340494: Improve the comment for arpresolve_full() in if_ether.c..
Improve the comment for arpresolve_full() in if_ether.c.
Sat, Nov 17, 4:13 PM
bz committed rS340493: Retire arpresolve_addr(), which is not used anywhere, from if_ether.c..
Retire arpresolve_addr(), which is not used anywhere, from if_ether.c.
Sat, Nov 17, 4:08 PM

Thu, Nov 15

bz accepted D2255: Fix DAD callout locking..

I'll trust you to get the assertion right; sounds good to me.

Thu, Nov 15, 10:48 PM
bz accepted D1715: Sysctl description for dad_count..
Thu, Nov 15, 9:55 PM
bz added inline comments to D2255: Fix DAD callout locking..
Thu, Nov 15, 9:52 PM
bz added a comment to D12467: Add sdio(4) peripheral device.
In D12467#277167, @imp wrote:
Thu, Nov 15, 4:01 PM

Mon, Nov 12

bz committed rS340369: MFC r340251:.
MFC r340251:
Mon, Nov 12, 4:44 PM
bz committed rS340367: MFC r340251:.
MFC r340251:
Mon, Nov 12, 4:37 PM
bz accepted D17777: Allow set ether/vlan PCP operation from the VNET jails..
Mon, Nov 12, 3:17 PM

Nov 9 2018

bz resigned from D17922: More IPv4 fragment checks.

Sorry, getting IPv4 fragments into my head is absolutely not a good idea.

Nov 9 2018, 5:41 PM
bz resigned from D17914: Check for an overly large fragment..

Sorry; getting IPv4 fragments into my head is not a good idea.

Nov 9 2018, 5:39 PM

Nov 8 2018

bz added inline comments to D17898: in6_ifattach_linklocal: handle immediate removal of the new LLA.
Nov 8 2018, 7:06 PM
bz accepted D17909: Avoid buffer underwrite in icmp_error.
Nov 8 2018, 5:19 PM
bz added a comment to D17909: Avoid buffer underwrite in icmp_error.

Can you please site the Apple CVE and possibly the original writeup instead of a (random) reddit thing?

Nov 8 2018, 4:52 PM
bz committed rS340251: Update rum(4) and run(4) man pages to reflect that newer versions.
Update rum(4) and run(4) man pages to reflect that newer versions
Nov 8 2018, 2:46 PM
bz requested changes to D17898: in6_ifattach_linklocal: handle immediate removal of the new LLA.

To me this change seems wrong. The only caller for this function is exactly for the situation when the link-local address is missing.
If we are in the progress of "configuring" the interface and someone is already de-configuring it to me that sounds like a concurrency problem elsewhere.
This entire function seems to be based on the idea that there's a lock held around it and it's the only actor (which might very well still be coming from &Giant days of FreeBSD 4).

Nov 8 2018, 12:55 PM

Nov 4 2018

bz committed rS340109: MFC r340009:.
MFC r340009:
Nov 4 2018, 6:25 AM

Nov 3 2018

bz committed rS340098: Update the "flag" for draft-ietf-6man-ipv6only-flag..
Update the "flag" for draft-ietf-6man-ipv6only-flag.
Nov 3 2018, 6:04 PM

Nov 2 2018

bz committed rS340058: MFC r337904:.
MFC r337904:
Nov 2 2018, 3:03 PM
bz committed rS340056: MFC r330795:.
MFC r330795:
Nov 2 2018, 3:00 PM
bz committed rS340054: MFC r339931,r339933.
MFC r339931,r339933
Nov 2 2018, 2:15 PM
bz committed rS340053: MFC r339431:.
MFC r339431:
Nov 2 2018, 2:13 PM
bz committed rS340052: MFC r339407:.
MFC r339407:
Nov 2 2018, 2:10 PM
bz committed rS340051: MFC r339930:.
MFC r339930:
Nov 2 2018, 2:07 PM
bz abandoned D17512: Fix dpcpu and vnet panics with complex types at the end of the section.

See PR 230857 for details.

Nov 2 2018, 1:56 PM

Nov 1 2018

bz committed rS340009: carpstats are the last virtualised variable in the file and end up at the.
carpstats are the last virtualised variable in the file and end up at the
Nov 1 2018, 5:26 PM
bz added a comment to D17787: While debugging some epoch related races at Netflix, we discoveredfew non fundamental, but annoying issues with epoch.First, the inlining makes it difficult to profile and trace epoch.At the same time, inlining doesn't effectively happens. In....

So is it the last 5 commits on your github branch or is there anything in there from before that? Having this broken up in logical junks for review will make it a lot easier.

Nov 1 2018, 4:35 PM
bz added a reviewer for D17787: While debugging some epoch related races at Netflix, we discoveredfew non fundamental, but annoying issues with epoch.First, the inlining makes it difficult to profile and trace epoch.At the same time, inlining doesn't effectively happens. In...: bz.
Nov 1 2018, 4:05 PM

Oct 31 2018

bz committed rS339953: MFC r339931,r339933:.
MFC r339931,r339933:
Oct 31 2018, 2:03 PM
bz committed rS339951: MFC r339930:.
MFC r339930:
Oct 31 2018, 12:50 PM
bz committed rS339950: MFC r339682:.
MFC r339682:
Oct 31 2018, 12:49 PM
bz committed rS339949: MFC r339586:.
MFC r339586:
Oct 31 2018, 12:05 PM
bz committed rS339947: MFC r339586:.
MFC r339586:
Oct 31 2018, 11:37 AM

Oct 30 2018

bz committed rS339933: Fix mips build after r339931..
Fix mips build after r339931.
Oct 30 2018, 9:36 PM
bz committed rS339931: As a follow-up to r339930 and various reports implement logging in case.
As a follow-up to r339930 and various reports implement logging in case
Oct 30 2018, 8:51 PM
bz committed rS339930: With more excessive use of modules, more kernel parts working with.
With more excessive use of modules, more kernel parts working with
Oct 30 2018, 8:45 PM
bz committed rS339929: Initial implementation of draft-ietf-6man-ipv6only-flag..
Initial implementation of draft-ietf-6man-ipv6only-flag.
Oct 30 2018, 8:09 PM
bz added a comment to D17512: Fix dpcpu and vnet panics with complex types at the end of the section.

Ideally we could place the padding outside of the section instead of inside and then just use <=. However, the linker can place any orphan section inbetween so there might be some relocations...
Since that is not possible this solution looks fine to me.

Oct 30 2018, 6:44 PM
bz committed rS339922: Introduce an EXPERIMENTAL option for both src.conf(5) and the kernel..
Introduce an EXPERIMENTAL option for both src.conf(5) and the kernel.
Oct 30 2018, 3:46 PM

Oct 26 2018

bz added a comment to D17512: Fix dpcpu and vnet panics with complex types at the end of the section.
In D17512#378547, @jhb wrote:

The magic value seems kind of odd. Note that it is a valid KVA on i386 now that i386 was 4:4 (and even before then it was possible to move the top of UVA down to give more KVA, e.g. some folks ran 2:2 on i386 instead of 3:1). Do you have more details on the relocation check? Is it using < instead of <= or some such?

Oct 26 2018, 10:17 PM
bz added a comment to D17512: Fix dpcpu and vnet panics with complex types at the end of the section.

Ok, I've tested this (well the shorter constants version mostly) with my two test modules (no longer panics, size of 1 symbol works), which a linker script which had a wrong padding, and with the matching modules. I am aware that 3rd party modules will be unhappy but after spending days and weeks to get to this, no better solution could be found. Does anyone want to review this quickly so it can go into HEAD and go to 12, to prevent panics there?

Oct 26 2018, 2:33 PM
bz updated the diff for D17512: Fix dpcpu and vnet panics with complex types at the end of the section.

Update the constants to sizeof linker-script-LONG (32bit) to have a smaller
possibility of accidentally matching.

Oct 26 2018, 2:30 PM
bz updated the diff for D17512: Fix dpcpu and vnet panics with complex types at the end of the section.

Go with Alex's suggestion of fixed padding at the end as linkers are not
working reliable enough to simply extend an already existing section (see PR 232291).
This simplfis the linker script logic and adds some extra checkes to link_elf.c
for just i386.

Oct 26 2018, 2:08 PM

Oct 25 2018

bz added a comment to D17593: in[6]_pcblookup_hash_locked() and callers locking after epoch(9).

Neither this nor the kernel version (though that one just less likely) is not deadlock safe. It can still happen.

Oct 25 2018, 2:06 PM

Oct 24 2018

bz committed rS339683: Remove redundant redeclaration of netmap_vp_reg()..
Remove redundant redeclaration of netmap_vp_reg().
Oct 24 2018, 2:15 PM
bz added a comment to D17598: Properly handle case when system is out of network interface numbers.

What's the reason we can't just use the IFNET_WLOCK() and be good with it and not rewriting the entire code but going back to what it was?
The original version if_grow() could not fail, ifindex_alloc() had at best one retry, ... I am still not getting why this wasn't good enough?

Oct 24 2018, 1:50 PM
bz committed rS339682: rip6_input() inp validation after epoch(9).
rip6_input() inp validation after epoch(9)
Oct 24 2018, 10:42 AM
bz closed D17594: rip6_input() inp validation after epoch(9).
Oct 24 2018, 10:42 AM
bz committed rS339681: Allow the bhyve VNC server to listen on IPv6 for incoming connections..
Allow the bhyve VNC server to listen on IPv6 for incoming connections.
Oct 24 2018, 8:45 AM

Oct 23 2018

bz added a reviewer for D17594: rip6_input() inp validation after epoch(9): hselasky.
Oct 23 2018, 9:15 PM
bz added a comment to D17594: rip6_input() inp validation after epoch(9).

Anyone? I'd love to get this in ...

Oct 23 2018, 9:15 PM

Oct 22 2018

bz committed rS339586: In bhyve's fbuf emulation improve the overall "usage" message and.
In bhyve's fbuf emulation improve the overall "usage" message and
Oct 22 2018, 11:44 AM

Oct 19 2018

bz added a comment to D17598: Properly handle case when system is out of network interface numbers.

@bz: Try modifying the script to create 65536 /dev/tun devices.

Oct 19 2018, 11:34 AM

Oct 18 2018

bz committed rS339431: In r78161 the lookup_set linker method was introduced which optionally.
In r78161 the lookup_set linker method was introduced which optionally
Oct 18 2018, 8:20 PM
bz added a comment to D17598: Properly handle case when system is out of network interface numbers.

Silly question; can you explain that test case? How do 255 multicast addresses assigned to 255 interfaces make you run out of ifindex space?

Oct 18 2018, 7:57 PM
bz accepted D17595: Fix handling of RST segments in SYN-RCVD state via the syn cache code path.

For as much as my brain still functions this seems ok

Oct 18 2018, 5:35 PM
bz added a comment to D17595: Fix handling of RST segments in SYN-RCVD state via the syn cache code path.

It would greatly help if the proposed commit message would also cite the RFC sections not just the RFCs; ideally actually comments in the code would do that as well at the right place so that future reference lookups will be easier.

Oct 18 2018, 3:54 PM
bz committed rS339417: While preparing to move init(8) to its own package as indicated.
While preparing to move init(8) to its own package as indicated
Oct 18 2018, 2:07 AM
bz committed rS339416: Fix modules/nvdimm build issues after r339391 by adding a dependency.
Fix modules/nvdimm build issues after r339391 by adding a dependency
Oct 18 2018, 12:51 AM

Oct 17 2018

bz committed rS339414: Fix spelling of an error message and add warning to another error.
Fix spelling of an error message and add warning to another error
Oct 17 2018, 4:54 PM
bz closed D10046: tunefs: fix error message and catch additional error.
Oct 17 2018, 4:54 PM
bz committed rS339413: Move the rc framework out of sbin/init into libexec/rc..
Move the rc framework out of sbin/init into libexec/rc.
Oct 17 2018, 4:49 PM
bz added a comment to D17595: Fix handling of RST segments in SYN-RCVD state via the syn cache code path.

Scrolling through it looks OK with cross-checking to the RFCs.
Mostly commenting on the fact that we should get this in before BETA as it does change the kernel KPI.
Hope someone will do the full technical review (want to add lstewart as well?)

Oct 17 2018, 4:34 PM
bz added reviewers for D10046: tunefs: fix error message and catch additional error: mckusick, jeff.

May I ask if you have a chance to look at this? It's been sitting around here so long that I forgot about it.

Oct 17 2018, 3:55 PM
bz committed rS339407: The countp argument passed to linker_file_lookup_set() in.
The countp argument passed to linker_file_lookup_set() in
Oct 17 2018, 10:31 AM
bz created D17594: rip6_input() inp validation after epoch(9).
Oct 17 2018, 8:25 AM
bz added a comment to D17593: in[6]_pcblookup_hash_locked() and callers locking after epoch(9).

Is this in response to an observed bug? This is adding a lot of complexity when we can simply validate the result

Oct 17 2018, 6:01 AM
bz created D17593: in[6]_pcblookup_hash_locked() and callers locking after epoch(9).
Oct 17 2018, 12:04 AM

Oct 12 2018

bz closed D17540: In udp_input() validate inp before use after epoch(9)..
Oct 12 2018, 10:52 PM
bz committed rS339339: In udp_input() when walking the pcblist we can come across.
In udp_input() when walking the pcblist we can come across
Oct 12 2018, 10:52 PM
bz created D17540: In udp_input() validate inp before use after epoch(9)..
Oct 12 2018, 9:33 PM
bz closed D17525: Move variable into proper block..
Oct 12 2018, 11:31 AM
bz committed rS339327: r217592 moved the check for imo in udp_input() into the conditional block.
r217592 moved the check for imo in udp_input() into the conditional block
Oct 12 2018, 11:30 AM
bz added a comment to D17500: Notify that the ifnet will go away, even on vnet shutdown.

Maybe both? We also don't want to not get notified and have an interface hanging around for ever given pf never releases a reference?
In the first block of you patch you might want to switch the order and set the kif to NULL before releasing the reference.

Oct 12 2018, 10:51 AM

Oct 11 2018

bz created D17525: Move variable into proper block..
Oct 11 2018, 11:46 PM
bz added a comment to D17512: Fix dpcpu and vnet panics with complex types at the end of the section.

I wonder if this could be done in a single pass by adding a dummy symbol in the pcpu/vnet macros and using . = . + (DEFINED(pcpu_dummy) ? 1 : 0?

Oct 11 2018, 10:06 AM

Oct 10 2018

bz updated the diff for D17512: Fix dpcpu and vnet panics with complex types at the end of the section.

The kmod.mk changes can be reduced to two linker invocations instead of three,
also needing one less intermediate file to cleanup.

Oct 10 2018, 10:55 PM
bz added a comment to D17512: Fix dpcpu and vnet panics with complex types at the end of the section.

Argh the kmod changes are the old ones. I'll update in a second

Oct 10 2018, 10:50 PM
bz created D17512: Fix dpcpu and vnet panics with complex types at the end of the section.
Oct 10 2018, 10:49 PM
bz accepted D17511: Add stat counter for ipv6 atomic fragments.
Oct 10 2018, 8:38 PM
bz accepted D17500: Notify that the ifnet will go away, even on vnet shutdown.

Still wonder if pf should hold a reference to the interface as well.

Oct 10 2018, 7:27 PM
bz accepted D17506: pfsync: Add missing unlock.
Oct 10 2018, 6:56 PM
bz accepted D17502: pfsync: Handle syncdev going away.

That was kind-of the model I had in mind for the other callbacks as well ;-)

Oct 10 2018, 6:54 PM
bz accepted D17501: pfsync: Ensure uninit is done before pf.

OK, this only makes sense after the callback functions are virtualized; before the above comment did make sense but was expecting a different architechtural solution (whether true or not at the time of writing)

Oct 10 2018, 6:50 PM
bz accepted D17499: pfsync: Make pfsync callbacks per-vnet.

OK. I was thinking (when reading the UNINIT change) that that only starts to make sense after virtualising these here; and then I wondered why I'd want to virtualise if these called functions would be perfectly fine and happy to determine if pfsync is enabled (RUNNING) in this vnet or not. That way there'd be less virtualisation.

Oct 10 2018, 6:49 PM
bz requested changes to D17499: pfsync: Make pfsync callbacks per-vnet.

Actually, why is this needed?

Oct 10 2018, 5:26 PM
bz added a comment to D17501: pfsync: Ensure uninit is done before pf.

I assume the "other way round" is only true after the function pointers have been virtualised, otherwise not.
And that makes me wonder..

Oct 10 2018, 5:25 PM
bz accepted D17499: pfsync: Make pfsync callbacks per-vnet.

I only scrolled through but it looks good to me.

Oct 10 2018, 5:17 PM

Oct 8 2018

bz accepted D17474: A couple of style fixes in recent TCP changes..

While you are at it, what about https://reviews.freebsd.org/D13865 ?

Oct 8 2018, 7:15 PM

Oct 4 2018

bz accepted D17406: Fix ips_localout counter for SCTP.
Oct 4 2018, 5:20 PM

Oct 2 2018

bz committed rS339091: After r338257 is was possible to trigger a KASSERT() in ud6_output().
After r338257 is was possible to trigger a KASSERT() in ud6_output()
Oct 2 2018, 5:30 PM

Oct 1 2018

bz committed rS339038: Fix the MODULE_PNP_INFO() for iwm(4) where I got the bus and module.
Fix the MODULE_PNP_INFO() for iwm(4) where I got the bus and module
Oct 1 2018, 10:44 AM
bz added a comment to D9770: Listening sockets revamp try #2..

Quick question from scrolling through

Oct 1 2018, 9:44 AM