Page MenuHomeFreeBSD

bz (Bjoern A. Zeeb)
User

Projects

User Details

User Since
Aug 29 2014, 12:11 PM (215 w, 4 d)

Recent Activity

Fri, Oct 12

bz closed D17540: In udp_input() validate inp before use after epoch(9)..
Fri, Oct 12, 10:52 PM
bz committed rS339339: In udp_input() when walking the pcblist we can come across.
In udp_input() when walking the pcblist we can come across
Fri, Oct 12, 10:52 PM
bz created D17540: In udp_input() validate inp before use after epoch(9)..
Fri, Oct 12, 9:33 PM
bz closed D17525: Move variable into proper block..
Fri, Oct 12, 11:31 AM
bz committed rS339327: r217592 moved the check for imo in udp_input() into the conditional block.
r217592 moved the check for imo in udp_input() into the conditional block
Fri, Oct 12, 11:30 AM
bz added a comment to D17500: Notify that the ifnet will go away, even on vnet shutdown.

Maybe both? We also don't want to not get notified and have an interface hanging around for ever given pf never releases a reference?
In the first block of you patch you might want to switch the order and set the kif to NULL before releasing the reference.

Fri, Oct 12, 10:51 AM

Thu, Oct 11

bz created D17525: Move variable into proper block..
Thu, Oct 11, 11:46 PM
bz added a comment to D17512: Fix dpcpu and vnet panics with complex types at the end of the section.

I wonder if this could be done in a single pass by adding a dummy symbol in the pcpu/vnet macros and using . = . + (DEFINED(pcpu_dummy) ? 1 : 0?

Thu, Oct 11, 10:06 AM

Wed, Oct 10

bz updated the diff for D17512: Fix dpcpu and vnet panics with complex types at the end of the section.

The kmod.mk changes can be reduced to two linker invocations instead of three,
also needing one less intermediate file to cleanup.

Wed, Oct 10, 10:55 PM
bz added a comment to D17512: Fix dpcpu and vnet panics with complex types at the end of the section.

Argh the kmod changes are the old ones. I'll update in a second

Wed, Oct 10, 10:50 PM
bz created D17512: Fix dpcpu and vnet panics with complex types at the end of the section.
Wed, Oct 10, 10:49 PM
bz accepted D17511: Add stat counter for ipv6 atomic fragments.
Wed, Oct 10, 8:38 PM
bz accepted D17500: Notify that the ifnet will go away, even on vnet shutdown.

Still wonder if pf should hold a reference to the interface as well.

Wed, Oct 10, 7:27 PM
bz accepted D17506: pfsync: Add missing unlock.
Wed, Oct 10, 6:56 PM
bz accepted D17502: pfsync: Handle syncdev going away.

That was kind-of the model I had in mind for the other callbacks as well ;-)

Wed, Oct 10, 6:54 PM
bz accepted D17501: pfsync: Ensure uninit is done before pf.

OK, this only makes sense after the callback functions are virtualized; before the above comment did make sense but was expecting a different architechtural solution (whether true or not at the time of writing)

Wed, Oct 10, 6:50 PM
bz accepted D17499: pfsync: Make pfsync callbacks per-vnet.

OK. I was thinking (when reading the UNINIT change) that that only starts to make sense after virtualising these here; and then I wondered why I'd want to virtualise if these called functions would be perfectly fine and happy to determine if pfsync is enabled (RUNNING) in this vnet or not. That way there'd be less virtualisation.

Wed, Oct 10, 6:49 PM
bz requested changes to D17499: pfsync: Make pfsync callbacks per-vnet.

Actually, why is this needed?

Wed, Oct 10, 5:26 PM
bz added a comment to D17501: pfsync: Ensure uninit is done before pf.

I assume the "other way round" is only true after the function pointers have been virtualised, otherwise not.
And that makes me wonder..

Wed, Oct 10, 5:25 PM
bz accepted D17499: pfsync: Make pfsync callbacks per-vnet.

I only scrolled through but it looks good to me.

Wed, Oct 10, 5:17 PM

Mon, Oct 8

bz accepted D17474: A couple of style fixes in recent TCP changes..

While you are at it, what about https://reviews.freebsd.org/D13865 ?

Mon, Oct 8, 7:15 PM

Thu, Oct 4

bz accepted D17406: Fix ips_localout counter for SCTP.
Thu, Oct 4, 5:20 PM

Tue, Oct 2

bz committed rS339091: After r338257 is was possible to trigger a KASSERT() in ud6_output().
After r338257 is was possible to trigger a KASSERT() in ud6_output()
Tue, Oct 2, 5:30 PM

Mon, Oct 1

bz committed rS339038: Fix the MODULE_PNP_INFO() for iwm(4) where I got the bus and module.
Fix the MODULE_PNP_INFO() for iwm(4) where I got the bus and module
Mon, Oct 1, 10:44 AM
bz added a comment to D9770: Listening sockets revamp try #2..

Quick question from scrolling through

Mon, Oct 1, 9:44 AM

Sat, Sep 29

bz committed rS339020: Provide MODULE_PNP_INFO() for iwm(4) so that devmatch(8) can.
Provide MODULE_PNP_INFO() for iwm(4) so that devmatch(8) can
Sat, Sep 29, 9:15 PM
bz accepted D17180: Fix changing the MTU for tun/tap devices via TUNSIFINFO/TAPSIFINFO iotcl.
Sat, Sep 29, 10:20 AM

Thu, Sep 27

bz added a comment to D17180: Fix changing the MTU for tun/tap devices via TUNSIFINFO/TAPSIFINFO iotcl.

Ok, I started three times already and got an INTR every time; let me ask the question: why are we doing this all manually here rather than calling the (from here) the generic ioctl to set the MTU and avoid the code duplication?

Thu, Sep 27, 9:51 PM
bz committed rS338969: In in6_pcbpurgeif0() called, e.g., from if_clone_destroy(),.
In in6_pcbpurgeif0() called, e.g., from if_clone_destroy(),
Thu, Sep 27, 3:32 PM

Mon, Sep 24

bz added a comment to D17302: Fix witness warning: uma_zalloc->witness_warn, exclusive sleep mutex xforms_list (IPsec transforms list).

Moving functions should be a separate commit and not be mixed with the functional changes.

Mon, Sep 24, 3:17 PM

Fri, Sep 21

bz accepted D17246: Hold a write lock across udp_notify().

LGTM

Fri, Sep 21, 10:58 PM

Thu, Sep 20

bz committed rS338831: In icmp6_rip6_input(), once we have a lock, make sure the inp is.
In icmp6_rip6_input(), once we have a lock, make sure the inp is
Thu, Sep 20, 3:46 PM

Wed, Sep 19

bz committed rS338804: Update udp6_output() inp locking to avoid concurrency issues with.
Update udp6_output() inp locking to avoid concurrency issues with
Wed, Sep 19, 6:50 PM
bz closed D17230: Update udp6_output() inp locking to avoid concurrency issues with route cache updates.
Wed, Sep 19, 6:49 PM
bz added a comment to D17246: Hold a write lock across udp_notify().

I was wondering for a second about the v6 path; at first glance it seems that udp6_common_ctlinput() via in6_pcbnotify() calls it with a write lock held; wouldn't hurt to double check that please?

Wed, Sep 19, 5:22 PM

Tue, Sep 18

bz updated the summary of D17230: Update udp6_output() inp locking to avoid concurrency issues with route cache updates.
Tue, Sep 18, 10:29 PM
bz created D17230: Update udp6_output() inp locking to avoid concurrency issues with route cache updates.
Tue, Sep 18, 10:26 PM

Sep 14 2018

bz committed rS338685: Set ident for GENERIC-MMCCAM to not announce itself as.
Set ident for GENERIC-MMCCAM to not announce itself as
Sep 14 2018, 3:46 PM

Sep 10 2018

bz added a comment to D17040: Enable WITHOUT_INET* WITHOUT_CRYPT WITHOUT_OPENSSL, WITHOUT_FILE.

I should probably add that I never liked having two options, but it's been inherited from what we had (I think v6 had it and I did the same for legacy). But since our option space has been way too fine grained to my believe anyway for too many things, which is a totally different issue.

Sep 10 2018, 1:20 PM

Sep 6 2018

bz closed D17062: Cleanup unused inpcb fields/flags.
Sep 6 2018, 7:56 PM
bz committed rS338509: The inp_lle field to struct inpcb, along with two "valid" flags.
The inp_lle field to struct inpcb, along with two "valid" flags
Sep 6 2018, 7:55 PM
bz added a reviewer for D17062: Cleanup unused inpcb fields/flags: markj.
Sep 6 2018, 6:32 PM
bz accepted D17065: Use ratecheck(9) in in_pcbinslbgrouphash()..

LGTM

Sep 6 2018, 6:29 PM
bz created D17062: Cleanup unused inpcb fields/flags.
Sep 6 2018, 4:34 PM
bz closed D16891: Make tcp_hpts compile with option RSS.
Sep 6 2018, 4:11 PM
bz committed rS338498: Make tcp_hpts.c compile a LINT kernel with options RSS and PCBGROUPS added by.
Make tcp_hpts.c compile a LINT kernel with options RSS and PCBGROUPS added by
Sep 6 2018, 4:11 PM

Sep 4 2018

bz accepted D17030: Fix style bugs in in_pcblookup_lbgroup()..

LGTM

Sep 4 2018, 11:53 PM

Sep 3 2018

bz added a comment to D17006: Apply RO_RTFREE() to more places.

Post commit Pointyhat to: bz

Sep 3 2018, 10:46 PM
bz committed rS338450: Replicate r328271 from legacy IP to IPv6 using a single macro.
Replicate r328271 from legacy IP to IPv6 using a single macro
Sep 3 2018, 10:27 PM
bz closed D17007: Appl RO_INVALIDATE_CACHE() to more netinet6 code.
Sep 3 2018, 10:27 PM
bz closed D17006: Apply RO_RTFREE() to more places.
Sep 3 2018, 10:14 PM
bz committed rS338449: Replicate r307234 from legacy IP to IPv6 code, using the RO_RTFREE().
Replicate r307234 from legacy IP to IPv6 code, using the RO_RTFREE()
Sep 3 2018, 10:14 PM
bz committed rS338448: As discussed in D6262 post-commit review, change inp_route to.
As discussed in D6262 post-commit review, change inp_route to
Sep 3 2018, 10:13 PM
bz closed D17005: Adjust inp_route to inp_route6 in netinet6 code.
Sep 3 2018, 10:13 PM
bz committed rS338447: Rather than duplicating the functionality of a macro after r322866.
Rather than duplicating the functionality of a macro after r322866
Sep 3 2018, 10:11 PM
bz closed D17004: Remove code duplicating in route.h.
Sep 3 2018, 10:11 PM
bz added a parent revision for D17007: Appl RO_INVALIDATE_CACHE() to more netinet6 code: D17006: Apply RO_RTFREE() to more places.
Sep 3 2018, 3:07 PM
bz added a child revision for D17006: Apply RO_RTFREE() to more places: D17007: Appl RO_INVALIDATE_CACHE() to more netinet6 code.
Sep 3 2018, 3:07 PM
bz created D17007: Appl RO_INVALIDATE_CACHE() to more netinet6 code.
Sep 3 2018, 2:57 PM
bz created D17006: Apply RO_RTFREE() to more places.
Sep 3 2018, 2:55 PM
bz created D17005: Adjust inp_route to inp_route6 in netinet6 code.
Sep 3 2018, 2:54 PM
bz created D17004: Remove code duplicating in route.h.
Sep 3 2018, 2:52 PM

Aug 27 2018

Herald added a reviewer for D6262: Implement L2 lookup caching for TCP and UDP: cem.

Just came across this commit tracing other problems ...

Aug 27 2018, 9:41 PM

Aug 24 2018

bz added a reviewer for D16891: Make tcp_hpts compile with option RSS: np.
Aug 24 2018, 10:26 PM
bz created D16891: Make tcp_hpts compile with option RSS.
Aug 24 2018, 10:25 PM
bz added a reviewer for D16851: Add support for header chain validation on IPv6 Fragments (RFC7112): bz.
Aug 24 2018, 10:13 PM
bz added a comment to D16851: Add support for header chain validation on IPv6 Fragments (RFC7112).

Go and have a look at https://svnweb.freebsd.org/base/head/sys/netpfil/ipfw/ip_fw2.c?annotate=336676#l1453 and be inspired for more?

Aug 24 2018, 10:13 PM
bz accepted D16471: Some TCP reassembly improvements.

The functional changes seem fine even though they address multiple independent problems and should probably be fixed in two independent commits?

Aug 24 2018, 10:00 PM
bz committed rS338306: Unbreak RSS builds after r338257. Folding both RSS blocks together.
Unbreak RSS builds after r338257. Folding both RSS blocks together
Aug 24 2018, 9:49 PM
bz accepted D16850: Update the fragment reassembly code's handling of overlapping fragments to conform to RFC 8200..

Ignoring the unrelated noise removing the #if 0 block the functional changes seem fine.

Aug 24 2018, 9:47 PM
bz added a comment to D16847: Eliminate KAME custom circular queues in reassembly code..

I skipped the #if 0 blocks ; we should nuke them (separately).
I still find the code very confusing and am not sure if all the HEAD/TAIL operations are correct and on the right part.

Aug 24 2018, 9:43 PM

Aug 23 2018

bz committed rS338277: Reduce the log level of tcpd_warn calls from ERR to WARNING..
Reduce the log level of tcpd_warn calls from ERR to WARNING.
Aug 23 2018, 8:44 PM
bz committed rS338257: MFp4 bz_ipv6_fast:.
MFp4 bz_ipv6_fast:
Aug 23 2018, 4:54 PM
bz closed D3721: Improve UDP/IPv6 send performance.
Aug 23 2018, 4:54 PM

Aug 20 2018

bz accepted D16796: Fix IPV6_USE_MIN_MTU socket option for TCP sockets.
Aug 20 2018, 9:41 PM
bz accepted D16792: Fix inheritance of IPv6 options.

LGTM

Aug 20 2018, 8:25 PM
bz accepted D16796: Fix IPV6_USE_MIN_MTU socket option for TCP sockets.

I think it looks good; given you've done the testing.

Aug 20 2018, 8:12 PM
bz committed rS338115: GC inc_isipv6; it was added for "temp" compatibility in 2001, r86764.
GC inc_isipv6; it was added for "temp" compatibility in 2001, r86764
Aug 20 2018, 8:06 PM

Aug 17 2018

bz committed rS337991: METALOG, unless manually overwritten, is defined as….
METALOG, unless manually overwritten, is defined as…
Aug 17 2018, 9:19 PM

Aug 16 2018

bz committed rS337904: Allow the use of TCP instead of UDP for queries by setting options usevc.
Allow the use of TCP instead of UDP for queries by setting options usevc
Aug 16 2018, 1:19 PM
bz closed D16607: Allow revolver(5) to set RES_USEVC.
Aug 16 2018, 1:18 PM

Aug 10 2018

bz added a comment to D16654: IPv6 transport for bsnmp.

I've only scrolled through. I really don't get why ipv6z (needless to say ipv4z is defined but not used) needs to be special. The fact that we encode the interface index is unhelpful in a config file as that might change between boots or other operations, such as oder of vnet creation, order of interface creation, etc.

Aug 10 2018, 10:19 AM

Aug 6 2018

bz created D16607: Allow revolver(5) to set RES_USEVC.
Aug 6 2018, 4:13 PM

Jul 29 2018

bz accepted D16458: Allow implicit connection setup for TCP/IPv6.

There's an exclamation mark missing at the ##else; like [style(9)]:

#ifdef COMPAT_43
/* A large region here, or other conditional code. */
#else /* !COMPAT_43 */
/* Or here. */
#endif /* COMPAT_43 */

Apart from that, thanks! :) I haven't done a any logical review. I assume Kevin has done that.

Jul 29 2018, 11:45 AM
bz requested changes to D16458: Allow implicit connection setup for TCP/IPv6.

Looks like there is a couple of overlong lines in there which should be wrapped.
Can you put comments at else and endif parts as the blocks are at times rather long and nested, so it would make it easier to find the other bit?

Jul 29 2018, 9:38 AM

Jul 26 2018

bz added a comment to D16459: bsnmpd(1): optimize interface description processing.
In D16459#349396, @bz wrote:

Hmm RFC 2863 says:

ifAlias OBJECT-TYPE

SYNTAX      DisplayString (SIZE(0..64))

Nice catch. Does it mean that complying SNMP application must support at most 64 (or 65) octects lenght ifAlias or it must support at least so? Note that Cisco supports "at least" or more: http://cfn.cloudapps.cisco.com/ITDIT/CFN/Dispatch?act=featdesc&task=display&featureId=742

So where is our real problem?

"Test plan" section describes our problems with bsnmpd:

  • bsnmpd spams logs indefinitly if a system has interface with description over 65 characters;
Jul 26 2018, 7:45 PM
bz requested changes to D16459: bsnmpd(1): optimize interface description processing.

I guess I want the real problem to be identified and understood (or a good description for this change and why) rather than patching something that simply masks a different problem.

Jul 26 2018, 6:32 PM
bz added a comment to D16459: bsnmpd(1): optimize interface description processing.

Hmm RFC 2863 says:

Jul 26 2018, 6:31 PM

Jul 24 2018

bz committed rS336681: Updated .Dd missed in r336674..
Updated .Dd missed in r336674.
Jul 24 2018, 6:51 PM

Jul 20 2018

bz accepted D16147: Create a macro for the static modifier with VNET.
Jul 20 2018, 1:07 PM

Jul 16 2018

bz accepted D16145: Don't use static on DPCPU data in arm64 modules.
Jul 16 2018, 4:47 PM

Jul 11 2018

bz updated the diff for D15865: Provide process space virtualisation functionality for jails..
  • Merge branch 'p2' into p3
Jul 11 2018, 3:50 PM
bz updated the diff for D15906: Implement "global" process (and zombie) lists loops iterating over all vps instances and all processes in each..
  • Looks like there was an unlock lost during the merge.
Jul 11 2018, 3:48 PM
bz resigned from D16205: Create three helper functions for parsing boot args..
Jul 11 2018, 3:15 PM
bz added a comment to D16205: Create three helper functions for parsing boot args..
In D16205#344159, @imp wrote:
In D16205#344062, @bz wrote:

Given this is multiple architectures, how are you dealing with colliding/different values? Hmm I see you don't touch that part.

There are no such values. RB_* are 100% the same everywhere.

Jul 11 2018, 3:14 PM
bz updated the diff for D15906: Implement "global" process (and zombie) lists loops iterating over all vps instances and all processes in each..
  • Merge branch 'p1' into p2
Jul 11 2018, 2:54 PM
bz updated the diff for D15570: Virtualization of basic variables and locks for jail+vps..
  • Merge branch 'p0' into p1
  • Maintanance on new code; add virtualisation where needed.
Jul 11 2018, 1:45 PM
bz added a comment to D16205: Create three helper functions for parsing boot args..

Given this is multiple architectures, how are you dealing with colliding/different values? Hmm I see you don't touch that part.
How are you dealing with architecture specific ones (not #defined but now part of the switch statement)?
I guess what I am saying is: if we clean this up, can we also break everything and cleanup the #defines along somehow to only have one set of those as well?

Jul 11 2018, 11:43 AM

Jul 10 2018

bz updated the diff for D15556: Initial vps (virtual process space) framework for jails..
Update to more recent head.
Jul 10 2018, 9:02 AM
bz added a reviewer for D16202: libradius(3) IPv6 support: hrs.
Jul 10 2018, 12:19 AM