- User Since
- Aug 29 2014, 12:11 PM (203 w, 9 h)
Mon, Jul 16
Wed, Jul 11
- Merge branch 'p2' into p3
- Looks like there was an unlock lost during the merge.
- Merge branch 'p1' into p2
- Merge branch 'p0' into p1
- Maintanance on new code; add virtualisation where needed.
Given this is multiple architectures, how are you dealing with colliding/different values? Hmm I see you don't touch that part.
How are you dealing with architecture specific ones (not #defined but now part of the switch statement)?
I guess what I am saying is: if we clean this up, can we also break everything and cleanup the #defines along somehow to only have one set of those as well?
Tue, Jul 10
Update to more recent head.
This feels like a 15 year old patch I've seen before.
Mon, Jul 9
Please also incorporate the one line subject summary into the description for the commit message.
Sat, Jul 7
If you can sort out the pf_ioctl.c volatile issue first, and add the comment as you suggested this look good to me.
Thu, Jul 5
Thanks for the review!
Addressed all the comments; not unlocking for panic also
allowed us to remove the tryl variable and just return.
do whatever you want with the comment and commit
Happy with those bits if you do the man page as you say :)
- Set P_TREE_REAPER on proc0 given it is the reaper for init now.
For the other comments it's basically the same; I moved the former inline code into sub-functions. I'll make the changes and upload a new patch.
What about (what do others think):
Add you two for the DPCPU (and later VNET) static file local load relative issue (1st step) solution.
Jun 20 2018
Jun 19 2018
Follow-up on comments to @jamie
I'll try to get some of the whitespace changes (using sub-functions for highly indented code, etc) out of this patch and into head separately to make it easier to review this one.
Jun 18 2018
Moved the VPS check for attach into do_jail_attach()
Prevent attaching to a jail both from jail_attach() and from jaiL_set() by moving the check into the first thing of do_jail_attach().
Jun 17 2018
Jun 14 2018
May 25 2018
May 24 2018
- Update the static asserts to match again.
- Merge branch 'master' into p0
I have already committed the noise to HEAD. Seems the git export was too slow to pick it up and merge it out.
May 6 2018
Apart from the style issue, I think this can be fine.
Apr 19 2018
Did you ever measure (apart from VTune) any difference. What does this change do to VIMAGE kernels given td_vnet gets down to the cold side of the structure?
Apr 17 2018
Hmm I tried to add syrinx but she's not on Phab it seems.
Apr 12 2018
Apr 9 2018
Fix the _ts stuff by not doing it anymore.
Apr 4 2018
Mar 29 2018
Mar 22 2018
Seems good to me.
Mar 20 2018
Sounds good to me. I think if the vnet disappears between before the callback we have entirely different problems.
Mar 16 2018
https://tools.ietf.org/html/rfc6890 table 20 these days disallows v4-mapped addresses on the wire; yiipppiiie!
Based on the F2F discussion:
get this one in and we'll sort the problem of https://tools.ietf.org/html/draft-itojun-v6ops-v4mapped-harmful-02 (still being true or not) out at a later time.
Mar 12 2018
Thanks for the feedback; I'll get the one-liner in and leave the rest of the cleanup to you.
Mar 9 2018
Feb 6 2018
Jan 30 2018
LGTM (not checked but assume you caught all places)
Jan 25 2018
Jan 23 2018
Ok, so I think this is not the complete fix.
The tcp6_usr_bind() code you reference has the additional bits to make this right-er.
Jan 14 2018
Jan 11 2018
Seems this came in in r271976 with D775 after VIMAGE was in the tree.
You don't need to set the CURVNET() that early (only after the switch) it seems but it shouldn't matter.
Looks OK to me.
Dec 31 2017
Dec 17 2017
Reading the comment I though "oh so it was actually a bug in netstat" and might squid be doing. Then I saw the patch. This needs a way better description for the commit message! Also a reference to the commit that changed the original behaviour now making this necessary.