Page MenuHomeFreeBSD

bz (Bjoern A. Zeeb)
User

Projects

User Details

User Since
Aug 29 2014, 12:11 PM (233 w, 21 h)

Recent Activity

Sat, Jan 26

bz committed rS343477: Fix logic errors in iwm_pcie_load_firmware_chunk introduced in r314065..
Fix logic errors in iwm_pcie_load_firmware_chunk introduced in r314065.
Sat, Jan 26, 5:52 PM
bz added a comment to D18904: Make arp return errors.

I know the initial emails were eaten by phabricator. I am still hoping someone would tell me why this is a really bad idea... or not. @karels @gnn ?

Sat, Jan 26, 2:57 PM

Fri, Jan 25

bz accepted D18960: Patch to MFC TCP reassembly rewrite to stable/11.

Given the discussions in D18968 I think you'd be safe as I'd assume we don't otherwise have TCP_REASS_LOGGING in 11, do we?
I guess rrs may or may not give you a more technical feedback.

Fri, Jan 25, 9:18 PM
bz added a comment to D18960: Patch to MFC TCP reassembly rewrite to stable/11.

Ok, your prepared change looks good from a merge-to-stable11 perspective.

Fri, Jan 25, 6:47 PM
bz requested changes to D18951: New pfil(9).

Can we also get rid of the special case pfil_ipfw with this (before/after this change)?
Also, while I like it can we break out certain changes which do not have to be part of the initial framework change, e.g., the Mellanox driver change seems to be self-contained (as others possibly are). Helps to review and understand individual parts.

Fri, Jan 25, 7:16 AM

Thu, Jan 24

bz accepted D18948: [bhnd] remove unused sc variable.

Looks good.

Thu, Jan 24, 9:16 PM

Wed, Jan 23

bz accepted D18906: Fix an LLE lookup race..

I am accepting it as it seems all correct. Given you said you want an EN for this as well, you might consider to split it up into two parts so that only the real functional fix would later be part of the EN.

Wed, Jan 23, 9:18 PM
bz accepted D18887: Fix refcounting leaks in IPv6 MLD code leading to loss of IPv6 connectivity.

You may want to consider forwarding this to re@ after commit and suggest once merged to stable/12 there should be a EN about this; probably together with markj's D18906.

Wed, Jan 23, 9:10 PM
bz added a reviewer for D18906: Fix an LLE lookup race.: bz.
Wed, Jan 23, 6:09 PM

Tue, Jan 22

bz added a reviewer for D18887: Fix refcounting leaks in IPv6 MLD code leading to loss of IPv6 connectivity: bz.
Tue, Jan 22, 5:07 PM
bz added a comment to D18887: Fix refcounting leaks in IPv6 MLD code leading to loss of IPv6 connectivity.

Most of the "cosmetic" changes can be ignored if you want. The only real one is the one I marked with XXX; if the current code is correct I think it would deserve a comment on why that is. I couldn't figure it out quickly.

Tue, Jan 22, 5:07 PM

Sun, Jan 20

bz created D18904: Make arp return errors.
Sun, Jan 20, 10:49 AM

Fri, Jan 18

bz added a comment to D18887: Fix refcounting leaks in IPv6 MLD code leading to loss of IPv6 connectivity.

(a) there's one or two lines of whitespace changes in there; can we get them sorted separately?
(b) how much of this has become "reverting" changes and how much is actual change now? I wonder if, for the sake of clarity and history as well as for easier review, could be split into two parts? Is that feasible?

Fri, Jan 18, 12:56 PM

Jan 15 2019

bz committed rS343065: With the sync from Dragonfly BSD in r318216 a bug slipped in (also still present.
With the sync from Dragonfly BSD in r318216 a bug slipped in (also still present
Jan 15 2019, 10:32 PM

Jan 11 2019

bz added a comment to D17521: Correct accounting when dropping fragment queues.

Hit enter too early; you might want to be slightly more verbose in the commit message as to why this change is done.

Jan 11 2019, 10:50 PM
bz accepted D17521: Correct accounting when dropping fragment queues.

Not sure where the documentation will go but netstat -s -p ip6 says "fragments" not "packets" so this change sees correct.

Jan 11 2019, 10:50 PM

Jan 7 2019

bz added a comment to D5165: [patch] dev/bwn suppressing "bwn0: unsupported rate 0" console messages.

Ok looks like bwi doesn't need.

Jan 7 2019, 4:56 PM
bz accepted D18769: Fix broken IPv6 scope ID checks in outgoing direction.

I like this version better than the one before. Thanks! For as much as I can say it looks OK. I haven't tested it.

Jan 7 2019, 3:52 PM
bz added a comment to D5165: [patch] dev/bwn suppressing "bwn0: unsupported rate 0" console messages.

Depending on the outcome here, it look like bwi will need similar treatment?

Jan 7 2019, 3:20 PM
bz added a comment to D18769: Fix broken IPv6 scope ID checks in outgoing direction.

Can you please fold some of the problem description of "why?" this change is needed in the proposed commit message; having some more information available when scrolling through source code management system logs is extremely helpful.

Jan 7 2019, 1:53 PM

Dec 23 2018

bz added inline comments to D18630: gai_strerror() - Update string error messages according to RFC 3493.
Dec 23 2018, 11:12 AM

Dec 15 2018

bz accepted D18505: Remove the timed daemon..

Ok, let's try this..

Dec 15 2018, 9:01 PM
bz requested changes to D18505: Remove the timed daemon..

Sorry, a tiny tinsy bit more.

Dec 15 2018, 12:14 PM

Dec 14 2018

bz added a comment to D18505: Remove the timed daemon..

Also please re-gen src.conf(5)

Dec 14 2018, 8:32 PM
bz added a comment to D18505: Remove the timed daemon..

I suggest a grep -ir timed over the src tree (ignore the .svn directory) is a good way of seeing or finding more.

Dec 14 2018, 8:31 PM
bz requested changes to D18505: Remove the timed daemon..

I think you are still not removing /etc/rc.d/timed using ObsoleteFiles and also libexec/rc/rc.d/timed (I assume is where it's coming from given the Makefile change) is still in SVN.

Dec 14 2018, 8:31 PM
bz accepted D18443: Fix bugs in plugable CC algorithm and siftr sysctls..
Dec 14 2018, 8:22 PM

Dec 13 2018

bz added a reviewer for D18443: Fix bugs in plugable CC algorithm and siftr sysctls.: bz.

I volunteered to look at this to get the transport unblocked. Can do tomorrow together in case I'd have a question.

Dec 13 2018, 5:26 PM

Dec 11 2018

bz committed rS341832: Remove a dead file. CVS was removed in r251794..
Remove a dead file. CVS was removed in r251794.
Dec 11 2018, 9:16 PM
bz requested changes to D18505: Remove the timed daemon..

Check libexec/rc/rc.d/Makefile:.if ${MK_TIMED} != "no"
Check tools/build/mk/OptionalObsoleteFiles.inc:.if ${MK_TIMED} == no
rm tools/build/options/WITHOUT_TIMED (and re-gen src.conf)

Dec 11 2018, 9:05 PM

Dec 6 2018

bz added a comment to D18420: add a method to defer destruction of if_softc to if_destroy.
In D18420#392922, @ae wrote:

I think such method can be useful. Do you plan to merge it?

Dec 6 2018, 4:37 PM

Dec 3 2018

bz requested changes to D18420: add a method to defer destruction of if_softc to if_destroy.

Sorry but my understanding is that this could possibly free the softc even before lagg_clone_destroy() has finished, couldn't it?

Dec 3 2018, 4:14 PM

Nov 29 2018

bz accepted D18366: Limit option_len for the TCP_CCALGOOPT option.
Nov 29 2018, 5:22 PM

Nov 27 2018

bz accepted D18338: Fix possible panic during ifnet detach in rtsock .
Nov 27 2018, 12:06 AM

Nov 26 2018

bz accepted D18340: Do not install GNU ld if lld is /usr/bin/ld.
Nov 26 2018, 3:30 PM
bz added inline comments to D18338: Fix possible panic during ifnet detach in rtsock .
Nov 26 2018, 2:14 PM

Nov 24 2018

bz added a comment to D12467: Add sdio(4) peripheral device.

@imp could you please comment on your architectural views (or wish-list) while there is still time? Otherwise I might have to sort it out after the facts; I am expecting to be at a point when I need to make a driver talk to some SDIO in about a week and that means I'll work on any middle-glue-code I'll see fit.

Nov 24 2018, 3:52 PM

Nov 17 2018

bz committed rS340494: Improve the comment for arpresolve_full() in if_ether.c..
Improve the comment for arpresolve_full() in if_ether.c.
Nov 17 2018, 4:13 PM
bz committed rS340493: Retire arpresolve_addr(), which is not used anywhere, from if_ether.c..
Retire arpresolve_addr(), which is not used anywhere, from if_ether.c.
Nov 17 2018, 4:08 PM

Nov 15 2018

bz accepted D2255: Fix DAD callout locking..

I'll trust you to get the assertion right; sounds good to me.

Nov 15 2018, 10:48 PM
bz accepted D1715: Sysctl description for dad_count..
Nov 15 2018, 9:55 PM
bz added inline comments to D2255: Fix DAD callout locking..
Nov 15 2018, 9:52 PM
bz added a comment to D12467: Add sdio(4) peripheral device.
In D12467#277167, @imp wrote:
Nov 15 2018, 4:01 PM

Nov 12 2018

bz committed rS340369: MFC r340251:.
MFC r340251:
Nov 12 2018, 4:44 PM
bz committed rS340367: MFC r340251:.
MFC r340251:
Nov 12 2018, 4:37 PM
bz accepted D17777: Allow set ether/vlan PCP operation from the VNET jails..
Nov 12 2018, 3:17 PM

Nov 9 2018

bz resigned from D17922: More IPv4 fragment checks.

Sorry, getting IPv4 fragments into my head is absolutely not a good idea.

Nov 9 2018, 5:41 PM
bz resigned from D17914: Check for an overly large fragment..

Sorry; getting IPv4 fragments into my head is not a good idea.

Nov 9 2018, 5:39 PM

Nov 8 2018

bz added inline comments to D17898: in6_ifattach_linklocal: handle immediate removal of the new LLA.
Nov 8 2018, 7:06 PM
bz accepted D17909: Avoid buffer underwrite in icmp_error.
Nov 8 2018, 5:19 PM
bz added a comment to D17909: Avoid buffer underwrite in icmp_error.

Can you please site the Apple CVE and possibly the original writeup instead of a (random) reddit thing?

Nov 8 2018, 4:52 PM
bz committed rS340251: Update rum(4) and run(4) man pages to reflect that newer versions.
Update rum(4) and run(4) man pages to reflect that newer versions
Nov 8 2018, 2:46 PM
bz requested changes to D17898: in6_ifattach_linklocal: handle immediate removal of the new LLA.

To me this change seems wrong. The only caller for this function is exactly for the situation when the link-local address is missing.
If we are in the progress of "configuring" the interface and someone is already de-configuring it to me that sounds like a concurrency problem elsewhere.
This entire function seems to be based on the idea that there's a lock held around it and it's the only actor (which might very well still be coming from &Giant days of FreeBSD 4).

Nov 8 2018, 12:55 PM

Nov 4 2018

bz committed rS340109: MFC r340009:.
MFC r340009:
Nov 4 2018, 6:25 AM

Nov 3 2018

bz committed rS340098: Update the "flag" for draft-ietf-6man-ipv6only-flag..
Update the "flag" for draft-ietf-6man-ipv6only-flag.
Nov 3 2018, 6:04 PM

Nov 2 2018

bz committed rS340058: MFC r337904:.
MFC r337904:
Nov 2 2018, 3:03 PM
bz committed rS340056: MFC r330795:.
MFC r330795:
Nov 2 2018, 3:00 PM
bz committed rS340054: MFC r339931,r339933.
MFC r339931,r339933
Nov 2 2018, 2:15 PM
bz committed rS340053: MFC r339431:.
MFC r339431:
Nov 2 2018, 2:13 PM
bz committed rS340052: MFC r339407:.
MFC r339407:
Nov 2 2018, 2:10 PM
bz committed rS340051: MFC r339930:.
MFC r339930:
Nov 2 2018, 2:07 PM
bz abandoned D17512: Fix dpcpu and vnet panics with complex types at the end of the section.

See PR 230857 for details.

Nov 2 2018, 1:56 PM

Nov 1 2018

bz committed rS340009: carpstats are the last virtualised variable in the file and end up at the.
carpstats are the last virtualised variable in the file and end up at the
Nov 1 2018, 5:26 PM
bz added a comment to D17787: While debugging some epoch related races at Netflix, we discoveredfew non fundamental, but annoying issues with epoch.First, the inlining makes it difficult to profile and trace epoch.At the same time, inlining doesn't effectively happens. In....

So is it the last 5 commits on your github branch or is there anything in there from before that? Having this broken up in logical junks for review will make it a lot easier.

Nov 1 2018, 4:35 PM
bz added a reviewer for D17787: While debugging some epoch related races at Netflix, we discoveredfew non fundamental, but annoying issues with epoch.First, the inlining makes it difficult to profile and trace epoch.At the same time, inlining doesn't effectively happens. In...: bz.
Nov 1 2018, 4:05 PM

Oct 31 2018

bz committed rS339953: MFC r339931,r339933:.
MFC r339931,r339933:
Oct 31 2018, 2:03 PM
bz committed rS339951: MFC r339930:.
MFC r339930:
Oct 31 2018, 12:50 PM
bz committed rS339950: MFC r339682:.
MFC r339682:
Oct 31 2018, 12:49 PM
bz committed rS339949: MFC r339586:.
MFC r339586:
Oct 31 2018, 12:05 PM
bz committed rS339947: MFC r339586:.
MFC r339586:
Oct 31 2018, 11:37 AM

Oct 30 2018

bz committed rS339933: Fix mips build after r339931..
Fix mips build after r339931.
Oct 30 2018, 9:36 PM
bz committed rS339931: As a follow-up to r339930 and various reports implement logging in case.
As a follow-up to r339930 and various reports implement logging in case
Oct 30 2018, 8:51 PM
bz committed rS339930: With more excessive use of modules, more kernel parts working with.
With more excessive use of modules, more kernel parts working with
Oct 30 2018, 8:45 PM
bz committed rS339929: Initial implementation of draft-ietf-6man-ipv6only-flag..
Initial implementation of draft-ietf-6man-ipv6only-flag.
Oct 30 2018, 8:09 PM
bz added a comment to D17512: Fix dpcpu and vnet panics with complex types at the end of the section.

Ideally we could place the padding outside of the section instead of inside and then just use <=. However, the linker can place any orphan section inbetween so there might be some relocations...
Since that is not possible this solution looks fine to me.

Oct 30 2018, 6:44 PM
bz committed rS339922: Introduce an EXPERIMENTAL option for both src.conf(5) and the kernel..
Introduce an EXPERIMENTAL option for both src.conf(5) and the kernel.
Oct 30 2018, 3:46 PM

Oct 26 2018

bz added a comment to D17512: Fix dpcpu and vnet panics with complex types at the end of the section.
In D17512#378547, @jhb wrote:

The magic value seems kind of odd. Note that it is a valid KVA on i386 now that i386 was 4:4 (and even before then it was possible to move the top of UVA down to give more KVA, e.g. some folks ran 2:2 on i386 instead of 3:1). Do you have more details on the relocation check? Is it using < instead of <= or some such?

Oct 26 2018, 10:17 PM
bz added a comment to D17512: Fix dpcpu and vnet panics with complex types at the end of the section.

Ok, I've tested this (well the shorter constants version mostly) with my two test modules (no longer panics, size of 1 symbol works), which a linker script which had a wrong padding, and with the matching modules. I am aware that 3rd party modules will be unhappy but after spending days and weeks to get to this, no better solution could be found. Does anyone want to review this quickly so it can go into HEAD and go to 12, to prevent panics there?

Oct 26 2018, 2:33 PM
bz updated the diff for D17512: Fix dpcpu and vnet panics with complex types at the end of the section.

Update the constants to sizeof linker-script-LONG (32bit) to have a smaller
possibility of accidentally matching.

Oct 26 2018, 2:30 PM
bz updated the diff for D17512: Fix dpcpu and vnet panics with complex types at the end of the section.

Go with Alex's suggestion of fixed padding at the end as linkers are not
working reliable enough to simply extend an already existing section (see PR 232291).
This simplfis the linker script logic and adds some extra checkes to link_elf.c
for just i386.

Oct 26 2018, 2:08 PM

Oct 25 2018

bz added a comment to D17593: in[6]_pcblookup_hash_locked() and callers locking after epoch(9).

Neither this nor the kernel version (though that one just less likely) is not deadlock safe. It can still happen.

Oct 25 2018, 2:06 PM

Oct 24 2018

bz committed rS339683: Remove redundant redeclaration of netmap_vp_reg()..
Remove redundant redeclaration of netmap_vp_reg().
Oct 24 2018, 2:15 PM
bz added a comment to D17598: Properly handle case when system is out of network interface numbers.

What's the reason we can't just use the IFNET_WLOCK() and be good with it and not rewriting the entire code but going back to what it was?
The original version if_grow() could not fail, ifindex_alloc() had at best one retry, ... I am still not getting why this wasn't good enough?

Oct 24 2018, 1:50 PM
bz committed rS339682: rip6_input() inp validation after epoch(9).
rip6_input() inp validation after epoch(9)
Oct 24 2018, 10:42 AM
bz closed D17594: rip6_input() inp validation after epoch(9).
Oct 24 2018, 10:42 AM
bz committed rS339681: Allow the bhyve VNC server to listen on IPv6 for incoming connections..
Allow the bhyve VNC server to listen on IPv6 for incoming connections.
Oct 24 2018, 8:45 AM

Oct 23 2018

bz added a reviewer for D17594: rip6_input() inp validation after epoch(9): hselasky.
Oct 23 2018, 9:15 PM
bz added a comment to D17594: rip6_input() inp validation after epoch(9).

Anyone? I'd love to get this in ...

Oct 23 2018, 9:15 PM

Oct 22 2018

bz committed rS339586: In bhyve's fbuf emulation improve the overall "usage" message and.
In bhyve's fbuf emulation improve the overall "usage" message and
Oct 22 2018, 11:44 AM

Oct 19 2018

bz added a comment to D17598: Properly handle case when system is out of network interface numbers.

@bz: Try modifying the script to create 65536 /dev/tun devices.

Oct 19 2018, 11:34 AM

Oct 18 2018

bz committed rS339431: In r78161 the lookup_set linker method was introduced which optionally.
In r78161 the lookup_set linker method was introduced which optionally
Oct 18 2018, 8:20 PM
bz added a comment to D17598: Properly handle case when system is out of network interface numbers.

Silly question; can you explain that test case? How do 255 multicast addresses assigned to 255 interfaces make you run out of ifindex space?

Oct 18 2018, 7:57 PM
bz accepted D17595: Fix handling of RST segments in SYN-RCVD state via the syn cache code path.

For as much as my brain still functions this seems ok

Oct 18 2018, 5:35 PM
bz added a comment to D17595: Fix handling of RST segments in SYN-RCVD state via the syn cache code path.

It would greatly help if the proposed commit message would also cite the RFC sections not just the RFCs; ideally actually comments in the code would do that as well at the right place so that future reference lookups will be easier.

Oct 18 2018, 3:54 PM
bz committed rS339417: While preparing to move init(8) to its own package as indicated.
While preparing to move init(8) to its own package as indicated
Oct 18 2018, 2:07 AM
bz committed rS339416: Fix modules/nvdimm build issues after r339391 by adding a dependency.
Fix modules/nvdimm build issues after r339391 by adding a dependency
Oct 18 2018, 12:51 AM

Oct 17 2018

bz committed rS339414: Fix spelling of an error message and add warning to another error.
Fix spelling of an error message and add warning to another error
Oct 17 2018, 4:54 PM
bz closed D10046: tunefs: fix error message and catch additional error.
Oct 17 2018, 4:54 PM
bz committed rS339413: Move the rc framework out of sbin/init into libexec/rc..
Move the rc framework out of sbin/init into libexec/rc.
Oct 17 2018, 4:49 PM
bz added a comment to D17595: Fix handling of RST segments in SYN-RCVD state via the syn cache code path.

Scrolling through it looks OK with cross-checking to the RFCs.
Mostly commenting on the fact that we should get this in before BETA as it does change the kernel KPI.
Hope someone will do the full technical review (want to add lstewart as well?)

Oct 17 2018, 4:34 PM