Handle review.

Handle review.

Can you explain why is it needed?

Might be point to the design documents we have somewhere else.

I only have one question, why this cmap needs to be per-cpu? I do not think that it is high-contention resource.

Dimitry, I am sorry, just committed a second before your approval.

Ping? I want to fix this regression. If no feedback is provided, I plan to commit the change tomorrow.

As an afterthough, i.e. I suggest to commit this and then add my further modifications:

1. we might check that clofd is indeed not a valid fd in the child
2. (my personal request) we should check that each desired bit is set in pmask by individual ATF_REQUIRE statement. Due to the kyua 'features', tests are impossible to debug, so a failure there cannot be identified just by looking the the test output.

In D56022#1287961, @aokblast wrote:

In D56022#1282431, @kib wrote:

In D56022#1282270, @aokblast wrote:

In D56022#1281980, @kib wrote:

No. Perhaps it is simpler to show code than to try to explain it, See D56053.

The example you provided would not work with my patch, it requires increasing the CXA_DTORS_ITERATIONS. Not sure if we want this.

If it breaks the valid C++ code, we should rethink about it. The T value can be somehow greater than CXA_DTORS_ITERATIONS if the user wants.

I do not disagree but there are also some robustness requirements as part of the implementation quality. So I am unsire, this is why I initially said that 'I am on edge' proposing this. Hanging in the system state (thread exiting) due to user bug is not robust.

That said, your patch should remove walk_cb_nocall(). And perhaps cxa_thread_walk() could drop the argument, simply inlining walk_cb_call.

I see, I think we can leave this patch in here before we get better conclusion. I run the test code on a Linux machine and it died immediately if we have infinity loop in thread local destructor. It seems that glibc also don't handle that case.

Pass tinderbox.

The version that builds with TARGET=arm64

Provide actual implementation for fegetenv, feenableexcept, fedisableexcept on aarch64.

Remove conditional include of the arch symbol map. All arches provide it, after the patch.

This is probably fine, but then resetting m_needs_zeroing seems to be somewhat unneeded. I started thinking that m_needs_zeroing should be removed, and when we find an invalid page on the shadowing object queue, we need to zero it immediately.

In D55912#1287198, @gallatin wrote:

You mean as a later, separate project, correct?

Sorry for the late reply.

The mere fact that we slept on the page somewhere in the shadow hierarchy does not mean that first_m should be zeroed.
But, if we go this route, then IMO m_needs_zero should be reset to true right at the RetryFault, and be done with it.

In D56223#1286935, @kevans wrote:

Hmm, The second kqueue might not be as useful as I've thought. It doesn't mean much because the filter needs to resolve the fd first, which will EBADF early.

Sentence per line

Sentence per line

Fix manpage.
Switch test to use non-_np names.