User Details
- User Since
- May 16 2014, 7:35 PM (574 w, 1 d)
Today
So overall I do not like this, sorry. It makes very delicate semantic change for what is basically an assisted self-induced jail problem. The O_RESOLVE_BENEATH is huge complication to the lookup process already to abuse it even more.
I would very much prefer the straight fix of not allowing to externalize dirfd if it comes from a different jail (with nuances about prison0 or equal roots).
You might want to mention that for dynamic binaries rtld selects which init model to use based on the presence of the FreeBSD note NOINIT.
Yesterday
Fix language mistakes in the man page.
IMO the right way is much simpler, and was formulated in the PR: only allow to pass dirfd across the same jail, or from any jail to prison0. I think your addition of allowing to pass dirfd between different jails but having same rootvp is neat.
Thu, May 15
Wed, May 14
Tue, May 13
So if talking about changing (bumping) this limit, we probably should just drop the kmem part of the formula for DMAP machines or machines where uma has small_alloc.
Mon, May 12
Exactly the reverse. Your comment repeats the code and does not say anything about a possible intent.
Having a verbose rewrite of the formula into the text does not help in reviewing the code.
The objections to the previous review are equally applicable to this one.
What is the point of making comment repeating the code in even more verbose way? This would make the comment inconsistent with the actual code on the next whatever minor change.
Sat, May 10
Fri, May 9
Implement andrew' suggestion.
Add needed headers for mem_aarch64.c
On armv8, generate simple-minded SError.
Thu, May 8
Wed, May 7
For me, Elf_Addr is more natural type synonym to use in the rtld code. Also, it gives us the luxury of Elf32/64_Addr typedefs, so if needed, multilib-like rtld has an easier way to express itself.
(I understand that this change in its current form depends on two other rtld reviews)