- User Since
- May 16 2014, 7:35 PM (337 w, 16 h)
I think this change is fine as is.
Thu, Oct 29
If doing such reorg, it might make sense to de-commission syscall_thread_enter/exit, renaming underscored functions back to syscall_thread_.... Then you would fetch SY_THR_STATIC once and cache it in local var.
Wed, Oct 28
enter is needed for syscalls from _loadable_ modules, not unloadable.
Provide extensive comment about get_parent_vp(), which in essence overviews the whole patch with its ERELOOKUP mechanism.
Last batch of fixes.
Passed full stress2 run.
Tue, Oct 27
refcount_release_if_last sounds almost like refcount_release, and I suspect that refcount_release() might be enough. As I understand, the problem is that pmap_remove_pages() has to operate on current pmap, which causes all that troubles. What if we just use refcount_release() and keep p_vmspace with refcount zero until pmap_remove_pages() finish ?
I am not sure about this approach. Note that vref()/usecount reference does not prevent the vnode reclaim. So for instance force umount results in vgone() which does inactivation and reclaim regardless of the active state (or rather does inactivation if the vnode is active). In this case, it seems to not fix the issue.
Mon, Oct 26
All pseudo fs do not do anything with from/source.
For real filesystems, resolving source is actually useful for users, I believe, but it would be a user-visible change. In fact, I sometimes want the behavior that your patch introduces.
Sun, Oct 25
Sat, Oct 24
Fix build for !DIAGNOSTICS.
Latest batch of the fixes for bugs reported by Peter.
vmspace != vm_map, and vm_map lock is only supposed to protect vm_map.
What about compat32 ?
Fri, Oct 23
Instead of trying to outguess all syscalls, might be add a TDP flag to indicate that AUDIT on exit does not need to be done. Then, in the special-case syscalls like *execve() and perhaps all users of kern_posix_exit(), call AUDIT_SYSCALL_EXIT() manually when you know the correct errno.
Reword text to distinguish between guard as is, and minimal guard size.
As far as this pass tinderbox ...
Thu, Oct 22
Wed, Oct 21
Handle Ed' notes.
Use .Dv for sysctl mib name.
Tue, Oct 20
I will handle the patch.
Merging i386/npx.c and amd64/fpu.c is a lot of work for many reasons, I evaluated that several years ago. For now keeping them separate is better IMO.
Mon, Oct 19
No, this should be in SATA driver.
Sun, Oct 18
I am curious. There is no arch restriction on the value of MSI base address ? System can map MSI page anywhere, and just programming the correct address into MSI address register would make it work ?
What do you refer above as an ancient stuff ? Except for __P() and perhaps __inline/__const/__volatile everything else is not about ancient. [We should get rid of __inline/__const etc IMO].
Sat, Oct 17
The bigger part of !GNUC support is in machine/atomic.h.
Fri, Oct 16
Thu, Oct 15
I think that memory saving is still more important than really minor TLB usage optimization.
Ok, the capsicum argument is convincing enough to not go with /dev/eventfd route. But on the other hand having a single syscall that can also serve timerfd in future would be nice indeed. I do not think that shmfd should be plugged into this case.