Page MenuHomeFreeBSD

kib (Konstantin Belousov)
User

Projects

User Details

User Since
May 16 2014, 7:35 PM (265 w, 3 d)

Recent Activity

Yesterday

kib added a comment to D20636: amd64 pmap: block on turnstile for lock-less DI.
In D20636#446616, @alc wrote:

I would suggest that you add a comment to the code explaining why the callout is necessary.

Mon, Jun 17, 8:10 AM

Sun, Jun 16

kib added inline comments to D18768: Describe FreeBSD's virtual memory in memory(7).
Sun, Jun 16, 12:21 AM
kib added a comment to D20645: add non-blocking variants of rangelock_rlock() and rangelock_wlock().

Feel free to do the rename in the preliminary commit.

Sun, Jun 16, 12:00 AM

Sat, Jun 15

kib added inline comments to D20645: add non-blocking variants of rangelock_rlock() and rangelock_wlock().
Sat, Jun 15, 9:32 PM
D20657: Three enhancements to arm64's pmap_protect() is now accepted and ready to land.
Sat, Jun 15, 9:17 PM

Fri, Jun 14

kib accepted D20632: Restore commentary lost in r349203.
Fri, Jun 14, 1:06 PM
kib created D20636: amd64 pmap: block on turnstile for lock-less DI.
Fri, Jun 14, 12:53 PM

Thu, Jun 13

kib created D20631: Handle errors from timesub()..
Thu, Jun 13, 9:29 PM
kib accepted D20627: Defer updates to the wired pages count in the arm64 pmap.
Thu, Jun 13, 9:46 AM
kib accepted D20628: Use vm_map_entry_t field prev less.
Thu, Jun 13, 9:44 AM

Wed, Jun 12

kib accepted D18880: Extend mmap/mprotect API to specify the max page protections..
Wed, Jun 12, 10:38 PM
kib accepted D20370: Eliminate code duplication around clip_start.
Wed, Jun 12, 8:57 PM
kib added inline comments to D20584: add a linux compatible copy_file_range(2) syscall.
Wed, Jun 12, 8:21 PM
kib accepted D20625: clarify reserv_test_config.
Wed, Jun 12, 7:12 PM
kib added inline comments to D20370: Eliminate code duplication around clip_start.
Wed, Jun 12, 7:07 PM
kib committed rS348991: MFC r347151,347181,347968,348421,348698,348701:.
MFC r347151,347181,347968,348421,348698,348701:
Wed, Jun 12, 11:48 AM
kib committed rS348988: MFC r348360:.
MFC r348360:
Wed, Jun 12, 11:09 AM

Tue, Jun 11

kib added a comment to D20584: add a linux compatible copy_file_range(2) syscall.

Yes, I did understand the comment w.r.t. range_locks. I fixed the rest of the stuff for two vnodes locked
concurrently, but I couldn't see an easy way to do range_locks on both of them without a LOR.
Because of the above and because it allows me to use FIOSEEKHOLE/FIOSEEKDATA, I've changed
the code to call vn_rdwr() with the vnodes unlocked and I just let vn_rdwr() deal with the range_locks, etc.

So you relock range for each chunk ? This defeats the purpose of the range locking. Should copy_file_range() be atomic WRT other reads and writes ?

Tue, Jun 11, 4:36 PM
kib accepted D20594: Avoid overflow in checking the size of free gaps in vm_map_findspace.
Tue, Jun 11, 2:52 PM
kib added a comment to D20594: Avoid overflow in checking the size of free gaps in vm_map_findspace.

Is this a fix for the i386 wrap issue, or just a related change ?

Tue, Jun 11, 10:46 AM
kib committed rS348898: MFC r348816:.
MFC r348816:
Tue, Jun 11, 10:41 AM
kib committed rS348897: MFC r348815:.
MFC r348815:
Tue, Jun 11, 10:04 AM
kib added inline comments to D20584: add a linux compatible copy_file_range(2) syscall.
Tue, Jun 11, 9:55 AM

Mon, Jun 10

kib added inline comments to D18880: Extend mmap/mprotect API to specify the max page protections..
Mon, Jun 10, 8:20 PM
kib added a comment to D18880: Extend mmap/mprotect API to specify the max page protections..

I believe that you should allocate a flag in the feature note and use it to opt-out (or opt-in ?) of max_prot.

Mon, Jun 10, 8:17 PM
kib accepted D20327: Don't reset memory attributes when mapping physical addresses for ACPI..
Mon, Jun 10, 8:07 PM
kib accepted D20592: improve error checking for modifcations to mmap len parameter.
Mon, Jun 10, 7:57 PM
kib added inline comments to D20584: add a linux compatible copy_file_range(2) syscall.
Mon, Jun 10, 6:57 PM
kib committed rS348872: MFC r348541:.
MFC r348541:
Mon, Jun 10, 5:45 PM
kib committed rS348871: MFC r348539:.
MFC r348539:
Mon, Jun 10, 5:43 PM
kib committed rS348870: MFC r348533:.
MFC r348533:
Mon, Jun 10, 5:40 PM
kib committed rS348869: MFC r348536:.
MFC r348536:
Mon, Jun 10, 5:39 PM
kib committed rS348868: MFC r348544:.
MFC r348544:
Mon, Jun 10, 5:36 PM
kib accepted D20585: Various arm64 pmap fixes (and one optimization).
Mon, Jun 10, 12:17 PM
kib added inline comments to D20584: add a linux compatible copy_file_range(2) syscall.
Mon, Jun 10, 8:58 AM
kib added inline comments to D20584: add a linux compatible copy_file_range(2) syscall.
Mon, Jun 10, 8:32 AM

Sun, Jun 9

kib accepted D20580: Make mmap fail when len parameter, round up to page size, becomes zero.
Sun, Jun 9, 8:59 PM
kib added inline comments to D20580: Make mmap fail when len parameter, round up to page size, becomes zero.
Sun, Jun 9, 8:45 PM
kib accepted D19826: reduce accesses to vm_map entries off the search path in updating max_free.
Sun, Jun 9, 10:18 AM

Sat, Jun 8

kib accepted D20561: Avoid locking, manipulating vm_map for bogus address lookup.
Sat, Jun 8, 9:21 PM
kib committed rS348816: Style MAP_ENTRY_ and MAP_ definitions..
Style MAP_ENTRY_ and MAP_ definitions.
Sat, Jun 8, 8:28 PM
kib closed D20560: Style MAP_ENTRY_ and MAP_ definitions..
Sat, Jun 8, 8:28 PM
kib committed rS348815: Correct definition for PGEX_SGX..
Correct definition for PGEX_SGX.
Sat, Jun 8, 8:26 PM
kib updated the diff for D20560: Style MAP_ENTRY_ and MAP_ definitions..

Lowercase comments.

Sat, Jun 8, 8:22 PM
kib committed rS348813: Make trap_msg array constant as well..
Make trap_msg array constant as well.
Sat, Jun 8, 7:51 PM
kib created D20560: Style MAP_ENTRY_ and MAP_ definitions..
Sat, Jun 8, 7:44 PM
kib accepted D20545: Break down swap_pager_swapoff function into small functions..
Sat, Jun 8, 5:41 PM
kib committed rS348802: Remove lazy FPU switch support from amd64..
Remove lazy FPU switch support from amd64.
Sat, Jun 8, 4:03 PM
kib committed rS348799: i386 trap.c: Remove unused MAX_TRAP_MSG define..
i386 trap.c: Remove unused MAX_TRAP_MSG define.
Sat, Jun 8, 1:41 PM
kib committed rS348798: amd64 trap.c: Modernize syntax around trap_msg[]..
amd64 trap.c: Modernize syntax around trap_msg[].
Sat, Jun 8, 1:41 PM
kib accepted D20538: Rethink r348246.
Sat, Jun 8, 11:39 AM

Fri, Jun 7

kib accepted D20538: Rethink r348246.
Fri, Jun 7, 5:40 PM
kib added inline comments to D20390: Show shm_open() and shmget() path/key in procstat -v..
Fri, Jun 7, 10:48 AM
kib committed rS348775: MFC r348476, r348630 (by alc):.
MFC r348476, r348630 (by alc):
Fri, Jun 7, 10:09 AM

Thu, Jun 6

kib accepted D20538: Rethink r348246.
Thu, Jun 6, 6:59 PM
kib accepted D20519: Add a debugging facility to manually reclaim a vnode.
Thu, Jun 6, 2:49 PM
kib added inline comments to D20519: Add a debugging facility to manually reclaim a vnode.
Thu, Jun 6, 2:24 PM
kib accepted D20519: Add a debugging facility to manually reclaim a vnode.

I think this version of code is technically correct. I still would prefer the fd-based sysctl instead.

Thu, Jun 6, 11:00 AM

Wed, Jun 5

kib added inline comments to D20526: Fix a fasttrap race..
Wed, Jun 5, 8:34 PM
kib added inline comments to D20526: Fix a fasttrap race..
Wed, Jun 5, 8:27 PM
kib committed rS348701: In vm_map_entry_set_vnode_text(), tolerate tmpfs mappings for which.
In vm_map_entry_set_vnode_text(), tolerate tmpfs mappings for which
Wed, Jun 5, 8:21 PM
kib committed rS348698: Manually clear text references on reclaim for nullfs and tmpfs..
Manually clear text references on reclaim for nullfs and tmpfs.
Wed, Jun 5, 8:16 PM
kib accepted D20528: nvdimm: Provide nvdimm location information.
Wed, Jun 5, 7:29 PM
kib added inline comments to D20519: Add a debugging facility to manually reclaim a vnode.
Wed, Jun 5, 7:25 PM
kib accepted D20526: Fix a fasttrap race..
Wed, Jun 5, 7:19 PM

Tue, Jun 4

kib added inline comments to D20519: Add a debugging facility to manually reclaim a vnode.
Tue, Jun 4, 10:24 PM
kib added a comment to D20519: Add a debugging facility to manually reclaim a vnode.
In D20519#443196, @kib wrote:

I suspect it could be more useful to pass a file descriptor number to the sysctl, leaving path manipulation to open. E.g., this way it would be possible to hack-reclaim unlinked inodes.

OTOH, taking a file descriptor instead of a pathname means that it wouldn't be able to reclaim inactive vnodes. For my purposes that's more important. For example, I want to be able to reclaim a directory that doesn't currently have any open file descriptors.

Tue, Jun 4, 9:55 PM
kib added a comment to D20519: Add a debugging facility to manually reclaim a vnode.

I suspect it could be more useful to pass a file descriptor number to the sysctl, leaving path manipulation to open. E.g., this way it would be possible to hack-reclaim unlinked inodes.

Tue, Jun 4, 8:49 PM
kib accepted D20514: Export some UMA info via sysctl..
Tue, Jun 4, 4:59 PM
kib added inline comments to D20514: Export some UMA info via sysctl..
Tue, Jun 4, 3:57 PM

Mon, Jun 3

kib accepted D20503: Remove the header comment in vm_page.c..
Mon, Jun 3, 7:21 PM
kib accepted D20505: very large dma mappings can cause integer overflow.
Mon, Jun 3, 5:57 PM
kib accepted D20502: Allocate wired pages in linux_alloc_pages()..
Mon, Jun 3, 4:27 PM
kib accepted D20503: Remove the header comment in vm_page.c..
Mon, Jun 3, 4:24 PM
kib committed rS348544: hwpmc_intel: List all Silvermont ids..
hwpmc_intel: List all Silvermont ids.
Mon, Jun 3, 4:21 PM
kib committed rS348541: efirt efi_enter(): Release acquired locks and restore FPU ownership if.
efirt efi_enter(): Release acquired locks and restore FPU ownership if
Mon, Jun 3, 3:42 PM
kib committed rS348539: amd64 ef_rt_arch_call: Preserve %rflags around call into EFI RT service..
amd64 ef_rt_arch_call: Preserve %rflags around call into EFI RT service.
Mon, Jun 3, 3:32 PM
kib committed rS348536: Remove dead check..
Remove dead check.
Mon, Jun 3, 3:23 PM
kib committed rS348533: Remove dead store..
Remove dead store.
Mon, Jun 3, 3:19 PM
kib committed rS348531: MFC r348306:.
MFC r348306:
Mon, Jun 3, 3:10 PM
kib committed rS348528: Release slavash..
Release slavash.
Mon, Jun 3, 7:58 AM

Sun, Jun 2

kib accepted D20487: add a new -I command line option to mountd which makes it update the kernel exports incrementally upon a reload.
Sun, Jun 2, 12:11 PM
kib committed rS348508: MFC r348433:.
MFC r348433:
Sun, Jun 2, 9:29 AM
kib committed rS348507: MFC r348432:.
MFC r348432:
Sun, Jun 2, 9:28 AM

Sat, Jun 1

kib accepted D20485: Use the vm_page_wired() predicate where appropriate..
Sat, Jun 1, 10:18 PM
kib added a comment to D20485: Use the vm_page_wired() predicate where appropriate..

Could you please update the diff to include the definition if vm_page_wired() ? I expect it to be trivial.

Sat, Jun 1, 5:47 PM
kib accepted D20492: Retire vm_reserv_extend_{contig,page}().
Sat, Jun 1, 5:41 PM
kib accepted D19826: reduce accesses to vm_map entries off the search path in updating max_free.
Sat, Jun 1, 5:40 PM
kib added a comment to D20411: Add devfs(5) support for VOP_MKDIR(9) and VOP_RMDIR(9).

Imagine that there is no pseudo ttys in the system, and user called mkdir('/dev/pts'). Then a new pty pair is created, which makes a device node in /dev/pts. On device destruction, the node is removed, and its contained directory is removed if empty. But '/dev/pts' was created by user, not my makedev(9).

Sat, Jun 1, 3:01 PM
kib added a comment to D20487: add a new -I command line option to mountd which makes it update the kernel exports incrementally upon a reload.

Your follow-up questions definitely show that you want some mountd.conf config file, e.g. to manage -I flag. The file should be re-read on SIGHUP.
I could argue that it is reasonable for mountd.conf to provide all options supplied as command-line arguments to mountd.

Sat, Jun 1, 2:37 PM
kib added inline comments to D20492: Retire vm_reserv_extend_{contig,page}().
Sat, Jun 1, 12:04 PM
kib added inline comments to D20347: efirt: Add efi_memory_attribute.
Sat, Jun 1, 11:47 AM

Fri, May 31

kib committed rS348479: MFC r348246:.
MFC r348246:
Fri, May 31, 7:13 PM
kib committed rS348478: MFC r348258:.
MFC r348258:
Fri, May 31, 7:10 PM
kib committed rS348477: MFC r348257:.
MFC r348257:
Fri, May 31, 7:07 PM
kib accepted D16901: Eliminate some needless attempts to merge buddies.
Fri, May 31, 6:54 PM
kib committed rS348476: Simplify flow of pmap_demote_pde_locked() and add more comprehensive.
Simplify flow of pmap_demote_pde_locked() and add more comprehensive
Fri, May 31, 6:53 PM
kib closed D20266: Simplify flow of pmap_demote_pde_locked() and add more comprehensive debugging checks..
Fri, May 31, 6:53 PM

Thu, May 30

kib accepted D20470: Use vm_page_unwire_noq() instead of vm_page_unwire(PQ_NONE)..
Thu, May 30, 5:27 PM
kib accepted D20469: Remove a redundant vm_page_remove() call..
Thu, May 30, 4:56 PM