Page MenuHomeFreeBSD

kib (Konstantin Belousov)
User

Projects

User Details

User Since
May 16 2014, 7:35 PM (239 w, 4 d)

Recent Activity

Today

kib committed rS342187: MFC r341810:.
MFC r341810:
Tue, Dec 18, 7:11 AM
kib added a comment to D18586: mount(8) does not handle "update" option in the fstab(5) correctly.

So what happen when somebody run 'mount -a' second time, with non-idempotent mount option + update ?

Tue, Dec 18, 5:31 AM

Sun, Dec 16

kib committed rS342149: MFC r341402:.
MFC r341402:
Sun, Dec 16, 2:47 AM
kib committed rS342148: MFC r341400:.
MFC r341400:
Sun, Dec 16, 2:46 AM
kib committed rS342147: MFC r341399:.
MFC r341399:
Sun, Dec 16, 2:45 AM
kib committed rS342146: MFC r341398:.
MFC r341398:
Sun, Dec 16, 2:42 AM
kib committed rS342145: MFC r341746:.
MFC r341746:
Sun, Dec 16, 2:31 AM
kib updated the diff for D5603: ASLR.

Grammar.
Add global restart counter.

Sun, Dec 16, 2:23 AM
kib added inline comments to D5603: ASLR.
Sun, Dec 16, 2:23 AM
kib closed D18568: Document new required MI behaviour of pmap_enter() for CoW..
Sun, Dec 16, 1:52 AM
kib committed rS342144: Document new required MI behaviour of pmap_enter(9) for CoW..
Document new required MI behaviour of pmap_enter(9) for CoW.
Sun, Dec 16, 1:51 AM

Sat, Dec 15

kib added inline comments to D18570: fsck_ffs: make rwerror() report errno..
Sat, Dec 15, 1:32 PM
kib created D18568: Document new required MI behaviour of pmap_enter() for CoW..
Sat, Dec 15, 5:40 AM

Thu, Dec 13

kib accepted D18538: rtld-elf/i386: silence gcc warnings.
Thu, Dec 13, 11:07 PM
kib added a comment to D18538: rtld-elf/i386: silence gcc warnings.

@cem pointed out to me r340842 & r340843. @kib would you prefer we just
did the same to i386 as was done to amd64?

Thu, Dec 13, 6:13 PM

Wed, Dec 12

kib added a comment to D18346: nvdimm: Move ownership of SPA mappings to the NVDIMM root device.
In D18346#394755, @kib wrote:

I do not understand your fixation on the newbus attachment for SPA. Now you are trying to hide it under the root NVDIMM device, but again, I do not see any connection between the root and activation of SPA support. To get SPA used, we only need SPA entries from the NFIT table.

I'm looking for the right place to put the ownership of the SPA_mappings. It seems wrong to have them owned and managed by the geom init function when geom is becoming a separate thing with a separate lifetime that can be destroyed before the SPA_mapping is destroyed. Does that sound like a reasonable motivation, or are you saying that doesn't matter?

In a certain sense, I think the SPA ranges could be considered as resources provided by the NVDIMM root device, specifically when you look at it in connection with the _DSMs the root device provides (sec 9.20.7 in the acpi spec). Though like you say, they're not like SPAs are _CRS resources so I suppose that view isn't inherent in the way things are modeled.

Wed, Dec 12, 1:29 AM
kib added a comment to D18346: nvdimm: Move ownership of SPA mappings to the NVDIMM root device.

I do not understand your fixation on the newbus attachment for SPA. Now you are trying to hide it under the root NVDIMM device, but again, I do not see any connection between the root and activation of SPA support. To get SPA used, we only need SPA entries from the NFIT table.

Wed, Dec 12, 12:54 AM

Tue, Dec 11

kib accepted D18499: Don't register IOCTLs with capsicum when there is no valid file descriptor..
Tue, Dec 11, 9:56 PM
kib added a reviewer for D18499: Don't register IOCTLs with capsicum when there is no valid file descriptor.: oshogbo.
Tue, Dec 11, 9:56 PM
kib committed rS341810: Free bootstacks after AP startup..
Free bootstacks after AP startup.
Tue, Dec 11, 2:54 AM
kib closed D18486: Free bootstacks after AP startup..
Tue, Dec 11, 2:54 AM
kib committed rS341809: Remove special case handling for getfhat(fd, NULL, handle)..
Remove special case handling for getfhat(fd, NULL, handle).
Tue, Dec 11, 2:49 AM
kib closed D18501: fix getfhat bug introduced by D18359.
Tue, Dec 11, 2:49 AM

Mon, Dec 10

kib accepted D18501: fix getfhat bug introduced by D18359.
Mon, Dec 10, 5:25 PM
kib added a comment to D18501: fix getfhat bug introduced by D18359.

I clearly missed this in the original commit. Why do you need this special-case 'dot' behaviour ? Why cannot getfhat() behave same as openat(2) WRT NULL path ?

Mon, Dec 10, 4:15 PM
kib added inline comments to D18450: Implement atomic_swap_xxx() for all platforms.
Mon, Dec 10, 9:40 AM
kib committed rS341779: MFC r341448:.
MFC r341448:
Mon, Dec 10, 1:39 AM
kib committed rS341778: MFC r341447:.
MFC r341447:
Mon, Dec 10, 1:39 AM
kib committed rS341777: MFC r341448:.
MFC r341448:
Mon, Dec 10, 1:03 AM
kib committed rS341776: MFC r341447:.
MFC r341447:
Mon, Dec 10, 1:02 AM
kib committed rS341775: MFC r341439:.
MFC r341439:
Mon, Dec 10, 12:59 AM
kib committed rS341774: MFC r341441:.
MFC r341441:
Mon, Dec 10, 12:58 AM
kib committed rS341773: MFC r341439:.
MFC r341439:
Mon, Dec 10, 12:56 AM
kib committed rS341772: MFC r341441:.
MFC r341441:
Mon, Dec 10, 12:54 AM

Sun, Dec 9

kib accepted D18450: Implement atomic_swap_xxx() for all platforms.

Asm versions of the mips swap() primitives would be less ugly, but I think this can be taken care of by the mips people.

Sun, Dec 9, 5:13 PM
kib accepted D18487: Don't report stale signal information for non-signal events in ptrace_lwpinfo..
Sun, Dec 9, 1:02 AM
kib committed rS341748: MFC r341397:.
MFC r341397:
Sun, Dec 9, 12:45 AM
kib committed rS341747: MFC r341397:.
MFC r341397:
Sun, Dec 9, 12:41 AM

Sat, Dec 8

kib created D18486: Free bootstacks after AP startup..
Sat, Dec 8, 11:28 PM
kib committed rS341746: Fix PAE boot..
Fix PAE boot.
Sat, Dec 8, 10:14 PM
kib committed rS341718: MFC r341375:.
MFC r341375:
Sat, Dec 8, 12:48 AM
kib committed rS341717: MFC r341374:.
MFC r341374:
Sat, Dec 8, 12:47 AM
kib committed rS341716: MFC r341375:.
MFC r341375:
Sat, Dec 8, 12:46 AM
kib committed rS341715: MFC r341374:.
MFC r341374:
Sat, Dec 8, 12:44 AM

Fri, Dec 7

kib committed rS341712: Simplify kern_readlink_vp()..
Simplify kern_readlink_vp().
Fri, Dec 7, 11:08 PM
kib committed rS341711: Fix expression evaluation..
Fix expression evaluation.
Fri, Dec 7, 11:05 PM
kib committed rS341690: Regen..
Regen.
Fri, Dec 7, 3:22 PM
kib committed rS341689: Add new file handle system calls..
Add new file handle system calls.
Fri, Dec 7, 3:18 PM
kib closed D18359: getfhat, fhlink, fhlinkat, fhreadlink: new file handle system calls.
Fri, Dec 7, 3:18 PM · manpages
kib committed rS341688: MFC r340864:.
MFC r340864:
Fri, Dec 7, 2:46 PM
kib committed rS341687: MFC r340858:.
MFC r340858:
Fri, Dec 7, 2:26 PM
kib added inline comments to D18359: getfhat, fhlink, fhlinkat, fhreadlink: new file handle system calls.
Fri, Dec 7, 11:30 AM · manpages
kib committed rS341673: MFC r340860:.
MFC r340860:
Fri, Dec 7, 12:50 AM
kib committed rS341671: MFC r340863:.
MFC r340863:
Fri, Dec 7, 12:39 AM
kib committed rS341670: MFC r340862:.
MFC r340862:
Fri, Dec 7, 12:38 AM
kib committed rS341669: MFC r340863:.
MFC r340863:
Fri, Dec 7, 12:36 AM
kib committed rS341668: MFC r340862:.
MFC r340862:
Fri, Dec 7, 12:33 AM

Thu, Dec 6

kib added inline comments to D18450: Implement atomic_swap_xxx() for all platforms.
Thu, Dec 6, 10:01 PM
kib committed rS341655: Fix build with option RSS, removing unused variables..
Fix build with option RSS, removing unused variables.
Thu, Dec 6, 9:52 PM
kib added inline comments to D18359: getfhat, fhlink, fhlinkat, fhreadlink: new file handle system calls.
Thu, Dec 6, 9:07 PM · manpages
kib committed rS341645: Appease gcc build, remove duplicated declaration..
Appease gcc build, remove duplicated declaration.
Thu, Dec 6, 7:20 PM
kib added inline comments to D18450: Implement atomic_swap_xxx() for all platforms.
Thu, Dec 6, 4:18 PM
kib added inline comments to D18450: Implement atomic_swap_xxx() for all platforms.
Thu, Dec 6, 3:16 PM
kib accepted D18444: const poison the `new` pointer of __sysctl..

If it compiles, fine with me.

Thu, Dec 6, 10:04 AM

Wed, Dec 5

kib added a comment to D18346: nvdimm: Move ownership of SPA mappings to the NVDIMM root device.
In D18346#392735, @kib wrote:

What do we need ? I see that we need a unique unit number (currently punned by reusing the SPA index) and a way to list all SPAs at the unload time, to destruct them. Would be a global list of all SPAs enough for the later ?

That, and then later a per-spa list of namespaces and the corresponding code to handle their discovery/creation/deletion/etc

Wed, Dec 5, 7:50 PM
kib added a comment to D18346: nvdimm: Move ownership of SPA mappings to the NVDIMM root device.
In D18346#392701, @kib wrote:

Why do we need newbus attachment for SPAs ?

For ACPI-enumerated NVDIMMs, creating the devices is more or less natural since they represent physical objects that exist in the chassis. But SPAs are purely software constructs, which newbus devices seems to only tunnel the calls to init_ine()/fini_one().

I created new devices to not need to reinvent lifecycle tracking. While we don't support it yet SPAs can come and go dynamically when dimms are hotplugged. Also in the future SPAs will have namespaces which will be variable in number and can come and go dynamically.

I agree that SPAs aren't really like devices, but more precisely like resources provided by the NVDIMM root device, but they could reasonably proxy some operations to either the nvdimm devices or the nvdimm root device (like writes to flush hint addresses on nvdimms, or provide error information via the root device's address range scrub functionality). Providing some operations from a somewhat virtual SPA or namespace device would let userspace not have to reconstruct which dimms compose a SPA, or what address range of a SPA make up a namespace.

So I think those reasons are compelling, but I can understand that it's a bit weird. If you're not convinced then I can go back to tracking SPAs not as devices, but in that case we will need to implement a fair bit of what bus can already provide us.

Wed, Dec 5, 7:21 PM
kib accepted D18441: Further simplify arguments to init..
Wed, Dec 5, 7:07 PM
kib added a comment to D18346: nvdimm: Move ownership of SPA mappings to the NVDIMM root device.

Why do we need newbus attachment for SPAs ?

Wed, Dec 5, 6:32 PM
kib accepted D15637: Regularize the declaration of the exit syscall..
Wed, Dec 5, 6:15 PM
kib accepted D18410: stat(2): expand list of syscalls that modify st_mtim.
Wed, Dec 5, 5:23 PM
kib accepted D18435: Manage process-related IDs with bitmaps.

I think this can be changed to avoid procid_lock at all.

Wed, Dec 5, 5:19 PM
kib accepted D18431: Remove ifdef BOOTCDROM option to start init..
Wed, Dec 5, 8:57 AM

Tue, Dec 4

kib committed rS341476: MFC r341094:.
MFC r341094:
Tue, Dec 4, 4:55 PM
kib added a comment to D18359: getfhat, fhlink, fhlinkat, fhreadlink: new file handle system calls.

Peter. could you please take the diff and run it through stress2 ?

Tue, Dec 4, 3:45 PM · manpages
kib updated subscribers of D18359: getfhat, fhlink, fhlinkat, fhreadlink: new file handle system calls.
Tue, Dec 4, 3:42 PM · manpages
kib accepted D18359: getfhat, fhlink, fhlinkat, fhreadlink: new file handle system calls.
Tue, Dec 4, 3:42 PM · manpages
kib committed rS341468: MFC r341096:.
MFC r341096:
Tue, Dec 4, 3:06 PM
kib committed rS341466: MFC r341094:.
MFC r341094:
Tue, Dec 4, 3:03 PM
kib accepted D15816: Normalize COMPAT_43 syscall declarations..

declErations, both it the title and in the text.

Tue, Dec 4, 9:07 AM

Mon, Dec 3

kib accepted D15469: Remove a needlessly clever hack to start init with sys_exec()..
Mon, Dec 3, 11:57 PM
kib accepted D18425: Remove MD __sys_* private symbols..

I think that our private export is too large. Ideally it would be trimmed down to the symbols used by libthr.

Mon, Dec 3, 11:54 PM
kib updated the diff for D5603: ASLR.

Disable clustering if map is limited by max_addr.

Mon, Dec 3, 11:54 PM
kib committed rS341448: Print type designator 'D' for the KF_TYPE_DEV files..
Print type designator 'D' for the KF_TYPE_DEV files.
Mon, Dec 3, 11:42 PM
kib committed rS341447: Improve procstat reporting for the linux cdev file descriptors..
Improve procstat reporting for the linux cdev file descriptors.
Mon, Dec 3, 11:42 PM
kib added inline comments to D15469: Remove a needlessly clever hack to start init with sys_exec()..
Mon, Dec 3, 10:58 PM
kib updated the diff for D5603: ASLR.

preserve->gap.
Comment update.

Mon, Dec 3, 9:59 PM
kib accepted D18424: Remove declarations of syscalls not used in libthr..
Mon, Dec 3, 9:48 PM
kib updated the diff for D5603: ASLR.

Reword comments.
Rename variable and symbol.
Remove dup assignment.

Mon, Dec 3, 9:15 PM
kib committed rS341441: Some fixes for LD_BIND_NOW + ifuncs..
Some fixes for LD_BIND_NOW + ifuncs.
Mon, Dec 3, 8:04 PM
kib closed D18400: Some fixes for LD_BIND_NOW + ifuncs..
Mon, Dec 3, 8:04 PM
kib reopened D18400: Some fixes for LD_BIND_NOW + ifuncs..
Mon, Dec 3, 8:01 PM
kib closed D18400: Some fixes for LD_BIND_NOW + ifuncs..
Mon, Dec 3, 7:57 PM
kib committed rS341439: Provide naive but self-contained implementations of memset(3) and.
Provide naive but self-contained implementations of memset(3) and
Mon, Dec 3, 7:57 PM
kib added a comment to D18423: Prototype WITH_PIE knob.

Also, formally architectures can have different -fPIC and -fPIE ABIs, so perhaps we really need libXXX_pie.a, and e.g. libc_pic.a and libc_pie.a simultaneously.

Do you have a reference for this? At least for any architecture relevant to us today I don't think this is a practical case, so perhaps we ought to build _pic.a for PIE use for now, with a comment in bsd.lib.mk?

-fPIE code does not need to redirect all its external symbol accesses through GOT/PLT. This does not matter for x86 at compile time, only at the link time, but it might give an opportunity to optimize for other arches. Also the default TLS model might be different.

Mon, Dec 3, 7:50 PM
kib added inline comments to D18417: Improve R_AARCH64_TLSDESC relocation..
Mon, Dec 3, 6:30 PM
kib added a comment to D18423: Prototype WITH_PIE knob.

Presumably we should build INTERNALLIBs and PRIVATELIBs as both libfoo.a and libfoo_pic.a (or some similar scheme) and choose the appropriate one when linking the binary. I don't know how far down that path we want to go though.

Mon, Dec 3, 6:26 PM
kib added inline comments to D18410: stat(2): expand list of syscalls that modify st_mtim.
Mon, Dec 3, 5:55 PM
kib accepted D18421: Fix memory disclosures from ptrace(PT_GET*REGS)..
Mon, Dec 3, 5:52 PM
kib added inline comments to D18421: Fix memory disclosures from ptrace(PT_GET*REGS)..
Mon, Dec 3, 5:20 PM
kib added inline comments to D18410: stat(2): expand list of syscalls that modify st_mtim.
Mon, Dec 3, 4:21 PM