- User Since
- May 16 2014, 7:35 PM (213 w, 6 d)
As I said I believe it is fine functionally.
This is fine.
It looks fine to me, I will wait some time for John opinion.
Other than two notes I put inline, the patch looks fine to me.
Wed, Jun 20
You can create symbols which are exported but not linkable, since they do not provide a default version. Such symbol can be only created by asm '@' syntax, it should be removed from the version map. Also I do not see a sense in leaving the private symbols around.
This is somewhat orthogonal, but since you are makes the init the proper child of the proc0, shouldn't proc0 get the P_TREE_REAPER flag ? Otherwise, dying init would confuse the reaping code. We do allow init(8) to die sometimes, without inducing the panic.
Tue, Jun 19
This should be fine.
Mon, Jun 18
grep for FOREACH_PROC_IN_SYSTEM() for the start. In fact these places are already visible in the patch because they require allproc_lock.
I was not able to imagine a case which is broken by this simplification. Also, the ptrace_test works with the patch.
Sat, Jun 16
Right now I think that this is working approach.
Please generate large diff context when you upload diff into phab, e.g. for svn it would be svn diff -x -U999999, for git diff -U999999.
Fri, Jun 15
Tinderbox and installworld tests passed with WITH_OFED=yes. I think that the patch is ready to go.
Remove SYSPROTO for them all, instead of patching ? It is not useful for current syscalls, and obviously even less so for compat.
I believe that stubs which return ENOSYS are fine, without redirecting to the syscalls. More, the stubs do not need to provide the default version, so that linking with the symbols will be impossible any more.
Thu, Jun 14
Fix libpcap dependency on libmlx5
Code makes consistent early processes start time vs rusage.
Add optional start:count for pciconf -D.
Update pciio(4) and pciconf(8) man pages.
Wed, Jun 13
Peter, could you, please, test this patch ? I do not think that it is feasible to try to reproduce the original problem, but the generic testing would be useful.
Remove use of vm_page_next(). Add comment.
Tue, Jun 12
Fixed bug with the iteration without lock. Implement other suggestions too.
Swap the patch for the swap_pager.c patch.
I suspect it might be useful to get an ack from the interrupt thread that it sees the IH_SUSP flag, so that device power down does not occur while the handler still run ?
I do not have any important notes about this change except the error code when raced.
Mon, Jun 11
The change tightly alias the worker wakeup to the period ticks. It might result at least in the cosmetics issues with the load average.