- User Since
- May 16 2014, 7:35 PM (179 w, 1 d)
Fri, Oct 20
This looks mostly fine, but is not committable because AT_HWCAP2 is not defined.
Thu, Oct 19
I agree that the change is functionally correct, but perhaps the intent was to coalesce the invalidations ? I.e. either pmap_remove_l3() should stop doing the invalidation, or its variant is added which does not do the invalidation and used there.
Wed, Oct 18
Perhaps split addition of AT_HWCAP2 and libc export commits.
libpmcstat.c must be split into per-function .c file. Also, I strongly suggest to mark the library as internal, since we cannot maintain PMC ABI even for a few weeks.
Tue, Oct 17
Stop incrementing uio_offset.
Change a condition into the assert. Add terminating dots into the comments.
Mon, Oct 16
Sun, Oct 15
Update the patch to the current set of the bug fixed.
Sat, Oct 14
Fri, Oct 13
Remove empty line.
Do not ever return from NO_SWAPPING swapper().
Is there a single IAPDESCR in your patch which contains only one of two flags IAP_F_SL and IAP_F_KL ? I mean that SDM lists desktop Skylake and Kabylake core events in the same table.
Wed, Oct 11
Mon, Oct 9
Sun, Oct 8
Sat, Oct 7
Fri, Oct 6
I am fine with the libc bits of the patch.
Can you put the readelf -a output from the patched libc somewhere ?
Thu, Oct 5
Wed, Oct 4
Tue, Oct 3
Mon, Oct 2
Sun, Oct 1
Note that in the current newbus locking model, DETACH_BEGIN and DETACH_COMPLETE/FAILED sequence of event handler invocation might interweave with other attach/detach events arbitrary. The handlers should be prepared for such situations.