♟ kib

In D11435#249799, @alc wrote:

By the way, once upon a time, you asked me about whether we should continue using the blist allocator for swap space or switch to vmem. Perhaps the most compelling reason, which I failed to give at the time, is that every allocated range from an arena consumes a boundary tag. In other words, while vmem coalesces free ranges, it maintains a boundary tag for each allocated range.

Ok.

Edit comments, use consistent loop iteration construct.

In D11866#249639, @emaste wrote:

However, we can't call DROP/PICKUP because they have to be in the same block.

I don't follow what you mean here.

Typo, the '-6' option selects inet6.

You may want to take a look at lib/libc/arm/sys/__vdso_gettc.c and at least use proper asm if possible, instead of the hardcoded instruction byte encoding, if possible after the patch.

Print whole machine state on double fault.

Add {rd,wr}{fs,gs}base C wrappers for instructions.

Remove confusion in the line explaining syntax of the msr read.

Fix a regression in r321608.

Improve standard compliance for memset_s() and abort_handler_s().

I think that the explanation from the revision' description should be added as a comment.

Fix logic error in the the assert, causing the condition to be always true.

I see this was already committed.

Avoid DI recursion when reclaim_pv_chunk() is called from

Explain why delayed invalidation is not required in pmap_protect() and

Remove trivial comments. Remove and-ing with UINT_MAX for minor(),

Provide more detailed specification for major(), minor() and makedev().

Fix off by one in calculation of the number of buckets for the pc

In D11826#245564, @trasz wrote:

If your init is broken, your theoretical wrapper would probably be broken in the exact same way. It's just another moving part that can cause problems. Moving it into the kernel, on the other hand, is intuitive to the user.

Relax visibility for some termios symbols.

I am fine with the move of all aio-related sysctls.

In D11826#245481, @trasz wrote:

I agree that a separate application would be more elegant. However, it would make it more complicated from the user point of view - the approach I took doesn't require the user to learn anything new; the init_path option existed since forever, and there are no special userspace tools to remember about. Also, we kind of already have that: it should be possible to get init(8) to do exactly that, although I don't exactly know how.

Get init to do what ?

I would suggest a different approach for this, since ability to run a shell without configuring tty port in init in single-user mode is sometimes useful. Create a program which opens /dev/console for fds 0,1,2 and execs /bin/sh or whatever specified by some kenv var.

For makedev(), cast the minor argument to unsigned type explicitely,

Change major()/minor() to work with 64bit dev_t.

Do not call trapsignal() after handling usermode fault or interrupt,

Rearrange loops. Update comment.

IMO this is an overreaction. For non-buggy CPUs, I do not see why do you want this.

In D11435#243818, @alc wrote:

Yes, let's try this patched version on a swap-intensive workload.

Please do not consider my note below as an objection against the patch, rather it is a generic question. As a side effect, it might affect the patch.

kib (Konstantin Belousov)
User

Projects

User Details

Recent Activity
View All

Yesterday

Wed, Aug 16

Tue, Aug 15

Mon, Aug 14

Sun, Aug 13

Sat, Aug 12

Fri, Aug 11

Thu, Aug 10

Wed, Aug 9

Tue, Aug 8

Mon, Aug 7

Sun, Aug 6

Sat, Aug 5

Fri, Aug 4

Thu, Aug 3

Wed, Aug 2

Tue, Aug 1

Mon, Jul 31

kib (Konstantin Belousov)User