- User Since
- May 16 2014, 7:35 PM (231 w, 3 d)
We can try to approximately calculate this information, but it is not reliable even on x86. For instance, we get a nonsensical error code for spurious page faults. But still, translating the bits from x86 exceptional error code into some additional information to vm_fault() is easy.
Sun, Oct 21
This looks like a hack, and deserves a comment at least, if applied.
Can you use --shortstat instead of parsing sha's ?
Looks fine from PoV of libc integration. I did not looked at the algorithms.
Sat, Oct 20
Reword man pages changes.
Patch all manpages.
So both you and mjg mentioned that there are a lot of consumers which do not check the result from release_if_not_last. How is it handled ?
Fri, Oct 19
Disallow absolute paths for BENEATH.
Remove no longer needed addition of timo argument to vm_wait().
Thu, Oct 18
Wnere is the 'P' constraint documented ? I see that in gcc 8 manual, 'P' is listed and machine-specific constraint, but x86 section does not mention it.
I do not believe that volatile makes such guarantees. I think that gcc and clang only do not allow the accesses to vanish, i.e. to optimize them based on cached values. But the load/inc/store code generation is legal for volatile x++;. In fact, the standard states that the value in the externally visible storage must be correct on the sequence point, thats all.
See the handling of amd64 pcb_flags where we do care about the interrupt safety of the value and use inline assembly instead of relying on the code generation.
Can we drop the operation, leaving the kernel structures in consistent state ?
Can you extract the helpers functions into separate review ?
Again, please upoad the context.
After some investigation, I see that crtbegin/crtend.o are shipped with compilers, at least it does with gcc. So I do not see a reason to provide the .ctor fallback for e.g. amd64 or i386: in-tree compiler does not need it, and out-of-tree gcc should cope on its own.
Can you reupload the diff with full context ?
I definitely agree with the genoffset.sh changes.
Wed, Oct 17
This was one of my questions. But, it is not clear to me what change, if any, you are proposing.
Tue, Oct 16
Mon, Oct 15
Simplify retry case as suggested.
Sun, Oct 14
You probably need to add the workaround to Makefile.inc1.
So we apparently have Y2K bug ?
Sat, Oct 13
Wording for stat(2).
Reword O_BENEATH explanation.
I accept absolute paths for O_BENEATH. This can be tweaked, I am not sure what is the useful approach there.
Commit _retval() change now, I agree with it.
Commit candidate, passed tinderbox.
I think that all hand-rolled string->number conversions in this file should check for overflow. Otherwise we call for undefined behavior and allow compiler authors to bully us.
Fri, Oct 12
Add suppression for !x86 arches.