Page MenuHomeFreeBSD

alc (Alan Cox)
User

Projects

User Details

User Since
Dec 14 2014, 5:52 AM (319 w, 17 h)

Recent Activity

Thu, Jan 21

alc added inline comments to D28219: Restrict supported alignment for malloc_domainset_aligned(9) to PAGE_SIZE..
Thu, Jan 21, 7:13 PM
alc accepted D28219: Restrict supported alignment for malloc_domainset_aligned(9) to PAGE_SIZE..
Thu, Jan 21, 7:08 PM
alc added inline comments to D28219: Restrict supported alignment for malloc_domainset_aligned(9) to PAGE_SIZE..
Thu, Jan 21, 7:45 AM

Wed, Jan 20

alc added inline comments to D28219: Restrict supported alignment for malloc_domainset_aligned(9) to PAGE_SIZE..
Wed, Jan 20, 8:10 AM
alc accepted D28219: Restrict supported alignment for malloc_domainset_aligned(9) to PAGE_SIZE..
Wed, Jan 20, 2:54 AM

Tue, Jan 19

alc accepted D28225: Set VM_KMEM_SIZE_SCALE to 1 on riscv and arm64.
Tue, Jan 19, 6:54 AM

Mon, Jan 18

alc added inline comments to D28219: Restrict supported alignment for malloc_domainset_aligned(9) to PAGE_SIZE..
Mon, Jan 18, 11:10 PM
alc accepted D28225: Set VM_KMEM_SIZE_SCALE to 1 on riscv and arm64.

Similarly, there is no reason to define VM_KMEM_SIZE_MIN.

Mon, Jan 18, 11:00 PM
alc accepted D28219: Restrict supported alignment for malloc_domainset_aligned(9) to PAGE_SIZE..
Mon, Jan 18, 10:26 PM

Fri, Jan 15

alc added a comment to D27956: amd64 pmap: do not sleep in _pmap_allocpte() with zero referenced page table page..
In D27956#627791, @kib wrote:

Do riscv or arm64 have the same bug?

No, this bug was introduced with LA57 rewrite of pmap_allocpte(). riscv and arm64 forked pmap.c before LA57.

Fri, Jan 15, 8:07 PM

Thu, Jan 14

alc added inline comments to D28117: vm_map_protect: allow to set prot and max_prot in one go..
Thu, Jan 14, 7:54 AM

Wed, Jan 13

alc added inline comments to D28117: vm_map_protect: allow to set prot and max_prot in one go..
Wed, Jan 13, 2:16 AM

Tue, Jan 12

alc added inline comments to D28050: Implement enforcing write XOR execute mapping policy..
Tue, Jan 12, 8:17 AM

Mon, Jan 11

alc accepted D28102: amd64: compare TLB shootdown target to all_cpus.
Mon, Jan 11, 10:13 PM

Sun, Jan 10

alc committed R10:5a181b8bce99: Prefer the use of vm_page_domain() to vm_phys_domain(). (authored by alc).
Prefer the use of vm_page_domain() to vm_phys_domain().
Sun, Jan 10, 7:29 PM
alc closed D28005: Prefer the use of vm_page_domain() to vm_phys_domain().
Sun, Jan 10, 7:29 PM

Sat, Jan 9

alc accepted D25815: amd64 pmap: add comment explaining TLB invalidation modes..
Sat, Jan 9, 11:56 PM
alc added inline comments to D25815: amd64 pmap: add comment explaining TLB invalidation modes..
Sat, Jan 9, 11:36 PM
alc added inline comments to D25815: amd64 pmap: add comment explaining TLB invalidation modes..
Sat, Jan 9, 11:28 PM
alc added inline comments to D25815: amd64 pmap: add comment explaining TLB invalidation modes..
Sat, Jan 9, 8:48 PM
alc added inline comments to D25815: amd64 pmap: add comment explaining TLB invalidation modes..
Sat, Jan 9, 7:55 PM

Wed, Jan 6

alc requested review of D28005: Prefer the use of vm_page_domain() to vm_phys_domain().
Wed, Jan 6, 7:10 PM
alc added a comment to D25815: amd64 pmap: add comment explaining TLB invalidation modes..

That's all that I have.

Wed, Jan 6, 6:40 PM

Tue, Jan 5

alc added inline comments to D25815: amd64 pmap: add comment explaining TLB invalidation modes..
Tue, Jan 5, 7:32 PM

Mon, Jan 4

alc added inline comments to D27956: amd64 pmap: do not sleep in _pmap_allocpte() with zero referenced page table page..
Mon, Jan 4, 11:57 PM
alc committed R10:7beeacb27b27: Honor the vm page's PG_NODUMP flag on arm and i386. (authored by alc).
Honor the vm page's PG_NODUMP flag on arm and i386.
Mon, Jan 4, 10:17 PM
alc closed D27949: Honor the PG_NODUMP flag in is_dumpable() on arm and i386.
Mon, Jan 4, 10:17 PM
alc requested review of D27949: Honor the PG_NODUMP flag in is_dumpable() on arm and i386.
Mon, Jan 4, 7:34 AM

Sat, Jan 2

alc accepted D27885: uma: Avoid unmapping ranges in the direct map.
Sat, Jan 2, 1:42 AM

Fri, Jan 1

alc accepted D27885: uma: Avoid unmapping ranges in the direct map.
Fri, Jan 1, 11:17 PM

Dec 17 2020

alc accepted D27607: Fix some errors in the page busying code.
Dec 17 2020, 7:21 PM

Dec 14 2020

alc accepted D27588: amd64 pmap: fix pcid invalidations.
Dec 14 2020, 10:20 PM
alc accepted D27588: amd64 pmap: fix pcid invalidations.

I have nothing more to add. Once you've dealt with Mark's latest comment, commit it. I don't see the need for me to look at this change again.

Dec 14 2020, 8:03 PM

Dec 13 2020

alc added inline comments to D27588: amd64 pmap: fix pcid invalidations.
Dec 13 2020, 9:22 PM
alc added inline comments to D27588: amd64 pmap: fix pcid invalidations.
Dec 13 2020, 8:14 PM
alc committed R9:a9e040146ef6: Oops. Add the semicolon that was missing from the (one) entry (authored by alc).
Oops. Add the semicolon that was missing from the (one) entry
Dec 13 2020, 7:55 PM
alc committed R9:071d5b732853: Finally, ... add myself to handbook. (The old handbook was frozen (authored by alc).
Finally, ... add myself to handbook. (The old handbook was frozen
Dec 13 2020, 7:55 PM
alc committed R9:5c13ddd0f846: The conversion of vm_map's lockmgr()-based locks from a shared/exclusive (authored by alc).
The conversion of vm_map's lockmgr()-based locks from a shared/exclusive
Dec 13 2020, 7:23 PM

Dec 12 2020

alc added inline comments to D27588: amd64 pmap: fix pcid invalidations.
Dec 12 2020, 10:58 PM
alc added inline comments to D27588: amd64 pmap: fix pcid invalidations.
Dec 12 2020, 9:01 PM

Dec 2 2020

alc accepted D27082: minidumps: Always use 64-bit physical addresses for dump_avail[].
Dec 2 2020, 6:40 PM

Dec 1 2020

alc added a comment to D27368: Bump MAXMEMDOM value to 8 to match amd64.

I'd be interested in seeing the output of sysctl vm.phys_segs on one of these machines. Can you post it here?

Dec 1 2020, 8:18 PM
alc added inline comments to D27082: minidumps: Always use 64-bit physical addresses for dump_avail[].
Dec 1 2020, 7:52 PM

Nov 29 2020

alc accepted D27409: bio aio: Destroy ephemeral mapping before unwiring page..
Nov 29 2020, 12:03 AM

Nov 28 2020

alc added inline comments to D27225: Make MAXPHYS tunable..
Nov 28 2020, 8:06 PM

Nov 19 2020

alc accepted D27207: vm_phys: Try to clean up NUMA KPIs.
Nov 19 2020, 12:24 AM
alc added inline comments to D27207: vm_phys: Try to clean up NUMA KPIs.
Nov 19 2020, 12:18 AM
alc added inline comments to D27207: vm_phys: Try to clean up NUMA KPIs.
Nov 19 2020, 12:03 AM

Nov 13 2020

alc added a comment to D27207: vm_phys: Try to clean up NUMA KPIs.

I ran into a similar problem with respect to vm_phys_segs[] in eliminating iteration from the vm_dumpset operations. I wonder if we shouldn't separate the struct vm_phys_seg and array declarations into their own separate header file that is included by vm_param.h. Then, vm_page.h could implement vm_page_domain().

Nov 13 2020, 6:53 PM

Nov 8 2020

alc added a comment to D25815: amd64 pmap: add comment explaining TLB invalidation modes..

Here is my first batch of comments.

Nov 8 2020, 8:26 PM

Nov 3 2020

alc accepted D27057: vmspace: Convert to refcount(9).
Nov 3 2020, 6:02 PM

Nov 2 2020

alc closed D27052: Tidy up the #includes in uma_machdep.c.
Nov 2 2020, 7:20 PM
alc committed rS367281: Tidy up the #includes. Recent changes, such as the introduction of.
Tidy up the #includes. Recent changes, such as the introduction of
Nov 2 2020, 7:20 PM
alc requested review of D27052: Tidy up the #includes in uma_machdep.c.
Nov 2 2020, 8:33 AM

Oct 27 2020

alc closed D26908: mmap(2): Clarify that guard is taken from the stack region..
Oct 27 2020, 6:09 PM
alc committed rS367087: Revise the description of MAP_STACK. In particular, describe the guard.
Revise the description of MAP_STACK. In particular, describe the guard
Oct 27 2020, 6:09 PM
alc added inline comments to D26908: mmap(2): Clarify that guard is taken from the stack region..
Oct 27 2020, 5:40 PM

Oct 26 2020

alc added inline comments to D26910: Make pmap_invalidate_ept() wait synchronously for guest exits.
Oct 26 2020, 6:48 PM
alc updated the diff for D26908: mmap(2): Clarify that guard is taken from the stack region..
Oct 26 2020, 4:52 AM
alc commandeered D26908: mmap(2): Clarify that guard is taken from the stack region..
Oct 26 2020, 4:51 AM

Oct 25 2020

alc added a comment to D26908: mmap(2): Clarify that guard is taken from the stack region..

After mulling this over for the past day or so, I'd like to propose the following alternative description:

Oct 25 2020, 12:06 AM

Oct 23 2020

alc added a comment to D26923: vm_map: Add fences around pmap rundown.

I'm afraid that I can't make sense out of the summary. Is this a problem with the KASSERT that precedes the pmap lock acquire in arm64's pmap_remove_pages()? Omce pmap_remove_pages() has performed the lock acquire, prior changes to the pmap should be visible to it.

Oct 23 2020, 10:46 PM
alc added inline comments to D26908: mmap(2): Clarify that guard is taken from the stack region..
Oct 23 2020, 5:29 PM
alc closed D26907: Conditionally compile struct vm_phys_seg's md_first field.
Oct 23 2020, 6:25 AM
alc committed rS366960: Conditionally compile struct vm_phys_seg's md_first field. This field is.
Conditionally compile struct vm_phys_seg's md_first field. This field is
Oct 23 2020, 6:25 AM

Oct 22 2020

alc added inline comments to D26894: mmap(2): Document guard size and related EINVAL..
Oct 22 2020, 6:16 PM
alc requested review of D26907: Conditionally compile struct vm_phys_seg's md_first field.
Oct 22 2020, 5:59 PM
alc closed D26876: Micro-optimize arm64's uma_small_alloc().
Oct 22 2020, 5:48 PM
alc committed rS366944: Micro-optimize uma_small_alloc(). Replace bzero(..., PAGE_SIZE) by.
Micro-optimize uma_small_alloc(). Replace bzero(..., PAGE_SIZE) by
Oct 22 2020, 5:48 PM

Oct 20 2020

alc added a comment to D26876: Micro-optimize arm64's uma_small_alloc().

Most other implementations also use bzero(), though on them pagezero() is nothing more than bzero(va, PAGE_SIZE) anyway.

Oct 20 2020, 2:54 AM

Oct 19 2020

alc requested review of D26876: Micro-optimize arm64's uma_small_alloc().
Oct 19 2020, 11:38 PM

Oct 17 2020

alc accepted D26802: link_elf_obj: Colour VM objects.

A while back, Intel quietly made it possible to measure address translation overhead for instruction accesses. I say, "quietly," because the manual provides a low-level description of the counter that doesn't really explain what it effectively measures. However, some Intel people gave a presentation at an HPC workshop about 2 years ago that explained the counter's meaning, and Intel published those slides here: https://software.intel.com/content/www/us/en/develop/download/how-top-down-microarchitecture-analysis-tma-addresses-challenges-in-modern-servers.html

Oct 17 2020, 7:04 PM

Oct 16 2020

alc accepted D26772: uma: Respect uk_reserve in keg_drain().
Oct 16 2020, 9:09 PM
alc added a comment to D26772: uma: Respect uk_reserve in keg_drain().

By the way, in case you are going to use the summary in the commit message, "reclamining" is misspelled.

Oct 16 2020, 6:39 PM
alc added inline comments to D26772: uma: Respect uk_reserve in keg_drain().
Oct 16 2020, 6:36 PM

Oct 15 2020

alc accepted D26770: vmem: Allocate btags before looping in vmem_xalloc().
Oct 15 2020, 8:48 AM

Oct 14 2020

alc accepted D26741: Avoid dump_avail[] redefinition..
Oct 14 2020, 5:23 PM
alc accepted D26769: vmem: Simplify bt_fill() callers a bit.
Oct 14 2020, 4:36 PM
alc added inline comments to D26741: Avoid dump_avail[] redefinition..
Oct 14 2020, 8:48 AM
alc added inline comments to D26769: vmem: Simplify bt_fill() callers a bit.
Oct 14 2020, 3:38 AM
alc added inline comments to D26769: vmem: Simplify bt_fill() callers a bit.
Oct 14 2020, 12:24 AM

Oct 13 2020

alc added inline comments to D26769: vmem: Simplify bt_fill() callers a bit.
Oct 13 2020, 11:13 PM

Oct 12 2020

alc added a comment to D26741: Avoid dump_avail[] redefinition..

Alternatively, move this code to a different header file. None of the new dump-related code uses struct vm_page.

Oct 12 2020, 4:52 PM
alc added inline comments to D26741: Avoid dump_avail[] redefinition..
Oct 12 2020, 4:34 PM

Oct 1 2020

alc added inline comments to D26610: vm_pageout: Avoid rounding down the inactive scan target.
Oct 1 2020, 5:22 PM

Sep 29 2020

alc accepted D26589: Simplify check for non-dumpable objects.
Sep 29 2020, 6:44 PM

Sep 23 2020

alc accepted D26467: Enable largepage support for arm64..
Sep 23 2020, 2:53 AM

Sep 22 2020

alc accepted D26513: amd64 pmap: More unification for psind = 1 vs 2 in pmap_enter_largepage()..

Is it documented anywhere what can versus can't be done to a non-transparent mapping?

Sep 22 2020, 10:50 PM
alc accepted D26466: Add largepage support to the arm64 pmap..
Sep 22 2020, 6:50 PM
alc added inline comments to D26513: amd64 pmap: More unification for psind = 1 vs 2 in pmap_enter_largepage()..
Sep 22 2020, 6:34 PM

Sep 21 2020

alc accepted D26510: Weaken assertions in pmap_l1_to_l2() and pmap_l2_to_l3()..
Sep 21 2020, 9:34 PM
alc added inline comments to D26513: amd64 pmap: More unification for psind = 1 vs 2 in pmap_enter_largepage()..
Sep 21 2020, 6:38 PM
alc added a comment to D26510: Weaken assertions in pmap_l1_to_l2() and pmap_l2_to_l3()..

I'd suggest that you add a comment explaining why the assertion has to be written this way.

Sep 21 2020, 5:43 PM
alc accepted D26499: amd64 pmap: only calculate page table page when needed..
Sep 21 2020, 1:32 AM

Sep 20 2020

alc added inline comments to D26466: Add largepage support to the arm64 pmap..
Sep 20 2020, 10:23 PM
alc accepted D26492: amd64 pmap: handle cases where pml4 page table page is not allocated..
Sep 20 2020, 5:30 PM
alc added inline comments to D26463: Fix some nits in 1G page handling..
Sep 20 2020, 12:57 AM
alc added inline comments to D26466: Add largepage support to the arm64 pmap..
Sep 20 2020, 12:56 AM
alc added inline comments to D26463: Fix some nits in 1G page handling..
Sep 20 2020, 12:51 AM

Sep 19 2020

alc added inline comments to D26466: Add largepage support to the arm64 pmap..
Sep 19 2020, 10:11 PM