Page MenuHomeFreeBSD
Differential D50263

vm_page: cleanup
ClosedPublic
Actions

Authored by dougm on May 9 2025, 3:29 AM.
Tags
None
Referenced Files
F123254195: D50263.diff
Sat, Jul 12, 6:39 PM
Unknown Object (File)
Sun, Jul 6, 4:32 AM
Unknown Object (File)
Sat, Jul 5, 3:16 PM
Unknown Object (File)
Sat, Jul 5, 6:32 AM
Unknown Object (File)
Thu, Jul 3, 7:52 PM
Unknown Object (File)
Wed, Jun 25, 3:19 PM
Unknown Object (File)
Mon, Jun 23, 7:51 AM
Unknown Object (File)
Sun, Jun 22, 9:22 AM
View All 29 Files
Subscribers
alc
imp

Details

Reviewers
alc
markj
kib
Commits
rG3fe2f81f665b: vm_page: reduce iter_reset calls in alloc_domain_iter
rG349340c8cd5c: vm_page: use vm_page_alloc_fail consistently
rGefde1e2c8b76: vm_page: remove unneeded use of mpred
rG7c9fe7a7925b: vm_page: remove obsolete page alloc loops
rGca18e0441029: vm_page: update some iterator-related comments
Summary

Reaction to @alc comments on D50253.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dougm requested review of this revision.May 9 2025, 3:29 AM
dougm created this revision.
markj added inline comments.May 11 2025, 4:16 PM
sys/vm/vm_page.c
2360

Every other block of conditionally compiled code guarded by VM_NRESERVLEVEL > 0 uses a preprocessor check, so I'd rather keep things consistent here even though it's equivalent.

2369
dougm updated this revision to Diff 155352.May 12 2025, 8:09 PM
dougm marked 2 inline comments as done.
kib accepted this revision.May 13 2025, 12:51 AM
kib added inline comments.
sys/vm/vm_page.c
2145
This revision is now accepted and ready to land.May 13 2025, 12:51 AM
markj accepted this revision.May 15 2025, 6:59 PM
alc accepted this revision.May 16 2025, 7:32 AM
Closed by commit rGca18e0441029: vm_page: update some iterator-related comments (authored by dougm). · Explain WhyMay 16 2025, 8:20 AM
This revision was automatically updated to reflect the committed changes.
dougm marked an inline comment as done.
dougm added a commit: rGca18e0441029: vm_page: update some iterator-related comments.
Herald added a subscriber: imp. · View Herald TranscriptMay 16 2025, 8:20 AM
dougm added a commit: rG7c9fe7a7925b: vm_page: remove obsolete page alloc loops.May 16 2025, 8:20 AM
dougm added a commit: rGefde1e2c8b76: vm_page: remove unneeded use of mpred.
dougm added a commit: rG349340c8cd5c: vm_page: use vm_page_alloc_fail consistently.
dougm added a commit: rG3fe2f81f665b: vm_page: reduce iter_reset calls in alloc_domain_iter.

Revision Contents
Changeset List

PathSize
sys/
vm/
7 lines

Diff 155547

View Options

sys/vm/vm_page.c

Loading...