Page MenuHomeFreeBSD

dougm (Doug Moore)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 30 2017, 3:18 PM (112 w, 3 h)

Tauist. Bit twiddler. Advocate for continued logarithms.

Recent Activity

Today

dougm updated the summary of D20814: Make entry simplification one-way.
Fri, Aug 23, 3:20 AM
dougm updated the test plan for D20814: Make entry simplification one-way.
Fri, Aug 23, 3:14 AM

Yesterday

dougm added a comment to D21372: Do not clear page flags in vm_page_pqbatch_submit()..

All existing callers guarantee that the page does not have a pre-existing dequeue pending.

Can you add a KASSERT to express that in the callee?

Thu, Aug 22, 8:37 PM

Wed, Aug 21

dougm added a comment to D20814: Make entry simplification one-way.

Apply reviewer directives.

Wed, Aug 21, 4:27 PM

Tue, Aug 20

D21343: Avoid requeuing active pages in vm_swapout_object_deactivate_pages(). is now accepted and ready to land.

Seems plausible.

Tue, Aug 20, 4:12 PM

Sat, Aug 17

dougm added a comment to D20814: Make entry simplification one-way.

Simplify the patch.

Sat, Aug 17, 7:20 PM
dougm added a comment to D20814: Make entry simplification one-way.

Apply reviewer suggestions.

Sat, Aug 17, 5:39 PM

Fri, Aug 16

dougm committed rS351150: MFC r348968:.
MFC r348968:
Fri, Aug 16, 9:54 PM
dougm committed rS351148: MFC r348881:.
MFC r348881:
Fri, Aug 16, 9:36 PM
dougm added a comment to D20814: Make entry simplification one-way.

Ready for review....

Fri, Aug 16, 6:53 PM

Thu, Aug 15

dougm committed rS351064: swap_pager.c reserves 2 blocks for a bsd label. Change that 2 to the.
swap_pager.c reserves 2 blocks for a bsd label. Change that 2 to the
Thu, Aug 15, 2:31 AM
Herald added a reviewer for D21191: Don't trim bsd_label: manpages.
Thu, Aug 15, 2:31 AM

Wed, Aug 14

D21191: Don't trim bsd_label now requires review to proceed.

.Dq late

Wed, Aug 14, 5:03 PM
dougm added a comment to D21191: Don't trim bsd_label.

line wrap.

Wed, Aug 14, 4:31 PM
dougm updated the diff for D21191: Don't trim bsd_label.
Wed, Aug 14, 4:17 PM
D21191: Don't trim bsd_label now requires review to proceed.

Apply alc comments.

Wed, Aug 14, 4:07 PM

Fri, Aug 9

dougm added a comment to D21191: Don't trim bsd_label.

Use howmany in one more place.

Fri, Aug 9, 4:32 AM
dougm added a comment to D21191: Don't trim bsd_label.

Apply reviewer suggestions.

Fri, Aug 9, 3:00 AM

Thu, Aug 8

D21191: Don't trim bsd_label now requires review to proceed.

Make associated manpage fixes, including a clumsy attempt to address a savecore issue.

Thu, Aug 8, 9:37 PM
dougm updated the diff for D21191: Don't trim bsd_label.
Thu, Aug 8, 8:41 PM
dougm retitled D21191: Don't trim bsd_label from name bsd_label_size, and don't trim bsd_label to Don't trim bsd_label.
Thu, Aug 8, 8:41 PM
dougm created D21191: Don't trim bsd_label.
Thu, Aug 8, 5:05 PM

Tue, Aug 6

dougm added a comment to D20863: prototype for trimming.

Without changing the behavior of this patch, add a SW_TRIM flag and a priority field to swdevt. Pass those from sys_swapon to kern_swapon (which does the work formerly done by sys_swapon) to swaponsomething, which creates the swap object.

Tue, Aug 6, 6:10 AM
dougm added a comment to D20863: prototype for trimming.

Without changing the behavior of this patch, add a SW_TRIM flag and a priority field to swdevt. Pass those from sys_swapon to kern_swapon (which does the work formerly done by sys_swapon) to swaponsomething, which creates the swap object.

Tue, Aug 6, 5:18 AM

Sat, Aug 3

dougm added a comment to D20863: prototype for trimming.

Update log messages to distinguish cases where trimming is aborted before it gets started. Currently, a stretch of log entries like:

Sat, Aug 3, 3:06 AM

Thu, Aug 1

dougm committed rS350495: MFC r350183, r350359.
MFC r350183, r350359
Thu, Aug 1, 5:30 AM

Wed, Jul 31

dougm added a comment to D20814: Make entry simplification one-way.

Fix function naming mismatches in KASSERTS. In wire/unwire, make sure to clip after first entry found in transition.

Wed, Jul 31, 9:37 PM
dougm added a comment to D20814: Make entry simplification one-way.

Don't unlock on early exit from map_wire_locked.

Wed, Jul 31, 2:58 PM
dougm updated the summary of D20814: Make entry simplification one-way.
Wed, Jul 31, 5:17 AM
dougm added a comment to D20814: Make entry simplification one-way.

Get rid of the remaining uses of vm_map_simplify_entry.

Wed, Jul 31, 5:16 AM

Mon, Jul 29

dougm created D21098: Try reusing about-to-be-freed memory in swap_pager_reserve when desperate.
Mon, Jul 29, 3:13 AM

Sun, Jul 28

dougm added a comment to D20863: prototype for trimming.

Update after checking in overlapping changes.

Sun, Jul 28, 7:39 PM
dougm committed rS350392: In swap_pager_putpages, move the initialization of a free-blocks.
In swap_pager_putpages, move the initialization of a free-blocks
Sun, Jul 28, 7:32 PM
dougm closed D21093: tidy up swap_pager_putpages.
Sun, Jul 28, 7:32 PM
dougm updated the test plan for D20814: Make entry simplification one-way.
Sun, Jul 28, 6:11 PM
dougm added a comment to D21093: tidy up swap_pager_putpages.

Tidy up comments.

Sun, Jul 28, 5:00 PM
dougm added a comment to D21093: tidy up swap_pager_putpages.

Apply reviewer suggestions. Make another style(9) fix.

Sun, Jul 28, 4:19 PM
dougm created D21093: tidy up swap_pager_putpages.
Sun, Jul 28, 4:38 AM

Sat, Jul 27

dougm added a reviewer for D20814: Make entry simplification one-way: alc.
Sat, Jul 27, 3:57 PM

Fri, Jul 26

dougm updated the summary of D20814: Make entry simplification one-way.

Use vm_map_try_merge_entries instead of vm_simplify_entry in vm_map_inherit.

Fri, Jul 26, 9:40 PM
dougm committed rS350359: Rewrite the comments that explain swapon_trim() to make them more.
Rewrite the comments that explain swapon_trim() to make them more
Fri, Jul 26, 3:18 PM
dougm closed D21034: improve swapon comments.
Fri, Jul 26, 3:18 PM
dougm added inline comments to D21034: improve swapon comments.
Fri, Jul 26, 3:02 PM
dougm updated the test plan for D20814: Make entry simplification one-way.
Fri, Jul 26, 4:38 AM
dougm added inline comments to D20814: Make entry simplification one-way.
Fri, Jul 26, 4:33 AM
dougm updated the test plan for D20814: Make entry simplification one-way.
Fri, Jul 26, 4:28 AM
D20814: Make entry simplification one-way now requires review to proceed.

In looking for the map entry that includes the page before page 0, use &map->header explicitly instead of using vm_map_lookup_entry.

Fri, Jul 26, 4:23 AM

Thu, Jul 25

D21034: improve swapon comments now requires review to proceed.

In one comment, connection -> descriptor.

Thu, Jul 25, 7:32 PM

Jul 24 2019

dougm updated subscribers of D20814: Make entry simplification one-way.
Jul 24 2019, 3:40 PM
dougm added inline comments to D21034: improve swapon comments.
Jul 24 2019, 8:01 AM

Jul 23 2019

dougm added a comment to D21034: improve swapon comments.

Consume reviewer suggestions.

Jul 23 2019, 3:55 PM
dougm added a comment to D20814: Make entry simplification one-way.

Rename vm_map_merge_entries to vm_map_try_merge_entries.

Jul 23 2019, 3:38 PM
dougm added inline comments to D20814: Make entry simplification one-way.
Jul 23 2019, 3:26 PM
dougm added inline comments to D21034: improve swapon comments.
Jul 23 2019, 3:18 PM
dougm created D21034: improve swapon comments.
Jul 23 2019, 3:15 AM

Jul 22 2019

dougm added a comment to D20863: prototype for trimming.

Fix broken log entry.

Jul 22 2019, 2:48 PM
dougm added inline comments to D20986: Centralize the logic in vfs_vmio_unwire() and sendfile_free_page()..
Jul 22 2019, 4:45 AM

Jul 21 2019

dougm added a comment to D20863: prototype for trimming.

Stop updating blk before it might be freed.

Jul 21 2019, 7:44 PM
dougm added a comment to D20863: prototype for trimming.

Back out the changes that would launch more that one trim request from a single call to swp_pager_trimswapspace.

Jul 21 2019, 7:38 PM
dougm updated the summary of D20814: Make entry simplification one-way.
Jul 21 2019, 4:32 PM
dougm added a comment to D20863: prototype for trimming.

If trimming fails after blocks are allocated, free the blocks and reset the trimming cursor.

Jul 21 2019, 3:45 PM
dougm added a comment to D20863: prototype for trimming.

Don't let the trimmer sleep waiting for a resources. Don't invoke the trimmer while holding an object lock. Do let the trimmer launch as many delete ops as it wants, subject to resource constraints. Don't worry about trimming too little.

Jul 21 2019, 4:56 AM

Jul 20 2019

dougm committed rS350183: In trimming on startup, invoke swapon before closing the fd used for.
In trimming on startup, invoke swapon before closing the fd used for
Jul 20 2019, 8:47 PM
dougm closed D21006: swapon before closing trimming fd.
Jul 20 2019, 8:47 PM
dougm added a comment to D21006: swapon before closing trimming fd.

Add explanatory comment.

Jul 20 2019, 6:12 PM
dougm retitled D21006: swapon before closing trimming fd from trim after swapon to swapon before closing trimming fd.
Jul 20 2019, 6:12 PM
dougm added a comment to D21006: swapon before closing trimming fd.

Fix Eflags typo.

Jul 20 2019, 7:31 AM
dougm added a comment to D21006: swapon before closing trimming fd.

Call swapon(2) after trimming, but before closing the trimming fd.

Jul 20 2019, 7:14 AM
dougm created D21006: swapon before closing trimming fd.
Jul 20 2019, 4:27 AM

Jul 19 2019

dougm added a comment to D20814: Make entry simplification one-way.

Code formatting and comment changes.

Jul 19 2019, 9:19 PM
dougm committed rS350155: Define vm_map_entry_in_transition to handle an in-transition map.
Define vm_map_entry_in_transition to handle an in-transition map
Jul 19 2019, 8:47 PM
dougm closed D20833: factor out common wiring code.
Jul 19 2019, 8:47 PM
dougm added a comment to D20833: factor out common wiring code.

Edit comments.

Jul 19 2019, 7:00 PM
dougm added a comment to D20833: factor out common wiring code.

Improve a comment.

Jul 19 2019, 4:23 PM

Jul 15 2019

dougm added inline comments to D20833: factor out common wiring code.
Jul 15 2019, 9:37 PM
dougm added a comment to D20833: factor out common wiring code.

Act on reviewer feedback.

Jul 15 2019, 9:37 PM
dougm added 1 blocking reviewer(s) for D20833: factor out common wiring code: alc.
Jul 15 2019, 6:10 AM

Jul 14 2019

D20833: factor out common wiring code now requires review to proceed.

Rename a variable. Restore a comment.

Jul 14 2019, 11:21 PM
dougm added a comment to D20863: prototype for trimming.

Make swapgeom_strategy() handle a BIO_DELETE just like a BIO_WRITE.

Jul 14 2019, 10:27 PM
dougm added inline comments to D20863: prototype for trimming.
Jul 14 2019, 8:58 PM
dougm added a comment to D20863: prototype for trimming.

Bypass swp_pager_strategy for the BIO_DELETE case and just go to sp->sw_strategy(bp, sp);

Jul 14 2019, 5:37 PM
dougm added a comment to D20814: Make entry simplification one-way.

Drop all the changes related to wiring and unwiring.

Jul 14 2019, 5:00 PM
dougm added a comment to D20863: prototype for trimming.

It would be unfair to Peter to keep guessing solutions for this problem and letting him try them out. Does anyone listening know what I've got wrong here?

Jul 14 2019, 8:23 AM

Jul 13 2019

dougm added a comment to D20625: clarify reserv_test_config.

Add an assertion. Use vm_paddr_t variable to manage bounds checking at function start.

Jul 13 2019, 6:33 PM
dougm added a comment to D20863: prototype for trimming.

g_io_request requires that b_data be NULL before BIO_DELETE. Make it so.

Jul 13 2019, 6:02 PM

Jul 12 2019

dougm committed rS349930: MFC r349286, r349293.
MFC r349286, r349293
Jul 12 2019, 2:04 AM

Jul 11 2019

dougm added a comment to D20863: prototype for trimming.

Don't try to trim exactly the swap device we just allocated from; just look for one that needs trimming.
Tweak the parameters to make the max trim size bigger, and make the trim zone smaller.

Jul 11 2019, 9:51 PM
dougm committed rS349923: Address problems in blist_alloc introduced in r349777. The swap block….
Address problems in blist_alloc introduced in r349777. The swap block…
Jul 11 2019, 8:52 PM
dougm closed D20893: Fix a next_leaf bug.
Jul 11 2019, 8:52 PM
dougm added inline comments to D20893: Fix a next_leaf bug.
Jul 11 2019, 7:49 PM
dougm updated the summary of D20833: factor out common wiring code.
Jul 11 2019, 1:35 PM

Jul 10 2019

dougm added a comment to D20893: Fix a next_leaf bug.

If we can allocation nothing from the next leaf, be sure to return immediately.

Jul 10 2019, 5:54 PM
D20893: Fix a next_leaf bug now requires review to proceed.

In the case that we have to back-up 'scan' because we've found that there's no next leaf with free blocks, we also have to back-up 'blk'.

Jul 10 2019, 4:05 PM
dougm added a comment to D20893: Fix a next_leaf bug.

Do I understand correctly that the "panic: freeing free block" condition is happening only with the patch from D20863 in place? Or does it happen with an unmodified kernel?

Jul 10 2019, 2:56 PM

Jul 9 2019

dougm created D20893: Fix a next_leaf bug.
Jul 9 2019, 3:53 PM
dougm added a comment to D20863: prototype for trimming.

Correct the last log field.

Jul 9 2019, 6:59 AM
dougm added a comment to D20863: prototype for trimming.

Add logging. Don't really try to trim anything.

Jul 9 2019, 3:06 AM
dougm updated the test plan for D20863: prototype for trimming.
Jul 9 2019, 3:06 AM

Jul 8 2019

dougm added a comment to D20833: factor out common wiring code.

The obvious questions are:
Does this happen without the patch in place?
Does this happen before r349777?

Jul 8 2019, 8:23 AM

Jul 7 2019

dougm added a comment to D20863: prototype for trimming.

In swap_pager_reserve, release the write lock when not modifying the object.

Jul 7 2019, 8:28 PM