Page MenuHomeFreeBSD

dougm (Doug Moore)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 30 2017, 3:18 PM (308 w, 4 d)

Tauist. Bit twiddler. Advocate for continued logarithms.

Recent Activity

Fri, May 12

dougm updated the diff for D40058: vm: reduce work of reclamation search.

Fix compilation errors.

Fri, May 12, 10:05 PM

Thu, May 11

dougm requested review of D40058: vm: reduce work of reclamation search.
Thu, May 11, 6:46 AM

Mon, May 1

dougm added inline comments to D39739: vm: implement vm_page_reclaim_contig_domain_ext() to reclaim multiple contiguous regions at once.
Mon, May 1, 8:49 PM

Feb 9 2023

dougm committed rG26a9c64d9df9: iommu_gas: initialize start_gap as first node (authored by dougm).
iommu_gas: initialize start_gap as first node
Feb 9 2023, 7:07 AM

Feb 8 2023

dougm committed rG87d405eab911: iommu_gas: initialize start_gap as first node (authored by dougm).
iommu_gas: initialize start_gap as first node
Feb 8 2023, 5:19 PM

Dec 25 2022

dougm committed rG8765df60dc26: iommu_gas: avoid overflow in bounds check (authored by dougm).
iommu_gas: avoid overflow in bounds check
Dec 25 2022, 7:02 AM

Dec 22 2022

dougm committed rG5b9b55fbc432: iommu_gas: avoid overflow in bounds check (authored by dougm).
iommu_gas: avoid overflow in bounds check
Dec 22 2022, 8:34 PM
dougm closed D37764: iommu_gas: avoid overflow in bounds check.
Dec 22 2022, 8:34 PM

Dec 21 2022

dougm updated the diff for D37764: iommu_gas: avoid overflow in bounds check.

Correct bounds check, where one was added when it should have been subtracted.

Dec 21 2022, 9:30 PM

Dec 20 2022

dougm requested review of D37764: iommu_gas: avoid overflow in bounds check.
Dec 20 2022, 9:03 PM
dougm resigned from D37756: IOMMU guest VA space fix.
Dec 20 2022, 6:45 PM

Dec 19 2022

dougm committed rG9d4303dbe2c4: rb_tree: fix stable/13 linux/rbtree.h post ABI fix (authored by dougm).
rb_tree: fix stable/13 linux/rbtree.h post ABI fix
Dec 19 2022, 10:08 PM
dougm closed D37743: rb_tree: fix linux links for 13 compat.
Dec 19 2022, 10:08 PM
dougm requested review of D37743: rb_tree: fix linux links for 13 compat.
Dec 19 2022, 11:02 AM

Dec 16 2022

dougm committed rGd8a88ec38149: rb_tree: restore binary compat w/ 13 (authored by dougm).
rb_tree: restore binary compat w/ 13
Dec 16 2022, 9:20 AM
dougm closed D37716: rb_tree: restore binary compat w/ 13.
Dec 16 2022, 9:20 AM
dougm added a comment to D37716: rb_tree: restore binary compat w/ 13.

I assume you test compile before committing. Looks good!

Dec 16 2022, 8:37 AM
dougm updated the diff for D37716: rb_tree: restore binary compat w/ 13.

Change usages of _RB_LINK to reorder the three pointers in RB_ENTRY to match the order in stable/13.

Dec 16 2022, 8:33 AM

Dec 15 2022

dougm requested review of D37716: rb_tree: restore binary compat w/ 13.
Dec 15 2022, 5:56 PM

Dec 12 2022

dougm added inline comments to D20477: Introduce stats(3).
Dec 12 2022, 10:30 PM

Nov 21 2022

dougm committed rG7a5de4db8cf1: iommu_gas: drop fini cleanup loop (authored by dougm).
iommu_gas: drop fini cleanup loop
Nov 21 2022, 8:26 AM
dougm committed rGdb151ca0c343: iommu_gas: start space search from 1st free space (authored by dougm).
iommu_gas: start space search from 1st free space
Nov 21 2022, 8:26 AM

Oct 29 2022

dougm committed rGa2c57c60d9e2: iommu_gas: drop fini cleanup loop (authored by dougm).
iommu_gas: drop fini cleanup loop
Oct 29 2022, 5:58 PM
dougm closed D37204: iommu_gas: drop fini cleanup loop.
Oct 29 2022, 5:57 PM
dougm requested review of D37204: iommu_gas: drop fini cleanup loop.
Oct 29 2022, 9:16 AM
dougm committed rG8b221ca631c2: iommu_gas: start space search from 1st free space (authored by dougm).
iommu_gas: start space search from 1st free space
Oct 29 2022, 5:56 AM
dougm closed D36624: iommu_gas: start space search from first free space.
Oct 29 2022, 5:55 AM

Oct 24 2022

dougm committed rGc1d077b80609: Fix LINT build after 368ee2f86a0f4f6 (authored by dougm).
Fix LINT build after 368ee2f86a0f4f6
Oct 24 2022, 12:44 AM
dougm committed rGd0fb642b6457: rb_tree: let insert search start from next node (authored by dougm).
rb_tree: let insert search start from next node
Oct 24 2022, 12:44 AM

Oct 23 2022

dougm added inline comments to D36624: iommu_gas: start space search from first free space.
Oct 23 2022, 7:58 PM
dougm updated the diff for D36624: iommu_gas: start space search from first free space.

Rewrite the rb_remove code for greater clarity. Add more to the comment before find_space updates start_gap, to make clear why a->size does not matter there.

Oct 23 2022, 7:58 PM
dougm added a reviewer for D36624: iommu_gas: start space search from first free space: kib.
Oct 23 2022, 9:12 AM

Oct 19 2022

dougm updated the diff for D36624: iommu_gas: start space search from first free space.

Don't 'fix' the start_gap hint until the next find_space. If an insert or removal leaves it at the root of a subtree with no usable gaps, a climb-up on the next find_space will fix it.

Oct 19 2022, 7:00 AM
dougm updated the diff for D35390: count node accesses in iommu_gas rb_tree searches.

Change how counting happens in loops.

Oct 19 2022, 6:34 AM

Oct 13 2022

dougm added inline comments to D36978: swap_pager: Reduce code duplication for swp_page_meta_build callers.
Oct 13 2022, 8:25 PM

Oct 12 2022

dougm committed rG52d4f5b16a15: rb_tree: Use void casts for RB_AUGMENT_CHECK with unused return value. (authored by jhb).
rb_tree: Use void casts for RB_AUGMENT_CHECK with unused return value.
Oct 12 2022, 3:01 AM
dougm committed rG871847f65312: rb_tree: add augmentation comments (authored by dougm).
rb_tree: add augmentation comments
Oct 12 2022, 3:01 AM
dougm committed rGdeeaf9c4d85d: rb_tree: pass parent to RB_INSERT_COLOR (authored by dougm).
rb_tree: pass parent to RB_INSERT_COLOR
Oct 12 2022, 3:01 AM
dougm committed rG85b89123b5c8: Use 0 and 1, not false and true, in tree.h changes. (authored by dougm).
Use 0 and 1, not false and true, in tree.h changes.
Oct 12 2022, 3:01 AM
dougm committed rGcd6395519895: rb_tree: augmentation shortcut (authored by dougm).
rb_tree: augmentation shortcut
Oct 12 2022, 3:01 AM
dougm committed rG7e139187708a: iommu_gas: don't remove and insert boundary entry (authored by dougm).
iommu_gas: don't remove and insert boundary entry
Oct 12 2022, 2:33 AM

Oct 4 2022

dougm updated the diff for D35390: count node accesses in iommu_gas rb_tree searches.

Update after many iommu_gas.c changes.

Oct 4 2022, 4:02 AM

Oct 3 2022

dougm updated the diff for D36624: iommu_gas: start space search from first free space.

Remove the tree changes that have been checked in.

Oct 3 2022, 7:49 AM
dougm resigned from D22150: Update swapon.8 to discourage using ZFS as swap device/file..
Oct 3 2022, 7:18 AM
dougm committed rGffbc2a58b13a: Fix LINT build after 368ee2f86a0f4f6 (authored by dougm).
Fix LINT build after 368ee2f86a0f4f6
Oct 3 2022, 5:17 AM
dougm closed D35516: rb_tree: let insert search start from adjacent node.
Oct 3 2022, 3:30 AM
dougm committed rG368ee2f86a0f: rb_tree: let insert search start from next node (authored by dougm).
rb_tree: let insert search start from next node
Oct 3 2022, 3:30 AM

Oct 2 2022

dougm updated the diff for D35516: rb_tree: let insert search start from adjacent node.

With DIAGNOSTIC defined, verify that the user of RB_INSERT_{PREV,NEXT} is using it properly.

Oct 2 2022, 11:15 PM

Oct 1 2022

dougm committed rG72c99edafa49: rb_tree: reduce duplication in balancing code (authored by dougm).
rb_tree: reduce duplication in balancing code
Oct 1 2022, 5:54 PM
dougm committed rGcde1c83e025a: rb_tree: silence unused function warnings (authored by dougm).
rb_tree: silence unused function warnings
Oct 1 2022, 5:54 PM
dougm committed rG6164e0292234: rb_tree: test rank balance (authored by dougm).
rb_tree: test rank balance
Oct 1 2022, 5:54 PM
dougm committed rGe5f93d10782d: show_sysctl_all: reduce copying, please coverity (authored by dougm).
show_sysctl_all: reduce copying, please coverity
Oct 1 2022, 5:22 PM
dougm closed D36847: show_sysctl_all: reduce copying, please coverity.
Oct 1 2022, 5:22 PM

Sep 30 2022

dougm requested review of D36847: show_sysctl_all: reduce copying, please coverity.
Sep 30 2022, 10:14 PM
dougm updated the diff for D35516: rb_tree: let insert search start from adjacent node.

Resolve conflict with recent commit.

Sep 30 2022, 2:45 AM

Sep 29 2022

dougm updated the diff for D35516: rb_tree: let insert search start from adjacent node.
Sep 29 2022, 9:09 PM

Sep 28 2022

dougm accepted D36778: rb_tree: Use void casts for RB_AUGMENT_CHECK with unused return value..
Sep 28 2022, 9:17 PM
dougm closed D36768: sysctl_search_oid: remove all-NULL precondition.
Sep 28 2022, 9:32 AM
dougm committed rG5294bfa75166: sysctl_search_oid: remove all-NULL precondition (authored by dougm).
sysctl_search_oid: remove all-NULL precondition
Sep 28 2022, 9:32 AM

Sep 27 2022

dougm requested review of D36768: sysctl_search_oid: remove all-NULL precondition.
Sep 27 2022, 9:26 PM
dougm closed D36765: name2oid: use find_oidname.
Sep 27 2022, 9:20 PM
dougm committed rG9f6f9007b98f: name2oid: use find_oidname (authored by dougm).
name2oid: use find_oidname
Sep 27 2022, 9:20 PM
dougm requested review of D36765: name2oid: use find_oidname.
Sep 27 2022, 7:47 PM
dougm committed rGe96ae5cb05b3: sysctl_search_oid: remove useless tests (authored by dougm).
sysctl_search_oid: remove useless tests
Sep 27 2022, 6:34 PM
dougm closed D36741: sysctl_search_oid: remove useless tests.
Sep 27 2022, 6:33 PM
dougm updated the diff for D36741: sysctl_search_oid: remove useless tests.

Add comments.

Sep 27 2022, 6:11 PM
dougm updated the diff for D36741: sysctl_search_oid: remove useless tests.
Sep 27 2022, 5:34 PM
dougm committed rGed5183455e46: register_oid: fix duplicate oid after d3f96f661050 (authored by dougm).
register_oid: fix duplicate oid after d3f96f661050
Sep 27 2022, 5:24 PM
dougm closed D36743: sysctl_register_oid: fix duplicate oid after d3f96f661050.
Sep 27 2022, 5:24 PM
dougm updated the diff for D36743: sysctl_register_oid: fix duplicate oid after d3f96f661050.

Offer an RB_NEXT compromise.

Sep 27 2022, 4:47 PM
dougm added a comment to D36743: sysctl_register_oid: fix duplicate oid after d3f96f661050.

It looks like your version will result in more sequential oid numbers. But I don't see how the old version could create a duplicate. Could you please explain?

After your change, when the first oid_number tried is found to be in use, you usually increment the oid_number and use it, assuming that it is not also in use. Before your change, when the first oid-number tried is found to be in use, the code usually incremented the old number and iterated, to check whether that number was in use, and kept doing so until it found a number not in use. So, you have introduced a bug, which I am trying to address, by making sure that the oid_number is not in use.

Oh, I see. I missed a goto retry. If you move that out of the if block then that would also fix the problem.

Sep 27 2022, 4:45 PM
dougm added a comment to D36743: sysctl_register_oid: fix duplicate oid after d3f96f661050.

It looks like your version will result in more sequential oid numbers. But I don't see how the old version could create a duplicate. Could you please explain?

Sep 27 2022, 4:30 PM
dougm added a reviewer for D36743: sysctl_register_oid: fix duplicate oid after d3f96f661050: hselasky.
Sep 27 2022, 3:50 PM
dougm requested review of D36743: sysctl_register_oid: fix duplicate oid after d3f96f661050.
Sep 27 2022, 8:11 AM
dougm added inline comments to D36500: Fix O(n^2) behavior in sysctl.
Sep 27 2022, 6:31 AM
dougm requested review of D36741: sysctl_search_oid: remove useless tests.
Sep 27 2022, 6:14 AM

Sep 26 2022

dougm updated the diff for D36624: iommu_gas: start space search from first free space.

Resolve conflict with updated tree.h comments.

Sep 26 2022, 5:47 PM
dougm committed rGb5b07c71e836: rb_tree: add augmentation comments (authored by dougm).
rb_tree: add augmentation comments
Sep 26 2022, 5:41 PM
dougm closed D36646: rb_tree: add augmentation comments.
Sep 26 2022, 5:41 PM

Sep 24 2022

dougm updated the diff for D36624: iommu_gas: start space search from first free space.

Use RB_INSERT_NEXT and RB_INSERT_PREV in more places.

Sep 24 2022, 9:07 PM

Sep 23 2022

dougm updated the diff for D36624: iommu_gas: start space search from first free space.

Use INSERT_NEXT, INSERT_PREV macros.

Sep 23 2022, 8:40 PM
dougm updated the diff for D36624: iommu_gas: start space search from first free space.

Define insert_next and insert_prev tree operations, and use them to update the iommu_gas_entries tree.

Sep 23 2022, 6:50 PM

Sep 21 2022

dougm abandoned D36058: iommu_gas: speed up augmentation.
Sep 21 2022, 4:05 PM
dougm updated the diff for D36624: iommu_gas: start space search from first free space.

Update after rb augment patch. Make start_gap point to the predecessor of the first empty gap that is big enough to hold a minimum allocation (1 page + 2 guards).

Sep 21 2022, 6:28 AM
dougm requested review of D36646: rb_tree: add augmentation comments.
Sep 21 2022, 5:22 AM
dougm committed rG86d00db451f7: Use 0 and 1, not false and true, in tree.h changes. (authored by dougm).
Use 0 and 1, not false and true, in tree.h changes.
Sep 21 2022, 4:38 AM
dougm closed D36509: rb_tree: augmentation shortcut.
Sep 21 2022, 4:25 AM
dougm committed rGb16f993ec2ca: rb_tree: augmentation shortcut (authored by dougm).
rb_tree: augmentation shortcut
Sep 21 2022, 4:25 AM
dougm updated the diff for D36509: rb_tree: augmentation shortcut.

Apply recommended style change.

Sep 21 2022, 4:15 AM
dougm added inline comments to D36509: rb_tree: augmentation shortcut.
Sep 21 2022, 4:08 AM
dougm updated the diff for D36509: rb_tree: augmentation shortcut.

Accept suggestions. Add comment explaining why the 'end' entry must be the first one inserted into the new tree.

Sep 21 2022, 3:56 AM
dougm updated the diff for D36509: rb_tree: augmentation shortcut.

Apply kib's manpage fix.

Sep 21 2022, 3:23 AM

Sep 19 2022

dougm committed rG35b262e57114: rb_tree: avoid extra reads in rebalancing (authored by dougm).
rb_tree: avoid extra reads in rebalancing
Sep 19 2022, 2:40 AM
dougm added a comment to D36509: rb_tree: augmentation shortcut.

Man page fix will go into the committed change.

Sep 19 2022, 2:36 AM

Sep 18 2022

dougm requested review of D36624: iommu_gas: start space search from first free space.
Sep 18 2022, 7:00 PM
dougm committed rGb63021e001dc: rb_tree: fine-tune RB_REMOVE (authored by dougm).
rb_tree: fine-tune RB_REMOVE
Sep 18 2022, 6:17 PM
dougm closed D36617: rb_tree: silence unused function warnings.
Sep 18 2022, 8:38 AM
dougm committed rG14696d81f163: rb_tree: silence unused function warnings (authored by dougm).
rb_tree: silence unused function warnings
Sep 18 2022, 8:38 AM
dougm requested review of D36617: rb_tree: silence unused function warnings.
Sep 18 2022, 3:52 AM

Sep 16 2022

dougm committed rG87cd087a4ae7: iommu_gas: don't remove and insert boundary entry (authored by dougm).
iommu_gas: don't remove and insert boundary entry
Sep 16 2022, 8:34 PM