Page MenuHomeFreeBSD

dougm (Doug Moore)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 30 2017, 3:18 PM (348 w, 13 h)

Tauist. Bit twiddler. Advocate for continued logarithms.

Recent Activity

Jan 29 2024

dougm accepted D43636: vm_phys: Add a vm_phys_seg_paddr_to_vm_page() helper.
Jan 29 2024, 4:54 PM

Jan 28 2024

dougm accepted D43636: vm_phys: Add a vm_phys_seg_paddr_to_vm_page() helper.
Jan 28 2024, 6:28 PM
dougm added inline comments to D38852: vm: improve kstack_object pindex calculation scheme to avoid pindex holes.
Jan 28 2024, 5:22 AM
dougm added inline comments to D38852: vm: improve kstack_object pindex calculation scheme to avoid pindex holes.
Jan 28 2024, 5:09 AM

Dec 21 2023

dougm updated the diff for D41335: vm_phys: speed up unfree_page search.

Refresh, seeking review.

Dec 21 2023, 5:03 AM
dougm committed rG6dd15b7a233a: vm_phys; fix uncalled free_contig (authored by dougm).
vm_phys; fix uncalled free_contig
Dec 21 2023, 3:43 AM
dougm closed D42891: vm_phys; fix uncalled free_contig.
Dec 21 2023, 3:43 AM

Dec 19 2023

dougm updated the diff for D42891: vm_phys; fix uncalled free_contig.
Dec 19 2023, 6:37 PM

Dec 18 2023

dougm added a reviewer for D42891: vm_phys; fix uncalled free_contig: markj.
Dec 18 2023, 9:05 PM

Dec 15 2023

dougm updated the test plan for D42891: vm_phys; fix uncalled free_contig.
Dec 15 2023, 10:08 AM

Dec 4 2023

dougm requested review of D42891: vm_phys; fix uncalled free_contig.
Dec 4 2023, 5:16 AM

Nov 29 2023

dougm added inline comments to D42698: bitstring: Support large bit strings..
Nov 29 2023, 3:34 AM

Nov 25 2023

dougm committed rG210fce73ae0e: vm_phys: fix freelist_contig (authored by dougm).
vm_phys: fix freelist_contig
Nov 25 2023, 1:27 AM

Nov 24 2023

dougm added inline comments to D42706: Avoid waiting on physical allocations that can't possibly be satisfied.
Nov 24 2023, 3:33 AM

Nov 23 2023

dougm added inline comments to D42698: bitstring: Support large bit strings..
Nov 23 2023, 7:55 AM
dougm added inline comments to D42706: Avoid waiting on physical allocations that can't possibly be satisfied.
Nov 23 2023, 7:42 AM

Nov 15 2023

dougm committed rG2a4897bd4e1b: vm_phys: fix freelist_contig (authored by dougm).
vm_phys: fix freelist_contig
Nov 15 2023, 9:38 AM
dougm closed D42509: vm_phys: fix freelist_contig.
Nov 15 2023, 9:38 AM

Nov 13 2023

dougm updated the diff for D42509: vm_phys: fix freelist_contig.

Fix typos identified by @markj.

Nov 13 2023, 5:21 PM

Nov 12 2023

dougm updated the diff for D42509: vm_phys: fix freelist_contig.

Edit a couple of comments.

Nov 12 2023, 10:06 PM

Nov 11 2023

dougm updated the diff for D42509: vm_phys: fix freelist_contig.

Add assertion. Add/update some comments.

Nov 11 2023, 10:36 PM
dougm updated the diff for D42509: vm_phys: fix freelist_contig.

Fix a comment, suggested by @alc.

Nov 11 2023, 9:47 PM
dougm updated the diff for D42509: vm_phys: fix freelist_contig.

For @alc, change a semicolon to empty braces.

Nov 11 2023, 8:20 PM
dougm added inline comments to D42509: vm_phys: fix freelist_contig.
Nov 11 2023, 8:19 PM
dougm updated the diff for D42509: vm_phys: fix freelist_contig.

As @alc suggests, remove a redundant assertion (aren't they all redundant?), and a pointless NULL check, and a comment which in no way improved performance.

Nov 11 2023, 8:00 PM
dougm updated the diff for D42509: vm_phys: fix freelist_contig.

Apply @alc suggestions. Remove some inessential parts.

Nov 11 2023, 7:39 PM

Nov 10 2023

dougm updated the diff for D42509: vm_phys: fix freelist_contig.

Fix an assertion identified by @markj.

Nov 10 2023, 8:00 PM
dougm updated the diff for D42509: vm_phys: fix freelist_contig.

Address feedback from @alc.

Nov 10 2023, 7:37 PM
dougm updated the diff for D42509: vm_phys: fix freelist_contig.

Re-enter an iterator for checking empty blocks.

Nov 10 2023, 3:49 AM
dougm updated the diff for D42509: vm_phys: fix freelist_contig.

Add a missing assignment.

Nov 10 2023, 3:15 AM

Nov 9 2023

dougm updated the diff for D42509: vm_phys: fix freelist_contig.

Apply suggestions from @markj.

Nov 9 2023, 8:25 PM
dougm updated the diff for D42509: vm_phys: fix freelist_contig.

Don't modify m_ret in the loop, in case iteration happens and that breaks FOREACH. Save the potential return value in m_val instead.

Nov 9 2023, 7:41 AM

Nov 8 2023

dougm requested review of D42509: vm_phys: fix freelist_contig.
Nov 8 2023, 5:15 PM

Oct 27 2023

dougm added a comment to D33947: Change free space search to avoid duplicate search.

The reporter of this bug:

Oct 27 2023, 3:58 PM

Sep 23 2023

dougm committed rGd9b8e5a74805: powerpc pmap: initialize kernel pmap radix trie (authored by dougm).
powerpc pmap: initialize kernel pmap radix trie
Sep 23 2023, 1:55 AM

Sep 21 2023

dougm added a comment to D41846: powerpc pmap: initialize kernel pmap radix trie.

Well, you need to ask re@ and since it was your fix, you should probably be the one to do it.

Sep 21 2023, 9:50 PM
dougm added a comment to D41846: powerpc pmap: initialize kernel pmap radix trie.

Can you also MFS to releng/14.0?

Sep 21 2023, 9:42 AM

Sep 20 2023

dougm committed rGa4c7a3f7f56a: powerpc pmap: initialize kernel pmap radix trie (authored by dougm).
powerpc pmap: initialize kernel pmap radix trie
Sep 20 2023, 2:12 AM

Sep 13 2023

dougm committed rG8763b9862f90: powerpc pmap: initialize kernel pmap radix trie (authored by dougm).
powerpc pmap: initialize kernel pmap radix trie
Sep 13 2023, 6:23 PM
dougm closed D41846: powerpc pmap: initialize kernel pmap radix trie.
Sep 13 2023, 6:22 PM
dougm requested review of D41846: powerpc pmap: initialize kernel pmap radix trie.
Sep 13 2023, 5:33 PM

Sep 12 2023

dougm committed rGe5635c3dab47: powerpc_mmu_radix: include vm_radix.h file (authored by dougm).
powerpc_mmu_radix: include vm_radix.h file
Sep 12 2023, 7:38 PM
dougm committed rGb24ed9c52dd2: powerpc_pmap: include proper vm_radix file (authored by dougm).
powerpc_pmap: include proper vm_radix file
Sep 12 2023, 1:14 PM
dougm committed rG10db91ecec98: vm_radix: add a missing paren (authored by dougm).
vm_radix: add a missing paren
Sep 12 2023, 9:22 AM
dougm committed rG429c871dddda: radix_trie: have vm_radix use pctrie code (authored by dougm).
radix_trie: have vm_radix use pctrie code
Sep 12 2023, 7:46 AM

Sep 11 2023

dougm added a reverting change for rGa494d30465f2: radix_trie: have vm_radix use pctrie code: rG6cec93da46c4: Revert "radix_trie: have vm_radix use pctrie code".
Sep 11 2023, 8:36 AM
dougm added a reverting change for D41344: radix_trie: have vm_radix use pctrie code: rG6cec93da46c4: Revert "radix_trie: have vm_radix use pctrie code".
Sep 11 2023, 8:36 AM
dougm committed rG6cec93da46c4: Revert "radix_trie: have vm_radix use pctrie code" (authored by dougm).
Revert "radix_trie: have vm_radix use pctrie code"
Sep 11 2023, 8:36 AM
dougm committed rGa494d30465f2: radix_trie: have vm_radix use pctrie code (authored by dougm).
radix_trie: have vm_radix use pctrie code
Sep 11 2023, 6:58 AM
dougm closed D41344: radix_trie: have vm_radix use pctrie code.
Sep 11 2023, 6:57 AM
dougm updated the diff for D41344: radix_trie: have vm_radix use pctrie code.

As @alc requested, drop the changes to the vm_page struct definition and the increment of the version number that accompanied it.

Sep 11 2023, 2:46 AM

Sep 9 2023

dougm updated the test plan for D41344: radix_trie: have vm_radix use pctrie code.
Sep 9 2023, 4:50 PM

Sep 8 2023

dougm added a comment to D41344: radix_trie: have vm_radix use pctrie code.

Are there any more issues to address before I commit this?

Sep 8 2023, 8:21 PM

Sep 6 2023

dougm updated the diff for D41344: radix_trie: have vm_radix use pctrie code.

Remove needless #include, __unused, blank line.

Sep 6 2023, 5:05 PM
dougm added inline comments to D41344: radix_trie: have vm_radix use pctrie code.
Sep 6 2023, 5:04 PM
dougm updated the diff for D41344: radix_trie: have vm_radix use pctrie code.

Bump __FreeBSD_version.
Reshuffle vm_page members as suggested.
Inline all the vm_radix functions that are wrappers for pctrie functions, leaving only a bit of storage management code in vm_radix.c.

Sep 6 2023, 4:21 PM

Sep 4 2023

dougm updated the diff for D41344: radix_trie: have vm_radix use pctrie code.

Rearrange ordering in vm_page one more time - to move pindex to the start and have order right after it. Without introducing gaps.

Sep 4 2023, 8:07 PM
dougm updated the diff for D41344: radix_trie: have vm_radix use pctrie code.

Move order and several others up with pindex to avoid creating a gap, and because future changes are likely to access 'order' in vm_radix calls, and having 'order' next to 'pindex' will be cache friendly. Didn't move enough up with pindex last time.

Sep 4 2023, 2:48 PM

Sep 3 2023

dougm updated the diff for D41344: radix_trie: have vm_radix use pctrie code.

Rearrange the members of vm_page. Move pindex to the beginning to avoid adding and subtracting in the vm_radix functions. Move order and 3 others up with pindex to avoid creating a gap, and because future changes are likely to access 'order' in vm_radix calls, and having 'order' next to 'pindex' will be cache friendly. Make order signed because, first, it is only ever assigned to, compare with, or printed as a signed value and, second, because negative values will be part of a planned future change.

Sep 3 2023, 6:34 AM

Aug 31 2023

dougm accepted D41344: radix_trie: have vm_radix use pctrie code.

Looks good to me, but wait a week to see if anyone else will comment before you commit it.

Aug 31 2023, 3:31 AM

Aug 30 2023

dougm added a comment to D40403: vm_page: Implement lazy page initialization.

What follows may be a series of stupid questions. If so, feel free to ignore them.

Aug 30 2023, 6:28 AM
dougm added inline comments to D40403: vm_page: Implement lazy page initialization.
Aug 30 2023, 6:07 AM

Aug 28 2023

dougm added inline comments to D40400: vm_phys: Factor out some calls to vm_freelist_add().
Aug 28 2023, 9:05 PM
dougm added inline comments to D41335: vm_phys: speed up unfree_page search.
Aug 28 2023, 4:05 PM

Aug 25 2023

dougm added a reviewer for D41335: vm_phys: speed up unfree_page search: markj.
Aug 25 2023, 7:43 PM
dougm added a comment to D40400: vm_phys: Factor out some calls to vm_freelist_add().

When I compile GENERIC-NODEBUG on amd64, I see that this change makes some functions grow larger. In particular, vm_phys_alloc_pages and vm_phys_enqueue_contig.

Aug 25 2023, 2:23 AM

Aug 24 2023

dougm edited reviewers for D41344: radix_trie: have vm_radix use pctrie code, added: dougm; removed: cem.
Aug 24 2023, 9:25 PM

Aug 22 2023

dougm added a comment to D41344: radix_trie: have vm_radix use pctrie code.

@alc will have to explain his position. I can’t.

Aug 22 2023, 10:56 PM
dougm added a comment to D41344: radix_trie: have vm_radix use pctrie code.

I would appreciate feedback here. I'm afraid that the only (unwritten, verbal) feedback I have so far is that this change is only acceptable if I strip all the code out of subr_pctrie.c and inline it in pctrie.h so that all that code can be generated over again for every user of pctrie.h. Is that a consensus position (of everyone but me)?

Aug 22 2023, 5:26 AM

Aug 21 2023

dougm closed D41396: pctrie: change for vm_radix compatibility.
Aug 21 2023, 5:35 PM
dougm committed rG3b7ffacdee49: pctrie: change for vm_radix compatibility (authored by dougm).
pctrie: change for vm_radix compatibility
Aug 21 2023, 5:35 PM

Aug 18 2023

dougm added a comment to D41396: pctrie: change for vm_radix compatibility.

Is there any more feedback to offer on this change?

Aug 18 2023, 8:18 PM
dougm committed rGb6a61d6836d9: linuxkpi math: fix kassert in math64.h (authored by dougm).
linuxkpi math: fix kassert in math64.h
Aug 18 2023, 5:33 AM

Aug 17 2023

dougm abandoned D40979: radix_trie: speed up search loops.

Other than a few comment rewrites, everything here has been checked in already.

Aug 17 2023, 9:32 PM
dougm updated the diff for D41396: pctrie: change for vm_radix compatibility.

Rewrite some comments.

Aug 17 2023, 3:19 AM

Aug 16 2023

dougm accepted D41475: vm_map.c: plug several more places which might modify entry->offset.
Aug 16 2023, 10:18 PM
dougm added inline comments to D41475: vm_map.c: plug several more places which might modify entry->offset.
Aug 16 2023, 7:28 PM
dougm added inline comments to D41475: vm_map.c: plug several more places which might modify entry->offset.
Aug 16 2023, 5:18 PM
dougm added a reviewer for D41344: radix_trie: have vm_radix use pctrie code: cem.
Aug 16 2023, 4:07 AM
dougm added a reviewer for D41396: pctrie: change for vm_radix compatibility: cem.
Aug 16 2023, 4:07 AM
dougm added inline comments to D41475: vm_map.c: plug several more places which might modify entry->offset.
Aug 16 2023, 3:59 AM

Aug 14 2023

dougm updated the diff for D41344: radix_trie: have vm_radix use pctrie code.

Don't modify vm_page. Implement everything in terms of subr_pctrie. Depends on another change (D41396) still under review.

Aug 14 2023, 12:57 AM
dougm updated the diff for D41396: pctrie: change for vm_radix compatibility.

Correct a typo in a comment.

Aug 14 2023, 12:51 AM

Aug 12 2023

dougm added a comment to D41344: radix_trie: have vm_radix use pctrie code.

Nothing you propose changes the layout of nodes, or the basic search routines, so I continue to believe that there's no need for all this code duplication.

Aug 12 2023, 9:36 PM
dougm added a comment to D41344: radix_trie: have vm_radix use pctrie code.

I can foresee using the vm_page's order field to encode an order, and thereby eliminate a level in the radix trie. Specifically, I believe that we could encode the order for allocated vm_pages as VM_NFREEORDER + the order

Aug 12 2023, 6:26 PM
dougm updated the diff for D41396: pctrie: change for vm_radix compatibility.

Expose PCTRIE_PAD in the header file, since it exists only to remind users of pctries not to allocate nodes at odd addresses.

Aug 12 2023, 5:33 AM

Aug 11 2023

dougm updated the diff for D41396: pctrie: change for vm_radix compatibility.
Aug 11 2023, 4:02 PM

Aug 10 2023

dougm added inline comments to D41099: More fixes for stacks.
Aug 10 2023, 9:00 AM
dougm added inline comments to D41099: More fixes for stacks.
Aug 10 2023, 7:09 AM
dougm added inline comments to D41099: More fixes for stacks.
Aug 10 2023, 6:47 AM
dougm accepted D41405: Update comment describing vm_map.
Aug 10 2023, 5:59 AM
dougm added inline comments to D41405: Update comment describing vm_map.
Aug 10 2023, 5:41 AM

Aug 9 2023

dougm updated the diff for D41396: pctrie: change for vm_radix compatibility.

Rename 'rtree' to 'ptree' in a few places to keep consistent with pctrie naming conventions.

Aug 9 2023, 9:40 PM
dougm requested review of D41396: pctrie: change for vm_radix compatibility.
Aug 9 2023, 5:48 PM
dougm committed rG15047a65099f: rangesets: use PCTRIE_DEFINE (authored by dougm).
rangesets: use PCTRIE_DEFINE
Aug 9 2023, 7:29 AM
dougm closed D41391: rangests: use PCTRIE_DEFINE.
Aug 9 2023, 7:28 AM
dougm requested review of D41391: rangests: use PCTRIE_DEFINE.
Aug 9 2023, 4:44 AM

Aug 7 2023

dougm added a comment to D41344: radix_trie: have vm_radix use pctrie code.

Do you plan to fully merge the two trie implementations?

Aug 7 2023, 3:21 PM
dougm requested review of D41344: radix_trie: have vm_radix use pctrie code.
Aug 7 2023, 7:16 AM

Aug 6 2023

dougm requested review of D41335: vm_phys: speed up unfree_page search.
Aug 6 2023, 6:53 AM