Page MenuHomeFreeBSD

dougm (Doug Moore)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 30 2017, 3:18 PM (119 w, 6 d)

Tauist. Bit twiddler. Advocate for continued logarithms.

Recent Activity

Yesterday

dougm added a comment to D20635: release multiple swap blocks at a time in swp_pager_force_pagein.

Fix a bug in the debug patch.

Thu, Oct 17, 3:15 PM
dougm added a comment to D20635: release multiple swap blocks at a time in swp_pager_force_pagein.

Here is a small patch that adds a few KASSERTS. There might be some value in seeing which of them is tripped first on the way to this failure.

Thu, Oct 17, 6:17 AM

Wed, Oct 16

dougm added a comment to D20635: release multiple swap blocks at a time in swp_pager_force_pagein.

It seems that this change broke something:
Hi Doug,

Wed, Oct 16, 7:50 AM

Mon, Oct 14

dougm updated the diff for D21964: Make vm_map a threaded tree.

Restore the invariant-checking code that fell out of the last patch.

Mon, Oct 14, 6:26 PM
dougm committed rS353497: Correct a transcription error that broke GENERIC introduced in r353496..
Correct a transcription error that broke GENERIC introduced in r353496.
Mon, Oct 14, 5:52 PM
dougm updated the diff for D21964: Make vm_map a threaded tree.

Reformat vm_map_entry_{pred,succ}.

Mon, Oct 14, 5:24 PM
dougm updated the summary of D21964: Make vm_map a threaded tree.
Mon, Oct 14, 5:21 PM
dougm closed D22011: Move vm_map debugging code.
Mon, Oct 14, 5:15 PM
dougm committed rS353496: Move the definition of _vm_map_assert_consistent so that it can use.
Move the definition of _vm_map_assert_consistent so that it can use
Mon, Oct 14, 5:15 PM
dougm added a comment to D21990: Optimize vm_page_in_laundry() with a bit operation..

Would there be a problem with changing the #defines:
#define PQ_NONE 255
#define PQ_UNSWAPPABLE 0
#define PQ_LAUNDRY 1
#define PQ_INACTIVE 2
#define PQ_ACTIVE 3
#define PQ_COUNT 4

Mon, Oct 14, 1:36 AM

Sun, Oct 13

dougm created D22011: Move vm_map debugging code.
Sun, Oct 13, 5:26 PM

Sat, Oct 12

dougm removed reviewers for D20664: Changes to vm_map_lookup_entry: alc, markj, kib.
Sat, Oct 12, 8:17 PM
dougm added reviewers for D21964: Make vm_map a threaded tree: markj, kib.
Sat, Oct 12, 8:16 PM
dougm added inline comments to D21989: Use enumeration to indicate swap almost full and full, instead of 2 variables..
Sat, Oct 12, 5:13 AM
dougm added inline comments to D21989: Use enumeration to indicate swap almost full and full, instead of 2 variables..
Sat, Oct 12, 2:56 AM
dougm added inline comments to D21990: Optimize vm_page_in_laundry() with a bit operation..
Sat, Oct 12, 2:42 AM

Thu, Oct 10

dougm updated the diff for D21964: Make vm_map a threaded tree.
Thu, Oct 10, 6:38 PM
dougm created D21964: Make vm_map a threaded tree.
Thu, Oct 10, 4:47 AM

Tue, Oct 8

dougm committed rS353298: Define macro VM_MAP_ENTRY_FOREACH for enumerating the entries in a vm_map..
Define macro VM_MAP_ENTRY_FOREACH for enumerating the entries in a vm_map.
Tue, Oct 8, 7:14 AM
dougm closed D21882: Use a loop macro for enumerating vm map entries.
Tue, Oct 8, 7:14 AM
dougm added inline comments to D21882: Use a loop macro for enumerating vm map entries.
Tue, Oct 8, 6:54 AM
dougm updated the diff for D21882: Use a loop macro for enumerating vm map entries.

VME_ -> VM_MAP_ENTRY_
Remove purposeless counter.
Move KASSERT out of loop.

Tue, Oct 8, 2:51 AM

Mon, Oct 7

dougm added inline comments to D21882: Use a loop macro for enumerating vm map entries.
Mon, Oct 7, 6:49 PM
dougm added inline comments to D21882: Use a loop macro for enumerating vm map entries.
Mon, Oct 7, 3:05 PM

Sun, Oct 6

dougm added a reviewer for D21882: Use a loop macro for enumerating vm map entries: markj.
Sun, Oct 6, 6:54 PM

Fri, Oct 4

dougm updated the diff for D21882: Use a loop macro for enumerating vm map entries.

Combine two loops in ptrace_vm_entry into one, so that "entry->next" doesn't have to appear.

Fri, Oct 4, 4:09 AM

Thu, Oct 3

dougm updated the diff for D21882: Use a loop macro for enumerating vm map entries.

Correct an off-by-one error.

Thu, Oct 3, 3:47 PM
dougm created D21882: Use a loop macro for enumerating vm map entries.
Thu, Oct 3, 8:00 AM

Sep 17 2019

dougm resigned from D20348: arm64: pmap: Try to find the correct attribute.
Sep 17 2019, 5:39 AM
dougm resigned from D20675: Eliminate incorrect 2 pagesized block skipping while preparing swap device..
Sep 17 2019, 5:38 AM
dougm updated the diff for D20664: Changes to vm_map_lookup_entry.

Update after r352433 committed changes to vm_map_entry_unlink that were part of this change.

Sep 17 2019, 3:08 AM
dougm committed rS352433: Remove dead code from vm_map_unlink_entry made dead by r351476, and also.
Remove dead code from vm_map_unlink_entry made dead by r351476, and also
Sep 17 2019, 2:54 AM
dougm closed D21668: remove dead code from vm_map_entry_unlink.
Sep 17 2019, 2:54 AM

Sep 16 2019

dougm created D21668: remove dead code from vm_map_entry_unlink.
Sep 16 2019, 3:14 AM

Sep 15 2019

dougm committed rS352366: MFC r348809, r349767.
MFC r348809, r349767
Sep 15 2019, 9:13 PM
dougm committed rS352365: MFC 351064.
MFC 351064
Sep 15 2019, 8:14 PM
dougm added a comment to D20664: Changes to vm_map_lookup_entry.

In D20664#472328, @alc wrote:

How does this perform on the microbenchmarks that you've previously used?

Sep 15 2019, 6:59 AM
dougm updated the diff for D20664: Changes to vm_map_lookup_entry.

Address reviewer comments. Replace another stray 'precessor' with 'predecessor'.

Sep 15 2019, 4:35 AM

Sep 6 2019

dougm updated the diff for D20664: Changes to vm_map_lookup_entry.

Rewrite comments describing vm_map_lookup_helper.

Sep 6 2019, 5:33 AM

Sep 4 2019

dougm updated the diff for D20664: Changes to vm_map_lookup_entry.

Discard parts that overlap/conflict with changes applied since this change was proposed.
Extend this change to completely eliminate the 'prev' field from vm_map_entry.

Sep 4 2019, 5:39 AM

Aug 31 2019

dougm added inline comments to D21352: procctl(PROC_STACKGAP_CTL).
Aug 31 2019, 7:11 PM

Aug 25 2019

dougm committed rS351476: vm_map_simplify_entry considers merging an entry with its two.
vm_map_simplify_entry considers merging an entry with its two
Aug 25 2019, 7:07 AM
dougm closed D20814: Make entry simplification one-way.
Aug 25 2019, 7:07 AM

Aug 23 2019

dougm updated the summary of D20814: Make entry simplification one-way.
Aug 23 2019, 3:20 AM
dougm updated the test plan for D20814: Make entry simplification one-way.
Aug 23 2019, 3:14 AM

Aug 22 2019

dougm added a comment to D21372: Do not clear page flags in vm_page_pqbatch_submit()..

All existing callers guarantee that the page does not have a pre-existing dequeue pending.

Can you add a KASSERT to express that in the callee?

Aug 22 2019, 8:37 PM

Aug 21 2019

dougm added a comment to D20814: Make entry simplification one-way.

Apply reviewer directives.

Aug 21 2019, 4:27 PM

Aug 20 2019

D21343: Avoid requeuing active pages in vm_swapout_object_deactivate_pages(). is now accepted and ready to land.

Seems plausible.

Aug 20 2019, 4:12 PM

Aug 17 2019

dougm added a comment to D20814: Make entry simplification one-way.

Simplify the patch.

Aug 17 2019, 7:20 PM
dougm added a comment to D20814: Make entry simplification one-way.

Apply reviewer suggestions.

Aug 17 2019, 5:39 PM

Aug 16 2019

dougm committed rS351150: MFC r348968:.
MFC r348968:
Aug 16 2019, 9:54 PM
dougm committed rS351148: MFC r348881:.
MFC r348881:
Aug 16 2019, 9:36 PM
dougm added a comment to D20814: Make entry simplification one-way.

Ready for review....

Aug 16 2019, 6:53 PM

Aug 15 2019

dougm committed rS351064: swap_pager.c reserves 2 blocks for a bsd label. Change that 2 to the.
swap_pager.c reserves 2 blocks for a bsd label. Change that 2 to the
Aug 15 2019, 2:31 AM
Herald added a reviewer for D21191: Don't trim bsd_label: manpages.
Aug 15 2019, 2:31 AM

Aug 14 2019

D21191: Don't trim bsd_label now requires review to proceed.

.Dq late

Aug 14 2019, 5:03 PM
dougm added a comment to D21191: Don't trim bsd_label.

line wrap.

Aug 14 2019, 4:31 PM
dougm updated the diff for D21191: Don't trim bsd_label.
Aug 14 2019, 4:17 PM
D21191: Don't trim bsd_label now requires review to proceed.

Apply alc comments.

Aug 14 2019, 4:07 PM

Aug 9 2019

dougm added a comment to D21191: Don't trim bsd_label.

Use howmany in one more place.

Aug 9 2019, 4:32 AM
dougm added a comment to D21191: Don't trim bsd_label.

Apply reviewer suggestions.

Aug 9 2019, 3:00 AM

Aug 8 2019

D21191: Don't trim bsd_label now requires review to proceed.

Make associated manpage fixes, including a clumsy attempt to address a savecore issue.

Aug 8 2019, 9:37 PM
dougm updated the diff for D21191: Don't trim bsd_label.
Aug 8 2019, 8:41 PM
dougm retitled D21191: Don't trim bsd_label from name bsd_label_size, and don't trim bsd_label to Don't trim bsd_label.
Aug 8 2019, 8:41 PM
dougm created D21191: Don't trim bsd_label.
Aug 8 2019, 5:05 PM

Aug 6 2019

dougm added a comment to D20863: prototype for trimming.

Without changing the behavior of this patch, add a SW_TRIM flag and a priority field to swdevt. Pass those from sys_swapon to kern_swapon (which does the work formerly done by sys_swapon) to swaponsomething, which creates the swap object.

Aug 6 2019, 6:10 AM
dougm added a comment to D20863: prototype for trimming.

Without changing the behavior of this patch, add a SW_TRIM flag and a priority field to swdevt. Pass those from sys_swapon to kern_swapon (which does the work formerly done by sys_swapon) to swaponsomething, which creates the swap object.

Aug 6 2019, 5:18 AM

Aug 3 2019

dougm added a comment to D20863: prototype for trimming.

Update log messages to distinguish cases where trimming is aborted before it gets started. Currently, a stretch of log entries like:

Aug 3 2019, 3:06 AM

Aug 1 2019

dougm committed rS350495: MFC r350183, r350359.
MFC r350183, r350359
Aug 1 2019, 5:30 AM

Jul 31 2019

dougm added a comment to D20814: Make entry simplification one-way.

Fix function naming mismatches in KASSERTS. In wire/unwire, make sure to clip after first entry found in transition.

Jul 31 2019, 9:37 PM
dougm added a comment to D20814: Make entry simplification one-way.

Don't unlock on early exit from map_wire_locked.

Jul 31 2019, 2:58 PM
dougm updated the summary of D20814: Make entry simplification one-way.
Jul 31 2019, 5:17 AM
dougm added a comment to D20814: Make entry simplification one-way.

Get rid of the remaining uses of vm_map_simplify_entry.

Jul 31 2019, 5:16 AM

Jul 29 2019

dougm created D21098: Try reusing about-to-be-freed memory in swap_pager_reserve when desperate.
Jul 29 2019, 3:13 AM

Jul 28 2019

dougm added a comment to D20863: prototype for trimming.

Update after checking in overlapping changes.

Jul 28 2019, 7:39 PM
dougm committed rS350392: In swap_pager_putpages, move the initialization of a free-blocks.
In swap_pager_putpages, move the initialization of a free-blocks
Jul 28 2019, 7:32 PM
dougm closed D21093: tidy up swap_pager_putpages.
Jul 28 2019, 7:32 PM
dougm updated the test plan for D20814: Make entry simplification one-way.
Jul 28 2019, 6:11 PM
dougm added a comment to D21093: tidy up swap_pager_putpages.

Tidy up comments.

Jul 28 2019, 5:00 PM
dougm added a comment to D21093: tidy up swap_pager_putpages.

Apply reviewer suggestions. Make another style(9) fix.

Jul 28 2019, 4:19 PM
dougm created D21093: tidy up swap_pager_putpages.
Jul 28 2019, 4:38 AM

Jul 27 2019

dougm added a reviewer for D20814: Make entry simplification one-way: alc.
Jul 27 2019, 3:57 PM

Jul 26 2019

dougm updated the summary of D20814: Make entry simplification one-way.

Use vm_map_try_merge_entries instead of vm_simplify_entry in vm_map_inherit.

Jul 26 2019, 9:40 PM
dougm committed rS350359: Rewrite the comments that explain swapon_trim() to make them more.
Rewrite the comments that explain swapon_trim() to make them more
Jul 26 2019, 3:18 PM
dougm closed D21034: improve swapon comments.
Jul 26 2019, 3:18 PM
dougm added inline comments to D21034: improve swapon comments.
Jul 26 2019, 3:02 PM
dougm updated the test plan for D20814: Make entry simplification one-way.
Jul 26 2019, 4:38 AM
dougm added inline comments to D20814: Make entry simplification one-way.
Jul 26 2019, 4:33 AM
dougm updated the test plan for D20814: Make entry simplification one-way.
Jul 26 2019, 4:28 AM
D20814: Make entry simplification one-way now requires review to proceed.

In looking for the map entry that includes the page before page 0, use &map->header explicitly instead of using vm_map_lookup_entry.

Jul 26 2019, 4:23 AM

Jul 25 2019

D21034: improve swapon comments now requires review to proceed.

In one comment, connection -> descriptor.

Jul 25 2019, 7:32 PM

Jul 24 2019

dougm updated subscribers of D20814: Make entry simplification one-way.
Jul 24 2019, 3:40 PM
dougm added inline comments to D21034: improve swapon comments.
Jul 24 2019, 8:01 AM

Jul 23 2019

dougm added a comment to D21034: improve swapon comments.

Consume reviewer suggestions.

Jul 23 2019, 3:55 PM
dougm added a comment to D20814: Make entry simplification one-way.

Rename vm_map_merge_entries to vm_map_try_merge_entries.

Jul 23 2019, 3:38 PM
dougm added inline comments to D20814: Make entry simplification one-way.
Jul 23 2019, 3:26 PM
dougm added inline comments to D21034: improve swapon comments.
Jul 23 2019, 3:18 PM
dougm created D21034: improve swapon comments.
Jul 23 2019, 3:15 AM

Jul 22 2019

dougm added a comment to D20863: prototype for trimming.

Fix broken log entry.

Jul 22 2019, 2:48 PM
dougm added inline comments to D20986: Centralize the logic in vfs_vmio_unwire() and sendfile_free_page()..
Jul 22 2019, 4:45 AM