roundup_pow_of_two: don't take the log of it
ClosedPublic
Actions

Authored by dougm on Sep 28 2024, 12:02 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, May 22, 9:13 PM

	Unknown Object (File)
	Thu, May 21, 4:44 PM

	Unknown Object (File)
	Thu, May 21, 11:34 AM

	Unknown Object (File)
	Thu, May 21, 8:44 AM

	Unknown Object (File)
	Tue, May 19, 5:32 AM

	Unknown Object (File)
	Mon, May 11, 7:47 PM

	Unknown Object (File)
	Mon, May 11, 7:38 PM

	Unknown Object (File)
	May 4 2026, 4:34 PM

View All 70 Files

Subscribers

imp

kib

Details

Reviewers

bz
kib

Commits

rGc44fbfdb5686: roundup_pow_of_two: don't take the log of it

Summary

Based on the definitions, ilog2(roundup_pow_of_two(x)) == order_base_2(x). Replace the former with the latter in a few places to save a few calculations.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dougm requested review of this revision.Sep 28 2024, 12:02 AM

dougm created this revision.

Add @kib in the hope that he's maintaining the mlx* bits these days.

To me looks ok

kib accepted this revision.Sep 28 2024, 11:40 AM

This revision is now accepted and ready to land.Sep 28 2024, 11:40 AM

Closed by commit rGc44fbfdb5686: roundup_pow_of_two: don't take the log of it (authored by dougm). · Explain WhySep 28 2024, 5:01 PM

This revision was automatically updated to reflect the committed changes.

dougm added a commit: rGc44fbfdb5686: roundup_pow_of_two: don't take the log of it.

Herald added a subscriber: imp. · View Herald TranscriptSep 28 2024, 5:01 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

mlx4/

mlx4_en/

en.h

2 lines

mlx4_ib/

mlx4_ib_qp.c

4 lines

Diff 143871

View Options

sys/dev/mlx4/mlx4_en/en.h