- User Since
- Jun 2 2014, 4:20 PM (207 w, 4 d)
This looks good.
Thu, May 24
I've considered Marius' suggestion. I reject it. memmove is now a first class citizen. If you'd like to make it even better, you are welcome to do so after this commit.
Wed, May 23
We only need to generate about 8 bytes of entropy per second total for the spiking of the algorithms...
Tue, May 22
OK. So it looked easy...
doh! no, with invariants
doh! compile with invariants
I agree. Comment says this was from nvme_scan_lun, and it uses path here not periph->path.
Mon, May 21
fix bogus mdastart -> ndastart
Fix missed part of the patch
Sun, May 20
Sat, May 19
Fri, May 18
I have a straw-man patch that does some of what mjg is talking about. It doesn't remove the b* functions though. It's not quite ready for sharing, though if there's interest i'll polish up enough to publish.
Thu, May 17
OK. Can't find anything else to argue with :)
Despite a couple grumbles, this looks good to my eye.
Wed, May 16
We can change to M_TRIM when Kirk commits his stuff :)
Tue, May 15
This approval is for a 'looks like you got it all and did the removal properly' aspect of this review.
I personally agree we should have removed this a while ago.
Mon, May 14
Looks good to me. One tiny question that occurred to me after I looked at it this morning. I think we're fine delaying the close for up to a tick so we don't have to try to send a bunch of wake ups during normal operation. Also did the obligatory lock check, and we're good there as well: refcount is only changed while holding the periph lock, and cam_periph_sleep uses the same lock to sleep on.
This looks good to my eye. I'd give mat@ 24 hours to opine on your changes in response to his comments.
Sun, May 13
Looks good to me. I don't understand mat@'s comment. It looks stale, but if not my approval is contingent on you resolving it.
Sat, May 12
Fri, May 11
looks like you've removed a lot of keywords...
Thu, May 10
This looks good. One minor concern about precedence, but if it's good, I'm good.
Update after committing the low-risk deck-chair motion.
not quite done.
Update to actually remove libkern/mmemmove.c
Wed, May 9
Generally I like it.
I'd like it a lot more if there were man.9 page(s) for the epoch API.
Some nits are all I see, but my CK foo is weak.
You'll need to rebase after my push. Sorry.
Tue, May 8
Mon, May 7
I think you can close this.