Page MenuHomeFreeBSD

imp (Warner Losh)
User

Projects

User Details

User Since
Jun 2 2014, 4:20 PM (312 w, 4 d)

Recent Activity

Today

imp accepted D25059: Only build ipsec modules if the kernel includes IPSEC_SUPPORT..

This is fine... it does highlight a bit more the impedance mismatch between kernel build and stand alone builds as options bleed out of the kernel...

Sat, May 30, 12:30 AM

Yesterday

imp accepted D25046: Fix IPSEC_DEBUG in ipsec.ko.
Fri, May 29, 6:51 AM

Thu, May 28

imp committed rS361608: MFC r358308:.
MFC r358308:
Thu, May 28, 11:24 PM
imp accepted D25028: do not enable pci bridge decoding on resume until I/O windows are restored.

This seems a reasonable fix for the problem at hand... I don't object, but John may have a specific case in mind...

Thu, May 28, 8:14 PM
imp accepted D23928: Add deprecation notices to ce,cp,mn sync serial drivers.

I think enough time has passed.

Thu, May 28, 3:51 PM

Tue, May 26

imp added inline comments to D24877: pci: loosen PCIe hot-plug requirements.
Tue, May 26, 8:46 PM

Sat, May 23

imp added a comment to D24968: geom_label: Use provider aliasing to alias upstream geoms.

I think there be dragons here.

Sat, May 23, 3:45 AM
imp accepted D24938: geom_part: Dispatch to partitions to create providers and aliases.
In D24938#549385, @cem wrote:

Kobj dispatch is on first method argument; correct method argument order to put
table first. In retrospect this is obvious but kobj doesn't detect this nicely
at either compile or runtime.

Sat, May 23, 1:17 AM

Mon, May 18

imp accepted D24900: bhyve: NVMe handle zero length DSM ranges.
Mon, May 18, 9:15 PM
imp accepted D24879: bhyve: refactor NVMe IO command handling.
Mon, May 18, 8:42 PM
imp accepted D24878: bhyve: convert NVMe logging statements.
Mon, May 18, 8:41 PM

Sat, May 16

imp accepted D24854: cam: ANSIfy 0-argument function definitions.
Sat, May 16, 7:39 AM

Fri, May 15

imp accepted D24596: vfs: add restrictions to read(2) of a directory.

All this angst over reading a directory which you shouldn't be doing since around 1983 or so.
fsdb is adequate, or should be updated, for debugging these things. It uses an existing security grant. And if you're looking at the low-level stuff, you'll likely need more information that just the dirent that you can get from reading the directory.
But, you can't do any of that with zfs, nfs, or others.
I've almost never wanted to read directories to get the dirents from them, even while debugging. They are at best, mildly interesting.
Adding another security knob to allow this for a niche use-case seems like overkill. Meh. The patch is fine.

Fri, May 15, 3:11 PM
imp added a comment to D24596: vfs: add restrictions to read(2) of a directory.

Probably grep(1) should be updated after this change. It has -d option to specify which action to to take on processing directories. From manpage:

-d ACTION, --directories=ACTION
       If an input file is a directory, use ACTION to process it.  By
       default, ACTION is read, which means that directories are read
       just as if they were ordinary files.  If ACTION is skip,
       directories are silently skipped.  If ACTION is recurse, grep
       reads all files under each directory, recursively; this is
       equivalent to the -r option.
Fri, May 15, 2:56 PM

Wed, May 13

imp committed rS361016: Add nvd alias back to nda now that it actually works..
Add nvd alias back to nda now that it actually works.
Wed, May 13, 7:17 PM
imp committed rS361015: Reimplement aliases in geom.
Reimplement aliases in geom
Wed, May 13, 7:17 PM
imp committed rS360999: Make the ata probe* and xpt* routines aprobe* and axpt* respectively..
Make the ata probe* and xpt* routines aprobe* and axpt* respectively.
Wed, May 13, 12:19 AM
imp closed D24825: Make all the ata probe* and xpt* routines aprobe* and axpt* respectively..
Wed, May 13, 12:19 AM
imp added a comment to D24825: Make all the ata probe* and xpt* routines aprobe* and axpt* respectively..

What about NVMe and MMC? If they don't have this problem, please say so in the commit message.

Wed, May 13, 12:11 AM

Tue, May 12

imp committed rS360995: Kill trailing newline while I'm here....
Kill trailing newline while I'm here...
Tue, May 12, 11:47 PM
imp committed rS360993: Refine the history of uname. It appeared in 4.4BSD. It was not in v7 unix. It.
Refine the history of uname. It appeared in 4.4BSD. It was not in v7 unix. It
Tue, May 12, 10:45 PM
imp updated the test plan for D24825: Make all the ata probe* and xpt* routines aprobe* and axpt* respectively..
Tue, May 12, 10:24 PM
imp requested review of D24825: Make all the ata probe* and xpt* routines aprobe* and axpt* respectively..
Tue, May 12, 9:18 PM
imp added inline comments to D24762: Implement aliases in a way that actually work..
Tue, May 12, 3:34 AM
imp added inline comments to D24762: Implement aliases in a way that actually work..
Tue, May 12, 1:15 AM
imp added a comment to D24762: Implement aliases in a way that actually work..

I note this is now creating an alias in NVMECAM, as well as in the GEOM layer; why both?

Tue, May 12, 1:14 AM

Sun, May 10

imp accepted D24802: Remove tests for obsolete compilers in the build system.

Follow on work may include assuming c++11 or c++14, but this is a great start and should be committed as is, module units from the review.

Sun, May 10, 10:59 PM
imp added a comment to D24596: vfs: add restrictions to read(2) of a directory.

I'd be tempted to loop in the security folks for a comment on sysctl vs tunable from a security perspective.

Sun, May 10, 2:53 PM

Sat, May 9

imp accepted D24788: Avoid using non-portable dd conv=osync option.
Sat, May 9, 11:35 PM
imp added a comment to D24760: remove %n support from printf(9).

Thanks cem

Sat, May 9, 8:29 PM
imp accepted D24786: clang: Reject %n for __attribute__((format(__freebsd_kprintf__))).

Love it. Easy to upstream.

Sat, May 9, 6:58 PM
imp added a comment to D24760: remove %n support from printf(9).

Or noisily complain / panic?

Sat, May 9, 5:07 PM
imp added a comment to D24760: remove %n support from printf(9).

Can we hack clang to warn? Or enable a clang option?

Sat, May 9, 5:05 PM

Fri, May 8

imp added inline comments to D24762: Implement aliases in a way that actually work..
Fri, May 8, 6:25 PM
imp added inline comments to D24762: Implement aliases in a way that actually work..
Fri, May 8, 5:22 PM
imp updated the test plan for D24762: Implement aliases in a way that actually work..
Fri, May 8, 5:19 PM
imp updated the test plan for D24762: Implement aliases in a way that actually work..
Fri, May 8, 4:46 PM
imp requested review of D24762: Implement aliases in a way that actually work..
Fri, May 8, 4:39 PM

Sun, May 3

imp accepted D24546: Use smaller jumbo mbufs in ENA as needed.
Sun, May 3, 4:39 PM
imp committed rS360600: We need to hold the periph lock when we release the ccb (and when we.
We need to hold the periph lock when we release the ccb (and when we
Sun, May 3, 4:22 AM

Fri, May 1

imp accepted D24532: Fix various Coverity-detected errors in nvme driver.

Looks great.

Fri, May 1, 10:19 PM
imp accepted D24297: Make include/malloc.h usable again..

Like the changes. Thanks for attending to all these pesky details.

Fri, May 1, 10:14 PM
imp committed rS360550: Add KASSERT to ensure sane nsid..
Add KASSERT to ensure sane nsid.
Fri, May 1, 9:24 PM
imp committed rS360549: Rename ns notification function....
Rename ns notification function...
Fri, May 1, 9:24 PM
imp committed rS360547: Document the passthru commands..
Document the passthru commands.
Fri, May 1, 8:30 PM
imp closed D24639: Document the passthru commands..
Fri, May 1, 8:30 PM
imp committed rS360546: Various improvements to this man page:.
Various improvements to this man page:
Fri, May 1, 8:30 PM
imp closed D24638: Various improvements to the nvmecontrol man page:.
Fri, May 1, 8:30 PM
imp committed rS360543: Redo r360540 to retain the ifndef sparc code, not delete it..
Redo r360540 to retain the ifndef sparc code, not delete it.
Fri, May 1, 6:37 PM
imp committed rS360540: Remove more stray sparc64 ifdefs..
Remove more stray sparc64 ifdefs.
Fri, May 1, 5:50 PM
imp committed rS360541: Spell LOADER correctly so we test lua build..
Spell LOADER correctly so we test lua build.
Fri, May 1, 5:50 PM
imp committed rS360539: Catch up to arm/arm and sparc64 removal..
Catch up to arm/arm and sparc64 removal.
Fri, May 1, 5:17 PM
imp committed rS360538: When we have an invalid build option, don't rm -rf the current.
When we have an invalid build option, don't rm -rf the current
Fri, May 1, 5:17 PM
imp added inline comments to D24532: Fix various Coverity-detected errors in nvme driver.
Fri, May 1, 3:39 PM
imp added inline comments to D24532: Fix various Coverity-detected errors in nvme driver.
Fri, May 1, 3:16 AM

Thu, Apr 30

imp committed rS360508: Fix three bugs highlighted by review:.
Fix three bugs highlighted by review:
Thu, Apr 30, 9:09 PM
imp committed rS360504: Style(9) nit: put function name at start of line..
Style(9) nit: put function name at start of line.
Thu, Apr 30, 8:58 PM
imp committed rS360503: Move / reword a comment..
Move / reword a comment.
Thu, Apr 30, 8:58 PM
imp committed rS360502: Remove stray blank line..
Remove stray blank line.
Thu, Apr 30, 7:49 PM
imp added reviewers for D24639: Document the passthru commands.: bcr, 0mp, manpages.
Thu, Apr 30, 5:55 PM
imp requested review of D24639: Document the passthru commands..
Thu, Apr 30, 5:54 PM
imp accepted D24637: Remove the SYMVER build option..
Thu, Apr 30, 5:22 PM
imp requested review of D24638: Various improvements to the nvmecontrol man page:.
Thu, Apr 30, 5:09 PM
imp accepted D24619: [website] Update projects section.

While there's continuing improvements here from time to time, the bulk of this work is done.

Thu, Apr 30, 4:01 PM

Apr 30 2020

imp added a comment to D24629: Implement the NVME_GET_NSID and NVME_PASSTHROUGH_CMD ioctls.

Add comments that cperciva noticed on IRC.

Apr 30 2020, 2:30 AM
imp added a comment to D24629: Implement the NVME_GET_NSID and NVME_PASSTHROUGH_CMD ioctls.

Doh! I pushed the wrong branch :(. So I'll fix things in a followup. I *THINK* I got this mostly right since I didn't need to add any new 'reach over' pointers...

Apr 30 2020, 2:00 AM
imp added inline comments to D24629: Implement the NVME_GET_NSID and NVME_PASSTHROUGH_CMD ioctls.
Apr 30 2020, 1:54 AM
imp added inline comments to D24629: Implement the NVME_GET_NSID and NVME_PASSTHROUGH_CMD ioctls.
Apr 30 2020, 12:44 AM
imp committed rS360484: Implement the NVME_GET_NSID and NVME_PASSTHROUGH_CMD ioctls.
Implement the NVME_GET_NSID and NVME_PASSTHROUGH_CMD ioctls
Apr 30 2020, 12:43 AM
imp committed rS360485: Make sure that we get the sbuf resources we need..
Make sure that we get the sbuf resources we need.
Apr 30 2020, 12:43 AM
imp committed rS360483: Return the nvmeX device associated with the ndaX device..
Return the nvmeX device associated with the ndaX device.
Apr 30 2020, 12:43 AM
imp added reviewers for D24629: Implement the NVME_GET_NSID and NVME_PASSTHROUGH_CMD ioctls: chs, chuck, rpokala.
Apr 30 2020, 12:31 AM
imp requested review of D24629: Implement the NVME_GET_NSID and NVME_PASSTHROUGH_CMD ioctls.
Apr 30 2020, 12:29 AM
imp committed rS360482: Generate a devctl event for interesting events.
Generate a devctl event for interesting events
Apr 30 2020, 12:27 AM

Apr 28 2020

imp added inline comments to D24596: vfs: add restrictions to read(2) of a directory.
Apr 28 2020, 2:01 AM
imp added a comment to D24596: vfs: add restrictions to read(2) of a directory.

I like this idea.

Apr 28 2020, 1:57 AM

Apr 27 2020

imp committed rS360413: Export the nda device's flags as a sysctl..
Export the nda device's flags as a sysctl.
Apr 27 2020, 11:43 PM
imp committed rS360411: Convert unmappedio over to a flag..
Convert unmappedio over to a flag.
Apr 27 2020, 11:43 PM
imp committed rS360412: Convert rotating to a flag bit..
Convert rotating to a flag bit.
Apr 27 2020, 11:43 PM
imp committed rS360410: Add flags sysctl to ada.
Add flags sysctl to ada
Apr 27 2020, 11:43 PM
imp committed rS360409: Change the flags back to an enum.
Change the flags back to an enum
Apr 27 2020, 11:39 PM
imp accepted D24583: Set use_nvd=0 in EC2 AMIs.
Apr 27 2020, 9:01 PM
imp accepted D24535: config: Add no-ctfconvert support..

Will need to remember to bump config version for anything that uses a driver that's tagged with this.

Apr 27 2020, 5:18 PM

Apr 26 2020

imp accepted D24297: Make include/malloc.h usable again..
Apr 26 2020, 9:42 PM

Apr 24 2020

imp accepted D24543: Improve MACHINE_ARCH handling for hard vs soft-float on RISC-V..

Other than what I think is a left over sys/elf.h include, this looks good.

Apr 24 2020, 8:40 PM

Apr 23 2020

imp added inline comments to D24532: Fix various Coverity-detected errors in nvme driver.
Apr 23 2020, 3:51 PM

Apr 22 2020

imp accepted D24544: Retire the GENERICSF kernel config..
Apr 22 2020, 9:58 PM

Apr 21 2020

imp added a comment to D24489: Don't pass a user buffer pointer as the data pointer in a CCB..

Blah, but thanks for the history on it, I guess I never noticed before. I would be surprised if this hasn't caused bugs. There's no longer an active standards group, and even if there was I'd advocate that this is wrong. Let's follow up with a change on it.

Apr 21 2020, 10:29 PM
imp accepted D24406: Don't allocate a stack buffer with a user-controlled size for CAMIOCOMMAND..

LGTM, but this stuff is tricky so you may want to wait for it to look good to others too.

Apr 21 2020, 7:22 PM

Apr 20 2020

imp accepted D24293: Add orders(7) man page from netbsd.

Obtained From: NetBSD

Apr 20 2020, 9:21 PM
imp added a comment to D10335: VirtFS/9p filesystem passthrough support (virtio-9p).

Why the move from contrib?

Apr 20 2020, 8:09 PM

Apr 19 2020

imp added a comment to D24480: Avoid panicing for commands that poll-out..
In D24480#538892, @mav wrote:

I worry this is at least incomplete implementation or even wrong approach. The problem I see in what happen if/when the command still complete after the polling gave up, or when the timeout handler expire. I think at very least it will be a stack corruption.

Apr 19 2020, 3:51 PM

Apr 18 2020

imp added inline comments to D24489: Don't pass a user buffer pointer as the data pointer in a CCB..
Apr 18 2020, 9:15 PM
imp accepted D24252: Install kerberos rc files regardless of MK_KERBEROS setting.

Lgtn

Apr 18 2020, 4:50 AM
imp committed rS360064: Add deprecation notice to amr(4).
Add deprecation notice to amr(4)
Apr 18 2020, 2:53 AM
imp committed rS360063: twa(4) deprecation notice.
twa(4) deprecation notice
Apr 18 2020, 2:53 AM
imp committed rS360062: Deprecation notice for iir.
Deprecation notice for iir
Apr 18 2020, 2:53 AM
imp committed rS360061: Add deprecation notice to mly.
Add deprecation notice to mly
Apr 18 2020, 2:53 AM
imp committed rS360060: Add deprecation notice for esp(4)..
Add deprecation notice for esp(4).
Apr 18 2020, 2:53 AM
imp updated the test plan for D24480: Avoid panicing for commands that poll-out..
Apr 18 2020, 2:46 AM