- User Since
- Jun 2 2014, 4:20 PM (164 w, 1 d)
Generally, this looks good to my eye. I think the masks are overkill, but that comes from my experience in pci land where they were over-used and under-needed.
Mon, Jul 24
Sat, Jul 22
I would posit that fsck is the wrong place to replicate newfs' calculations, unless there's some value that's added that I'm not seeing.
If newfs was used with default settings, and the partition was not resized, then alternate superblocks can be found by fsck using the same calculation as was done by newfs.
The problematic case is the e.g. resizing of the partition and the filesystem after initial filesystem creation, since alternate superblocks with stale content would be found.
Wed, Jul 19
This also works, and I like the larger area protect by _KERNEL.
Should have been done when the kernel side of this was committed.
Tue, Jul 18
IMHO, This is completely bogus.
Mon, Jul 17
Would SUBDIR_UNSORTED make more sense? Of course SUBDIR_PARALLEL likely should wither and die for a similar reason...
Fri, Jul 14
Thu, Jul 13
Updating D11589: Print more info when super blocks don't match, implement ability to
Wed, Jul 12
Why not 50MB instead of 512kb? That's stupidly small and precludes any and all future use of UEFI programs as well as boot block bloat. bz2 compressed, the size difference is trivial.
Tue, Jul 11
Mon, Jul 10
Sun, Jul 9
Fri, Jul 7
While complete, this interface is a total PITA. End to end protection type 2 is what again? Oh, I have to go look in the standard to understand all these parameters?
Can we at least have a description of what's going on here? A table for each of the magic numbers?
Sun, Jul 2
Sat, Jul 1
Is this really format, or is it namespace provisioning? There's another set of name space provisioning patches that are also under review right now.
Thu, Jun 29
Tue, Jun 27
Mon, Jun 26
Jun 25 2017
This looks good to me as well...
Jun 24 2017
While not technically incorrect (except maybe the lib32 comment), this papers over a weakness in the new lazy depend generation that should actually be fixed in said generation. Or failing that, the check belongs in libc generically so we don't have to maintain these silly lists.
Jun 23 2017
Jun 20 2017
Rebase to latest tip of the spear...
Remove unused includes, per kib.
I've updated the summary to be the commit message, modulo the content we put in the commit message that differential barfs on.
Latest nits from kib@
Add getfsstat. needed for df.
Jun 19 2017
OK, with the latest update, I think I've addressed everything there.
Fix leak I overlooked.
Missed a spelling mistake kib@ found.
Implement kib's suggestions (hopefully I didn't miss any)
Jun 18 2017
Jun 15 2017
Updated with the various issues raised in the code review: weak
symbols, osreldate, missing fields.
Jun 14 2017
Jun 13 2017
Trying with magic in git.config file.
Jun 9 2017
Jun 2 2017
There's no problem with either memcpy or memmove in the kernel. They just work. For like at least decade....
May 27 2017
I'm not entirely sure that switching interpreters is a good idea. I rather think it's a terrible idea, but am open to seeing how it progresses before rendering final judgement.
May 26 2017
May 25 2017
May 22 2017
I don't know if there's folks still using glimpse from before... But it's been long enough that I think it can go.
May 20 2017
May 18 2017
Actually I think I take that back... mips and arm aren't listed at all. Are they affected?
May 17 2017
Looks good to my eye as well...