Page MenuHomeFreeBSD

imp (Warner Losh)
User

Projects

User Details

User Since
Jun 2 2014, 4:20 PM (246 w, 2 d)

Recent Activity

Yesterday

imp added a reviewer for D19275: Rework logpage extensibility.: jhb.
Wed, Feb 20, 10:58 PM
imp created D19275: Rework logpage extensibility..
Wed, Feb 20, 10:53 PM
imp added a comment to D19262: Distinguish between "no partition" and "choose best partition" with a constant..

I love this. Or at least the idea of this.
If we also kill some of the type-punning that remains for disk_devdesc and other types, I think we'll have tamed the beast
I've not checked through every single instance as I'm busy today, but wanted to blast out that I loved this.
The only other alternative might be to have a flags field inside of disc_devdesc which controls this sort of behavior if that would be easier. Given how pervasive this idiom is, though, I'm guessing maybe not. I mention this in case I'm wrong in my guess.

Wed, Feb 20, 9:44 PM
imp added inline comments to D19231: Fix few issues in ioat(4) driver..
Wed, Feb 20, 4:45 PM

Tue, Feb 19

imp committed rS344304: Remove drm from LINT kernels.
Remove drm from LINT kernels
Tue, Feb 19, 9:21 PM
imp committed rS344299: Remove the i915 and radeon drivers..
Remove the i915 and radeon drivers.
Tue, Feb 19, 7:42 PM
imp committed rS344297: Per discussions on arch@ and elsewhere, retire drm module / drives..
Per discussions on arch@ and elsewhere, retire drm module / drives.
Tue, Feb 19, 7:42 PM
imp committed rS344298: Remove drm2 modules..
Remove drm2 modules.
Tue, Feb 19, 7:37 PM
imp closed D19196: Per discussions on arch@ and elsewhere, retire drm module / drives..
Tue, Feb 19, 7:37 PM
imp committed rS344300: Add an UPDATING entry for the removal of drm and drm2.
Add an UPDATING entry for the removal of drm and drm2
Tue, Feb 19, 7:37 PM
imp accepted D19242: Add the unix path to the output of `efivar --load-option`.

looks good to me.

Tue, Feb 19, 7:00 PM

Mon, Feb 18

imp added a comment to D19238: loader: disk api should honor d_partition = -1 and open slice.

Can we please spell -1 "SLICE_ONLY" or "Full slice" or something similar? I hate -1 being a special case that I have to puzzle out for each instance of it we have in the code.

Mon, Feb 18, 8:41 PM
imp added a comment to D18705: efibootmgr: make generic usage message more readable.

Go ahead and commit. This won't collide with anything I have out of the tree at the moment, and it's better to have better messages in the mean time.

Mon, Feb 18, 8:20 PM

Sat, Feb 16

imp committed rS344191: Remove write-only s_flag..
Remove write-only s_flag.
Sat, Feb 16, 12:15 AM

Fri, Feb 15

imp added a comment to D19203: Replace two-operand instruction aliases that clang does not understand with the three-operand instructions..
In D19203#410890, @jhb wrote:

I haven't needed this when building mips64 on clang 6. clang 7 can't build mips due to a different regression (but not in this file).

Fri, Feb 15, 7:04 PM
imp accepted D18694: evdev: add sysctls with device info.

This code looks good to me. I take no positions on any name stuff. The one thing I saw is not relevant to this change, so forgive my side comment.

Fri, Feb 15, 4:11 PM
imp accepted D19206: stand: dev_net: correct net_open's interpretation of params.

This cleans up one of the abuses of the devdesc stuff. Thank you.

Fri, Feb 15, 3:35 PM

Thu, Feb 14

imp committed rS344129: Fix small typo..
Fix small typo.
Thu, Feb 14, 5:04 PM
imp accepted D19193: Small typo in UPDATING.

Since this appears to come from a non-committer, and it's trivial, I'll just commit it.

Thu, Feb 14, 5:00 PM
imp added reviewers for D19196: Per discussions on arch@ and elsewhere, retire drm module / drives.: manu, mmel, zeising, johalun.
Thu, Feb 14, 4:47 PM
imp created D19196: Per discussions on arch@ and elsewhere, retire drm module / drives..
Thu, Feb 14, 4:46 PM

Wed, Feb 13

imp accepted D19168: CID 1332078: Logically dead code in sys/dev/pms/freebsd/driver/ini/src/osapi.c.

OK. I'm happy with the due diligence that's been done, and look forward to better timeout handling.
In general, our error recovery from timeout sucks, so I wouldn't be too hard on the vendor.

Wed, Feb 13, 7:56 PM
imp committed rS344070: Fix panic message..
Fix panic message.
Wed, Feb 13, 12:10 AM

Tue, Feb 12

imp added a comment to D19168: CID 1332078: Logically dead code in sys/dev/pms/freebsd/driver/ini/src/osapi.c.
In D19168#410022, @dab wrote:

I can test on hardware at $WORK. As to it being vendor code, although the driver was imported from PMC-Sierra 3 years ago, it doesn't look to me like any updates have come from them since. If you know of a source of updated vendor code, can you point me to it?

Tue, Feb 12, 9:48 PM
imp created D19169: Implement a system-wide limit or da and ada devices for delete..
Tue, Feb 12, 8:47 PM
imp committed rS344058: Revert the r343077 MFC after it was reverted in -current..
Revert the r343077 MFC after it was reverted in -current.
Tue, Feb 12, 8:12 PM
imp added a comment to D19168: CID 1332078: Logically dead code in sys/dev/pms/freebsd/driver/ini/src/osapi.c.

I ask because it's basically vendor code.

Tue, Feb 12, 7:30 PM
imp added a comment to D19168: CID 1332078: Logically dead code in sys/dev/pms/freebsd/driver/ini/src/osapi.c.

do you have the ability to test this change?

Tue, Feb 12, 7:30 PM
imp committed rS344057: Revert r343077 until the license issues surrounding it can be resolved..
Revert r343077 until the license issues surrounding it can be resolved.
Tue, Feb 12, 7:05 PM

Sun, Feb 10

imp added a comment to D3715: Add "rcorder -p"..

I wonder: why not leverage tsort?

Sun, Feb 10, 1:18 AM

Sat, Feb 9

imp added a comment to D17848: Update review requests for bhyve..

Would it make sense to add araujo's name to the usr.sbin/byhve line?

Sat, Feb 9, 5:43 AM
imp accepted D19101: Add myself to committers-src.dot and calendar.freebsd.
Sat, Feb 9, 5:21 AM
imp accepted D18965: Enable PCI bar reallocation by default..

I thought we did this years ago...
Now is a great time to do it. If there are issues, we'll find out in plenty of time to either (a) fix or (b) chicken out.

Sat, Feb 9, 4:03 AM

Thu, Feb 7

imp added inline comments to D19093: Extend libsecureboot(old libve) to obtain trusted certificates from UEFI and implement revocation.
Thu, Feb 7, 4:45 AM
imp committed rS343854: Welcome Johannes Lundberg to the ranks of committers..
Welcome Johannes Lundberg to the ranks of committers.
Thu, Feb 7, 2:37 AM

Tue, Feb 5

imp committed rS343814: Add quirk for Sansisk X400 drives.
Add quirk for Sansisk X400 drives
Tue, Feb 5, 10:53 PM
imp committed rS343812: Remove obsolete controller.
Remove obsolete controller
Tue, Feb 5, 9:38 PM
imp committed rS343811: Remove All Rights Reserved.
Remove All Rights Reserved
Tue, Feb 5, 9:37 PM
imp committed rS343810: Remove a few stray "All Rights Reserved." declarations on stuff I've.
Remove a few stray "All Rights Reserved." declarations on stuff I've
Tue, Feb 5, 9:28 PM
imp added a comment to D4557: Modify LUA code to use libstand.

Hmm, looking at the dates, this pre-dates the lua integration and is likely OBE.

Tue, Feb 5, 3:19 PM
imp requested changes to D4557: Modify LUA code to use libstand.

I worked really hard so we wouldn't have to do this. Do not commit this.
What problem is being solved here?
The original LUA loader submission had stuff like this in it, and I specifically rejected it and made all the files that lua needed usable / mimicked in libstand by linking those files to stand.h and having stand.h define everything that's needed.

Tue, Feb 5, 3:01 PM

Mon, Feb 4

imp committed rS343755: Regularize the Netflix copyright.
Regularize the Netflix copyright
Mon, Feb 4, 9:28 PM

Thu, Jan 31

imp created D19048: Implement 64-bit atomic functions on 32-bit mips..
Thu, Jan 31, 7:55 PM
imp committed rD52792: Fix my botched commits for Johannes' entry and email.
Fix my botched commits for Johannes' entry and email
Thu, Jan 31, 6:35 PM
imp committed rD52791: Add Johannes' email entry.
Add Johannes' email entry
Thu, Jan 31, 6:02 PM
imp committed rD52790: Sign Johannes' key and add him to pgpkeys.ent.
Sign Johannes' key and add him to pgpkeys.ent
Thu, Jan 31, 6:00 PM
imp committed rD52789: This isn't my key, but johannes'.
This isn't my key, but johannes'
Thu, Jan 31, 5:59 PM
imp committed rD52788: Update my key with new expiration date..
Update my key with new expiration date.
Thu, Jan 31, 5:58 PM
imp committed rD52787: Add Johannes' pgp entry.
Add Johannes' pgp entry
Thu, Jan 31, 5:58 PM
imp committed rD52786: Add Johannes Lunderg's public key.
Add Johannes Lunderg's public key
Thu, Jan 31, 5:55 PM

Wed, Jan 30

imp accepted D19012: sysctl has not -R option.
Wed, Jan 30, 4:21 PM
imp added a comment to D19012: sysctl has not -R option.
In D19012#406701, @0mp wrote:

I think it should be NRTbdehnotqx, shouldn't it? I'm sure most of our manpages are like that.

It depends. ls(1) has -ABab while grep(1) has -AaBb. Personally, I prefer -AaBb. It's also what the example for the Fl macro suggests in mdoc(7):

.Op Fl 1AaCcdFfgHhikLlmnopqRrSsTtux
Wed, Jan 30, 4:20 PM

Tue, Jan 29

imp added inline comments to D19016: Replace strlen with strnlen..
Tue, Jan 29, 4:28 PM

Mon, Jan 28

imp accepted D18991: Add dash as a valid characterl to UFS label name.

Dashes in labels won't cause problems for geom or the boot loader, so I think this is a good change. Thanks for driving it.

Mon, Jan 28, 9:58 PM

Thu, Jan 24

imp accepted D18948: [bhnd] remove unused sc variable.
Thu, Jan 24, 9:55 PM

Jan 18 2019

imp requested changes to D18885: Make SIFTR work again.
Jan 18 2019, 5:30 PM
imp added a comment to D18774: Add AMD NTB Hardware Driver for AMD SoC.

I just made a pass through for anything that caught my eye, and found a couple. I have not reviewed it to see if it matches the hardware spec for what it's trying to control.

Jan 18 2019, 5:28 PM

Jan 12 2019

imp accepted D18705: efibootmgr: make generic usage message more readable.

This is fine, but there's a chance we'll rework the arg parsing in this program in the near future... Better to get this in now though.

Jan 12 2019, 5:49 PM

Jan 11 2019

imp committed rS342948: Add man page for device_delete_children..
Add man page for device_delete_children.
Jan 11 2019, 7:05 PM
imp closed D18452: Add device_delete_children(9) manual page.
Jan 11 2019, 7:05 PM

Jan 10 2019

imp added inline comments to D16337: Build options etc for libbearssl and libve.
Jan 10 2019, 8:12 PM
imp added inline comments to D18623: Address the fact that errors from `copyout(9)` are not properly percolated up on failure.
Jan 10 2019, 4:17 PM
imp accepted D18765: Add EINTEGRITY as new error number.

Lua bits look good

Jan 10 2019, 4:25 AM
imp added inline comments to D18794: Introduce Build options for Secure Boot.
Jan 10 2019, 12:39 AM
imp added a comment to D18799: Create binsign tool to sign binary files for Secure Boot.

how is this different than uefisign(8)?

Jan 10 2019, 12:37 AM

Jan 9 2019

imp accepted D18778: Complete r342182..

This is fine.

Jan 9 2019, 5:09 PM
imp added inline comments to D18790: Make sh(1) support \u in PS1..
Jan 9 2019, 4:53 PM
imp added inline comments to D18774: Add AMD NTB Hardware Driver for AMD SoC.
Jan 9 2019, 4:07 PM
imp added inline comments to D18790: Make sh(1) support \u in PS1..
Jan 9 2019, 4:01 PM
imp committed rS342878: Add quirk for 128MB Creative Nomad..
Add quirk for 128MB Creative Nomad.
Jan 9 2019, 6:22 AM

Jan 8 2019

imp committed rS342866: Add NO_SYNC_CACHE quirk for PENTAX cameras.
Add NO_SYNC_CACHE quirk for PENTAX cameras
Jan 8 2019, 8:55 PM
imp committed rS342865: biospci_write_config args were backwards.
biospci_write_config args were backwards
Jan 8 2019, 8:02 PM
imp accepted D18783: Avoid bsd.files.mk duplicate rule warning for bfd ldscripts.

This looks reasonable to me.

Jan 8 2019, 3:02 PM

Jan 7 2019

imp accepted D18772: Add NVMe drive to NOIOB quirk list.

This works for me. There is a newer way to cope with this, but I don't think the 4600 implements this, so this change is appropriate.

Jan 7 2019, 7:50 PM
imp accepted D18765: Add EINTEGRITY as new error number.

Just checked the LUA bits, but they are fine. My acceptance is only for that.

Jan 7 2019, 7:34 AM
imp committed rS342843: Fix a race between setting up the interrupt handler and it firing by.
Fix a race between setting up the interrupt handler and it firing by
Jan 7 2019, 6:19 AM
imp committed rS342842: Fix TI PCI1520 PCI Cardbus bridge, but others affected..
Fix TI PCI1520 PCI Cardbus bridge, but others affected.
Jan 7 2019, 6:00 AM
imp committed rS342840: Create MK_LOADER_VERBOSE and connect it to ELF_VERBOSE in the loader.
Create MK_LOADER_VERBOSE and connect it to ELF_VERBOSE in the loader
Jan 7 2019, 5:49 AM

Jan 4 2019

imp accepted D18746: MFC r342046: nda(4) fix check for Dataset Management support.

Most MFCs don't need phab reviews, btw. This one looks fine...

Jan 4 2019, 8:15 PM
imp added a comment to D18742: (PR 125707): powerd(8): allow to force a method of battery state query.
In D18742#399975, @pi wrote:

Hmm, I still use

apm

daily to check the battery status of my laptops. What would be the alternative ?

Jan 4 2019, 7:07 PM
imp accepted D18742: (PR 125707): powerd(8): allow to force a method of battery state query.

I doubt there's any FreeBSD machines running FreeBSD 6 or newer using APM today. This stopped being relevant around Pentium MMX 200MHz time frame, and was relevant only for laptops. You can safely completely and totally ignore the APM method. We should GC all that code.

Jan 4 2019, 5:40 PM
imp added a comment to D18745: Limit git history searches in newvers.sh.

10,000 is a bit arbitrary, but is a decent enough limit. 1k likely would do the trick, but maybe not always and wouldn't help the speed much at all. 100k likely would be measurably slower. I know that patch collections in monta vista linux for just the kernel ran into the thousands back in the day when I had to cope with their insanity, so maybe 10k isn't all that over-high...

Jan 4 2019, 4:35 PM
imp accepted D18740: Update the note about the need for COMPAT_FREEBSD<n> kernel options..

Thanks for tweaking this John... I don't think it's been materially changed since I wrote it 15 years ago.

Jan 4 2019, 2:07 AM

Jan 3 2019

imp added inline comments to D18739: add separate knob for zfs support in bootloader .
Jan 3 2019, 9:50 PM
imp added a comment to D18694: evdev: add sysctls with device info.

This looks generally good to me, but I've not taken the time to verify every bit is correctly serialized / deserialized.

Jan 3 2019, 7:17 PM

Jan 2 2019

imp added a comment to D18703: Fix bhyve's NVMe Completion Queue entry values.

LGTM! Could you please set a MFC?

Absolutely. I have one in the real commit message, but Differential didn't seem to like it in the summary.

Jan 2 2019, 6:21 PM · bhyve
imp requested changes to D18705: efibootmgr: make generic usage message more readable.
Jan 2 2019, 4:19 PM
imp accepted D18703: Fix bhyve's NVMe Completion Queue entry values.

lgtm

Jan 2 2019, 7:10 AM · bhyve
imp accepted D18702: Fix bhyve's NVMe queue bookkeeping.

This looks good to me as well...

Jan 2 2019, 7:09 AM · bhyve

Dec 31 2018

imp committed rS342657: Add NO_RC16 quirk for Chipfancier 16GB USB stick....
Add NO_RC16 quirk for Chipfancier 16GB USB stick...
Dec 31 2018, 10:20 PM

Dec 30 2018

imp accepted D18694: evdev: add sysctls with device info.

This looks fine, but I'd create a sysctl that publishes this information as well. devd events are just that: one shot events that say that something has changed. when we restart devd, we don't republish everything that's gone before. This looks necessary to cope with devices that are plugged into the system. Otherwise we may have a race if devd starts, processes events, then x11 and friends start and expect this event in the queue. Maybe it is, maybe it isn't. devd is designed to have no memory, and I really really want to keep it that way.

Dec 30 2018, 11:16 PM
imp requested changes to D18693: devd: remember notify events for currently attached devices and allow clients to request them.

We don't remember any old events.
You need to find a different way to get this information through the system.
I'd suggest a sysctl that publishes this information that can be read.

Dec 30 2018, 11:13 PM
imp added a comment to D18645: Fix ESP generation when using a gmirror, and when booting from RO medium.

I think this is fine, but I'm not totally sure.

Dec 30 2018, 5:17 PM
imp accepted D18648: Change the way efibootmgr works by specifying bootnum via -b parameter.

Works for me. Again, I think it was a mistake to have flags for both verbs and options, but that's what linux did and will need to be fixed in a separate commit.

Dec 30 2018, 5:14 PM

Dec 24 2018

imp added inline comments to D18648: Change the way efibootmgr works by specifying bootnum via -b parameter.
Dec 24 2018, 5:13 PM
imp accepted D18647: Activate support for efibootmgr(8) -b --bootnum parameter.
Dec 24 2018, 8:33 AM
imp accepted D18646: Improve the efibootmgr(8) man page.
Dec 24 2018, 8:32 AM
imp added a comment to D18648: Change the way efibootmgr works by specifying bootnum via -b parameter.

I went back and forth on this when I was writing the code. I thought it was a more natural interface to say --activate #, --deactivate #, etc, rather that --activate --bootnum #. I see the use-case, though. It could be handled by a second invocation, but the original code was already confused over what set_active means (in some places using it as a boolean, other places using it and the boot number). So I think on the whole this is good, modulo my comments.

Dec 24 2018, 8:28 AM
imp added a comment to D18648: Change the way efibootmgr works by specifying bootnum via -b parameter.

Be sure to commit these separately.

Dec 24 2018, 8:15 AM

Dec 21 2018

imp committed rS342358: Try the first 256 units with nvmecontrol devlist..
Try the first 256 units with nvmecontrol devlist.
Dec 21 2018, 11:22 PM