User Details
- User Since
- Jun 2 2014, 4:20 PM (511 w, 14 h)
Yesterday
This is too bog to easily review, so it has always dropped to the end of the list...
This is fine. The syntax is Forth, the comments are Forth and a quick grep suggests that dictthreshold is the right variable to set.
This looks good. There areno compat concerns
Sun, Mar 17
These changes aren't backward compatible. You likely need to keep the old struct to reply to the old ioctl...
Fri, Mar 15
Thu, Mar 14
just one (possibly unrelated) question.
Wed, Mar 13
I would suggest iwlwifi vs iwm except that LinuxKPI drivers don't probe normally (they all run in a late SYSINIT for some reason) so this won't work for that case. :(
We need to fix that. It's unacceptable. I'm tired of all the stupid hacks in LinuxKPI because the original author couldn't be bothered to do things correctly... See also the restriction on not being able to be loaded from the boot loader...
ooops. This is not ready. It doesn't even work, sadly.
Sounds good,,, CLEAN isn't in the list :)
I think tis is good... not sure about jrtc's comments
Tue, Mar 12
This isn't quite right. We also should change sys/sys/unistd.h since it only defines 200112 compliance, when we're effectively 200809 compliant.
We should likely just move the BSD defines down to the highlighted #if, but we'd also need to make the sys/sys/unitstd.h change. I'd recommend that for upstream, then it automatiocally starts working.
Have you confirmed that this makes these files now match upstream?
Mon, Mar 11
So I don't think I need timezone.3 in the old files stuff...
update, per Brooks.
Sat, Mar 9
I think these are right.
Fri, Mar 8
Looks good, feel free to take up or not my suggestion.
This looks good, though having _new in the ABI seems a little weird... It would just be for the life of whatever branches you merge this to, though.
Thu, Mar 7
actually fix the redundancy
rebase
but I'll do that fix as another commit
mav@ is correct.
I don't know what I was thinking here...