- User Since
- Jun 2 2014, 4:20 PM (312 w, 4 d)
This is fine... it does highlight a bit more the impedance mismatch between kernel build and stand alone builds as options bleed out of the kernel...
Thu, May 28
This seems a reasonable fix for the problem at hand... I don't object, but John may have a specific case in mind...
I think enough time has passed.
Tue, May 26
Sat, May 23
I think there be dragons here.
Mon, May 18
Sat, May 16
Fri, May 15
All this angst over reading a directory which you shouldn't be doing since around 1983 or so.
fsdb is adequate, or should be updated, for debugging these things. It uses an existing security grant. And if you're looking at the low-level stuff, you'll likely need more information that just the dirent that you can get from reading the directory.
But, you can't do any of that with zfs, nfs, or others.
I've almost never wanted to read directories to get the dirents from them, even while debugging. They are at best, mildly interesting.
Adding another security knob to allow this for a niche use-case seems like overkill. Meh. The patch is fine.
Wed, May 13
Tue, May 12
Sun, May 10
Follow on work may include assuming c++11 or c++14, but this is a great start and should be committed as is, module units from the review.
I'd be tempted to loop in the security folks for a comment on sysctl vs tunable from a security perspective.
Sat, May 9
Love it. Easy to upstream.
Or noisily complain / panic?
Can we hack clang to warn? Or enable a clang option?
Fri, May 8
Sun, May 3
Fri, May 1
Like the changes. Thanks for attending to all these pesky details.
Thu, Apr 30
While there's continuing improvements here from time to time, the bulk of this work is done.
Apr 30 2020
Add comments that cperciva noticed on IRC.
Doh! I pushed the wrong branch :(. So I'll fix things in a followup. I *THINK* I got this mostly right since I didn't need to add any new 'reach over' pointers...
Apr 28 2020
I like this idea.
Apr 27 2020
Will need to remember to bump config version for anything that uses a driver that's tagged with this.
Apr 26 2020
Apr 24 2020
Other than what I think is a left over sys/elf.h include, this looks good.
Apr 23 2020
Apr 22 2020
Apr 21 2020
LGTM, but this stuff is tricky so you may want to wait for it to look good to others too.
Apr 20 2020
Why the move from contrib?
Apr 19 2020
Apr 18 2020