Page MenuHomeFreeBSD

imp (Warner Losh)
User

Projects (8)

User Details

User Since
Jun 2 2014, 4:20 PM (632 w, 5 d)

Recent Activity

Fri, Jul 17

imp added a comment to D58262: tests: skip gracefully when the tested binary's own package isn't installed.

Side thought: it would be nice if these were actually broken down into subpackages, e.g., indent-tests, etc.

Fri, Jul 17, 3:11 PM

Wed, Jul 15

imp updated the test plan for D58262: tests: skip gracefully when the tested binary's own package isn't installed.
Wed, Jul 15, 6:07 PM
imp requested review of D58262: tests: skip gracefully when the tested binary's own package isn't installed.
Wed, Jul 15, 5:39 PM

Tue, Jul 14

imp accepted D58235: sys/exterrvar.h: forward declare struct thread.
Tue, Jul 14, 11:05 PM
imp closed D58007: Harmonize the cross repo advice..
Tue, Jul 14, 11:01 PM
imp committed R9:5055f6624bd0: Harmonize the cross repo advice. (authored by imp).
Harmonize the cross repo advice.
Tue, Jul 14, 11:01 PM
imp updated the diff for D58007: Harmonize the cross repo advice..

jhb's changes

Tue, Jul 14, 8:43 PM
imp accepted D58232: nvme: Add quirk for Amazon EBS NVMe Controller.
Tue, Jul 14, 7:35 PM
imp added inline comments to D58231: nvme: Add quirk for broken namespace-change log.
Tue, Jul 14, 7:35 PM
imp added a comment to D56474: Generate SBOM files as part of the build.

No longer build bomtool(1) and spdxtool(1) with NO_SHARED in the tooling phase. (Reported by imp@, thanks!)

Tue, Jul 14, 5:39 PM

Mon, Jul 13

imp committed rG878bf20fa56a: Ignore the white-space-only change for decompress.c (authored by imp).
Ignore the white-space-only change for decompress.c
Mon, Jul 13, 8:26 PM
imp committed rGe49fc64b9b00: loader: Fix indentation mistakes (authored by imp).
loader: Fix indentation mistakes
Mon, Jul 13, 8:25 PM
imp requested review of D58219: geom: Limit async I/O at the top of geom.
Mon, Jul 13, 7:40 PM
imp accepted D58210: firewire: remove SPL calls.
Mon, Jul 13, 7:35 PM · drivers, firewire
imp requested review of D58218: loader: Add docs for some commands.
Mon, Jul 13, 6:23 PM
imp requested review of D58217: loader.efi: Add EFI commands.
Mon, Jul 13, 6:23 PM
imp requested review of D58216: loader: Document common commands.
Mon, Jul 13, 6:23 PM

Sun, Jul 12

imp accepted D58198: mkimg: Add ms-basic-data alias for GPT.
Sun, Jul 12, 7:56 PM
imp added a comment to D57956: pkgbasify: Add new utility.

how is this related to the pkgbaseify that was linked off a foundation blog?
The code looks clean, but I don't know if it's correct.

Sun, Jul 12, 5:17 PM
imp accepted D58165: pkg: Add support for -r and -j.

I like it.

Sun, Jul 12, 5:16 PM
imp accepted D58186: efisign: add to the efi-tools package.
Sun, Jul 12, 4:06 AM
imp committed rGdf9d6403caa6: loader: Add forgotten xz.c and zstdfs.c (authored by imp).
loader: Add forgotten xz.c and zstdfs.c
Sun, Jul 12, 3:54 AM
imp accepted D58187: uefisign: rename to efisign.

I had similar patches in my tree for a while, but these aremore complete and better. Thanks!!!

Sun, Jul 12, 3:34 AM

Sat, Jul 11

imp committed rGa7ebe2d436e5: boot-test.sh: Test many boot loader combinations. (authored by imp).
boot-test.sh: Test many boot loader combinations.
Sat, Jul 11, 7:54 PM
imp committed rG541e6e2d516b: bsd.dirs.mk: Fix MK_INSTALL_AS_USER for directories (authored by imp).
bsd.dirs.mk: Fix MK_INSTALL_AS_USER for directories
Sat, Jul 11, 7:54 PM
imp closed D58008: boot-test.sh: Test many boot loader combinations..
Sat, Jul 11, 7:54 PM
imp committed rG7db502d50c1e: loader: Add xzfs support by defualt to BIOS and EFI loaders (authored by imp).
loader: Add xzfs support by defualt to BIOS and EFI loaders
Sat, Jul 11, 7:31 PM
imp committed rG86d719ae68aa: loader: Add xzfs, like gzipfs but with xz. (authored by imp).
loader: Add xzfs, like gzipfs but with xz.
Sat, Jul 11, 7:31 PM
imp committed rGc61ee49cd06a: loader: zstd based filesystem, zstdfs like gzipfs (authored by imp).
loader: zstd based filesystem, zstdfs like gzipfs
Sat, Jul 11, 7:31 PM
imp committed rGdc6c193bb4a6: loader.efi: Add xz decompression (authored by imp).
loader.efi: Add xz decompression
Sat, Jul 11, 7:30 PM
imp closed D58073: loader.efi: Add xz decompression.
Sat, Jul 11, 7:30 PM
imp updated the diff for D58008: boot-test.sh: Test many boot loader combinations..

near final version, add lots of netbooting, though we need a lot more.

Sat, Jul 11, 1:42 PM

Fri, Jul 10

imp added a comment to D58164: init(8): extract reroot transient code into reroot_seed.

Why not have /libexec/reroot and just copy that instead?

Fri, Jul 10, 9:59 PM
imp accepted D58156: tools/build: Don't set RANLIB for non-FreeBSD builds.
Fri, Jul 10, 5:48 PM
imp accepted D58153: emulators/qemu-user-static: Fix build on main.

This is good.

Fri, Jul 10, 1:49 PM
imp added a comment to D58153: emulators/qemu-user-static: Fix build on main.
diff --git a/emulators/qemu-user-static/Makefile b/emulators/qemu-user-static/Makefile
index 9521422f9f6b..8b51fb5cba46 100644
--- a/emulators/qemu-user-static/Makefile
+++ b/emulators/qemu-user-static/Makefile
@@ -1,6 +1,6 @@
 PORTNAME=      qemu
 PORTVERSION=   3.1.0
-PORTREVISION=  15
+PORTREVISION=  16
 CATEGORIES=    emulators
 PKGNAMESUFFIX= -user-static
 DIST_SUBDIR=   qemu/${PORTVERSION}
@@ -17,7 +17,7 @@ CONFLICTS_INSTALL=    qemu-user-static-devel
Fri, Jul 10, 1:38 PM
imp added a comment to D58153: emulators/qemu-user-static: Fix build on main.

These are already in 3.1-rebase branch:

commit f7eaacf0bd63f1955a357e46e0b6e3de749da74c (HEAD, bsd-user/bsd-user-rebase-3.1, bsd-user/HEAD)
Author: Siva Mahadevan <me@svmhdvn.name>
Date:   Sat Apr 11 13:46:42 2026 -0400
Fri, Jul 10, 1:36 PM
imp committed rG584ecfeb9cde: XZ kernel build cleanup (authored by imp).
XZ kernel build cleanup
Fri, Jul 10, 4:19 AM
imp committed rG45f9f6ebacff: kldxref: Add -m filag to print info about modules in one file (authored by imp).
kldxref: Add -m filag to print info about modules in one file
Fri, Jul 10, 4:19 AM
imp committed rGbcb1b157fdf9: loader: Add two new build knobs for x86 BIOS loaders (authored by imp).
loader: Add two new build knobs for x86 BIOS loaders
Fri, Jul 10, 4:19 AM
imp committed rGc8842f1d18ae: Revert "loader.efi: Trim ZFS searching for other booting options" (authored by imp).
Revert "loader.efi: Trim ZFS searching for other booting options"
Fri, Jul 10, 4:19 AM
imp added a reverting change for rG3e3fd1fde8e1: loader.efi: Trim ZFS searching for other booting options: rGc8842f1d18ae: Revert "loader.efi: Trim ZFS searching for other booting options".
Fri, Jul 10, 4:19 AM
imp committed rG1d1298269d4c: loader.efi: Simplify the code for null decompression a little (authored by imp).
loader.efi: Simplify the code for null decompression a little
Fri, Jul 10, 4:19 AM
imp closed D57902: kldxref: Add -m filag to print info about modules in one file.
Fri, Jul 10, 4:19 AM
imp closed D58072: loader: Add two new build knobs for x86 BIOS loaders.
Fri, Jul 10, 4:19 AM
imp committed rG603270b4d69e: loader.efi: Fix off by one error in size of the virtual disk (authored by imp).
loader.efi: Fix off by one error in size of the virtual disk
Fri, Jul 10, 4:19 AM
imp committed rGf273414c11e4: MINIMAL: Add device md (authored by imp).
MINIMAL: Add device md
Fri, Jul 10, 4:19 AM
imp committed rGa22fa5ec74e0: laoder.efi: Fix error in download protcol (authored by imp).
laoder.efi: Fix error in download protcol
Fri, Jul 10, 4:19 AM
imp closed D58071: Revert "loader.efi: Trim ZFS searching for other booting options".
Fri, Jul 10, 4:19 AM
imp added a reverting change for D57805: loader.efi: Trim ZFS searching for other booting options: rGc8842f1d18ae: Revert "loader.efi: Trim ZFS searching for other booting options".
Fri, Jul 10, 4:19 AM
imp closed D58070: loader.efi: Simplify the code for null decompression a little.
Fri, Jul 10, 4:19 AM
imp closed D58069: loader.efi: Fix off by one error in size of the virtual disk.
Fri, Jul 10, 4:19 AM
imp closed D58068: laoder.efi: Fix error in download protcol.
Fri, Jul 10, 4:19 AM
imp closed D58067: MINIMAL: Add device md.
Fri, Jul 10, 4:18 AM

Wed, Jul 8

imp committed rG3eb80d8d7daf: ufs: Allow read-only mounting of NetBSD FFSv2 WAPBL filesystems (authored by rbranco_suse.com).
ufs: Allow read-only mounting of NetBSD FFSv2 WAPBL filesystems
Wed, Jul 8, 5:17 AM
imp committed rGf723b28c9663: reboot: fix openlog(3) calls (authored by rbranco_suse.com).
reboot: fix openlog(3) calls
Wed, Jul 8, 5:17 AM

Tue, Jul 7

imp accepted D58010: Fix namespace listing for old NVMe devices.
Tue, Jul 7, 6:24 PM
imp accepted D58025: acpi_einj: Support for ACPI error injection.
Tue, Jul 7, 6:17 PM
imp added inline comments to D58024: acpi: Add a pseudo-bus for APEI devices to manage resources.
Tue, Jul 7, 6:16 PM
imp accepted D58026: einj: Tool to manage APEI error injection.

Looks good, one minor nit for your consideration.

Tue, Jul 7, 6:13 PM
imp requested review of D58073: loader.efi: Add xz decompression.
Tue, Jul 7, 4:15 AM
imp added a reverting change for rG3e3fd1fde8e1: loader.efi: Trim ZFS searching for other booting options: D58071: Revert "loader.efi: Trim ZFS searching for other booting options".
Tue, Jul 7, 4:15 AM
imp requested review of D58072: loader: Add two new build knobs for x86 BIOS loaders.
Tue, Jul 7, 4:15 AM
imp requested review of D58071: Revert "loader.efi: Trim ZFS searching for other booting options".
Tue, Jul 7, 4:15 AM
imp added a reverting change for D57805: loader.efi: Trim ZFS searching for other booting options: D58071: Revert "loader.efi: Trim ZFS searching for other booting options".
Tue, Jul 7, 4:15 AM
imp requested review of D58070: loader.efi: Simplify the code for null decompression a little.
Tue, Jul 7, 4:15 AM
imp requested review of D58069: loader.efi: Fix off by one error in size of the virtual disk.
Tue, Jul 7, 4:13 AM
imp requested review of D58068: laoder.efi: Fix error in download protcol.
Tue, Jul 7, 4:13 AM
imp requested review of D58067: MINIMAL: Add device md.
Tue, Jul 7, 4:12 AM

Sat, Jul 4

imp added a comment to D57931: Add sbintime.9 manual page.

Looks basically good. Just a couple of points, the biggest one is to use an approximation to help people reason and think about the quantity w/o burdening them with the exact value.

Sat, Jul 4, 11:45 PM
imp added a comment to D54954: atrtc: Prevent duplicate device attachment.

The root of the problem still hasn't been answered: why the duplicate? Why is it added twice? What's the device_add_child that gives us each of these? Is there an atrtc in device.hints?

Sat, Jul 4, 6:48 PM · drivers
imp updated the diff for D58008: boot-test.sh: Test many boot loader combinations..

powerpc64 works

Sat, Jul 4, 2:07 PM

Thu, Jul 2

imp requested review of D58008: boot-test.sh: Test many boot loader combinations..
Thu, Jul 2, 4:39 PM
imp requested review of D58007: Harmonize the cross repo advice..
Thu, Jul 2, 4:36 PM
imp accepted D57930: usb/quirks: Sort the USB mass storage quirks.
Thu, Jul 2, 12:01 PM
imp accepted D57929: usb/quirks: Add entry for Verbatim Store'n'Go.
Thu, Jul 2, 12:00 PM

Tue, Jun 30

imp committed rG6ed2f5184251: diskless(8): remove references to deleted clone_root script (authored by Kit Dallege <xaum.io@gmail.com>).
diskless(8): remove references to deleted clone_root script
Tue, Jun 30, 3:36 PM

Sat, Jun 27

imp accepted D57821: stand: Fix display offset.

A more verbose commit message would be nice :)
But the changes look OK to me, but I'm not 100% sure what I'm looking at...
But given the visuals, this is the sort of change I'd expect.

Sat, Jun 27, 9:26 PM
imp requested review of D57902: kldxref: Add -m filag to print info about modules in one file.
Sat, Jun 27, 1:28 PM

Fri, Jun 26

imp closed D57893: loader.efi: Fix build with gcc due to pointer / int issues on 32-bit build.
Fri, Jun 26, 11:15 PM
imp committed rG1fc6923e6a40: loader: Test GCC cross builds as part of universe.sh (authored by imp).
loader: Test GCC cross builds as part of universe.sh
Fri, Jun 26, 11:15 PM
imp committed rG9cb1459633a1: loader.efi: Fix build with gcc due to pointer / int issues on 32-bit build (authored by imp).
loader.efi: Fix build with gcc due to pointer / int issues on 32-bit build
Fri, Jun 26, 11:15 PM
imp added a comment to D57893: loader.efi: Fix build with gcc due to pointer / int issues on 32-bit build.

For my education: do we know in the 32-bit environment that physical addresses assuredly are below 4 GB?

Fri, Jun 26, 10:48 PM
imp added a comment to D57893: loader.efi: Fix build with gcc due to pointer / int issues on 32-bit build.

Yea. I don't care about 80 columns for the boot loader. It's obsolete and makes the code ugly. I usually wrap around 100 chars..

Fri, Jun 26, 10:33 PM
imp requested review of D57893: loader.efi: Fix build with gcc due to pointer / int issues on 32-bit build.
Fri, Jun 26, 7:58 PM
imp closed D57340: Move all the software license stuff to a central location..
Fri, Jun 26, 5:14 PM · docs
imp committed R9:6bd5860091a3: Move all the software license stuff to a central location. (authored by imp).
Move all the software license stuff to a central location.
Fri, Jun 26, 5:14 PM
imp closed D57514: policy: Cross Repo Commit Policy.
Fri, Jun 26, 5:14 PM
imp committed R9:072353ccfc5d: policy: Cross Repo Commit Policy (authored by imp).
policy: Cross Repo Commit Policy
Fri, Jun 26, 5:14 PM
imp added a comment to D57871: sys/tools/fdt/make_dtb.sh: small fixes.

Selecting a random one of theses reports...
Could you create parent / child relationships between all these requests? It will make it easier to work with and integrate if you do. Thanks!

Fri, Jun 26, 4:36 PM
imp added inline comments to D57883: sys/conf/newvers.sh: small fixes.
Fri, Jun 26, 4:17 PM
imp committed rGafee781523e4: loader.efi: Recognize new memdisk=<url> and memcd=<url> options (authored by imp).
loader.efi: Recognize new memdisk=<url> and memcd=<url> options
Fri, Jun 26, 3:00 PM
imp committed rG4e9d303c8300: pxeldr: Bump the limit by 30k for loader size (authored by imp).
pxeldr: Bump the limit by 30k for loader size
Fri, Jun 26, 3:00 PM
imp committed rG59219fc76a4b: loader.efi: efiblk_memdisk_preload passes the VirtualDisks to FreeBSD (authored by imp).
loader.efi: efiblk_memdisk_preload passes the VirtualDisks to FreeBSD
Fri, Jun 26, 3:00 PM
imp committed rG3e3fd1fde8e1: loader.efi: Trim ZFS searching for other booting options (authored by imp).
loader.efi: Trim ZFS searching for other booting options
Fri, Jun 26, 3:00 PM
imp committed rG7f5475594aab: loader.efi: Improve the trying MD messsages (authored by imp).
loader.efi: Improve the trying MD messsages
Fri, Jun 26, 3:00 PM
imp committed rGce9bfd781679: loader.efi: Refactor try_boot_device_partitions (authored by imp).
loader.efi: Refactor try_boot_device_partitions
Fri, Jun 26, 3:00 PM
imp committed rG82eb1970759d: loader.efi: Expand uefi_rootdev to probe disks (authored by imp).
loader.efi: Expand uefi_rootdev to probe disks
Fri, Jun 26, 3:00 PM
imp closed D57677: loader.efi: Recognize new memdisk=<url> and memcd=<url> options.
Fri, Jun 26, 3:00 PM
imp committed rG7140742c8c68: loader.efi: Add verbose flag to try_as_currdev (authored by imp).
loader.efi: Add verbose flag to try_as_currdev
Fri, Jun 26, 2:59 PM