Page MenuHomeFreeBSD

imp (Warner Losh)
User

Projects

User Details

User Since
Jun 2 2014, 4:20 PM (329 w, 4 d)

Recent Activity

Yesterday

imp updated the diff for D26543: Adjustments to includes for openzfs.

put nullability macro outside kernel ifdefs

Thu, Sep 24, 3:28 PM
imp added a comment to D26543: Adjustments to includes for openzfs.

This revision successfully builds and reboots, so I think it's right But since it's systm.h and we do some funky monkey business in there, I'd like more eyes on it to be sure.

Thu, Sep 24, 7:28 AM
imp updated the diff for D26543: Adjustments to includes for openzfs.

rebase, again

Thu, Sep 24, 7:26 AM
imp committed rS366104: Don't define _STANDALONE when building kernel modules..
Don't define _STANDALONE when building kernel modules.
Thu, Sep 24, 7:10 AM
imp updated the summary of D26543: Adjustments to includes for openzfs.
Thu, Sep 24, 6:47 AM
imp updated the diff for D26543: Adjustments to includes for openzfs.

rebase

Thu, Sep 24, 6:46 AM
imp committed rS366101: Create a standalone version of sys/malloc.h.
Create a standalone version of sys/malloc.h
Thu, Sep 24, 6:40 AM
imp requested review of D26543: Adjustments to includes for openzfs.
Thu, Sep 24, 6:19 AM
imp updated the diff for D26218: Integrate zstd into boot loader.

Rebase (again!)

Thu, Sep 24, 6:16 AM
imp updated the diff for D26218: Integrate zstd into boot loader.

Rebase

Thu, Sep 24, 6:12 AM

Wed, Sep 23

imp accepted D26502: RISC-V LINT kernel config.

Nice.

Wed, Sep 23, 11:30 PM
imp added inline comments to D26540: Eliminate building LINT makefiles.
Wed, Sep 23, 11:30 PM
imp added a comment to D26534: Misc compiler warning fixes in lib/libc.

btw, the rest of the changes look totally fine. Sorry to be so nitpicky over this one...

Wed, Sep 23, 11:19 PM
imp added inline comments to D26534: Misc compiler warning fixes in lib/libc.
Wed, Sep 23, 11:15 PM
imp committed rS366096: Remove stray lines.
Remove stray lines
Wed, Sep 23, 10:49 PM
imp requested review of D26540: Eliminate building LINT makefiles.
Wed, Sep 23, 10:04 PM
imp added inline comments to D26534: Misc compiler warning fixes in lib/libc.
Wed, Sep 23, 7:42 PM
imp committed rS366088: Use envvar rather than nonstandard hint. lines.
Use envvar rather than nonstandard hint. lines
Wed, Sep 23, 7:19 PM
imp committed rS366042: Work around cp breakage in current from last week.
Work around cp breakage in current from last week
Wed, Sep 23, 1:04 AM

Tue, Sep 22

imp committed rS366027: Add devctl_notify(9) man page.
Add devctl_notify(9) man page
Tue, Sep 22, 11:02 PM
imp committed rS366026: Document quoting requirements for the devctl protocol.
Document quoting requirements for the devctl protocol
Tue, Sep 22, 11:02 PM
imp committed rS366025: Document devctl_safe_quote_sb.
Document devctl_safe_quote_sb
Tue, Sep 22, 11:02 PM
imp committed rS366024: Add a devctl_process_running man page..
Add a devctl_process_running man page.
Tue, Sep 22, 11:02 PM
imp closed D26520: Document all the 'documented' devctl_* kernel functions..
Tue, Sep 22, 11:02 PM
imp added inline comments to D26435: Add rtsx driver for Realtek SD card readers..
Tue, Sep 22, 9:31 PM

Mon, Sep 21

imp requested review of D26520: Document all the 'documented' devctl_* kernel functions..
Mon, Sep 21, 11:57 PM
imp added inline comments to D26483: Add necessary include dirs & clean up style.
Mon, Sep 21, 7:41 PM
imp added inline comments to D26483: Add necessary include dirs & clean up style.
Mon, Sep 21, 7:37 PM
imp requested changes to D26435: Add rtsx driver for Realtek SD card readers..

This review is missing a lot of files (even prior versions). rtsx.c at the very least is missing
Does this driver support MMCCAM?

Mon, Sep 21, 7:24 PM
imp accepted D26509: awk: Fix subobject out-of-bounds access.
Mon, Sep 21, 6:32 PM
imp accepted D26511: Do not leak B_BARRIER..
Mon, Sep 21, 3:53 PM
imp accepted D26504: fix compiler warnings-as-errors on gcc6 in rcorder/crunchgen.

Non pmc bits look good to go

Mon, Sep 21, 6:46 AM

Thu, Sep 17

imp added a comment to D26471: Build debug kernels with -O2..

Will this screw up the tracebacks? One of the reason that I've compiled at lower O levels is to not have @#^#$Y up DEBUG kernels...

Thu, Sep 17, 9:29 PM
imp closed D26448: Move to a more conservative alloation scheme for devctl messages.
Thu, Sep 17, 5:29 PM
imp committed rS365843: Move to a more robust and conservative alloation scheme for devctl messages.
Move to a more robust and conservative alloation scheme for devctl messages
Thu, Sep 17, 5:29 PM

Wed, Sep 16

imp added a comment to D26448: Move to a more conservative alloation scheme for devctl messages.
In D26448#588627, @mjg wrote:

Given this already has support for reusing items from a global list, why uma allocation in the first place? Most notably why per-CPU caches. The current code does not scale regardless and is expensive to use, but with expected low msg rates it should be fine for the time being.

Wed, Sep 16, 8:50 PM
imp updated the summary of D26448: Move to a more conservative alloation scheme for devctl messages.
Wed, Sep 16, 8:32 PM
imp updated the diff for D26448: Move to a more conservative alloation scheme for devctl messages.

Another round of comment cleanup to make things more descriptive and less verbose.

Wed, Sep 16, 8:29 PM
imp updated the diff for D26448: Move to a more conservative alloation scheme for devctl messages.

Update some comments.

Wed, Sep 16, 8:25 PM
imp updated the diff for D26448: Move to a more conservative alloation scheme for devctl messages.

Fold in feedback from MarkJ

Wed, Sep 16, 7:26 PM
imp added inline comments to D26448: Move to a more conservative alloation scheme for devctl messages.
Wed, Sep 16, 6:04 PM
imp added a comment to D26453: Hack to install symlinks atomically..

Why do we install libgcc_s multiple times?

Wed, Sep 16, 3:54 PM
imp added a comment to D26450: Remove APM (series of commits, but shown as one for review).

You probably want to remove tools/build/options/WITHOUT_APM since that option is gone and update tools/build/options/WITHOUT_ACPI to indicate that it also governs the installation of the apm(8) userland utility. OptionalObsoleteFiles.inc probably need to take this into account also.

Wed, Sep 16, 3:30 PM
imp added a comment to D26220: Improve test coverage for sbuf.
In D26220#588231, @jmg wrote:

@jmg @imp I have seen other places where KASSERT was re-defined as

#define	KASSERT(exp,msg) assert((exp))

I think using assert should be used. It doesn't pollute stdout, generates a core dump, and is more obvious that there was a failure.

Thanks.

Wed, Sep 16, 7:15 AM · tests
imp requested review of D26450: Remove APM (series of commits, but shown as one for review).
Wed, Sep 16, 7:09 AM
imp committed rS365790: Use standard bool type, instead of non-standard boolean_t.
Use standard bool type, instead of non-standard boolean_t
Wed, Sep 16, 6:03 AM
imp added inline comments to D26448: Move to a more conservative alloation scheme for devctl messages.
Wed, Sep 16, 1:45 AM

Tue, Sep 15

imp updated the diff for D26448: Move to a more conservative alloation scheme for devctl messages.

Fix comment and silly lack of assignment. Tiny style tweaks too.

Tue, Sep 15, 11:21 PM
imp added inline comments to D26448: Move to a more conservative alloation scheme for devctl messages.
Tue, Sep 15, 11:16 PM
imp updated the test plan for D26448: Move to a more conservative alloation scheme for devctl messages.
Tue, Sep 15, 11:13 PM
imp requested review of D26448: Move to a more conservative alloation scheme for devctl messages.
Tue, Sep 15, 11:12 PM
imp committed rS365751: Include sys/types.h here.
Include sys/types.h here
Tue, Sep 15, 3:21 PM
imp added inline comments to D26428: Initial support for implementing the bootXXX.efi workaround.
Tue, Sep 15, 2:56 PM
imp added a comment to D26428: Initial support for implementing the bootXXX.efi workaround.

You description is wrong. No BIOS will boot off an EFI partition. Don't mix BIOS and UEFI firmware implementation.

Tue, Sep 15, 2:55 PM
imp accepted D26430: [PowerPC] Remove obsolete MK_LOADER_FORCE_LE.
Tue, Sep 15, 2:07 AM · PowerPC

Mon, Sep 14

imp committed rS365737: We don't need the sc_ekeys_lock in standalone environment..
We don't need the sc_ekeys_lock in standalone environment.
Mon, Sep 14, 11:51 PM
imp committed rS365735: Don't do the busy dance in icee_open/close.
Don't do the busy dance in icee_open/close
Mon, Sep 14, 11:30 PM
imp closed D26431: Don't do the busy dance in icee_open/close.
Mon, Sep 14, 11:30 PM
imp committed rS365734: Tweak what's visible in the standalone environment. We define offsetof.
Tweak what's visible in the standalone environment. We define offsetof
Mon, Sep 14, 11:28 PM
imp requested review of D26431: Don't do the busy dance in icee_open/close.
Mon, Sep 14, 10:36 PM
imp updated the diff for D26428: Initial support for implementing the bootXXX.efi workaround.

Add comment documenting why we only conditionally install bootx64.efi

Mon, Sep 14, 9:59 PM
imp added reviewers for D26428: Initial support for implementing the bootXXX.efi workaround: emaste, bcran.
Mon, Sep 14, 9:49 PM
imp requested review of D26428: Initial support for implementing the bootXXX.efi workaround.
Mon, Sep 14, 9:43 PM
imp added inline comments to D26399: [PowerPC64LE] Set up powerpc.powerpc64le architecture.
Mon, Sep 14, 7:41 PM · PowerPC
imp requested review of D26423: Integrate 4.4BSD-Lite2 changes to IOC_* definitions.
Mon, Sep 14, 5:43 PM
imp accepted D26390: Honor the FWUG value of some drives in nvmecontrol.

Looks good to me. I'd be tempted to commit the kernel and non-kernel parts separately since the kernel bits aren't directly related to the firmware downloading change, but merely facilitate it (and possibly other) uses.

Mon, Sep 14, 5:39 PM

Sat, Sep 12

imp committed rS365665: Update flp test for new diskinfo output.
Update flp test for new diskinfo output
Sat, Sep 12, 5:24 PM
imp committed rS365664: Fix trailing whitespace.
Fix trailing whitespace
Sat, Sep 12, 5:24 PM
imp committed rS365663: Make this compile again by fixing err args to have formats.
Make this compile again by fixing err args to have formats
Sat, Sep 12, 5:24 PM
imp accepted D26292: Reduce Duplication in sys/*/include files.

I think this is fine

Sat, Sep 12, 3:08 PM
imp added inline comments to D26395: cp: fall back to read/write if copy_file_range fails.
Sat, Sep 12, 2:16 AM

Fri, Sep 11

imp committed rS365645: Remove disk images / tests from alpha, sun and pc98.
Remove disk images / tests from alpha, sun and pc98
Fri, Sep 11, 11:38 PM
imp added a comment to D26340: run clang-format over vtfontcvt.c.

Is there a file which is already perfectly style(9) compliant? Is it this file?

Assuming a "perfect" file, we could then tweak the clang-format config iteratively, until we find the output which has the smallest diff, and then tweak clang-format to fix the remainder and bring the diff to 0.

Fri, Sep 11, 6:15 PM
imp added a comment to D17102: Add build-time option to boot0sio to reset terminal.

I think this is good. There's many other strings we might consider for the reset, but this is good.

Fri, Sep 11, 5:46 PM
imp accepted D26343: Improvements for src.conf(5) and build(7) man pages.

I'm happy now. Thanks for listening to my feedback.

Fri, Sep 11, 5:05 PM

Thu, Sep 10

imp accepted D26403: Disable WITNESS for spin locks by default..
Thu, Sep 10, 10:18 PM
imp added inline comments to D26343: Improvements for src.conf(5) and build(7) man pages.
Thu, Sep 10, 10:13 PM
imp committed rP548220: Disable python. This ancient version of gdb wants python2..
Disable python. This ancient version of gdb wants python2.
Thu, Sep 10, 7:04 PM
imp added a comment to D26395: cp: fall back to read/write if copy_file_range fails.

Minor nit, which could report a bad write total in some rare circumstances is the only issue I see.

Thu, Sep 10, 6:16 PM

Wed, Sep 9

imp added inline comments to D26364: stand/ficl 64-bit compatibility.
Wed, Sep 9, 11:41 PM · PowerPC
imp accepted D26381: Mark i386 as Tier 2 starting in FreeBSD 13.0..
Wed, Sep 9, 11:38 PM
imp accepted D26380: Update tier info for MIPS and sparc64..
Wed, Sep 9, 11:36 PM
imp committed rS365544: MFC r365016 | imp | 2020-08-31 17:48:23 -0600 (Mon, 31 Aug 2020) | 2 lines.
MFC r365016 | imp | 2020-08-31 17:48:23 -0600 (Mon, 31 Aug 2020) | 2 lines
Wed, Sep 9, 11:06 PM
imp committed rS365543: MFC r365015:.
MFC r365015:
Wed, Sep 9, 11:05 PM
imp committed rS365542: MFC: r365009.
MFC: r365009
Wed, Sep 9, 11:04 PM
imp committed rS365541: MFC r364824:.
MFC r364824:
Wed, Sep 9, 11:02 PM
imp committed rS365540: MFC r364725, r364726.
MFC r364725, r364726
Wed, Sep 9, 11:00 PM
imp committed rS365539: MFC: 364430:.
MFC: 364430:
Wed, Sep 9, 10:54 PM
imp committed rS365538: MFC r364424:.
MFC r364424:
Wed, Sep 9, 10:52 PM
imp committed rS365537: MFC r364359, r364360, r364361, r364362, r364364, r364370.
MFC r364359, r364360, r364361, r364362, r364364, r364370
Wed, Sep 9, 10:49 PM
imp committed rS365536: MFC r364335,r364336,r364337,r364351.
MFC r364335,r364336,r364337,r364351
Wed, Sep 9, 10:45 PM
imp committed rS365535: MFC r364291:.
MFC r364291:
Wed, Sep 9, 10:42 PM
imp committed rS365533: MFC r363408:.
MFC r363408:
Wed, Sep 9, 10:40 PM
imp committed rS365532: MFC r362664, r362665:.
MFC r362664, r362665:
Wed, Sep 9, 10:38 PM
imp committed rS365531: MFC r362420:.
MFC r362420:
Wed, Sep 9, 10:36 PM
imp committed rS365530: MFC: r361882:.
MFC: r361882:
Wed, Sep 9, 10:33 PM
imp committed rS365529: MFC: r361868:.
MFC: r361868:
Wed, Sep 9, 10:30 PM
imp committed rS365528: MFC r361867:.
MFC r361867:
Wed, Sep 9, 10:30 PM
imp committed rS365527: MFC r361673:.
MFC r361673:
Wed, Sep 9, 10:24 PM
imp committed rS365526: MFC r360993:.
MFC r360993:
Wed, Sep 9, 10:22 PM