Page MenuHomeFreeBSD

imp (Warner Losh)
User

Projects

User Details

User Since
Jun 2 2014, 4:20 PM (469 w, 4 d)

Recent Activity

Today

imp accepted D40405: Adds support for Purism coreboot keyboards .
Sat, Jun 3, 4:50 AM · Contributor Reviews (src)
imp added a comment to D40405: Adds support for Purism coreboot keyboards .

So.. looks good to me...
It would be awesome if we could automatically detect this quirk... maybe if the probe works turn the rest off? If you are up for trying that...
If not, this can go in as is...

Sat, Jun 3, 4:50 AM · Contributor Reviews (src)

Yesterday

imp added a comment to D40389: stand/boot1.efi: use the bootonce dataset as root dataset.

Though thinking about it, one could likely make the same argument as '88 and say this is existing behavior.
If you'd agree with that, then this is fine and we'll look at making things better.

Fri, Jun 2, 10:38 PM
imp added a comment to D40389: stand/boot1.efi: use the bootonce dataset as root dataset.

I think we have a bug with this, which I think we can fix as I suggested. I don't think that spa_name is ever change once it's cerated, so I think at least the error message is OK, though it doesn't specify which dataset failed.

Fri, Jun 2, 10:32 PM
imp accepted D40388: stand/loader.efi: read zfs bootonce attribute before checking currdev.
Fri, Jun 2, 10:21 PM
imp accepted D40401: vm_phys: Change the return type of vm_phys_unfree_page() to bool.
Fri, Jun 2, 8:35 PM
imp added inline comments to D40388: stand/loader.efi: read zfs bootonce attribute before checking currdev.
Fri, Jun 2, 2:38 PM
imp committed rG409594ef340b: gpart(8): Improve manual page syntax (authored by Tom Hukins <tom@FreeBSD.org>).
gpart(8): Improve manual page syntax
Fri, Jun 2, 2:45 AM
imp committed rGd275d2e3d375: gpart(8): Refer to a related manual page (authored by Tom Hukins <tom@FreeBSD.org>).
gpart(8): Refer to a related manual page
Fri, Jun 2, 2:45 AM
imp committed rG2bcbf4d83146: camcontrol(8): Use simpler language (authored by Tom Hukins <tom@FreeBSD.org>).
camcontrol(8): Use simpler language
Fri, Jun 2, 2:44 AM
imp committed rG2675b8bd3d94: camcontrol(8): Add manual page cross references (authored by Tom Hukins <tom@FreeBSD.org>).
camcontrol(8): Add manual page cross references
Fri, Jun 2, 2:44 AM
imp committed rG3e1af044c9b3: cam(3): Add a manual page cross reference (authored by Tom Hukins <tom@FreeBSD.org>).
cam(3): Add a manual page cross reference
Fri, Jun 2, 2:44 AM
imp committed rGfe4fa9326928: fstyp: Fix typos (authored by ehaouas_noos.fr).
fstyp: Fix typos
Fri, Jun 2, 2:42 AM
imp committed rG56ca9ef09206: mfiutil: Fix typos (authored by ehaouas_noos.fr).
mfiutil: Fix typos
Fri, Jun 2, 2:42 AM
imp committed rG663b1be814c5: efidp: Fix typos (authored by ehaouas_noos.fr).
efidp: Fix typos
Fri, Jun 2, 2:42 AM
imp committed rGe5263025de1a: fsck_ffs: Fix typos (authored by ehaouas_noos.fr).
fsck_ffs: Fix typos
Fri, Jun 2, 2:42 AM
imp committed rGe4861dc85799: ipfw/ipfw2: Fix typos (authored by ehaouas_noos.fr).
ipfw/ipfw2: Fix typos
Fri, Jun 2, 2:42 AM
imp committed rGb03b271bb73b: cdcontrol: Fix typos (authored by ehaouas_noos.fr).
cdcontrol: Fix typos
Fri, Jun 2, 2:42 AM
imp committed rGd0b0bc37a3a5: ports(7): '*-list' targets: Add/fix doc on whether they are recursive (authored by olce.freebsd_certner.fr).
ports(7): '*-list' targets: Add/fix doc on whether they are recursive
Fri, Jun 2, 2:39 AM
imp committed rGf6a119cf8d23: zfsd: Fix typo in comment (authored by ehaouas_noos.fr).
zfsd: Fix typo in comment
Fri, Jun 2, 2:37 AM
imp committed rGa57ca37dd184: iovctl: Fix typos (authored by ehaouas_noos.fr).
iovctl: Fix typos
Fri, Jun 2, 2:37 AM
imp committed rGb152ff4c1e74: makefs: Fix typos (authored by ehaouas_noos.fr).
makefs: Fix typos
Fri, Jun 2, 2:37 AM
imp committed rG1e95a9a41c21: mld6query: Fix typos (authored by ehaouas_noos.fr).
mld6query: Fix typos
Fri, Jun 2, 2:37 AM
imp committed rGa9e160c38fe1: cron/lib: Fix typos (authored by ehaouas_noos.fr).
cron/lib: Fix typos
Fri, Jun 2, 2:37 AM
imp committed rGc77cc8462a11: mountd: Fix typos (authored by ehaouas_noos.fr).
mountd: Fix typos
Fri, Jun 2, 2:37 AM
imp committed rGed96987b4cfa: mfiuitl: Spell acquire correctly (authored by imp).
mfiuitl: Spell acquire correctly
Fri, Jun 2, 2:37 AM
imp committed rGe71b32940258: route6d: Fix typos (authored by ehaouas_noos.fr).
route6d: Fix typos
Fri, Jun 2, 2:37 AM
imp committed rG8883fd2c4b86: bsnmpd/modules/snmp_lm75: Fix typos (authored by ehaouas_noos.fr).
bsnmpd/modules/snmp_lm75: Fix typos
Fri, Jun 2, 2:37 AM
imp committed rG1f0cd2d9ce73: wlandebug: Fix typos (authored by ehaouas_noos.fr).
wlandebug: Fix typos
Fri, Jun 2, 2:37 AM
imp committed rG6372f2c8a884: rpc.lockd: Fix typos (authored by ehaouas_noos.fr).
rpc.lockd: Fix typos
Fri, Jun 2, 2:37 AM
imp committed rGb66b2c4d9b3f: ifconfig: Fix typos (authored by ehaouas_noos.fr).
ifconfig: Fix typos
Fri, Jun 2, 2:37 AM
imp committed rG843fe4892e3c: ipf: Fix typos (authored by ehaouas_noos.fr).
ipf: Fix typos
Fri, Jun 2, 2:37 AM
imp committed rGd15f57a29d78: camcontrol: Fix typos (authored by ehaouas_noos.fr).
camcontrol: Fix typos
Fri, Jun 2, 2:37 AM
imp committed rG589fe499b72b: nvmecontrol: Fix typos (authored by ehaouas_noos.fr).
nvmecontrol: Fix typos
Fri, Jun 2, 2:37 AM
imp committed rGe095cbab2f81: ipf/ipfstat: Fix typos (authored by ehaouas_noos.fr).
ipf/ipfstat: Fix typos
Fri, Jun 2, 2:37 AM
imp committed rG05d85d778124: lpr: Fix typos (authored by ehaouas_noos.fr).
lpr: Fix typos
Fri, Jun 2, 2:36 AM
imp committed rG136a9bb4e348: hastd: Fix typos (authored by ehaouas_noos.fr).
hastd: Fix typos
Fri, Jun 2, 2:36 AM
imp committed rG34181db8bcbf: cxgbetool: Fix typos (authored by ehaouas_noos.fr).
cxgbetool: Fix typos
Fri, Jun 2, 2:36 AM
imp committed rG8b223768d19d: bsnmpd/tools/libbsnmptools: Fix typos (authored by ehaouas_noos.fr).
bsnmpd/tools/libbsnmptools: Fix typos
Fri, Jun 2, 2:36 AM
imp committed rGb8b97d31bda1: pmcstat: Fix typos (authored by ehaouas_noos.fr).
pmcstat: Fix typos
Fri, Jun 2, 2:36 AM
imp committed rGde8b490010ad: bsnmpd/modules/snmp_hostres: Fix typos (authored by ehaouas_noos.fr).
bsnmpd/modules/snmp_hostres: Fix typos
Fri, Jun 2, 2:36 AM
imp committed rG8c9946be5265: bsnmpd/modules/snmp_bridge: Fix typos (authored by ehaouas_noos.fr).
bsnmpd/modules/snmp_bridge: Fix typos
Fri, Jun 2, 2:36 AM
imp committed rG66ebda7a04f9: bluetooth: Fix typos (authored by ehaouas_noos.fr).
bluetooth: Fix typos
Fri, Jun 2, 2:36 AM
imp committed rG0dc159ced718: bhyve: Fix typos (authored by ehaouas_noos.fr).
bhyve: Fix typos
Fri, Jun 2, 2:36 AM
imp committed rG0939cf32c0c1: ipf/libipf: Fix typos (authored by ehaouas_noos.fr).
ipf/libipf: Fix typos
Fri, Jun 2, 2:35 AM

Thu, Jun 1

imp accepted D40387: <sys/memrange.h>: Include <sys/ioccom.h>..

Since it has ioctl definitions, this is correct since you aren't supposed to include ioccom.h in user code.

Thu, Jun 1, 11:40 PM
imp added a comment to D39873: Add gve, the driver for Google Virtual NIC (gVNIC).

I have a bunch of silly style things that my automated script catches. Please consider fixing them.

Thu, Jun 1, 9:50 PM
imp accepted D40329: rc(8): document how to reload rc's configuration.
Thu, Jun 1, 8:15 PM · manpages, rc
imp accepted D40367: bsdinstall: remove sendmail hardening option.

I like it. 1 down, 9 to go to make Robert happy :)

Thu, Jun 1, 6:08 PM
imp accepted D37574: nlsysevent: add a genetlink(4) module to report kernel events.

I think this approach is an innovative way to cope with things.

Thu, Jun 1, 6:07 PM
imp accepted D37573: devctl: allow to register a hook to receive the events.
Thu, Jun 1, 6:06 PM
imp added a comment to D40375: loader: BIOS loader should not build framebuffer support by default.

So I think this is a great next step.
I'd love gfx to be 100% optional, but there's still some interdependencies with lua and 4th that make that much harder than it needs to be.
It might also be better to move the framebuffer stuff more into vbe.c since that might allow fewer ifdefs, but I've not delved enough to know if that's really a good idea.

Thu, Jun 1, 4:55 PM

Wed, May 31

imp added a comment to D38459: timerfd: Add native support for Linux's timerfd.
In D38459#918469, @kib wrote:
In D38459#918467, @imp wrote:

I have code that automatically translates new system calls between host/target for bsd-user (though I'm not quite ready to commit it).
ioctl is possible, but has a lot more exceptional cases so is harder to do automatically. There's no automated annotation like there is for system calls.
The 'generic interfaces' require that I go and create annotations for each of the 'op codes' in that, because that doesn't exist in our current annotation.

So having a few extra system calls means they will be annotated and my job of getting it to work in bsd-user and others wanting to do automatic translation is easier.

For system calls you do need annotations, you cannot properly understand the purpose of any pointer passed to syscall otherwise. Is it in, out, in/out, or even just an abstract address like mmap/munmap/madvise arguments?

Wed, May 31, 7:43 PM · linuxkpi, Linux Emulation
imp added a comment to D40260: Import vixie cron 4.0.

I'd think that doing a vendor branch with OpenBSD as the upstream might be ideal.
This code seems mostly fine, though, and I'm generally on board with the idea.

Wed, May 31, 7:21 PM
imp committed rG0ec220df526d: tap(4): allow full-duplex and non-zero speed (authored by Alexandre Snarskii <snar@snar.spb.ru>).
tap(4): allow full-duplex and non-zero speed
Wed, May 31, 3:55 PM

Tue, May 30

imp added a comment to D40233: website: Update Software License Policy examples.

Sorry I missed this, but we should just remove this entirely from here. It duplicates info elsewhere. I'll take care of doing that.

Tue, May 30, 11:40 PM
imp added a comment to D38459: timerfd: Add native support for Linux's timerfd.

I have code that automatically translates new system calls between host/target for bsd-user (though I'm not quite ready to commit it).
ioctl is possible, but has a lot more exceptional cases so is harder to do automatically. There's no automated annotation like there is for system calls.
The 'generic interfaces' require that I go and create annotations for each of the 'op codes' in that, because that doesn't exist in our current annotation.

Tue, May 30, 10:00 PM · linuxkpi, Linux Emulation

Mon, May 29

imp added inline comments to D40314: kern: mountroot: add a mountroot directive to reboot.
Mon, May 29, 2:30 AM

Fri, May 26

imp added inline comments to D40261: ci: Add basic pull request checker.
Fri, May 26, 1:02 AM

Thu, May 25

imp added reviewers for D40274: flua: add libfetch functionality: kevans, imp.
Thu, May 25, 11:24 PM
imp accepted D40144: Add deprecation notices to publickey(5) tools.

I believe all of these are good to remove given the shakiness of their crypto underpinnings

Thu, May 25, 8:16 PM
imp committed rG46927f674466: stand/efi/eficom: Free comc_port if we can't find the serial port (authored by imp).
stand/efi/eficom: Free comc_port if we can't find the serial port
Thu, May 25, 4:35 AM
imp closed D40223: stand/efi/eficom: Free comc_port if we can't find the serial port.
Thu, May 25, 4:35 AM
imp committed rGe5d4e036f247: stand/efi/eficom: Make aarch64 compat code probe correctly (authored by imp).
stand/efi/eficom: Make aarch64 compat code probe correctly
Thu, May 25, 4:35 AM
imp closed D40222: stand/efi/eficom: Make aarch64 compat code probe correctly.
Thu, May 25, 4:34 AM
imp committed rG42b0b7a926e3: stand/efi/eficom: Don't allow this for !HYPERV machines (authored by imp).
stand/efi/eficom: Don't allow this for !HYPERV machines
Thu, May 25, 4:34 AM
imp closed D40221: stand/efi/eficom: Don't allow this for !HYPERV machines.
Thu, May 25, 4:34 AM
imp committed rGf28dff43ad62: stand/efi/eficom: better handling of absent device (authored by imp).
stand/efi/eficom: better handling of absent device
Thu, May 25, 4:34 AM
imp closed D40220: stand/efi/eficom: better handling of absent device.
Thu, May 25, 4:34 AM
imp committed rG2efbc8e2840f: stand/efi/smbios: Move detection of smbios earlier. (authored by imp).
stand/efi/smbios: Move detection of smbios earlier.
Thu, May 25, 4:34 AM
imp closed D40219: stand/efi/smbios: Move detection of smbios earlier..
Thu, May 25, 4:34 AM

Wed, May 24

imp added inline comments to D40261: ci: Add basic pull request checker.
Wed, May 24, 10:46 PM
imp requested review of D40261: ci: Add basic pull request checker.
Wed, May 24, 10:28 PM

Tue, May 23

imp accepted D40244: efi: Update efi_phys_to_kva to accept the size of the object being mapped..

I like it. But let's get Andy and kib to sign off on it too...

Tue, May 23, 6:02 PM
imp added a comment to D40191: build: Ensure assym.inc and offset.inc are generated in proper order..

Your conclusion is valid only for meta mode. For non-meta mode, beforedepend is always buiilt before beforebuild, even if you aren't generating the .depend files. So your logic doesn't match the code, and having an expliict comment about why both isbetter. And that disccitnction should be exxplicitly called out because otherwises it looks redundant to people that know the code and they might remove it if the justistifcaion isn't there with specificity (and not thte logical conclusion, but the actual implementation). It tripped me up and I've been looking at this stuf for 20 years...

Tue, May 23, 10:50 AM
imp added inline comments to D40190: build: Fix for sporadic build failures..
Tue, May 23, 9:19 AM
imp added a comment to D40219: stand/efi/smbios: Move detection of smbios earlier..

hm, do we actually need this preprocessor #if statement?

Tue, May 23, 9:12 AM
imp accepted D40225: motd: Adapt with recent changes..

Nice.. there was a freebsd-version phabricator or pull request that can use these REs instead of the badly broken ones there now.

Tue, May 23, 5:00 AM
imp requested changes to D40190: build: Fix for sporadic build failures..
Tue, May 23, 2:52 AM
imp added a comment to D40190: build: Fix for sporadic build failures..
.if defined(KERNBUILDDIR)
.PATH: ${KERNBUILDDIR}
CFLAGS+=        -I${KERNBUILDDIR}
.for _src in ${SRCS:Mopt_*.h}
CLEANFILES+=    ${_src}
.if !target(${_src})
${_src}:
        ln -sf ${KERNBUILDDIR}/${_src} ${.TARGET}
.endif
.endfor
.else
.for _src in ${SRCS:Mopt_*.h}
CLEANFILES+=    ${_src}
.if !target(${_src})
${_src}:
        :> ${.TARGET}
.endif
.endfor
.endif
Tue, May 23, 2:50 AM
imp added inline comments to D40190: build: Fix for sporadic build failures..
Tue, May 23, 2:12 AM
imp added a comment to D40191: build: Ensure assym.inc and offset.inc are generated in proper order..

Ok. A comment about why is good for me.. I should have looked more deeply. Thanks @sjg...

Tue, May 23, 12:22 AM

Mon, May 22

imp updated subscribers of D40191: build: Ensure assym.inc and offset.inc are generated in proper order..

@imp : Get me right: Maybe I need to += them to a new variable?

When you have "beforedepend:" inside a .if conditional, is that respected?

What I meant to code is:

When these files are needed, assym.inc and offset.inc, they need to happen beforedepend and beforebuild.

There is no problem when using -j1 . I only saw this occasionally when using -jXX .

Mon, May 22, 11:10 PM
imp added a comment to D40191: build: Ensure assym.inc and offset.inc are generated in proper order..
In D40191#915079, @kib wrote:

Which modules need .inc files? For amd64, I cannot think about any except efirt.ko and might be linux.ko. You incur the overhead to generate the files to all modules, from my reading.

Mon, May 22, 11:06 PM
imp added reviewers for D40223: stand/efi/eficom: Free comc_port if we can't find the serial port: kevans, emaste, tsoome.
Mon, May 22, 10:33 PM
imp added reviewers for D40222: stand/efi/eficom: Make aarch64 compat code probe correctly: emaste, tsoome, kevans.
Mon, May 22, 10:32 PM
imp added reviewers for D40221: stand/efi/eficom: Don't allow this for !HYPERV machines: kevans, emaste, tsoome.
Mon, May 22, 10:32 PM
imp added reviewers for D40220: stand/efi/eficom: better handling of absent device: kevans, tsoome, emaste.
Mon, May 22, 10:31 PM
imp added reviewers for D40219: stand/efi/smbios: Move detection of smbios earlier.: tsoome, emaste, kevans.
Mon, May 22, 10:30 PM
imp requested review of D40223: stand/efi/eficom: Free comc_port if we can't find the serial port.
Mon, May 22, 10:28 PM
imp requested review of D40222: stand/efi/eficom: Make aarch64 compat code probe correctly.
Mon, May 22, 10:28 PM
imp requested review of D40221: stand/efi/eficom: Don't allow this for !HYPERV machines.
Mon, May 22, 10:28 PM
imp requested review of D40219: stand/efi/smbios: Move detection of smbios earlier..
Mon, May 22, 10:28 PM
imp requested review of D40220: stand/efi/eficom: better handling of absent device.
Mon, May 22, 10:28 PM
imp accepted D40197: powerd: Don't restore original frequency in rc script; powerd does that itself.
Mon, May 22, 1:43 AM

Sun, May 21

imp added a comment to D40193: kernel: Add automation to sort all constructors and destructors at compile time..

I'll have to study this in detail... it's a bigger change than I thought it would be...

Sun, May 21, 4:56 PM
imp added a comment to D40192: build: Add missing dependencies when building kernel for amd64..

It would be better if we depended on the header files directly... but if these really are files otherwise not mentioned in the build system and are purely a side effect of the o creation then this is goid.

Sun, May 21, 4:50 PM
imp added a comment to D40191: build: Ensure assym.inc and offset.inc are generated in proper order..

Do you really need both? Before depend is how we do all the other ones like this... unless something has changed that I missed

Sun, May 21, 4:48 PM

Sat, May 20

imp added a comment to D40177: Improve header self-containment.
In D40177#914781, @imp wrote:

There's a general preference to include sys/_types.h instead of sys/types.h

It looks like including sys/_types.h does not define types like uint32_t and uint64_t. I still get compilation errors for every file in this review when replacing sys/types.h with sys/_types.h.

Sat, May 20, 3:37 PM
imp added a comment to D40183: build: Reduce the cost of supporting NO<INET|INET6|IP>* variants of the kernel..

I'm not sure I like this... I'm not a fan of disabling warnings since it could hide other issues that creep in...

Sat, May 20, 2:59 PM