Page MenuHomeFreeBSD

imp (Warner Losh)
User

Projects

User Details

User Since
Jun 2 2014, 4:20 PM (367 w, 4 d)

Recent Activity

Today

imp added inline comments to D30815: hz.9: update stathz for current usage.
Fri, Jun 18, 8:16 PM
imp added inline comments to D30815: hz.9: update stathz for current usage.
Fri, Jun 18, 7:25 PM
imp updated the diff for D30815: hz.9: update stathz for current usage.

ah, drop callout xr

Fri, Jun 18, 7:19 PM
imp added a comment to D30815: hz.9: update stathz for current usage.

Added kib based on his observations on my original commit.

Fri, Jun 18, 7:18 PM
imp added a reviewer for D30815: hz.9: update stathz for current usage: kib.
Fri, Jun 18, 7:18 PM
imp updated the diff for D30815: hz.9: update stathz for current usage.

add in kib's observations.

Fri, Jun 18, 7:17 PM
imp updated the diff for D30815: hz.9: update stathz for current usage.

Update, per jhb@ review, adopting his wording...

Fri, Jun 18, 6:16 PM
imp added a reviewer for D30815: hz.9: update stathz for current usage: jhb.
Fri, Jun 18, 3:52 PM
imp requested review of D30815: hz.9: update stathz for current usage.
Fri, Jun 18, 3:51 PM
imp committed R10:7bd295750b13: NOTES: fix typo (authored by imp).
NOTES: fix typo
Fri, Jun 18, 3:22 PM
imp added a comment to D30802: man9: add hz(9) and hardclock(9).


is what it sometimes feels to work on the time code.

Fri, Jun 18, 3:17 PM
imp committed R9:8e3f48400a61: arch-handbook: reformat scsi chapter one sentence per line before editing. (authored by imp).
arch-handbook: reformat scsi chapter one sentence per line before editing.
Fri, Jun 18, 3:08 PM
imp committed R10:4c0bc591466f: man9: add hz(9) and hardclock(9) (authored by imp).
man9: add hz(9) and hardclock(9)
Fri, Jun 18, 2:44 PM
imp closed D30802: man9: add hz(9) and hardclock(9).
Fri, Jun 18, 2:44 PM
imp closed D30804: NOTES: Update the HZ entry with latest advice..
Fri, Jun 18, 2:44 PM
imp committed R10:0f882bb14a0e: NOTES: Update the HZ entry with latest advice. (authored by imp).
NOTES: Update the HZ entry with latest advice.
Fri, Jun 18, 2:44 PM
imp added a comment to D30812: Add support for -c option to sha256sum et.al..

Also, could you you use arc to upload this, or do a diff -U999999 so we can see more of the context?

Fri, Jun 18, 2:28 PM
imp updated the diff for D30802: man9: add hz(9) and hardclock(9).

update based on phk's feedback

Fri, Jun 18, 1:29 PM
imp added a comment to D30762: regulator: Add manpage this framework.

Couple of nits.

Fri, Jun 18, 12:50 PM
imp added a comment to D30297: arm64/nexus: use actual PA range for I/O memory limit.

The nexus parts look good. Don't know if the determination of max address is right....

Fri, Jun 18, 4:03 AM

Yesterday

imp added a comment to D30805: vmm: Fix ivrs_drv device_printf usage.
In D30805#692800, @jhb wrote:

Wait, how did this compile exactly? Does it stop at the first invalid character so that '\008' becomes '\0' and '8'?

Thu, Jun 17, 11:24 PM
imp accepted D30808: rman: Remove an outdated comment that no longer applies.
Thu, Jun 17, 11:22 PM
imp accepted D30806: Improved language in devmatch.

Change looks good to me:

Thu, Jun 17, 9:33 PM
imp accepted D30805: vmm: Fix ivrs_drv device_printf usage.
Thu, Jun 17, 9:31 PM
imp committed R10:6a836ea741c7: config(8): Remove obsolete 'config' directive. (authored by imp).
config(8): Remove obsolete 'config' directive.
Thu, Jun 17, 9:26 PM
imp updated the diff for D30802: man9: add hz(9) and hardclock(9).

basically rewrite hz(9): it now doesn't have anything but the most trivial bits
from NetBSD, so drop the NetBSD copyright on hz.9 as not relevant.

Thu, Jun 17, 8:46 PM
imp committed R10:a19bd307bda8: man9: Sort unr in Makefile MLINKS (authored by imp).
man9: Sort unr in Makefile MLINKS
Thu, Jun 17, 7:57 PM
imp committed R10:5851680bcabe: style(9): Add advice about $FreeBSD$ (authored by imp).
style(9): Add advice about $FreeBSD$
Thu, Jun 17, 7:56 PM
imp closed D30789: style(9): Add advice about $FreeBSD$.
Thu, Jun 17, 7:56 PM
imp updated the diff for D30804: NOTES: Update the HZ entry with latest advice..

Rewrite again to address review suggestions and concerns.

Thu, Jun 17, 7:51 PM
imp added inline comments to D30804: NOTES: Update the HZ entry with latest advice..
Thu, Jun 17, 5:04 PM
imp added inline comments to D30802: man9: add hz(9) and hardclock(9).
Thu, Jun 17, 4:53 PM
imp added a comment to D30802: man9: add hz(9) and hardclock(9).
In D30802#692635, @mav wrote:

Now all three routines hardclock(), statclock() and profclock() are called from the same source of handleevents() in kern_clocksource.c according to eventtimers(4), driven by whatever hardware available on specific system (periodic or one-shot, global or per-cpu, etc), but in any case trying to emulate legacy hz, stathz and profhz rates as much as possible by reprogramming the hardware via eventtimers(9) KPI.

Thu, Jun 17, 4:47 PM
imp updated the diff for D30802: man9: add hz(9) and hardclock(9).

Update to more closely match FreeBSD's implementation, as noted by
mav@. Hopefully this gets closer, but if not...

Thu, Jun 17, 4:45 PM
imp added inline comments to D30802: man9: add hz(9) and hardclock(9).
Thu, Jun 17, 4:41 PM
imp committed R9:b7385189ef01: committers-guide: Strongly suggest careful review of all pull requests (authored by imp).
committers-guide: Strongly suggest careful review of all pull requests
Thu, Jun 17, 4:39 PM
imp added inline comments to D30789: style(9): Add advice about $FreeBSD$.
Thu, Jun 17, 4:37 PM
imp updated the diff for D30789: style(9): Add advice about $FreeBSD$.

Try to address ceri's concern

Thu, Jun 17, 4:30 PM
imp added inline comments to D30798: aacraid: reduce max I/O size to avoid DMA issues.
Thu, Jun 17, 4:16 PM
imp added inline comments to D30799: aacraid: log DMA failures.
Thu, Jun 17, 4:15 PM
imp added a comment to D30798: aacraid: reduce max I/O size to avoid DMA issues.

This is similar to the hacks we've done elsewhere in the system. Does it need to be also limited by MAXPHYS?

Thu, Jun 17, 4:15 PM
imp requested review of D30804: NOTES: Update the HZ entry with latest advice..
Thu, Jun 17, 4:06 PM
imp updated the diff for D30802: man9: add hz(9) and hardclock(9).

more / better / vm

Thu, Jun 17, 4:06 PM
imp abandoned D30801: DUPLICATE man9: add hz(9) and hardclock(9).

accidentally created 2. junking this one.

Thu, Jun 17, 3:39 PM
imp retitled D30801: DUPLICATE man9: add hz(9) and hardclock(9) from man9: add hz(9) and hardclock(9) to DUPLICATE man9: add hz(9) and hardclock(9).
Thu, Jun 17, 3:39 PM
imp added reviewers for D30802: man9: add hz(9) and hardclock(9): mav, phk.
Thu, Jun 17, 3:39 PM
imp requested review of D30802: man9: add hz(9) and hardclock(9).
Thu, Jun 17, 3:38 PM
imp requested review of D30801: DUPLICATE man9: add hz(9) and hardclock(9).
Thu, Jun 17, 3:37 PM
imp updated the diff for D30789: style(9): Add advice about $FreeBSD$.

take up allanjude's suggestion, with a tweak or two (sorry allan,
I did this before I saw your review :)

Thu, Jun 17, 2:55 PM
imp committed R10:0a99422970d7: Move mips and arm to 1000Hz by default. (authored by imp).
Move mips and arm to 1000Hz by default.
Thu, Jun 17, 2:01 AM
imp updated the diff for D30789: style(9): Add advice about $FreeBSD$.

Add some additional, relevant advice.

Thu, Jun 17, 12:18 AM

Wed, Jun 16

imp updated the diff for D30794: committers-guide: Strongly suggest careful review of all pull requests.

more advice

Wed, Jun 16, 10:38 PM
imp requested review of D30794: committers-guide: Strongly suggest careful review of all pull requests.
Wed, Jun 16, 10:34 PM
imp committed R9:8d6cf88d2faa: committers-guide: Add note to check for default anonymous github names (authored by imp).
committers-guide: Add note to check for default anonymous github names
Wed, Jun 16, 10:17 PM
imp committed R9:563afbd6f0ea: committer-guide: Add an anchor for the how to land a github pull request… (authored by imp).
committer-guide: Add an anchor for the how to land a github pull request…
Wed, Jun 16, 9:37 PM
imp added a comment to D30793: powerpc64, powerpc64le: ZFS support as kernel builtin.

That is, I'd rather see ZFS64

include GENERIC64
options ZFS

etc

Wed, Jun 16, 9:25 PM · PowerPC
imp added a comment to D30793: powerpc64, powerpc64le: ZFS support as kernel builtin.

I'd really rather we didn't do this... I don't think it's a good idea....

Wed, Jun 16, 9:24 PM · PowerPC
imp added a comment to D30789: style(9): Add advice about $FreeBSD$.

Tweaked a little.
A bit torn on whether to move the bulk of the wording changes up or not...

Wed, Jun 16, 5:21 PM
imp updated the diff for D30789: style(9): Add advice about $FreeBSD$.

Wording tweak from bcr
Use .Li markup as used elsewhere for $FreeBSD$
Add ", if applicable" to an earlier mention of $FreeBSD$

Wed, Jun 16, 5:20 PM
imp updated the diff for D30789: style(9): Add advice about $FreeBSD$.

s/can/should/

Wed, Jun 16, 3:46 PM
imp committed R9:304a5e375433: port-handbook: $FreeBSD$ was removed from the ports tree, remove it here (authored by imp).
port-handbook: $FreeBSD$ was removed from the ports tree, remove it here
Wed, Jun 16, 3:45 PM
imp requested review of D30789: style(9): Add advice about $FreeBSD$.
Wed, Jun 16, 3:39 PM
imp added inline comments to D30786: rk805: add system poweroff support.
Wed, Jun 16, 3:02 PM
imp added inline comments to D30786: rk805: add system poweroff support.
Wed, Jun 16, 3:01 PM
imp committed R9:3da6865c14b6: committers-guide: git always requires a clean tree to rebase. (authored by imp).
committers-guide: git always requires a clean tree to rebase.
Wed, Jun 16, 2:55 PM
imp committed R9:8dd6ba22afde: committers-guide: fix thinko: this should be --ff-only to match elsewhere (authored by imp).
committers-guide: fix thinko: this should be --ff-only to match elsewhere
Wed, Jun 16, 2:54 PM
imp accepted D30774: linux(4): Retire linux_kplatform..

While FreeBSD can run on 486 and 586 class cores, Linux has long ago made the choice to compile for 686 and newer cores only in its popular distributions. FreeBSD changed its default to i686 for 13 as well.
One in theory could run a 486 or 586 binary on a machine of that class. However, that's such a odd-ball combination I'm virtually certain has seen no testing that this is fine.

Wed, Jun 16, 2:49 PM
imp added inline comments to D30786: rk805: add system poweroff support.
Wed, Jun 16, 2:35 PM
imp committed R9:1962be9bebf7: Change Docbook to AsciiDoc in the contributing article. (authored by imp).
Change Docbook to AsciiDoc in the contributing article.
Wed, Jun 16, 2:51 AM

Tue, Jun 15

imp accepted D30779: vn_fullpath.9: update args after rev 364633.

From a manpage / markup perspective it looks good.
Also, this matches the current function signature.

Tue, Jun 15, 8:54 PM
imp committed R10:1fbd574e87e6: u3g: Note range of GOBI devices (authored by imp).
u3g: Note range of GOBI devices
Tue, Jun 15, 4:22 PM
imp committed R9:2c7165edbaf2: committers-guide: wordsmith the basics with the links a little. (authored by imp).
committers-guide: wordsmith the basics with the links a little.
Tue, Jun 15, 4:43 AM
imp committed R9:bccb39375bab: comitter-guide: Add link to git for computer scientists (authored by imp).
comitter-guide: Add link to git for computer scientists
Tue, Jun 15, 1:17 AM

Mon, Jun 14

imp committed R10:df4e97876513: relnotes: fix wording for gconcat entry. (authored by imp).
relnotes: fix wording for gconcat entry.
Mon, Jun 14, 11:54 PM
imp accepted D28467: Emit an error when we seen absolute paths to .o files.

Given the additional testing reported, I think this is good...

Mon, Jun 14, 11:42 PM
imp accepted D30763: spl: Unbreak crossbuild after f20893853e8e.
Mon, Jun 14, 9:35 PM
imp closed D29632: hptnr: Store the .o files directly in the repo.
Mon, Jun 14, 8:05 PM
imp committed R10:dd3fd6b85bcc: gconcat append: should be in release notes (authored by imp).
gconcat append: should be in release notes
Mon, Jun 14, 5:46 PM
imp committed R10:d575e81fbcfa: gconcat: Implement new online append feature (authored by noah.bergbauer_tum.de).
gconcat: Implement new online append feature
Mon, Jun 14, 5:43 PM
imp committed R9:09d6adaf27ed: committer-guide: Add link to migration article (authored by imp).
committer-guide: Add link to migration article
Mon, Jun 14, 5:38 PM
imp committed R10:070264ccdf98: u3g: Add reference to gobi_loader port (authored by imp).
u3g: Add reference to gobi_loader port
Mon, Jun 14, 4:20 AM

Sun, Jun 13

imp committed R10:efec757b2042: bhyve: enhance debug info for memory range clash (authored by crowston_protonmail.com).
bhyve: enhance debug info for memory range clash
Sun, Jun 13, 10:44 PM
imp closed D29696: bhyve: enhance debug info for memory range clash.
Sun, Jun 13, 10:44 PM
imp closed D22938: [new port] systuils/gobi_loader: Firmware Loader for Qualcomm Gobi USB Chipsets.
Sun, Jun 13, 8:24 PM
imp committed R11:eaaf120a0f21: systuils/gobi_loader: Firmware Loader for Qualcomm Gobi USB Chipsets (authored by zarychtam_plan-b.pwste.edu.pl).
systuils/gobi_loader: Firmware Loader for Qualcomm Gobi USB Chipsets
Sun, Jun 13, 8:24 PM
imp accepted D22938: [new port] systuils/gobi_loader: Firmware Loader for Qualcomm Gobi USB Chipsets.
Sun, Jun 13, 8:01 PM
imp accepted D27735: cam: don't lock while handling an AC_UNIT_ATTENTION (da).

I believe this is probably right. The comment deleted was one I added as I was auditing things...
I didn't have good test case to check.

Sun, Jun 13, 7:49 PM
imp committed R10:d21c884e52eb: USB/U3G: Added Panasonic CF-F9 GOBI 3G modem to U3G module. (authored by tomek_cedro.info).
USB/U3G: Added Panasonic CF-F9 GOBI 3G modem to U3G module.
Sun, Jun 13, 4:24 PM
imp committed R10:bb130ff39747: u3g: Document Panasonic CF-F9 GOBI support (authored by imp).
u3g: Document Panasonic CF-F9 GOBI support
Sun, Jun 13, 4:24 PM
imp committed R10:f06fa6f88733: syslogd: fix WITHOUT_INET builds (authored by akhramov_pm.me).
syslogd: fix WITHOUT_INET builds
Sun, Jun 13, 4:29 AM
imp committed R10:7cf9caf294ce: updating: note recent removals (authored by imp).
updating: note recent removals
Sun, Jun 13, 4:22 AM

Sat, Jun 12

imp accepted D30750: scsi_sg: get rid of unused include.sg driver does not depends on Linuxulator any more..
Sat, Jun 12, 11:37 PM

Fri, Jun 11

imp closed D30739: Move the developer-centric bits from handbook/mirrors to committers-guide.
Fri, Jun 11, 10:14 PM
imp committed R9:bcbdcf52ce65: Move the developer-centric bits from handbook/mirrors to committers-guide (authored by imp).
Move the developer-centric bits from handbook/mirrors to committers-guide
Fri, Jun 11, 10:14 PM
imp added a comment to D30736: Remove 'make update'..

books/handbook/mirrors/_index.adoc:# make update SVN_UPDATE=yes

Fri, Jun 11, 8:54 PM
imp added a comment to D30736: Remove 'make update'..

Does this need companion commits to the FreeBSD handbook or related docs?

Fri, Jun 11, 8:53 PM
imp committed R10:cd7de223769a: Remove an manpage (authored by imp).
Remove an manpage
Fri, Jun 11, 8:41 PM
imp committed R10:7700494d9603: mtk: Add printing of CPU model (authored by imp).
mtk: Add printing of CPU model
Fri, Jun 11, 8:31 PM
imp committed R10:768787bee30d: mtk: Initialize mask correctly. (authored by Priit Trees <trees@neti.ee>).
mtk: Initialize mask correctly.
Fri, Jun 11, 8:31 PM
imp committed R10:b0e54e61b390: Change "compiled" to "assembled" (authored by imp).
Change "compiled" to "assembled"
Fri, Jun 11, 8:00 PM