Page MenuHomeFreeBSD

imp (Warner Losh)
User

Projects

User Details

User Since
Jun 2 2014, 4:20 PM (515 w, 6 d)

Recent Activity

Yesterday

imp added inline comments to D44836: mfc-candidates: move pretty printing into lua.
Sun, Apr 21, 2:54 PM

Sat, Apr 20

imp added inline comments to D44884: Throws exception to block redundant devmatch events.
Sat, Apr 20, 11:47 PM
imp added inline comments to D44884: Throws exception to block redundant devmatch events.
Sat, Apr 20, 8:37 PM
imp added inline comments to D44884: Throws exception to block redundant devmatch events.
Sat, Apr 20, 8:35 PM
imp added inline comments to D44884: Throws exception to block redundant devmatch events.
Sat, Apr 20, 8:31 PM
imp added a comment to D44884: Throws exception to block redundant devmatch events.

So which events and why? I dont think the appraoch outlined here can possibly work.

Sat, Apr 20, 8:17 PM

Fri, Apr 19

imp added a comment to D44872: WiP: Use LTO/symbol versioning to optimize (de-clutter) boot bits and pieces.

impressive gains if true... However, the 'no-whole-archive' stuff makes me ask the question "doesn't that eliminate all the commands that we build on linker sets?"

Fri, Apr 19, 11:25 PM
imp committed rG1bd4f769caf8: add dtb support for RPI CM4, CM4s, CM4_ioBoard (authored by maciphone2_googlemail.com).
add dtb support for RPI CM4, CM4s, CM4_ioBoard
Fri, Apr 19, 11:13 PM
imp committed rGdbd0366f3434: package: move lpr into its own package (authored by lexi_le-fay.org).
package: move lpr into its own package
Fri, Apr 19, 11:13 PM
imp committed rG42acb16bb86f: rescue: add ipfw, pfctl (authored by lexi_le-fay.org).
rescue: add ipfw, pfctl
Fri, Apr 19, 11:13 PM
imp committed rG0bdcfb08f2d5: usr.bin/units: use else..if to avoid calling the next branch (authored by rilysh <nightquick@proton.me>).
usr.bin/units: use else..if to avoid calling the next branch
Fri, Apr 19, 11:13 PM
imp committed rG1f2776e12360: Add support for Intel Atom S1200 UART (authored by henrichhartzer_tuta.io).
Add support for Intel Atom S1200 UART
Fri, Apr 19, 11:12 PM
imp committed rGa8fd0a5f4423: glabel: Remove support for old reiserfs (authored by rbranco_suse.com).
glabel: Remove support for old reiserfs
Fri, Apr 19, 10:49 PM
imp committed rG67677a654aa7: acpi_iicbus: Shift slave address (authored by Ahmad Khalifa <ahmadkhalifa570@gmail.com>).
acpi_iicbus: Shift slave address
Fri, Apr 19, 10:49 PM
imp committed rG493715f9b817: ig4_iic: Warn on NACK (authored by Ahmad Khalifa <ahmadkhalifa570@gmail.com>).
ig4_iic: Warn on NACK
Fri, Apr 19, 10:49 PM
imp committed rGd0cc25f770ae: acpi_cmbat: Use nitems instead of sizeof (authored by Ahmad Khalifa <ahmadkhalifa570@gmail.com>).
acpi_cmbat: Use nitems instead of sizeof
Fri, Apr 19, 10:49 PM
imp committed rG54e231b373ef: Add support for i2c-tiny-usb: usb to iic bridge (authored by Denis Bodor <lefinnois@lefinnois.net>).
Add support for i2c-tiny-usb: usb to iic bridge
Fri, Apr 19, 10:49 PM
imp committed rGbf2fd4755086: ig4_reg: Update datasheet link (authored by Ahmad Khalifa <ahmadkhalifa570@gmail.com>).
ig4_reg: Update datasheet link
Fri, Apr 19, 10:49 PM
imp committed rG725a9f47324d: bsdiff: Use mmap instead of malloc (authored by rbranco_suse.com).
bsdiff: Use mmap instead of malloc
Fri, Apr 19, 10:35 PM
imp committed rGde525c502a3a: intro.2: Integrate introduction with state of page (authored by concussious.bugzilla_runbox.com).
intro.2: Integrate introduction with state of page
Fri, Apr 19, 10:35 PM
imp committed rGd846f33bb6d4: intro.2: Section RETURN VALUES is actually ERRORS (authored by concussious.bugzilla_runbox.com).
intro.2: Section RETURN VALUES is actually ERRORS
Fri, Apr 19, 10:35 PM
imp committed rG4696ca7baf2f: intro.2: Add FILES mentioning table of syscalls (authored by concussious.bugzilla_runbox.com).
intro.2: Add FILES mentioning table of syscalls
Fri, Apr 19, 10:35 PM
imp committed rG9e8df7900f52: intro.2: Tweak grammar and syntax for consistency (authored by concussious.bugzilla_runbox.com).
intro.2: Tweak grammar and syntax for consistency
Fri, Apr 19, 10:35 PM
imp committed rGbcc57e971597: intro.2: Import HISTORY from OpenBSD but our style (authored by concussious.bugzilla_runbox.com).
intro.2: Import HISTORY from OpenBSD but our style
Fri, Apr 19, 10:35 PM
imp committed rG961bcbeef251: mailwrapper(8): change behaviour if mailer.conf cannot be opened (authored by lexi_le-fay.org).
mailwrapper(8): change behaviour if mailer.conf cannot be opened
Fri, Apr 19, 10:35 PM
imp committed rG5fbdcd65fe5c: xargs: use getline() instead of fgetln() (authored by Martin Tournoij <martin@arp242.net>).
xargs: use getline() instead of fgetln()
Fri, Apr 19, 9:53 PM
imp committed rG25696725b65b: patch: use getline() instead of fgetln() (authored by Martin Tournoij <martin@arp242.net>).
patch: use getline() instead of fgetln()
Fri, Apr 19, 9:53 PM
imp committed rGd3643c9efe78: join: use getline() instead of fgetln() (authored by Martin Tournoij <martin@arp242.net>).
join: use getline() instead of fgetln()
Fri, Apr 19, 9:53 PM
imp committed rG3abcc79c6a25: head: use getline() instead of fgetln() (authored by Martin Tournoij <martin@arp242.net>).
head: use getline() instead of fgetln()
Fri, Apr 19, 9:53 PM
imp committed rG9744821765fc: diff: use getline() instead of fgetln() (authored by Martin Tournoij <martin@arp242.net>).
diff: use getline() instead of fgetln()
Fri, Apr 19, 9:53 PM
imp committed rGb05785953e55: cut: use getline() instead of fgetln() (authored by Martin Tournoij <martin@arp242.net>).
cut: use getline() instead of fgetln()
Fri, Apr 19, 9:53 PM
imp added a comment to D44869: rtld: Add support for arm64 variant pcs.

The code likely is good, but the why for some of it isn't obvious to me and needs some clarification I think.

Fri, Apr 19, 3:53 PM
imp accepted D44868: elf_common.h: Add STO_AARCH64_VARIANT_PCS.
Fri, Apr 19, 3:41 PM
imp accepted D44866: install: Fix a compiler warning when bootstrapping.
Fri, Apr 19, 3:02 PM
imp added a comment to D44863: adduser: Overhaul..

Might want to also note that you've made a lot of variables local. I think that's a good change too, but best to note it or split it off into another commit.

Fri, Apr 19, 2:17 PM
imp accepted D44859: ahc(4): resolve some minor nits.

I think this is good... but mav will know for sure if we're missing something

Fri, Apr 19, 2:12 AM
imp accepted D44860: ahc(4)/ahd(4): fix target mode on ARM.
Fri, Apr 19, 2:11 AM
imp accepted D44844: ctl: Add CTL_IO_ASSERT_SCSI wrapper macro.
Fri, Apr 19, 2:10 AM
imp accepted D44842: nvmecontrol: Always build instead of being conditional on WITH_NVME.
Fri, Apr 19, 2:06 AM

Thu, Apr 18

imp accepted D44713: cam: Add a XPORT_NVMF for NVMe over Fabrics sims.
Thu, Apr 18, 10:36 PM
imp accepted D44843: Remove the MK_NVME build option.
Thu, Apr 18, 10:35 PM
imp accepted D44857: CONRIBUTING: mention sys/crypto as another "contrib" directory.
Thu, Apr 18, 6:52 PM
imp accepted D44838: showconfig: Set MACHINE for src.opts.mk.

Surprised this wasn't already the case

Thu, Apr 18, 4:21 PM
imp added a comment to D41509: crypt(3) style password support for lua loader.

I've created a hash module that has some of the sha routines. I don't have big issues connecting those.

Thu, Apr 18, 3:27 PM · Loader
imp added a comment to D44706: nvmf.h: New header defining ioctls for NVMe over Fabrics.
In D44706#1021491, @jhb wrote:
In D44706#1020670, @imp wrote:

One nit... also applies to all of this series of reviews: consider omitting the license boilerplate.

Hmm, are we ready to do that? I know we have some SPDX-only files in the tree and are kind of allowing it, but I wasn't sure we'd crossed the point to preferring that by default.

Thu, Apr 18, 4:24 AM
imp added a comment to D44704: nvmf_proto.h: Update for use in FreeBSD.

I'd be happy moving to #pragma once for almost all files in the tree...

Thu, Apr 18, 4:18 AM
imp accepted D44826: Fix build with WITH_NVME newly enabled.

oh! That's the problem... I did a clean build and that's why I didn't see it...

Thu, Apr 18, 3:50 AM

Wed, Apr 17

imp added a comment to D44825: misc: Add a map of FreeBSD IDs to GitHub IDs.

Some of this can be found with
curl -i -s 'https://api.github.com/search/users?q=$USER@freebsd.org'
but only if the FreeBSD address is the primary email.
I've not found how to lookup by secondary email.

Wed, Apr 17, 9:21 PM
imp committed rGf122045e36dd: crunchgen: add --list option (authored by Martin Tournoij <martin@arp242.net>).
crunchgen: add --list option
Wed, Apr 17, 6:07 PM
imp committed rG75eda0096bf8: networking.7 : create network quickstart guide (authored by concussious.bugzilla_runbox.com).
networking.7 : create network quickstart guide
Wed, Apr 17, 4:00 PM
imp added a comment to D44823: Enable L1SS handling on RPI4 pcib.

Let's put all the reviews in the PR for this. It's usually a bad idea to do both and wastes my time having to deal with both unless there's a good reason.

Wed, Apr 17, 1:24 PM · arm64
imp committed rG49ea0889f2cb: nvmecontrol: One file per line (authored by imp).
nvmecontrol: One file per line
Wed, Apr 17, 3:34 AM
imp committed rG2fda3ab0ac19: WITH_NVME: Remove from broken. (authored by imp).
WITH_NVME: Remove from broken.
Wed, Apr 17, 3:34 AM
imp committed rG98ab7d0a30f8: nvmecontrol: Add nvme 2.0 fields to read_logpage (authored by imp).
nvmecontrol: Add nvme 2.0 fields to read_logpage
Wed, Apr 17, 3:34 AM
imp committed rG383a44fc0bcb: nvmecontrol: Preliminary namespace documentation (authored by imp).
nvmecontrol: Preliminary namespace documentation
Wed, Apr 17, 3:34 AM
imp committed rGe39873820da7: nvmecontrol: add newlines where needed for ns command printfs (authored by imp).
nvmecontrol: add newlines where needed for ns command printfs
Wed, Apr 17, 3:34 AM
imp committed rG97b77de2d951: nvme: Eliminate intel_log_temp_stats_swapbytes (authored by imp).
nvme: Eliminate intel_log_temp_stats_swapbytes
Wed, Apr 17, 3:34 AM
imp committed rG55a1679ece1f: nvmecontrol: Move sanitize status page printing to little endian orderinng (authored by imp).
nvmecontrol: Move sanitize status page printing to little endian orderinng
Wed, Apr 17, 3:34 AM
imp committed rGf0f7e9616da0: nvmecontrol: Move intel temperature page printing to little endian orderinng (authored by imp).
nvmecontrol: Move intel temperature page printing to little endian orderinng
Wed, Apr 17, 3:34 AM
imp committed rG3d28a9c608a3: nvmecontrol: Move reservation notifcation page printing to little endian… (authored by imp).
nvmecontrol: Move reservation notifcation page printing to little endian…
Wed, Apr 17, 3:34 AM
imp closed D44684: nvmecontrol: One file per line.
Wed, Apr 17, 3:34 AM
imp committed rG98f841efd8ce: nvmecontrol: Move self test status page printing to little endian orderinng (authored by imp).
nvmecontrol: Move self test status page printing to little endian orderinng
Wed, Apr 17, 3:34 AM
imp committed rGacdf72f7bbe5: nvmecontrol: Move namespace change page printing to little endian orderinng (authored by imp).
nvmecontrol: Move namespace change page printing to little endian orderinng
Wed, Apr 17, 3:34 AM
imp committed rGb850caf7b709: nvmecontrol: Move command effeccts page printing to little endian orderinng (authored by imp).
nvmecontrol: Move command effeccts page printing to little endian orderinng
Wed, Apr 17, 3:34 AM
imp closed D44683: nvmecontrol: Add nvme 2.0 fields to read_logpage.
Wed, Apr 17, 3:34 AM
imp closed D44682: nvmecontrol: Preliminary namespace documentation.
Wed, Apr 17, 3:34 AM
imp closed D44681: nvmecontrol: add newlines where needed for ns command printfs.
Wed, Apr 17, 3:34 AM
imp committed rG1c4b7effa7f9: nvmecontrol: Fix to128 for big endian targets (authored by imp).
nvmecontrol: Fix to128 for big endian targets
Wed, Apr 17, 3:34 AM
imp committed rG729ee4c88f2a: nvmecontrol: Move smart/health printing to little endian orderinng (authored by imp).
nvmecontrol: Move smart/health printing to little endian orderinng
Wed, Apr 17, 3:34 AM
imp closed D44659: nvme: Eliminate intel_log_temp_stats_swapbytes.
Wed, Apr 17, 3:34 AM
imp closed D44658: nvmecontrol: Move intel temperature page printing to little endian orderinng.
Wed, Apr 17, 3:34 AM
imp closed D44657: nvmecontrol: Move sanitize status page printing to little endian orderinng.
Wed, Apr 17, 3:34 AM
imp committed rGe098d24b5290: nvmecontrol: Have to truncate on all 32-bit architectures (authored by imp).
nvmecontrol: Have to truncate on all 32-bit architectures
Wed, Apr 17, 3:34 AM
imp closed D44656: nvmecontrol: Move reservation notifcation page printing to little endian orderinng.
Wed, Apr 17, 3:34 AM
imp closed D44655: nvmecontrol: Move command effeccts page printing to little endian orderinng.
Wed, Apr 17, 3:34 AM
imp closed D44654: nvmecontrol: Move self test status page printing to little endian orderinng.
Wed, Apr 17, 3:34 AM
imp closed D44653: nvmecontrol: Move namespace change page printing to little endian orderinng.
Wed, Apr 17, 3:34 AM
imp committed rG85656a9a0153: nvmecontrol: Make the error log page work on native format (authored by imp).
nvmecontrol: Make the error log page work on native format
Wed, Apr 17, 3:34 AM
imp committed rG67163bc485a5: nvmecontrol: Create letoh to generically convert to host order (authored by imp).
nvmecontrol: Create letoh to generically convert to host order
Wed, Apr 17, 3:34 AM
imp committed rGde22251127cd: arm_kernel_bothdr.awk: Update to latest ota (authored by imp).
arm_kernel_bothdr.awk: Update to latest ota
Wed, Apr 17, 3:34 AM
imp closed D44652: nvmecontrol: Move smart/health printing to little endian orderinng.
Wed, Apr 17, 3:34 AM
imp closed D44651: nvmecontrol: Fix to128 for big endian targets.
Wed, Apr 17, 3:34 AM
imp closed D44650: nvmecontrol: Have to truncate on all 32-bit architectures.
Wed, Apr 17, 3:34 AM
imp closed D44649: nvmecontrol: Create letoh generically convert to host order.
Wed, Apr 17, 3:34 AM
imp closed D44680: nvmecontrol: Make the error log page work on native format.
Wed, Apr 17, 3:34 AM
imp closed D44801: arm_kernel_bothdr.awk: Update to latest ota.
Wed, Apr 17, 3:34 AM

Tue, Apr 16

imp retitled D44649: nvmecontrol: Create letoh generically convert to host order from nvmecontrol: Create LE2H to generically convert to host order to nvmecontrol: Create letoh generically convert to host order.
Tue, Apr 16, 10:47 PM
imp added a comment to D44649: nvmecontrol: Create letoh generically convert to host order.
In D44649#1019208, @jhb wrote:

I kind of wonder if we'd like to just have this in <sys/endian.h> as letoh, but then you'd want the full complement of betoh, htobe, etc.

Tue, Apr 16, 10:45 PM
imp updated the diff for D44651: nvmecontrol: Fix to128 for big endian targets.

update, per review.

Tue, Apr 16, 10:36 PM
imp added inline comments to D44651: nvmecontrol: Fix to128 for big endian targets.
Tue, Apr 16, 10:36 PM
imp added inline comments to D44651: nvmecontrol: Fix to128 for big endian targets.
Tue, Apr 16, 10:32 PM
imp committed rGd476e51525ff: gicv3: If the LPI is already allocated, remember it (authored by imp).
gicv3: If the LPI is already allocated, remember it
Tue, Apr 16, 9:43 PM
imp committed rGb53202779c2e: gicv3: In its_init_cpu_lpi record each cpu's PENDBASER (authored by imp).
gicv3: In its_init_cpu_lpi record each cpu's PENDBASER
Tue, Apr 16, 9:43 PM
imp committed rG582cece4507b: gicv3: Define PA masks for the PENDBASR and PROPBASER registers (authored by imp).
gicv3: Define PA masks for the PENDBASR and PROPBASER registers
Tue, Apr 16, 9:43 PM
imp committed rG6368e71a25ba: gicv3: Report PENDBASE when bootverbose (authored by imp).
gicv3: Report PENDBASE when bootverbose
Tue, Apr 16, 9:43 PM
imp committed rGbfb3b0e7065f: gicv3: Only set the redistributor base if we're not prealloced (authored by imp).
gicv3: Only set the redistributor base if we're not prealloced
Tue, Apr 16, 9:43 PM
imp committed rG9eea5eb52a0e: gicv3: Don't allocate pend_base if we're already started (authored by imp).
gicv3: Don't allocate pend_base if we're already started
Tue, Apr 16, 9:43 PM
imp committed rG531302411740: gicv3: Panic if the gicv3 already running (authored by imp).
gicv3: Panic if the gicv3 already running
Tue, Apr 16, 9:43 PM
imp committed rG02eaed648f40: gicv3: Change how we initialize its children. (authored by imp).
gicv3: Change how we initialize its children.
Tue, Apr 16, 9:43 PM
imp added inline comments to D44719: ctl: Support NVMe requests in debug trace functions.
Tue, Apr 16, 9:17 PM