Page MenuHomeFreeBSD

imp (Warner Losh)
User

Projects

User Details

User Since
Jun 2 2014, 4:20 PM (511 w, 14 h)

Recent Activity

Yesterday

imp added a comment to D42936: sysclock: Bug fixes and cleanup.

This is too bog to easily review, so it has always dropped to the end of the list...

Mon, Mar 18, 11:25 PM
imp accepted D44413: uboot/Makefile move BINDIR.
Mon, Mar 18, 8:51 PM
imp accepted D44414: loader.4th dictthreshold too small.

This is fine. The syntax is Forth, the comments are Forth and a quick grep suggests that dictthreshold is the right variable to set.

Mon, Mar 18, 6:34 PM
imp accepted D44290: pciconf: Report topology information.

This looks good. There areno compat concerns

Mon, Mar 18, 5:57 PM

Sun, Mar 17

imp accepted D44400: Add myself (jfree) to calendar.freebsd.
Sun, Mar 17, 10:50 PM
imp requested changes to D44289: PCIOCGETCONF: Report NUMA domain.

These changes aren't backward compatible. You likely need to keep the old struct to reply to the old ioctl...

Sun, Mar 17, 10:49 PM

Fri, Mar 15

imp committed rGd2a824c29d69: share/mk: Don't install only differing in case files on case insensitive fs (authored by imp).
share/mk: Don't install only differing in case files on case insensitive fs
Fri, Mar 15, 3:03 PM
imp closed D44347: share/mk: Don't install only differing in case files on case insensitive fs.
Fri, Mar 15, 3:03 PM
imp closed D44346: scsi: Stop installing both cam.4 and CAM.4.
Fri, Mar 15, 3:02 PM
imp committed rGa00f9e4e8181: scsi: Stop installing both cam.4 and CAM.4 (authored by imp).
scsi: Stop installing both cam.4 and CAM.4
Fri, Mar 15, 3:02 PM
imp added reviewers for D44367: cam: Move temporary queue from stack to softc: mav, ken.
Fri, Mar 15, 4:17 AM
imp requested review of D44367: cam: Move temporary queue from stack to softc.
Fri, Mar 15, 4:17 AM

Thu, Mar 14

imp accepted D44360: arm64: Return all registers to gdb when able.
Thu, Mar 14, 5:55 PM
imp accepted D44358: uart: Add uart_cpu_acpi_setup to setup the uart.
Thu, Mar 14, 5:54 PM
imp accepted D44357: uart: Split out initilisation of the acpi devinfo.

just one (possibly unrelated) question.

Thu, Mar 14, 5:53 PM

Wed, Mar 13

imp added a comment to D44264: newbus: Create %probe_bias in every devclass.

I would suggest iwlwifi vs iwm except that LinuxKPI drivers don't probe normally (they all run in a late SYSINIT for some reason) so this won't work for that case. :(

We need to fix that. It's unacceptable. I'm tired of all the stupid hacks in LinuxKPI because the original author couldn't be bothered to do things correctly... See also the restriction on not being able to be loaded from the boot loader...

Wed, Mar 13, 8:42 PM
imp added a comment to D44264: newbus: Create %probe_bias in every devclass.
In D44264#1011411, @jhb wrote:

I think it would be useful to include a specific example in the commit log (and I wish there was a manpage to document this in, but I can't think of a good one).

Wed, Mar 13, 8:38 PM
imp abandoned D44348: mtree: Hack to allow gname and uname to pass through.

ooops. This is not ready. It doesn't even work, sadly.

Wed, Mar 13, 8:33 PM
imp requested review of D44348: mtree: Hack to allow gname and uname to pass through.
Wed, Mar 13, 8:32 PM
imp requested review of D44347: share/mk: Don't install only differing in case files on case insensitive fs.
Wed, Mar 13, 8:32 PM
imp requested review of D44346: scsi: Stop installing both cam.4 and CAM.4.
Wed, Mar 13, 8:32 PM
imp accepted D44345: bsd.opts.mk: drop transtion aid for NO_* options.

Sounds good,,, CLEAN isn't in the list :)

Wed, Mar 13, 8:03 PM
imp accepted D44341: arm64 gicv3: Use void pointers instead of vm_offset_t.
Wed, Mar 13, 7:59 PM
imp accepted D44318: openbsm: Remove $FreeSBD$ tags from the configuration files.
Wed, Mar 13, 1:15 PM
imp accepted D44334: riscv: remove more riscv64sf support.

I think tis is good... not sure about jrtc's comments

Wed, Mar 13, 1:58 AM

Tue, Mar 12

imp added a comment to D44320: Allow the bundled zstd to use utimensat.

An exp-run is what you suggested when I first raised the issue on freebsd-hackers last September. However, I don't know how to do an exp-run. Are you volunteering?

Tue, Mar 12, 9:22 PM
imp requested changes to D44320: Allow the bundled zstd to use utimensat.

This isn't quite right. We also should change sys/sys/unistd.h since it only defines 200112 compliance, when we're effectively 200809 compliant.
We should likely just move the BSD defines down to the highlighted #if, but we'd also need to make the sys/sys/unitstd.h change. I'd recommend that for upstream, then it automatiocally starts working.

Tue, Mar 12, 7:58 PM
imp added a comment to D44318: openbsm: Remove $FreeSBD$ tags from the configuration files.

Have you confirmed that this makes these files now match upstream?

Tue, Mar 12, 6:44 PM
imp committed rG5b35479e3ede: RELNOTES: Add awk update from 2 weeks ago. (authored by imp).
RELNOTES: Add awk update from 2 weeks ago.
Tue, Mar 12, 3:25 PM
imp committed rGe36906ac1a4d: RELNOTES: Add pointer to awk info. (authored by imp).
RELNOTES: Add pointer to awk info.
Tue, Mar 12, 3:24 PM
imp committed rG10f1eebd2c61: Add info about one true awk 2nd edition. (authored by imp).
Add info about one true awk 2nd edition.
Tue, Mar 12, 3:22 PM
imp committed rGb0f058525b5b: awk: Fix the tests (authored by imp).
awk: Fix the tests
Tue, Mar 12, 2:50 PM
imp committed rGdaf917daba9c: Merge one true awk from 2024-01-22 for the Awk Second Edition support (authored by imp).
Merge one true awk from 2024-01-22 for the Awk Second Edition support
Tue, Mar 12, 2:49 PM
imp committed rG47fff7407c22: ada: Another NCQ Trim instability drive (authored by imp).
ada: Another NCQ Trim instability drive
Tue, Mar 12, 4:52 AM
imp committed rG7a0a6b276cfd: libc: Move tzset.3 to stdtime (authored by imp).
libc: Move tzset.3 to stdtime
Tue, Mar 12, 4:20 AM
imp committed rGa34940a9756a: timezone: Move to the XSI/POSIX definition for timezone. (authored by imp).
timezone: Move to the XSI/POSIX definition for timezone.
Tue, Mar 12, 4:20 AM
imp closed D44281: timezone: Move to the XSI/POSIX definition for timezone..
Tue, Mar 12, 4:20 AM
imp added inline comments to D44281: timezone: Move to the XSI/POSIX definition for timezone..
Tue, Mar 12, 3:25 AM

Mon, Mar 11

imp added inline comments to D44281: timezone: Move to the XSI/POSIX definition for timezone..
Mon, Mar 11, 10:54 PM
imp added a comment to D44281: timezone: Move to the XSI/POSIX definition for timezone..

So I don't think I need timezone.3 in the old files stuff...

Mon, Mar 11, 9:35 PM
imp added inline comments to D44281: timezone: Move to the XSI/POSIX definition for timezone..
Mon, Mar 11, 9:34 PM
imp updated the diff for D44281: timezone: Move to the XSI/POSIX definition for timezone..

update, per Brooks.

Mon, Mar 11, 9:33 PM
imp committed rG462af7676b3e: kboot: kbootfdt: fix error handling (authored by imp).
kboot: kbootfdt: fix error handling
Mon, Mar 11, 9:24 PM
imp committed rGd75524b3fe21: kboot: Use is_linux_error to check mmap return error (authored by imp).
kboot: Use is_linux_error to check mmap return error
Mon, Mar 11, 9:24 PM
imp committed rGa9cd3b675e24: kboot: Print UEFI memory map (authored by imp).
kboot: Print UEFI memory map
Mon, Mar 11, 9:24 PM
imp committed rGd650c3efb638: kboot: hostfs -- check for llseek failure correctly (authored by imp).
kboot: hostfs -- check for llseek failure correctly
Mon, Mar 11, 9:24 PM
imp committed rG8b1925f29c54: kboot: Avoid UB in signed shift (authored by imp).
kboot: Avoid UB in signed shift
Mon, Mar 11, 9:24 PM
imp committed rG3ae18fdfbcaa: kboot: Create function for error checking. (authored by imp).
kboot: Create function for error checking.
Mon, Mar 11, 9:24 PM
imp closed D44287: kboot: Print UEFI memory map.
Mon, Mar 11, 9:23 PM
imp closed D44286: kboot: hostfs -- check for llseek failure correctly.
Mon, Mar 11, 9:23 PM
imp closed D44285: kboot: Avoid UB behavior.
Mon, Mar 11, 9:23 PM

Sat, Mar 9

imp added inline comments to D44287: kboot: Print UEFI memory map.
Sat, Mar 9, 10:53 PM
imp added reviewers for D44286: kboot: hostfs -- check for llseek failure correctly: kevans, tsoome.
Sat, Mar 9, 10:52 PM
imp added reviewers for D44287: kboot: Print UEFI memory map: kevans, tsoome.
Sat, Mar 9, 10:52 PM
imp requested review of D44287: kboot: Print UEFI memory map.
Sat, Mar 9, 10:51 PM
imp added reviewers for D44285: kboot: Avoid UB behavior: jrtc27, kevans, tsoome.
Sat, Mar 9, 10:51 PM
imp requested review of D44286: kboot: hostfs -- check for llseek failure correctly.
Sat, Mar 9, 10:51 PM
imp requested review of D44285: kboot: Avoid UB behavior.
Sat, Mar 9, 10:50 PM
imp added inline comments to D44283: if_wg: use proper barriers around pkt->p_state.
Sat, Mar 9, 4:11 AM
imp added a comment to D44283: if_wg: use proper barriers around pkt->p_state.

I think these are right.

Sat, Mar 9, 1:44 AM

Fri, Mar 8

imp accepted D44282: mrsas: don't issue IO to hot-removed physical disk of RAID1 volume..

Looks good, feel free to take up or not my suggestion.

Fri, Mar 8, 7:21 PM
imp accepted D44128: new-bus: Remove the 'type' argument from BUS_ADJUST_RESOURCE.
Fri, Mar 8, 6:47 PM
imp accepted D44131: new-bus: Remove the 'rid' and 'type' arguments from BUS_RELEASE_RESOURCE.
Fri, Mar 8, 6:46 PM
imp accepted D44130: new-bus: Remove the 'rid' and 'type' arguments from BUS_*ACTIVATE_RESOURCE.
Fri, Mar 8, 6:46 PM
imp accepted D44129: new-bus: Remove the 'type' argument from BUS_MAP/UNMAP_RESOURCE.
Fri, Mar 8, 6:45 PM
imp accepted D44127: pcib: Use rman_get_type in internal functions.
Fri, Mar 8, 6:44 PM
imp accepted D44126: bhnd: Use rman_get_type in bhndb_find_resource_limits.
Fri, Mar 8, 6:30 PM
imp accepted D44125: acpi: Use rman_get_type in acpi_is_resource_managed.
Fri, Mar 8, 6:30 PM
imp accepted D44124: new-bus: Introduce a simpler bus API for managing resources.

This looks good, though having _new in the ABI seems a little weird... It would just be for the life of whatever branches you merge this to, though.

Fri, Mar 8, 6:29 PM
imp accepted D44123: sys: Set the type of allocated bus resources.
Fri, Mar 8, 6:27 PM
imp accepted D44122: rman: Add rman_get/set_type.
Fri, Mar 8, 6:27 PM
imp added reviewers for D44281: timezone: Move to the XSI/POSIX definition for timezone.: kib, brooks.
Fri, Mar 8, 6:13 PM
imp requested review of D44281: timezone: Move to the XSI/POSIX definition for timezone..
Fri, Mar 8, 6:11 PM
imp committed rG4f9fbde5ee94: ObsoleteFiles.inc: add the awk tests I just remvoed (authored by imp).
ObsoleteFiles.inc: add the awk tests I just remvoed
Fri, Mar 8, 6:05 AM
imp committed rGba7b7f94c239: awk: Fix the tests (authored by imp).
awk: Fix the tests
Fri, Mar 8, 5:56 AM

Thu, Mar 7

imp added inline comments to D44269: newbus: Remove redundant check for 0.
Thu, Mar 7, 7:30 PM
imp added inline comments to D44269: newbus: Remove redundant check for 0.
Thu, Mar 7, 7:30 PM
imp added inline comments to D44264: newbus: Create %probe_bias in every devclass.
Thu, Mar 7, 7:29 PM
imp updated the diff for D44269: newbus: Remove redundant check for 0.

actually fix the redundancy

Thu, Mar 7, 7:27 PM
imp updated the diff for D44264: newbus: Create %probe_bias in every devclass.

rebase

Thu, Mar 7, 7:16 PM
imp requested review of D44269: newbus: Remove redundant check for 0.
Thu, Mar 7, 7:15 PM
imp added a comment to D44264: newbus: Create %probe_bias in every devclass.

but I'll do that fix as another commit

Thu, Mar 7, 7:14 PM
imp added inline comments to D44264: newbus: Create %probe_bias in every devclass.
Thu, Mar 7, 7:13 PM
imp added a comment to D44180: nvme: Give reset a chance to undo failure.

mav@ is correct.

Thu, Mar 7, 7:09 PM
imp abandoned D44181: nvme_sim: Allow administrative commands when we're marked as failed.

I don't know what I was thinking here...

Thu, Mar 7, 7:07 PM
imp committed rGfe52c3384c61: nvme_sim: Add comment about the is_failed test (authored by imp).
nvme_sim: Add comment about the is_failed test
Thu, Mar 7, 7:06 PM
imp requested review of D44264: newbus: Create %probe_bias in every devclass.
Thu, Mar 7, 6:14 PM
imp added inline comments to D44210: nvme: Change devctl events for the controller.
Thu, Mar 7, 1:43 AM
imp committed rG6a3877a0e2b5: devd: Document the nvme devd events (authored by imp).
devd: Document the nvme devd events
Thu, Mar 7, 1:40 AM
imp committed rG7c6af2096915: devd: Add directory information (authored by imp).
devd: Add directory information
Thu, Mar 7, 1:40 AM
imp committed rG2a2682ee5330: nvme: Add SMART WARNING for persistent memory region (authored by imp).
nvme: Add SMART WARNING for persistent memory region
Thu, Mar 7, 1:40 AM
imp closed D44212: devd: Document the nvme devd events.
Thu, Mar 7, 1:40 AM
imp committed rG5cdedf676d03: nvme: Log reset success or failure to devd (authored by imp).
nvme: Log reset success or failure to devd
Thu, Mar 7, 1:40 AM
imp closed D44213: nvme: Add SMART WARNING for persistent memory region.
Thu, Mar 7, 1:40 AM
imp closed D44211: nvme: Log reset success or failure to devd.
Thu, Mar 7, 1:40 AM
imp committed rG4f817fcf6a26: nvme: Change devctl events for the controller (authored by imp).
nvme: Change devctl events for the controller
Thu, Mar 7, 1:40 AM
imp closed D44210: nvme: Change devctl events for the controller.
Thu, Mar 7, 1:40 AM
imp closed D44209: nvme: split devctl out to its own function.
Thu, Mar 7, 1:39 AM
imp committed rGfc3afe939530: nvme: split devctl out to its own function (authored by imp).
nvme: split devctl out to its own function
Thu, Mar 7, 1:39 AM

Wed, Mar 6

imp added a comment to D44180: nvme: Give reset a chance to undo failure.
In D44180#1008994, @mav wrote:

On failure we've already notified consumers that controller has failed. What will report it is back? And is there even a device to sent request IOCTL?

Wed, Mar 6, 6:34 PM