Page MenuHomeFreeBSD

imp (Warner Losh)
User

Projects

User Details

User Since
Jun 2 2014, 4:20 PM (298 w, 1 d)

Recent Activity

Today

imp added a reviewer for D23755: Don't convert all lower-layer errors to EIO.: kib.
Wed, Feb 19, 3:38 PM
imp added a reviewer for D23756: Don't spam the console with an additional, and useless, error message.: kib.
Wed, Feb 19, 3:38 PM
imp created D23756: Don't spam the console with an additional, and useless, error message..
Wed, Feb 19, 3:37 PM
imp created D23755: Don't convert all lower-layer errors to EIO..
Wed, Feb 19, 3:37 PM
imp added a comment to D23754: Complete the failsafe outstanding commands to the device later in the process..

Note: the manual for this card is a bit ambiguous on this point, but the implications are there...

Wed, Feb 19, 3:36 PM
imp added reviewers for D23754: Complete the failsafe outstanding commands to the device later in the process.: scottl, ken.
Wed, Feb 19, 3:35 PM
imp created D23754: Complete the failsafe outstanding commands to the device later in the process..
Wed, Feb 19, 3:33 PM

Mon, Feb 17

imp accepted D23730: Fix compile errors in altera_sdcard_io.c after r357647.

Lgtm

Mon, Feb 17, 6:44 PM

Sun, Feb 16

imp accepted D23633: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N).
Sun, Feb 16, 4:56 PM
imp added a comment to D23717: Use EARLY_DRIVER_MODULE in the acpi bus.

I think this is fine.

Sun, Feb 16, 4:53 PM

Sat, Feb 15

imp committed rS357969: The KASSERT is too strict: revert r357897.
The KASSERT is too strict: revert r357897
Sat, Feb 15, 6:14 PM

Fri, Feb 14

imp added a comment to D23644: graphics/wayland: convert to USES=meson.

OK. I did the following:

Fri, Feb 14, 8:59 PM
imp added a comment to D23644: graphics/wayland: convert to USES=meson.

I'll test this on my arm64 box... I'll also try hack things to put a 'sleep 30' into the generation of wayland-client-protocol.h to exaggerate the race.

Fri, Feb 14, 4:35 PM
imp added a comment to D23644: graphics/wayland: convert to USES=meson.

@pkubaj, @mikael, can you test build on powerpc64 and aarch64 on real hardware?
I'm trying to figure out if https://gitlab.freedesktop.org/wayland/wayland/issues/144 is due to qemu-user-static.

Fri, Feb 14, 2:54 PM
imp committed rS357897: Add a KASSERT that there's no outstanding CCBs when we call camperiphfree. We.
Add a KASSERT that there's no outstanding CCBs when we call camperiphfree. We
Fri, Feb 14, 12:13 AM
imp committed rS357896: xpt_release_simq_timeout is unused. Remove it..
xpt_release_simq_timeout is unused. Remove it.
Fri, Feb 14, 12:13 AM

Thu, Feb 13

imp added reviewers for D23660: Abstract out SMBIOS -- move it to libsa: kevans, tsoome.
Thu, Feb 13, 4:20 AM
imp created D23660: Abstract out SMBIOS -- move it to libsa.
Thu, Feb 13, 4:10 AM
imp committed rS357853: Use INT instead of string for the ints. Because the string "I" was right, the.
Use INT instead of string for the ints. Because the string "I" was right, the
Thu, Feb 13, 3:37 AM
imp committed rS357849: Convert rotating and unmapped_io to a DA flag.
Convert rotating and unmapped_io to a DA flag
Thu, Feb 13, 1:23 AM
imp committed rS357848: Export the current da flags as bitfield.
Export the current da flags as bitfield
Thu, Feb 13, 1:23 AM
imp closed D23417: Export the current da flags as bitfield.
Thu, Feb 13, 1:23 AM
imp added inline comments to D23644: graphics/wayland: convert to USES=meson.
Thu, Feb 13, 1:10 AM
imp updated the diff for D23417: Export the current da flags as bitfield.

Update, per scottl

Thu, Feb 13, 1:00 AM
imp created D23658: More sparc64 removal bits.
Thu, Feb 13, 12:12 AM

Wed, Feb 12

imp added a watcher for x11: imp.
Wed, Feb 12, 11:38 PM
imp added a comment to D23648: style.9: update C99 commentary.

I'm cool with the parenthetical form.

Wed, Feb 12, 11:16 PM
imp added a comment to D23643: graphics/wayland: Update to 1.18.

this looks promising...

Wed, Feb 12, 11:10 PM
imp added inline comments to D23644: graphics/wayland: convert to USES=meson.
Wed, Feb 12, 11:07 PM
imp added a comment to D23644: graphics/wayland: convert to USES=meson.

Thanks Jan. I like this direction.
There's two build errors that look easy to fix (or I'm misreading the logs). What are you plans there?

Wed, Feb 12, 11:06 PM
imp accepted D23648: style.9: update C99 commentary.

I think the .St -isoC-99 is better than a raw C99. Otherwise, I like the prefers.

Wed, Feb 12, 10:05 PM
imp accepted D23390: efiloader: don't execute hooks when setting currdev/loaddev.
Wed, Feb 12, 4:55 PM
imp committed rS357798: Remove sparc64 specific inclusion of bswap32 built-ins..
Remove sparc64 specific inclusion of bswap32 built-ins.
Wed, Feb 12, 6:56 AM
imp committed rS357797: Remove sparc64 specific warning suppression..
Remove sparc64 specific warning suppression.
Wed, Feb 12, 6:54 AM
imp committed rS357796: Remove excluding libproc and librtld_db on sparc64..
Remove excluding libproc and librtld_db on sparc64.
Wed, Feb 12, 6:54 AM
imp committed rS357795: Remove sparc64 files.
Remove sparc64 files
Wed, Feb 12, 6:53 AM
imp committed rS357794: Remove sparc64 specific bits of the man pages..
Remove sparc64 specific bits of the man pages.
Wed, Feb 12, 6:52 AM
imp added a comment to D23615: This adds wulf7 / iichid on github to ports.

If you make the changes you say, this looks good to me

Wed, Feb 12, 5:12 AM

Tue, Feb 11

imp added a comment to D23615: This adds wulf7 / iichid on github to ports.

I'm up for this... you can add me as a maintainer

Tue, Feb 11, 5:48 AM

Mon, Feb 10

imp committed rS357743: Use __riscv instead of __riscv__.
Use __riscv instead of __riscv__
Mon, Feb 10, 6:28 PM
imp committed rS357741: Remove ifdefs for ia64 and sparc64..
Remove ifdefs for ia64 and sparc64.
Mon, Feb 10, 5:17 PM
imp committed rS357740: Refresh architecture list with latest:.
Refresh architecture list with latest:
Mon, Feb 10, 5:17 PM
imp committed rS357739: Remove sparc64 specific eeprom command.
Remove sparc64 specific eeprom command
Mon, Feb 10, 5:17 PM
imp committed rS357738: For valid arch values (really $MACHINE), remove references to alpha.
For valid arch values (really $MACHINE), remove references to alpha
Mon, Feb 10, 5:17 PM
imp committed rS357737: Fix a comment for the SUN geom class..
Fix a comment for the SUN geom class.
Mon, Feb 10, 5:17 PM
imp committed rS357735: Remove sparc64 ifdef.
Remove sparc64 ifdef
Mon, Feb 10, 5:17 PM
imp committed rS357736: Fix comment. It mentioned sparc64 specifically, but alignment issues.
Fix comment. It mentioned sparc64 specifically, but alignment issues
Mon, Feb 10, 5:17 PM
imp committed rS357734: Remove sparc64 example..
Remove sparc64 example.
Mon, Feb 10, 5:16 PM
imp closed D23593: Remove sparc64 stuff from usr.sbin.
Mon, Feb 10, 5:16 PM

Sun, Feb 9

imp added inline comments to D23593: Remove sparc64 stuff from usr.sbin.
Sun, Feb 9, 7:00 PM
imp created D23593: Remove sparc64 stuff from usr.sbin.
Sun, Feb 9, 6:57 PM

Fri, Feb 7

imp committed rS357659: Supress not supported message.
Supress not supported message
Fri, Feb 7, 5:47 PM
imp added inline comments to D23564: usb: Add vendor Hygon.
Fri, Feb 7, 4:32 PM
imp abandoned D23541: Make BIO_SPEEDUP opt-in.

We'll fix a different way

Fri, Feb 7, 1:51 PM
imp added a comment to D23541: Make BIO_SPEEDUP opt-in.
In D23541#516975, @mjg wrote:

In that case what about the console spam? I presume messages of this sort:

g_vfs_done():md10a[UNKNOWN()]error = 45

stem precisely from this. This happens to really spam the console for me when e.g., running stress2 when at least for this case it should never print anything. iow it looks like a design error that that devices which don't support something can get a request AND fail resulting in an error message.
Here is an example from pho's log: https://people.freebsd.org/~pho/stress/log/mark125.txt

Good point, the block layer shouldn't be spamming like this.

Fri, Feb 7, 1:51 PM
imp added a comment to D23541: Make BIO_SPEEDUP opt-in.
In D23541#516964, @imp wrote:

I agree with Alexander, I really don't like that this perpetuates bad design.

So the proper fix is to fix all the disk drivers to just return op not supported?

Yep, gotta bite the bullet sometime

--- scsi_da.c	(revision 355435)
+++ scsi_da.c	(working copy)
@@ -3381,6 +3381,10 @@
 			}
 			break;
 		}
+		default:
+			biofinish(bp, NULL, EOPNOTSUPP);
+			xpt_release_ccb(start_ccb);
+			return;
 		}
 		start_ccb->ccb_h.ccb_state = DA_CCB_BUFFER_IO;
 		start_ccb->ccb_h.flags |= CAM_UNLOCKED;
Fri, Feb 7, 7:27 AM
imp added a comment to D23541: Make BIO_SPEEDUP opt-in.

I agree with Alexander, I really don't like that this perpetuates bad design.

Fri, Feb 7, 7:04 AM

Thu, Feb 6

imp added a comment to D23541: Make BIO_SPEEDUP opt-in.
In D23541#516766, @mav wrote:

I won't object too much, but first addition of quite specialized command and then workaround for it does not make me particularly happy.

Thu, Feb 6, 8:31 PM
imp added a comment to D23541: Make BIO_SPEEDUP opt-in.
In D23541#516762, @mav wrote:

I would honestly prefer drivers to report reasonable errors on unknown commands. That would fix the issue once and for all.

Thu, Feb 6, 8:21 PM
imp added reviewers for D23541: Make BIO_SPEEDUP opt-in: chs, chuck.
Thu, Feb 6, 8:18 PM
imp added reviewers for D23541: Make BIO_SPEEDUP opt-in: markj, scottl, mav, ken, kib.
Thu, Feb 6, 8:12 PM
imp created D23541: Make BIO_SPEEDUP opt-in.
Thu, Feb 6, 8:10 PM
imp committed rS357629: Add elf2aout removal.
Add elf2aout removal
Thu, Feb 6, 6:00 PM
imp committed rS357628: Add relnotes entries for armv5 and sparc64 being removed..
Add relnotes entries for armv5 and sparc64 being removed.
Thu, Feb 6, 6:00 PM
imp closed D23527: Remove elf2aout.
Thu, Feb 6, 5:52 PM
imp closed D23526: Mark elf2aout as deprecated..
Thu, Feb 6, 5:52 PM
imp committed rS357626: Mark elf2aout as deprecated..
Mark elf2aout as deprecated.
Thu, Feb 6, 5:52 PM
imp committed rS357627: Remove elf2aout.
Remove elf2aout
Thu, Feb 6, 5:52 PM
imp committed rS357625: No need to have a special sparc64 list here..
No need to have a special sparc64 list here.
Thu, Feb 6, 5:52 PM
imp closed D23525: No need to have a special sparc64 list here..
Thu, Feb 6, 5:52 PM
imp committed rS357624: No need to make sunlabel anymore.
No need to make sunlabel anymore
Thu, Feb 6, 5:52 PM
imp closed D23524: No need to make sunlabel anymore.
Thu, Feb 6, 5:52 PM
imp committed rS357623: Restore missing comment.
Restore missing comment
Thu, Feb 6, 5:52 PM
imp added a comment to D23526: Mark elf2aout as deprecated..

A document describing the language and process of depreicating would be good to have.

Thu, Feb 6, 4:43 PM
imp committed rS357621: 'is now deprecated' -> 'is deprecated'.
'is now deprecated' -> 'is deprecated'
Thu, Feb 6, 4:38 PM
imp committed rS357622: Avoid the phrase 'now deprecated'.
Avoid the phrase 'now deprecated'
Thu, Feb 6, 4:38 PM
imp added inline comments to D23526: Mark elf2aout as deprecated..
Thu, Feb 6, 4:29 PM
imp added inline comments to D23526: Mark elf2aout as deprecated..
Thu, Feb 6, 4:27 PM
imp updated the diff for D23526: Mark elf2aout as deprecated..

update, per ed's comments using brooks' wording from 10M nic removal.

Thu, Feb 6, 4:26 PM
imp committed rS357620: MFC r357393.
MFC r357393
Thu, Feb 6, 4:22 PM
imp added inline comments to D23526: Mark elf2aout as deprecated..
Thu, Feb 6, 4:07 PM
imp added inline comments to D23540: Update Platform support information.
Thu, Feb 6, 3:40 PM
imp added a comment to D23527: Remove elf2aout.

Will commit with the usr.bin/Makefile changes suggested.

Thu, Feb 6, 12:24 AM
imp accepted D23124: 2020-02-29 rm GCC 4.2.1 build infrastructure.

I like it, and agree with the other comments you've already said you'd address.

Thu, Feb 6, 12:18 AM

Wed, Feb 5

imp added reviewers for D23527: Remove elf2aout: emaste, jhb.
Wed, Feb 5, 11:38 PM
imp created D23527: Remove elf2aout.
Wed, Feb 5, 11:34 PM
imp created D23526: Mark elf2aout as deprecated..
Wed, Feb 5, 11:30 PM
imp created D23525: No need to have a special sparc64 list here..
Wed, Feb 5, 11:29 PM
imp created D23524: No need to make sunlabel anymore.
Wed, Feb 5, 11:28 PM
imp created D23523: Restore missing comment.
Wed, Feb 5, 11:27 PM
imp accepted D23515: Temporarily force IFF_NEEDSEPOCH until drivers have been resolved..

This is the least sucky way to fix much of the breakage as a stop gap to the final solution

Wed, Feb 5, 3:49 AM

Tue, Feb 4

imp added inline comments to D23483: Fix for unbalanced EPOCH(9) usage in kernel interrupt handler.
Tue, Feb 4, 8:05 PM
imp committed rS357498: Bump __FreeBSD_version to 1300077 for r357455.
Bump __FreeBSD_version to 1300077 for r357455
Tue, Feb 4, 9:12 AM

Mon, Feb 3

imp committed rS357464: Fix a stray 'e'from my last commit..
Fix a stray 'e'from my last commit.
Mon, Feb 3, 7:36 PM
imp committed rS357455: Remove sparc64 kernel support.
Remove sparc64 kernel support
Mon, Feb 3, 5:35 PM
imp committed rS357454: Remove sparc64 support from the boot loader..
Remove sparc64 support from the boot loader.
Mon, Feb 3, 5:35 PM
imp committed rS357426: On powerpc, we use ofw_syscons for device sc. That references the default.
On powerpc, we use ofw_syscons for device sc. That references the default
Mon, Feb 3, 5:39 AM

Sun, Feb 2

imp committed rS357407: Per the firm plan, start to remove sparc64.
Per the firm plan, start to remove sparc64
Sun, Feb 2, 11:37 AM
imp added a comment to D23403: Add deprecation notice to vpo.4.

Shouldnt the driver code include a gone_in?

Sun, Feb 2, 8:47 AM
imp committed rS357401: Move font.h generation to conf/files from conf/files.*.
Move font.h generation to conf/files from conf/files.*
Sun, Feb 2, 8:27 AM