Hmmm, reserved is the right type for nvdimm, but it does pmap_large_map() instead of mpam_map(), but both of those should yield the same results...

We "should" support this. However, we do not, so this is the right thing to do.

I love it... if it works. You may need to move it later for my suggested test to success.

Aborting isn't on by default, so we have few miles on that code....

Thanks!

So I'm confused, why would the parent IRQ numbering matter here? Maybe explain that in the commit message since ISA is the only place that matters. ACPI interrupt isn't sufficiently specific, I guess.

Make them RWTUN. Best of both world. Then you can set them in the loader if you want (or more importantly need to), but you can also set them after boot if you are debugging. Most of the ACPI ones should be this, honestly. There's very few that can't be like that.

I'm surprised this is even here.

The only concern I have with the kernel enforcing write is what happens if we boot old binary, new kernel (which is quite typical). Would we have situations where we can't configure the system enough to build/install a new binary.

I'd have also broken this up by subcommand because all together the review length is starting to get hard to review.
And it's unclear what the actual syntax here is too. It's a case where the old-school camcontrol commands are getting in the way of having commands that are more similar to linux's nvme cli. Translating between what we do and what they do is a lot of friction for no benefit.