Page MenuHomeFreeBSD

imp (Warner Losh)
User

Projects

User Details

User Since
Jun 2 2014, 4:20 PM (263 w, 18 h)

Recent Activity

Yesterday

imp added inline comments to D20678: Changes to allow camcontrol to use cached data more often.
Mon, Jun 17, 8:59 PM
imp added reviewers for D20678: Changes to allow camcontrol to use cached data more often: scottl, ken, mav.
Mon, Jun 17, 8:33 PM
imp created D20678: Changes to allow camcontrol to use cached data more often.
Mon, Jun 17, 8:32 PM
imp added a comment to D20153: x11-drivers/xf86-video-vmware: Enable hardware accelerated graphics in VMware.

Looks OK to me. One possible nit

Mon, Jun 17, 5:46 AM
D20652: Document the PCIOCATTACHED ioctl(2) in pci(4) is now accepted and ready to land.
Mon, Jun 17, 3:05 AM

Sun, Jun 16

imp added inline comments to D20652: Document the PCIOCATTACHED ioctl(2) in pci(4).
Sun, Jun 16, 5:45 PM

Sat, Jun 15

imp committed rS336770: Remove Atmel AT91RM9200 and AT91SAM9 support..
Remove Atmel AT91RM9200 and AT91SAM9 support.
Sat, Jun 15, 4:37 PM
imp requested changes to D20644: MFC 348757: nvdimm: Provide nvdimm location information.
Sat, Jun 15, 4:10 PM

Thu, Jun 13

imp committed rS349025: Add opt_cam.h so we can build this outside of a kernel build..
Add opt_cam.h so we can build this outside of a kernel build.
Thu, Jun 13, 10:04 PM
imp added inline comments to D20626: bhyve: move common code to net_utils.c.
Thu, Jun 13, 4:02 PM
imp added a comment to D20630: ACPI support for USB , mainly hub..

I've not looked deeply into this, but it seems to my limited understanding in the right direction, though I'll defer to hps@ should his opinion differ.
Just noted a couple of nits, plus there's some minor style issues with some of the code that we can get into once other comments are made to the source.

Thu, Jun 13, 3:47 PM
imp added inline comments to D20626: bhyve: move common code to net_utils.c.
Thu, Jun 13, 3:43 PM
imp committed rS349011: Don't print the request we may be aborting in ciss_notify_abort as.
Don't print the request we may be aborting in ciss_notify_abort as
Thu, Jun 13, 5:19 AM
imp committed rS349010: Increase the timeout for READ NATIVE MAX.
Increase the timeout for READ NATIVE MAX
Thu, Jun 13, 5:19 AM

Wed, Jun 12

imp added inline comments to D20615: Add support for retrieving the VPD pages that are supported..
Wed, Jun 12, 10:25 PM
imp accepted D20622: Fix gcc build.

yea, this never should have been in boot_module.h to start with.

Wed, Jun 12, 9:52 PM

Tue, Jun 11

imp updated the diff for D20615: Add support for retrieving the VPD pages that are supported..

Nits

Tue, Jun 11, 9:37 PM
imp created D20615: Add support for retrieving the VPD pages that are supported..
Tue, Jun 11, 9:17 PM
imp committed rS348963: Minor white space changes..
Minor white space changes.
Tue, Jun 11, 8:48 PM

Mon, Jun 10

imp accepted D20591: Make it obvious that SR-IOV VF creation fails because of the PCIe bus, not the device driver.
Mon, Jun 10, 10:59 PM · PCI
imp accepted D20507: enable synaptics and elantech touchpads by default.
Mon, Jun 10, 6:09 PM
imp added inline comments to D20562: The efifat files are no longer used: remove the code to build them..
Mon, Jun 10, 12:31 AM

Sat, Jun 8

imp added a comment to D20562: The efifat files are no longer used: remove the code to build them..

Added emaste as a sanity check for the 'not used' bit. I'd like to see this die in fire.

Sat, Jun 8, 10:46 PM
imp added a reviewer for D20562: The efifat files are no longer used: remove the code to build them.: emaste.
Sat, Jun 8, 10:46 PM
imp accepted D20562: The efifat files are no longer used: remove the code to build them..
Sat, Jun 8, 10:45 PM
imp committed rS348814: Add stuff to disable warning for %S.
Add stuff to disable warning for %S
Sat, Jun 8, 7:59 PM
imp committed rS348812: Create gptboot.efi.
Create gptboot.efi
Sat, Jun 8, 7:02 PM
imp committed rS348811: Break out the disk selection protocol from the rest of boot1..
Break out the disk selection protocol from the rest of boot1.
Sat, Jun 8, 7:00 PM
imp closed D20547: Split boot1 in half and use the useful half for gptboot.efi.
Sat, Jun 8, 7:00 PM
imp added inline comments to D20547: Split boot1 in half and use the useful half for gptboot.efi.
Sat, Jun 8, 5:23 PM
imp added inline comments to D20547: Split boot1 in half and use the useful half for gptboot.efi.
Sat, Jun 8, 5:43 AM
imp added inline comments to D20547: Split boot1 in half and use the useful half for gptboot.efi.
Sat, Jun 8, 5:40 AM
imp added inline comments to D20547: Split boot1 in half and use the useful half for gptboot.efi.
Sat, Jun 8, 5:34 AM
imp added inline comments to D20547: Split boot1 in half and use the useful half for gptboot.efi.
Sat, Jun 8, 5:28 AM

Fri, Jun 7

imp accepted D20482: Free MCA entries after logging.
Fri, Jun 7, 6:37 PM
imp added a comment to D20293: ucom(4): synchronously execute param changes.
In D20293#444094, @ian wrote:

I agree about that, but as you know the TTY layer holds a mutex while calling us, so sleeping is not allowed or am I wrong? You don't solve mutex problems by just dropping the TTY lock, that leaves races wide open.
I suggest a new method in the ttydevsw which drain any pending commands off the underlying layer, which can be called outside the tty_lock() so we don't mess with the TTY's internal state.

Oh right, I had forgotten about tty_lock() being held during calls to ttydevsw stuff. Now I remember looking into all this once before, a few years ago. What I discovered (and re-discovered yesterday) is that lots of places now are dropping and reacquiring the tty lock, unsafely. At a minimum, you have to check tty_gone() after recaquiring it. In addition you have to consider the other parts of tty state that the lock protects and what might have changed there, and that's hard to do because what the lock protects is not documented.

Fri, Jun 7, 3:22 PM
imp added a comment to D20116: Introduce <sys/qmath.h>.
In D20116#443964, @cem wrote:

The concept is cool but it's impossible to closely review 2000 lines of novel content.

Fri, Jun 7, 2:24 PM
imp accepted D20548: Teach readelf about some OpenBSD ELF program headers.
Fri, Jun 7, 3:49 AM
imp updated the test plan for D20547: Split boot1 in half and use the useful half for gptboot.efi.
Fri, Jun 7, 2:27 AM
imp created D20547: Split boot1 in half and use the useful half for gptboot.efi.
Fri, Jun 7, 2:24 AM
imp committed rS348768: Rework the reporting of the priority..
Rework the reporting of the priority.
Fri, Jun 7, 2:05 AM
imp closed D20537: Rework the reporting of the priority..
Fri, Jun 7, 2:05 AM
imp committed rS348766: Remove left-over status variables.
Remove left-over status variables
Fri, Jun 7, 12:02 AM

Thu, Jun 6

imp committed rS348763: Fix when NOFAT is defined.
Fix when NOFAT is defined
Thu, Jun 6, 10:57 PM
imp committed rS348760: Use simple malloc/free instead of dropping down to the UEFI.
Use simple malloc/free instead of dropping down to the UEFI
Thu, Jun 6, 9:04 PM
imp closed D20540: Use simple malloc/free instead of dropping down to the UEFI BootServices AllocatePool/FreePool calls. They are simpler to use and result in the same thing happening..
Thu, Jun 6, 9:04 PM
imp accepted D20542: Remove an overly-aggressive assertion..
Thu, Jun 6, 8:54 PM
imp accepted D20315: Add list of valid CPUTYPE flags for arm/arm64 to make.conf example.
Thu, Jun 6, 8:34 PM · arm64, ARM
imp updated the test plan for D20540: Use simple malloc/free instead of dropping down to the UEFI BootServices AllocatePool/FreePool calls. They are simpler to use and result in the same thing happening..
Thu, Jun 6, 6:58 PM
imp created D20540: Use simple malloc/free instead of dropping down to the UEFI BootServices AllocatePool/FreePool calls. They are simpler to use and result in the same thing happening..
Thu, Jun 6, 6:56 PM
imp accepted D20527: improve performance of ipmi kcs interface..
Thu, Jun 6, 5:46 PM
imp updated the test plan for D20537: Rework the reporting of the priority..
Thu, Jun 6, 4:54 PM
imp created D20537: Rework the reporting of the priority..
Thu, Jun 6, 4:41 PM
imp accepted D20031: Allow control over initial state of RTS and DTR lines.

Use rtsdtr as the stty argument to set the default mode, and -rtsdtr to
disable automatically asserting them on open().
This causes the stty argument to have the opposite polarity as the control
flag. The stty flag name can be renamed fairly easily, but the control flag
pretty much needs to default to zero.

Thu, Jun 6, 4:23 PM
imp committed rS348722: Don't make the efifat thing if NOFAT is defined..
Don't make the efifat thing if NOFAT is defined.
Thu, Jun 6, 3:07 AM

Wed, Jun 5

imp accepted D20506: isa/isa_common.c: remove needless if (!rl) check in isa_get_resource_list().

I'd just roll with this. IMHO, the simplicity trumps the other patterns in the file because using the pattern here gives no real benefit.

Wed, Jun 5, 3:36 PM
imp requested changes to D20520: Normalize deployment tools usage and definitions.

bootools is a terrible name, so bad I'm ticking 'request changes'.

Wed, Jun 5, 3:35 PM
imp added a comment to D20458: first step towards enforcing must-succeed semantics for bus accessors.
In D20458#443364, @cem wrote:
In D20458#443358, @avg wrote:

I would like to commit this change as is now. And then change printf to KASSERT in a week rather than in a month.
Hope that no one would object.

Ok by me.

In D20458#443359, @avg wrote:

Also, another thing that I realized is that this defensive code won't help much if a bus defines BUS1_IVAR_X and a child device requests BUS2_IVAR_Y when BUS1_IVAR_X == BUS2_IVAR_Y.
BUS_READ_IVAR / BUS_WRITE_IVAR may succeed in that case but the result could be meaningless.
The only idea I have is to start gradually introducing a pattern where a first value of an ivar enum is some randomly chosen number.
E.g.:

enum {
        IICBUS_IVAR_ADDR = 100500,      /* Address or base address */
        IICBUS_IVAR_NOSTOP,             /* nostop defaults */
};
enum smbus_ivars {
    SMBUS_IVAR_ADDR = 100600,           /* slave address of the device */
};

That might help to minimize a chance of an accidental ivar value clash.
But changing this for existing ivars would break the ABI.
So, I guess, that we could start doing this only for new bus devices.

Could do something cute like compile time hash of svn/git rev + bus + var name? Would require some makefile support or a c++1x constexpr compilation unit with extern C visibility (depending on how much we care to detect this). Obviously svn/git revision would be frozen at stable branch. Maybe too cute for little benefit.

Wed, Jun 5, 3:30 PM
imp committed rS348678: Eliminate unused uuid parameters from gptread and gptread_table. We.
Eliminate unused uuid parameters from gptread and gptread_table. We
Wed, Jun 5, 2:35 AM
imp committed rS348675: ufs_module.c can't currently be compiled with -Wcast-align, but the.
ufs_module.c can't currently be compiled with -Wcast-align, but the
Wed, Jun 5, 12:08 AM
imp committed rS348674: Don't shadow a global zfsmount variable..
Don't shadow a global zfsmount variable.
Wed, Jun 5, 12:04 AM

Tue, Jun 4

imp added a comment to D19746: Introduce sim_dev and cam_sim_alloc_dev()..

The change looks reasonable to me. Are there any ABI issues with changing the size of struct cam_sim?

Tue, Jun 4, 11:02 PM
imp accepted D19746: Introduce sim_dev and cam_sim_alloc_dev()..
Tue, Jun 4, 10:58 PM
imp committed rS348659: Use newly minted efi_devpath_same_disk() instead of.
Use newly minted efi_devpath_same_disk() instead of
Tue, Jun 4, 6:36 PM
imp committed rS348658: Introduce efi_devpath_same_disk.
Introduce efi_devpath_same_disk
Tue, Jun 4, 6:36 PM
imp closed D20513: Fix regression in r347193 in selecting which drive to boot..
Tue, Jun 4, 6:36 PM
imp added a reviewer for D20513: Fix regression in r347193 in selecting which drive to boot.: tsoome.
Tue, Jun 4, 3:32 PM
imp created D20513: Fix regression in r347193 in selecting which drive to boot..
Tue, Jun 4, 2:55 PM
imp added a comment to D20506: isa/isa_common.c: remove needless if (!rl) check in isa_get_resource_list().

Warner, do you want me to update the diff to use return (&DEVTOISA(child)->id_resources);? I'm a bit worried that it would cause more repochurn compared to the current diff which only removes the lines and thus does not affect svn blame on the the others.

Tue, Jun 4, 2:12 PM
imp accepted D20509: daemon(8): Don't block TERM during restart delay.
Tue, Jun 4, 2:00 PM

Mon, Jun 3

imp accepted D20507: enable synaptics and elantech touchpads by default.

This change should do what it says it will do.
Let's see if we can get a bunch of 'works for me' reports from testers :)

Mon, Jun 3, 8:29 PM
imp accepted D20506: isa/isa_common.c: remove needless if (!rl) check in isa_get_resource_list().

It's never needed it

Mon, Jun 3, 7:16 PM
imp committed rS348569: [zfsboot] Fix boot env back compat (#190).
[zfsboot] Fix boot env back compat (#190)
Mon, Jun 3, 7:11 PM
imp abandoned D19816: Add an option for specifying the default debug flags for mps driver..

On second thought, I'll use the tunable.

Mon, Jun 3, 6:03 PM
imp accepted D20501: loader: disk_open() should honor D_PARTNONE.

I think this is good, thought I thought'd I'd committed the PARTWILD stuff already. Are there more places I/we've missed?

Mon, Jun 3, 3:12 PM
imp committed rS348530: Stopgap fix to breakage from r348521..
Stopgap fix to breakage from r348521.
Mon, Jun 3, 2:15 PM
imp committed rS348527: Another partial revert of r301289..
Another partial revert of r301289.
Mon, Jun 3, 5:25 AM
imp committed rS348526: Fix mismerge that crept into r301289..
Fix mismerge that crept into r301289.
Mon, Jun 3, 5:25 AM

Sun, Jun 2

imp committed rS348519: Revert r348518.
Revert r348518
Sun, Jun 2, 8:52 PM
imp committed rS348518: Reapply r301691:.
Reapply r301691:
Sun, Jun 2, 8:47 PM
imp committed rS348515: This should have been committed in r348511 with the awk update..
This should have been committed in r348511 with the awk update.
Sun, Jun 2, 4:44 PM
imp committed rS348513: Reapply r315426 by pfg:.
Reapply r315426 by pfg:
Sun, Jun 2, 4:31 PM
imp committed rS348512: Reapply r301289 by pfg:.
Reapply r301289 by pfg:
Sun, Jun 2, 4:28 PM
imp committed rS348511: Merge from upstream at 4189ef5d from https://github.com/onetrueawk/awk.git.
Merge from upstream at 4189ef5d from https://github.com/onetrueawk/awk.git
Sun, Jun 2, 4:25 PM
imp committed rS348506: Record the vendor import of git has 4189ef5d from.
Record the vendor import of git has 4189ef5d from
Sun, Jun 2, 4:28 AM
imp committed rS348505: Import latest one-true-awk from upstream.
Import latest one-true-awk from upstream
Sun, Jun 2, 4:24 AM

Sat, Jun 1

imp committed rS348495: Since a fatal trap can happen at aribtrary times, don't panic when the.
Since a fatal trap can happen at aribtrary times, don't panic when the
Sat, Jun 1, 3:37 PM
imp closed D20478: Since a fatal trap can happen at aribtrary times, don't panic when the completions are not in a consistent state..
Sat, Jun 1, 3:37 PM
imp accepted D20491: Fix comment parsing in interp_simple.c.
Sat, Jun 1, 4:15 AM
imp accepted D20490: Warn about deprecated features on all major OS versions..
Sat, Jun 1, 2:29 AM

Fri, May 31

imp committed rS348486: Defer evaluation of modified until after it's set.
Defer evaluation of modified until after it's set
Fri, May 31, 10:57 PM
imp closed D20480: Defer evaluation of modified until after it's set.
Fri, May 31, 10:57 PM
imp updated the diff for D20478: Since a fatal trap can happen at aribtrary times, don't panic when the completions are not in a consistent state..

better comment.

Fri, May 31, 9:10 PM
imp updated the diff for D20478: Since a fatal trap can happen at aribtrary times, don't panic when the completions are not in a consistent state..

Remove now-obsolete comment.

Fri, May 31, 9:05 PM
imp added a comment to D20480: Defer evaluation of modified until after it's set.

No objection but I'm generally not a fan of the deferred evaluation; what about just setting include_metadata=yes/no/if-modified and making the test something like
if [${include_metadata} = yes || (${include_metadata} = if-modified && ${modified} = yes)]
Anyway if you prefer this approach that's fine with me

Fri, May 31, 9:03 PM
imp accepted D20482: Free MCA entries after logging.
Fri, May 31, 8:55 PM
imp updated the diff for D20480: Defer evaluation of modified until after it's set.

Fix per ed (though a little different construct)
Fix backwards test after converting from -z notation...

Fri, May 31, 8:53 PM
imp updated the diff for D20478: Since a fatal trap can happen at aribtrary times, don't panic when the completions are not in a consistent state..

Plug more holes with tips from kib, jhb and markj.

Fri, May 31, 8:12 PM
imp updated the diff for D20478: Since a fatal trap can happen at aribtrary times, don't panic when the completions are not in a consistent state..

Try a little harder, add comments.

Fri, May 31, 3:27 PM
imp added reviewers for D20480: Defer evaluation of modified until after it's set: emaste, zeising.
Fri, May 31, 3:12 PM