Page MenuHomeFreeBSD

imp (Warner Losh)
User

Projects

User Details

User Since
Jun 2 2014, 4:20 PM (254 w, 3 d)

Recent Activity

Yesterday

imp committed rS346359: When parsing command line stuff, treat tabs and spaces the same..
When parsing command line stuff, treat tabs and spaces the same.
Thu, Apr 18, 10:52 PM
imp added inline comments to D19944: random(4): Restore availability tradeoff prior to r346250.
Thu, Apr 18, 5:24 PM
imp committed rS346354: Add note that I'm the defacto maintainer of libegacy, our.
Add note that I'm the defacto maintainer of libegacy, our
Thu, Apr 18, 3:19 PM
imp committed rS346353: Minor tweak to the debug.
Minor tweak to the debug
Thu, Apr 18, 3:19 PM
imp committed rS346346: Add efi_delenv.
Add efi_delenv
Thu, Apr 18, 5:41 AM
imp committed rS346345: Add a more generic efi_setenv function..
Add a more generic efi_setenv function.
Thu, Apr 18, 5:37 AM
imp accepted D19944: random(4): Restore availability tradeoff prior to r346250.
Thu, Apr 18, 3:32 AM
imp added a comment to D19944: random(4): Restore availability tradeoff prior to r346250.

This looks good, and we can make good use of this in our automation. It's adequate for netflix to decide what to do at boot when the aberrant conditions happen, as well as accommodating our diverse deployment model which is currently biased towards servers, but may not always be.

Thu, Apr 18, 3:31 AM

Wed, Apr 17

imp accepted D18933: Ensure kernel.bootfile is a real file.

Other than fixing the misleading comments, I understand why we're doing this, and it looks good.

Wed, Apr 17, 5:59 PM
imp requested changes to D18933: Ensure kernel.bootfile is a real file.

The sysctl returns non-nonsense now. Is this even needed?

Wed, Apr 17, 5:57 PM
imp requested changes to D19928: random(4): More thoroughly attempt to ensure seeding during priming.

I like that we can have a fallback seeding to RND devices, but Netflix requires a system to be bootable to userland no matter what goes on with the randomness in early boot. As such, we'd like a mode that can report that something screwed up in the early random stuff so we can decide if we care or not about that. And then take appropriate action based on our level of caring and concern. We have boxes all over the world and a hung boot would mean an RMA which is quite costly. We'd rather the system come up at least enough to report broken randomness to our backplane, or to take remediation steps when, for example, our entropy file is corrupted on a crash by recreating it and rebooting.

Wed, Apr 17, 5:38 PM

Tue, Apr 16

imp accepted D19927: stack_protector: Add tunable to bypass random cookies.

this is a reasonable stopgap, approved with the understanding that there will be follow on work to allow MD sources of entropy, like RDSEED on x86 etc

Tue, Apr 16, 6:29 PM

Sun, Apr 14

imp accepted D19904: bhyve: Add Integrated Endpoint to PCIe Capability.

Looks good to me.

Sun, Apr 14, 7:12 PM
imp added a comment to D19905: bhyve: Add EUI64 to NVMe device.

There's only one issue that I see with this commit, and that's OUI namespace management. It's likely not a huge deal, but I think it's an easy thing to get right. emaste@ or kevans@ have the context / information to get the allocation from the foundation that I think we need. It's a minor tweak to the code to o things that way.

Sun, Apr 14, 7:06 PM

Sat, Apr 13

imp committed rS346177: Move mpr/mps drivers from per-arch NOTES files into the MI notes.
Move mpr/mps drivers from per-arch NOTES files into the MI notes
Sat, Apr 13, 6:30 AM
imp committed rS346176: Fix sbttons for values > 2s.
Fix sbttons for values > 2s
Sat, Apr 13, 4:46 AM

Fri, Apr 12

imp accepted D19507: Add quirk for ignoring SPCR AccessWidth values on the PL011 UART.

Looks like Andy's suggestions were followed... I was going to make similar when I last looked at it as well.

Fri, Apr 12, 11:09 PM · arm64
imp accepted D19781: rename nvme_ctrlr_destroy_qpair to nvme_ctrlr_destroy_qpairs.

This change looks correct to me. Unsure why we need to do it though. Would like to see the follow-on fixes that this depends on, since I'm pretty happy with this if there's some reason to change.

Fri, Apr 12, 6:49 PM
imp accepted D19841: bhyve NVMe emulation locking.

This looks OK to me, but my knowledge of what bhyve does to emulate PCI is weak.

Fri, Apr 12, 6:47 PM

Thu, Apr 11

imp accepted D19876: Allow this script to be run from within src/tools/boot dir, create image in $TMPDIR..
Thu, Apr 11, 4:27 PM
imp added inline comments to D17675: Suspend to idle support.
Thu, Apr 11, 3:22 PM

Wed, Apr 10

imp accepted D19832: Add some CMD53-related definitions.
Wed, Apr 10, 8:42 PM
imp added inline comments to D17055: gpioc user-space interrupt handling.
Wed, Apr 10, 8:00 PM · ARM
imp accepted D19779: Add new fields to mmc_data in preparation to SDIO CMD53 block mode support.
Wed, Apr 10, 7:43 PM · ARM
imp accepted D19871: Only set up the interrupts that will actually be used in arm generic_timer..
Wed, Apr 10, 3:35 AM
imp accepted D19870: Parse simple MIPS relocations to unbreak kldxref on MIPS..

So this looks good to me. Having at least mips64 covered, even if other things are unknown is a win. one question about r_mips_32 to think about.

Wed, Apr 10, 1:24 AM

Tue, Apr 9

imp accepted D19865: Make zfsd(8) build obey CFLAGS.
Tue, Apr 9, 5:42 PM
imp accepted D18793: Implement support for "/SYM64/" archives in ar.

Couple of minor style nits, but the code looks good to my brain.

Tue, Apr 9, 5:28 PM
imp accepted D19817: add mrsas_shutdown method.

This looks good to me, however I'd wait a few days to see if Scott can spot something that I can't.

Tue, Apr 9, 5:20 PM
imp added inline comments to D19833: pci_cfgreg.c: Use io port config access for early boot time..
Tue, Apr 9, 5:19 PM

Mon, Apr 8

imp added inline comments to D19832: Add some CMD53-related definitions.
Mon, Apr 8, 7:59 PM
imp accepted D19783: Implement CMD53 block mode support for SDHCI and AllWinner-based boards.

OK. this looks good, and you are using the flag I was complaining about not being used , so ignore that bit.
This is conditional on D19779.
and I'm ENOCLUE on the hardware, but it looks like it might be right.

Mon, Apr 8, 7:58 PM
imp added inline comments to D19779: Add new fields to mmc_data in preparation to SDIO CMD53 block mode support.
Mon, Apr 8, 7:56 PM · ARM
imp added inline comments to D19849: Reorg newvers.sh to eliminate VARS_ONLY and do things more directly.
Mon, Apr 8, 7:21 PM
imp retitled D19849: Reorg newvers.sh to eliminate VARS_ONLY and do things more directly from Move function definitions to after the VARS_ONLY exit to Reorg newvers.sh to eliminate VARS_ONLY and do things more directly.
Mon, Apr 8, 6:42 PM
imp updated the diff for D19849: Reorg newvers.sh to eliminate VARS_ONLY and do things more directly.

Finish the transition

Mon, Apr 8, 6:39 PM
imp created D19849: Reorg newvers.sh to eliminate VARS_ONLY and do things more directly.
Mon, Apr 8, 6:26 PM
imp committed rS346039: Style only change: Prefer $() to ``.
Style only change: Prefer $() to ``
Mon, Apr 8, 6:25 PM
imp closed D19840: Style only change: Prefer $() to ``.
Mon, Apr 8, 6:25 PM

Sun, Apr 7

imp committed rS346022: Make RELDATE be on a single line..
Make RELDATE be on a single line.
Sun, Apr 7, 9:01 PM
imp added reviewers for D19840: Style only change: Prefer $() to ``: emaste, allanjude.
Sun, Apr 7, 6:58 PM
imp created D19840: Style only change: Prefer $() to ``.
Sun, Apr 7, 6:57 PM
imp committed rS346018: Use default shell assignment rather more complicated if then.
Use default shell assignment rather more complicated if then
Sun, Apr 7, 6:40 PM
imp closed D19797: Use default shell assignment rather more complicated if then construct..
Sun, Apr 7, 6:40 PM

Fri, Apr 5

imp added a comment to D19695: bhyve(8): Fix NVMe data structure copy to guest.
In D19695#423813, @imp wrote:

This looks good to me. It's the right thing to do.
Do we need to expand it more generally (in a different commit) for any time we have to copy data out, or is the I/O path good?

The IO path appears to be OK, but I only took brief look. That said, I've run a fair amount of IO against and haven't seen any issues in practice. Where as this issue was easily reproducible.

Fri, Apr 5, 4:20 PM
imp committed rS345947: Remove another instance of All Rights Reserved..
Remove another instance of All Rights Reserved.
Fri, Apr 5, 2:28 PM
imp updated the diff for D19797: Use default shell assignment rather more complicated if then construct..

Fix, per ed. move b= to place closer to where it's used.

Fri, Apr 5, 6:16 AM
imp added a comment to D19816: Add an option for specifying the default debug flags for mps driver..

I debated tossing this into sys/conf/NOTES, but didn't want to play whack-a-mole with the architectures that I'd opt out of... Comments?

Fri, Apr 5, 6:07 AM
imp updated the diff for D19816: Add an option for specifying the default debug flags for mps driver..

mps debug flags in NOTES, as appropriate.

Fri, Apr 5, 6:04 AM
imp added a comment to D19827: aac(4): Add subvendor / subdevice to MODULE_PNP_INFO()'s descriptor_string.

I'm trying to recall that. I know that the different types of subdevices don't change what's probed (as there are catch-all entries). I had a specific reason, but I can't recall it now.

Fri, Apr 5, 5:35 AM
imp added a comment to D19827: aac(4): Add subvendor / subdevice to MODULE_PNP_INFO()'s descriptor_string.

I specifically allowed those duplicates when I was originally reviewing this change....

Fri, Apr 5, 5:20 AM
imp added a comment to D19816: Add an option for specifying the default debug flags for mps driver..
In D19816#425165, @cem wrote:

Why not just cut straight to a tunable instead and save a compile?

Fri, Apr 5, 3:38 AM
imp committed rS345902: Add mpr, mps, mpt to NOTES file.
Add mpr, mps, mpt to NOTES file
Fri, Apr 5, 2:54 AM

Thu, Apr 4

imp added inline comments to D19817: add mrsas_shutdown method.
Thu, Apr 4, 5:17 PM
imp added a comment to D19816: Add an option for specifying the default debug flags for mps driver..

If this looks good, I'll do the identical changes to mpr as well.

Thu, Apr 4, 3:56 AM
imp updated the test plan for D19816: Add an option for specifying the default debug flags for mps driver..
Thu, Apr 4, 3:54 AM
imp created D19816: Add an option for specifying the default debug flags for mps driver..
Thu, Apr 4, 3:53 AM

Wed, Apr 3

imp accepted D19646: Add BUS_RESET() and devctl reset..

Looks great, apart from the stupid date nits :). And even if those weren't fixed, it wouldn't be too bad.

Wed, Apr 3, 3:54 PM
imp requested changes to D19706: Kernel code to upgrade to use the latest contrib/zlib..
Wed, Apr 3, 4:39 AM

Tue, Apr 2

imp added inline comments to D19690: mount/unmount events to devd.
Tue, Apr 2, 10:07 PM · Contributor Reviews (base)
imp added inline comments to D19690: mount/unmount events to devd.
Tue, Apr 2, 10:01 PM · Contributor Reviews (base)
imp added inline comments to D19779: Add new fields to mmc_data in preparation to SDIO CMD53 block mode support.
Tue, Apr 2, 4:28 PM · ARM
imp added inline comments to D19797: Use default shell assignment rather more complicated if then construct..
Tue, Apr 2, 4:24 PM
imp created D19797: Use default shell assignment rather more complicated if then construct..
Tue, Apr 2, 3:44 PM

Mon, Apr 1

imp added inline comments to D19779: Add new fields to mmc_data in preparation to SDIO CMD53 block mode support.
Mon, Apr 1, 10:59 PM · ARM
imp added a comment to D19779: Add new fields to mmc_data in preparation to SDIO CMD53 block mode support.
In D19779#424220, @bz wrote:

This is missing files I think. The mmcreg.h structure changes are missing from this one. This won't compile.

Sorry, something has gone wrong with my tree. I will reupload.

Mon, Apr 1, 10:23 PM · ARM
imp added inline comments to D19747: Improve sdhci slot_printf() debug printing..
Mon, Apr 1, 10:20 PM
imp accepted D19748: Improve error/debug messages in sdhci.c.
Mon, Apr 1, 10:17 PM
imp added a comment to D19778: Reap idle src bits.

So slm is Steve McConnell who has been the long-time driver maintainer inside of LSI/et-al. His day job has transitioned to firmware, but is active on phab.
Achim is from Adaptec / Microsemi and left Adaptec in 2016.
Scott is going to contact both of them as a courtesy to these vendors.

Mon, Apr 1, 10:03 PM
imp accepted D19778: Reap idle src bits.

Apart from slm and achim, I'm good. Let's put those two in the not yet box.

Mon, Apr 1, 9:54 PM
imp updated the diff for D19296: Generic cmd parsing.

Update after latest cleanups.

Mon, Apr 1, 9:06 PM
imp accepted D15912: sys/cam/mmc/mmc_da.c: Refactor error handling.
Mon, Apr 1, 6:24 PM
imp accepted D15892: Use information about max data size that the controller is able to operate.
Mon, Apr 1, 6:24 PM
imp added a comment to D19749: Add a CAM-Newbus SDIO support module..

I'd be happier if we copied usbdevs.awk to sdiodevs.awk.
I'll take a closer look next week when I'm back in the office.

Mon, Apr 1, 5:10 PM
imp added a comment to D19507: Add quirk for ignoring SPCR AccessWidth values on the PL011 UART.
In D19507#423825, @imp wrote:

IIRC, this violates the ACPI definition for these fields.

Where are they defined? https://docs.microsoft.com/en-us/windows-hardware/drivers/serports/serial-port-console-redirection-table — Ctrl+F "width" — 0 results. (Thanks Microsoft.)

Mon, Apr 1, 2:37 PM · arm64
imp added inline comments to D19646: Add BUS_RESET() and devctl reset..
Mon, Apr 1, 2:26 PM
imp accepted D19773: Remove note about possible support changes for STABLE/12.
Mon, Apr 1, 1:39 AM

Sun, Mar 31

imp added a comment to D19507: Add quirk for ignoring SPCR AccessWidth values on the PL011 UART.

Dammit. The Ampere eMAG (which uses the pl011 SBSR UART) represents *shiftp = 2; as

[029h 0041   1]                    Bit Width : 20
[02Ah 0042   1]                   Bit Offset : 00
[02Bh 0043   1]         Encoded Access Width : 01 [Byte Access:8]
Sun, Mar 31, 5:25 PM · arm64
imp added inline comments to D19019: zfs stand: plumb primary vdev out through zfs_probe_dev as needed.
Sun, Mar 31, 5:14 PM
imp accepted D19695: bhyve(8): Fix NVMe data structure copy to guest.

This looks good to me. It's the right thing to do.
Do we need to expand it more generally (in a different commit) for any time we have to copy data out, or is the I/O path good?

Sun, Mar 31, 4:14 PM
imp accepted D19676: bhyve: Fix NVMe BAR size calculation.

one quick Q. if you know the windows versions, document it in the comment. the code is good to go. If you know, update the comment. If you don't know, that's cool too. either way, I no need to do a round trip through the review. you can just tweak that and commit.

Sun, Mar 31, 4:11 PM

Sat, Mar 30

imp added a comment to D19754: cxgbe(4): Integrate with PNP PCIID-based autoload.

jhb specifically asked me not to do this driver. Please be sure to get sign off from him.

Sat, Mar 30, 6:28 AM
imp added a comment to D19749: Add a CAM-Newbus SDIO support module..

I'd be happier if we copied usbdevs.awk to sdiodevs.awk.
I'll take a closer look next week when I'm back in the office.

Sat, Mar 30, 6:24 AM
imp requested changes to D19749: Add a CAM-Newbus SDIO support module..

I'd be happier if we copied usbdevs.awk to sdiodevs.awk.

Sat, Mar 30, 6:23 AM

Fri, Mar 29

imp accepted D19736: fdt: further consolidate DTB building and revise manpage.

These are good changes, though the conf/files and kern.post.mk fragments seem a separate thing...

Fri, Mar 29, 1:39 AM

Thu, Mar 28

imp accepted D19646: Add BUS_RESET() and devctl reset..

generally, I'm happy. Once minor nit that you can do or not as you see fit.

Thu, Mar 28, 8:48 PM

Tue, Mar 26

imp added inline comments to D19646: Add BUS_RESET() and devctl reset..
Tue, Mar 26, 8:59 PM
imp accepted D19696: Make smartpqi(4) behave better when running out of memory..

I think this looks good, but I've not studied it in enough detail to know for sure.
It might make sense to see if Scott or Ken has a chance to look into this to be sure it's the right solution.

Tue, Mar 26, 3:58 AM

Mon, Mar 25

imp added inline comments to D19424: config: Only warn if duplicate option/device comes from the same file.
Mon, Mar 25, 11:53 PM
imp added a comment to D18902: Change default value of kernel.bootfile.

My mistake... 386bsd booted from a file named /386bsd. FreeBSD changed that early on to be /kernel.

Mon, Mar 25, 6:47 AM

Sun, Mar 24

imp added a comment to D18902: Change default value of kernel.bootfile.

Current default was set before 1996, when "/kernel" was the
actual path I guess.

Sun, Mar 24, 9:20 PM
imp accepted D18902: Change default value of kernel.bootfile.

Defaults should match defaults. If we don't know, guess the default FFS.

Sun, Mar 24, 9:15 PM

Sat, Mar 23

imp committed rS345456: Remove duplicate options..
Remove duplicate options.
Sat, Mar 23, 6:32 PM
imp committed rS345455: Add device xz. This was somehow missed in the last round..
Add device xz. This was somehow missed in the last round.
Sat, Mar 23, 6:32 PM

Fri, Mar 22

imp added a comment to D19677: Fix timeout-related panics in MPR and MPS.

derp... I missed you did both...

Fri, Mar 22, 2:05 PM
imp accepted D19677: Fix timeout-related panics in MPR and MPS.

Does MPR need a similar fix?

Fri, Mar 22, 2:04 PM

Thu, Mar 21

imp accepted D19661: Add Cirrus-CI CI build and QEMU boot test.
Thu, Mar 21, 1:31 PM
imp added a comment to D19661: Add Cirrus-CI CI build and QEMU boot test.

You might want to take a look at tools/boot/rootgen.sh. It's as shell script I use to generate about 24 or 32 different images to test all the different ways you can boot. It also generates a bunch of different scripts to do the qemu testing that likely could be leveraged to provide more complete qemu coverage testing.

Thu, Mar 21, 1:30 PM
imp committed rS345365: Remove -n flag, fix setting date / time.
Remove -n flag, fix setting date / time
Thu, Mar 21, 6:47 AM
imp closed D19668: Remove -n flag, fix setting date / time.
Thu, Mar 21, 6:47 AM