Page MenuHomeFreeBSD

imp (Warner Losh)
User

Projects

User Details

User Since
Jun 2 2014, 4:20 PM (347 w, 4 h)

Recent Activity

Today

imp requested review of D28338: newvers: tweak uname to be more useful.
Mon, Jan 25, 8:03 PM

Yesterday

imp accepted D28312: Remove leftover big-endian arm support from libc.
Sun, Jan 24, 2:12 AM

Fri, Jan 22

imp added a comment to D28260: Define PNP info after defining driver modules.
In D28260#632737, @cem wrote:

Hmm, the kldxref change doesn't fully fix the problem as I understand it (not that my commit does). The real problem is that the pnp info structure doesn't contain the module name, so devmatch(8) doesn't know which PNP info goes with which module. The kldxref change at least ensures that devmatch won't try to process a PNP info definition without having seen an MDT_MODULE record.

MDT_PNP_INFO always corresponds to the most recently traversed MDT_MODULE. That's the ordering property guaranteed by the kldxref change. I don't know what crash or bug you hit in devmatch exactly. Do you have a stack or short summary? Does it reproduce on CURRENT or with kldxref otherwise fixed?

The reason we made the kldxref change was to generally address a specific problem this revision also seems to try to address — the ordering between MDT_MODULE and MDT_PNP_INFO. So I am surprised that we still need to shuffle things around in the code. If we're missing something in kldxref or devmatch, let's fix it there. (As the kldxref commit mentions, there is no guarantee the compiler preserves the source code ordering of static data values.)

Fri, Jan 22, 9:05 PM
imp accepted D28267: Create symlinks to host tools on non-FreeBSD hosts.

We only need the copies on FreeBSD to avoid the issue you cited. On other systems, symlinks are fine.

Fri, Jan 22, 4:26 PM
imp added a comment to D28260: Define PNP info after defining driver modules.
In D28260#632585, @cem wrote:

Wait, kldxref should be ordering these correctly since rS348309. Why isn't it?

Probably because I hit this issue on stable/12 and didn't notice that kldxref was fixed.

Hmm, the kldxref change doesn't fully fix the problem as I understand it (not that my commit does). The real problem is that the pnp info structure doesn't contain the module name, so devmatch(8) doesn't know which PNP info goes with which module. The kldxref change at least ensures that devmatch won't try to process a PNP info definition without having seen an MDT_MODULE record.

Fri, Jan 22, 2:51 AM

Wed, Jan 20

imp accepted D28262: devinfo sysctl handler: Do not write zero-length strings in to sbuf twice.
Wed, Jan 20, 10:55 PM
imp added a comment to D28260: Define PNP info after defining driver modules.
In D28260#632046, @imp wrote:

To expand a little: devmatch shouldn't dump core... I don't see how, but I've not seen the core traceback yet...

Wed, Jan 20, 10:07 PM
imp added a comment to D28260: Define PNP info after defining driver modules.

To expand a little: devmatch shouldn't dump core... I don't see how, but I've not seen the core traceback yet...

Wed, Jan 20, 9:02 PM
imp accepted D28260: Define PNP info after defining driver modules.

I agree that something better is needed here...
But unless we change the PNP macros to require driver name and bus name, there's no way to easily detect this at compile time.
At run time, we could emit a warning for this condition... At the time I wrote devmatch, no driver violated this rule, so I never saw the core dump....
This is fine enough for 13.0, though.

Wed, Jan 20, 8:47 PM

Sun, Jan 17

imp accepted D28207: Add COM3 and COM4 to bhyve guests.

Looks good to my eye, but I'd feel better with a nod from one of the main bhyve developers

Sun, Jan 17, 5:50 PM

Fri, Jan 15

imp closed D28168: uart: Improve console specification parsing.
Fri, Jan 15, 12:49 AM
imp committed R10:d1949353e5f5: uart: Improve console specification parsing (authored by imp).
uart: Improve console specification parsing
Fri, Jan 15, 12:49 AM

Thu, Jan 14

imp requested review of D28168: uart: Improve console specification parsing.
Thu, Jan 14, 8:45 PM
imp accepted D28153: loader: Use TERM_EMU for arm and arm64.

Video has had ugly escape sequences in it for too long I think..

Thu, Jan 14, 3:40 PM

Wed, Jan 13

imp accepted D28043: pms: handle maximum size IO with any alignment.
Wed, Jan 13, 10:06 PM

Mon, Jan 11

imp added inline comments to D28095: gitignore: expand list of ignored files.
Mon, Jan 11, 5:53 PM

Sat, Jan 9

imp added inline comments to D28069: tools: git hooks: drop "submitted by" from commit template.
Sat, Jan 9, 8:27 PM
imp added a comment to D28069: tools: git hooks: drop "submitted by" from commit template.

perhaps we should include git commit --author in the template, something like "should be set appropriately, using git commit --author... if someone"?

Sat, Jan 9, 8:19 PM
imp accepted D28058: Build VirtIO modules on all architectures.

In that case, I'm good!

Sat, Jan 9, 8:08 PM
imp committed R10:40e6e2c2f711: sysctl: improve debug.kdb.panic_str description (authored by imp).
sysctl: improve debug.kdb.panic_str description
Sat, Jan 9, 6:12 PM
imp added inline comments to D28060: hid: Fix LINT build.
Sat, Jan 9, 5:44 PM
imp added a comment to D28058: Build VirtIO modules on all architectures.

Does this survive universe? mips has no virtualization support at all, last I checked... A quick peek at virtio suggests that it's entirely platform neutral...

Sat, Jan 9, 5:37 PM

Fri, Jan 8

imp accepted D27878: Track pipe(3) I/O in rusage.

I believe these are good places to add the accounting. They do assume that ANY read or ANY write, even one that also have an error, counts as a message rcv or snd, but I think that's OK.

Fri, Jan 8, 10:20 PM
imp committed R10:936440560bde: sysctl: implement debug.kdb.panic_str (authored by imp).
sysctl: implement debug.kdb.panic_str
Fri, Jan 8, 9:31 PM
imp closed D28041: sysctl: implement debug.kdb.panic_str.
Fri, Jan 8, 9:31 PM
imp updated the diff for D28041: sysctl: implement debug.kdb.panic_str.

fix type

Fri, Jan 8, 9:09 PM
imp accepted D28048: rc.conf(5): describe devmatch rc variables.
Fri, Jan 8, 9:00 PM
imp added inline comments to D28043: pms: handle maximum size IO with any alignment.
Fri, Jan 8, 8:05 PM
imp added inline comments to D28043: pms: handle maximum size IO with any alignment.
Fri, Jan 8, 7:35 PM
imp updated the diff for D28041: sysctl: implement debug.kdb.panic_str.

tweak description

Fri, Jan 8, 5:59 PM
imp updated the diff for D28041: sysctl: implement debug.kdb.panic_str.

remove cut and pasted code that was bogus

Fri, Jan 8, 5:50 PM
imp requested review of D28041: sysctl: implement debug.kdb.panic_str.
Fri, Jan 8, 4:42 PM
imp committed R10:429c7d1ab4c0: pccard: Update UPDATING (authored by imp).
pccard: Update UPDATING
Fri, Jan 8, 3:45 AM
imp committed R10:a21def4d568f: pccard: Remove wi(4) driver (authored by imp).
pccard: Remove wi(4) driver
Fri, Jan 8, 3:45 AM
imp committed R10:23e124c78bcb: pccard: Remove bt3c(4) driver (authored by imp).
pccard: Remove bt3c(4) driver
Fri, Jan 8, 3:45 AM
imp committed R10:0d3a424a89c1: pccard: Remove cmx(4) driver (authored by imp).
pccard: Remove cmx(4) driver
Fri, Jan 8, 3:45 AM
imp committed R10:31cafce9fddd: pccard: Remove ata(4) PC Card attachemnt (authored by imp).
pccard: Remove ata(4) PC Card attachemnt
Fri, Jan 8, 3:45 AM
imp committed R10:ba29d48c7cbc: pccard: Remove uart(4) PC Card attachment (authored by imp).
pccard: Remove uart(4) PC Card attachment
Fri, Jan 8, 3:45 AM
imp committed R10:07263b02d872: pccard: Remove if_ndis(4) PC Card attachment (authored by imp).
pccard: Remove if_ndis(4) PC Card attachment
Fri, Jan 8, 3:45 AM
imp committed R10:135021edfd9c: pccard: Remove puc(4) PC Card attachment (authored by imp).
pccard: Remove puc(4) PC Card attachment
Fri, Jan 8, 3:45 AM
imp committed R10:163b959a73c8: pccard: Remove fdc(4) PC Card attachment point (authored by imp).
pccard: Remove fdc(4) PC Card attachment point
Fri, Jan 8, 3:45 AM
imp committed R10:fbcdcec55b77: pccard: Remove an(4) PC Card attachment (authored by imp).
pccard: Remove an(4) PC Card attachment
Fri, Jan 8, 3:45 AM
imp committed R10:149c9220e63b: pccard: remove pccbb_isa (authored by imp).
pccard: remove pccbb_isa
Fri, Jan 8, 12:08 AM
imp committed R10:cabbfa3e0723: pccard: Move power_if.m from pccard to cardbus (authored by imp).
pccard: Move power_if.m from pccard to cardbus
Fri, Jan 8, 12:08 AM
imp accepted D28031: virtio: Use a common class name between virtio_mmio and virtio_pci.

newbusly it looks good.

Fri, Jan 8, 12:02 AM

Thu, Jan 7

imp accepted D28030: efidev: remove EFIIOC_GET_TABLE ioctl.
Thu, Jan 7, 11:47 PM
imp accepted D28023: isci: use maxphys rather than 128KB to size s/g list.
Thu, Jan 7, 4:39 PM

Wed, Jan 6

imp accepted D28008: vfs: fix rangelock range in vn_rdwr() for IO_APPEND.
Wed, Jan 6, 9:44 PM

Mon, Jan 4

imp accepted D27963: mpr, mps: Fix a stack buffer overflow in the user passthru ioctl.

These look good to my eye.

Mon, Jan 4, 11:50 PM

Sun, Jan 3

imp accepted D27566: g_provider_by_name(9): argument can be a geom name or fullpath.
Sun, Jan 3, 8:08 PM

Sat, Jan 2

imp accepted D27878: Track pipe(3) I/O in rusage.
Sat, Jan 2, 12:26 AM

Wed, Dec 30

imp accepted D27853: cam: Remove Giant handling from cam_sim_alloc().
Wed, Dec 30, 11:16 PM

Tue, Dec 29

imp added a comment to D27782: uefi.8: mention boot1.efi.
In D27782#621399, @imp wrote:

Also, boot1.efi is obsolete. We retain it only for special needs users: those with the bogus tiny ESP partitions and some really weird edge cases that loader.efi doesn't work for.

I have Ubuntu 20.10 and FreeBSD -current installed on my thinkpad laptop.
Linux's Grub2 is unable to boot FreeBSD directly from UEFI, I have to copy
the FreeBSD UEFI loader (/boot/boot.efi) into EFI partition.

Tue, Dec 29, 1:46 AM

Mon, Dec 28

imp added a comment to D27782: uefi.8: mention boot1.efi.

Also, boot1.efi is obsolete. We retain it only for special needs users: those with the bogus tiny ESP partitions and some really weird edge cases that loader.efi doesn't work for.

Mon, Dec 28, 3:56 PM

Dec 25 2020

imp added a comment to D27751: Fix newvers.sh to no longer print an outdated SVN rev.

This looks good. If it is checked out of subversion on -stable, then we'll get the right uname, so it can likely be MFC'd... We're not writing new svn revs to git, but there may be something I'm missing.

Dec 25 2020, 8:10 AM

Dec 19 2020

imp added a comment to D25358: Sync vis(1) with recent NetBSD sources.
In D25358#618886, @gbe wrote:
In D25358#618885, @imp wrote:
In D25358#618884, @gbe wrote:

@emaste any change that this can be committed before the switch to git?

Nope. It will have to wait. Your reward for eating, though, is that I'd be happy to do the import to test the process for real once things open again.

OK, even if I don't understand the phrase "your reward for eating", since I am not a native speaker. ;)

Dec 19 2020, 4:57 PM
imp added a comment to D25358: Sync vis(1) with recent NetBSD sources.
In D25358#618884, @gbe wrote:

@emaste any change that this can be committed before the switch to git?

Dec 19 2020, 4:52 PM

Dec 18 2020

imp accepted D27669: efirt: enter runtime environment to deref efi_cfgtbl.

This looks like it would fix things, but I wonder why this is even here... If we keep it, this change prevents a crash... Though I can't for the life of me think about the purpose this serves... It went in with a bunch of efi env var support.

Dec 18 2020, 4:25 PM

Dec 17 2020

imp accepted D27633: Initial version of git commit message preparation hook.

looks good, with spaces I'm happy.

Dec 17 2020, 7:08 PM
imp committed rS368721: Drop EFI_STAGING_SIZE back down to 64M.
Drop EFI_STAGING_SIZE back down to 64M
Dec 17 2020, 5:02 PM
imp committed R9:a9729ccf8868: Add news entry for the conversion of the src repository to Git. The (authored by imp).
Add news entry for the conversion of the src repository to Git. The
Dec 17 2020, 3:44 PM

Dec 16 2020

imp accepted D27646: newvers.sh: Speed up git_tree_modified.
Dec 16 2020, 9:25 PM
imp committed R9:1ce17f83bdf7: Add news that FreeBSD-doc switched over to git. (authored by imp).
Add news that FreeBSD-doc switched over to git.
Dec 16 2020, 9:07 PM
imp accepted D27641: bsdinstall: remove VTOC8 partition scheme option.
Dec 16 2020, 8:13 PM

Dec 14 2020

imp added a comment to D27608: [contrib/bc] Only use fallthrough on GCC's that support it.

Can you get this accepted upstream?

Dec 14 2020, 7:24 PM
imp added a comment to D27517: nvmecontrol: add device self-test op and log page.
In D27517#615211, @mav wrote:

We also have several 128-bit capacity values represented as arrays of bytes.

Dec 14 2020, 7:14 PM
imp accepted D27517: nvmecontrol: add device self-test op and log page.
Dec 14 2020, 7:12 PM
imp accepted D27603: loader: Ignore the .interp section on RISC-V.
Dec 14 2020, 12:09 AM

Dec 13 2020

imp added a comment to D27599: Fix all warnings emitted in `make kernel-toolchain`.

everything but the tools/build/Makefile changes are good. I'm not at all sure that I understand those... This file has become a rather twisty maze, so I've not puzzled all the way through understanding...

Dec 13 2020, 9:44 PM
imp added a comment to D27598: Stop passing MK_WARNS=no for bootstrap tools.

Separate commit is fine

Dec 13 2020, 9:15 PM
imp committed R9:125b4a08c65d: Add my PGP key, as requested. (authored by imp).
Add my PGP key, as requested.
Dec 13 2020, 8:09 PM
imp committed R9:e45caebf62ed: Cut and paste my ELF explaination from my -current post a few days (authored by imp).
Cut and paste my ELF explaination from my -current post a few days
Dec 13 2020, 8:01 PM
imp committed R9:89314826cba6: When creating swap file, set permission bits to ensure its safety. (authored by imp).
When creating swap file, set permission bits to ensure its safety.
Dec 13 2020, 7:57 PM
imp committed R9:1eee3e63b345: Add pointers to recent security advisories (authored by imp).
Add pointers to recent security advisories
Dec 13 2020, 7:52 PM
imp committed R9:5a833061e0fd: Add the latest security advisories. Also update the list of supported (authored by imp).
Add the latest security advisories. Also update the list of supported
Dec 13 2020, 7:48 PM
imp committed R9:720cc4b7b6e3: Document FreeBSD_version 430000, 430001, 430002: (authored by imp).
Document FreeBSD_version 430000, 430001, 430002:
Dec 13 2020, 7:34 PM
imp committed R9:3c214b23cab5: Document bump to 500023 for KSE milestone 2. (authored by imp).
Document bump to 500023 for KSE milestone 2.
Dec 13 2020, 7:31 PM
imp committed R9:34941bca09ab: Add new entry for d_thread_t/500024. Hope I did it right (authored by imp).
Add new entry for d_thread_t/500024. Hope I did it right
Dec 13 2020, 7:31 PM
imp committed R9:d8e47ccdae31: Document 440001: d_thread_t introduced (authored by imp).
Document 440001: d_thread_t introduced
Dec 13 2020, 7:30 PM
imp committed R9:c2c5801a7bf2: Correct typo d_threat_t -> d_thread_t (authored by imp).
Correct typo d_threat_t -> d_thread_t
Dec 13 2020, 7:30 PM
imp committed R9:410436975d07: Add a core opinion on the effect of early elections on next election. (authored by imp).
Add a core opinion on the effect of early elections on next election.
Dec 13 2020, 7:23 PM
imp committed R9:ffeefaae81c9: Update the rules on commit bit suspention to reflect the current (authored by imp).
Update the rules on commit bit suspention to reflect the current
Dec 13 2020, 7:22 PM
imp committed R9:5dc1ae8669fb: Give a better bus address example than 0x23c, since most ISA devices (authored by imp).
Give a better bus address example than 0x23c, since most ISA devices
Dec 13 2020, 7:18 PM
imp committed R9:243ed2c67d31: Update the date of the last core election (it started in May 2002), (authored by imp).
Update the date of the last core election (it started in May 2002),
Dec 13 2020, 7:15 PM
imp committed R9:0bc9e3f43fa5: Document 460100 (belatedly), 470100 and 470101. The last of these is the (authored by imp).
Document 460100 (belatedly), 470100 and 470101. The last of these is the
Dec 13 2020, 7:15 PM
imp committed R9:ba68ff2173d3: Add my desire for a multi-port serial card. Too many machines in the (authored by imp).
Add my desire for a multi-port serial card. Too many machines in the
Dec 13 2020, 7:12 PM
imp committed R9:b7bc4630007d: wicontrol -p 6 is bogus and not needed (and will not be supported in (authored by imp).
wicontrol -p 6 is bogus and not needed (and will not be supported in
Dec 13 2020, 7:11 PM
imp committed R9:db8a3fbe8777: Move the speed (-t 3) option into the ifconfig line. Remove the ssid (authored by imp).
Move the speed (-t 3) option into the ifconfig line. Remove the ssid
Dec 13 2020, 7:11 PM
imp committed R9:55abf211cedb: Ooops, delete the paragraph that described the wicontrol that I just deleted. (authored by imp).
Ooops, delete the paragraph that described the wicontrol that I just deleted.
Dec 13 2020, 7:11 PM
imp committed R9:77581b892cd6: Prism 3 is also supported in hostap mode. (authored by imp).
Prism 3 is also supported in hostap mode.
Dec 13 2020, 7:11 PM
imp committed R9:66b6052b33d0: Missed a spot where meidaopt as used w/o a media. (authored by imp).
Missed a spot where meidaopt as used w/o a media.
Dec 13 2020, 7:11 PM
imp committed R9:cbbbe65b731c: Greatly expand the information here. Unbreak the build (stray " crept (authored by imp).
Greatly expand the information here. Unbreak the build (stray " crept
Dec 13 2020, 7:11 PM
imp committed R9:eed194a269f3: I need an o2 mciro cardbus laptop (authored by imp).
I need an o2 mciro cardbus laptop
Dec 13 2020, 7:10 PM
imp committed R9:fcc29f4c9418: The EISA system has arrived. (authored by imp).
The EISA system has arrived.
Dec 13 2020, 7:09 PM
imp committed R9:143fe4e865c1: Move the folks whose commit bits have been retired to the almni (authored by imp).
Move the folks whose commit bits have been retired to the almni
Dec 13 2020, 7:08 PM
imp committed R9:6891feb81d48: Three content changes: (authored by imp).
Three content changes:
Dec 13 2020, 7:02 PM
imp committed R9:301b3e945b11: document, in some detail with explainations and assides, how to add a (authored by imp).
document, in some detail with explainations and assides, how to add a
Dec 13 2020, 7:02 PM
imp committed R9:e13f102cbb74: Update date on Newbus locking (authored by imp).
Update date on Newbus locking
Dec 13 2020, 7:02 PM
imp committed R9:d5b0c34a4c6f: Change a 'be' to 'may' so that a sentence makes sense. Point at the (authored by imp).
Change a 'be' to 'may' so that a sentence makes sense. Point at the
Dec 13 2020, 6:54 PM
imp committed R9:a30ef3ecabf1: Although 'Unanimous Consent' appears to be a well defined and used in (authored by imp).
Although 'Unanimous Consent' appears to be a well defined and used in
Dec 13 2020, 6:54 PM