Page MenuHomeFreeBSD

imp (Warner Losh)
User

Projects

User Details

User Since
Jun 2 2014, 4:20 PM (287 w, 4 d)

Recent Activity

Yesterday

imp added a comment to D22710: Update owc_gpiobus (one-wire over gpio) to the modern gpio_pin interface..

I'll take a look at this and make sure my setup still work w/minimum of hassle.

Fri, Dec 6, 10:36 PM
imp committed rS355465: trackers always know what qpair they are on.
trackers always know what qpair they are on
Fri, Dec 6, 10:12 PM
imp committed rS355464: Remove ifdefs for FreeBSD 6, 7, 8 and 9. Assume we're past that..
Remove ifdefs for FreeBSD 6, 7, 8 and 9. Assume we're past that.
Fri, Dec 6, 9:50 PM
imp closed D22539: Remove ifdefs for FreeBSD 6, 7, 8 and 9. Assume we're past that..
Fri, Dec 6, 9:50 PM
imp added a comment to D22598: Use callout(9) instead of deprecated timeout(9)..
In D22598#494456, @imp wrote:
In D22598#494383, @jhb wrote:

@sbruno Do you have a PoC for this driver?

IIRC, it was from HP. But I'm not sure how well PQI with SOP has been accepted in the marketplace...

Well, we seem to be selling lots of cards. :) I'll have the developers update our code base and test out these changes.

Fri, Dec 6, 6:42 PM
imp accepted D22322: Conduct/reporting split.

Sorry for the delay... this looks good to me.

Fri, Dec 6, 5:32 PM

Wed, Dec 4

imp accepted D22676: [New Port] devel/R-cran-bigmemory.sri: A shared resource interface for Bigmemory Project packages.

assuming it passed portlint and this was part of a poudriere build, it looks ready.

Wed, Dec 4, 6:51 PM
imp accepted D22675: [New Port] math/R-cran-alabama: Constrained Nonlinear Optimization.

assuming it passed portlint and this was part of a poudriere build, it looks ready.

Wed, Dec 4, 6:51 PM
imp accepted D22673: [New Port] math/R-cran-ADGofTest: Anderson-Darling GoF test.

assuming it passed portlint and this was part of a poudriere build, it looks ready.

Wed, Dec 4, 6:50 PM
imp accepted D22667: [New Port] math/R-cran-acepack: ACE and AVAS for selecting multiple regression transformations.

assuming it passed portlint and this was part of a poudriere build, it looks ready.

Wed, Dec 4, 6:50 PM
imp added a comment to D22676: [New Port] devel/R-cran-bigmemory.sri: A shared resource interface for Bigmemory Project packages.

This looks generally good to me, modulo my one comment. I assume that it also passes portlint since I didn't do that myself.

Wed, Dec 4, 5:17 PM
imp committed rS355394: Regularize my copyright notice.
Regularize my copyright notice
Wed, Dec 4, 4:56 PM
imp committed rS355393: Fix accidentally changed copyright year..
Fix accidentally changed copyright year.
Wed, Dec 4, 4:56 PM
imp accepted D22664: vfs: eliminate v_iflag read from vn_lock.

Nice catch

Wed, Dec 4, 4:47 AM

Tue, Dec 3

imp accepted D22660: Define __SOFT_FP__ for riscv64sf to avoid infinite recursion..
In D22660#495654, @jhb wrote:

Probably this should be on for all soft-float architectures. I'd rather pull in Makefile.float from https://github.com/freebsd/freebsd/commit/eb836f75fe342c01a51bba1c96abacd448fabc88 and use that to set this rather than add all the combinatorics though. This has also only been observed on riscv to date.

Tue, Dec 3, 11:38 PM
imp added inline comments to D22537: Add support for generating release images using GPT for ARM.
Tue, Dec 3, 6:59 PM
imp committed rS355330: Regularize copyright notices for me..
Regularize copyright notices for me.
Tue, Dec 3, 3:48 PM

Mon, Dec 2

imp added a comment to D22625: Handle multiple clock ticks in sched_clock().

Looks same to me. The only macro difference is dropping the idle thread check. Is that intended? Is so, is it safe?

Mon, Dec 2, 6:21 AM
imp accepted D22627: sysutils/ssd_report: Update ssd_report from version 0.2 to 0.4.
Mon, Dec 2, 6:08 AM
imp accepted D22629: sysutils/cmocka: Update cmocka from version 1.1.3 to 1.1.5.
Mon, Dec 2, 6:08 AM
imp accepted D22627: sysutils/ssd_report: Update ssd_report from version 0.2 to 0.4.
Mon, Dec 2, 3:14 AM

Sun, Dec 1

imp added inline comments to D15818: Add a delayed VT attachment for ofwfb.
Sun, Dec 1, 9:49 PM

Sat, Nov 30

imp accepted D22538: Add PINE64 ROCKPro64 config for generation of release images.
Sat, Nov 30, 10:14 PM
imp added inline comments to D22537: Add support for generating release images using GPT for ARM.
Sat, Nov 30, 10:13 PM
imp added a comment to D22598: Use callout(9) instead of deprecated timeout(9)..
In D22598#494383, @jhb wrote:

@sbruno Do you have a PoC for this driver?

Sat, Nov 30, 2:45 AM

Fri, Nov 29

imp added inline comments to D15955: Discover cards on boot.
Fri, Nov 29, 6:48 AM
imp accepted D22598: Use callout(9) instead of deprecated timeout(9)..
Fri, Nov 29, 1:51 AM

Thu, Nov 28

imp accepted D22600: Pass 0 to __builtin_frame_address() to appease modern GCC..
Thu, Nov 28, 8:44 PM
imp committed rS355168: Also turn of teken for RB_MULTIPLE.
Also turn of teken for RB_MULTIPLE
Thu, Nov 28, 5:40 AM
imp committed rS355167: Remove comment. We're just going to the next node here..
Remove comment. We're just going to the next node here.
Thu, Nov 28, 5:40 AM
imp added inline comments to D22587: Add a lockless lookup mechanism that uses a SMR zone..
Thu, Nov 28, 1:54 AM

Wed, Nov 27

imp added a comment to D22575: Remove the trm driver.

I'll look at this more, but I think you need obsolete files updates.

Wed, Nov 27, 8:40 PM
imp added a comment to D22573: Fix a logic bug when "mask: contains a ?: operator..

I would have been tempted to put parents around all macro args while l was at it...

Wed, Nov 27, 8:38 PM
imp accepted D22569: Add support to allocate more space before and after a current allocation.

Not seeing any holes here

Wed, Nov 27, 3:54 PM

Tue, Nov 26

imp accepted D15955: Discover cards on boot.

Other than printing a warning here to help debugging should the alloc fail, I think this is good.

Tue, Nov 26, 10:04 PM
imp accepted D22560: stop building arm LINT-V5 kernel.
Tue, Nov 26, 8:42 PM

Mon, Nov 25

imp accepted D22330: Capitalize usage message and some user visible output.

Looks good to me

Mon, Nov 25, 11:27 PM

Sun, Nov 24

imp updated the test plan for D22539: Remove ifdefs for FreeBSD 6, 7, 8 and 9. Assume we're past that..
Sun, Nov 24, 3:48 PM
imp created D22539: Remove ifdefs for FreeBSD 6, 7, 8 and 9. Assume we're past that..
Sun, Nov 24, 3:47 PM
imp committed rS355058: Don't need giant for these drivers dev nodes..
Don't need giant for these drivers dev nodes.
Sun, Nov 24, 3:37 PM
imp committed rS355057: Hoist locking giant back up into the ioctl handler.
Hoist locking giant back up into the ioctl handler
Sun, Nov 24, 3:37 PM
imp committed rS355056: Fix leak in state machine for commands..
Fix leak in state machine for commands.
Sun, Nov 24, 3:24 PM
imp accepted D22529: bsd-family-tree: add several new entries.
Sun, Nov 24, 7:37 AM

Sat, Nov 23

imp committed rS355039: Add a warning about Giant Locked devices.
Add a warning about Giant Locked devices
Sat, Nov 23, 11:57 PM
imp committed rS355037: Push Giant down one layer.
Push Giant down one layer
Sat, Nov 23, 11:44 PM
imp committed rS355038: We don't even need Giant here. It isn't protecting anything internal.
We don't even need Giant here. It isn't protecting anything internal
Sat, Nov 23, 11:44 PM
imp accepted D22525: [PowerPC] Fix typo in _ctx_start on ppc32.
Sat, Nov 23, 11:17 PM · PowerPC
imp accepted D22514: amd64: assert that EARLY_COUNTER does not corrupt memory.
Sat, Nov 23, 4:05 PM
imp accepted D22513: Linux epoll: Don't deregister file descriptor after EPOLLONESHOT is fired.
Sat, Nov 23, 4:04 PM

Fri, Nov 22

imp accepted D22500: stand: liblua: drop default buffer size to 128.
Fri, Nov 22, 11:37 PM

Thu, Nov 21

imp accepted D22474: Add option to run rpc.{lockd,statd} in the foreground..

Looks good to me. Other commands use different flags to run in foreground, though. IT's inconsistent...

Thu, Nov 21, 11:28 PM
imp committed rS354976: Install bsd.sysdir.mk..
Install bsd.sysdir.mk.
Thu, Nov 21, 7:54 PM
imp committed rS354972: Remove two obsolete comments that reference splhigh/splx..
Remove two obsolete comments that reference splhigh/splx.
Thu, Nov 21, 6:50 PM
imp accepted D22118: Add a kmod.opts.mk..

Thanks for your patience with me for delays in my end.
Looks good and I think we're good to go.

Thu, Nov 21, 5:45 PM
imp committed rS354968: Introduce bsd.sysdir.mk to consolidate looking for the kernel..
Introduce bsd.sysdir.mk to consolidate looking for the kernel.
Thu, Nov 21, 3:59 PM
imp closed D22144: Introduce bsd.sysdir.mk to consolidate looking for the kernel..
Thu, Nov 21, 3:59 PM
imp added a comment to D22144: Introduce bsd.sysdir.mk to consolidate looking for the kernel..

Running a final make universe before committing.
Should be in tomorrow morning if nothing breaks.

Thu, Nov 21, 6:54 AM
imp committed rS354937: Include MACHINE in the which variable selection to use section..
Include MACHINE in the which variable selection to use section.
Thu, Nov 21, 6:48 AM
imp committed rS354936: Add table for MACHINE_CPUARCH.
Add table for MACHINE_CPUARCH
Thu, Nov 21, 6:44 AM

Wed, Nov 20

imp committed rS354925: Add --esp/-E argument to print the currently booted ESP.
Add --esp/-E argument to print the currently booted ESP
Wed, Nov 20, 11:58 PM
imp closed D22432: Add --esp/-E argument to print the currently booted ESP.
Wed, Nov 20, 11:58 PM
imp committed rS354922: Create /etc/os-release file..
Create /etc/os-release file.
Wed, Nov 20, 11:45 PM
imp closed D22271: Create /etc/os-release file..
Wed, Nov 20, 11:45 PM
imp committed rS354915: Standardize EFI's ESP mount point..
Standardize EFI's ESP mount point.
Wed, Nov 20, 9:06 PM
imp closed D21344: Standardize EFI's ESP mount point..
Wed, Nov 20, 9:06 PM
imp accepted D22464: Makefile.inc1: push /usr/libexec into the BPATH/TMPPATH .

LGTM

Wed, Nov 20, 7:42 PM
imp accepted D22446: Allow boostrapping xinstall on Linux.
Wed, Nov 20, 4:18 PM
imp added inline comments to D22446: Allow boostrapping xinstall on Linux.
Wed, Nov 20, 4:18 PM
imp accepted D22451: Use per-architecture packing list files for architecture-specific files..

This looks better to my eye.

Wed, Nov 20, 12:02 AM

Tue, Nov 19

imp accepted D22448: Make the warning for deprecated NO_ variables an error..

Go for it!

Tue, Nov 19, 11:52 PM
imp accepted D22267: Make sure the 'struct tcp_info' is stable.

If we are nailing this struct down, this does that.

Tue, Nov 19, 3:38 PM

Mon, Nov 18

imp accepted D21893: Add flua to the base system, install to /usr/libexec.
Mon, Nov 18, 8:42 PM
imp added inline comments to D21893: Add flua to the base system, install to /usr/libexec.
Mon, Nov 18, 5:54 PM

Sun, Nov 17

imp created D22432: Add --esp/-E argument to print the currently booted ESP.
Sun, Nov 17, 4:35 PM
imp added inline comments to D22425: libclang_rt: enable on powerpc*.
Sun, Nov 17, 2:58 AM

Sat, Nov 16

imp accepted D22383: Actually hook CAM_IO_STATS up to the build.

Looks good. Must have missed these bits when we upstreamed it.

Sat, Nov 16, 6:57 PM
imp added a comment to D21893: Add flua to the base system, install to /usr/libexec.

If you moved lfs.[ch] to libexec/flua/modules, then a simple -I addition to CFLAGS and a .PATH would get the job done.

Sat, Nov 16, 4:38 AM
imp accepted D21893: Add flua to the base system, install to /usr/libexec.

I don't like the lfs.h sharing detail, but it's fine enough we can work out after commit.

Sat, Nov 16, 2:19 AM

Fri, Nov 15

imp accepted D22374: TSX Asynchronous Abort Mitigation.

I'm cool with the sysctl/tunable naming.. Don't know about TAA enough to comment on the rest :)

Fri, Nov 15, 11:35 PM
imp added inline comments to D22358: NTPD Circumvent ASLR.
Fri, Nov 15, 4:33 AM
imp added inline comments to D22358: NTPD Circumvent ASLR.
Fri, Nov 15, 4:21 AM
imp accepted D22147: Add freebsd-gcc6 port..
Fri, Nov 15, 12:23 AM
imp added a comment to D22147: Add freebsd-gcc6 port..

I think this is ready to go as is. PLIST cleanups can wait IMO.

Fri, Nov 15, 12:23 AM

Thu, Nov 14

imp added inline comments to D22360: initial linker support userland-DTrace aarch64.
Thu, Nov 14, 6:53 AM
imp accepted D22358: NTPD Circumvent ASLR.

Seems sane to me, but I'd feel better about getting it committed if others more deeply familiar with the aslr stuff give it their blessing.

Thu, Nov 14, 3:20 AM
imp committed rS354700: armv6 soft float build fixed.
armv6 soft float build fixed
Thu, Nov 14, 1:39 AM

Wed, Nov 13

imp accepted D22352: armv6-soft build fixed.

This looks like a simple bug fix to me, so I'm inclined to let it in.

Wed, Nov 13, 9:46 PM
imp accepted D22350: Refine r354661 to unbreak the GCC_BOOTSTRAP case..
Wed, Nov 13, 8:20 PM
imp accepted D22337: Allow per-file lex and yacc options..

I love it now.

Wed, Nov 13, 2:21 AM
imp committed rS354668: Fix a race between daopen and damediapoll.
Fix a race between daopen and damediapoll
Wed, Nov 13, 1:59 AM

Tue, Nov 12

imp added inline comments to D22337: Allow per-file lex and yacc options..
Tue, Nov 12, 11:25 PM
imp added inline comments to D22337: Allow per-file lex and yacc options..
Tue, Nov 12, 11:15 PM
imp added a comment to D22332: Force MK_CLANG_IS_CC on in XMAKE..

Hmmm, does this break native builds for gcc?

Tue, Nov 12, 5:41 PM
imp accepted D22332: Force MK_CLANG_IS_CC on in XMAKE..
Tue, Nov 12, 5:40 PM

Mon, Nov 11

imp committed rS354623: Add asserts for some state transitions.
Add asserts for some state transitions
Mon, Nov 11, 5:37 PM
imp committed rS354622: Update the softc state of the da driver before releasing the CCB..
Update the softc state of the da driver before releasing the CCB.
Mon, Nov 11, 5:37 PM
imp committed rS354621: Require and enforce that dareprobe() has to be called with the periph lock held..
Require and enforce that dareprobe() has to be called with the periph lock held.
Mon, Nov 11, 5:37 PM
imp committed rS354620: Fix panic message to indicate right action that was improper..
Fix panic message to indicate right action that was improper.
Mon, Nov 11, 5:37 PM
imp closed D22295: Fix panic message to indicate right action that was improper..
Mon, Nov 11, 5:37 PM
imp added a comment to D22295: Fix panic message to indicate right action that was improper..

I think what we're seeing is that we're running this with the queue unfrozen. This sometimes leads to the race I found because, I think, we run things twice: once in the ccb release path, and then again in the schedule path. The freezes and single stepping has always confused me. Part of the confusion is why we only see this sometimes... How does that come to be...

Mon, Nov 11, 5:22 AM