Page MenuHomeFreeBSD

imp (Warner Losh)
User

Projects

User Details

User Since
Jun 2 2014, 4:20 PM (385 w, 2 d)

Recent Activity

Today

imp accepted D32582: service(8): Fix typo in man page.
Wed, Oct 20, 4:47 PM · manpages
imp added a comment to D32579: Fix intra-object buffer overread for labeled msdosfs volumes.

Presumably the transform isn't hard to write for someone who knows coccinelle, but the issue is knowing whether a string is from a trusted source or not (in the sense that we can trust it to have a NUL byte; strlcpy is safe if you know there's a NUL in the object but just cannot guarantee a bound on its length). For that you'd presumably need taint tracking via annotations on every data structure.

Wed, Oct 20, 4:45 PM
imp accepted D32578: sys/bus.h: silence warnings about write-only variables.
Wed, Oct 20, 4:42 PM
imp accepted D32577: ufs, msdosfs, tmpfs: remove write-only variables.
Wed, Oct 20, 4:40 PM
imp added inline comments to D32570: freebsd-update: efficiently handle no updates in fetch.
Wed, Oct 20, 4:28 PM
imp added a reviewer for D32570: freebsd-update: efficiently handle no updates in fetch: cperciva.
Wed, Oct 20, 4:19 PM
imp accepted D32579: Fix intra-object buffer overread for labeled msdosfs volumes.
Wed, Oct 20, 3:31 PM
imp added a comment to D32579: Fix intra-object buffer overread for labeled msdosfs volumes.

I like it. Is there a coccinelle script we can run on the whole tree?

Wed, Oct 20, 3:31 PM
imp added inline comments to D32485: Porter's handbook: Mention git-format-patch(1) in using git to make patches.
Wed, Oct 20, 3:08 PM

Yesterday

imp accepted D32567: ada: Fix intra-object buffer overread of identify strings.
Tue, Oct 19, 8:25 PM
imp accepted D32562: sysctl.3: sys/types.h no longer needs to be explicitly included.

nice catch.

Tue, Oct 19, 4:38 PM

Mon, Oct 18

imp accepted D32227: loader: net_open() should not replace f->f_devdata.
Mon, Oct 18, 9:40 PM
imp committed R10:7881db834647: Remove POWER_PM_TYPE_APM. It's now unused. (authored by imp).
Remove POWER_PM_TYPE_APM. It's now unused.
Mon, Oct 18, 2:45 PM
imp closed D32549: Remove POWER_PM_TYPE_APM. It's now unused..
Mon, Oct 18, 2:45 PM
imp updated the test plan for D32549: Remove POWER_PM_TYPE_APM. It's now unused..
Mon, Oct 18, 2:25 PM
imp requested review of D32549: Remove POWER_PM_TYPE_APM. It's now unused..
Mon, Oct 18, 2:24 PM
imp accepted D32546: Pass the ACPI ID when reading the ACPI domain.

Looks good to me. Any other places we make this mistake?

Mon, Oct 18, 2:14 PM
imp accepted D32543: vt: Disable bell by default.
Mon, Oct 18, 2:05 PM
imp added a comment to D32504: kern/intr: remove "irq" from kernel event API.

I'm removing mips in a few weeks. If there is a hassle due to mips, it won't be a hassle for long. Unless I've misread this, I don't see this change being MFCd.

Mon, Oct 18, 4:35 AM
imp accepted D32542: Fix cross-building on Linux/aarch64.

I have other comments on the makefile since it seems to confuse machine and machine_arch in the terminology. But that's beyond the scope of this change...

Mon, Oct 18, 3:02 AM

Sun, Oct 17

imp added inline comments to D32538: ipq4018: add initial IPQ4018/IPQ4019 support.
Sun, Oct 17, 8:17 PM
imp added inline comments to D32538: ipq4018: add initial IPQ4018/IPQ4019 support.
Sun, Oct 17, 7:37 PM
imp added inline comments to D32538: ipq4018: add initial IPQ4018/IPQ4019 support.
Sun, Oct 17, 5:51 PM
imp added a comment to D32538: ipq4018: add initial IPQ4018/IPQ4019 support.

Removed core from reviewer. This tripped over the GPL check in herald for SPDX lines, but the OR MIT means it's fine and doesn't require approval (which is why I removed core blocking rather than approved it with my core hat on).

Sun, Oct 17, 5:35 PM
imp removed a reviewer for D32538: ipq4018: add initial IPQ4018/IPQ4019 support: Core Team.
Sun, Oct 17, 5:33 PM
imp added inline comments to D32446: LinuxKPI: Implement _ioremap_attr for riscv.
Sun, Oct 17, 3:44 PM
imp accepted D32534: bhyve: Bump the SMBIOS firmware version to 14.0 for 14-CURRENT.
Sun, Oct 17, 3:18 PM

Sat, Oct 16

imp added a comment to D32512: x86: Implement deferred TSC calibration.

Rather than having a callback after 1 second, can you leave the final synchronization happening in the SYSINIT? I realize this will slow things down (by preventing anything else from happening during that 1 second interval) but I will be able to speed up the calibration dramatically via repeated measurements.

Sure, I can do this, and that would side-step some of the discussion above. Can you explain your approach in more detail (or provide a pointer to a patch)?

Conceptually: rather than plotting two points on a graph, drawing a line between them, and calculating the slope, I was plotting a few thousand points on a graph and drawing the best-fit line through them. How long it takes will depend on how fast the underlying timer is but I was getting < 1 ppm accuracy in ~10 ms..

Sat, Oct 16, 7:11 PM

Fri, Oct 15

imp added inline comments to D32512: x86: Implement deferred TSC calibration.
Fri, Oct 15, 9:19 PM
imp added a comment to D32512: x86: Implement deferred TSC calibration.
In D32512#733514, @imp wrote:
In D32512#733493, @imp wrote:

What's the frequency error you see in early boot?

From the PIT loop you mean? I can't remember offhand but the value was clearly wrong. I'll recheck later today.

For either that or the CPUID leaf values. During early boot, the frequency error can be large (even a few percent, as much as maybe 10% would be fine for device initialization, etc), but once we start 'timekeeping' for real, it needs to be < 100-200ppm and ideally < 10-20ppm (though at this level of accuracy, thermal effects start to introduce a fair amount of noise).

This was mentioned in the review description, though admittedly it is too verbose, sorry: I get 1600MHz from CPUID and ~1608MHz from late calibration (and ntpd reports an error of 5-20ppm with the latter). I suspect 1600MHz is good enough for early boot, indeed.

Fri, Oct 15, 9:09 PM
imp added a comment to D32512: x86: Implement deferred TSC calibration.
In D32512#733493, @imp wrote:

What's the frequency error you see in early boot?

From the PIT loop you mean? I can't remember offhand but the value was clearly wrong. I'll recheck later today.

Fri, Oct 15, 8:58 PM
imp added a comment to D32512: x86: Implement deferred TSC calibration.

Also, Colin has code in this area as well, might want to add him as a reviewer.

Fri, Oct 15, 8:22 PM
imp added a comment to D32512: x86: Implement deferred TSC calibration.

What's the frequency error you see in early boot?

Fri, Oct 15, 8:21 PM
imp accepted D32510: x86: Remove some leftover APM support.

Don't know how I missed this in my sweep! Good catch!

Fri, Oct 15, 8:10 PM
imp accepted D32511: timecounter: Lock the timecounter list.
Fri, Oct 15, 8:10 PM
imp added a comment to D32505: Add rseq(2).

Do we need a man page for this?

Fri, Oct 15, 7:16 PM
imp added inline comments to D32498: Test various header files to ensure they can be included by themselves..
Fri, Oct 15, 6:05 PM
imp updated the diff for D32498: Test various header files to ensure they can be included by themselves..

.PHONY fix

Fri, Oct 15, 5:20 PM
imp updated the diff for D32498: Test various header files to ensure they can be included by themselves..

Move to opt-out rather than opt-in list.

Fri, Oct 15, 5:15 PM
imp updated the diff for D32498: Test various header files to ensure they can be included by themselves..

Add net*/*.h too
We're at ~250/650 being stand alone in these directories.

Fri, Oct 15, 4:19 PM
imp added a comment to D32498: Test various header files to ensure they can be included by themselves..

Note:

Fri, Oct 15, 3:52 PM
imp updated the diff for D32498: Test various header files to ensure they can be included by themselves..

hack for phab

Fri, Oct 15, 3:51 PM
imp updated the diff for D32498: Test various header files to ensure they can be included by themselves..

this time with goodfiles.inc <sigh>

Fri, Oct 15, 3:50 PM
imp updated the summary of D32498: Test various header files to ensure they can be included by themselves..
Fri, Oct 15, 3:49 PM
imp updated the diff for D32498: Test various header files to ensure they can be included by themselves..

updates based on suggestions so far: move to a goodfiles list that's updated by
a makefile target. This makes maintaining the list trivial and so long as we run
the target only when hdrtest is buildable, the list will only ever increase in
size (absent those rare cases we remove files from /usr/include).

Fri, Oct 15, 3:47 PM
imp added a comment to D32498: Test various header files to ensure they can be included by themselves..

I'm thinking .include with a target to regenerate the file... the list would keep things working. Regenerating when you fix something would be easy and thus the list would only grow. No need for marking or filtering.

Fri, Oct 15, 5:34 AM
imp updated the diff for D32498: Test various header files to ensure they can be included by themselves..

Better comment... Will harmonize it and the commit message.

Fri, Oct 15, 4:26 AM
imp updated the diff for D32498: Test various header files to ensure they can be included by themselves..

Pull in most of brooks' suggested changes
Also augment it a little with cleaning the generated files
Still not sure how the target ${.OBJDIR}/sys gets created, but special code to
create it seems unnecessary.

Fri, Oct 15, 4:17 AM
imp added a comment to D32498: Test various header files to ensure they can be included by themselves..

Thinking about @markj's idea, a BADHDRS variable to filter out headers from a generated list wouldn't be hard to maintain.

Fri, Oct 15, 4:16 AM

Thu, Oct 14

imp closed D32259: nvme: Use adaptive spinning when polling for completion or state change.

83581511d9476ef5084f47e3cc379be7191ae866 should have closed this.

Thu, Oct 14, 7:43 PM
imp added a comment to D32498: Test various header files to ensure they can be included by themselves..

I know this isn't actually part of buildworld
And I'd be keen on knowing whether or not an extra file with all the header files would be a good idea
As well as creating an actual dummy program that might make this a little easier.

So as developers add new headers, we want to ensure that they don't have external dependencies. With the scheme in the proposed diff, they have to manually add their header to this file. I think a script (or makefile I guess) which tests every single header that we install and compares failures against a known-bad list would require the least maintenance. I'm not quite sure what an "extra file with all of the header files" would be for - can't the makefile do something like "HDRS!=find <directories> -name \*.h" and test each one? Or is that too hacky?

Thu, Oct 14, 7:02 PM
imp added inline comments to D32498: Test various header files to ensure they can be included by themselves..
Thu, Oct 14, 5:43 PM
imp updated the test plan for D32498: Test various header files to ensure they can be included by themselves..
Thu, Oct 14, 5:24 PM
imp requested review of D32498: Test various header files to ensure they can be included by themselves..
Thu, Oct 14, 5:22 PM
imp abandoned D32496: test: sys/sysctl.h is standalone.
Thu, Oct 14, 4:46 PM
imp added a comment to D32496: test: sys/sysctl.h is standalone.

I'm torn... on the one hand I like the idea of building this during MK_TESTS=yes because the build will fail if you break it.
On the other hand, I like being able to test the target system.

Thu, Oct 14, 4:16 PM
imp added inline comments to D32496: test: sys/sysctl.h is standalone.
Thu, Oct 14, 4:13 PM
imp updated the diff for D32496: test: sys/sysctl.h is standalone.

better comment

Thu, Oct 14, 3:20 PM
imp added reviewers for D32496: test: sys/sysctl.h is standalone: asomers, ngie.
Thu, Oct 14, 3:18 PM
imp added reviewers for D32496: test: sys/sysctl.h is standalone: markj, lwhsu.
Thu, Oct 14, 3:11 PM
imp requested review of D32496: test: sys/sysctl.h is standalone.
Thu, Oct 14, 3:11 PM
imp committed R10:2ec165e3f065: nvme: Reduce traffic to the doorbell register (authored by imp).
nvme: Reduce traffic to the doorbell register
Thu, Oct 14, 2:46 PM
imp closed D32470: nvme: Reduce traffic to the doorbell register.
Thu, Oct 14, 2:46 PM

Wed, Oct 13

imp accepted D32470: nvme: Reduce traffic to the doorbell register.
Wed, Oct 13, 6:34 PM
imp updated the diff for D32470: nvme: Reduce traffic to the doorbell register.

If we 'accept' it, then bump the count of items we've cleared.

Wed, Oct 13, 6:28 PM
imp added inline comments to D32470: nvme: Reduce traffic to the doorbell register.
Wed, Oct 13, 4:35 PM
imp added a comment to D32476: New man page arswitch(4).

Thanks for moving this here... It's a lot easier to comment on something like this here than in bz.

Wed, Oct 13, 2:51 AM · docs
imp accepted D32475: mount: Check for !VDIR mount points before handling -o emptydir.
Wed, Oct 13, 1:55 AM

Tue, Oct 12

imp updated the test plan for D32470: nvme: Reduce traffic to the doorbell register.
Tue, Oct 12, 8:36 PM
imp requested review of D32470: nvme: Reduce traffic to the doorbell register.
Tue, Oct 12, 8:36 PM
imp committed R10:18dc12bfd2e2: nvme: Restore hotplug warning (authored by imp).
nvme: Restore hotplug warning
Tue, Oct 12, 8:28 PM
imp accepted D32464: Fix ldd -f on shared objects.
Tue, Oct 12, 3:01 PM

Mon, Oct 11

imp committed R10:cdccd11b366d: forward declare struct thread (authored by imp).
forward declare struct thread
Mon, Oct 11, 7:02 PM
imp added a reverting change for R10:e8f26e5dc859: bootstrap: No need to disable shared libraries for bootstrap tools: R10:c05b382edb17: Revert "bootstrap: No need to disable shared libraries for bootstrap tools".
Mon, Oct 11, 5:55 PM
imp committed R10:c05b382edb17: Revert "bootstrap: No need to disable shared libraries for bootstrap tools" (authored by imp).
Revert "bootstrap: No need to disable shared libraries for bootstrap tools"
Mon, Oct 11, 5:55 PM
imp added a reverting change for D32443: bootstrap: No need to disabled shared libraries: R10:c05b382edb17: Revert "bootstrap: No need to disable shared libraries for bootstrap tools".
Mon, Oct 11, 5:54 PM
imp committed R10:99eefc727eba: sysctl.h: Less namespace pollution (authored by imp).
sysctl.h: Less namespace pollution
Mon, Oct 11, 5:25 PM
imp committed R10:56ee5c551f89: sysctl: make sys/sysctl.h self contained (authored by imp).
sysctl: make sys/sysctl.h self contained
Mon, Oct 11, 5:24 PM
imp committed R10:e8f26e5dc859: bootstrap: No need to disable shared libraries for bootstrap tools (authored by imp).
bootstrap: No need to disable shared libraries for bootstrap tools
Mon, Oct 11, 5:24 PM
imp closed D32457: sysctl.h: Less namespace pollution.
Mon, Oct 11, 5:24 PM
imp closed D32443: bootstrap: No need to disabled shared libraries.
Mon, Oct 11, 5:24 PM
imp closed D31827: sysctl: make sys/sysctl.h self contained.
Mon, Oct 11, 5:24 PM
imp committed R9:4a04ef603433: git: recommend git bisect start --first-parent (authored by imp).
git: recommend git bisect start --first-parent
Mon, Oct 11, 5:10 PM
imp updated the diff for D31827: sysctl: make sys/sysctl.h self contained.

Finalize kib's comments

Mon, Oct 11, 3:44 PM
imp added reviewers for D32457: sysctl.h: Less namespace pollution: kib, jhb.
Mon, Oct 11, 3:43 PM
imp requested review of D32457: sysctl.h: Less namespace pollution.
Mon, Oct 11, 3:43 PM
imp added inline comments to D31827: sysctl: make sys/sysctl.h self contained.
Mon, Oct 11, 1:04 PM

Sun, Oct 10

imp updated the diff for D32444: bootstrap: bump minimum supported version.

11.4

Sun, Oct 10, 7:29 PM
imp requested review of D32444: bootstrap: bump minimum supported version.
Sun, Oct 10, 6:34 PM
imp added reviewers for D32443: bootstrap: No need to disabled shared libraries: jrtc27, arichardson, bapt, marcel.
Sun, Oct 10, 5:23 PM
imp requested review of D32443: bootstrap: No need to disabled shared libraries.
Sun, Oct 10, 5:23 PM
imp closed D32442: cross-build: Remove redundant lines..
Sun, Oct 10, 5:19 PM
imp committed R10:880aec7361ea: cross-build: Remove redundant lines. (authored by imp).
cross-build: Remove redundant lines.
Sun, Oct 10, 5:19 PM
imp added reviewers for D32442: cross-build: Remove redundant lines.: arichardson, jrtc27.
Sun, Oct 10, 4:36 PM
imp requested review of D32442: cross-build: Remove redundant lines..
Sun, Oct 10, 4:35 PM
imp accepted D32435: ncurses: convert libncursesw.a into a static ldscript.
Sun, Oct 10, 5:45 AM

Fri, Oct 8

imp committed R10:15575aca8754: bsd.cpu.mk: Minor formatting for armv6 vs armv7 (authored by imp).
bsd.cpu.mk: Minor formatting for armv6 vs armv7
Fri, Oct 8, 9:46 PM
imp accepted D32370: virtio: make the write_config buffer argument const.

Looks like const-poisoning to me. :)

Fri, Oct 8, 4:14 PM
imp accepted D32161: LinuxKPI: add check for resource_disabled().

I think this check should be in the linux_pci_probe function, not the attach one.

	if (resource_disabled(device_get_name(dev), device_get_unit(dev)))
		return (ENXIO);

Else looks good.

Fri, Oct 8, 4:13 PM
imp accepted D32291: linux: Partially implement TCSBRK.

Minor wording tweak, but now it's fine.

Fri, Oct 8, 2:49 PM