imp (Warner Losh)
User

Projects

User Details

User Since
Jun 2 2014, 4:20 PM (215 w, 5 d)

Recent Activity

Today

imp accepted D16380: Restore apmd.conf and rc.d/apmd.
Sat, Jul 21, 5:12 PM
imp added a comment to D16328: brelse() should not make buffers dirty again when writes fail.
In D16328#347509, @kib wrote:

For data blocks, this is absolutely the right fix.

This is not a right fix for the data blocks, at least for some people. https://wiki.postgresql.org/wiki/Fsync_Errors

Sat, Jul 21, 3:59 AM
imp requested changes to D16374: Purge apmd.

I accepted? Really? No, I did not.

Sat, Jul 21, 3:29 AM
imp added a comment to D16374: Purge apmd.

So what's actually wrong with this code?
APM is still in the range of things we support, and that standard hasn't changed in a long time.
Many early ACPI machines are now blacklisted as being too old, so we can only run APM on them (though not all of them). FreeBSD still runs on these systems, but 12 will likely be the last release for them since the coming purge will likely prune device support past the point of viability for these machines (plus many have issues running a full range applications that will just get worse as we get into the 13 release). At that time, I agree that this might be a good candidate to evaluate for removal, but not being updated in a along time is not a compelling reason to me.

Sat, Jul 21, 3:29 AM

Yesterday

imp added a comment to D16328: brelse() should not make buffers dirty again when writes fail.

On further thought, I realize that while we (correctly) deal with the B_PAGING panic, we simply replace it with the "dangling dependency" panic in UFS along with about 100 UFS metadata corruption panics that occur if the I/O fails when writing a UFS metadata block. So, at a minimum we need to make a callback to the filesystem when we are going to fail a write so that it can take some sort of defensive action (such as forcible unmount). This can be done here where we know that we are about to start the cascade or perhaps in buf_free where we should call buf_deallocate if the reason for the buffer being freed is that it had a failed write.

Fri, Jul 20, 4:55 PM
imp committed rS336538: Bump version to 1200075 for zfsloader being folded into loader..
Bump version to 1200075 for zfsloader being folded into loader.
Fri, Jul 20, 5:34 AM
imp committed rS336537: Mention zfsloader being folded into loader in UPDATING..
Mention zfsloader being folded into loader in UPDATING.
Fri, Jul 20, 5:26 AM
imp committed rS336536: Remove three stray instances of zfsloader..
Remove three stray instances of zfsloader.
Fri, Jul 20, 5:26 AM
imp committed rS336535: Hoist EFI_TARGET and SOURCE_DATE_EPOCH up into efi/Makefile.inc.
Hoist EFI_TARGET and SOURCE_DATE_EPOCH up into efi/Makefile.inc
Fri, Jul 20, 5:18 AM
imp committed rS336534: NM and OBJCOPY are already defined for all builds. There's no need to.
NM and OBJCOPY are already defined for all builds. There's no need to
Fri, Jul 20, 5:18 AM
imp committed rS336533: Eliminate zfsloader man page..
Eliminate zfsloader man page.
Fri, Jul 20, 5:18 AM
imp committed rS336532: Collapse zfsloader functionality back down into loader..
Collapse zfsloader functionality back down into loader.
Fri, Jul 20, 5:18 AM
imp closed D16361: Stop building zfsloader. Instead, include zfs in loader. Provide a compatibility link from zfsloader to loader for people that haven't updated their boot blocks..
Fri, Jul 20, 5:18 AM
imp updated the diff for D16361: Stop building zfsloader. Instead, include zfs in loader. Provide a compatibility link from zfsloader to loader for people that haven't updated their boot blocks..

We don't need the zfsloader.efi compat link...

Fri, Jul 20, 3:09 AM
imp updated the diff for D16361: Stop building zfsloader. Instead, include zfs in loader. Provide a compatibility link from zfsloader to loader for people that haven't updated their boot blocks..

actually do the link to zfsloader now.

Fri, Jul 20, 3:04 AM
imp added reviewers for D16361: Stop building zfsloader. Instead, include zfs in loader. Provide a compatibility link from zfsloader to loader for people that haven't updated their boot blocks.: allanjude, kevans.
Fri, Jul 20, 2:24 AM
imp created D16361: Stop building zfsloader. Instead, include zfs in loader. Provide a compatibility link from zfsloader to loader for people that haven't updated their boot blocks..
Fri, Jul 20, 2:23 AM

Thu, Jul 19

imp committed rS336524: Note big endian arm removal..
Note big endian arm removal.
Thu, Jul 19, 11:54 PM

Wed, Jul 18

imp committed rS336464: If the console is already set, don't override it..
If the console is already set, don't override it.
Wed, Jul 18, 10:45 PM
imp committed rS336463: If rootdev is set, use it as currdev..
If rootdev is set, use it as currdev.
Wed, Jul 18, 10:45 PM
imp requested changes to D15912: sys/cam/mmc/mmc_da.c: Refactor error handling.

make sure all the places you've put the mmc_handle_reply can handle errno-type errors. There's at least one that can't.

Wed, Jul 18, 10:32 PM
imp added inline comments to D15892: Use information about max data size that the controller is able to operate.
Wed, Jul 18, 10:23 PM
imp added inline comments to D16155: Add veriexec to loader.
Wed, Jul 18, 10:03 PM
imp added inline comments to D15955: Discover cards on boot.
Wed, Jul 18, 10:01 PM
imp accepted D16328: brelse() should not make buffers dirty again when writes fail.
Wed, Jul 18, 6:23 PM
imp created D16322: If rootdev is set, use it as currdev..
Wed, Jul 18, 3:28 PM
imp added a comment to D16312: Remove Atmel AT91RM9200 and AT91SAM9 support..

I think this will also remove support for the last ARMv4 SoC.

No, CNS11XXNAS is also ARMv4.

Wed, Jul 18, 2:02 PM
imp added reviewers for D16312: Remove Atmel AT91RM9200 and AT91SAM9 support.: ian, cognet.
Wed, Jul 18, 2:35 AM
imp added reviewers for D16313: Remove xscale support: cognet, ian.
Wed, Jul 18, 2:34 AM
imp created D16313: Remove xscale support.
Wed, Jul 18, 2:33 AM
imp created D16312: Remove Atmel AT91RM9200 and AT91SAM9 support..
Wed, Jul 18, 1:52 AM

Tue, Jul 17

imp committed rS336436: Remove kernel support for armeb.
Remove kernel support for armeb
Tue, Jul 17, 11:24 PM
imp committed rS336437: Remove special cases for armeb in the build..
Remove special cases for armeb in the build.
Tue, Jul 17, 11:24 PM
imp committed rS336435: Remove armeb from arch.7.
Remove armeb from arch.7
Tue, Jul 17, 11:24 PM
imp committed rS336434: As discussed several times on freebsd-arch, start to decommission armeb..
As discussed several times on freebsd-arch, start to decommission armeb.
Tue, Jul 17, 11:23 PM
imp closed D16257: As discussed several times on freebsd-arch, start to decommission armeb..
Tue, Jul 17, 11:23 PM
imp committed rS336432: Fix compile error introduced in r336245..
Fix compile error introduced in r336245.
Tue, Jul 17, 11:01 PM
imp committed rS336431: Remove bogus attempt to simulate scrolling. It's not needed and messes.
Remove bogus attempt to simulate scrolling. It's not needed and messes
Tue, Jul 17, 9:45 PM
imp closed D16309: Remove bogus attempt to simulate scrolling. It's not needed and messes up serial output..
Tue, Jul 17, 9:45 PM
imp committed rS336430: Fix a typo: change lists to list to match rest of sentence..
Fix a typo: change lists to list to match rest of sentence.
Tue, Jul 17, 9:19 PM
imp committed rS336428: Remove VM_FREELIST_ISADMA.
Remove VM_FREELIST_ISADMA
Tue, Jul 17, 9:08 PM
imp committed rS336427: Remove VM_FREELIST_ISADMA. It's not needed on these architectures..
Remove VM_FREELIST_ISADMA. It's not needed on these architectures.
Tue, Jul 17, 9:08 PM
imp committed rS336425: More typos.
More typos
Tue, Jul 17, 8:26 PM
imp updated the summary of D16309: Remove bogus attempt to simulate scrolling. It's not needed and messes up serial output..
Tue, Jul 17, 8:20 PM
imp created D16309: Remove bogus attempt to simulate scrolling. It's not needed and messes up serial output..
Tue, Jul 17, 8:13 PM
imp committed rS336424: Fix typo in the command summary..
Fix typo in the command summary.
Tue, Jul 17, 8:12 PM

Mon, Jul 16

imp accepted D16214: config(8): Bump major version after r335998.
Mon, Jul 16, 6:38 PM
imp created D16291: NVME trim stuff..
Mon, Jul 16, 5:54 PM
imp added inline comments to D16290: Combine VM_FREELIST_ISADMA and VM_FREELIST_LOWMEM. They are the same thing..
Mon, Jul 16, 5:40 PM
imp added inline comments to D11124: ZSTD compression for ZFS.
Mon, Jul 16, 5:01 PM
imp added a comment to D16254: Create an empty stdint.h for arm_neon.h to include..

I wish I'd seen this. Any reason why arm_neon.h couldn't just include sys/stdint.h?

Mon, Jul 16, 4:35 PM
imp added reviewers for D16290: Combine VM_FREELIST_ISADMA and VM_FREELIST_LOWMEM. They are the same thing.: markj, alc, marius, br.
Mon, Jul 16, 4:00 PM
imp added a comment to D16260: Use memory locality info provided in the FDT..

https://reviews.freebsd.org/D16290

Mon, Jul 16, 3:57 PM
imp created D16290: Combine VM_FREELIST_ISADMA and VM_FREELIST_LOWMEM. They are the same thing..
Mon, Jul 16, 3:57 PM
imp added a comment to D16260: Use memory locality info provided in the FDT..

sparc64 does not need ISADMA either. There's actually no fdc driver that needs it.

Mon, Jul 16, 3:50 PM
imp committed rS336347: Add pointer to freebsd-numerics for libm..
Add pointer to freebsd-numerics for libm.
Mon, Jul 16, 3:29 PM
imp added a comment to D16260: Use memory locality info provided in the FDT..
In D16260#345214, @alc wrote:

Does this architecture actually need VM_FREELIST_ISADMA?

From my reading of the code I don't think so, but I'm unsure it's intended purpose. I would expect riscv also doesn't need it.

Mon, Jul 16, 2:47 PM
imp added inline comments to D16281: Make it possible to run ntpd as a non-root user, add ntpd uid and gid..
Mon, Jul 16, 4:44 AM

Sun, Jul 15

imp committed rS336302: Use EF_SEG_READ_STRING instead of EF_SEG_READ when reading strings..
Use EF_SEG_READ_STRING instead of EF_SEG_READ when reading strings.
Sun, Jul 15, 5:30 AM

Sat, Jul 14

imp added a comment to D16258: ffs_syncvnode: Remove spammy print.
In D16258#345051, @kib wrote:

I can only think about failing writes re-dirtying the buffers with error.

Sat, Jul 14, 3:43 PM
imp accepted D16258: ffs_syncvnode: Remove spammy print.
Sat, Jul 14, 3:16 PM
imp committed rS336272: Minor adjustments:.
Minor adjustments:
Sat, Jul 14, 6:44 AM
imp committed rS336271: Add reporting of whether or not a keyboard is detected. In addition,.
Add reporting of whether or not a keyboard is detected. In addition,
Sat, Jul 14, 1:46 AM
imp committed rS336270: uefi stand: Guess the console better.
uefi stand: Guess the console better
Sat, Jul 14, 12:40 AM
imp closed D15917: uefi stand: Guess the console better.
Sat, Jul 14, 12:40 AM
imp added a comment to D15917: uefi stand: Guess the console better.

last cleanup... Will put through it's paces in a new couple places then commit.

Sat, Jul 14, 12:28 AM
imp updated the diff for D15917: uefi stand: Guess the console better.

Style changes from john, collapse if statement one layer

Sat, Jul 14, 12:26 AM
imp added inline comments to D16155: Add veriexec to loader.
Sat, Jul 14, 12:23 AM

Fri, Jul 13

imp updated the diff for D15917: uefi stand: Guess the console better.

Review feedback and fix overrides

Fri, Jul 13, 10:05 PM
imp committed rS336264: Define ADR subtype of ACPI type for a device path..
Define ADR subtype of ACPI type for a device path.
Fri, Jul 13, 9:03 PM
imp committed rS336262: Fix machdep_boot.c.
Fix machdep_boot.c
Fri, Jul 13, 8:33 PM
imp committed rS336261: Catch up to the inflate renaming..
Catch up to the inflate renaming.
Fri, Jul 13, 8:08 PM
imp committed rS336255: g_eli_key_cmp is used only in the kernel, so only define it in the.
g_eli_key_cmp is used only in the kernel, so only define it in the
Fri, Jul 13, 6:21 PM
imp committed rS336254: Use if rather than case for a simple boolean. gcc thinks blks is.
Use if rather than case for a simple boolean. gcc thinks blks is
Fri, Jul 13, 6:19 PM
imp committed rS336253: Add missing include of sys/boot.h.
Add missing include of sys/boot.h
Fri, Jul 13, 6:00 PM
imp committed rS336250: There's two files in the sys tree named inflate.c, in addition.
There's two files in the sys tree named inflate.c, in addition
Fri, Jul 13, 5:41 PM
imp committed rS336249: Fix sparc64 builds.
Fix sparc64 builds
Fri, Jul 13, 5:15 PM
imp accepted D15743: Extend loader(8) geli support to all architectures and all disk-like devices..

let's get this in, modulo the one nit.

Fri, Jul 13, 4:47 PM
imp committed rS336246: Eliminate boot loader copies of boot arg parsing..
Eliminate boot loader copies of boot arg parsing.
Fri, Jul 13, 4:44 PM
imp committed rS336247: Transition to boot_env_to_howto and boot_howto_to_env in the boot.
Transition to boot_env_to_howto and boot_howto_to_env in the boot
Fri, Jul 13, 4:44 PM
imp committed rS336244: Create helper functions for parsing boot args..
Create helper functions for parsing boot args.
Fri, Jul 13, 4:44 PM
imp committed rS336245: Use boot_parse_* to parse command line args and retire cut-n-paste.
Use boot_parse_* to parse command line args and retire cut-n-paste
Fri, Jul 13, 4:44 PM
imp closed D16205: Create three helper functions for parsing boot args..
Fri, Jul 13, 4:44 PM
imp added a reviewer for D16257: As discussed several times on freebsd-arch, start to decommission armeb.: bdrewery.
Fri, Jul 13, 3:45 PM
imp created D16257: As discussed several times on freebsd-arch, start to decommission armeb..
Fri, Jul 13, 3:43 PM

Thu, Jul 12

imp added inline comments to D16239: release: Add arm_install_boot to install the commit boot bits.
Thu, Jul 12, 10:27 PM
imp added inline comments to D16239: release: Add arm_install_boot to install the commit boot bits.
Thu, Jul 12, 10:25 PM
imp committed rS336220: Fix an obvious 'is odd' check..
Fix an obvious 'is odd' check.
Thu, Jul 12, 4:19 PM
imp accepted D16242: sysutils/u-boot-rpi-0-w: Add port.

I agree with linimon's stuff, but have no other niggles.

Thu, Jul 12, 3:37 PM
imp accepted D16241: sysutils/u-boot-master, -rpi2, -rpi3: Update to v2018.07.
Thu, Jul 12, 3:36 PM
imp accepted D16240: release: Add rpi firmware dtb and mmc overlays for RPI-B and RPI2.
Thu, Jul 12, 3:30 PM
imp accepted D16239: release: Add arm_install_boot to install the commit boot bits.

This is a good first step...
I wonder, though about the one item I highlighted.

Thu, Jul 12, 3:30 PM
imp added inline comments to D16238: release: Uniform release image size.
Thu, Jul 12, 3:23 PM
imp accepted D16243: sysutils/rpi-firmware: Update to 1.20180619 and add rpi0-w config.txt.
Thu, Jul 12, 3:21 PM
imp accepted D16237: release: Remove some arm board release config.

Except maybe the hummingboard one

Thu, Jul 12, 2:52 PM
imp added a comment to D16237: release: Remove some arm board release config.

Hmmm, I have all these boards except the GUMSTIX :).

Thu, Jul 12, 2:51 PM

Wed, Jul 11

imp committed rS336213: Small refactor of install-boot.
Small refactor of install-boot
Wed, Jul 11, 9:53 PM
imp updated the diff for D16205: Create three helper functions for parsing boot args..

Track down copyright holders / original authors as best I can.

Wed, Jul 11, 4:19 PM
imp added inline comments to D16205: Create three helper functions for parsing boot args..
Wed, Jul 11, 3:12 PM
imp added a comment to D16205: Create three helper functions for parsing boot args..
In D16205#344062, @bz wrote:

Given this is multiple architectures, how are you dealing with colliding/different values? Hmm I see you don't touch that part.

Wed, Jul 11, 3:08 PM