Page MenuHomeFreeBSD

imp (Warner Losh)
User

Projects

User Details

User Since
Jun 2 2014, 4:20 PM (280 w, 4 h)

Recent Activity

Today

imp accepted D22016: ig4. Various improvements.
Mon, Oct 14, 1:43 AM
imp added a comment to D22016: ig4. Various improvements.

Generally I like this. I'm unsure of DEV_ACPI stuff is proper...

Mon, Oct 14, 1:43 AM

Yesterday

imp added a comment to D22012: Import dhcpcd(8) version 8.1.0 into FreeBSD base..

I didn't see you address Brooks' objection in the posted thread. given the extreme level of exposure here, it needs to be answered satisfactorily

Sun, Oct 13, 6:32 PM
imp added a comment to D22012: Import dhcpcd(8) version 8.1.0 into FreeBSD base..

Where was this discussed?

Sun, Oct 13, 6:14 PM

Sat, Oct 12

imp accepted D22004: devel/powerpc64-gcc: always set the endian flag for the linker emulation for MIPS..
Sat, Oct 12, 9:06 PM
imp accepted D21998: RISC-V: Call devmap_print_table() on bootverbose.

lgtm.. do you have someone to commit this yet?

Sat, Oct 12, 6:11 PM

Fri, Oct 11

imp added inline comments to D21987: nvdimm(4): Don't expose namespaces for inaccessible SPAs.
Fri, Oct 11, 10:50 PM
imp accepted D21983: Centralize adding OBJCOPY=${XOBJCOPY} to LIB32WMAKEFLAGS..
Fri, Oct 11, 6:14 PM

Thu, Oct 10

imp accepted D21972: Add support to geom_nop.ko kernel module for older geom_nop.so userland modules..

This seems sane to me...
I'd e tempted to split this into two commits. One for geom_ctl and one for g_nop.

Thu, Oct 10, 6:57 PM

Wed, Oct 9

imp committed rS353373: Add note about universe changes to arch and the need to add.
Add note about universe changes to arch and the need to add
Wed, Oct 9, 9:45 PM
imp committed rS353372: Add UPDATING entry for universe changes.
Add UPDATING entry for universe changes
Wed, Oct 9, 9:45 PM
imp committed rS353370: Wordsmith and simplify.
Wordsmith and simplify
Wed, Oct 9, 9:19 PM
imp added inline comments to D21942: Don't compile old gcc 4.2.1 archs by default in universe/tinderbox..
Wed, Oct 9, 9:08 PM
imp committed rS353368: Fix casting error from newer gcc.
Fix casting error from newer gcc
Wed, Oct 9, 9:02 PM
imp closed D21942: Don't compile old gcc 4.2.1 archs by default in universe/tinderbox..
Wed, Oct 9, 8:59 PM
imp committed rS353367: Don't compile old gcc 4.2.1 archs by default in universe/tinderbox..
Don't compile old gcc 4.2.1 archs by default in universe/tinderbox.
Wed, Oct 9, 8:59 PM
imp added a comment to D20293: ucom(4): synchronously execute param changes.

You either want to return success synchronously, or return failure and not change things... so long as there are those semantics, a timeout is fine.

Wed, Oct 9, 1:19 PM
imp accepted D21930: fix ESP generation for ZFS boot.
Wed, Oct 9, 2:05 AM
imp accepted D21948: Support hotplug of PCI devices on EC2..

The newbus side of this looks good

Wed, Oct 9, 12:36 AM
imp added a comment to D21948: Support hotplug of PCI devices on EC2..

Looking giant around bus scan is, sadly, still required. Yea asserts I added :)

Wed, Oct 9, 12:32 AM

Tue, Oct 8

imp added inline comments to D21942: Don't compile old gcc 4.2.1 archs by default in universe/tinderbox..
Tue, Oct 8, 10:56 PM
imp added a comment to D21942: Don't compile old gcc 4.2.1 archs by default in universe/tinderbox..

Looking at Brooks' ask for llvm90, I think it's not quite ready for prime time, as we fail early in the build:

% make buildworld CROSS_TOOLCHAIN=llvm90 TARGET_ARCH=mips64
...
--- libstdc++.so.6.full ---
building shared library libstdc++.so.6
/usr/local/bin/clang90 -target mips64-unknown-freebsd13.0 --sysroot=/usr/home/imp/obj/usr/home/imp/git/head/mips.mips64/tmp -B/var/empty  -EB -mabi=64 -Wl,--version-script=libstdc++.map    -shared -Wl,-x -Wl,--fatal-warnings -Wl,--warn-shared-textrel  -o libstdc++.so.6.full -Wl,-soname,libstdc++.so.6  `NM='nm' NMFLAGS='' lorder bitmap_allocator.pico pool_allocator.pico mt_allocator.pico codecvt.pico compatibility.pico complex_io.pico ctype.pico debug.pico debug_list.pico functexcept.pico globals_io.pico ios.pico ios_failure.pico ios_init.pico ios_locale.pico limits.pico list.pico locale.pico locale_init.pico locale_facets.pico localename.pico stdexcept.pico strstream.pico tree.pico allocator-inst.pico concept-inst.pico fstream-inst.pico ext-inst.pico ios-inst.pico iostream-inst.pico istream-inst.pico istream.pico locale-inst.pico misc-inst.pico ostream-inst.pico sstream-inst.pico streambuf-inst.pico streambuf.pico string-inst.pico valarray-inst.pico wlocale-inst.pico wstring-inst.pico atomicity.pico codecvt_members.pico collate_members.pico ctype_members.pico messages_members.pico monetary_members.pico numeric_members.pico time_members.pico basic_file_stdio.pico c_locale.pico atomicity.pico codecvt_members.pico collate_members.pico ctype_members.pico messages_members.pico monetary_members.pico numeric_members.pico time_members.pico basic_file_stdio.pico c_locale.pico stubs.pico del_op.pico del_opnt.pico del_opv.pico del_opvnt.pico eh_alloc.pico eh_arm.pico eh_aux_runtime.pico eh_call.pico eh_catch.pico eh_exception.pico eh_globals.pico eh_personality.pico eh_term_handler.pico eh_terminate.pico eh_throw.pico eh_type.pico eh_unex_handler.pico guard.pico new_handler.pico new_op.pico new_opnt.pico new_opv.pico new_opvnt.pico pure.pico tinfo.pico tinfo2.pico vec.pico vterminate.pico cp-demangle.pico |  tsort -q` -Wl,-f,libsupc++.so.1  -lm
ld: error: can't create dynamic relocation R_MIPS_64 against local symbol in readonly segment; recompile object files with -fPIC or pass '-Wl,-z,notext' to allow text relocations in the output

so I'm going to remain open to making that possible in the future, but won't gate this review on making that work (unless I find a way to make it go).

Tue, Oct 8, 9:41 PM
imp added a comment to D21942: Don't compile old gcc 4.2.1 archs by default in universe/tinderbox..

I'll note it would be nice to have a more generic xtoolchain thing for things like llvm and/or "I'd like to do a universe with all the external toolchains regardless of base compiler support"

Tue, Oct 8, 5:53 PM
imp updated the diff for D21942: Don't compile old gcc 4.2.1 archs by default in universe/tinderbox..

xtoolchain part of the IRC ask

Tue, Oct 8, 5:51 PM
imp added a comment to D21942: Don't compile old gcc 4.2.1 archs by default in universe/tinderbox..

On IRC, it was suggested I do the right thing for mips, etc if llvm90 and/or mips-gcc is installed. Will noodle around on that and post an update with riscv moved.

Tue, Oct 8, 5:05 PM
imp created D21942: Don't compile old gcc 4.2.1 archs by default in universe/tinderbox..
Tue, Oct 8, 4:47 PM

Mon, Oct 7

imp added a comment to D16698: First draft HID over I2C support (Mouse only).
In D16698#478767, @imp wrote:

So with the suggested changes, I'm not able to get very far with the patches in this review. With wulf's code I'm able to get the device probed. With this code, I see the following

Is this code still really considered? wulf's repo is currently actively developed (now even includes the long-awaited and very necessary "HID bus" abstraction), this was last updated in August.
data point: I'm using wulf's code on my Pixelbook, multi-touch works great for both the touchpad and touchscreen.

Mon, Oct 7, 5:26 PM · Contributor Reviews (base)
imp added a comment to D16698: First draft HID over I2C support (Mouse only).

So with the suggested changes, I'm not able to get very far with the patches in this review. With wulf's code I'm able to get the device probed. With this code, I see the following:

Mon, Oct 7, 1:12 AM · Contributor Reviews (base)
imp added inline comments to D16698: First draft HID over I2C support (Mouse only).
Mon, Oct 7, 1:08 AM · Contributor Reviews (base)
imp accepted D21912: nda(4): Remove unnecessary union and avoid Clang -Wsizeof-array-div warning.
Mon, Oct 7, 12:55 AM

Fri, Oct 4

imp accepted D21887: Formalize the use of linker scripts for kernel modules..

I'm cool with jhb's reasoning, so this looks ready to land.

Fri, Oct 4, 5:26 PM
imp added a comment to D21897: mountroot: Run statfs after mounting devfs.

I think this is OK. But since it's only /dev that's being mounted here, is the reported problem with aio on raw devices?

Fri, Oct 4, 5:24 PM

Thu, Oct 3

imp added a comment to D21886: Add USB support for location based device unit numbers.

There is people who expect the first serial device they plug-in to be ttyU0 (me for example) and there are people who would prefer the unit number to stay the same independent of the order the devices are detected (me as well).
I would prefer aliases as well, so we can have both. I didn't check whether it actually is a match to your problem, but how about tty_makealias() in sys/tty.h?
sys/tty.h-int tty_makedevf(struct tty *tp, struct ucred *cred, int flags,
sys/tty.h- const char *fmt, ...) printflike(4, 5);
sys/tty.h-#define TTYMK_CLONING 0x1
sys/tty.h-#define tty_makedev(tp, cred, fmt, ...) \
sys/tty.h- (void )tty_makedevf((tp), (cred), 0, (fmt), __VA_ARGS__) sys/tty.h:#define tty_makealias(tp,fmt,...) \ sys/tty.h- make_dev_alias((tp)->t_dev, fmt,
VA_ARGS__)
sys/tty.h-
sys/tty.h-/* Signalling processes. */
sys/tty.h-void tty_signal_sessleader(struct tty *tp, int signal);
sys/tty.h-void tty_signal_pgrp(struct tty *tp, int signal);
I do remember from way back talks about naming schemes for USB devices in the USB device tree, something like usb-1-3-2 being a device plugged into port 2 of a hub that is plugged into port 3 of a hub plugged into port 1 of the root hub.

Thu, Oct 3, 7:38 PM
imp added inline comments to D21887: Formalize the use of linker scripts for kernel modules..
Thu, Oct 3, 6:21 PM
imp added a comment to D21886: Add USB support for location based device unit numbers.

Unit numbers are kinda lame. Wouldn't it be better to add aliases?

Thu, Oct 3, 3:46 PM

Wed, Oct 2

imp added a comment to D21865: avoid compiling in hpt* drivers containing binary blobs.
In D21865#477783, @imp wrote:

I'd propose we kick them out of the tree, put them in ports and let people that care about them be listed as maintainer, or they get deleted from the ports tree...

IMO having drivers in the ports tree doesn't really help. The fact that they're still in ports implies some level of support, so they're still a maintenance burden, and patching out-of-tree code is more work. I would much sooner just build them as modules and keep them in the tree for some time. The out-of-tree legacy DRM drivers are a case in point here.

Wed, Oct 2, 3:44 PM
imp added a comment to D21865: avoid compiling in hpt* drivers containing binary blobs.

querying for hptFOO: no controller returns the same number of hits. Spot checking again shows no actual indicated use.

Wed, Oct 2, 2:42 PM
imp added a comment to D21865: avoid compiling in hpt* drivers containing binary blobs.

+re@
I'm mostly in favor of the change (smaller kernel size, etc.), but since we are removing driver from GENERIC, it's better if we can provide a mechanism to load the driver on demand, or a binary update can easily brick the system...

Wed, Oct 2, 2:41 PM
imp added inline comments to D21863: ugensa: add support for Google Cr50 (GSC) Closed Case Debugging UART interfaces.
Wed, Oct 2, 3:04 AM

Tue, Oct 1

imp abandoned D4987: Create an API to reset a struct bio (g_reset_bio). This is mandatory for all struct bio you get back from g_{new,alloc}_bio, and optional for all other struct bio..

This has been comitte.d

Tue, Oct 1, 3:31 PM
imp added a comment to D4987: Create an API to reset a struct bio (g_reset_bio). This is mandatory for all struct bio you get back from g_{new,alloc}_bio, and optional for all other struct bio..

I thought I'd committed this stuff already...

Tue, Oct 1, 2:02 AM

Mon, Sep 30

imp added a comment to D2418: Add support for launching soft-float binaries with ld-elf-soft.so instead of ld-elf.so ala ld-elf32.so..

I've had no requests in the last 4 years since I posted this...

Mon, Sep 30, 5:12 PM
imp added inline comments to D21836: mips: fcmpset: do not spin on sc failure.
Mon, Sep 30, 2:03 AM
imp committed rS352883: MFC r351828:.
MFC r351828:
Mon, Sep 30, 1:59 AM
imp added inline comments to D21836: mips: fcmpset: do not spin on sc failure.
Mon, Sep 30, 1:49 AM

Sun, Sep 29

imp added a comment to D20674: [libkvm] kvm_geswapinfo() to stop subtracting vm.dmmax size from swap device sizes..
In D20674#476856, @alc wrote:
In D20674#476783, @kib wrote:
In D20674#476657, @alc wrote:

I believe that there is a sound reason for not reporting the unmodified size of the device. Specifically, the swap pager can't use the first, if I recall correctly, 8KB of a swap device because it might contain a disk label. However, I can't explain why we use dmmax to calculate the modified size.

I think reporting the total size minus reserved blocks (for any definition of the block size, correct or not), is more confusing to users than reporting raw size and used. At worst, user would observe that some amount of swap volume is not filled, instead of seeing mismatch between e.g. geom size and vm size for the swap volume.

I'm sympathetic to that argument. In any case, the current code is wrong, in that, it subtracts too much.

That said, I suspect that we no longer need to avoid initial blocks. At least not for the label preservation.

I'm afraid that is not true. I found out the hard way that it is needed. I lost a disk label, swap area, and file system when I first enabled "trimonce". However, the configuration of that storage device is usual. The first partition is a swap area, not a file system.

Sun, Sep 29, 4:35 PM

Sat, Sep 28

imp committed rS352846: Revert the mode_t -> int changes and add a warning in the BUGS section instead..
Revert the mode_t -> int changes and add a warning in the BUGS section instead.
Sat, Sep 28, 5:15 PM

Fri, Sep 27

imp committed rS352822: Use set -o xtrace in preference to set -x for consistency with.
Use set -o xtrace in preference to set -x for consistency with
Fri, Sep 27, 8:56 PM
imp committed rS352821: Push and pop xtrace correctly for run_early_customize.
Push and pop xtrace correctly for run_early_customize
Fri, Sep 27, 8:56 PM
imp committed rS352820: Remove workaround for building on FreeBSD hosts prior to FreeBSD 10..
Remove workaround for building on FreeBSD hosts prior to FreeBSD 10.
Fri, Sep 27, 8:56 PM
imp closed D21816: openat(2), mq_open(2): do not refer to mode_t for variadic arguments.
Fri, Sep 27, 4:12 PM · manpages
imp committed rS352795: Document varadic args as int, since you can't have short varadic args (they are.
Document varadic args as int, since you can't have short varadic args (they are
Fri, Sep 27, 4:12 PM
imp accepted D21816: openat(2), mq_open(2): do not refer to mode_t for variadic arguments.

LGTM

Fri, Sep 27, 4:11 PM · manpages
imp added inline comments to D21807: VirtIO SCSI online disk resize.
Fri, Sep 27, 1:38 PM
imp committed rP512994: Use tab instead of multiple spaces.
Use tab instead of multiple spaces
Fri, Sep 27, 12:03 AM

Thu, Sep 26

imp committed rP512986: The code creates a lambda function that takes by reference the core_id local.
The code creates a lambda function that takes by reference the core_id local
Thu, Sep 26, 8:53 PM
imp closed D21804: cherry-pick memory corruption bug fix from github.
Thu, Sep 26, 8:53 PM
imp accepted D21804: cherry-pick memory corruption bug fix from github.

This looks good to me. I'll update the port with it shortly.

Thu, Sep 26, 5:33 PM
imp committed rS352761: Merge from stable/12 r352735 and r352741.
Merge from stable/12 r352735 and r352741
Thu, Sep 26, 4:52 PM
imp added a comment to D21697: Fix MIPS CSU compilation w/ LLVM.

If prefer to just spell out the assembly rather than just the magic cp* macros.

Thu, Sep 26, 4:34 PM
imp committed rS352741: mpr/mps crash badly. Part of the stability added use of atomic64 functions not.
mpr/mps crash badly. Part of the stability added use of atomic64 functions not
Thu, Sep 26, 12:55 PM
imp added a comment to D21733: loader: Fully reset terminal settings, not just colors.

while we've transitioned to teken, it looks like it eats the ESC c

Ok, that looks pretty tough to deal with. Now that you mention it, I'm not seeing colors on the EFI serial console either, and under bhyve the scroll region is broken after the loader hands off to the kernel as well. It's everything I wanted to fix, still broken! Ugh! I thought I had tested that, but I guess I only tested a video output with the EFI console.

Thu, Sep 26, 3:08 AM
imp committed rS352735: Catch up with stability fixes to mpr/mps in -current since 12.
Catch up with stability fixes to mpr/mps in -current since 12
Thu, Sep 26, 1:54 AM

Wed, Sep 25

imp added a comment to D21733: loader: Fully reset terminal settings, not just colors.

I had very similar code in FORTH for our boot loader and it didn't work with EFI, just comconsole. while we've transitioned to teken, it looks like it eats the ESC c and does a reset for the eficonsole, which means that efi's com redirect in the BIOS doesn't work.

Wed, Sep 25, 11:13 PM
imp added a comment to D21733: loader: Fully reset terminal settings, not just colors.

Does this work for EFI console? When I tried it, the terminal emualtor intercepted the escape sequences and so the serial console didn't get them...

Wed, Sep 25, 10:50 PM
imp added a comment to D21733: loader: Fully reset terminal settings, not just colors.

Do we need this now that tsoome has committed all his stuff to fix the broken color stuff that lead to this situation in the first place?

Wed, Sep 25, 10:07 PM
imp accepted D21789: snd_hda: Add Intel Cannon Lake support.

This looks good to my eye. Don't know if it will work...

Wed, Sep 25, 8:41 PM · multimedia
imp accepted D21710: efibootmgr(8): fix markup and style issues.

This looks good to me.

Wed, Sep 25, 8:39 PM
imp accepted D21703: o Unify all <machine>/resource.h, unhide PCI_RES_BUS, add CLK and PWR..
Wed, Sep 25, 8:37 PM
imp added a comment to D21697: Fix MIPS CSU compilation w/ LLVM.

At least according to https://techpubs.jurassic.nl/manuals/0530/developer/Cplr_PTG/sgi_html/apa.html which appears to be the reproduction of the sgi assembler manual from whence all this stuff came.

Wed, Sep 25, 8:16 PM
imp added a comment to D21697: Fix MIPS CSU compilation w/ LLVM.

How do you know offset 12 on the stack is a good place to store this? I'd expect there to be something like:
cprestore will store gp to <offset>(sp) and then load it from there after every jal operation to restore gp.

Wed, Sep 25, 8:15 PM
imp committed rS352671: Size is unsigned, so remove the test entirely..
Size is unsigned, so remove the test entirely.
Wed, Sep 25, 7:51 AM
imp committed rS352665: After my comnd changes, the number of threads and size weren't set. In.
After my comnd changes, the number of threads and size weren't set. In
Wed, Sep 25, 12:25 AM

Tue, Sep 24

imp requested changes to D16164: Make options IFLIB a real configuration option..
Tue, Sep 24, 5:34 PM
imp added a comment to D16164: Make options IFLIB a real configuration option..

I'm struggling to understand here. How does this make it a real option? It seems to say that you must include iflib to get these drivers and there will be no warning if you don't. Maybe I'm misunderstanding something here, but that strikes me as unwise on its surface. I don't think this is a good idea at all, unless I'm missing something.

Tue, Sep 24, 5:33 PM
imp requested changes to D21775: (WIP) Rewrite makesyscalls.sh in Lua.

I'm currently in transit from EuroBSDcon and will likely be out of commission for a couple of days. I'd like to request the favor of getting a chance to review this once I've recovered before you push it in. Thanks!

Tue, Sep 24, 5:17 PM

Sat, Sep 21

imp accepted D21564: LinuxKPI: enable class dev_groups attributes.

Seems fine to me. Does this cause an issue for other users of LinuxKPI?

Sat, Sep 21, 10:17 PM
imp accepted D21746: acpi_cros_kblt: New driver for Chromebook keyboard backlight control.

I was going to suggest adding the devmatch changes, but no other ACPI driver seems to have them yet, so I can do that in a sweep.

Sat, Sep 21, 10:15 PM

Fri, Sep 20

imp accepted D21603: new port: sysutils/u-boot-rpi3-32, u-boot for the RPi3 running in 32 bit mode.

This looks good to me.

Fri, Sep 20, 8:27 AM

Mon, Sep 16

imp added a comment to D19237: Fix TARGET_TRIPLE variable assembly when specifying TARGET_ABI.

So I think this belongs in share/mk/src.sys.env.mk, but I'm not sure.

Mon, Sep 16, 7:15 PM

Sep 14 2019

imp requested changes to D21660: Ask sync(8) to sync multiple times.

If you need more than one sync, then you've broken posix semantics.

Sep 14 2019, 8:33 PM

Sep 12 2019

imp accepted D21593: Add an option to gnop to allow rejecting I/O after allowing some through..

Modulo kib's quibble, this is ready to go. No need to repost the review if all you change is the .Dd date and kib's thing.

Sep 12 2019, 10:20 PM
imp accepted D21623: mtree: Fix -f -f not considering type changes..

I wonder why we still have fmtree though

Sep 12 2019, 6:43 PM

Sep 11 2019

imp added a comment to D21581: Disable the default of ntpd locking of pages in memory.
In D21581#470863, @cy wrote:

Does anyone think we need UPDATING or RELNOTES entries? Probably UPDATING. Not sure about RELNOTES.

Sep 11 2019, 11:24 PM
imp committed rS352212: Assume all the short args have optional args so allocate space for the.
Assume all the short args have optional args so allocate space for the
Sep 11 2019, 1:34 PM
imp accepted D21487: mips: ubldr: use truncated load address for mips32.

I fear this is the last bad choice we have.

Sep 11 2019, 1:18 AM

Sep 10 2019

imp committed rS352171: Remove dirs (and their now-empty parents) empty since r344779.
Remove dirs (and their now-empty parents) empty since r344779
Sep 10 2019, 5:51 PM
imp committed rS352170: Remove dir empty since r327952.
Remove dir empty since r327952
Sep 10 2019, 5:50 PM
imp committed rS352169: Remove dir empty since r314564.
Remove dir empty since r314564
Sep 10 2019, 5:49 PM
imp committed rS352168: Remove dirs empty since r280031.
Remove dirs empty since r280031
Sep 10 2019, 5:47 PM
imp committed rS352167: Remove dir empty since r276851.
Remove dir empty since r276851
Sep 10 2019, 5:46 PM
imp committed rS352162: Remove empty directory after r297894.
Remove empty directory after r297894
Sep 10 2019, 5:31 PM
imp committed rS352161: Remove empty dir after r342815 (pt 2, oops).
Remove empty dir after r342815 (pt 2, oops)
Sep 10 2019, 5:30 PM
imp committed rS352160: Remove empty dir after r288683.
Remove empty dir after r288683
Sep 10 2019, 5:27 PM
imp committed rS352159: Remove empty dir after r342815.
Remove empty dir after r342815
Sep 10 2019, 5:26 PM
imp committed rS352158: Remove dir empty since r214734.
Remove dir empty since r214734
Sep 10 2019, 5:20 PM
imp committed rS352157: Remove dirs empty since r336203.
Remove dirs empty since r336203
Sep 10 2019, 5:19 PM
imp committed rS352156: Remove directory empty after r266735.
Remove directory empty after r266735
Sep 10 2019, 4:58 PM
imp committed rS352155: Remove empty directory after r215937.
Remove empty directory after r215937
Sep 10 2019, 4:57 PM
imp committed rS352154: Remove empty directory after r342871.
Remove empty directory after r342871
Sep 10 2019, 4:56 PM