Page MenuHomeFreeBSD

imp (Warner Losh)
User

Projects (6)

User Details

User Since
Jun 2 2014, 4:20 PM (416 w, 1 d)

Recent Activity

Yesterday

imp updated the diff for D35312: cam: better ioctl compatibility for cd.

more direct call

Tue, May 24, 10:07 PM
imp requested review of D35312: cam: better ioctl compatibility for cd.
Tue, May 24, 9:51 PM
imp committed R10:f5dcfbe36e21: stty: Remove stray '-'. (authored by imp).
stty: Remove stray '-'.
Tue, May 24, 8:47 PM
imp added a comment to D35309: bsdinstall: use gpt/efiboot0 label in /etc/fstab.
In D35309#800308, @imp wrote:

So long as we don't have two disks with that label, we'll be fine...
So this is better than what we had, but not quite to where we need to get to....
Though the functionality we need to get there isn't in bsdinstall...

Well, when using a mirrored setup at least bsdinstall creates a /dev/gpt/efiboot0 and a /dev/gpt/efiboot1. What functionality do you think we need?

Tue, May 24, 7:34 PM
imp added a comment to D35309: bsdinstall: use gpt/efiboot0 label in /etc/fstab.

So long as we don't have two disks with that label, we'll be fine...
So this is better than what we had, but not quite to where we need to get to....
Though the functionality we need to get there isn't in bsdinstall...

Tue, May 24, 7:20 PM

Mon, May 23

imp added inline comments to D35291: Clean up in the pci host generic driver.
Mon, May 23, 2:22 PM

Fri, May 20

imp accepted D35276: LinuxKPI: move pm_message_t from kernel.h to pm.h.
Fri, May 20, 10:02 PM
imp added a comment to D35110: devel/freebsd-gcc9: Add flavors for armv6 and armv7..

This is fine. armv6 likely has a more limited time frame than armv7 and it certainly has a much smaller audience.
Having said that, this may help unless we wanted to opt for the more intrusive bsd.cpu.mk idea. We did it for MIPS, but there were always issues with that for edge cases, users of gmake not picking it up, etc.

Fri, May 20, 5:01 PM
imp accepted D35263: sys/dts: Remove MIPS files.
Fri, May 20, 1:10 PM

Thu, May 19

imp accepted D35254: libsa: Fix a bug in nvlist creation.
Thu, May 19, 5:09 PM

Wed, May 18

imp added a comment to D35248: makefs: Add ZFS support.

I also wonder if there's precedent for sharing code with the loader like that. Should it perhaps be moved to some common area, or should I just set .PATH=stand/libsa/zfs and not worry about it?

Wed, May 18, 7:59 PM
imp added a comment to D35248: makefs: Add ZFS support.

Shouldn't you reach over into the boot loader to get the shared files?
If there's some reason you can't do this, it should be documented and/or discussed.

Wed, May 18, 7:08 PM
imp accepted D35246: Fix grammar nit in versions chapter as discussed with bsdimp in email..
Wed, May 18, 7:03 PM
imp added a comment to D35222: Add kern.reboot_on_halt sysctl.

Halting the machine is still important in 2022. A number of people want to power it off afterwards, though sometimes the automatic power is busted.

Wed, May 18, 6:56 PM
imp committed R10:f8f1e9cd1cee: bsd-family-tree: FreeBSD 13.1 (authored by imp).
bsd-family-tree: FreeBSD 13.1
Wed, May 18, 12:04 AM

Mon, May 9

imp accepted D34809: Fix overflow errors in sbttous and sbttoms.

I think we're good. Thanks

Mon, May 9, 9:59 PM

Sat, May 7

imp closed D35141: msgbuf: Allow microsecond granularity timestamps.

Landed, but not automatically closed.

Sat, May 7, 3:58 PM
imp committed R10:2f44ad86f555: dmesg: Better wording from review (authored by imp).
dmesg: Better wording from review
Sat, May 7, 3:56 PM
imp closed D35139: dmesg: Document kern.msgbuf_show_timestamp.
Sat, May 7, 3:55 PM
imp added a comment to D35139: dmesg: Document kern.msgbuf_show_timestamp.

Yea, I stole the wording from one of the geom man pages.
I'll update. I accidentally pushed this too soon, but I'll update with this review.

Sat, May 7, 3:46 PM
imp committed R9:caedc90bf0cf: Document 1400054-1400058 (except '57 which was already here) (authored by imp).
Document 1400054-1400058 (except '57 which was already here)
Sat, May 7, 3:45 PM
imp committed R10:2e32d4e41d20: param.h: Bump FreeBSD_Version to 1400058 for devclass newbus changes (authored by imp).
param.h: Bump FreeBSD_Version to 1400058 for devclass newbus changes
Sat, May 7, 3:35 PM
imp committed R10:45ae223ac654: msgbuf: Allow microsecond granularity timestamps (authored by imp).
msgbuf: Allow microsecond granularity timestamps
Sat, May 7, 3:35 PM
imp committed R10:6910fee62e77: dmesg: Document kern.msgbuf_show_timestamp (authored by imp).
dmesg: Document kern.msgbuf_show_timestamp
Sat, May 7, 3:35 PM

Fri, May 6

imp added a comment to D34809: Fix overflow errors in sbttous and sbttoms.

Generally, I like this. Couple of small nits, sorry for the delay.

Fri, May 6, 10:43 PM
imp added a comment to D35141: msgbuf: Allow microsecond granularity timestamps.

Nice! (How did I not know that kern.msgbuf_show_timestamp was a thing?!?)

Fri, May 6, 5:43 PM
imp requested review of D35141: msgbuf: Allow microsecond granularity timestamps.
Fri, May 6, 5:33 PM
imp requested review of D35139: dmesg: Document kern.msgbuf_show_timestamp.
Fri, May 6, 4:32 PM
imp accepted D33603: Add FreeBSD "Orb" logo to boot loader.

Seems legit

Fri, May 6, 2:50 AM · PowerPC
imp accepted D35134: Correctly measure system load averages > 1024.

This looks good. normally fixfp_t is 32-bit int, which suggests that there may be other place we need to widen.
And updating the comment with the new limit would be good (~2 million if I'm doing the math right)...

Fri, May 6, 2:41 AM

Thu, May 5

imp committed R10:a85fea31c5cb: iosched: remove stray debug (authored by imp).
iosched: remove stray debug
Thu, May 5, 2:35 AM

Wed, May 4

imp committed R10:1907e1c07c36: ada: Move comment (authored by imp).
ada: Move comment
Wed, May 4, 10:55 PM
imp added inline comments to D32051: byteswap.h: Add a glibc/linux compatible byteswap.h.
Wed, May 4, 3:22 PM

Mon, May 2

imp committed R10:6f78dae8491b: cam: Remove redunant static __inline forward decls (authored by imp).
cam: Remove redunant static __inline forward decls
Mon, May 2, 4:29 PM
imp added a comment to D34977: ada: Retry commands with retries left on CAM_SEL_TIMEOUT.
In D34977#795715, @mav wrote:

The only case I see AHCI to return CAM_SEL_TIMEOUT is:

 if (ch->devices == 0 ||
    (ch->pm_present == 0 &&
     ccb->ccb_h.target_id > 0 && ccb->ccb_h.target_id < 15)) {
        ccb->ccb_h.status = CAM_SEL_TIMEOUT;
        break;
}

, which means device is not detected. I don't see how it can be transient and why it should be retried.

Mon, May 2, 2:25 PM

Sun, May 1

imp committed R10:1599fc904d35: iosched: Move bio_next() inside of the CAM_IOSCHED_DYNAMIC ifdef (authored by imp).
iosched: Move bio_next() inside of the CAM_IOSCHED_DYNAMIC ifdef
Sun, May 1, 10:54 PM
imp committed R10:d095d6a34c72: cam_xpt: Prefer bool to int where it's a boolean (authored by imp).
cam_xpt: Prefer bool to int where it's a boolean
Sun, May 1, 6:16 PM
imp closed D34351: cam iosched: Allow read bias to be 0.
Sun, May 1, 5:29 PM
imp accepted D34351: cam iosched: Allow read bias to be 0.

closed with cc1572ddeb8cd82879ce0cca634bf6a8830c0f40 with updated wording from @chs but didn't close automatically since i didn't notice git arc stage didn't put a review in.

Sun, May 1, 5:29 PM
imp committed R10:d592c0db8ba7: cam: add hw.cam.iosched.read_bias (authored by imp).
cam: add hw.cam.iosched.read_bias
Sun, May 1, 5:29 PM
imp closed D34365: cam: add hw.cam.iosched.read_bias.
Sun, May 1, 5:29 PM
imp committed R10:b65803ba5773: cam iosched: default to no read bias in dynamic ioscheduling (authored by imp).
cam iosched: default to no read bias in dynamic ioscheduling
Sun, May 1, 5:29 PM
imp committed R10:cc1572ddeb8c: cam iosched: Remove write bias when read bias = 0 (authored by imp).
cam iosched: Remove write bias when read bias = 0
Sun, May 1, 5:28 PM
imp committed R10:7df08a14e3fd: stand: Initial kboot support on amd64 (authored by imp).
stand: Initial kboot support on amd64
Sun, May 1, 5:14 PM
imp closed D35100: stand: Initial kboot support on amd64.
Sun, May 1, 5:14 PM
imp committed R10:6c8ab086fed3: ada: Retry commands with retries left on CAM_SEL_TIMEOUT (authored by imp).
ada: Retry commands with retries left on CAM_SEL_TIMEOUT
Sun, May 1, 5:11 PM
imp closed D34977: ada: Retry commands with retries left on CAM_SEL_TIMEOUT.
Sun, May 1, 5:11 PM
imp updated the diff for D35100: stand: Initial kboot support on amd64.

Address the libstand comment.

Sun, May 1, 4:32 PM

Sat, Apr 30

imp committed R10:70b5c4ff4807: stand: Install libsa.3 (authored by imp).
stand: Install libsa.3
Sat, Apr 30, 6:52 PM
imp added a comment to D35102: stand: use snprintf here.

There is this nagging question however - should we check the return value from snprintf (like in this last instance). We do know those strings should fit (normally), but if there is non normal case of memory corruption...

Sat, Apr 30, 2:32 PM
imp committed R10:11f49259c88e: stand: Change libstand.3 to libsa.3 (authored by imp).
stand: Change libstand.3 to libsa.3
Sat, Apr 30, 2:09 PM
imp added a comment to D35102: stand: use snprintf here.

I believe the new code is the same safety as the old if there's no bugs, and safer if there are bugs.
Discuss and/or prove me wrong.

Sat, Apr 30, 2:05 PM
imp added reviewers for D35102: stand: use snprintf here: tsoome, kevans, emaste, cperciva.
Sat, Apr 30, 2:05 PM
imp requested review of D35102: stand: use snprintf here.
Sat, Apr 30, 2:00 PM
imp committed R10:bd001d86d679: stand: s/libstand/libsa/g to catch up with rename (authored by imp).
stand: s/libstand/libsa/g to catch up with rename
Sat, Apr 30, 1:35 PM
imp added reviewers for D35100: stand: Initial kboot support on amd64: kevans, tsoome.
Sat, Apr 30, 1:23 AM
imp requested review of D35100: stand: Initial kboot support on amd64.
Sat, Apr 30, 1:23 AM

Fri, Apr 29

imp added a comment to D31962: linux: For better compatibility, provide compatible endian.h.

unix-linux upstream pull request
https://github.com/util-linux/util-linux/pull/1670

Fri, Apr 29, 10:51 PM
imp added a comment to D31962: linux: For better compatibility, provide compatible endian.h.

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=258544 contains the exp run information.

Fri, Apr 29, 10:51 PM
imp updated the diff for D32051: byteswap.h: Add a glibc/linux compatible byteswap.h.

Update comments from review suggestiosn, and hopefully some additional verbosity
to disambiguate other possible readings not flagged in earlier reviews.

Fri, Apr 29, 10:46 PM

Thu, Apr 28

imp closed D35093: cam_periph: Return ENXIO when peripheral is invalidated.
Thu, Apr 28, 10:31 PM
imp committed R10:9fb40baf6043: cam_periph: Return ENXIO when peripheral is invalidated (authored by imp).
cam_periph: Return ENXIO when peripheral is invalidated
Thu, Apr 28, 10:31 PM
imp closed D35092: mpr/mps: when sending reset on removal, include target in message.
Thu, Apr 28, 10:31 PM
imp committed R10:ca420b4ef2ce: mpr/mps: when sending reset on removal, include target in message (authored by imp).
mpr/mps: when sending reset on removal, include target in message
Thu, Apr 28, 10:31 PM
imp updated the test plan for D35092: mpr/mps: when sending reset on removal, include target in message.
Thu, Apr 28, 8:18 PM
imp updated the summary of D35093: cam_periph: Return ENXIO when peripheral is invalidated.
Thu, Apr 28, 8:12 PM
imp requested review of D35093: cam_periph: Return ENXIO when peripheral is invalidated.
Thu, Apr 28, 7:48 PM
imp requested review of D35092: mpr/mps: when sending reset on removal, include target in message.
Thu, Apr 28, 7:48 PM
imp committed R10:c5041b4ee8c3: mpr/mps: Add comment explaining state transition (authored by imp).
mpr/mps: Add comment explaining state transition
Thu, Apr 28, 5:22 PM

Tue, Apr 26

imp closed D35059: ndaasync: sync to SCSI's daasyncs cam_periph_async() calls.
Tue, Apr 26, 5:02 PM
imp committed R10:e4b1ae214715: ndaasync: sync to SCSI's daasyncs cam_periph_async() calls (authored by imp).
ndaasync: sync to SCSI's daasyncs cam_periph_async() calls
Tue, Apr 26, 5:02 PM
imp closed D35057: adaasync: Harmonize with daasync.
Tue, Apr 26, 5:02 PM
imp committed R10:ae1955cd67c2: adaasync: Harmonize with daasync (authored by imp).
adaasync: Harmonize with daasync
Tue, Apr 26, 5:02 PM
imp added inline comments to D34762: ctld: Fix coverity raised issues.
Tue, Apr 26, 1:18 PM

Mon, Apr 25

imp updated the test plan for D35059: ndaasync: sync to SCSI's daasyncs cam_periph_async() calls.
Mon, Apr 25, 11:41 PM
imp requested review of D35059: ndaasync: sync to SCSI's daasyncs cam_periph_async() calls.
Mon, Apr 25, 11:39 PM
imp updated the diff for D35057: adaasync: Harmonize with daasync.

pivot a little

Mon, Apr 25, 11:36 PM
imp added a comment to D35057: adaasync: Harmonize with daasync.
In D35057#794539, @imp wrote:
In D35057#794531, @mav wrote:

async handlers are called only for the events explicitly specified to xpt_register_async(). As such, every periph driver specifies there AC_LOST_DEVICE, handled by cam_periph_async(). It means every driver has to know what cam_periph_async() can actually handle and how better call it. In such situation "default" case (calling always) can be useful only to not explicitly list new event types sometimes in the future, that may actually be more confusing.

So should I add AC_LOST_DEVICE as an explicit case here? I'm sorry, but I'm having trouble understanding your point...

Mon, Apr 25, 11:36 PM
imp retitled D35057: adaasync: Harmonize with daasync from adaasync: Don't call cam_periph_async when not needed to adaasync: Harmonize with daasync.
Mon, Apr 25, 11:35 PM
imp added a comment to D35038: cam: Small reorg of ata xpt async code.
In D35038#794530, @mav wrote:

Are you going to do the same for SCSI to not diverge them?

Mon, Apr 25, 11:28 PM
imp added a comment to D35057: adaasync: Harmonize with daasync.
In D35057#794531, @mav wrote:

async handlers are called only for the events explicitly specified to xpt_register_async(). As such, every periph driver specifies there AC_LOST_DEVICE, handled by cam_periph_async(). It means every driver has to know what cam_periph_async() can actually handle and how better call it. In such situation "default" case (calling always) can be useful only to not explicitly list new event types sometimes in the future, that may actually be more confusing.

Mon, Apr 25, 11:25 PM
imp committed R10:ccaec73d0b49: ada: Eliminate dead code (authored by imp).
ada: Eliminate dead code
Mon, Apr 25, 6:55 PM
imp committed R10:9d899bbcb788: cam: Small reorg of ata xpt async code (authored by imp).
cam: Small reorg of ata xpt async code
Mon, Apr 25, 6:55 PM
imp closed D35039: ada: Eliminate dead code.
Mon, Apr 25, 6:55 PM
imp closed D35038: cam: Small reorg of ata xpt async code.
Mon, Apr 25, 6:55 PM
imp updated the test plan for D35057: adaasync: Harmonize with daasync.
Mon, Apr 25, 5:11 PM
imp requested review of D35057: adaasync: Harmonize with daasync.
Mon, Apr 25, 5:01 PM
imp added a comment to D35040: ada: create ada_reprobe for common probe starting logic.
In D35040#794429, @mav wrote:

While I see no problem with this patch, I am not sure it is not an obfuscation. The same checks are done (or should be done) at every probe stage. The check seems to be missing on transition from ADA_CCB_RAHEAD to ADA_STATE_WCACHE. I think "goto skipstate" logic of dastart() could be more universal.

Mon, Apr 25, 3:20 PM

Apr 24 2022

imp committed R10:b43cfe717130: ada/da: Borrow comment from nda about cleanup (authored by imp).
ada/da: Borrow comment from nda about cleanup
Apr 24 2022, 9:13 PM
imp committed R10:48ae3f4f64ca: ata/nvme: Add comment (authored by imp).
ata/nvme: Add comment
Apr 24 2022, 9:13 PM
imp closed D35034: g_vfs_done: Only report ENXIO once.
Apr 24 2022, 8:04 PM
imp committed R10:347a8e93fe68: g_vfs_done: Only report ENXIO once (authored by imp).
g_vfs_done: Only report ENXIO once
Apr 24 2022, 8:04 PM
imp closed D35037: g_vfs_done: Report when we switch on ENXIO conversion.
Apr 24 2022, 8:03 PM
imp committed R10:e8827f4094cb: g_vfs_done: Report when we switch on ENXIO conversion (authored by imp).
g_vfs_done: Report when we switch on ENXIO conversion
Apr 24 2022, 8:03 PM
imp closed D35036: geom_vfs: make sc_orphaned and sc_enxio_active bools.
Apr 24 2022, 8:03 PM
imp committed R10:f58385f3daf6: geom_vfs: make sc_orphaned a bool (authored by imp).
geom_vfs: make sc_orphaned a bool
Apr 24 2022, 8:03 PM
imp closed D35035: bio: Add the speedup flags to PRINT_BIO_FLAGS.
Apr 24 2022, 8:03 PM
imp committed R10:965e91950622: bio: Add the speedup flags to PRINT_BIO_FLAGS (authored by imp).
bio: Add the speedup flags to PRINT_BIO_FLAGS
Apr 24 2022, 8:03 PM
imp added a reviewer for D35038: cam: Small reorg of ata xpt async code: mav.
Apr 24 2022, 2:36 AM
imp added a reviewer for D35039: ada: Eliminate dead code: mav.
Apr 24 2022, 2:35 AM