- User Since
- Jun 2 2014, 4:20 PM (272 w, 9 h)
Sun, Aug 18
it looks to my eye that all prior comments had been addressed...
generally I like this. Couple of minor spacing nits, and a question about a possible improper use of KASSERT
Sat, Aug 17
This does what the comment says it does... I'm not qualified too know if that's actually the right thing to do or not.
This is good, and good commit message. V7 was released 40 years ago this past January. It flourished in the late 70s and early 80s as a platform people ported to (I'm aware of maybe a dozen such ports too 4 or 5 different architectures)... then all those ports migrated to System III or System V by maybe 1989 or so. The last time I saw this software pattern was in the mid 90s when I updated the program in question to not do that.... I doubt this code path has been execute in the last decade or two except by pedants testing V7 compatibility.
Fri, Aug 16
kill them with fire :)
Ah, I see where it's used now. There are several alternatives, but this is the least bad one that comes to mind.
We have a little bit of dead code vs having #ifdefs for FDT in usb_ethernet.c.
It's more modular to have it like this, so I'm cool with it.
looks fine as far as it goes, but what's including this? usb_ethernet.c certainly needs miibus too compile...
looks great to me.
ah, enough searching and I see that it is.
well, it could be in the files, but it's unambiguous enough. I assume this is how it is upstream?
This detached license is basically required since bdf files don't have a good way to add it.
I'd personally rather see us bring back something from the past . We had WITH_CLANG_AS_CC which controlled creating cc->clang links. What if we had WITH_CLANG_LINKS or similar that would create clang->cc links and have it default to off? This isn't blocking if there's no support for it, though. I didn't click request changes for this :).
I think this is fine.... Not 100% sure, but I think we'll be good. The time may be here to always link in libsa.a, but if you don't *NEED* that, then let's not go there yet. the day will come though...
OK. Not really worth optimizing then. Thanks for the feedback.
Seems sane enough...
Thu, Aug 15
had the same thing in mind
Wed, Aug 14
Tue, Aug 13
P,S, I don't know the clicky button to say this is no longer blocked by core@, so don't let that stop you from committing it.
Alternatively, you could add a explicit reference to the location of the license file in FreeBSD's repo in the .c and .h. That would be fine enough.
time to go... but need to remove from files and double check to make sure there's no lingering man page Xr's.
minor comment fixing.
Mon, Aug 12
Combine and rebase
Per jhb suggestion, combining with https://reviews.freebsd.org/D21233
Update to use include more directly, per jhb
update per jhb's suggestions
These are fine but (a) you need to have mount privs to execute this ioctl; (b) nandfs is a panic trap due to bad locking and the system can't stay up once there's any vnode pressure at all; and (c) the set of nandfs users is the empty set due to (b). This is not exploitable in any meaningful way.
Sat, Aug 10
This commit is purposely thin to get the framework up and going so we can focus on framework issues.
changes per jhb review, except the ifdef x86 in makeLINT.mk
And also https://reviews.freebsd.org/D21208
See follow on review https://reviews.freebsd.org/D21207
I think these are good. There's comments in the Linux emulator that says they do different things because of this ifdef: