- User Since
- Jun 2 2014, 4:20 PM (235 w, 6 d)
Sat, Dec 8
Fri, Dec 7
Thu, Dec 6
updates per cem@
Wed, Dec 5
Tue, Dec 4
Update the pacing base that Kirk sent me to cope better with multiple workers.
Mon, Dec 3
I looked at this on my phone a few days ago and meant to stamp it with LGTM when I got back to my computer, but that fell through the cracks.
The code seems fine, other than the weird msi_tupelo which randomly seems to be the same as msi_enabled, but only some of the time. A comment is needed to explain why the oddity.
Sun, Dec 2
I'll do the ones I marked and call it good and do round 2 for the const changes and the dlopen feature.
I've updated to be close to the end game. All that remains is readdir(/libexec/nvmecontrol and /usr/local/libexec/nvmecontrol) for all the .so's at startup and we'll be to the point where Netflix can deploy the Sekret Soss modules we have from Vendor X w/o changing base or polluting base with NDA material.
Lots of cleanup, will be separate commits
Thanks for the feedback. I'll see how much I can include in my next round as some of them are asking for more structural changes beyond the scope of this set of changes (the suggestions are good, btw, just am keen to avoid too much scope creep).
Sat, Dec 1
There's a suggestion that the new trim program be named 'discard' to match linux's discard option on mount. Perhaps discard would be a better name. Though I hesitate to make such a bike-sheddy suggestion.
I'm pissed this was committed. It wasn't ready and in total breach of protocol.
This matter is *NOT* settled and you're lucky I don't just remove it from the tree.
Fri, Nov 30
Couple of minor nits, but otherwise looks OK.
My acceptance is provisional here.
Thu, Nov 29
I like this, independent of a standalone utility.
Wed, Nov 28
a quick scan doesn't reveal anything major.
First pass at turning off write limiting when in speedup mode.
OK. I've updated this in a few ways:
Update based on Kirk's comments and some thinking about the problem.
Fold Kirk's suggestions in, but only his diff, not the one to remove one of my calls.
Kirk sent me this (patch has been removed, but integrated into next update, but I've not yet internalized it enough to comment tonight):
Tue, Nov 27
Again with the changes, this time including all the changes.
Mon, Nov 26
Thu, Nov 22
Tue, Nov 20
updated with kasserts enabled as much as I can...
KASSERT where possible...
Mon, Nov 19
OK. I think that some of the other ways to spell stuff may be more obscure.
Fri, Nov 16
This was committed a long time ago...
I don't think we need email= anymore.