- User Since
- Jun 2 2014, 4:20 PM (329 w, 4 d)
put nullability macro outside kernel ifdefs
This revision successfully builds and reboots, so I think it's right But since it's systm.h and we do some funky monkey business in there, I'd like more eyes on it to be sure.
Wed, Sep 23
btw, the rest of the changes look totally fine. Sorry to be so nitpicky over this one...
Tue, Sep 22
Mon, Sep 21
This review is missing a lot of files (even prior versions). rtsx.c at the very least is missing
Does this driver support MMCCAM?
Non pmc bits look good to go
Thu, Sep 17
Will this screw up the tracebacks? One of the reason that I've compiled at lower O levels is to not have @#^#$Y up DEBUG kernels...
Wed, Sep 16
Another round of comment cleanup to make things more descriptive and less verbose.
Update some comments.
Fold in feedback from MarkJ
Why do we install libgcc_s multiple times?
Tue, Sep 15
Fix comment and silly lack of assignment. Tiny style tweaks too.
Mon, Sep 14
Add comment documenting why we only conditionally install bootx64.efi
Looks good to me. I'd be tempted to commit the kernel and non-kernel parts separately since the kernel bits aren't directly related to the firmware downloading change, but merely facilitate it (and possibly other) uses.
Sat, Sep 12
I think this is fine
Fri, Sep 11
I think this is good. There's many other strings we might consider for the reset, but this is good.
I'm happy now. Thanks for listening to my feedback.
Thu, Sep 10
Minor nit, which could report a bad write total in some rare circumstances is the only issue I see.