Feed Advanced Search

Yesterday

imp added a comment to D13942: stand: Move sections around to fix stand/ build with ld.lld on armv7.

that's seriously AFU boot order.

Wed, Jan 17, 10:39 PM
imp accepted D13959: Convert ls(1) to not use libxo(3)..

My only regret is that phab won't let me click accept twice.

Wed, Jan 17, 10:34 PM
imp added a comment to D13306: Allow compiling usr.bin/find on Linux and Mac.

This is fine, but I'd like to see us centralize these things so each new tool is easier not a reinvent from scratch effort. libegacy is the right place for this, since we already in place for dealing with older build hosts.

Wed, Jan 17, 10:33 PM
imp accepted D13761: sysutils/dtc: Update to 1.4.6 and add test support.
Wed, Jan 17, 8:40 PM
imp committed rS328089: Move setting of CAM_SIM_QUEUED to before we actually submit it to the.
Move setting of CAM_SIM_QUEUED to before we actually submit it to the
Wed, Jan 17, 5:08 PM
imp accepted D13948: PPC: machdep, zero BSS always but BookE.
Wed, Jan 17, 2:37 PM
imp added a comment to D13942: stand: Move sections around to fix stand/ build with ld.lld on armv7.

Aside: I don't have any armv7 EFI stuff to test boot with, so coverage for that change is lacking. I also haven't checked that that change still builds with ld.bfd, but I have no reason to think it wouldn't.

There is nanobsd support to build for qemu which uses EFI. There is a config file in tools/tools/nanobsd/embedded/qemu-armv7.cfg, however it will need to be updated as it doesn't know about TARGET_ARCH=armv7.

Wed, Jan 17, 2:34 PM
imp added inline comments to D13911: `make buildworld' should display the build time in seconds.
Wed, Jan 17, 2:26 PM · Contributor Reviews (base)
imp added a comment to D13911: `make buildworld' should display the build time in seconds.

This looks good to my eye, modulo some nits. I'd let Bryan have the final say, but commit it if he says nothing.

Wed, Jan 17, 2:25 PM · Contributor Reviews (base)
imp added inline comments to D13931: Implement mitigation for Spectre Version 2 attacks on ARMv7..
Wed, Jan 17, 2:23 PM

Tue, Jan 16

imp accepted D13942: stand: Move sections around to fix stand/ build with ld.lld on armv7.

Seems reasonable, but I don't completely understand these goofy things
\

Tue, Jan 16, 10:50 PM
imp added a comment to D13940: Bug 225159 - `make installkernel’ should display a “completed” message if done.
In D13940#292367, @cem wrote:

I'd like to see someone with make/build experience review this (Bryan?) but assuming they approve it, I approve it.

Tue, Jan 16, 10:48 PM
imp added a comment to D13307: Allow xinstall and makefs to be crossbuilt on Linux and Mac.
In D13307#292355, @imp wrote:

Why not the less ugly #ifdef UF_SETTABLE?

you wouldn't need the nbtool junk either.

I didn't know there was a macro I could check that works across operating systems to check for st_flags availability. It seems like macOS has the UF_SETTABLE in sys/stat.h and Linux doesn't so I could remove the nbtool changes. I'll post a follow up patch tomorrow.

Tue, Jan 16, 10:32 PM
imp added inline comments to D13941: stand: use -z norelro when linking EFI components.
Tue, Jan 16, 10:03 PM
imp added a comment to D13307: Allow xinstall and makefs to be crossbuilt on Linux and Mac.

Why not the less ugly #ifdef UF_SETTABLE?

Tue, Jan 16, 9:55 PM
imp accepted D13933: utf8_to_ucs2() should check for malloc failure.

Wow! How'd that get left out...
]

Tue, Jan 16, 4:19 PM
imp added a comment to D13931: Implement mitigation for Spectre Version 2 attacks on ARMv7..

Looks good to me, modulo one real problem that likely is a stray line noted in the assembler. Most of my concerns are questions and helping me connect all the dots that I have.

Tue, Jan 16, 4:18 PM
imp created D13929: Simplify suspend / resume timekeeping stuff..
Tue, Jan 16, 2:30 AM

Mon, Jan 15

imp committed rS328031: Need to free uv after we're done using it..
Need to free uv after we're done using it.
Mon, Jan 15, 10:17 PM
imp committed rS328030: Check the return value from utf8_to_ucs2 instead of whether or not uv.
Check the return value from utf8_to_ucs2 instead of whether or not uv
Mon, Jan 15, 10:17 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Mon, Jan 15, 10:17 PM
imp closed D13917: When returning an error and freeing allocated memory from ucs2_to_utf8 and utf8_to_ucs2, be sure to NULL out the return pointer too, rather than return a pointer to free memory..
Mon, Jan 15, 10:17 PM
imp committed rS328029: When returning an error and freeing allocated memory from ucs2_to_utf8.
When returning an error and freeing allocated memory from ucs2_to_utf8
Mon, Jan 15, 10:17 PM
imp added inline comments to D13918: Check the return value from utf8_to_ucs2 instead of whether or not uv is NULL. That's more correct and doesn't depend on the error behavior of utf8_to_ucs2. In practice, we'll never see this though since we pass utf8_to_ucs2 a well formed string..
Mon, Jan 15, 10:09 PM
imp added reviewers for D13918: Check the return value from utf8_to_ucs2 instead of whether or not uv is NULL. That's more correct and doesn't depend on the error behavior of utf8_to_ucs2. In practice, we'll never see this though since we pass utf8_to_ucs2 a well formed string.: andrew, tsoome.
Mon, Jan 15, 5:03 PM
imp created D13918: Check the return value from utf8_to_ucs2 instead of whether or not uv is NULL. That's more correct and doesn't depend on the error behavior of utf8_to_ucs2. In practice, we'll never see this though since we pass utf8_to_ucs2 a well formed string..
Mon, Jan 15, 5:03 PM
imp added a comment to D13915: Fix booting on arm64.

See also https://reviews.freebsd.org/D13917, but I think checking the return values is better in both places.

Mon, Jan 15, 4:34 PM
imp added reviewers for D13917: When returning an error and freeing allocated memory from ucs2_to_utf8 and utf8_to_ucs2, be sure to NULL out the return pointer too, rather than return a pointer to free memory.: andrew, tsoome.
Mon, Jan 15, 4:34 PM
imp created D13917: When returning an error and freeing allocated memory from ucs2_to_utf8 and utf8_to_ucs2, be sure to NULL out the return pointer too, rather than return a pointer to free memory..
Mon, Jan 15, 4:33 PM
imp added inline comments to D13915: Fix booting on arm64.
Mon, Jan 15, 4:28 PM
imp added inline comments to D13916: Add big-endian support to NVMe.
Mon, Jan 15, 4:20 PM
imp requested changes to D13916: Add big-endian support to NVMe.

Shouldn't all this endian flipping be done in bus space?

Mon, Jan 15, 4:15 PM
imp accepted D13915: Fix booting on arm64.
Mon, Jan 15, 3:49 PM

Sun, Jan 14

This revision was not accepted when it landed; it landed in state Needs Review.
Sun, Jan 14, 4:55 PM
imp committed rS327970: Report CG checksum mismatches. These errors are non-fatal. The.
Report CG checksum mismatches. These errors are non-fatal. The
Sun, Jan 14, 4:55 PM

Fri, Jan 12

imp committed rS327881: Allow this file to be included.
Allow this file to be included
Fri, Jan 12, 5:22 PM
imp committed rS327880: Move getsecs() prototype to stand.h from net.h so it can be used.
Move getsecs() prototype to stand.h from net.h so it can be used
Fri, Jan 12, 4:29 PM
imp added inline comments to D13884: Report CG checksum mismatches..
Fri, Jan 12, 3:48 PM
imp added reviewers for D13884: Report CG checksum mismatches.: mckusick, emaste, kib, scottl.
Fri, Jan 12, 3:43 PM
imp created D13884: Report CG checksum mismatches..
Fri, Jan 12, 3:42 PM
imp committed rS327879: Report the boot order and where we are in that boot order. Add.
Report the boot order and where we are in that boot order. Add
Fri, Jan 12, 3:31 PM
imp committed rS327878: Add GUID for UEFI boot manager variables..
Add GUID for UEFI boot manager variables.
Fri, Jan 12, 3:31 PM
imp committed rS327877: Fix error in determining the next available boot slot..
Fix error in determining the next available boot slot.
Fri, Jan 12, 3:31 PM

Thu, Jan 11

imp added inline comments to D13784: Make loader.efi dual boot, step 1.
Thu, Jan 11, 9:37 PM
imp added a comment to D13868: Use XPT_GET_ADVINFO for retrieving MMC params.

This looks good to me, modulo my one question...
I'll test it out shortly.

Thu, Jan 11, 6:23 PM
imp committed rS327805: When we crash, we'll stop the scheduler before we call the.
When we crash, we'll stop the scheduler before we call the
Thu, Jan 11, 3:11 AM

Wed, Jan 10

imp added reviewers for D13845: Don't hang on crashes with dumps to ada devices.: markj, scottl.
Wed, Jan 10, 11:05 PM
imp created D13845: Don't hang on crashes with dumps to ada devices..
Wed, Jan 10, 11:05 PM
imp accepted D13830: Set the 'FR' bit in the status register for N32 kernels..

lgtm

Wed, Jan 10, 7:46 PM
imp added inline comments to D13827: Enable ld.lld as bootstrap linker by default on amd64.
Wed, Jan 10, 6:09 PM
imp committed rS327774: inittodr(0) actually sets the time, so there's no need to call.
inittodr(0) actually sets the time, so there's no need to call
Wed, Jan 10, 5:25 PM
imp committed rS327773: Catchup to removing this directory.
Catchup to removing this directory
Wed, Jan 10, 4:56 PM
imp committed rS327772: Docuent pmtimer driver removal..
Docuent pmtimer driver removal.
Wed, Jan 10, 4:52 PM
imp committed rS327771: Move prof_machdep.c to it's more traditional place under i386/i386..
Move prof_machdep.c to it's more traditional place under i386/i386.
Wed, Jan 10, 4:52 PM
imp committed rS327767: Retire pmtimer driver. Move time fixing into apm driver. Move.
Retire pmtimer driver. Move time fixing into apm driver. Move
Wed, Jan 10, 2:59 PM
imp closed D13823: Retire pmtimer driver..
Wed, Jan 10, 2:59 PM
imp committed rS327766: Remove vestiges of digi(4) driver, first attempted in r305235 with.
Remove vestiges of digi(4) driver, first attempted in r305235 with
Wed, Jan 10, 2:59 PM
imp added inline comments to D13823: Retire pmtimer driver..
Wed, Jan 10, 6:36 AM
imp updated the test plan for D13823: Retire pmtimer driver..
Wed, Jan 10, 6:34 AM
imp updated the diff for D13823: Retire pmtimer driver..

Compile it!

Wed, Jan 10, 6:29 AM
imp updated the diff for D13823: Retire pmtimer driver..

remove from generic, notes

Wed, Jan 10, 6:22 AM
imp created D13823: Retire pmtimer driver..
Wed, Jan 10, 6:18 AM
imp updated the diff for D13818: Create deprecation management functions..

Tag drivers

Wed, Jan 10, 4:34 AM
imp created D13818: Create deprecation management functions..
Wed, Jan 10, 12:59 AM

Tue, Jan 9

imp accepted D13815: sysutils/devcpu-data Update Intel Microcode release to 20180108.
Tue, Jan 9, 8:29 PM
imp committed rS327731: Consolidate two identical copies of sysres_ids..
Consolidate two identical copies of sysres_ids.
Tue, Jan 9, 4:42 PM
imp committed rS327729: Remove ccbque.h from i386/isa..
Remove ccbque.h from i386/isa.
Tue, Jan 9, 4:11 PM
imp added inline comments to D13672: Inline ccbque.h into scsi_low.h and delete from i386/isa..
Tue, Jan 9, 4:04 PM
imp accepted D13799: Do not build lint(1) by default on stable-11, add WITH_LINT to enable building it..
In D13799#289417, @ian wrote:

lint could be treated as a bootstrap tool to fix the build problem. What that provide, that this change doesn't, is a broken version of lint (it has been broken for 3 years) which can't really be used for anything other than making the build complete without errors.

Tue, Jan 9, 3:50 PM

Mon, Jan 8

imp added a comment to D13797: PTI for amd64..
In D13797#289013, @cem wrote:
In D13797#289001, @imp wrote:

PTI means what?

Page Table Isolation.

Mon, Jan 8, 5:45 PM
imp added a comment to D13797: PTI for amd64..

PTI means what?
Also, looks like this is unconditionally enabled unless the tunable is false. There's talk of doing things automatically based on CPU type and vendor elsewhere.
Finally, there's a lot of churn in this patch that could be a separate commit. I'd normally suggest that, but given the time sensitive nature of things and the need to later back-port, I'm going to note it and suggest you ignore such requests if they are made by others.

Mon, Jan 8, 5:31 PM

Sun, Jan 7

imp updated the diff for D13784: Make loader.efi dual boot, step 1.

-2 now means always break to OK in case of failure. -1 means never
break. 0 means poll once and > 0 means wait up to that many seconds
for a key stroke.

Sun, Jan 7, 12:32 AM

Sat, Jan 6

imp updated the diff for D13784: Make loader.efi dual boot, step 1.

Update to actually implement timeout.

Sat, Jan 6, 7:15 PM
imp added a comment to D13784: Make loader.efi dual boot, step 1.
In D13784#288697, @cem wrote:

What's dual boot mean in this context? Thanks.

Sat, Jan 6, 6:38 PM
imp added a reviewer for D13784: Make loader.efi dual boot, step 1: tsoome.
Sat, Jan 6, 5:26 PM
imp created D13784: Make loader.efi dual boot, step 1.
Sat, Jan 6, 5:26 PM
imp committed rS327619: The source strings are from the password database which guarantees.
The source strings are from the password database which guarantees
Sat, Jan 6, 12:46 PM
imp committed rS327618: Sanity check sysconf return value to ensure it's positive before we.
Sanity check sysconf return value to ensure it's positive before we
Sat, Jan 6, 12:46 PM
imp committed rS327617: Sanity check media size and sector counts to ensure that we don't.
Sanity check media size and sector counts to ensure that we don't
Sat, Jan 6, 12:34 PM
imp committed rS327612: Invent new #defines for the biospci_{read,write}_config function to.
Invent new #defines for the biospci_{read,write}_config function to
Sat, Jan 6, 6:01 AM
imp committed rS327611: There's no need / benefit from deleting the variable before we set it..
There's no need / benefit from deleting the variable before we set it.
Sat, Jan 6, 6:00 AM
imp committed rS327610: Fix usage strings. -d and -p were removed before this was committed to.
Fix usage strings. -d and -p were removed before this was committed to
Sat, Jan 6, 6:00 AM

Fri, Jan 5

imp added a comment to D13776: Handle misconfigured/noexistent pcidev for comconsole instead of BTX panic.

Ah, looking at the biospci_read_config code I see that its 0 for 1 byte, 1 for 2 bytes, 2 for 4 bytes based on the opcode sent to the BIOS. n/m about that question.

Fri, Jan 5, 10:37 PM
imp added a comment to D13776: Handle misconfigured/noexistent pcidev for comconsole instead of BTX panic.
In D13776#288529, @jhb wrote:

biospci_readconfig() doesn't look for a matching entry, it just invokes a BIOS routine that probably just translates the register arguments into the right values for writing to 0xcf8 and reading from 0xcfc.

Fri, Jan 5, 10:28 PM
imp accepted D13776: Handle misconfigured/noexistent pcidev for comconsole instead of BTX panic.

Looks good to me.

Fri, Jan 5, 8:25 PM
imp accepted D13776: Handle misconfigured/noexistent pcidev for comconsole instead of BTX panic.
Fri, Jan 5, 7:24 PM
imp committed rS327581: Remove dead code (comma is either 0 or 1 for sure, no need to test)..
Remove dead code (comma is either 0 or 1 for sure, no need to test).
Fri, Jan 5, 7:29 AM
imp committed rS327580: bits is never null when we call ot. Add an assert to that effect and.
bits is never null when we call ot. Add an assert to that effect and
Fri, Jan 5, 7:29 AM
imp committed rS327579: Tag 'a' case as one we're intentionally falling through to.
Tag 'a' case as one we're intentionally falling through to
Fri, Jan 5, 7:28 AM
imp committed rS327576: Add a number of sanity checks to the data that we're handling from the.
Add a number of sanity checks to the data that we're handling from the
Fri, Jan 5, 7:09 AM
imp committed rS327575: Need to convert '/' back to '\' when creating a path. Ideally, this.
Need to convert '/' back to '\' when creating a path. Ideally, this
Fri, Jan 5, 7:09 AM
imp committed rS327574: Set dp to NULL when we free it, and tree a NULL dp as an error.
Set dp to NULL when we free it, and tree a NULL dp as an error
Fri, Jan 5, 7:09 AM
imp committed rS327573: Free options before setting them. This will prevent us from leaking.
Free options before setting them. This will prevent us from leaking
Fri, Jan 5, 7:09 AM
imp committed rS327572: Ensure that we have a description string. When unspecified, default to ""..
Ensure that we have a description string. When unspecified, default to "".
Fri, Jan 5, 7:09 AM
imp committed rS327571: Don't close fd twice. This line should have been deleted in r327279..
Don't close fd twice. This line should have been deleted in r327279.
Fri, Jan 5, 5:34 AM
imp committed rS327570: Only call close if fd and fd1 are not -1..
Only call close if fd and fd1 are not -1.
Fri, Jan 5, 5:34 AM
imp committed rS327569: Fix cut and paste error from devinfo.8 origin of this file.
Fix cut and paste error from devinfo.8 origin of this file
Fri, Jan 5, 5:02 AM

Thu, Jan 4

imp accepted D13770: Make it possible to re-evaluate cpu_features..

Looks good to me...

Thu, Jan 4, 10:55 PM
imp committed rD51364: Add news blurb about the micro-architecture attacks driven by.
Add news blurb about the micro-architecture attacks driven by
Thu, Jan 4, 5:50 PM
imp accepted D13766: Introduce mallocarray() in the kernel.

I like this.

Thu, Jan 4, 4:31 PM