Feed Advanced Search

Today

imp added inline comments to D15983: convert EBR like barrier to epoch(9).
Sun, Jun 24, 12:27 AM

Yesterday

imp added inline comments to D15978: Add PNP info to PCI attachment of et driver.
Sat, Jun 23, 2:24 PM

Thu, Jun 21

imp accepted D15858: Fix output of linprocfs stat entry.
Thu, Jun 21, 10:45 PM
imp accepted D15952: Fix the Linux kernel version number calculation.
Thu, Jun 21, 10:44 PM

Wed, Jun 20

imp added inline comments to D15917: uefi stand: Guess the console better.
Wed, Jun 20, 7:41 PM
imp added inline comments to D15917: uefi stand: Guess the console better.
Wed, Jun 20, 2:18 PM
imp updated the diff for D15917: uefi stand: Guess the console better.

better

Wed, Jun 20, 4:50 AM
imp added inline comments to D15917: uefi stand: Guess the console better.
Wed, Jun 20, 12:59 AM
imp added a reviewer for D15917: uefi stand: Guess the console better: kevans.
Wed, Jun 20, 12:37 AM
imp added reviewers for D15917: uefi stand: Guess the console better: emaste, tsoome, jhb, allanjude.
Wed, Jun 20, 12:37 AM
imp created D15917: uefi stand: Guess the console better.
Wed, Jun 20, 12:35 AM

Tue, Jun 19

imp committed rS335388: Fix typo noticed by pstef@..
Fix typo noticed by pstef@.
Tue, Jun 19, 9:58 PM
imp added a comment to D15891: Add MMCCAM support to AllWinner MMC driver.

Please do mention in the commit message that MMCCAM is not usable on Allwinner boards using root-on-MMC to curtail that set of complaints if people actually try it.

Tue, Jun 19, 7:47 PM
imp accepted D15211: Add uefisign and friends to MK_EFI.
Tue, Jun 19, 7:10 PM
imp accepted D13063: Fix setting RCA for MMC cards.

Add the comment and this will be sufficient for now.

Tue, Jun 19, 3:35 PM
imp committed rS335350: Add my script for coping with git-svn and the need to rebase.
Add my script for coping with git-svn and the need to rebase
Tue, Jun 19, 12:27 AM

Mon, Jun 18

imp committed rS335349: Switch to creating UEFI ESPs using loader.efi instead of boot1.efi..
Switch to creating UEFI ESPs using loader.efi instead of boot1.efi.
Mon, Jun 18, 11:17 PM
imp accepted D15889: Correctly define rawscr so initializing it doesn't result in overwriting memory..
Mon, Jun 18, 9:39 PM
imp accepted D15888: Set MMC_DATA_MULTI flag when doing multi-block transfers.
Mon, Jun 18, 9:38 PM
imp accepted D15891: Add MMCCAM support to AllWinner MMC driver.

Seems fine to me.

Mon, Jun 18, 9:37 PM
imp accepted D15890: Don't try to turn power down MMC bus if it is already down.
Mon, Jun 18, 9:36 PM
imp committed rS335337: Remove stray debugging line..
Remove stray debugging line.
Mon, Jun 18, 7:53 PM
imp committed rS335336: Remove now-empty geli directory.
Remove now-empty geli directory
Mon, Jun 18, 7:42 PM
imp accepted D15884: u-boot-: Switch to uboot@FreeBSD.Org for the maintainer.

These all look good. Maybe consider MAINTAINER?= uboot@freebsd.org in the master file?

Mon, Jun 18, 7:36 PM
imp accepted D15885: u-boot-riotboard: Add port for this board.

mechanically, this looks good to me.

Mon, Jun 18, 7:28 PM
imp committed rS335321: stand: move libgeliboot into libsa..
stand: move libgeliboot into libsa.
Mon, Jun 18, 4:24 PM

Sun, Jun 17

imp accepted D15847: stand/common/disk.c: Read the partition table relative to the start of the drive.
Sun, Jun 17, 5:10 AM
imp accepted D15862: gptboot, zfsboot, gptzfsboot: Enable the video and serial consoles early.

I'd reword the commit message.
You are really enabling serial and video early...

Sun, Jun 17, 2:58 AM
imp committed rS335274: FreeBSD/amd64 requires 256MiB to boot UEFI, 128MB simply doesn't work..
FreeBSD/amd64 requires 256MiB to boot UEFI, 128MB simply doesn't work.
Sun, Jun 17, 2:49 AM
imp committed rS335272: Many netboot scenarios don't have /boot/defaults/loader.conf. As.
Many netboot scenarios don't have /boot/defaults/loader.conf. As
Sun, Jun 17, 1:27 AM

Sat, Jun 16

imp added a comment to D15847: stand/common/disk.c: Read the partition table relative to the start of the drive.

I'm leery of committing 'I'm not sure why, but this seems to make it work' kind of code.

Sat, Jun 16, 1:40 PM
imp accepted D15846: rootgen.sh: complete all profiles except GELI+MBR (not supported).

Seems good to me...

Sat, Jun 16, 1:37 PM
imp accepted D15844: Avoid reading past the end of the disk in zfsboot.c and biosdisk.c.

Are there other disks that we should give this treatment to? Like all of them?

Sat, Jun 16, 1:36 PM
imp accepted D15839: Correct logic error.

Yes sir! We have a winner!

Sat, Jun 16, 2:46 AM

Fri, Jun 15

imp added a comment to D15746: Fix build of ndis with base gcc on i386.

ref: https://c9x.me/x86/html/file_module_x86_id_139.html
DX is used here, not EDX, for the I/O port giving a range of 0..65,535
Even though you can do 32-bit I/O to a port, the range of the ports is limited to 16-bits.

Fri, Jun 15, 10:02 PM
imp accepted D15746: Fix build of ndis with base gcc on i386.

This is fine.
On x86, the resource I/O port is < 64k. the (void *) is to keep the compiler happy and is a bit of type-punning that the NDIS interface forces upon the user.

Fri, Jun 15, 10:00 PM
imp abandoned D14295: Add Lua as a scripting langauge to /boot/loader.

this was committed

Fri, Jun 15, 9:50 PM
imp accepted D15831: Clean up the vcs ID strings in libc's gen/ directory..

thanks for doing this largely thankless task.
#ifdef link -= 1000 because of it.

Fri, Jun 15, 7:11 PM
imp committed rS335231: There's no need to walk through the tables looking for the smbios.
There's no need to walk through the tables looking for the smbios
Fri, Jun 15, 7:07 PM
imp committed rS335230: Move arg parsing into its own routine for possible later reuse..
Move arg parsing into its own routine for possible later reuse.
Fri, Jun 15, 7:07 PM
imp committed rS335229: Provide a more direct interface to tell ZFS what the preferred handle.
Provide a more direct interface to tell ZFS what the preferred handle
Fri, Jun 15, 7:07 PM
imp committed rS335228: Migrate has_keyboard to bool..
Migrate has_keyboard to bool.
Fri, Jun 15, 7:07 PM
imp committed rS335224: Remove empty directory.
Remove empty directory
Fri, Jun 15, 6:46 PM
imp added a comment to D15207: loader: zfs reader must use uint64_t instead of off_t.
In D15207#334555, @imp wrote:

I don't like this change at all. There's no practical difference, and this diverges us from the normal unix APIs.

there is a problem - zfs is *not* written to use "normal" unix API's. at all. So what we have is the code where unsigned type is swapped to signed and there are virtually no checks against sign wraps, overflows etc. Of course part of the issue is that there is no unsigned off_t and there is always the confusion how many bits that particular type has...

Fri, Jun 15, 4:20 PM
imp added a comment to D15207: loader: zfs reader must use uint64_t instead of off_t.

I don't like this change at all. There's no practical difference, and this diverges us from the normal unix APIs.

Fri, Jun 15, 2:16 PM

Thu, Jun 14

imp accepted D15802: Permit the kernel environment to set an array of numeric values for a single sysctl(9) node..

I think this is good. I'm a little hesitant about the suffix part of it, but know of no good way to flag it's acceptance (I know of several ways, they are all complex and error-prone though).
so, I'd feel better with someone else also blessed the change.

Thu, Jun 14, 2:14 PM
imp accepted D14279: fixed amd type flash write opration and diaplay chip infomation at boot.

I think this looks good now.

Thu, Jun 14, 1:53 PM
imp committed rS335117: bootprog_info is generated in vers.c. Move it's definition to.
bootprog_info is generated in vers.c. Move it's definition to
Thu, Jun 14, 6:41 AM
imp committed rS335116: Use bool for vargood, since it's a boolean..
Use bool for vargood, since it's a boolean.
Thu, Jun 14, 6:41 AM
imp committed rS335110: Remove redundant defs.mk includes. They aren't needed..
Remove redundant defs.mk includes. They aren't needed.
Thu, Jun 14, 6:15 AM
imp committed rS335101: NVME support is only for x86 and powerpc64..
NVME support is only for x86 and powerpc64.
Thu, Jun 14, 1:15 AM

Wed, Jun 13

imp added a comment to D15583: Mmap device BAR into userspace..

this got lost in my todo inbox. sorry for my delay.

Wed, Jun 13, 11:06 PM
imp committed rS335092: Make camcontrol identify work with nda devices.
Make camcontrol identify work with nda devices
Wed, Jun 13, 10:00 PM
imp committed rS335091: Make it possible to use print_controller from another program.
Make it possible to use print_controller from another program
Wed, Jun 13, 10:00 PM
imp closed D15371: Make camcontrol identify work with nda devices.
Wed, Jun 13, 10:00 PM
imp committed rS335086: Add PNP info to PCI attachment of ae driver.
Add PNP info to PCI attachment of ae driver
Wed, Jun 13, 8:25 PM
imp committed rS335085: Add PNP info to PCI attachments of age driver.
Add PNP info to PCI attachments of age driver
Wed, Jun 13, 8:25 PM
imp committed rS335084: Add PNP info to PCI attachment of amr driver.
Add PNP info to PCI attachment of amr driver
Wed, Jun 13, 8:25 PM
imp committed rS335083: Add PNP info to PCI attachment of ale driver.
Add PNP info to PCI attachment of ale driver
Wed, Jun 13, 8:25 PM
imp committed rS335082: Add PNP info to PCI attachment of bwi driver.
Add PNP info to PCI attachment of bwi driver
Wed, Jun 13, 8:25 PM
imp committed rS335081: Add PNP info to PCI attachment of bwn driver.
Add PNP info to PCI attachment of bwn driver
Wed, Jun 13, 8:25 PM
imp committed rS335080: Add PNP info to PCI attachment of an driver.
Add PNP info to PCI attachment of an driver
Wed, Jun 13, 8:25 PM
imp committed rS335079: Add PNP info to the PCI attachment of the ahci driver.
Add PNP info to the PCI attachment of the ahci driver
Wed, Jun 13, 8:25 PM
imp committed rS335078: Add PNP info to the PCI attachment of the aacraid driver..
Add PNP info to the PCI attachment of the aacraid driver.
Wed, Jun 13, 8:25 PM
imp committed rS335077: Add PNP info to the PCI attachment of the ncr driver..
Add PNP info to the PCI attachment of the ncr driver.
Wed, Jun 13, 8:25 PM
imp accepted D15579: Exit with an error if a linker hints file can't be found..
Wed, Jun 13, 7:09 PM
imp committed rS335071: Initialize variables we later free so they aren't used.
Initialize variables we later free so they aren't used
Wed, Jun 13, 5:43 PM
imp committed rS335070: Remove unused variables..
Remove unused variables.
Wed, Jun 13, 5:43 PM
imp committed rS335069: Remove fail: label. It's unused..
Remove fail: label. It's unused.
Wed, Jun 13, 5:28 PM
imp committed rS335066: Implement a 'car limit' for bioq..
Implement a 'car limit' for bioq.
Wed, Jun 13, 4:48 PM
imp added inline comments to D15743: Extend loader(8) geli support to all architectures and all disk-like devices..
Wed, Jun 13, 3:40 PM
imp committed rS335029: Use "$@" instead of $* to cope with parameters that have spaces in.
Use "$@" instead of $* to cope with parameters that have spaces in
Wed, Jun 13, 6:11 AM
imp closed D15784: Use "$@" instead of $* to cope with parameters that have spaces in them..
Wed, Jun 13, 6:11 AM
imp created D15784: Use "$@" instead of $* to cope with parameters that have spaces in them..
Wed, Jun 13, 4:26 AM
imp accepted D15563: Add linprocfs support for min_free_kbytes.
Wed, Jun 13, 2:05 AM ยท Linux Emulation

Tue, Jun 12

imp accepted D15770: simplebus pnp: Do not generate pnp info is the bus status is not okay.

This is somewhat a dangerous change. However, it's the best change we can have given our current use of ofs_bus_status_okay().

Tue, Jun 12, 7:53 PM

Mon, Jun 11

imp committed rS334982: User service foo rather than /etc/rc.d/foo..
User service foo rather than /etc/rc.d/foo.
Mon, Jun 11, 10:48 PM
imp added a comment to D15764: Fix da(4) probe locking problems..

try 'camcontrol rescan all'. That's the usual case that breaks locking :(

Mon, Jun 11, 8:44 PM
imp committed rS334980: Revert size limits..
Revert size limits.
Mon, Jun 11, 8:38 PM
imp committed rS334979: Fix a bug in the counting of blks..
Fix a bug in the counting of blks.
Mon, Jun 11, 8:38 PM
imp committed rS334974: Don't initialize c_count. We don't need to..
Don't initialize c_count. We don't need to.
Mon, Jun 11, 7:35 PM
imp committed rS334972: Minor style polishing..
Minor style polishing.
Mon, Jun 11, 7:33 PM
imp committed rS334970: Document the dump issue in UPDATING so people understand when they.
Document the dump issue in UPDATING so people understand when they
Mon, Jun 11, 7:32 PM
imp committed rS334971: Document the newly enforced 524288 inode restriction..
Document the newly enforced 524288 inode restriction.
Mon, Jun 11, 7:32 PM
imp committed rS334969: Add asserts to prevent overflows of c_addr..
Add asserts to prevent overflows of c_addr.
Mon, Jun 11, 7:32 PM
imp added a comment to D15755: add support for marking interrupt handlers as suspended.

Generally, I like this path, but I have a couple of questions about locks since I'm having trouble working out the interlock needed.

Mon, Jun 11, 6:43 PM
imp added a comment to D15229: Allow run-time delayed attachment of devices.
In D15229#333038, @imp wrote:

The final option would be to do a variation on the prior option, but institutionalize it in DEVICE_ATTACH_LATE. It would be called just after interrupts were enabled for deferred work like this. It would cover the vast majority of driver independencies by giving a 'last' point. At that point, you return an error if you still weren't ready, and we'd loop while the number of devices returning an error was declining. It could largely replace config_intrhook.

I think this would work reasonably well for the general case here; the other suggestions would solve the case of smu(4), but there are other, simpler, ways to do that.

That said, I'm not sure what the advantage of a DEVICE_ATTACH_LATE() is over the mechanism originally proposed here or something like it except that it, as a side effect, delays until after interrupts -- which might not even be wanted, for example if the device in question is an interrupt controller.

Mon, Jun 11, 6:36 PM
imp added a comment to D15229: Allow run-time delayed attachment of devices.

The final option would be to do a variation on the prior option, but institutionalize it in DEVICE_ATTACH_LATE. It would be called just after interrupts were enabled for deferred work like this. It would cover the vast majority of driver independencies by giving a 'last' point. At that point, you return an error if you still weren't ready, and we'd loop while the number of devices returning an error was declining. It could largely replace config_intrhook.

Mon, Jun 11, 5:22 PM
imp added a comment to D15229: Allow run-time delayed attachment of devices.

Another alternative would be to attach the devices, but defer attaching the children and/or configuring the interrupts until interrupts are enabled. This is another way to ensure doorbell is present and shown in https://reviews.freebsd.org/D15760

Mon, Jun 11, 5:07 PM
imp created D15760: Defer work until we have interrupts running. We use this to ensure that the doorbell device has attached. This has the nice side effect that we can do I/O to the i2c children if need be in the future..
Mon, Jun 11, 5:05 PM
imp added a comment to D15229: Allow run-time delayed attachment of devices.

An alternative in this case would be https://reviews.freebsd.org/D15759 which defers establishing the interrupt until both devices are present, regardless of the order.

Mon, Jun 11, 4:00 PM
imp created D15759: Ensure that both doorbell and smu are attached before registering interrupts..
Mon, Jun 11, 3:58 PM

Sun, Jun 10

imp added inline comments to D15743: Extend loader(8) geli support to all architectures and all disk-like devices..
Sun, Jun 10, 9:30 PM
imp added a comment to D15743: Extend loader(8) geli support to all architectures and all disk-like devices..

OK. Generally, I really like it.

Sun, Jun 10, 8:38 PM
imp accepted D15734: Fix objcopy for little-endian MIPS64 objects..

Do we also need changes to rtld and/or the kernel loader?

Sun, Jun 10, 4:42 PM
imp accepted D15729: Assorted fixes to MSI-X/MSI/INTx setup iflib(9).

This looks good to my eye as far as I can tell...

Sun, Jun 10, 5:18 AM
imp committed rS334910: Remove old, dead compat code..
Remove old, dead compat code.
Sun, Jun 10, 2:30 AM
imp committed rS334909: Set the $PATH in /etc/crontab like it is set by the cron(8).
Set the $PATH in /etc/crontab like it is set by the cron(8)
Sun, Jun 10, 2:13 AM
imp accepted D15727: Quiet coretemp probe.

I'm surprised we need this since I set all CPUs to quiet children if they aren't CPU0.

Sun, Jun 10, 1:51 AM
imp accepted D15726: Drop MOUSE_GETVARS and MOUSE_SETVARS ioctls support..
Sun, Jun 10, 1:20 AM