Page MenuHomeFreeBSD
Feed Advanced Search

Today

imp accepted D45247: Simplify the code..
Sun, May 19, 2:45 AM
imp accepted D45249: buf: define and use BUF_DISOWNED.
Sun, May 19, 2:20 AM
imp accepted D45246: lock.9: LK_TIMELOCK is a lockmgr flag, not lockinit.
Sun, May 19, 2:18 AM

Yesterday

imp accepted D45242: rc.conf.5: remove obsolete advice about kld_list.
Sat, May 18, 3:16 PM
imp committed rG97aedd3395b4: devctl: Disable the boottime optimization of suppressing NOMATCH (authored by imp).
devctl: Disable the boottime optimization of suppressing NOMATCH
Sat, May 18, 1:11 PM

Thu, May 16

imp added a comment to D45215: kern/geom: Reserve some bios for the non-blocking allocation..
In D45215#1031630, @imp wrote:

What does nvmecontrol identify ndaX say here? What's the optimal I/O boundary? And maybe we should just have a knob to disable trying to use it.

nvmecontrol identify nda4 | grep Opt
Optimal I/O Boundary:        256 blocks
Thu, May 16, 9:38 PM
imp added a comment to D45215: kern/geom: Reserve some bios for the non-blocking allocation..

What does nvmecontrol identify ndaX say here? What's the optimal I/O boundary? And maybe we should just have a knob to disable trying to use it.

Thu, May 16, 8:53 PM
imp committed rGf38117359af1: ctladm: fix resource leak (authored by khorben_defora.org).
ctladm: fix resource leak
Thu, May 16, 5:23 PM
imp committed rG1787871a6627: bhyve: avoid resource leak (authored by khorben_defora.org).
bhyve: avoid resource leak
Thu, May 16, 5:21 PM
imp committed rG304a03275a65: sys/modules/dpdk_lpm4: do not build without INET (authored by lexi_le-fay.org).
sys/modules/dpdk_lpm4: do not build without INET
Thu, May 16, 5:17 PM
imp committed rGae9c0ba8ef2f: netstat(8): for -W, use IFNAMSIZ (authored by lexi_le-fay.org).
netstat(8): for -W, use IFNAMSIZ
Thu, May 16, 5:12 PM
imp committed rGd33b87e8cf91: netstat(1): increase width of Netif column (authored by lexi_le-fay.org).
netstat(1): increase width of Netif column
Thu, May 16, 5:12 PM
imp committed rG1687d77197c0: man filesystems: move driver pages to section four (authored by concussious.bugzilla_runbox.com).
man filesystems: move driver pages to section four
Thu, May 16, 4:53 PM
imp committed rG1a720cbec513: man filesystems: fix xrefs after move to section 4 (authored by concussious.bugzilla_runbox.com).
man filesystems: fix xrefs after move to section 4
Thu, May 16, 4:53 PM
imp committed rGa03e8a40d404: man filesystems: ObsoleteFiles after move to sec 4 (authored by concussious.bugzilla_runbox.com).
man filesystems: ObsoleteFiles after move to sec 4
Thu, May 16, 4:53 PM
imp added inline comments to D45215: kern/geom: Reserve some bios for the non-blocking allocation..
Thu, May 16, 10:23 AM
imp added inline comments to D45215: kern/geom: Reserve some bios for the non-blocking allocation..
Thu, May 16, 9:44 AM
imp added inline comments to D45215: kern/geom: Reserve some bios for the non-blocking allocation..
Thu, May 16, 8:31 AM

Wed, May 15

imp added a comment to D45174: TLB flush enlightment using Hyper-V hypercall.

Respectfully, this code is non-standards-conforming, since the standard doesn't allow multiple variable sized elements in a structure.

Wed, May 15, 5:07 PM
imp accepted D45209: ifconfig: Markup nits..

It's all one sentence one line with a couple minor tweaks that are easy to review.

Wed, May 15, 1:13 PM
imp added a comment to D45194: kernel: Fix defining of .init_array and .fini_array sections.

Yes

Wed, May 15, 2:59 AM
imp added a comment to D45194: kernel: Fix defining of .init_array and .fini_array sections.

Then a quick line in yhe commit messafe saying its a fix

Wed, May 15, 1:55 AM
imp accepted D45201: Enable soft updates by default for UFS2 filesystems.

I don't know.. has soft updates cooked enough ? :)

Wed, May 15, 12:45 AM

Tue, May 14

imp accepted D45193: arm: fail early on gcc builds.

I'd be more inclined to land the other review, but until it does, this isn't bad.

Tue, May 14, 6:31 PM
imp committed rGeb690a0576e8: awk: Merge in bsd-feature branch of OTA from 20240422 (31bb33a32f71) (authored by imp).
awk: Merge in bsd-feature branch of OTA from 20240422 (31bb33a32f71)
Tue, May 14, 6:18 PM
imp committed rG887b27736b04: ota: Import bsd-feature branch from 20240422 (31bb33a32f71) (authored by imp).
ota: Import bsd-feature branch from 20240422 (31bb33a32f71)
Tue, May 14, 6:15 PM
imp added a comment to D45194: kernel: Fix defining of .init_array and .fini_array sections.

S/lube/line/. Stupid autocowrecked

Tue, May 14, 2:45 PM
imp accepted D45194: kernel: Fix defining of .init_array and .fini_array sections.

Other arch? At the very least a lube in the commit about why not relevant there

Tue, May 14, 12:55 PM
imp added a comment to D45192: nvme: Improve timeout action.

Yea. I didn't like it either.
I could move the timeouts into qpair. Then there'd be no more computing the values... I'd have to plumb the sysctl too... it would be cleaner. I could also put the soft timeout in there too. Then it wouldn't be so arbitrary.

Tue, May 14, 3:42 AM

Mon, May 13

imp updated the test plan for D45192: nvme: Improve timeout action.
Mon, May 13, 11:45 PM
imp requested review of D45192: nvme: Improve timeout action.
Mon, May 13, 11:42 PM
imp committed rG0dd84c3b117a: nvme: Add comment about where tr->deadline is set (authored by imp).
nvme: Add comment about where tr->deadline is set
Mon, May 13, 10:40 PM
imp committed rGc931cf6af08b: nvme: Slight simplification (authored by imp).
nvme: Slight simplification
Mon, May 13, 10:39 PM
imp committed rG9db8ca92b985: nvme: Slight reworking this loop to match FreeBSD style (authored by imp).
nvme: Slight reworking this loop to match FreeBSD style
Mon, May 13, 10:39 PM
imp committed rG5a178b831a9f: nvme: Add locking asserts (authored by imp).
nvme: Add locking asserts
Mon, May 13, 10:39 PM
imp added a comment to D45175: SysV IPC: provide in-kernel helpers to obtain ipcs(8)-like information.

A 32bit freebsd cat reading /compat/linux/mumble

Mon, May 13, 2:32 PM
imp added inline comments to D45175: SysV IPC: provide in-kernel helpers to obtain ipcs(8)-like information.
Mon, May 13, 2:29 PM
imp accepted D45166: ifconfig: Add format shortcuts..

Generally i like it. It does seem to mix memory leak / style fixed in with the new functionality.

Mon, May 13, 1:59 PM

Sun, May 12

imp added a reverting change for rG099a81a4173b: linprocfs: Add support for proc/sysvipc/{msg,sem,shm}: rG71ffda413069: Revert linprocfs commits.
Sun, May 12, 3:24 PM
imp added a reverting change for rG02f481a30b82: linprocfs: Fix i386 time type: rG71ffda413069: Revert linprocfs commits.
Sun, May 12, 3:24 PM
imp added a reverting change for rGee2e36686e84: linprocfs: Really fix time_t type issue: rG71ffda413069: Revert linprocfs commits.
Sun, May 12, 3:24 PM
imp committed rG71ffda413069: Revert linprocfs commits (authored by imp).
Revert linprocfs commits
Sun, May 12, 3:24 PM
imp committed rGee2e36686e84: linprocfs: Really fix time_t type issue (authored by imp).
linprocfs: Really fix time_t type issue
Sun, May 12, 4:58 AM
imp committed rG02f481a30b82: linprocfs: Fix i386 time type (authored by imp).
linprocfs: Fix i386 time type
Sun, May 12, 12:39 AM
imp committed rGc5f906d32d2b: linux: Make module standalone-buildable (authored by imp).
linux: Make module standalone-buildable
Sun, May 12, 12:39 AM

Sat, May 11

imp accepted D45159: uart: Honour clock-frequency in FDT for UART_FDT_CLASS if present.
Sat, May 11, 8:42 PM
imp committed rG099a81a4173b: linprocfs: Add support for proc/sysvipc/{msg,sem,shm} (authored by rbranco_suse.com).
linprocfs: Add support for proc/sysvipc/{msg,sem,shm}
Sat, May 11, 7:40 PM
imp committed rG881ae768f2fd: usb: Remove uneeded revision verbosity from quirks list (authored by Ahmad Khalifa <ahmadkhalifa570@gmail.com>).
usb: Remove uneeded revision verbosity from quirks list
Sat, May 11, 7:37 PM
imp committed rG64e05e90657f: usb: Fix quirks list (authored by Ahmad Khalifa <ahmadkhalifa570@gmail.com>).
usb: Fix quirks list
Sat, May 11, 7:37 PM
imp committed rG9bcc1b18c119: /bin/rmdir: Exit with status 2 for invalid arguments (authored by henrichhartzer_tuta.io).
/bin/rmdir: Exit with status 2 for invalid arguments
Sat, May 11, 7:17 PM
imp committed rG3d966ae7895b: nvmecontrol: Appease a meaningless signed error warning thing (authored by imp).
nvmecontrol: Appease a meaningless signed error warning thing
Sat, May 11, 7:06 PM
imp committed rGc1fccf0f60ca: nvmecontrol: Implement telemetry-log command. (authored by imp).
nvmecontrol: Implement telemetry-log command.
Sat, May 11, 6:11 PM
imp committed rGe63d20b70ee1: stand: Spell LUA_COMPILE_SET correctly. (authored by imp).
stand: Spell LUA_COMPILE_SET correctly.
Sat, May 11, 6:11 PM
imp committed rGe84a75f93602: nvme: Add telemetry page definitions (authored by imp).
nvme: Add telemetry page definitions
Sat, May 11, 6:11 PM
imp accepted D45153: nvme/f: Use strlcpy instead of strncpy + manual string termination.
Sat, May 11, 1:55 AM
imp accepted D45152: nvme: Use strlcpy instead of strncpy to ensure termination.
Sat, May 11, 1:46 AM

Fri, May 10

imp added a comment to D27176: Discourage the use of sysexits(3) in new code.

So I was aware of this and preferred the pull request. It documented the current policy that's been in place for a while.
I appreciate the views expressed here, but I think it is better to try to resolve this by getting a broader consensus than we can get in a phab review.
I kinda think the project went a little far in subscribing to bde's views on this, but I don't think we'd be well served making a big change to this policy (which has a lot of lurking emotion behind it) via only a phab request.
I do think there's some sympathy for documenting / standardizing at least some of these values, but also a recognition that some are overlapping and confusing and were just Eric's first guess at what to do in sendmail for different errors.

Fri, May 10, 10:24 PM
imp committed rGa2409f17377e: intr: Document how to get the interrupt frame (authored by imp).
intr: Document how to get the interrupt frame
Fri, May 10, 9:45 PM
imp committed rG38c35248fe3b: kern/intr: remove support for passing trap frame as argument (authored by ehem_freebsd_m5p.com).
kern/intr: remove support for passing trap frame as argument
Fri, May 10, 9:37 PM
imp closed D37688: kern/intr: remove support for passing trap frame as argument.
Fri, May 10, 9:37 PM
imp committed rG467e3e2f2052: CONTRIBUTING.md/style: spring cleaning (authored by concussious.bugzilla_runbox.com).
CONTRIBUTING.md/style: spring cleaning
Fri, May 10, 9:09 PM
imp committed rGa7cc56b28fb1: linux: Adjust rlimit SIGPENDING & MSGQUEUE behaviour to match linprocfs (authored by rbranco_suse.com).
linux: Adjust rlimit SIGPENDING & MSGQUEUE behaviour to match linprocfs
Fri, May 10, 8:52 PM
imp added a reverting change for rG6ed7d0e3ac9c: grdc: Add copyright: rG88cbbbb6070c: Revert "grdc: Add copyright".
Fri, May 10, 8:13 PM
imp committed rG88cbbbb6070c: Revert "grdc: Add copyright" (authored by imp).
Revert "grdc: Add copyright"
Fri, May 10, 8:13 PM
imp accepted D45146: kmod.mk use ${XARGS}.
Fri, May 10, 6:51 PM
imp committed rG71ed1adda83d: grdc: add countdown timer mode (authored by gavin).
grdc: add countdown timer mode
Fri, May 10, 3:26 PM
imp committed rG6ed7d0e3ac9c: grdc: Add copyright (authored by imp).
grdc: Add copyright
Fri, May 10, 3:26 PM
imp committed rG06af7bd12a4a: posix: POSIX-1.2008 moved SA_* from XSI to base standard (authored by imp).
posix: POSIX-1.2008 moved SA_* from XSI to base standard
Fri, May 10, 3:26 PM
imp closed D43463: grdc: add countdown timer mode.
Fri, May 10, 3:25 PM
imp committed rGb01988d5e570: mdconfig: Print options when listing devices (authored by rbranco_suse.com).
mdconfig: Print options when listing devices
Fri, May 10, 4:46 AM
imp committed rG042267e0cdda: Explain cron.d (authored by Paweł Krawczyk <p+freebsd@krvtz.net>).
Explain cron.d
Fri, May 10, 4:36 AM
imp committed rG783baf00128f: at cron file is now in /etc/cron.d (authored by Paweł Krawczyk <p+freebsd@krvtz.net>).
at cron file is now in /etc/cron.d
Fri, May 10, 4:36 AM
imp committed rG5ccaab1797e5: sysexits: Tidy deprecated header and manual (authored by concussious.bugzilla_runbox.com).
sysexits: Tidy deprecated header and manual
Fri, May 10, 2:53 AM
imp committed rG9f91b8aaf5da: Update README.md to add pointer to release page. (authored by Lukas R. Jackson <Lukasjacksoneg@gmail.com>).
Update README.md to add pointer to release page.
Fri, May 10, 2:42 AM
imp committed rGc733dc7a6f86: ahc(4): Default to memory mapped IO (authored by hp_tmm.cx).
ahc(4): Default to memory mapped IO
Fri, May 10, 2:18 AM
imp committed rG09025a714708: ipfw: correctly report table manipulation errors (authored by ben_desync.com).
ipfw: correctly report table manipulation errors
Fri, May 10, 2:10 AM
imp committed rG12be6f12e87a: Fix memory corruption in C++ demangler (authored by Justine Tunney <jtunney@gmail.com>).
Fix memory corruption in C++ demangler
Fri, May 10, 2:01 AM

Thu, May 9

imp committed rG8c2f6c3be012: Address module reproducibility issues (authored by dan.mcgregor_usask.ca).
Address module reproducibility issues
Thu, May 9, 11:40 PM
imp committed rGcd917a17bc39: arp.8: don't document a syntax that doesn't exist (authored by lexi_le-fay.org).
arp.8: don't document a syntax that doesn't exist
Thu, May 9, 11:29 PM
imp committed rGd9817976625f: intr/x86: replace use of vector in interface with intsrc (authored by ehem_freebsd_m5p.com).
intr/x86: replace use of vector in interface with intsrc
Thu, May 9, 11:22 PM
imp committed rG98c276811aec: arm: add missing atomic-pointer functions (authored by ehem_freebsd_m5p.com).
arm: add missing atomic-pointer functions
Thu, May 9, 11:22 PM
imp committed rG99adf661ab63: sys: declare bit sets unsigned (authored by ehem_freebsd_m5p.com).
sys: declare bit sets unsigned
Thu, May 9, 11:22 PM
imp committed rG9f3a552f9e1a: intrng: switch flag arguments to unsigned (authored by ehem_freebsd_m5p.com).
intrng: switch flag arguments to unsigned
Thu, May 9, 11:22 PM
imp committed rGa9e0f316b3da: kern/intr: redeclare intr_setaffinity()'s third arg constant (authored by ehem_freebsd_m5p.com).
kern/intr: redeclare intr_setaffinity()'s third arg constant
Thu, May 9, 11:21 PM
imp closed D35386: intr/x86: replace use of vector in interface with intsrc.
Thu, May 9, 11:21 PM
imp committed rGcd04887b9569: kern/intr: change ->ie_irq to unsigned (authored by ehem_freebsd_m5p.com).
kern/intr: change ->ie_irq to unsigned
Thu, May 9, 11:21 PM
imp closed D37778: arm: add missing atomic-pointer functions.
Thu, May 9, 11:21 PM
imp committed rGe64318e76ed9: arm/pmu: remove passing trap frame as argument (authored by ehem_freebsd_m5p.com).
arm/pmu: remove passing trap frame as argument
Thu, May 9, 11:21 PM
imp closed D32793: sys: declare bit sets unsigned.
Thu, May 9, 11:21 PM
imp accepted D42369: bsdinstall: Remove unused variables in fetchmissingdists.

Since these aren't exported or used anywhere, I think they are safe to remove.

Thu, May 9, 10:11 PM
imp committed rG52e41d1a5bd9: Update example from gcc6 to gcc13 (authored by imp).
Update example from gcc6 to gcc13
Thu, May 9, 2:19 PM
imp accepted D45130: tftpd: Drop unneeded includes..
Thu, May 9, 1:56 PM

Wed, May 8

imp accepted D45132: tftpd: Satisfy clang-analyzer..
Wed, May 8, 9:31 PM
imp accepted D45131: tftpd: Add missing include..
Wed, May 8, 9:30 PM
imp accepted D45129: tftpd: Add missing `-S` option to synopsis..
Wed, May 8, 9:30 PM
imp added a comment to D45124: rwhod: IPv6 clean.

What do you do if neither INET nor INET6 are defined? In a lot of cases, it looks like you fail. Likewise for when you don't have the right address family compiled in.

Wed, May 8, 4:45 PM
imp accepted D45126: libthr: avoid varargs in fcntl and openat interposers.
Wed, May 8, 2:28 PM

Tue, May 7

imp added a comment to D45115: smsc(4): update to mention Microchip.

makes sense @emaste. Thanks!

Tue, May 7, 6:56 PM
imp accepted D45115: smsc(4): update to mention Microchip.

Why though?

Tue, May 7, 4:22 PM
imp added a comment to D45011: RDMA/bnxt_re: Add bnxt_re RoCE driver.

The build is good, modulo one quibble.
The rest looks OK, but is really too large for me to review.

Tue, May 7, 3:39 PM