Page MenuHomeFreeBSD
Feed Advanced Search

Yesterday

imp committed rS338888: We don't need shell protection for when we're expanding matches..
We don't need shell protection for when we're expanding matches.
Sat, Sep 22, 3:33 PM
imp closed D17267: We don't need shell protection for when we're expanding matches. Don't add it. This should fix when we do regepx matches against variables we've set and fix wifi bring up..
Sat, Sep 22, 3:33 PM
imp added inline comments to D17279: Define a ifunc-noplt linker feature..
Sat, Sep 22, 3:14 AM

Fri, Sep 21

imp added a comment to D17267: We don't need shell protection for when we're expanding matches. Don't add it. This should fix when we do regepx matches against variables we've set and fix wifi bring up..

Does this require any changes to devd.conf to work? Only applying this patch and copy over devd binary to my test machine doesn't change anything for me, the regexp still starts with ^$'(.....

Fri, Sep 21, 1:20 PM
imp created D17267: We don't need shell protection for when we're expanding matches. Don't add it. This should fix when we do regepx matches against variables we've set and fix wifi bring up..
Fri, Sep 21, 5:28 AM

Thu, Sep 20

imp added a comment to D17256: Move device.hints install into stand.

I really dislike this. It's not really a stand thing, and the GENERIC assumption is weak. We should be linking it to the installed kernel's hints, which maybe we should be installing into /boot/kernel when we install it.
It's always been an ugly wart on the side of things since it was introduced in FreeBSD 4.

Thu, Sep 20, 4:47 PM

Wed, Sep 19

imp accepted D17250: Add support for EC2 i3.metal serial port.
Wed, Sep 19, 10:08 PM

Tue, Sep 18

imp added a comment to D17211: Only enable HyperV support by default on x86..

This is actually wrong. HYPERV should be added to BROKEN_OPTIONS on !x86.
But there's already 3 other bad offenders :(

Tue, Sep 18, 8:04 PM

Fri, Sep 14

imp added a comment to D17169: Add quirk to disable NCQ TRIM for Samsung 860 SSDs.

How were you able to determine this?
The latest version of Linux doesn't have this quirk.

Fri, Sep 14, 9:13 PM
imp added a comment to D16753: Simplify the EFI delay() function by calling BS->Stall()..

This year's award for going above and beyond in testing goes to...

Fri, Sep 14, 9:07 PM

Thu, Sep 13

imp added a comment to D17151: Add "geom -t"..

What does this do that
sysctl -n kern.geom.conftxt
doesn't do?
Seems like this is just filtered information from that data source.
At the very least, a pointer to that information should be given since it's so much easier to use in scripts than this output.

Thu, Sep 13, 2:24 PM

Wed, Sep 12

imp added a comment to D17131: loader: create bio_alloc and bio_free for bios bounce buffer.

Generally I like this, but it also looks like there's some drive reset retry logic tossed in as well...

Wed, Sep 12, 6:16 PM

Mon, Sep 10

imp created D17112: Improve error messages for loader modules..
Mon, Sep 10, 7:21 PM
imp committed rS338559: Correct directions for building pxeboot. One needs to cd to src/stand,.
Correct directions for building pxeboot. One needs to cd to src/stand,
Mon, Sep 10, 3:16 PM

Thu, Sep 6

imp added inline comments to D16966: Permit local kernel modules to be built as part of a kernel..
Thu, Sep 6, 7:26 PM
imp added inline comments to D16966: Permit local kernel modules to be built as part of a kernel..
Thu, Sep 6, 7:24 PM
imp accepted D17052: Summary: Add device_attach and device_detach events to man page..
Thu, Sep 6, 6:20 PM
imp accepted D17058: libsa: memory leak in tftp_open().
Thu, Sep 6, 2:45 PM
imp committed rS338474: Be a little conservative about when to force size optimizations..
Be a little conservative about when to force size optimizations.
Thu, Sep 6, 12:30 PM
imp closed D17016: Be a little conservative about when to force size optimizations..
Thu, Sep 6, 12:30 PM

Tue, Sep 4

imp created D17016: Be a little conservative about when to force size optimizations..
Tue, Sep 4, 3:41 PM

Mon, Sep 3

imp added a comment to D6814: Add libfdt user space library.
In D6814#362680, @ian wrote:

This should be attached to the build, and used by the GNU dtc.

I'm wondering should libfdt be conditionally built and, if so, should it be based on MK_FDT and MK_GPL_DTC (since the dtc build will be using it after the suggested changes)?

I think it should be conditional on MK_FDT, but not on MK_GPL_DTC, because the library itself is BSD-licensed.

Mon, Sep 3, 3:43 PM

Sun, Sep 2

imp committed rS338432: Make -a (to make the entry active) apply to creation of a new boot.
Make -a (to make the entry active) apply to creation of a new boot
Sun, Sep 2, 6:40 PM
imp closed D16977: Make -a (to make the entry active) apply to creation of a new boot variable..
Sun, Sep 2, 6:40 PM

Fri, Aug 31

imp created D16977: Make -a (to make the entry active) apply to creation of a new boot variable..
Fri, Aug 31, 9:53 PM
imp accepted D16945: userboot: handle guest interpreter mismatches more intelligently.

Looks good to me. I could nit-pick all day at this stuff, but I'd rather get this in and cope with the nits after the release.

Fri, Aug 31, 4:53 PM
imp added inline comments to D16945: userboot: handle guest interpreter mismatches more intelligently.
Fri, Aug 31, 4:51 PM
imp accepted D16960: dd: Correct padding in status=progress.
Fri, Aug 31, 3:57 PM
imp accepted D16960: dd: Correct padding in status=progress.

looks good, as does the good humanize_number catch.

Fri, Aug 31, 3:39 PM
imp added a comment to D16960: dd: Correct padding in status=progress.

I listed both because different applications require different numbers.
Sometimes you need SI stuff since you are more familiar with that stuff due to there aspects of your pipeline (eg disks or networks)
Other times you want the IEC ones because you (eg memory images)
It's also not burdensome to do both, just tricky to get the code right...

Fri, Aug 31, 3:37 PM
imp closed D16959: Don't load ccp automatically..

rS338402 Sr338402 fixes this. Said differential review, not differential revision.

Fri, Aug 31, 1:05 AM
imp committed rS338402: Don't load ccp automatically with devmatch.
Don't load ccp automatically with devmatch
Fri, Aug 31, 1:01 AM

Thu, Aug 30

imp added a comment to D16959: Don't load ccp automatically..

Thanks for the context, I'll update the commit message and submit to re@

Thu, Aug 30, 10:38 PM
imp added reviewers for D16959: Don't load ccp automatically.: jhb, cem.
Thu, Aug 30, 9:14 PM
imp created D16959: Don't load ccp automatically..
Thu, Aug 30, 9:00 PM
imp added inline comments to D16945: userboot: handle guest interpreter mismatches more intelligently.
Thu, Aug 30, 7:50 PM
imp added inline comments to D16945: userboot: handle guest interpreter mismatches more intelligently.
Thu, Aug 30, 7:47 PM
imp added a comment to D16945: userboot: handle guest interpreter mismatches more intelligently.

I think you can get around the edge case of dlclose by using setjmp/longjmp as outlined.

Thu, Aug 30, 2:27 PM

Wed, Aug 29

imp committed rS338376: Tweak typos in UPDATING.
Tweak typos in UPDATING
Wed, Aug 29, 5:37 PM
imp created D16945: userboot: handle guest interpreter mismatches more intelligently.
Wed, Aug 29, 4:46 PM

Tue, Aug 28

imp committed rS338349: Regen src.conf.5 after r338347..
Regen src.conf.5 after r338347.
Tue, Aug 28, 2:53 PM
imp committed rS338347: Put building of drm and drm2 modules behind options..
Put building of drm and drm2 modules behind options.
Tue, Aug 28, 2:47 PM
imp committed rS338348: Add big, nasty abandonware tags to this code..
Add big, nasty abandonware tags to this code.
Tue, Aug 28, 2:47 PM
imp updated the diff for D16894: Put building of drm and drm2 modules behind options and Add big, nasty abandonware tags to this code..

Regen latest tree

  • Put building of drm and drm2 modules behind options.
  • Add big, nasty abandonware tags to this code.
Tue, Aug 28, 2:34 PM

Mon, Aug 27

imp added a comment to D16914: lualoader: Create a module blacklist, add DRM modules to it.

btw, the 4th ask is just an ask, not a must have

Mon, Aug 27, 3:17 AM
imp added a comment to D16914: lualoader: Create a module blacklist, add DRM modules to it.

Now all we need to do is get Devin to add it in forth and we'll be set :)
1/2 :)

Mon, Aug 27, 3:13 AM
imp added a comment to D16914: lualoader: Create a module blacklist, add DRM modules to it.

Seems straight forward enough... Not sure this is the right layer to put this functionality.
lemme cook on this.

Mon, Aug 27, 3:06 AM

Sun, Aug 26

imp added a comment to D16894: Put building of drm and drm2 modules behind options and Add big, nasty abandonware tags to this code..

LGTM and I assume there's another patch coming that will fix the loader issues?

Sun, Aug 26, 3:35 PM
imp added inline comments to D16894: Put building of drm and drm2 modules behind options and Add big, nasty abandonware tags to this code..
Sun, Aug 26, 2:56 PM
imp added inline comments to D16894: Put building of drm and drm2 modules behind options and Add big, nasty abandonware tags to this code..
Sun, Aug 26, 2:46 PM

Sat, Aug 25

imp added a comment to D16894: Put building of drm and drm2 modules behind options and Add big, nasty abandonware tags to this code..

I think I've done all the actionable items in this review.

Sat, Aug 25, 4:58 PM
imp committed rS338314: Add in a missing newline.
Add in a missing newline
Sat, Aug 25, 3:48 PM
imp closed D16895: Add in a missing newline.
Sat, Aug 25, 3:48 PM
imp updated the diff for D16894: Put building of drm and drm2 modules behind options and Add big, nasty abandonware tags to this code..
  • Add big, nasty abandonware tags to this code.
Sat, Aug 25, 2:21 PM
imp added inline comments to D16894: Put building of drm and drm2 modules behind options and Add big, nasty abandonware tags to this code..
Sat, Aug 25, 2:11 PM
imp added a reviewer for D16895: Add in a missing newline: nwhitehorn.
Sat, Aug 25, 4:36 AM
imp created D16895: Add in a missing newline.
Sat, Aug 25, 4:35 AM
imp updated the diff for D16894: Put building of drm and drm2 modules behind options and Add big, nasty abandonware tags to this code..

Rod comments

Sat, Aug 25, 3:56 AM
imp updated the diff for D16894: Put building of drm and drm2 modules behind options and Add big, nasty abandonware tags to this code..

cem's suggestions and WITH*DRM stuff

Sat, Aug 25, 2:18 AM
imp updated the diff for D16894: Put building of drm and drm2 modules behind options and Add big, nasty abandonware tags to this code..
  • Put building of drm and drm2 modules behind options.
  • Add big, nasty abandonware tags to this code.
Sat, Aug 25, 2:08 AM
imp updated the summary of D16894: Put building of drm and drm2 modules behind options and Add big, nasty abandonware tags to this code..
Sat, Aug 25, 1:49 AM
imp added reviewers for D16894: Put building of drm and drm2 modules behind options and Add big, nasty abandonware tags to this code.: mmacy, johalun0_gmail.com, zeising, gjb, Core Team.
Sat, Aug 25, 1:22 AM
imp created D16894: Put building of drm and drm2 modules behind options and Add big, nasty abandonware tags to this code..
Sat, Aug 25, 1:21 AM

Aug 24 2018

imp committed rS338285: Revert drm2 removal..
Revert drm2 removal.
Aug 24 2018, 12:02 AM

Aug 23 2018

imp added a comment to D16870: Turn drm2 back on in TEGRA124.

I respectfully request that a straight revert of the commits be done rather than this, for one this does not allow us to do the proper deprecation commits, nor to merge those commits back to stable/11. This is still a major violation of deprecation policy. Warner, would you new policy allow this type of thing to be accepted? I would hope not.

Furthermore this differential is failing build, something we do not want hours before code freeze!

Aug 23 2018, 7:19 PM
imp updated the summary of D16870: Turn drm2 back on in TEGRA124.
Aug 23 2018, 4:57 PM
imp added a comment to D16870: Turn drm2 back on in TEGRA124.

There's three files that matter here, given my plan: sys/conf/Makefile.arm, sys/arm/conf/TEGRA124 and sys/arm/nvidia/tegra124/files.tegra124
The rest are just copies from dev/drm2 before the rm.

Aug 23 2018, 4:51 PM
imp updated the summary of D16870: Turn drm2 back on in TEGRA124.
Aug 23 2018, 4:49 PM
imp updated the summary of D16870: Turn drm2 back on in TEGRA124.
Aug 23 2018, 4:45 PM
imp updated the test plan for D16870: Turn drm2 back on in TEGRA124.
Aug 23 2018, 3:49 PM
imp created D16870: Turn drm2 back on in TEGRA124.
Aug 23 2018, 3:47 PM
imp committed rS338240: Forgot to bump .Dd in r338233 like I promised in the review. Doh!.
Forgot to bump .Dd in r338233 like I promised in the review. Doh!
Aug 23 2018, 5:09 AM
imp committed rS338239: Add a special note to UPDATING for the devmatch stuff. While tested,.
Add a special note to UPDATING for the devmatch stuff. While tested,
Aug 23 2018, 5:06 AM
imp committed rS338238: Implement blacklisting for devmatch.
Implement blacklisting for devmatch
Aug 23 2018, 5:06 AM
imp committed rS338237: When trying to match the nomatch event passed to us, attempt to look.
When trying to match the nomatch event passed to us, attempt to look
Aug 23 2018, 5:06 AM
imp committed rS338236: Add a new device flag: DF_ATTACHED_ONCE.
Add a new device flag: DF_ATTACHED_ONCE
Aug 23 2018, 5:06 AM
imp committed rS338235: Remove sorting of matches and print all the matches as we find them..
Remove sorting of matches and print all the matches as we find them.
Aug 23 2018, 5:06 AM
imp committed rS338234: Improve devmatch driver loading.
Improve devmatch driver loading
Aug 23 2018, 5:06 AM
imp committed rS338233: Create devctl freeze/thaw..
Create devctl freeze/thaw.
Aug 23 2018, 5:06 AM
imp closed D16735: Create devctl freeze/thaw..
Aug 23 2018, 5:05 AM

Aug 22 2018

imp added inline comments to D16815: Allow building world without inhering $PATH.
Aug 22 2018, 9:02 PM
imp added a comment to D16510: Rework rtld's TLS Variant I implementation to match r326794.

mmel's fix looks good to me.

Aug 22 2018, 3:15 PM
imp accepted D16837: Document FreeBSD version 1200081.
Aug 22 2018, 3:11 PM
imp updated the diff for D16735: Create devctl freeze/thaw..
  • nomatch
Aug 22 2018, 3:10 PM
imp added inline comments to D16735: Create devctl freeze/thaw..
Aug 22 2018, 3:03 PM

Aug 21 2018

imp added a comment to D14317: Stop using unifdef to generate bsdxml.h.

need to update a comment, but otherwise looks good.

Aug 21 2018, 7:11 PM
imp accepted D16781: Move all devd related configs to sbin/devd/.
Aug 21 2018, 4:19 PM
imp added inline comments to D16735: Create devctl freeze/thaw..
Aug 21 2018, 3:59 PM
imp updated the diff for D16735: Create devctl freeze/thaw..
  • Improve devmatch driver loading
  • Remove sorting of matches and print all the matches as we find them.
  • Stupid debug
  • fold kernel
  • Add a new device flag: DF_ATTACHED_ONCE
  • When trying to match the nomatch event passed to us, attempt to look
  • Implement blacklisting for devmatch
  • Mark nomatch devices
Aug 21 2018, 3:57 PM
imp accepted D16723: Cache the most recently drawn text on vt and don't re-draw it.

These optimizations look sane to me, but I've not spent a lot of time studying it for subtle effects.

Aug 21 2018, 3:44 PM
imp accepted D16404: nvme: Alternate approach to restoring API.
Aug 21 2018, 3:34 PM
imp accepted D16827: Remove 'imen' global variable from atpic(4)..
Aug 21 2018, 3:28 PM
imp added a comment to D16815: Allow building world without inhering $PATH.
In D16815#358213, @imp wrote:
In D16815#358208, @imp wrote:

How does this interact with LOCAL_XTOOL_DIRS? Doesn't this totally break that feature?

As far as I can tell LOCAL_XTOOL_DIRS is only added to the cross-tools list of subdirectories so it should just work (unless the build of LOCAL_XTOOL_DIRS depends on another tool that is not in $PATH)

A trivial test case would be nanobsd:

cd tools/tools/nanobsd/embedded ; sh ../nanobsd.sh -c qemu-amd64-uefi.cfg

which uses the feature to build mkimg.

Thanks, I'll try that and update the patch if necessary.

Aug 21 2018, 2:40 PM
imp added a comment to D16815: Allow building world without inhering $PATH.
In D16815#358208, @imp wrote:

How does this interact with LOCAL_XTOOL_DIRS? Doesn't this totally break that feature?

As far as I can tell LOCAL_XTOOL_DIRS is only added to the cross-tools list of subdirectories so it should just work (unless the build of LOCAL_XTOOL_DIRS depends on another tool that is not in $PATH)

Aug 21 2018, 2:32 PM
imp added a comment to D16815: Allow building world without inhering $PATH.

How does this interact with LOCAL_XTOOL_DIRS? Doesn't this totally break that feature?

Aug 21 2018, 2:21 PM
imp added inline comments to D16781: Move all devd related configs to sbin/devd/.
Aug 21 2018, 3:27 AM

Aug 20 2018

imp committed rS338116: Move options INTRNG into std.armv6 and std.armv7.
Move options INTRNG into std.armv6 and std.armv7
Aug 20 2018, 8:32 PM
imp committed rS338114: mergemaster: better defaults for SOURCEDIR.
mergemaster: better defaults for SOURCEDIR
Aug 20 2018, 7:39 PM
imp committed rS338108: Serial console menus for lua..
Serial console menus for lua.
Aug 20 2018, 4:44 PM
imp closed D16816: Remove a bunch of special cases for UEFI and serial consoles. We do want to do curses and menu things here..
Aug 20 2018, 4:44 PM