Page MenuHomeFreeBSD
Feed Advanced Search

Today

imp accepted D44542: kerneldump: Add flag to indicate kernel core was successfully dumped.
Thu, Mar 28, 6:15 AM
imp accepted D44541: stand/efi: Changes to efichar to allow it to be used in the kernel.
Thu, Mar 28, 6:14 AM

Yesterday

imp added inline comments to D44534: mmc: Add hint.mmcsd.X.ignore_part tunable.
Wed, Mar 27, 8:40 PM
imp accepted D44532: uart_snps: Register a device xref for UARTs.
Wed, Mar 27, 6:22 PM

Tue, Mar 26

imp added a comment to D44511: ln: Use stdbool, style nits..
In D44511#1015246, @des wrote:

mark usage() dead

Tue, Mar 26, 4:31 PM
imp accepted D44511: ln: Use stdbool, style nits..
Tue, Mar 26, 4:21 PM
imp added inline comments to D44506: kldunload.2 Document another case for the error EBUSY.
Tue, Mar 26, 2:21 PM

Mon, Mar 25

imp accepted D44500: tzsetup: be explicit about *timezone* abbreviation.

Agnostic on it's existence... maybe lean for removing it

Mon, Mar 25, 9:02 PM
imp added a comment to D43575: fdisk: disconnect from the build.

I think this might break nanobsd.
I'm traveling this week, so it may be next before i get it fixed.

Mon, Mar 25, 9:01 PM
imp accepted D43586: bsdlabel: emit deprecation notice when run.
Mon, Mar 25, 7:57 PM
imp committed rGbaab6b195497: Remove a reference to xrpu from timetc.h (authored by jeffpc_josefsipek.net).
Remove a reference to xrpu from timetc.h
Mon, Mar 25, 5:54 PM
imp closed D44462: Remove a reference to xrpu from timetc.h.
Mon, Mar 25, 5:54 PM
imp accepted D44462: Remove a reference to xrpu from timetc.h.

Yup, it's gone.... Since 2007 it even appears...

Mon, Mar 25, 5:34 PM
imp accepted D44494: mpi3r: Track IO per target counter during queue poll with local var.

Change looks good, but you'll want to edit the 'subject' of the commit message to be < 70 characters

Mon, Mar 25, 10:25 AM

Sun, Mar 24

imp added a comment to D44320: Allow the bundled zstd to use utimensat.

So digging into this a bit more... I bumped the POSIX_VERSION in FreeBSD. This code seemed to compile great when I did that after I moved the BSDs to the #if I highlighted.

Sun, Mar 24, 10:17 AM

Sat, Mar 23

imp accepted D44486: mem.4: Correct the HISTORY section.
Sat, Mar 23, 5:56 PM

Fri, Mar 22

imp accepted D44443: nvme: Add constants for the PSDT field in cdw0..
Fri, Mar 22, 9:19 PM
imp added inline comments to D44448: nvme: Add NVMe over Fabrics fields to nvme_controller_data.
Fri, Mar 22, 9:17 PM
imp added inline comments to D44449: nvmecontrol: Display additional Fabrics-related fields for cdata.
Fri, Mar 22, 9:16 PM

Thu, Mar 21

imp added inline comments to D44452: mpi3mr: Divert WriteSame IOs which has unmap and ndob bit set to firmware if its transfer length exceeds firmware limit..
Thu, Mar 21, 12:10 PM
imp added inline comments to D44443: nvme: Add constants for the PSDT field in cdw0..
Thu, Mar 21, 9:37 AM
imp accepted D44442: nvme: Add SGL structure and constants for use in NVMe commands.
Thu, Mar 21, 9:35 AM
imp added inline comments to D44441: nvme: Export constants for min and max queue sizes.
Thu, Mar 21, 9:34 AM
imp accepted D44444: nvme: Add constants for the extended data for Get Log Page command flag.
Thu, Mar 21, 9:30 AM
imp accepted D44445: nvme: Add constants for fields in AER completion dword 0.
Thu, Mar 21, 9:30 AM
imp accepted D44446: nvme: Add constants and types for the discovery log page.
Thu, Mar 21, 9:22 AM
imp accepted D44447: nvme: Add constants for the Controller Attributes field in cdata.
Thu, Mar 21, 9:20 AM
imp accepted D44448: nvme: Add NVMe over Fabrics fields to nvme_controller_data.
Thu, Mar 21, 9:20 AM
imp accepted D44449: nvmecontrol: Display additional Fabrics-related fields for cdata.
Thu, Mar 21, 9:18 AM
imp accepted D44430: mpi3mr: Update driver version to 8.10.0.1.0.
Thu, Mar 21, 9:06 AM
imp accepted D44429: mpi3mr: Update copyright year to 2024.
Thu, Mar 21, 9:06 AM
imp accepted D44428: mpi3mr: Update mpi header to latest version.
Thu, Mar 21, 9:03 AM
imp accepted D44427: mpi3mr: Adding FreeBSD OS Type to Fault/Reset Reason Code.
Thu, Mar 21, 9:03 AM
imp accepted D44426: mpi3mr: Consider Diagnostic Fault Reset Success Beyond 0xF000 fault Code.
Thu, Mar 21, 8:56 AM
imp added inline comments to D44425: mpi3mr: Update consumerindex of admin and op reply queues after every 100 replies.
Thu, Mar 21, 8:50 AM
imp accepted D44423: mpi3mr: poll reply queue and add MPI3MR_DEV_REMOVE_HS_COMPLETED flag.

Fine as it is if the same sort of redundancy is done elsewhere

Thu, Mar 21, 8:45 AM
imp accepted D44424: mpi3mr: Decrement per controller and per target IO counter post controller reset.
Thu, Mar 21, 8:41 AM
imp accepted D44422: mpi3mr: Add controller state check before enabling PEL.
Thu, Mar 21, 8:37 AM
imp accepted D44421: mpi3mr: Block devices persist despite being offlined during reset.
Thu, Mar 21, 8:35 AM

Wed, Mar 20

imp accepted D44440: BSD.usr.dist: remove empty /usr/libdata/gcc directory.

I think this is good. Maybe ask dim/jhb if there is some weird reason we need these?

Wed, Mar 20, 5:51 PM
imp added inline comments to D44438: kassert.h: update MPASS definition commentary.
Wed, Mar 20, 4:01 PM

Tue, Mar 19

imp added inline comments to D44434: KASSERT(9): add assertion message guidelines.
Tue, Mar 19, 8:10 PM
imp added a comment to D44434: KASSERT(9): add assertion message guidelines.
In D44434#1013310, @jhb wrote:

I really wish we could transition KASSERT gracefully to using __VA_ARGS__ and away from the nested ()'s, but I'm not sure of a good way to permit both syntaxes concurrently.

Tue, Mar 19, 8:04 PM

Mon, Mar 18

imp added a comment to D42936: sysclock: Bug fixes and cleanup.

This is too bog to easily review, so it has always dropped to the end of the list...

Mon, Mar 18, 11:25 PM
imp accepted D44413: uboot/Makefile move BINDIR.
Mon, Mar 18, 8:51 PM
imp accepted D44414: loader.4th dictthreshold too small.

This is fine. The syntax is Forth, the comments are Forth and a quick grep suggests that dictthreshold is the right variable to set.

Mon, Mar 18, 6:34 PM
imp accepted D44290: pciconf: Report topology information.

This looks good. There areno compat concerns

Mon, Mar 18, 5:57 PM

Sun, Mar 17

imp accepted D44400: Add myself (jfree) to calendar.freebsd.
Sun, Mar 17, 10:50 PM
imp requested changes to D44289: PCIOCGETCONF: Report NUMA domain.

These changes aren't backward compatible. You likely need to keep the old struct to reply to the old ioctl...

Sun, Mar 17, 10:49 PM

Fri, Mar 15

imp committed rGd2a824c29d69: share/mk: Don't install only differing in case files on case insensitive fs (authored by imp).
share/mk: Don't install only differing in case files on case insensitive fs
Fri, Mar 15, 3:03 PM
imp closed D44347: share/mk: Don't install only differing in case files on case insensitive fs.
Fri, Mar 15, 3:03 PM
imp closed D44346: scsi: Stop installing both cam.4 and CAM.4.
Fri, Mar 15, 3:02 PM
imp committed rGa00f9e4e8181: scsi: Stop installing both cam.4 and CAM.4 (authored by imp).
scsi: Stop installing both cam.4 and CAM.4
Fri, Mar 15, 3:02 PM
imp added reviewers for D44367: cam: Move temporary queue from stack to softc: mav, ken.
Fri, Mar 15, 4:17 AM
imp requested review of D44367: cam: Move temporary queue from stack to softc.
Fri, Mar 15, 4:17 AM

Thu, Mar 14

imp accepted D44360: arm64: Return all registers to gdb when able.
Thu, Mar 14, 5:55 PM
imp accepted D44358: uart: Add uart_cpu_acpi_setup to setup the uart.
Thu, Mar 14, 5:54 PM
imp accepted D44357: uart: Split out initilisation of the acpi devinfo.

just one (possibly unrelated) question.

Thu, Mar 14, 5:53 PM

Wed, Mar 13

imp added a comment to D44264: newbus: Create %probe_bias in every devclass.

I would suggest iwlwifi vs iwm except that LinuxKPI drivers don't probe normally (they all run in a late SYSINIT for some reason) so this won't work for that case. :(

We need to fix that. It's unacceptable. I'm tired of all the stupid hacks in LinuxKPI because the original author couldn't be bothered to do things correctly... See also the restriction on not being able to be loaded from the boot loader...

Wed, Mar 13, 8:42 PM
imp added a comment to D44264: newbus: Create %probe_bias in every devclass.
In D44264#1011411, @jhb wrote:

I think it would be useful to include a specific example in the commit log (and I wish there was a manpage to document this in, but I can't think of a good one).

Wed, Mar 13, 8:38 PM
imp abandoned D44348: mtree: Hack to allow gname and uname to pass through.

ooops. This is not ready. It doesn't even work, sadly.

Wed, Mar 13, 8:33 PM
imp requested review of D44348: mtree: Hack to allow gname and uname to pass through.
Wed, Mar 13, 8:32 PM
imp requested review of D44347: share/mk: Don't install only differing in case files on case insensitive fs.
Wed, Mar 13, 8:32 PM
imp requested review of D44346: scsi: Stop installing both cam.4 and CAM.4.
Wed, Mar 13, 8:32 PM
imp accepted D44345: bsd.opts.mk: drop transtion aid for NO_* options.

Sounds good,,, CLEAN isn't in the list :)

Wed, Mar 13, 8:03 PM
imp accepted D44341: arm64 gicv3: Use void pointers instead of vm_offset_t.
Wed, Mar 13, 7:59 PM
imp accepted D44318: openbsm: Remove $FreeSBD$ tags from the configuration files.
Wed, Mar 13, 1:15 PM
imp accepted D44334: riscv: remove more riscv64sf support.

I think tis is good... not sure about jrtc's comments

Wed, Mar 13, 1:58 AM

Tue, Mar 12

imp added a comment to D44320: Allow the bundled zstd to use utimensat.

An exp-run is what you suggested when I first raised the issue on freebsd-hackers last September. However, I don't know how to do an exp-run. Are you volunteering?

Tue, Mar 12, 9:22 PM
imp requested changes to D44320: Allow the bundled zstd to use utimensat.

This isn't quite right. We also should change sys/sys/unistd.h since it only defines 200112 compliance, when we're effectively 200809 compliant.
We should likely just move the BSD defines down to the highlighted #if, but we'd also need to make the sys/sys/unitstd.h change. I'd recommend that for upstream, then it automatiocally starts working.

Tue, Mar 12, 7:58 PM
imp added a comment to D44318: openbsm: Remove $FreeSBD$ tags from the configuration files.

Have you confirmed that this makes these files now match upstream?

Tue, Mar 12, 6:44 PM
imp committed rG5b35479e3ede: RELNOTES: Add awk update from 2 weeks ago. (authored by imp).
RELNOTES: Add awk update from 2 weeks ago.
Tue, Mar 12, 3:25 PM
imp committed rGe36906ac1a4d: RELNOTES: Add pointer to awk info. (authored by imp).
RELNOTES: Add pointer to awk info.
Tue, Mar 12, 3:24 PM
imp committed rG10f1eebd2c61: Add info about one true awk 2nd edition. (authored by imp).
Add info about one true awk 2nd edition.
Tue, Mar 12, 3:22 PM
imp committed rGb0f058525b5b: awk: Fix the tests (authored by imp).
awk: Fix the tests
Tue, Mar 12, 2:50 PM
imp committed rGdaf917daba9c: Merge one true awk from 2024-01-22 for the Awk Second Edition support (authored by imp).
Merge one true awk from 2024-01-22 for the Awk Second Edition support
Tue, Mar 12, 2:49 PM
imp committed rG47fff7407c22: ada: Another NCQ Trim instability drive (authored by imp).
ada: Another NCQ Trim instability drive
Tue, Mar 12, 4:52 AM
imp committed rG7a0a6b276cfd: libc: Move tzset.3 to stdtime (authored by imp).
libc: Move tzset.3 to stdtime
Tue, Mar 12, 4:20 AM
imp committed rGa34940a9756a: timezone: Move to the XSI/POSIX definition for timezone. (authored by imp).
timezone: Move to the XSI/POSIX definition for timezone.
Tue, Mar 12, 4:20 AM
imp closed D44281: timezone: Move to the XSI/POSIX definition for timezone..
Tue, Mar 12, 4:20 AM
imp added inline comments to D44281: timezone: Move to the XSI/POSIX definition for timezone..
Tue, Mar 12, 3:25 AM

Mon, Mar 11

imp added inline comments to D44281: timezone: Move to the XSI/POSIX definition for timezone..
Mon, Mar 11, 10:54 PM
imp added a comment to D44281: timezone: Move to the XSI/POSIX definition for timezone..

So I don't think I need timezone.3 in the old files stuff...

Mon, Mar 11, 9:35 PM
imp added inline comments to D44281: timezone: Move to the XSI/POSIX definition for timezone..
Mon, Mar 11, 9:34 PM
imp updated the diff for D44281: timezone: Move to the XSI/POSIX definition for timezone..

update, per Brooks.

Mon, Mar 11, 9:33 PM
imp committed rG462af7676b3e: kboot: kbootfdt: fix error handling (authored by imp).
kboot: kbootfdt: fix error handling
Mon, Mar 11, 9:24 PM
imp committed rGd75524b3fe21: kboot: Use is_linux_error to check mmap return error (authored by imp).
kboot: Use is_linux_error to check mmap return error
Mon, Mar 11, 9:24 PM
imp committed rGa9cd3b675e24: kboot: Print UEFI memory map (authored by imp).
kboot: Print UEFI memory map
Mon, Mar 11, 9:24 PM
imp committed rGd650c3efb638: kboot: hostfs -- check for llseek failure correctly (authored by imp).
kboot: hostfs -- check for llseek failure correctly
Mon, Mar 11, 9:24 PM
imp committed rG8b1925f29c54: kboot: Avoid UB in signed shift (authored by imp).
kboot: Avoid UB in signed shift
Mon, Mar 11, 9:24 PM
imp committed rG3ae18fdfbcaa: kboot: Create function for error checking. (authored by imp).
kboot: Create function for error checking.
Mon, Mar 11, 9:24 PM
imp closed D44287: kboot: Print UEFI memory map.
Mon, Mar 11, 9:23 PM
imp closed D44286: kboot: hostfs -- check for llseek failure correctly.
Mon, Mar 11, 9:23 PM
imp closed D44285: kboot: Avoid UB behavior.
Mon, Mar 11, 9:23 PM

Sat, Mar 9

imp added inline comments to D44287: kboot: Print UEFI memory map.
Sat, Mar 9, 10:53 PM
imp added reviewers for D44286: kboot: hostfs -- check for llseek failure correctly: kevans, tsoome.
Sat, Mar 9, 10:52 PM
imp added reviewers for D44287: kboot: Print UEFI memory map: kevans, tsoome.
Sat, Mar 9, 10:52 PM
imp requested review of D44287: kboot: Print UEFI memory map.
Sat, Mar 9, 10:51 PM
imp added reviewers for D44285: kboot: Avoid UB behavior: jrtc27, kevans, tsoome.
Sat, Mar 9, 10:51 PM
imp requested review of D44286: kboot: hostfs -- check for llseek failure correctly.
Sat, Mar 9, 10:51 PM