Page MenuHomeFreeBSD
Feed Advanced Search

Thu, Sep 17

imp added a comment to D26471: Build debug kernels with -O2..

Will this screw up the tracebacks? One of the reason that I've compiled at lower O levels is to not have @#^#$Y up DEBUG kernels...

Thu, Sep 17, 9:29 PM
imp closed D26448: Move to a more conservative alloation scheme for devctl messages.
Thu, Sep 17, 5:29 PM
imp committed rS365843: Move to a more robust and conservative alloation scheme for devctl messages.
Move to a more robust and conservative alloation scheme for devctl messages
Thu, Sep 17, 5:29 PM

Wed, Sep 16

imp added a comment to D26448: Move to a more conservative alloation scheme for devctl messages.
In D26448#588627, @mjg wrote:

Given this already has support for reusing items from a global list, why uma allocation in the first place? Most notably why per-CPU caches. The current code does not scale regardless and is expensive to use, but with expected low msg rates it should be fine for the time being.

Wed, Sep 16, 8:50 PM
imp updated the summary of D26448: Move to a more conservative alloation scheme for devctl messages.
Wed, Sep 16, 8:32 PM
imp updated the diff for D26448: Move to a more conservative alloation scheme for devctl messages.

Another round of comment cleanup to make things more descriptive and less verbose.

Wed, Sep 16, 8:29 PM
imp updated the diff for D26448: Move to a more conservative alloation scheme for devctl messages.

Update some comments.

Wed, Sep 16, 8:25 PM
imp updated the diff for D26448: Move to a more conservative alloation scheme for devctl messages.

Fold in feedback from MarkJ

Wed, Sep 16, 7:26 PM
imp added inline comments to D26448: Move to a more conservative alloation scheme for devctl messages.
Wed, Sep 16, 6:04 PM
imp added a comment to D26453: Hack to install symlinks atomically..

Why do we install libgcc_s multiple times?

Wed, Sep 16, 3:54 PM
imp added a comment to D26450: Remove APM (series of commits, but shown as one for review).

You probably want to remove tools/build/options/WITHOUT_APM since that option is gone and update tools/build/options/WITHOUT_ACPI to indicate that it also governs the installation of the apm(8) userland utility. OptionalObsoleteFiles.inc probably need to take this into account also.

Wed, Sep 16, 3:30 PM
imp added a comment to D26220: Improve test coverage for sbuf.
In D26220#588231, @jmg wrote:

@jmg @imp I have seen other places where KASSERT was re-defined as

#define	KASSERT(exp,msg) assert((exp))

I think using assert should be used. It doesn't pollute stdout, generates a core dump, and is more obvious that there was a failure.

Thanks.

Wed, Sep 16, 7:15 AM · tests
imp requested review of D26450: Remove APM (series of commits, but shown as one for review).
Wed, Sep 16, 7:09 AM
imp committed rS365790: Use standard bool type, instead of non-standard boolean_t.
Use standard bool type, instead of non-standard boolean_t
Wed, Sep 16, 6:03 AM
imp added inline comments to D26448: Move to a more conservative alloation scheme for devctl messages.
Wed, Sep 16, 1:45 AM

Tue, Sep 15

imp updated the diff for D26448: Move to a more conservative alloation scheme for devctl messages.

Fix comment and silly lack of assignment. Tiny style tweaks too.

Tue, Sep 15, 11:21 PM
imp added inline comments to D26448: Move to a more conservative alloation scheme for devctl messages.
Tue, Sep 15, 11:16 PM
imp updated the test plan for D26448: Move to a more conservative alloation scheme for devctl messages.
Tue, Sep 15, 11:13 PM
imp requested review of D26448: Move to a more conservative alloation scheme for devctl messages.
Tue, Sep 15, 11:12 PM
imp committed rS365751: Include sys/types.h here.
Include sys/types.h here
Tue, Sep 15, 3:21 PM
imp added inline comments to D26428: Initial support for implementing the bootXXX.efi workaround.
Tue, Sep 15, 2:56 PM
imp added a comment to D26428: Initial support for implementing the bootXXX.efi workaround.

You description is wrong. No BIOS will boot off an EFI partition. Don't mix BIOS and UEFI firmware implementation.

Tue, Sep 15, 2:55 PM
imp accepted D26430: [PowerPC] Remove obsolete MK_LOADER_FORCE_LE.
Tue, Sep 15, 2:07 AM · PowerPC

Mon, Sep 14

imp committed rS365737: We don't need the sc_ekeys_lock in standalone environment..
We don't need the sc_ekeys_lock in standalone environment.
Mon, Sep 14, 11:51 PM
imp committed rS365735: Don't do the busy dance in icee_open/close.
Don't do the busy dance in icee_open/close
Mon, Sep 14, 11:30 PM
imp closed D26431: Don't do the busy dance in icee_open/close.
Mon, Sep 14, 11:30 PM
imp committed rS365734: Tweak what's visible in the standalone environment. We define offsetof.
Tweak what's visible in the standalone environment. We define offsetof
Mon, Sep 14, 11:28 PM
imp requested review of D26431: Don't do the busy dance in icee_open/close.
Mon, Sep 14, 10:36 PM
imp updated the diff for D26428: Initial support for implementing the bootXXX.efi workaround.

Add comment documenting why we only conditionally install bootx64.efi

Mon, Sep 14, 9:59 PM
imp added reviewers for D26428: Initial support for implementing the bootXXX.efi workaround: emaste, bcran.
Mon, Sep 14, 9:49 PM
imp requested review of D26428: Initial support for implementing the bootXXX.efi workaround.
Mon, Sep 14, 9:43 PM
imp added inline comments to D26399: [PowerPC64LE] Set up powerpc.powerpc64le architecture.
Mon, Sep 14, 7:41 PM · PowerPC
imp requested review of D26423: Integrate 4.4BSD-Lite2 changes to IOC_* definitions.
Mon, Sep 14, 5:43 PM
imp accepted D26390: Honor the FWUG value of some drives in nvmecontrol.

Looks good to me. I'd be tempted to commit the kernel and non-kernel parts separately since the kernel bits aren't directly related to the firmware downloading change, but merely facilitate it (and possibly other) uses.

Mon, Sep 14, 5:39 PM

Sat, Sep 12

imp committed rS365665: Update flp test for new diskinfo output.
Update flp test for new diskinfo output
Sat, Sep 12, 5:24 PM
imp committed rS365664: Fix trailing whitespace.
Fix trailing whitespace
Sat, Sep 12, 5:24 PM
imp committed rS365663: Make this compile again by fixing err args to have formats.
Make this compile again by fixing err args to have formats
Sat, Sep 12, 5:24 PM
imp accepted D26292: Reduce Duplication in sys/*/include files.

I think this is fine

Sat, Sep 12, 3:08 PM
imp added inline comments to D26395: cp: fall back to read/write if copy_file_range fails.
Sat, Sep 12, 2:16 AM

Fri, Sep 11

imp committed rS365645: Remove disk images / tests from alpha, sun and pc98.
Remove disk images / tests from alpha, sun and pc98
Fri, Sep 11, 11:38 PM
imp added a comment to D26340: run clang-format over vtfontcvt.c.

Is there a file which is already perfectly style(9) compliant? Is it this file?

Assuming a "perfect" file, we could then tweak the clang-format config iteratively, until we find the output which has the smallest diff, and then tweak clang-format to fix the remainder and bring the diff to 0.

Fri, Sep 11, 6:15 PM
imp added a comment to D17102: Add build-time option to boot0sio to reset terminal.

I think this is good. There's many other strings we might consider for the reset, but this is good.

Fri, Sep 11, 5:46 PM
imp accepted D26343: Improvements for src.conf(5) and build(7) man pages.

I'm happy now. Thanks for listening to my feedback.

Fri, Sep 11, 5:05 PM

Thu, Sep 10

imp accepted D26403: Disable WITNESS for spin locks by default..
Thu, Sep 10, 10:18 PM
imp added inline comments to D26343: Improvements for src.conf(5) and build(7) man pages.
Thu, Sep 10, 10:13 PM
imp committed rP548220: Disable python. This ancient version of gdb wants python2..
Disable python. This ancient version of gdb wants python2.
Thu, Sep 10, 7:04 PM
imp added a comment to D26395: cp: fall back to read/write if copy_file_range fails.

Minor nit, which could report a bad write total in some rare circumstances is the only issue I see.

Thu, Sep 10, 6:16 PM

Wed, Sep 9

imp added inline comments to D26364: stand/ficl 64-bit compatibility.
Wed, Sep 9, 11:41 PM · PowerPC
imp accepted D26381: Mark i386 as Tier 2 starting in FreeBSD 13.0..
Wed, Sep 9, 11:38 PM
imp accepted D26380: Update tier info for MIPS and sparc64..
Wed, Sep 9, 11:36 PM
imp committed rS365544: MFC r365016 | imp | 2020-08-31 17:48:23 -0600 (Mon, 31 Aug 2020) | 2 lines.
MFC r365016 | imp | 2020-08-31 17:48:23 -0600 (Mon, 31 Aug 2020) | 2 lines
Wed, Sep 9, 11:06 PM
imp committed rS365543: MFC r365015:.
MFC r365015:
Wed, Sep 9, 11:05 PM
imp committed rS365542: MFC: r365009.
MFC: r365009
Wed, Sep 9, 11:04 PM
imp committed rS365541: MFC r364824:.
MFC r364824:
Wed, Sep 9, 11:02 PM
imp committed rS365540: MFC r364725, r364726.
MFC r364725, r364726
Wed, Sep 9, 11:00 PM
imp committed rS365539: MFC: 364430:.
MFC: 364430:
Wed, Sep 9, 10:54 PM
imp committed rS365538: MFC r364424:.
MFC r364424:
Wed, Sep 9, 10:52 PM
imp committed rS365537: MFC r364359, r364360, r364361, r364362, r364364, r364370.
MFC r364359, r364360, r364361, r364362, r364364, r364370
Wed, Sep 9, 10:49 PM
imp committed rS365536: MFC r364335,r364336,r364337,r364351.
MFC r364335,r364336,r364337,r364351
Wed, Sep 9, 10:45 PM
imp committed rS365535: MFC r364291:.
MFC r364291:
Wed, Sep 9, 10:42 PM
imp committed rS365533: MFC r363408:.
MFC r363408:
Wed, Sep 9, 10:40 PM
imp committed rS365532: MFC r362664, r362665:.
MFC r362664, r362665:
Wed, Sep 9, 10:38 PM
imp committed rS365531: MFC r362420:.
MFC r362420:
Wed, Sep 9, 10:36 PM
imp committed rS365530: MFC: r361882:.
MFC: r361882:
Wed, Sep 9, 10:33 PM
imp committed rS365529: MFC: r361868:.
MFC: r361868:
Wed, Sep 9, 10:30 PM
imp committed rS365528: MFC r361867:.
MFC r361867:
Wed, Sep 9, 10:30 PM
imp committed rS365527: MFC r361673:.
MFC r361673:
Wed, Sep 9, 10:24 PM
imp committed rS365526: MFC r360993:.
MFC r360993:
Wed, Sep 9, 10:22 PM
imp added inline comments to D26340: run clang-format over vtfontcvt.c.
Wed, Sep 9, 10:12 PM
imp added a comment to D26369: Clean up gprof.

Only support aout.c on i386 & amd64

Wed, Sep 9, 6:32 PM
imp added inline comments to D26369: Clean up gprof.
Wed, Sep 9, 3:56 PM
imp accepted D26364: stand/ficl 64-bit compatibility.
Wed, Sep 9, 1:10 AM · PowerPC

Sat, Sep 5

imp added inline comments to D26340: run clang-format over vtfontcvt.c.
Sat, Sep 5, 9:24 PM
imp added a comment to D26340: run clang-format over vtfontcvt.c.

One of the big advantages of style(9) has always been it's been a range of acceptable behavior. As we've loosed the strict dogma over the years, it provided a large enough space that people stopped fighting over style issues... Going to a strict, at checkin time, thing would a huge step backwards. clang-format fixes a few issues, but still causes far more issues than it fixes. It's OK if someone wants to run it on their code that has a radically different format, but for things that are close, I don't see the value.

Sat, Sep 5, 8:45 PM
imp added a comment to D26340: run clang-format over vtfontcvt.c.

meh, not a very good job. I see only one actual formatting bug in all these changes, though the headers are arguably slightly better modulo the double inclusion.

Sat, Sep 5, 8:36 PM
imp accepted D26337: Turn MALLOC_PRODUCTION into a regular src.conf(5) option.
Sat, Sep 5, 4:58 PM
imp added a comment to D26044: Stop using lorder and ranlib when building libraries.
In D26044#578026, @imp wrote:

Probably closer to ~2000 for the cut-over date. Toolchains in the 90s did support indexing, but I ran into several cases where lorder helped even though it shouldn't have... That did stop being the case sometime in the early 2000s, though... At least for static libraries. Dynamic ones did indeed work from about the mid 1990's w/o ranlib/tsort/lorder. Linux's a.out libraries being the last one I recall where that was beneficial.

The main risk here is that it reorders all the .o's and may cause too long of a call/jump that didn't happen before... Not a case I think we need to seriously worry about, but the possibility reinforces the notion of a universe before this commit.

Quibbles aside, i like this. There's a minor downside to the ARFLAGS change, but not enough of one to worry about. It will increase disk usage in builds a bit, but only in edge cases. The clarity and simplicity of the resulting use more than make up for some folks with extremely old code-bases that might have to adjust, or those that have added it by hand to their make files. This risk suggests an exprun might be warranted.

I think this is unlikely to break anything other than duplicated sources so I was planning to commit it on Monday. @imp is this okay or should I ask for an exprun?

Sat, Sep 5, 3:46 PM
imp accepted D24276: ci-qemu-test.sh: use pkgbase.
Sat, Sep 5, 4:27 AM
imp committed rS365358: Fix typo in comment..
Fix typo in comment.
Sat, Sep 5, 4:21 AM

Fri, Sep 4

imp added inline comments to D24276: ci-qemu-test.sh: use pkgbase.
Fri, Sep 4, 3:35 PM

Thu, Sep 3

imp added a comment to D26284: Make device_busy/unbusy work w/o Giant held.
In D26284#584505, @jhb wrote:

I'd rather axe device_busy and instead require drivers to use device_quiesce.

However, this does mean that bus drivers need to use a bus_generic_quiesce that recurses to preserve the "device_busy of the parent" semantic.

Thu, Sep 3, 11:58 PM
imp added a comment to D26302: Don't do the busy dance in icee_open/close.
In D26302#584633, @ian wrote:

So, what prevents "kldunload icee" while someone has the cdev open?

Thu, Sep 3, 3:16 AM

Wed, Sep 2

imp accepted D26286: cam_sim: harmonize code related to acquiring a mtx.

This looks fine to me.

Wed, Sep 2, 7:00 PM
imp requested review of D26302: Don't do the busy dance in icee_open/close.
Wed, Sep 2, 5:43 PM
imp added a comment to D26220: Improve test coverage for sbuf.

@jmg @imp Need your input how to proceed on the sbuf_negative test.

Wed, Sep 2, 5:31 PM · tests
imp closed D24762: Implement aliases in a way that actually work..

Fixed in r361015

Wed, Sep 2, 3:35 PM
imp committed rS365249: Add note about needing to manually import the zfs pools or update.
Add note about needing to manually import the zfs pools or update
Wed, Sep 2, 2:29 PM
imp accepted D26289: Remove risky compatability with old kernels..

Kill it with fire

Wed, Sep 2, 3:52 AM

Tue, Sep 1

imp accepted D26288: Log ENOSYS in init.

badsys is a piece of work...

Tue, Sep 1, 9:08 PM
imp added a reviewer for D26284: Make device_busy/unbusy work w/o Giant held: jhb.
Tue, Sep 1, 5:24 PM
imp requested review of D26284: Make device_busy/unbusy work w/o Giant held.
Tue, Sep 1, 5:22 PM
imp committed rS365053: Bump date for r365052.
Bump date for r365052
Tue, Sep 1, 4:13 PM
imp committed rS365052: Have script accept and ignore -e for Linux compat.
Have script accept and ignore -e for Linux compat
Tue, Sep 1, 4:11 PM
imp committed rS365027: Update to today's date.
Update to today's date
Tue, Sep 1, 7:56 AM
imp committed rS365026: Add defines for OpenZFS variables.
Add defines for OpenZFS variables
Tue, Sep 1, 7:54 AM
imp committed rS365025: Very preliminary loader.efi(8) man page.
Very preliminary loader.efi(8) man page
Tue, Sep 1, 7:54 AM
imp committed rS365024: Document boot1.efi.
Document boot1.efi
Tue, Sep 1, 7:46 AM
imp committed rS365022: Smaller crc for the boot loader..
Smaller crc for the boot loader.
Tue, Sep 1, 4:38 AM
imp closed D24225: Save 7k of text space by using simpler crc32 for standalone case..
Tue, Sep 1, 4:38 AM

Mon, Aug 31

imp committed rS365016: Add documentation for ETHERNET events..
Add documentation for ETHERNET events.
Mon, Aug 31, 11:48 PM