kern: osd: trash a slot's methods upon deregistration
AcceptedPublic
Actions

Authored by kevans on Dec 14 2024, 4:21 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, May 23, 8:35 PM

	Unknown Object (File)
	Apr 25 2025, 6:41 PM

	Unknown Object (File)
	Apr 23 2025, 8:10 AM

	Unknown Object (File)
	Apr 15 2025, 3:26 PM

	Unknown Object (File)
	Apr 15 2025, 3:25 PM

	Unknown Object (File)
	Apr 15 2025, 9:25 AM

	Unknown Object (File)
	Apr 15 2025, 4:26 AM

	Unknown Object (File)
	Apr 8 2025, 9:46 AM

View All 18 Files

Subscribers

imp

olce

Details

Reviewers

markj
jamie
pjd
imp

Summary

This both lets us quickly identify a slot that's been deallocated while
debugging, and forces us to take a fault if something tries to call one
of the methods anyways somehow with osd_destructors[slot - 1] == NULL.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 61153
Build 58037: arc lint + arc unit

Event Timeline

kevans created this revision.Dec 14 2024, 4:21 AM

Herald added subscribers: olce, imp. · View Herald TranscriptDec 14 2024, 4:21 AM

kevans requested review of this revision.Dec 14 2024, 4:21 AM

kevans added a parent revision: D48074: kern: osd: abstract away the math for locating a slot method.

Harbormaster completed remote builds in B61153: Diff 147948.Dec 14 2024, 4:21 AM

jamie mentioned this in D48074: kern: osd: abstract away the math for locating a slot method.Dec 14 2024, 4:44 AM

imp accepted this revision.Dec 14 2024, 4:45 AM

This revision is now accepted and ready to land.Dec 14 2024, 4:45 AM

Accepted with the caveat I mentioned in D48074.

Revision Contents
Changeset List

Path

Size

sys/

kern/

kern_osd.c

12 lines

Diff 147948

View Options

kern: osd: trash a slot's methods upon deregistrationAcceptedPublicActions