kern: osd: trash a slot's methods upon deregistration
ClosedPublic
Actions

Authored by kevans on Dec 14 2024, 4:21 AM.

Details

Reviewers

markj
jamie
pjd
imp

Commits

rG4ffa7e126ed0: kern: osd: trash a slot's methods upon deregistration

Summary

This both lets us quickly identify a slot that's been deallocated while
debugging, and forces us to take a fault if something tries to call one
of the methods anyways somehow with osd_destructors[slot - 1] == NULL.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kevans created this revision.Dec 14 2024, 4:21 AM

Herald added subscribers: olce, imp. · View Herald TranscriptDec 14 2024, 4:21 AM

kevans requested review of this revision.Dec 14 2024, 4:21 AM

kevans added a parent revision: D48074: kern: osd: abstract away the math for locating a slot method.

Harbormaster completed remote builds in B61153: Diff 147948.Dec 14 2024, 4:21 AM

jamie mentioned this in D48074: kern: osd: abstract away the math for locating a slot method.Dec 14 2024, 4:44 AM

imp accepted this revision.Dec 14 2024, 4:45 AM

This revision is now accepted and ready to land.Dec 14 2024, 4:45 AM

Accepted with the caveat I mentioned in D48074.

Closed by commit rG4ffa7e126ed0: kern: osd: trash a slot's methods upon deregistration (authored by kevans). · Explain WhyJun 25 2026, 3:09 AM

This revision was automatically updated to reflect the committed changes.

kevans added a commit: rG4ffa7e126ed0: kern: osd: trash a slot's methods upon deregistration.

Revision Contents
Changeset List

Path

Size

sys/

kern/

kern_osd.c

12 lines

Diff 180596

View Options

kern: osd: trash a slot's methods upon deregistrationClosedPublicActions