I'm OK with this, but I note that the -r option isn't documented at all because it wasn't actually supposed to be generally useful. We should probably fix that so that this message makes sense, since it *is* generally useful (for precisely scenarios like this).

Use allocf, matches lua's internal naming

We could continue to omit the NM record for directories that would avoid
mapping (for example, one named 1234.567) but this does not seem worth
the complexity.

This matches my reading of the spec; single LE DWORD.

Incorporate further fixes, notably:

In D39140#890858, @kib wrote:

No objections, but IMO it would be slightly cleaner to check the condition in identify_hypervisor_smbios() and immediately return, instead of asserting.

s/1/STATUS_ERROR/ per review comment

Switch to a fixed ARG_MAX * 2 buffer instead of complicating it with realloc()

See also: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=270239, this is the cause of at least Hyper-V failing to boot.

Run away

Abandoning in favor of D37424, which actually goes the other way and removes the resource_spec.

I'm actually happy with this as-is whether we go the extra step right now or not, forgot to click the button.

IMO let's go one step further and remove the significance of the index into sc->irqs

s/usersapce/userspace/ in subject line

• Not finding a required interrupt in interrupt-names now errors out
• Less verbose when we can't find optional interrupt-names, bootverbose to bring them back. A large number of platforms won't have hypervisor timers, so this would otherwise add at least two lines worth of noise for non-error scenarios.

Split out acpi/fdt attach functions and allocate interrupts there

• Drop "all rights reserved", as per emaste 2021/01/05
• Correct red offset

Tested only on my M1 Mac for the moment.

In D30079#885639, @andrew wrote:

Does the M1 work if you have this patch, D34333, and the following change?

I had to do this kind of nasty feeling patch to get devices right on M1: https://people.freebsd.org/~kevans/m1/pci-mapping.diff -- I don't know if there's a better way to have done that, or if a custom bus_activate_resource that handles the mapping is really just the way to go.

Abandon in favor of D34333