User Details
- User Since
- Oct 2 2015, 1:17 PM (502 w, 2 d)
Fri, May 16
Thu, May 15
It's a good cleanup, even if it doesn't solve the problem.
Wed, May 14
Tue, May 13
Fix Dag-Erling's test in D50296
Mon, May 12
Implementation looks fine to me; it does make me wish that we'd settle on an appropriate test framework for lua, though. I'd love to have a test that confirms that the argv[0] behavior works as expected (and doesn't, e..g, crash when it's omitted). I don't insist on trying to solve that kind of problem before proceeding here, though... just something to think about.
Sun, May 11
I do wonder if @jmmv has an opinion, if he still gets/reads phab e-mail there, but I don't see off-hand why atf shouldn't try to function in these kinds of environments.
Sat, May 10
Thu, May 8
IMO you don't get the privilege of wearing the hat just because you didn't have a smaller display to test on. I don't think it's unreasonable to expect that we would choose a sensible font with all of these options at hand.
Need to fix the title... should've mentioned NFSv4 ACLs. *sigh*
Wed, May 7
I forgot to note that this is a conformance motivated change, but I might need to go reread the spec and see if maybe we should flush then re-raise instead
Rebase and hit a few more devctl_notify() callers
Tap in bapt, too, since this could slightly change some nlsysevent semantics in more edgey cases.
Rebase past nlsysevent's devctl tap
Tue, May 6
Mon, May 5
Sat, May 3
Thu, May 1
Wed, Apr 30
Tue, Apr 29
LGTM modulo the minor typos noted by @jlduran, but happy enough for those to be fixed pre-commit.
Mon, Apr 28
Sun, Apr 27
Sat, Apr 26
Fri, Apr 25
Thu, Apr 24
Wed, Apr 23
If you're up for it, adding _FORTIFY_SOURCE support for this would be nearly trivial. The __ssp_redirect pattern for arc4random_buf in include/ssp/stdlib.h can be copied for this (the __buf and __len names are significant and used in the implementation for size-checking, other names are fair game) and tests added easily by copying arc4random_buf again in lib/libc/tests/secure/generate-fortify-tests.lua (regeneration requires devel/lua-luacheck for make generate-tests).
Tue, Apr 22
Please amend the commit message to point out that this may be worth a COMPILER_FEATURES entry in case it inspires someone to try and add more blocks stuff elsewhere, but it is hard to see the value with this little of proliferation at the moment
Mon, Apr 21
On second thought, I'm not so sure this will work anyways... I'd need to finish the sbuf in order to tap out a copy for netlink, since sbuf_data() is only guaranteed to work on a finished sbuf.
Seems reasonable to me, thanks!