Page MenuHomeFreeBSD

kevans (Kyle Evans)
User

Projects (9)

User Details

User Since
Oct 2 2015, 1:17 PM (502 w, 2 d)

Recent Activity

Fri, May 16

kevans accepted D50302: man: Exit cleanly on SIGPIPE..
Fri, May 16, 1:13 PM

Thu, May 15

kevans accepted D50360: libusb: use eventfd.

It's a good cleanup, even if it doesn't solve the problem.

Thu, May 15, 2:12 PM

Wed, May 14

kevans committed rG964557fe9807: mail: exit with the correct exit status on SIGHUP in send mode (authored by kevans).
mail: exit with the correct exit status on SIGHUP in send mode
Wed, May 14, 7:21 PM
kevans committed rGdf16cbdcf192: mail: remove the SIGHUP handler from lex.c (authored by kevans).
mail: remove the SIGHUP handler from lex.c
Wed, May 14, 7:21 PM
kevans closed D50251: mail: exit with the correct exit status on SIGHUP.
Wed, May 14, 7:21 PM
kevans closed D50247: mail: remove the SIGHUP handler from lex.c.
Wed, May 14, 7:21 PM
kevans accepted D50296: mail: Add test cases for SIGHUP..
Wed, May 14, 6:19 PM
kevans added a comment to D50339: libpam: provide a real /etc/pam.d/ftp.
In D50339#1148754, @ivy wrote:
In D50339#1148701, @des wrote:

I would prefer fixing the mk scripts, if that's not too much work?

i don't think this is a problem in the mk scripts, the Makefile just wasn't accounting for the fact that the file is in a non-default conf group. unless there's something else to fix here?

Wed, May 14, 12:11 PM
kevans added inline comments to D50339: libpam: provide a real /etc/pam.d/ftp.
Wed, May 14, 2:25 AM

Tue, May 13

kevans added inline comments to D50296: mail: Add test cases for SIGHUP..
Tue, May 13, 6:21 PM
kevans updated the diff for D50251: mail: exit with the correct exit status on SIGHUP.

Fix Dag-Erling's test in D50296

Tue, May 13, 5:46 PM

Mon, May 12

kevans added a comment to D50177: flua: add posix.unistd.execp.

Implementation looks fine to me; it does make me wish that we'd settle on an appropriate test framework for lua, though. I'd love to have a test that confirms that the argv[0] behavior works as expected (and doesn't, e..g, crash when it's omitted). I don't insist on trying to solve that kind of problem before proceeding here, though... just something to think about.

Mon, May 12, 5:35 PM

Sun, May 11

kevans accepted D50267: atf: Don't be deterred by weird umasks..

I do wonder if @jmmv has an opinion, if he still gets/reads phab e-mail there, but I don't see off-hand why atf shouldn't try to function in these kinds of environments.

Sun, May 11, 1:55 AM
kevans accepted D49843: jail: add allow.routing jail permission.
Sun, May 11, 1:52 AM
kevans updated subscribers of D49843: jail: add allow.routing jail permission.
Sun, May 11, 1:52 AM
kevans added inline comments to D50292: deprecate RIP.
Sun, May 11, 1:48 AM

Sat, May 10

kevans accepted D50273: flua: clean up lposix argument checking.
Sat, May 10, 1:56 PM

Thu, May 8

kevans added inline comments to D50251: mail: exit with the correct exit status on SIGHUP.
Thu, May 8, 7:49 PM
kevans committed rG78661696e639: loader: i386: use -z nostart-stop-gc for bfd as well (authored by kevans).
loader: i386: use -z nostart-stop-gc for bfd as well
Thu, May 8, 7:48 PM
kevans closed D50252: loader: i386: use -z nostart-stop-gc for bfd as well.
Thu, May 8, 7:48 PM
kevans accepted D50259: stand: Revert adding Spleen 32x64.

IMO you don't get the privilege of wearing the hat just because you didn't have a smaller display to test on. I don't think it's unreasonable to expect that we would choose a sensible font with all of these options at hand.

Thu, May 8, 7:40 PM
kevans retitled D50260: libc: nfsv4 acls: flip 'd' and 'D' in table definitions from libc: flip 'd' and 'D' in nfs4 acl definitions to libc: nfsv4 acls: flip 'd' and 'D' in table definitions.
Thu, May 8, 7:20 PM
kevans added a reviewer for D50260: libc: nfsv4 acls: flip 'd' and 'D' in table definitions: walker.aj325_gmail.com.

Need to fix the title... should've mentioned NFSv4 ACLs. *sigh*

Thu, May 8, 7:19 PM
kevans requested review of D50260: libc: nfsv4 acls: flip 'd' and 'D' in table definitions.
Thu, May 8, 7:19 PM
kevans accepted D50233: fts: Add FTS_COMFOLLOWDIR and FTS_NOSTAT_TYPE..
Thu, May 8, 11:49 AM
kevans added inline comments to D50233: fts: Add FTS_COMFOLLOWDIR and FTS_NOSTAT_TYPE..
Thu, May 8, 11:49 AM
kevans requested review of D50252: loader: i386: use -z nostart-stop-gc for bfd as well.
Thu, May 8, 4:20 AM
kevans committed rG354fb783e6d5: loader: ficl: restore isvirtualized? (authored by kevans).
loader: ficl: restore isvirtualized?
Thu, May 8, 4:07 AM
kevans added a comment to D50247: mail: remove the SIGHUP handler from lex.c.
In D50247#1146172, @imp wrote:

Oh, wait, sighup? That's different...
I think that's there so mail doesn't go into an infinite loop. But that maybe obsolete since the tty driver is now sane

Thu, May 8, 2:06 AM
kevans requested review of D50251: mail: exit with the correct exit status on SIGHUP.
Thu, May 8, 1:49 AM
kevans added a reviewer for D50247: mail: remove the SIGHUP handler from lex.c: des.
Thu, May 8, 1:34 AM
kevans accepted D50190: Remove remaining mentions of pr_usrreq..
Thu, May 8, 1:26 AM
kevans accepted D50234: fts: Add tests for most FTS options..
Thu, May 8, 1:25 AM
kevans accepted D50235: fts: Give the blocks test a description..
Thu, May 8, 1:22 AM
kevans added inline comments to D50233: fts: Add FTS_COMFOLLOWDIR and FTS_NOSTAT_TYPE..
Thu, May 8, 1:03 AM

Wed, May 7

kevans added inline comments to D50241: Teach ngctl to attach and run itself in a jail..
Wed, May 7, 9:41 PM
kevans added a comment to D50247: mail: remove the SIGHUP handler from lex.c.
In D50247#1146048, @ivy wrote:

that seems reasonable to me, but did you consider the other places it handles SIGHUP, e.g. collect.c?

Wed, May 7, 9:24 PM
kevans added a comment to D50241: Teach ngctl to attach and run itself in a jail..

Check out https://docs.freebsd.org/en/articles/license-guide/ or style.9 from current, there is a much shorter text you can use now. EDIT: This was for your other review, sorry.

That makes sense as I'm not comfortable changing licenses for existing code. But do you mean I should change for both D50244 and D50245 ? I think I just realized I did the usual thing of copying sys/netgraph/ng_sample.[ch] for creating ng_wormhole.[ch] and it has the "WHISTLE COMMUNICATIONS" disclaimer.

Should I change both to the much shorter text?

Wed, May 7, 9:08 PM
kevans added a comment to D50247: mail: remove the SIGHUP handler from lex.c.
In D50247#1146023, @ivy wrote:

I forgot to note that this is a conformance motivated change

can you please link the relevant standard?

Wed, May 7, 8:59 PM
kevans added inline comments to D50241: Teach ngctl to attach and run itself in a jail..
Wed, May 7, 8:53 PM
kevans accepted D50218: fts: Drop obsolete conditionals..
Wed, May 7, 8:50 PM
kevans added a comment to D50247: mail: remove the SIGHUP handler from lex.c.

I forgot to note that this is a conformance motivated change, but I might need to go reread the spec and see if maybe we should flush then re-raise instead

Wed, May 7, 8:17 PM
kevans added a comment to D50247: mail: remove the SIGHUP handler from lex.c.
In D50247#1146012, @imp wrote:

It flushesmore stdio output...
But i don't think that matters these days...
Back in the 80s it helped with debugging lex bugs iirc

Wed, May 7, 8:14 PM
kevans requested review of D50247: mail: remove the SIGHUP handler from lex.c.
Wed, May 7, 7:49 PM
kevans accepted D50242: mbuf: Allow clusters to fill an entire jumbo page..
Wed, May 7, 6:21 PM
kevans updated the diff for D34505: kern: switch various devfs_notify() callers to devfs_notifyf().

Rebase and hit a few more devctl_notify() callers

Wed, May 7, 1:39 AM
kevans added a reviewer for D34504: kern: add devctl_notifyf(): bapt.

Tap in bapt, too, since this could slightly change some nlsysevent semantics in more edgey cases.

Wed, May 7, 1:06 AM
kevans updated the diff for D34504: kern: add devctl_notifyf().

Rebase past nlsysevent's devctl tap

Wed, May 7, 1:05 AM

Tue, May 6

kevans accepted D50195: service: Use explicit path for /usr/bin/env.
Tue, May 6, 3:49 PM
kevans added inline comments to D50063: net/if_dl.h: put kernel decls behind _KERNEL.
Tue, May 6, 3:12 PM
kevans added inline comments to D50063: net/if_dl.h: put kernel decls behind _KERNEL.
Tue, May 6, 2:04 AM
kevans accepted D50113: rc.conf.5: add a missing word in the description of $ipv6_enable.
Tue, May 6, 2:02 AM
kevans added inline comments to D50063: net/if_dl.h: put kernel decls behind _KERNEL.
Tue, May 6, 12:31 AM

Mon, May 5

kevans added a comment to D50065: net/if_dl.h: make self-contained.

I'd vote against putting it back. I submitted patch to the port upstream.

Mon, May 5, 10:22 PM
kevans accepted D50144: libcrypto: move engines and modules to openssl-lib.
Mon, May 5, 10:15 PM
kevans added inline comments to D50144: libcrypto: move engines and modules to openssl-lib.
Mon, May 5, 9:02 PM
kevans accepted D50166: Add a shutdown precaution measure.
Mon, May 5, 1:17 PM

Sat, May 3

kevans accepted D50135: rc.d: remove obsolete /etc/rc.d/keyserv.
Sat, May 3, 3:39 PM

Thu, May 1

kevans added inline comments to D50099: netinet6: make RFC4291 anycast conformance a sysctl.
Thu, May 1, 2:36 PM
kevans added inline comments to D50092: mail: Further refine the SIGINT test..
Thu, May 1, 2:05 PM

Wed, Apr 30

kevans added inline comments to D50065: net/if_dl.h: make self-contained.
Wed, Apr 30, 3:39 AM
kevans added inline comments to D50065: net/if_dl.h: make self-contained.
Wed, Apr 30, 3:23 AM

Tue, Apr 29

kevans accepted D50021: nuageinit: implement chpasswd.

LGTM modulo the minor typos noted by @jlduran, but happy enough for those to be fixed pre-commit.

Tue, Apr 29, 1:50 PM
kevans accepted D50069: mail: Exit non-zero on failure to collect mail..
Tue, Apr 29, 1:40 PM

Mon, Apr 28

kevans added a comment to D49970: queue: Consistent single space after all #define.
In D49970#1141594, @jhb wrote:

Hmm, isn't this backwards as style(9) requires tabs? Probably not worth swapping back at this point, but maybe avoid future style regressions?

Mon, Apr 28, 3:54 PM
kevans accepted D50050: wpa_supplicant: Use PF_LOCAL instead of PF_INET*.
Mon, Apr 28, 1:51 PM

Sun, Apr 27

kevans committed rG09e0a909fb07: tee: try opening as a UNIX socket if open(2) fails (authored by kevans).
tee: try opening as a UNIX socket if open(2) fails
Sun, Apr 27, 7:00 PM

Sat, Apr 26

kevans committed rGe5a4712e6557: libpmcstat: fix pmcstat -G on older-ish -CURRENT w/ drm-kmod (authored by kevans).
libpmcstat: fix pmcstat -G on older-ish -CURRENT w/ drm-kmod
Sat, Apr 26, 3:25 AM
kevans committed rG8dc42b80fdfb: libbe: don't hardcode /tmp (authored by kevans).
libbe: don't hardcode /tmp
Sat, Apr 26, 3:25 AM
kevans committed rG0635fe29225b: libbe: attempt to remove autocreated mountpoints at unmount time (authored by kevans).
libbe: attempt to remove autocreated mountpoints at unmount time
Sat, Apr 26, 3:25 AM
kevans added a reverting change for rG6e824f371301: time: siginfo_recvd needs to be marked volatile: rG8b42f57eebde: time: switch to fences for siginfo_recvd.
Sat, Apr 26, 3:22 AM
kevans committed rG8b42f57eebde: time: switch to fences for siginfo_recvd (authored by kevans).
time: switch to fences for siginfo_recvd
Sat, Apr 26, 3:22 AM
kevans committed rG73f88915a119: wireguard-tools: ipc: freebsd: use AF_LOCAL for the control socket (authored by kevans).
wireguard-tools: ipc: freebsd: use AF_LOCAL for the control socket
Sat, Apr 26, 3:22 AM
kevans committed rGba560cd8fba3: wg: Improve wg_peer_alloc() to simplify the calling (authored by aly_aaronly.me).
wg: Improve wg_peer_alloc() to simplify the calling
Sat, Apr 26, 3:22 AM
kevans committed rG25512b1fca07: libc: locale: fix EUC shift check (authored by kevans).
libc: locale: fix EUC shift check
Sat, Apr 26, 3:22 AM
kevans committed rGc195ae95912a: bintrans: disable argument permutation for qp and base64 (authored by kevans).
bintrans: disable argument permutation for qp and base64
Sat, Apr 26, 3:22 AM
kevans committed rG99509fcc8733: tee: minor cleanup (authored by kevans).
tee: minor cleanup
Sat, Apr 26, 3:22 AM
kevans committed rG00640ea3144c: tee: add some basic tests (authored by kevans).
tee: add some basic tests
Sat, Apr 26, 3:22 AM

Fri, Apr 25

kevans added inline comments to D50034: efivar: Test uuid against zero.
Fri, Apr 25, 7:36 PM
kevans accepted D50019: tcp: allow connections to IPv6 anycast address.
Fri, Apr 25, 6:31 PM
kevans accepted D50011: mail: Don't trap signals we shouldn't..
Fri, Apr 25, 1:56 PM

Thu, Apr 24

kevans added inline comments to D50011: mail: Don't trap signals we shouldn't..
Thu, Apr 24, 10:49 PM
kevans accepted D49979: libc: Add getenv_r() function..
Thu, Apr 24, 6:22 PM

Wed, Apr 23

kevans accepted D49875: nuageinint: implement ssh_pwauth.
Wed, Apr 23, 2:24 PM
kevans accepted D49979: libc: Add getenv_r() function..

If you're up for it, adding _FORTIFY_SOURCE support for this would be nearly trivial. The __ssp_redirect pattern for arc4random_buf in include/ssp/stdlib.h can be copied for this (the __buf and __len names are significant and used in the implementation for size-checking, other names are fair game) and tests added easily by copying arc4random_buf again in lib/libc/tests/secure/generate-fortify-tests.lua (regeneration requires devel/lua-luacheck for make generate-tests).

Wed, Apr 23, 12:52 PM

Tue, Apr 22

kevans accepted D49877: fts: Add blocks support..

Please amend the commit message to point out that this may be worth a COMPILER_FEATURES entry in case it inspires someone to try and add more blocks stuff elsewhere, but it is hard to see the value with this little of proliferation at the moment

Tue, Apr 22, 5:09 PM
kevans added inline comments to D49877: fts: Add blocks support..
Tue, Apr 22, 3:23 PM

Mon, Apr 21

kevans added inline comments to D49945: libsbuf: add an sbuf_prepend() API.
Mon, Apr 21, 9:43 PM
kevans added inline comments to D49945: libsbuf: add an sbuf_prepend() API.
Mon, Apr 21, 8:09 PM
kevans added a comment to D49945: libsbuf: add an sbuf_prepend() API.

On second thought, I'm not so sure this will work anyways... I'd need to finish the sbuf in order to tap out a copy for netlink, since sbuf_data() is only guaranteed to work on a finished sbuf.

Mon, Apr 21, 7:16 PM
kevans accepted D49835: Add minimal flua(1) man page.

Seems reasonable to me, thanks!

Mon, Apr 21, 7:07 PM · manpages, Restricted Project
kevans requested review of D49945: libsbuf: add an sbuf_prepend() API.
Mon, Apr 21, 7:01 PM
kevans requested review of D49944: libsbuf: switch to using libc's Versions.def.
Mon, Apr 21, 7:01 PM
kevans committed rG77721403c91d: libpmcstat: fix pmcstat -G on older-ish -CURRENT w/ drm-kmod (authored by kevans).
libpmcstat: fix pmcstat -G on older-ish -CURRENT w/ drm-kmod
Mon, Apr 21, 4:00 AM
kevans closed D39875: libpmcstat: fix pmcstat -G on recent -CURRENT w/ drm-kmod.
Mon, Apr 21, 4:00 AM
kevans committed rG8bf37c868f45: getfacl: implement --skip-base (-s) (authored by kevans).
getfacl: implement --skip-base (-s)
Mon, Apr 21, 3:58 AM
kevans committed rGec8e79c4e4cf: getfacl: add some long options for Linux compatibility (authored by kevans).
getfacl: add some long options for Linux compatibility
Mon, Apr 21, 3:58 AM
kevans closed D40603: getfacl: implement --skip-base (-s).
Mon, Apr 21, 3:58 AM
kevans closed D40602: getfacl: add some long options for Linux compatibility.
Mon, Apr 21, 3:58 AM
kevans committed rG2f11393fee4d: libbe: don't hardcode /tmp (authored by kevans).
libbe: don't hardcode /tmp
Mon, Apr 21, 3:50 AM