Page MenuHomeFreeBSD

kevans (Kyle Evans)
User

Projects

User Details

User Since
Oct 2 2015, 1:17 PM (184 w, 6 d)

Recent Activity

Today

kevans added a comment to D16402: Add TIOCFBAUD UART ioctl to allow fractional baudrates.

Allow preventing RTS/DTR from being asserted on open()
RTTY Radios are generally wired up to start transmitting when RTS is
asserted. While most older radios use relays, so it can be turned off fast
enough to prevent a transmission, newer radios use solid-state switching.
This change allows preventing RTS from being pulsed. Since many of the
searches online for an existing API resulted in threads where people wanted
to avoid asserting DTR on open(), added that as well.
This isn't an ideal interface, since it requires you to use stty on the init
device before opening it, but it's certainly easier than adding yet another
set of devices to the /dev/tty and /dev/cua family.

Thu, Apr 18, 3:46 AM

Yesterday

kevans committed rS346328: Compile sha1.c when ether support is included.
Compile sha1.c when ether support is included
Wed, Apr 17, 6:08 PM
kevans committed rS346326: iflib: Use new ether_gen_addr, restricting addresses to that subset.
iflib: Use new ether_gen_addr, restricting addresses to that subset
Wed, Apr 17, 5:20 PM
kevans closed D19587: net: adjust randomized address bits.
Wed, Apr 17, 5:19 PM
kevans committed rS346324: net: adjust randomized address bits.
net: adjust randomized address bits
Wed, Apr 17, 5:18 PM
kevans committed rS346307: fdt: further consolidate DTB building and revise manpage.
fdt: further consolidate DTB building and revise manpage
Wed, Apr 17, 3:29 AM
kevans closed D19736: fdt: further consolidate DTB building and revise manpage.
Wed, Apr 17, 3:29 AM

Tue, Apr 16

kevans committed rS346304: MFC r345519: DTS/DTSO makeoptions.
MFC r345519: DTS/DTSO makeoptions
Tue, Apr 16, 9:10 PM
kevans committed rS346303: MFC r345192-r345194: if_bridge(4): Drop pointless rtflush.
MFC r345192-r345194: if_bridge(4): Drop pointless rtflush
Tue, Apr 16, 9:02 PM
kevans committed rS346302: MFC r346132: stand: refactor overlay loading a little bit.
MFC r346132: stand: refactor overlay loading a little bit
Tue, Apr 16, 9:01 PM
kevans committed rS346301: MFC r346082: libbe(3): use libzfs name validation for datasets/snapshot names.
MFC r346082: libbe(3): use libzfs name validation for datasets/snapshot names
Tue, Apr 16, 9:00 PM
kevans committed rS346300: MFC r345180, r345187: if_bridge(4): Fix module teardown.
MFC r345180, r345187: if_bridge(4): Fix module teardown
Tue, Apr 16, 8:57 PM
kevans created D19924: cron(8): schedule interval jobs that get loaded during execution.
Tue, Apr 16, 2:57 PM

Mon, Apr 15

kevans updated the diff for D19587: net: adjust randomized address bits.
Mon, Apr 15, 9:43 PM
kevans updated the diff for D19587: net: adjust randomized address bits.
Mon, Apr 15, 9:41 PM
kevans committed rS346254: config(8): replace opteq with a call to strcasecmp.
config(8): replace opteq with a call to strcasecmp
Mon, Apr 15, 9:20 PM
kevans committed rS346252: cron(8): Add MAILFROM ability for crontabs.
cron(8): Add MAILFROM ability for crontabs
Mon, Apr 15, 6:53 PM

Fri, Apr 12

kevans added a comment to D19587: net: adjust randomized address bits.

Would iflib like any kind of UPDATING or relnote mention for the generated 'stable' MAC address likely changing (since we're restricting the range now to a subset of the FF OUI), or is it fine without explicit mention?

Fri, Apr 12, 4:17 PM

Thu, Apr 11

kevans committed rS346132: stand: refactor overlay loading a little bit.
stand: refactor overlay loading a little bit
Thu, Apr 11, 1:26 PM

Wed, Apr 10

kevans committed rS346082: libbe(3): use libzfs name validation for datasets/snapshot names.
libbe(3): use libzfs name validation for datasets/snapshot names
Wed, Apr 10, 2:00 PM

Tue, Apr 9

kevans added a comment to D19587: net: adjust randomized address bits.

Any other comments?

Tue, Apr 9, 4:15 PM

Mon, Apr 8

kevans committed rS346042: MFC r344161: stand: dev_net: correct net_open's interpretation of params.
MFC r344161: stand: dev_net: correct net_open's interpretation of params
Mon, Apr 8, 6:38 PM
kevans committed rS346041: MFC r345680: NOTES: Use non-default value for BOOT_TAG.
MFC r345680: NOTES: Use non-default value for BOOT_TAG
Mon, Apr 8, 6:37 PM
kevans committed rS346040: MFC r343599: libc/tests: Add test case for jemalloc/libthr bug fixed/r343566.
MFC r343599: libc/tests: Add test case for jemalloc/libthr bug fixed/r343566
Mon, Apr 8, 6:34 PM
kevans committed rS346037: MFC r343065, r343373-r343390, r343477.
MFC r343065, r343373-r343390, r343477
Mon, Apr 8, 6:15 PM
kevans committed rS346036: MFC r343255: awg: fix soft reset failure with no link.
MFC r343255: awg: fix soft reset failure with no link
Mon, Apr 8, 5:59 PM
kevans committed rS346035: MFC r343240: iwm(4): Fix possible null pointer indirection.
MFC r343240: iwm(4): Fix possible null pointer indirection
Mon, Apr 8, 5:55 PM
kevans committed rS346034: MFC r343335, r343977, r343993-r343994, r344034, r344084, r345302, r345769.
MFC r343335, r343977, r343993-r343994, r344034, r344084, r345302, r345769
Mon, Apr 8, 5:41 PM
kevans added a comment to D18564: allow creation of non-recursive boot environments (libbe).

The channel programs look like a cool feature - I have a few questions about it:

  1. Where would these .zcp scripts live?
  2. Would they be consumed by libbe, bectl or ...?
  3. According to zfs-program(1M), cloning isn't available yet, any guess when it may be implemented?

    Earlier in the review, Kyle suggested arbitrary depth creation as well. I'm not opposed to modifying this patch for depth creation if that's the preferred route. I think the use-cases for shallow boot environments is a short list - with arbitrary depth boot environments being an even shorter list. At some point the end-user will have to add/remove a dataset within the boot environment to get their 'perfect' set-up.
Mon, Apr 8, 5:39 PM
kevans committed rS346033: MFC r345848: libbe(3): Add a serial to the generated snapshot names.
MFC r345848: libbe(3): Add a serial to the generated snapshot names
Mon, Apr 8, 5:36 PM
kevans accepted D19424: config: Only warn if duplicate option/device comes from the same file.
Mon, Apr 8, 4:10 PM

Thu, Apr 4

kevans committed rS345882: MFC r344243, r345517-r345518: lualoader: More intelligent screen clearing.
MFC r344243, r345517-r345518: lualoader: More intelligent screen clearing
Thu, Apr 4, 5:30 PM
kevans committed rS345881: MFC r345628: dtc(1): Update to 1a79f5f26631.
MFC r345628: dtc(1): Update to 1a79f5f26631
Thu, Apr 4, 5:27 PM
kevans committed rS345880: dtc(1): Update to 1a79f5f26631.
dtc(1): Update to 1a79f5f26631
Thu, Apr 4, 5:26 PM
kevans committed rS345879: MFC r345516: netbsd-tests: import memory bump for libc/regex/t_exhaust.
MFC r345516: netbsd-tests: import memory bump for libc/regex/t_exhaust
Thu, Apr 4, 5:25 PM
kevans committed rS345878: MFC r344677: patch(1): Exit successfully if we're fed a 0-length patch.
MFC r344677: patch(1): Exit successfully if we're fed a 0-length patch
Thu, Apr 4, 5:21 PM

Wed, Apr 3

kevans committed rS345848: libbe(3): Add a serial to the generated snapshot names.
libbe(3): Add a serial to the generated snapshot names
Wed, Apr 3, 5:04 PM
kevans accepted D19666: bectl.8: Clean up & clarify the create subcommand.
Wed, Apr 3, 1:25 PM

Mon, Apr 1

kevans committed rS345769: libbe: Fix zfs_is_mounted check w/ snapshots.
libbe: Fix zfs_is_mounted check w/ snapshots
Mon, Apr 1, 5:44 PM
kevans closed D19650: Don't check if the dataset is mounted when destroying a snapshot (libbe).
Mon, Apr 1, 5:44 PM

Sun, Mar 31

kevans accepted D19650: Don't check if the dataset is mounted when destroying a snapshot (libbe).

Excellent, thanks! Will commit when I get a chunk of free time tomorrow night (for reference, ~22 hours from now)

Sun, Mar 31, 3:56 AM

Fri, Mar 29

kevans created D19757: if_bridge(4): Complete bpf auditing of local traffic over the bridge.
Fri, Mar 29, 7:17 PM
kevans committed rS345680: NOTES: Use non-default value for BOOT_TAG.
NOTES: Use non-default value for BOOT_TAG
Fri, Mar 29, 4:01 AM
kevans added a comment to D19736: fdt: further consolidate DTB building and revise manpage.
In D19736#423137, @imp wrote:

These are good changes, though the conf/files and kern.post.mk fragments seem a separate thing...

Fri, Mar 29, 2:35 AM

Thu, Mar 28

kevans added inline comments to D19587: net: adjust randomized address bits.
Thu, Mar 28, 9:28 PM
kevans updated the diff for D19587: net: adjust randomized address bits.
  • Stripped iflib.c of some headers it no longer needs
  • Pulled out the _masked version of ether_gen_addr; the envisioned other consumed will not be using it, so there is no need.
  • Revised comment to match suggested wording by jhb.
Thu, Mar 28, 9:27 PM
kevans added a comment to D19587: net: adjust randomized address bits.

Any further input on this latest iteration?

Thu, Mar 28, 2:56 PM
kevans created D19736: fdt: further consolidate DTB building and revise manpage.
Thu, Mar 28, 2:06 PM
kevans committed rS345628: dtc(1): Update to 1a79f5f26631.
dtc(1): Update to 1a79f5f26631
Thu, Mar 28, 3:48 AM
kevans committed rS345627: if_bridge(4): ensure all traffic passing over the bridge is accounted for.
if_bridge(4): ensure all traffic passing over the bridge is accounted for
Thu, Mar 28, 3:32 AM
kevans closed D19614: if_bridge(4): ensure all traffic passing over the bridge is accounted for.
Thu, Mar 28, 3:32 AM

Tue, Mar 26

kevans accepted D19650: Don't check if the dataset is mounted when destroying a snapshot (libbe).

Change is good; please do go ahead and include a bectl test, referencing the PR in the test's descr.

Tue, Mar 26, 2:53 AM
kevans committed rS345519: Allow kernel config to specify DTS/DTSO to build, and out-of-tree support.
Allow kernel config to specify DTS/DTSO to build, and out-of-tree support
Tue, Mar 26, 2:45 AM
kevans closed D19351: Allow kernel config to specify DTS/DTSO to build, and out-of-tree support.
Tue, Mar 26, 2:45 AM
kevans committed rS345518: lualoader: Fix up some luacheck concerns.
lualoader: Fix up some luacheck concerns
Tue, Mar 26, 2:36 AM
kevans committed rS345517: lualoader: Clear the screen before prompting for password.
lualoader: Clear the screen before prompting for password
Tue, Mar 26, 2:33 AM
kevans committed rS345516: MFV r345515: netbsd-tests: import memory bump for libc/regex/t_exhaust.
MFV r345515: netbsd-tests: import memory bump for libc/regex/t_exhaust
Tue, Mar 26, 2:21 AM
kevans committed rS345515: netbsd-tests: import memory bump for libc/regex/t_exhaust.
netbsd-tests: import memory bump for libc/regex/t_exhaust
Tue, Mar 26, 2:13 AM

Wed, Mar 20

kevans added inline comments to D19588: Add a new efi-update-loader script and associated man page.
Wed, Mar 20, 6:52 PM
kevans added inline comments to D19588: Add a new efi-update-loader script and associated man page.
Wed, Mar 20, 5:48 PM
kevans accepted D19658: [loader] fix file name cut causing hang when a "." is found in paths like "boot/kernel.elfv2/kernel".
Wed, Mar 20, 4:16 PM
kevans added inline comments to D19658: [loader] fix file name cut causing hang when a "." is found in paths like "boot/kernel.elfv2/kernel".
Wed, Mar 20, 2:33 PM

Tue, Mar 19

kevans committed rS345302: bectl(8): change jail command to execute jail(8).
bectl(8): change jail command to execute jail(8)
Tue, Mar 19, 5:39 PM
kevans closed D19282: bectl(8): change jail command to execute jail(8).
Tue, Mar 19, 5:39 PM
kevans added inline comments to D19588: Add a new efi-update-loader script and associated man page.
Tue, Mar 19, 3:14 PM

Mar 17 2019

kevans created D19614: if_bridge(4): ensure all traffic passing over the bridge is accounted for.
Mar 17 2019, 7:39 PM
kevans abandoned D19586: if_bridge: Give bpf a shot at packets passed over the bridge.

Abandoning for this now; further contemplation leads me to think my local hack should stay local on this one. I do think there's a tangentially related problem here, though, that I'll likely address in a different review: consider a bridge0 with em0 and em1 members. Traffic rx'd by em0 that gets forwarded *through* em1 will increment bridge0 IPACKETS/IBYTES and get passed through bridge0 bpf. Unicast traffic specifically for em1, though, will *not* have any of this accounting done and not get passed to bridge0 bpf, just em0 bpf, despite still having passed over the bridge in the same fashion. It strikes me as incorrect to treat this traffic any differently than in the bridge_forward case.

Mar 17 2019, 5:02 PM
kevans added inline comments to D19588: Add a new efi-update-loader script and associated man page.
Mar 17 2019, 3:41 AM

Mar 15 2019

kevans updated the diff for D19587: net: adjust randomized address bits.

Here's a second stab at it. Highlights reel:

  • Changed terminology from random -> generated
  • Threw in some commentary about expectations
  • arc4random -> SHA1 w/ hostuuid and if_xname (to start with...)
  • Converted iflib to using the same mechanism since we're leaning towards "there's nothing wrong with these always being deterministic"
Mar 15 2019, 8:18 PM
kevans added inline comments to D19587: net: adjust randomized address bits.
Mar 15 2019, 7:01 PM
kevans added inline comments to D19587: net: adjust randomized address bits.
Mar 15 2019, 5:38 PM
kevans committed rS345194: if_bridge(4): Drop pointless rtflush.
if_bridge(4): Drop pointless rtflush
Mar 15 2019, 5:19 PM
kevans committed rS345193: Revert r345192: Too many trees in play for bridge(4) bits.
Revert r345192: Too many trees in play for bridge(4) bits
Mar 15 2019, 5:18 PM
kevans committed rS345192: if_bridge(4): Drop pointless rtflush.
if_bridge(4): Drop pointless rtflush
Mar 15 2019, 5:13 PM
kevans committed rS345180: if_bridge(4): Fix module teardown.
if_bridge(4): Fix module teardown
Mar 15 2019, 1:20 PM
kevans closed D19578: if_bridge(4): Fix module teardown .
Mar 15 2019, 1:20 PM
kevans added inline comments to D19587: net: adjust randomized address bits.
Mar 15 2019, 11:46 AM
kevans updated the diff for D19586: if_bridge: Give bpf a shot at packets passed over the bridge.

Correct slight oversight: don't double-tap packets that are being received by the same interface that they came in on. Those take the same path.

Mar 15 2019, 3:50 AM
kevans abandoned D17607: [new driver] Tehuti networks tn40xx device driver..
Mar 15 2019, 2:37 AM
kevans commandeered D17607: [new driver] Tehuti networks tn40xx device driver..

Commandeering to abandon in favor of D18856

Mar 15 2019, 2:36 AM
kevans created D19587: net: adjust randomized address bits.
Mar 15 2019, 2:25 AM

Mar 14 2019

kevans committed rS345151: ether_fakeaddr: Use 'b' 's' 'd' for the prefix.
ether_fakeaddr: Use 'b' 's' 'd' for the prefix
Mar 14 2019, 7:49 PM
kevans created D19586: if_bridge: Give bpf a shot at packets passed over the bridge.
Mar 14 2019, 6:24 PM
kevans added a comment to D19578: if_bridge(4): Fix module teardown .

Do we need to virtualise the bridge_rtnode_zone? Doesn't the cleanup call to bridge_rtflush() take care of all of the allocations already?

Mar 14 2019, 5:54 PM
kevans committed rS345139: ether: centralize fake hwaddr generation.
ether: centralize fake hwaddr generation
Mar 14 2019, 5:18 PM
kevans closed D19573: ether: centralize fake hwaddr generation.
Mar 14 2019, 5:18 PM
kevans updated the diff for D19578: if_bridge(4): Fix module teardown .

Push vnet context up into the callout callback

Mar 14 2019, 1:11 PM
kevans added a comment to D18856: new driver: Tehuti networks tn40xx device driver..

I'll drop in to provide some initial review within the next couple of days, now that I've done a bit of dabbling in the area. Apologies for the delay.

Mar 14 2019, 11:55 AM
kevans added inline comments to D19578: if_bridge(4): Fix module teardown .
Mar 14 2019, 11:41 AM
kevans updated the diff for D19578: if_bridge(4): Fix module teardown .

Sorry, did the dumb there... ripped out the explicit teardown of the clones, since that actually happens. bridge_rtnode_zone remains virtualized, because that's still the cleanest way -- the clones get destroyed upon if_clone_detach, which happens after the MOD_UNLOAD event.

Mar 14 2019, 4:36 AM
kevans added a comment to D19578: if_bridge(4): Fix module teardown .

I guess I should mention that my original example isn't actually accurate to what I'm doing -- I've got an interface like OpenBSD's if_vether that I'm throwing in the bridge rather than em0. That doesn't work for other reasons, but it was clear that the panic was legit.

Mar 14 2019, 1:49 AM
kevans created D19578: if_bridge(4): Fix module teardown .
Mar 14 2019, 1:42 AM

Mar 13 2019

kevans created D19573: ether: centralize fake hwaddr generation.
Mar 13 2019, 5:24 PM

Mar 12 2019

kevans committed rS345066: stand: Improve some debugging experience.
stand: Improve some debugging experience
Mar 12 2019, 4:21 PM

Mar 11 2019

kevans added inline comments to D19351: Allow kernel config to specify DTS/DTSO to build, and out-of-tree support.
Mar 11 2019, 6:48 PM
kevans added inline comments to D19351: Allow kernel config to specify DTS/DTSO to build, and out-of-tree support.
Mar 11 2019, 6:46 PM
kevans committed rS344989: MFC r336255: Only define g_eli_key_cmp in the kernel.
MFC r336255: Only define g_eli_key_cmp in the kernel
Mar 11 2019, 1:12 AM

Mar 6 2019

kevans added a reviewer for D19351: Allow kernel config to specify DTS/DTSO to build, and out-of-tree support: bdrewery.

Tagging @bdrewery as well, since I'm hooking this up to the kernel build. A glance over to make sure I'm not doing anything too terrifying would be appreciated.

Mar 6 2019, 4:11 AM
kevans added a comment to D18564: allow creation of non-recursive boot environments (libbe).

I guess while you're addressing those, you can go ahead and upload a version that has the mtree addition with it, too. =-) ^/etc/mtree/BSD.tests.dist just needs the two-line addition to make test installation work out.

Mar 6 2019, 4:01 AM
kevans added a comment to D18564: allow creation of non-recursive boot environments (libbe).

That's odd, but not a problem -- I'll do a final pass over this tomorrow and commit, but it looks good at a glance.

Mar 6 2019, 3:29 AM