Page MenuHomeFreeBSD

kevans (Kyle Evans)
User

Projects (7)

User Details

User Since
Oct 2 2015, 1:17 PM (311 w, 5 d)

Recent Activity

Today

kevans committed R10:5e79bba562bc: kern: random: collect ~16x less from fast-entropy sources (authored by kevans).
kern: random: collect ~16x less from fast-entropy sources
Thu, Sep 23, 6:04 AM
kevans committed R10:6895cade9421: kern: random: drop read_rate and associated functionality (authored by kevans).
kern: random: drop read_rate and associated functionality
Thu, Sep 23, 6:04 AM
kevans closed D32021: kern: random: reduce the rate at which we collect from fast entropy sources.
Thu, Sep 23, 6:03 AM
kevans requested review of D32074: cmp: add -b, --print-bytes.
Thu, Sep 23, 5:56 AM
kevans requested review of D32073: cmp: add -i, --ignore-initial, an alternative to skip1/skip2 args.
Thu, Sep 23, 5:56 AM
kevans requested review of D32072: cmp: add -n, --bytes to limit number of bytes to compare.
Thu, Sep 23, 5:56 AM
kevans requested review of D32071: cmp: accept SI suffixes for skip1 and skip2.
Thu, Sep 23, 5:55 AM

Yesterday

kevans updated the summary of D32063: man: reset OPTIND after parsing args.
Wed, Sep 22, 9:18 PM
kevans updated the diff for D32063: man: reset OPTIND after parsing args.

Go ahead and reset getopts state before each, to be safe/correct.

Wed, Sep 22, 9:17 PM
kevans added a reviewer for D32063: man: reset OPTIND after parsing args: gordon.
Wed, Sep 22, 8:31 PM
kevans requested review of D32063: man: reset OPTIND after parsing args.
Wed, Sep 22, 8:31 PM
kevans accepted D32060: Revert "linux32: add a hack to avoid redefining the type of the savefpu tag".
Wed, Sep 22, 7:14 PM
kevans added a comment to D32021: kern: random: reduce the rate at which we collect from fast entropy sources.

Another observation (unrelated to your change) is that the current RANDOM_KTHREAD_HZ was 10; we might want to choose a power of two value that is close (8 maybe?) to simplify some calculation?

Wed, Sep 22, 6:09 AM

Tue, Sep 21

kevans added inline comments to D32021: kern: random: reduce the rate at which we collect from fast entropy sources.
Tue, Sep 21, 6:11 PM
kevans added a reviewer for D32052: tests: Test endian.h, byteswap.h, sys/endian.h and both endian.h and byteswap.h together: kevans.
Tue, Sep 21, 5:49 PM
kevans updated the diff for D32021: kern: random: reduce the rate at which we collect from fast entropy sources.

Whoops, fix git snafu. I also had some inline review comments that remained unsubmitted, but I went ahead and nuked those because the changes mentioned have already generally been observed. :-)

Tue, Sep 21, 5:18 PM
kevans updated the diff for D32021: kern: random: reduce the rate at which we collect from fast entropy sources.

Address comments, maybe

Tue, Sep 21, 7:45 AM

Mon, Sep 20

kevans accepted D31893: bcm2835_sdhci: don't use DMA for kernel dumps.

aggressive pong. :-)

Mon, Sep 20, 7:50 PM
kevans added inline comments to D32021: kern: random: reduce the rate at which we collect from fast entropy sources.
Mon, Sep 20, 6:15 AM
kevans requested review of D32021: kern: random: reduce the rate at which we collect from fast entropy sources.
Mon, Sep 20, 6:12 AM

Sun, Sep 19

kevans added a comment to D32013: virtqueue: add virtqueue_poll_timeout().
In D32013#722392, @cem wrote:

If that's an option, then sure. =-) I didn't/don't understand fortuna's design well enough to make claims about what a reasonable rate is. If we can securely drop it down to <= 1kB/s on average then yeah, we can probably just not care about this at all.

Yeah, we can. Fortuna doesn't call for a random source that provides 512x32 bits of entropy every 100ms. I think (but am not totally sure) our random_kthread() -> random_sources_feed() dates to the earlier Yarrow CSPRNG, which only had two pools -- 16x lower entropy requests per call.

We should (1) eliminate its use of read_rate (which becomes a dead variable we can remove, along with read_rate_increment()), and (2) reduce the frequency random_kthread invokes random_sources_feed() below 10 Hz. We may still want to process the other data in random_kthread at 10Hz (hc_entropy_ring, hc_entropy_fast_accumulator), but we can use a counter to only invoke random_sources_feed once in ten or a hundred iterations (or something like that). Alternatively, restructure random_sources_feed to be able to fill smaller chunks at a time, spreading out the request volume over time. (This is probably good for RDSEED, in addition to virtio-rng.) Or like, use an additional thread, but that seems unnecessary.

Sun, Sep 19, 5:04 PM
kevans added inline comments to D20780: Add support for getting early entropy from the UEFI RNG protocol.
Sun, Sep 19, 3:13 AM · csprng, security, arm64

Sat, Sep 18

kevans added a comment to D32013: virtqueue: add virtqueue_poll_timeout().
In D32013#722385, @cem wrote:

I think we should really try to scale down our “fast source” entropy collection instead. 2kB/s is pretty ridiculous. I really think we could just collect 256 bits x2 into the zero pool per reseed (64B) and maybe change the fortuna minimum reseed interval to 1s (from 100ms).

Sat, Sep 18, 7:32 PM
kevans updated the diff for D31896: openssh: consolidate some globally-applicable flags.

Review feedback

Sat, Sep 18, 4:05 PM
kevans added a comment to D32013: virtqueue: add virtqueue_poll_timeout().

Good catch-

Sat, Sep 18, 4:00 PM
kevans updated the diff for D32013: virtqueue: add virtqueue_poll_timeout().

Review feedback

Sat, Sep 18, 3:55 PM
kevans requested review of D32014: virtio_random: timeout rather than blocking entropy collection.
Sat, Sep 18, 7:41 AM
kevans requested review of D32013: virtqueue: add virtqueue_poll_timeout().
Sat, Sep 18, 7:40 AM
kevans requested review of D32012: virtio_random: assert on virtqueue_poll()'s return.
Sat, Sep 18, 7:40 AM

Wed, Sep 15

kevans committed R10:08703a56498d: kern: drop remaining references to removed makesyscalls.sh (authored by kevans).
kern: drop remaining references to removed makesyscalls.sh
Wed, Sep 15, 1:53 AM

Tue, Sep 14

kevans accepted D31961: tzcode: Fix operation without WITH_DETECT_TZ_CHANGES.
Tue, Sep 14, 7:05 PM

Sun, Sep 12

kevans committed R10:8df27f0acea8: lualoader: use more concise verbiage for autoboot (authored by kevans).
lualoader: use more concise verbiage for autoboot
Sun, Sep 12, 5:44 AM
kevans committed R10:ea03e7dbeea0: loader: do not output empty menu title (authored by tsoome).
loader: do not output empty menu title
Sun, Sep 12, 5:43 AM
kevans committed R10:59f99ecf87c6: loader_lua: consider userboot console as serial (authored by tsoome).
loader_lua: consider userboot console as serial
Sun, Sep 12, 5:43 AM
kevans committed R10:cdd8bfecd2ff: loader: insert spaces around menu title (authored by tsoome).
loader: insert spaces around menu title
Sun, Sep 12, 5:43 AM
kevans committed R10:0c675cb9c9cb: lualoader: allow brands to specify a shift (authored by kevans).
lualoader: allow brands to specify a shift
Sun, Sep 12, 5:43 AM
kevans committed R10:b359fcb1cb4f: lualoader: remove shadowed local from graphics:drawitem() (authored by kevans).
lualoader: remove shadowed local from graphics:drawitem()
Sun, Sep 12, 5:43 AM
kevans committed R10:81719aafa86d: lualoader: use more concise verbiage for autoboot (authored by kevans).
lualoader: use more concise verbiage for autoboot
Sun, Sep 12, 5:43 AM
kevans committed R10:a0a8e7a89e09: lualoader: allow brands to specify a shift (authored by kevans).
lualoader: allow brands to specify a shift
Sun, Sep 12, 5:43 AM

Sat, Sep 11

kevans added reviewers for D31888: Rework functions allocating credetials: kib, markj, mjg.

Scattershot a couple of folks that might we willing to review-

Sat, Sep 11, 8:29 PM

Fri, Sep 10

kevans added inline comments to D31896: openssh: consolidate some globally-applicable flags.
Fri, Sep 10, 2:49 PM
kevans committed R10:7955efd574b9: Add support for jail.conf.d (authored by antranigv_freebsd.am).
Add support for jail.conf.d
Fri, Sep 10, 5:31 AM
kevans closed D24570: Add support for jail.d.
Fri, Sep 10, 5:31 AM
kevans requested review of D31896: openssh: consolidate some globally-applicable flags.
Fri, Sep 10, 5:22 AM
kevans committed R10:35aa1d6e4542: kern: drop remaining references to removed makesyscalls.sh (authored by kevans).
kern: drop remaining references to removed makesyscalls.sh
Fri, Sep 10, 12:42 AM
kevans closed D30250: kern: remove makesyscalls.sh.
Fri, Sep 10, 12:41 AM

Thu, Sep 9

kevans committed R10:ed107537b43c: lualoader: use more concise verbiage for autoboot (authored by kevans).
lualoader: use more concise verbiage for autoboot
Thu, Sep 9, 7:04 AM
kevans committed R10:e19d9a9b6e44: lualoader: allow brands to specify a shift (authored by kevans).
lualoader: allow brands to specify a shift
Thu, Sep 9, 7:04 AM
kevans committed R10:763bcebe0b6d: lualoader: remove shadowed local from graphics:drawitem() (authored by kevans).
lualoader: remove shadowed local from graphics:drawitem()
Thu, Sep 9, 7:03 AM
kevans committed R11:4f32bd205f04: devel/arduino18: restore GH_ACCOUNT to unbreak (authored by kevans).
devel/arduino18: restore GH_ACCOUNT to unbreak
Thu, Sep 9, 4:05 AM

Wed, Sep 8

kevans accepted D24570: Add support for jail.d.
Wed, Sep 8, 7:09 AM

Mon, Sep 6

kevans accepted D30848: loader: implement mount/unmount rootfs.
Mon, Sep 6, 5:19 AM

Sat, Sep 4

kevans committed R10:c0674b71720b: pxeboot: improve and simplify rx handling (authored by kevans).
pxeboot: improve and simplify rx handling
Sat, Sep 4, 7:46 AM
kevans committed R10:f5da4b012fea: pxeboot: improve and simplify rx handling (authored by kevans).
pxeboot: improve and simplify rx handling
Sat, Sep 4, 7:45 AM
kevans committed R10:96df822abbab: pxeboot: improve and simplify rx handling (authored by kevans).
pxeboot: improve and simplify rx handling
Sat, Sep 4, 7:45 AM
kevans committed R10:de140815c9a5: caroot: cumulative cert update (authored by kevans).
caroot: cumulative cert update
Sat, Sep 4, 7:44 AM
kevans committed R10:a12641eaecc3: caroot: update CA bundle processor (authored by kevans).
caroot: update CA bundle processor
Sat, Sep 4, 7:44 AM
kevans committed R10:534d1019aa53: caroot: cumulative cert update (authored by kevans).
caroot: cumulative cert update
Sat, Sep 4, 7:41 AM
kevans committed R10:0ef0442fcf63: caroot: update CA bundle processor (authored by kevans).
caroot: update CA bundle processor
Sat, Sep 4, 7:41 AM
kevans committed R10:62aaa70143a6: caroot: cumulative cert update (authored by kevans).
caroot: cumulative cert update
Sat, Sep 4, 7:40 AM
kevans committed R10:c8c18ce8daca: caroot: update CA bundle processor (authored by kevans).
caroot: update CA bundle processor
Sat, Sep 4, 7:40 AM
kevans committed R10:76461921dac1: caroot: update root store (authored by kevans).
caroot: update root store
Sat, Sep 4, 7:33 AM

Thu, Sep 2

kevans added inline comments to D31807: FreeBSD base system ssh 7.9p1 diff against upstream.
Thu, Sep 2, 7:30 PM

Wed, Sep 1

kevans accepted D31350: syscalls.master: switch to CAPENABLED flags.
Wed, Sep 1, 7:00 PM
kevans accepted D31351: syscalls.master: correct formatting issues.
Wed, Sep 1, 6:59 PM
kevans added a comment to D31349: makesyscalls.lua: add a CAPENABLED flag.

Thanks!

Wed, Sep 1, 6:09 PM
kevans accepted D31349: makesyscalls.lua: add a CAPENABLED flag.
Wed, Sep 1, 6:09 PM
kevans accepted D31760: openssh: simplify login class restrictions.

This looks exceedingly reasonable to me.

Wed, Sep 1, 2:27 AM

Sun, Aug 29

kevans committed R10:5a67aaf1fa2c: kern: mountroot: avoid fd leak in .md parsing (authored by kevans).
kern: mountroot: avoid fd leak in .md parsing
Sun, Aug 29, 5:01 PM
kevans committed R10:99992f383bff: kern: mountroot: avoid fd leak in .md parsing (authored by kevans).
kern: mountroot: avoid fd leak in .md parsing
Sun, Aug 29, 5:01 PM
kevans committed R10:1420778e9ee6: freebsd-update: create a ZFS boot environment on install (authored by dave_fullard.ca).
freebsd-update: create a ZFS boot environment on install
Sun, Aug 29, 4:58 PM
kevans committed R10:c538903f7bec: freebsd-update: create a ZFS boot environment on install (authored by dave_fullard.ca).
freebsd-update: create a ZFS boot environment on install
Sun, Aug 29, 4:58 PM

Fri, Aug 27

kevans committed R10:f96130dbeeb1: crunch: drop WARNS override (authored by kevans).
crunch: drop WARNS override
Fri, Aug 27, 1:14 AM
kevans committed R10:62885c0f0e57: crunchgen: fix remaining issues under WARNS=6 (authored by kevans).
crunchgen: fix remaining issues under WARNS=6
Fri, Aug 27, 1:14 AM
kevans committed R10:5c22fa5d0713: crunchide: static'ify remaining non-exported functions (authored by kevans).
crunchide: static'ify remaining non-exported functions
Fri, Aug 27, 1:14 AM
kevans committed R10:46e1f6a8b7b3: crunchide: address complaints from WARNS=6 (authored by kevans).
crunchide: address complaints from WARNS=6
Fri, Aug 27, 1:14 AM
kevans committed R10:bb194ea3356a: crunchgen: sprinkle some const-poisoning around (authored by kevans).
crunchgen: sprinkle some const-poisoning around
Fri, Aug 27, 1:13 AM
kevans committed R10:96a692ed6ff4: pkg: use specific CONFSNAME_${file} for FreeBSD.conf (authored by kevans).
pkg: use specific CONFSNAME_${file} for FreeBSD.conf
Fri, Aug 27, 1:13 AM
kevans committed R10:6cd271fbc243: pkg: allow multiple add arguments again (authored by kevans).
pkg: allow multiple add arguments again
Fri, Aug 27, 1:13 AM
kevans committed R10:b3e2d70a7f30: malloc(9): Document/complete aligned variants (authored by adam_fenn.io).
malloc(9): Document/complete aligned variants
Fri, Aug 27, 1:13 AM
kevans committed R10:edcdb6d19e1b: devclass_alloc_unit: move "at" hint test to after device-in-use test (authored by adam_fenn.io).
devclass_alloc_unit: move "at" hint test to after device-in-use test
Fri, Aug 27, 1:13 AM

Thu, Aug 26

kevans committed R10:75046797387c: crunch: drop WARNS override (authored by kevans).
crunch: drop WARNS override
Thu, Aug 26, 5:30 PM
kevans committed R10:c81c1995e9ad: crunchgen: fix remaining issues under WARNS=6 (authored by kevans).
crunchgen: fix remaining issues under WARNS=6
Thu, Aug 26, 5:30 PM
kevans committed R10:90bf0d3033f4: crunchide: static'ify remaining non-exported functions (authored by kevans).
crunchide: static'ify remaining non-exported functions
Thu, Aug 26, 5:30 PM
kevans committed R10:76520030a0a1: crunchide: address complaints from WARNS=6 (authored by kevans).
crunchide: address complaints from WARNS=6
Thu, Aug 26, 5:30 PM
kevans committed R10:f6aab4dd7706: crunchgen: sprinkle some const-poisoning around (authored by kevans).
crunchgen: sprinkle some const-poisoning around
Thu, Aug 26, 5:30 PM
kevans committed R10:55eea57aba30: pkg: use specific CONFSNAME_${file} for FreeBSD.conf (authored by kevans).
pkg: use specific CONFSNAME_${file} for FreeBSD.conf
Thu, Aug 26, 5:29 PM
kevans committed R10:48ac2697742e: pkg: allow multiple add arguments again (authored by kevans).
pkg: allow multiple add arguments again
Thu, Aug 26, 5:29 PM
kevans committed R10:453e51048a83: devclass_alloc_unit: move "at" hint test to after device-in-use test (authored by adam_fenn.io).
devclass_alloc_unit: move "at" hint test to after device-in-use test
Thu, Aug 26, 5:29 PM
kevans committed R10:e70e1b132ee8: malloc(9): Document/complete aligned variants (authored by adam_fenn.io).
malloc(9): Document/complete aligned variants
Thu, Aug 26, 5:29 PM
kevans committed R10:18f89d2df457: kern: remove deprecated makesyscalls.sh (authored by kevans).
kern: remove deprecated makesyscalls.sh
Thu, Aug 26, 6:45 AM
kevans committed R10:63c85520018a: init: execute /etc/rc.final after all user processes have terminated (authored by kevans).
init: execute /etc/rc.final after all user processes have terminated
Thu, Aug 26, 6:44 AM
kevans committed R10:a961049fc9b6: kenv: allow listing of static kernel environments (authored by kevans).
kenv: allow listing of static kernel environments
Thu, Aug 26, 6:44 AM
kevans committed R10:a68421a0e61d: kenv: s/dump/list/ to clarify meaning (authored by kevans).
kenv: s/dump/list/ to clarify meaning
Thu, Aug 26, 6:44 AM
kevans committed R10:ef70a18d88e6: kern: add an option for preserving the early kenv (authored by kevans).
kern: add an option for preserving the early kenv
Thu, Aug 26, 6:44 AM
kevans committed R10:9ee8e86c0da0: init: execute /etc/rc.final after all user processes have terminated (authored by kevans).
init: execute /etc/rc.final after all user processes have terminated
Thu, Aug 26, 6:43 AM
kevans committed R10:d511b903b9ed: kenv: allow listing of static kernel environments (authored by kevans).
kenv: allow listing of static kernel environments
Thu, Aug 26, 6:38 AM
kevans committed R10:8e11e8fb782c: kern: add an option for preserving the early kenv (authored by kevans).
kern: add an option for preserving the early kenv
Thu, Aug 26, 6:38 AM
kevans committed R10:40ea449c41b6: kenv: s/dump/list/ to clarify meaning (authored by kevans).
kenv: s/dump/list/ to clarify meaning
Thu, Aug 26, 6:38 AM
kevans committed R10:3daa8e165c66: pxeboot: improve and simplify rx handling (authored by kevans).
pxeboot: improve and simplify rx handling
Thu, Aug 26, 3:01 AM