kevans (Kyle Evans)
User

Projects

User Details

User Since
Oct 2 2015, 1:17 PM (145 w, 3 d)

Recent Activity

Today

kevans committed rS336358: Partially revert r336353: sys/conf/* %VERSREQ bumps.
Partially revert r336353: sys/conf/* %VERSREQ bumps
Mon, Jul 16, 9:53 PM
kevans closed D16214: config(8): Bump major version after r335998.
Mon, Jul 16, 7:07 PM
kevans added 1 commit(s) for D16214: config(8): Bump major version after r335998: rS336353: config(8): Bump major version after r335998.
Mon, Jul 16, 7:07 PM
kevans added an edge to rS336353: config(8): Bump major version after r335998: D16214: config(8): Bump major version after r335998.
Mon, Jul 16, 7:07 PM
kevans committed rS336353: config(8): Bump major version after r335998.
config(8): Bump major version after r335998
Mon, Jul 16, 7:06 PM
kevans committed rS336346: MFC r304910, r304912, r304915, r304952, r325019, r328164, r331094, r332664,.
MFC r304910, r304912, r304915, r304952, r325019, r328164, r331094, r332664,
Mon, Jul 16, 3:02 PM
kevans committed rS336345: MFC r304908-r304909.
MFC r304908-r304909
Mon, Jul 16, 2:56 PM
kevans committed rS336344: MFC r335757:.
MFC r335757:
Mon, Jul 16, 2:42 PM
kevans committed rS336343: MFC r335652-r335654.
MFC r335652-r335654
Mon, Jul 16, 2:39 PM
kevans committed rS336342: Record-only MFC r336011-r336013.
Record-only MFC r336011-r336013
Mon, Jul 16, 2:34 PM
kevans committed rS336341: Record-only MFC of r335995, r335997; latter reverts the former.
Record-only MFC of r335995, r335997; latter reverts the former
Mon, Jul 16, 2:32 PM
kevans committed rS336337: Unconditionally build libnv in legacy.
Unconditionally build libnv in legacy
Mon, Jul 16, 1:15 PM

Sat, Jul 14

kevans accepted D15917: uefi stand: Guess the console better.
Sat, Jul 14, 12:35 AM

Thu, Jul 12

kevans committed rS336217: kern_environment: Give the static environment a chance to disable MD env.
kern_environment: Give the static environment a chance to disable MD env
Thu, Jul 12, 2:52 AM

Wed, Jul 11

kevans created D16214: config(8): Bump major version after r335998.
Wed, Jul 11, 1:56 AM

Tue, Jul 10

kevans committed rS336184: net80211: Fix ifdetach w/o ifattach, small whitespace cleanup.
net80211: Fix ifdetach w/o ifattach, small whitespace cleanup
Tue, Jul 10, 11:30 PM
kevans accepted D16205: Create three helper functions for parsing boot args..

Seems reasonable...hurray for de-duplication.

Tue, Jul 10, 4:23 PM
kevans added inline comments to D16205: Create three helper functions for parsing boot args..
Tue, Jul 10, 1:07 PM
kevans committed rS336157: kern_environment: bool'itize dynamic_kenv; fix small style(9) nit.
kern_environment: bool'itize dynamic_kenv; fix small style(9) nit
Tue, Jul 10, 2:43 AM
kevans committed rS336154: subr_hints: Skip static_env and static_hints if they don't contain hints.
subr_hints: Skip static_env and static_hints if they don't contain hints
Tue, Jul 10, 12:36 AM
kevans committed rS336153: subr_hints: Convert some bool-like ints to bools.
subr_hints: Convert some bool-like ints to bools
Tue, Jul 10, 12:34 AM
kevans committed rS336152: subr_hints: Use goto/label instead of series of conditionals.
subr_hints: Use goto/label instead of series of conditionals
Tue, Jul 10, 12:33 AM

Sun, Jul 8

kevans accepted D16187: No longer install sys/nv.h and sys/cnv.h in lib/libnv/Makefile.

A-ha! \0/ This is the solution I was searching for.

Sun, Jul 8, 10:41 PM

Fri, Jul 6

kevans committed rS336036: kern_environment: Fix SYSINIT ordering.
kern_environment: Fix SYSINIT ordering
Fri, Jul 6, 4:51 PM
kevans committed rS336026: config(8): Fix broken ABI.
config(8): Fix broken ABI
Fri, Jul 6, 11:23 AM
kevans committed rS336019: config(8): De-dupe hint/env vars within a single file.
config(8): De-dupe hint/env vars within a single file
Fri, Jul 6, 1:11 AM

Thu, Jul 5

kevans committed rS336013: Revert r336011,r336012 until I can competently test.
Revert r336011,r336012 until I can competently test
Thu, Jul 5, 6:55 PM
kevans committed rS336012: Fix build after r336011.
Fix build after r336011
Thu, Jul 5, 6:39 PM
kevans committed rS336011: config(8): De-dupe hint/env vars within a single file.
config(8): De-dupe hint/env vars within a single file
Thu, Jul 5, 5:54 PM
kevans committed rS335998: kern_environment: use any provided environments, evict hintmode/envmode.
kern_environment: use any provided environments, evict hintmode/envmode
Thu, Jul 5, 4:30 PM
kevans committed rS335997: Revert r335995 due to accidental changes snuck in.
Revert r335995 due to accidental changes snuck in
Thu, Jul 5, 4:28 PM
kevans committed rS335995: kern_environment: use any provided environments, evict hintmode/envmode.
kern_environment: use any provided environments, evict hintmode/envmode
Thu, Jul 5, 4:26 PM
kevans closed D15953: Kernel environments: use any and all provided environments, evict hintmode and envmode.
Thu, Jul 5, 4:26 PM
kevans committed rS335984: MFC r335479, r335509.
MFC r335479, r335509
Thu, Jul 5, 3:27 PM

Mon, Jul 2

kevans committed rS335863: MFC r335642, r335651: config(8) envvar support.
MFC r335642, r335651: config(8) envvar support
Mon, Jul 2, 1:08 PM

Thu, Jun 28

kevans committed rS335757: ifconfig(8): Attempt to render non-printable sequences w/ UTF-8 Environment.
ifconfig(8): Attempt to render non-printable sequences w/ UTF-8 Environment
Thu, Jun 28, 3:37 AM
kevans closed D15922: Added ssid values to render UTF-8 encoded characters in ifconfig(8).
Thu, Jun 28, 3:37 AM
kevans committed rS335755: MFC r334882, r334884-r334885: loader(8) boot flag <-> environment fixes.
MFC r334882, r334884-r334885: loader(8) boot flag <-> environment fixes
Thu, Jun 28, 1:32 AM
kevans committed rS335754: MFC r334878: libsa(3): Correct statement about FS Write-support, name change.
MFC r334878: libsa(3): Correct statement about FS Write-support, name change
Thu, Jun 28, 1:30 AM

Wed, Jun 27

kevans committed rS335752: MFC r335467: Don't remove loader.conf(5) when built WITHOUT_FORTH.
MFC r335467: Don't remove loader.conf(5) when built WITHOUT_FORTH
Wed, Jun 27, 11:02 PM
kevans committed rS335745: MFC r332395 (ian): Use explicit_bzero() when cleaning values out of the kenv.
MFC r332395 (ian): Use explicit_bzero() when cleaning values out of the kenv
Wed, Jun 27, 9:23 PM
kevans committed rS335743: MFC r335458: Add debug.verbose_sysinit tunable for VERBOSE_SYSINIT.
MFC r335458: Add debug.verbose_sysinit tunable for VERBOSE_SYSINIT
Wed, Jun 27, 9:13 PM
kevans committed rS335742: MFC r335404: sort(1): Fix -m when only implicit stdin is used for input.
MFC r335404: sort(1): Fix -m when only implicit stdin is used for input
Wed, Jun 27, 9:11 PM
kevans committed rS335741: MFC r333221: rsu(4) does not require legal.realtek.license_ack=1.
MFC r333221: rsu(4) does not require legal.realtek.license_ack=1
Wed, Jun 27, 9:10 PM
kevans committed rS335740: MFC r333192: fcntl(2): Vaguely document that ENOTTY is possible + examples.
MFC r333192: fcntl(2): Vaguely document that ENOTTY is possible + examples
Wed, Jun 27, 9:04 PM
kevans committed rS335739: MFC r330086, r333155: seq(1) improvements.
MFC r330086, r333155: seq(1) improvements
Wed, Jun 27, 9:03 PM
kevans committed rS335738: MFC r333157: cmp(1): Provide some long options.
MFC r333157: cmp(1): Provide some long options
Wed, Jun 27, 9:00 PM
kevans committed rS335737: MFC r333156: uniq(1): Add some long options.
MFC r333156: uniq(1): Add some long options
Wed, Jun 27, 8:56 PM
kevans committed rS335736: MFC r333122: seq(1): Provide some long options.
MFC r333122: seq(1): Provide some long options
Wed, Jun 27, 8:54 PM
kevans added inline comments to D15922: Added ssid values to render UTF-8 encoded characters in ifconfig(8).
Wed, Jun 27, 1:00 PM
kevans added a comment to D15922: Added ssid values to render UTF-8 encoded characters in ifconfig(8).

I guess what I'm getting at is- if it's not commonly set or exposed, I think we should go ahead and do this. If we get it wrong, there's always the temporary workaround of env LC_CTYPE=C ifconfig and exposing the SSID Encoding bit doesn't appear to be a monumental task.

Wed, Jun 27, 3:07 AM
kevans added a comment to D15922: Added ssid values to render UTF-8 encoded characters in ifconfig(8).

I'm not sure if I object to this change or not, but it's worth noting that SSIDs are not necessarily UTF-8 strings. Unless the SSIDEncoding is set it is 0-32 octets. Having 0 bytes in the middle of the SSID is valid (though I'd be very surprised if that actually worked on more than a handful of devices). If SSIDEncoding is set it is indeed a UTF-8 string.
For additional fun Microsoft got this wrong and several Windows versions interpret the SSID as being Latin1 encoded.

Wed, Jun 27, 2:58 AM

Tue, Jun 26

kevans updated the diff for D15953: Kernel environments: use any and all provided environments, evict hintmode and envmode.

Some relatively minor issues:

  • The logic for static_env.disabled was backwards
  • Initializing the dynamic env now uses the first value for a variable that it finds, and any later assignments of the same value are ignored. This is to match how searching the static environment in the kernel works so that we get consistent results between the static environment and the dynamic environment. config(8) should setup the static environment for us in such a way that a later assignment to a variable overrides an earlier assignment.
  • In rS273487. @cperciva started zero'ing out the static environment as it filled the dynamic environment to avoid leaking data from the kernel environment. I've extended this cleaning to zero out even the skipped entries to eradicate all traces of the static environment once we've provisioned the dynamic one.
Tue, Jun 26, 1:36 PM
kevans committed rS335654: config(8): part of patch disappeared, don't close ifp at the end.
config(8): part of patch disappeared, don't close ifp at the end
Tue, Jun 26, 4:07 AM
kevans committed rS335653: config(8): Flip the order of concatenation for `hints` and `env`.
config(8): Flip the order of concatenation for `hints` and `env`
Tue, Jun 26, 4:02 AM
kevans committed rS335652: config(8): Make 'env' files consistent with other file-accepting options.
config(8): Make 'env' files consistent with other file-accepting options
Tue, Jun 26, 3:56 AM
kevans committed rS335651: config(8): Set envmode if we accept an envvar.
config(8): Set envmode if we accept an envvar
Tue, Jun 26, 2:06 AM

Mon, Jun 25

kevans added inline comments to D15953: Kernel environments: use any and all provided environments, evict hintmode and envmode.
Mon, Jun 25, 7:07 PM
kevans updated the diff for D15953: Kernel environments: use any and all provided environments, evict hintmode and envmode.

Avoid reallocation if we're looking at a same-size replacement.

Mon, Jun 25, 6:44 PM
kevans added inline comments to D15953: Kernel environments: use any and all provided environments, evict hintmode and envmode.
Mon, Jun 25, 6:32 PM
kevans updated the diff for D15953: Kernel environments: use any and all provided environments, evict hintmode and envmode.

Add realloc missed in previous revision

Mon, Jun 25, 6:31 PM
kevans added a comment to D15953: Kernel environments: use any and all provided environments, evict hintmode and envmode.

I intend to commit this by the end of next week (July 6-8 time frame) without any strong objections, given the lack of any outcry from my e-mail to -arch/-embedded.

Mon, Jun 25, 5:47 PM
kevans committed rS335642: config(8): Add `envvar` support.
config(8): Add `envvar` support
Mon, Jun 25, 5:18 PM
kevans closed D15962: config(8): Add `envvar` support.
Mon, Jun 25, 5:18 PM

Sat, Jun 23

kevans updated the diff for D15962: config(8): Add `envvar` support.

This idea courtesy of ian@:

Sat, Jun 23, 12:55 AM

Fri, Jun 22

kevans added inline comments to D15962: config(8): Add `envvar` support.
Fri, Jun 22, 10:50 PM
kevans added a reviewer for D15953: Kernel environments: use any and all provided environments, evict hintmode and envmode: imp.
Fri, Jun 22, 9:34 PM
kevans added inline comments to D15962: config(8): Add `envvar` support.
Fri, Jun 22, 6:32 PM
kevans updated the diff for D15962: config(8): Add `envvar` support.

Updated following discussion on IRC with Ian:

Fri, Jun 22, 6:26 PM
kevans created D15962: config(8): Add `envvar` support.
Fri, Jun 22, 4:19 AM
kevans updated the diff for D15953: Kernel environments: use any and all provided environments, evict hintmode and envmode.

Add back in the ability to specify static_env.disabled and static_hints.disabled. The reimplementation of these follows suit with how we treat environments in the new age- static_hints.disabled may be specified in either static_env or loader(8) env, and static_env.disabled may only be specified in loader(8) env.

Fri, Jun 22, 2:56 AM

Thu, Jun 21

kevans committed rS335509: subr_hints: Fix acpi unit hinting (at the very least).
subr_hints: Fix acpi unit hinting (at the very least)
Thu, Jun 21, 9:50 PM
kevans added a comment to D15955: Discover cards on boot.

Tested on: Lamobo R1 w/ root-on-SD

Thu, Jun 21, 7:24 PM
kevans created D15953: Kernel environments: use any and all provided environments, evict hintmode and envmode.
Thu, Jun 21, 3:38 PM
kevans committed rS335479: subr_hints: simplify a little bit.
subr_hints: simplify a little bit
Thu, Jun 21, 2:04 PM
kevans closed D15940: subr_hints: simplify a little bit.
Thu, Jun 21, 2:04 PM
kevans committed rS335467: Don't remove loader.conf(5) when built WITHOUT_FORTH.
Don't remove loader.conf(5) when built WITHOUT_FORTH
Thu, Jun 21, 5:28 AM

Wed, Jun 20

kevans created D15940: subr_hints: simplify a little bit.
Wed, Jun 20, 11:43 PM
kevans committed rS335458: Add debug.verbose_sysinit tunable for VERBOSE_SYSINIT.
Add debug.verbose_sysinit tunable for VERBOSE_SYSINIT
Wed, Jun 20, 7:24 PM
kevans added inline comments to D15917: uefi stand: Guess the console better.
Wed, Jun 20, 1:05 PM
kevans committed rS335404: sort(1): Fix -m when only implicit stdin is used for input.
sort(1): Fix -m when only implicit stdin is used for input
Wed, Jun 20, 3:31 AM
kevans committed rS335403: sort(1): Add bits to allow easy checking against NetBSD tests.
sort(1): Add bits to allow easy checking against NetBSD tests
Wed, Jun 20, 3:11 AM
kevans added inline comments to D15917: uefi stand: Guess the console better.
Wed, Jun 20, 12:44 AM

Tue, Jun 19

kevans added a comment to D15891: Add MMCCAM support to AllWinner MMC driver.
In D15891#336632, @imp wrote:

Please do mention in the commit message that MMCCAM is not usable on Allwinner boards using root-on-MMC to curtail that set of complaints if people actually try it.

why not? What breaks?

Tue, Jun 19, 7:51 PM
kevans added a comment to D15891: Add MMCCAM support to AllWinner MMC driver.

Please do mention in the commit message that MMCCAM is not usable on Allwinner boards using root-on-MMC to curtail that set of complaints if people actually try it.

Tue, Jun 19, 4:37 PM
kevans committed rS335371: lualoader: Correct kernel_options handling.
lualoader: Correct kernel_options handling
Tue, Jun 19, 3:05 PM

Jun 16 2018

kevans committed rD51841: Swap out PGP key for new ed25519-based key.
Swap out PGP key for new ed25519-based key
Jun 16 2018, 5:29 AM

Jun 15 2018

kevans added reviewers for D15833: truss: add option to print the active syscall(s) if no activity after N seconds.: jhb, tuexen.

Adding @jhb and @tuexen as possible reviewers

Jun 15 2018, 8:39 PM
kevans committed rS335220: extres/regulator: Switch boot_on/always_on sysctl to uint8.
extres/regulator: Switch boot_on/always_on sysctl to uint8
Jun 15 2018, 5:29 PM
kevans committed rS335195: Revert r335173 at request of mmel@.
Revert r335173 at request of mmel@
Jun 15 2018, 1:15 PM
kevans committed rS335188: bsdgrep(1): Remove redundant initialization; unconditionally assigned later.
bsdgrep(1): Remove redundant initialization; unconditionally assigned later
Jun 15 2018, 3:31 AM

Jun 14 2018

kevans committed rS335173: extres/regulator: Properly refcount gpio regulators.
extres/regulator: Properly refcount gpio regulators
Jun 14 2018, 8:37 PM
kevans committed rS335168: a10_ahci: Correct clock indices for new bindings.
a10_ahci: Correct clock indices for new bindings
Jun 14 2018, 6:34 PM
kevans committed rS335165: aw_ccung: Add a10/a20 support.
aw_ccung: Add a10/a20 support
Jun 14 2018, 5:50 PM
kevans closed D15810: aw_ccung: Add a10/a20 support.
Jun 14 2018, 5:50 PM
kevans committed rS335162: aw_ccung: Support clock factors where factor=0, factor is effectively 1.
aw_ccung: Support clock factors where factor=0, factor is effectively 1
Jun 14 2018, 5:36 PM
kevans closed D15806: aw_ccung: Support clock factors where factor=0, factor is effectively 1.
Jun 14 2018, 5:36 PM
kevans added a comment to D15810: aw_ccung: Add a10/a20 support.
In D15810#334274, @manu wrote:

I prefer spliting the A10 and A20 right now even if for now they are the same.

Jun 14 2018, 5:27 PM
kevans added a dependent revision for D15806: aw_ccung: Support clock factors where factor=0, factor is effectively 1: D15810: aw_ccung: Add a10/a20 support.
Jun 14 2018, 5:17 PM
kevans added a dependency for D15810: aw_ccung: Add a10/a20 support: D15806: aw_ccung: Support clock factors where factor=0, factor is effectively 1.
Jun 14 2018, 5:17 PM