Page MenuHomeFreeBSD

kevans (Kyle Evans)
User

Projects

User Details

User Since
Oct 2 2015, 1:17 PM (202 w, 1 d)

Recent Activity

Fri, Aug 16

kevans added a comment to D21263: tap: add support for virtio-net offloads.

In any case this patch needs more work to support capabilities enable/disable (e.g. ifconfig tap0 -tso).
Also, it's probably not a good idea to update if_capenable on TAPSVNETHDR, as the current patch does right now, and let the user program do that explicitly.
I'd like to hear the maintainers' opinion here.

Fri, Aug 16, 9:35 PM
kevans committed rS351145: MFC r351078, r351085, r351088: mostly a nop (two commits + revert of two).
MFC r351078, r351085, r351088: mostly a nop (two commits + revert of two)
Fri, Aug 16, 9:14 PM
kevans committed rS351143: MFC r350630, r350657: static analysis fixes from Haiku.
MFC r350630, r350657: static analysis fixes from Haiku
Fri, Aug 16, 9:04 PM
kevans committed rS351142: MFC r350464: kern_shm_open: push O_CLOEXEC into caller control.
MFC r350464: kern_shm_open: push O_CLOEXEC into caller control
Fri, Aug 16, 9:01 PM
kevans committed rS351136: stand: gptboot: fix build with xtoolchain-llvm90.
stand: gptboot: fix build with xtoolchain-llvm90
Fri, Aug 16, 8:09 PM
kevans closed D21291: stand: fix build with xtoolchain-llvm90.
Fri, Aug 16, 8:08 PM
kevans committed rS351135: stand: boot2: fix build with xtoolchain-llvm90.
stand: boot2: fix build with xtoolchain-llvm90
Fri, Aug 16, 8:08 PM
kevans added a comment to D21278: Update XFCE to 4.14.

To be clear to non-sbruno people that may glance over this... arc diff (and default svn diff without --show-copies-as-adds) is generating a diff against the version that this was repocopied from, since it's being revived from history. patch(1) cannot do the right thing with this, as it doesn't have the svn history available for context. svn patch can probably do the right thing, but it's not clear to me that the markings needed for it to get it right are preserved when it hits Phab.

Exactly what I did to resuscitate the port without loosing history as required.

Fri, Aug 16, 5:19 PM · xfce
kevans added a comment to D21278: Update XFCE to 4.14.

Hrm ... phabricator and patch really don't like to apply this to my local tree. It chokes on adding new stuff and I can't seem to work around it. Any suggestions?

Strange, I generated it using arc from command line.
You can grab a ports overlay here:
https://github.com/madpilot78/FreeBSD-xfce4.13
it's the same as the patch.
I also uploaded the result of svn diff here:
https://people.freebsd.org/~madpilot/xfce414.diff

Can you regenerate the svn diff with "--show-copies-as-adds"? The xfce4-places-plugin directory is very confused in the diff. It shows that it was copied from somewhere, but its not clear where it was copied from.

Fri, Aug 16, 4:43 PM · xfce
kevans updated the summary of D21291: stand: fix build with xtoolchain-llvm90.
Fri, Aug 16, 3:02 PM
kevans added inline comments to D21291: stand: fix build with xtoolchain-llvm90.
Fri, Aug 16, 2:32 PM
kevans added inline comments to D21291: stand: fix build with xtoolchain-llvm90.
Fri, Aug 16, 2:11 PM
kevans created D21291: stand: fix build with xtoolchain-llvm90.
Fri, Aug 16, 1:45 PM
kevans committed rS351119: stand: push LIBC_SRC up into defs.mk.
stand: push LIBC_SRC up into defs.mk
Fri, Aug 16, 1:23 PM
kevans closed D21282: stand: fix build with xtoolchain-llvm90.
Fri, Aug 16, 1:23 PM
kevans updated the summary of D21282: stand: fix build with xtoolchain-llvm90.
Fri, Aug 16, 12:30 AM
kevans created D21282: stand: fix build with xtoolchain-llvm90.
Fri, Aug 16, 12:29 AM
D21281: Work around a bug in the EFI HTTP driver is now accepted and ready to land.

This seems to LGTM.

Fri, Aug 16, 12:10 AM

Thu, Aug 15

kevans committed rS351094: MFC r350576: ipfw: fix jail option after r348215.
MFC r350576: ipfw: fix jail option after r348215
Thu, Aug 15, 5:41 PM
kevans closed D21274: rtld-elf: fix build with xtoolchain-llvm90.
Thu, Aug 15, 5:37 PM
kevans committed rS351093: rtld-elf: fix build with xtoolchain-llvm90.
rtld-elf: fix build with xtoolchain-llvm90
Thu, Aug 15, 5:35 PM
kevans committed rS351088: Revert r351078, r351085: stand/quad.h eviction.
Revert r351078, r351085: stand/quad.h eviction
Thu, Aug 15, 5:15 PM
kevans committed rS351085: libc quad.h: one last _STANDALONE correction.
libc quad.h: one last _STANDALONE correction
Thu, Aug 15, 4:28 PM
kevans committed rS351078: stand: kick out quad.h.
stand: kick out quad.h
Thu, Aug 15, 3:47 PM
kevans created D21274: rtld-elf: fix build with xtoolchain-llvm90.
Thu, Aug 15, 2:59 PM

Fri, Aug 9

kevans added a comment to D21194: libcasper/libnv: various error handling changes.

Plugs a potential nvlist/fd leak in fileargs_add_cache. The fd is moved into new if it succeeds, and new is cloned into nvlout with the fd dup'd. Destroy new after nvlist_add whether it failed or not to plug it.

Fri, Aug 9, 12:20 AM

Thu, Aug 8

kevans added a comment to D21194: libcasper/libnv: various error handling changes.

the libnv(3) change could/should probably only drain enough bytes to hold the cmsg that can't happen (nfds * CMSG_SPACE(sizeof(int)) + sizeof(struct msghdr).

Thu, Aug 8, 9:37 PM
kevans created D21194: libcasper/libnv: various error handling changes.
Thu, Aug 8, 9:27 PM

Wed, Aug 7

kevans created D21183: makeLINT: consistently clean up extra LINT.
Wed, Aug 7, 8:43 PM

Tue, Aug 6

kevans committed rS350657: ral: rt2860: fix wcid2ni access/size issue.
ral: rt2860: fix wcid2ni access/size issue
Tue, Aug 6, 8:22 PM
kevans committed rS350630: oce(4): potential out of bounds access before vector validation.
oce(4): potential out of bounds access before vector validation
Tue, Aug 6, 1:09 PM

Mon, Aug 5

kevans committed rS350576: ipfw: fix jail option after r348215.
ipfw: fix jail option after r348215
Mon, Aug 5, 12:08 AM
kevans closed D21128: ipfw: fix jail option.
Mon, Aug 5, 12:08 AM

Fri, Aug 2

kevans added a comment to D21128: ipfw: fix jail option.

The user who reported this on freebsd-stable@ confirms that it works for them, so I'll likely commit it tomorrow morning (~20 hours from now) with a 3-day MFC window and afterwards propose it as 11.3 EN.

Fri, Aug 2, 6:25 PM

Thu, Aug 1

kevans created D21128: ipfw: fix jail option.
Thu, Aug 1, 4:01 PM

Wed, Jul 31

kevans committed rS350465: MFC r350336: if_tun(4): Add TUNGIFNAME.
MFC r350336: if_tun(4): Add TUNGIFNAME
Wed, Jul 31, 3:56 PM
kevans committed rS350464: kern_shm_open: push O_CLOEXEC into caller control.
kern_shm_open: push O_CLOEXEC into caller control
Wed, Jul 31, 3:17 PM
kevans closed D21119: kern_shm_open: push O_CLOEXEC into caller controller.
Wed, Jul 31, 3:17 PM
kevans updated the summary of D21119: kern_shm_open: push O_CLOEXEC into caller controller.
  • sys_shm_open -> sys_shm_open()
  • update previously missed cloudabi caller to also unconditionally set O_CLOEXEC to maintain previous behavior
Wed, Jul 31, 3:08 AM

Tue, Jul 30

kevans added inline comments to D21111: beinstall.sh: Use bectl instead of beadm by default.
Tue, Jul 30, 9:37 PM
kevans added a reviewer for D21111: beinstall.sh: Use bectl instead of beadm by default: kevans.

Throwing myself on as a reviewer so I remember to circle back to this... I seem to recall that bectl might have some issue with mount (not mounting everything that might be needed for some setups, maybe?) -- I'll search through my e-mail and get back to this, though.

Tue, Jul 30, 9:36 PM
kevans updated subscribers of D21119: kern_shm_open: push O_CLOEXEC into caller controller.

What about cloudabi_sys_fd_create1()? There is no reference to CLOEXEC at all in the cloudabi code, so it's not clear to me whether it cares about this particular case.

Tue, Jul 30, 8:11 PM
kevans created D21119: kern_shm_open: push O_CLOEXEC into caller controller.
Tue, Jul 30, 7:50 PM
kevans accepted D21113: Enable copy_file_range(2) in capability mode..
Tue, Jul 30, 3:12 PM

Fri, Jul 26

kevans committed rS350344: MFC r349380, r349383, r349455: bectl(8)/libbe(3) fixes.
MFC r349380, r349383, r349455: bectl(8)/libbe(3) fixes
Fri, Jul 26, 1:50 AM
kevans committed rS350342: MFC r348471: stand: zfs: Free bouncebuf on error path in vdev_read.
MFC r348471: stand: zfs: Free bouncebuf on error path in vdev_read
Fri, Jul 26, 1:47 AM
kevans committed rS350341: MFC r344226, r344234: stand: zfs memory corruption bug.
MFC r344226, r344234: stand: zfs memory corruption bug
Fri, Jul 26, 1:45 AM
kevans committed rS350340: MFC r348328: bectl(8): Address Coverity complaints.
MFC r348328: bectl(8): Address Coverity complaints
Fri, Jul 26, 1:42 AM
kevans committed rS350339: Partial revert r350338: stable/11 part.
Partial revert r350338: stable/11 part
Fri, Jul 26, 1:38 AM
kevans committed rS350338: MFC r348328: bectl(8): Address Coverity complaints.
MFC r348328: bectl(8): Address Coverity complaints
Fri, Jul 26, 1:35 AM

Thu, Jul 25

kevans committed rS350336: if_tuntap(4): Add TUNGIFNAME.
if_tuntap(4): Add TUNGIFNAME
Thu, Jul 25, 10:23 PM

Wed, Jul 24

kevans created P278 (An Untitled Masterwork).
Wed, Jul 24, 6:59 PM

Jul 11 2019

kevans added inline comments to D20046: cron: add log suppression and mail suppression for successful runs.
Jul 11 2019, 3:43 AM
kevans added a comment to D20046: cron: add log suppression and mail suppression for successful runs.

Sorry for the long delay... I think just these really minor style nits.

Jul 11 2019, 2:47 AM

Jul 10 2019

kevans added inline comments to D20811: Allow efi loader to get network params from uboot.
Jul 10 2019, 4:03 PM
kevans added inline comments to D20811: Allow efi loader to get network params from uboot.
Jul 10 2019, 4:02 PM

Jun 27 2019

kevans committed rS349455: bectl(8): create non-recursive boot environments.
bectl(8): create non-recursive boot environments
Jun 27 2019, 2:03 PM
kevans closed D20240: create non-recursive boot environments (bectl).
Jun 27 2019, 2:03 PM
kevans added a comment to D20773: stand: shuffle dv_open/dv_init bits around.

conf.c -> devsw.c
dv_inited -> dv_flags (I liked DV_FLAG_INIT_DONE)

Jun 27 2019, 12:39 AM

Jun 26 2019

kevans updated the summary of D20773: stand: shuffle dv_open/dv_init bits around.

Address review comments:

  • Delete stale comment
  • Push dev == null check into dv_open wrapper
Jun 26 2019, 7:55 PM
kevans created D20773: stand: shuffle dv_open/dv_init bits around.
Jun 26 2019, 6:09 PM

Jun 25 2019

kevans committed rS349383: libbe(3): restructure be_mount, skip canmount check for BE dataset.
libbe(3): restructure be_mount, skip canmount check for BE dataset
Jun 25 2019, 6:48 PM
kevans committed rS349380: libbe(3): mount: the BE dataset is mounted at /.
libbe(3): mount: the BE dataset is mounted at /
Jun 25 2019, 6:13 PM

Jun 13 2019

kevans accepted D20626: bhyve: move common code to net_utils.c.

I am pulling Kyle Evans in on this as he just did a bunch of cleanup on mac generation code and there may already be existing code to reused rather than have yet another mac generator.

Jun 13 2019, 4:39 PM

Jun 10 2019

kevans committed rS348867: MFC r342747 (mmacy): zfsboot: support newer ZFS versions.
MFC r342747 (mmacy): zfsboot: support newer ZFS versions
Jun 10 2019, 4:36 PM
kevans committed rS348866: MFC r348569: [zfsboot] Fix boot env back compat (#190).
MFC r348569: [zfsboot] Fix boot env back compat (#190)
Jun 10 2019, 3:55 PM
kevans committed rS348865: MFC r348569: [zfsboot] Fix boot env back compat (#190).
MFC r348569: [zfsboot] Fix boot env back compat (#190)
Jun 10 2019, 3:46 PM
kevans committed rS348863: MFC r348510: bectl(8): Don't accept jid=0 from jail_getid.
MFC r348510: bectl(8): Don't accept jid=0 from jail_getid
Jun 10 2019, 2:48 PM
kevans committed rS348862: MFC r348510: bectl(8): Don't accept jid=0 from jail_getid.
MFC r348510: bectl(8): Don't accept jid=0 from jail_getid
Jun 10 2019, 2:35 PM

Jun 4 2019

kevans accepted D20513: Fix regression in r347193 in selecting which drive to boot..
Jun 4 2019, 5:05 PM

Jun 3 2019

kevans committed rS348546: MFC r348509: jail_getid(3): add special-case immediate return for jid 0.
MFC r348509: jail_getid(3): add special-case immediate return for jid 0
Jun 3 2019, 4:48 PM
kevans committed rS348538: MFC r348509: jail_getid(3): add special-case immediate return for jid 0.
MFC r348509: jail_getid(3): add special-case immediate return for jid 0
Jun 3 2019, 3:28 PM

Jun 2 2019

kevans committed rS348510: bectl(8): Don't accept jid=0 from jail_getid.
bectl(8): Don't accept jid=0 from jail_getid
Jun 2 2019, 2:06 PM
kevans committed rS348509: jail_getid(3): add special-case immediate return for jid 0.
jail_getid(3): add special-case immediate return for jid 0
Jun 2 2019, 2:04 PM
kevans committed rS348504: llvm-symbolizer: Move out of CLANG_EXTRAS, into CLANG.
llvm-symbolizer: Move out of CLANG_EXTRAS, into CLANG
Jun 2 2019, 4:04 AM
kevans closed D20484: llvm-symbolizer: Move out of CLANG_EXTRAS, into CLANG.
Jun 2 2019, 4:04 AM
kevans committed rS348503: grep: Move lone 'r'grep case into the adjacent switch.
grep: Move lone 'r'grep case into the adjacent switch
Jun 2 2019, 2:39 AM

May 31 2019

kevans updated the diff for D20483: stand: evict zfs_alloc/zfs_free.

Take two, a little better... some of the raidz verification stuff needs a small API revamp or reconsideration if we want to try and recover from those, and we may want to improve diagnostics a little bit in other areas.

May 31 2019, 8:20 PM
kevans created D20484: llvm-symbolizer: Move out of CLANG_EXTRAS, into CLANG.
May 31 2019, 7:38 PM
kevans created D20483: stand: evict zfs_alloc/zfs_free.
May 31 2019, 6:59 PM
kevans committed rS348471: stand: zfs: Free bouncebuf on error path in vdev_read.
stand: zfs: Free bouncebuf on error path in vdev_read
May 31 2019, 5:44 PM
kevans committed rP503173: games/gzdoom: Fix 32-bit build after r501260 (update to 4.1.1).
games/gzdoom: Fix 32-bit build after r501260 (update to 4.1.1)
May 31 2019, 1:30 PM

May 30 2019

kevans updated the summary of D20468: Port if_vether from OpenBSD.
May 30 2019, 1:27 PM
kevans created D20468: Port if_vether from OpenBSD.
May 30 2019, 4:15 AM

May 29 2019

kevans added a comment to D20278: vimage: support kmods determining VIMAGE status at runtime.
In D20278#441710, @bz wrote:

Hi,
I just only scrolled through this and there's a few things. I am not going into detail at the moment as I'd love to give this a full review once my brain capacity for yet-another-module-thing-complication is there. It'll be helpful to later decompose this into "whitespace change" and functional change (as a lot of renaming, etc. makes this hard to read).
We still have architectures where we cannot get in-src-tree modules built along kernel non-panicing in all cases. We've been dealing and finding edge-cases over the last 18 months. While I appreciate the effort of trying to solve more kernel module problems and easing pain, can you please hold this off at least until the more severe problems are fixed?

May 29 2019, 3:00 PM
kevans added a reviewer for D20278: vimage: support kmods determining VIMAGE status at runtime: pawel.biernacki-gmail.com.
May 29 2019, 2:08 PM
kevans committed rS348346: if_bridge(4): Complete bpf auditing of local traffic over the bridge.
if_bridge(4): Complete bpf auditing of local traffic over the bridge
May 29 2019, 1:08 AM
kevans closed D19757: if_bridge(4): Complete bpf auditing of local traffic over the bridge.
May 29 2019, 1:08 AM

May 28 2019

kevans committed rS348328: bectl(8): Address Coverity complaints.
bectl(8): Address Coverity complaints
May 28 2019, 4:12 PM

May 27 2019

kevans committed rS348305: MFC r348127: bectl(8): add description for create subcommand.
MFC r348127: bectl(8): add description for create subcommand
May 27 2019, 1:14 PM
kevans committed rS348304: MFC r348215, r348219: fix bectl(8) jail w/ numeric BE names.
MFC r348215, r348219: fix bectl(8) jail w/ numeric BE names
May 27 2019, 1:13 PM
kevans committed rS348297: MFC r348215, r348219: fix bectl(8) jail w/ numeric BE names.
MFC r348215, r348219: fix bectl(8) jail w/ numeric BE names
May 27 2019, 2:18 AM
kevans committed rS348296: MFC r348127: bectl(8): add description for create subcommand.
MFC r348127: bectl(8): add description for create subcommand
May 27 2019, 2:17 AM

May 24 2019

kevans added a comment to D20293: ucom(4): synchronously execute param changes.

The part that runs off the USB process threads is fine. But what contexts can ucom_param() be called from. Is there any chance of race here?

May 24 2019, 12:33 PM
kevans added a comment to D20293: ucom(4): synchronously execute param changes.

What happens if there are two threads calling the function where you drop the lock?

May 24 2019, 11:40 AM
kevans added a comment to D20293: ucom(4): synchronously execute param changes.

Just make sure that ucom_param() won't race when you drop the lock.

May 24 2019, 3:45 AM
kevans added a comment to D16653: libfdt: Update to 1.5.0.

Looks OK to me. One question: Do we want the various instances of fdt_check_header() in our code to be spelled FDT_RO_PROBE() now?

Yeah, neither loader nor the kernel need care for the extra bits done by fdt_check_header. I'll spin up a patch to do this conversion separately, to be committed after the 1.5.0 update since it's not critical.

May 24 2019, 2:21 AM
kevans updated the diff for D16653: libfdt: Update to 1.5.0.
May 24 2019, 2:18 AM
kevans committed rS348221: Tag libfdt 1.5.0.
Tag libfdt 1.5.0
May 24 2019, 2:11 AM
kevans committed rS348220: Import libfdt from dtc 1.5.0.
Import libfdt from dtc 1.5.0
May 24 2019, 2:10 AM