Page MenuHomeFreeBSD

kevans (Kyle Evans)
User

Projects (9)

User Details

User Since
Oct 2 2015, 1:17 PM (390 w, 6 d)

Recent Activity

Today

kevans accepted D39346: bectl: Improve error message when libbe_init() fails.

I'm OK with this, but I note that the -r option isn't documented at all because it wasn't actually supposed to be generally useful. We should probably fix that so that this message makes sense, since it *is* generally useful (for precisely scenarios like this).

Thu, Mar 30, 8:38 PM

Sun, Mar 26

kevans closed D39277: arm64: cpu_switch: don't zero out pcb_onfault.
Sun, Mar 26, 7:22 PM
kevans committed rGec1bc530027f: arm64: cpu_switch: don't zero out pcb_onfault (authored by kevans).
arm64: cpu_switch: don't zero out pcb_onfault
Sun, Mar 26, 7:22 PM
kevans updated the summary of D39277: arm64: cpu_switch: don't zero out pcb_onfault.
Sun, Mar 26, 4:53 PM
kevans requested review of D39277: arm64: cpu_switch: don't zero out pcb_onfault.
Sun, Mar 26, 4:46 PM
kevans updated the diff for D39083: flua: lposix: add more useful functions for general purpose scripts.

Use allocf, matches lua's internal naming

Sun, Mar 26, 4:27 PM

Sat, Mar 25

kevans accepted D39258: makefs: emit NM records for all directory entries.

We could continue to omit the NM record for directories that would avoid
mapping (for example, one named 1234.567) but this does not seem worth
the complexity.

Sat, Mar 25, 4:03 AM

Thu, Mar 23

kevans committed rG698dbd66fed2: arm64: add a GENERIC-KASAN config (authored by mhorne).
arm64: add a GENERIC-KASAN config
Thu, Mar 23, 10:09 PM
kevans committed rG89c52f9d59fa: arm64: add KASAN support (authored by kevans).
arm64: add KASAN support
Thu, Mar 23, 10:08 PM
kevans closed D36701: arm64: add KASAN support.
Thu, Mar 23, 10:08 PM
kevans closed D36702: arm64: add a GENERIC-KASAN config.
Thu, Mar 23, 10:08 PM
kevans accepted D39231: makefs: correct El Torito bood record.

This matches my reading of the spec; single LE DWORD.

Thu, Mar 23, 9:33 PM
kevans accepted D39221: makefs: correct iso9660 Rock Ridge TF timestamps.
Thu, Mar 23, 3:34 AM
kevans committed rGb84aaf143c50: daemon: reformat longopts (authored by kevans).
daemon: reformat longopts
Thu, Mar 23, 3:15 AM
kevans committed rG4c41f4a0d67f: daemon: decouple init logic from main loop (authored by ihor_antonovs.family).
daemon: decouple init logic from main loop
Thu, Mar 23, 3:14 AM

Wed, Mar 22

kevans added inline comments to D36701: arm64: add KASAN support.
Wed, Mar 22, 10:08 PM
kevans updated the diff for D36701: arm64: add KASAN support.

Incorporate further fixes, notably:

Wed, Mar 22, 7:06 PM
kevans added a reviewer for D39011: Enable jail(8) to parse all config files: Jails.
Wed, Mar 22, 5:14 AM

Tue, Mar 21

kevans committed rG9ee1faeebab5: daemon: move signal setup into a function (authored by ihor_antonovs.family).
daemon: move signal setup into a function
Tue, Mar 21, 5:15 AM
kevans committed R11:e500acf64f29: devel/arm-none-eabi-newlib: fix the build with newer clang (authored by kevans).
devel/arm-none-eabi-newlib: fix the build with newer clang
Tue, Mar 21, 5:11 AM
kevans committed R11:d8dd1f531d8f: devel/arm-none-eabi-newlib: fix the build with newer clang (authored by kevans).
devel/arm-none-eabi-newlib: fix the build with newer clang
Tue, Mar 21, 5:05 AM

Mon, Mar 20

kevans committed rG822057bfbbbc: pkill: tests: do a pass for case-sensitive conflicts (authored by kevans).
pkill: tests: do a pass for case-sensitive conflicts
Mon, Mar 20, 7:57 PM
kevans closed D38663: pkill: use an ARG_MAX size buffer for argument matching.
Mon, Mar 20, 7:21 PM
kevans committed rG3610bffd2888: pkill: use an ARG_MAX size buffer for argument matching (authored by kevans).
pkill: use an ARG_MAX size buffer for argument matching
Mon, Mar 20, 7:21 PM

Sat, Mar 18

kevans committed rG6b49a630f441: daemon: kill off some stray blank lines (authored by kevans).
daemon: kill off some stray blank lines
Sat, Mar 18, 6:06 AM
kevans committed rGcf6356fd471c: daemon: repace goto exit with daemon_terminate() (authored by ihor_antonovs.family).
daemon: repace goto exit with daemon_terminate()
Sat, Mar 18, 5:55 AM
kevans committed rG8117ea0a4131: daemon: remove unnecessary memset in daemon_state_init() (authored by ihor_antonovs.family).
daemon: remove unnecessary memset in daemon_state_init()
Sat, Mar 18, 5:55 AM

Fri, Mar 17

kevans committed rG799d67ec407f: daemon: set supervise_enabled during argument processing (authored by ihor_antonovs.family).
daemon: set supervise_enabled during argument processing
Fri, Mar 17, 9:08 PM
kevans committed rG3f0b048a24bc: daemon: add braces to while loop (authored by ihor_antonovs.family).
daemon: add braces to while loop
Fri, Mar 17, 9:08 PM
kevans committed rG204306b0532a: daemon: flatten and simplify fork() logic (authored by ihor_antonovs.family).
daemon: flatten and simplify fork() logic
Fri, Mar 17, 9:07 PM
kevans committed rGbc9d2ee0a7ac: daemon: simplify if/else chain (authored by ihor_antonovs.family).
daemon: simplify if/else chain
Fri, Mar 17, 9:03 PM
kevans committed rG05578dd5218d: daemon: style changes (authored by ihor_antonovs.family).
daemon: style changes
Fri, Mar 17, 9:02 PM
kevans committed rG8eb1e5dd77ca: daemon: more human-friendly variable names (authored by ihor_antonovs.family).
daemon: more human-friendly variable names
Fri, Mar 17, 9:02 PM
kevans committed rGd8b8a0316ed7: daemon: move syslog facility and syslog tag into log_params (authored by ihor_antonovs.family).
daemon: move syslog facility and syslog tag into log_params
Fri, Mar 17, 9:02 PM
kevans committed rGb71a65870f4d: daemon: deduplicate log_params varaibles (authored by ihor_antonovs.family).
daemon: deduplicate log_params varaibles
Fri, Mar 17, 9:02 PM
kevans committed rG5e46ebc5d0a4: daemon: make log_reopen variable a bool (authored by ihor_antonovs.family).
daemon: make log_reopen variable a bool
Fri, Mar 17, 9:02 PM
kevans committed rGd394c80f4950: daemon: make dosyslog variable a bool and give it a better name (authored by ihor_antonovs.family).
daemon: make dosyslog variable a bool and give it a better name
Fri, Mar 17, 9:02 PM
kevans committed rG6f71a684560f: daemon: add supervision_enabled var (authored by ihor_antonovs.family).
daemon: add supervision_enabled var
Fri, Mar 17, 9:02 PM
kevans committed rGcc123f0dba83: daemon: initialize mask_orig with sigemptyset() (authored by ihor_antonovs.family).
daemon: initialize mask_orig with sigemptyset()
Fri, Mar 17, 9:02 PM
kevans committed rG52f302f1361f: daemon: initialize struct sigaction at declaration site (authored by ihor_antonovs.family).
daemon: initialize struct sigaction at declaration site
Fri, Mar 17, 9:02 PM
kevans committed rG93871c6cff22: daemon: fix double init of pid variable (authored by ihor_antonovs.family).
daemon: fix double init of pid variable
Fri, Mar 17, 9:02 PM
kevans committed rGd24c97ebfb86: daemon: consolidate variable declarations and initializaions (authored by ihor_antonovs.family).
daemon: consolidate variable declarations and initializaions
Fri, Mar 17, 9:02 PM
kevans committed rG488cf4bb6fa1: daemon: use braces with 'if' consistently (authored by ihor_antonovs.family).
daemon: use braces with 'if' consistently
Fri, Mar 17, 9:02 PM
kevans committed rG282e4cf32d4e: daemon: add long_opts (authored by ihor_antonovs.family).
daemon: add long_opts
Fri, Mar 17, 9:02 PM
kevans closed D39140: x86: gate smbios hypervisor identification behind vm_guest.
Fri, Mar 17, 5:57 AM
kevans committed rGf7a884cb017f: x86: gate smbios hypervisor identification behind vm_guest (authored by kevans).
x86: gate smbios hypervisor identification behind vm_guest
Fri, Mar 17, 5:57 AM
kevans added a comment to D39140: x86: gate smbios hypervisor identification behind vm_guest.
In D39140#890858, @kib wrote:

No objections, but IMO it would be slightly cleaner to check the condition in identify_hypervisor_smbios() and immediately return, instead of asserting.

Fri, Mar 17, 5:51 AM
kevans committed rG6fdb5daba679: efifb: add a tunable to select the framebuffer cache attribute (authored by kevans).
efifb: add a tunable to select the framebuffer cache attribute
Fri, Mar 17, 5:49 AM
kevans committed rG1e6d266d70e9: kern: physmem: don't create a new exregion for different flags... (authored by kevans).
kern: physmem: don't create a new exregion for different flags...
Fri, Mar 17, 5:49 AM
kevans committed rGd18524b6f720: grep: remove tautological condition (authored by kevans).
grep: remove tautological condition
Fri, Mar 17, 5:49 AM
kevans committed rG04accaacd45a: i18n: csmapper: hook up the top-level .src files to the build (authored by kevans).
i18n: csmapper: hook up the top-level .src files to the build
Fri, Mar 17, 5:49 AM
kevans committed rGcda391fe2207: iconvlist(3): fix count argument type (authored by kevans).
iconvlist(3): fix count argument type
Fri, Mar 17, 5:49 AM
kevans committed rG7c0cbba1d51d: kern: physmem: don't truncate addresses in DEBUG output (authored by kevans).
kern: physmem: don't truncate addresses in DEBUG output
Fri, Mar 17, 5:49 AM
kevans updated the diff for D38663: pkill: use an ARG_MAX size buffer for argument matching.

s/1/STATUS_ERROR/ per review comment

Fri, Mar 17, 4:50 AM
kevans updated the diff for D38663: pkill: use an ARG_MAX size buffer for argument matching.

Switch to a fixed ARG_MAX * 2 buffer instead of complicating it with realloc()

Fri, Mar 17, 4:49 AM
kevans retitled D38663: pkill: use an ARG_MAX size buffer for argument matching from pkill: use a dynamic buffer to allow for searching longer arguments to pkill: use an ARG_MAX size buffer for argument matching.
Fri, Mar 17, 4:48 AM
kevans added inline comments to D39140: x86: gate smbios hypervisor identification behind vm_guest.
Fri, Mar 17, 4:08 AM
kevans added a comment to D39140: x86: gate smbios hypervisor identification behind vm_guest.

See also: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=270239, this is the cause of at least Hyper-V failing to boot.

Fri, Mar 17, 12:18 AM
kevans requested review of D39140: x86: gate smbios hypervisor identification behind vm_guest.
Fri, Mar 17, 12:15 AM

Thu, Mar 16

kevans accepted D39116: tail: Verify correct behavior when input does not end in a newline..
Thu, Mar 16, 2:41 PM

Wed, Mar 15

kevans abandoned D23128: Fix the GOOGLETEST build with mips-gcc{6,9}.

Run away

Wed, Mar 15, 5:31 PM
kevans accepted D39093: Use the physical timer when able.
Wed, Mar 15, 3:38 PM
kevans accepted D39094: Stop using the rid as an index in the arm timer.
Wed, Mar 15, 3:38 PM
kevans added inline comments to D39094: Stop using the rid as an index in the arm timer.
Wed, Mar 15, 3:06 PM
kevans requested review of D39084: tools: build: add a rewrite of makeman in lua.
Wed, Mar 15, 5:32 AM
kevans requested review of D39083: flua: lposix: add more useful functions for general purpose scripts.
Wed, Mar 15, 5:31 AM

Tue, Mar 14

kevans abandoned D39074: arm: generic_timer: dedupe resource specs between ACPI and FDT.

Abandoning in favor of D37424, which actually goes the other way and removes the resource_spec.

Tue, Mar 14, 3:21 PM
kevans accepted D37424: Keep per-timer interrupt data together.

I'm actually happy with this as-is whether we go the extra step right now or not, forgot to click the button.

Tue, Mar 14, 3:14 PM
kevans added a comment to D37424: Keep per-timer interrupt data together.

IMO let's go one step further and remove the significance of the index into sc->irqs

Tue, Mar 14, 3:02 PM
kevans requested review of D39074: arm: generic_timer: dedupe resource specs between ACPI and FDT.
Tue, Mar 14, 4:47 AM
kevans committed rG91b2da13702f: arm: generic_timer: use interrupt-names when available (authored by kevans).
arm: generic_timer: use interrupt-names when available
Tue, Mar 14, 12:32 AM
kevans closed D38911: arm: generic_timer: use interrupt-names when available.
Tue, Mar 14, 12:31 AM
kevans accepted D39059: Always enable the virtual timer for usersapce.

s/usersapce/userspace/ in subject line

Tue, Mar 14, 12:28 AM

Fri, Mar 10

kevans updated the diff for D38911: arm: generic_timer: use interrupt-names when available.
  • Not finding a required interrupt in interrupt-names now errors out
  • Less verbose when we can't find optional interrupt-names, bootverbose to bring them back. A large number of platforms won't have hypervisor timers, so this would otherwise add at least two lines worth of noise for non-error scenarios.
Fri, Mar 10, 4:26 PM
kevans committed rGcc0fe048ec39: kern: physmem: don't create a new exregion for different flags... (authored by kevans).
kern: physmem: don't create a new exregion for different flags...
Fri, Mar 10, 5:35 AM

Thu, Mar 9

kevans committed rGb61758494286: grep: remove tautological condition (authored by kevans).
grep: remove tautological condition
Thu, Mar 9, 5:55 AM
kevans added a reverting change for rGf6d6c6688900: grep: remove tautological condition: rGc816aea7abcf: Revert "grep: remove tautological condition".
Thu, Mar 9, 5:54 AM
kevans committed rGc816aea7abcf: Revert "grep: remove tautological condition" (authored by kevans).
Revert "grep: remove tautological condition"
Thu, Mar 9, 5:54 AM
kevans committed rGf6d6c6688900: grep: remove tautological condition (authored by kevans).
grep: remove tautological condition
Thu, Mar 9, 5:35 AM

Wed, Mar 8

kevans added inline comments to D38969: tftp: Add tests..
Wed, Mar 8, 1:14 AM

Tue, Mar 7

kevans committed rG1867702942b0: arm64: fix the LINT-ACPI build (authored by kevans).
arm64: fix the LINT-ACPI build
Tue, Mar 7, 5:42 PM
kevans added inline comments to D38911: arm: generic_timer: use interrupt-names when available.
Tue, Mar 7, 5:21 PM
kevans updated the diff for D38911: arm: generic_timer: use interrupt-names when available.

Split out acpi/fdt attach functions and allocate interrupts there

Tue, Mar 7, 5:18 PM
kevans committed rGd71a00e9f5db: arm64: ofw: respect the nonposted-mmio prop in OF_decode_addr() (authored by kevans).
arm64: ofw: respect the nonposted-mmio prop in OF_decode_addr()
Tue, Mar 7, 6:16 AM
kevans closed D38920: arm64: ofw: respect the nonposted-mmio prop in OF_decode_addr().
Tue, Mar 7, 6:16 AM

Mon, Mar 6

kevans requested review of D38920: arm64: ofw: respect the nonposted-mmio prop in OF_decode_addr().
Mon, Mar 6, 2:31 AM

Sun, Mar 5

kevans updated the diff for D30103: Add a simple-framebuffer vt driver.
  • Drop "all rights reserved", as per emaste 2021/01/05
  • Correct red offset
Sun, Mar 5, 4:53 AM
kevans added reviewers for D38911: arm: generic_timer: use interrupt-names when available: andrew, ARM, arm64.

Tested only on my M1 Mac for the moment.

Sun, Mar 5, 12:52 AM
kevans requested review of D38911: arm: generic_timer: use interrupt-names when available.
Sun, Mar 5, 12:51 AM

Fri, Mar 3

kevans added a comment to D30079: Map arm64 pci config memory as non-posted.

Does the M1 work if you have this patch, D34333, and the following change?

Fri, Mar 3, 11:36 PM
kevans accepted D30079: Map arm64 pci config memory as non-posted.

I had to do this kind of nasty feeling patch to get devices right on M1: https://people.freebsd.org/~kevans/m1/pci-mapping.diff -- I don't know if there's a better way to have done that, or if a custom bus_activate_resource that handles the mapping is really just the way to go.

Fri, Mar 3, 8:59 PM
kevans accepted D34333: Support non-posted MMIO on arm64 with FDT.
Fri, Mar 3, 8:56 PM
kevans abandoned D38895: arm64: use non-posted device memory if nonposted-mmio is set.

Abandon in favor of D34333

Fri, Mar 3, 8:55 PM
kevans committed rGd2ae03bae2ad: arm64: disable the physical timer for now if HCR_EL2.E2H is set (authored by kevans).
arm64: disable the physical timer for now if HCR_EL2.E2H is set
Fri, Mar 3, 5:03 PM
kevans closed D38884: arm64: disable the physical timer for now if HCR_EL2.E2H is set.
Fri, Mar 3, 5:03 PM
kevans requested review of D38895: arm64: use non-posted device memory if nonposted-mmio is set.
Fri, Mar 3, 5:01 PM
kevans requested review of D38884: arm64: disable the physical timer for now if HCR_EL2.E2H is set.
Fri, Mar 3, 7:28 AM
kevans committed rGf907027b49d9: daemon: set supervise_enabled during argument processing (authored by ihor_antonovs.family).
daemon: set supervise_enabled during argument processing
Fri, Mar 3, 5:18 AM
kevans committed rGe781739084e9: daemon: decouple restart variable (authored by ihor_antonovs.family).
daemon: decouple restart variable
Fri, Mar 3, 5:18 AM
kevans committed rGd6c398d882b6: daemon: add braces to while loop (authored by ihor_antonovs.family).
daemon: add braces to while loop
Fri, Mar 3, 5:18 AM