Page MenuHomeFreeBSD

kevans (Kyle Evans)
User

Projects

User Details

User Since
Oct 2 2015, 1:17 PM (223 w, 6 d)

Recent Activity

Today

kevans accepted D21481: Make a start at supporting login.conf environment settings.

I'd like to start moving forward on this... this looks like a fine idea to me. I'll look at starting to commit it over the next week, likely broken up into the various logical changes you've outlined.

Fri, Jan 17, 4:47 AM

Yesterday

kevans added a comment to D23197: sysent targets: further cleanup and deduplication.

Very nice cleanup.
One think I notice upon review is that in every case except sys/kern/Makefile we have the same set of 5 files with a different prefix. I'm not sure it's worth addressing that, but I guess you could do something like GENERATED?=${COMMON_GENERATED:S/^/${GENERATED_PREFIX}}

Thu, Jan 16, 10:39 PM
kevans accepted D23204: Use clang and lld as the default toolchain for MIPS..

Yeah, so I succesfully built all of the ports that we use in freebsd-wifi-build with in-tree llvm (+ your patch that just got committed here) on o32; I test-booted MALTA a while ago just fine (with no substantial changes to llvm that would break it in the meantime) and I built a new image for one of my o32 dev units to test on real hardware, but haven't imaged one with it yet.

Thu, Jan 16, 2:21 PM
kevans updated the diff for D23197: sysent targets: further cleanup and deduplication.

Whoops; missed an instance of setting SYSENT_CONF redundantly in compat/cloudabi*

Thu, Jan 16, 4:16 AM
kevans created D23197: sysent targets: further cleanup and deduplication.
Thu, Jan 16, 4:13 AM
kevans committed rS356775: MFC r356356, r356358, r356422: replace gcclibs' libssp.
MFC r356356, r356358, r356422: replace gcclibs' libssp
Thu, Jan 16, 3:38 AM
kevans committed rS356774: Record-only MFC of r353140, r356735.
Record-only MFC of r353140, r356735
Thu, Jan 16, 3:25 AM
kevans committed rS356773: MFC r356688, r356694: tap(4) manpage improvements.
MFC r356688, r356694: tap(4) manpage improvements
Thu, Jan 16, 3:16 AM
kevans committed rS356772: MFC r356649: regulator: small enhancements to regulator_shutdown.
MFC r356649: regulator: small enhancements to regulator_shutdown
Thu, Jan 16, 3:14 AM
kevans committed rS356771: MFC r356538: stand/fdt: Scale blob size better as overlays apply.
MFC r356538: stand/fdt: Scale blob size better as overlays apply
Thu, Jan 16, 3:11 AM

Wed, Jan 15

kevans added inline comments to D22493: Support for bcm2838 RNG.
Wed, Jan 15, 8:24 PM · arm64
kevans accepted D23191: hexdump test: take into account byte order.

Perfect, thanks! =-) May I ask which big-endian arch you're running these tests on? This is just my curiosity- the tests are indisputably broken as-is.

Wed, Jan 15, 4:10 PM · tests
kevans committed rS356761: mips trampoline: don't bother with unwind tables.
mips trampoline: don't bother with unwind tables
Wed, Jan 15, 3:59 PM
kevans added a comment to D23192: 2020-02-29 retire in-tree GPL dtc.

I intend to rm the sources at the same time but will probably do it as a separate commit. Do need to ensure we don't remove libfdt though.

Wed, Jan 15, 3:30 PM
kevans accepted D23192: 2020-02-29 retire in-tree GPL dtc.

powerpc* was the last reason to keep GPL dtc in-tree, IMO.

Wed, Jan 15, 2:57 PM
kevans accepted D23191: hexdump test: take into account byte order.

Seems like a good approach to me; the only nit I have to offer is that we oftentimes prefer spelling these "el" and "eb," but I suspect we have enough of a mix that it doesn't matter.

Wed, Jan 15, 2:36 PM · tests

Tue, Jan 14

kevans committed rS356735: Revert r353140: Re-add ALLOW_MIPS_SHARED_TEXTREL, sprinkle it around.
Revert r353140: Re-add ALLOW_MIPS_SHARED_TEXTREL, sprinkle it around
Tue, Jan 14, 5:50 PM
kevans added a comment to D23132: libzfs: add zfs_mount_at, switch libbe to it.

This was accepted into ZoL this morning: https://github.com/zfsonlinux/zfs/commit/68a192e4b762 -> merging this into the FreeBSD-merging-into-ZoL efforts should be fairly trivial

Tue, Jan 14, 5:13 PM
kevans added a reviewer for D23154: pipe log destination process limits for syslogd: cem.
Tue, Jan 14, 5:10 PM
kevans accepted D23168: [netgraph/ng_eiface] Generate MAC address from the FreeBSD OUI range..

This seems like a good idea. I'm not well-versed in netgraph, but the manpage here doesn't lead me thinking I'd need to consider setting a MAC address and I certainly don't typically have to for other interfaces- solid +1.

Tue, Jan 14, 12:13 PM

Mon, Jan 13

kevans committed rS356694: tap(4): also note that we drop configured addresses.
tap(4): also note that we drop configured addresses
Mon, Jan 13, 6:26 PM
kevans committed rS356692: MFC r356617: camdd: initialize devs earlier.
MFC r356617: camdd: initialize devs earlier
Mon, Jan 13, 6:23 PM
kevans committed rS356691: MFC r356614: tests: fusefs: silence remaining unsigned/signed warnings.
MFC r356614: tests: fusefs: silence remaining unsigned/signed warnings
Mon, Jan 13, 6:20 PM
kevans committed rS356690: MFC r356601-r356602: inetd fixes for WITHOUT_* knobs.
MFC r356601-r356602: inetd fixes for WITHOUT_* knobs
Mon, Jan 13, 6:18 PM
kevans committed rS356689: MFC r356600: a10_ahci: grab the target-supply regulator and enable it.
MFC r356600: a10_ahci: grab the target-supply regulator and enable it
Mon, Jan 13, 6:17 PM
kevans accepted D23152: Optimize diff -q..

Yup, LGTM

Mon, Jan 13, 5:25 PM
kevans committed rS356688: Install tap(4) manpage as vmnet(4) as well.
Install tap(4) manpage as vmnet(4) as well
Mon, Jan 13, 5:02 PM
kevans committed rP522896: rpi-firmware: update to latest rpi3-psci-monitor.
rpi-firmware: update to latest rpi3-psci-monitor
Mon, Jan 13, 4:53 PM
kevans committed rS356674: MFC r324815: Make elf_aux_info() as public libc function..
MFC r324815: Make elf_aux_info() as public libc function.
Mon, Jan 13, 3:36 AM

Sun, Jan 12

kevans added a comment to D23145: dwc(4) Ethernet MAC address setting/generating.
In D23145#507267, @manu wrote:
In D23145#507266, @bz wrote:

If it were to become a "generic" function, where would we put it?

No idea :)

Sun, Jan 12, 5:20 PM
kevans committed rS356650: Makefile.inc1: push /usr/libexec into the BPATH/TMPPATH.
Makefile.inc1: push /usr/libexec into the BPATH/TMPPATH
Sun, Jan 12, 4:18 AM
kevans closed D22464: Makefile.inc1: push /usr/libexec into the BPATH/TMPPATH .
Sun, Jan 12, 4:18 AM
kevans closed D22213: regulator: small enhancements to regulator_shutdown.
Sun, Jan 12, 4:07 AM
kevans committed rS356649: regulator: small enhancements to regulator_shutdown.
regulator: small enhancements to regulator_shutdown
Sun, Jan 12, 4:07 AM
kevans committed rS356648: MFC r356564: dwc_otg: fix fdt attachment for newer bcm2708-usb nodes.
MFC r356564: dwc_otg: fix fdt attachment for newer bcm2708-usb nodes
Sun, Jan 12, 4:05 AM
kevans committed rS356647: MFC r356562: bcm2835_vcbus: hide 'checking root' messages under bootverbose.
MFC r356562: bcm2835_vcbus: hide 'checking root' messages under bootverbose
Sun, Jan 12, 4:03 AM
kevans committed rS356646: MFC r356539: md(4): improve documentation of preloading.
MFC r356539: md(4): improve documentation of preloading
Sun, Jan 12, 4:01 AM
kevans added a comment to D23128: Fix the GOOGLETEST build with mips-gcc{6,9}.

I'm afraid I can't explain it -- I'm seeing similar results with amd64-gcc6 and amd64-gcc9:

Sun, Jan 12, 3:03 AM

Sat, Jan 11

kevans added a comment to D23128: Fix the GOOGLETEST build with mips-gcc{6,9}.
Thread model: posix
gcc version 6.5.0 (FreeBSD Ports Collection for mips) 
COMPILER_PATH=/usr/local/mips-unknown-freebsd13.0/bin/:/usr/local/libexec/gcc/mips-unknown-freebsd13.0/6.5.0/:/usr/local/libexec/gcc/mips-unknown-freebsd13.0/6.5.0/:/usr/local/libexec/gcc/mips-unknown-freebsd13.0/:/usr/local/lib/gcc/mips-unknown-freebsd13.0/6.5.0/:/usr/local/lib/gcc/mips-unknown-freebsd13.0/:/usr/local/lib/gcc/mips-unknown-freebsd13.0/6.5.0/../../../../mips-unknown-freebsd13.0/bin/
LIBRARY_PATH=/usr/local/mips-unknown-freebsd13.0/bin/:/usr/local/lib/gcc/mips-unknown-freebsd13.0/6.5.0/:/usr/obj/usr/src/mips.mips/tmp/usr/lib/
COLLECT_GCC_OPTIONS='-B' '/usr/local/mips-unknown-freebsd13.0/bin/' '-EB' '-mabi=32' '-shared' '-o' 'libprivategtest.so.0.full' '-shared-libgcc' '-mips3'
 /usr/local/libexec/gcc/mips-unknown-freebsd13.0/6.5.0/collect2 -plugin /usr/local/libexec/gcc/mips-unknown-freebsd13.0/6.5.0/liblto_plugin.so "-plugin-opt=/usr/local/libexec/gcc/mips-unknown-freebsd13.0/6.5.0/lto-wrapper" "-plugin-opt=-fresolution=/tmp//ccErDyqz.res" "-plugin-opt=-pass-through=-lgcc_s" "-plugin-opt=-pass-through=-lc" "-plugin-opt=-pass-through=-lgcc_s" "--sysroot=/usr/obj/usr/src/mips.mips/tmp" --eh-frame-hdr -EB -EB -mips3 -melf32btsmip_fbsd -Bshareable --enable-new-dtags -o libprivategtest.so.0.full /usr/obj/usr/src/mips.mips/tmp/usr/lib/crti.o /usr/obj/usr/src/mips.mips/tmp/usr/lib/crtbeginS.o -L/usr/local/mips-unknown-freebsd13.0/bin -L/usr/local/lib/gcc/mips-unknown-freebsd13.0/6.5.0 -L/usr/obj/usr/src/mips.mips/tmp/usr/lib -x --fatal-warnings --warn-shared-textrel -z notext -soname libprivategtest.so.0 gtest-all.pico -lpthread "-lc++" -lm -lgcc_s -lc -lgcc_s /usr/obj/usr/src/mips.mips/tmp/usr/lib/crtendS.o /usr/obj/usr/src/mips.mips/tmp/usr/lib/crtn.o
COLLECT_GCC_OPTIONS='-B' '/usr/local/mips-unknown-freebsd13.0/bin/' '-EB' '-mabi=32' '-shared' '-o' 'libprivategtest.so.0.full' '-shared-libgcc' '-mips3'
Sat, Jan 11, 8:12 PM
kevans added a comment to D23128: Fix the GOOGLETEST build with mips-gcc{6,9}.
In D23128#507084, @kib wrote:

I should have been more precise, 'does libcompiler_rt.a ...'. The visibility of the symbol is not important for resolution from a static library during link. It is enough that the symbol is provided and it is not local.

Sat, Jan 11, 7:02 PM
kevans added a comment to D23128: Fix the GOOGLETEST build with mips-gcc{6,9}.
In D23128#507040, @kib wrote:
# readelf -a libprivategtest.so | grep 'floatunsidf'
   540: 00000000000587a0     0 FUNC    GLOBAL DEFAULT  UND __floatunsidf
   394: 00000000000587a0     0 FUNC    GLOBAL DEFAULT  UND __floatunsidf

So two questions:

  1. does libcompiler_rt on mips provide the symbol ?
Sat, Jan 11, 5:30 PM
kevans committed rS356635: Fix warning after r356634.
Fix warning after r356634
Sat, Jan 11, 4:28 PM
kevans added a comment to D23128: Fix the GOOGLETEST build with mips-gcc{6,9}.
In D23128#507007, @kib wrote:

libcompiler_rt provides symbols needed by a (the ?) compiler-generated code. As such they are not part of the ABI contract for the FreeBSD platforms and must not be exported neither from libraries nor from binaries, which can be compiled with different compilers, requiring different support routines.
This is the reason why the replacement for libgcc.a must not export them, and the symbols must not be reexported after linking. For the same reasons symbols must not be exported from libgcc.so, the only ABI part of libgcc.so are unwinder and corresponding support.

Sat, Jan 11, 3:25 PM
kevans committed rS356634: MFC r356359-r356360: kern_mmap: add fpcheck invariant for linux_mmap.
MFC r356359-r356360: kern_mmap: add fpcheck invariant for linux_mmap
Sat, Jan 11, 3:06 PM
kevans updated the diff for D23132: libzfs: add zfs_mount_at, switch libbe to it.

Remove spurious blank line

Sat, Jan 11, 4:19 AM
kevans created D23132: libzfs: add zfs_mount_at, switch libbe to it.
Sat, Jan 11, 4:17 AM
kevans committed rS356626: MFC r356355: ssp: knock out some trivial warnings that come up with WARNS=6.
MFC r356355: ssp: knock out some trivial warnings that come up with WARNS=6
Sat, Jan 11, 3:15 AM
kevans added a reviewer for D23128: Fix the GOOGLETEST build with mips-gcc{6,9}: kib.

Adding kib, too, for discussion.

Sat, Jan 11, 1:47 AM

Fri, Jan 10

kevans updated the diff for D23128: Fix the GOOGLETEST build with mips-gcc{6,9}.

Unhide floatunsidf in the build gloop, instead. I can narrow the scope to just mips, if desired, but it's not clear to me why the builtins are hidden in the first place.

Fri, Jan 10, 10:28 PM
kevans committed rS356617: camdd: initialize devs earlier.
camdd: initialize devs earlier
Fri, Jan 10, 10:20 PM
kevans closed D23127: tests: fusefs: silence remaining unsigned/signed comparison warnings.
Fri, Jan 10, 9:51 PM
kevans committed rS356614: tests: fusefs: silence remaining unsigned/signed comparison warnings.
tests: fusefs: silence remaining unsigned/signed comparison warnings
Fri, Jan 10, 9:51 PM
kevans created D23128: Fix the GOOGLETEST build with mips-gcc{6,9}.
Fri, Jan 10, 9:25 PM
kevans updated the diff for D23127: tests: fusefs: silence remaining unsigned/signed comparison warnings.

Whoops, fix types.

Fri, Jan 10, 9:23 PM
kevans created D23127: tests: fusefs: silence remaining unsigned/signed comparison warnings.
Fri, Jan 10, 9:13 PM
kevans closed D23099: Set .ORDER for makesyscalls generated files.
Fri, Jan 10, 6:24 PM
kevans committed rS356604: Set .ORDER for makesyscalls generated files.
Set .ORDER for makesyscalls generated files
Fri, Jan 10, 6:24 PM
kevans closed D23098: makesyscalls.lua: generate all files in /tmp, write into place at the end.
Fri, Jan 10, 6:22 PM
kevans committed rS356603: makesyscalls.lua: generate all files in /tmp, write into place at the end.
makesyscalls.lua: generate all files in /tmp, write into place at the end
Fri, Jan 10, 6:22 PM
kevans committed rS356602: inetd: two more nits.
inetd: two more nits
Fri, Jan 10, 2:44 PM
kevans committed rS356601: inetd: free WITHOUT_INET6_SUPPORT build of warnings.
inetd: free WITHOUT_INET6_SUPPORT build of warnings
Fri, Jan 10, 2:40 PM
kevans committed rS356600: a10_ahci: grab the target-supply regulator and enable it.
a10_ahci: grab the target-supply regulator and enable it
Fri, Jan 10, 2:10 PM
kevans closed D23112: a10_ahci: grab the target-supply regulator and enable it.
Fri, Jan 10, 2:10 PM
kevans committed rS356594: MFC r356327-r356328: mips: csu: fix compilation w/ LLVM.
MFC r356327-r356328: mips: csu: fix compilation w/ LLVM
Fri, Jan 10, 3:47 AM
kevans committed rS356593: MFC r356279: libbe(3): promote dependent clones when destroying a BE.
MFC r356279: libbe(3): promote dependent clones when destroying a BE
Fri, Jan 10, 3:38 AM

Thu, Jan 9

kevans added a comment to D23112: a10_ahci: grab the target-supply regulator and enable it.

I've since realized that the cubieboard1 does in-fact have SATA, I just don't have it broken out. Test-booted, and now I get:

Thu, Jan 9, 8:52 PM
kevans created D23112: a10_ahci: grab the target-supply regulator and enable it.
Thu, Jan 9, 8:39 PM
kevans added a comment to D22213: regulator: small enhancements to regulator_shutdown.

This might need to grow a small DELAY after the "shutting down %s..." bootverbose message (if bootverbose) in case the regulator gets shutdown before we can actually print the message, but I'm still testing it to figure out why it's flakey.

Thu, Jan 9, 8:10 PM
kevans updated the diff for D22213: regulator: small enhancements to regulator_shutdown.

Update to give and put the initial notice under bootverbose... I still don't like that we're potentially (and did, in the case that spawned this patch) shutting down regulators that make the system look like it just spontaneously lost power without emitting a notice, but I'd much prefer to get this patch in because the current situation makes it hard to debug.

Thu, Jan 9, 8:02 PM
kevans committed rS356564: dwc_otg: fix fdt attachment for newer bcm2708-usb nodes.
dwc_otg: fix fdt attachment for newer bcm2708-usb nodes
Thu, Jan 9, 7:22 PM
kevans added a comment to D22963: Expand generic subword atomic primitives.

Ahh, sorry, I see what you're pointing out now.

Thu, Jan 9, 7:19 PM
kevans committed rS356562: bcm2835_vcbus: hide 'checking root' messages under bootverbose.
bcm2835_vcbus: hide 'checking root' messages under bootverbose
Thu, Jan 9, 7:13 PM
kevans added inline comments to D23099: Set .ORDER for makesyscalls generated files.
Thu, Jan 9, 4:09 PM
kevans updated the diff for D23099: Set .ORDER for makesyscalls generated files.

Update to use .ORDER, hopefully articulate the problem a little better both in commit message and actually add a comment lightly mentioning the problem we're addressing.

Thu, Jan 9, 3:56 PM
kevans added inline comments to D22963: Expand generic subword atomic primitives.
Thu, Jan 9, 12:44 PM
kevans committed rS356540: kern/Makefile: systrace_args.c is also generated.
kern/Makefile: systrace_args.c is also generated
Thu, Jan 9, 6:10 AM
kevans added a comment to D23099: Set .ORDER for makesyscalls generated files.

After discussing with sjg, I'm going to update these to .ORDER: ${GENERATED} and add inline comments describing why we care.

Thu, Jan 9, 5:36 AM
kevans committed rS356539: md(4): improve documentation of preloading.
md(4): improve documentation of preloading
Thu, Jan 9, 4:39 AM
kevans closed D22844: md(4): improve documentation of preloading.
Thu, Jan 9, 4:39 AM
kevans committed rS356538: stand/fdt: Scale blob size better as overlays apply.
stand/fdt: Scale blob size better as overlays apply
Thu, Jan 9, 4:34 AM
kevans closed D14133: stand/fdt: Scale blob size better as overlays apply.
Thu, Jan 9, 4:34 AM
kevans committed rS356537: shmfd: posix_fallocate(2): only take rangelock for section we need.
shmfd: posix_fallocate(2): only take rangelock for section we need
Thu, Jan 9, 4:03 AM
kevans committed rS356536: if_vmove: return proper error status.
if_vmove: return proper error status
Thu, Jan 9, 3:53 AM
kevans closed D22780: if_vmove: return proper error status.
Thu, Jan 9, 3:53 AM
kevans added a reviewer for D23099: Set .ORDER for makesyscalls generated files: sjg.
Thu, Jan 9, 3:32 AM
kevans created D23099: Set .ORDER for makesyscalls generated files.
Thu, Jan 9, 3:27 AM
kevans created D23098: makesyscalls.lua: generate all files in /tmp, write into place at the end.
Thu, Jan 9, 3:08 AM

Wed, Jan 8

kevans committed rS356512: posixshm: implement posix_fallocate(2).
posixshm: implement posix_fallocate(2)
Wed, Jan 8, 7:09 PM
kevans committed rS356511: Bump __FreeBSD_version after r356510.
Bump __FreeBSD_version after r356510
Wed, Jan 8, 7:06 PM
kevans committed rS356510: posix_fallocate: push vnop implementation into the fileop layer.
posix_fallocate: push vnop implementation into the fileop layer
Wed, Jan 8, 7:05 PM
kevans closed D23042: posix_fallocate: push vnop implementation into the fileops layer.
Wed, Jan 8, 7:05 PM
kevans added a comment to D23042: posix_fallocate: push vnop implementation into the fileops layer.

I have one more local change to this that allows shm_dotruncate to borrow a rangelock from the caller to use, then shm_fallocate takes a write lock on it before checking the size, but the changes are fairly non-invasive so I suspect I will not rev this review one more time unless requested.

Wed, Jan 8, 3:22 PM

Tue, Jan 7

kevans committed rS356463: Remove gcclibs libssp build glue.
Remove gcclibs libssp build glue
Tue, Jan 7, 7:49 PM

Mon, Jan 6

kevans committed rS356423: Refine fusefs test workaround for mips+llvm.
Refine fusefs test workaround for mips+llvm
Mon, Jan 6, 6:26 PM
kevans committed rS356422: Update libssp paths in various Makefile.depend* files.
Update libssp paths in various Makefile.depend* files
Mon, Jan 6, 6:16 PM
kevans added inline comments to D23042: posix_fallocate: push vnop implementation into the fileops layer.
Mon, Jan 6, 12:27 AM

Sun, Jan 5

kevans committed rS356388: MFC further inetd(8) cleanup: r356204, r356215, r356217-r356218,.
MFC further inetd(8) cleanup: r356204, r356215, r356217-r356218,
Sun, Jan 5, 9:35 PM
kevans committed rS356387: MFC r310921, r311354, r315644: Light inetd(8) cleanup.
MFC r310921, r311354, r315644: Light inetd(8) cleanup
Sun, Jan 5, 9:32 PM
kevans accepted D23013: Simplify arguments to signal handlers on mips..
Sun, Jan 5, 8:36 PM
kevans updated the diff for D23042: posix_fallocate: push vnop implementation into the fileops layer.

Move {sys,kern}_posix_fallocate into sys_generic.c -- there's no longer anything vfs specific to it, as those have been split off into vfs_vnops.

Sun, Jan 5, 8:31 PM