Page MenuHomeFreeBSD

kevans (Kyle Evans)
User

Projects

User Details

User Since
Oct 2 2015, 1:17 PM (260 w, 19 h)

Recent Activity

Today

kevans added a comment to D26558: bsd.port.mk: make sure REINPLACE_ARGS is factored into REINPLACE_CMD.

Does -i... need to be stripped from REINPLACE_ARGS? Like ${REINPLACE_ARGS:N-i*} or something?

Sat, Sep 26, 1:11 AM

Yesterday

kevans accepted D26562: Move kernel env global variables, etc to sys/kenv.h.
Fri, Sep 25, 10:29 PM
kevans accepted D26534: Misc compiler warning fixes in lib/libc.
Fri, Sep 25, 7:11 PM
kevans requested review of D26558: bsd.port.mk: make sure REINPLACE_ARGS is factored into REINPLACE_CMD.
Fri, Sep 25, 5:05 PM
kevans committed rS366135: dtc: fix the -fno-common build.
dtc: fix the -fno-common build
Fri, Sep 25, 1:16 AM

Thu, Sep 24

kevans committed rS366125: MFS r365987: certctl rehash upon install/distribute.
MFS r365987: certctl rehash upon install/distribute
Thu, Sep 24, 6:36 PM
kevans committed rS366124: Unrevert r364793: revert r364792: caroot: switch to using echo+shell glob.
Unrevert r364793: revert r364792: caroot: switch to using echo+shell glob
Thu, Sep 24, 6:22 PM
kevans added inline comments to D26540: Eliminate building LINT makefiles.
Thu, Sep 24, 1:28 PM

Wed, Sep 23

kevans accepted D26540: Eliminate building LINT makefiles.

Yup, this matches what I envisioned when you pitched it! =)

Wed, Sep 23, 11:08 PM
kevans accepted D26530: Make makesyscalls.lua initialize 'struct sysent' entries using c99 designated identifiers.

Sure, that's reasonable- while we don't expect people to look at the output, it is good for it to look at least somewhat clean in case we need to sanity check it.

Wed, Sep 23, 9:32 PM
kevans committed rS366093: tests: move the memfd tests over to sys/posixshm.
tests: move the memfd tests over to sys/posixshm
Wed, Sep 23, 7:55 PM
kevans abandoned D25780: Use NULL for zfs_send_one in be_export.
Wed, Sep 23, 6:43 PM
kevans commandeered D25780: Use NULL for zfs_send_one in be_export.
Wed, Sep 23, 6:43 PM
kevans committed rS366084: MFS r365986: caroot: update base store.
MFS r365986: caroot: update base store
Wed, Sep 23, 5:42 PM
kevans added inline comments to D26530: Make makesyscalls.lua initialize 'struct sysent' entries using c99 designated identifiers.
Wed, Sep 23, 5:03 PM
kevans added a reviewer for D26530: Make makesyscalls.lua initialize 'struct sysent' entries using c99 designated identifiers: brooks.

Tagging Brooks in as well for Cheri perspective

Wed, Sep 23, 2:02 PM
kevans committed rS366060: cp: tests: fix weird 20 insertion.
cp: tests: fix weird 20 insertion
Wed, Sep 23, 3:03 AM
kevans committed rS366059: cp: add some basic tests.
cp: add some basic tests
Wed, Sep 23, 3:01 AM

Tue, Sep 22

kevans added inline comments to D26517: Refactor pkg bootstrap to fetch compression types.
Tue, Sep 22, 5:03 PM
kevans committed rS365990: Record-only MFC of r365018.
Record-only MFC of r365018
Tue, Sep 22, 2:22 AM
kevans committed rS365989: Record-only MFC of r361257.
Record-only MFC of r361257
Tue, Sep 22, 2:20 AM
kevans committed rS365988: MFC r365829, r365837: certctl rehash upon install/distribute.
MFC r365829, r365837: certctl rehash upon install/distribute
Tue, Sep 22, 2:15 AM
kevans committed rS365987: MFC r365829, r365837, r365852: certctl rehash upon install/distribute.
MFC r365829, r365837, r365852: certctl rehash upon install/distribute
Tue, Sep 22, 2:15 AM
kevans committed rS365986: MFC r365896: caroot: update base store.
MFC r365896: caroot: update base store
Tue, Sep 22, 1:58 AM

Mon, Sep 21

kevans committed rS365972: bsdbox: fix build after recent libifconfig changes.
bsdbox: fix build after recent libifconfig changes
Mon, Sep 21, 7:50 PM
kevans accepted D26516: fsx: fix build with WARNS=6.
Mon, Sep 21, 5:46 PM
kevans committed rS365954: xargs: add some long options for GNU compatibility.
xargs: add some long options for GNU compatibility
Mon, Sep 21, 5:07 PM
kevans committed rS365953: base: add a *.pem hint to svn:auto-props.
base: add a *.pem hint to svn:auto-props
Mon, Sep 21, 4:59 PM
kevans accepted D26504: fix compiler warnings-as-errors on gcc6 in rcorder/crunchgen.
Mon, Sep 21, 1:07 PM

Sat, Sep 19

kevans accepted D26479: Fix -Wpointer-sign warnings in usr.bin/grep.

Why do we currently -Wno-pointer-sign? Too many false positives?

Sat, Sep 19, 2:15 PM
kevans accepted D26481: Prefer bootstrapped tools when running certctl.sh.
Sat, Sep 19, 2:14 PM
kevans committed rS365897: MFS r365891: certctl: fix unprivileged mode.
MFS r365891: certctl: fix unprivileged mode
Sat, Sep 19, 2:12 AM
kevans committed rS365896: caroot: update base store.
caroot: update base store
Sat, Sep 19, 1:59 AM

Fri, Sep 18

kevans committed rS365891: MFC r365756: certctl: fix unprivileged mode.
MFC r365756: certctl: fix unprivileged mode
Fri, Sep 18, 10:25 PM
kevans closed D26397: build: provide a default WARNS for src builds.
Fri, Sep 18, 5:20 PM
kevans accepted D26397: build: provide a default WARNS for src builds.
Fri, Sep 18, 5:20 PM
kevans committed rS365887: build: provide a default WARNS for all in-tree builds.
build: provide a default WARNS for all in-tree builds
Fri, Sep 18, 5:18 PM
kevans closed D26455: Bootstrap crunchgen for builds from older trees.
Fri, Sep 18, 5:18 PM
kevans committed rS365883: pkgbase: use consistent annotation for objectk eys.
pkgbase: use consistent annotation for objectk eys
Fri, Sep 18, 2:29 PM

Thu, Sep 17

kevans committed rS365852: Revert r361257: bsdinstall: do a `certctl rehash` upon installation [...].
Revert r361257: bsdinstall: do a `certctl rehash` upon installation [...]
Thu, Sep 17, 8:36 PM
kevans closed D22189: New ports devel/g-wrap, graphics/guile-cairo, x11-toolkits/guile-gnome-platform: enables the use of the Gnome GUI from Guile scripts.
Thu, Sep 17, 5:47 PM
kevans committed rP548847: [NEW] x11-toolkits/guile-gnome-platform: Guile bindings for Gnome.
[NEW] x11-toolkits/guile-gnome-platform: Guile bindings for Gnome
Thu, Sep 17, 5:47 PM
kevans committed rS365837: Promote the installworld `certctl rehash` to distributeworld.
Promote the installworld `certctl rehash` to distributeworld
Thu, Sep 17, 3:59 PM
kevans committed rS365829: installworld: run `certctl rehash` after installation completes.
installworld: run `certctl rehash` after installation completes
Thu, Sep 17, 2:18 AM

Wed, Sep 16

kevans added inline comments to D26455: Bootstrap crunchgen for builds from older trees.
Wed, Sep 16, 11:34 PM
kevans committed rS365821: MFC r365631: Only set WARNS if not defined.
MFC r365631: Only set WARNS if not defined
Wed, Sep 16, 11:17 PM
kevans committed rS365820: MFC r365493-r365494, r365600, r365602, r365637: various WARNS fixes.
MFC r365493-r365494, r365600, r365602, r365637: various WARNS fixes
Wed, Sep 16, 11:14 PM
kevans committed rS365817: Record merge of r364190.
Record merge of r364190
Wed, Sep 16, 10:38 PM
kevans committed rS365816: MFC outstanding crunchgen work: r350152, r364166, r364174, r364234,.
MFC outstanding crunchgen work: r350152, r364166, r364174, r364234,
Wed, Sep 16, 10:36 PM
kevans updated the summary of D26397: build: provide a default WARNS for src builds.
Wed, Sep 16, 5:15 PM
kevans updated the diff for D26397: build: provide a default WARNS for src builds.

Rebase

Wed, Sep 16, 5:15 PM
kevans requested review of D26455: Bootstrap crunchgen for builds from older trees.
Wed, Sep 16, 5:15 PM

Tue, Sep 15

kevans committed rS365756: certctl: fix unprivileged mode.
certctl: fix unprivileged mode
Tue, Sep 15, 5:13 PM
kevans added a comment to D22189: New ports devel/g-wrap, graphics/guile-cairo, x11-toolkits/guile-gnome-platform: enables the use of the Gnome GUI from Guile scripts.

I've added the following post-patch target locally to address the build breakage on -CURRENT that I mentioned, let me know if you'd prefer to do it otherwise -- I think sed'ing it is OK if it's not worth upstreaming the expression change. I've test-built on -CURRENT/amd64 and 12.1/i386, with 11.3/amd64 in progress:

Tue, Sep 15, 3:50 PM

Mon, Sep 14

kevans committed rP548669: emulator/qemu-user-static: fix major regression from signal refactor.
emulator/qemu-user-static: fix major regression from signal refactor
Mon, Sep 14, 6:40 PM
kevans committed rS365705: __FreeBSD_version bump for r365605 (crunchgen producing WARNS-clean).
__FreeBSD_version bump for r365605 (crunchgen producing WARNS-clean)
Mon, Sep 14, 1:56 AM
kevans added inline comments to D26397: build: provide a default WARNS for src builds.
Mon, Sep 14, 1:33 AM
kevans added a comment to D26397: build: provide a default WARNS for src builds.

I think I'm going to go ahead and commit this in the coming days -- FWIW, I hacked together a reallllly primitive interface for browsing warnings by crude 'path' (based solely on output, so not perfect) : https://warns.kevans.dev/ -- this should work in the interim until we can get something in CI proper. I'll hack together some pretty graphs from it when it gets a couple more builds under its belt.

Mon, Sep 14, 1:17 AM

Sun, Sep 13

kevans committed rS365684: MFS r365682: getlogin_r: fix the type of len.
MFS r365682: getlogin_r: fix the type of len
Sun, Sep 13, 2:18 AM
kevans committed rS365683: MFS r365681: certctl: fix hashed link generation with duplicate subjects.
MFS r365681: certctl: fix hashed link generation with duplicate subjects
Sun, Sep 13, 2:17 AM
kevans committed rS365682: MFC r365506 getlogin_r: fix the type of len.
MFC r365506 getlogin_r: fix the type of len
Sun, Sep 13, 1:44 AM
kevans committed rS365681: MFC r365500: certctl: fix hashed link generation with duplicate subjects.
MFC r365500: certctl: fix hashed link generation with duplicate subjects
Sun, Sep 13, 1:09 AM
kevans committed rS365680: MFC r361397, r361655, r361683: certctl(8) unprivileged & HISTORY correction.
MFC r361397, r361655, r361683: certctl(8) unprivileged & HISTORY correction
Sun, Sep 13, 1:08 AM

Sat, Sep 12

kevans committed rS365651: Regen src.conf(5) after r365649.
Regen src.conf(5) after r365649
Sat, Sep 12, 1:55 AM
kevans committed rS365650: Add missing WITHOUT_CAROOT description.
Add missing WITHOUT_CAROOT description
Sat, Sep 12, 1:55 AM
kevans committed rS365649: MFC r365490-r365491: Remove FREEBSD_UPDATE dependency on PORTSNAP.
MFC r365490-r365491: Remove FREEBSD_UPDATE dependency on PORTSNAP
Sat, Sep 12, 1:48 AM

Fri, Sep 11

kevans added a comment to D26270: Add getenv_is_true() and getenv_is_false().

This seems reasonable, though getenv_bool is defined static but declared/used as if it were not. :-)

Fri, Sep 11, 6:11 PM
kevans committed rS365637: MFV r365636: libarchive: import fix for WARNS=6 builds in testing bits.
MFV r365636: libarchive: import fix for WARNS=6 builds in testing bits
Fri, Sep 11, 4:13 PM
kevans committed rS365636: libarchive: import fix for WARNS=6 builds in testing bits.
libarchive: import fix for WARNS=6 builds in testing bits
Fri, Sep 11, 4:13 PM
kevans updated subscribers of D26397: build: provide a default WARNS for src builds.
In D26397#587148, @phk wrote:

Maybe, as inspiration, we should make a web-service which made the warnings at current and higher levels for the non-6 directories available, along with a X/T plot of how many there are ?

What an excellent idea- I do believe it'd be trivial to strip -Werror and force WARNS to 6 for an entire build. I'll hack something together for this.

Jenkins has a nice graph view for compiler warnings with the warnings next plugin. Maybe we could add another job without Werror and max warnings and run that like once a week?

Fri, Sep 11, 2:57 PM
kevans committed rS365631: Only set WARNS if not defined.
Only set WARNS if not defined
Fri, Sep 11, 1:29 PM
kevans added a comment to D26397: build: provide a default WARNS for src builds.
In D26397#587148, @phk wrote:

Maybe, as inspiration, we should make a web-service which made the warnings at current and higher levels for the non-6 directories available, along with a X/T plot of how many there are ?

Fri, Sep 11, 12:41 PM
kevans committed rS365624: memfd_create: simplify HUGETLB support a little bit.
memfd_create: simplify HUGETLB support a little bit
Fri, Sep 11, 2:02 AM

Thu, Sep 10

kevans committed rS365615: memfd_create: fix return values.
memfd_create: fix return values
Thu, Sep 10, 9:25 PM
kevans added a comment to D26397: build: provide a default WARNS for src builds.

Seems sensible. I guess it's good that most of the issues are in tests or GPL code we're deleting soon?

Thu, Sep 10, 7:17 PM
kevans added a reviewer for D26397: build: provide a default WARNS for src builds: brooks.
Thu, Sep 10, 6:53 PM
kevans requested review of D26397: build: provide a default WARNS for src builds.
Thu, Sep 10, 6:49 PM
kevans committed rS365605: crunchgen(8): fix crunched application build with WARNS=6.
crunchgen(8): fix crunched application build with WARNS=6
Thu, Sep 10, 6:20 PM
kevans closed D26363: crunchgen(8): fix crunched application build with WARNS=6.
Thu, Sep 10, 6:20 PM
kevans committed rS365603: Fix the build after r365592.
Fix the build after r365592
Thu, Sep 10, 5:58 PM
kevans committed rS365602: librt: tests: fix minor issues with higher WARNS.
librt: tests: fix minor issues with higher WARNS
Thu, Sep 10, 5:53 PM
kevans accepted D26394: Fix interaction between largepages and seals/writes..
Thu, Sep 10, 5:49 PM
kevans committed rS365600: MFV r365599: import fix for a libexecinfo warning at higher WARNS.
MFV r365599: import fix for a libexecinfo warning at higher WARNS
Thu, Sep 10, 5:48 PM
kevans committed rS365599: netbsd-tests: import fix for a libexecinfo warning at higher WARNS.
netbsd-tests: import fix for a libexecinfo warning at higher WARNS
Thu, Sep 10, 5:46 PM
kevans committed rS365593: Fix memfd_create tests after r365524.
Fix memfd_create tests after r365524
Thu, Sep 10, 5:23 PM

Wed, Sep 9

kevans closed D26335: getlogin_r: fix the type of len.
Wed, Sep 9, 6:07 PM
kevans committed rS365506: getlogin_r: fix the type of len.
getlogin_r: fix the type of len
Wed, Sep 9, 6:07 PM
kevans accepted D26325: devel/py-libzfs: Take over as maintainer, bump for OpenZFS in base.

I took a "trust, but verify" stance and confirmed that it built on 12i386 and 11amd64. :-)

Wed, Sep 9, 3:41 PM
kevans added a comment to D26363: crunchgen(8): fix crunched application build with WARNS=6.

LGTM. I probably wouldn't bother with the typedef and just add the parameters but don't mind either way.

Wed, Sep 9, 11:39 AM
kevans committed rS365500: certctl: fix hashed link generation with duplicate subjects.
certctl: fix hashed link generation with duplicate subjects
Wed, Sep 9, 9:08 AM
kevans closed D26167: certctl: fix hashed link generation with duplicate subjects.
Wed, Sep 9, 9:08 AM
kevans added a comment to D26167: certctl: fix hashed link generation with duplicate subjects.

Would you prefer to receive attribution for this review at your phab email address (@gmx) or bugzilla (@siemens)?

Wed, Sep 9, 8:07 AM
kevans committed rS365494: libc tests: dynthr_mod: fix some WARNS issues.
libc tests: dynthr_mod: fix some WARNS issues
Wed, Sep 9, 2:46 AM
kevans closed D24844: libc/resolv: attempt to fix the test under WARNS=6.
Wed, Sep 9, 2:42 AM
kevans committed rS365493: libc/resolv: attempt to fix the test under WARNS=6.
libc/resolv: attempt to fix the test under WARNS=6
Wed, Sep 9, 2:42 AM
kevans committed rS365492: src.conf(5): regen after r365491.
src.conf(5): regen after r365491
Wed, Sep 9, 12:41 AM
kevans committed rS365491: opts: FREEBSD_UPDATE no longer relies on PORTSNAP.
opts: FREEBSD_UPDATE no longer relies on PORTSNAP
Wed, Sep 9, 12:41 AM
kevans committed rS365490: phttpget: move out of portsnap.
phttpget: move out of portsnap
Wed, Sep 9, 12:39 AM
kevans closed D26255: phttpget: move out of portsnap.
Wed, Sep 9, 12:39 AM

Tue, Sep 8

kevans updated the diff for D26167: certctl: fix hashed link generation with duplicate subjects.

Rework, drop *.[0-9] from FILEPAT and use hopefully less-fragile fingerprint comparison. This fixes the previously reported issue:

Tue, Sep 8, 9:56 PM