User Details
- User Since
- Oct 2 2015, 1:17 PM (441 w, 3 d)
Yesterday
Oh, return () style differs here
Fri, Mar 15
Tue, Mar 12
Nice, thanks. I think at one point I thought I might have something else worth adding to struct tuntap_driver_cloner, but if it hasn't happened in the intervening 5 years then I think it's safe to say that it's not going to happen.
Mon, Mar 11
Sat, Mar 9
Thu, Mar 7
ah, I see; some of these were read from a header, some of them left un-exported in the first place... someone seemingly applied a relatively large hammer.
Tue, Mar 5
Revert back to the size check, assert that we do or do not have a resource
after as appropriate.
Oh, that probably won't work... we probably printed the entire left-hand side before the return, so it'd need to be on a separate line or something
Mon, Mar 4
Sun, Mar 3
Use a loop, set error before (it'll either get clobbered or remain untouched),
and just consistently keep it locked leaving the loop.
(Sorry, I just realized I forgot about this review entirely)
Second, the setting is inherited by children of the spawn process. Is it fine? For me yes.
Sat, Mar 2
Fri, Mar 1
Thu, Feb 29
Wed, Feb 28
I'd recommend doing a linting pass with devel/lua-luacheck- usually the concerns it points out aren't too crazy.
Mon, Feb 26
Sun, Feb 25
Sat, Feb 24
s/matater/matter/ in commit msg
The lsan tests reliably trigger the deadlock described above LockStuffAndStopTheWorld, so I can't really get any valid results from that one.
Fri, Feb 23
lldb multiple scripting interfaces, most notably in python and lua
My hope was to get a sanity check on StopTheWorld, at least, beforehand since that's a FreeBSD implementation detail and it seems easier to collect reviews for that specifically here.
Oh, and I note that I've only tested this on amd64 and arm64 to make sure that both the rfork_thread and rfork paths work. LSan is incredibly useful when used in an ASan + libFuzzer combination.
Thu, Feb 22
Ah, yeah, that'd definitely do it...
Feb 17 2024
Stash the rid off in the pcie_range, use that everywhere after allocation both
for bus_*_resource() APIs bus also to decide if we're skipping an element to
deallocate.
Feb 15 2024
Add a macro, fixup other places, commentary
Feb 14 2024
Feb 13 2024
Relevant test in https://reviews.freebsd.org/D43859
Feb 12 2024
No comment on the veriexec bits (they seem generally sane, but that's your area of course :-)), but the motivation described here: