Page MenuHomeFreeBSD

kevans (Kyle Evans)
User

Projects

User Details

User Since
Oct 2 2015, 1:17 PM (194 w, 5 d)

Recent Activity

Today

kevans updated the summary of D20773: stand: shuffle dv_open/dv_init bits around.

Address review comments:

  • Delete stale comment
  • Push dev == null check into dv_open wrapper
Wed, Jun 26, 7:55 PM
kevans created D20773: stand: shuffle dv_open/dv_init bits around.
Wed, Jun 26, 6:09 PM

Yesterday

kevans committed rS349383: libbe(3): restructure be_mount, skip canmount check for BE dataset.
libbe(3): restructure be_mount, skip canmount check for BE dataset
Tue, Jun 25, 6:48 PM
kevans committed rS349380: libbe(3): mount: the BE dataset is mounted at /.
libbe(3): mount: the BE dataset is mounted at /
Tue, Jun 25, 6:13 PM

Thu, Jun 13

kevans accepted D20626: bhyve: move common code to net_utils.c.

I am pulling Kyle Evans in on this as he just did a bunch of cleanup on mac generation code and there may already be existing code to reused rather than have yet another mac generator.

Thu, Jun 13, 4:39 PM

Mon, Jun 10

kevans committed rS348867: MFC r342747 (mmacy): zfsboot: support newer ZFS versions.
MFC r342747 (mmacy): zfsboot: support newer ZFS versions
Mon, Jun 10, 4:36 PM
kevans committed rS348866: MFC r348569: [zfsboot] Fix boot env back compat (#190).
MFC r348569: [zfsboot] Fix boot env back compat (#190)
Mon, Jun 10, 3:55 PM
kevans committed rS348865: MFC r348569: [zfsboot] Fix boot env back compat (#190).
MFC r348569: [zfsboot] Fix boot env back compat (#190)
Mon, Jun 10, 3:46 PM
kevans committed rS348863: MFC r348510: bectl(8): Don't accept jid=0 from jail_getid.
MFC r348510: bectl(8): Don't accept jid=0 from jail_getid
Mon, Jun 10, 2:48 PM
kevans committed rS348862: MFC r348510: bectl(8): Don't accept jid=0 from jail_getid.
MFC r348510: bectl(8): Don't accept jid=0 from jail_getid
Mon, Jun 10, 2:35 PM

Tue, Jun 4

kevans accepted D20513: Fix regression in r347193 in selecting which drive to boot..
Tue, Jun 4, 5:05 PM

Mon, Jun 3

kevans committed rS348546: MFC r348509: jail_getid(3): add special-case immediate return for jid 0.
MFC r348509: jail_getid(3): add special-case immediate return for jid 0
Mon, Jun 3, 4:48 PM
kevans committed rS348538: MFC r348509: jail_getid(3): add special-case immediate return for jid 0.
MFC r348509: jail_getid(3): add special-case immediate return for jid 0
Mon, Jun 3, 3:28 PM

Sun, Jun 2

kevans committed rS348510: bectl(8): Don't accept jid=0 from jail_getid.
bectl(8): Don't accept jid=0 from jail_getid
Sun, Jun 2, 2:06 PM
kevans committed rS348509: jail_getid(3): add special-case immediate return for jid 0.
jail_getid(3): add special-case immediate return for jid 0
Sun, Jun 2, 2:04 PM
kevans committed rS348504: llvm-symbolizer: Move out of CLANG_EXTRAS, into CLANG.
llvm-symbolizer: Move out of CLANG_EXTRAS, into CLANG
Sun, Jun 2, 4:04 AM
kevans closed D20484: llvm-symbolizer: Move out of CLANG_EXTRAS, into CLANG.
Sun, Jun 2, 4:04 AM
kevans committed rS348503: grep: Move lone 'r'grep case into the adjacent switch.
grep: Move lone 'r'grep case into the adjacent switch
Sun, Jun 2, 2:39 AM

Fri, May 31

kevans updated the diff for D20483: stand: evict zfs_alloc/zfs_free.

Take two, a little better... some of the raidz verification stuff needs a small API revamp or reconsideration if we want to try and recover from those, and we may want to improve diagnostics a little bit in other areas.

Fri, May 31, 8:20 PM
kevans created D20484: llvm-symbolizer: Move out of CLANG_EXTRAS, into CLANG.
Fri, May 31, 7:38 PM
kevans created D20483: stand: evict zfs_alloc/zfs_free.
Fri, May 31, 6:59 PM
kevans committed rS348471: stand: zfs: Free bouncebuf on error path in vdev_read.
stand: zfs: Free bouncebuf on error path in vdev_read
Fri, May 31, 5:44 PM
kevans committed rP503173: games/gzdoom: Fix 32-bit build after r501260 (update to 4.1.1).
games/gzdoom: Fix 32-bit build after r501260 (update to 4.1.1)
Fri, May 31, 1:30 PM

Thu, May 30

kevans updated the summary of D20468: Port if_vether from OpenBSD.
Thu, May 30, 1:27 PM
kevans created D20468: Port if_vether from OpenBSD.
Thu, May 30, 4:15 AM

Wed, May 29

kevans added a comment to D20278: vimage: support kmods determining VIMAGE status at runtime.
In D20278#441710, @bz wrote:

Hi,
I just only scrolled through this and there's a few things. I am not going into detail at the moment as I'd love to give this a full review once my brain capacity for yet-another-module-thing-complication is there. It'll be helpful to later decompose this into "whitespace change" and functional change (as a lot of renaming, etc. makes this hard to read).
We still have architectures where we cannot get in-src-tree modules built along kernel non-panicing in all cases. We've been dealing and finding edge-cases over the last 18 months. While I appreciate the effort of trying to solve more kernel module problems and easing pain, can you please hold this off at least until the more severe problems are fixed?

Wed, May 29, 3:00 PM
kevans added a reviewer for D20278: vimage: support kmods determining VIMAGE status at runtime: pawel.biernacki-gmail.com.
Wed, May 29, 2:08 PM
kevans committed rS348346: if_bridge(4): Complete bpf auditing of local traffic over the bridge.
if_bridge(4): Complete bpf auditing of local traffic over the bridge
Wed, May 29, 1:08 AM
kevans closed D19757: if_bridge(4): Complete bpf auditing of local traffic over the bridge.
Wed, May 29, 1:08 AM

Tue, May 28

kevans committed rS348328: bectl(8): Address Coverity complaints.
bectl(8): Address Coverity complaints
Tue, May 28, 4:12 PM

May 27 2019

kevans committed rS348305: MFC r348127: bectl(8): add description for create subcommand.
MFC r348127: bectl(8): add description for create subcommand
May 27 2019, 1:14 PM
kevans committed rS348304: MFC r348215, r348219: fix bectl(8) jail w/ numeric BE names.
MFC r348215, r348219: fix bectl(8) jail w/ numeric BE names
May 27 2019, 1:13 PM
kevans committed rS348297: MFC r348215, r348219: fix bectl(8) jail w/ numeric BE names.
MFC r348215, r348219: fix bectl(8) jail w/ numeric BE names
May 27 2019, 2:18 AM
kevans committed rS348296: MFC r348127: bectl(8): add description for create subcommand.
MFC r348127: bectl(8): add description for create subcommand
May 27 2019, 2:17 AM

May 24 2019

kevans added a comment to D20293: ucom(4): synchronously execute param changes.

The part that runs off the USB process threads is fine. But what contexts can ucom_param() be called from. Is there any chance of race here?

May 24 2019, 12:33 PM
kevans added a comment to D20293: ucom(4): synchronously execute param changes.

What happens if there are two threads calling the function where you drop the lock?

May 24 2019, 11:40 AM
kevans added a comment to D20293: ucom(4): synchronously execute param changes.

Just make sure that ucom_param() won't race when you drop the lock.

May 24 2019, 3:45 AM
kevans added a comment to D16653: libfdt: Update to 1.5.0.

Looks OK to me. One question: Do we want the various instances of fdt_check_header() in our code to be spelled FDT_RO_PROBE() now?

Yeah, neither loader nor the kernel need care for the extra bits done by fdt_check_header. I'll spin up a patch to do this conversion separately, to be committed after the 1.5.0 update since it's not critical.

May 24 2019, 2:21 AM
kevans updated the diff for D16653: libfdt: Update to 1.5.0.
May 24 2019, 2:18 AM
kevans committed rS348221: Tag libfdt 1.5.0.
Tag libfdt 1.5.0
May 24 2019, 2:11 AM
kevans committed rS348220: Import libfdt from dtc 1.5.0.
Import libfdt from dtc 1.5.0
May 24 2019, 2:10 AM
kevans added a comment to D16653: libfdt: Update to 1.5.0.
In D16653#353877, @imp wrote:

Was the larger size an issue for us?

May 24 2019, 2:06 AM
kevans committed rS348219: bectl(8): Add a test for jail/unjail of numeric BE names.
bectl(8): Add a test for jail/unjail of numeric BE names
May 24 2019, 1:54 AM
kevans committed rS348215: jail_getid(3): validate jid string input.
jail_getid(3): validate jid string input
May 24 2019, 1:28 AM
kevans closed D20388: jail_getid(3): validate jid string input.
May 24 2019, 1:28 AM

May 23 2019

kevans created D20388: jail_getid(3): validate jid string input.
May 23 2019, 8:53 PM
kevans accepted D19849: Reorg newvers.sh to eliminate VARS_ONLY and do things more directly.
May 23 2019, 5:18 PM
kevans accepted D19498: loader: Add pnp functions for autoloading modules based on linker.hints.
May 23 2019, 4:00 PM

May 22 2019

kevans committed rS348133: MFC r347640: libbe(3): Descend into children of datasets w/ mountpoint=none.
MFC r347640: libbe(3): Descend into children of datasets w/ mountpoint=none
May 22 2019, 11:34 PM
kevans committed rS348127: bectl(8): add description for create subcommand.
bectl(8): add description for create subcommand
May 22 2019, 11:07 PM
kevans closed D20249: add description for create subcommand (bectl.8).
May 22 2019, 11:07 PM
kevans accepted D20249: add description for create subcommand (bectl.8).

*nod* That was ultimately a mistake- my bad. This looks good to me.

May 22 2019, 11:06 PM
kevans added inline comments to D20240: create non-recursive boot environments (bectl).
May 22 2019, 11:04 PM
kevans committed rS348126: MFC r347578: tun/tap: Defer clearing if_softc until after if_detach.
MFC r347578: tun/tap: Defer clearing if_softc until after if_detach
May 22 2019, 10:56 PM
kevans committed rS348125: MFC r347640: libbe(3): Descend into children of datasets w/ mountpoint=none.
MFC r347640: libbe(3): Descend into children of datasets w/ mountpoint=none
May 22 2019, 10:55 PM
kevans committed rS348124: MFC r347578: tun/tap: Defer clearing if_softc until after if_detach.
MFC r347578: tun/tap: Defer clearing if_softc until after if_detach
May 22 2019, 10:34 PM
kevans added a comment to D20044: tun/tap: merge.
In D20044#438958, @dch wrote:

just noting that ports and scripts that rely on doing kldload if_tap will obviously break at this point. Something like:

+    # tap(4) & tun(4) were unified in r347241, this is closest ABI bump
+    if [ `uname -U` -ge 1300029 ]; then
+        if_tap="if_tuntap"
+    else
+        if_tap="if_tap"
+    fi
+    kldload "${if_tap}"

is all that should be needed; leaving this as a reference for others,
or a recommended improvement if there's a better way to handle this.

May 22 2019, 1:30 PM

May 17 2019

kevans created D20293: ucom(4): synchronously execute param changes.
May 17 2019, 5:46 PM

May 16 2019

kevans created D20278: vimage: support kmods determining VIMAGE status at runtime.
May 16 2019, 6:04 PM
kevans committed rS347640: libbe(3): Descend into children of datasets w/ mountpoint=none.
libbe(3): Descend into children of datasets w/ mountpoint=none
May 16 2019, 2:11 AM

May 14 2019

kevans committed rS347578: tuntap: Defer clearing if_softc until after if_detach.
tuntap: Defer clearing if_softc until after if_detach
May 14 2019, 8:32 PM
kevans committed rS347557: MFC r347241 (partial), r347392, r347429: ifconfig(8) ifname <-> kld mapping.
MFC r347241 (partial), r347392, r347429: ifconfig(8) ifname <-> kld mapping
May 14 2019, 2:00 AM

May 11 2019

kevans committed rS347483: tuntap: Improve style.
tuntap: Improve style
May 11 2019, 4:18 AM

May 10 2019

kevans committed rS347429: ifconfig(8): Add kld mappings for ipsec/enc.
ifconfig(8): Add kld mappings for ipsec/enc
May 10 2019, 1:18 PM

May 9 2019

kevans committed rS347404: tuntap: Don't down tap interfaces if LINK0 is set.
tuntap: Don't down tap interfaces if LINK0 is set
May 9 2019, 6:54 PM
kevans committed rS347394: tuntap: Properly detach tap ifp.
tuntap: Properly detach tap ifp
May 9 2019, 2:06 PM
kevans committed rS347392: ifconfig(8): Partial revert of r347241.
ifconfig(8): Partial revert of r347241
May 9 2019, 12:58 PM
kevans committed rS347378: MFC r346602, r346670-r346671, r347183: tun/tap race fixes.
MFC r346602, r346670-r346671, r347183: tun/tap race fixes
May 9 2019, 3:51 AM
kevans committed rS347376: MFC r339121 (tuexen): Use strlcpy() instead of strncpy()..
MFC r339121 (tuexen): Use strlcpy() instead of strncpy().
May 9 2019, 1:16 AM

May 8 2019

kevans closed D20044: tun/tap: merge.
May 8 2019, 2:32 AM
kevans committed rS347241: tun/tap: merge and rename to `tuntap`.
tun/tap: merge and rename to `tuntap`
May 8 2019, 2:32 AM

May 7 2019

kevans added a comment to D20044: tun/tap: merge.

Any other comments on this?

May 7 2019, 3:39 PM

May 6 2019

kevans committed rS347170: MFC r347027-r347028: libbe(3) mountpoint handling fixes.
MFC r347027-r347028: libbe(3) mountpoint handling fixes
May 6 2019, 2:10 AM
kevans committed rS347169: MFC r347021: fdt: Fix installation of aarch64 dtb.
MFC r347021: fdt: Fix installation of aarch64 dtb
May 6 2019, 2:09 AM

May 3 2019

kevans accepted D20148: geom: fix initialization order.

I suspect you'll need to bump some g_raid parts as well- it has modules declared at SI_SUB_DRIVERS/SI_ORDER_{FIRST,SECOND,THIRD} that I suspect could/should be bumped to SECOND/THIRD/FOURTH -- but I haven't had time to dig into it and examine the dependencies there.

The only other usage of g_modevent I've found is in g_raid, but it's already initialized at SI_ORDER_THIRD:
https://svnweb.freebsd.org/base/head/sys/geom/raid/g_raid.c?view=markup#l2570
There may be more that I've missed, I'm not familiar with the geom code at all.
I can confirm this change fixes the panic.

May 3 2019, 2:54 PM
kevans added a comment to D20148: geom: fix initialization order.

I suspect you'll need to bump some g_raid parts as well- it has modules declared at SI_SUB_DRIVERS/SI_ORDER_{FIRST,SECOND,THIRD} that I suspect could/should be bumped to SECOND/THIRD/FOURTH -- but I haven't had time to dig into it and examine the dependencies there.

May 3 2019, 2:20 PM

May 2 2019

kevans committed rS347028: libbe: set mountpoint=none in be_import.
libbe: set mountpoint=none in be_import
May 2 2019, 5:51 PM
kevans committed rS347027: libbe(3): Properly mount BEs with mountpoint=none.
libbe(3): Properly mount BEs with mountpoint=none
May 2 2019, 5:44 PM
kevans committed rS347023: stand: correct mis-merge from r346879.
stand: correct mis-merge from r346879
May 2 2019, 5:01 PM
kevans committed rS347021: fdt: Fix installation of aarch64 dtb.
fdt: Fix installation of aarch64 dtb
May 2 2019, 4:56 PM

Apr 29 2019

kevans updated the diff for D20044: tun/tap: merge.

Perhaps out of scope for this and should be split out, but add a mechanism to ifconfig(8) to allow explicitly mapping interface names to a specific kld. This allows remapping tun*, tap*, and vmnet* to if_tuntap to kill off errors akin to:

Apr 29 2019, 6:00 PM
kevans updated the diff for D20044: tun/tap: merge.

Slight rework of TUNSIFMODE handling, remove stale comment.

Apr 29 2019, 5:16 PM
kevans updated the diff for D20044: tun/tap: merge.

Fix ioctl issue diagnosed by @tuexen (thanks!)
Fix up some other ioctl issues:

  • #define tapinfo as tuninfo (equivalently sized/named before)
  • #define all of the TAP* ioctls as TUN* ioctls, just for clarity (they were equivalent values before)
Apr 29 2019, 5:12 PM
kevans added a comment to D20044: tun/tap: merge.

... [snip] ...
This means: On an unpatched system, setting the IPv4 address brings the interface up, whereas on an patched system, the
interface stays down. Is that intended?

Apr 29 2019, 1:28 PM
kevans updated the diff for D20044: tun/tap: merge.

Rename to tuntap, amend UPDATING and all kernel configs that have it included, as well as NOTES. Alias logic stolen from the fusefs module, since it recently went through a rename as well. Some bits within tuntap, mostly in what I've added, were renamed to reflect the new module name.

Apr 29 2019, 2:28 AM
kevans added a comment to D20044: tun/tap: merge.

I can't seem to reproduce this issue (though some things aren't functional in my current test system (until tomorrow), as I'm bridging with encrypted wifi):

Apr 29 2019, 1:08 AM

Apr 28 2019

kevans added a comment to D20044: tun/tap: merge.

I'll take a look and attempt to reproduce ASAP.

Apr 28 2019, 10:42 PM
kevans added a comment to D20044: tun/tap: merge.

Would it make sense to use if_tuntap.c instead of if_tun.c, the same for the name of the module to load, the device to compile in?

Apr 28 2019, 1:52 PM
kevans committed rS346803: MFC r346688-r346689: tap(4) MODULE_VERSION.
MFC r346688-r346689: tap(4) MODULE_VERSION
Apr 28 2019, 3:51 AM
kevans committed rS346802: MFC r346545-r346546, r346680, r346700, r346705.
MFC r346545-r346546, r346680, r346700, r346705
Apr 28 2019, 3:50 AM

Apr 27 2019

kevans committed rS346784: Bump __FreeBSD_version for ether_gen_addr availability.
Bump __FreeBSD_version for ether_gen_addr availability
Apr 27 2019, 4:52 AM
kevans committed rS346783: MFC r345139, r345151, r346324, r346328: ether_gen_addr KPI.
MFC r345139, r345151, r346324, r346328: ether_gen_addr KPI
Apr 27 2019, 4:39 AM
kevans committed rS346782: MFC r346469: dtc(1): Pull in fix for segfault-upon-error condition.
MFC r346469: dtc(1): Pull in fix for segfault-upon-error condition
Apr 27 2019, 4:16 AM
kevans committed rS346781: MFC r346307, r346618: Further DTB building consolidation/documentation.
MFC r346307, r346618: Further DTB building consolidation/documentation
Apr 27 2019, 4:12 AM

Apr 26 2019

kevans updated the diff for D20044: tun/tap: merge.

Addressed the last of @melifaro's comments.

Apr 26 2019, 3:03 PM
kevans added inline comments to D20044: tun/tap: merge.
Apr 26 2019, 2:54 PM

Apr 25 2019

kevans committed rS346705: libbe(3): Fix libcompat build.
libbe(3): Fix libcompat build
Apr 25 2019, 8:48 PM
kevans committed rS346700: libbe(3): Fix mis-application of patch (SHLIBDIR).
libbe(3): Fix mis-application of patch (SHLIBDIR)
Apr 25 2019, 8:02 PM
kevans accepted D20059: loader: fdt: Add fdt_is_setup function.
Apr 25 2019, 7:42 PM
kevans committed rS346689: tap(4): Correct driver name....
tap(4): Correct driver name...
Apr 25 2019, 6:26 PM