Page MenuHomeFreeBSD

kevans (Kyle Evans)
User

Projects

User Details

User Since
Oct 2 2015, 1:17 PM (167 w, 4 h)

Recent Activity

Wed, Dec 12

kevans accepted D18302: regcomp() recurses infinitely on a case-insensitive pattern containing wide characters in 128-255 range.

@kevans are you OK with the test case added to libc/regex instead and using sed? :)

Wed, Dec 12, 3:05 AM

Thu, Dec 6

kevans committed rS341644: Fix kenv handling in stable/11 following r337333.
Fix kenv handling in stable/11 following r337333
Thu, Dec 6, 7:19 PM

Mon, Nov 26

kevans accepted D18335: sync bectl usage with man page.

Please mark it for three day MFC or so and I'll pick it up on Wednesday if you don't.

Mon, Nov 26, 8:48 AM

Fri, Nov 23

kevans added a comment to D18302: regcomp() recurses infinitely on a case-insensitive pattern containing wide characters in 128-255 range.

Can you throw a test case for this in ^/usr.bin/grep/tests/grep_freebsd_test.sh as well, please? It's currently pretty-much-mandatory to run grep/sed/libc test suites against regex(3) changes anyways, so this would be sensible.

Fri, Nov 23, 2:37 PM
kevans accepted D18297: PR153502: [libc] regex(3) bug with UTF-8 locale.

Looks good to me. =) ++testcases

Fri, Nov 23, 2:16 AM

Thu, Nov 22

kevans committed rS340753: MFC r340507-r340508, r340592-r340594, r340635-r340636: bectl(8) fixes.
MFC r340507-r340508, r340592-r340594, r340635-r340636: bectl(8) fixes
Thu, Nov 22, 4:39 AM
kevans committed rS340752: MFC r339701: Update lualoader test script a little bit.
MFC r339701: Update lualoader test script a little bit
Thu, Nov 22, 3:04 AM
kevans committed rS340751: MFC r340507-r340508, r340592-r340594, r340635-r340636: bectl(8) fixes.
MFC r340507-r340508, r340592-r340594, r340635-r340636: bectl(8) fixes
Thu, Nov 22, 1:26 AM

Mon, Nov 19

kevans committed rS340648: MFC r340392: Add dynamic_kenv assertion to init_static_kenv.
MFC r340392: Add dynamic_kenv assertion to init_static_kenv
Mon, Nov 19, 7:05 PM
kevans committed rS340647: MFC r340392: Add dynamic_kenv assertion to init_static_kenv.
MFC r340392: Add dynamic_kenv assertion to init_static_kenv
Mon, Nov 19, 7:05 PM
kevans committed rS340646: MFC r340390: Fix test-dts{,o} targets.
MFC r340390: Fix test-dts{,o} targets
Mon, Nov 19, 6:59 PM
kevans committed rS340636: bectl(8) tests: attempt to load the ZFS module.
bectl(8) tests: attempt to load the ZFS module
Mon, Nov 19, 5:10 PM
kevans committed rS340635: libbe(3): Handle non-ZFS rootfs better.
libbe(3): Handle non-ZFS rootfs better
Mon, Nov 19, 4:47 PM
kevans committed rS340594: bectl(8): Add some regression tests.
bectl(8): Add some regression tests
Mon, Nov 19, 2:30 AM
kevans committed rS340593: libbe(3): Properly account for altroot when creating new BEs.
libbe(3): Properly account for altroot when creating new BEs
Mon, Nov 19, 2:16 AM
kevans closed D18029: bectl(3)/libbe(3): Allow BE root to be specified.
Mon, Nov 19, 2:12 AM
kevans committed rS340592: bectl(3)/libbe(3): Allow BE root to be specified.
bectl(3)/libbe(3): Allow BE root to be specified
Mon, Nov 19, 2:12 AM

Sun, Nov 18

kevans committed rP485228: MFH: r485226.
MFH: r485226
Sun, Nov 18, 3:06 PM
kevans committed rP485226: net/freerdp1: Fix build with OpenSSL 1.1.
net/freerdp1: Fix build with OpenSSL 1.1
Sun, Nov 18, 2:53 PM
kevans added a comment to D18029: bectl(3)/libbe(3): Allow BE root to be specified.

create also needs to learn about zpool altroot, or else it screws things up.

Sun, Nov 18, 3:16 AM
kevans created D18029: bectl(3)/libbe(3): Allow BE root to be specified.
Sun, Nov 18, 2:52 AM

Sat, Nov 17

kevans committed rS340519: MFC r340372: dtb.mk: Fix passing of ECHO to make_dtb{,o}.sh.
MFC r340372: dtb.mk: Fix passing of ECHO to make_dtb{,o}.sh
Sat, Nov 17, 8:27 PM
kevans committed rS340508: libbe(3): Rewrite be_unmount to stop mucking with getmntinfo(2).
libbe(3): Rewrite be_unmount to stop mucking with getmntinfo(2)
Sat, Nov 17, 7:19 PM
kevans committed rS340507: libbe(3): rewrite init to support chroot usage.
libbe(3): rewrite init to support chroot usage
Sat, Nov 17, 7:15 PM
kevans closed D18012: libbe(3): rewrite init to support chroot usage.
Sat, Nov 17, 7:15 PM
kevans added a comment to D18012: libbe(3): rewrite init to support chroot usage.

Ok, good! The be_unmount can use some cleanup of its own, though, which might help a bit. Right now we use getmntinfo(2), locate the mountpoint for the requested BE, then unmount(2) it... this can all be simplified into zfs_open/zfs_unmount/zfs_close and probably be more robust from ZFS' perspective and might also fix your problem.

Sat, Nov 17, 7:02 PM
kevans updated the diff for D18012: libbe(3): rewrite init to support chroot usage.

Eliminate all of the bits that care about the mountpoint being "/" -- there were exactly two, in validating BE snapshots and in validating that a BE was valid.

Sat, Nov 17, 2:53 PM
kevans added a comment to D18012: libbe(3): rewrite init to support chroot usage.

Ah, this is actually a thing Allan pointed out was bogus a couple days ago. I just need to axe ~20 lines- I think it fails in your case because with altroot, the mountpoint property really won't read as / but ZFS will do the right thing anyways.

Sat, Nov 17, 2:11 PM
kevans created D18012: libbe(3): rewrite init to support chroot usage.
Sat, Nov 17, 2:11 AM

Thu, Nov 15

kevans committed rS340454: MFC r340334: libbe(3): Set canmount properly when activating a new BE.
MFC r340334: libbe(3): Set canmount properly when activating a new BE
Thu, Nov 15, 4:04 PM

Nov 13 2018

kevans committed rS340392: Add dynamic_kenv assertion to init_static_kenv.
Add dynamic_kenv assertion to init_static_kenv
Nov 13 2018, 4:34 AM

Nov 12 2018

kevans committed rS340390: Fix test-dts{,o} targets.
Fix test-dts{,o} targets
Nov 12 2018, 10:18 PM
kevans closed D17961: Fix test-dts{,o} targets.
Nov 12 2018, 10:18 PM
kevans created D17961: Fix test-dts{,o} targets.
Nov 12 2018, 6:22 PM
kevans committed rS340372: dtb.mk: Fix passing of ECHO to make_dtb{,o}.sh.
dtb.mk: Fix passing of ECHO to make_dtb{,o}.sh
Nov 12 2018, 5:10 PM
kevans committed rS340362: MFC r340297: Use ${ECHO} in dtb/dtbo build, pass in from dtb.mk for -s.
MFC r340297: Use ${ECHO} in dtb/dtbo build, pass in from dtb.mk for -s
Nov 12 2018, 3:18 PM
kevans added a comment to D17958: Print an error message in efi_main.c if we can't allocate memory for the heap..

+1 for including the size of the allocation. I wish we could also (cheaply) work out and print how much space we actually have to work with, but meh. I'm not proud of how many times qemu's bitten me because I didn't pay attention to the -m default and spent x amount of time working out again that I didn't give it enough memory to boot successfully.

Nov 12 2018, 2:07 PM

Nov 10 2018

kevans committed rS340334: libbe(3): Set canmount properly when activating a new BE.
libbe(3): Set canmount properly when activating a new BE
Nov 10 2018, 8:42 PM

Nov 9 2018

kevans committed rS340297: Use ${ECHO} in dtb/dtbo build, pass in from dtb.mk for -s.
Use ${ECHO} in dtb/dtbo build, pass in from dtb.mk for -s
Nov 9 2018, 6:56 PM

Nov 8 2018

kevans committed rS340244: MFC r340040, r340152: lualoader boot-conf and chainload.
MFC r340040, r340152: lualoader boot-conf and chainload
Nov 8 2018, 3:25 AM
kevans committed rS340243: MFC r340146: Move pmc* bits behind MK_PMC to fix WITHOUT_PMC build.
MFC r340146: Move pmc* bits behind MK_PMC to fix WITHOUT_PMC build
Nov 8 2018, 3:24 AM

Nov 7 2018

kevans added a reviewer for D17653: Teach newvers.sh how to get the last revision on the branch: emaste.

Tagging @emaste as well, but I think this looks good to me as-is.

Nov 7 2018, 7:11 PM

Nov 5 2018

kevans committed rS340154: MFC r339994: libbe(3): Don't promote non-cloned BEs.
MFC r339994: libbe(3): Don't promote non-cloned BEs
Nov 5 2018, 6:12 PM
kevans committed rS340153: MFC r339972: rescue: Add bectl(8).
MFC r339972: rescue: Add bectl(8)
Nov 5 2018, 6:12 PM
kevans committed rS340152: lualoader: Add chainload menu entry.
lualoader: Add chainload menu entry
Nov 5 2018, 4:20 PM
kevans committed rS340146: Move pmc* bits behind MK_PMC to fix WITHOUT_PMC build.
Move pmc* bits behind MK_PMC to fix WITHOUT_PMC build
Nov 5 2018, 12:21 AM

Nov 2 2018

kevans committed rS340040: lualoader: Implement boot-conf.
lualoader: Implement boot-conf
Nov 2 2018, 3:25 AM

Nov 1 2018

kevans committed rS340012: MFC r339849: lualoader: Fix try_include error handling.
MFC r339849: lualoader: Fix try_include error handling
Nov 1 2018, 5:37 PM
kevans committed rS339994: libbe(3): Don't promote non-cloned BEs.
libbe(3): Don't promote non-cloned BEs
Nov 1 2018, 2:01 PM

Oct 31 2018

kevans committed rS339978: MFC r339677-r339678, r339702, r339805: Lualoader Bugfixes.
MFC r339677-r339678, r339702, r339805: Lualoader Bugfixes
Oct 31 2018, 11:09 PM
kevans committed rS339974: i386/MINIMAL: VERBOSE_SYSINIT=0 for consistency.
i386/MINIMAL: VERBOSE_SYSINIT=0 for consistency
Oct 31 2018, 10:55 PM
kevans committed rS339973: Compile in VERBOSE_SYSINIT support by default, remain silent by default.
Compile in VERBOSE_SYSINIT support by default, remain silent by default
Oct 31 2018, 10:38 PM
kevans committed rS339972: rescue: Add bectl(8).
rescue: Add bectl(8)
Oct 31 2018, 8:42 PM
kevans accepted D17776: fix failing sed test case.
Oct 31 2018, 1:27 PM

Oct 30 2018

kevans accepted D17608: tpm(4): Add the STANDARDS and HISTORY sections..
Oct 30 2018, 12:18 AM

Oct 29 2018

kevans committed rS339849: lualoader: Fix try_include error handling.
lualoader: Fix try_include error handling
Oct 29 2018, 2:58 AM

Oct 27 2018

kevans committed rS339805: lualoader: Always return a proper dictionary for blacklist.
lualoader: Always return a proper dictionary for blacklist
Oct 27 2018, 4:10 AM

Oct 25 2018

kevans committed rS339702: lualoader: Improve module loading diagnostics.
lualoader: Improve module loading diagnostics
Oct 25 2018, 2:14 AM
kevans closed D17694: lualoader: Improve module loading diagnostics.
Oct 25 2018, 2:14 AM
kevans committed rS339701: Update lualoader test script a little bit.
Update lualoader test script a little bit
Oct 25 2018, 2:04 AM
kevans updated the diff for D17694: lualoader: Improve module loading diagnostics.

Don't brick boots without the updated liblua... most commonly occurring if loader.efi's been installed to ESP, additional intervention is required.

Oct 25 2018, 1:42 AM
kevans created D17694: lualoader: Improve module loading diagnostics.
Oct 25 2018, 1:39 AM

Oct 24 2018

kevans committed rS339678: menu.lua: Abort autoboot sequence on failed command.
menu.lua: Abort autoboot sequence on failed command
Oct 24 2018, 3:14 AM
kevans committed rS339677: lualoader: unload upon kernel change if a kernel was previously loaded.
lualoader: unload upon kernel change if a kernel was previously loaded
Oct 24 2018, 2:02 AM

Oct 23 2018

kevans added inline comments to D6814: Add libfdt user space library.
Oct 23 2018, 5:07 PM

Oct 22 2018

kevans added a reviewer for D17653: Teach newvers.sh how to get the last revision on the branch: kevans.
Oct 22 2018, 9:58 PM

Oct 19 2018

kevans added a comment to D17607: Tehuti networks tn40xx device driver..

This diff: https://people.freebsd.org/~kevans/tn40xx-build.diff applied on top of what you have here should hook it up to the build properly-ish (sys/modules/Makefile should have a SUBDIR+= tn40xx line later, but needs testing first) -- you can add device tn40xx to your kernconf and get the driver built into the kernel, or walk into sys/modules/tn40xx and make the kmod manually.

Oct 19 2018, 3:33 AM

Oct 15 2018

kevans committed rS339371: Correct COMPAT* macro names in syscalls.master.
Correct COMPAT* macro names in syscalls.master
Oct 15 2018, 9:36 PM

Oct 11 2018

kevans committed rS339309: Disable kernels_autodetect on installation media.
Disable kernels_autodetect on installation media
Oct 11 2018, 5:19 PM
kevans committed rS339308: Enable lualoader's kernel autodetection, disabled on install media.
Enable lualoader's kernel autodetection, disabled on install media
Oct 11 2018, 5:18 PM
kevans committed rS339307: lualoader: Provide a 'menu' command to redraw the menu at the loader prompt.
lualoader: Provide a 'menu' command to redraw the menu at the loader prompt
Oct 11 2018, 5:16 PM

Oct 7 2018

kevans committed rS339222: lualoader: Honor boot_* variables at lua init.
lualoader: Honor boot_* variables at lua init
Oct 7 2018, 3:28 PM
kevans closed D16914: lualoader: Create a module blacklist, add DRM modules to it.
Oct 7 2018, 1:54 AM
kevans committed rS339218: lualoader: Create a module blacklist, add DRM modules to it.
lualoader: Create a module blacklist, add DRM modules to it
Oct 7 2018, 1:54 AM

Oct 5 2018

kevans committed rS339200: lualoader: Don't draw loader menu with autoboot_delay=-1.
lualoader: Don't draw loader menu with autoboot_delay=-1
Oct 5 2018, 5:07 PM

Oct 3 2018

kevans committed rS339164: MFC r338040: diff(1): Refactor -B a little bit.
MFC r338040: diff(1): Refactor -B a little bit
Oct 3 2018, 5:22 PM
kevans committed rS339163: MFC r338646: dd(1): Correct padding in status=progress.
MFC r338646: dd(1): Correct padding in status=progress
Oct 3 2018, 5:20 PM
kevans committed rS339162: MFC r338223, r338263: Missing bits from OptionalObsoleteFiles.
MFC r338223, r338263: Missing bits from OptionalObsoleteFiles
Oct 3 2018, 5:19 PM
kevans committed rS339161: MFC r338219, r338250: FDT in Loader fixes.
MFC r338219, r338250: FDT in Loader fixes
Oct 3 2018, 5:17 PM
kevans committed rS339160: MFC r338039: diff(1): Implement -B/--ignore-blank-lines.
MFC r338039: diff(1): Implement -B/--ignore-blank-lines
Oct 3 2018, 5:16 PM
kevans committed rS339159: MFC r337964, r338232: dtc(1) updates.
MFC r337964, r338232: dtc(1) updates
Oct 3 2018, 5:14 PM

Oct 1 2018

kevans committed rS339047: libbe(3): Fix BE activation promoting activated BE.
libbe(3): Fix BE activation promoting activated BE
Oct 1 2018, 2:57 PM

Sep 19 2018

kevans accepted D17236: Improve loader passwords.

I don't have time to do a thorough review/test, but nothing here offends my greater sensibilities so it looks good to me if you've tested it. =)

Sep 19 2018, 4:25 PM

Sep 13 2018

kevans committed rS338646: dd(1): Correct padding in status=progress.
dd(1): Correct padding in status=progress
Sep 13 2018, 2:55 PM
kevans closed D16960: dd: Correct padding in status=progress.
Sep 13 2018, 2:54 PM
kevans added a comment to D16960: dd: Correct padding in status=progress.

Firing off an e-mail to re@

Sep 13 2018, 2:13 PM

Sep 12 2018

kevans accepted D17132: PR228448: `unlink -foo` , the original use of `unlink`, no longer works..
Sep 12 2018, 1:33 PM

Sep 3 2018

kevans committed rS338438: lualoader: Handle comma-separated kernels as well.
lualoader: Handle comma-separated kernels as well
Sep 3 2018, 3:23 AM

Sep 1 2018

kevans accepted D16972: Catch exceptions during EFI RT calls on amd64..
Sep 1 2018, 8:00 PM
kevans committed rS338418: userboot: handle guest interpreter mismatches more intelligently.
userboot: handle guest interpreter mismatches more intelligently
Sep 1 2018, 2:24 AM
kevans closed D16945: userboot: handle guest interpreter mismatches more intelligently.
Sep 1 2018, 2:24 AM
kevans committed rS338417: libbe(3): Fix error handling with respect to be_exists.
libbe(3): Fix error handling with respect to be_exists
Sep 1 2018, 2:23 AM

Aug 31 2018

kevans added a comment to D16945: userboot: handle guest interpreter mismatches more intelligently.

Thanks!

Aug 31 2018, 5:29 PM
kevans added a comment to D16960: dd: Correct padding in status=progress.
In D16960#362030, @imp wrote:

looks good, as does the good humanize_number catch.

Aug 31 2018, 4:38 PM
kevans added inline comments to D16945: userboot: handle guest interpreter mismatches more intelligently.
Aug 31 2018, 4:28 PM
kevans updated the diff for D16945: userboot: handle guest interpreter mismatches more intelligently.

Fix semantics and simplify. Notable changes:

Aug 31 2018, 4:25 PM
kevans committed rS338407: lualoader: Print error messages from command failures at the prompt.
lualoader: Print error messages from command failures at the prompt
Aug 31 2018, 3:03 PM
kevans added a comment to D16960: dd: Correct padding in status=progress.

Hi @imp - I've also received some other questions about status=progress:

Aug 31 2018, 12:51 PM

Aug 30 2018

kevans added inline comments to D16945: userboot: handle guest interpreter mismatches more intelligently.
Aug 30 2018, 11:16 PM
kevans added a comment to D16945: userboot: handle guest interpreter mismatches more intelligently.

I'll take a look at these later tonight(-ish) (CDT), thanks!

Aug 30 2018, 6:46 PM