Page MenuHomeFreeBSD

kevans (Kyle Evans)
User

Projects (8)

User Details

User Since
Oct 2 2015, 1:17 PM (365 w, 3 d)

Recent Activity

Thu, Sep 29

kevans committed rG78f3c734a5b7: arm64: fix build without FDT (authored by kevans).
arm64: fix build without FDT
Thu, Sep 29, 7:34 PM
kevans committed rG23c318ed86c4: extres: regulator: fix the build without FDT (authored by kevans).
extres: regulator: fix the build without FDT
Thu, Sep 29, 7:34 PM
kevans committed rGb4c2a5b68986: arm64: coresight: fix the build without FDT (authored by kevans).
arm64: coresight: fix the build without FDT
Thu, Sep 29, 7:34 PM
kevans committed rG4a4ad02da3c8: uart: uart_cpu_arm64: fix the build without FDT (authored by kevans).
uart: uart_cpu_arm64: fix the build without FDT
Thu, Sep 29, 7:34 PM
kevans committed rG79794d5c18b7: extres: syscon: pull in sys/malloc.h (fix !FDT) (authored by kevans).
extres: syscon: pull in sys/malloc.h (fix !FDT)
Thu, Sep 29, 7:34 PM
kevans closed D36791: arm64: fix build without FDT.
Thu, Sep 29, 7:34 PM
kevans closed D36789: arm64: coresight: fix the build without FDT.
Thu, Sep 29, 7:34 PM
kevans closed D36790: extres: regulator: fix the build without FDT.
Thu, Sep 29, 7:34 PM
kevans closed D36787: extres: syscon: pull in sys/malloc.h (fix !FDT).
Thu, Sep 29, 7:34 PM
kevans closed D36788: uart: uart_cpu_arm64: fix the build without FDT.
Thu, Sep 29, 7:34 PM
kevans updated the diff for D36788: uart: uart_cpu_arm64: fix the build without FDT.

Switch to Andy's idea; do fdt setup in a new function entirely, just return
ENXIO if neither setup succeeds.

Thu, Sep 29, 4:11 PM
kevans requested review of D36791: arm64: fix build without FDT.
Thu, Sep 29, 6:12 AM
kevans requested review of D36790: extres: regulator: fix the build without FDT.
Thu, Sep 29, 6:12 AM
kevans requested review of D36789: arm64: coresight: fix the build without FDT.
Thu, Sep 29, 6:12 AM
kevans requested review of D36788: uart: uart_cpu_arm64: fix the build without FDT.
Thu, Sep 29, 6:12 AM
kevans requested review of D36787: extres: syscon: pull in sys/malloc.h (fix !FDT).
Thu, Sep 29, 6:12 AM
kevans added a comment to D36776: arm64: add a std.aws config.

I always use GENERIC in EC2, but this seems accurate as far as it goes. Maybe you want to throw in an explicit device nvme as well since that's what modern EC2 systems use? But (as with acpi) that's something people are likely to have anyway.

Thu, Sep 29, 4:06 AM

Wed, Sep 28

kevans requested review of D36776: arm64: add a std.aws config.
Wed, Sep 28, 8:50 PM

Tue, Sep 27

kevans added inline comments to D36701: arm64: add KASAN support.
Tue, Sep 27, 8:57 PM
kevans committed rG26d786331bf8: usb: musb_otg_allwinner: de-constify bus_space_tags (authored by mhorne).
usb: musb_otg_allwinner: de-constify bus_space_tags
Tue, Sep 27, 8:55 PM
kevans closed D36764: usb: musb_otg_allwinner: de-constify bus_space_tags.
Tue, Sep 27, 8:55 PM
kevans added a comment to D36764: usb: musb_otg_allwinner: de-constify bus_space_tags.

Seems harmless to me.

other than the fact that I can't figure out how to make that change.

Does it not work because bus_space_tag_t is a pointer on some platforms but not others?

Tue, Sep 27, 8:17 PM
kevans requested review of D36764: usb: musb_otg_allwinner: de-constify bus_space_tags.
Tue, Sep 27, 7:35 PM
kevans committed rGf2963b530e17: kasan: disable kasan_mark() after a violation (authored by mhorne).
kasan: disable kasan_mark() after a violation
Tue, Sep 27, 4:02 PM
kevans closed D36742: kasan: disable kasan_mark() after a violation.
Tue, Sep 27, 4:01 PM
kevans requested review of D36742: kasan: disable kasan_mark() after a violation.
Tue, Sep 27, 6:29 AM
kevans updated the diff for D36701: arm64: add KASAN support.

Second round of review feedback; rebased on top of Andy's pmap bootstrap cleanup
branch.

Tue, Sep 27, 5:55 AM

Mon, Sep 26

kevans committed rG818cae0ff752: kasan: provide bus peek/poke definitions (authored by mhorne).
kasan: provide bus peek/poke definitions
Mon, Sep 26, 7:27 PM
kevans committed rGf8e38b421b38: arm64: bus: provide bus_space_set_{multi,region}_stream definitions (authored by mhorne).
arm64: bus: provide bus_space_set_{multi,region}_stream definitions
Mon, Sep 26, 7:27 PM
kevans committed rGc5500a01c78a: arm64: bus: unhide bus_space definition with sanitizers included (authored by mhorne).
arm64: bus: unhide bus_space definition with sanitizers included
Mon, Sep 26, 7:27 PM
kevans committed rGbd93b5f79ab4: pci_host_generic: stop address translation in bus_alloc_resource (authored by kevans).
pci_host_generic: stop address translation in bus_alloc_resource
Mon, Sep 26, 7:27 PM
kevans closed D36700: kasan: provide bus peek/poke definitions.
Mon, Sep 26, 7:26 PM
kevans closed D36618: pci_host_generic: stop address translation in bus_alloc_resource.
Mon, Sep 26, 7:26 PM
kevans closed D36719: arm64: bus: provide bus_space_set_{multi,region}_stream definitions.
Mon, Sep 26, 7:26 PM
kevans closed D36718: arm64: bus: unhide bus_space definition with sanitizers included.
Mon, Sep 26, 7:26 PM
kevans requested review of D36719: arm64: bus: provide bus_space_set_{multi,region}_stream definitions.
Mon, Sep 26, 3:32 PM
kevans requested review of D36718: arm64: bus: unhide bus_space definition with sanitizers included.
Mon, Sep 26, 3:32 PM
kevans added inline comments to D36701: arm64: add KASAN support.
Mon, Sep 26, 3:14 PM
kevans updated the diff for D36701: arm64: add KASAN support.

Address review feedback.

Mon, Sep 26, 4:45 AM

Sun, Sep 25

kevans added a comment to D36701: arm64: add KASAN support.

I also still haven't put too much thought into why arm64 KASAN seems to use way more stack than amd64 KASAN.

Sun, Sep 25, 6:44 PM
kevans requested review of D36702: arm64: add a GENERIC-KASAN config.
Sun, Sep 25, 6:42 PM
kevans requested review of D36701: arm64: add KASAN support.
Sun, Sep 25, 6:42 PM
kevans requested review of D36700: kasan: provide bus peek/poke definitions.
Sun, Sep 25, 6:42 PM
kevans added a reviewer for D32308: Add a build knob for _FORTIFY_SOURCE: imp.
Sun, Sep 25, 1:37 AM
kevans added a reviewer for D32307: Prepare the system for _FORTIFY_SOURCE: imp.
Sun, Sep 25, 1:37 AM
kevans added a reviewer for D32306: Import _FORTIFY_SOURCE implementation from NetBSD: imp.
Sun, Sep 25, 1:36 AM

Sun, Sep 18

kevans accepted D36619: Deprecate telnetd.
Sun, Sep 18, 8:23 AM
kevans committed rG8a832ed2f8c1: stand: i386: take into account disk sector size for blk calculation (authored by kevans).
stand: i386: take into account disk sector size for blk calculation
Sun, Sep 18, 6:28 AM
kevans committed rG6ef5bf8c21aa: arm64, riscv: size boot stacks appropriately (authored by kevans).
arm64, riscv: size boot stacks appropriately
Sun, Sep 18, 6:28 AM
kevans committed rG42b5d30b9dfe: iconv: only conditionally use ICONV_SET_DISCARD_ILSEQ (authored by kevans).
iconv: only conditionally use ICONV_SET_DISCARD_ILSEQ
Sun, Sep 18, 6:28 AM
kevans committed rG65b33f206d34: tools: test: iconv: fix open_2 to not segfault (authored by kevans).
tools: test: iconv: fix open_2 to not segfault
Sun, Sep 18, 6:28 AM
kevans committed rG94f51bb57834: alc: force maximum payload size to 128 bytes for AR816X/AR817x (authored by kevans).
alc: force maximum payload size to 128 bytes for AR816X/AR817x
Sun, Sep 18, 6:28 AM
kevans committed rG56f9e6ff1dca: zdiff: avoid non-conformant features (authored by kevans).
zdiff: avoid non-conformant features
Sun, Sep 18, 6:28 AM
kevans committed rG354d310fe987: arm64: gic: disable the ITS if it's enabled prior to configuration (authored by kevans).
arm64: gic: disable the ITS if it's enabled prior to configuration
Sun, Sep 18, 6:28 AM
kevans committed rG7e04dc0797f3: stand: i386: take into account disk sector size for blk calculation (authored by kevans).
stand: i386: take into account disk sector size for blk calculation
Sun, Sep 18, 6:28 AM
kevans committed rGf086a0afe0c9: arm64: disable the EL2 MMU before dropping to EL1 (authored by kevans).
arm64: disable the EL2 MMU before dropping to EL1
Sun, Sep 18, 6:28 AM
kevans committed rG9a45e76cfd25: arm64, riscv: size boot stacks appropriately (authored by kevans).
arm64, riscv: size boot stacks appropriately
Sun, Sep 18, 6:28 AM
kevans committed rG540ecebdd01b: tools: test: iconv: fix open_2 to not segfault (authored by kevans).
tools: test: iconv: fix open_2 to not segfault
Sun, Sep 18, 6:27 AM
kevans committed rG426e7ab3cacc: iconv: only conditionally use ICONV_SET_DISCARD_ILSEQ (authored by kevans).
iconv: only conditionally use ICONV_SET_DISCARD_ILSEQ
Sun, Sep 18, 6:27 AM
kevans committed rGf248e70fc1a4: alc: force maximum payload size to 128 bytes for AR816X/AR817x (authored by kevans).
alc: force maximum payload size to 128 bytes for AR816X/AR817x
Sun, Sep 18, 6:27 AM
kevans committed rGe683e1fc0fde: date: attempt to more accurately describe year limitations with -v (authored by kevans).
date: attempt to more accurately describe year limitations with -v
Sun, Sep 18, 6:27 AM
kevans committed rG2f5dbe4772e8: zdiff: avoid non-conformant features (authored by kevans).
zdiff: avoid non-conformant features
Sun, Sep 18, 6:27 AM
kevans committed rG5a08fbb315e8: arm64: disable the EL2 MMU before dropping to EL1 (authored by kevans).
arm64: disable the EL2 MMU before dropping to EL1
Sun, Sep 18, 6:27 AM
kevans committed rGd7474d9b3104: arm64: gic: disable the ITS if it's enabled prior to configuration (authored by kevans).
arm64: gic: disable the ITS if it's enabled prior to configuration
Sun, Sep 18, 6:27 AM
kevans updated the diff for D36618: pci_host_generic: stop address translation in bus_alloc_resource.

"Whoops", GC phys_start/phys_end now

Sun, Sep 18, 6:23 AM
kevans requested review of D36618: pci_host_generic: stop address translation in bus_alloc_resource.
Sun, Sep 18, 6:14 AM

Thu, Sep 8

kevans committed rG72291cee075d: stand: i386: take into account disk sector size for blk calculation (authored by kevans).
stand: i386: take into account disk sector size for blk calculation
Thu, Sep 8, 3:06 PM
kevans closed D36490: stand: i386: take into account disk sector size for blk calculation.
Thu, Sep 8, 3:06 PM
kevans committed rGbab32a8029c3: arm64, riscv: size boot stacks appropriately (authored by kevans).
arm64, riscv: size boot stacks appropriately
Thu, Sep 8, 5:04 AM
kevans closed D36475: arm64, riscv: size boot stacks appropriately.
Thu, Sep 8, 5:03 AM
kevans updated the diff for D36490: stand: i386: take into account disk sector size for blk calculation.

Simplify, just divide; bd_sectorsize should always be a multiple of 512.

Thu, Sep 8, 1:34 AM
kevans requested review of D36490: stand: i386: take into account disk sector size for blk calculation.
Thu, Sep 8, 12:37 AM

Wed, Sep 7

kevans updated the diff for D36475: arm64, riscv: size boot stacks appropriately.

Missed one error condition where we'd kmem_free()

Wed, Sep 7, 5:32 AM
kevans added a reviewer for D36475: arm64, riscv: size boot stacks appropriately: riscv.
Wed, Sep 7, 2:56 AM
kevans requested review of D36475: arm64, riscv: size boot stacks appropriately.
Wed, Sep 7, 2:26 AM

Tue, Sep 6

kevans added inline comments to D36323: split: use a dynamic buffer for -l/-p matching.
Tue, Sep 6, 11:16 PM

Sep 2 2022

kevans committed rG30d7d06f4f37: Import lua 5.4.3 (authored by kevans).
Import lua 5.4.3
Sep 2 2022, 1:55 AM
kevans committed rG755d9301ca89: Import Lua 5.4.4 (authored by kevans).
Import Lua 5.4.4
Sep 2 2022, 1:55 AM

Sep 1 2022

kevans accepted D36418: lualoader: Add loader_menu_multi_user_prompt config variable.

Seems fine to me, thanks!

Sep 1 2022, 10:52 PM
kevans updated the diff for D36323: split: use a dynamic buffer for -l/-p matching.

Address review commente

Sep 1 2022, 4:47 AM

Aug 29 2022

kevans closed D34344: libc: iconv: add mb_cur_min for encoder traits.
Aug 29 2022, 11:22 PM

Aug 26 2022

kevans added inline comments to D36367: stand: Allow any boot loader to provide entropy.
Aug 26 2022, 8:56 PM

Aug 24 2022

kevans accepted D36301: Add scandirat(3).
Aug 24 2022, 3:19 AM
kevans requested review of D36324: split: add some tests.
Aug 24 2022, 2:21 AM
kevans requested review of D36323: split: use a dynamic buffer for -l/-p matching.
Aug 24 2022, 2:21 AM

Aug 22 2022

kevans accepted D36286: stand: Document EFI consoles.
Aug 22 2022, 3:50 PM

Aug 17 2022

kevans added inline comments to D36187: kern: Support duplicate variables in early kenv.
Aug 17 2022, 3:51 AM
kevans added inline comments to D36187: kern: Support duplicate variables in early kenv.
Aug 17 2022, 3:45 AM
kevans accepted D36187: kern: Support duplicate variables in early kenv.

@kevans On IRC it sounded like you were ok with this -- was that "ok with the concept" or "ok with the code"?

Aug 17 2022, 12:35 AM

Aug 13 2022

kevans accepted D27318: freebsd-version(1): present -v option, to print verbose output.
Approved by: kevans (src)
Aug 13 2022, 3:34 AM
kevans requested review of D36188: libbe: bail out early if the zfs kmod isn't loaded.
Aug 13 2022, 12:22 AM

Aug 11 2022

kevans committed rG693f88c9da8d: iconv_std: complete the //IGNORE support (authored by kevans).
iconv_std: complete the //IGNORE support
Aug 11 2022, 4:44 PM
kevans committed rG2300a22c9712: libc: iconv: add mb_cur_min for encoder traits (authored by kevans).
libc: iconv: add mb_cur_min for encoder traits
Aug 11 2022, 4:44 PM
kevans committed rG814bd1ed438f: tools: test: iconv: fix open_2 to not segfault (authored by kevans).
tools: test: iconv: fix open_2 to not segfault
Aug 11 2022, 4:44 PM
kevans committed rGc1f46b8fcb97: libc: iconv: push option ignore into citrus_iconv_open() (authored by kevans).
libc: iconv: push option ignore into citrus_iconv_open()
Aug 11 2022, 4:44 PM
kevans committed rGea0f37dec65d: iconv: only conditionally use ICONV_SET_DISCARD_ILSEQ (authored by kevans).
iconv: only conditionally use ICONV_SET_DISCARD_ILSEQ
Aug 11 2022, 4:44 PM
kevans closed D34345: iconv_std: complete the //IGNORE support.
Aug 11 2022, 4:44 PM
kevans closed D34343: libc: iconv: push option ignore into citrus_iconv_open().
Aug 11 2022, 4:44 PM
kevans closed D34342: iconv: only conditionally use ICONV_SET_DISCARD_ILSEQ.
Aug 11 2022, 4:44 PM
kevans accepted D36129: stand: impose 510,000 byte limit for /boot/loader and /boot/pxeldr.

LGTM

Aug 11 2022, 12:13 AM