Page MenuHomeFreeBSD

kevans (Kyle Evans)
User

Projects (9)

User Details

User Since
Oct 2 2015, 1:17 PM (437 w, 4 d)

Recent Activity

Sat, Feb 17

kevans added a comment to D43921: pci: avoid accidental clobbering of regs on some fdt platforms.
In D43921#1002445, @jhb wrote:

This is probably fine, but I think you could also just leave the rid member off. I'm working on a series that removes the rid argument from bus_release_resource. My one thought for having the rid in the ranges structure is if we wanted to set the rids and do bus_set_resource in the bus-specific attach routine when the ranges are enumerated, but I'm not sure it's worth moving the code there (where it would have to be duplicated).

Sat, Feb 17, 2:50 AM
kevans updated the diff for D43921: pci: avoid accidental clobbering of regs on some fdt platforms.

Stash the rid off in the pcie_range, use that everywhere after allocation both
for bus_*_resource() APIs bus also to decide if we're skipping an element to
deallocate.

Sat, Feb 17, 12:34 AM

Thu, Feb 15

kevans updated the diff for D43921: pci: avoid accidental clobbering of regs on some fdt platforms.

Add a macro, fixup other places, commentary

Thu, Feb 15, 6:36 PM
kevans requested review of D43921: pci: avoid accidental clobbering of regs on some fdt platforms.
Thu, Feb 15, 5:42 PM
kevans accepted D43908: loader: Move drawer.lua over to gfx table..
Thu, Feb 15, 12:43 AM
kevans accepted D43907: loader: Move gfx functions to gfx.lua.8.
Thu, Feb 15, 12:42 AM
kevans accepted D43906: loader: Move to using linker sets to bring in optional bits.
Thu, Feb 15, 12:41 AM
kevans accepted D43905: loader: Remove gfx_fb_stub.c, it's no longer needed.
Thu, Feb 15, 12:41 AM
kevans accepted D43904: loader: Only create gfx 4th bindings when gfx is available.
Thu, Feb 15, 12:40 AM
kevans accepted D43903: loader: Add prototype for gfx_interp_md.
Thu, Feb 15, 12:40 AM
kevans accepted D43902: loader: Create new gfx table.

Hah

Thu, Feb 15, 12:39 AM
kevans accepted D43901: loader: Separate gfx to a new file..
Thu, Feb 15, 12:38 AM
kevans accepted D43900: loader: Register the gfx stuff separately..
Thu, Feb 15, 12:38 AM

Wed, Feb 14

kevans added a comment to D43858: More avoidance of the filtees loading recursion.

hm, I applied this one https://people.freebsd.org/~krion/D43858.diff and it worked

This is definitively different from what I have... but it is also different from what I get displayed here in the review.

Wed, Feb 14, 2:40 PM
kevans added inline comments to D43872: flua: Add hash module.
Wed, Feb 14, 3:43 AM

Tue, Feb 13

kevans committed rG16eebc4e19de: caroot: routine update (authored by kevans).
caroot: routine update
Tue, Feb 13, 8:35 PM
kevans committed rG9fc1d78e39d5: caroot: routine update (authored by kevans).
caroot: routine update
Tue, Feb 13, 7:17 PM
kevans committed rG9b7611d9c7b4: caroot: routine update (authored by kevans).
caroot: routine update
Tue, Feb 13, 7:16 PM
kevans requested review of D43869: crunchgen: slap a dependency on the generated makefile for .lo.
Tue, Feb 13, 7:04 PM
kevans committed rGc5796f1572c8: rtld: add some dlopen tests (authored by kevans).
rtld: add some dlopen tests
Tue, Feb 13, 3:39 PM
kevans closed D43859: rtld: add some dlopen tests.
Tue, Feb 13, 3:39 PM
kevans added a comment to D43859: rtld: add some dlopen tests.
In D43859#1000568, @kib wrote:

How fresh are processes where ATF executes tests? Would both dlopen_basic and dlopen_recursing execute in the same image sequentially, or ATF spawns/execs a new process to run each test?

Tue, Feb 13, 3:55 AM
kevans added a comment to D43858: More avoidance of the filtees loading recursion.

Relevant test in https://reviews.freebsd.org/D43859

Tue, Feb 13, 2:31 AM
kevans requested review of D43859: rtld: add some dlopen tests.
Tue, Feb 13, 2:31 AM

Mon, Feb 12

kevans accepted D43810: libsecureboot do not report expected unverified files.

No comment on the veriexec bits (they seem generally sane, but that's your area of course :-)), but the motivation described here:

Mon, Feb 12, 9:49 PM
kevans accepted D43844: rescue: belatedly add zfsbootcfg.
Mon, Feb 12, 5:15 PM
kevans accepted D43831: rescue,nextboot: Install nextboot as a link to reboot, rm nextboot.sh.
Mon, Feb 12, 5:14 PM
kevans accepted D43843: rescue: Update for changes for nextboot.
Mon, Feb 12, 5:14 PM
kevans accepted D43829: reboot: Implement -o to set kernel options for next boot.
Mon, Feb 12, 5:12 PM
kevans accepted D43828: reboot: Implement -k in terms of env.
Mon, Feb 12, 5:11 PM
kevans accepted D43824: reboot: Implement zfs support.
Mon, Feb 12, 5:07 PM
kevans accepted D43823: zfsbootcfg: Remove bogus CFLAGS.
Mon, Feb 12, 5:04 PM
kevans accepted D43803: reboot: Add sanity checking of write to nextboot.conf.
Mon, Feb 12, 4:59 PM
kevans accepted D43802: reboot: Don't reboot if the next kernel isn't there.
Mon, Feb 12, 4:57 PM
kevans accepted D43801: reboot: convert flags to bools.
Mon, Feb 12, 4:56 PM
kevans accepted D43800: reboot: Disallow -k and -r, it doesn't make sense..
Mon, Feb 12, 4:55 PM

Sun, Feb 11

kevans committed rG0d3b2bdbf719: caroot: routine update (authored by kevans).
caroot: routine update
Sun, Feb 11, 6:36 AM

Fri, Feb 9

kevans requested review of D43799: [RFC] ktrace: log genio events on failed write.
Fri, Feb 9, 4:21 AM
kevans accepted D43701: loader: Document the lua loader table..

LGTM, thanks!

Fri, Feb 9, 3:32 AM

Wed, Feb 7

kevans committed rGba90708fb116: kern: tty: fix ttyinq_read_uio assertion (authored by kevans).
kern: tty: fix ttyinq_read_uio assertion
Wed, Feb 7, 5:22 AM

Tue, Feb 6

kevans committed rGa8aa5ba3db69: kern: tty: fix ttyinq_read_uio assertion (authored by kevans).
kern: tty: fix ttyinq_read_uio assertion
Tue, Feb 6, 6:11 PM
kevans committed rG81ef0de636ff: kern: tty: fix ttyinq_read_uio assertion (authored by kevans).
kern: tty: fix ttyinq_read_uio assertion
Tue, Feb 6, 6:11 PM

Wed, Jan 31

kevans committed rGc0565e7d34ac: Create namespace for the symbols added during 15-CURRENT cycle (authored by yuripv).
Create namespace for the symbols added during 15-CURRENT cycle
Wed, Jan 31, 7:15 AM

Tue, Jan 30

kevans committed rG050b4db5a8c1: kern: tty: recanonicalize the buffer on ICANON/VEOF/VEOL changes (authored by kevans).
kern: tty: recanonicalize the buffer on ICANON/VEOF/VEOL changes
Tue, Jan 30, 5:12 PM
kevans committed rG984128ce2d5e: kern: pts: do not special case closed slave side (authored by kevans).
kern: pts: do not special case closed slave side
Tue, Jan 30, 5:12 PM
kevans committed rGaebaa32c3108: kern: pts: do not special case closed slave side (authored by kevans).
kern: pts: do not special case closed slave side
Tue, Jan 30, 5:12 PM
kevans committed rGae7357f2e712: kern: tty: recanonicalize the buffer on ICANON/VEOF/VEOL changes (authored by kevans).
kern: tty: recanonicalize the buffer on ICANON/VEOF/VEOL changes
Tue, Jan 30, 5:12 PM
kevans committed rG8fb7d0ddd3e3: kern: tty: fix EOF handling for canonical reads (authored by kevans).
kern: tty: fix EOF handling for canonical reads
Tue, Jan 30, 5:12 PM
kevans committed rG2a05c2033908: kern: tty: fix EOF handling for canonical reads (authored by kevans).
kern: tty: fix EOF handling for canonical reads
Tue, Jan 30, 5:12 PM
kevans committed rGc0c932b27f95: wg: detach bpf upon destroy as well (authored by aly_aaronly.me).
wg: detach bpf upon destroy as well
Tue, Jan 30, 5:43 AM
kevans committed rGb0fa37f356fd: if_wg: fix access to noise_local->l_has_identity and l_private (authored by aly_aaronly.me).
if_wg: fix access to noise_local->l_has_identity and l_private
Tue, Jan 30, 5:42 AM
kevans committed rG86986d381072: if_wg: fix erroneous calculation in calculate_padding() for p_mtu == 0 (authored by aly_aaronly.me).
if_wg: fix erroneous calculation in calculate_padding() for p_mtu == 0
Tue, Jan 30, 5:42 AM
kevans committed rG3deeb70f7f70: wg: detach bpf upon destroy as well (authored by aly_aaronly.me).
wg: detach bpf upon destroy as well
Tue, Jan 30, 5:41 AM
kevans committed rGce2d249b2070: if_wg: fix access to noise_local->l_has_identity and l_private (authored by aly_aaronly.me).
if_wg: fix access to noise_local->l_has_identity and l_private
Tue, Jan 30, 5:40 AM
kevans committed rGbbda52e814e0: if_wg: fix erroneous calculation in calculate_padding() for p_mtu == 0 (authored by aly_aaronly.me).
if_wg: fix erroneous calculation in calculate_padding() for p_mtu == 0
Tue, Jan 30, 5:40 AM

Mon, Jan 29

kevans accepted D43652: open(2): describe *at behavior for dirfd opened without O_SEARCH.
Mon, Jan 29, 7:38 PM

Fri, Jan 26

kevans accepted D43591: libbe: handle destroying/renaming temporary/bootonce boot environments.

Thanks!

Fri, Jan 26, 4:28 PM

Thu, Jan 25

kevans accepted D43565: kern_jail: add security.jail.children.max and .cur sysctl.

Is the plan still to use JAIL_MAX in the test work, or to switch to this since tests can be executed started in non-prison0?

Thu, Jan 25, 10:36 PM
kevans added inline comments to D43591: libbe: handle destroying/renaming temporary/bootonce boot environments.
Thu, Jan 25, 10:33 PM
kevans added inline comments to D43591: libbe: handle destroying/renaming temporary/bootonce boot environments.
Thu, Jan 25, 10:23 PM
kevans added a comment to D43591: libbe: handle destroying/renaming temporary/bootonce boot environments.

Seems to LGTM. At some point we may want to update lbh->bootonce as new environments are activated/deactivated, but this is sufficient for bectl's needs and we don't really make many guarantees about the caching (or lack thereof) that occurs in the handle today, IIRC.

Thu, Jan 25, 5:04 PM
kevans added a comment to D43591: libbe: handle destroying/renaming temporary/bootonce boot environments.

Can you add a test for this in sbin/bectl/tests/bectl_test.sh as well, please? Presumably you could use zfsbootcfg -z rather than checking the bectl list output.

Thu, Jan 25, 4:10 PM
kevans committed R11:0932dd4166fd: sysutils/orch: update to v0.2 (authored by kevans).
sysutils/orch: update to v0.2
Thu, Jan 25, 4:47 AM

Wed, Jan 24

kevans committed rG5738d741fb79: kern: tty: fix recanonicalization (authored by kevans).
kern: tty: fix recanonicalization
Wed, Jan 24, 7:49 PM
kevans committed rG009db0d40c6a: ncurses: serialize the tinfo build a little bit (authored by kevans).
ncurses: serialize the tinfo build a little bit
Wed, Jan 24, 5:02 AM
kevans closed D43540: ncurses: serialize the tinfo build a little bit.
Wed, Jan 24, 5:01 AM

Mon, Jan 22

kevans committed rG7b48fa60a578: bhyveload(8): document some SECURITY CONSIDERATIONS (authored by kevans).
bhyveload(8): document some SECURITY CONSIDERATIONS
Mon, Jan 22, 5:33 PM
kevans committed rG6b23df1a398f: bhyveload: add CAP_SEEK to our dirfd rights (authored by kevans).
bhyveload: add CAP_SEEK to our dirfd rights
Mon, Jan 22, 5:33 PM
kevans committed rG979c1cdb405d: bhyveload: make error printing consistent (authored by kevans).
bhyveload: make error printing consistent
Mon, Jan 22, 5:33 PM
kevans committed rG482ab31c64cd: bhyveload: support guest rebooting from the loader (authored by kevans).
bhyveload: support guest rebooting from the loader
Mon, Jan 22, 5:33 PM
kevans committed rG20e06202f126: bhyveload: limit rights on the dirfds we create (authored by kevans).
bhyveload: limit rights on the dirfds we create
Mon, Jan 22, 5:33 PM
kevans committed rGc6989de2e700: bhyveload: enter capability mode after we setup the vcpu (authored by kevans).
bhyveload: enter capability mode after we setup the vcpu
Mon, Jan 22, 5:33 PM
kevans committed rGb7390f6f8412: bhyveload: hold /boot and do relative lookups for the loader (authored by kevans).
bhyveload: hold /boot and do relative lookups for the loader
Mon, Jan 22, 5:33 PM
kevans committed rGdee3902d1eda: bhyveload(8): document some SECURITY CONSIDERATIONS (authored by kevans).
bhyveload(8): document some SECURITY CONSIDERATIONS
Mon, Jan 22, 5:32 PM
kevans committed rGa95fbd3da860: bhyveload: add CAP_SEEK to our dirfd rights (authored by kevans).
bhyveload: add CAP_SEEK to our dirfd rights
Mon, Jan 22, 5:32 PM
kevans committed rG7b74346b7d34: bhyveload: make error printing consistent (authored by kevans).
bhyveload: make error printing consistent
Mon, Jan 22, 5:32 PM
kevans committed rG3b01995df47a: bhyveload: support guest rebooting from the loader (authored by kevans).
bhyveload: support guest rebooting from the loader
Mon, Jan 22, 5:31 PM
kevans committed rG4bd568bd759b: bhyveload: limit rights on the dirfds we create (authored by kevans).
bhyveload: limit rights on the dirfds we create
Mon, Jan 22, 5:31 PM
kevans committed rG097d8306bfba: bhyveload: enter capability mode after we setup the vcpu (authored by kevans).
bhyveload: enter capability mode after we setup the vcpu
Mon, Jan 22, 5:31 PM
kevans committed rG3299277af825: bhyveload: hold /boot and do relative lookups for the loader (authored by kevans).
bhyveload: hold /boot and do relative lookups for the loader
Mon, Jan 22, 5:31 PM
kevans committed rG43be2d7aaf25: wg: detach bpf upon destroy as well (authored by aly_aaronly.me).
wg: detach bpf upon destroy as well
Mon, Jan 22, 4:24 PM

Jan 22 2024

kevans requested review of D43540: ncurses: serialize the tinfo build a little bit.
Jan 22 2024, 3:24 AM

Jan 19 2024

kevans committed R11:3a26999f32da: sysutils/orch: pull in some patches following portability testing (authored by kevans).
sysutils/orch: pull in some patches following portability testing
Jan 19 2024, 5:08 PM

Jan 18 2024

kevans accepted D43490: arm64: fix the handling of DDB symbols in early boot.

whoops

Jan 18 2024, 4:19 PM
kevans committed R11:c721369988fc: sysutils/orch: add a new port for program orchestration (authored by kevans).
sysutils/orch: add a new port for program orchestration
Jan 18 2024, 2:35 AM

Jan 17 2024

kevans committed rG7a4d1d1df0b2: if_wg: fix access to noise_local->l_has_identity and l_private (authored by aly_aaronly.me).
if_wg: fix access to noise_local->l_has_identity and l_private
Jan 17 2024, 11:31 PM
kevans committed rGb891f61ef538: if_wg: fix erroneous calculation in calculate_padding() for p_mtu == 0 (authored by aly_aaronly.me).
if_wg: fix erroneous calculation in calculate_padding() for p_mtu == 0
Jan 17 2024, 11:31 PM
kevans accepted D43476: sys/jail.h: expose JAIL_MAX constant to applications.

I don't have any technical objection to it, though I do wonder now that I'm looking at it if we want to consider breaking this out as a rdonly sysctl instead. I'm somewhat wondering if one would have a use in the future to make the overall max tunable (namely, *decreasing* the max # jails for some reason).

Jan 17 2024, 4:46 PM
kevans committed R9:b5593e192e29: pgpkeys: renew kevans' key (authored by kevans).
pgpkeys: renew kevans' key
Jan 17 2024, 5:36 AM

Jan 16 2024

kevans resigned from D41318: Add the "missing" WireGuard rc.d script.

Resigning from this; I tried to provide feedback over IRC, but that was seemingly not well-received (and questions unanswered) and I'm not interested in reviewing this as-is. I'd much prefer splitting it into two scripts, one with, e.g., verbs, that manages wireguard interfaces and then the rc script that simply drives that in an obvious way. The last objection I heard was that there's too much state to pass around, but it's not at all clear why unless this is trying to mix way too much rc.conf configuration in with wg config.

Jan 16 2024, 4:15 PM · manpages, rc, network
kevans added inline comments to D43465: usb: if_ure: stop touching the mbuf accounting on rxq insertion.
Jan 16 2024, 3:02 PM
kevans added inline comments to D43465: usb: if_ure: stop touching the mbuf accounting on rxq insertion.
Jan 16 2024, 6:49 AM
kevans requested review of D43465: usb: if_ure: stop touching the mbuf accounting on rxq insertion.
Jan 16 2024, 6:46 AM
kevans closed D43457: kern: pts: do not special case closed slave side.
Jan 16 2024, 2:58 AM
kevans committed rG30189156d325: kern: pts: do not special case closed slave side (authored by kevans).
kern: pts: do not special case closed slave side
Jan 16 2024, 2:58 AM
kevans closed D43456: kern: tty: recanonicalize the buffer on ICANON/VEOF/VEOL changes.
Jan 16 2024, 2:58 AM
kevans committed rG522083ffbd1a: kern: tty: recanonicalize the buffer on ICANON/VEOF/VEOL changes (authored by kevans).
kern: tty: recanonicalize the buffer on ICANON/VEOF/VEOL changes
Jan 16 2024, 2:58 AM
kevans closed D43378: kern: tty: fix EOF handling for canonical reads.
Jan 16 2024, 2:57 AM
kevans committed rGd51dac5f1370: kern: tty: fix EOF handling for canonical reads (authored by kevans).
kern: tty: fix EOF handling for canonical reads
Jan 16 2024, 2:57 AM
kevans closed D43377: kern: tty: fix ttyinq_read_uio assertion.
Jan 16 2024, 2:57 AM