Page MenuHomeFreeBSD

kevans (Kyle Evans)
User

Projects

User Details

User Since
Oct 2 2015, 1:17 PM (235 w, 2 d)

Recent Activity

Today

kevans committed rS359642: adduser: allow standard IFS characters in passwords.
adduser: allow standard IFS characters in passwords
Sun, Apr 5, 7:26 PM
kevans closed D24292: Don't remove leading or trailing IFS for passwords.
Sun, Apr 5, 7:26 PM

Yesterday

kevans committed rP530711: MFH: r530709.
MFH: r530709
Sat, Apr 4, 7:02 PM
kevans closed D24260: emulators/virtualbox-ose-{additions,kmod}: Remove missing patch.
Sat, Apr 4, 7:01 PM
kevans committed rP530709: emulators/virtualbox-ose-{additions,kmod}: Remove missing patch.
emulators/virtualbox-ose-{additions,kmod}: Remove missing patch
Sat, Apr 4, 7:01 PM
kevans accepted D24292: Don't remove leading or trailing IFS for passwords.

Agreed; will commit this sometime today.

Sat, Apr 4, 3:18 PM
kevans added reviewers for D24291: fix users of cn_flags for 64 bits: kib, markj.
Sat, Apr 4, 2:21 PM
kevans added inline comments to D24288: Allow hostuuid to be preloaded for early-boot use.
Sat, Apr 4, 1:40 PM
kevans created D24288: Allow hostuuid to be preloaded for early-boot use.
Sat, Apr 4, 2:12 AM
kevans updated the test plan for D24260: emulators/virtualbox-ose-{additions,kmod}: Remove missing patch.
Sat, Apr 4, 12:47 AM
kevans accepted D24210: dump/restore: define variables in exactly one compilation unit.

Looks good and compiles with -fno-common. Thanks much!

Sat, Apr 4, 12:02 AM

Fri, Apr 3

kevans added a comment to D24264: llvm: add a build knob for enabling assertions.
In D24264#533992, @dim wrote:

Let's call it MK_LLVM_ASSERTIONS since that is the term used by upstream, even though they only use the NDEBUG macro for it. (Upstream uses the CMake configuration option -DLLVM_ENABLE_ASSERTIONS=On). For the rest I'm fine with this patch.

Fri, Apr 3, 3:38 PM
kevans created D24270: bsd.{files,conf}.mk: remove some complicated logic.
Fri, Apr 3, 1:16 AM

Thu, Apr 2

kevans updated the summary of D24264: llvm: add a build knob for enabling assertions.
Thu, Apr 2, 8:39 PM
kevans created D24264: llvm: add a build knob for enabling assertions.
Thu, Apr 2, 8:34 PM
kevans created D24261: lang/pypy{,3}: Update to 7.3.0 .
Thu, Apr 2, 1:57 PM
kevans updated the summary of D24260: emulators/virtualbox-ose-{additions,kmod}: Remove missing patch.
Thu, Apr 2, 1:23 PM
kevans created D24260: emulators/virtualbox-ose-{additions,kmod}: Remove missing patch.
Thu, Apr 2, 1:23 PM

Tue, Mar 31

kevans added a comment to D24209: dumprestore: extern the instance of union u_spcl.

While u_spcl is used only in dump/tape.c, it is used in four different files in restore and is not meant to be a separate instance in each one. So, you will have to make it an extern in the header file and then declare it in dump/tape.c and restore/dump.c. I prefer that you do it that way as opposed to the much uglier EXTERN approach.

Tue, Mar 31, 12:40 AM
kevans updated the diff for D24209: dumprestore: extern the instance of union u_spcl.
Tue, Mar 31, 12:36 AM

Mon, Mar 30

kevans committed rS359455: flua: follow-up to r359453, don't bother with libedit in bootstrap.
flua: follow-up to r359453, don't bother with libedit in bootstrap
Mon, Mar 30, 8:02 PM
kevans committed rS359453: flua: enable readline bits, courtesy of libedit.
flua: enable readline bits, courtesy of libedit
Mon, Mar 30, 6:43 PM
kevans committed rS359443: MFV r359442: bmake: import -fno-common fix build back from upstream.
MFV r359442: bmake: import -fno-common fix build back from upstream
Mon, Mar 30, 4:22 PM
kevans committed rS359442: bmake: import -fno-common fix build back from upstream.
bmake: import -fno-common fix build back from upstream
Mon, Mar 30, 4:20 PM
kevans committed rS359434: cron: respect PATH from login.conf.
cron: respect PATH from login.conf
Mon, Mar 30, 3:27 AM
kevans closed D23597: Respect PATH from login.conf in cron..
Mon, Mar 30, 3:27 AM
kevans committed rS359433: bmake: fix -fno-common build.
bmake: fix -fno-common build
Mon, Mar 30, 12:07 AM

Sun, Mar 29

kevans committed rS359432: gdb: compile with -fcommon explicitly.
gdb: compile with -fcommon explicitly
Sun, Mar 29, 11:59 PM
kevans committed rS359427: fsck_ffs/fsdb: fix -fno-common build.
fsck_ffs/fsdb: fix -fno-common build
Sun, Mar 29, 8:04 PM
kevans committed rS359425: locate: fix -fno-common build.
locate: fix -fno-common build
Sun, Mar 29, 7:16 PM
kevans committed rS359424: openssh: -fno-common fix from upstream f47d72ddad.
openssh: -fno-common fix from upstream f47d72ddad
Sun, Mar 29, 7:14 PM
kevans committed rS359416: systat: remove redundant definition of kd.
systat: remove redundant definition of kd
Sun, Mar 29, 2:30 AM
kevans committed rS359415: userboot: mark host_fsops as extern.
userboot: mark host_fsops as extern
Sun, Mar 29, 2:29 AM
kevans committed rS359414: iscontrol: move definition of vflag/iscsidev to iscontrol.c.
iscontrol: move definition of vflag/iscsidev to iscontrol.c
Sun, Mar 29, 2:28 AM
kevans committed rS359413: ipfilter: remove duplicate definition of 'thishost'.
ipfilter: remove duplicate definition of 'thishost'
Sun, Mar 29, 2:27 AM

Sat, Mar 28

kevans committed rS359406: telnet: kill off remaining duplicate definition.
telnet: kill off remaining duplicate definition
Sat, Mar 28, 8:43 PM
kevans committed rS359404: Re-apply r359399: telnet -fno-common fix.
Re-apply r359399: telnet -fno-common fix
Sat, Mar 28, 7:44 PM
kevans added a reverting change for rS359399: telnet: remove some duplicate definitions, mark terminaltype extern: rS359403: Revert 359399: telnet -fno-common bits.
Sat, Mar 28, 5:57 PM
kevans committed rS359403: Revert 359399: telnet -fno-common bits.
Revert 359399: telnet -fno-common bits
Sat, Mar 28, 5:57 PM
kevans committed rS359402: MFV r359401: OpenBSM: import ee79d73e8df5: auditreduce: add a zone filter.
MFV r359401: OpenBSM: import ee79d73e8df5: auditreduce: add a zone filter
Sat, Mar 28, 5:37 PM
kevans committed rS359401: OpenBSM: import ee79d73e8df5: auditreduce: add a zone filter.
OpenBSM: import ee79d73e8df5: auditreduce: add a zone filter
Sat, Mar 28, 5:35 PM
kevans committed rS359400: MFC r359072-r359073: loader: Add a "kernel.loaded" hook.
MFC r359072-r359073: loader: Add a "kernel.loaded" hook
Sat, Mar 28, 5:12 PM
kevans committed rS359399: telnet: remove some duplicate definitions, mark terminaltype extern.
telnet: remove some duplicate definitions, mark terminaltype extern
Sat, Mar 28, 5:06 PM
kevans committed rS359398: sh: remove duplicate el definition.
sh: remove duplicate el definition
Sat, Mar 28, 5:02 PM
kevans committed rS359397: zfs: fix -fno-common issues.
zfs: fix -fno-common issues
Sat, Mar 28, 5:00 PM
kevans created D24210: dump/restore: define variables in exactly one compilation unit.
Sat, Mar 28, 3:29 PM
kevans created D24209: dumprestore: extern the instance of union u_spcl.
Sat, Mar 28, 3:23 PM
kevans committed rS359394: MFV r359393: tcsh: import 6974bc35a5cd.
MFV r359393: tcsh: import 6974bc35a5cd
Sat, Mar 28, 3:01 PM
kevans committed rS359393: tcsh: import 6974bc35a5cd.
tcsh: import 6974bc35a5cd
Sat, Mar 28, 2:58 PM
kevans committed rS359389: config(8): fixes for -fno-common.
config(8): fixes for -fno-common
Sat, Mar 28, 4:02 AM
kevans committed rS359388: gas: mark dwarf2_loc_mark_labels as extern.
gas: mark dwarf2_loc_mark_labels as extern
Sat, Mar 28, 3:59 AM

Wed, Mar 25

kevans committed rS359290: MFC r358553: hexdump: tests: take into account byte order.
MFC r358553: hexdump: tests: take into account byte order
Wed, Mar 25, 12:32 AM

Mon, Mar 23

kevans committed rS359243: bsdbox: remove useless linking against libl.
bsdbox: remove useless linking against libl
Mon, Mar 23, 2:54 PM
kevans added a comment to D24159: pkgbase: Move device.hints from the runtime to the bootloader package.

not related to you, but it seems a bit odd that /boot/device.hints is installed by /etc/Makefile

Mon, Mar 23, 1:03 PM

Wed, Mar 18

kevans accepted D24115: loader: Add a "kernel.loaded" hook.
Wed, Mar 18, 3:21 PM
kevans committed rP528622: MFH: r528547.
MFH: r528547
Wed, Mar 18, 1:58 AM
kevans committed rS359059: MFC r358993: libssp: don't compile with -fstack-protector*.
MFC r358993: libssp: don't compile with -fstack-protector*
Wed, Mar 18, 1:55 AM

Tue, Mar 17

kevans accepted D24090: Add an internal liblua and use it in flua..

Seems to LGTM.

Tue, Mar 17, 3:51 PM

Mon, Mar 16

kevans committed rP528547: sysutils/u-boot-rpi{3,4}: Add patch to fix PSCI stub reservation.
sysutils/u-boot-rpi{3,4}: Add patch to fix PSCI stub reservation
Mon, Mar 16, 9:33 PM
kevans closed D24085: sysutils/u-boot-rpi{3,4}: Add patch to fix PSCI stub reservation.
Mon, Mar 16, 9:33 PM
kevans updated the summary of D24085: sysutils/u-boot-rpi{3,4}: Add patch to fix PSCI stub reservation.
Mon, Mar 16, 2:24 AM
kevans added a comment to D24085: sysutils/u-boot-rpi{3,4}: Add patch to fix PSCI stub reservation.

Does this need MFH'ing?

Mon, Mar 16, 2:24 AM
kevans added 1 blocking reviewer(s) for D24085: sysutils/u-boot-rpi{3,4}: Add patch to fix PSCI stub reservation: manu.

Add maintainers for non-blanket (not implicitly approved) changes as blocking reviewers, eg: if @bapt and @manu are uboot@.
When you add a user as a reviewer, there's two entries per user, add as a reviewer and add as a blocking reviewer

Mon, Mar 16, 2:04 AM
kevans created D24085: sysutils/u-boot-rpi{3,4}: Add patch to fix PSCI stub reservation.
Mon, Mar 16, 1:57 AM

Sat, Mar 14

kevans committed rS358993: libssp: don't compile with -fstack-protector*.
libssp: don't compile with -fstack-protector*
Sat, Mar 14, 3:15 PM

Fri, Mar 13

kevans accepted D24036: Provide chmod to flua.

LGTM

Fri, Mar 13, 2:29 AM

Thu, Mar 12

kevans committed rP528259: MFH: r528258.
MFH: r528258
Thu, Mar 12, 12:45 AM
kevans committed rP528258: emulators/virtualbox-ose: use contemporary GCC instead of old llvm.
emulators/virtualbox-ose: use contemporary GCC instead of old llvm
Thu, Mar 12, 12:42 AM
kevans closed D23967: emulators/virtualbox-ose: use contemporary GCC instead of old llvm.
Thu, Mar 12, 12:42 AM

Wed, Mar 11

kevans added a comment to D21805: freebsd-update: rehash certs as needed.

Is this stalled?

Wed, Mar 11, 8:28 PM
kevans updated the summary of D23967: emulators/virtualbox-ose: use contemporary GCC instead of old llvm.
Wed, Mar 11, 1:26 PM
kevans updated the diff for D23967: emulators/virtualbox-ose: use contemporary GCC instead of old llvm.

s/9/any/

Wed, Mar 11, 1:19 PM

Tue, Mar 10

kevans committed rS358847: Remove tre from the vendor tree.
Remove tre from the vendor tree
Tue, Mar 10, 4:36 PM
kevans added a comment to D23204: Use Clang and LLD as the default toolchain for MIPS.

llvm 10 landing date seems to be tentatively scheduled for today-ish. \o/

Tue, Mar 10, 1:45 PM

Mar 5 2020

kevans committed rS358687: tftpd: tests: raise targeted cstd to c11.
tftpd: tests: raise targeted cstd to c11
Mar 5 2020, 10:45 PM
kevans added a comment to D23967: emulators/virtualbox-ose: use contemporary GCC instead of old llvm.

USE_GCC= any is not sufficient, as GCC8 doesn't support the feature used by atomic.h.

Gcc 8 should... The docs for gcc 6 introduce the feature, and I specifically tried a test case with gcc 7, although I didn't actually try a kernel build.
https://gcc.gnu.org/onlinedocs/gcc-6.1.0/gcc/Extended-Asm.html#Extended-Asm

Mar 5 2020, 2:02 PM
kevans updated the summary of D23967: emulators/virtualbox-ose: use contemporary GCC instead of old llvm.
Mar 5 2020, 2:02 PM
kevans updated the summary of D23967: emulators/virtualbox-ose: use contemporary GCC instead of old llvm.
Mar 5 2020, 4:28 AM
kevans created D23967: emulators/virtualbox-ose: use contemporary GCC instead of old llvm.
Mar 5 2020, 4:27 AM

Mar 3 2020

kevans added inline comments to D23939: Ensure pkg-devel package is built with default pkg.
Mar 3 2020, 1:38 PM

Mar 2 2020

kevans committed rS358553: hexdump: tests: take into account byte order.
hexdump: tests: take into account byte order
Mar 2 2020, 6:40 PM
kevans closed D23191: hexdump test: take into account byte order.
Mar 2 2020, 6:40 PM · tests
kevans committed rS358549: pkgbase: remove logic for _profile packages.
pkgbase: remove logic for _profile packages
Mar 2 2020, 3:59 PM
kevans added a comment to D16857: Introduce certctl(8).

Can someone tell me when this will land in RELEASE? I have jails running on 12.1-RELASE and can see that it is in STABLE only. 12.2-RELEASE?

Mar 2 2020, 3:23 PM
kevans committed rS358518: elfctl: initialize features.
elfctl: initialize features
Mar 2 2020, 4:22 AM
kevans closed D23842: When generating an cloned interface instance in edsc_clone_create(), generate a random MAC address.
Mar 2 2020, 2:46 AM · network
kevans committed rS358515: if_edsc: generate an arbitrary MAC address.
if_edsc: generate an arbitrary MAC address
Mar 2 2020, 2:46 AM

Feb 28 2020

kevans accepted D23882: Add BSM conversion logic for some jail and setlogin class events.

+1

Feb 28 2020, 11:44 PM
kevans added a reviewer for D23882: Add BSM conversion logic for some jail and setlogin class events: kevans.
Feb 28 2020, 7:48 PM
kevans accepted D23842: When generating an cloned interface instance in edsc_clone_create(), generate a random MAC address.

Seems like a good/sane idea

Feb 28 2020, 7:31 PM · network
kevans committed rP527348: security/luasec: update to 0.9.
security/luasec: update to 0.9
Feb 28 2020, 6:57 PM
kevans closed D23823: security/luasec: update to 0.9.
Feb 28 2020, 6:57 PM
kevans committed rS358442: MFC r357828: interp_lua: fix bogus indentation, NFC.
MFC r357828: interp_lua: fix bogus indentation, NFC
Feb 28 2020, 6:36 PM
kevans committed rS358441: MFC r358091: certctl(8): switch to install(1) to fix DESTDIR support.
MFC r358091: certctl(8): switch to install(1) to fix DESTDIR support
Feb 28 2020, 6:34 PM
kevans added a comment to D16857: Introduce certctl(8).

That all looks fine.
Here are now my questions:

  1. Why has the hash option selected? D16352 uses the common approach to concat PEM files into one PEM bundle which can be easily transported and distributed.
Feb 28 2020, 1:31 PM

Feb 27 2020

kevans added a comment to D23856: graphics/wayland: disable posix_fallocate on FreeBSD < 13.

We could maybe MFC posix_fallocate support for shmfd, but it'd be a little contorted because we can't change struct fileops like we did in head. memfd_create could be MFC'd, but file sealing cannot and I'm not sure we want it if file sealing cannot be supported.

Feb 27 2020, 11:51 PM

Feb 26 2020

kevans committed rS358331: MFC r347515: Catch up with r347241 (if_tuntap rename)..
MFC r347515: Catch up with r347241 (if_tuntap rename).
Feb 26 2020, 1:24 PM

Feb 25 2020

kevans added a comment to D23823: security/luasec: update to 0.9.

Nice review @kevans
Have slave port(s) being checkled/qa'd? (not mentioned in review)?

Feb 25 2020, 1:37 PM

Feb 24 2020

kevans added a comment to D23823: security/luasec: update to 0.9.

Submitter did provide confirmation that it passed testport, but I re-ran it through on -CURRENT/amd64 to sanity check.

Feb 24 2020, 10:01 PM
kevans created D23823: security/luasec: update to 0.9.
Feb 24 2020, 9:59 PM