Page MenuHomeFreeBSD
Feed Advanced Search

Fri, Nov 25

kevans accepted D37482: pkgbase: report errors via metalog reader exit status.
Fri, Nov 25, 3:23 AM

Thu, Nov 24

kevans added inline comments to D37496: flua: add a chown(2) binding.
Thu, Nov 24, 2:03 PM

Wed, Nov 23

kevans added inline comments to D37482: pkgbase: report errors via metalog reader exit status.
Wed, Nov 23, 9:59 PM

Fri, Nov 18

kevans added a comment to D37435: Allow netcat to be a tun tunnel broker.

Just some minor simplifications, I think we can just use tun_fd being a valid fd as an indicator that we should be tunneling instead of tracking that in separate state.

Fri, Nov 18, 5:52 PM

Thu, Nov 17

kevans added inline comments to D37400: wg: Re-add basic if_wg(4) tests..
Thu, Nov 17, 7:04 PM

Wed, Nov 16

kevans added reviewers for D37404: wg.8: Rewrite the manual page: jason_zx2c4.com, emaste, jhb.

Frankly, I'm not comfortable with taking -this- much of a diff without looping in upstream in advance -- the SEE ALSO proposal was reasonable, though. Adding Jason in on this.

Wed, Nov 16, 10:20 PM
kevans committed rGfc8b021e7aaa: share: i18n: fix mismatch in BIG5 esdb generation (authored by kevans).
share: i18n: fix mismatch in BIG5 esdb generation
Wed, Nov 16, 4:11 AM

Sun, Nov 13

kevans committed rG2b20cade1eca: include: put includes into -dev packages (authored by kevans).
include: put includes into -dev packages
Sun, Nov 13, 5:40 AM
kevans committed rGfa4ac142ef99: mktemp: don't double up on trailing slashes for -t paths (authored by kevans).
mktemp: don't double up on trailing slashes for -t paths
Sun, Nov 13, 5:39 AM
kevans committed rGd55f890e012e: wg: drop -Wno-cast-qual from CFLAGS (authored by kevans).
wg: drop -Wno-cast-qual from CFLAGS
Sun, Nov 13, 5:39 AM
kevans committed rG30697383812e: mktemp: add -p/--tmpdir argument (authored by kevans).
mktemp: add -p/--tmpdir argument
Sun, Nov 13, 5:39 AM
kevans committed rG53310486d884: mktemp: add some GNU-compatible long options (authored by kevans).
mktemp: add some GNU-compatible long options
Sun, Nov 13, 5:39 AM
kevans committed rGcd1ebf9c7ee8: usr.bin: hook wg(8) up to the build (authored by kevans).
usr.bin: hook wg(8) up to the build
Sun, Nov 13, 5:39 AM
kevans committed rG08c0976fdce9: Merge commit '93bf91b4012a28610672d2266366dfa0a663b70f' into HEAD (authored by kevans).
Merge commit '93bf91b4012a28610672d2266366dfa0a663b70f' into HEAD
Sun, Nov 13, 5:39 AM
kevans committed rG919fc568b68f: Add 'contrib/wireguard-tools/' from commit… (authored by kevans).
Add 'contrib/wireguard-tools/' from commit…
Sun, Nov 13, 5:39 AM

Sat, Nov 12

kevans requested review of D37374: md5: fix *sum -c with missing files.
Sat, Nov 12, 1:10 AM

Fri, Nov 11

kevans committed rG753a23ac152c: arm64: add a spin-table implementation for Apple Silicon (authored by kevans).
arm64: add a spin-table implementation for Apple Silicon
Fri, Nov 11, 7:51 PM
kevans closed D34661: arm64: add a spin-table implementation for Apple Silicon.
Fri, Nov 11, 7:51 PM
kevans committed rG1a7136cf2942: split: reset errno prior to getline() (authored by sigsys_gmail.com).
split: reset errno prior to getline()
Fri, Nov 11, 6:13 PM
kevans committed rG6b628a694d88: split: add word order fix (authored by kevans).
split: add word order fix
Fri, Nov 11, 6:12 PM
kevans committed rG50b1ea7ea07c: split: add some tests (authored by kevans).
split: add some tests
Fri, Nov 11, 6:12 PM
kevans committed rGf6a842313ca2: split: switch to getline() for line/pattern matching (authored by kevans).
split: switch to getline() for line/pattern matching
Fri, Nov 11, 6:12 PM

Thu, Nov 10

kevans accepted D37334: stand: Remove i386-only support fire firewire.
Thu, Nov 10, 5:54 PM
kevans committed rG8b8babf044ca: include: put includes into -dev packages (authored by kevans).
include: put includes into -dev packages
Thu, Nov 10, 4:22 AM
kevans closed D37256: include: put includes into -dev packages.
Thu, Nov 10, 4:22 AM

Wed, Nov 9

kevans committed rGd22f03636be1: mktemp: skip later TMPDIR check if -p is specified (authored by kevans).
mktemp: skip later TMPDIR check if -p is specified
Wed, Nov 9, 6:05 AM

Sat, Nov 5

kevans added inline comments to D34923: stand: stop using varargs for dv_open() implementations.
Sat, Nov 5, 8:14 PM
kevans added inline comments to D37277: stand: fix usb build.
Sat, Nov 5, 4:17 PM
kevans requested review of D37277: stand: fix usb build.
Sat, Nov 5, 5:50 AM
kevans updated the diff for D34923: stand: stop using varargs for dv_open() implementations.

Address new comments, drop in some XXX notes for future work

Sat, Nov 5, 5:32 AM
kevans requested review of D37276: stand: usb: catch up to DRIVER_MODULE changes in the kernel.
Sat, Nov 5, 5:15 AM
kevans committed rGa28989483e9d: wg: drop -Wno-cast-qual from CFLAGS (authored by kevans).
wg: drop -Wno-cast-qual from CFLAGS
Sat, Nov 5, 3:48 AM
kevans committed rG2cb43631ab12: Merge commit '93bf91b4012a28610672d2266366dfa0a663b70f' into HEAD (authored by kevans).
Merge commit '93bf91b4012a28610672d2266366dfa0a663b70f' into HEAD
Sat, Nov 5, 3:48 AM
kevans committed rG93bf91b4012a: Update wireguard-tools to 139aac59a5ab7 (authored by kevans).
Update wireguard-tools to 139aac59a5ab7
Sat, Nov 5, 3:44 AM
kevans updated the diff for D34923: stand: stop using varargs for dv_open() implementations.

Remove the devdesc arg to dv_open() entirely. f->f_devdata is always a devdesc
for the initial open(), modulo one instance in userboot that calls dv_open()
manually. Adopt it to the new interface like we do in uboot and just fake a
properly constructed struct open_file to pass in.

Sat, Nov 5, 2:55 AM

Thu, Nov 3

kevans requested review of D37256: include: put includes into -dev packages.
Thu, Nov 3, 7:29 PM
kevans closed D37234: emulators/qemu{,70}: enable for aarch64.
Thu, Nov 3, 4:21 AM
kevans committed R11:4b8ac78ce3e2: emulators/qemu{,70}: enable for aarch64 (authored by kevans).
emulators/qemu{,70}: enable for aarch64
Thu, Nov 3, 4:21 AM
kevans committed rGa6346c02f646: mktemp: don't double up on trailing slashes for -t paths (authored by kevans).
mktemp: don't double up on trailing slashes for -t paths
Thu, Nov 3, 2:44 AM

Wed, Nov 2

kevans committed rG501f7030231b: usb: musb_otg_allwinner: de-constify bus_space_tags (authored by mhorne).
usb: musb_otg_allwinner: de-constify bus_space_tags
Wed, Nov 2, 5:05 PM
kevans committed rG9b6930c6eadb: kasan: disable kasan_mark() after a violation (authored by mhorne).
kasan: disable kasan_mark() after a violation
Wed, Nov 2, 5:05 PM
kevans committed rGffcb2897471b: kasan: provide bus peek/poke definitions (authored by mhorne).
kasan: provide bus peek/poke definitions
Wed, Nov 2, 5:05 PM
kevans committed rG0baacb12181a: arm64: fix build without FDT (authored by kevans).
arm64: fix build without FDT
Wed, Nov 2, 5:05 PM
kevans committed rGcd365639563a: extres: regulator: fix the build without FDT (authored by kevans).
extres: regulator: fix the build without FDT
Wed, Nov 2, 5:05 PM
kevans committed rGb2fd407415af: arm64: bus: unhide bus_space definition with sanitizers included (authored by mhorne).
arm64: bus: unhide bus_space definition with sanitizers included
Wed, Nov 2, 5:05 PM
kevans committed rG483b42cee78d: arm64: coresight: fix the build without FDT (authored by kevans).
arm64: coresight: fix the build without FDT
Wed, Nov 2, 5:05 PM
kevans committed rG3c631d2f19cd: extres: syscon: pull in sys/malloc.h (fix !FDT) (authored by kevans).
extres: syscon: pull in sys/malloc.h (fix !FDT)
Wed, Nov 2, 5:05 PM
kevans committed rGaf0995b7f365: uart: uart_cpu_arm64: fix the build without FDT (authored by kevans).
uart: uart_cpu_arm64: fix the build without FDT
Wed, Nov 2, 5:04 PM
kevans committed rGb3ec0abfbf39: arm64: bus: provide bus_space_set_{multi,region}_stream definitions (authored by mhorne).
arm64: bus: provide bus_space_set_{multi,region}_stream definitions
Wed, Nov 2, 5:04 PM
kevans committed rG9c0faaeb1b9c: sysent: regenerate files every time (authored by kevans).
sysent: regenerate files every time
Wed, Nov 2, 5:03 PM
kevans added a comment to D37234: emulators/qemu{,70}: enable for aarch64.

Sigh, typo in the commit message: both result in ARCH=ppc64, as they did before. (not ppc)

Wed, Nov 2, 4:29 AM
kevans requested review of D37234: emulators/qemu{,70}: enable for aarch64.
Wed, Nov 2, 4:13 AM
kevans committed rG4a7fe8305e77: psci: set psci_present as early as possible (authored by kevans).
psci: set psci_present as early as possible
Wed, Nov 2, 4:12 AM

Tue, Nov 1

kevans accepted D37231: arm64: Handle translation faults for thread structures.
Tue, Nov 1, 9:24 PM

Mon, Oct 31

kevans committed rGac6f924e1cd1: mktemp: add -p/--tmpdir argument (authored by kevans).
mktemp: add -p/--tmpdir argument
Mon, Oct 31, 3:57 AM
kevans closed D37121: mktemp: add -p/--tmpdir argument.
Mon, Oct 31, 3:56 AM
kevans closed D37120: mktemp: add some GNU-compatible long options.
Mon, Oct 31, 3:56 AM
kevans committed rGcfc57d7dbe5b: mktemp: add some GNU-compatible long options (authored by kevans).
mktemp: add some GNU-compatible long options
Mon, Oct 31, 3:56 AM

Sat, Oct 29

kevans closed D36952: Import & build wg(8).
Sat, Oct 29, 3:27 AM
kevans accepted D36952: Import & build wg(8).

Bah, sorry, I suck. Manually related the commits in after committing it just a bit ago; closing.

Sat, Oct 29, 3:27 AM
kevans committed rG028382670670: usr.bin: hook wg(8) up to the build (authored by kevans).
usr.bin: hook wg(8) up to the build
Sat, Oct 29, 3:11 AM
kevans committed rGadf376485712: Add 'contrib/wireguard-tools/' from commit… (authored by kevans).
Add 'contrib/wireguard-tools/' from commit…
Sat, Oct 29, 3:11 AM
kevans committed rG7e00bf8773b9: Import wireguard-tools for wg(8) (authored by kevans).
Import wireguard-tools for wg(8)
Sat, Oct 29, 3:04 AM

Fri, Oct 28

kevans updated the diff for D36952: Import & build wg(8).

One final update; re-scope wg import down to both src/ and .gitignore a bunch of files that we don't need (many with GPL-2-only, just to avoid false-positives of folks scanning the tree and wondering if we use those)

Fri, Oct 28, 9:54 PM
kevans added inline comments to D37083: top: fix sorting by pid (-o pid).
Fri, Oct 28, 4:00 PM

Oct 27 2022

kevans updated the diff for D34661: arm64: add a spin-table implementation for Apple Silicon.

Toss in a barrier prior to wakeup; perhaps paranoid, but it seems like a
reasonable concern

Oct 27 2022, 9:23 PM
kevans accepted D37182: script: Handle a missing 's' stamp gracefully..

Yup, LGTM!

Oct 27 2022, 8:10 PM
kevans accepted D37177: script: Use size_t / ssize_t where needed. script: Further usage string nits..
Oct 27 2022, 7:46 PM
kevans committed rG172be8642d93: split: reset errno prior to getline() (authored by sigsys_gmail.com).
split: reset errno prior to getline()
Oct 27 2022, 5:20 PM
kevans accepted D37178: Stop building FDT-only modules in an ACPI only kernel.
Oct 27 2022, 5:16 PM
kevans closed D36776: arm64: add a std.aws config.
Oct 27 2022, 3:40 PM
kevans committed rG60c96dbf20da: arm64: add a std.ec2 config (authored by kevans).
arm64: add a std.ec2 config
Oct 27 2022, 3:40 PM
kevans updated the diff for D37121: mktemp: add -p/--tmpdir argument.

Empty -p flag should be treated the same as an omitted --tmpdir to actually be
compatible; fixed this omission, updated the manpage appropriately and added
a test for that specific scenario.

Oct 27 2022, 3:30 PM
kevans added a comment to D37121: mktemp: add -p/--tmpdir argument.

I tried to compile the new feature. But the patch failed. Is the patch up-to-date for -current?

I was previously synced to rGed5e7fb16c by mistake, but I rebased this branch to rG866beaa0aa9 and it still builds OK here -- what does the failure look like?

curl -L -o diff 'https://reviews.freebsd.org/D37121?download=true'

% Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                               Dload  Upload   Total   Spent    Left  Speed
0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0

100 8388 0 8388 0 0 13312 0 --:--:-- --:--:-- --:--:-- 721k
wosch@cloud2.dev <06:08:21> 14.0-CURRENT [~/projects/src] 508
bash$ patch -p1 < diff
Hmm... Looks like a unified diff to me...

The text leading up to this was:

diff --git a/etc/mtree/BSD.tests.dist b/etc/mtree/BSD.tests.dist
--- a/etc/mtree/BSD.tests.dist
+++ b/etc/mtree/BSD.tests.dist

Patching file etc/mtree/BSD.tests.dist using Plan A...
Hunk #1 succeeded at 1060 (offset 2 lines).
Hmm... The next patch looks like a unified diff to me...

The text leading up to this was:

diff --git a/usr.bin/mktemp/Makefile b/usr.bin/mktemp/Makefile
--- a/usr.bin/mktemp/Makefile
+++ b/usr.bin/mktemp/Makefile

Patching file usr.bin/mktemp/Makefile using Plan A...
Hunk #1 succeeded at 1.
Hmm... The next patch looks like a unified diff to me...

The text leading up to this was:

diff --git a/usr.bin/mktemp/mktemp.1 b/usr.bin/mktemp/mktemp.1
--- a/usr.bin/mktemp/mktemp.1
+++ b/usr.bin/mktemp/mktemp.1

Patching file usr.bin/mktemp/mktemp.1 using Plan A...
Hunk #1 succeeded at 37.
Hunk #2 succeeded at 93.
Hunk #3 failed at 146.
1 out of 3 hunks failed--saving rejects to usr.bin/mktemp/mktemp.1.rej
Hmm... The next patch looks like a unified diff to me...

The text leading up to this was:

diff --git a/usr.bin/mktemp/mktemp.c b/usr.bin/mktemp/mktemp.c
--- a/usr.bin/mktemp/mktemp.c
+++ b/usr.bin/mktemp/mktemp.c

Patching file usr.bin/mktemp/mktemp.c using Plan A...
Hunk #1 succeeded at 38 with fuzz 2 (offset -1 lines).
Hunk #2 failed at 53.
Hunk #3 failed at 63.
Hunk #4 succeeded at 103 (offset -7 lines).
Hunk #5 succeeded at 145 (offset -1 lines).
Hunk #6 succeeded at 183 (offset -7 lines).
2 out of 6 hunks failed--saving rejects to usr.bin/mktemp/mktemp.c.rej

Oct 27 2022, 6:18 AM
kevans added a comment to D37121: mktemp: add -p/--tmpdir argument.

I tried to compile the new feature. But the patch failed. Is the patch up-to-date for -current?

Oct 27 2022, 5:58 AM
kevans added a comment to D34661: arm64: add a spin-table implementation for Apple Silicon.

With rG866beaa0aa95 this has successfully booted a Raspberry Pi 4 both with our armstub8* that does PSCI and with the upstream stock armstub8*, and we use this actively on M1 WIP as well.

Oct 27 2022, 5:25 AM
kevans committed rG866beaa0aa95: psci: set psci_present as early as possible (authored by kevans).
psci: set psci_present as early as possible
Oct 27 2022, 5:20 AM

Oct 26 2022

kevans updated subscribers of D32936: bsdinstall: use gpt label instead of swap partition name when updating fstab..

The reason we stopped doing this originally, is that if ZFS imports the pool using disk names like /dev/ada0p3, then the GPT label version like /dev/gpt/swap went away, and then you ended up with no swap mounted.
I don't know if things have changed somewhat since when I ran into these problems around 2015. I know there was some work to try to mitigate the issue.

Oct 26 2022, 4:36 AM
kevans accepted D37128: w: Fix premature rounding..
Oct 26 2022, 3:18 AM

Oct 25 2022

kevans committed rG7aaa50c6b583: split: add word order fix (authored by kevans).
split: add word order fix
Oct 25 2022, 9:53 PM
kevans requested review of D37121: mktemp: add -p/--tmpdir argument.
Oct 25 2022, 4:53 PM
kevans requested review of D37120: mktemp: add some GNU-compatible long options.
Oct 25 2022, 4:52 PM
kevans committed rG75c3ca1ebf81: split: add some tests (authored by kevans).
split: add some tests
Oct 25 2022, 3:07 PM
kevans committed rG5c053aa3c5e9: split: switch to getline() for line/pattern matching (authored by kevans).
split: switch to getline() for line/pattern matching
Oct 25 2022, 3:07 PM
kevans closed D36324: split: add some tests.
Oct 25 2022, 3:07 PM
kevans closed D36323: split: switch to getline() for line/pattern matching.
Oct 25 2022, 3:06 PM
kevans committed R11:d41a31aa689e: games/gzdoom: fix runtime against SDL newer than 2.0 (authored by kevans).
games/gzdoom: fix runtime against SDL newer than 2.0
Oct 25 2022, 5:22 AM
kevans committed R11:32b4b09f7dbf: games/gzdoom: fix runtime against SDL newer than 2.0 (authored by kevans).
games/gzdoom: fix runtime against SDL newer than 2.0
Oct 25 2022, 5:03 AM
kevans committed R11:f2e7a18e1789: audio/zmusic: update to 1.1.10 (authored by kevans).
audio/zmusic: update to 1.1.10
Oct 25 2022, 5:03 AM
kevans retitled D36323: split: switch to getline() for line/pattern matching from split: use a dynamic buffer for -l/-p matching to split: switch to getline() for line/pattern matching.
Oct 25 2022, 3:39 AM
kevans updated the diff for D36323: split: switch to getline() for line/pattern matching.

Clean up the diff a bit more; don't rename bfr -> buf for split1(), but maintain
the MAXBSIZE -> sizeof(bfr) change.

Oct 25 2022, 3:38 AM
kevans updated the diff for D36323: split: switch to getline() for line/pattern matching.

Switch to getline() for split2's buffer management, move the global buf/bufsize
into split1() and keep that at MAXBSIZE.

Oct 25 2022, 3:36 AM
kevans accepted D36913: wg: Trim compat shims for versions older than current stable/13..
Oct 25 2022, 1:02 AM
kevans accepted D36912: wg: Retire now unused support.h..
Oct 25 2022, 1:01 AM
kevans accepted D36911: wg: Use zfree..
Oct 25 2022, 1:01 AM
kevans accepted D36910: wg: Use atomic(9) instead of concurrency-kit atomics..
Oct 25 2022, 1:01 AM
kevans accepted D36909: Import the WireGuard driver from zx2c4.com..
Oct 25 2022, 1:00 AM
kevans accepted D36908: Split netinet shell tests into one per line..
Oct 25 2022, 1:00 AM

Oct 24 2022

kevans accepted D37110: acpi_ged: Module build no longer needs to define INTRNG.
Oct 24 2022, 4:49 PM
kevans accepted D37108: config.mk: All options in DEFAULTS are now defined in opt_global.h.
Oct 24 2022, 4:48 PM