Page MenuHomeFreeBSD

emaste (Ed Maste)
UserAdministrator

Projects (10)

User Details

User Since
Nov 24 2013, 3:15 AM (340 w, 2 d)
Roles
Administrator

Recent Activity

Yesterday

emaste committed rS361740: lld: Set DF_1_PIE for -pie.
lld: Set DF_1_PIE for -pie
Tue, Jun 2, 10:57 PM
emaste committed rS361739: llvm: Add DF_1_PIE.
llvm: Add DF_1_PIE
Tue, Jun 2, 10:56 PM
emaste accepted D25086: Do not allow to load ET_DYN object with DF_1_PIE flag set..

This looks reasonable to me. We'll need to bring in a couple of LLVM commits to be able to test.

Tue, Jun 2, 1:07 AM
emaste added a comment to D25086: Do not allow to load ET_DYN object with DF_1_PIE flag set..

Following up after discussions on IRC, the canonical way do do this is:
CFLAGS=-fPIC
LDFLAGS=-pic
or if compiling a test app on the command line,
cc -fPIC -pic ...

Tue, Jun 2, 12:50 AM
emaste committed rS361714: MFC r361657: elf_common.h: define DF_1_PIE.
MFC r361657: elf_common.h: define DF_1_PIE
Tue, Jun 2, 12:49 AM
emaste committed rS361713: bsd.prog.mk: split MK_PIE test for clarity.
bsd.prog.mk: split MK_PIE test for clarity
Tue, Jun 2, 12:46 AM

Mon, Jun 1

emaste added a comment to D25086: Do not allow to load ET_DYN object with DF_1_PIE flag set..

Problem is that all drivers link with crt1.o instead of Scrt1.o. See r200038.

Mon, Jun 1, 7:11 PM
emaste added a comment to D25086: Do not allow to load ET_DYN object with DF_1_PIE flag set..

lld 10 refuses to link with -fPIE -Wl,--pie with errors like

ld: error: cannot preempt symbol: _DYNAMIC
>>> defined in 
>>> referenced by crt1.c:62 (/usr/home/emaste/src/freebsd-svn/head/lib/csu/amd64/crt1.c:62)
>>>               /usr/lib/crt1.o:(_start)
...
Mon, Jun 1, 5:28 PM

Sun, May 31

emaste committed rS361662: readelf: add more DT_FLAGS_1 flags.
readelf: add more DT_FLAGS_1 flags
Sun, May 31, 3:32 PM
emaste accepted D25079: vt(4): reset scrollback and cursor position after clearing history buffer.
Sun, May 31, 12:48 AM

Sat, May 30

emaste committed rS361657: elf_common.h: define DF_1_PIE.
elf_common.h: define DF_1_PIE
Sat, May 30, 7:57 PM
emaste committed rS361656: binutils: build as with BINUTILS || BINUTILS_BOOTSTRAP.
binutils: build as with BINUTILS || BINUTILS_BOOTSTRAP
Sat, May 30, 7:16 PM
emaste committed rS361651: Makefile.inc1: remove BINUTILS_BOOTSTRAP linker support.
Makefile.inc1: remove BINUTILS_BOOTSTRAP linker support
Sat, May 30, 4:20 PM
emaste committed rS361650: Add deprecation notice to WITH_BINUTILS option description.
Add deprecation notice to WITH_BINUTILS option description
Sat, May 30, 4:13 PM
emaste committed rS361649: Add deprecation notice to WITH_BINUTILS option description.
Add deprecation notice to WITH_BINUTILS option description
Sat, May 30, 4:13 PM
emaste committed rS361648: Disable BINUTILS by default on amd64.
Disable BINUTILS by default on amd64
Sat, May 30, 4:12 PM
emaste committed rP537092: databases/memcached: add BUILD_DEPENDS as:devel/binutils.
databases/memcached: add BUILD_DEPENDS as:devel/binutils
Sat, May 30, 4:06 PM
emaste committed rP537091: lang/myrddin: add BUILD_DEPENDS as:devel/binutils.
lang/myrddin: add BUILD_DEPENDS as:devel/binutils
Sat, May 30, 4:02 PM
emaste committed rP537090: net/zerotier: add BUILD_DEPENDS as:devel/binutils.
net/zerotier: add BUILD_DEPENDS as:devel/binutils
Sat, May 30, 4:00 PM
emaste committed rP537089: security/nflib: add BUILD_DEPENDS as:devel/binutils.
security/nflib: add BUILD_DEPENDS as:devel/binutils
Sat, May 30, 3:58 PM
emaste committed rP537088: security/akmos: add BUILD_DEPENDS as:devel/binutils.
security/akmos: add BUILD_DEPENDS as:devel/binutils
Sat, May 30, 3:56 PM
emaste committed rP537087: audio/ardour5: add BUILD_DEPENDS as:devel/binutils.
audio/ardour5: add BUILD_DEPENDS as:devel/binutils
Sat, May 30, 3:53 PM

Fri, May 29

emaste committed rS361629: regen src.conf.5 after BINUTILS changes.
regen src.conf.5 after BINUTILS changes
Fri, May 29, 5:43 PM
emaste committed rS361628: Disable BINUTILS by default on i386.
Disable BINUTILS by default on i386
Fri, May 29, 5:43 PM
emaste added inline comments to D24688: Introduce cap_net a network service for Casper..
Fri, May 29, 3:05 AM
emaste added inline comments to D24688: Introduce cap_net a network service for Casper..
Fri, May 29, 2:56 AM
emaste added inline comments to D24688: Introduce cap_net a network service for Casper..
Fri, May 29, 2:27 AM
emaste committed rP536828: lang/mit-scheme: add BUILD_DEPENDS as:devel/binutils.
lang/mit-scheme: add BUILD_DEPENDS as:devel/binutils
Fri, May 29, 12:22 AM
emaste committed rP536827: lang/ocaml: add BUILD_DEPENDS as:devel/binutils.
lang/ocaml: add BUILD_DEPENDS as:devel/binutils
Fri, May 29, 12:20 AM
emaste committed rP536826: devel/plan9port: add BUILD_DEPENDS as:devel/binutils.
devel/plan9port: add BUILD_DEPENDS as:devel/binutils
Fri, May 29, 12:17 AM
emaste committed rP536825: comms/syncterm: add BUILD_DEPENDS as:devel/binutils.
comms/syncterm: add BUILD_DEPENDS as:devel/binutils
Fri, May 29, 12:15 AM
emaste committed rP536824: comms/libfec: add BUILD_DEPENDS as:devel/binutils.
comms/libfec: add BUILD_DEPENDS as:devel/binutils
Fri, May 29, 12:12 AM

Thu, May 28

emaste added a comment to D25021: Synchronize OpenBSM github repository with the FreeBSD sources.

I'm a little confused, should this not just be a vendor update of OpenBSM? In come circumstances we might cherry-pick an individual fix or two into contrib/, but in general I'd expect to see a wholesale update to a newer release/snapshot.

Thu, May 28, 11:42 PM
Herald added 1 blocking reviewer(s) for D15358: Address memory leak in new reno cc module: transport.

@lstewart sorry I missed your question earlier, but it looks like there was sufficient commentary

Thu, May 28, 11:03 PM
emaste committed rS361607: rename in-tree libevent v1 to libevent1.
rename in-tree libevent v1 to libevent1
Thu, May 28, 10:06 PM
emaste closed D17275: rename in-tree libevent v1 from libevent to libevent1.
Thu, May 28, 10:06 PM
emaste committed rS361596: fortune: remove warning about potentially offensive fortunes.
fortune: remove warning about potentially offensive fortunes
Thu, May 28, 8:39 PM
emaste accepted D24815: vt(4): Add support for `vidcontrol -C'.

I noticed one nit - after clearing history you can press Scroll Lock and scroll up through the cleared history buffer, while we probably want to reset that as well. However, I'd suggest that you commit this now and we can address that in a followup. I also did not check how sc(4) behaves with respect to this.

Thu, May 28, 4:49 PM
emaste added a comment to D23928: Add deprecation notices to ce,cp,mn sync serial drivers.

Some time ago I started a thread on FreeBSD-stable to ask if there are any users and received no responses.

Thu, May 28, 2:40 PM
emaste added a comment to D23928: Add deprecation notices to ce,cp,mn sync serial drivers.

@glebius were you able to find out anything?

Thu, May 28, 2:36 PM

Wed, May 27

emaste added a comment to D25031: [net80211] Fix interrupted scan logic and ticks comparison.

Could make the flags bool instead of int

Wed, May 27, 5:35 PM
emaste committed rS361543: MFC r361292: vt: fix duplicate keymap descriptions.
MFC r361292: vt: fix duplicate keymap descriptions
Wed, May 27, 1:04 AM

Tue, May 26

emaste removed a watcher for wireless: emaste.
Tue, May 26, 12:30 AM
emaste added a member for wireless: emaste.
Tue, May 26, 12:30 AM
emaste added a watcher for wireless: emaste.
Tue, May 26, 12:30 AM

Mon, May 25

emaste abandoned D11394: Disable in-tree binutils bootstrap for powerpc64.

At this point BINUTILS is enabled only on i386 and amd64, BINUTILS_BOOTSTRAP only on amd64.

Mon, May 25, 9:28 PM
emaste accepted D24176: pkgbase: Remove the last users of the FreeBSD-example package.
Mon, May 25, 1:32 PM

Sun, May 24

emaste defrocked rpaulo.
Sun, May 24, 10:41 PM
emaste committed rS361437: Make i386 memstick images bootable..
Make i386 memstick images bootable.
Sun, May 24, 6:26 PM

Fri, May 22

emaste committed rP536203: math/ldouble: add BUILD_DEPENDS as:devel/binutils.
math/ldouble: add BUILD_DEPENDS as:devel/binutils
Fri, May 22, 1:56 PM
emaste committed rP536201: lang/hla: add BUILD_DEPENDS as:devel/binutils.
lang/hla: add BUILD_DEPENDS as:devel/binutils
Fri, May 22, 1:50 PM
emaste committed rS361378: MFS11 r361305 (dteske): bsdinstall: fix wpa_supplicant.conf indentation.
MFS11 r361305 (dteske): bsdinstall: fix wpa_supplicant.conf indentation
Fri, May 22, 12:54 PM
emaste added a comment to D24948: Add btyacc(1) - yacc(1) compiled with backtracking support.

OK, fair enough. Another question, what is the downside of building regular yacc with YYBTYACC?

Fri, May 22, 1:33 AM
emaste added a comment to D24948: Add btyacc(1) - yacc(1) compiled with backtracking support.

Seems reasonable to me, although I'm curious about the use cases

Fri, May 22, 1:25 AM

Thu, May 21

emaste added a comment to D24945: Turn off SSLv3..
In D24945#549333, @jmg wrote:

If you want to test, you generate a self sign cert:

Thu, May 21, 11:27 PM
emaste added inline comments to D24946: Revert to the initial version of D24918.
Thu, May 21, 10:31 PM
emaste accepted D24947: Remove support for SSLv3 from fetch(3).
Thu, May 21, 10:08 PM
emaste added inline comments to D24946: Revert to the initial version of D24918.
Thu, May 21, 7:22 PM
emaste accepted D24945: Turn off SSLv3..
Thu, May 21, 6:01 PM

Wed, May 20

emaste committed rS361304: MFC r361104 (jhibbits): elftoolchain: Add powerpc64 definition.
MFC r361104 (jhibbits): elftoolchain: Add powerpc64 definition
Wed, May 20, 10:19 PM
emaste committed rS361301: MFC r349577 (arichardson): Allow bootstrapping elftoolchain on MacOS and Linux.
MFC r349577 (arichardson): Allow bootstrapping elftoolchain on MacOS and Linux
Wed, May 20, 9:41 PM
emaste committed rS361292: vt: fix duplicate keymap descriptions.
vt: fix duplicate keymap descriptions
Wed, May 20, 8:24 PM
emaste closed D24139: pkgbase: use -dev,-dbg instead of -development,-debug.
Wed, May 20, 7:45 PM
emaste committed rS361290: pkgbase: use -dev,-dbg instead of -development,-debug.
pkgbase: use -dev,-dbg instead of -development,-debug
Wed, May 20, 7:45 PM
emaste requested review of D24933: implement W^X for mmap and mprotect.
Wed, May 20, 6:29 PM
emaste added a comment to D24596: vfs: add restrictions to read(2) of a directory.

I can remove this pre-commit if consensus moves in that direction.

Wed, May 20, 6:05 PM
emaste committed rS361283: src.conf.5: regen after r361282, GNU_DIFF knob descriptions.
src.conf.5: regen after r361282, GNU_DIFF knob descriptions
Wed, May 20, 5:27 PM
emaste committed rS361282: Update GNU_DIFF knob descriptions.
Update GNU_DIFF knob descriptions
Wed, May 20, 5:21 PM
emaste added a comment to D10335: VirtFS/9p filesystem passthrough support (virtio-9p).

Will you refresh this review now that the library is in vendor (and merged to contrib)?

Wed, May 20, 4:40 PM
emaste added a comment to D24596: vfs: add restrictions to read(2) of a directory.
In D24596#547800, @pi wrote:

These types of greps on a linux system return an error message for every directory in the directory you ran the grep in

So if we modify grep to not try to read directories and not spew errors, would that be a solution ?

Wed, May 20, 4:09 PM
emaste accepted D24918: Add load offset value to struct link_map..

This is fine with me

Wed, May 20, 2:37 PM

Tue, May 19

emaste committed rS361269: MFC r357826: elfcopy: set ELF OS/ABI field when converting from binary.
MFC r357826: elfcopy: set ELF OS/ABI field when converting from binary
Tue, May 19, 10:10 PM
emaste added a comment to D24918: Add load offset value to struct link_map..

I do wonder what the impact of changing l_addr would actually be

Tue, May 19, 3:57 PM
emaste committed rS361230: blacklistd.conf.5: typo/grammar fixes.
blacklistd.conf.5: typo/grammar fixes
Tue, May 19, 12:15 AM

Mon, May 18

emaste committed rS361218: GNU as: move deprecation message after option parsing.
GNU as: move deprecation message after option parsing
Mon, May 18, 4:07 PM
emaste added a reviewer for D24883: ldconfig: remove i386 aout invocation: imp.
Mon, May 18, 2:45 PM

Sun, May 17

emaste committed rS361142: MF11 r360876: Merge commit 21e5e1724b75 from llvm git:.
MF11 r360876: Merge commit 21e5e1724b75 from llvm git:
Sun, May 17, 9:30 PM

Sat, May 16

emaste closed D24790: libalias: retire cuseeme support.

rS361099

Sat, May 16, 9:54 PM
emaste committed rS361099: libalias: retire cuseeme support.
libalias: retire cuseeme support
Sat, May 16, 2:29 AM

Fri, May 15

emaste added a comment to D24790: libalias: retire cuseeme support.

We should also check the other modules -- for example, ftp and irc are in common use; I'm not sure off hand what skinny and smedia are.

Fri, May 15, 2:40 PM

Thu, May 14

emaste added inline comments to D21959: introduce new 'ice' driver for Intel E800 Ethernet controllers.
Thu, May 14, 11:27 PM
emaste added a comment to D24805: liblzma: Make liblzma use libmd implementation of SHA256..

Do we need to request an up-to-date exp-run?

Thu, May 14, 9:04 PM
emaste changed the visibility for D24790: libalias: retire cuseeme support.
Thu, May 14, 8:44 PM
emaste committed rS361059: MFC r360594: ipfw: whitespace fix in SCTP_ABORT_ASSOCIATION case statement….
MFC r360594: ipfw: whitespace fix in SCTP_ABORT_ASSOCIATION case statement…
Thu, May 14, 8:44 PM
emaste added a comment to D8188: Introduce lib/libgcc_eh and lib/libgcc_s for LLVM's implementation.

It looks like we should be able to do away with it

Thu, May 14, 8:07 PM
emaste accepted D24596: vfs: add restrictions to read(2) of a directory.
Thu, May 14, 7:46 PM
emaste added a comment to D24815: vt(4): Add support for `vidcontrol -C'.

I will try this out shortly

Thu, May 14, 7:40 PM
emaste accepted D24307: memalign(3).
Thu, May 14, 6:23 PM
emaste committed rS361034: ObsoleteFiles.inc: use date (not xxxx) for ubsec removal.
ObsoleteFiles.inc: use date (not xxxx) for ubsec removal
Thu, May 14, 5:19 PM
emaste added a comment to D24837: Hide host CPUID 0x15 TSC/Crystal ratio/freq info from guest..

Ideally we can get this committed and MFC'd, with a goal of including it in 11.4.

Thu, May 14, 4:48 PM

Wed, May 13

emaste added a comment to D24596: vfs: add restrictions to read(2) of a directory.

Go for it!

Wed, May 13, 10:40 PM
emaste added a comment to D24586: Activate reproducible builds.

Seems reasonable as a first step. Do we address the python issue with this change?

Wed, May 13, 1:03 AM

Tue, May 12

emaste committed rS360996: MFC r359166: objcopy: add new sections also when there is no .shstrtab.
MFC r359166: objcopy: add new sections also when there is no .shstrtab
Tue, May 12, 11:51 PM
emaste committed rS360973: MFC r360968: libalias: fix potential memory disclosure from ftp module.
MFC r360968: libalias: fix potential memory disclosure from ftp module
Tue, May 12, 4:52 PM
emaste committed rS360971: MFC r360967: libalias: validate packet lengths before accessing headers.
MFC r360967: libalias: validate packet lengths before accessing headers
Tue, May 12, 4:49 PM
emaste committed rS360968: libalias: fix potential memory disclosure from ftp module.
libalias: fix potential memory disclosure from ftp module
Tue, May 12, 4:38 PM
emaste committed rS360967: libalias: validate packet lengths before accessing headers.
libalias: validate packet lengths before accessing headers
Tue, May 12, 4:33 PM
emaste added a comment to D24596: vfs: add restrictions to read(2) of a directory.

Further discussion leaves me content with this patch, without a a sysctl to revert to the old behaviour.

Tue, May 12, 4:18 PM
emaste committed rS360947: MFC r360676: elfctl: update earliest FreeBSD revision to 12.2.
MFC r360676: elfctl: update earliest FreeBSD revision to 12.2
Tue, May 12, 1:02 AM

Mon, May 11

emaste accepted D24802: Remove tests for obsolete compilers in the build system.
Mon, May 11, 3:26 PM