emaste (Ed Maste)Administrator
User

Projects (7)

User Details

User Since
Nov 24 2013, 3:15 AM (191 w, 3 d)
Roles
Administrator

Recent Activity

Yesterday

emaste added a comment to D11690: Introduce flopenat(3) function..

Should the man page document AT_FDCWD?

Tue, Jul 25, 9:32 PM
emaste added a comment to D11733: Remove CloudABI Binutils tools..

Sounds good to me.

Tue, Jul 25, 9:23 PM
emaste committed rS321488: readelf: fix printing of DT_FILTER and some other DT_* values.
readelf: fix printing of DT_FILTER and some other DT_* values
Tue, Jul 25, 5:25 PM
emaste accepted D11732: Always set the receive mask in loader.efi.

LGTM

Tue, Jul 25, 4:04 PM
emaste accepted D11698: bsdgrep(1): Don't exit before processing every file.
Tue, Jul 25, 1:07 AM
emaste added a comment to D11719: lib/clang/lldb build warning fixes.

These should be posted upstream at https://reviews.llvm.org/ See https://llvm.org/docs/Phabricator.html for notes on submission - in particular, note the requirement to CC the mailing list with the initial review creation, and include context with the diff.

Tue, Jul 25, 12:52 AM
emaste added inline comments to D11698: bsdgrep(1): Don't exit before processing every file.
Tue, Jul 25, 12:42 AM

Mon, Jul 24

emaste created D11721: bsdinstall: default to UEFI-only boot on arm64.
Mon, Jul 24, 11:42 PM
emaste committed rS321436: ar: handle partial writes from archive_write_data.
ar: handle partial writes from archive_write_data
Mon, Jul 24, 9:26 PM
emaste closed D11715: ar: handle partial writes from archive_write_data by committing rS321436: ar: handle partial writes from archive_write_data.
Mon, Jul 24, 9:26 PM
emaste updated subscribers of D11715: ar: handle partial writes from archive_write_data.
Mon, Jul 24, 8:46 PM
emaste created D11715: ar: handle partial writes from archive_write_data.
Mon, Jul 24, 8:46 PM
emaste committed rS321417: lld 5.0 supports filter libraries, so enable linker feature flag.
lld 5.0 supports filter libraries, so enable linker feature flag
Mon, Jul 24, 3:39 PM

Fri, Jul 21

emaste abandoned D11687: libarchive: ensure ar strtab is null terminated.

This will be fixed via an upstream change and import.

Fri, Jul 21, 3:07 PM
emaste updated subscribers of D11687: libarchive: ensure ar strtab is null terminated.

Upstream pull request at https://github.com/libarchive/libarchive/pull/926

Fri, Jul 21, 12:33 PM
emaste created D11687: libarchive: ensure ar strtab is null terminated.
Fri, Jul 21, 10:41 AM

Thu, Jul 20

emaste accepted D11679: Fix printf format warning in iflib.c.
Thu, Jul 20, 8:08 PM
emaste added a comment to D11679: Fix printf format warning in iflib.c.

What about an (unsigned long) cast and %lu? Since bus_size_t is already unsigned long that seems to be reasonable, and doesn't require an unnecessary 64-bit value on ILP32 archs.

Thu, Jul 20, 8:04 PM
emaste added a comment to D11679: Fix printf format warning in iflib.c.

aside, there's come crazy whitespace going on in iflib.c

Thu, Jul 20, 7:57 PM
emaste accepted D11577: regex(3): Add test to cover recent BRE regression.
Thu, Jul 20, 7:16 PM
emaste committed rS321302: add arm64 objcopy output target for embedfs.
add arm64 objcopy output target for embedfs
Thu, Jul 20, 6:23 PM
emaste committed rS321299: acpidump: add GIC ITS srat type.
acpidump: add GIC ITS srat type
Thu, Jul 20, 5:36 PM
emaste committed rS321298: acpidump: add ACPI NFIT (NVDIMM Firmware Interface Table).
acpidump: add ACPI NFIT (NVDIMM Firmware Interface Table)
Thu, Jul 20, 5:31 PM
emaste closed D11479: Add NFIT tables to `acpidump -t` output by committing rS321298: acpidump: add ACPI NFIT (NVDIMM Firmware Interface Table).
Thu, Jul 20, 5:31 PM
emaste accepted D11479: Add NFIT tables to `acpidump -t` output.
Thu, Jul 20, 5:28 PM
emaste committed rS321294: acpidump: use C99 designated initializers.
acpidump: use C99 designated initializers
Thu, Jul 20, 3:52 PM
emaste closed D11659: Convert existing array entries to designated initializer form by committing rS321294: acpidump: use C99 designated initializers.
Thu, Jul 20, 3:52 PM
emaste accepted D11659: Convert existing array entries to designated initializer form.
Thu, Jul 20, 3:52 PM
emaste committed rS321293: date: avoid crash on invalid time.
date: avoid crash on invalid time
Thu, Jul 20, 3:29 PM
emaste closed D11660: date: avoid crash on invalid time by committing rS321293: date: avoid crash on invalid time.
Thu, Jul 20, 3:29 PM
emaste added a comment to D11653: Use @@@ instead of @@ in __sym_default.

After merging LLVM r308492 to my wip branch (based on FreeBSD's clang500-import branch) the buildworld/buildkernel with this change is successful. If you can merge r308492 to the 5.0 branch we'll bring it into FreeBSD-HEAD from there, and could apply this change later.

Thu, Jul 20, 1:12 PM
emaste added a comment to D11653: Use @@@ instead of @@ in __sym_default.

Oh, wait -- this failure was observed with the FreeBSD clang500-import branch, which has llvm/clang/lld/lldb/compiler-rt/libc++ at upstream r308421.

Thu, Jul 20, 11:15 AM
emaste added a comment to D11653: Use @@@ instead of @@ in __sym_default.

Although I wonder if we shouldn't arrange the build & sys/cdefs.h to activate all of the .symver machinery only for the objects that will be used by the shared lib, excluding it all from libc.a?

Thu, Jul 20, 1:39 AM
emaste added a comment to D11653: Use @@@ instead of @@ in __sym_default.

With this patch my build fails in some applications that link against libc.a.

Thu, Jul 20, 1:16 AM

Wed, Jul 19

emaste added a comment to D11653: Use @@@ instead of @@ in __sym_default.

I have a test universe build running and will commit the change once that finishes.

Wed, Jul 19, 10:59 PM
emaste updated subscribers of D11479: Add NFIT tables to `acpidump -t` output.
Wed, Jul 19, 9:34 PM
emaste added a dependent revision for D11659: Convert existing array entries to designated initializer form: D11479: Add NFIT tables to `acpidump -t` output.
Wed, Jul 19, 9:02 PM
emaste added a dependency for D11479: Add NFIT tables to `acpidump -t` output: D11659: Convert existing array entries to designated initializer form.
Wed, Jul 19, 9:02 PM
emaste updated the diff for D11660: date: avoid crash on invalid time.

correct retypeo from previous upload

Wed, Jul 19, 8:12 PM
emaste updated the diff for D11660: date: avoid crash on invalid time.

check an additional localtime for NULL return

Wed, Jul 19, 8:03 PM
emaste added inline comments to D11660: date: avoid crash on invalid time.
Wed, Jul 19, 7:43 PM
emaste committed rS321226: bsdinstall: improve checksum mismatch error for snapshots.
bsdinstall: improve checksum mismatch error for snapshots
Wed, Jul 19, 6:26 PM
emaste closed D11641: Improved error messages when *.txz checksum failed during installation by committing rS321226: bsdinstall: improve checksum mismatch error for snapshots.
Wed, Jul 19, 6:26 PM
emaste committed rS321218: zfs: Fix a typo in the delay_min_dirty_percent sysctl description.
zfs: Fix a typo in the delay_min_dirty_percent sysctl description
Wed, Jul 19, 6:18 PM
emaste created D11660: date: avoid crash on invalid time.
Wed, Jul 19, 6:08 PM
emaste added a comment to D11653: Use @@@ instead of @@ in __sym_default.

Do you have a doc reference for @@@?

Wed, Jul 19, 4:47 PM
emaste added a comment to D11653: Use @@@ instead of @@ in __sym_default.

Do you have a doc reference for @@@?

Wed, Jul 19, 4:38 PM
emaste updated subscribers of D11653: Use @@@ instead of @@ in __sym_default.
Wed, Jul 19, 4:17 PM
emaste added inline comments to D11641: Improved error messages when *.txz checksum failed during installation.
Wed, Jul 19, 2:25 PM
emaste committed rS321202: MFC r302145: bsdinstall: increase EFI partition size to 200MB.
MFC r302145: bsdinstall: increase EFI partition size to 200MB
Wed, Jul 19, 2:16 PM
emaste committed rS321201: enable pidfile tests on arm64.
enable pidfile tests on arm64
Wed, Jul 19, 2:07 PM
emaste committed rS321200: MFC r313547, r313777: fix mouse selection when vt(4) scrolls.
MFC r313547, r313777: fix mouse selection when vt(4) scrolls
Wed, Jul 19, 1:32 PM
emaste committed rS321199: MFC r313547, r313777: fix mouse selection when vt(4) scrolls.
MFC r313547, r313777: fix mouse selection when vt(4) scrolls
Wed, Jul 19, 1:28 PM
emaste committed rS321198: MFC r303043: Increase vt(4) framebuffer maximum size.
MFC r303043: Increase vt(4) framebuffer maximum size
Wed, Jul 19, 1:11 PM
emaste committed rS321183: MFC r320235: retire arm64 kernel module linker workaround.
MFC r320235: retire arm64 kernel module linker workaround
Wed, Jul 19, 3:20 AM
emaste created D11652: extend "make universe" xtoolchain autodetection.
Wed, Jul 19, 2:12 AM
emaste added a comment to D11633: Include ARCH_FLAGS in CFLAGS when building modules..

It looks like ARCH_FLAGS is used only on MIPS? I'm missing something here since it seems the default MIPS ARCH_FLAGS is set in sys/conf/Makefile.mips, which has CFLAGS+=${EXTRA_FLAGS} $(ARCH_FLAGS)

Wed, Jul 19, 12:23 AM
emaste added inline comments to D11641: Improved error messages when *.txz checksum failed during installation.
Wed, Jul 19, 12:12 AM
emaste added inline comments to D11641: Improved error messages when *.txz checksum failed during installation.
Wed, Jul 19, 12:05 AM

Tue, Jul 18

emaste added inline comments to D11641: Improved error messages when *.txz checksum failed during installation.
Tue, Jul 18, 11:38 PM
emaste committed rS321178: bsdinstall: remove EOL whitespace.
bsdinstall: remove EOL whitespace
Tue, Jul 18, 11:35 PM
emaste committed rP446142: sysutils/py-diffoscope: update to version 84.
sysutils/py-diffoscope: update to version 84
Tue, Jul 18, 1:41 PM

Mon, Jul 17

emaste committed rP446117: sysutils/py-diffoscope: update to version 83.
sysutils/py-diffoscope: update to version 83
Mon, Jul 17, 9:19 PM
emaste updated the diff for D11482: Make compiler-rt's quad-math routines available to libgcc_s.

Just add new symbols to version file -- additional work is required to enable this for amd64, but this should have an effect on arm64 and riscv64.

Mon, Jul 17, 2:28 PM

Sun, Jul 16

emaste added inline comments to D11479: Add NFIT tables to `acpidump -t` output.
Sun, Jul 16, 8:58 PM
emaste committed rS321056: MFC r319890: Correct bitwise test in mac_bsdextended ugidfw_rule_valid().
MFC r319890: Correct bitwise test in mac_bsdextended ugidfw_rule_valid()
Sun, Jul 16, 7:25 PM
emaste committed rS321055: MFC r319890: Correct bitwise test in mac_bsdextended ugidfw_rule_valid().
MFC r319890: Correct bitwise test in mac_bsdextended ugidfw_rule_valid()
Sun, Jul 16, 7:24 PM
emaste committed rS321054: MFC r319516: tsan: set noexec stack on aarch64.
MFC r319516: tsan: set noexec stack on aarch64
Sun, Jul 16, 7:21 PM
emaste committed rS321053: MFC r319219: add a sanity check before installworld on the running system.
MFC r319219: add a sanity check before installworld on the running system
Sun, Jul 16, 7:20 PM
emaste committed rS321052: MFC r320065: arm: add .arch_extension sec for smc instruction.
MFC r320065: arm: add .arch_extension sec for smc instruction
Sun, Jul 16, 7:16 PM
emaste committed rS321049: MFC r320056: arm: set appropriate section flags for .init_pagetable.
MFC r320056: arm: set appropriate section flags for .init_pagetable
Sun, Jul 16, 5:05 PM
emaste committed rS321046: readelf: correct printing of DT_FILTER and DT_AUXILIARY values.
readelf: correct printing of DT_FILTER and DT_AUXILIARY values
Sun, Jul 16, 4:23 PM
emaste committed rS321045: readelf: fix printing of DT_FILTER and some other DT_* values.
readelf: fix printing of DT_FILTER and some other DT_* values
Sun, Jul 16, 12:31 PM

Fri, Jul 14

emaste updated subscribers of D11479: Add NFIT tables to `acpidump -t` output.
Fri, Jul 14, 8:49 PM
emaste committed rS313780: prefix UFS symbols with UFS_ to reduce namespace pollution.
prefix UFS symbols with UFS_ to reduce namespace pollution
Fri, Jul 14, 12:50 PM
emaste closed D9536: prefix UFS symbols with UFS_ to reduce namespace pollution by committing rS313780: prefix UFS symbols with UFS_ to reduce namespace pollution.
Fri, Jul 14, 12:50 PM

Thu, Jul 13

emaste added a comment to D11504: Provide libdl..

What about aux filters ? The patch should be same.

Thu, Jul 13, 2:09 PM
emaste added a comment to D11504: Provide libdl..

Filter support is in review at https://reviews.llvm.org/D35352.

Thu, Jul 13, 1:49 PM

Mon, Jul 10

emaste accepted D11504: Provide libdl..
Mon, Jul 10, 2:34 PM
emaste added inline comments to D11504: Provide libdl..
Mon, Jul 10, 1:46 PM
emaste added inline comments to D11479: Add NFIT tables to `acpidump -t` output.
Mon, Jul 10, 1:12 AM

Sun, Jul 9

emaste committed rS320821: MFC r320069: Add ZFS to Linux statfs ftype.
MFC r320069: Add ZFS to Linux statfs ftype
Sun, Jul 9, 12:25 AM

Fri, Jul 7

emaste accepted D11522: regex(3): Correct branching oversight from rS320742.

Can we add a base test to catch this?

Fri, Jul 7, 6:47 PM
emaste updated subscribers of D11520: monthly.cgi: add warning about using chrome.
Fri, Jul 7, 3:29 PM
emaste created D11520: monthly.cgi: add warning about using chrome.
Fri, Jul 7, 3:27 PM
emaste added inline comments to D11507: Add LLVM's OpenMP 4.0.0 library to the base system.
Fri, Jul 7, 2:34 PM

Thu, Jul 6

emaste accepted D11508: Update copyright e-mail addresses.
Thu, Jul 6, 7:42 PM
emaste added inline comments to D11479: Add NFIT tables to `acpidump -t` output.
Thu, Jul 6, 7:19 PM
emaste accepted D11504: Provide libdl..
Thu, Jul 6, 7:01 PM
emaste accepted D11504: Provide libdl..
Thu, Jul 6, 6:50 PM
emaste added inline comments to D11507: Add LLVM's OpenMP 4.0.0 library to the base system.
Thu, Jul 6, 6:48 PM
emaste added inline comments to D11507: Add LLVM's OpenMP 4.0.0 library to the base system.
Thu, Jul 6, 6:45 PM
emaste committed rS320751: MF11 r320685: Update to ELF Tool Chain snapshot at r3561.
MF11 r320685: Update to ELF Tool Chain snapshot at r3561
Thu, Jul 6, 6:31 PM
emaste accepted D11506: Fix sparc64 libc build after r320742.
Thu, Jul 6, 6:15 PM
emaste added a comment to D11504: Provide libdl..

I think we ought to have some note in dlopen.2 mentioning that libdl is provided for compatibility on FreeBSD but is not needed.

Thu, Jul 6, 5:59 PM
emaste updated subscribers of D11395: bsdgrep(1): Switch src.opts.mk .include to .sinclude for out-of-tree builds.
Thu, Jul 6, 5:22 PM
emaste added inline comments to D11479: Add NFIT tables to `acpidump -t` output.
Thu, Jul 6, 3:00 PM
emaste committed rS320736: acpidump: warn and exit loop on invalid subtable length.
acpidump: warn and exit loop on invalid subtable length
Thu, Jul 6, 2:35 PM
emaste added a comment to D10920: regcomp(3): Refactor and combine top-level expression parsers.

Approved.

Thu, Jul 6, 2:03 PM
emaste committed rS320735: compiler_rt: provide bswap buildins on sparc64.
compiler_rt: provide bswap buildins on sparc64
Thu, Jul 6, 1:27 PM