Page MenuHomeFreeBSD

emaste (Ed Maste)
UserAdministrator

Projects (15)

User Details

User Since
Nov 24 2013, 3:15 AM (561 w, 6 d)
Roles
Administrator

Recent Activity

Thu, Aug 29

emaste accepted D46460: sdiodevs: add more vendors and devices.
Thu, Aug 29, 2:51 PM
emaste added inline comments to D46476: src.conf: Add a MK_ZFS_TESTS knob.
Thu, Aug 29, 2:49 PM
emaste requested review of D46474: UPDATING: remove 20240813 DMAR entry.
Thu, Aug 29, 12:45 PM

Wed, Aug 28

emaste added inline comments to D46384: loader.efi(8): beef up the updating the ESP.
Wed, Aug 28, 10:56 PM
emaste added inline comments to D46384: loader.efi(8): beef up the updating the ESP.
Wed, Aug 28, 10:50 PM

Tue, Aug 27

emaste accepted D46455: tools/sdiodevs2h.awk: introduce palias.

OK

Tue, Aug 27, 10:58 PM
emaste accepted D46463: LinuxKPI: add no_printk.
Tue, Aug 27, 9:57 PM
emaste added a comment to D46463: LinuxKPI: add no_printk.

typo: chekcing

Tue, Aug 27, 9:57 PM
emaste accepted D46462: LinuxKPI: add eth_hdr().
Tue, Aug 27, 9:53 PM
emaste accepted D46461: LinuxKPI: add ENAVAIL error code.

Huh, No XENIX semaphores available. But OK

Tue, Aug 27, 9:51 PM
emaste accepted D46464: LinuxKPI: add get_random_u8().

typo in commit message: "just to e done"

Tue, Aug 27, 9:29 PM
emaste accepted D46454: netinet: Explicitly disallow connections to the unspecified address.
Tue, Aug 27, 8:43 PM
emaste added a comment to D46454: netinet: Explicitly disallow connections to the unspecified address.

What if V_connect_inaddr_wild is true but also CK_STAILQ_EMPTY(&V_in_ifaddrhead)?
I guess ENETUNREACH is sensible in that case as well.

Tue, Aug 27, 7:55 PM

Mon, Aug 26

emaste committed rG85707cfdaddc: bhyve: avoid updating fbaddr when vm_mmap_memseg fails (authored by khorben_defora.org).
bhyve: avoid updating fbaddr when vm_mmap_memseg fails
Mon, Aug 26, 8:26 PM
emaste committed rG27777283da79: ctl: avoid heap info leak in ctl_request_sense (authored by emaste).
ctl: avoid heap info leak in ctl_request_sense
Mon, Aug 26, 6:30 PM
emaste committed rG51768dc31df6: ctl: avoid heap info leak in ctl_request_sense (authored by emaste).
ctl: avoid heap info leak in ctl_request_sense
Mon, Aug 26, 1:29 PM
emaste committed rG131b7dcb2fbf: ctl: avoid heap info leak in ctl_request_sense (authored by emaste).
ctl: avoid heap info leak in ctl_request_sense
Mon, Aug 26, 1:28 PM
emaste committed rG6a847b6d1ee8: linux.4: clarify path translation (authored by emaste).
linux.4: clarify path translation
Mon, Aug 26, 1:23 PM
emaste committed rG226c73373738: linux.4: clarify path translation (authored by emaste).
linux.4: clarify path translation
Mon, Aug 26, 1:22 PM

Sun, Aug 25

emaste accepted D46429: vmm: Move vmm_ktr.h to a common directory.

This happens to clean up a BSD-2-Clause-FreeBSD too

Sun, Aug 25, 11:43 PM

Wed, Aug 21

emaste committed rGdb87c98168b1: ctl: avoid heap info leak in ctl_request_sense (authored by emaste).
ctl: avoid heap info leak in ctl_request_sense
Wed, Aug 21, 1:33 PM
emaste committed rGaa0bc761d245: bsd.symver.mk: pass $CFLAGS to $CPP invocation (authored by emaste).
bsd.symver.mk: pass $CFLAGS to $CPP invocation
Wed, Aug 21, 1:19 AM
emaste closed D45346: bsd.symver.mk: pass $CFLAGS to $CPP invocation.
Wed, Aug 21, 1:19 AM

Tue, Aug 20

emaste accepted D46004: libcxxrt: Add a stub implementation of __cxa_call_terminate.
Tue, Aug 20, 8:49 PM
emaste abandoned D46319: UPDATING: reference existing PR for DMAR issue.

hw.dmar.enable defaults to 0 again as of 0875f3cd74b2f305e82bff4e640c89f891ca84f8, and this note in UPDATING can be removed.

Tue, Aug 20, 8:14 PM
emaste added a comment to D22642: Intel IOMMU DMAR suspend/resume support (only without QI for now).

Referenced in PR280817

Tue, Aug 20, 6:21 PM · x86
emaste added a reverting change for rG3192fc30230a: x86: Enable Intel DMAR by default: rG0875f3cd74b2: Revert "x86: Enable Intel DMAR by default".
Tue, Aug 20, 3:50 PM
emaste committed rG0875f3cd74b2: Revert "x86: Enable Intel DMAR by default" (authored by emaste).
Revert "x86: Enable Intel DMAR by default"
Tue, Aug 20, 3:50 PM
emaste added a reverting change for D42435: Enable Intel DMAR by default: rG0875f3cd74b2: Revert "x86: Enable Intel DMAR by default".
Tue, Aug 20, 3:50 PM
emaste accepted D46376: audio/virtual_oss: Enable BT_SPEAKER by default.

Yeah I see no reason to avoid it.

Tue, Aug 20, 2:01 PM
emaste added a comment to D46321: sh: move histedit() call outside of test for bind -.

https://reviews.freebsd.org/P645 is a diff that teaches libedit how to parse it, by the way.

Tue, Aug 20, 12:08 AM

Mon, Aug 19

emaste requested review of D46321: sh: move histedit() call outside of test for bind -.
Mon, Aug 19, 5:04 PM
emaste accepted D46320: pkgbase: Make src package creation recipes more precise.

|| : seems unnecessarily clever to me, IMO || true is more obvious
but what error are we trying to ignore here anyway?

Mon, Aug 19, 3:34 PM
emaste committed rGd1daec3d358e: linux.4: improve the path translation clarificiation (authored by emaste).
linux.4: improve the path translation clarificiation
Mon, Aug 19, 2:29 PM
emaste committed rGf66e71fa78e1: linux.4: clarify path translation (authored by emaste).
linux.4: clarify path translation
Mon, Aug 19, 2:15 PM
emaste added a comment to D40481: umtx: close race between umtxq_sleep() and umtxq_requeue().

Is this possibly the same bug reported here? https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=280667

Mon, Aug 19, 1:24 PM
emaste requested review of D46319: UPDATING: reference existing PR for DMAR issue.
Mon, Aug 19, 1:07 PM

Sat, Aug 17

emaste accepted D46306: sound examples: Simplify MIDI example.
Sat, Aug 17, 4:24 PM

Thu, Aug 15

emaste committed rGef9fc9609a1f: sys: Mark ACL conversion routines as __result_use_check (authored by khorben_defora.org).
sys: Mark ACL conversion routines as __result_use_check
Thu, Aug 15, 7:06 PM
emaste added a comment to D46306: sound examples: Simplify MIDI example.

It might be better to keep the move & rewrite as separate commits so it's clear to git that it's the same file (rather than inferring this from delete + new file that are similar); if you do keep them separate I don't have a strong opinion on move-then-edit or edit-then-move.

Thu, Aug 15, 3:54 PM
emaste added a comment to D46308: sound examples: Move MIDI example out of OSS directory.

Probably need an ObsoleteFiles.inc update as well.
I guess this is technically also Fixes: cb00491fbc51 as this moves it back to what it used to be in sound/midi.c

Thu, Aug 15, 3:48 PM
emaste added a comment to D46306: sound examples: Simplify MIDI example.

Commit message should include some more detail (e.g. explain that it's not really OSS) and will need an ObsoleteFiles.inc update for the now-removed ossmidi.h.

Thu, Aug 15, 3:46 PM

Wed, Aug 14

emaste accepted D46288: Makefile.inc1: Let source packages be built in parallel.
Wed, Aug 14, 1:13 PM
emaste accepted D46286: build.7: Document the packages target.
Wed, Aug 14, 1:06 AM

Tue, Aug 13

emaste added a comment to D42435: Enable Intel DMAR by default.

This didn't get noted anywhere :(

Followed up with a reply to the commit mail

Tue, Aug 13, 9:06 PM
emaste committed rG2777a32588e1: iommu: disable dma by default (authored by emaste).
iommu: disable dma by default
Tue, Aug 13, 8:03 PM
emaste committed rG3192fc30230a: x86: Enable Intel DMAR by default (authored by emaste).
x86: Enable Intel DMAR by default
Tue, Aug 13, 8:03 PM
emaste closed D42435: Enable Intel DMAR by default.
Tue, Aug 13, 8:03 PM
emaste closed D42832: EN for OpenZFS data corruption issue.
Tue, Aug 13, 7:49 PM
emaste added a comment to D42832: EN for OpenZFS data corruption issue.

Thanks for the review everyone, released as https://www.freebsd.org/security/advisories/FreeBSD-EN-23:16.openzfs.asc

Tue, Aug 13, 7:49 PM
emaste closed D42887: EN-23:15.sanitizer update for 13.2.

https://www.freebsd.org/security/advisories/FreeBSD-EN-23:15.sanitizer.asc was updated

Tue, Aug 13, 7:48 PM
emaste added a comment to D45572: adjkerntz(8): Prefer "Real-Time Clock (RTC)" terminology.

Alexander Ziaee included some of this in ad57cea9e633cac5ef3f17ce0a82160bc32d7f63

Tue, Aug 13, 6:35 PM
emaste committed rG1b30c5d3a515: acl_copyin: avoid returning uninitialized memory (authored by khorben_defora.org).
acl_copyin: avoid returning uninitialized memory
Tue, Aug 13, 4:45 PM
emaste committed rG8807350405ce: pipe: keep uio_iovcnt consistent (authored by emaste).
pipe: keep uio_iovcnt consistent
Tue, Aug 13, 4:45 PM
emaste closed D45632: bsd.port.mk: remove unused base system binutils support.
Tue, Aug 13, 3:35 PM
emaste added a comment to D45632: bsd.port.mk: remove unused base system binutils support.

It seems I forgot about this review and did it again in D46015

Tue, Aug 13, 3:35 PM
emaste closed D46015: bsd.port.mk: remove unused base system binutils support.
Tue, Aug 13, 3:34 PM
emaste committed R11:a01528793ea6: bsd.port.mk: remove unused base system binutils support (authored by emaste).
bsd.port.mk: remove unused base system binutils support
Tue, Aug 13, 3:34 PM

Mon, Aug 12

emaste accepted D46249: Add smbus and i2c device id for Meteor Lake.
Mon, Aug 12, 2:30 PM
emaste accepted D46271: Fix EFI loader reproducibility with lld.
Mon, Aug 12, 11:59 AM

Sun, Aug 11

emaste committed rG8f16d9f7dc8c: acl_copyin: avoid returning uninitialized memory (authored by khorben_defora.org).
acl_copyin: avoid returning uninitialized memory
Sun, Aug 11, 11:06 PM
emaste committed rG0fb9da95f7cb: pipe: keep uio_iovcnt consistent (authored by emaste).
pipe: keep uio_iovcnt consistent
Sun, Aug 11, 11:05 PM
emaste committed rGf8a439c53840: linuxkpi: use canonical tests for is_{zero,broadcast}_ether_addr (authored by emaste).
linuxkpi: use canonical tests for is_{zero,broadcast}_ether_addr
Sun, Aug 11, 11:05 PM
emaste committed rG6bf5c32ad8aa: acl_copyin: avoid returning uninitialized memory (authored by khorben_defora.org).
acl_copyin: avoid returning uninitialized memory
Sun, Aug 11, 11:04 PM
emaste committed rGcbbc8d67301c: pipe: keep uio_iovcnt consistent (authored by emaste).
pipe: keep uio_iovcnt consistent
Sun, Aug 11, 11:03 PM
emaste committed rG6fb0634bc4ce: linuxkpi: use canonical tests for is_{zero,broadcast}_ether_addr (authored by emaste).
linuxkpi: use canonical tests for is_{zero,broadcast}_ether_addr
Sun, Aug 11, 11:03 PM
emaste added a comment to D46249: Add smbus and i2c device id for Meteor Lake.

LGTM other than the whitespace consistency with the other lines

Sun, Aug 11, 9:18 PM
emaste accepted D46271: Fix EFI loader reproducibility with lld.

OK as a workaround but we ought to report this upstream

Sun, Aug 11, 8:49 PM
emaste added inline comments to D46249: Add smbus and i2c device id for Meteor Lake.
Sun, Aug 11, 7:01 PM

Fri, Aug 9

emaste committed rG6ee6c7b14664: acl_copyin: avoid returning uninitialized memory (authored by khorben_defora.org).
acl_copyin: avoid returning uninitialized memory
Fri, Aug 9, 2:50 PM
emaste added a comment to D45852: Stop checking for failures from malloc(M_WAITOK).

sound: Stop checking for failures from malloc(M_WAITOK) LGTM

Fri, Aug 9, 2:35 PM
emaste added a comment to D46227: audio(8): Initial revision.

I also wonder about the name for this utility - ISTM audio(8) is too generic. If it has (will grow to have) features like @dev_submerge.ch mentions maybe audioctl(8)?

Fri, Aug 9, 2:31 PM

Thu, Aug 8

emaste committed rGd8ff42e81684: pipe: keep uio_iovcnt consistent (authored by emaste).
pipe: keep uio_iovcnt consistent
Thu, Aug 8, 6:17 PM
emaste closed D45999: pipe: keep uio_iovcnt consistent.
Thu, Aug 8, 6:17 PM
emaste committed rGa1295b24842d: linuxkpi: use canonical tests for is_{zero,broadcast}_ether_addr (authored by emaste).
linuxkpi: use canonical tests for is_{zero,broadcast}_ether_addr
Thu, Aug 8, 4:40 PM
emaste closed D21037: linuxpki: correct is_{zero,broadcast}_ether_addr.
Thu, Aug 8, 4:40 PM

Wed, Aug 7

emaste committed R9:7c02b391345d: Sync erratum and security advisory templates with secteam repo (authored by emaste).
Sync erratum and security advisory templates with secteam repo
Wed, Aug 7, 3:59 PM
emaste committed rGbd3aa40e0a55: sshd: remove blacklist call from grace_alarm_timer (authored by emaste).
sshd: remove blacklist call from grace_alarm_timer
Wed, Aug 7, 3:40 PM

Tue, Aug 6

emaste committed rG02ef8e4061ab: libusb: claim to be version 1.0.16 (authored by emaste).
libusb: claim to be version 1.0.16
Tue, Aug 6, 9:53 PM
emaste committed rG5bd6e6c1ddff: libusb: claim to be version 1.0.16 (authored by emaste).
libusb: claim to be version 1.0.16
Tue, Aug 6, 9:26 PM
emaste committed rGdc39004bc670: libm: fma: correct zero sign with small inputs (authored by Steve Kargl <kargl@FreeBSD.org>).
libm: fma: correct zero sign with small inputs
Tue, Aug 6, 9:26 PM
emaste committed rG5daa7f5bef21: depend-cleanup: remove entries from 2020 and 2021 (authored by emaste).
depend-cleanup: remove entries from 2020 and 2021
Tue, Aug 6, 9:24 PM
emaste committed rGf06d322e9d92: Remove "All Rights Reserved" from FreeBSD Foundation copyrights (authored by emaste).
Remove "All Rights Reserved" from FreeBSD Foundation copyrights
Tue, Aug 6, 9:24 PM
emaste committed rGed4fbdda588d: tools/build/make.py: Minor typo fix (authored by jlduran_gmail.com).
tools/build/make.py: Minor typo fix
Tue, Aug 6, 9:11 PM
emaste added a comment to D46224: LinuxKPI: update linuxkpi_video to Linux 6.6.

looks reasonable to me

Tue, Aug 6, 8:48 PM
emaste committed rGd1d8c9114751: libm: add parens to clarify expressions in fma, fmal (authored by emaste).
libm: add parens to clarify expressions in fma, fmal
Tue, Aug 6, 8:44 PM
emaste committed rG6cd4450c6c9a: msun: update Clang bug reference in fma test (authored by emaste).
msun: update Clang bug reference in fma test
Tue, Aug 6, 8:44 PM
emaste committed rGd5f16ef6463d: sshd: remove blacklist call from grace_alarm_timer (authored by emaste).
sshd: remove blacklist call from grace_alarm_timer
Tue, Aug 6, 7:47 PM
emaste committed rG73466449a9bf: sshd: remove blacklist call from grace_alarm_timer (authored by emaste).
sshd: remove blacklist call from grace_alarm_timer
Tue, Aug 6, 7:44 PM
emaste committed rG3d3bae9b9538: sshd: bump VersionAddendum for 2739a6845031 (authored by emaste).
sshd: bump VersionAddendum for 2739a6845031
Tue, Aug 6, 7:37 PM
emaste committed rG2739a6845031: sshd: remove blacklist call from grace_alarm_timer (authored by emaste).
sshd: remove blacklist call from grace_alarm_timer
Tue, Aug 6, 7:18 PM

Aug 1 2024

emaste committed rGbd208ed0ab94: uipc_shm: Fix double check for shmfd->shm_path (authored by rbranco_suse.com).
uipc_shm: Fix double check for shmfd->shm_path
Aug 1 2024, 5:36 PM
emaste committed rG88069992b210: bhyve: avoid resource leak in error path (authored by khorben_defora.org).
bhyve: avoid resource leak in error path
Aug 1 2024, 5:36 PM
emaste committed rG25114e7dd759: newsyslog: Fix case of the 'P' flag in newsyslog.conf(5) (authored by Joshua Kinard <freebsd@kumba.dev>).
newsyslog: Fix case of the 'P' flag in newsyslog.conf(5)
Aug 1 2024, 5:36 PM
emaste committed rGdbb6f488df6e: hda: add support for Tiger Lake-H (authored by Adam Retter <adam.retter@googlemail.com>).
hda: add support for Tiger Lake-H
Aug 1 2024, 5:36 PM
emaste committed rG34f7ebd56319: vt/sc: retire logic to select vt(4) by default for UEFI boot (authored by emaste).
vt/sc: retire logic to select vt(4) by default for UEFI boot
Aug 1 2024, 4:12 PM
emaste committed rG35957d27eab4: iichid: Soften "Interrupt setup failed" message (authored by emaste).
iichid: Soften "Interrupt setup failed" message
Aug 1 2024, 4:12 PM
emaste committed rG1f645823e0ea: etcupdate(8): improve phrasing (authored by emaste).
etcupdate(8): improve phrasing
Aug 1 2024, 4:11 PM
emaste committed rG1755b9daa693: libcbor: vendor update to 0.11.0 (authored by emaste).
libcbor: vendor update to 0.11.0
Aug 1 2024, 4:08 PM
emaste committed rGa357bacb86a0: madt: print CPU APIC ID as signed int (authored by emaste).
madt: print CPU APIC ID as signed int
Aug 1 2024, 4:08 PM