- User Since
- Nov 24 2013, 3:15 AM (380 w, 1 d)
Sat, Mar 6
Fri, Mar 5
Thu, Mar 4
Add missing bsd.sys.mk change
Wed, Mar 3
Update after 0b7472b3d8d2f1e90fade5236b44fd98d8e396c2
Tue, Mar 2
Mon, Mar 1
For kernel builds, do we have to change the 'makeoptions' like in GENERIC or can we get by with doing it in some kern.*mk file?
add compressed-debug compiler feature
x86_64-unknown-freebsd13.0-gcc6: error: -gz is not supported in this configuration
I think this is reasonable. I don't think we care whether SSP detects a stack overflow that overwrites only padding.
@gbe would you like to take care of committing this?
Fri, Feb 26
Thu, Feb 25
@lwhsu already took care of this one
afaict it's ok, but we should update all of them, or change the comments
Wed, Feb 24
Is this work also available in a git repo?
I'll commit with the updated comment of yours.
and as long as it builds
LGTM. I think the comments are unnecessary though.
Tue, Feb 23
And further, https://marc.info/?l=linux-arch&m=155002737229348
From Linux openat2 there are a set of resolve flags including
No objection from me
Yes makes sense for the tests to use -fno-builtins
I believe we've seen cases where tests fail in CI but pass regularly when run locally; not sure if that's the case for these tests but if we do re-enable them in CI we will need to watch closely and be ready to disable them again.
Mon, Feb 22
Looks OK to me, tiny concern is whether _libnetbsd= lib/libmd lib/libnetbsd could become out of sync (exists in two places)
Affected ports from the exp-run have been fixed, or have patches available and are waiting on maintainer approval. So, this should be ready to commit any time, although I think we should have a comment explaining which architectures have been opted-out (32-bit) and a brief sentence why.
Waiting on port maintainer approval
Email sent to port maintainer for approval
Received maintainer approval via email.
Sat, Feb 20
It's outside the scope of this review, but we might want to consider adding another column guide to the prepare-commit-msg hook, which indicates where 63 columns is located.
Remove old /boot/efi too