Page MenuHomeFreeBSD

emaste (Ed Maste)
UserAdministrator

Projects (12)

User Details

User Since
Nov 24 2013, 3:15 AM (361 w, 2 d)
Roles
Administrator

Recent Activity

Yesterday

emaste updated subscribers of D26956: libcasper/services/cap_net: Add cap_getprotobyname.
Mon, Oct 26, 1:25 PM

Sun, Oct 25

emaste added inline comments to D26909: Readelf: add -z decompression support.
Sun, Oct 25, 6:58 PM
emaste committed rS367043: rc.d/syscons: remove spaces before tab.
rc.d/syscons: remove spaces before tab
Sun, Oct 25, 6:27 PM
emaste committed rS367042: mergemaster: Clarify installed and updated versions.
mergemaster: Clarify installed and updated versions
Sun, Oct 25, 6:07 PM

Fri, Oct 23

emaste added a comment to D26909: Readelf: add -z decompression support.

libelf committed in rS366977

Fri, Oct 23, 5:26 PM
emaste added a comment to D24566: Add functions to get compression header for libelf.

(Dates in man pages and in copyright statements updated)

Fri, Oct 23, 4:36 PM
emaste closed D24566: Add functions to get compression header for libelf.
Fri, Oct 23, 4:35 PM
emaste committed rS366977: libelf: add compression header support.
libelf: add compression header support
Fri, Oct 23, 4:35 PM
emaste added inline comments to D24566: Add functions to get compression header for libelf.
Fri, Oct 23, 4:24 PM

Thu, Oct 22

emaste accepted D26913: xhci: Handle the case when MSI-X BAR is same as IO BAR..

LGTM and confirm it fixes the "Unable to map MSI-X table" issue on the machine I'm testing on.

Thu, Oct 22, 11:44 PM
emaste accepted D26908: mmap(2): Clarify that guard is taken from the stack region..

Looks good to me.

Thu, Oct 22, 7:13 PM
emaste added inline comments to D26908: mmap(2): Clarify that guard is taken from the stack region..
Thu, Oct 22, 6:53 PM
emaste added a comment to D26908: mmap(2): Clarify that guard is taken from the stack region..

One grammar nit

Thu, Oct 22, 6:50 PM
emaste added a comment to D26894: mmap(2): Document guard size and related EINVAL..

Oh I see @kib has D26908 for this.

Thu, Oct 22, 6:47 PM
emaste added inline comments to D26908: mmap(2): Clarify that guard is taken from the stack region..
Thu, Oct 22, 6:46 PM
emaste added inline comments to D26894: mmap(2): Document guard size and related EINVAL..
Thu, Oct 22, 6:45 PM
emaste accepted D26903: Only use ASAN when using the in-tree compiler.

I think this is OK.

Thu, Oct 22, 4:46 PM
emaste added a comment to D24566: Add functions to get compression header for libelf.

I intend to commit the libelf portion first, followed by readelf. @tig_freebsdfoundation.org perhaps you can update readelf.c based on @markj's comments, and put it in a separate review?

Thu, Oct 22, 1:59 PM

Wed, Oct 21

emaste accepted D26894: mmap(2): Document guard size and related EINVAL..
Wed, Oct 21, 6:57 PM
emaste accepted D26894: mmap(2): Document guard size and related EINVAL..
Wed, Oct 21, 6:30 PM
emaste added inline comments to D24566: Add functions to get compression header for libelf.
Wed, Oct 21, 1:36 PM

Tue, Oct 20

emaste committed rS366902: arm64: add uhci to GENERIC.
arm64: add uhci to GENERIC
Tue, Oct 20, 8:11 PM
emaste added a comment to D26856: Improve FPU Tag Word reconstruction on i386 to indicate register states.

If you update the review with the style(9) items @kib identified he or I will commit.

Tue, Oct 20, 6:08 PM
emaste added a comment to D24566: Add functions to get compression header for libelf.

One final thing, we'll need to add a man page, contrib/elftoolchain/libelf/gelf_getchdr.3. You can use e.g. gelf_getshdr.3 as a template, and see man mdoc for a reference to mdoc formatting.

Tue, Oct 20, 4:32 PM

Mon, Oct 19

emaste added a comment to D26876: Micro-optimize arm64's uma_small_alloc().

LGTM

Mon, Oct 19, 11:39 PM
emaste committed rS366861: build vmware modules on arm64.
build vmware modules on arm64
Mon, Oct 19, 8:43 PM
emaste accepted D26869: arm64: QorIQ: gpio: return BUS_PROBE_DEFAULT.
Mon, Oct 19, 7:33 PM
emaste added inline comments to D26867: arm64: QorIQ: gpio: Style cleanups..
Mon, Oct 19, 7:31 PM
emaste committed rS366847: uma: fix KTR message after r366840.
uma: fix KTR message after r366840
Mon, Oct 19, 6:54 PM
emaste added a comment to D24566: Add functions to get compression header for libelf.

Added to my staging tree as

diff --git a/contrib/elftoolchain/libelf/Version.map b/contrib/elftoolchain/libelf/Version.map
index e71a59197d0d..ae9783f221ca 100644
--- a/contrib/elftoolchain/libelf/Version.map
+++ b/contrib/elftoolchain/libelf/Version.map
@@ -4,6 +4,7 @@ R1.0 {
 global:
        elf32_checksum;
        elf32_fsize;
+       elf32_getchdr;
        elf32_getehdr;
        elf32_getphdr;
        elf32_getshdr;
@@ -13,6 +14,7 @@ global:
        elf32_xlatetom;
        elf64_checksum;
        elf64_fsize;
+       elf64_getchdr;
        elf64_getehdr;
        elf64_getphdr;
        elf64_getshdr;
@@ -65,6 +67,7 @@ global:
        gelf_checksum;
        gelf_fsize;
        gelf_getcap;
+       gelf_getchdr;
        gelf_getclass;
        gelf_getdyn;
        gelf_getehdr;
Mon, Oct 19, 5:42 PM
emaste added a comment to D24566: Add functions to get compression header for libelf.

New symbols need to be added to contrib/elftoolchain/libelf/Version.map

Mon, Oct 19, 5:38 PM
emaste added a comment to D26835: Add "device ch" to GENERIC kernel config for arm64 and descriptions to block devices.

Title is incorrect - sc is the syscons driver and is not added in this review.

Mon, Oct 19, 3:00 PM

Fri, Oct 16

emaste accepted D26819: cdefs: require gcc 4.2 or later.
Fri, Oct 16, 6:37 PM
emaste accepted D26817: cdefs.h: remove intel_compiler support.
Fri, Oct 16, 6:35 PM
emaste added inline comments to D26815: Slightly improve linux ptrace debug for PTRACE_GET_SYSCALL_INFO.
Fri, Oct 16, 1:20 PM

Thu, Oct 15

emaste updated subscribers of D10390: Add an option to create XZ-compressed cores.
Thu, Oct 15, 5:54 PM
emaste accepted D26777: Fix prlimit(1).
Thu, Oct 15, 3:38 PM
emaste committed rS366726: move vmware pv drivers to sys/conf/files.
move vmware pv drivers to sys/conf/files
Thu, Oct 15, 2:38 PM

Wed, Oct 14

emaste committed rS366705: MFC r366313: Add cd device to arm64 GENERIC.
MFC r366313: Add cd device to arm64 GENERIC
Wed, Oct 14, 3:26 PM
emaste accepted D26778: Set default stack size for Linux apps to 8MB..
Wed, Oct 14, 1:52 PM
emaste added inline comments to D26777: Fix prlimit(1).
Wed, Oct 14, 1:29 PM

Tue, Oct 13

emaste added a comment to D26773: [traceroute6] Fix compilation warnings + without casper.

no objection

Tue, Oct 13, 10:57 PM
emaste updated subscribers of D26764: arm64/gicv3: Initialize all ITS collections at attach time.
Tue, Oct 13, 9:20 PM
emaste updated subscribers of D26766: arm64: Increase NIRQ to 16k.
Tue, Oct 13, 9:20 PM
emaste added a comment to D26762: [libcasper] Use null inline functions when casper is disabled.

Agree with the change, two small suggestions

Tue, Oct 13, 9:18 PM
emaste added a comment to D26748: Major improvement to build parallelism for googletest internal tests.

No objection

Tue, Oct 13, 2:11 PM

Sat, Oct 10

emaste committed rS366596: modules/crypto: reenable assembly optimized skein implementation.
modules/crypto: reenable assembly optimized skein implementation
Sat, Oct 10, 1:13 AM

Fri, Oct 9

emaste added inline comments to D26727: linuxkpi: Move kobject related function in its own file.
Fri, Oct 9, 11:38 PM
emaste added inline comments to D26728: linuxkpi: Move timer related functions in its own file..
Fri, Oct 9, 11:35 PM
emaste added inline comments to D26725: arm: Check dtb version against the one we're expecting to find..
Fri, Oct 9, 9:05 PM
emaste updated subscribers of D26724: Brand our DTS with the Linux version it was imported from.
Fri, Oct 9, 9:01 PM
emaste committed rS366581: MFC r365847: makefs: connect cd9660 El Torito EFI boot image system type.
MFC r365847: makefs: connect cd9660 El Torito EFI boot image system type
Fri, Oct 9, 6:31 PM

Thu, Oct 8

emaste accepted D26695: Do not allow to use O_BENEATH as an oracle..
Thu, Oct 8, 6:03 PM
emaste added inline comments to D24566: Add functions to get compression header for libelf.
Thu, Oct 8, 5:31 PM

Wed, Oct 7

emaste added a comment to D24566: Add functions to get compression header for libelf.

For committing this we'd do the libelf change first, then the readelf change.

Wed, Oct 7, 4:10 PM
emaste added inline comments to D24566: Add functions to get compression header for libelf.
Wed, Oct 7, 3:42 PM
emaste added a comment to D26562: Move kernel env global variables, etc to sys/kenv.h.

Committed as rS366508

Wed, Oct 7, 1:14 PM

Tue, Oct 6

emaste added inline comments to D26695: Do not allow to use O_BENEATH as an oracle..
Tue, Oct 6, 4:12 PM

Mon, Oct 5

emaste added a comment to D26646: Cleanup ports after 11.3-EOL.

uh, this should not have been closed

Mon, Oct 5, 8:39 PM
emaste added inline comments to D24566: Add functions to get compression header for libelf.
Mon, Oct 5, 7:12 PM

Sun, Oct 4

emaste added inline comments to D26523: Enable multipath for outbound connections.
Sun, Oct 4, 5:12 PM

Sat, Oct 3

emaste added a comment to D26652: Implement SO_RERROR.

what other OSes share this API now?

Sat, Oct 3, 8:17 PM
emaste accepted D26643: amd64 Store full 64bit of FIP/FDP for 64bit processes when using XSAVE..
Sat, Oct 3, 7:51 PM

Fri, Oct 2

emaste committed rS366362: libmd: add dependency workaround for r366344.
libmd: add dependency workaround for r366344
Fri, Oct 2, 2:01 PM

Thu, Oct 1

emaste committed rS366344: libmd: fix assembly optimized skein implementation.
libmd: fix assembly optimized skein implementation
Thu, Oct 1, 9:06 PM
emaste closed D26614: fix skein1024.
Thu, Oct 1, 9:06 PM
emaste added a comment to D26517: Refactor pkg bootstrap to fetch compression types.
18:16 <@bapt> so all in all to be backward compatible you can just create a new symlink in bsd.port.mk
18:17 <@bapt> and coordinate with antoine so the hook so sign now also sign the pkg.bootstrap
Thu, Oct 1, 6:17 PM
emaste added a comment to D26517: Refactor pkg bootstrap to fetch compression types.

on IRC @bapt suggests latest/pkg.bootstrap as the symlink, full URL pkg.freebsd.org/FreeBSD:13:amd64/latest/pkg.bootstrap
Note that this removes the Latest from the URL currently used for pkg.txz.

Thu, Oct 1, 6:16 PM
emaste added a comment to D26517: Refactor pkg bootstrap to fetch compression types.

bapt suggests pkg.latest or pkg.bootstrap as the agnostic symlink name

Thu, Oct 1, 5:47 PM
emaste added a comment to D26517: Refactor pkg bootstrap to fetch compression types.

what about using pkg.bsd as the format-agnostic symlink name?

pkg.bsd -> pkg.txz
Thu, Oct 1, 5:20 PM
emaste added a member for linuxkpi: emaste.
Thu, Oct 1, 2:01 PM
emaste added a comment to D26598: linuxkpi: upstream drm-kmod conflicting changes.

I added a linuxkpi group in Phabricator that folks with an interest may join

Thu, Oct 1, 1:58 PM
emaste updated subscribers of D26598: linuxkpi: upstream drm-kmod conflicting changes.
Thu, Oct 1, 1:57 PM
emaste created linuxkpi.
Thu, Oct 1, 1:55 PM
emaste committed rS366313: Add cd device to arm64 GENERIC.
Add cd device to arm64 GENERIC
Thu, Oct 1, 1:29 PM
emaste updated subscribers of D26614: fix skein1024.
Thu, Oct 1, 12:45 AM
emaste added inline comments to D26614: fix skein1024.
Thu, Oct 1, 12:43 AM
emaste added reviewers for D26614: fix skein1024: emaste, arichardson.
Thu, Oct 1, 12:41 AM

Wed, Sep 30

emaste updated subscribers of D26617: Rename DISTDIR to RELDISTDIR to avoid clash with ports DISTDIR defined in make.conf.
Wed, Sep 30, 9:46 PM
emaste committed rS366299: MFC r359067: -F is GNU diff specific, not implemented in BSD diff..
MFC r359067: -F is GNU diff specific, not implemented in BSD diff.
Wed, Sep 30, 8:57 PM
emaste committed rS366298: MFC r363563: chio: avoid out of bounds read.
MFC r363563: chio: avoid out of bounds read
Wed, Sep 30, 7:23 PM
emaste added a comment to D26590: Implement sparse core dumps.

To me the new runlen loop is more clear.

Wed, Sep 30, 7:08 PM
emaste added a comment to D26608: update docs for 11.3 EOL.

No worries; I see from rD54553 that there's a lot more to update than just releng/index.xml (which is mentioned in security.xml); is there a list of all of these places we should reference instead?

Wed, Sep 30, 3:00 PM
emaste added inline comments to D26608: update docs for 11.3 EOL.
Wed, Sep 30, 2:58 PM
emaste requested review of D26608: update docs for 11.3 EOL.
Wed, Sep 30, 2:36 PM
emaste accepted D26599: gdb(4): Don't escape GDB special characters at application layer.

OK

Wed, Sep 30, 2:19 PM
emaste committed rD54552: update advisory templates for 11.3 EOL.
update advisory templates for 11.3 EOL
Wed, Sep 30, 2:06 PM
emaste abandoned D26546: bspatch: enter capability mode after dropping fd rights.
Wed, Sep 30, 1:30 PM
emaste accepted D26594: Makefile.inc1: sysent: allow subordinate sysent targets to run in parallel.
Wed, Sep 30, 12:11 AM

Tue, Sep 29

emaste accepted D26591: Prefer --ld-path=/path/to/ld on clang >= 12..
Tue, Sep 29, 10:13 PM
emaste accepted D26592: libgssapi: modernize static string array use.
Tue, Sep 29, 9:56 PM
emaste added inline comments to D26594: Makefile.inc1: sysent: allow subordinate sysent targets to run in parallel.
Tue, Sep 29, 9:47 PM

Mon, Sep 28

emaste closed D26538: Add SIOCGIFDATA.
Mon, Sep 28, 4:55 PM
emaste committed rS366230: add SIOCGIFDATA ioctl.
add SIOCGIFDATA ioctl
Mon, Sep 28, 4:54 PM
emaste added inline comments to D26546: bspatch: enter capability mode after dropping fd rights.
Mon, Sep 28, 3:41 PM

Sun, Sep 27

emaste committed rS366209: MFC r356323: src.opts.mk: SVNLITE requires FILE.
MFC r356323: src.opts.mk: SVNLITE requires FILE
Sun, Sep 27, 10:50 PM
emaste committed rS366208: MFC r356615: src.opts.mk: force KERBEROS_SUPPORT off where KERBEROS forced off.
MFC r356615: src.opts.mk: force KERBEROS_SUPPORT off where KERBEROS forced off
Sun, Sep 27, 10:48 PM
emaste updated subscribers of D26544: riscv: Panic on PMP errors.
Sun, Sep 27, 10:30 PM

Sep 24 2020

emaste added inline comments to D26340: run clang-format over vtfontcvt.c.
Sep 24 2020, 2:46 PM
emaste committed rS366115: mgb.4: add note about experimental status.
mgb.4: add note about experimental status
Sep 24 2020, 2:42 PM