Page MenuHomeFreeBSD

emaste (Ed Maste)
UserAdministrator

Projects (16)

User Details

User Since
Nov 24 2013, 3:15 AM (575 w, 16 h)
Roles
Administrator

Recent Activity

Today

emaste accepted D47856: Expose POSIX functions incorporated into C23.
Sun, Dec 1, 5:16 PM
emaste accepted D47659: lib/libc/gen: use Lemire's algorithm for arc4random_uniform()..
Sun, Dec 1, 5:12 PM
emaste accepted D47852: 14.2/relnotes: Add a few more notes about FreeBSD Foundation work.

Couple of small notes inline, please incorporate if you're happy with them or go ahead without.

Sun, Dec 1, 2:47 PM

Fri, Nov 29

emaste added a comment to D47843: zfs: handle the `UF_NOUNLINK` chflags fflag.

This should go to https://github.com/openzfs/zfs

Fri, Nov 29, 7:16 PM
emaste added a reviewer for D47828: comsat: Use initgroups and setgid not just setuid: jlduran.
Fri, Nov 29, 4:46 PM
emaste accepted D47722: mtree: TESTSBASE directory always starts with a /.

This is fine with me, but you could instead strip a leading / from TESTBASE if present, e.g. /usr/lib/debug/${TESTBASE:S,^/,,}. This will be robust against a possible TESTBASE without a leading slash.

Fri, Nov 29, 4:46 PM

Thu, Nov 28

emaste accepted D47834: fileno(3): set errno when returning -1.
Thu, Nov 28, 11:24 PM
emaste added inline comments to D47747: net80211: add helper functions for determining 11n transmit parameters - AMPDU density/size, short-GI.
Thu, Nov 28, 9:49 PM · wireless
emaste requested review of D47828: comsat: Use initgroups and setgid not just setuid.
Thu, Nov 28, 4:56 PM
emaste accepted D47721: mtree: Align BSD.usr.dist keywords.
Thu, Nov 28, 3:28 PM
emaste committed rG062b69ba045d: comsat: Improve use of setuid() (authored by emaste).
comsat: Improve use of setuid()
Thu, Nov 28, 1:05 PM
emaste added inline comments to D47748: ath: use the new net80211 methods for AMPDU density/limit, short-GI.
Thu, Nov 28, 12:58 AM · wireless
emaste added inline comments to D47747: net80211: add helper functions for determining 11n transmit parameters - AMPDU density/size, short-GI.
Thu, Nov 28, 12:55 AM · wireless

Wed, Nov 27

emaste added a comment to D47819: ARM64 GICv3: Fix device table size calculation.

Please generate patches with git diff -U99999 or git show -U99999 so that Phab will show context

Wed, Nov 27, 7:41 PM · arm64
emaste added inline comments to D47562: rtwn: Fix RTL8188EU & RTL8192EU cannot associate in STA mode.
Wed, Nov 27, 7:18 PM
emaste committed rGc0faaa14d77d: intro(3): remove profiling libs (authored by emaste).
intro(3): remove profiling libs
Wed, Nov 27, 6:02 PM
emaste updated the diff for D47806: freebsd-update: remove $FreeBSD$ special case.
Wed, Nov 27, 5:41 PM
emaste added a comment to D47806: freebsd-update: remove $FreeBSD$ special case.

Actually I think all of these cases no longer exist and we can just remove this functionality altogether.

Wed, Nov 27, 5:39 PM
emaste added inline comments to D47806: freebsd-update: remove $FreeBSD$ special case.
Wed, Nov 27, 5:39 PM
emaste requested review of D47806: freebsd-update: remove $FreeBSD$ special case.
Wed, Nov 27, 5:04 PM
emaste added a comment to D47782: procctl.2: Editing pass.

I think many of these tweaks are slightly more readable or simpler to understand, but that may just be a matter of taste.

Wed, Nov 27, 4:57 PM
emaste accepted D47782: procctl.2: Editing pass.

Some minor notes

Wed, Nov 27, 4:51 PM
emaste accepted D47781: sound: Fix mis-sorted CHN_F_BITS line.
Wed, Nov 27, 4:00 PM
emaste added a comment to D47775: rtwn: enable FCS in the recive config to work around truncated frames.

oh it's when I do commit update to add the differential revision to the git commit message

Wed, Nov 27, 3:56 PM · wireless
emaste added a comment to D47737: sound: Merge pcm/matrix_map.h with pcm/matrix.h.

Seems OK -- I imagine it was split out as it is rather long but it does not seem necessary to do so.

Wed, Nov 27, 2:41 PM
emaste added inline comments to D47733: sound: Remove dead code from pcm/.
Wed, Nov 27, 1:34 PM
emaste added inline comments to D47562: rtwn: Fix RTL8188EU & RTL8192EU cannot associate in STA mode.
Wed, Nov 27, 1:28 PM
emaste added a comment to D47775: rtwn: enable FCS in the recive config to work around truncated frames.

add url

Wed, Nov 27, 1:01 PM · wireless
emaste added inline comments to D47659: lib/libc/gen: use Lemire's algorithm for arc4random_uniform()..
Wed, Nov 27, 1:08 AM
emaste added inline comments to D47774: rtwn: fix rtl8812/rtl8821 vht definitions, add VHT calibration/rate control.
Wed, Nov 27, 12:32 AM · wireless

Tue, Nov 26

emaste accepted D47724: mtree: Add missing entries in BSD.tests.dist.
Tue, Nov 26, 6:20 PM
emaste added inline comments to D47748: ath: use the new net80211 methods for AMPDU density/limit, short-GI.
Tue, Nov 26, 4:41 PM · wireless
emaste accepted D47712: Install pvscsi man page.
Tue, Nov 26, 3:46 PM
emaste requested review of D47753: libc: Move disktab here from sbin/bsdlabel.
Tue, Nov 26, 1:10 AM

Mon, Nov 25

emaste committed rGe59630a3ddc0: dconschat: Increase WARNS to 2 (authored by emaste).
dconschat: Increase WARNS to 2
Mon, Nov 25, 9:34 PM
emaste committed rGd4820e1727ec: mac_bsdextended: Remove \n from sysctl descriptions (authored by emaste).
mac_bsdextended: Remove \n from sysctl descriptions
Mon, Nov 25, 9:28 PM
emaste updated the diff for D47742: kernel linker: Disable local sym resolution by default.

whole patch

Mon, Nov 25, 9:05 PM
emaste added a comment to D47740: netinet: Disallow connections to INADDR_ANY.

Does this need an entry in RELNOTES as a followup commit perhaps?

Mon, Nov 25, 7:52 PM
emaste added a comment to D47740: netinet: Disallow connections to INADDR_ANY.

It might be worth giving a heads-up anyway, just so people have a hint if something stops working.

Mon, Nov 25, 7:39 PM
emaste added a comment to D47742: kernel linker: Disable local sym resolution by default.

PR: 207898

Mon, Nov 25, 7:10 PM
emaste requested review of D47742: kernel linker: Disable local sym resolution by default.
Mon, Nov 25, 7:10 PM
emaste requested review of D47740: netinet: Disallow connections to INADDR_ANY.
Mon, Nov 25, 7:00 PM
emaste accepted D47703: HW Relnotes: Remove joy(4).
Mon, Nov 25, 5:10 PM
emaste accepted D47726: nvmecontrol: Fix minor usage typo.

Minor comment on commit message - imperative, present tense is preferred, so e.g. nvmecontrol: Fix usage typo (or typo in option description etc.)

Mon, Nov 25, 4:49 PM
emaste requested review of D47731: getpwent: Add note about y2016 issue in v4 db format.
Mon, Nov 25, 2:02 PM
emaste accepted D47716: rc.conf: Update commented examples for lo0 to use CIDR.
Mon, Nov 25, 12:54 PM

Sun, Nov 24

emaste committed rG93a321b60750: libc: Note that getentropy is nearly POSIX 2024 (authored by emaste).
libc: Note that getentropy is nearly POSIX 2024
Sun, Nov 24, 4:47 PM
emaste committed rG28092a8bc72e: mac_bsdextended: Remove \n from sysctl descriptions (authored by emaste).
mac_bsdextended: Remove \n from sysctl descriptions
Sun, Nov 24, 4:47 PM

Fri, Nov 22

emaste committed rGc769f45a5709: gvinum: Postpone removal to FreeBSD 15 (authored by emaste).
gvinum: Postpone removal to FreeBSD 15
Fri, Nov 22, 7:38 PM
emaste added a comment to D47704: HW Relnotes: Improve Supported Architectures.

Thinking a bit more I'd go with what you have here, and we should revisit this just before 15.0 (which shouldn't have any 32-bit except for armv7 anyway).

Fri, Nov 22, 7:28 PM
emaste added a comment to D47704: HW Relnotes: Improve Supported Architectures.

I've wondered if we should use the order you have here, or go based on tier order (amd64, aarch64, i386, armv7, ...). Or maybe we don't need to think too much, and once i386 is retired the problem solves itself.

Fri, Nov 22, 7:09 PM
emaste accepted D47704: HW Relnotes: Improve Supported Architectures.
Fri, Nov 22, 7:06 PM
emaste committed rG66439659982c: getentropy: restore unistd.h include (authored by emaste).
getentropy: restore unistd.h include
Fri, Nov 22, 6:09 PM
emaste added a comment to D47699: 14.2 Release HW Notes: cleanup keyboard/pointing.

IMO it's most important to get the notes into shape for 14.2, and archetypes must receive the same change. (Ideally we would have updated archetypes just before creating the 14.2 notes.) I wouldn't bother changing the old release notes for these. Removing references to drivers that were excised from the tree long ago makes sense, but not for reordering the sections etc.

Fri, Nov 22, 2:50 PM
emaste closed D47564: Release Notes: Hardware Compat: cs(4) was removed.
Fri, Nov 22, 2:16 PM · doceng, releng, docs
emaste committed R9:fc77d87905c9: HW relnotes: Remove cs(4) (authored by concussious.bugzilla_runbox.com).
HW relnotes: Remove cs(4)
Fri, Nov 22, 2:16 PM
emaste closed D47566: Release Notes: Hardware Compat: Remove tx(4).
Fri, Nov 22, 2:14 PM · manpages, releng, doceng, docs
emaste committed R9:818ef56e5620: HW relnotes: Remove tx(4) (authored by concussious.bugzilla_runbox.com).
HW relnotes: Remove tx(4)
Fri, Nov 22, 2:14 PM
emaste accepted D47566: Release Notes: Hardware Compat: Remove tx(4).
Fri, Nov 22, 2:13 PM · manpages, releng, doceng, docs
emaste closed D47637: HW Relnotes: Remove sio(4).
Fri, Nov 22, 2:13 PM · doceng, releng, docs
emaste committed R9:cacf9d5614ad: HW relnotes: Remove sio(4) (authored by concussious.bugzilla_runbox.com).
HW relnotes: Remove sio(4)
Fri, Nov 22, 2:13 PM
emaste accepted D47637: HW Relnotes: Remove sio(4).
Fri, Nov 22, 2:06 PM · doceng, releng, docs
emaste added inline comments to D47699: 14.2 Release HW Notes: cleanup keyboard/pointing.
Fri, Nov 22, 2:05 PM
emaste committed rGf85dd3f546ba: src.conf.5: Regen after MK_PROFILE removal (authored by emaste).
src.conf.5: Regen after MK_PROFILE removal
Fri, Nov 22, 1:02 PM

Thu, Nov 21

emaste added a comment to D47675: Replace calls to bus_generic_attach with bus_attach_children.

The Linux folks use coccinelle

Yeah it would be great to have coccinelle for downstream projects to apply the same change in derived repos.

Thu, Nov 21, 10:46 PM
emaste accepted D47624: MAC/do: Convert internal TAILQs to STAILQs.
Thu, Nov 21, 9:37 PM
emaste committed rGae4f39464c61: ng_parse: disallow negative length for malloc (authored by emaste).
ng_parse: disallow negative length for malloc
Thu, Nov 21, 8:56 PM
emaste closed D37229: ng_parse: disallow negative length for malloc.
Thu, Nov 21, 8:56 PM
emaste added a comment to D37229: ng_parse: disallow negative length for malloc.

I'm going to commit this as an interim improvement. We can revisit ng_get_composite_len's return type and error handling later on.

Thu, Nov 21, 8:52 PM
emaste accepted D47682: LinuxKPI: firmware: change order filenames trying to load firmware.
Thu, Nov 21, 6:59 PM
emaste added a comment to D47498: mac_bsdextended: remove obsolete sysctl from man page.

This is the sysctl node under which rules are created; they are opaque binary objects and aren't shown by sysctl(8). You can add a rule in ugidfw and then run ktrace -i ugidfw list to see them being used -- something like:

Thu, Nov 21, 3:59 PM
emaste committed rG7dfaf238562c: rtwn: Add device ID for TPLink RTL8192CU (authored by waddlesplash_gmail.com).
rtwn: Add device ID for TPLink RTL8192CU
Thu, Nov 21, 3:41 PM
emaste committed rG6b62e00da4ad: mac_bsdextended: Remove \n from sysctl descriptions (authored by emaste).
mac_bsdextended: Remove \n from sysctl descriptions
Thu, Nov 21, 3:28 PM
emaste requested review of D47693: bstring: Use "byte object" rather than "byte string.
Thu, Nov 21, 12:55 AM
emaste committed rG2e8ab3d4e9b9: fork: Document _Fork (and fork) as POSIX 2024 (authored by emaste).
fork: Document _Fork (and fork) as POSIX 2024
Thu, Nov 21, 12:47 AM
emaste committed rG098ed26bf456: libc: indicate existing functions that are POSIX 2024 (authored by emaste).
libc: indicate existing functions that are POSIX 2024
Thu, Nov 21, 12:47 AM

Wed, Nov 20

emaste added inline comments to D47659: lib/libc/gen: use Lemire's algorithm for arc4random_uniform()..
Wed, Nov 20, 11:01 PM
emaste requested changes to D47659: lib/libc/gen: use Lemire's algorithm for arc4random_uniform()..
Wed, Nov 20, 11:00 PM
emaste added a comment to D47659: lib/libc/gen: use Lemire's algorithm for arc4random_uniform()..

The C code in Lemire's paper uses a uint64_t bound and __uint128_t variable. Maybe it is worth a small note to this effect in the commit message (of course, 32/64 or 64/128 doesn't matter for the algorithm itself).

Wed, Nov 20, 10:53 PM
emaste updated the diff for D47689: libc: Fix getentropy POSIX 2024 conformance issues.

Restore POSIX_VISIBLE tests - issue was local cross-threading

Wed, Nov 20, 9:15 PM
emaste added a comment to D47689: libc: Fix getentropy POSIX 2024 conformance issues.

Oh, on ref15-amd64.freebsd.org I get:

#include <sys/cdefs.h>
#include <stdio.h>
Wed, Nov 20, 9:09 PM
emaste added a comment to D47689: libc: Fix getentropy POSIX 2024 conformance issues.

I'm not sure how the build is intended to set __POSIX_VISIBLE for building libc's getentropy.c.

Wed, Nov 20, 7:43 PM
emaste requested review of D47689: libc: Fix getentropy POSIX 2024 conformance issues.
Wed, Nov 20, 7:42 PM
emaste closed D47589: getentropy: note that it is nearly POSIX 2024.
Wed, Nov 20, 7:32 PM
emaste committed rG95b71a659a9b: libc: Note that getentropy is nearly POSIX 2024 (authored by emaste).
libc: Note that getentropy is nearly POSIX 2024
Wed, Nov 20, 7:32 PM
emaste accepted D47664: sound: Remove unused CHN_F_SILENCE.
Wed, Nov 20, 5:34 PM
emaste committed rG5cc53d79655b: memcmp.3: Clarify return value (authored by emaste).
memcmp.3: Clarify return value
Wed, Nov 20, 5:16 PM
emaste closed D47683: memcmp.3: clarify return value.
Wed, Nov 20, 5:15 PM
emaste updated the diff for D47683: memcmp.3: clarify return value.
Wed, Nov 20, 4:59 PM
emaste added inline comments to D47589: getentropy: note that it is nearly POSIX 2024.
Wed, Nov 20, 4:24 PM
emaste updated the diff for D47683: memcmp.3: clarify return value.

missing word, update test

Wed, Nov 20, 4:06 PM
emaste added a comment to D47683: memcmp.3: clarify return value.

I don't believe we should change it nor stop documenting it.

Wed, Nov 20, 4:02 PM
emaste requested review of D47683: memcmp.3: clarify return value.
Wed, Nov 20, 3:46 PM
emaste added a comment to D47409: release: factor out common code from make-memstick.sh.

Yeah I'd hold off on this until after 14.2 is out the door

Wed, Nov 20, 2:34 PM
emaste added a comment to D47682: LinuxKPI: firmware: change order filenames trying to load firmware.

Can we simplify this eventually and standardize on only the first case?

Wed, Nov 20, 2:29 PM
emaste updated the diff for D47589: getentropy: note that it is nearly POSIX 2024.

typo, mention that it nearly conforms to posix 24

Wed, Nov 20, 2:27 PM
emaste added inline comments to D47682: LinuxKPI: firmware: change order filenames trying to load firmware.
Wed, Nov 20, 1:40 PM
emaste accepted D47409: release: factor out common code from make-memstick.sh.

I think we can reduce some duplication in memstick_mkimg later, but this is a great start

Wed, Nov 20, 1:27 PM
emaste committed rG62dab3d016ab: getentropy: Remove fallback code (authored by emaste).
getentropy: Remove fallback code
Wed, Nov 20, 2:32 AM
emaste closed D47636: getentropy: Remove fallback code.
Wed, Nov 20, 2:32 AM