emaste (Ed Maste)Administrator
User

Projects (7)

User Details

User Since
Nov 24 2013, 3:15 AM (208 w, 5 d)
Roles
Administrator

Recent Activity

Yesterday

emaste committed rS326179: Temporarily disable VIMAGE on arm64.
Temporarily disable VIMAGE on arm64
Fri, Nov 24, 7:21 PM
emaste added inline comments to D4385: Prepare the ports tree for reproducible builds.
Fri, Nov 24, 6:59 PM
emaste updated the diff for D4385: Prepare the ports tree for reproducible builds.

For now avoid setting the reproducible build timestamp in PKG_ENV for all ports that set USES=python

Fri, Nov 24, 6:52 PM
emaste added a comment to D4385: Prepare the ports tree for reproducible builds.

Would it be reasonable to scan the plist for any port that sets USES=python, and avoid overriding the package archive metadata if any .pyo/.pyc found?

Fri, Nov 24, 6:41 PM
emaste added a comment to D4385: Prepare the ports tree for reproducible builds.

Debian doesn't ship the .pyc / .pyo files; they generate them at install time.

Fri, Nov 24, 4:01 PM
emaste accepted D13213: Disable vim syntax highlighting..

No objection from me.

Fri, Nov 24, 2:06 AM

Thu, Nov 23

emaste committed rP454807: sysutils/safecat: fix linking with GNU ld.
sysutils/safecat: fix linking with GNU ld
Thu, Nov 23, 10:34 PM
emaste added a comment to D13020: If device path returns NULL, don't use it..

A similar change has been committed

Thu, Nov 23, 10:16 PM
emaste added a comment to D5603: ASLR.

D13155 / rS326097 introduced a conflict; this needs a rebase.

Thu, Nov 23, 7:11 PM
emaste committed rS326136: bfd: avoid crash on corrupt binaries.
bfd: avoid crash on corrupt binaries
Thu, Nov 23, 4:05 PM
emaste committed rS326135: bfd: fix segfault in the ihex parser on malformed ihex file.
bfd: fix segfault in the ihex parser on malformed ihex file
Thu, Nov 23, 2:30 PM

Wed, Nov 22

emaste accepted D13193: iscsisctl language fixes.
Wed, Nov 22, 5:57 PM
emaste committed rS326094: Fix indentation in bsdinstall-created wpa_supplicant.conf.
Fix indentation in bsdinstall-created wpa_supplicant.conf
Wed, Nov 22, 3:18 PM
emaste closed D13190: Fix indentation in bsdinstall-created wpa_supplicant.conf.
Wed, Nov 22, 3:18 PM
emaste committed rS326082: freebsd-update: do not duplicate patchlist entries.
freebsd-update: do not duplicate patchlist entries
Wed, Nov 22, 1:50 AM
emaste created D13190: Fix indentation in bsdinstall-created wpa_supplicant.conf.
Wed, Nov 22, 1:38 AM

Tue, Nov 21

emaste added a comment to D4385: Prepare the ports tree for reproducible builds.

What would you suggest for selectively setting PKG_ENV (e.g., for all but python ports, for now)?

Tue, Nov 21, 10:53 PM
emaste committed rS326074: filter all passwords (not only changed) from periodic passwd backup.
filter all passwords (not only changed) from periodic passwd backup
Tue, Nov 21, 8:32 PM
emaste updated the diff for D4385: Prepare the ports tree for reproducible builds.
  • Bump default timestamp to nice round 1500000000 since it s no longer a future time
  • Set SOURCE_DATE_EPOCH only for the pkg env, not the build env
  • Add a comment
Tue, Nov 21, 6:44 PM
emaste added a comment to D12851: aw_ccung: changes to accommodate upcoming a83t support.

I approve based on @manu's review

Tue, Nov 21, 5:45 PM
emaste added inline comments to D12650: Add EFI RTC support.
Tue, Nov 21, 5:31 PM
emaste committed rS326062: MFC r325813 (bz): Unbreak IPv6..
MFC r325813 (bz): Unbreak IPv6.
Tue, Nov 21, 3:34 PM
emaste committed rS326059: MFC r325811: vnic: report that the driver supports multicast.
MFC r325811: vnic: report that the driver supports multicast
Tue, Nov 21, 1:59 PM
emaste committed rS326057: vidcontrol: correct history size error message.
vidcontrol: correct history size error message
Tue, Nov 21, 1:55 PM
emaste updated subscribers of D13155: Do not loop infinitely in vm_map_find()..
Tue, Nov 21, 4:07 AM
emaste committed rS326046: dt_modtext: return error on archs lacking an implementation.
dt_modtext: return error on archs lacking an implementation
Tue, Nov 21, 3:15 AM
emaste closed D13176: dt_modtext: return error on archs lacking an implementation.
Tue, Nov 21, 3:15 AM
emaste added a comment to D13178: Add Pull Request to the Subversion commit template.

I would put it before Differential Revision: to help cement the idea that D-R should go last (even though you'd generally not have both of these on the same commit) and because Differential Revision: is too long and pushes the rest of the text over to the right.

Tue, Nov 21, 2:46 AM
emaste added a comment to D13176: dt_modtext: return error on archs lacking an implementation.

https://github.com/emaste/freebsd/commit/1847c866134eff8524004bdb2edeb457bf33a06e

Tue, Nov 21, 2:09 AM
emaste created D13176: dt_modtext: return error on archs lacking an implementation.
Tue, Nov 21, 2:08 AM

Mon, Nov 20

emaste committed rP454582: sysutils/safecat: avoid duplicating object files in library.
sysutils/safecat: avoid duplicating object files in library
Mon, Nov 20, 10:23 PM
emaste committed rS326030: Install strings unconditionally.
Install strings unconditionally
Mon, Nov 20, 8:55 PM
emaste closed D8398: Install strings unconditionally.
Mon, Nov 20, 8:55 PM
emaste added inline comments to D8398: Install strings unconditionally.
Mon, Nov 20, 7:57 PM
emaste added inline comments to D12650: Add EFI RTC support.
Mon, Nov 20, 4:21 PM
emaste added a comment to D12650: Add EFI RTC support.

Tested successfully on SoftIron OverDrive 1000 after applying fpu_kern_enter fix from @andrew via IRC

Mon, Nov 20, 4:17 PM
emaste added a comment to D12843: (WIP) Allwinner a83t: add ccung bits.

Mentor approved after @manu's review

Mon, Nov 20, 3:53 PM

Sun, Nov 19

emaste added a comment to D13122: aw_nmi: add support for a83t's r_intc.

After @manu's review, you have my approval.

Sun, Nov 19, 1:06 AM
emaste committed rS325989: MFC r325444: ANSIfy sys/kern/md4c.c.
MFC r325444: ANSIfy sys/kern/md4c.c
Sun, Nov 19, 12:32 AM
emaste committed rS325988: ANSIfy sys/libkern.
ANSIfy sys/libkern
Sun, Nov 19, 12:31 AM

Fri, Nov 17

emaste added a comment to D12650: Add EFI RTC support.

I believe that the patch was already tested on arm64, IMO amd64 would be much more interesting.

Fri, Nov 17, 9:24 PM
emaste added a comment to D12650: Add EFI RTC support.

Attempting to set the time on OD1000:

root@od1000:~ # date 1711171600
timeout stopping cpus
panic: invalid fpcurthread
cpuid = 2
time = 1510952400
KDB: stack backtrace:
db_trace_self() at db_trace_self_wrapper+0x28
         pc = 0xffff00000060d8f8  lr = 0xffff000000086eec
         sp = 0xffff0000e64e93e0  fp = 0xffff0000e64e95f0
Fri, Nov 17, 9:22 PM
emaste added a comment to D10486: Bug 218860 - libelf doesn't reload section headers after update with ELF_C_WRITE.
In D10486#273287, @cem wrote:

@emaste , @kaiw , any objection to committing this change?

Fri, Nov 17, 8:15 PM
emaste added a comment to D12650: Add EFI RTC support.

I'm building a new kernel to test this on a SoftIron OverDrive 1000 now.

Fri, Nov 17, 3:58 PM
emaste committed rS325916: MFC r325683: vnic: apply BPF tap before passing packet to hardware.
MFC r325683: vnic: apply BPF tap before passing packet to hardware
Fri, Nov 17, 12:38 AM

Thu, Nov 16

emaste added a comment to D13114: Add sanity check for CK_CLYGRP.

Ok, no objection to this patch.

Thu, Nov 16, 6:38 PM
emaste added a comment to D12765: newfs: warn if newer than kernel.

Because we use the new newfs with the old kernel in the release process

Thu, Nov 16, 6:25 PM
emaste added inline comments to D13114: Add sanity check for CK_CLYGRP.
Thu, Nov 16, 3:51 PM
emaste added inline comments to D13114: Add sanity check for CK_CLYGRP.
Thu, Nov 16, 1:05 PM
emaste added a comment to D13114: Add sanity check for CK_CLYGRP.

I think this change is good (modulo kib's comment).

Thu, Nov 16, 12:50 PM
emaste added a comment to D12765: newfs: warn if newer than kernel.
In D12765#272641, @imp wrote:

Won't this trigger every single time we build a snapshot with a kernel that doesn't match?

Thu, Nov 16, 12:43 PM

Wed, Nov 15

emaste closed D12765: newfs: warn if newer than kernel.
Wed, Nov 15, 6:40 PM
emaste committed rS325860: newfs: warn if newer than kernel.
newfs: warn if newer than kernel
Wed, Nov 15, 6:40 PM
emaste closed D13103: Sort pkgbase mtree metadata, for reproducible builds.
Wed, Nov 15, 6:03 PM
emaste committed rS325859: Sort pkgbase mtree metadata, for reproducible builds.
Sort pkgbase mtree metadata, for reproducible builds
Wed, Nov 15, 6:03 PM
emaste updated the diff for D13103: Sort pkgbase mtree metadata, for reproducible builds.
  • fix stray ; \
  • add explicit LC_COLLATE=C per @bapt suggestion
Wed, Nov 15, 2:46 PM
emaste added a comment to D13103: Sort pkgbase mtree metadata, for reproducible builds.
In D13103#272413, @bapt wrote:

You should enforce a locale for sort to produce a consistent output! either LC_COLLATE=C or anything (imho the best is LC_COLLATE=C)

Wed, Nov 15, 2:42 PM
emaste updated subscribers of D13103: Sort pkgbase mtree metadata, for reproducible builds.
Wed, Nov 15, 2:01 PM
emaste created D13103: Sort pkgbase mtree metadata, for reproducible builds.
Wed, Nov 15, 1:57 PM

Tue, Nov 14

emaste added a comment to D13018: vmtotal: extend counters to match reality.

I would put the 64-bit fields first, and make the whole struct 8-byte aligned, but I'll defer to any suggestion kib might offer.

Tue, Nov 14, 7:57 PM
emaste committed rS325825: disallow clock_settime too far in the future to avoid panic.
disallow clock_settime too far in the future to avoid panic
Tue, Nov 14, 6:18 PM
emaste accepted D12631: patch(1): don't assume a match if we run out of context to check.

As long as the ports tree is good let's get this back in.

Tue, Nov 14, 5:31 PM
emaste committed rS325811: vnic: report that the driver supports multicast.
vnic: report that the driver supports multicast
Tue, Nov 14, 4:31 PM
emaste added a comment to D13018: vmtotal: extend counters to match reality.
In D13018#272087, @kib wrote:

The problem which I envision is that the uint64_t type has 8-bytes alignment on amd64, but only 4-bytes on i386.

Tue, Nov 14, 3:41 PM

Mon, Nov 13

emaste added inline comments to D13018: vmtotal: extend counters to match reality.
Mon, Nov 13, 11:57 PM
emaste added a comment to D12912: Don't fail the build due to clang integer constant range warnings.

How many warnings of this type does the build produce?

Mon, Nov 13, 6:56 PM

Sun, Nov 12

emaste committed rS325744: boot1: also check for NULL device.
boot1: also check for NULL device
Sun, Nov 12, 5:16 PM

Fri, Nov 10

emaste committed rS325683: vnic: apply BPF tap before passing packet to hardware.
vnic: apply BPF tap before passing packet to hardware
Fri, Nov 10, 10:17 PM
emaste closed D13038: Add check to avoid freeing null pointer in boot1.c.
Fri, Nov 10, 9:27 PM
emaste committed rS325681: boot1: avoid using NULL device path.
boot1: avoid using NULL device path
Fri, Nov 10, 9:27 PM
emaste added inline comments to D13038: Add check to avoid freeing null pointer in boot1.c.
Fri, Nov 10, 8:54 PM
emaste added a comment to D13038: Add check to avoid freeing null pointer in boot1.c.

Also for the commit message -- it's not freeing that we need to avoid, it's using the null pointer at all. free(NULL) is actually fine. it's the printf/setenv that we can't pass a NULL pointer to.

Fri, Nov 10, 8:44 PM
emaste accepted D13038: Add check to avoid freeing null pointer in boot1.c.
Fri, Nov 10, 8:34 PM
emaste committed rS325664: Strip EOL whitespace in usr.sbin/{jail,jexec}.
Strip EOL whitespace in usr.sbin/{jail,jexec}
Fri, Nov 10, 2:53 PM
emaste updated the diff for D13028: vnic: correct and simplify SIOCSIFFLAGS ioctl.

undo accidental if_getdrvflags breakage

Fri, Nov 10, 2:40 PM
emaste created D13028: vnic: correct and simplify SIOCSIFFLAGS ioctl.
Fri, Nov 10, 2:36 PM

Thu, Nov 9

emaste updated subscribers of D13015: Axe xlint..
In D13015#270388, @kib wrote:

Aren't they automatically re-generated by somebody else ? I did found them by grepping, and decided not to update because they are not human-editable. Am I wrong ?

Thu, Nov 9, 2:46 PM
emaste accepted D12985: bhyve: don't try to capsicumise after failed open.
Thu, Nov 9, 2:41 PM · bhyve
emaste accepted D13015: Axe xlint..

There are also adjustments to make in targets/pseudo/hosttools/Makefile.depend.host and targets/pseudo/userland/Makefile.depend

Thu, Nov 9, 2:27 PM

Wed, Nov 8

emaste committed rS325523: MFC r325420: lld: accept EINVAL to indicate posix_fallocate is unsupported.
MFC r325420: lld: accept EINVAL to indicate posix_fallocate is unsupported
Wed, Nov 8, 12:45 AM

Sun, Nov 5

emaste committed rS325444: ANSIfy sys/kern/md4c.c.
ANSIfy sys/kern/md4c.c
Sun, Nov 5, 7:50 PM
emaste committed rS325422: posix_fallocate.2: add an EINVAL errno case.
posix_fallocate.2: add an EINVAL errno case
Sun, Nov 5, 3:02 AM
emaste committed rS325420: lld: accept EINVAL to indicate posix_fallocate is unsupported.
lld: accept EINVAL to indicate posix_fallocate is unsupported
Sun, Nov 5, 12:52 AM

Fri, Nov 3

emaste accepted D12925: Only build the libmagic build-tools if MK_FILE != no.

LGTM

Fri, Nov 3, 11:12 PM

Thu, Nov 2

emaste accepted D12910: Remove -fuse-ld= when creating _LDFLAGS from LDFLAGS.
Thu, Nov 2, 2:18 PM
emaste accepted D11925: Export std::get_new_handler() from libcxxrt.so.
Thu, Nov 2, 1:46 PM

Wed, Nov 1

emaste added a comment to D12840: Add option UNIFIED_OBJDIR, on by default, which moves the default build OBJDIR..

Should we make a reference to WITHOUT_UNIFIED_OBJDIR being a transition aid that will be removed later on? (for 12.0)?

Wed, Nov 1, 12:22 AM

Tue, Oct 31

emaste added a comment to D12631: patch(1): don't assume a match if we run out of context to check.

Or even a small example just in this Phabricator review that demonstrates the issue?

Tue, Oct 31, 2:57 PM
emaste accepted D12631: patch(1): don't assume a match if we run out of context to check.

Approved. Could we add a simple test case too?

Tue, Oct 31, 2:40 PM

Mon, Oct 30

emaste added a comment to D12817: Follow-up r320149: Enable GPL_DTC if we're using GCC as the cross-compiler..

I think so - I'm not suggesting we add GPL_DTC_BOOTSTRAP since it seems it would be more complexity than is warranted, but just checking that the reason we don't have this same problem with Clang is because it's split out into separate enables for the boostrap and installed cases.

Mon, Oct 30, 6:26 PM

Sun, Oct 29

emaste added a comment to D12817: Follow-up r320149: Enable GPL_DTC if we're using GCC as the cross-compiler..

Is it the case that the other C++11 option in this block (CLANG) works only because it is split into CLANG and CLANG_BOOTSTRAP? It would otherwise have the same problem, yes?

Sun, Oct 29, 2:02 PM

Fri, Oct 27

emaste committed rS325047: dma: fix use-after-free.
dma: fix use-after-free
Fri, Oct 27, 8:21 PM
emaste added a comment to D12717: Import libipt.

Oops, pasted in the wrong review.

Fri, Oct 27, 6:55 PM
emaste updated subscribers of D12717: Import libipt.

I agree with @kib that this should be a private lib

Fri, Oct 27, 6:54 PM
emaste committed rS325042: libdtrace: replace "DOODAD" with more descriptive string.
libdtrace: replace "DOODAD" with more descriptive string
Fri, Oct 27, 4:23 PM

Oct 24 2017

emaste added a comment to D12718: add libpmcstat.

It is moved around, so I am not sure what is your point.

Oct 24 2017, 2:26 PM
emaste added a comment to D12718: add libpmcstat.

This stuff would greatly benefit from more cleanup

Oct 24 2017, 1:47 PM
emaste committed rS324942: MFC r324683: write.2: correct maximum nbytes size for EINVAL error.
MFC r324683: write.2: correct maximum nbytes size for EINVAL error
Oct 24 2017, 12:32 AM

Oct 23 2017

emaste committed rS324936: uefi.8: mention use on (32-bit) arm.
uefi.8: mention use on (32-bit) arm
Oct 23 2017, 8:32 PM
emaste created D12765: newfs: warn if newer than kernel.
Oct 23 2017, 12:44 AM