- User Since
- Nov 24 2013, 3:15 AM (281 w, 6 d)
Thu, Apr 18
Wed, Apr 17
cap_fileargs change committed in:
looks good, thanks
Tue, Apr 16
I'm fine with this as an immediate fix for the installer/VM boot issues.
Mon, Apr 15
FYI if you put just the D19507 reference (not the full URL) in a comment Phabricator will create a cross-reference automatically.
tested on eMAG and ThunderX2
Sun, Apr 14
Fri, Apr 12
Tested eMAG on rS237234 + this change, serial console works as expected for initial boot messages until encountering AcpiExSystemMemorySpaceHandler panic same as reported in PR 237055. Will test on ThunderX2 soon.
Thu, Apr 11
The set -e issue has to be addressed one way or another.
I needed to add -O1 to stand/defs.mk else the loader was too big
I think this is fine other than the set -e issue mentioned earlier.
Wed, Apr 10
Conceptually this LGTM, but I will defer to ports folks for implementation details related to MD/MI ports.
OR are you suggesting have:
Tue, Apr 9
Some proposed style(9) fixups in https://github.com/emaste/freebsd/commit/8506f5949cb13d54a688414c5aae3f696e33db42
Mon, Apr 8
Could we (also) add assertions in pidfile_open for this case?
Fri, Apr 5
commit 122d67f846cb0be2c9e1c3880db9eb9545bbe38c Author: Rich Felker <firstname.lastname@example.org> Date: Thu Nov 8 15:00:02 2018 -0500
This LGTM as long as compilers or static analyzers don't try to "helpfully" warn that the string does not fit or will not be null terminated.
Thu, Apr 4
Wed, Apr 3
Tue, Apr 2
Mon, Apr 1
I think it makes sense to svn cp first, then apply the changes to the contrib/ location; is that your plan?
Please reference the upstream pull request in the commit (perhaps mentioning that upstream has been slow on addressing PRs).
Sun, Mar 31
Can you generate a review that's just the local diffs, i.e., after the svn cp?
Sat, Mar 30
Fri, Mar 29
The downside of adding these is just the extra loops?
Approved. Please test make tinderbox though.