Page MenuHomeFreeBSD

emaste (Ed Maste)
UserAdministrator

Projects (15)

User Details

User Since
Nov 24 2013, 3:15 AM (542 w, 1 d)
Roles
Administrator

Recent Activity

Today

emaste accepted D42790: git/mfc-candidates.sh: allow comments in exclude file.
Mon, Apr 15, 5:53 PM
emaste added inline comments to D44774: carp: support VRRPv3.
Mon, Apr 15, 5:47 PM
emaste accepted D44587: LinuxKPI: add __counted_by() and __nonstring.

LGTM, CC @dim in case he has any extra insight on the two forms.

Mon, Apr 15, 5:01 PM
emaste accepted D44798: man: do not ignore the exit status of roff tools.

OK. Discarding errors from $cattool is not directly related to the original issue, right?

Mon, Apr 15, 1:16 PM
emaste accepted D44590: LinuxKPI: sk_buff: implement skb_queue_splice_tail_init().
Mon, Apr 15, 1:20 AM

Sat, Apr 13

emaste accepted D44782: NOTES: Move the VirtIO entries to the MI NOTES file.
Sat, Apr 13, 10:22 PM

Wed, Apr 10

emaste accepted D44735: vmm: Define a dummy _start symbol in vmm_hyp_blob.elf.
Wed, Apr 10, 2:19 PM
emaste accepted D44732: pciconf(8): dump AMD IOMMU Base Capability.
Wed, Apr 10, 12:28 AM
emaste accepted D44732: pciconf(8): dump AMD IOMMU Base Capability.
Wed, Apr 10, 12:14 AM

Tue, Apr 9

emaste committed rG54030e8a5df5: dma.conf: Fix typo (authored by Mikael Urankar <mikael@FreeBSD.org>).
dma.conf: Fix typo
Tue, Apr 9, 1:39 PM
emaste committed rGc525951492dd: freebsd-update: Fix typo in comment (authored by a-biardi <a.biardi@tiscali.it>).
freebsd-update: Fix typo in comment
Tue, Apr 9, 1:39 PM
emaste committed rG8e8d76571f77: ccdconfig: reference gpart rather than fdisk and disklabel (authored by emaste).
ccdconfig: reference gpart rather than fdisk and disklabel
Tue, Apr 9, 1:38 PM
emaste committed rGda7a43501881: ccdconfig: remove obsolete references to BSD disklabels (authored by emaste).
ccdconfig: remove obsolete references to BSD disklabels
Tue, Apr 9, 1:38 PM
emaste committed rG7ced57106295: ccdconfig: reference gpart rather than fdisk and disklabel (authored by emaste).
ccdconfig: reference gpart rather than fdisk and disklabel
Tue, Apr 9, 1:36 PM

Sun, Apr 7

emaste committed rGe8b7c78c1b38: Cirrus-CI: switch to llvm18 by default (authored by emaste).
Cirrus-CI: switch to llvm18 by default
Sun, Apr 7, 9:24 PM
emaste committed rG9031978083ce: rights.4: add note about rights not being simple bitmasks (authored by emaste).
rights.4: add note about rights not being simple bitmasks
Sun, Apr 7, 4:59 PM
emaste committed rGa2ce5a2dc95f: tar: make error reporting more robust and use correct errno (authored by emaste).
tar: make error reporting more robust and use correct errno
Sun, Apr 7, 4:59 PM
emaste committed rG6ac10e8a72a7: rights.4: add note about rights not being simple bitmasks (authored by emaste).
rights.4: add note about rights not being simple bitmasks
Sun, Apr 7, 4:35 PM
emaste committed rG507e18dfc324: freebsd-update: Fix typo in comment (authored by a-biardi <a.biardi@tiscali.it>).
freebsd-update: Fix typo in comment
Sun, Apr 7, 4:35 PM
emaste committed rGbedc8daace26: dma.conf: Fix typo (authored by Mikael Urankar <mikael@FreeBSD.org>).
dma.conf: Fix typo
Sun, Apr 7, 4:35 PM

Sat, Apr 6

emaste added a comment to D44587: LinuxKPI: add __counted_by() and __nonstring.

From a textcase in the LLVM review that introduced it (https://reviews.llvm.org/D148381):

Sat, Apr 6, 10:30 PM

Fri, Apr 5

emaste accepted D44643: Add OpenBSD 7.5 to bsd-family-tree.
Fri, Apr 5, 1:35 PM
emaste accepted D44614: exports.5: Clarify that exported dirs should be local mount points.
Fri, Apr 5, 12:23 PM
emaste accepted D44636: tarfs.5: Provide some guidance on zstd frame sizes.
Fri, Apr 5, 12:21 PM

Thu, Apr 4

emaste added a comment to D44583: LinuxKPI: Remove an unused local var fileid from the macro request_module.

I was just curious how (and why) this got spotted given it's been sitting there like this for a decade.

Thu, Apr 4, 6:52 PM
emaste added a comment to D44583: LinuxKPI: Remove an unused local var fileid from the macro request_module.

I don't know if the code path in drm_encoder_slave.c actually uses this

Thu, Apr 4, 6:36 PM
emaste accepted D44583: LinuxKPI: Remove an unused local var fileid from the macro request_module.

sure, there is no need to pass in a temporary variable just to discard the result

Thu, Apr 4, 6:17 PM
emaste accepted D44636: tarfs.5: Provide some guidance on zstd frame sizes.

This LGTM thanks

Thu, Apr 4, 5:19 PM

Wed, Apr 3

emaste added inline comments to D44618: fusefs: fix two bugs regarding _PC_MIN_HOLE_SIZE.
Wed, Apr 3, 9:44 PM
emaste accepted D44614: exports.5: Clarify that exported dirs should be local mount points.
Wed, Apr 3, 4:28 PM
emaste added a comment to D44614: exports.5: Clarify that exported dirs should be local mount points.

It's a bit terse, but: https://docs.freebsd.org/en/books/handbook/zfs/#zfs-zfs-set-share

Wed, Apr 3, 4:27 PM
emaste added a comment to D44614: exports.5: Clarify that exported dirs should be local mount points.

(Do we have something like Klara's https://klarasystems.com/articles/nfs-shares-with-zfs/ in a man page or the Handbook?)

Wed, Apr 3, 2:48 PM
emaste added a comment to D44614: exports.5: Clarify that exported dirs should be local mount points.

Should we mention something about ZFS here? I guess there should be a high-level section on ZFS/NFS that has a xref to wherever the sharenfs property is documented, and we could have an internal reference to tat section from the "Note well" text.

Wed, Apr 3, 2:47 PM
emaste committed rG26c9cc10b220: boot0: remove reference to fdisk (authored by emaste).
boot0: remove reference to fdisk
Wed, Apr 3, 1:08 PM
emaste committed rGbade279b8106: tar: make error reporting more robust and use correct errno (authored by emaste).
tar: make error reporting more robust and use correct errno
Wed, Apr 3, 1:08 PM
emaste accepted D44603: LinuxKPI: add BITS_TO_BYTES().
Wed, Apr 3, 1:08 AM

Tue, Apr 2

emaste committed rG51b2556ee60a: bsdlabel: add BUGS section documenting 8 partition limit (authored by emaste).
bsdlabel: add BUGS section documenting 8 partition limit
Tue, Apr 2, 1:59 PM
emaste committed rG1f97fc87f1a6: Cirrus-CI: Add manual Clang 18 jobs (authored by emaste).
Cirrus-CI: Add manual Clang 18 jobs
Tue, Apr 2, 1:58 PM
emaste committed rG9f9289901c86: bsdlabel: add BUGS section documenting 8 partition limit (authored by emaste).
bsdlabel: add BUGS section documenting 8 partition limit
Tue, Apr 2, 1:57 PM
emaste committed rG8db49fc84c53: msgs: Use C99 bool instead of defining our own (authored by collin.funk1_gmail.com).
msgs: Use C99 bool instead of defining our own
Tue, Apr 2, 1:55 PM
emaste committed rG918117116254: freebsd-update: Fix typo in comment (authored by a-biardi <a.biardi@tiscali.it>).
freebsd-update: Fix typo in comment
Tue, Apr 2, 12:46 PM
emaste accepted D44591: LinuxKPI: napi_schedule() requires return value.
Tue, Apr 2, 12:20 PM
emaste added inline comments to D44590: LinuxKPI: sk_buff: implement skb_queue_splice_tail_init().
Tue, Apr 2, 12:18 PM
emaste accepted D44588: LinuxKPI: add dev_alloc_pages().
Tue, Apr 2, 12:14 PM
emaste accepted D44587: LinuxKPI: add __counted_by() and __nonstring.

In general __has_attribute(foo) to check
I think this is fine to get the driver compiling but ought to have a TODO comment

Tue, Apr 2, 12:12 PM
emaste accepted D44586: LinuxKPI: implement memzero_explicit().
Tue, Apr 2, 12:09 PM
emaste added a comment to D44586: LinuxKPI: implement memzero_explicit().

as an aside we should really add memset_explicit to libc and libkern

Tue, Apr 2, 12:09 PM
emaste accepted D44525: linux: support IUTF8.
Tue, Apr 2, 12:06 PM

Mon, Apr 1

emaste committed rG7249e0d28c23: crunch: remove fdisk from examples (authored by emaste).
crunch: remove fdisk from examples
Mon, Apr 1, 11:51 PM
emaste committed rG87c576a25a1f: release: rework distributions list (authored by emaste).
release: rework distributions list
Mon, Apr 1, 11:51 PM

Sun, Mar 31

emaste committed rGd68c68693e11: tar: make error reporting more robust and use correct errno (authored by emaste).
tar: make error reporting more robust and use correct errno
Sun, Mar 31, 2:41 PM

Sat, Mar 30

emaste accepted D44557: Document some best practices related to vendor import:.

I'm fine with this version, or with some updates for @imp's notes.

Sat, Mar 30, 9:39 PM
emaste added inline comments to D44557: Document some best practices related to vendor import:.
Sat, Mar 30, 9:37 PM

Fri, Mar 29

emaste added inline comments to D44557: Document some best practices related to vendor import:.
Fri, Mar 29, 4:50 PM
emaste added a comment to D44546: sound: Make verbose sndstat output more readable.

So, the patch will break this, but I think OBS has to be patched anyway...

Fri, Mar 29, 12:54 PM

Thu, Mar 28

emaste committed R9:593c16f52c2b: EOL: Bump stable/13 to April 30, 2026 (authored by emaste).
EOL: Bump stable/13 to April 30, 2026
Thu, Mar 28, 3:35 PM
emaste added a comment to D44546: sound: Make verbose sndstat output more readable.

Note that there is software that parses /dev/sndstat, e.g.
https://github.com/obsproject/obs-studio/blob/6f3f7b4e5a561a02bc0c7cd37260cd7814fba1a9/plugins/oss-audio/oss-input.c#L463

Thu, Mar 28, 2:21 PM
emaste closed D42487: handbook/serialcomms: update for 115200 bps default.
Thu, Mar 28, 12:51 PM
emaste committed R9:bfe164303878: serialcomms: update for 115200 bps default (authored by emaste).
serialcomms: update for 115200 bps default
Thu, Mar 28, 12:51 PM
emaste committed R9:50aa88e00999: Update SA and EN templates from secteam SVN repo (authored by emaste).
Update SA and EN templates from secteam SVN repo
Thu, Mar 28, 12:37 PM

Wed, Mar 27

emaste accepted D44522: amd64: handle MXCSR from XSAVEOPT when x87 state was optimized.
Wed, Mar 27, 4:54 PM
emaste added inline comments to D44522: amd64: handle MXCSR from XSAVEOPT when x87 state was optimized.
Wed, Mar 27, 3:38 PM
emaste committed rGc92400a6f690: dma.conf: Fix typo (authored by Mikael Urankar <mikael@FreeBSD.org>).
dma.conf: Fix typo
Wed, Mar 27, 3:14 PM
emaste added a comment to D44522: amd64: handle MXCSR from XSAVEOPT when x87 state was optimized.

I'm not fully familiar with the xsave details - I'm curious why this was AMD-specific (and/or, what implies that the x87 area was not saved, in the new block)?

Wed, Mar 27, 1:25 PM

Tue, Mar 26

emaste added a comment to D44499: Clarify how exports work for administrative controls.

See also: D44502

Tue, Mar 26, 11:52 PM
emaste accepted D44499: Clarify how exports work for administrative controls.
Tue, Mar 26, 11:51 PM
emaste accepted D44502: Make mountd generate warning log messages when administrative controls exports entire file systems.
Tue, Mar 26, 12:29 AM

Mon, Mar 25

emaste committed rGb16cb28aca00: ssh: Update to OpenSSH 9.7p1 (authored by emaste).
ssh: Update to OpenSSH 9.7p1
Mon, Mar 25, 10:40 PM
emaste committed rG495bdd698e42: linuxkpi: remove invalid KASSERT from hash_add_rcu (authored by emaste).
linuxkpi: remove invalid KASSERT from hash_add_rcu
Mon, Mar 25, 10:32 PM
emaste committed rG464fa66f639b: ssh: Update to OpenSSH 9.7p1 (authored by emaste).
ssh: Update to OpenSSH 9.7p1
Mon, Mar 25, 10:32 PM
emaste committed rGc9bd948da3c8: arm64: Save an instruction in locore.S (authored by gfunni234_gmail.com).
arm64: Save an instruction in locore.S
Mon, Mar 25, 10:30 PM
emaste committed rG3f8927179476: blacklistd: Handle fds that are pointing to routing sockets (authored by jlduran_gmail.com).
blacklistd: Handle fds that are pointing to routing sockets
Mon, Mar 25, 10:29 PM
emaste committed rG602ea0ced129: sound: Fix OSS API requests for more than 8 channels (authored by dev_submerge.ch).
sound: Fix OSS API requests for more than 8 channels
Mon, Mar 25, 10:29 PM
emaste committed rG49e126a03b6b: ctfmerge: demote "No ctf sections found" to a warning (authored by emaste).
ctfmerge: demote "No ctf sections found" to a warning
Mon, Mar 25, 10:28 PM
emaste committed rG7dc5c6c4120e: bsdlabel: add BUGS section documenting 8 partition limit (authored by emaste).
bsdlabel: add BUGS section documenting 8 partition limit
Mon, Mar 25, 10:27 PM
emaste added a comment to D43575: fdisk: disconnect from the build.

I won't commit this before all dependencies are addressed - mainly I want to get deprecation notices into the tree and MFC'd.

Mon, Mar 25, 10:20 PM
emaste added a comment to D44500: tzsetup: be explicit about *timezone* abbreviation.

I'm not entirely convinced this dialog should exist at all...

Mon, Mar 25, 8:42 PM
emaste requested review of D44500: tzsetup: be explicit about *timezone* abbreviation.
Mon, Mar 25, 8:28 PM
emaste closed D43586: bsdlabel: emit deprecation notice when run.

Committed (with typo in Differential Revision, which is why it didn't auto-close)

Mon, Mar 25, 8:22 PM
emaste added a comment to D43585: fdisk: emit deprecation notice when run.

It seems I haven't proposed a deprecation notice for the fdisk.8 man page yet

Mon, Mar 25, 8:01 PM
emaste committed rG3bd637afbd68: boot0: remove reference to fdisk (authored by emaste).
boot0: remove reference to fdisk
Mon, Mar 25, 8:00 PM
emaste committed rG3661658c76ce: bsdlabel: emit deprecation notice when run (authored by emaste).
bsdlabel: emit deprecation notice when run
Mon, Mar 25, 8:00 PM
emaste updated subscribers of D44499: Clarify how exports work for administrative controls.
Mon, Mar 25, 7:51 PM
emaste accepted D44499: Clarify how exports work for administrative controls.

makes sense to me. a couple of little notes on phrasing

Mon, Mar 25, 7:50 PM
emaste committed rGb6f3cced151f: bsdlabel: add deprecation notice (authored by emaste).
bsdlabel: add deprecation notice
Mon, Mar 25, 7:44 PM
emaste closed D43563: bsdlabel: add legacy notice.
Mon, Mar 25, 7:44 PM
emaste accepted D44497: x86: test the right CPUID bit when checking for XSAVEOPT support.
Mon, Mar 25, 5:29 PM
emaste accepted D44498: amd64: initialize td_frame stack area for init(8) main thread.
Mon, Mar 25, 3:21 PM
emaste added a comment to D44498: amd64: initialize td_frame stack area for init(8) main thread.

Would it be excessive to just zero td_frame in MI code?

Mon, Mar 25, 1:59 PM

Sun, Mar 24

emaste committed rGadc61137fdf7: Cirrus-CI: bump Clang versions to 16 and 17 (authored by emaste).
Cirrus-CI: bump Clang versions to 16 and 17
Sun, Mar 24, 5:50 PM
emaste committed rGc3c2233c9673: gpioevents: Fix build with newer Clang (authored by John F. Carr <jfc@mit.edu>).
gpioevents: Fix build with newer Clang
Sun, Mar 24, 5:49 PM

Sat, Mar 23

emaste updated subscribers of D44453: coredirector - Intel TD/HFI driver - Part1: Add ITD/HFI related MSR/CPUID defines to specialregs.h.

FYI, if you have reason to upload new patches please include full context (via e.g. git show -U999999) - see https://wiki.freebsd.org/Phabricator for details.

Sat, Mar 23, 2:33 PM

Fri, Mar 22

emaste committed rG0459337491cd: makefs: warn that ffs sectorsize other than 512 may not work (authored by emaste).
makefs: warn that ffs sectorsize other than 512 may not work
Fri, Mar 22, 7:04 PM
emaste committed rG8669e516f0e6: ccdconfig: reference gpart rather than fdisk and disklabel (authored by emaste).
ccdconfig: reference gpart rather than fdisk and disklabel
Fri, Mar 22, 6:51 PM
emaste closed D43564: ccdconfig: reference gpart rather than fdisk and disklabel.
Fri, Mar 22, 6:51 PM
emaste committed rGa59eba2caacf: bsdlabel: limit to 8 partitions (authored by emaste).
bsdlabel: limit to 8 partitions
Fri, Mar 22, 6:45 PM
emaste committed rG8e402178193f: makefs: warn that ffs sectorsize other than 512 may not work (authored by emaste).
makefs: warn that ffs sectorsize other than 512 may not work
Fri, Mar 22, 6:44 PM
emaste committed rGa323dd42bcac: bsdlabel: limit to 8 partitions (authored by emaste).
bsdlabel: limit to 8 partitions
Fri, Mar 22, 6:43 PM
emaste committed rG537bdafbc25d: rights.4: add note about rights not being simple bitmasks (authored by emaste).
rights.4: add note about rights not being simple bitmasks
Fri, Mar 22, 2:03 PM
emaste closed D44473: rights.4: add note about rights not being simple bitmasks.
Fri, Mar 22, 2:03 PM