Page MenuHomeFreeBSD

emaste (Ed Maste)
UserAdministrator

Projects (8)

User Details

User Since
Nov 24 2013, 3:15 AM (307 w, 1 d)
Roles
Administrator

Recent Activity

Fri, Oct 11

emaste accepted D21983: Centralize adding OBJCOPY=${XOBJCOPY} to LIB32WMAKEFLAGS..
Fri, Oct 11, 7:36 PM

Wed, Oct 9

emaste updated the diff for D21945: kvm: fix types for `kvm_walk_pages`.

update comment again

Wed, Oct 9, 11:44 PM
emaste updated the diff for D21945: kvm: fix types for `kvm_walk_pages`.

update comment per jhb

Wed, Oct 9, 11:42 PM
emaste updated the diff for D21945: kvm: fix types for `kvm_walk_pages`.

chase member rename

Wed, Oct 9, 11:40 PM
emaste added inline comments to D21947: gcore: Add aarch64 32-bit core support.
Wed, Oct 9, 4:46 PM
emaste added a comment to D21775: (WIP) Rewrite makesyscalls.sh in Lua.

Can lua not continue a string on the next line?

Wed, Oct 9, 4:42 PM
emaste committed rS353347: MFC r353021: simplify path handling in sysctl_try_reclaim_vnode.
MFC r353021: simplify path handling in sysctl_try_reclaim_vnode
Wed, Oct 9, 2:35 PM
emaste updated the summary of D21945: kvm: fix types for `kvm_walk_pages`.
Wed, Oct 9, 1:13 PM
emaste updated the summary of D19183: libkvm: Fix the kvm_walk_pages in amd64.
Wed, Oct 9, 1:08 PM
emaste added a comment to D21945: kvm: fix types for `kvm_walk_pages`.

Note that the types are the same size on LP64 archs. This breaks the ABI on ILP32.

Wed, Oct 9, 1:05 PM
emaste added a reviewer for D21945: kvm: fix types for `kvm_walk_pages`: will.
Wed, Oct 9, 12:59 PM
emaste accepted D21942: Don't compile old gcc 4.2.1 archs by default in universe/tinderbox..
Wed, Oct 9, 12:52 PM

Tue, Oct 8

emaste updated subscribers of D19183: libkvm: Fix the kvm_walk_pages in amd64.
Tue, Oct 8, 8:56 PM
emaste added inline comments to D21945: kvm: fix types for `kvm_walk_pages`.
Tue, Oct 8, 6:31 PM
emaste added a reviewer for D21945: kvm: fix types for `kvm_walk_pages`: brooks.
Tue, Oct 8, 6:30 PM
emaste created D21945: kvm: fix types for `kvm_walk_pages`.
Tue, Oct 8, 6:29 PM
emaste added inline comments to D21942: Don't compile old gcc 4.2.1 archs by default in universe/tinderbox..
Tue, Oct 8, 5:56 PM
emaste requested changes to D21942: Don't compile old gcc 4.2.1 archs by default in universe/tinderbox..
Tue, Oct 8, 5:13 PM
emaste added a comment to D21886: Add USB support for location based device unit numbers.

Of course, totally identical devices (down to serial numbers) can still cause confusion.

Tue, Oct 8, 4:12 PM
emaste added a comment to D21886: Add USB support for location based device unit numbers.

My use case for something like this is a USB-serial console server where I might have 16 different USB-serial adapters attached to various USB hubs; I intended to address it by using the serial number in each device.

Tue, Oct 8, 3:06 PM

Fri, Oct 4

emaste committed rS353109: MFC r352796: Check the vfs option length is valid before accessing through.
MFC r352796: Check the vfs option length is valid before accessing through
Fri, Oct 4, 5:28 PM
emaste updated subscribers of D21893: Add flua to the base system, install to /usr/libexec.
Fri, Oct 4, 12:55 PM

Thu, Oct 3

emaste committed rS353044: MFC r352742: bspatch: add integer overflow checks.
MFC r352742: bspatch: add integer overflow checks
Thu, Oct 3, 1:04 PM
emaste committed rS353043: MFC r352742: bspatch: add integer overflow checks.
MFC r352742: bspatch: add integer overflow checks
Thu, Oct 3, 1:02 PM
emaste committed rS353042: Remove host binary object drivers from GENERIC.
Remove host binary object drivers from GENERIC
Thu, Oct 3, 12:52 PM
emaste closed D21865: avoid compiling in hpt* drivers containing binary blobs.
Thu, Oct 3, 12:52 PM

Wed, Oct 2

emaste closed D21876: simplify path handling in sysctl_try_reclaim_vnode.
Wed, Oct 2, 9:01 PM
emaste committed rS353021: simplify path handling in sysctl_try_reclaim_vnode.
simplify path handling in sysctl_try_reclaim_vnode
Wed, Oct 2, 9:01 PM
emaste accepted D21861: Add a KLD_SHARED variable to kmod.mk..
Wed, Oct 2, 7:41 PM
emaste added a comment to D21865: avoid compiling in hpt* drivers containing binary blobs.

I'm mostly in favor of the change (smaller kernel size, etc.), but since we are removing driver from GENERIC, it's better if we can provide a mechanism to load the driver on demand, or a binary update can easily brick the system...

Wed, Oct 2, 6:30 PM
emaste accepted D21696: Re-add ALLOW_MIPS_SHARED_TEXTREL, sprinkle it around.

looks ok to me

Wed, Oct 2, 6:23 PM
emaste accepted D21861: Add a KLD_SHARED variable to kmod.mk..
Wed, Oct 2, 6:22 PM
emaste updated the diff for D21876: simplify path handling in sysctl_try_reclaim_vnode.

Drop min and make the test >= PATH_MAX. As the sysctl passes the string excluding the NUL req->newlen equal to PATH_MAX is too long.

Wed, Oct 2, 5:00 PM
emaste added inline comments to D21876: simplify path handling in sysctl_try_reclaim_vnode.
Wed, Oct 2, 4:55 PM
emaste updated the diff for D21876: simplify path handling in sysctl_try_reclaim_vnode.

Correct per @kib

Wed, Oct 2, 3:33 PM
emaste added inline comments to D21876: simplify path handling in sysctl_try_reclaim_vnode.
Wed, Oct 2, 2:29 PM
emaste added a comment to D21876: simplify path handling in sysctl_try_reclaim_vnode.

Ah, I probably just grepped in sys/kern. I'll take a look at a patch for nfs_nfsdport.c in a bit - it's not so straightforward.

Wed, Oct 2, 1:52 PM
emaste updated subscribers of D21876: simplify path handling in sysctl_try_reclaim_vnode.
Wed, Oct 2, 1:43 PM
emaste added a comment to D21876: simplify path handling in sysctl_try_reclaim_vnode.

@kib pointed out on IRC that the original PATH_MAX + 1 is incorrect but arguably innocent and I agree, but think it is worth the change to avoid confusing folks (who find that code) into wondering if PATH_MAX includes space for the NUL or not - that's what prompted me to look at this in the first place.

Wed, Oct 2, 1:43 PM
emaste added inline comments to D21876: simplify path handling in sysctl_try_reclaim_vnode.
Wed, Oct 2, 1:41 PM
emaste added inline comments to D20519: Add a debugging facility to manually reclaim a vnode.
Wed, Oct 2, 1:36 PM
emaste created D21876: simplify path handling in sysctl_try_reclaim_vnode.
Wed, Oct 2, 1:35 PM
emaste added inline comments to D20519: Add a debugging facility to manually reclaim a vnode.
Wed, Oct 2, 12:55 PM

Tue, Oct 1

emaste added a comment to D21861: Add a KLD_SHARED variable to kmod.mk..

I wonder if it's worth committing all but actually switching amd64 to KLD_SHARED, then making that change separately.

Tue, Oct 1, 9:08 PM
emaste accepted D21866: Harmonize the hptmv blob build rule with other hpt* drivers..
Tue, Oct 1, 9:04 PM
emaste updated subscribers of D21865: avoid compiling in hpt* drivers containing binary blobs.
Tue, Oct 1, 8:23 PM
emaste created D21865: avoid compiling in hpt* drivers containing binary blobs.
Tue, Oct 1, 8:22 PM
emaste added inline comments to D21861: Add a KLD_SHARED variable to kmod.mk..
Tue, Oct 1, 7:48 PM
emaste committed rS352931: sysalls.master: remove superfluous ellipsis in comment.
sysalls.master: remove superfluous ellipsis in comment
Tue, Oct 1, 5:05 PM

Mon, Sep 30

emaste added a comment to D2418: Add support for launching soft-float binaries with ld-elf-soft.so instead of ld-elf.so ala ld-elf32.so..

Just abandon it then I guess?

Mon, Sep 30, 5:31 PM
emaste committed rD53443: pin 11.2 EOL to October 31, 2019.
pin 11.2 EOL to October 31, 2019
Mon, Sep 30, 4:48 PM
emaste added a reviewer for D21606: linux_renameat2: improve flag checks: kaktus.
Mon, Sep 30, 4:04 PM
emaste accepted D21852: linux_renameat2: don't add extra \n on error.
Mon, Sep 30, 4:03 PM
emaste accepted D21830: Rename etc/rc.d/abi to etc/rc.d/linux.
Mon, Sep 30, 1:55 PM
emaste added a comment to D2292: elfcopy/strip: Ensure sections have required alignment on output.

It may be that the right approach is to just have elfcopy/strip fail on such broken input and we should just drop this patch.

Mon, Sep 30, 1:53 PM
emaste updated the diff for D2292: elfcopy/strip: Ensure sections have required alignment on output.

Actually set alignment in output

Mon, Sep 30, 1:18 PM
emaste added a comment to D2418: Add support for launching soft-float binaries with ld-elf-soft.so instead of ld-elf.so ala ld-elf32.so..

What do we do with this change?

Mon, Sep 30, 1:17 PM
emaste added reviewers for D2292: elfcopy/strip: Ensure sections have required alignment on output: markj, jkoshy_users.sourceforge.net.
Mon, Sep 30, 1:07 PM
emaste added a comment to D21851: extend in-tree toolchain check to suggest xtoolchain package.

Previously we checked for only BINUTILS_BOOTSTRAP as a broken option and suggested installing the binutils package. This was originally done for arm64 where we used the in-tree Clang and external binutils package. Extend the warning to suggest instead the full xtoolchain package if we have no in-tree compiler either.

Mon, Sep 30, 1:01 PM
emaste created D21851: extend in-tree toolchain check to suggest xtoolchain package.
Mon, Sep 30, 12:59 PM

Fri, Sep 27

emaste accepted D21821: Restore the ability to set capenabled directly in syscalls.conf..

Ouch, command substitution in syscalls.conf

Fri, Sep 27, 7:57 PM
emaste committed rS352815: controlelf: update man page.
controlelf: update man page
Fri, Sep 27, 7:27 PM
emaste committed rS352809: controlelf: exit with error if file endianness does not match host.
controlelf: exit with error if file endianness does not match host
Fri, Sep 27, 7:07 PM
emaste committed rS352808: controlelf: simplify feature string parsing.
controlelf: simplify feature string parsing
Fri, Sep 27, 6:49 PM
emaste committed rS352806: controlelf: tidy up option parsing.
controlelf: tidy up option parsing
Fri, Sep 27, 6:39 PM
emaste committed rS352805: controlelf: add protmax control.
controlelf: add protmax control
Fri, Sep 27, 5:28 PM
emaste committed rS352803: controlelf: some style(9) cleanup.
controlelf: some style(9) cleanup
Fri, Sep 27, 4:57 PM
emaste committed rS352801: controlelf: install standard BSD 2 clause license.
controlelf: install standard BSD 2 clause license
Fri, Sep 27, 4:44 PM
emaste committed rS352799: controlelf: clean up warnings.
controlelf: clean up warnings
Fri, Sep 27, 4:35 PM
emaste committed rS352797: Add tool to modify ELF binary feature control bits.
Add tool to modify ELF binary feature control bits
Fri, Sep 27, 4:28 PM
emaste closed D19290: Add a tool to modify control features in ELF binaries.
Fri, Sep 27, 4:28 PM
emaste added a reviewer for D20321: emulators/linux_base-c7: Don't create /compat/linux/dev: trasz.
Fri, Sep 27, 1:30 PM
emaste added reviewers for D20575: pseudofs: add sysctl to set sbuf buffer size: kib, markj.
Fri, Sep 27, 1:29 PM
emaste added a comment to D20576: linprocfs: warn users if we can't fill process memory map..

(of course the message is only valid after D20575)

Fri, Sep 27, 1:28 PM
emaste accepted D20576: linprocfs: warn users if we can't fill process memory map..
Fri, Sep 27, 1:27 PM
emaste added reviewers for D20674: [libkvm] kvm_geswapinfo() to stop subtracting vm.dmmax size from swap device sizes.: kib, markj.
Fri, Sep 27, 1:25 PM
emaste added a comment to D20618: [archivers/nulib] PR 21519 - Use dirent.h instead of sys/dir.h.

This one actually does have public distfiles and ongoing development (and maybe upstream does not use sys/dir.h any longer), but I think someone would have to take maintainership to restore it.

Fri, Sep 27, 1:24 PM
emaste accepted D21106: Capsicumize c++filt(1)..
Fri, Sep 27, 1:20 PM
emaste added a comment to D21107: Capsicumize nm(1)..

looks good

Fri, Sep 27, 1:20 PM
emaste committed rS352792: compiler-rt: correct RISC-V struct_kernel_stat64_sz.
compiler-rt: correct RISC-V struct_kernel_stat64_sz
Fri, Sep 27, 1:14 PM
emaste closed D21684: Fix compiler_rt definition for RISC-V.
Fri, Sep 27, 1:14 PM
emaste added a comment to D21684: Fix compiler_rt definition for RISC-V.

We need to figure out how to get all of this upstream as well.

Fri, Sep 27, 1:14 PM
emaste accepted D21444: Disable REPRODUCIBLE_BUILD for kernel builds..
Fri, Sep 27, 1:09 PM
emaste added a comment to D21669: mtod macro: Drop the type argument.

I would suggest describing this plan on freebsd-net@ and freebsd-arch@ mailing lists

Fri, Sep 27, 1:08 PM
emaste accepted D21684: Fix compiler_rt definition for RISC-V.
Fri, Sep 27, 1:07 PM
emaste added a reviewer for D21684: Fix compiler_rt definition for RISC-V: br.
Fri, Sep 27, 1:04 PM
emaste added inline comments to D21696: Re-add ALLOW_MIPS_SHARED_TEXTREL, sprinkle it around.
Fri, Sep 27, 1:04 PM
emaste updated subscribers of D21761: gdb(4): Implement support for NoAckMode.
Fri, Sep 27, 1:02 PM

Thu, Sep 26

emaste committed rS352777: Regen src.conf.5 after r352768, r352769.
Regen src.conf.5 after r352768, r352769
Thu, Sep 26, 9:07 PM
emaste committed rS352769: MFS r352752: Add a WITH_BIND_NOW build knob.
MFS r352752: Add a WITH_BIND_NOW build knob
Thu, Sep 26, 6:57 PM
emaste committed rS352768: MFS r352754: Add WITH_PIE knob to build Position Independent Executables.
MFS r352754: Add WITH_PIE knob to build Position Independent Executables
Thu, Sep 26, 6:38 PM
emaste added a comment to D21669: mtod macro: Drop the type argument.

And mbuf.9 change along with mbuf.h.

Thu, Sep 26, 5:44 PM
emaste added a comment to D21669: mtod macro: Drop the type argument.

Ugly, but amazing. I would suggest committing the macro change first followed by the refactoring.

Thu, Sep 26, 5:41 PM
emaste committed rS352760: MFC r352551: elf_common: add ELF note names.
MFC r352551: elf_common: add ELF note names
Thu, Sep 26, 4:39 PM
emaste committed rS352755: src.conf.5: regen after r352754, WITH_PIE.
src.conf.5: regen after r352754, WITH_PIE
Thu, Sep 26, 4:09 PM
emaste committed rS352754: Add WITH_PIE knob to build Position Independent Executables.
Add WITH_PIE knob to build Position Independent Executables
Thu, Sep 26, 4:06 PM
emaste committed rS352753: src.conf.5: regen after r352752, WITH_BIND_NOW.
src.conf.5: regen after r352752, WITH_BIND_NOW
Thu, Sep 26, 3:52 PM
emaste committed rS352752: Add a WITH_BIND_NOW build knob.
Add a WITH_BIND_NOW build knob
Thu, Sep 26, 3:50 PM
emaste committed rS352742: bspatch: add integer overflow checks.
bspatch: add integer overflow checks
Thu, Sep 26, 1:27 PM
emaste closed D7897: bspatch: add integer overflow checks.
Thu, Sep 26, 1:27 PM