- User Since
- Nov 24 2013, 3:15 AM (208 w, 5 d)
For now avoid setting the reproducible build timestamp in PKG_ENV for all ports that set USES=python
Would it be reasonable to scan the plist for any port that sets USES=python, and avoid overriding the package archive metadata if any .pyo/.pyc found?
Debian doesn't ship the .pyc / .pyo files; they generate them at install time.
Thu, Nov 23
A similar change has been committed
Wed, Nov 22
Tue, Nov 21
What would you suggest for selectively setting PKG_ENV (e.g., for all but python ports, for now)?
- Bump default timestamp to nice round 1500000000 since it s no longer a future time
- Set SOURCE_DATE_EPOCH only for the pkg env, not the build env
- Add a comment
I approve based on @manu's review
I would put it before Differential Revision: to help cement the idea that D-R should go last (even though you'd generally not have both of these on the same commit) and because Differential Revision: is too long and pushes the rest of the text over to the right.
Mon, Nov 20
Tested successfully on SoftIron OverDrive 1000 after applying fpu_kern_enter fix from @andrew via IRC
Mentor approved after @manu's review
Sun, Nov 19
After @manu's review, you have my approval.
Fri, Nov 17
I believe that the patch was already tested on arm64, IMO amd64 would be much more interesting.
Attempting to set the time on OD1000:
root@od1000:~ # date 1711171600 timeout stopping cpus panic: invalid fpcurthread cpuid = 2 time = 1510952400 KDB: stack backtrace: db_trace_self() at db_trace_self_wrapper+0x28 pc = 0xffff00000060d8f8 lr = 0xffff000000086eec sp = 0xffff0000e64e93e0 fp = 0xffff0000e64e95f0
I'm building a new kernel to test this on a SoftIron OverDrive 1000 now.
Thu, Nov 16
Ok, no objection to this patch.
Because we use the new newfs with the old kernel in the release process
I think this change is good (modulo kib's comment).
Wed, Nov 15
- fix stray ; \
- add explicit LC_COLLATE=C per @bapt suggestion
Tue, Nov 14
I would put the 64-bit fields first, and make the whole struct 8-byte aligned, but I'll defer to any suggestion kib might offer.
As long as the ports tree is good let's get this back in.
Mon, Nov 13
How many warnings of this type does the build produce?
Sun, Nov 12
Fri, Nov 10
Also for the commit message -- it's not freeing that we need to avoid, it's using the null pointer at all. free(NULL) is actually fine. it's the printf/setenv that we can't pass a NULL pointer to.
undo accidental if_getdrvflags breakage
Thu, Nov 9
There are also adjustments to make in targets/pseudo/hosttools/Makefile.depend.host and targets/pseudo/userland/Makefile.depend
Wed, Nov 8
Sun, Nov 5
Fri, Nov 3
Thu, Nov 2
Wed, Nov 1
Should we make a reference to WITHOUT_UNIFIED_OBJDIR being a transition aid that will be removed later on? (for 12.0)?
Tue, Oct 31
Or even a small example just in this Phabricator review that demonstrates the issue?
Approved. Could we add a simple test case too?
Mon, Oct 30
I think so - I'm not suggesting we add GPL_DTC_BOOTSTRAP since it seems it would be more complexity than is warranted, but just checking that the reason we don't have this same problem with Clang is because it's split out into separate enables for the boostrap and installed cases.
Sun, Oct 29
Is it the case that the other C++11 option in this block (CLANG) works only because it is split into CLANG and CLANG_BOOTSTRAP? It would otherwise have the same problem, yes?
Fri, Oct 27
Oops, pasted in the wrong review.
I agree with @kib that this should be a private lib
Oct 24 2017
It is moved around, so I am not sure what is your point.
This stuff would greatly benefit from more cleanup