Page MenuHomeFreeBSD

emaste (Ed Maste)
UserAdministrator

Projects (8)

User Details

User Since
Nov 24 2013, 3:15 AM (281 w, 6 d)
Roles
Administrator

Recent Activity

Yesterday

emaste added inline comments to D19974: Remove vestiges of ia64, alpha, and pc98 from our documentation and websites.
Fri, Apr 19, 8:49 PM
emaste added inline comments to D19965: Fix various IPV6_CHECKSUM issues.
Fri, Apr 19, 3:59 PM

Thu, Apr 18

emaste added inline comments to D19290: Add a tool to modify control features in ELF binaries.
Thu, Apr 18, 8:32 PM
emaste closed D18843: readelf(1): Speed up readelf -wo.

rS346323

Thu, Apr 18, 8:27 PM
emaste accepted D19959: Update and cut some parts of the netperf web page (linking to the wiki info more).
Thu, Apr 18, 6:48 PM

Wed, Apr 17

emaste updated subscribers of D19946: allow iflib drivers to pass their own ifmedia.
Wed, Apr 17, 8:33 PM
emaste committed rS346330: Put QEMU CI smoke test boot log in /tmp if TMPDIR not set.
Put QEMU CI smoke test boot log in /tmp if TMPDIR not set
Wed, Apr 17, 7:24 PM
emaste committed rS346329: Install some entropy for QEMU CI smoke test.
Install some entropy for QEMU CI smoke test
Wed, Apr 17, 7:16 PM
emaste committed rS346327: readelf: use size_t for object counts.
readelf: use size_t for object counts
Wed, Apr 17, 5:50 PM
emaste committed rS346325: MFC r345855: cpsw: use `phy-handle` in FDT to find PHY address.
MFC r345855: cpsw: use `phy-handle` in FDT to find PHY address
Wed, Apr 17, 5:19 PM
emaste added a comment to D19407: Port openrsync to FreeBSD using capsicum.

cap_fileargs change committed in:

Wed, Apr 17, 5:04 PM
emaste updated subscribers of D19290: Add a tool to modify control features in ELF binaries.
Wed, Apr 17, 5:01 PM
emaste committed rS346323: readelf: speed up readelf -wo.
readelf: speed up readelf -wo
Wed, Apr 17, 5:00 PM
emaste committed rS346321: cap_fileargs: fix test after r346318.
cap_fileargs: fix test after r346318
Wed, Apr 17, 4:45 PM
emaste committed rS346318: cap_fileargs: fix GCC build, don't shadow 'stat'.
cap_fileargs: fix GCC build, don't shadow 'stat'
Wed, Apr 17, 4:31 PM
emaste committed rS346316: cap_fileargs: chase r346315, update fileargs_init in consumers.
cap_fileargs: chase r346315, update fileargs_init in consumers
Wed, Apr 17, 4:18 PM
emaste committed rS346315: cap_fileargs: add fileargs_lstat service.
cap_fileargs: add fileargs_lstat service
Wed, Apr 17, 4:03 PM
emaste closed D19548: Add fileargs_lstat to cap_fileargs service.
Wed, Apr 17, 4:03 PM
emaste committed rS346314: cap_fileargs.3: typo and markup corrections.
cap_fileargs.3: typo and markup corrections
Wed, Apr 17, 4:00 PM
emaste accepted D19876: Allow this script to be run from within src/tools/boot dir, create image in $TMPDIR..

looks good, thanks

Wed, Apr 17, 3:58 PM
emaste committed rS346313: cap_fileargs.3: correct 'filerags' typo.
cap_fileargs.3: correct 'filerags' typo
Wed, Apr 17, 3:48 PM

Tue, Apr 16

emaste committed rS346299: iflibtxrx.9: update function descriptions to match implementation.
iflibtxrx.9: update function descriptions to match implementation
Tue, Apr 16, 8:41 PM
emaste accepted D19927: stack_protector: Add tunable to bypass random cookies.

I'm fine with this as an immediate fix for the installer/VM boot issues.

Tue, Apr 16, 6:06 PM
emaste committed rS346273: correct readlinkat(2) return type.
correct readlinkat(2) return type
Tue, Apr 16, 1:26 PM
emaste committed rS346268: MFC r346054: libc: update strstr implementation to match musl.
MFC r346054: libc: update strstr implementation to match musl
Tue, Apr 16, 11:30 AM
emaste updated subscribers of D19917: Implement linux_sendfile for the linuxulator.
Tue, Apr 16, 1:28 AM

Mon, Apr 15

emaste added inline comments to D19895: Fix up CXXSTD support, added in r345708.
Mon, Apr 15, 2:20 PM
emaste added a comment to D19896: Match PCI UART devices using PCI data from the ACPI SPCR table.

FYI if you put just the D19507 reference (not the full URL) in a comment Phabricator will create a cross-reference automatically.

Mon, Apr 15, 1:49 PM · arm64
emaste committed rS346228: Add quirk for ignoring SPCR AccessWidth values on the PL011 UART.
Add quirk for ignoring SPCR AccessWidth values on the PL011 UART
Mon, Apr 15, 1:42 PM
emaste closed D19507: Add quirk for ignoring SPCR AccessWidth values on the PL011 UART.
Mon, Apr 15, 1:42 PM · arm64
emaste added a comment to D19507: Add quirk for ignoring SPCR AccessWidth values on the PL011 UART.

tested on eMAG and ThunderX2

Mon, Apr 15, 1:38 PM · arm64

Sun, Apr 14

emaste added a comment to D19869: Add a new uefi-edk2-qemu port..

But, I think I'd like to have the new port committed before I finish that work, with ONLY_FOR_ARCHS=x64 remaining for the time being, since it's work I'd like to schedule and work on separately.

Sun, Apr 14, 12:44 AM

Fri, Apr 12

emaste added a comment to D19507: Add quirk for ignoring SPCR AccessWidth values on the PL011 UART.

Tested eMAG on rS237234 + this change, serial console works as expected for initial boot messages until encountering AcpiExSystemMemorySpaceHandler panic same as reported in PR 237055. Will test on ThunderX2 soon.

Fri, Apr 12, 9:03 PM · arm64
emaste committed rS346142: MFC r345693, 345694: rtld: attempt to fix reloc_nonplt_object TLS allocation.
MFC r345693, 345694: rtld: attempt to fix reloc_nonplt_object TLS allocation
Fri, Apr 12, 12:31 AM

Thu, Apr 11

emaste requested changes to D19876: Allow this script to be run from within src/tools/boot dir, create image in $TMPDIR..

The set -e issue has to be addressed one way or another.

Thu, Apr 11, 5:35 PM
emaste added inline comments to D19876: Allow this script to be run from within src/tools/boot dir, create image in $TMPDIR..
Thu, Apr 11, 5:34 PM
emaste added inline comments to D19851: Fix warnings with lib/libpmc.
Thu, Apr 11, 1:11 PM
emaste added a comment to D16155: Add veriexec to loader.

I needed to add -O1 to stand/defs.mk else the loader was too big
to boot.

Thu, Apr 11, 1:07 PM
emaste added inline comments to D19869: Add a new uefi-edk2-qemu port..
Thu, Apr 11, 1:05 PM
emaste added a comment to D19876: Allow this script to be run from within src/tools/boot dir, create image in $TMPDIR..

I think this is fine other than the set -e issue mentioned earlier.

Thu, Apr 11, 1:03 PM
emaste committed rS346121: Cirrus-CI: pass OVMF env var to test script for upcoming changes.
Cirrus-CI: pass OVMF env var to test script for upcoming changes
Thu, Apr 11, 1:01 PM

Wed, Apr 10

emaste updated subscribers of D19876: Allow this script to be run from within src/tools/boot dir, create image in $TMPDIR..
Wed, Apr 10, 5:05 PM
emaste added inline comments to D19876: Allow this script to be run from within src/tools/boot dir, create image in $TMPDIR..
Wed, Apr 10, 5:01 PM
emaste committed rS346085: Add Cirrus CI config file to support CI builds (in downstream projects).
Add Cirrus CI config file to support CI builds (in downstream projects)
Wed, Apr 10, 3:39 PM
emaste added a comment to D19869: Add a new uefi-edk2-qemu port..

Conceptually this LGTM, but I will defer to ports folks for implementation details related to MD/MI ports.

Wed, Apr 10, 3:15 PM
emaste added inline comments to D19869: Add a new uefi-edk2-qemu port..
Wed, Apr 10, 2:50 PM
emaste added a comment to D19869: Add a new uefi-edk2-qemu port..

OR are you suggesting have:
uefi-edk2-qemu-x86_64
uefi-edk2-qemu-arm64

Wed, Apr 10, 2:44 PM
emaste added inline comments to D19869: Add a new uefi-edk2-qemu port..
Wed, Apr 10, 2:41 PM
emaste added inline comments to D19869: Add a new uefi-edk2-qemu port..
Wed, Apr 10, 2:26 PM
emaste added inline comments to D19869: Add a new uefi-edk2-qemu port..
Wed, Apr 10, 2:13 PM
emaste added inline comments to D19869: Add a new uefi-edk2-qemu port..
Wed, Apr 10, 1:57 PM
emaste added inline comments to D19869: Add a new uefi-edk2-qemu port..
Wed, Apr 10, 1:47 PM
emaste committed rS346080: Add a smoke test QEMU boot script for CI.
Add a smoke test QEMU boot script for CI
Wed, Apr 10, 1:41 PM
emaste closed D19661: Add Cirrus-CI CI build and QEMU boot test.
Wed, Apr 10, 1:41 PM
emaste committed rS346079: ar: implement support for /SYM64/ 64-bit archives.
ar: implement support for /SYM64/ 64-bit archives
Wed, Apr 10, 1:13 PM
emaste closed D18793: Implement support for "/SYM64/" archives in ar.
Wed, Apr 10, 1:13 PM
emaste added inline comments to D18793: Implement support for "/SYM64/" archives in ar.
Wed, Apr 10, 1:04 PM
emaste added inline comments to D19869: Add a new uefi-edk2-qemu port..
Wed, Apr 10, 12:42 AM

Tue, Apr 9

emaste added a comment to D18793: Implement support for "/SYM64/" archives in ar.

Some proposed style(9) fixups in https://github.com/emaste/freebsd/commit/8506f5949cb13d54a688414c5aae3f696e33db42

Tue, Apr 9, 11:22 PM
emaste added inline comments to D18793: Implement support for "/SYM64/" archives in ar.
Tue, Apr 9, 7:38 PM
emaste added a comment to D19864: Polish netmap(4) testcases a bit.

Approved

Tue, Apr 9, 5:39 PM
emaste committed rS346054: libc: update strstr implementation to match musl.
libc: update strstr implementation to match musl
Tue, Apr 9, 3:52 PM
emaste closed D19834: [libc] strstr implementation update to match musl's.
Tue, Apr 9, 3:52 PM
emaste added a comment to D19805: MFC r344662:.

Approved

Tue, Apr 9, 1:21 PM
emaste accepted D19806: MFC r345216:.

Approved.

Tue, Apr 9, 1:20 PM
emaste added a comment to D19854: Fix geli device cleanup.

Approved

Tue, Apr 9, 1:09 PM
emaste added a comment to D19852: Fix a typo when sanity checking in the bootstrap-tools target.

Approved.

Tue, Apr 9, 1:07 PM
emaste accepted D19852: Fix a typo when sanity checking in the bootstrap-tools target.
Tue, Apr 9, 1:07 PM

Mon, Apr 8

emaste accepted D19847: Exercise some care before sending SIGHUP to mountd..
Mon, Apr 8, 6:04 PM
emaste accepted D19847: Exercise some care before sending SIGHUP to mountd..

Could we (also) add assertions in pidfile_open for this case?

Mon, Apr 8, 3:52 PM
emaste accepted D19840: Style only change: Prefer $() to ``.
Mon, Apr 8, 12:55 PM

Fri, Apr 5

emaste accepted D19834: [libc] strstr implementation update to match musl's.

For reference,

commit 122d67f846cb0be2c9e1c3880db9eb9545bbe38c
Author: Rich Felker <dalias@aerifal.cx>
Date:   Thu Nov 8 15:00:02 2018 -0500
Fri, Apr 5, 11:35 PM
emaste accepted D19829: Write string constant differently to improve readability..

This LGTM as long as compilers or static analyzers don't try to "helpfully" warn that the string does not fit or will not be null terminated.

Fri, Apr 5, 8:25 PM

Thu, Apr 4

emaste committed rS345889: if_muge: use NULL not 0 for DRIVER_MODULE pointer args.
if_muge: use NULL not 0 for DRIVER_MODULE pointer args
Thu, Apr 4, 7:59 PM
emaste closed D1186: Update audio/shoutcast to 2.4.2 Build 167.
Thu, Apr 4, 1:03 PM

Wed, Apr 3

emaste committed rS345855: cpsw: use `phy-handle` in FDT to find PHY address.
cpsw: use `phy-handle` in FDT to find PHY address
Wed, Apr 3, 9:02 PM
emaste closed D19814: Use 'phy-handle' in FDT to find PHY address.
Wed, Apr 3, 9:02 PM
emaste committed rS345844: MFC r343764 (jchandra): arm, acpi: increase size of memory region arrays.
MFC r343764 (jchandra): arm, acpi: increase size of memory region arrays
Wed, Apr 3, 1:20 PM

Tue, Apr 2

emaste added inline comments to D19797: Use default shell assignment rather more complicated if then construct..
Tue, Apr 2, 4:45 PM
emaste added inline comments to D19797: Use default shell assignment rather more complicated if then construct..
Tue, Apr 2, 3:47 PM
emaste accepted D19787: bhyve: Stop compiling with -O0..
Tue, Apr 2, 2:28 PM
emaste added a comment to D19788: bhyve: Use separate fds for stdin and stdout..

Can we get a review to cause bhyve -b to emit a deprecation warning notice (gone_in(13)) if someone tries to use it?

Tue, Apr 2, 2:25 PM
emaste committed rS345802: MFC r344280: freebsd-update: Clarify help text.
MFC r344280: freebsd-update: Clarify help text
Tue, Apr 2, 1:58 PM
emaste committed rS345801: MFC r344280: freebsd-update: Clarify help text.
MFC r344280: freebsd-update: Clarify help text
Tue, Apr 2, 1:58 PM

Mon, Apr 1

emaste added a comment to D19758: Integrate capsicum-test into the FreeBSD test suite.
In D19758#424232, @ngie wrote:

I think it makes sense to svn cp first, then apply the changes to the contrib/ location; is that your plan?

Yup. Here's how I've been updating the code for reviews (I broke the merge history somehow when I didn't properly reintegrate the googletest branch, so I'm resorting to manual patching):

svn copy ^/vendor/google/capsicum-test/dist contrib/capsicum-test
Mon, Apr 1, 9:15 PM
emaste added a comment to D19758: Integrate capsicum-test into the FreeBSD test suite.

I think it makes sense to svn cp first, then apply the changes to the contrib/ location; is that your plan?

Mon, Apr 1, 8:57 PM
emaste added inline comments to D19758: Integrate capsicum-test into the FreeBSD test suite.
Mon, Apr 1, 7:37 PM
emaste committed rS345778: Fix gdb/kgdb build under WITH_PIE.
Fix gdb/kgdb build under WITH_PIE
Mon, Apr 1, 7:20 PM
emaste added a comment to D13179: Add "Pull Request" to the devel/subversion commit template.
In D13179#289885, @mat wrote:

Mmmm, I don't really know. The ports tree does not support patches from pull requests, only from our bugzilla, it would be much better to have the pull-request -> bugzilla gateway finally working.

Mon, Apr 1, 6:21 PM
emaste added a comment to D19765: Import proof-of-concept for handling `GTEST_SKIP()` in `Environment::SetUp`.

Please reference the upstream pull request in the commit (perhaps mentioning that upstream has been slow on addressing PRs).

Mon, Apr 1, 3:02 PM

Sun, Mar 31

emaste added a comment to D19758: Integrate capsicum-test into the FreeBSD test suite.

Can you generate a review that's just the local diffs, i.e., after the svn cp?

Sun, Mar 31, 6:14 PM

Sat, Mar 30

emaste accepted D19756: Allow programs to set `NO_SHARED` on a per-prog basis.
Sat, Mar 30, 2:29 PM
emaste accepted D19759: Add option to build LLVM RISC-V target.

LGTM

Sat, Mar 30, 12:52 AM
emaste added a comment to D19755: PROG_OVERRIDE_VARS should override default values.

approved

Sat, Mar 30, 12:49 AM

Fri, Mar 29

emaste added a comment to D19756: Allow programs to set `NO_SHARED` on a per-prog basis.

The downside of adding these is just the extra loops?

Fri, Mar 29, 8:37 PM
emaste added a comment to D19738: Allow users to override CSTD/CXXSTD on a per-prog basis.

Approved

Fri, Mar 29, 6:34 PM
emaste committed rS345694: rtld: attempt to fix reloc_non_plt TLS allocation on MIPS.
rtld: attempt to fix reloc_non_plt TLS allocation on MIPS
Fri, Mar 29, 3:07 PM
emaste committed rS345693: rtld: attempt to fix reloc_nonplt_object TLS allocation.
rtld: attempt to fix reloc_nonplt_object TLS allocation
Fri, Mar 29, 2:35 PM
emaste added a comment to D19732: Standardize -std=c++* as CXXSTD.

Approved. Please test make tinderbox though.

Fri, Mar 29, 2:15 PM

Thu, Mar 28

emaste committed rS345646: readelf: add newline after dumping dynamic FLAGS / FLAGS_1.
readelf: add newline after dumping dynamic FLAGS / FLAGS_1
Thu, Mar 28, 5:30 PM