emaste (Ed Maste)Administrator
User

Projects (7)

User Details

User Since
Nov 24 2013, 3:15 AM (183 w, 2 d)
Roles
Administrator

Recent Activity

Today

emaste added a comment to D10987: add a rescue/sh sanity check for installing on the running system.

But with the direct exec mode in ld-elf.so.1 it is easy to run real sh with real libraries from the target environment, activated by real dynamic linker.

Tue, May 30, 10:49 AM
emaste updated the diff for D10987: add a rescue/sh sanity check for installing on the running system.

Add a bypass knob as requested by kib

Tue, May 30, 10:45 AM
emaste updated subscribers of D10987: add a rescue/sh sanity check for installing on the running system.
Tue, May 30, 2:52 AM
emaste updated the diff for D10987: add a rescue/sh sanity check for installing on the running system.
  • correct make target (_installcheck_world with only one leading _)
  • use false instead of exit 1 as elsewhere
Tue, May 30, 2:21 AM
emaste created D10987: add a rescue/sh sanity check for installing on the running system.
Tue, May 30, 2:08 AM

Yesterday

emaste committed rS319132: bsdgrep: bump version number and add Kyle Evans copyright.
bsdgrep: bump version number and add Kyle Evans copyright
Mon, May 29, 1:10 PM
emaste closed D10982: bsdgrep(1): Bump version number after recent fixes and restructuring, add copyright notice where substantial work has been done by committing rS319132: bsdgrep: bump version number and add Kyle Evans copyright.
Mon, May 29, 1:10 PM
emaste accepted D10982: bsdgrep(1): Bump version number after recent fixes and restructuring, add copyright notice where substantial work has been done.
Mon, May 29, 1:10 PM
emaste accepted D10826: Document direct execution mode for ld.so..
Mon, May 29, 12:52 PM

Sun, May 28

emaste accepted D10972: getdirentries(2): Note it explicit that basep can be NULL..
Sun, May 28, 9:08 PM
emaste added inline comments to D10826: Document direct execution mode for ld.so..
Sun, May 28, 8:56 PM
emaste added a comment to D10487: Bug 218861 - libelf elf_update fails when adding sections.

Do you have a straightforward testcase that can be used to reproduce the issue (and the one in D10486)?

Sun, May 28, 8:26 PM

Sat, May 27

emaste added inline comments to D10931: boot1 generate-fat: generate all templates at once.
Sat, May 27, 6:14 PM
emaste added inline comments to D10931: boot1 generate-fat: generate all templates at once.
Sat, May 27, 6:06 PM
emaste added inline comments to D10931: boot1 generate-fat: generate all templates at once.
Sat, May 27, 6:04 PM
emaste added a comment to D10642: Fix serial line terminal size..

From resizewin(1):

-z  Do nothing unless the current kernel terminal size is zero.  This is
    useful when run from a user's profile (shell startup) scripts: query-
    ing the window size is required for serial lines, but not when log-
    ging in over the network, as protocols like TELNET or SSH already
    handle the terminal size by themselves.
Sat, May 27, 5:43 PM
emaste committed rS318974: uart: add AMT SOL PCI ID.
uart: add AMT SOL PCI ID
Sat, May 27, 2:07 AM
emaste accepted D10922: limit buffer sizes..
Sat, May 27, 1:53 AM
emaste committed rS318972: MFC r312599 (cem): Add remaining ELF compression definitions and structs.
MFC r312599 (cem): Add remaining ELF compression definitions and structs
Sat, May 27, 1:36 AM
emaste updated subscribers of D10931: boot1 generate-fat: generate all templates at once.
Sat, May 27, 12:16 AM

Fri, May 26

emaste added inline comments to D10931: boot1 generate-fat: generate all templates at once.
Fri, May 26, 4:15 PM
emaste committed rS318957: rm stale ptrace dependencies after r305012.
rm stale ptrace dependencies after r305012
Fri, May 26, 4:03 PM
emaste closed D10930: rm stale ptrace dependencies after r305012 by committing rS318957: rm stale ptrace dependencies after r305012.
Fri, May 26, 4:03 PM
emaste accepted D10932: libthr: fix warnings at WARNS=6.
Fri, May 26, 3:52 PM
emaste added a comment to D10780: makefs: add -O (offset) option.

How did you produce this bug? I am not able to reproduce it on my end.

Fri, May 26, 3:50 PM
emaste committed rS318951: makefs: add -O (offset) option.
makefs: add -O (offset) option
Fri, May 26, 3:49 PM
emaste closed D10780: makefs: add -O (offset) option by committing rS318951: makefs: add -O (offset) option.
Fri, May 26, 3:49 PM
emaste accepted D10780: makefs: add -O (offset) option.
Fri, May 26, 3:43 PM
emaste accepted D10922: limit buffer sizes..

LGTM

Fri, May 26, 2:57 PM
emaste updated subscribers of D10931: boot1 generate-fat: generate all templates at once.
Fri, May 26, 1:52 PM
emaste created D10931: boot1 generate-fat: generate all templates at once.
Fri, May 26, 1:47 PM
emaste updated subscribers of D10930: rm stale ptrace dependencies after r305012.
Fri, May 26, 1:15 PM
emaste created D10930: rm stale ptrace dependencies after r305012.
Fri, May 26, 1:14 PM
emaste committed rS318916: bsdgrep: use safer sizeof() construct.
bsdgrep: use safer sizeof() construct
Fri, May 26, 3:36 AM
emaste closed D10824: bsdgrep(1): Correct some minor assumptions to prepare for later chunking efforts by committing rS318914: bsdgrep: correct assumptions to prepare for chunking.
Fri, May 26, 2:30 AM
emaste committed rS318914: bsdgrep: correct assumptions to prepare for chunking.
bsdgrep: correct assumptions to prepare for chunking
Fri, May 26, 2:30 AM
emaste added a comment to D10780: makefs: add -O (offset) option.

Seems to be a bug in here:

% makefs -t ffs -O 1024 foo /etc
Calculated size of `foo': 233024 bytes, 423 inodes
Extent size set to 8192
foo: 2.3MB (4752 sectors) block size 8192, fragment size 1024
       using 1 cylinder groups of 2.32MB, 297 blks, 512 inodes.
super-block backups (for fsck -b #) at:
 32,
Populating `foo'
makefs: Writing inode 2 (dir), bytes 0 + 2048: No space left on device
Fri, May 26, 1:01 AM
emaste added inline comments to D10876: Remove stale generated asm files for functions which are no longer syscalls..
Fri, May 26, 12:53 AM
emaste closed D10876: Remove stale generated asm files for functions which are no longer syscalls. by committing rS318912: libc: rm stale generated files which are no longer syscalls.
Fri, May 26, 12:51 AM
emaste committed rS318912: libc: rm stale generated files which are no longer syscalls.
libc: rm stale generated files which are no longer syscalls
Fri, May 26, 12:51 AM
emaste committed rS318908: bsdgrep: add --mmap tests.
bsdgrep: add --mmap tests
Fri, May 26, 12:20 AM
emaste closed D10827: bsdgrep(1): Add some --mmap tests for basic sanity and previous breakage by committing rS318908: bsdgrep: add --mmap tests.
Fri, May 26, 12:20 AM
emaste added inline comments to D10876: Remove stale generated asm files for functions which are no longer syscalls..
Fri, May 26, 12:13 AM

Thu, May 25

emaste added inline comments to D10876: Remove stale generated asm files for functions which are no longer syscalls..
Thu, May 25, 11:54 PM
emaste committed rS318902: makefs: make buf generic.
makefs: make buf generic
Thu, May 25, 9:41 PM
emaste closed D10803: makefs: make buf generic by committing rS318902: makefs: make buf generic.
Thu, May 25, 9:41 PM
emaste accepted D10803: makefs: make buf generic.
Thu, May 25, 9:38 PM
emaste updated subscribers of D10315: regex(3): Consistently handle invalid {} constructs between BREs and EREs.
Thu, May 25, 8:37 PM
emaste updated subscribers of D10897: hexdump: actually enter Capsicum sandbox on last file.
Thu, May 25, 5:52 PM
emaste added a comment to D10827: bsdgrep(1): Add some --mmap tests for basic sanity and previous breakage.

@ngie are you happy with the final update?

Thu, May 25, 5:42 PM
emaste updated subscribers of D10824: bsdgrep(1): Correct some minor assumptions to prepare for later chunking efforts.
Thu, May 25, 5:37 PM
emaste updated subscribers of D10121: bsdgrep(1): Sprinkle some capsicum(4) on top.
Thu, May 25, 5:37 PM
emaste updated subscribers of D10833: bsdgrep(1): Pet clang-scan.
Thu, May 25, 5:37 PM
emaste updated subscribers of D10827: bsdgrep(1): Add some --mmap tests for basic sanity and previous breakage.
Thu, May 25, 5:37 PM
emaste committed rS318884: lldb: map TRAP_CAP to a trace trap.
lldb: map TRAP_CAP to a trace trap
Thu, May 25, 4:41 PM
emaste added inline comments to D10897: hexdump: actually enter Capsicum sandbox on last file.
Thu, May 25, 4:16 PM
emaste updated the diff for D10897: hexdump: actually enter Capsicum sandbox on last file.
  • print correct arg in err case
  • do not access *(argv + 1) if already at end of argv list
Thu, May 25, 4:15 PM
emaste added a comment to D10803: makefs: make buf generic.

What's this diff relative to? It looks like e.g ffs/buf.c does not correspond to what is currently SVN master.

Thu, May 25, 2:47 PM
emaste updated the diff for D10876: Remove stale generated asm files for functions which are no longer syscalls..

Upload correct diff this time

Thu, May 25, 1:58 PM
emaste updated the diff for D10876: Remove stale generated asm files for functions which are no longer syscalls..

Include pipe and simplify with @jhb's suggestion.

Thu, May 25, 1:57 PM
emaste updated subscribers of D10897: hexdump: actually enter Capsicum sandbox on last file.
Thu, May 25, 1:02 PM
emaste created D10897: hexdump: actually enter Capsicum sandbox on last file.
Thu, May 25, 1:01 PM
emaste updated subscribers of D10876: Remove stale generated asm files for functions which are no longer syscalls..

If you are going to do this you should include pipe() fallout as well, and maybe open() if that was also removed?

Thu, May 25, 12:08 PM
emaste committed rS318841: MFC r318603: nm: document 'r' symbol type.
MFC r318603: nm: document 'r' symbol type
Thu, May 25, 12:34 AM

Wed, May 24

emaste added a comment to D10876: Remove stale generated asm files for functions which are no longer syscalls..

Thanks for the feedback. I will capitalize Removing based on the apparently common style in this file.

Wed, May 24, 8:12 PM
emaste updated subscribers of D10876: Remove stale generated asm files for functions which are no longer syscalls..
Wed, May 24, 7:45 PM
emaste added reviewers for D10876: Remove stale generated asm files for functions which are no longer syscalls.: imp, jhb.
Wed, May 24, 6:53 PM
emaste updated the diff for D10876: Remove stale generated asm files for functions which are no longer syscalls..

correct rm args

Wed, May 24, 6:52 PM
emaste updated the diff for D10876: Remove stale generated asm files for functions which are no longer syscalls..

clean asm files from _worldtmp instead

Wed, May 24, 6:50 PM
emaste added a comment to D10876: Remove stale generated asm files for functions which are no longer syscalls..

I modified the .depend file to refer to the ${.OBJDIR}/getdents.S and see

--- beforedepend ---
removing stale generated syscall asm files
--- getdents.pico ---
--- lstat.pico ---
--- mknod.pico ---
--- stat.pico ---
--- getdents.o ---
--- lstat.o ---
--- mknod.o ---
--- getdents.o ---
cc -target x86_64-unknown-freebsd12.0 --sysroot=/usr/obj/usr/home/emaste/src/freebsd/tmp -B/usr/obj/usr/home/emaste/src/freebsd/tmp/usr/bin -O2 -pipe   -I/usr/home/emaste/src/freebsd/lib/libc/include -I/usr/home/emaste/src/freebsd/include -I/usr/home/emaste/src/freebsd/lib/libc/amd64 -DNLS  -D__DBINTERFACE_PRIVATE -I/usr/home/emaste/src/freebsd/contrib/gdtoa -I/usr/home/emaste/src/freebsd/contrib/libc-vis -DINET6 -I/usr/obj/usr/home/emaste/src/freebsd/lib/libc -I/usr/home/emaste/src/freebsd/lib/libc/resolv -D_ACL_PRIVATE -DPOSIX_MISTAKE -I/usr/home/emaste/src/freebsd/lib/libmd -I/usr/home/emaste/src/freebsd/contrib/jemalloc/include -I/usr/home/emaste/src/freebsd/contrib/tzcode/stdtime -I/usr/home/emaste/src/freebsd/lib/libc/stdtime -I/usr/home/emaste/src/freebsd/lib/libc/locale -DBROKEN_DES -DPORTMAP -DDES_BUILTIN -I/usr/home/emaste/src/freebsd/lib/libc/rpc -DWANT_HYPERV -DYP -DNS_CACHING -DSYMBOL_VERSIONING -MD  -MF.depend.getdents.o -MTgetdents.o -std=gnu99 -fstack-protector-strong -Wsystem-headers -Werror -Wall -Wno-format-y2k -Wno-uninitialized -Wno-pointer-sign -Wno-empty-body -Wno-string-plus-int -Wno-unused-const-variable -Wno-tautological-compare -Wno-unused-value -Wno-parentheses-equality -Wno-unused-function -Wno-enum-conversion -Wno-unused-local-typedef -Wno-address-of-packed-member -Wno-switch -Wno-switch-enum -Wno-knr-promoted-parameter  -Qunused-arguments  -I/usr/home/emaste/src/freebsd/lib/libutil -I/usr/home/emaste/src/freebsd/lib/msun/amd64 -I/usr/home/emaste/src/freebsd/lib/msun/x86 -I/usr/home/emaste/src/freebsd/lib/msun/src   -c /usr/obj/usr/home/emaste/src/freebsd/lib/libc/getdents.S -o getdents.o
cc: error: no such file or directory: '/usr/obj/usr/home/emaste/src/freebsd/lib/libc/getdents.S'
cc: error: no input files
*** [getdents.o] Error code 1
Wed, May 24, 6:35 PM
emaste planned changes to D10876: Remove stale generated asm files for functions which are no longer syscalls..

Does not work as @bdrewery points out because the bad .S file will be cached from the .depend, before the .depend is deleted.

Wed, May 24, 6:34 PM
emaste added a comment to D10876: Remove stale generated asm files for functions which are no longer syscalls..

from a build log after touch getdents.S in the objdir:

Wed, May 24, 6:24 PM
emaste updated the diff for D10876: Remove stale generated asm files for functions which are no longer syscalls..

Test for one of the generated asm files, and only if it exists try to remove them as well as the .depend files.

Wed, May 24, 6:22 PM
emaste commandeered D10876: Remove stale generated asm files for functions which are no longer syscalls..
Wed, May 24, 6:20 PM
emaste added inline comments to D10876: Remove stale generated asm files for functions which are no longer syscalls..
Wed, May 24, 5:54 PM
emaste committed rS318792: UPDATING: clarify ino64 upgrade instructions even further.
UPDATING: clarify ino64 upgrade instructions even further
Wed, May 24, 5:11 PM
emaste added a comment to D10803: makefs: make buf generic.

One more minor divergence from NetBSD noted inline. I suggest we go ahead with this change, and revisit the whitespace later on.

Wed, May 24, 12:21 AM
emaste added a comment to D8734: HBSD: fix long standing issue in bsdconfig's keymap selection.

@dteske will you commit it?

Wed, May 24, 12:01 AM
emaste added a comment to D10765: Implement sincos, sincosf, and sincosl..

No objections - I think you should go ahead. I don't have the background to review it in depth but I trust the author.

Wed, May 24, 12:00 AM

Tue, May 23

emaste committed rS318758: UPDATING: ino64 upgrade should include COMPAT_FREEBSD11.
UPDATING: ino64 upgrade should include COMPAT_FREEBSD11
Tue, May 23, 8:52 PM
emaste added a comment to D10776: Make Capsicum obligatory..
In D10776#223734, @bz wrote:

I really don't like the idea of losing the #ifdefs.
There are people how are trying to figure out the costs of these things (like me, possibly for CAPSICUM) and having the ifdef really helps.

Tue, May 23, 8:43 PM
emaste committed rS318757: Add note to UPDATING for ino64 to follow the standard upgrade process.
Add note to UPDATING for ino64 to follow the standard upgrade process
Tue, May 23, 8:26 PM
emaste closed D10877: Add UPDATING entry for ino64 by committing rS318757: Add note to UPDATING for ino64 to follow the standard upgrade process.
Tue, May 23, 8:26 PM
emaste added inline comments to D10876: Remove stale generated asm files for functions which are no longer syscalls..
Tue, May 23, 7:53 PM
emaste added a comment to D10877: Add UPDATING entry for ino64.

I don't really like documenting "follow the documented process", but I've seen many people express surprise that ino64 is not mentioned in here.

Tue, May 23, 7:46 PM
emaste added reviewers for D10877: Add UPDATING entry for ino64: sbruno, gjb, kib, imp.
Tue, May 23, 7:45 PM
emaste added a comment to D10876: Remove stale generated asm files for functions which are no longer syscalls..
In D10876#225322, @kib wrote:

Note that there is no reasonable date in sight where this workaround could be removed. Upgrades from 11 to 12, which are performed with -DNO_CLEAN source builds, need it. I do not discuss the feasibility of such builds on major upgrades.

Tue, May 23, 7:44 PM
emaste created D10877: Add UPDATING entry for ino64.
Tue, May 23, 7:38 PM
emaste added inline comments to D10876: Remove stale generated asm files for functions which are no longer syscalls..
Tue, May 23, 6:15 PM
emaste added a reviewer for D10876: Remove stale generated asm files for functions which are no longer syscalls.: smahadevan_freebsdfoundation.org.

@kib beat you to it :)

Tue, May 23, 6:02 PM
emaste updated subscribers of D10801: sysutils/py-psutil: Update for ino64.
Tue, May 23, 1:19 PM

Mon, May 22

emaste accepted D10814: Remove qsort copy in hemidal.

So this is just compiling to an empty qsort.o today, and the removal is to prevent it from being discovered in grep -r etc.?

Mon, May 22, 2:47 PM
emaste committed rS318635: Regen sysent after r318634, no open(2) in capability mode.
Regen sysent after r318634, no open(2) in capability mode
Mon, May 22, 11:45 AM
emaste committed rS318634: disallow open(2) in capability mode.
disallow open(2) in capability mode
Mon, May 22, 11:43 AM
emaste closed D10850: disallow open(2) in capability mode by committing rS318634: disallow open(2) in capability mode.
Mon, May 22, 11:43 AM
emaste added a reviewer for D10759: build(7): clarify buildenv target can be used for non-cross builds: bdrewery.
Mon, May 22, 3:59 AM
emaste requested changes to D10765: Implement sincos, sincosf, and sincosl..
Mon, May 22, 3:59 AM
emaste added inline comments to D10765: Implement sincos, sincosf, and sincosl..
Mon, May 22, 3:55 AM
emaste accepted D10846: For arm targets, place ABI at the end of the target triple.

This seems correct to me, although I'm not sure what unanticipated fallout there might be and perhaps others will comment.

Mon, May 22, 3:52 AM
emaste updated subscribers of D10826: Document direct execution mode for ld.so..

A few English comments -- perhaps @wblock could refine further.

Mon, May 22, 3:50 AM