Page MenuHomeFreeBSD

emaste (Ed Maste)Administrator
User

Projects (9)

User Details

User Since
Nov 24 2013, 3:15 AM (263 w, 1 d)
Roles
Administrator

Recent Activity

Yesterday

emaste committed rS341796: Clean stale wpa dependencies and objects after r341759.
Clean stale wpa dependencies and objects after r341759
Mon, Dec 10, 2:50 PM

Fri, Dec 7

emaste committed rS341703: BSD.debug.dist: add newly added nvmecontrol directory.
BSD.debug.dist: add newly added nvmecontrol directory
Fri, Dec 7, 4:55 PM
emaste accepted D18472: Allow bootstrapping libnv on macOS and Linux.

Fine with me.

Fri, Dec 7, 3:18 PM
emaste committed rS341686: MFC r340076: Define NT_FREEBSD_FEATURE_CTL ELF note type.
MFC r340076: Define NT_FREEBSD_FEATURE_CTL ELF note type
Fri, Dec 7, 1:54 PM

Thu, Dec 6

emaste committed rS341653: hier.7: add /lib/casper directory.
hier.7: add /lib/casper directory
Thu, Dec 6, 9:27 PM
emaste committed rS341637: MFC r340986: UPDATING: add note for ld.bfd removal.
MFC r340986: UPDATING: add note for ld.bfd removal
Thu, Dec 6, 4:10 PM

Wed, Dec 5

emaste committed rS341607: MFC r341484: Always treat firmware request and response sizes as unsigned..
MFC r341484: Always treat firmware request and response sizes as unsigned.
Wed, Dec 5, 9:54 PM
emaste committed rS341606: MFC r298454 (araujo): Use MIN()/MAX() macros from sys/param.h..
MFC r298454 (araujo): Use MIN()/MAX() macros from sys/param.h.
Wed, Dec 5, 9:51 PM

Tue, Dec 4

emaste committed rS341470: ggated: do not expose stack data in sendfail().
ggated: do not expose stack data in sendfail()
Tue, Dec 4, 3:28 PM
emaste committed rS341467: MFC r327860: ANSIfy function definitions in sys/vm/.
MFC r327860: ANSIfy function definitions in sys/vm/
Tue, Dec 4, 3:06 PM
emaste accepted D18428: Only gnu/lib/csu when MK_BSD_CRTBEGIN is off.

Yes we should build only one or the other and _startup_libs reaching into gnu/lib/csu directly bypassed the ${MK_BSD_CRTBEGIN} test in gnu/lib/Makefile.

Tue, Dec 4, 2:25 PM
emaste committed rS341465: MFC r323010: hv_vss.4: Fix spelling of 'responsibility'.
MFC r323010: hv_vss.4: Fix spelling of 'responsibility'
Tue, Dec 4, 2:08 PM

Mon, Dec 3

emaste added a comment to D18423: Prototype WITH_PIE knob.

This does not matter for x86 at compile time, only at the link time

Mon, Dec 3, 8:08 PM
emaste accepted D18400: Some fixes for LD_BIND_NOW + ifuncs..
Mon, Dec 3, 7:43 PM
emaste added a comment to D18369: stand/i386: rename .s to .S to use Clang IAS.
In D18369#392138, @imp wrote:

I looked at this on my phone a few days ago and meant to stamp it with LGTM when I got back to my computer, but that fell through the cracks.

Mon, Dec 3, 7:25 PM
emaste committed rS341437: stand/i386: rename .s to .S to use Clang IAS.
stand/i386: rename .s to .S to use Clang IAS
Mon, Dec 3, 7:19 PM
emaste closed D18369: stand/i386: rename .s to .S to use Clang IAS.
Mon, Dec 3, 7:19 PM
emaste added a comment to D18369: stand/i386: rename .s to .S to use Clang IAS.

rS341437

Mon, Dec 3, 7:18 PM
emaste added a comment to D18423: Prototype WITH_PIE knob.

Also, formally architectures can have different -fPIC and -fPIE ABIs, so perhaps we really need libXXX_pie.a, and e.g. libc_pic.a and libc_pie.a simultaneously.

Mon, Dec 3, 7:01 PM
emaste added a comment to D18400: Some fixes for LD_BIND_NOW + ifuncs..

Smoke test in my staging tree (this patch plus 3 unrelated changes) looks good.

Mon, Dec 3, 6:51 PM
emaste added a comment to D18423: Prototype WITH_PIE knob.

Presumably we should build INTERNALLIBs and PRIVATELIBs as both libfoo.a and libfoo_pic.a (or some similar scheme) and choose the appropriate one when linking the binary. I don't know how far down that path we want to go though.

Mon, Dec 3, 6:06 PM
emaste created D18423: Prototype WITH_PIE knob.
Mon, Dec 3, 6:06 PM
emaste added a comment to D18400: Some fixes for LD_BIND_NOW + ifuncs..

I tested this patch in my tree, with BIND_NOW on by default, PIE on by default, and rS341429 reverted. Sanity tests on a few threaded applications showed no issues. Building vanilla FreeBSD + this patch for testing now.

Mon, Dec 3, 4:36 PM
emaste committed rS341429: disable BIND_NOW in libc, libthr, and rtld.
disable BIND_NOW in libc, libthr, and rtld
Mon, Dec 3, 4:00 PM
emaste added a comment to D18408: PR209468: aacraid fixes to work with newer controller firmware.

IMO go ahead and commit

Mon, Dec 3, 3:05 PM
emaste added a comment to D18400: Some fixes for LD_BIND_NOW + ifuncs..

Will test shortly

Mon, Dec 3, 1:49 PM
emaste committed rS341419: MFC r340095: Remove apparently unused 0-byte files that cause grief on Windows.
MFC r340095: Remove apparently unused 0-byte files that cause grief on Windows
Mon, Dec 3, 2:39 AM
emaste committed rS341418: MFC r340095: Remove apparently unused 0-byte files that cause grief on Windows.
MFC r340095: Remove apparently unused 0-byte files that cause grief on Windows
Mon, Dec 3, 2:35 AM
emaste committed rS341417: MFC r340095: Remove apparently unused 0-byte files that cause grief on Windows.
MFC r340095: Remove apparently unused 0-byte files that cause grief on Windows
Mon, Dec 3, 2:35 AM

Fri, Nov 30

emaste added reviewers for D18369: stand/i386: rename .s to .S to use Clang IAS: kevans, tsoome.
Fri, Nov 30, 7:42 PM
emaste accepted D18395: Add uk.macbook.kbd keymap (vt).
Fri, Nov 30, 7:38 PM · Contributor Reviews (base)
emaste reclaimed D7338: Disconnect objdump from the build.

In D18307 @kib suggests not installing as objdump; leave both reviews open until we decide.

Fri, Nov 30, 2:11 PM

Thu, Nov 29

emaste committed rS341258: MFC r340260: Avoid buffer underwrite in icmp_error.
MFC r340260: Avoid buffer underwrite in icmp_error
Thu, Nov 29, 8:17 PM
emaste committed rS341240: regen src.conf.5 after r341239.
regen src.conf.5 after r341239
Thu, Nov 29, 3:56 PM
emaste committed rS341239: MFC r340984: Do not install GNU ld if lld is /usr/bin/ld.
MFC r340984: Do not install GNU ld if lld is /usr/bin/ld
Thu, Nov 29, 3:48 PM
emaste added a comment to D18377: Fix newvers.sh with BUILD_WITH_STRICT_TMPPATH=1.

Oh, maybe I'm conflating a different comment with something about mkfifo, but it was in D15968. In any case, the issue is that with cmd | while ... a return in the while loop returns from the subshell, not the function. There's a decent Stack Overflow discussion at https://stackoverflow.com/questions/13726764/while-loop-subshell-dilemma-in-bash

Thu, Nov 29, 3:34 PM
emaste accepted D18377: Fix newvers.sh with BUILD_WITH_STRICT_TMPPATH=1.

LGTM. One of either @kib or @markj suggested eliminating the mkfifo but I believe we cannot without a more capable shell.

Thu, Nov 29, 3:19 PM

Wed, Nov 28

Herald added a reviewer for D10776: Make Capsicum obligatory.: manu.

Is it acceptable if some binaries fail?

Wed, Nov 28, 6:41 PM
emaste created D18369: stand/i386: rename .s to .S to use Clang IAS.
Wed, Nov 28, 3:56 PM

Tue, Nov 27

emaste committed rS341055: llvm-objdump.1: remove more unintentional options.
llvm-objdump.1: remove more unintentional options
Tue, Nov 27, 1:53 PM
emaste added a comment to D18319: Make security.bsd.unprivileged_proc_debug per-jail.

I don't know why you can't update this patch, as it's editable by all users.

Tue, Nov 27, 1:47 PM

Mon, Nov 26

emaste created D18344: linuxulator: rename .s files to .S/.asm to use Clang IAS.
Mon, Nov 26, 7:47 PM
emaste committed rS340991: stand/i386/libi386: rename .s file to .S to use Clang IAS.
stand/i386/libi386: rename .s file to .S to use Clang IAS
Mon, Nov 26, 7:29 PM
emaste committed rS340990: btx: rename .s files to .S to use Clang IAS.
btx: rename .s files to .S to use Clang IAS
Mon, Nov 26, 7:15 PM
emaste committed rS340986: UPDATING: add note for r340984 (ld.bfd removal).
UPDATING: add note for r340984 (ld.bfd removal)
Mon, Nov 26, 5:22 PM
emaste committed rS340985: src.conf.5: regen after r340984 (and r340841).
src.conf.5: regen after r340984 (and r340841)
Mon, Nov 26, 5:12 PM
emaste committed rS340984: Do not install GNU ld if lld is /usr/bin/ld.
Do not install GNU ld if lld is /usr/bin/ld
Mon, Nov 26, 5:08 PM
emaste closed D18340: Do not install GNU ld if lld is /usr/bin/ld.
Mon, Nov 26, 5:08 PM
emaste added a comment to D18307: Install llvm-objdump as objdump on Clang-using architectures (RFC review).
In D18307#389445, @kib wrote:

What are the big non-implemented features ?

Mon, Nov 26, 3:37 PM
emaste committed rS340975: llvm-objdump.1: fix igor / mandoc -Tlint warnings.
llvm-objdump.1: fix igor / mandoc -Tlint warnings
Mon, Nov 26, 3:13 PM
emaste committed rS340973: llvm-objdump.1: remove invalid options.
llvm-objdump.1: remove invalid options
Mon, Nov 26, 2:46 PM
emaste committed rS340972: llvm-objdump: initial man page.
llvm-objdump: initial man page
Mon, Nov 26, 2:35 PM
emaste closed D18309: llvm-objdump: initial man page.
Mon, Nov 26, 2:35 PM
emaste added a comment to D18340: Do not install GNU ld if lld is /usr/bin/ld.

Combined with D18307 the only binutils tool installed on amd64, arm64, armv7 will be GNU as.

Mon, Nov 26, 2:21 PM
emaste created D18340: Do not install GNU ld if lld is /usr/bin/ld.
Mon, Nov 26, 2:17 PM
emaste committed rS340969: revert r340640 "libc: forcibly disable BIND_NOW".
revert r340640 "libc: forcibly disable BIND_NOW"
Mon, Nov 26, 1:56 PM

Sun, Nov 25

emaste committed rS340916: MFC r340771: proto: change device permissions to 0600.
MFC r340771: proto: change device permissions to 0600
Sun, Nov 25, 12:36 AM
emaste committed rS340915: MFC r340771: proto: change device permissions to 0600.
MFC r340771: proto: change device permissions to 0600
Sun, Nov 25, 12:33 AM

Fri, Nov 23

emaste committed rS340855: MFS12 r340849, r340850, r340851:.
MFS12 r340849, r340850, r340851:
Fri, Nov 23, 9:08 PM
emaste committed rS340854: MFC r340663 (rmacklem):.
MFC r340663 (rmacklem):
Fri, Nov 23, 8:42 PM
emaste committed rS340853: MFC r340662 (rmacklem):.
MFC r340662 (rmacklem):
Fri, Nov 23, 8:39 PM
emaste committed rS340852: MFC r340661 (rmacklem):.
MFC r340661 (rmacklem):
Fri, Nov 23, 8:39 PM
emaste committed rS340851: MFC r340663 (rmacklem):.
MFC r340663 (rmacklem):
Fri, Nov 23, 8:32 PM
emaste committed rS340850: MFC r340662 (rmacklem):.
MFC r340662 (rmacklem):
Fri, Nov 23, 8:31 PM
emaste committed rS340849: MFC r340661 (rmacklem):.
MFC r340661 (rmacklem):
Fri, Nov 23, 8:30 PM
emaste added a parent revision for D18307: Install llvm-objdump as objdump on Clang-using architectures (RFC review): D18309: llvm-objdump: initial man page.
Fri, Nov 23, 7:42 PM
emaste added a child revision for D18309: llvm-objdump: initial man page: D18307: Install llvm-objdump as objdump on Clang-using architectures (RFC review).
Fri, Nov 23, 7:42 PM
emaste abandoned D7338: Disconnect objdump from the build.

Plan to migrate to llvm-objdump instead, in D18307

Fri, Nov 23, 7:41 PM
emaste added a comment to D18309: llvm-objdump: initial man page.
In D18309#388676, @bcr wrote:

OK from manpages, others may have comments on the content itself.

Fri, Nov 23, 7:31 PM
emaste updated the diff for D18309: llvm-objdump: initial man page.

Clean up mandoc -Tlint and/or igor complaints.

Fri, Nov 23, 7:24 PM
emaste updated subscribers of D18309: llvm-objdump: initial man page.
Fri, Nov 23, 7:02 PM
emaste updated the diff for D18309: llvm-objdump: initial man page.

Split mach-o options to subsection.

Fri, Nov 23, 6:49 PM
emaste added inline comments to D18309: llvm-objdump: initial man page.
Fri, Nov 23, 4:26 PM
emaste added a comment to D18309: llvm-objdump: initial man page.

See also D18307.

Fri, Nov 23, 4:14 PM
emaste added reviewers for D18309: llvm-objdump: initial man page: dim, jhb, brooks.
Fri, Nov 23, 3:59 PM
emaste created D18309: llvm-objdump: initial man page.
Fri, Nov 23, 3:58 PM
emaste added a comment to D18307: Install llvm-objdump as objdump on Clang-using architectures (RFC review).

See also D13881 (deprecation notice for GNU objdump) and D7338 (old review to disconnect GNU objdump w/o replacement).

Fri, Nov 23, 2:22 PM
emaste updated subscribers of D18307: Install llvm-objdump as objdump on Clang-using architectures (RFC review).
Fri, Nov 23, 2:19 PM
emaste added inline comments to D18307: Install llvm-objdump as objdump on Clang-using architectures (RFC review).
Fri, Nov 23, 2:16 PM
emaste created D18307: Install llvm-objdump as objdump on Clang-using architectures (RFC review).
Fri, Nov 23, 2:10 PM
emaste committed rS340834: Disable build-id in i386 binary boot components.
Disable build-id in i386 binary boot components
Fri, Nov 23, 1:50 PM
emaste closed D15470: disable build-id in i386 binary boot components.
Fri, Nov 23, 1:50 PM
emaste updated subscribers of D18038: Capsicumize strings.

Adding @arichardson for comment on Linux bootstrapping.

Fri, Nov 23, 2:10 AM
emaste added a comment to D18038: Capsicumize strings.

Also depends on D18037

Fri, Nov 23, 2:08 AM
emaste added inline comments to D18038: Capsicumize strings.
Fri, Nov 23, 2:04 AM
emaste accepted D16771: Allow bootstrapping elftoolchain on MacOS and Linux.

@arichardson I'm fine with this change in FreeBSD (if we end up with a different approach upstream we can just migrate to it on the next elftoolchain update).

Fri, Nov 23, 1:56 AM
emaste committed rS340790: MFC r340285: kldxref: use appropriate Elf_Off type for offsets.
MFC r340285: kldxref: use appropriate Elf_Off type for offsets
Fri, Nov 23, 1:05 AM

Thu, Nov 22

emaste updated subscribers of D14244: crossbuild: Allow bootstrapping libopenbsd on Linux.
Thu, Nov 22, 11:29 PM
emaste accepted D14244: crossbuild: Allow bootstrapping libopenbsd on Linux.

I don't really like this, but given that any failure should be fairly straightforward to track down OK.

Thu, Nov 22, 11:29 PM
emaste added a comment to D18038: Capsicumize strings.

See also D7941

Thu, Nov 22, 10:32 PM
emaste committed rP485615: lang/php73: link with -znotext on i386.
lang/php73: link with -znotext on i386
Thu, Nov 22, 8:21 PM
emaste committed rS340773: MF12 r340697: Introduce src.conf knob to build userland with retpoline.
MF12 r340697: Introduce src.conf knob to build userland with retpoline
Thu, Nov 22, 6:59 PM
emaste committed rS340771: proto: change device permissions to 0600.
proto: change device permissions to 0600
Thu, Nov 22, 4:55 PM

Wed, Nov 21

emaste added a comment to D18291: Align mips crt .init/.fini sections to 4 bytes instead of 16.

It looks like other existing files all use .align, I would probably keep that consistent.

Wed, Nov 21, 5:38 PM
emaste added a comment to D18291: Align mips crt .init/.fini sections to 4 bytes instead of 16.

I suspect only crtn.S (i.e., the _init and _fini epilogues need the 4-byte alignment treatment.

Wed, Nov 21, 5:33 PM
emaste accepted D18290: readelf --debug-dump=decodedline produces incorrect results.
Wed, Nov 21, 3:54 PM
emaste added a comment to D18036: Fix style nits in strings.

@oshogbo if you commit this to FreeBSD I'll grab the diff and commit to ELF Tool Chain.

Wed, Nov 21, 3:49 PM
emaste committed rS340725: Add some non-default src.conf(5) knob descriptions.
Add some non-default src.conf(5) knob descriptions
Wed, Nov 21, 2:51 PM

Tue, Nov 20

emaste committed rS340702: csu: use BSD-1-clause license on csu files.
csu: use BSD-1-clause license on csu files
Tue, Nov 20, 9:04 PM
emaste committed rS340701: Add NT_FREEBSD_FEATURE_CTL ELF note to csu.
Add NT_FREEBSD_FEATURE_CTL ELF note to csu
Tue, Nov 20, 9:00 PM