Page MenuHomeFreeBSD

emaste (Ed Maste)
UserAdministrator

Projects (15)

User Details

User Since
Nov 24 2013, 3:15 AM (442 w, 1 d)
Roles
Administrator

Recent Activity

Sat, May 14

emaste added a comment to D4964: Protect calls to explicit_bzero() via by explicitly disabling the link-time and other optimizations that can cause code elimination..

Note that -flto doesn't actually LTO system libraries, because we do not yet provide LLVM IR libraries. If you put an explicit_bzero implementation in your test code though you can get it to be eliminated. As it stands today for normal use (linking against libc as usual) it will not be eliminated.

Sat, May 14, 2:06 AM

Fri, May 13

emaste added inline comments to D34746: add minimal OCI-compliant image builder.
Fri, May 13, 2:19 PM
emaste added a comment to D34746: add minimal OCI-compliant image builder.

See also Oracle image guidelines at https://docs.oracle.com/en/cloud/marketplace/partner-portal/ocmpd/how-to-publish-an-oci-image-listing.pdf

Fri, May 13, 2:15 PM
emaste accepted D35165: devel/git-devtools: Simple Git tools from src/tools/tools/git.
Fri, May 13, 2:05 PM

Thu, May 12

emaste added a comment to D35178: Add end to end tests for dhclient.

If you upload again for changes, please include full context e.g. git diff -U99999 .... or git show -U99999 ...

Thu, May 12, 5:50 PM
emaste committed R10:0e12eb7b58ae: ssh: update sshd_config for prohibit-password option (authored by emaste).
ssh: update sshd_config for prohibit-password option
Thu, May 12, 3:17 PM
emaste committed R10:4143e4fb197b: Hide -fuse-ld= not supported message for non-build targets (authored by emaste).
Hide -fuse-ld= not supported message for non-build targets
Thu, May 12, 2:59 PM

Wed, May 11

emaste added inline comments to D35175: linux(4): Get rid of __WCLONE handling..
Wed, May 11, 6:12 PM
emaste added a comment to D35067: if_ovpn: basic test case.

Can we include the command(s) used to generate the certs somewhere, maybe a comment in the test?

Wed, May 11, 2:28 PM

Tue, May 10

emaste added inline comments to D35162: LinuxKPI: Implement linux/hashtable.h for FreeBSD..
Tue, May 10, 1:29 PM

Mon, May 9

emaste added a comment to D35156: Allow developers to run their own Workflows(Github) and CI(Cirrus).

There are developers who want to run these tasks on their own forks - at least, I do. Users could also configure Cirrus-CI not to run on their fork, if so desired (i.e., by not giving Cirrus-CI access to the specific repo).

Mon, May 9, 11:30 PM

Sat, May 7

emaste committed R10:6866dd9f4a3a: Remove stray .Pp from WITH_LOADER_EFI_SECUREBOOT description (authored by emaste).
Remove stray .Pp from WITH_LOADER_EFI_SECUREBOOT description
Sat, May 7, 1:15 AM
emaste committed R10:74b048673865: Correct markup in WITH_/WITHOUT_UNIFIED_OBJDIR descriptions (authored by emaste).
Correct markup in WITH_/WITHOUT_UNIFIED_OBJDIR descriptions
Sat, May 7, 1:15 AM
emaste committed R10:1ce26701708e: Correct markup in WITH_/WITHOUT_UNIFIED_OBJDIR descriptions (authored by emaste).
Correct markup in WITH_/WITHOUT_UNIFIED_OBJDIR descriptions
Sat, May 7, 1:15 AM
emaste committed R10:c25c8d621e93: Remove stray .Pp from WITH_LOADER_EFI_SECUREBOOT description (authored by emaste).
Remove stray .Pp from WITH_LOADER_EFI_SECUREBOOT description
Sat, May 7, 1:14 AM
emaste committed R10:2103ecdad8d0: Update UNIFIED_OBJDIR descriptions (authored by emaste).
Update UNIFIED_OBJDIR descriptions
Sat, May 7, 1:13 AM
emaste committed R10:7bf8bd9de347: Update UNIFIED_OBJDIR descriptions (authored by emaste).
Update UNIFIED_OBJDIR descriptions
Sat, May 7, 1:12 AM
emaste committed R10:8feaf3506d32: Update WITH_PROFILE description as it is yet removed (authored by emaste).
Update WITH_PROFILE description as it is yet removed
Sat, May 7, 1:11 AM
emaste committed R10:9cc40aefeb7b: Update WITH_PROFILE description as it is yet removed (authored by emaste).
Update WITH_PROFILE description as it is yet removed
Sat, May 7, 1:11 AM
emaste committed R10:904c148f1c93: libutil: eliminate one syscall from kinfo_getproc (authored by emaste).
libutil: eliminate one syscall from kinfo_getproc
Sat, May 7, 12:06 AM
emaste closed D35140: Eliminate one syscall from kinfo_getproc.
Sat, May 7, 12:06 AM

Fri, May 6

emaste added a comment to D35139: dmesg: Document kern.msgbuf_show_timestamp.

I like Ravi's first, but you can also drop "can be used to"
The following sysctl variables control how the kernel ...

Fri, May 6, 4:49 PM
emaste added a comment to D35140: Eliminate one syscall from kinfo_getproc.

Reported by: Thomas Hurst https://twitter.com/blaagh/status/1521857962297507842

Fri, May 6, 4:47 PM
emaste requested review of D35140: Eliminate one syscall from kinfo_getproc.
Fri, May 6, 4:47 PM

Thu, May 5

emaste added a reverting change for R10:c4585b938a04: tests: vnet tests started failing in CI, disable temporarily: R10:adbe6e6435a2: Reenable vnet tests in CI.
Thu, May 5, 7:17 PM
emaste added a reverting change for R10:711524d96123: tests/dummynet: disable since mbuf pointer serialization KPI to be backed out: R10:adbe6e6435a2: Reenable vnet tests in CI.
Thu, May 5, 7:17 PM
emaste committed R10:613acc64834b: mbuf: do not restore dying interfaces (authored by kp).
mbuf: do not restore dying interfaces
Thu, May 5, 7:17 PM
emaste committed R10:adbe6e6435a2: Reenable vnet tests in CI (authored by emaste).
Reenable vnet tests in CI
Thu, May 5, 7:16 PM
emaste committed R10:51f798e761b1: netisr: serialize/restore m_pkthdr.rcvif when queueing mbufs (authored by glebius).
netisr: serialize/restore m_pkthdr.rcvif when queueing mbufs
Thu, May 5, 7:16 PM
emaste added a reverting change for D35119: Disable VNET tests on CI temporarily: R10:adbe6e6435a2: Reenable vnet tests in CI.
Thu, May 5, 7:16 PM
emaste committed R10:8ef7beb29edd: dummynet: use m_rcvif_serialize/restore when queueing packets (authored by glebius).
dummynet: use m_rcvif_serialize/restore when queueing packets
Thu, May 5, 7:16 PM
emaste committed R10:4d7a1361ef32: ifnet/mbuf: provide KPI to serialize/restore m->m_pkthdr.rcvif (authored by glebius).
ifnet/mbuf: provide KPI to serialize/restore m->m_pkthdr.rcvif
Thu, May 5, 7:15 PM
emaste committed R10:80e60e236d85: ifnet: make if_index global (authored by glebius).
ifnet: make if_index global
Thu, May 5, 7:15 PM

Wed, May 4

emaste accepted D35096: mfc-candidates.sh: Set default to_branch for ports.
Wed, May 4, 6:39 PM

Tue, May 3

emaste committed R10:5949d17a29b4: Clean up warnings in pthread tests (authored by emaste).
Clean up warnings in pthread tests
Tue, May 3, 6:23 PM
emaste committed R10:5e017a84744a: teken: color #3 is yellow not brown - use TC_YELLOW as the name (authored by emaste).
teken: color #3 is yellow not brown - use TC_YELLOW as the name
Tue, May 3, 6:23 PM
emaste committed R10:23fbcad8cc08: ssh: remove 11.x from FREEBSD-upgrade instructions (authored by emaste).
ssh: remove 11.x from FREEBSD-upgrade instructions
Tue, May 3, 6:23 PM
emaste committed R10:ec004c5779dc: ntp: disable format string warnings in libopts (authored by emaste).
ntp: disable format string warnings in libopts
Tue, May 3, 6:23 PM
emaste committed R10:94f2607bc9a3: Add a number of five letter words to the dictionary (authored by emaste).
Add a number of five letter words to the dictionary
Tue, May 3, 6:22 PM
emaste committed R10:6841bc7b8c02: kcov: use __func__ in KASSERT instead of old function name (authored by emaste).
kcov: use __func__ in KASSERT instead of old function name
Tue, May 3, 6:22 PM
emaste committed R10:e5f1a45b2473: Clean up warnings in pthread tests (authored by emaste).
Clean up warnings in pthread tests
Tue, May 3, 6:21 PM
emaste accepted D35113: bsdinstall: stop messing with file descriptors.
Tue, May 3, 1:11 PM
emaste accepted D35114: bsdinstall/script: umount before zpool export.
Tue, May 3, 1:07 PM

Mon, May 2

emaste committed R10:729ee7891170: Remove stray .Pp from WITH_LOADER_EFI_SECUREBOOT description (authored by emaste).
Remove stray .Pp from WITH_LOADER_EFI_SECUREBOOT description
Mon, May 2, 7:46 PM
emaste committed R10:6cd1bc531609: freebsd-update: restart sshd after upgrade (authored by emaste).
freebsd-update: restart sshd after upgrade
Mon, May 2, 6:39 PM
emaste closed D35109: freebsd-update: restart sshd after upgrade.
Mon, May 2, 6:39 PM
emaste added a comment to D35109: freebsd-update: restart sshd after upgrade.

Will change the comment to

# Restart sshd if running (PR263489).  Note that this does not
# affect child sshd processes handling existing sessions.
Mon, May 2, 6:30 PM
emaste added a comment to D35109: freebsd-update: restart sshd after upgrade.

Dumb question, I'm sure, but doesn't restarting sshd kill current ssh sessions?

Mon, May 2, 6:27 PM
emaste closed D35108: relnotes: Mention sshd restart issue.
Mon, May 2, 6:24 PM
emaste committed R9:d335263b28a6: relnotes: Mention sshd restart issue (authored by emaste).
relnotes: Mention sshd restart issue
Mon, May 2, 6:24 PM
emaste committed R10:b7f53cdcf8d5: Update UNIFIED_OBJDIR descriptions (authored by emaste).
Update UNIFIED_OBJDIR descriptions
Mon, May 2, 6:04 PM
emaste added inline comments to D35100: stand: Initial kboot support on amd64.
Mon, May 2, 5:57 PM
emaste added a reviewer for D35109: freebsd-update: restart sshd after upgrade: kevans.
Mon, May 2, 5:25 PM
emaste requested review of D35109: freebsd-update: restart sshd after upgrade.
Mon, May 2, 5:19 PM
emaste added inline comments to D35108: relnotes: Mention sshd restart issue.
Mon, May 2, 5:09 PM
emaste added reviewers for D35108: relnotes: Mention sshd restart issue: ygy, carlavilla.
Mon, May 2, 5:03 PM
emaste requested review of D35108: relnotes: Mention sshd restart issue.
Mon, May 2, 5:02 PM
emaste committed R10:85983255c15b: fwcontrol: eliminate set but not used warning (authored by emaste).
fwcontrol: eliminate set but not used warning
Mon, May 2, 2:11 PM
emaste committed R10:89d405a5ae73: ssh: remove 11.x from FREEBSD-upgrade instructions (authored by emaste).
ssh: remove 11.x from FREEBSD-upgrade instructions
Mon, May 2, 1:56 PM

Sun, May 1

emaste committed R10:eb845555fd0a: ssh: use upstream SSH_OPENSSL_VERSION macro (authored by emaste).
ssh: use upstream SSH_OPENSSL_VERSION macro
Sun, May 1, 7:38 PM
emaste committed R10:ae91d937e2cb: ssh: use upstream SSH_OPENSSL_VERSION macro (authored by emaste).
ssh: use upstream SSH_OPENSSL_VERSION macro
Sun, May 1, 7:37 PM

Sat, Apr 30

emaste added a comment to D31558: Retire MK_PROFILE infrastructure.

I changed the WITH_PROFILE description in f768ecf247b7acd98fd0ee395522e559769e3e51 as it may not be gone in 14.

Sat, Apr 30, 8:09 PM
emaste committed R10:13cf43130436: src.conf.5: regen after f768ecf247b7 (authored by emaste).
src.conf.5: regen after f768ecf247b7
Sat, Apr 30, 7:44 PM
emaste committed R10:60b08330a503: Correct markup in WITH_/WITHOUT_UNIFIED_OBJDIR descriptions (authored by emaste).
Correct markup in WITH_/WITHOUT_UNIFIED_OBJDIR descriptions
Sat, Apr 30, 7:44 PM
emaste committed R10:f768ecf247b7: Update WITH_PROFILE description as it is yet removed (authored by emaste).
Update WITH_PROFILE description as it is yet removed
Sat, Apr 30, 7:37 PM
emaste updated subscribers of D31558: Retire MK_PROFILE infrastructure.
Sat, Apr 30, 2:08 PM
emaste added reviewers for D31558: Retire MK_PROFILE infrastructure: imp, phk.
Sat, Apr 30, 2:00 PM

Fri, Apr 29

emaste added inline comments to D35096: mfc-candidates.sh: Set default to_branch for ports.
Fri, Apr 29, 4:58 PM

Thu, Apr 28

emaste committed R10:1a50bf77af90: Add a tool to find MFC candidates (authored by emaste).
Add a tool to find MFC candidates
Thu, Apr 28, 6:07 PM
emaste closed D34208: find-mfc: add a tool to find MFC candidates.
Thu, Apr 28, 6:07 PM

Wed, Apr 27

emaste accepted D35060: firewire: Initialize firewire_devclass in fw_modevent..

Is it time to look at deprecation plans for firewire?

Wed, Apr 27, 7:10 PM
emaste committed R10:346f0084ba72: libcxxrt: Insert padding in __cxa_dependent_exception (authored by emaste).
libcxxrt: Insert padding in __cxa_dependent_exception
Wed, Apr 27, 5:55 PM
emaste updated the diff for D31807: FreeBSD base system ssh 9.0p1 diff against upstream.

Regenerate after:

Wed, Apr 27, 5:40 PM
emaste added inline comments to D31807: FreeBSD base system ssh 9.0p1 diff against upstream.
Wed, Apr 27, 5:38 PM
emaste committed R10:69a40d924128: libcxxrt: Insert padding in __cxa_dependent_exception (authored by emaste).
libcxxrt: Insert padding in __cxa_dependent_exception
Wed, Apr 27, 4:05 PM
emaste committed R10:c40e4349889b: libcxxrt: Insert padding in __cxa_dependent_exception (authored by emaste).
libcxxrt: Insert padding in __cxa_dependent_exception
Wed, Apr 27, 1:42 PM

Tue, Apr 26

emaste added inline comments to D34340: ovpn: Introduce OpenVPN DCO support.
Tue, Apr 26, 4:35 PM
emaste committed R10:7bc8d9eda1ea: openssh: Add a note to check for deprecated and removed config options (authored by markj).
openssh: Add a note to check for deprecated and removed config options
Tue, Apr 26, 1:49 PM
emaste committed R10:f52bfdc1148d: ssh: remove duplicate setting of MAIL env var (authored by emaste).
ssh: remove duplicate setting of MAIL env var
Tue, Apr 26, 1:45 PM
emaste committed R10:2cf06d01f916: ssh: remove duplicate setting of MAIL env var (authored by emaste).
ssh: remove duplicate setting of MAIL env var
Tue, Apr 26, 1:41 PM
emaste committed R10:870735c46b15: capsicum: briefly describe capabilities in man page (authored by emaste).
capsicum: briefly describe capabilities in man page
Tue, Apr 26, 12:56 AM
emaste committed R10:364a69a529b2: capsicum: briefly describe capabilities in man page (authored by emaste).
capsicum: briefly describe capabilities in man page
Tue, Apr 26, 12:55 AM

Mon, Apr 25

emaste added a comment to D10469: The c11 appendix K string functions.

There seems to be no change here or in https://github.com/trixirt/libc11ext in the last five years. @trix_juniper.net are you still planning to pursue this?

Mon, Apr 25, 5:40 PM
emaste added a comment to D35055: ASAN: reduce verbosity.

Note to self: for upstreaming, see also D33934

Mon, Apr 25, 1:46 PM
emaste accepted D35055: ASAN: reduce verbosity.

LGTM except style issue, look at the SANITIZER_PPC64V2 case above, space after the 1 and line up the string indentation.

Mon, Apr 25, 1:37 PM
emaste committed R10:776b9127edb1: ssh: apply style(9) to version_addendum (authored by emaste).
ssh: apply style(9) to version_addendum
Mon, Apr 25, 1:06 AM
emaste committed R10:d47ac32b4a4f: ssh: apply style(9) to version_addendum (authored by emaste).
ssh: apply style(9) to version_addendum
Mon, Apr 25, 1:05 AM

Sun, Apr 24

emaste committed R10:6e24fe61287b: ssh: use upstream SSH_OPENSSL_VERSION macro (authored by emaste).
ssh: use upstream SSH_OPENSSL_VERSION macro
Sun, Apr 24, 12:11 AM

Sat, Apr 23

emaste committed R10:835ee05f3c75: ssh: drop $FreeBSD$ from crypto/openssh (authored by emaste).
ssh: drop $FreeBSD$ from crypto/openssh
Sat, Apr 23, 2:17 AM

Fri, Apr 22

emaste added inline comments to D34547: bhyve - snapshot capsicum integration[Part 1].
Fri, Apr 22, 3:27 PM
emaste added a comment to D35021: linuxkpi: Mitigate a seqlock livelock.

I'm reasonably confident that this patch has addressed the issue I observed.

Fri, Apr 22, 2:57 PM
emaste added a comment to D35029: src.conf(5): Remove the WITHOUT_GAMES build option.

there are still a few things controlled by WITH_/WITHOUT_GAMES:

$ git grep MK_GAMES
Makefile.inc1:.if ${MK_GAMES} != "no"
release/Makefile:           MK_GAMES=no \
tools/build/mk/OptionalObsoleteFiles.inc:.if ${MK_GAMES} == no
usr.bin/Makefile:SUBDIR.${MK_GAMES}+=   caesar
usr.bin/Makefile:SUBDIR.${MK_GAMES}+=   factor
usr.bin/Makefile:SUBDIR.${MK_GAMES}+=   fortune
usr.bin/Makefile:SUBDIR.${MK_GAMES}+=   grdc
usr.bin/Makefile:SUBDIR.${MK_GAMES}+=   morse
usr.bin/Makefile:SUBDIR.${MK_GAMES}+=   number
usr.bin/Makefile:SUBDIR.${MK_GAMES}+=   pom
usr.bin/Makefile:SUBDIR.${MK_GAMES}+=   primes
usr.bin/Makefile:SUBDIR.${MK_GAMES}+=   random
Fri, Apr 22, 12:55 PM

Thu, Apr 21

emaste added a comment to D35021: linuxkpi: Mitigate a seqlock livelock.

I've applied this to my local tree and so far it appears to address the livelock issue I was observed somewhat regularly under load (video/keyboard unresponsive, although mouse cursor still moved).

Thu, Apr 21, 6:16 PM
emaste added inline comments to D31807: FreeBSD base system ssh 9.0p1 diff against upstream.
Thu, Apr 21, 2:22 PM

Wed, Apr 20

emaste added a comment to D35008: FB_INSTALL_CDEV: Remove this option and related code..

Macro makeitso:

Wed, Apr 20, 8:32 PM
emaste accepted D35008: FB_INSTALL_CDEV: Remove this option and related code..
Wed, Apr 20, 8:30 PM
emaste added a comment to D34984: Remove PAGE_SIZE from libthr.

Macro shipit:

Wed, Apr 20, 8:22 PM
emaste added a comment to D34984: Remove PAGE_SIZE from libthr.

looks reasonable to me

Wed, Apr 20, 4:39 PM
emaste committed R10:1bb77846adee: vidcontrol: disable p, P, and H when vt(4) is in use (authored by emaste).
vidcontrol: disable p, P, and H when vt(4) is in use
Wed, Apr 20, 3:30 AM
emaste committed R10:60b63dfef66d: ssh-agent: move -x description to correct spot in man page (authored by emaste).
ssh-agent: move -x description to correct spot in man page
Wed, Apr 20, 12:32 AM