libelf committed in rS366977

(Dates in man pages and in copyright statements updated)

LGTM and confirm it fixes the "Unable to map MSI-X table" issue on the machine I'm testing on.

Looks good to me.

One grammar nit

Oh I see @kib has D26908 for this.

I think this is OK.

I intend to commit the libelf portion first, followed by readelf. @tig_freebsdfoundation.org perhaps you can update readelf.c based on @markj's comments, and put it in a separate review?

If you update the review with the style(9) items @kib identified he or I will commit.

One final thing, we'll need to add a man page, contrib/elftoolchain/libelf/gelf_getchdr.3. You can use e.g. gelf_getshdr.3 as a template, and see man mdoc for a reference to mdoc formatting.

LGTM

Added to my staging tree as

diff --git a/contrib/elftoolchain/libelf/Version.map b/contrib/elftoolchain/libelf/Version.map
index e71a59197d0d..ae9783f221ca 100644
--- a/contrib/elftoolchain/libelf/Version.map
+++ b/contrib/elftoolchain/libelf/Version.map
@@ -4,6 +4,7 @@ R1.0 {
 global:
        elf32_checksum;
        elf32_fsize;
+       elf32_getchdr;
        elf32_getehdr;
        elf32_getphdr;
        elf32_getshdr;
@@ -13,6 +14,7 @@ global:
        elf32_xlatetom;
        elf64_checksum;
        elf64_fsize;
+       elf64_getchdr;
        elf64_getehdr;
        elf64_getphdr;
        elf64_getshdr;
@@ -65,6 +67,7 @@ global:
        gelf_checksum;
        gelf_fsize;
        gelf_getcap;
+       gelf_getchdr;
        gelf_getclass;
        gelf_getdyn;
        gelf_getehdr;

New symbols need to be added to contrib/elftoolchain/libelf/Version.map

Title is incorrect - sc is the syscons driver and is not added in this review.

no objection

Agree with the change, two small suggestions

No objection

For committing this we'd do the libelf change first, then the readelf change.

Committed as rS366508

uh, this should not have been closed

what other OSes share this API now?

on IRC @bapt suggests latest/pkg.bootstrap as the symlink, full URL pkg.freebsd.org/FreeBSD:13:amd64/latest/pkg.bootstrap
Note that this removes the Latest from the URL currently used for pkg.txz.

bapt suggests pkg.latest or pkg.bootstrap as the agnostic symlink name

what about using pkg.bsd as the format-agnostic symlink name?

pkg.bsd -> pkg.txz

I added a linuxkpi group in Phabricator that folks with an interest may join

To me the new runlen loop is more clear.

No worries; I see from rD54553 that there's a lot more to update than just releng/index.xml (which is mentioned in security.xml); is there a list of all of these places we should reference instead?

OK