Page MenuHomeFreeBSD

emaste (Ed Maste)
UserAdministrator

Projects (14)

User Details

User Since
Nov 24 2013, 3:15 AM (380 w, 1 d)
Roles
Administrator

Recent Activity

Today

emaste requested review of D29123: sed: add deprecation notice for -i .bak.
Mon, Mar 8, 12:25 AM

Sat, Mar 6

emaste added a comment to D28192: linux: make fstatat(2) handle AT_EMPTY_PATH.

see also https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=197778

Sat, Mar 6, 8:10 PM
emaste committed R10:8d25741b633a: growfs: allow operation on RW-mounted filesystems (authored by emaste).
growfs: allow operation on RW-mounted filesystems
Sat, Mar 6, 7:47 PM
emaste committed R10:56d80e35a333: growfs: allow operation on RW-mounted filesystems (authored by emaste).
growfs: allow operation on RW-mounted filesystems
Sat, Mar 6, 1:14 AM
emaste committed R10:b5920128c7eb: growfs: allow operation on RW-mounted filesystems (authored by emaste).
growfs: allow operation on RW-mounted filesystems
Sat, Mar 6, 1:13 AM

Fri, Mar 5

emaste committed R10:41b9a5af2e19: bsdinstall: add knob to set ASLR sysctls (authored by emaste).
bsdinstall: add knob to set ASLR sysctls
Fri, Mar 5, 5:54 PM
emaste committed R10:8ea77f39ec17: bsdinstall: replace multiple ifs with case (authored by emaste).
bsdinstall: replace multiple ifs with case
Fri, Mar 5, 5:53 PM
emaste committed R10:982cd9620615: Cirrus-CI: temporarily avoid qemu smoke test boot (authored by emaste).
Cirrus-CI: temporarily avoid qemu smoke test boot
Fri, Mar 5, 5:53 PM
emaste committed R10:31cbc4f946ae: Cirrus-CI: add df/du to track down disk full issues (authored by emaste).
Cirrus-CI: add df/du to track down disk full issues
Fri, Mar 5, 5:53 PM
emaste committed R10:de40e928fb5a: Cirrus-CI: remove svn2git remnant (authored by emaste).
Cirrus-CI: remove svn2git remnant
Fri, Mar 5, 5:49 PM
emaste committed R10:680867cb7029: newvers.sh: add newline at EOF in generated vers.c (authored by emaste).
newvers.sh: add newline at EOF in generated vers.c
Fri, Mar 5, 5:49 PM
emaste committed R10:812a476244c4: tests/sys/audit: force PIE off (authored by emaste).
tests/sys/audit: force PIE off
Fri, Mar 5, 5:49 PM
emaste committed R10:765cc83260b1: cxgbetool: correct utilties typo (authored by emaste).
cxgbetool: correct utilties typo
Fri, Mar 5, 5:49 PM

Thu, Mar 4

emaste updated the diff for D29002: By default use compressed debug in standalone userland debug files.

Add missing bsd.sys.mk change

Thu, Mar 4, 8:21 PM
emaste committed R10:19587d742264: clang: Fix -gz=zlib options for linker (authored by emaste).
clang: Fix -gz=zlib options for linker
Thu, Mar 4, 8:13 PM
emaste closed D29028: clang: Fix -gz=zlib options for linker.
Thu, Mar 4, 8:13 PM
emaste added a comment to D29064: riscv: fix errors in some atomic type aliases.
Thu, Mar 4, 6:51 PM

Wed, Mar 3

emaste closed D29021: growfs: allow operation on RW-mounted filesystems.
Wed, Mar 3, 11:37 PM
emaste committed R10:0dcde5cc1274: growfs: allow operation on RW-mounted filesystems (authored by emaste).
growfs: allow operation on RW-mounted filesystems
Wed, Mar 3, 11:37 PM
emaste committed R10:f2f24008a2b1: Cirrus-CI: Add more information to help track down disk full issues (authored by emaste).
Cirrus-CI: Add more information to help track down disk full issues
Wed, Mar 3, 4:53 PM
emaste updated subscribers of D29035: Import Arm Optimized Routines v21.02.
Wed, Mar 3, 3:13 PM
emaste updated the diff for D28814: hier.7: move ESP mountpoint to /efi (from /boot/efi).

Update after 0b7472b3d8d2f1e90fade5236b44fd98d8e396c2

Wed, Mar 3, 2:17 PM
emaste requested review of D29028: clang: Fix -gz=zlib options for linker.
Wed, Mar 3, 1:40 AM

Tue, Mar 2

emaste added inline comments to D29021: growfs: allow operation on RW-mounted filesystems.
Tue, Mar 2, 10:44 PM
emaste requested review of D29021: growfs: allow operation on RW-mounted filesystems.
Tue, Mar 2, 10:43 PM
emaste committed R10:7f72497ef756: libc: Use musl's optimized strchr and strchrnul (authored by emaste).
libc: Use musl's optimized strchr and strchrnul
Tue, Mar 2, 2:11 AM
emaste closed D17630: libc: Use musl's optimized strchr, strchrnul, strcspn.
Tue, Mar 2, 2:11 AM
emaste added inline comments to D29007: address a performance problem w/ partial sscanf on long strings....
Tue, Mar 2, 12:07 AM

Mon, Mar 1

emaste committed R10:a7d593dd1da2: Cirrus-CI: temporarily avoid qemu smoke test boot (authored by emaste).
Cirrus-CI: temporarily avoid qemu smoke test boot
Mon, Mar 1, 10:39 PM
emaste closed D28869: multimedia/cx88: Fix build with default PIE..
Mon, Mar 1, 8:53 PM
emaste committed rP566909: multimedia/cx88: fix build with base system PIE default.
multimedia/cx88: fix build with base system PIE default
Mon, Mar 1, 8:53 PM
emaste added a comment to D29002: By default use compressed debug in standalone userland debug files.

For kernel builds, do we have to change the 'makeoptions' like in GENERIC or can we get by with doing it in some kern.*mk file?

Mon, Mar 1, 8:13 PM
emaste added a comment to D29002: By default use compressed debug in standalone userland debug files.
Mon, Mar 1, 8:13 PM
emaste updated the diff for D29002: By default use compressed debug in standalone userland debug files.

add compressed-debug compiler feature

Mon, Mar 1, 8:11 PM
emaste added a comment to D29002: By default use compressed debug in standalone userland debug files.

hrmph
x86_64-unknown-freebsd13.0-gcc6: error: -gz is not supported in this configuration

Mon, Mar 1, 8:01 PM
emaste requested review of D29002: By default use compressed debug in standalone userland debug files.
Mon, Mar 1, 6:49 PM
emaste committed R10:af11c2029006: Cirrus-CI: show mounted filesystems and free space at start (authored by emaste).
Cirrus-CI: show mounted filesystems and free space at start
Mon, Mar 1, 4:56 PM
emaste added inline comments to D28997: Allow ssp_test:read to pass more reliably.
Mon, Mar 1, 3:40 PM
emaste accepted D28997: Allow ssp_test:read to pass more reliably.

I think this is reasonable. I don't think we care whether SSP detects a stack overflow that overwrites only padding.

Mon, Mar 1, 3:37 PM
emaste accepted D28986: security(7): note W^X sysctl.

@gbe would you like to take care of committing this?

Mon, Mar 1, 3:03 AM

Fri, Feb 26

emaste updated subscribers of D28944: arm64: fix hardware single-stepping from EL1.
Fri, Feb 26, 6:02 PM
emaste added inline comments to D28939: development(7): update to reflect Git transition.
Fri, Feb 26, 2:49 PM
emaste added inline comments to D28889: Fix ptrace_test:ptrace__syscall_args after ATF upgrade.
Fri, Feb 26, 4:23 AM

Thu, Feb 25

emaste committed R9:3707c59faf94: committers-guide: update example to match guidance (authored by emaste).
committers-guide: update example to match guidance
Thu, Feb 25, 11:58 PM
emaste committed R10:ba7ede0b9b3d: Add UPDATING entry for PIE default (authored by emaste).
Add UPDATING entry for PIE default
Thu, Feb 25, 4:03 PM
emaste abandoned D28921: Add 2021-03-03 Bhyve office hours.

@lwhsu already took care of this one

Thu, Feb 25, 3:24 PM
emaste added a member for Jails: emaste.
Thu, Feb 25, 2:41 PM
emaste added a comment to D28920: Sort 2021 events in reverse chronological order.

afaict it's ok, but we should update all of them, or change the comments

Thu, Feb 25, 1:03 AM
emaste requested review of D28921: Add 2021-03-03 Bhyve office hours.
Thu, Feb 25, 12:00 AM

Wed, Feb 24

emaste requested review of D28920: Sort 2021 events in reverse chronological order.
Wed, Feb 24, 11:09 PM
emaste added a comment to D26976: bhyve - ARMv8 implementation.

Is this work also available in a git repo?

Wed, Feb 24, 10:15 PM
emaste accepted D28328: Enable PIE by default on 64-bit architectures.
Wed, Feb 24, 7:09 PM · PowerPC, arm64
emaste added a comment to D28328: Enable PIE by default on 64-bit architectures.

I'll commit with the updated comment of yours.

Wed, Feb 24, 7:09 PM · PowerPC, arm64
emaste added a comment to D28905: committers-guide: update commit trailer descriptions.

and as long as it builds

Wed, Feb 24, 7:04 PM
emaste closed D28905: committers-guide: update commit trailer descriptions.
Wed, Feb 24, 7:03 PM
emaste committed R9:ef7b7813665b: committers-guide: update commit trailer descriptions (authored by emaste).
committers-guide: update commit trailer descriptions
Wed, Feb 24, 7:03 PM
emaste closed D26123: [handbook] Remove reference to cusueeme.
Wed, Feb 24, 6:58 PM
emaste committed R9:9ad75d64f7dd: [handbook] Remove reference to cusueeme (authored by driesm.michiels_gmail.com).
[handbook] Remove reference to cusueeme
Wed, Feb 24, 6:57 PM
emaste added inline comments to D28893: Disable PIE for PowerPC bootloaders..
Wed, Feb 24, 6:52 PM · PowerPC
emaste accepted D28893: Disable PIE for PowerPC bootloaders..

LGTM. I think the comments are unnecessary though.

Wed, Feb 24, 6:52 PM · PowerPC
emaste accepted D28370: Disable PIE for MIPS u-boot-loader..
Wed, Feb 24, 6:51 PM · MIPS
emaste added a comment to D26123: [handbook] Remove reference to cusueeme.

It's possible Phabricator mangled things.

What I wanted you to do was:
1: Change 'seem' to 'appear'
2: Put the full path to /etc/rc.conf (instead of just rc.conf).

Wed, Feb 24, 6:42 PM
emaste added inline comments to D28328: Enable PIE by default on 64-bit architectures.
Wed, Feb 24, 6:35 PM · PowerPC, arm64
emaste added a comment to D28328: Enable PIE by default on 64-bit architectures.

Outstanding fixes for affected ports: D28801, D28864, D28866, D28868, D28869

Wed, Feb 24, 6:27 PM · PowerPC, arm64

Tue, Feb 23

emaste added a comment to D28907: open(2): Remove O_BENEATH and AT_BENEATH.

And further, https://marc.info/?l=linux-arch&m=155002737229348

Tue, Feb 23, 9:40 PM
emaste added a comment to D28907: open(2): Remove O_BENEATH and AT_BENEATH.

From Linux openat2 there are a set of resolve flags including

Tue, Feb 23, 9:32 PM
emaste added a comment to D28897: Mount ESP on newly-installed systems.

No objection from me

Tue, Feb 23, 9:22 PM
emaste requested review of D28905: committers-guide: update commit trailer descriptions.
Tue, Feb 23, 6:52 PM
emaste accepted D28577: While building libm, turn off any math-related compiler builtins.

Yes makes sense for the tests to use -fno-builtins

Tue, Feb 23, 2:26 PM
emaste added a comment to D28888: Remove atf_tc_skip calls from ptrace_test.

I believe we've seen cases where tests fail in CI but pass regularly when run locally; not sure if that's the case for these tests but if we do re-enable them in CI we will need to watch closely and be ready to disable them again.

Tue, Feb 23, 2:22 PM
emaste committed R10:89238773a37f: xen-blkback: fix leak of grant maps on ring setup failure (authored by royger).
xen-blkback: fix leak of grant maps on ring setup failure
Tue, Feb 23, 12:59 AM
emaste committed R10:dfb372f5d38c: xen-blkback: fix leak of grant maps on ring setup failure (authored by royger).
xen-blkback: fix leak of grant maps on ring setup failure
Tue, Feb 23, 12:58 AM
emaste committed R10:ab3e1bd3c22a: xen-blkback: fix leak of grant maps on ring setup failure (authored by royger).
xen-blkback: fix leak of grant maps on ring setup failure
Tue, Feb 23, 12:56 AM

Mon, Feb 22

emaste added a comment to D27619: Add makefs to the list of bootstrap tools.

Looks OK to me, tiny concern is whether _libnetbsd= lib/libmd lib/libnetbsd could become out of sync (exists in two places)

Mon, Feb 22, 8:19 PM
emaste committed R10:519496a59855: openssh: document two changes that are now upstream (authored by emaste).
openssh: document two changes that are now upstream
Mon, Feb 22, 7:05 PM
emaste accepted D28835: Fix makefs bootstrap after d485c77f203fb0f4cdc08dea5ff81631b51d8809.
Mon, Feb 22, 5:41 PM
emaste added a comment to D28328: Enable PIE by default on 64-bit architectures.

Affected ports from the exp-run have been fixed, or have patches available and are waiting on maintainer approval. So, this should be ready to commit any time, although I think we should have a comment explaining which architectures have been opted-out (32-bit) and a brief sentence why.

Mon, Feb 22, 5:01 PM · PowerPC, arm64
emaste added a comment to D28801: net/sup: Fix build with default PIE..

Waiting on port maintainer approval

Mon, Feb 22, 4:43 PM
emaste added a comment to D28868: japanese/kon2-16dot: Fix build with default PIE..

Email sent to port maintainer for approval

Mon, Feb 22, 4:43 PM
emaste closed D28863: www/rssroll: Fix build with default PIE..
Mon, Feb 22, 4:41 PM
emaste committed rP566310: www/rssroll: Prepare for base system default PIE.
www/rssroll: Prepare for base system default PIE
Mon, Feb 22, 4:41 PM
emaste closed D28800: www/obhttpd: Fix build with default PIE..
Mon, Feb 22, 4:38 PM
emaste committed rP566309: www/obhttpd: Prepare for base system default PIE.
www/obhttpd: Prepare for base system default PIE
Mon, Feb 22, 4:37 PM
emaste closed D28792: devel/cvs: fix build with base system PIE default.
Mon, Feb 22, 4:34 PM
emaste committed rP566308: devel/cvs: prepare for base system PIE default.
devel/cvs: prepare for base system PIE default
Mon, Feb 22, 4:34 PM
emaste added a comment to D28792: devel/cvs: fix build with base system PIE default.

Received maintainer approval via email.

Mon, Feb 22, 4:33 PM
emaste closed D28793: www/mathopd: Fix build with default PIE..
Mon, Feb 22, 4:27 PM
emaste committed rP566307: www/mathopd: Fix build with default PIE.
www/mathopd: Fix build with default PIE
Mon, Feb 22, 4:27 PM
emaste committed R10:aa8ae5fe17eb: git hooks: add "Fixes" trailer to commit message template (authored by emaste).
git hooks: add "Fixes" trailer to commit message template
Mon, Feb 22, 3:32 PM
emaste closed D28693: prepare-commit-msg: add "Fixes:" .
Mon, Feb 22, 3:32 PM

Sat, Feb 20

emaste committed R9:b2a9be92aee6: committers-guide: add missing line break in commit message section (authored by emaste).
committers-guide: add missing line break in commit message section
Sat, Feb 20, 7:10 PM
emaste added a comment to D28815: Add commit message information to committer's guide.

It's outside the scope of this review, but we might want to consider adding another column guide to the prepare-commit-msg hook, which indicates where 63 columns is located.

Sat, Feb 20, 6:46 PM
emaste closed D28815: Add commit message information to committer's guide.
Sat, Feb 20, 6:45 PM
emaste committed R9:11f82357745e: Add commit message information to committer's guide (authored by emaste).
Add commit message information to committer's guide
Sat, Feb 20, 6:45 PM
emaste closed D28418: bsdinstall: add knob to set ASLR sysctls.
Sat, Feb 20, 4:57 PM
emaste committed R10:020f4112559e: bsdinstall: add knob to set ASLR sysctls (authored by emaste).
bsdinstall: add knob to set ASLR sysctls
Sat, Feb 20, 4:57 PM
emaste closed D28417: bsdinstall: replace multiple ifs with case.
Sat, Feb 20, 4:57 PM
emaste committed R10:fbc57e2df95b: bsdinstall: replace multiple ifs with case (authored by emaste).
bsdinstall: replace multiple ifs with case
Sat, Feb 20, 4:57 PM
emaste requested review of D28815: Add commit message information to committer's guide.
Sat, Feb 20, 3:30 AM
emaste updated the diff for D28814: hier.7: move ESP mountpoint to /efi (from /boot/efi).

Remove old /boot/efi too

Sat, Feb 20, 12:17 AM