Page MenuHomeFreeBSD

emaste (Ed Maste)
UserAdministrator

Projects (15)

User Details

User Since
Nov 24 2013, 3:15 AM (496 w, 2 d)
Roles
Administrator

Recent Activity

Today

emaste added a reviewer for D40341: unbound: avoid calling deprecated OpenSSL function: ngie.
Tue, May 30, 9:43 PM
emaste requested review of D40341: unbound: avoid calling deprecated OpenSSL function.
Tue, May 30, 9:42 PM
emaste accepted D40275: Fix rpc.tlsservd and rpc.tlsclntd so they build for OpenSSL3.

I guess we did not observe a problem here in the OpenSSL 3 experiments because the deprecation checks only activate when OPENSSL_API_COMPAT is set.

Tue, May 30, 6:04 PM
emaste updated subscribers of D40275: Fix rpc.tlsservd and rpc.tlsclntd so they build for OpenSSL3.
Tue, May 30, 5:57 PM
emaste added a comment to D40236: Fix NULL deref in ip_output during route change.

Looks like a sensible approach for 12.x

Tue, May 30, 3:16 PM
emaste committed rG98c5211847af: Cirrus-CI: move arch and toolchain to beginning of task names (authored by emaste).
Cirrus-CI: move arch and toolchain to beginning of task names
Tue, May 30, 1:18 PM
emaste committed rGdf042dcf268c: Cirrus-CI: add amd64 and arm64 Clang/LLVM 16 jobs (authored by emaste).
Cirrus-CI: add amd64 and arm64 Clang/LLVM 16 jobs
Tue, May 30, 1:18 PM
emaste closed D40286: Cirrus-CI: Add Clang/LLVM 16 job.
Tue, May 30, 1:18 PM

Sat, May 27

emaste accepted D40305: Reduce ifdef soup by adding pre-3.0 compat support.
Sat, May 27, 11:09 PM
emaste added a comment to D40297: Add simple factor/primes regression tests.

anyhow, I think it's reasonable to commit this version and update if/when we change factor to disallow non-integer args

Sat, May 27, 4:22 PM
emaste accepted D40297: Add simple factor/primes regression tests.
Sat, May 27, 4:21 PM
emaste added inline comments to D40297: Add simple factor/primes regression tests.
Sat, May 27, 1:27 PM
emaste accepted D40298: factor: support OpenSSL 3.

When it's time to merge this I'd suggest squashing in the OPENSSL_API_COMPAT addition so that usr.bin/factor/Makefile does not change on stable/13, but we retain the "cherry picked from" line.

Sat, May 27, 1:17 PM
emaste accepted D40295: libpcap: Update PACKAGE_STRING to 1.10.4.

Don't forget to add a Fixes: trailer upon commit

Sat, May 27, 2:30 AM

Fri, May 26

emaste added inline comments to D40289: hwpmc: style(9) pass of hwpmc_mod.c.
Fri, May 26, 8:02 PM
emaste accepted D40288: hpwmc: add __pmcdbg_used annotation.
Fri, May 26, 8:00 PM
emaste added inline comments to D40290: hwpmc: Improve re-attachment logic in pmc_process_exec().
Fri, May 26, 7:55 PM
emaste added a comment to D40286: Cirrus-CI: Add Clang/LLVM 16 job.

Run: https://cirrus-ci.com/build/6750220826968064

Fri, May 26, 6:27 PM
emaste added inline comments to D40286: Cirrus-CI: Add Clang/LLVM 16 job.
Fri, May 26, 6:20 PM
emaste updated the diff for D40286: Cirrus-CI: Add Clang/LLVM 16 job.

also add arm64-llvm16 job

Fri, May 26, 6:20 PM
emaste requested review of D40286: Cirrus-CI: Add Clang/LLVM 16 job.
Fri, May 26, 6:03 PM
emaste committed rG7409d45ed4c5: auditdistd: Request the OpenSSL 1.1 API (authored by khorben_defora.org).
auditdistd: Request the OpenSSL 1.1 API
Fri, May 26, 1:23 PM
emaste closed D40273: auditdistd: Avoid calling deprecated OpenSSL functions.
Fri, May 26, 1:22 PM
emaste committed rGb01c10d25d06: auditdistd: Avoid calling deprecated OpenSSL functions (authored by emaste).
auditdistd: Avoid calling deprecated OpenSSL functions
Fri, May 26, 1:22 PM
emaste committed rG0f2bb40bc7dd: lldb: dereference stoppcbs based on target kernel version (authored by emaste).
lldb: dereference stoppcbs based on target kernel version
Fri, May 26, 1:50 AM
emaste closed D39939: lldb: dereference stoppcbs based on target kernel version.
Fri, May 26, 1:50 AM

Thu, May 25

emaste added a comment to D40273: auditdistd: Avoid calling deprecated OpenSSL functions.

(Copied from the GitHub pull request) So far I am aiming for minimal diffs, and plan to make another pass over everything later on including updates to use OpenSSL 3 APIs. In particular I don't want to delete SSL_library_init(); if other pre-OpenSSL-1.1 code remains (I haven't checked whether or not it does, yet).

Thu, May 25, 11:45 PM
emaste committed rGfed03614bd2d: factor: Request the OpenSSL 1.1 API (authored by khorben_defora.org).
factor: Request the OpenSSL 1.1 API
Thu, May 25, 8:53 PM
emaste requested review of D40273: auditdistd: Avoid calling deprecated OpenSSL functions.
Thu, May 25, 7:47 PM
emaste committed rG5a7500dab9b8: libarchive: Request the OpenSSL 1.1 API (authored by khorben_defora.org).
libarchive: Request the OpenSSL 1.1 API
Thu, May 25, 7:10 PM
emaste committed rG07523f1d4fae: libradius: specify OpenSSL 1.1 APIs (authored by khorben_defora.org).
libradius: specify OpenSSL 1.1 APIs
Thu, May 25, 5:18 PM
emaste committed rG77d788e23d09: libfetch: specify OpenSSL 1.1 APIs (authored by khorben_defora.org).
libfetch: specify OpenSSL 1.1 APIs
Thu, May 25, 5:17 PM
emaste committed rG01aee8c92d93: libfetch: do not call deprecated OpenSSL functions (authored by emaste).
libfetch: do not call deprecated OpenSSL functions
Thu, May 25, 4:22 PM
emaste closed D40265: libfetch: do not call deprecated OpenSSL functions.
Thu, May 25, 4:22 PM
emaste added a comment to D40265: libfetch: do not call deprecated OpenSSL functions.

For reference, in current OpenSSL 1.1:

Thu, May 25, 4:10 PM
emaste requested review of D40265: libfetch: do not call deprecated OpenSSL functions.
Thu, May 25, 3:30 PM
emaste committed rG5804b7ab378d: superio: Add device ID for ITE IT8613 (authored by jo_bruelltuete.com).
superio: Add device ID for ITE IT8613
Thu, May 25, 3:21 PM
emaste closed D39969: superio(4): Add device ID for ITE IT8613.
Thu, May 25, 3:20 PM
emaste added a comment to D39969: superio(4): Add device ID for ITE IT8613.

Can you please provide the author info as you'd like it to be, for git commit --author=...

Thu, May 25, 1:49 PM
emaste committed rGb238d51d0adc: ldns: specify OpenSSL 1.1 APIs (authored by khorben_defora.org).
ldns: specify OpenSSL 1.1 APIs
Thu, May 25, 2:18 AM

Wed, May 24

emaste committed rGbaef3a5b585f: tcpdump: specify OpenSSL 1.1 APIs (authored by khorben_defora.org).
tcpdump: specify OpenSSL 1.1 APIs
Wed, May 24, 11:45 PM
emaste committed rG96e6e5b5fe9b: ppp: specify OpenSSL 1.1 APIs (authored by khorben_defora.org).
ppp: specify OpenSSL 1.1 APIs
Wed, May 24, 6:56 PM
emaste committed rGffbd1c8bc08e: libtelnet: specify OpenSSL 1.1 APIs (authored by emaste).
libtelnet: specify OpenSSL 1.1 APIs
Wed, May 24, 6:41 PM
emaste added a comment to D39806: smp: Dynamically allocate the stoppcbs array.

According to our general compatibility policy I'd presume to be able to use 13.0 kgdb to debug 13.x vmcores. If so, that precludes MFCing the kernel patch, no matter which approach is taken.

Wed, May 24, 6:06 PM
emaste committed rGae60012e46ec: release/oci.conf: add missing vm_extra_pre_umount() steps (authored by emaste).
release/oci.conf: add missing vm_extra_pre_umount() steps
Wed, May 24, 5:12 PM
emaste closed D40257: release/oci.conf: add missing vm_extra_pre_umount() steps.
Wed, May 24, 5:12 PM
emaste requested review of D40257: release/oci.conf: add missing vm_extra_pre_umount() steps.
Wed, May 24, 3:49 PM
emaste added a comment to D36838: amd64: Bump MAXCPU to 1024 (from 256).

Userland cpuset_t increase has been reapplied.

Wed, May 24, 3:25 PM
emaste accepted D40226: ldns: Upgrade to 1.8.3..

IMO for privatelib we can leave SHLIB_MAJOR alone

Wed, May 24, 3:14 PM
emaste committed rGd1639e43c589: cpuset: increase userland maximum size to 1024 (authored by emaste).
cpuset: increase userland maximum size to 1024
Wed, May 24, 3:09 PM
emaste added a comment to D40246: LinuxKPI: add ktime_get_real_ts64().

AFAICT "real" refers to it being time of day, rather than not-cached.

Wed, May 24, 12:32 PM
emaste accepted D40248: LinuxKPI: add utsname for init_utsname() with release.
Wed, May 24, 12:17 AM
emaste accepted D40249: LinuxKPI: uuid: add guid_gen() and guid_copy().
Wed, May 24, 12:14 AM

Tue, May 23

emaste added inline comments to D40250: LinuxKPI: add page pool skeleton.
Tue, May 23, 11:58 PM
emaste added a comment to D40246: LinuxKPI: add ktime_get_real_ts64().

I'm not sure if this one needs to be the non-get version, could be getnanotime?

Tue, May 23, 11:47 PM
emaste accepted D40213: Teach ifconfig to attach and run itself in a jail..
Tue, May 23, 7:45 PM
emaste added a comment to D40217: Update handbook/pkg-files#pkg-message to use sysrc and service .

Oops @carlavilla just missed your review before pushing.

Tue, May 23, 7:30 PM
emaste closed D40217: Update handbook/pkg-files#pkg-message to use sysrc and service .
Tue, May 23, 7:30 PM
emaste committed R9:b992b27125b5: porters-handbook: reference tools for handling services (authored by admin_hackacad.net).
porters-handbook: reference tools for handling services
Tue, May 23, 7:30 PM
emaste accepted D40205: mksnap_ffs.8: update /home examples.
Tue, May 23, 7:13 PM
emaste accepted D40233: website: Update Software License Policy examples.
Tue, May 23, 6:51 PM
emaste updated the diff for D40217: Update handbook/pkg-files#pkg-message to use sysrc and service .

Combine new note into existing block

Tue, May 23, 6:42 PM
emaste commandeered D40217: Update handbook/pkg-files#pkg-message to use sysrc and service .
Tue, May 23, 6:42 PM
emaste added a comment to D40217: Update handbook/pkg-files#pkg-message to use sysrc and service .

I think @jrm is right, this can just go in the existing box:

image.png (382×1 px, 69 KB)

Tue, May 23, 6:40 PM
emaste accepted D40242: ofw_cpu: whitespace cleanup.
Tue, May 23, 6:05 PM
emaste accepted D40232: developers-handbook: Remove source code layout.
Tue, May 23, 5:42 PM
emaste added a comment to D40209: New committer (src): Christos Margiolis (christos).

In this case, I *think* you can just go ahead even though I don't have a doc bit either.

Tue, May 23, 3:35 PM
emaste accepted D40209: New committer (src): Christos Margiolis (christos).

(You can commit to doc/ as well with approval.)

Tue, May 23, 3:28 PM
emaste closed D40214: FAQ: switch Subversion references to Git.
Tue, May 23, 3:14 PM
emaste committed R9:34c42fd3b3d4: FAQ: switch Subversion references to Git (authored by emaste).
FAQ: switch Subversion references to Git
Tue, May 23, 3:14 PM
emaste added a comment to D19934: Add an "Event: " line to the commit messages to not abuse the "Sponsored by:" line.

This was added in 8da7e46fae2f in fact. Perhaps it was by accident?

Tue, May 23, 3:11 PM
emaste accepted D40232: developers-handbook: Remove source code layout.
Tue, May 23, 3:03 PM
emaste added inline comments to D40217: Update handbook/pkg-files#pkg-message to use sysrc and service .
Tue, May 23, 2:39 PM
emaste added inline comments to D40217: Update handbook/pkg-files#pkg-message to use sysrc and service .
Tue, May 23, 2:37 PM
emaste added a reviewer for D40157: add defaults for adduser.sh (OK? [yes] & additional user [no]): kevans.
Tue, May 23, 2:14 PM

Mon, May 22

emaste updated subscribers of D40217: Update handbook/pkg-files#pkg-message to use sysrc and service .
Mon, May 22, 10:10 PM
emaste accepted D40157: add defaults for adduser.sh (OK? [yes] & additional user [no]).

This LGTM. I suspect "All OK" might have intentionally had no default (to force the admin to pause and confirm) but IMO it really does not have a benefit.

Mon, May 22, 10:07 PM
emaste committed R9:52c0a842a1bd: FAQ: update "Where can I get FreeBSD" for current releases (authored by emaste).
FAQ: update "Where can I get FreeBSD" for current releases
Mon, May 22, 9:49 PM
emaste committed R9:f005afe756bf: linux-users: reference Git repository (not svn) (authored by emaste).
linux-users: reference Git repository (not svn)
Mon, May 22, 8:47 PM
emaste added inline comments to D40214: FAQ: switch Subversion references to Git.
Mon, May 22, 8:43 PM
emaste requested review of D40214: FAQ: switch Subversion references to Git.
Mon, May 22, 8:40 PM
emaste added a comment to D40213: Teach ifconfig to attach and run itself in a jail..

yes let's add the man page in here too

Mon, May 22, 8:26 PM
emaste accepted D40208: Update -ftrivial-auto-var-init flags for clang >= 16 and gcc >= 12.

IMO bsd.compiler.mk (enabling for GCC) can be committed separately

Mon, May 22, 6:36 PM
emaste closed D40196: committers-guide: make it clear that `Submitted by` is deprecated.
Mon, May 22, 1:50 PM
emaste committed R9:89243b692318: committers-guide: make it clear that `Submitted by` is deprecated (authored by emaste).
committers-guide: make it clear that `Submitted by` is deprecated
Mon, May 22, 1:50 PM

Sun, May 21

emaste committed R9:816e51eadb5e: 13.2 relnotes: clarify page invalidation hardware bug (authored by emaste).
13.2 relnotes: clarify page invalidation hardware bug
Sun, May 21, 11:22 PM
emaste requested review of D40196: committers-guide: make it clear that `Submitted by` is deprecated.
Sun, May 21, 11:14 PM

Sat, May 20

emaste added inline comments to D40183: build: Reduce the cost of supporting NO<INET|INET6|IP>* variants of the kernel..
Sat, May 20, 2:59 PM
emaste added a comment to D40184: prepare-commit-msg: add 'Event'.

IMO this shouldn't sort first, perhaps it should go along with Sponsored by:

Sat, May 20, 2:56 PM
emaste accepted D40174: LinuxKPI: add put_unaligned_le16() and get_unaligned_be64().
Sat, May 20, 2:10 AM
emaste accepted D40176: LinuxKPI: add dummy rhashtable implementation.
Sat, May 20, 2:08 AM

Fri, May 19

emaste accepted D40149: linux(4): Guard linux_fork.h by _KERNEL for use by libsysdecode.
Fri, May 19, 2:25 PM · Linux Emulation
emaste accepted D40151: kdump: Decode linux_clone syscall flags.
Fri, May 19, 2:23 PM · Linux Emulation
emaste accepted D40150: libsysdecode: Decode linux_clone syscall flags.
Fri, May 19, 2:18 PM · Linux Emulation
emaste committed rGf326a83c8570: Cirrus-CI: switch to -lite LLVM package for native run (authored by emaste).
Cirrus-CI: switch to -lite LLVM package for native run
Fri, May 19, 1:59 PM
emaste closed D40136: Cirrus-CI: switch to lite LLVM package.
Fri, May 19, 1:58 PM

Thu, May 18

emaste added inline comments to D40136: Cirrus-CI: switch to lite LLVM package.
Thu, May 18, 8:03 PM
emaste accepted D40152: linux(4): Drop a weird comment from linux_set_syscall_retval on amd64.
Thu, May 18, 7:39 PM · Linux Emulation
emaste updated subscribers of D40152: linux(4): Drop a weird comment from linux_set_syscall_retval on amd64.
Thu, May 18, 7:39 PM · Linux Emulation
emaste added a comment to D40148: linux(4): Add a dedicated linux_exec_copyin_args().

Are we aware of any actual Linux binary use cases for argc=0?

Thu, May 18, 7:33 PM