Should the man page document AT_FDCWD?

Sounds good to me.

LGTM

These should be posted upstream at https://reviews.llvm.org/ See https://llvm.org/docs/Phabricator.html for notes on submission - in particular, note the requirement to CC the mailing list with the initial review creation, and include context with the diff.

This will be fixed via an upstream change and import.

Upstream pull request at https://github.com/libarchive/libarchive/pull/926

What about an (unsigned long) cast and %lu? Since bus_size_t is already unsigned long that seems to be reasonable, and doesn't require an unnecessary 64-bit value on ILP32 archs.

aside, there's come crazy whitespace going on in iflib.c

After merging LLVM r308492 to my wip branch (based on FreeBSD's clang500-import branch) the buildworld/buildkernel with this change is successful. If you can merge r308492 to the 5.0 branch we'll bring it into FreeBSD-HEAD from there, and could apply this change later.

Oh, wait -- this failure was observed with the FreeBSD clang500-import branch, which has llvm/clang/lld/lldb/compiler-rt/libc++ at upstream r308421.

Although I wonder if we shouldn't arrange the build & sys/cdefs.h to activate all of the .symver machinery only for the objects that will be used by the shared lib, excluding it all from libc.a?

With this patch my build fails in some applications that link against libc.a.

I have a test universe build running and will commit the change once that finishes.

correct retypeo from previous upload

check an additional localtime for NULL return

Do you have a doc reference for @@@?

Do you have a doc reference for @@@?

It looks like ARCH_FLAGS is used only on MIPS? I'm missing something here since it seems the default MIPS ARCH_FLAGS is set in sys/conf/Makefile.mips, which has CFLAGS+=${EXTRA_FLAGS} $(ARCH_FLAGS)

Just add new symbols to version file -- additional work is required to enable this for amd64, but this should have an effect on arm64 and riscv64.

What about aux filters ? The patch should be same.

Filter support is in review at https://reviews.llvm.org/D35352.

Can we add a base test to catch this?

I think we ought to have some note in dlopen.2 mentioning that libdl is provided for compatibility on FreeBSD but is not needed.

Approved.