emaste (Ed Maste)Administrator
User

Projects (9)

User Details

User Since
Nov 24 2013, 3:15 AM (247 w, 2 h)
Roles
Administrator

Recent Activity

Fri, Aug 17

emaste committed rS337963: MFC r337569: readelf: display NT_GNU_PROPERTY_TYPE_0 note name.
MFC r337569: readelf: display NT_GNU_PROPERTY_TYPE_0 note name
Fri, Aug 17, 12:39 PM

Thu, Aug 16

emaste accepted D16750: Enable -zifunc-noplt on i386 and amd64..
Thu, Aug 16, 9:59 PM
emaste accepted D16748: Preserve relocations against ifuncs when -zifunc-noplt is specified..
Thu, Aug 16, 9:58 PM
emaste added inline comments to D16750: Enable -zifunc-noplt on i386 and amd64..
Thu, Aug 16, 9:57 PM
emaste added inline comments to D16750: Enable -zifunc-noplt on i386 and amd64..
Thu, Aug 16, 5:03 PM
emaste added a comment to D16748: Preserve relocations against ifuncs when -zifunc-noplt is specified..

I think this is good and agree it should be easy to carry as a local patch while coordinating upstreaming. Man page update needed too though.

Thu, Aug 16, 4:58 PM
emaste committed rS337901: src.conf.5: regen after r337899 WITH_LLD_IS_LD on armv7.
src.conf.5: regen after r337899 WITH_LLD_IS_LD on armv7
Thu, Aug 16, 9:37 AM
emaste committed rS337899: Enable LLD_IS_LD by default on armv7.
Enable LLD_IS_LD by default on armv7
Thu, Aug 16, 9:11 AM

Wed, Aug 15

emaste created D16734: sys/types.h: avoid using terse macro _M.
Wed, Aug 15, 9:43 PM

Fri, Aug 10

emaste committed rS337569: readelf: display NT_GNU_PROPERTY_TYPE_0 note name.
readelf: display NT_GNU_PROPERTY_TYPE_0 note name
Fri, Aug 10, 10:37 AM

Thu, Aug 9

emaste added a comment to D16507: build: skip the database check for the distributeworld target.

Upgrading the build host is a way of saying that building images for a given version is only supported if the build host is running the version of the image you're trying to build.

Thu, Aug 9, 9:24 AM

Sun, Aug 5

emaste added a comment to D16593: Summary: git-svn-init: Clarify branch creation commands Suggested by: eadler.

Approved

Sun, Aug 5, 6:58 PM

Sat, Aug 4

emaste added a comment to D16584: Remove chroot(2) call from dhclient..

I thought that was planned for 12, actually.

Sat, Aug 4, 12:54 AM

Fri, Aug 3

emaste accepted D16385: Make the default image base on AArch64 and i386 superpage-aligned.

This is fine with me, and I have no objection to it going into FreeBSD first and @dim@ or @markj or me working on upstream.

Fri, Aug 3, 7:13 PM
emaste added inline comments to D15734: Fix objcopy for little-endian MIPS64 objects..
Fri, Aug 3, 4:06 PM
emaste added a comment to D15713: Bug 182518 - [login.conf] Better Password Hashes .

In fairness, this example pre-dates the crypt_r in FreeBSD by 4+ years.

Fri, Aug 3, 2:26 PM · security
emaste committed rS337240: Chase sanitizer file rename from r337136.
Chase sanitizer file rename from r337136
Fri, Aug 3, 2:03 PM
emaste updated subscribers of D16563: Add signelf utility.

@linimon I removed the "libelf" prefix; this review includes a change to libelf (which is actually the dependency D10487 and ought not be included here) but this change is not a "libelf" change.

Fri, Aug 3, 2:19 AM
emaste retitled D16563: Add signelf utility from libelf: Add signelf utility to Add signelf utility.
Fri, Aug 3, 2:17 AM

Thu, Aug 2

emaste committed rS337176: lld: use now-upstream ld.lld.1.
lld: use now-upstream ld.lld.1
Thu, Aug 2, 8:31 PM
emaste committed rS337174: ld.lld.1: restore option note from FreeBSD r329003.
ld.lld.1: restore option note from FreeBSD r329003
Thu, Aug 2, 8:28 PM
emaste committed rS337173: Merge vendor lld/docs directory from r337145.
Merge vendor lld/docs directory from r337145
Thu, Aug 2, 8:26 PM
emaste added a comment to D16385: Make the default image base on AArch64 and i386 superpage-aligned.
In D16385#351802, @alc wrote:

If the switch to lld on i386 is changing the default image base, then we might as well be changing it to a superpage-aligned address.

Thu, Aug 2, 8:08 PM
emaste added a comment to D16370: Implement early microcode loading for Intel i386 and amd64 platforms..

Businesses may have early NDA access to microcode that the port does not have access to or cannot distribute.

Thu, Aug 2, 5:00 PM
emaste added a comment to D16370: Implement early microcode loading for Intel i386 and amd64 platforms..

We'd re-apply the old blob. I'm not sure if this is a bug or not - if no blob is loaded at boot time, then upon resume the new update will be lost anyway.

Thu, Aug 2, 3:03 PM
emaste added a parent revision for D16563: Add signelf utility: D10487: Bug 218861 - libelf elf_update fails when adding sections.
Thu, Aug 2, 2:59 PM
emaste added a child revision for D10487: Bug 218861 - libelf elf_update fails when adding sections: D16563: Add signelf utility.
Thu, Aug 2, 2:59 PM
emaste updated the diff for D16438: makefs: add msdosfs support.

Undo renames pointed out by @cem

Thu, Aug 2, 1:17 PM
emaste committed rS337130: Regen src.conf.5 after r337057, LLD_BOOTSTRAP on armv7.
Regen src.conf.5 after r337057, LLD_BOOTSTRAP on armv7
Thu, Aug 2, 12:39 PM
emaste added inline comments to D16438: makefs: add msdosfs support.
Thu, Aug 2, 12:25 AM

Wed, Aug 1

emaste committed rS337057: Use lld as the bootstrap linker on armv7 by default.
Use lld as the bootstrap linker on armv7 by default
Wed, Aug 1, 7:18 PM
emaste closed D16528: Use lld as the bootstrap linker on armv7 by default.
Wed, Aug 1, 7:18 PM
emaste added a comment to D10487: Bug 218861 - libelf elf_update fails when adding sections.

Awaiting review; I pointed out a couple of minor nits to address on commit

Wed, Aug 1, 6:17 PM
emaste updated subscribers of D10487: Bug 218861 - libelf elf_update fails when adding sections.
Wed, Aug 1, 4:41 PM
emaste committed rS337045: libelf: reload section headers after update with ELF_C_WRITE.
libelf: reload section headers after update with ELF_C_WRITE
Wed, Aug 1, 3:55 PM
emaste closed D10486: Bug 218860 - libelf doesn't reload section headers after update with ELF_C_WRITE.
Wed, Aug 1, 3:55 PM
emaste added a comment to D10486: Bug 218860 - libelf doesn't reload section headers after update with ELF_C_WRITE.

Other issue in D10487

Wed, Aug 1, 2:07 PM
emaste added a comment to D16313: Remove xscale support.

The commit message should have background about the removal and why we believe it's acceptable (did not actually work, hardware has not been produced for years and has no known users, etc.)

Wed, Aug 1, 2:00 PM
emaste added a comment to D10486: Bug 218860 - libelf doesn't reload section headers after update with ELF_C_WRITE.

I pinged @kaiw by email requesting a look at this change.

Wed, Aug 1, 1:51 PM
emaste added a comment to D10320: usr.bin/netstat: -n should not print symbolic names.

I still believe this change should go in, although if we really believe it's a backwards compatibility issue perhaps avoid default only with -n -n or -nn?

Wed, Aug 1, 1:49 PM
emaste added a comment to D16025: Fix misspellings of transmit, transmitter, and transmitted.

atombios.h is 3rd party code, although I am unsure if there's a viable upstream to submit it to. Please go ahead with the others for now though.

Wed, Aug 1, 1:21 PM
emaste added a comment to D15785: Handle case when the PCAP file is not set in tcpdump.

Ping

Wed, Aug 1, 1:17 PM
emaste accepted D16042: tools: Add a git-svn bootstrap script.

Approved, we can get additional testing with it in tree.

Wed, Aug 1, 1:17 PM
emaste added a comment to D15734: Fix objcopy for little-endian MIPS64 objects..

LGTM with @jkoshy_users.sourceforge.net's comments addressed

Wed, Aug 1, 1:13 PM
emaste added a comment to D14034: Chapter 17.9 of the Handbook: put -t cd9660 option for the ISO formats.

@bcr please go ahead

Wed, Aug 1, 1:09 PM
emaste added a comment to D13179: Add "Pull Request" to the devel/subversion commit template.

Ping

Wed, Aug 1, 1:01 PM
emaste added a comment to D12533: Fix building the kernel with upstream clang.

What happened to this change?

Wed, Aug 1, 1:00 PM
emaste added a comment to D11317: expr(1): Add -E flag to interpret regular expressions as EREs.

I think this is fine.

Wed, Aug 1, 12:58 PM
emaste added a comment to D7876: Add Security System/Crypto (PRNG) driver for Allwinner A10/A20 SoC.

Googling turned up http://sunxi.montjoie.ovh/ with Linux status, which claims:

Wed, Aug 1, 12:44 PM

Tue, Jul 31

emaste added a comment to D16528: Use lld as the bootstrap linker on armv7 by default.

FreeBSD version number bumped in rS337009

Tue, Jul 31, 9:28 PM
emaste committed rS337009: bump lld version number after r336972 arm(v7) VFP tag support.
bump lld version number after r336972 arm(v7) VFP tag support
Tue, Jul 31, 9:06 PM
emaste added a comment to D16527: Require MAC labels to be non-zero in length..

I dislike the magic 2 without a comment or #define

Tue, Jul 31, 8:51 PM
emaste added a comment to D16528: Use lld as the bootstrap linker on armv7 by default.

force a bootstrap LLD to be built?

Tue, Jul 31, 8:31 PM
emaste committed rS337003: Remove presumed editor dropping from r336988.
Remove presumed editor dropping from r336988
Tue, Jul 31, 7:35 PM
emaste updated the summary of D16528: Use lld as the bootstrap linker on armv7 by default.
Tue, Jul 31, 3:40 PM
emaste created D16528: Use lld as the bootstrap linker on armv7 by default.
Tue, Jul 31, 3:40 PM
emaste committed rS336972: lld: [ELF][ARM] Implement support for Tag_ABI_VFP_args.
lld: [ELF][ARM] Implement support for Tag_ABI_VFP_args
Tue, Jul 31, 3:25 PM
emaste committed rS336970: llvm: [ARM] Complete enumeration values for Tag_ABI_VFP_args.
llvm: [ARM] Complete enumeration values for Tag_ABI_VFP_args
Tue, Jul 31, 2:14 PM
emaste committed rS336969: llvm: [ELF][ARM] Add Arm ABI names for float ABI ELF Header flags.
llvm: [ELF][ARM] Add Arm ABI names for float ABI ELF Header flags
Tue, Jul 31, 2:12 PM
emaste added a comment to D16438: makefs: add msdosfs support.

It's possible to build makefs FAT support now:

  1. apply D16526 (header modifications)
  2. copy msdosfs_fat.c and msdosfs_lookup.c from sys/fs/msdosfs to usr.sbin/makefs/msdos
  3. apply D16438
Tue, Jul 31, 12:58 PM
emaste added a parent revision for D16438: makefs: add msdosfs support: D16526: msdosfs: header changes to support makefs.
Tue, Jul 31, 12:53 PM
emaste added a child revision for D16526: msdosfs: header changes to support makefs: D16438: makefs: add msdosfs support.
Tue, Jul 31, 12:53 PM
emaste created D16526: msdosfs: header changes to support makefs.
Tue, Jul 31, 12:53 PM
emaste committed rS336966: msdosfs: trim EOL whitespace.
msdosfs: trim EOL whitespace
Tue, Jul 31, 12:44 PM
emaste committed rS336965: cd9660: replace bcopy/bzero with C standard equivalents.
cd9660: replace bcopy/bzero with C standard equivalents
Tue, Jul 31, 12:37 PM

Mon, Jul 30

emaste updated the diff for D16438: makefs: add msdosfs support.

Updated patch that shares kernel headers, based on part of D11197

Mon, Jul 30, 9:48 PM
emaste added a comment to D14725: Make timespecadd(3) and friends public.

Phabricator's still working:

Still Importing...
This commit is still importing. Changes will be visible once the import finishes.

Mon, Jul 30, 9:40 PM
emaste committed rS336935: msdosfs: use same max filesize #define as NetBSD and move to header.
msdosfs: use same max filesize #define as NetBSD and move to header
Mon, Jul 30, 8:37 PM
emaste added a comment to D12298: libc: remove gets.

The hacky workaround would have to be something like #define gets(s) abort(), NULL instead, but I am unable to verify the gets -> __gets_chk transformation works in the first place. Maybe the GCC build does not enable this on FreeBSD?

Mon, Jul 30, 6:13 PM
emaste committed rS336920: MFC r335459: acpidump.8: include NFIT in the man page list of tables.
MFC r335459: acpidump.8: include NFIT in the man page list of tables
Mon, Jul 30, 5:50 PM
emaste added a comment to D16155: Add veriexec to loader.

Little tip, if you use just the short D##### tag Phabricator will automatically add links both ways:

Mon, Jul 30, 5:02 PM
emaste committed rS336910: Revert accidental change from r336908.
Revert accidental change from r336908
Mon, Jul 30, 3:10 PM
emaste committed rS336908: Makefile.libcompat: correctly append to make variable.
Makefile.libcompat: correctly append to make variable
Mon, Jul 30, 2:43 PM
emaste committed rS336907: Makefile.libcompat: use one variable assignment per line.
Makefile.libcompat: use one variable assignment per line
Mon, Jul 30, 2:28 PM
emaste committed rS336904: Regen src.conf.5 after r336901, WITH_LLD_BOOTSTRAP on i386.
Regen src.conf.5 after r336901, WITH_LLD_BOOTSTRAP on i386
Mon, Jul 30, 12:58 PM
emaste committed rS336901: Enable ld.lld as bootstrap linker by default on i386.
Enable ld.lld as bootstrap linker by default on i386
Mon, Jul 30, 12:38 PM
emaste committed rS336880: MFC r336664: lld: fix addends with partial linking.
MFC r336664: lld: fix addends with partial linking
Mon, Jul 30, 12:08 AM
emaste committed rS336879: Correct typo and whitespace in UPDATING.
Correct typo and whitespace in UPDATING
Mon, Jul 30, 12:05 AM

Sat, Jul 28

emaste committed rS331254: Rename assym.s to assym.inc.
Rename assym.s to assym.inc
Sat, Jul 28, 3:28 AM
emaste closed D14180: Rename assym.s to .S to use the compiler driver.
Sat, Jul 28, 3:27 AM

Thu, Jul 26

emaste committed rS336745: elf_common: update ARM ABI flag names.
elf_common: update ARM ABI flag names
Thu, Jul 26, 5:53 PM
emaste added a comment to D16089: committer guide: update rules for contrib software..

Seems a good change overall, thank you

Thu, Jul 26, 3:02 PM
emaste committed rS336736: makefs: use FreeBSD brelse function signature.
makefs: use FreeBSD brelse function signature
Thu, Jul 26, 1:33 PM

Wed, Jul 25

emaste updated subscribers of D16438: makefs: add msdosfs support.
Wed, Jul 25, 8:47 PM
emaste added inline comments to D16438: makefs: add msdosfs support.
Wed, Jul 25, 8:45 PM
emaste added inline comments to D16438: makefs: add msdosfs support.
Wed, Jul 25, 7:27 PM
emaste updated the diff for D16438: makefs: add msdosfs support.
  • Exclude buf.h changes
  • Rebase on newly copied sys/fs/msdosfs files
Wed, Jul 25, 6:01 PM
emaste added a comment to D11197: msdosfs: expose and hide definitions/functions for makefs FAT fs support.

I would prefer that we share the common files, and have the side effect of allowing us to more easily test and debug the msdosfs code, but in the interest of expediency I've posted a rebased version of Siva's work that copies the files to userland -- D16438. We can take a careful look at deduplication later on.

Wed, Jul 25, 2:29 PM
emaste added inline comments to D16438: makefs: add msdosfs support.
Wed, Jul 25, 2:04 PM
emaste created D16438: makefs: add msdosfs support.
Wed, Jul 25, 1:52 PM
emaste committed rS336706: makefs: whitespace cleanup in msdos files.
makefs: whitespace cleanup in msdos files
Wed, Jul 25, 1:27 PM
emaste accepted D16434: Actually install bsd.dirs.mk.
Wed, Jul 25, 12:24 AM
emaste committed rS336692: sockopt.h: remove stale comment.
sockopt.h: remove stale comment
Wed, Jul 25, 12:18 AM
emaste added a comment to D11962: Use __FreeBSD_version insted of __FreeBSD__.

I committed my change in rS336691; if we're going to make a change like the one in this D11962 we can include lib/clang/include/llvm/Config/config.h as well.

Wed, Jul 25, 12:12 AM
emaste committed rS336691: llvm: remove __FreeBSD_version conditionals.
llvm: remove __FreeBSD_version conditionals
Wed, Jul 25, 12:06 AM

Tue, Jul 24

emaste committed rS336687: Revert msdosfs MAKEFS #ifdef changes from r319870.
Revert msdosfs MAKEFS #ifdef changes from r319870
Tue, Jul 24, 9:10 PM
emaste added a comment to D11962: Use __FreeBSD_version insted of __FreeBSD__.

I have a related change for Clang in https://github.com/emaste/freebsd/commit/b03c6b060658f5fed4a2ad8511095c5f4df6e9f4 to avoid rebuilding so much when __FreeBSD_version gets bumped.

Tue, Jul 24, 6:59 PM
emaste committed rS336664: lld: fix addends with partial linking.
lld: fix addends with partial linking
Tue, Jul 24, 11:35 AM

Mon, Jul 23

emaste committed rS336657: arch.7: fix whitespace from r336435.
arch.7: fix whitespace from r336435
Mon, Jul 23, 9:10 PM
emaste added inline comments to D16403: Finalize the boot manager protocol support for next-stage boot loading..
Mon, Jul 23, 8:39 PM