emaste (Ed Maste)Administrator
User

Projects (7)

User Details

User Since
Nov 24 2013, 3:15 AM (174 w, 4 d)
Roles
Administrator

Recent Activity

Yesterday

emaste committed rS316284: elfcopy: remove temporary ELF file when converting from binary.
elfcopy: remove temporary ELF file when converting from binary
Thu, Mar 30, 5:37 PM
emaste added inline comments to D10193: Remove archaic register keyword from sys and ANSIfy prototypes while here.
Thu, Mar 30, 1:18 AM
emaste added inline comments to D10193: Remove archaic register keyword from sys and ANSIfy prototypes while here.
Thu, Mar 30, 1:15 AM
emaste updated subscribers of D10193: Remove archaic register keyword from sys and ANSIfy prototypes while here.
Thu, Mar 30, 1:08 AM
emaste added a comment to D10193: Remove archaic register keyword from sys and ANSIfy prototypes while here.
In D10193#210689, @cem wrote:

Did you use a coccinelle script for the ANSIfying, and if so, what was it?

Thu, Mar 30, 1:07 AM
emaste committed rS316188: libc: remove use of archaic __P() macro.
libc: remove use of archaic __P() macro
Thu, Mar 30, 1:03 AM
emaste created D10193: Remove archaic register keyword from sys and ANSIfy prototypes while here.
Thu, Mar 30, 12:53 AM

Wed, Mar 29

emaste added a comment to D10170: Capsicumize cpuset_*.

Oops, forgot to hit "Submit," so sorry if some of these comments are OBE.

Wed, Mar 29, 11:43 PM
emaste committed rS316177: makefs: sync with NetBSD.
makefs: sync with NetBSD
Wed, Mar 29, 8:50 PM
emaste committed rS316150: makefs: free specfile structure once it has been applied.
makefs: free specfile structure once it has been applied
Wed, Mar 29, 3:47 PM
emaste added a comment to D10152: Use contemporary C function prototypes with less(1)..

Additional changes LGTM, still line length & register nits.

Wed, Mar 29, 2:17 PM

Tue, Mar 28

emaste committed rS316067: Remove usfs(4) from arm kernel configs.
Remove usfs(4) from arm kernel configs
Tue, Mar 28, 12:57 AM
emaste closed D10153: remove usfs from arm kernel configs by committing rS316067: Remove usfs(4) from arm kernel configs.
Tue, Mar 28, 12:57 AM

Mon, Mar 27

emaste added a reviewer for D10153: remove usfs from arm kernel configs: imp.
Mon, Mar 27, 8:44 PM
emaste created D10153: remove usfs from arm kernel configs.
Mon, Mar 27, 8:43 PM
emaste committed rS316055: makefs: sort roundup with the other off_t members in fsinfo_t.
makefs: sort roundup with the other off_t members in fsinfo_t
Mon, Mar 27, 8:24 PM
emaste accepted D10152: Use contemporary C function prototypes with less(1)..

LGTM with a few nitpicks noted inline

Mon, Mar 27, 6:57 PM
emaste committed rS316029: lld: hack version and help output for compatibility with libtool.
lld: hack version and help output for compatibility with libtool
Mon, Mar 27, 4:01 PM
emaste added inline comments to D7997: makeman: don't copy $FreeBSD$ tags from source files into output.
Mon, Mar 27, 2:00 PM

Wed, Mar 22

emaste updated subscribers of D10104: bsdgrep(1): generally fix matching behavior in one broad sweep.
Wed, Mar 22, 11:34 PM
emaste accepted D10109: bsdgrep(1): Understand rgrep, create rgrep symlink if using bsdgrep.

Interesting, the gnugrep package does not install rgrep, but this change seems sensible regardless of whether we install rgrep or not.

Wed, Mar 22, 11:32 PM

Tue, Mar 21

emaste added a comment to D10085: Explicitly pass ABI flags for MIPS..

Overall LGTM, two minor comments inline.

Tue, Mar 21, 11:07 PM
emaste closed D10084: Fix stable/10's expected EoL date by committing rD50072: Set expected stable/10 branch EoL date.
Tue, Mar 21, 9:26 PM
emaste committed rD50072: Set expected stable/10 branch EoL date.
Set expected stable/10 branch EoL date
Tue, Mar 21, 9:26 PM
emaste added a comment to D10084: Fix stable/10's expected EoL date.

(Note I mean "fix" as in "to set or place definitely", not that the EoL is broken.)

Tue, Mar 21, 8:54 PM
emaste created D10084: Fix stable/10's expected EoL date.
Tue, Mar 21, 8:51 PM
emaste committed rS315685: tighten buffer bounds in imgact_binmisc_populate_interp.
tighten buffer bounds in imgact_binmisc_populate_interp
Tue, Mar 21, 6:02 PM
emaste closed D10042: tighten buffer bounds in imgact_binmisc_populate_interp by committing rS315685: tighten buffer bounds in imgact_binmisc_populate_interp.
Tue, Mar 21, 6:02 PM

Sun, Mar 19

emaste committed rS315522: use INT3 instead of NOP for x86 binary padding.
use INT3 instead of NOP for x86 binary padding
Sun, Mar 19, 12:22 AM
emaste closed D10047: fill x86 padding with INT3 instead of NOP by committing rS315522: use INT3 instead of NOP for x86 binary padding.
Sun, Mar 19, 12:22 AM

Sat, Mar 18

emaste created D10047: fill x86 padding with INT3 instead of NOP.
Sat, Mar 18, 6:25 PM
emaste committed rS315468: libc: add reference to two-way algorithm and bad shift table in memmem/strstr.
libc: add reference to two-way algorithm and bad shift table in memmem/strstr
Sat, Mar 18, 12:53 AM
emaste committed rS315467: libc: Use musl's O(n) memmem and strstr.
libc: Use musl's O(n) memmem and strstr
Sat, Mar 18, 12:51 AM
emaste closed D2601: libc: Use musl's O(n) memmem and strstr by committing rS315467: libc: Use musl's O(n) memmem and strstr.
Sat, Mar 18, 12:51 AM

Fri, Mar 17

emaste updated the summary of D10042: tighten buffer bounds in imgact_binmisc_populate_interp.
Fri, Mar 17, 7:35 PM
emaste created D10042: tighten buffer bounds in imgact_binmisc_populate_interp.
Fri, Mar 17, 7:32 PM
emaste added inline comments to D9030: First attempt at a new fexecve() variant that allows the interpreter to be specified explicitly with a file descriptor..
Fri, Mar 17, 4:06 PM

Thu, Mar 16

emaste accepted D10038: Point out that -F probably does not do what the user expects..

Sounds good to me, having been bitten by exactly this issue. If we knew of a use case for -F we could allude to it (e.g. not the option you are looking for, unless ...), but I'm not sure where one would actually want -F.

Thu, Mar 16, 11:22 PM
emaste added a comment to D7997: makeman: don't copy $FreeBSD$ tags from source files into output.

For reference, the generated output with this change looks like:

.\" DO NOT EDIT-- this file is automatically generated.
.\" $FreeBSD$
.Dd March 16, 2017
.Dt SRC.CONF 5
...
.Pp
This list provides a name and short description for variables
that can be used for source builds.
.Bl -tag -width indent
.It Va WITHOUT_ACCT
Set to not build process accounting tools such as
.Xr accton 8
and
.Xr sa 8 .
.It Va WITHOUT_ACPI
Set to not build
.Xr acpiconf 8 ,
.Xr acpidump 8
and related programs.
...
Thu, Mar 16, 7:37 PM
emaste updated the diff for D7997: makeman: don't copy $FreeBSD$ tags from source files into output.
  • rebase
  • also remove from FreeBSD for makeman itself
Thu, Mar 16, 7:24 PM
emaste added a comment to D7997: makeman: don't copy $FreeBSD$ tags from source files into output.

I only have an SVN checkout for head for makeman handling.

Thu, Mar 16, 7:15 PM

Wed, Mar 15

emaste added inline comments to D8729: lldb: retrieve the whole thread name from the kernel.
Wed, Mar 15, 7:53 PM
emaste committed rS315321: makefs: improve error messages.
makefs: improve error messages
Wed, Mar 15, 6:15 PM
emaste committed rS315317: makefs: don't print pointers in debugging messages.
makefs: don't print pointers in debugging messages
Wed, Mar 15, 5:26 PM
emaste committed rS315311: makefs: use 'm' for cd9660 allow-multidot, per NetBSD.
makefs: use 'm' for cd9660 allow-multidot, per NetBSD
Wed, Mar 15, 4:16 PM
emaste committed rS315304: makefs: sync option parsing with NetBSD.
makefs: sync option parsing with NetBSD
Wed, Mar 15, 1:35 PM

Tue, Mar 14

emaste committed rS315276: makefs: sync -T timestamp with NetBSD.
makefs: sync -T timestamp with NetBSD
Tue, Mar 14, 6:08 PM
emaste committed rS315271: makefs: remove unused variable.
makefs: remove unused variable
Tue, Mar 14, 4:40 PM

Fri, Mar 3

emaste committed rS314603: regen src.conf.5 for clang-4.0.0 merge.
regen src.conf.5 for clang-4.0.0 merge
Fri, Mar 3, 4:08 PM
emaste committed rS314573: MFC r312899: add octeon+ as an alias for octeon in GCC & binutils.
MFC r312899: add octeon+ as an alias for octeon in GCC & binutils
Fri, Mar 3, 12:39 AM

Thu, Mar 2

emaste committed rS314568: kern_sig.c: ANSIfy and remove archaic register keyword.
kern_sig.c: ANSIfy and remove archaic register keyword
Thu, Mar 2, 10:18 PM
emaste committed rS314560: MFC r309649 (oshogbo): tcpdump: allow to use BIOCROTZBUF in capability mode.
MFC r309649 (oshogbo): tcpdump: allow to use BIOCROTZBUF in capability mode
Thu, Mar 2, 5:17 PM
emaste committed rS314537: makefs: remove clause 3 & 4 from Manuel Bouyer license.
makefs: remove clause 3 & 4 from Manuel Bouyer license
Thu, Mar 2, 4:11 AM
emaste committed rS314536: makefs: remove archaic __P prototypes from ufs_bswap.h.
makefs: remove archaic __P prototypes from ufs_bswap.h
Thu, Mar 2, 4:08 AM
emaste added inline comments to D9854: Add cxgbetool(8) to the base system..
Thu, Mar 2, 2:49 AM
emaste committed rS314534: regen src.conf.5 after r313169.
regen src.conf.5 after r313169
Thu, Mar 2, 2:11 AM
emaste committed rS314532: MFC r314139: make vi message catalogues build independent of locale.
MFC r314139: make vi message catalogues build independent of locale
Thu, Mar 2, 1:28 AM

Wed, Mar 1

emaste committed rP435204: sysutils/py-diffoscope: update to version 78.
sysutils/py-diffoscope: update to version 78
Wed, Mar 1, 11:16 PM
emaste requested changes to D5603: ASLR.

Needs to be rebased after conflicts in at least rS314489

Wed, Mar 1, 9:44 PM
emaste committed rS314495: Remove hard line breaks from README.md.
Remove hard line breaks from README.md
Wed, Mar 1, 3:40 PM
emaste added a comment to D9841: Tidy up machine dependent Makefiles in libc..

This LGTM

Wed, Mar 1, 2:27 PM
emaste added a comment to D9655: Add src.conf knob to disable the installation of /var/db/services.db.

I think that there should be a global knob for removing all of these databases.

Wed, Mar 1, 2:21 PM
emaste committed rS314447: MFC r313774: localtime: return NULL if time_t out of range of struct tm.
MFC r313774: localtime: return NULL if time_t out of range of struct tm
Wed, Mar 1, 1:46 AM
emaste committed rS314446: MFC r313774: localtime: return NULL if time_t out of range of struct tm.
MFC r313774: localtime: return NULL if time_t out of range of struct tm
Wed, Mar 1, 1:45 AM

Feb 27 2017

emaste added a comment to D9826: Add 'make showitools' target to report install tool paths.

I'd like to try to do something like

.for prog in ${ITOOLS}
_PROGPATH!=     which ${prog}
.if ${_PROGPATH} != ""
ITOOLS_PROGS+= ${_PROGPATH}
.else
ITOOLS_MISSING_PROGS+= ${prog}
.endif
.endfor

(moving the for-loop from shell to make) but it doesn't work.

Feb 27 2017, 8:26 PM
emaste retitled D9826: Add 'make showitools' target to report install tool paths from to Add 'make showitools' target to report install tool paths.
Feb 27 2017, 3:58 PM

Feb 23 2017

emaste committed rS314139: make vi message catalogues build independent of locale.
make vi message catalogues build independent of locale
Feb 23 2017, 2:40 PM
emaste closed D9765: make vi message catalogues build independent of locale by committing rS314139: make vi message catalogues build independent of locale.
Feb 23 2017, 2:40 PM
emaste retitled D9765: make vi message catalogues build independent of locale from to make vi message catalogues build independent of locale.
Feb 23 2017, 1:41 PM
emaste committed rS314117: makefs: eliminate global cd9660 structure.
makefs: eliminate global cd9660 structure
Feb 23 2017, 2:28 AM
emaste closed D9627: makefs: eliminate global cd9660 structure by committing rS314117: makefs: eliminate global cd9660 structure.
Feb 23 2017, 2:28 AM

Feb 22 2017

emaste committed rP434647: MFH: r433526 r434137 r434189.
MFH: r433526 r434137 r434189
Feb 22 2017, 10:05 PM
emaste accepted D9681: improve ipfw rule creation for blacklist-helper script.

OK

Feb 22 2017, 4:56 PM
emaste added a comment to D8788: Document USB Mass Storage CTL frontend..
In D8788#201022, @trasz wrote:

Thanks. One thing I'm not sure about is the "USB OTG" stuff. "OTG" is not an acronym it itself, I think; "USB OTG" is. As in, the whole stuff.

Feb 22 2017, 3:33 PM
emaste added a comment to D9627: makefs: eliminate global cd9660 structure.

cd9660 tests pass except:

makefs_cd9660_tests:D_flag -> skipped: makefs crashes with SIGBUS with dupe mtree entries; see FreeBSD bug # 192839
makefs_cd9660_tests:o_flag_allow_max_name: expected_failure: -o allow-max-name doesn't appear to be implemented on FreeBSD's copy of makefs [yet]
makefs_cd9660_tests:o_flag_isolevel_1: expected_failure: this testcase needs work; the filenames generated seem incorrect/corrupt
Feb 22 2017, 2:58 AM

Feb 21 2017

emaste committed rS314054: Exclude -flto when building *genassym.o.
Exclude -flto when building *genassym.o
Feb 21 2017, 6:59 PM
emaste closed D9659: Remove -flto when building genassym.o by committing rS314054: Exclude -flto when building *genassym.o.
Feb 21 2017, 6:59 PM
emaste added a comment to D9680: Increase EFI MSDOSFS image size to 512Kib.

Does it still make sense to uuencode binary files like this? SVN can handle binary files just fine.

Feb 21 2017, 3:46 PM
emaste added inline comments to D9407: [MIPS64] [MIPS] Modifications in support of clang enabled builds + IAS.
Feb 21 2017, 2:54 PM

Feb 19 2017

emaste accepted D9303: Capsicumize traceroute.
Feb 19 2017, 8:31 PM
emaste committed rS313955: bsdgrep: document ignored option -u.
bsdgrep: document ignored option -u
Feb 19 2017, 5:40 PM
emaste committed rS313948: bsdgrep: fix EOF handling with --mmap.
bsdgrep: fix EOF handling with --mmap
Feb 19 2017, 5:23 PM

Feb 18 2017

emaste added a comment to D9575: Boot-time Key Intake Metadata.

Is there a command line that works with git diff?

Feb 18 2017, 7:26 PM
emaste retitled D9659: Remove -flto when building genassym.o from to Remove -flto when building genassym.o.
Feb 18 2017, 4:10 AM
emaste updated subscribers of D9649: Enable VNET operations for ifconfig and route.
Feb 18 2017, 1:12 AM · network

Feb 17 2017

emaste added inline comments to D8787: Add USB Mass Storage CTL frontend..
Feb 17 2017, 10:15 PM
emaste added inline comments to D8787: Add USB Mass Storage CTL frontend..
Feb 17 2017, 9:49 PM
emaste added inline comments to D9303: Capsicumize traceroute.
Feb 17 2017, 8:41 PM
emaste updated subscribers of D9655: Add src.conf knob to disable the installation of /var/db/services.db.

I strongly support the ability to make small root filesystems, but I'm a bit worried about ending up with dozens of fiddly WITHOUT_ knobs (even though I'm guilty of adding a few myself).

Feb 17 2017, 8:29 PM
emaste accepted D9532: Fix unaligned access in newfs_nandfs.

I think this is fine, but it feels like a Clang false-positive to me.
(fsdata.f_uuid is at offset 64 in nandfs_fsdata)

Feb 17 2017, 7:50 PM
emaste committed rP434188: Document arbitrary file write in diffoscope < 76.
Document arbitrary file write in diffoscope < 76
Feb 17 2017, 1:20 AM
emaste closed D9598: Document arbitrary file write in diffoscope < 76 by committing rP434188: Document arbitrary file write in diffoscope < 76.
Feb 17 2017, 1:20 AM
emaste committed rS313848: MFC r313563: kldxref: bump MAXSEGS to 3.
MFC r313563: kldxref: bump MAXSEGS to 3
Feb 17 2017, 12:49 AM
emaste committed rS313847: MFC r313562: kldxref: s/sections/segments/ in warning message.
MFC r313562: kldxref: s/sections/segments/ in warning message
Feb 17 2017, 12:48 AM
emaste committed rS313846: MFC r313563: kldxref: bump MAXSEGS to 3.
MFC r313563: kldxref: bump MAXSEGS to 3
Feb 17 2017, 12:46 AM
emaste committed rS313845: MFC r313562: kldxref: s/sections/segments/ in warning message.
MFC r313562: kldxref: s/sections/segments/ in warning message
Feb 17 2017, 12:45 AM

Feb 16 2017

emaste committed rS313787: makefs: use a macro to simplify per-fs function declarations.
makefs: use a macro to simplify per-fs function declarations
Feb 16 2017, 3:13 AM
emaste added inline comments to D9430: Use -Os when compiling all bootloaders, not just some.
Feb 16 2017, 2:22 AM
emaste retitled D9627: makefs: eliminate global cd9660 structure from to makefs: eliminate global cd9660 structure.
Feb 16 2017, 1:51 AM

Feb 15 2017

emaste retitled D9623: prefix (more) UFS symbols with UFS_ to reduce namespace pollution from to prefix (more) UFS symbols with UFS_ to reduce namespace pollution.
Feb 15 2017, 7:54 PM