Page MenuHomeFreeBSD

emaste (Ed Maste)
UserAdministrator

Projects (9)

User Details

User Since
Nov 24 2013, 3:15 AM (273 w, 4 d)
Roles
Administrator

Recent Activity

Tue, Feb 19

emaste added inline comments to D19246: svn: support building as PIE.
Tue, Feb 19, 10:27 PM
emaste updated subscribers of D19147: Reserve next `NT_FREEBSD_FEATURE_CTL` bits.
Tue, Feb 19, 10:15 PM
emaste added a comment to D19188: Make `server_cat(..)` handle short receives.

Approved

Tue, Feb 19, 10:14 PM
emaste added a comment to D19246: svn: support building as PIE.
In D19246#411794, @cem wrote:

Why is the MK_PIE PIE_SUFFIX “_pic”? That seems inconsistent. Otherwise, LGTM.

Tue, Feb 19, 6:02 PM
emaste added a comment to D19072: Fix initial exec TLS mode for dynamically loaded shared objects..

llvm commit in https://reviews.llvm.org/D57821, @dim reasonable to backport in your opinion?

Tue, Feb 19, 5:47 PM
emaste added a comment to D19072: Fix initial exec TLS mode for dynamically loaded shared objects..

llvm commit in https://reviews.llvm.org/D57821, @dim reasonable to backport in your opinion?

Tue, Feb 19, 5:45 PM
emaste added a comment to D18944: freebsd-update: Clarify unclear help text.

Updated to 11.2-RELEASE (now-current version) and e.g. instead of i.e.. e.g. is short for the Latin exempli gratia meaning "for example" while i.e. is id est or "that is".

Tue, Feb 19, 5:41 PM
emaste committed rS344280: freebsd-update: Clarify help text.
freebsd-update: Clarify help text
Tue, Feb 19, 5:38 PM
emaste closed D18944: freebsd-update: Clarify unclear help text.
Tue, Feb 19, 5:38 PM
emaste created D19246: svn: support building as PIE.
Tue, Feb 19, 3:21 PM

Mon, Feb 18

emaste updated subscribers of D19098: Parallel zfs mounting.
Mon, Feb 18, 7:43 PM
emaste committed rS344246: kdump: expand comment on reasons for CAPFAIL_LOOKUP.
kdump: expand comment on reasons for CAPFAIL_LOOKUP
Mon, Feb 18, 3:49 AM

Sun, Feb 17

emaste added a comment to D7343: remove CONSTRUCTORS from kernel linker scripts.
In D7343#152829, @kib wrote:

Do we use or support .ctors or .dtors in the kernel? If not I don't see why we would need to add them.

In principle the answer is yes, we might some day allow the attribute ((constructor)) to work in kernel. E.g. it might occur before the MI sysinit pass. For this reason, I do not see why would it be useful to strip linker script from many features which seems to be unused now.

Sun, Feb 17, 3:22 PM

Sat, Feb 16

emaste committed rS344211: wlandebug: disable PIE to fix build failure.
wlandebug: disable PIE to fix build failure
Sat, Feb 16, 12:50 PM

Fri, Feb 15

emaste committed rS344182: Use make's :tl instead of checking "no" and "NO".
Use make's :tl instead of checking "no" and "NO"
Fri, Feb 15, 10:48 PM
emaste committed rS344181: Fix Makefile conditional after r344179.
Fix Makefile conditional after r344179
Fri, Feb 15, 10:30 PM
emaste committed rS344180: Regen src.conf.5 after r344179.
Regen src.conf.5 after r344179
Fri, Feb 15, 10:28 PM
emaste committed rS344179: Add WITH_PIE knob to build Position Independent Executables.
Add WITH_PIE knob to build Position Independent Executables
Fri, Feb 15, 10:22 PM
emaste closed D18423: Prototype WITH_PIE knob.
Fri, Feb 15, 10:22 PM
emaste updated the diff for D18423: Prototype WITH_PIE knob.

fix bsd.prog.mk

Fri, Feb 15, 3:28 PM
emaste added a comment to D18423: Prototype WITH_PIE knob.
In D18423#410852, @kib wrote:

Do static binaries work ? I suspect they do not, or they work by a chance. Most scary is init(8) of course, but other static binaries esp. rescue(8) are also questionable.

Fri, Feb 15, 3:26 PM
emaste added a comment to D18423: Prototype WITH_PIE knob.

I believe this is ready to commit now (disabled by default); commit message:

Fri, Feb 15, 2:58 PM
emaste added reviewers for D18423: Prototype WITH_PIE knob: gordon, delphij.
Fri, Feb 15, 2:36 PM

Thu, Feb 14

emaste accepted D19194: Make anon clustering more compatible..
Thu, Feb 14, 2:18 PM
emaste updated the diff for D18423: Prototype WITH_PIE knob.

Just turn off PIE for clang and svn (their Makefiles explicitly reference .a archives and need invasive changes to add ${PIE_SUFFIX} - that may come in a later commit but this smaller change is easier to review.

Thu, Feb 14, 2:03 PM
emaste added inline comments to D18423: Prototype WITH_PIE knob.
Thu, Feb 14, 2:01 PM
emaste added a comment to D19194: Make anon clustering more compatible..

Precedent for documenting 0/1/2 options:

kern.geom.eli.visible_passphrase: Visibility of passphrase prompt (0 = invisible, 1 = visible, 2 = asterisk)
kern.vt.splash_cpu_style: Draw logo style (0 = Alternate beastie, 1 = Beastie, 2 = Orb)
vfs.timestamp_precision: File timestamp precision (0: seconds, 1: sec + ns accurate to 1/HZ, 2: sec + ns truncated to us, 3+: sec + ns (max. precision))
vfs.write_behind: Cluster write-behind; 0: disable, 1: enable, 2: backed off
hw.hn.tx_taskq_mode: TX taskqueue modes: 0 - independent, 1 - share global tx taskqs, 2 - share event taskqs
hw.pci.do_power_nodriver: Place a function into D3 state when no driver attaches to it.  0 means disable.  1 means conservatively place devices into D3 state.  2 means aggressively place devices into D3 state.  3 means put absolutely everything in D3 state.
hw.pcic.pd6722_vsense: Select CL-PD6722's VSENSE method.  VSENSE is used to determine the voltage of inserted cards.  The CL-PD6722 has two methods to determine the voltage of the card.  0 means assume a 5.0V card and do not check.  1 means use the same method that the CL-PD6710 uses (default).  2 means use the same method as the CL-PD6729.  2 is documented in the datasheet as being the correct way, but 1 seems to give better results on more laptops.
dev.pcm.#.XXX.vchanmode: vchan format/rate selection: 0=fixed, 1=passthrough, 2=adaptive
dev.uart.0.pps_mode: pulse mode: 0/1/2=disabled/CTS/DCD; add 0x10 to invert, 0x20 for narrow pulse
dev.netmap.admode: Adapter mode. 0 selects the best option available,1 forces native adapter, 2 forces emulated adapter
Thu, Feb 14, 1:55 PM
emaste added a comment to D19194: Make anon clustering more compatible..

LGTM

Thu, Feb 14, 1:51 PM
emaste added inline comments to D19188: Make `server_cat(..)` handle short receives.
Thu, Feb 14, 1:29 AM

Wed, Feb 13

emaste updated subscribers of D18423: Prototype WITH_PIE knob.
Wed, Feb 13, 9:41 PM
emaste updated subscribers of D19183: libkvm: Fix the kvm_walk_pages in amd64.
Wed, Feb 13, 9:28 PM
emaste added inline comments to D18423: Prototype WITH_PIE knob.
Wed, Feb 13, 5:58 PM
emaste updated the diff for D18423: Prototype WITH_PIE knob.

Compile objs with -fpie or -fPIE and use _pie suffix instead of reusing _pic build infrastructure as generated code may be different. (PIE objects do not need to support symbol interposition and thus avoid GOT/PLT use.)

Wed, Feb 13, 5:52 PM
emaste added a comment to D15307: [new driver] dev/hpt37xx: Add Highpoint driver for 3740A/840A cards.

IMO uuencoding objects is an artifact of when we had a less capable VCS; we have binary files in the tree already and so it should be fine to skip the uuencode.

Wed, Feb 13, 2:06 AM
emaste accepted D18622: Import GoogleTest 1.8.1 into the vendor tree under `^/google/googletest/dist`.

Approved

Wed, Feb 13, 2:02 AM
emaste added a comment to D18950: Remove references to pdwait4(2) and `CAP_PDWAIT` from rights(4).

IMO it's fair to remove from the man page now, but I would like feedback from capsicum for the source changes.

Wed, Feb 13, 1:43 AM

Tue, Feb 12

emaste accepted D19154: Bump `__FreeBSD_version__` for r343891.

Approved

Tue, Feb 12, 3:30 AM

Mon, Feb 11

emaste added a comment to D18423: Prototype WITH_PIE knob.

This is suboptimal - consider this test code:

int global_variable;
Mon, Feb 11, 8:11 PM
emaste accepted D19135: Fix compiler flags related to kernel coverage.

OK with me

Mon, Feb 11, 3:06 PM
emaste added inline comments to D19147: Reserve next `NT_FREEBSD_FEATURE_CTL` bits.
Mon, Feb 11, 2:39 PM
emaste created D19147: Reserve next `NT_FREEBSD_FEATURE_CTL` bits.
Mon, Feb 11, 2:36 PM
emaste added a comment to D10487: Bug 218861 - libelf elf_update fails when adding sections.

ping

Mon, Feb 11, 2:29 PM

Sun, Feb 10

emaste added inline comments to D19135: Fix compiler flags related to kernel coverage.
Sun, Feb 10, 2:58 PM

Thu, Feb 7

emaste added a comment to D19095: Teach /etc/rc.d/growfs to handle disks with ZFS.

if you have to reupload for a change please include full context next time

Thu, Feb 7, 2:32 PM
emaste committed rS343869: Mention clang-format in WITH_CLANG_EXTRAS.
Mention clang-format in WITH_CLANG_EXTRAS
Thu, Feb 7, 2:05 PM
emaste updated subscribers of D19096: Fix renameat(2) for CAPABILITIES kernels..
Thu, Feb 7, 4:07 AM

Wed, Feb 6

emaste updated subscribers of D18622: Import GoogleTest 1.8.1 into the vendor tree under `^/google/googletest/dist`.

@imp, @brooks you seem to be possible curators of contrib/; does google/googletest/ seem like the right location? Seems sensible to me.

Wed, Feb 6, 8:52 PM
emaste added a comment to D18641: Clean up all directories created by `make hier`.

Approved

Wed, Feb 6, 8:50 PM
emaste added a reviewer for D18950: Remove references to pdwait4(2) and `CAP_PDWAIT` from rights(4): capsicum.

Not documenting it (as in rS320058) is reasonable, but I'm less sure about removing the bit definition unless we're certain we never intend to implement it.

Wed, Feb 6, 8:48 PM
emaste committed rS343843: riscv: default to non-executable stack.
riscv: default to non-executable stack
Wed, Feb 6, 7:22 PM
emaste committed rS343842: vtfontcvt: whitespace cleanup.
vtfontcvt: whitespace cleanup
Wed, Feb 6, 6:51 PM
emaste committed rS343839: Retire SPX_HACK option unused after r342244.
Retire SPX_HACK option unused after r342244
Wed, Feb 6, 5:21 PM
emaste committed rS343838: Retire CTM option after r342126.
Retire CTM option after r342126
Wed, Feb 6, 4:30 PM

Tue, Feb 5

emaste committed rS343793: UPDATING and newvers entries for 11.2-p9.
UPDATING and newvers entries for 11.2-p9
Tue, Feb 5, 6:22 PM
emaste committed rS343792: UPDATING and newvers entries for 12.0-p3.
UPDATING and newvers entries for 12.0-p3
Tue, Feb 5, 6:20 PM
emaste committed rS343790: MFS12 r343785: Avoid leaking fp references when truncating SCM_RIGHTS.
MFS12 r343785: Avoid leaking fp references when truncating SCM_RIGHTS
Tue, Feb 5, 6:11 PM
emaste committed rS343789: amd64: clear callee-preserved registers on syscall exit.
amd64: clear callee-preserved registers on syscall exit
Tue, Feb 5, 6:07 PM
emaste committed rS343788: MFS12 r343781: amd64: clear callee-preserved registers on syscall exit.
MFS12 r343781: amd64: clear callee-preserved registers on syscall exit
Tue, Feb 5, 6:05 PM
emaste committed rS343787: MFS12 r343454: Fix an LLE lookup race.
MFS12 r343454: Fix an LLE lookup race
Tue, Feb 5, 6:00 PM
emaste committed rS343783: MFS12 r342267: dtrace: fix userspace access on boxes with SMAP.
MFS12 r342267: dtrace: fix userspace access on boxes with SMAP
Tue, Feb 5, 5:54 PM

Mon, Feb 4

emaste added a comment to D19072: Fix initial exec TLS mode for dynamically loaded shared objects..
In D19072#407799, @kib wrote:

Lets discuss it. They did not stated why DF_STATIC_TLS was considered as 'not needed'.

Mon, Feb 4, 9:56 PM
emaste added a comment to D19026: Avoid the DNS lookup for "localhost".

Approved.

Mon, Feb 4, 6:53 PM
emaste added a comment to D18004: pci_host_generic_acpi: use IORT data for MSI/MSI-X.

I think this needs to be rebased too

Mon, Feb 4, 5:33 PM · ARM
emaste updated the diff for D19076: scp: check in scp client that filenames sent during.

Actually resolve getopt conflict

Mon, Feb 4, 4:50 PM
emaste created D19076: scp: check in scp client that filenames sent during.
Mon, Feb 4, 4:45 PM

Sun, Feb 3

emaste added a comment to D19072: Fix initial exec TLS mode for dynamically loaded shared objects..

Should we encourage lld to revive the https://reviews.llvm.org/D33041 patch?

Sun, Feb 3, 10:14 PM

Fri, Feb 1

emaste committed rS343669: readelf: decode FreeBSD note types.
readelf: decode FreeBSD note types
Fri, Feb 1, 10:24 PM
emaste closed D19054: readelf: decode FreeBSD note types.
Fri, Feb 1, 10:24 PM
emaste updated the diff for D19054: readelf: decode FreeBSD note types.

actually check alignment

Fri, Feb 1, 10:00 PM
emaste updated the diff for D19054: readelf: decode FreeBSD note types.

add alignment check

Fri, Feb 1, 9:57 PM
emaste added inline comments to D19053: readelf: use table-based DT_FLAGS and DT_FLAGS_1 decoding.
Fri, Feb 1, 8:30 PM
emaste committed rS343665: readelf: use table-based DT_FLAGS and DT_FLAGS_1 decoding.
readelf: use table-based DT_FLAGS and DT_FLAGS_1 decoding
Fri, Feb 1, 8:28 PM
emaste closed D19053: readelf: use table-based DT_FLAGS and DT_FLAGS_1 decoding.
Fri, Feb 1, 8:28 PM
emaste added inline comments to D19054: readelf: decode FreeBSD note types.
Fri, Feb 1, 8:24 PM
emaste added a child revision for D19053: readelf: use table-based DT_FLAGS and DT_FLAGS_1 decoding: D19054: readelf: decode FreeBSD note types.
Fri, Feb 1, 3:13 PM
emaste added a parent revision for D19054: readelf: decode FreeBSD note types: D19053: readelf: use table-based DT_FLAGS and DT_FLAGS_1 decoding.
Fri, Feb 1, 3:13 PM
emaste created D19054: readelf: decode FreeBSD note types.
Fri, Feb 1, 3:11 PM
emaste created D19053: readelf: use table-based DT_FLAGS and DT_FLAGS_1 decoding.
Fri, Feb 1, 3:09 PM

Thu, Jan 31

emaste added a comment to D19026: Avoid the DNS lookup for "localhost".

I don't object to this patch but shouldn't we be able to prevent any DNS use via nsswitch.conf?

Thu, Jan 31, 6:05 PM
emaste committed rS343614: readelf: dump elf note data.
readelf: dump elf note data
Thu, Jan 31, 5:05 PM
emaste committed rS343613: elfdump: use designated array initialization for note types.
elfdump: use designated array initialization for note types
Thu, Jan 31, 4:49 PM
emaste committed rS343611: elfdump: fix build after r343610.
elfdump: fix build after r343610
Thu, Jan 31, 4:21 PM
emaste committed rS343610: elfdump: include note type names.
elfdump: include note type names
Thu, Jan 31, 4:19 PM
emaste committed rS343609: elfdump: whitespace fixup in advance of other changes.
elfdump: whitespace fixup in advance of other changes
Thu, Jan 31, 4:11 PM
emaste committed rS343608: regen src.conf.5 after r343606.
regen src.conf.5 after r343606
Thu, Jan 31, 3:50 PM
emaste committed rS343606: Enable lld as the system linker by default on i386.
Enable lld as the system linker by default on i386
Thu, Jan 31, 3:07 PM
emaste added inline comments to D5603: ASLR.
Thu, Jan 31, 1:25 AM

Wed, Jan 30

emaste committed rS343593: readelf: fix i386 build.
readelf: fix i386 build
Wed, Jan 30, 9:46 PM
emaste added a reviewer for D5603: ASLR: emaste.
Wed, Jan 30, 9:13 PM
emaste updated subscribers of D18848: readelf(1): Fix readelf -wo to show correct offsets.
Wed, Jan 30, 8:46 PM
emaste updated subscribers of D18843: readelf(1): Speed up readelf -wo.
Wed, Jan 30, 8:46 PM
emaste committed rS343592: readelf: decode flag bits in DT_FLAGS/DT_FLAGS_1.
readelf: decode flag bits in DT_FLAGS/DT_FLAGS_1
Wed, Jan 30, 8:45 PM
emaste added inline comments to D18784: readelf(1): Decode values when DT_FLAGS/DT_FLAGS_1.
Wed, Jan 30, 8:45 PM
emaste closed D18784: readelf(1): Decode values when DT_FLAGS/DT_FLAGS_1.
Wed, Jan 30, 8:45 PM
emaste added inline comments to D5603: ASLR.
Wed, Jan 30, 8:26 PM
emaste removed a reviewer for D5603: ASLR: emaste.
Wed, Jan 30, 8:22 PM
emaste added inline comments to D5603: ASLR.
Wed, Jan 30, 8:11 PM
emaste closed D10482: freebsd-update: regenerate man page database after update.
Wed, Jan 30, 7:19 PM
emaste committed rS343589: freebsd-update: regenerate man page database after update.
freebsd-update: regenerate man page database after update
Wed, Jan 30, 7:19 PM
emaste added a comment to D10487: Bug 218861 - libelf elf_update fails when adding sections.

@eric_metricspace.net ping re @cem's comment

Wed, Jan 30, 7:16 PM