Page MenuHomeFreeBSD

emaste (Ed Maste)
UserAdministrator

Projects (8)

User Details

User Since
Nov 24 2013, 3:15 AM (290 w, 2 d)
Roles
Administrator

Recent Activity

Sun, Jun 16

emaste committed rS349111: vtfontcvt: correct typo in hex parsing update.
vtfontcvt: correct typo in hex parsing update
Sun, Jun 16, 3:14 PM
emaste committed rS349108: vtfontcvt: improve .bdf validation.
vtfontcvt: improve .bdf validation
Sun, Jun 16, 1:52 PM
emaste committed rS349107: vtfontcvt: improve .bdf verification.
vtfontcvt: improve .bdf verification
Sun, Jun 16, 1:35 PM
emaste committed rS349106: allow vt(4) fonts to be built from .bdf files.
allow vt(4) fonts to be built from .bdf files
Sun, Jun 16, 12:44 PM
emaste committed rS349105: vtfontcvt: initialize another variable to quiet GCC warning.
vtfontcvt: initialize another variable to quiet GCC warning
Sun, Jun 16, 12:26 PM
emaste added inline comments to D18880: Extend mmap/mprotect API to specify the max page protections..
Sun, Jun 16, 12:16 PM
emaste added a comment to D18880: Extend mmap/mprotect API to specify the max page protections..
*** Check failed: /root/freebsd/tests/sys/vm/mmap_test.c:107: MAP_ANON with extra PROT flags succeeded
*** Check failed: /root/freebsd/tests/sys/vm/mmap_test.c:107: shm fd with garbage PROT succeeded
Sun, Jun 16, 12:09 PM
emaste added a comment to D18880: Extend mmap/mprotect API to specify the max page protections..

Some straightforward ad-hoc testing looks good.

Sun, Jun 16, 11:50 AM
emaste committed rS349101: vtfontcvt: initialize bbwbytes to avoid GCC 4.2.1 uninitialized warning.
vtfontcvt: initialize bbwbytes to avoid GCC 4.2.1 uninitialized warning
Sun, Jun 16, 10:43 AM
emaste added inline comments to D18880: Extend mmap/mprotect API to specify the max page protections..
Sun, Jun 16, 10:01 AM
emaste committed rS349100: vtfontcvt: improve BDF and hex font parsing.
vtfontcvt: improve BDF and hex font parsing
Sun, Jun 16, 9:17 AM
emaste closed D20650: vtfontcvt: improve BDF and hex font parsing.
Sun, Jun 16, 9:17 AM
emaste added inline comments to D20650: vtfontcvt: improve BDF and hex font parsing.
Sun, Jun 16, 9:02 AM

Sat, Jun 15

emaste added a comment to D18880: Extend mmap/mprotect API to specify the max page protections..

I've imported the update into my testing tree (after encountering the boot failure on the previous version) and it works fine.

Sat, Jun 15, 1:46 PM
emaste updated subscribers of D20654: Add spleen vt(4) fonts.
Sat, Jun 15, 1:36 PM
emaste added a comment to D20654: Add spleen vt(4) fonts.

Spleen fonts from https://www.cambus.net/spleen-monospaced-bitmap-fonts/
Requires vtfontcvt changes from D20650

Sat, Jun 15, 1:36 PM
emaste created D20654: Add spleen vt(4) fonts.
Sat, Jun 15, 1:35 PM
emaste created D20653: Import spleen bitmap fonts to contrib/.
Sat, Jun 15, 1:33 PM
emaste updated the diff for D20650: vtfontcvt: improve BDF and hex font parsing.

Correct typo (; instead of , in variable definition)

Sat, Jun 15, 1:17 PM
emaste added a comment to D20650: vtfontcvt: improve BDF and hex font parsing.

Can use spleen font for testing.

Sat, Jun 15, 12:45 PM
emaste updated subscribers of D20650: vtfontcvt: improve BDF and hex font parsing.
Sat, Jun 15, 12:35 PM
emaste created D20650: vtfontcvt: improve BDF and hex font parsing.
Sat, Jun 15, 12:30 PM
emaste committed rS349053: MFC r348498: libatf: remove workaround not required after atf >= 0.18 update.
MFC r348498: libatf: remove workaround not required after atf >= 0.18 update
Sat, Jun 15, 9:30 AM
emaste committed rS349052: MFC r348498: libatf: remove workaround not required after atf >= 0.18 update.
MFC r348498: libatf: remove workaround not required after atf >= 0.18 update
Sat, Jun 15, 9:29 AM
emaste committed rS349051: MFC r348497: octusb: fix detach loop over USB ports.
MFC r348497: octusb: fix detach loop over USB ports
Sat, Jun 15, 9:27 AM
emaste committed rS349050: MFC r348497: octusb: fix detach loop over USB ports.
MFC r348497: octusb: fix detach loop over USB ports
Sat, Jun 15, 9:25 AM
emaste committed rS349049: vtfontcvt: add comments in add_glyph.
vtfontcvt: add comments in add_glyph
Sat, Jun 15, 9:16 AM
emaste accepted D20644: MFC 348757: nvdimm: Provide nvdimm location information.

It looks like Phabricator will report that there are property changes on the directory but does not show the details - you can confirm that svn diff shows this metadata change:

Sat, Jun 15, 8:36 AM

Wed, Jun 12

emaste added a comment to D18880: Extend mmap/mprotect API to specify the max page protections..

I believe that you should allocate a flag in the feature note and use it to opt-out (or opt-in ?) of max_prot.

Wed, Jun 12, 10:00 PM
emaste added a comment to D20618: [archivers/nulib] PR 21519 - Use dirent.h instead of sys/dir.h.

I think @ota_j.email.ne.jp started working on patches before you removed these ports from the tree.

Wed, Jun 12, 7:55 AM

Sun, Jun 9

emaste added a comment to D20562: The efifat files are no longer used: remove the code to build them..

There's random bits of boot1.efifat lore scattered around, e.g. Google turned up https://ashish.blog/2018/06/freebsd-uefi-boot/ and https://gist.github.com/tehpeh/a5676b711db94f6c1b9af1ec3356a13c. Hopefully a relnotes entry and a mailing-list heads-up is sufficiently discoverable by authors of those sorts of docs.

Sun, Jun 9, 3:43 PM
emaste accepted D20562: The efifat files are no longer used: remove the code to build them..

I approve, this should go.

Sun, Jun 9, 3:39 PM

Sat, Jun 8

emaste committed rS348796: vtfontcvt: allow out-of-order glyphs.
vtfontcvt: allow out-of-order glyphs
Sat, Jun 8, 8:26 AM

Thu, Jun 6

emaste accepted D20533: Add a basic clang-format configuration file.
Thu, Jun 6, 1:20 PM
emaste added a comment to D20533: Add a basic clang-format configuration file.

Perhaps we should put a comment at the beginning of this file explaining that it's not a perfect match for style(9) and providing an example or two of how it can be used?

Thu, Jun 6, 1:16 PM

Wed, Jun 5

emaste committed rS348692: vtfontcvt: exit on error if the input font has too many glyphs.
vtfontcvt: exit on error if the input font has too many glyphs
Wed, Jun 5, 3:24 PM
emaste committed rS348689: Use CLANG knob to remove llvm-symbolizer man page.
Use CLANG knob to remove llvm-symbolizer man page
Wed, Jun 5, 2:08 PM
emaste committed rS348677: move llvm-ar and llvm-nm to appropriate location in OptionalObsoleteFiles.inc.
move llvm-ar and llvm-nm to appropriate location in OptionalObsoleteFiles.inc
Wed, Jun 5, 12:55 AM

Tue, Jun 4

emaste committed rS348668: vtfontcvt: zero memory allocated by xmalloc.
vtfontcvt: zero memory allocated by xmalloc
Tue, Jun 4, 7:39 PM
emaste committed rS348662: vtfontcvt: include width and height in verbose info.
vtfontcvt: include width and height in verbose info
Tue, Jun 4, 6:55 PM
emaste committed rS348661: vtfontcvt: rework height/width setting.
vtfontcvt: rework height/width setting
Tue, Jun 4, 6:50 PM
emaste committed rS348656: vtfontcvt: unwrap a line per style(9).
vtfontcvt: unwrap a line per style(9)
Tue, Jun 4, 6:32 PM
emaste committed rS348653: vtfontcvt: use VFNT_MAP_{NORMAL|BOL}_RH symbolic constants.
vtfontcvt: use VFNT_MAP_{NORMAL|BOL}_RH symbolic constants
Tue, Jun 4, 6:26 PM
emaste accepted D20473: strip: Use libelftc_string_table to manage the section string table..
Tue, Jun 4, 6:17 PM
emaste committed rS348651: MFC r348059: vt efifb: add suspend/resume calls.
MFC r348059: vt efifb: add suspend/resume calls
Tue, Jun 4, 6:11 PM
emaste added a comment to D20347: efirt: Add efi_memory_attribute.

Tested on X86? I had an earlier version of this in my WIP tree for testing on eMAG/ThunderX2 (where it worked) but encountered a panic on x86. I do have some other WIP in that tree though.

Tue, Jun 4, 5:43 PM
emaste accepted D20443: libelf: Use a red-black tree to manage sections.
Tue, Jun 4, 3:57 PM
emaste updated the diff for D20516: readelf: decode NT_GNU_PROPERTY_TYPE_0 / GNU_PROPERTY_X86_FEATURE_1_AND.

Address issues reported by markj

Tue, Jun 4, 3:57 PM
emaste added a comment to D20473: strip: Use libelftc_string_table to manage the section string table..

The previous implementation does suffix matching, which libelftc does not. However, I think this is fine; in general it is unlikely that one section's name is a suffix of another. For .strtab we'd want to do suffix matching.

Tue, Jun 4, 3:53 PM
emaste accepted D20471: strip: Use a lookup instead of a linear search through sections..

By inspection existing elf_getscn mirrors the logic of the existing while loop here

Tue, Jun 4, 3:50 PM
emaste added a comment to D20443: libelf: Use a red-black tree to manage sections.

sys/tree.h works on all supported operating systems? (for upstreaming)

Tue, Jun 4, 3:50 PM
emaste updated subscribers of D20443: libelf: Use a red-black tree to manage sections.
Tue, Jun 4, 3:47 PM
emaste closed D20515: elf_common: add GNU note types and NT_GNU_PROPERTY_TYPE_0 bits.

Committed as rS348628, forgot review tag.

Tue, Jun 4, 3:45 PM
emaste committed rS348628: elf_common: add GNU note types and NT_GNU_PROPERTY_TYPE_0 bits.
elf_common: add GNU note types and NT_GNU_PROPERTY_TYPE_0 bits
Tue, Jun 4, 3:44 PM
emaste created D20516: readelf: decode NT_GNU_PROPERTY_TYPE_0 / GNU_PROPERTY_X86_FEATURE_1_AND.
Tue, Jun 4, 3:37 PM
emaste created D20515: elf_common: add GNU note types and NT_GNU_PROPERTY_TYPE_0 bits.
Tue, Jun 4, 3:33 PM
emaste committed rS348612: style(9) / tidying for r348611.
style(9) / tidying for r348611
Tue, Jun 4, 1:45 PM
emaste added a comment to D20508: Use parse_integer to avoid sign extension..

LGTM

Tue, Jun 4, 1:28 PM
emaste added a comment to D20511: Expose build-ID through `uname -b`.

Submitted by: @ali_mashtizadeh.com
Relnotes: Yes
Event: Waterloo Hackathon 2019

Tue, Jun 4, 1:13 PM
emaste created D20511: Expose build-ID through `uname -b`.
Tue, Jun 4, 1:12 PM
emaste committed rS348611: Expose the kernel's build-ID through sysctl.
Expose the kernel's build-ID through sysctl
Tue, Jun 4, 1:07 PM
emaste closed D20326: Expose the buildid hash through sysctl.
Tue, Jun 4, 1:07 PM
emaste added a comment to D20326: Expose the buildid hash through sysctl.

I will commit the uname changes separately

Tue, Jun 4, 1:07 PM
emaste committed rS348610: build llvm-ar and llvm-nm with Clang (promote out of CLANG_EXTRAS).
build llvm-ar and llvm-nm with Clang (promote out of CLANG_EXTRAS)
Tue, Jun 4, 1:01 PM
emaste committed rS348609: Makefile.inc1: clean up stale dependency hacks.
Makefile.inc1: clean up stale dependency hacks
Tue, Jun 4, 12:56 PM

Sat, Jun 1

emaste committed rS348498: libatf: remove workaround not required after atf >= 0.18 update.
libatf: remove workaround not required after atf >= 0.18 update
Sat, Jun 1, 6:26 PM
emaste committed rS348497: octusb: fix detach loop over USB ports.
octusb: fix detach loop over USB ports
Sat, Jun 1, 6:19 PM
emaste accepted D20484: llvm-symbolizer: Move out of CLANG_EXTRAS, into CLANG.
Sat, Jun 1, 4:27 PM

Fri, May 31

emaste added a comment to D20480: Defer evaluation of modified until after it's set.

No objection but I'm generally not a fan of the deferred evaluation; what about just setting include_metadata=yes/no/if-modified and making the test something like
if [${include_metadata} = yes || (${include_metadata} = if-modified && ${modified} = yes)]

Fri, May 31, 4:59 PM
emaste updated subscribers of D19849: Reorg newvers.sh to eliminate VARS_ONLY and do things more directly.
Fri, May 31, 1:56 PM
emaste committed rS348456: newvers.sh correct typo from r348175.
newvers.sh correct typo from r348175
Fri, May 31, 1:54 PM
emaste added a comment to D20479: Delete sys/dir.h which was deprecated since 1997..

What do you mean by "an exp-run?" I had made buildworld and buildkernel successful on i386. Universe will be better but I don't have enough disk space.
Original PR suggest visit and fix all of ports. It's been over 20 years since taken out of POSIX mentioned PR, I hope most of ports are sys/dir.h clean.

Fri, May 31, 2:44 AM
emaste added a comment to D20479: Delete sys/dir.h which was deprecated since 1997..

Should request an exp-run for completeness sake.

Fri, May 31, 1:45 AM

Thu, May 30

emaste added a comment to D20475: readelf: Make -t imply -S, for compatibility with GNU binutils..

presumably you want to compare readelf -t too :)

Thu, May 30, 6:41 PM
emaste added a comment to D20475: readelf: Make -t imply -S, for compatibility with GNU binutils..

elftoolchain readelf and binutils readelf produce identical formating for readelf -St /lib/libc.so.7.

presumably you want to compare readelf -t too :)

Thu, May 30, 6:41 PM
emaste accepted D20475: readelf: Make -t imply -S, for compatibility with GNU binutils..
Thu, May 30, 6:39 PM
emaste accepted D20472: libelftc: Minor cleanups..
Thu, May 30, 6:16 PM
emaste accepted D20474: libelftc: Add man page mlinks..
Thu, May 30, 6:15 PM
emaste updated subscribers of D20462: newvers: append commit count to uname version string.
Thu, May 30, 1:58 PM

Wed, May 29

emaste updated subscribers of D20462: newvers: append commit count to uname version string.

In a fork based on our svn2git mirror (i.e., based on https://github.com/freebsd/freebsd master branch) this will produce a version number like: r348309+937a4a817304-c260384(wipbsd.20190326)-dirty. We'd generate e.g. r348309=937a4a817304-c360384(test) in a git svn-based fork.

Wed, May 29, 1:57 PM
emaste created D20462: newvers: append commit count to uname version string.
Wed, May 29, 1:49 PM
emaste accepted D20430: posixshmcontrol(1) page.

Ok, LGTM; I'm not an expert on man page markup but can be adjusted after commit if needed.

Wed, May 29, 12:57 PM
emaste added a comment to D20448: style.9: Codify tolerance for eliding blank lines.

The very first version had:

f3()
{
					/* Empty line if no variables. */
	return (1);
}
Wed, May 29, 12:07 AM

Tue, May 28

emaste added inline comments to D20448: style.9: Codify tolerance for eliding blank lines.
Tue, May 28, 7:19 PM
emaste accepted D20444: strip: Optimize for insertions at the tail of the section list..

LGTM

Tue, May 28, 4:48 PM
emaste accepted D20445: strip: Remove unneeded memset..
Tue, May 28, 4:40 PM
emaste committed rS348325: MFC r348069: bootpd: avoid the same error indication for different issues.
MFC r348069: bootpd: avoid the same error indication for different issues
Tue, May 28, 1:15 PM

Mon, May 27

emaste added inline comments to D20430: posixshmcontrol(1) page.
Mon, May 27, 6:14 PM
emaste accepted D20418: arm64 gicv3_its: Fix a typo.
Mon, May 27, 2:33 PM
emaste accepted D20405: kldxref(8): Sort MDT_MODULE info first in linker.hints output.

LGTM

Mon, May 27, 1:57 PM
emaste accepted D20367: Add missing powerpc64 relocation support to libdwarf.
Mon, May 27, 12:04 PM · PowerPC

Fri, May 24

emaste added a comment to D18832: NTB Perf: Tool to measure performance of NTB hw drivers.

Can you provide a link to the original source file, and make a second review (or link to a diff) that shows the delta between upstream and your ported version?

Fri, May 24, 9:05 PM
emaste committed rS348239: nanobsd: exclude .git (and .hg) in the same places we exclude .svn.
nanobsd: exclude .git (and .hg) in the same places we exclude .svn
Fri, May 24, 3:21 PM
emaste committed rS348237: MFC r346598: Enable Mellanox drivers (modules) on AArch64.
MFC r346598: Enable Mellanox drivers (modules) on AArch64
Fri, May 24, 1:40 PM

Thu, May 23

emaste added inline comments to D20378: [PowerPC64] LLVM is now the default toolchain for PowerPC64 target binutils BFD linker is kept for compiling 32 bit binaries such as LIB32 and stand/slof.
Thu, May 23, 6:31 PM
emaste added a comment to D20383: [PowerPC64] starting from FreeBSD 13.0, default 64-bit ELF ABI is V2 (ELFv2).

Of course this will need to go upstream as well.

Thu, May 23, 4:36 PM
emaste added a comment to D20357: Use ACPI SPCR on x86.

please just commit with the baudrate 0 comment preserved

Thu, May 23, 4:22 PM
emaste added a comment to D20337: [PowerPC64] backport of LLVM fixes in preparation for building FreeBSD/PowerPC64.

Do we currently have changes relative to upstream in any of the files affected by this review? (Knowing there are none, or what they are, may be useful in the future when we import 9.0.)

Thu, May 23, 2:59 PM
emaste added a comment to D20378: [PowerPC64] LLVM is now the default toolchain for PowerPC64 target binutils BFD linker is kept for compiling 32 bit binaries such as LIB32 and stand/slof.

All known outstanding issues are recorded as parents of this review?

Thu, May 23, 2:55 PM
emaste added a comment to D20367: Add missing powerpc64 relocation support to libdwarf.

LGTM although I am curious how _dwarf_get_reloc_type actually gets used?

Thu, May 23, 1:14 AM · PowerPC