Page MenuHomeFreeBSD

emaste (Ed Maste)
UserAdministrator

Projects (9)

User Details

User Since
Nov 24 2013, 3:15 AM (325 w, 3 d)
Roles
Administrator

Recent Activity

Today

emaste committed rS358120: Cirrus-CI: increase timeout to 120m.
Cirrus-CI: increase timeout to 120m
Wed, Feb 19, 3:57 PM
emaste committed rS358111: whereis: remove gnu/libexec from source search paths.
whereis: remove gnu/libexec from source search paths
Wed, Feb 19, 2:41 PM
emaste committed rS358105: nanobsd: add WITHOUT_LLVM_COV, akin to WITHOUT_GCOV.
nanobsd: add WITHOUT_LLVM_COV, akin to WITHOUT_GCOV
Wed, Feb 19, 2:26 PM
emaste committed rS358102: src.conf.5: regen after r358101, WITHOUT_GCOV default.
src.conf.5: regen after r358101, WITHOUT_GCOV default
Wed, Feb 19, 2:17 PM
emaste committed rS358101: Move GCOV option to default NO.
Move GCOV option to default NO
Wed, Feb 19, 2:13 PM

Yesterday

emaste updated subscribers of D23744: Added casper service to logger.
Tue, Feb 18, 10:25 PM
emaste updated subscribers of D23745: add binutils build-dep for i386 ports needing `as`.
Tue, Feb 18, 7:31 PM
emaste created D23745: add binutils build-dep for i386 ports needing `as`.
Tue, Feb 18, 7:28 PM
emaste added inline comments to D23744: Added casper service to logger.
Tue, Feb 18, 7:01 PM
emaste committed rS358072: remove old perl entries from ObsoleteFiles.inc.
remove old perl entries from ObsoleteFiles.inc
Tue, Feb 18, 4:38 PM
emaste updated subscribers of D23626: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N).
Tue, Feb 18, 2:59 PM
emaste updated subscribers of D23739: libfetch: add support for keep-alive.
Tue, Feb 18, 2:37 PM

Fri, Feb 14

emaste added a reviewer for D23658: More sparc64 removal bits: dim.

Overall LGTM with a few trivial nits

Fri, Feb 14, 11:56 PM
emaste added a comment to D23641: Fix indentation in bsdinstall-created wpa_supplicant.conf.

If you have a preferred fix please commandeer this revision and update the new patch.

Fri, Feb 14, 11:24 PM
emaste committed rS357939: Update version in openssh FREEBSD-vendor metadata.
Update version in openssh FREEBSD-vendor metadata
Fri, Feb 14, 10:32 PM
emaste committed rS357934: Tag OpenSSH 8.0p1..
Tag OpenSSH 8.0p1.
Fri, Feb 14, 7:48 PM
emaste committed rS357933: Vendor import of OpenSSH 8.0p1..
Vendor import of OpenSSH 8.0p1.
Fri, Feb 14, 7:47 PM
emaste committed rS357932: Update OpenSSH upgrade instructions to use https, not ftp.
Update OpenSSH upgrade instructions to use https, not ftp
Fri, Feb 14, 7:34 PM
emaste committed rS357926: Upgrade to OpenSSH 7.9p1..
Upgrade to OpenSSH 7.9p1.
Fri, Feb 14, 7:07 PM
emaste committed rS357925: sshd: add upgrade process note about TCP wrappers.
sshd: add upgrade process note about TCP wrappers
Fri, Feb 14, 7:00 PM
emaste committed rS357922: openssh: add a note about libwrap in config.h.
openssh: add a note about libwrap in config.h
Fri, Feb 14, 5:05 PM

Thu, Feb 13

emaste added inline comments to D23658: More sparc64 removal bits.
Thu, Feb 13, 4:54 PM
emaste updated subscribers of D23662: dtc: remove unknown option printf, since getopt will print it.

Oh I was wondering if there was an upstream!

Thu, Feb 13, 4:40 PM
emaste added a comment to D23662: dtc: remove unknown option printf, since getopt will print it.

change should also go here: https://github.com/davidchisnall/dtc

Thu, Feb 13, 4:19 PM
emaste committed rS357862: addr2line: use stdbool.h header for bool.
addr2line: use stdbool.h header for bool
Thu, Feb 13, 4:17 PM

Wed, Feb 12

emaste added inline comments to D23648: style.9: update C99 commentary.
Wed, Feb 12, 10:17 PM
emaste committed rS357844: addr2line: Handle DW_AT_ranges in compile units.
addr2line: Handle DW_AT_ranges in compile units
Wed, Feb 12, 9:52 PM
emaste closed D23501: Added ranges to Addr2line.
Wed, Feb 12, 9:52 PM
emaste accepted D23571: Fixed bug where elfcopy --add-section needs to be called twice for section to be created.

Thank you for the investigation and patch. I commented on a few minor items, I will update them before committing to svn (i.e., no need to reupload).

Wed, Feb 12, 8:21 PM
emaste added a comment to D23652: Handle non-plt IRELATIVE relocations..

Overall seems reasonable

Wed, Feb 12, 8:14 PM
emaste committed rS357839: regen sysent after r357831, r357838.
regen sysent after r357831, r357838
Wed, Feb 12, 7:05 PM
emaste committed rS357838: Allow getloginclass in capability mode.
Allow getloginclass in capability mode
Wed, Feb 12, 6:59 PM
emaste committed rS357833: Tag pjdfstest symlink with pkgbase package.
Tag pjdfstest symlink with pkgbase package
Wed, Feb 12, 5:37 PM
emaste committed rS357832: tag /etc/rmt symlink with pkgbase package.
tag /etc/rmt symlink with pkgbase package
Wed, Feb 12, 5:30 PM
emaste committed rS357831: Allow fdatasync in capability mode.
Allow fdatasync in capability mode
Wed, Feb 12, 5:12 PM
emaste added a comment to D23504: Fixed bug where elf header field osabi is not set by objcopy.

committed to FreeBSD, will upstream soon

Wed, Feb 12, 4:00 PM
emaste committed rS357826: elfcopy: set ELF OS/ABI field when converting from binary.
elfcopy: set ELF OS/ABI field when converting from binary
Wed, Feb 12, 4:00 PM
emaste closed D23504: Fixed bug where elf header field osabi is not set by objcopy.
Wed, Feb 12, 4:00 PM
emaste created D23648: style.9: update C99 commentary.
Wed, Feb 12, 2:36 PM

Tue, Feb 11

emaste created D23641: Fix indentation in bsdinstall-created wpa_supplicant.conf.
Tue, Feb 11, 10:08 PM
emaste abandoned D23607: retire `WITH_PORT_BASE_GCC`.
Tue, Feb 11, 5:41 PM
emaste added a comment to D23607: retire `WITH_PORT_BASE_GCC`.

Ok, please review my proposed ObsoleteFiles.inc/OptionalObsoleteFiles.inc changes in D23124

Tue, Feb 11, 5:40 PM
emaste updated the diff for D23124: 2020-02-29 rm GCC 4.2.1 build infrastructure.

update ObsoleteFiles.inc and OptionalObsoleteFiles.inc

Tue, Feb 11, 5:40 PM

Mon, Feb 10

emaste created D23607: retire `WITH_PORT_BASE_GCC`.
Mon, Feb 10, 6:04 PM

Fri, Feb 7

emaste added inline comments to D23555: acpi_hpet: Add Hygon Dhyana support.
Fri, Feb 7, 9:44 PM
emaste added a comment to D23124: 2020-02-29 rm GCC 4.2.1 build infrastructure.

Tracking PR: PR228919

Fri, Feb 7, 9:20 PM
emaste added reviewers for D23571: Fixed bug where elfcopy --add-section needs to be called twice for section to be created: markj, kaiw, jkoshy_users.sourceforge.net.
Fri, Feb 7, 9:09 PM
emaste added a comment to D23453: Correct some typos in sourcesfiles.

rS357664

Fri, Feb 7, 8:51 PM
emaste committed rS357664: Miscellaneous typo fixes.
Miscellaneous typo fixes
Fri, Feb 7, 7:53 PM
emaste added a comment to D23453: Correct some typos in sourcesfiles.

The secure/ and stand/ ones have an upstream or at least other copies around and I'll exclude them initially, but will commit the rest shortly.

Fri, Feb 7, 7:53 PM
emaste added a comment to D23350: Added Single Entry Cache to addr2line.

Tree-based cache added in rS357450 instead

Fri, Feb 7, 7:16 PM
emaste added a comment to D23556: ahci: Add Hygon Dhyana support.

please upload with context and presumably the new entry should be sorted in alpha oder

Fri, Feb 7, 4:20 PM
emaste added inline comments to D23555: acpi_hpet: Add Hygon Dhyana support.
Fri, Feb 7, 4:19 PM
emaste added a comment to D23553: vmm: Add Hygon Dhyana support.

I agree with @grehan, vmm_is_svm is preferable rather than changing all cases to vmm_is_amd || vmm_is_hygon

Fri, Feb 7, 4:18 PM
emaste added a comment to D23564: usb: Add vendor Hygon.

for future updates please include context - see https://wiki.freebsd.org/Phabricator for info
e.g. one of

git diff -U999999 other-branch > change.diff
git show -U999999 <commit-hash> > change.diff
svn diff --diff-cmd=diff -x -U999999 > change.diff
Fri, Feb 7, 4:14 PM
emaste updated subscribers of D23501: Added ranges to Addr2line.
Fri, Feb 7, 2:31 PM
emaste added reviewers for D23504: Fixed bug where elf header field osabi is not set by objcopy: markj, jkoshy_users.sourceforge.net, kaiw.
Fri, Feb 7, 2:30 PM

Thu, Feb 6

emaste added inline comments to D23531: replace strncpy with memcpy when copying full string.
Thu, Feb 6, 6:50 PM
emaste added a comment to D23531: replace strncpy with memcpy when copying full string.

pe.c: In function 'create_pe':
pe.c:177:3: error: 'strncpy' specified bound 8 equals destination size [-Werror=stringop-truncation]

strncpy(psh.sh_name, name, sizeof(psh.sh_name));
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Thu, Feb 6, 5:49 PM
emaste accepted D23526: Mark elf2aout as deprecated..
Thu, Feb 6, 4:46 PM
emaste added inline comments to D23540: Update Platform support information.
Thu, Feb 6, 3:30 PM
emaste added a comment to D23531: replace strncpy with memcpy when copying full string.

And note there is still one error after this change:

cc -O2 -Wno-error -DWITH_PE=1 -I. -I/tmp/cirrus-ci-build/elfcopy -I/tmp/cirrus-ci-build/elfcopy/../common -I/tmp/cirrus-ci-build/elfcopy/../libelf -I/tmp/cirrus-ci-build/elfcopy/../libelftc -I/tmp/cirrus-ci-build/elfcopy/../libpe  -Wall -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wno-uninitialized -Wreturn-type -Wcast-qual -Wpointer-arith -Wwrite-strings -Wswitch -Wshadow -Werror   -c pe.c
pe.c: In function 'create_pe':
pe.c:177:3: error: 'strncpy' specified bound 8 equals destination size [-Werror=stringop-truncation]
   strncpy(psh.sh_name, name, sizeof(psh.sh_name));
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
*** Error code 1
Thu, Feb 6, 2:47 PM
emaste added a comment to D23531: replace strncpy with memcpy when copying full string.

Using memcpy avoids the warning and makes use of the already-calculated strlen, and I'm inclined to commit this as a first step. That said, I'd like to replace all of these with a better idiom.

Thu, Feb 6, 2:39 PM
emaste accepted D23527: Remove elf2aout.
Thu, Feb 6, 2:28 PM
emaste accepted D23525: No need to have a special sparc64 list here..
Thu, Feb 6, 2:27 PM
emaste accepted D23524: No need to make sunlabel anymore.
Thu, Feb 6, 2:27 PM
emaste accepted D23526: Mark elf2aout as deprecated..
Thu, Feb 6, 2:26 PM
emaste added inline comments to D23526: Mark elf2aout as deprecated..
Thu, Feb 6, 2:26 PM
emaste committed rS357618: src.conf.5: regen after r357617, BINUTILS_BOOTSTRAP description update.
src.conf.5: regen after r357617, BINUTILS_BOOTSTRAP description update
Thu, Feb 6, 2:19 PM
emaste committed rS357617: Update WITH_/WITHOUT_BINUTILS_BOOTSTRAP descriptions.
Update WITH_/WITHOUT_BINUTILS_BOOTSTRAP descriptions
Thu, Feb 6, 2:13 PM
emaste created D23531: replace strncpy with memcpy when copying full string.
Thu, Feb 6, 2:00 AM
emaste added inline comments to D23124: 2020-02-29 rm GCC 4.2.1 build infrastructure.
Thu, Feb 6, 12:22 AM

Wed, Feb 5

emaste accepted D23523: Restore missing comment.
Wed, Feb 5, 11:54 PM
emaste added a comment to D23527: Remove elf2aout.

OK with me, with usr.bin/Makefile update

Wed, Feb 5, 11:52 PM
emaste added a comment to D23124: 2020-02-29 rm GCC 4.2.1 build infrastructure.

Wed, Feb 5, 9:28 PM
emaste added inline comments to D23124: 2020-02-29 rm GCC 4.2.1 build infrastructure.
Wed, Feb 5, 8:41 PM
emaste added a comment to D10335: VirtFS/9p filesystem passthrough support (virtio-9p).
In D10335#516241, @jhb wrote:

I think it would be good to first import lib9p into the vendor/ space and then contrib/

Wed, Feb 5, 8:38 PM
emaste committed rS357592: libssp_nonshared: use only on i386 and ppc.
libssp_nonshared: use only on i386 and ppc
Wed, Feb 5, 8:08 PM
emaste added inline comments to D23453: Correct some typos in sourcesfiles.
Wed, Feb 5, 7:18 PM
emaste committed rS357589: delete empty directories after r357455.
delete empty directories after r357455
Wed, Feb 5, 7:18 PM
emaste committed rS357588: beri: correct kernel printf typo.
beri: correct kernel printf typo
Wed, Feb 5, 7:15 PM
emaste committed rS357582: MFC r357212: libfetch: fix urldecode buffer overrun.
MFC r357212: libfetch: fix urldecode buffer overrun
Wed, Feb 5, 6:27 PM
emaste committed rS357581: MFC r354399: blacklist: update to NetBSD snapshot on 20191106.
MFC r354399: blacklist: update to NetBSD snapshot on 20191106
Wed, Feb 5, 6:24 PM
emaste committed rS357579: libfetch: disallow invalid escape sequences.
libfetch: disallow invalid escape sequences
Wed, Feb 5, 4:55 PM
emaste committed rS357578: regen linuxulator sysent after r357577.
regen linuxulator sysent after r357577
Wed, Feb 5, 4:54 PM
emaste committed rS357577: linuxulator: implement sendfile.
linuxulator: implement sendfile
Wed, Feb 5, 4:53 PM
emaste closed D19917: Implement linux_sendfile for the linuxulator.
Wed, Feb 5, 4:53 PM
emaste updated the diff for D23124: 2020-02-29 rm GCC 4.2.1 build infrastructure.
  • rebase
  • remove gperf remnants
  • remove cc_tools leftovers from Makefile.inc1
-       # Clean out improper TARGET=MACHINE files
-       ${_+_}cd ${.CURDIR}/gnu/usr.bin/cc/cc_tools; ${NXBTMAKE} cleandir
Wed, Feb 5, 3:03 PM

Tue, Feb 4

emaste added a comment to D23501: Added ranges to Addr2line.

Can you add a link to the PR/patch submission in here?

Tue, Feb 4, 3:55 PM
emaste updated subscribers of D23383: Update contrib/subversion to the latest LTS version (1.10.6).
Tue, Feb 4, 3:16 PM
emaste updated subscribers of D23499: Add AUTO_VAR_INIT to ensure the stack it initialised.
Tue, Feb 4, 2:55 PM

Mon, Feb 3

emaste added a comment to D23489: Ping patches (2 of 4).

Also can you add a proposed commit message - it will be something like:

Mon, Feb 3, 9:14 PM
emaste added a comment to D23491: Ping patches (4 of 4).

This is a change you'd keep locally while testing, it won't be committed upstream. (You can "abandon" it in Phabricator.)

Mon, Feb 3, 9:07 PM
emaste added a comment to D23488: Ping patches (1 of 4).

Please include context with the change - see https://wiki.freebsd.org/Phabricator

Mon, Feb 3, 8:38 PM
emaste added a comment to D23479: namei: preserve errors from fget_cap_locked.

I would do it differently

Mon, Feb 3, 7:05 PM
emaste added inline comments to D23479: namei: preserve errors from fget_cap_locked.
Mon, Feb 3, 6:11 PM
emaste added a comment to D23335: retire rmt(8), the remote magtape protocol module.

when dump/restore are invoked with the leading r they change behavior and speak "rmt". Yes, there is probably much documentaiton missing.

Mon, Feb 3, 5:07 PM
emaste added a comment to D23335: retire rmt(8), the remote magtape protocol module.

You need r{dump,restore} to talk rmt protocol to a remote tape drive, you can not just pipe over ssh to a remote tape drive.

Mon, Feb 3, 4:39 PM
emaste added a comment to D23335: retire rmt(8), the remote magtape protocol module.

rmt, rdump, rrestore all support something other than rsh(1) as a transport mechanism, ie ssh

Mon, Feb 3, 4:09 PM
emaste added a comment to D23335: retire rmt(8), the remote magtape protocol module.

How are the symlinks /etc/termcap, /etc/unbound, and /etc/aliases handled by pkgbase? You certainly can't go removing those.

Mon, Feb 3, 3:41 PM