emaste (Ed Maste)Administrator
User

Projects (9)

User Details

User Since
Nov 24 2013, 3:15 AM (238 w, 4 d)
Roles
Administrator

Recent Activity

Today

emaste added inline comments to D15858: Fix output of linprocfs stat entry.
Thu, Jun 21, 9:23 PM
emaste accepted D15952: Fix the Linux kernel version number calculation.

I'm fine with either check (<= 0 or @cem's version) with the same change applied to linux32_sysvec.c

Thu, Jun 21, 8:45 PM
emaste added inline comments to D15952: Fix the Linux kernel version number calculation.
Thu, Jun 21, 8:18 PM
emaste added inline comments to D15952: Fix the Linux kernel version number calculation.
Thu, Jun 21, 8:07 PM
emaste added a comment to D15952: Fix the Linux kernel version number calculation.

I'm only finding two copies: sys/i386/linux/linux_sysvec.c and sys/amd64/linux/linux_sysvec.c but have updated the patch to fix those copies.

Thu, Jun 21, 8:02 PM
emaste accepted D15952: Fix the Linux kernel version number calculation.

We will also need to address the four copies of linux_trans_osrel (but after further investigation if desired, I have not checked exactly how the value they calculate is used).

Thu, Jun 21, 7:00 PM
emaste added a comment to D15952: Fix the Linux kernel version number calculation.
In D15952#337697, @cem wrote:

Right, I suggested using LINUX_KERNVER() to do this in my initial comment :-).

Thu, Jun 21, 6:42 PM
emaste added a comment to D15952: Fix the Linux kernel version number calculation.

Ah, top level Linux Makefile emits a definition of KERNEL_VERSION using shifts.

Thu, Jun 21, 6:38 PM
emaste added a comment to D15952: Fix the Linux kernel version number calculation.

Ah, I see the comment in the bug now - yes, if Linux uses shifts we should too. It would be good to put a reference in the commit that mentions the Linux macro/etc. that calculates it though.

Thu, Jun 21, 6:31 PM
emaste added a comment to D15952: Fix the Linux kernel version number calculation.
In D15952#337607, @cem wrote:

Ed, can you explain it in a little more detail?

Thu, Jun 21, 6:26 PM
emaste added a comment to D15858: Fix output of linprocfs stat entry.

See linux_map_osrel

This probably fits better with the existing code, and I'm inclined to move that direction. Is using linux_kernver() the way to access this value?

Thu, Jun 21, 2:53 PM
emaste committed rS335482: Rename usr.bin/elfcopy to usr.bin/objcopy.
Rename usr.bin/elfcopy to usr.bin/objcopy
Thu, Jun 21, 2:28 PM
emaste committed rS335464: Makefile.inc1: rename build metadata file to toolchain-metadata.mk.
Makefile.inc1: rename build metadata file to toolchain-metadata.mk
Thu, Jun 21, 2:16 AM

Yesterday

emaste added a comment to D15931: Add LPIT parsing to acpidump.

I'm still getting the handle of the process here. In my local repo, these are two separate git commits, are you saying the correct way to do this would have been two separate arc diff commands for each of my git commits?

Wed, Jun 20, 8:00 PM
emaste added a comment to D15931: Add LPIT parsing to acpidump.

I took care of the NFIT man page addition in rS335459 - it was my fault :)

Wed, Jun 20, 7:41 PM
emaste committed rS335459: acpidump.8: include NFIT in the man page list of tables.
acpidump.8: include NFIT in the man page list of tables
Wed, Jun 20, 7:41 PM
emaste updated subscribers of D15931: Add LPIT parsing to acpidump.
Wed, Jun 20, 6:59 PM
emaste committed rS335454: usr.bin/ar: use standard 2-Clause FreeBSD license.
usr.bin/ar: use standard 2-Clause FreeBSD license
Wed, Jun 20, 6:43 PM
emaste accepted D15928: Add ThunderX2 CPU revision macro. Add ThunderX2 name in identcpu.c.
Wed, Jun 20, 4:47 PM
emaste added a comment to D15904: As objdump is being phased out for 12.0, convert the small bit using it to using readelf..
In D15904#336964, @mat wrote:

What matters is that it is available on all supported releases :-)

Wed, Jun 20, 2:58 PM
emaste updated subscribers of D15904: As objdump is being phased out for 12.0, convert the small bit using it to using readelf..

Another option: upon discussion with @dim we will likely end up installing llvm's llvm-objdump as objdump. It's broadly compatible, but the output format etc. might be slightly different.

Wed, Jun 20, 2:17 PM
emaste added a comment to D15908: readelf: add `--print-file-name`.

On second thought I'm not sure about this: --print-file-name options typically prefix all output lines with the file name.

Wed, Jun 20, 1:53 PM
emaste added a comment to D15904: As objdump is being phased out for 12.0, convert the small bit using it to using readelf..

This looks fine to me. It's probably worth adding a comment explaining the use of ${NONEXISTENT} though.

Wed, Jun 20, 1:52 PM
emaste added a comment to D15904: As objdump is being phased out for 12.0, convert the small bit using it to using readelf..
In D15904#336884, @mat wrote:

Mmmm,

$ readelf --print-file-name -r /usr/bin/mktemp
readelf: unrecognized option `--print-file-name'
Wed, Jun 20, 1:46 PM

Tue, Jun 19

emaste committed rS335387: linuxulator: handle V3 capget/capset.
linuxulator: handle V3 capget/capset
Tue, Jun 19, 9:26 PM
emaste closed D15887: linuxulator: handle V3 capget/capset.
Tue, Jun 19, 9:26 PM
emaste committed rS335377: usr.bin/ar: remove incorrect SPDX tags.
usr.bin/ar: remove incorrect SPDX tags
Tue, Jun 19, 5:30 PM
emaste committed rS335376: usr.bin/ar: use standard 2-Clause FreeBSD license.
usr.bin/ar: use standard 2-Clause FreeBSD license
Tue, Jun 19, 5:28 PM
emaste closed D14561: usr.bin/ar: use standard 2-Clause FreeBSD license.
Tue, Jun 19, 5:28 PM
emaste committed rS335375: MFC r334363: elfdump: chase ABI tag note name change from r232832.
MFC r334363: elfdump: chase ABI tag note name change from r232832
Tue, Jun 19, 5:12 PM
emaste created D15908: readelf: add `--print-file-name`.
Tue, Jun 19, 5:10 PM
emaste added a comment to D15904: As objdump is being phased out for 12.0, convert the small bit using it to using readelf..

Reported in the PR -- nm might be more useful for this script.

Tue, Jun 19, 3:05 PM
emaste updated subscribers of D15834: arm64 linuxulator: arm64 linux64 sysvec.
Tue, Jun 19, 1:03 PM
emaste accepted D15836: Rework how the ld link is handled in WORLDTMP from r322811..
Tue, Jun 19, 2:27 AM
emaste added a comment to D15836: Rework how the ld link is handled in WORLDTMP from r322811..

LGTM

Tue, Jun 19, 2:27 AM
emaste added inline comments to D15837: Rework WITHOUT_LLD/TOOLCHAIN fix from r327892 for cross-tools..
Tue, Jun 19, 2:24 AM
emaste added inline comments to D15837: Rework WITHOUT_LLD/TOOLCHAIN fix from r327892 for cross-tools..
Tue, Jun 19, 2:19 AM
emaste added a comment to D15837: Rework WITHOUT_LLD/TOOLCHAIN fix from r327892 for cross-tools..

Would it make sense to set some new variable based on TOOLS_PREFIX, MK_LLD, MK_LLD_BOOTSTRAP so that the same expression doesn't need to be repeated?

Tue, Jun 19, 1:34 AM
emaste added inline comments to D15836: Rework how the ld link is handled in WORLDTMP from r322811..
Tue, Jun 19, 1:31 AM
emaste updated subscribers of D15894: Add WITH_SYSTEM_LINKER, on by default, that avoids building lld when possible..

Looks ok

Tue, Jun 19, 1:28 AM
emaste added a comment to D14561: usr.bin/ar: use standard 2-Clause FreeBSD license.

(email followup to copyright holders sent Jun 18)

Tue, Jun 19, 12:48 AM

Mon, Jun 18

emaste added a comment to D15858: Fix output of linprocfs stat entry.

See linux_map_osrel

Mon, Jun 18, 9:36 PM
emaste updated the diff for D15834: arm64 linuxulator: arm64 linux64 sysvec.

Minor tidyup

Mon, Jun 18, 9:26 PM
emaste committed rS335333: Introduce arm64 linuxulator stubs.
Introduce arm64 linuxulator stubs
Mon, Jun 18, 7:34 PM
emaste closed D15832: Stub arm64 linuxulator routines.
Mon, Jun 18, 7:34 PM
emaste updated the diff for D15887: linuxulator: handle V3 capget/capset.

Also support V2. It's identical to V3 except that in Linux it produces a warning if used.

Mon, Jun 18, 7:19 PM
emaste created D15887: linuxulator: handle V3 capget/capset.
Mon, Jun 18, 7:11 PM
emaste committed rS335327: linuxulator: add debugging for invalid capget/capset version.
linuxulator: add debugging for invalid capget/capset version
Mon, Jun 18, 6:43 PM
emaste committed rS335324: Regen arm64 linuxulator sysent files after r335323.
Regen arm64 linuxulator sysent files after r335323
Mon, Jun 18, 6:10 PM
emaste committed rS335323: arm64 linuxulator: add dup syscall entry.
arm64 linuxulator: add dup syscall entry
Mon, Jun 18, 6:08 PM
emaste updated the diff for D15832: Stub arm64 linuxulator routines.

Update copyright and minor cleanup

Mon, Jun 18, 3:29 PM
emaste committed rS335315: linsysfs: depend on linux_common module on arm64, as on amd64.
linsysfs: depend on linux_common module on arm64, as on amd64
Mon, Jun 18, 1:26 PM
emaste added a comment to D15858: Fix output of linprocfs stat entry.

I like the idea, but I think the version comparison ought to be simplified and made more general. What do you think about parsing the version into a __FreeBSD_version style single integer in the sysctl handler and simplifying any comparisons of the value?

Mon, Jun 18, 12:50 PM

Sun, Jun 17

emaste added a comment to D15870: Add an 'efi' alias to g_part_mbr.

I did this in my tree this morning after our IRC discussion but went out for the afternoon. Committed after IRC discussion with @allanjude

Sun, Jun 17, 8:11 PM
emaste committed rS335301: gpart: add EFI alias for MBR partition scheme.
gpart: add EFI alias for MBR partition scheme
Sun, Jun 17, 8:11 PM
emaste closed D15870: Add an 'efi' alias to g_part_mbr.
Sun, Jun 17, 8:11 PM
emaste committed rS335300: Sort geom/part mbr/ebr/ldm alias table entries.
Sort geom/part mbr/ebr/ldm alias table entries
Sun, Jun 17, 8:06 PM

Sat, Jun 16

emaste added inline comments to D15836: Rework how the ld link is handled in WORLDTMP from r322811..
Sat, Jun 16, 7:52 PM

Fri, Jun 15

emaste added a reviewer for D15834: arm64 linuxulator: arm64 linux64 sysvec: andrew.
Fri, Jun 15, 8:40 PM
emaste created D15834: arm64 linuxulator: arm64 linux64 sysvec.
Fri, Jun 15, 8:39 PM
emaste created D15832: Stub arm64 linuxulator routines.
Fri, Jun 15, 8:31 PM
emaste committed rS335235: arm64 linuxulator: add linux_dummy.c based on amd64.
arm64 linuxulator: add linux_dummy.c based on amd64
Fri, Jun 15, 7:42 PM
emaste committed rS335232: arm64: add arm64 linux.h based on i386 linuxulator and Linux headers.
arm64: add arm64 linux.h based on i386 linuxulator and Linux headers
Fri, Jun 15, 7:09 PM
emaste added a comment to D15827: Remove obsolete asf(8).

I actually worry less about man page DEPRECATION, and more about having the binary spit something out so anyone using it for who knows what gets a heads up that it is/may be going away soon.

Fri, Jun 15, 5:45 PM
emaste committed rS335222: Remove obsolete asf(8).
Remove obsolete asf(8)
Fri, Jun 15, 5:44 PM
emaste closed D15827: Remove obsolete asf(8).
Fri, Jun 15, 5:44 PM
emaste committed rS335221: Add deprecation notice in asf.8.
Add deprecation notice in asf.8
Fri, Jun 15, 5:38 PM
emaste added a comment to D15827: Remove obsolete asf(8).

perhaps this for deprecation notice:

Index: usr.sbin/asf/asf.8
===================================================================
--- usr.sbin/asf/asf.8  (revision 335216)
+++ usr.sbin/asf/asf.8  (working copy)
@@ -37,6 +37,15 @@
 .Op Fl o Ar outfile
 .Op Fl X Ar suffix
 .Op Ar modules-path Op Ar outfile
+.Sh DEPRECATION NOTICE
+The
+.Nm
+utility is not present in
+.Fx 12.0
+and later.
+The
+.Xr kgdb 1
+debugger handles kernel module state internally.
 .Sh DESCRIPTION
 By default,
 .Nm
Fri, Jun 15, 5:32 PM
emaste added a comment to D7338: Disconnect objdump from the build.

Objdump removal tracking pr in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=229046

Fri, Jun 15, 5:18 PM
emaste added a comment to D13881: Add deprecation notice to objdump man page.

Committed to rendered man page in rS335219.

Fri, Jun 15, 5:18 PM
emaste committed rS335219: objdump.1: manually apply r229046 to the rendered man page.
objdump.1: manually apply r229046 to the rendered man page
Fri, Jun 15, 5:16 PM
emaste committed rS335217: Add deprecation notice to objdump man page.
Add deprecation notice to objdump man page
Fri, Jun 15, 5:04 PM
emaste closed D13881: Add deprecation notice to objdump man page.
Fri, Jun 15, 5:04 PM
emaste updated subscribers of D15827: Remove obsolete asf(8).
Fri, Jun 15, 4:57 PM
emaste created D15827: Remove obsolete asf(8).
Fri, Jun 15, 4:57 PM
emaste committed rS335214: Correct kern.pre.mk comment: objcopy, not objdump, copies objects..
Correct kern.pre.mk comment: objcopy, not objdump, copies objects.
Fri, Jun 15, 4:32 PM
emaste committed rS335213: ldd: reference readelf instead of objdump in warning message.
ldd: reference readelf instead of objdump in warning message
Fri, Jun 15, 4:29 PM
emaste committed rS335212: src.conf.5: regen after r335210, *BINUTILS description updates.
src.conf.5: regen after r335210, *BINUTILS description updates
Fri, Jun 15, 4:25 PM
emaste committed rS335210: Remove objcopy from BINUTILS option descriptions.
Remove objcopy from BINUTILS option descriptions
Fri, Jun 15, 4:18 PM
emaste committed rS335209: elf.5: add readelf cross-reference.
elf.5: add readelf cross-reference
Fri, Jun 15, 4:14 PM
emaste committed rS335201: linuxulator: do not include legacy syscalls on arm64.
linuxulator: do not include legacy syscalls on arm64
Fri, Jun 15, 2:42 PM
emaste closed D15237: linuxulator: do not include legacy syscalls on arm64.
Fri, Jun 15, 2:42 PM
emaste committed rS335200: Correct debug control for linuxulator faccessat.
Correct debug control for linuxulator faccessat
Fri, Jun 15, 2:30 PM
emaste committed rS335198: Add stubbed arm64 linuxulator /proc/cpuinfo handler.
Add stubbed arm64 linuxulator /proc/cpuinfo handler
Fri, Jun 15, 1:53 PM
emaste added a comment to D15237: linuxulator: do not include legacy syscalls on arm64.

How will this work if we decide to add linux32 on arm64? I expect we will need to implement the legacy syscalls there.

Fri, Jun 15, 1:33 PM
emaste added reviewers for D15237: linuxulator: do not include legacy syscalls on arm64: chuck, andrew.
Fri, Jun 15, 1:02 PM

Thu, Jun 14

emaste added a comment to D15638: Name the implementation of brk and sbrk sys_break()..

LGTM

Thu, Jun 14, 8:51 PM

Wed, Jun 13

emaste accepted D15563: Add linprocfs support for min_free_kbytes.
Wed, Jun 13, 1:23 AM · Linux Emulation

Tue, Jun 12

emaste accepted D15563: Add linprocfs support for min_free_kbytes.

It might be worth moving the clarification you provided in response to my query into a comment above linprocfs_dominfree.

Tue, Jun 12, 4:18 PM · Linux Emulation
emaste committed rS334998: linux64: use linux output target for linux_vdso.so.
linux64: use linux output target for linux_vdso.so
Tue, Jun 12, 1:32 PM
emaste updated subscribers of D15734: Fix objcopy for little-endian MIPS64 objects..
Tue, Jun 12, 2:17 AM
emaste added a comment to D14295: Add Lua as a scripting langauge to /boot/loader.

rS329166

Tue, Jun 12, 2:11 AM
emaste added inline comments to D15141: Add support for ThunderX2 PCIe.
Tue, Jun 12, 2:07 AM
emaste added inline comments to D15211: Add uefisign and friends to MK_EFI.
Tue, Jun 12, 2:02 AM
emaste accepted D15626: WITHOUT_NLS cleanup of more empty dirs.
Tue, Jun 12, 2:00 AM
emaste added a comment to D15638: Name the implementation of brk and sbrk sys_break()..

Change seems sensible to me.

Tue, Jun 12, 1:58 AM
emaste abandoned D3384: Add initDwarfEHRegSizeTable for arm64.
Tue, Jun 12, 1:53 AM

Mon, Jun 11

emaste accepted D15767: Add fat32lba description to gpart(8).
Mon, Jun 11, 11:00 PM
emaste committed rS334981: muge.4: remove BUGS section (about link/act LEDs).
muge.4: remove BUGS section (about link/act LEDs)
Mon, Jun 11, 8:46 PM
emaste committed rS334977: Connect muge.4 man page.
Connect muge.4 man page
Mon, Jun 11, 8:19 PM