- User Since
- Nov 24 2013, 3:15 AM (299 w, 1 d)
Fri, Aug 16
This change is not valid, it removes the templates but leaves the Makefile rules in place to install them.
LGTM other than the minor comments inline
rebase, add inline as suggested by @delphij
This is just another "upstream only considered Linux, we need to be included in the same way as Linux" case.
Can you show a diff of the NetBSD version to this? i.e. what you had to change in the port?
(I assume that we don't want to treat this as contrib code and will just adopt it.)
Wrap in .if !defined(_SKIP_BUILD)
(I've looked over the change other than the just update dictionary section so far)
Thu, Aug 15
No objection from me
As it turns out gptzfsboot is identical, whether GAS or IAS is used to assemble gptldr.S:
all other boot components have been addressed; only gptzfsboot needs to be investigated now
rebase after committing boot2 and cdboot changes
cdboot in rS351092
cdboot differences are a large number of addr32 prefixes and using nop nop for alignment rather than xchg %eax,%eax, so it is ok too
Do we know if the differences are similar there as well?
rS351073 for boot2
side by side comparison with the .o generated
Wed, Aug 14
Tue, Aug 13
Mon, Aug 12
Seems reasonable to me. I might expand the comment slightly to "prevents a MITM attack on the dependency."
Thu, Aug 8
@ngie will you commit this?
Looks like this was broken in rS336439
Tue, Aug 6
Sun, Aug 4
Thu, Aug 1
We're no longer using monthly.cgi
No objection. Please make sure that the releng documentation gets updated to make sure it gets turned back on again (either when making the stable branch or the release branch)
They are indeed not broken which is why I originally abandoned the review, but reopened it based on cem's feedback - as written there's some opportunity for confusion.