I have no objection

LGTM, we might have a few things to iterate on with this in the tree

I'm not sure where the argument got here in the first place.

Fine with me, assuming these are built using a different mechanism for the build toolchain itself.

LGTM, but give @dim a day or so to weigh in.

No objection from me

@trasz or @pstef will you shepherd this in?

Unfortunate that this convoluted method is required, but thanks for the clear comment explaining why it's that way.

Typo, "Tob Byte Ignore"

Would you be so kind as to show (snippets from) sample output with this change? I think having this sort of data available will be quite useful, just curious how it will look in practice.

Yes, a quick search suggests vsyscall was implemented only on 32- and 64-bit x86 Linux (and in Linuxulator, only 64-bit). And, sv_trap is used only in sys/amd64/amd64/trap.c.

Looks OK to me but will defer to @dim for questions about maintainability / expected impact on future clang/llvm updates

Drop "By default"

Unlike the Linux version

I will commit this shortly if nobody beats me to it.

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=256874 submitted for the GCC change

Roll this into D30924?

exp-run requested for good measure: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=256873
will commit after that's finished

ifunc can't be used

process VA layout has changed

Upstream review at https://reviews.llvm.org/D104753

Hrm, it seems I had an inline comment that was never submitted.

LGTM

Fix getTriple() in freebsd::Linker::ConstructJob()

Restore missing {

Created D30861 to have Clang stop linking against _p libraries with -pg for FreeBSD 14 and up. We'll need a similar change for GCC.

You'd be better off testing on i386 than amd64 I imagine.

I tried a quick sanity check of -pg on my ~ FreeBSD 13.0 amd64 laptop, without success:

Cirrus-CI runs
main: https://cirrus-ci.com/task/4988055556718592
28:46 build time
11886 du -m -s /usr/obj

In D22012#693142, @koobs wrote:

ISC DHCP client/relay end of maintenance:

I like this idea.