Page MenuHomeFreeBSD

emaste (Ed Maste)
UserAdministrator

Projects (19)

User Details

User Since
Nov 24 2013, 3:15 AM (653 w, 4 d)
Roles
Administrator

Recent Activity

Today

emaste committed rGf0ac411a7747: bsdinstall: Use libarchive secure flags for extract (authored by emaste).
bsdinstall: Use libarchive secure flags for extract
Thu, Jun 4, 1:17 AM

Yesterday

emaste added inline comments to D46193: sys: implement Kernel CFI from clang.
Wed, Jun 3, 11:55 PM
emaste committed rG67df31301590: linuxkpi: Make pm_qos.h self-contained (authored by siri_racha.ca).
linuxkpi: Make pm_qos.h self-contained
Wed, Jun 3, 11:42 PM
emaste closed D57415: LinuxKPI: Add linux/types.h to pm_qos.h, fixes issue in new drm-kmod patches.
Wed, Jun 3, 11:42 PM · linuxkpi
emaste added a comment to D57415: LinuxKPI: Add linux/types.h to pm_qos.h, fixes issue in new drm-kmod patches.

FWIW Linux does not include types.h from pm_qos.h, but it has three other #includes, one of which presumably transitively includes types.h.

Wed, Jun 3, 9:57 PM · linuxkpi
emaste added a comment to D57415: LinuxKPI: Add linux/types.h to pm_qos.h, fixes issue in new drm-kmod patches.

needed by a new version of a wireless driver

Wed, Jun 3, 9:03 PM · linuxkpi
emaste closed D57418: install.1: Convert link flags to a table.
Wed, Jun 3, 8:46 PM
emaste committed rG248dd56d2dea: install.1: Convert link flags to a table (authored by emaste).
install.1: Convert link flags to a table
Wed, Jun 3, 8:46 PM
emaste added a comment to D57411: xinstall: Add metalog contents reference link type.

Aside from fixing compatibility with symlink/hard link creation we'll also need to address certctl, which currently has ${METALOG_INSTALLFLAGS} passed to it in installworld.

Wed, Jun 3, 8:38 PM
emaste added a reviewer for D57418: install.1: Convert link flags to a table: ziaee.
Wed, Jun 3, 8:35 PM
emaste committed rGb49021b49a78: install.1: Document options incompatible with -s (authored by emaste).
install.1: Document options incompatible with -s
Wed, Jun 3, 8:35 PM
emaste closed D57409: install.1: Document options incompatible with -s.
Wed, Jun 3, 8:35 PM
emaste added a comment to D57411: xinstall: Add metalog contents reference link type.

Hrm, on 2nd thought -l c is not as obvious as I at first thought. We use the existing -l modes in the build already, via INSTALL_LINK, INSTALL_SYMLINK, INSTALL_RSYMLINK.

Wed, Jun 3, 6:31 PM
emaste accepted D57317: sysutils/rpi-usbboot: Raspberry Pi USB device provisioning tool.
Wed, Jun 3, 6:18 PM
emaste requested review of D57418: install.1: Convert link flags to a table.
Wed, Jun 3, 6:03 PM
emaste updated the diff for D57411: xinstall: Add metalog contents reference link type.
  • improve man page
  • move (and rename) parse_l
  • add digest
  • start adding test suite
Wed, Jun 3, 6:02 PM
emaste added inline comments to D57411: xinstall: Add metalog contents reference link type.
Wed, Jun 3, 4:25 PM
emaste removed a reviewer for D57411: xinstall: Add metalog contents reference link type: brooks.
Wed, Jun 3, 3:59 PM
emaste requested review of D57411: xinstall: Add metalog contents reference link type.
Wed, Jun 3, 3:57 PM
emaste requested review of D57409: install.1: Document options incompatible with -s.
Wed, Jun 3, 3:36 PM
emaste committed rG521afce6a859: xinstall: Do not allow -l and -s together (authored by emaste).
xinstall: Do not allow -l and -s together
Wed, Jun 3, 3:33 PM
emaste committed rG4908bea5b7f5: xinstall: Add test for -d -s not allowed together (authored by emaste).
xinstall: Add test for -d -s not allowed together
Wed, Jun 3, 3:33 PM
emaste closed D57403: xinstall: Add test for -d -s not allowed together.
Wed, Jun 3, 3:33 PM
emaste closed D57398: xinstall: Do not allow -l and -s together.
Wed, Jun 3, 3:33 PM
emaste added a reviewer for D57403: xinstall: Add test for -d -s not allowed together: des.
Wed, Jun 3, 2:28 PM
emaste added reviewers for D57398: xinstall: Do not allow -l and -s together: des, jrtc27.
Wed, Jun 3, 2:28 PM
emaste updated the diff for D57398: xinstall: Do not allow -l and -s together.

add test

Wed, Jun 3, 2:28 PM
emaste requested review of D57403: xinstall: Add test for -d -s not allowed together.
Wed, Jun 3, 2:21 PM
emaste requested review of D57398: xinstall: Do not allow -l and -s together.
Wed, Jun 3, 1:27 AM

Mon, Jun 1

emaste added a comment to D57348: rtprio(_thread): Add capability mode checks.

Do we want some test that coveres this?

Mon, Jun 1, 6:44 PM
emaste committed rGf77d37cffdf3: linuxulator: Return EINVAL for invalid inotify flags (authored by emaste).
linuxulator: Return EINVAL for invalid inotify flags
Mon, Jun 1, 6:43 PM
emaste closed D57387: linuxulator: Return EINVAL for invalid inotify flags.
Mon, Jun 1, 6:43 PM
emaste added a comment to D45243: Introduce fcopydata() and fcopydata_sig() functions..

@pjd do you expect to pick this up again?

Mon, Jun 1, 6:29 PM
emaste updated the summary of D57387: linuxulator: Return EINVAL for invalid inotify flags.
Mon, Jun 1, 6:25 PM
emaste requested review of D57387: linuxulator: Return EINVAL for invalid inotify flags.
Mon, Jun 1, 6:24 PM
emaste added a reviewer for D57385: getpgid,getsid: Add capability mode checks: capsicum.
Mon, Jun 1, 5:14 PM
emaste requested review of D57385: getpgid,getsid: Add capability mode checks.
Mon, Jun 1, 5:14 PM
emaste committed rG72e34b3e3907: get/setpriority: Add capability mode checks (authored by emaste).
get/setpriority: Add capability mode checks
Mon, Jun 1, 4:31 PM
emaste closed D57345: get/setpriority: Add capability mode checks.
Mon, Jun 1, 4:31 PM
emaste added a reviewer for D57255: cut(1), rev(1): add Capsicum sandboxing: capsicum.
Mon, Jun 1, 3:30 PM

Sat, May 30

emaste added a comment to D57345: get/setpriority: Add capability mode checks.

The first to land of this one and D57348 needs to add #include <sys/capsicum.h>.

Sat, May 30, 1:26 AM

Fri, May 29

emaste updated the diff for D57346: p1003_1b: Add capability mode checks.

add header

Fri, May 29, 11:15 PM
emaste updated the diff for D57348: rtprio(_thread): Add capability mode checks.

Add header

Fri, May 29, 11:15 PM
emaste committed rG96dbc9a8de10: netlink: Check permissions for interface flag changes (authored by emaste).
netlink: Check permissions for interface flag changes
Fri, May 29, 11:12 PM
emaste committed rG9ddb6064f815: netlink: Use early exit pattern in _nl_modify_ifp_generic (authored by emaste).
netlink: Use early exit pattern in _nl_modify_ifp_generic
Fri, May 29, 11:12 PM
emaste closed D57332: netlink: Check permission for interface flag changes.
Fri, May 29, 11:12 PM
emaste closed D57349: netlink: Use early exit pattern in _nl_modify_ifp_generic.
Fri, May 29, 11:11 PM
emaste committed rG692b0ef1506b: syscalls.master: Allow clock_nanosleep in capability mode (authored by emaste).
syscalls.master: Allow clock_nanosleep in capability mode
Fri, May 29, 10:26 PM
emaste closed D57343: syscalls.master: Allow clock_nanosleep in capability mode.
Fri, May 29, 10:26 PM
emaste accepted D57338: netlink/route: extend pre-2.6.19 Linux compat shim to del/getroute.
Fri, May 29, 10:19 PM
emaste closed D57336: route: Fix `flush` w/o specified address family.
Fri, May 29, 10:19 PM
emaste committed rG32a7ba251acb: route: Fix `flush` w/o specified address family (authored by emaste).
route: Fix `flush` w/o specified address family
Fri, May 29, 10:19 PM
emaste requested review of D57349: netlink: Use early exit pattern in _nl_modify_ifp_generic.
Fri, May 29, 9:10 PM
emaste requested review of D57348: rtprio(_thread): Add capability mode checks.
Fri, May 29, 9:05 PM
emaste requested review of D57346: p1003_1b: Add capability mode checks.
Fri, May 29, 9:00 PM
emaste requested review of D57345: get/setpriority: Add capability mode checks.
Fri, May 29, 8:51 PM
emaste added a comment to D57343: syscalls.master: Allow clock_nanosleep in capability mode.

Fixes: 3f8455b0905a ("Add clock_nanosleep()")

Fri, May 29, 8:29 PM
emaste requested review of D57343: syscalls.master: Allow clock_nanosleep in capability mode.
Fri, May 29, 8:27 PM
emaste committed rGd11ff01b3aec: sigqueue: In capability mode, only allow signalling self (authored by emaste).
sigqueue: In capability mode, only allow signalling self
Fri, May 29, 7:13 PM
emaste committed rGdefd9b86ef99: sigqueue: In capability mode, only allow signalling self (authored by emaste).
sigqueue: In capability mode, only allow signalling self
Fri, May 29, 7:12 PM
emaste updated subscribers of D57336: route: Fix `flush` w/o specified address family.
Fri, May 29, 6:09 PM
emaste added a comment to D56750: netlink: store osreldate of the process in the netlink pcb.

Do you have an example of the kind of backwards compat we'd provide?

Fri, May 29, 5:47 PM
emaste added a comment to D57338: netlink/route: extend pre-2.6.19 Linux compat shim to del/getroute.

Perhaps worth a static inline old_linux_compat() to avoid repeating it 3 times? LGTM either way

Fri, May 29, 5:35 PM
emaste requested review of D57336: route: Fix `flush` w/o specified address family.
Fri, May 29, 5:13 PM
emaste requested review of D57334: netlink: Indicate that ifinfomsg uses IFT_* types.
Fri, May 29, 4:30 PM
emaste updated the diff for D57332: netlink: Check permission for interface flag changes.

also promisc

Fri, May 29, 4:02 PM
emaste added inline comments to D57332: netlink: Check permission for interface flag changes.
Fri, May 29, 3:58 PM
emaste requested review of D57332: netlink: Check permission for interface flag changes.
Fri, May 29, 3:53 PM

Thu, May 28

emaste added a comment to D57317: sysutils/rpi-usbboot: Raspberry Pi USB device provisioning tool.

Would it make sense for it to be sysutils/rpi-usbboot as well, so the port and package name match? I'm not sure about conventions here.

Thu, May 28, 11:44 PM
emaste requested review of D57304: dhclient.conf.5: Add supersede interface-mtu to example.
Thu, May 28, 4:50 PM
emaste accepted D55392: LinuxKPi: idr: use macros for lock idr lock operations.
Thu, May 28, 2:25 PM
emaste committed rGf9f46294d6af: bsdinstall: Use libarchive secure flags for extract (authored by emaste).
bsdinstall: Use libarchive secure flags for extract
Thu, May 28, 1:04 PM
emaste closed D57274: bsdinstall: Use libarchive secure flags for extract.
Thu, May 28, 1:04 PM
emaste added a comment to D57274: bsdinstall: Use libarchive secure flags for extract.

I mean, sure, I guess, but what's the threat model here? I sure hope you trust the tarballs you're unpacking to install a system not to be malicious, otherwise what's the point?

Thu, May 28, 12:58 PM
emaste accepted D57288: ptrace_test: expect PT_STEP tests to fail on riscv.
Thu, May 28, 12:48 AM

Wed, May 27

emaste accepted D57266: rtnetlink: Fix weight overflow in RTA_MULTIPATH.

Oops, MIN of course.

Wed, May 27, 9:21 PM
emaste added inline comments to D57266: rtnetlink: Fix weight overflow in RTA_MULTIPATH.
Wed, May 27, 2:10 PM
emaste requested review of D57274: bsdinstall: Use libarchive secure flags for extract.
Wed, May 27, 1:32 PM

Tue, May 26

emaste committed rGb9d16b7fd2fa: sigqueue: In capability mode, only allow signalling self (authored by emaste).
sigqueue: In capability mode, only allow signalling self
Tue, May 26, 7:19 PM
emaste closed D57244: sigqueue: In capability mode, only allow signalling self.
Tue, May 26, 7:19 PM
emaste committed rG2ca9d9256fd4: nlist.3: Add discouraged use notice (authored by emaste).
nlist.3: Add discouraged use notice
Tue, May 26, 5:19 PM
emaste committed rG50832522ecc0: nlist.3: Clarify which symbol table is used (authored by emaste).
nlist.3: Clarify which symbol table is used
Tue, May 26, 5:19 PM
emaste committed rGfea07b76a0bc: nlist.3: Replace a.out(5) Xref with elf(5) (authored by emaste).
nlist.3: Replace a.out(5) Xref with elf(5)
Tue, May 26, 5:19 PM
emaste committed rGe25366d46bf5: nlist.3: Clarify which symbol table is used (authored by emaste).
nlist.3: Clarify which symbol table is used
Tue, May 26, 5:14 PM
emaste committed rGbe2da08e0b5b: nlist.3: Add discouraged use notice (authored by emaste).
nlist.3: Add discouraged use notice
Tue, May 26, 5:14 PM
emaste committed rG9d9651c49575: nlist.3: Replace a.out(5) Xref with elf(5) (authored by emaste).
nlist.3: Replace a.out(5) Xref with elf(5)
Tue, May 26, 5:14 PM
emaste added a comment to D51589: amdgpio: Suspend routine.

Is it reasonable to commit this (with the understanding that there will still be issues post-resume)?

Tue, May 26, 2:38 PM
emaste updated the diff for D57244: sigqueue: In capability mode, only allow signalling self.

Add a (not even build tested yet) test

Tue, May 26, 1:55 PM
emaste added a reviewer for D57244: sigqueue: In capability mode, only allow signalling self: capsicum.
Tue, May 26, 1:27 PM
emaste requested review of D57244: sigqueue: In capability mode, only allow signalling self.
Tue, May 26, 1:26 PM

Mon, May 25

emaste closed D57234: netlink: Fix RTM_GETROUTE loop for RT_TABLE_UNSPEC.
Mon, May 25, 4:38 PM
emaste committed rG33acf0f26b49: netlink: Fix RTM_GETROUTE loop for RT_TABLE_UNSPEC (authored by emaste).
netlink: Fix RTM_GETROUTE loop for RT_TABLE_UNSPEC
Mon, May 25, 4:38 PM
emaste accepted D57238: vt: Drain select/poll threads when closing /dev/sysmouse.
Mon, May 25, 4:17 PM
emaste added a comment to D50614: tests: Allow building without TIOCSTI.

You mean the TIOCSTI definition was hidden?

Sorry, yes. The ioctl definition.

Mon, May 25, 2:55 PM
emaste requested review of D57234: netlink: Fix RTM_GETROUTE loop for RT_TABLE_UNSPEC.
Mon, May 25, 2:21 PM
emaste accepted D57232: acpi: Replace mentions of the s2idle with suspend_to_idle.
Mon, May 25, 2:12 PM
emaste requested review of D57233: tty: Add sysctl knob to globally disable TIOCSTI.
Mon, May 25, 2:09 PM
emaste added a comment to D50614: tests: Allow building without TIOCSTI.

In my tree I hid the sysctl to find consumers and confirm that the system works without it. The consumers are:

  • clang sanitizers
  • tcsh
  • mail
  • this test
Mon, May 25, 2:08 PM
emaste added a reviewer for D50614: tests: Allow building without TIOCSTI: secteam.
Mon, May 25, 1:49 PM
emaste committed rGf05fb5157ba1: vtfontcvt: Return error from write_fnt_source (authored by emaste).
vtfontcvt: Return error from write_fnt_source
Mon, May 25, 1:48 PM