emaste (Ed Maste)Administrator
User

Projects (9)

User Details

User Since
Nov 24 2013, 3:15 AM (222 w, 1 d)
Roles
Administrator

Recent Activity

Today

emaste added a comment to D14407: Introduce cap_fileargs..

Other than a couple of small comments I think this is good to go.

Mon, Feb 26, 3:26 AM
emaste updated subscribers of D14407: Introduce cap_fileargs..

@cem, @kevans: I think hexdump is probably a good candidate for the next program to apply fileargs, as we've currently implemented enter-capability-mode-on-last-argument.

Mon, Feb 26, 2:43 AM

Yesterday

emaste added inline comments to D14178: Allow CROSS_TOOLCHAIN to be a path to a file..
Sun, Feb 25, 10:10 PM
emaste added a comment to D10213: Adding virtualization support for ARMv7 platforms.

MI - Machine Independent
MD - Machine Dependent (i.e., architecture-specific)

Sun, Feb 25, 2:22 PM · ARM

Fri, Feb 23

emaste added a comment to D10213: Adding virtualization support for ARMv7 platforms.

I'd suggest we commit this incrementally; I'm looking at the MD/MI movement atm.

Fri, Feb 23, 8:13 PM · ARM
emaste reopened D3715: Add "rcorder -p"..

@trasz sorry I accidentally committed r329877 but referenced this review; can you please re-upload?

Fri, Feb 23, 8:06 PM
emaste abandoned D14489: Correct typo in ATA_WRITE_UNCORRECTABLE_PSEUDO.
Fri, Feb 23, 8:05 PM
emaste accepted D14489: Correct typo in ATA_WRITE_UNCORRECTABLE_PSEUDO.

Committed as r329877 (which accidentally reported review D3715).

Fri, Feb 23, 8:05 PM
emaste committed rS329877: Correct typo in ATA_WRITE_UNCORRECTABLE_PSEUDO.
Correct typo in ATA_WRITE_UNCORRECTABLE_PSEUDO
Fri, Feb 23, 8:01 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Fri, Feb 23, 8:01 PM
emaste created D14489: Correct typo in ATA_WRITE_UNCORRECTABLE_PSEUDO.
Fri, Feb 23, 7:45 PM
emaste committed rS329876: Use linux types for linux-specific syscalls.
Use linux types for linux-specific syscalls
Fri, Feb 23, 7:09 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Fri, Feb 23, 7:09 PM
emaste committed rS329873: Correct pseudo misspelling in sys/ comments.
Correct pseudo misspelling in sys/ comments
Fri, Feb 23, 6:16 PM
emaste added a comment to D14407: Introduce cap_fileargs..

So for know the idea is to just create two or three whatever fileargs instance as you need with difference rights.

Fri, Feb 23, 4:46 PM
emaste added a comment to D14407: Introduce cap_fileargs..

See D14408 and D14409 for example use case

Fri, Feb 23, 3:25 PM

Thu, Feb 22

emaste committed rS329801: Remove accidental vim droppings.
Remove accidental vim droppings
Thu, Feb 22, 3:37 AM
emaste added inline comments to D14464: Avoid grabbing locks when grabbing the vt(4) console for DDB..
Thu, Feb 22, 2:47 AM
emaste committed rS329794: Correct proper nouns in the Linuxulator.
Correct proper nouns in the Linuxulator
Thu, Feb 22, 2:24 AM
emaste committed rS329787: Use 'const int *' for sysentvec errno translation table.
Use 'const int *' for sysentvec errno translation table
Thu, Feb 22, 2:00 AM
emaste accepted D14464: Avoid grabbing locks when grabbing the vt(4) console for DDB..

LGTM

Thu, Feb 22, 12:30 AM
emaste added a comment to D14408: Sandbox wc(1) with fileargs..

Looks good

Thu, Feb 22, 12:26 AM
emaste added inline comments to D14409: Sandbox head(1) with fileargs..
Thu, Feb 22, 12:23 AM
emaste added a comment to D14407: Introduce cap_fileargs..

I think this looks good. (Note that I haven't yet reviewed in detail.)

Thu, Feb 22, 12:12 AM

Wed, Feb 21

emaste updated the diff for D14242: Enable kernel retpoline support.
  • rename KERNEL_RETPOLINE to separate it from possible future userland support
  • default to no for now, with the intent of setting it in GENERIC as is done with CTF
Wed, Feb 21, 8:38 PM
emaste committed rS329745: load_elf.c: Use consistent indentation.
load_elf.c: Use consistent indentation
Wed, Feb 21, 7:43 PM
emaste committed rS329723: ministat: disallow negative variance / nan Stddev.
ministat: disallow negative variance / nan Stddev
Wed, Feb 21, 3:54 PM

Tue, Feb 20

emaste added a comment to D14242: Enable kernel retpoline support.
In D14242#302967, @imp wrote:

Since kernel config files set 'makeoptions' it should use WITH/WITHOUT.

Tue, Feb 20, 9:27 PM
emaste added a comment to D14242: Enable kernel retpoline support.
In D14242#302122, @dim wrote:

Well, if there is only one setting, users will have the choice to compile *everything* with, or without retpoline mitigation. Not sure if there is a scenario where one would want to have a mitigated kernel with a non-mitigated userland, or vice versa?

Tue, Feb 20, 9:06 PM
emaste added a reviewer for D14242: Enable kernel retpoline support: jhb.
Tue, Feb 20, 8:45 PM

Sat, Feb 17

emaste added inline comments to D14409: Sandbox head(1) with fileargs..
Sat, Feb 17, 1:02 PM
emaste added inline comments to D14407: Introduce cap_fileargs..
Sat, Feb 17, 12:59 PM

Fri, Feb 16

emaste committed rS329373: Correct module symbol export handling.
Correct module symbol export handling
Fri, Feb 16, 3:38 PM
emaste closed D14284: Correct module symbol export handling.
Fri, Feb 16, 3:38 PM
emaste added a comment to D14284: Correct module symbol export handling.
In D14284#300508, @jhb wrote:

I was just curious, I don't think there's probably a need to make a test module (though having a real test for this might be nice). I had figured you had run into it somehow and was wondering if that somehow had turned into an easy test to verify correctness. :)

Fri, Feb 16, 3:34 PM
emaste edited reviewers for D14210: Rationalize license test on Linuxolator files, added: peter, dfr, dchagin; removed: marcel, gallatin, eadler, kan.
Fri, Feb 16, 3:10 PM
emaste updated subscribers of D14210: Rationalize license test on Linuxolator files.

After r329370 remaining files waiting on approval from:

  • Assar Westerlund
  • Doug Rabson
  • Peter Wemm
  • Tim J. Robbins
  • Dmitry Chagin
Fri, Feb 16, 3:09 PM
emaste updated the diff for D14210: Rationalize license test on Linuxolator files.

Refresh after partial commit

Fri, Feb 16, 3:06 PM
emaste committed rS329370: Rationalize license text on Linuxolator files.
Rationalize license text on Linuxolator files
Fri, Feb 16, 3:00 PM
emaste added inline comments to D9925: en_CA and fr_CA switch to ISO8601 date format.
Fri, Feb 16, 3:43 AM

Thu, Feb 15

emaste added a comment to D14103: Support post-2015 Lenovo models in acpi_ibm / support keyboard backlight (also led(4)) / support micmute led(4).

Here's the acpidump -dt:

Thu, Feb 15, 1:48 AM

Tue, Feb 13

emaste added a comment to D14282: Set the RW/NX bits to protect kernel text and data loaded as part of the main kernel image.
In D14282#300983, @jhb wrote:

Unfortunately there isn't an existing MD hook before before/after that would let you avoid #ifdef's in that routine. Could add some new macros to sys/<arch>/include/gdb_machdep.h for start/stop of memory write perhaps.

Tue, Feb 13, 11:59 PM
emaste committed rS329247: MFC r328052: kldxref: handle modules with md_cval at end of allocated secs.
MFC r328052: kldxref: handle modules with md_cval at end of allocated secs
Tue, Feb 13, 10:40 PM
emaste committed rS329246: MFC r327503: kldxref: correct function names in warning messages.
MFC r327503: kldxref: correct function names in warning messages
Tue, Feb 13, 10:38 PM
emaste created D14363: Install llvm-cov also as gcov, if no GNU gcov.
Tue, Feb 13, 10:34 PM
emaste committed rS329245: Add DECLARE_MODULE_TIED mlink missed in r329244.
Add DECLARE_MODULE_TIED mlink missed in r329244
Tue, Feb 13, 9:33 PM
emaste committed rS329244: Document DECLARE_MODULE_TIED.
Document DECLARE_MODULE_TIED
Tue, Feb 13, 9:22 PM
emaste added inline comments to D14282: Set the RW/NX bits to protect kernel text and data loaded as part of the main kernel image.
Tue, Feb 13, 8:54 PM
emaste committed rS329239: amd64/pmap: Move Foundation copyright to the 2-clause section.
amd64/pmap: Move Foundation copyright to the 2-clause section
Tue, Feb 13, 7:19 PM
emaste committed rS329237: libkern: use nul for terminating char rather than 0.
libkern: use nul for terminating char rather than 0
Tue, Feb 13, 7:18 PM
emaste added a comment to D14302: Fix uninitialized warning, and work around a bug in gcc over clobbering.

Yes. At least the plan of record is we ditch GCC4.2 in 13. That will be nice.

Tue, Feb 13, 6:47 PM
emaste accepted D14343: Put the rootfs on the correct partition.
Tue, Feb 13, 6:40 PM
emaste accepted D14343: Put the rootfs on the correct partition.

LGTM

Tue, Feb 13, 2:55 PM
emaste added a comment to D14347: Ensure memory consistency on COW.

I tested net/samba47 builds as suggested in PR 225584. Previous tests without this D14347 patch (but some with various diagnostic or workaround patches) hung between the first and 20th or so iteration. With this patch applied my Threadripper completed 132 cycles of net/samba47 build last night.

Tue, Feb 13, 2:33 PM

Mon, Feb 12

emaste added a comment to D14284: Correct module symbol export handling.
In D14284#300389, @jhb wrote:

Looks ok to me. Did you have a test kernel module you used to test this?

Mon, Feb 12, 8:05 PM

Sun, Feb 11

emaste added inline comments to D14317: Allow building bsdxml.h when the bmake shell uses -o pipefail.
Sun, Feb 11, 11:29 PM

Sat, Feb 10

emaste added a comment to D14103: Support post-2015 Lenovo models in acpi_ibm / support keyboard backlight (also led(4)) / support micmute led(4).

Testing with this change on X260 (LEN0068, MHKV 0x0200 AFAICT) I see warnings like:

# sysctl dev.acpi_ibm.0.kbd_backlight=0
ACPI Warning: \_SB.PCI0.LPC.EC.HKEY.MLCG: Insufficient arguments - Caller passed 0, method requires 1 (20180209/nsarguments-383)
ACPI Warning: \_SB.PCI0.LPC.EC.HKEY.MLCG: Insufficient arguments - Caller passed 0, method requires 1 (20180209/nsarguments-383)
dev.acpi_ibm.0.kbd_backlight: 1ACPI Warning: \_SB.PCI0.LPC.EC.HKEY.MLCG: Insufficient arguments - Caller passed 0, method requires 1 (20180209/nsarguments-383)
 -> ACPI Warning: \_SB.PCI0.LPC.EC.HKEY.MLCG: Insufficient arguments - Caller passed 0, method requires 1 (20180209/nsarguments-383)
ACPI Warning: \_SB.PCI0.LPC.EC.HKEY.MLCG: Insufficient arguments - Caller passed 0, method requires 1 (20180209/nsarguments-383)
0
#

Keyboard backlight control works despite the warnings. I haven't tested this machine on an unpatched kernel. echo 1 > /dev/led/micmute has no effect.

Sat, Feb 10, 11:53 PM
emaste committed rS329113: MFC r328895: Correct Russia spelling in regdomain.xml.
MFC r328895: Correct Russia spelling in regdomain.xml
Sat, Feb 10, 10:36 PM
emaste committed rS329111: MFC r328895: Correct Russia spelling in regdomain.xml.
MFC r328895: Correct Russia spelling in regdomain.xml
Sat, Feb 10, 10:35 PM
emaste added a comment to D14295: Add Lua as a scripting langauge to /boot/loader.

I presume the commit will have Sponsored bys for Google Summer of Code, Netflix, and the FreeBSD Foundation; any others?

Sat, Feb 10, 8:20 PM
emaste added a comment to D14103: Support post-2015 Lenovo models in acpi_ibm / support keyboard backlight (also led(4)) / support micmute led(4).

No regressions observed on my Thinkpad X220 with this change.
Changing dev.acpi_ibm.0.volume has no effect, but did not work before either.

Sat, Feb 10, 2:28 AM
emaste added a comment to D14103: Support post-2015 Lenovo models in acpi_ibm / support keyboard backlight (also led(4)) / support micmute led(4).

I'll test this on old and hopefully new thinkpads

Sat, Feb 10, 12:34 AM
emaste committed rS329094: Regen src.conf.5 after r329093, WITH_/WITHOUT_LLVM_COV.
Regen src.conf.5 after r329093, WITH_/WITHOUT_LLVM_COV
Sat, Feb 10, 12:27 AM
emaste committed rS329093: Promote llvm-cov to a standalone option.
Promote llvm-cov to a standalone option
Sat, Feb 10, 12:22 AM

Fri, Feb 9

emaste updated the diff for D14284: Correct module symbol export handling.

Microoptimize away a fork+exec of tr, from @stevek

Fri, Feb 9, 7:08 PM
emaste updated subscribers of D14284: Correct module symbol export handling.
Fri, Feb 9, 6:51 PM
emaste created D14284: Correct module symbol export handling.
Fri, Feb 9, 6:43 PM

Thu, Feb 8

emaste accepted D14267: loader: fix endianness conversion.

This works in my QEMU test case and LGTM, modulo indentation nits.

Thu, Feb 8, 6:41 PM
emaste added inline comments to D14170: Initial changes to Makefile.inc1 to allow crossbuilding on Linux and Mac.
Thu, Feb 8, 6:36 PM
emaste updated subscribers of D14267: loader: fix endianness conversion.

Existing indentation in this file is a mess, but there are a couple of new cases that don't match either of the two existing styles. I suggest tweaking this change to match the surrounding cases, and then someone (@imp or me, perhaps) should follow up with reformatting the portions that don't conform to style(9).

Thu, Feb 8, 6:23 PM
emaste added inline comments to D14265: Promote llvm-cov to a standalone option.
Thu, Feb 8, 4:38 PM
emaste created D14265: Promote llvm-cov to a standalone option.
Thu, Feb 8, 4:37 PM
emaste added a comment to D14242: Enable kernel retpoline support.
In D14242#298846, @dim wrote:

Maybe a general remark, will this MK_RETPOLINE option be separate from a similar option for userland? Also, does this take care of adding the required link flags when linking the kernel?

Thu, Feb 8, 2:34 PM
emaste added inline comments to D14170: Initial changes to Makefile.inc1 to allow crossbuilding on Linux and Mac.
Thu, Feb 8, 2:44 AM
emaste committed rS329006: MFC r328412: vt: add Ctrl+/ key mapping.
MFC r328412: vt: add Ctrl+/ key mapping
Thu, Feb 8, 12:42 AM
emaste committed rS329005: MFC r328412: vt: add Ctrl+/ key mapping.
MFC r328412: vt: add Ctrl+/ key mapping
Thu, Feb 8, 12:41 AM
emaste committed rS329003: ld.lld.1: explain long options may use one or two dashes.
ld.lld.1: explain long options may use one or two dashes
Thu, Feb 8, 12:09 AM

Wed, Feb 7

emaste committed rS329002: Update ld.lld.1 based on the version committed upstream.
Update ld.lld.1 based on the version committed upstream
Wed, Feb 7, 11:58 PM
emaste updated subscribers of D14242: Enable kernel retpoline support.
Wed, Feb 7, 10:01 PM
emaste added inline comments to D14246: crossbuild: make mkioctls script work on Linux and MacOS.
Wed, Feb 7, 7:24 PM
emaste added a comment to D14242: Enable kernel retpoline support.

With this patch I see six register-indirect jmps/calls in a GENERIC kernel:

ffffffff80999047:       ff d0   callq   *%rax
ffffffff80e3c0d6:       ff d0   callq   *%rax
ffffffff80e5d5d0:       ff 14 24        callq   *(%rsp)
ffffffff80f3d79f:       ff 55 f8        callq   *-8(%rbp)
ffffffff80f88b40:       ff 54 24 10     callq   *16(%rsp)
ffffffff80f88b60:       ff 54 24 10     callq   *16(%rsp)

The corresponding symbols for these are: privcmd_ioctl, outofnmi, sigcode, hypercall_md, ia32_sigcode, freebsd4_ia32_sigcode.

Wed, Feb 7, 6:24 PM
emaste updated the diff for D14242: Enable kernel retpoline support.

Use COMPILER_FEATURES not LINKER_FEATURES for testing compiler features as reported by @dim.

Wed, Feb 7, 4:44 PM
emaste added a comment to D14242: Enable kernel retpoline support.

Example of retpoline, from sys/cam/scsi/scsi_enc.c

Wed, Feb 7, 3:35 PM
emaste added inline comments to D14242: Enable kernel retpoline support.
Wed, Feb 7, 3:29 PM
emaste created D14242: Enable kernel retpoline support.
Wed, Feb 7, 3:21 PM
emaste committed rS328972: add retpoline compiler and linker feature flags.
add retpoline compiler and linker feature flags
Wed, Feb 7, 2:50 PM
emaste closed D14228: bsd.linker.mk: add retpolineplt linker feature.
Wed, Feb 7, 2:50 PM
emaste abandoned D14220: ld.lld.1: document the rest of the -z options.

These changes will be included in the work to upstream the man page, tracked in https://reviews.llvm.org/D42963

Wed, Feb 7, 2:30 PM
emaste accepted D14185: Don't change directory owner to root when building with -DNO_ROOT.

LGTM, would like to see ideally @bdrewery but at least someone else agree

Wed, Feb 7, 1:17 AM
emaste added a comment to D14228: bsd.linker.mk: add retpolineplt linker feature.
In D14228#298494, @dim wrote:

This looks good to me, though at some version gcc and BFD ld will also support retpoline, right? We can add that later...

Wed, Feb 7, 1:08 AM

Tue, Feb 6

emaste accepted D14231: Avoid find -s, use find | sort instead..

LGTM although I still think a comment is warranted

Tue, Feb 6, 10:43 PM
emaste updated the diff for D14228: bsd.linker.mk: add retpolineplt linker feature.

Quote COMPILER_FEATURES for CROSSENV as it may contain spaces

Tue, Feb 6, 10:36 PM
emaste added a comment to D14231: Avoid find -s, use find | sort instead..

Might be wroth adding a comment that find -s is not portable, to discourage someone from changing it back to remove the extra exec as an optimization.

Tue, Feb 6, 10:17 PM
emaste added inline comments to D14220: ld.lld.1: document the rest of the -z options.
Tue, Feb 6, 8:44 PM
emaste updated the diff for D14220: ld.lld.1: document the rest of the -z options.

improvements from kib

Tue, Feb 6, 8:43 PM
emaste updated the diff for D14228: bsd.linker.mk: add retpolineplt linker feature.

Include COMPILER_FEATURES

Tue, Feb 6, 8:18 PM
emaste created D14228: bsd.linker.mk: add retpolineplt linker feature.
Tue, Feb 6, 8:09 PM
emaste added inline comments to D14220: ld.lld.1: document the rest of the -z options.
Tue, Feb 6, 7:14 PM
emaste updated subscribers of D14220: ld.lld.1: document the rest of the -z options.
Tue, Feb 6, 5:24 PM
emaste created D14220: ld.lld.1: document the rest of the -z options.
Tue, Feb 6, 4:12 AM