Page MenuHomeFreeBSD

emaste (Ed Maste)
UserAdministrator

Projects (8)

User Details

User Since
Nov 24 2013, 3:15 AM (299 w, 1 d)
Roles
Administrator

Recent Activity

Yesterday

emaste added inline comments to D16438: makefs: add msdosfs support.
Mon, Aug 19, 9:40 PM
emaste closed D21316: Expand description of image-size in makefs(8).
Mon, Aug 19, 9:38 PM
emaste committed rS351232: makefs.8: expand description of image size.
makefs.8: expand description of image size
Mon, Aug 19, 9:38 PM
emaste added inline comments to D21316: Expand description of image-size in makefs(8).
Mon, Aug 19, 9:37 PM
emaste committed rS351230: makefs.8: style updates from igor.
makefs.8: style updates from igor
Mon, Aug 19, 9:21 PM
emaste added a comment to D16438: makefs: add msdosfs support.

rebase

Mon, Aug 19, 9:03 PM
emaste committed rD53310: Rework advisory "Perform one of the following" text.
Rework advisory "Perform one of the following" text
Mon, Aug 19, 7:11 PM

Fri, Aug 16

D20562: The efifat files are no longer used: remove the code to build them. now requires changes to proceed.

This change is not valid, it removes the templates but leaves the Makefile rules in place to install them.

Fri, Aug 16, 8:54 PM
emaste added a comment to D21295: Rework r339635 to fix .depend.tables.h handling..

LGTM other than the minor comments inline

Fri, Aug 16, 8:45 PM
emaste added inline comments to D21295: Rework r339635 to fix .depend.tables.h handling..
Fri, Aug 16, 8:19 PM
emaste added inline comments to D21295: Rework r339635 to fix .depend.tables.h handling..
Fri, Aug 16, 8:18 PM
emaste abandoned D21069: libsysdecode: automate tables.h dependency generation.
Fri, Aug 16, 8:16 PM
emaste added inline comments to D21295: Rework r339635 to fix .depend.tables.h handling..
Fri, Aug 16, 8:15 PM
emaste added inline comments to D16438: makefs: add msdosfs support.
Fri, Aug 16, 7:41 PM
emaste added a comment to D14363: Install llvm-cov also as gcov, if no GNU gcov.

rS340289 / D17923

Fri, Aug 16, 7:31 PM
emaste closed D8133: abort in srandomdev if kern.arandom sysctl fails.
Fri, Aug 16, 6:58 PM
emaste added a comment to D8133: abort in srandomdev if kern.arandom sysctl fails.

rS306708

Fri, Aug 16, 6:58 PM
D7897: bspatch: add integer overflow checks now requires review to proceed.

rebase, add inline as suggested by @delphij

Fri, Aug 16, 6:45 PM
emaste closed D20787: aarch64: make pmap_change_attr public like on other platforms.
Fri, Aug 16, 6:21 PM · arm64
emaste committed rS351131: aarch64: make pmap_change_attr public like on other platforms.
aarch64: make pmap_change_attr public like on other platforms
Fri, Aug 16, 6:21 PM
emaste added a comment to D21167: base llvm: Enable OpenMP on aarch64.

This is just another "upstream only considered Linux, we need to be included in the same way as Linux" case.

Fri, Aug 16, 4:38 PM · arm64
D18936: Remove the unused and unusable MDIOCLIST ioctl. is now accepted and ready to land.
Fri, Aug 16, 4:26 PM
emaste added a comment to D20974: Port sbsawdt (ARM SBSA generic watchdog) driver from NetBSD.

Can you show a diff of the NetBSD version to this? i.e. what you had to change in the port?
(I assume that we don't want to treat this as contrib code and will just adopt it.)

Fri, Aug 16, 4:13 PM · arm64
emaste updated subscribers of D21107: Capsicumize nm(1)..
Fri, Aug 16, 4:11 PM
emaste added inline comments to D21167: base llvm: Enable OpenMP on aarch64.
Fri, Aug 16, 4:10 PM · arm64
emaste added a comment to D21069: libsysdecode: automate tables.h dependency generation.

Wrap in .if !defined(_SKIP_BUILD)

Fri, Aug 16, 3:37 PM
emaste added inline comments to D21069: libsysdecode: automate tables.h dependency generation.
Fri, Aug 16, 3:33 PM
emaste committed rS351122: Add @generated tag to libc syscall asm wrappers.
Add @generated tag to libc syscall asm wrappers
Fri, Aug 16, 2:15 PM
emaste committed rS351121: arch.7: indicate expectation that arm (i.e., v5) will be removed before 13.0.
arch.7: indicate expectation that arm (i.e., v5) will be removed before 13.0
Fri, Aug 16, 2:06 PM
emaste committed rS351120: Regen src.conf.5 after r351027 (enable BSD_CRTBEGIN on powerpc).
Regen src.conf.5 after r351027 (enable BSD_CRTBEGIN on powerpc)
Fri, Aug 16, 1:50 PM
emaste added a comment to D21186: Convert ng_deflate to use new zlib..

(I've looked over the change other than the just update dictionary section so far)

Fri, Aug 16, 12:22 AM

Thu, Aug 15

emaste added a comment to D21060: Stop installing clang, clang++, and clang-cpp hardlinks in /usr/bin..

No objection from me

Thu, Aug 15, 7:48 PM
emaste updated subscribers of D18758: Refactor skein_block_asm.s to assemble with LLVM integrated assembler.
Thu, Aug 15, 7:30 PM
emaste added inline comments to D18758: Refactor skein_block_asm.s to assemble with LLVM integrated assembler.
Thu, Aug 15, 7:24 PM
emaste committed rS351097: gptzfsboot: remove CLANG_NO_IAS.
gptzfsboot: remove CLANG_NO_IAS
Thu, Aug 15, 6:43 PM
emaste closed D11115: Clang groks .codeNN; remove CLANG_NO_IAS from sys/boot/i386.
Thu, Aug 15, 6:43 PM
emaste added a comment to D11115: Clang groks .codeNN; remove CLANG_NO_IAS from sys/boot/i386.

As it turns out gptzfsboot is identical, whether GAS or IAS is used to assemble gptldr.S:

Thu, Aug 15, 6:39 PM
emaste added a comment to D11115: Clang groks .codeNN; remove CLANG_NO_IAS from sys/boot/i386.

all other boot components have been addressed; only gptzfsboot needs to be investigated now

Thu, Aug 15, 6:00 PM
emaste committed rS351096: stand: remove CLANG_NO_IAS from pxeldr.
stand: remove CLANG_NO_IAS from pxeldr
Thu, Aug 15, 5:59 PM
emaste added a comment to D11115: Clang groks .codeNN; remove CLANG_NO_IAS from sys/boot/i386.

rebase after committing boot2 and cdboot changes

Thu, Aug 15, 5:34 PM
emaste added a comment to D11115: Clang groks .codeNN; remove CLANG_NO_IAS from sys/boot/i386.

cdboot in rS351092

Thu, Aug 15, 5:32 PM
emaste committed rS351092: stand: remove CLANG_NO_IAS from cdboot.
stand: remove CLANG_NO_IAS from cdboot
Thu, Aug 15, 5:32 PM
emaste added a comment to D11115: Clang groks .codeNN; remove CLANG_NO_IAS from sys/boot/i386.

cdboot differences are a large number of addr32 prefixes and using nop nop for alignment rather than xchg %eax,%eax, so it is ok too

Thu, Aug 15, 3:24 PM
emaste added a comment to D11115: Clang groks .codeNN; remove CLANG_NO_IAS from sys/boot/i386.

Do we know if the differences are similar there as well?

Thu, Aug 15, 2:56 PM
emaste committed rS351073: stand: remove CLANG_NO_IAS from boot2.
stand: remove CLANG_NO_IAS from boot2
Thu, Aug 15, 2:54 PM
emaste added a comment to D11115: Clang groks .codeNN; remove CLANG_NO_IAS from sys/boot/i386.

rS351073 for boot2

Thu, Aug 15, 2:54 PM
emaste added a comment to D11115: Clang groks .codeNN; remove CLANG_NO_IAS from sys/boot/i386.

side by side comparison with the .o generated

Thu, Aug 15, 2:40 PM
emaste committed rS351070: telnet: remove 3rd clause from Berkeley copyrights.
telnet: remove 3rd clause from Berkeley copyrights
Thu, Aug 15, 1:28 PM
emaste committed rS351069: do not enable userland retpoline if not supported by compiler/linker.
do not enable userland retpoline if not supported by compiler/linker
Thu, Aug 15, 12:48 PM
emaste closed D21101: enable userland retpoline only if supported by compiler and linker.
Thu, Aug 15, 12:48 PM
emaste committed rS351063: arch.7: be explicit about the future for unmigrated GCC 4.2.1 archs.
arch.7: be explicit about the future for unmigrated GCC 4.2.1 archs
Thu, Aug 15, 2:15 AM

Wed, Aug 14

emaste committed rS351040: compiler-rt: enable __bswapsi2/__bswapdi2 for RISC-V.
compiler-rt: enable __bswapsi2/__bswapdi2 for RISC-V
Wed, Aug 14, 6:41 PM
emaste committed rS351037: arch.7: clarify that the table shows the default tool chain.
arch.7: clarify that the table shows the default tool chain
Wed, Aug 14, 5:18 PM
emaste committed rS351036: arch.7: add deprecation notice for GCC 4.2.1.
arch.7: add deprecation notice for GCC 4.2.1
Wed, Aug 14, 5:13 PM
emaste committed rS351035: arch.7: add tool chain table.
arch.7: add tool chain table
Wed, Aug 14, 5:04 PM
emaste committed rS351026: MFC r350497: ppp: correct echo-req magic number on big endian archs.
MFC r350497: ppp: correct echo-req magic number on big endian archs
Wed, Aug 14, 1:15 PM
emaste committed rS351025: MFC r350497: ppp: correct echo-req magic number on big endian archs.
MFC r350497: ppp: correct echo-req magic number on big endian archs
Wed, Aug 14, 1:14 PM

Tue, Aug 13

emaste committed rS351000: sys/{x86,amd64}: remove one of doubled ;s.
sys/{x86,amd64}: remove one of doubled ;s
Tue, Aug 13, 7:39 PM
emaste added a comment to D21110: fusefs: merge from projects/fuse2.

Submitted as r350665. I don't know why Phabricator didn't close the revision automatically.

Tue, Aug 13, 4:50 PM
emaste committed rD53305: advisory-template: add shutdown command to template.
advisory-template: add shutdown command to template
Tue, Aug 13, 4:49 PM
emaste committed rS350989: Remove some more leftover rlogin man page xrefs.
Remove some more leftover rlogin man page xrefs
Tue, Aug 13, 3:41 PM
emaste committed rS350983: crunch: remove rsh and rlogin from example config file.
crunch: remove rsh and rlogin from example config file
Tue, Aug 13, 3:23 PM
emaste committed rS350981: Regen src.conf.5 after r350980 (remove rsh/rlogin references).
Regen src.conf.5 after r350980 (remove rsh/rlogin references)
Tue, Aug 13, 2:57 PM
emaste committed rS350980: Remove rlogin/rsh references from src.conf(5) WITHOUT_BLACKLIST_SUPPORT.
Remove rlogin/rsh references from src.conf(5) WITHOUT_BLACKLIST_SUPPORT
Tue, Aug 13, 2:51 PM
emaste committed rS350979: Remove rsh/rlogin references from security man page.
Remove rsh/rlogin references from security man page
Tue, Aug 13, 2:47 PM

Mon, Aug 12

emaste accepted D21208: Floppy driver really only works on x86.
Mon, Aug 12, 5:26 PM
emaste committed rS350903: nandfs: avoid integer overflow in nandfs_get_dat_bdescs_ioctl.
nandfs: avoid integer overflow in nandfs_get_dat_bdescs_ioctl
Mon, Aug 12, 5:25 PM
emaste closed D21232: nandfs: avoid integer overflow in nandfs_get_dat_bdescs_ioctl.
Mon, Aug 12, 5:25 PM
emaste added a comment to D21232: nandfs: avoid integer overflow in nandfs_get_dat_bdescs_ioctl.
In D21232#461469, @imp wrote:

These are fine but (a) you need to have mount privs to execute this ioctl; (b) nandfs is a panic trap due to bad locking and the system can't stay up once there's any vnode pressure at all; and (c) the set of nandfs users is the empty set due to (b). This is not exploitable in any meaningful way.

Mon, Aug 12, 5:13 PM
emaste created D21232: nandfs: avoid integer overflow in nandfs_get_dat_bdescs_ioctl.
Mon, Aug 12, 4:56 PM
emaste added a comment to D21230: Force ports depending on a fetch target to actually run checksum..

Seems reasonable to me. I might expand the comment slightly to "prevents a MITM attack on the dependency."

Mon, Aug 12, 4:28 PM
emaste committed rS350901: MFC r350498: telnet: use asprintf for r350140 [MFC of r349890] change.
MFC r350498: telnet: use asprintf for r350140 [MFC of r349890] change
Mon, Aug 12, 3:55 PM
emaste committed rS350900: MFC r350498: telnet: use asprintf for r350139 [MFC of r349890] change.
MFC r350498: telnet: use asprintf for r350139 [MFC of r349890] change
Mon, Aug 12, 3:52 PM

Thu, Aug 8

emaste added a comment to D21018: tests/sys/opencrypto: enable armv8crypto.

@ngie will you commit this?

Thu, Aug 8, 8:09 PM · arm64
emaste committed rS350750: armv8crypto: add missing unlock for session (after r336439).
armv8crypto: add missing unlock for session (after r336439)
Thu, Aug 8, 2:35 PM
emaste closed D21012: armv8crypto: add missing unlock for session (fix "sleeping thread owns a non-sleepable lock").
Thu, Aug 8, 2:35 PM · arm64
emaste added a comment to D21012: armv8crypto: add missing unlock for session (fix "sleeping thread owns a non-sleepable lock").

Looks like this was broken in rS336439

Thu, Aug 8, 2:31 PM · arm64

Tue, Aug 6

emaste committed rS350650: MFC r350645: Correct ICMPv6/MLDv2 out-of-bounds memory access.
MFC r350645: Correct ICMPv6/MLDv2 out-of-bounds memory access
Tue, Aug 6, 5:15 PM
emaste committed rS350648: MFC r350645: Correct ICMPv6/MLDv2 out-of-bounds memory access.
MFC r350645: Correct ICMPv6/MLDv2 out-of-bounds memory access
Tue, Aug 6, 5:13 PM
emaste committed rS350645: Correct ICMPv6/MLDv2 out-of-bounds memory access.
Correct ICMPv6/MLDv2 out-of-bounds memory access
Tue, Aug 6, 5:11 PM
emaste committed rS350638: MFC r350635: bsnmp: add asn1 message length validation.
MFC r350635: bsnmp: add asn1 message length validation
Tue, Aug 6, 4:13 PM
emaste committed rS350637: MFC r350635: bsnmp: add asn1 message length validation.
MFC r350635: bsnmp: add asn1 message length validation
Tue, Aug 6, 4:11 PM
emaste committed rS350635: bsnmp: add asn1 message length validation.
bsnmp: add asn1 message length validation
Tue, Aug 6, 4:09 PM

Sun, Aug 4

emaste committed rS350574: MFC r350518: as: add deprecation notice to the man page.
MFC r350518: as: add deprecation notice to the man page
Sun, Aug 4, 8:40 PM
emaste committed rS350565: objdump: update deprecation notice.
objdump: update deprecation notice
Sun, Aug 4, 1:18 AM

Thu, Aug 1

emaste committed rS350518: as: add deprecation notice to the man page.
as: add deprecation notice to the man page
Thu, Aug 1, 7:01 PM
emaste updated subscribers of D18758: Refactor skein_block_asm.s to assemble with LLVM integrated assembler.
Thu, Aug 1, 6:06 PM
emaste added a comment to D11520: monthly.cgi: add warning about using chrome.

We're no longer using monthly.cgi

Thu, Aug 1, 6:04 PM
emaste committed rS350511: readelf: decode NT_GNU_PROPERTY_TYPE_0 / GNU_PROPERTY_X86_FEATURE_1_AND.
readelf: decode NT_GNU_PROPERTY_TYPE_0 / GNU_PROPERTY_X86_FEATURE_1_AND
Thu, Aug 1, 6:00 PM
emaste closed D20516: readelf: decode NT_GNU_PROPERTY_TYPE_0 / GNU_PROPERTY_X86_FEATURE_1_AND.
Thu, Aug 1, 6:00 PM
emaste updated subscribers of D20516: readelf: decode NT_GNU_PROPERTY_TYPE_0 / GNU_PROPERTY_X86_FEATURE_1_AND.
Thu, Aug 1, 5:59 PM
D20895: Flip REPRODUCIBLE_BUILD back to off by default in head. is now accepted and ready to land.

No objection. Please make sure that the releng documentation gets updated to make sure it gets turned back on again (either when making the stable branch or the release branch)

Thu, Aug 1, 5:54 PM
emaste committed rS350506: remove obsolete kernel debugging script.
remove obsolete kernel debugging script
Thu, Aug 1, 5:03 PM
emaste added a comment to D21037: linuxpki: correct is_{zero,broadcast}_ether_addr.

They are indeed not broken which is why I originally abandoned the review, but reopened it based on cem's feedback - as written there's some opportunity for confusion.

Thu, Aug 1, 3:32 PM
emaste committed rS350505: objdump: be explicit that GNU objdump that will be removed.
objdump: be explicit that GNU objdump that will be removed
Thu, Aug 1, 2:43 PM
emaste committed rS350503: objdump: move deprecation notice to indended spot in the man page.
objdump: move deprecation notice to indended spot in the man page
Thu, Aug 1, 2:39 PM
emaste committed rS350500: newvers: append commit count to uname version string.
newvers: append commit count to uname version string
Thu, Aug 1, 2:13 PM
emaste closed D20462: newvers: append commit count to uname version string.
Thu, Aug 1, 2:13 PM
emaste committed rS350499: acpi_resource.c: mention ThunderX2 firmware revision with issue.
acpi_resource.c: mention ThunderX2 firmware revision with issue
Thu, Aug 1, 2:03 PM
emaste committed rS350498: telnet: use asprintf for r349890 change.
telnet: use asprintf for r349890 change
Thu, Aug 1, 1:46 PM