User Details
- User Since
- Nov 24 2013, 3:15 AM (561 w, 6 d)
- Roles
- Administrator
Thu, Aug 29
Wed, Aug 28
Tue, Aug 27
Huh, No XENIX semaphores available. But OK
typo in commit message: "just to e done"
What if V_connect_inaddr_wild is true but also CK_STAILQ_EMPTY(&V_in_ifaddrhead)?
I guess ENETUNREACH is sensible in that case as well.
Mon, Aug 26
Sun, Aug 25
This happens to clean up a BSD-2-Clause-FreeBSD too
Wed, Aug 21
Tue, Aug 20
hw.dmar.enable defaults to 0 again as of 0875f3cd74b2f305e82bff4e640c89f891ca84f8, and this note in UPDATING can be removed.
Referenced in PR280817
Yeah I see no reason to avoid it.
Mon, Aug 19
|| : seems unnecessarily clever to me, IMO || true is more obvious
but what error are we trying to ignore here anyway?
Sat, Aug 17
Thu, Aug 15
It might be better to keep the move & rewrite as separate commits so it's clear to git that it's the same file (rather than inferring this from delete + new file that are similar); if you do keep them separate I don't have a strong opinion on move-then-edit or edit-then-move.
Probably need an ObsoleteFiles.inc update as well.
I guess this is technically also Fixes: cb00491fbc51 as this moves it back to what it used to be in sound/midi.c
Commit message should include some more detail (e.g. explain that it's not really OSS) and will need an ObsoleteFiles.inc update for the now-removed ossmidi.h.
Wed, Aug 14
Tue, Aug 13
This didn't get noted anywhere :(
Followed up with a reply to the commit mail
Thanks for the review everyone, released as https://www.freebsd.org/security/advisories/FreeBSD-EN-23:16.openzfs.asc
Alexander Ziaee included some of this in ad57cea9e633cac5ef3f17ce0a82160bc32d7f63
It seems I forgot about this review and did it again in D46015
Mon, Aug 12
Sun, Aug 11
LGTM other than the whitespace consistency with the other lines
OK as a workaround but we ought to report this upstream
Fri, Aug 9
sound: Stop checking for failures from malloc(M_WAITOK) LGTM
I also wonder about the name for this utility - ISTM audio(8) is too generic. If it has (will grow to have) features like @dev_submerge.ch mentions maybe audioctl(8)?
Thu, Aug 8
Wed, Aug 7
Tue, Aug 6
looks reasonable to me