Page MenuHomeFreeBSD

emaste (Ed Maste)
UserAdministrator

Projects (20)

User Details

User Since
Nov 24 2013, 3:15 AM (677 w, 3 d)
Roles
Administrator

Recent Activity

Today

emaste added a comment to D61513: nuageinit: Split pw line on :s.

@dtxdf should be fine now, if you can take another look

Wed, Nov 18, 3:45 PM

Yesterday

emaste added a comment to D61522: kern.mk: Remove special case for Clang < 16.

FWIW this was prompted by llm-postcr complaining about possible compiler version incompatibility in cb1627e40d5c0c21f2f7d13e848cf6495390e777 which added -mindirect-branch-cs-prefix. Because the kernel does not build with Clang < 16 anyway I did not bother adding a version or COMPILER_FEATURES test.

Tue, Nov 17, 7:25 PM
emaste added a comment to D61522: kern.mk: Remove special case for Clang < 16.

With CROSS_TOOLCHAIN=llvm15 the build fails in libunwind

In file included from /root/freebsd/contrib/llvm-project/libunwind/src/libunwind.cpp:14:
In file included from /root/freebsd/contrib/llvm-project/libunwind/src/config.h:19:
In file included from /usr/obj/root/freebsd/amd64.amd64/tmp/usr/include/c++/v1/stdlib.h:109:
In file included from /usr/obj/root/freebsd/amd64.amd64/tmp/usr/include/c++/v1/__math/abs.h:14:
In file included from /usr/obj/root/freebsd/amd64.amd64/tmp/usr/include/c++/v1/__type_traits/is_integral.h:14:
/usr/obj/root/freebsd/amd64.amd64/tmp/usr/include/c++/v1/__type_traits/remove_cv.h:22:32: error: unknown type name '__remove_cv'; did you mean 'remove_cv'?
  using type _LIBCPP_NODEBUG = __remove_cv(_Tp);
                               ^
Tue, Nov 17, 7:17 PM
emaste added inline comments to D61675: syscalls.master: Add a capsicum note about sync(2).
Tue, Nov 17, 5:11 PM
emaste requested review of D61675: syscalls.master: Add a capsicum note about sync(2).
Tue, Nov 17, 3:36 PM
emaste updated subscribers of D61266: bhyve: fix snapshot IPC handling.
Tue, Nov 17, 3:23 PM
emaste updated subscribers of D61163: bhyve: validate configuration options.
Tue, Nov 17, 3:23 PM

Mon, Nov 16

emaste accepted D61624: usbdevs: Add HumanWare BrailleNote Apex IDs.
Mon, Nov 16, 2:45 PM · Accessibility
emaste added inline comments to D61513: nuageinit: Split pw line on :s.
Mon, Nov 16, 1:48 PM
emaste added a comment to D61513: nuageinit: Split pw line on :s.

Thanks, this works with mdo -- but so very convoluted.

Mon, Nov 16, 1:16 AM
emaste updated the diff for D61513: nuageinit: Split pw line on :s.

Reset pw before reusing for underscore_ user

Mon, Nov 16, 1:15 AM
emaste committed rGb3b73816f531: nuageinit: Skip ssh keys if default user adduser fails.
Mon, Nov 16, 12:50 AM
emaste closed D61511: nuageinit: Skip ssh keys if default user adduser fails.
Mon, Nov 16, 12:50 AM
emaste added a comment to D61513: nuageinit: Split pw line on :s.

If I run the test directly it passes:

emaste@framework:~/src/freebsd-src/wipbsd $ /usr/libexec/flua /usr/obj/home/emaste/src/freebsd-src/wipbsd/amd64.amd64/libexec/nuageinit/tests/checkdir/usr/tests/libexec/nuageinit/adduser.lua 
nuageinit: Argument should be a table
nuageinit: Argument should be a table
emaste@framework:~/src/freebsd-src/wipbsd $ echo $?
0
Mon, Nov 16, 12:48 AM

Sat, Nov 14

emaste updated the diff for D61522: kern.mk: Remove special case for Clang < 16.

ELFv2 also

Sat, Nov 14, 3:46 AM

Fri, Nov 13

emaste added inline comments to D61522: kern.mk: Remove special case for Clang < 16.
Fri, Nov 13, 10:06 PM
emaste updated subscribers of D61522: kern.mk: Remove special case for Clang < 16.
Fri, Nov 13, 10:06 PM
emaste requested review of D61522: kern.mk: Remove special case for Clang < 16.
Fri, Nov 13, 10:05 PM
emaste committed rGcb1627e40d5c: kernel: Add -mindirect-branch-cs-prefix for WITH_KERNEL_RETPOLINE.
Fri, Nov 13, 9:19 PM
emaste closed D61514: kernel: Add -mindirect-branch-cs-prefix for WITH_KERNEL_RETPOLINE.
Fri, Nov 13, 9:19 PM
emaste committed rG7fca9094d86c: if_media: Add 100BASE-T1 and 1000BASE-T1 media types.
Fri, Nov 13, 9:16 PM
emaste updated the diff for D61513: nuageinit: Split pw line on :s.

Add a test

Fri, Nov 13, 5:46 PM
emaste requested review of D61514: kernel: Add -mindirect-branch-cs-prefix for WITH_KERNEL_RETPOLINE.
Fri, Nov 13, 4:55 PM
emaste requested review of D61513: nuageinit: Split pw line on :s.
Fri, Nov 13, 4:42 PM
emaste requested review of D61511: nuageinit: Skip ssh keys if default user adduser fails.
Fri, Nov 13, 4:15 PM
emaste closed D61158: ure: Initialize ifm_active in ure_ifmedia_sts.
Fri, Nov 13, 4:06 PM
emaste committed rG83067a22396f: ure: Initialize ifm_active in ure_ifmedia_sts.
Fri, Nov 13, 4:06 PM
emaste closed D61441: nuageinit; Skip SSH keys and doas/sudo if adduser fails.
Fri, Nov 13, 3:55 PM
emaste committed rGd9fa6016011e: nuageinit; Skip SSH keys and doas/sudo if adduser fails.
Fri, Nov 13, 3:55 PM
emaste closed D61412: sched_*(2), rtprio*(2): Add capability mode checks.
Fri, Nov 13, 3:52 PM
emaste committed rG1947932d6f4f: capsicum: Add tests for sched_* and rtprio* (authored by ojanerif_amd.com).
Fri, Nov 13, 3:52 PM
emaste closed D61469: clock_gettime: Add capability mode check.
Fri, Nov 13, 3:01 PM
emaste committed rG973698a330c3: clock_gettime: Add capability mode check.
Fri, Nov 13, 3:01 PM
emaste closed D61269: lan867xphy: Add silicon rev D0 configuration.
Fri, Nov 13, 2:25 PM
emaste committed rG57e8eddc52b9: lan867xphy: Add silicon rev D0 configuration.
Fri, Nov 13, 2:25 PM

Thu, Nov 12

emaste added a comment to D61469: clock_gettime: Add capability mode check.

I'm not sure if we're supposed to guard these checks with #ifdef CAPABILITY_MODE.

Thu, Nov 12, 7:55 PM
emaste closed D61268: lan867xphy: Add silicon rev C2 configuration.
Thu, Nov 12, 6:58 PM
emaste committed rGf3ec447a1c06: lan867xphy: Add silicon rev C2 configuration.
Thu, Nov 12, 6:58 PM
emaste committed rG0a8d25e0ae34: aq(4): arm PHY thermal shutdown from the admin poll (authored by nprice).
Thu, Nov 12, 4:07 PM
emaste requested review of D61469: clock_gettime: Add capability mode check.
Thu, Nov 12, 3:56 PM
emaste added a comment to D61412: sched_*(2), rtprio*(2): Add capability mode checks.

Thanks, I have landed D57346, D57385, and the rtprio* addition from this review (9b6ea599c955cfdffac0a5e0204f57a72e6f7cda), and will land the tests soon.

Thu, Nov 12, 3:20 PM
emaste abandoned D57348: rtprio(_thread): Add capability mode checks.

Portion of D61412 committed as 9b6ea599c955cfdffac0a5e0204f57a72e6f7cda

Thu, Nov 12, 3:18 PM
emaste closed D57385: getpgid,getsid: Add capability mode checks.
Thu, Nov 12, 3:16 PM
emaste committed rG93f78e8fb89a: getpgid,getsid: Add capability mode checks.
Thu, Nov 12, 3:15 PM
emaste committed rG9b6ea599c955: rtprio*: Add capability mode checks (authored by ojanerif_amd.com).
Thu, Nov 12, 3:13 PM

Wed, Nov 11

emaste committed rG55ede03fc24a: ssh: use defaultkey sentinel for ML-DSA-44 default host key (authored by ojanerif_amd.com).
Wed, Nov 11, 9:41 PM
emaste committed rGbb3fe4a04aff: rc: Generate ML-DSA44/Ed25519 host keys by default (authored by jlduran).
Wed, Nov 11, 9:12 PM
emaste committed rG8ffa19f39a72: OpenSSH: Update to 10.6p2.
Wed, Nov 11, 9:12 PM
emaste committed rG1135d4e15933: OpenSSH: Update to 10.6p1.
Wed, Nov 11, 9:11 PM
emaste committed rG9dcb032aaeb0: OpenSSH: Update to 10.5p1.
Wed, Nov 11, 9:11 PM
emaste accepted D61435: periodic: Fix empty output check.
Wed, Nov 11, 5:50 PM
emaste accepted D61435: periodic: Fix empty output check.
Wed, Nov 11, 4:51 PM
emaste added a comment to D59883: linuxkpi: lkpi_vmf_insert_special_pte_locked().

Since you are saying that only GPU hangs, it should be possible to access machine though a network.

Wed, Nov 11, 4:41 PM
emaste added a comment to D59883: linuxkpi: lkpi_vmf_insert_special_pte_locked().

Yes I have patched drm-kmod: https://github.com/emaste/drm-kmod/commit/b686b798555c4faf4d20673f167b6559ef841c6e
This is in my WIP tree which has many other changes; I can try to reproduce on just main + these patches later on.

Wed, Nov 11, 4:25 PM
emaste added a comment to D59883: linuxkpi: lkpi_vmf_insert_special_pte_locked().
In D59883#1408204, @kib wrote:

I am currently running this patch on my main laptop

You need to use swap to really test the patch, as in cause the machine to swap.

Wed, Nov 11, 4:15 PM
emaste requested review of D61441: nuageinit; Skip SSH keys and doas/sudo if adduser fails.
Wed, Nov 11, 3:56 PM
emaste committed rGeca5b28692ea: nuageinit: Add support for uid (authored by zenzesama_gmail.com).
Wed, Nov 11, 3:23 PM
emaste closed D61174: nuageinit: Add support for uid.
Wed, Nov 11, 3:23 PM
emaste closed D57346: p1003_1b: Add capability mode checks.
Wed, Nov 11, 3:14 PM
emaste committed rG70d08c69f4d0: p1003_1b: Add capability mode checks.
Wed, Nov 11, 3:14 PM
emaste added inline comments to D61435: periodic: Fix empty output check.
Wed, Nov 11, 3:12 PM
emaste accepted D61435: periodic: Fix empty output check.
Wed, Nov 11, 3:10 PM
emaste added a comment to D61433: rc: Generate ML-DSA44/Ed25519 host keys by default.

In case I'm AFK, would you mind including this commit in your MFC batch later today?

Wed, Nov 11, 2:58 PM
emaste added a comment to D61174: nuageinit: Add support for uid.

git-arc patch figures it out: Making best guess: Turning zenzesama_gmail.com to Kushagra Chauhan <zenzesama@gmail.com>

Wed, Nov 11, 2:49 PM
emaste accepted D61433: rc: Generate ML-DSA44/Ed25519 host keys by default.
Wed, Nov 11, 2:25 PM
emaste updated the diff for D57346: p1003_1b: Add capability mode checks.
Wed, Nov 11, 2:22 PM

Tue, Nov 10

emaste added a comment to D61412: sched_*(2), rtprio*(2): Add capability mode checks.

Some of these are already in D57346

Tue, Nov 10, 10:36 PM
emaste added a comment to D59883: linuxkpi: lkpi_vmf_insert_special_pte_locked().

I am currently running this patch on my main laptop

Tue, Nov 10, 10:13 PM
emaste committed rG6fcdc18bdfb1: OpenSSH: Update to 10.6p2.
Tue, Nov 10, 2:26 PM
emaste committed rG6dd16be872c6: OpenSSH: Update to 10.6p1.
Tue, Nov 10, 2:09 PM

Mon, Nov 9

emaste accepted D61347: kdump: Fix some cpp conditionals.

I've been guilty of this myself. I wonder if we should make the first one #if defined(__amd64__) as well, for consistency

Mon, Nov 9, 6:28 PM
emaste added a comment to D59172: openssh: Update to 10.5p1.

bd9d7cdd142073d2a83d2748df8781ee552f2336

Mon, Nov 9, 2:56 PM
emaste committed rGbd9d7cdd1420: OpenSSH: Update to 10.5p1.
Mon, Nov 9, 2:55 PM

Sun, Nov 8

emaste added a comment to D61325: ctfconvert: Demote lack of DWARF to a warning.

@des shared https://ci.freebsd.org/job/FreeBSD-main-amd64-gcc14_build/5142/console

02:57:24 --- exception.o ---
02:57:24 /workspace/src/sys/amd64/amd64/exception.S: Assembler messages:
02:57:24 /workspace/src/sys/amd64/amd64/exception.S:617: Warning: no instruction mne=
02:57:24 monic suffix given and no register operands; using default for `sysret'
02:57:24 ctfconvert -L VERSION -g exception.o
02:57:24 ERROR: ctfconvert: file does not contain dwarf type data (try compiling wit=
02:57:24 h -g)
02:57:24 *** [exception.o] Error code 1
02:57:24 
02:57:24 make[2]: stopped making "all" in /tmp/obj/workspace/src/amd64.amd64/sys/GEN=
02:57:24 ERIC
Sun, Nov 8, 7:33 PM
emaste requested review of D61325: ctfconvert: Demote lack of DWARF to a warning.
Sun, Nov 8, 6:41 PM
emaste accepted D61154: libdwarf: standard DWARF 5 form names, DW_LANG_C17 and C23.
Sun, Nov 8, 3:26 PM

Sat, Nov 7

emaste updated the diff for D61268: lan867xphy: Add silicon rev C2 configuration.

some cleanup, #defines instead of magic numbers etc.

Sat, Nov 7, 3:47 PM

Fri, Nov 6

emaste reopened D32540: iSCSI: Fast and per-session timeouts.
Fri, Nov 6, 11:22 PM
emaste updated the diff for D61269: lan867xphy: Add silicon rev D0 configuration.

Use helper from refactored C2 support, tidy up

Fri, Nov 6, 10:49 PM
emaste added reviewers for D61268: lan867xphy: Add silicon rev C2 configuration: jbo, kbowling, nprice.
Fri, Nov 6, 10:47 PM
emaste updated the diff for D61268: lan867xphy: Add silicon rev C2 configuration.

Some cleanup

Fri, Nov 6, 10:45 PM
emaste updated the diff for D61268: lan867xphy: Add silicon rev C2 configuration.

Add C1 to C2 case

Fri, Nov 6, 9:54 PM
emaste updated the diff for D61268: lan867xphy: Add silicon rev C2 configuration.
  • add const to config table
  • fix mask in lan867xphy_indirect_read
Fri, Nov 6, 8:04 PM
emaste requested review of D61269: lan867xphy: Add silicon rev D0 configuration.
Fri, Nov 6, 6:18 PM
emaste requested review of D61268: lan867xphy: Add silicon rev C2 configuration.
Fri, Nov 6, 6:17 PM
emaste committed rGaa5bef3e5025: Vendor import of OpenSSH 10.6p2.
Fri, Nov 6, 4:10 AM

Thu, Nov 5

emaste accepted D61210: linuxkpi: Add `str_true_false()` and `str_false_true()`.
Thu, Nov 5, 8:03 PM · linuxkpi
emaste accepted D61231: ctfconvert: Make the absence of debug info non-fatal.
Thu, Nov 5, 6:33 PM
emaste accepted D61200: linuxkpi: Define all constants in <linux/media-bus-format.h>.
Thu, Nov 5, 2:03 PM · linuxkpi

Wed, Nov 4

emaste accepted D61045: ioctl: Add a macro for extracting the ioctl number from a command.
Wed, Nov 4, 10:34 PM

Tue, Nov 3

emaste added inline comments to D61158: ure: Initialize ifm_active in ure_ifmedia_sts.
Tue, Nov 3, 7:15 PM
emaste added inline comments to D61161: netlink: Pre-register the missing devctl event systems.
Tue, Nov 3, 5:19 PM
emaste requested review of D61158: ure: Initialize ifm_active in ure_ifmedia_sts.
Tue, Nov 3, 3:46 PM

Mon, Nov 2

emaste added a comment to D61089: arm64: add virtio_console to std.virt.

Also please upload with full context (e.g. using -U999999).

Mon, Nov 2, 1:22 PM

Fri, Oct 30

emaste closed D61061: ure.4: Remove non-USB devices from HARDWARE.
Fri, Oct 30, 8:50 PM
emaste committed rG53dd6b7760d5: ure.4: Remove non-USB devices from HARDWARE.
Fri, Oct 30, 8:50 PM
emaste added a reviewer for D61061: ure.4: Remove non-USB devices from HARDWARE: kenrap_kennethraplee.com.
Fri, Oct 30, 8:11 PM
emaste requested review of D61061: ure.4: Remove non-USB devices from HARDWARE.
Fri, Oct 30, 8:11 PM
emaste committed rGeb0f28db1bfa: ure: Handle SIOCGIFXMEDIA.
Fri, Oct 30, 7:05 PM
emaste closed D61049: ure: Handle SIOCGIFXMEDIA.
Fri, Oct 30, 7:05 PM