Page MenuHomeFreeBSD

emaste (Ed Maste)
UserAdministrator

Projects (15)

User Details

User Since
Nov 24 2013, 3:15 AM (400 w, 2 d)
Roles
Administrator

Recent Activity

Yesterday

emaste committed R10:a077a4e3b41b: Cirrus-CI: report pkg version (authored by emaste).
Cirrus-CI: report pkg version
Mon, Jul 26, 6:19 PM
emaste requested review of D31309: committers-guide: Place Differential Revision last in table.
Mon, Jul 26, 5:00 PM
emaste committed R9:359f4a35ff35: committers-guide: add missing period (authored by emaste).
committers-guide: add missing period
Mon, Jul 26, 4:47 PM
emaste added a comment to D31154: make buildworld with time logging for each stage.

I have no objection

Mon, Jul 26, 4:34 PM
emaste committed R10:2bfba2a04b05: Cirrus-CI: Temporarily skip package build + test (authored by emaste).
Cirrus-CI: Temporarily skip package build + test
Mon, Jul 26, 3:38 PM
emaste accepted D31060: Add WITH_LLVM_BINUTILS to install LLVM binutils instead of Elftoolchain.

LGTM, we might have a few things to iterate on with this in the tree

Mon, Jul 26, 3:34 PM

Tue, Jul 20

emaste added a comment to D31251: linux: Fix declaration of rt_sigreturn().

I'm not sure where the argument got here in the first place.

Tue, Jul 20, 7:56 PM
emaste added inline comments to D31242: arm64: Print CPU features slightly earlier.
Tue, Jul 20, 4:45 PM

Mon, Jul 19

emaste committed R10:79e6eb5c018d: zfs: Remove zfs-images submodule (authored by emaste).
zfs: Remove zfs-images submodule
Mon, Jul 19, 8:42 PM
emaste added a comment to D31058: Only build {llvm,clang,lldb}-tblgen for the target with MK_CLANG_EXTRAS.

Fine with me, assuming these are built using a different mechanism for the build toolchain itself.

Mon, Jul 19, 1:36 PM

Fri, Jul 16

emaste updated subscribers of D31121: amd64 UEFI boot: stop copying staging area to 2M phys .
Fri, Jul 16, 1:40 PM
emaste accepted D31059: Don't default MK_LLVM_TARGET_ALL to yes unless MK_CLANG is requested.

LGTM, but give @dim a day or so to weigh in.

Fri, Jul 16, 2:39 AM
emaste added a comment to D28181: Remove mkcsmapper_static and mkesdb_static from build-tools.

No objection from me

Fri, Jul 16, 2:33 AM
emaste added a comment to D29917: BeFS support for fstyp command.

@trasz or @pstef will you shepherd this in?

Fri, Jul 16, 2:04 AM
emaste committed R10:feb1dc84d895: Skip netgraph tests when WITHOUT_NETGRAPH is set (authored by emaste).
Skip netgraph tests when WITHOUT_NETGRAPH is set
Fri, Jul 16, 12:41 AM

Thu, Jul 15

emaste requested review of D31192: memcpy.3: remove BUGS section allowing overlapping strings.
Thu, Jul 15, 2:12 PM
emaste accepted D31187: loader: make sure CPUTYPE is ignored when building.

Unfortunate that this convoluted method is required, but thanks for the clear comment explaining why it's that way.

Thu, Jul 15, 2:13 AM

Wed, Jul 14

emaste added a comment to D31179: Start to clean up arm64 address space selection.

Typo, "Tob Byte Ignore"

Wed, Jul 14, 3:56 PM

Tue, Jul 13

emaste committed R10:ae2e05423dff: Skip netgraph tests when WITHOUT_NETGRAPH is set (authored by emaste).
Skip netgraph tests when WITHOUT_NETGRAPH is set
Tue, Jul 13, 12:29 AM

Mon, Jul 12

emaste updated subscribers of D31154: make buildworld with time logging for each stage.

Would you be so kind as to show (snippets from) sample output with this change? I think having this sort of data available will be quite useful, just curious how it will look in practice.

Mon, Jul 12, 6:59 PM
emaste added inline comments to D31060: Add WITH_LLVM_BINUTILS to install LLVM binutils instead of Elftoolchain.
Mon, Jul 12, 12:33 AM

Sun, Jul 11

emaste committed R10:d004f3428f95: clang: stop linking _p libs for -pg as of FreeBSD 14 (authored by emaste).
clang: stop linking _p libs for -pg as of FreeBSD 14
Sun, Jul 11, 11:31 PM
emaste committed R10:2e96f2635591: clang: stop linking _p libs for -pg as of FreeBSD 14 (authored by emaste).
clang: stop linking _p libs for -pg as of FreeBSD 14
Sun, Jul 11, 11:30 PM

Thu, Jul 8

emaste added a reviewer for D31109: Add Power8 and Power9 PMCs: mhorne.
Thu, Jul 8, 12:54 PM

Wed, Jul 7

emaste accepted D31092: ObsoleteFiles.inc: Remove manpages from OLD_FILES.
Wed, Jul 7, 6:42 PM
emaste added inline comments to D31092: ObsoleteFiles.inc: Remove manpages from OLD_FILES.
Wed, Jul 7, 4:59 PM
emaste added inline comments to D31093: Update the arm64 HCR_EL2 registers.
Wed, Jul 7, 4:56 PM
emaste added a comment to D31091: linux(4): remove unfinished vsyscall bits on arm64.

Yes, a quick search suggests vsyscall was implemented only on 32- and 64-bit x86 Linux (and in Linuxulator, only 64-bit). And, sv_trap is used only in sys/amd64/amd64/trap.c.

Wed, Jul 7, 3:17 PM
emaste accepted D31091: linux(4): remove unfinished vsyscall bits on arm64.
Wed, Jul 7, 3:13 PM
emaste committed R10:c3e6df3967f9: Add deprecation notice for WITH_PROFILE option (authored by emaste).
Add deprecation notice for WITH_PROFILE option
Wed, Jul 7, 1:20 PM
emaste committed R10:9e06b34bb5d3: Add deprecation notice for WITH_PROFILE option (authored by emaste).
Add deprecation notice for WITH_PROFILE option
Wed, Jul 7, 1:19 PM

Tue, Jul 6

emaste added a comment to D31057: Allow bootstrapping llvm-tblgen on macOS and Linux.

Looks OK to me but will defer to @dim for questions about maintainability / expected impact on future clang/llvm updates

Tue, Jul 6, 6:40 PM
emaste added inline comments to D31043: Add build system support for ASAN+UBSAN instrumentation.
Tue, Jul 6, 6:33 PM
emaste closed D31079: handbook: OpenSSH no longer supports protocol v1.
Tue, Jul 6, 6:23 PM
emaste committed R9:b45dd6398ac6: handbook: OpenSSH no longer supports protocol v1 (authored by emaste).
handbook: OpenSSH no longer supports protocol v1
Tue, Jul 6, 6:23 PM
emaste updated the diff for D31079: handbook: OpenSSH no longer supports protocol v1.

Drop "By default"

Tue, Jul 6, 5:34 PM
emaste added inline comments to D31079: handbook: OpenSSH no longer supports protocol v1.
Tue, Jul 6, 5:33 PM
emaste requested review of D31079: handbook: OpenSSH no longer supports protocol v1.
Tue, Jul 6, 5:33 PM
emaste committed R10:c9144ec14d2a: Skip netgraph tests when WITHOUT_NETGRAPH is set (authored by emaste).
Skip netgraph tests when WITHOUT_NETGRAPH is set
Tue, Jul 6, 1:47 PM

Mon, Jul 5

emaste added inline comments to D31040: Add missing dep patterns for .pieo and .nosspico.
Mon, Jul 5, 1:09 PM
emaste added inline comments to D31043: Add build system support for ASAN+UBSAN instrumentation.
Mon, Jul 5, 1:07 PM

Fri, Jul 2

emaste added a comment to D30984: man(1): Add full search (-K) flag.

Unlike the Linux version

Fri, Jul 2, 4:46 PM

Thu, Jul 1

emaste added inline comments to D30979: LinuxKPI: add sign_extend32().
Thu, Jul 1, 4:25 PM
emaste accepted D30979: LinuxKPI: add sign_extend32().
Thu, Jul 1, 3:26 PM

Wed, Jun 30

emaste added a comment to D30965: Import AMD Zen 3 PMU events.

I will commit this shortly if nobody beats me to it.

Wed, Jun 30, 7:45 PM
emaste updated subscribers of D30965: Import AMD Zen 3 PMU events.
Wed, Jun 30, 5:30 PM

Tue, Jun 29

emaste added inline comments to D30104: efirt: add ESRT table support.
Tue, Jun 29, 5:25 PM
emaste committed R10:47722575d948: mkimg: Add fat32lba partition type (authored by jlduran_gmail.com).
mkimg: Add fat32lba partition type
Tue, Jun 29, 2:03 PM

Mon, Jun 28

emaste committed R10:f94360971e64: Clarify notice for profiled libraries in FreeBSD 14 (authored by emaste).
Clarify notice for profiled libraries in FreeBSD 14
Mon, Jun 28, 11:26 PM
emaste added a comment to D30833: Enable WITHOUT_PROFILE by default.

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=256874 submitted for the GCC change

Mon, Jun 28, 7:49 PM
emaste accepted D30928: LinuxKPI: Rename a short description of kmalloc type..
Mon, Jun 28, 6:06 PM
emaste accepted D30927: LinuxKPI: Put compat code under appropriate condition..

Roll this into D30924?

Mon, Jun 28, 5:52 PM
emaste added a comment to D30833: Enable WITHOUT_PROFILE by default.

exp-run requested for good measure: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=256873
will commit after that's finished

Mon, Jun 28, 3:55 PM
emaste committed R10:175841285e28: Add deprecation notice for WITH_PROFILE option (authored by emaste).
Add deprecation notice for WITH_PROFILE option
Mon, Jun 28, 3:38 PM

Sun, Jun 27

emaste committed R10:914b6a0122c3: src.conf.5: regen after RISC-V OPENMP (aa033e0b14f2) (authored by emaste).
src.conf.5: regen after RISC-V OPENMP (aa033e0b14f2)
Sun, Jun 27, 5:31 PM
emaste committed R10:b762974cf4b9: clang: stop linking _p libs for -pg as of FreeBSD 14 (authored by emaste).
clang: stop linking _p libs for -pg as of FreeBSD 14
Sun, Jun 27, 5:13 PM
emaste closed D30861: Clang: stop linking _p libs for -pg as of FreeBSD 14.
Sun, Jun 27, 5:13 PM

Jun 26 2021

emaste closed D30907: CI: add arm64 support to ci-qemu-test.sh.
Jun 26 2021, 8:16 PM
emaste committed R10:bba96bb143bb: CI: add arm64 support to ci-qemu-test.sh (authored by emaste).
CI: add arm64 support to ci-qemu-test.sh
Jun 26 2021, 8:16 PM
emaste committed R10:7d9794b34bcd: CI: use amd64 EDK II firmware included with QEMU (authored by emaste).
CI: use amd64 EDK II firmware included with QEMU
Jun 26 2021, 6:24 PM
emaste closed D30915: CI: use amd64 EDK II firmware included with QEMU.
Jun 26 2021, 6:23 PM
emaste added inline comments to D30907: CI: add arm64 support to ci-qemu-test.sh.
Jun 26 2021, 4:56 PM
emaste requested review of D30915: CI: use amd64 EDK II firmware included with QEMU.
Jun 26 2021, 4:51 PM

Jun 25 2021

emaste added inline comments to D30900: linux(4); Almost complete the vDSO..
Jun 25 2021, 9:39 PM
emaste added inline comments to D30907: CI: add arm64 support to ci-qemu-test.sh.
Jun 25 2021, 9:04 PM
emaste requested review of D30907: CI: add arm64 support to ci-qemu-test.sh.
Jun 25 2021, 8:22 PM
emaste accepted D30904: linux(4): Add arch name to the some printfs..
Jun 25 2021, 7:06 PM
emaste added a comment to D30900: linux(4); Almost complete the vDSO..

ifunc can't be used

Jun 25 2021, 4:18 PM
emaste accepted D30901: linux(4): Constify vdso install/deinstall..
Jun 25 2021, 4:14 PM
emaste added a comment to D30903: linprocfs: Fixup vDSO name in the procmaps..

process VA layout has changed

Jun 25 2021, 4:14 PM
emaste added inline comments to D30904: linux(4): Add arch name to the some printfs..
Jun 25 2021, 4:12 PM
emaste added inline comments to D30902: linux(4): Fixup the vDSO initialization order..
Jun 25 2021, 4:09 PM

Jun 22 2021

emaste accepted D30831: genet: pullup minimum header amount for IPv4.
Jun 22 2021, 11:05 PM
emaste added a comment to D30861: Clang: stop linking _p libs for -pg as of FreeBSD 14.

Upstream review at https://reviews.llvm.org/D104753

Jun 22 2021, 9:44 PM
emaste added a comment to D30622: fusefs: correctly set lock owner during FUSE_SETLK.

Hrm, it seems I had an inline comment that was never submitted.

Jun 22 2021, 8:52 PM
emaste added a comment to D30831: genet: pullup minimum header amount for IPv4.

LGTM

Jun 22 2021, 1:42 AM
emaste committed R10:d98a4eb807e9: mkimg: Add fat32lba partition type (authored by jlduran_gmail.com).
mkimg: Add fat32lba partition type
Jun 22 2021, 1:07 AM
emaste updated the diff for D30861: Clang: stop linking _p libs for -pg as of FreeBSD 14.

Fix getTriple() in freebsd::Linker::ConstructJob()

Jun 22 2021, 12:50 AM

Jun 21 2021

emaste updated the diff for D30861: Clang: stop linking _p libs for -pg as of FreeBSD 14.

Restore missing {

Jun 21 2021, 11:23 PM
emaste added a comment to D30833: Enable WITHOUT_PROFILE by default.

Created D30861 to have Clang stop linking against _p libraries with -pg for FreeBSD 14 and up. We'll need a similar change for GCC.

Jun 21 2021, 9:53 PM
emaste requested review of D30861: Clang: stop linking _p libs for -pg as of FreeBSD 14.
Jun 21 2021, 9:52 PM
emaste added a comment to D30833: Enable WITHOUT_PROFILE by default.

You'd be better off testing on i386 than amd64 I imagine.

Jun 21 2021, 9:13 PM
emaste added inline comments to D30831: genet: pullup minimum header amount for IPv4.
Jun 21 2021, 3:56 PM
emaste added a comment to D30833: Enable WITHOUT_PROFILE by default.

I tried a quick sanity check of -pg on my ~ FreeBSD 13.0 amd64 laptop, without success:

Jun 21 2021, 3:18 PM

Jun 20 2021

emaste added a comment to D30833: Enable WITHOUT_PROFILE by default.

Cirrus-CI runs
main: https://cirrus-ci.com/task/4988055556718592
28:46 build time
11886 du -m -s /usr/obj

Jun 20 2021, 8:49 PM
emaste requested review of D30833: Enable WITHOUT_PROFILE by default.
Jun 20 2021, 7:13 PM
emaste added inline comments to D30815: hz.9: update stathz for current usage.
Jun 20 2021, 4:18 PM
emaste added inline comments to D30815: hz.9: update stathz for current usage.
Jun 20 2021, 3:50 PM

Jun 19 2021

emaste added a comment to D22012: Import dhcpcd(8) version 8.1.0 into FreeBSD base..

ISC DHCP client/relay end of maintenance:

Jun 19 2021, 2:37 PM
emaste accepted D30809: LinuxKPI: Do not wait for a grace period in rcu_barrier().
Jun 19 2021, 12:00 AM

Jun 18 2021

emaste added inline comments to D30815: hz.9: update stathz for current usage.
Jun 18 2021, 8:42 PM
emaste added inline comments to D30815: hz.9: update stathz for current usage.
Jun 18 2021, 7:19 PM
emaste added a member for Contributor Reviews (base): emaste.
Jun 18 2021, 1:24 PM
emaste added inline comments to D30809: LinuxKPI: Do not wait for a grace period in rcu_barrier().
Jun 18 2021, 1:01 AM

Jun 16 2021

emaste accepted D30780: fusefs: improve warnings about buggy FUSE servers.
Jun 16 2021, 6:40 PM
emaste added a comment to D30780: fusefs: improve warnings about buggy FUSE servers.

I like this idea.

Jun 16 2021, 6:09 PM
emaste accepted D30784: fusefs: support EVFILT_WRITE on /dev/fuse.
Jun 16 2021, 5:06 PM
emaste committed R10:97f3e018fa2f: LinuxKPI: add fault_flag_allow_retry_first (authored by greg_unrelenting.technology).
LinuxKPI: add fault_flag_allow_retry_first
Jun 16 2021, 4:51 PM
emaste committed R10:07ef7a034965: LinuxKPI: add fault_flag_allow_retry_first (authored by greg_unrelenting.technology).
LinuxKPI: add fault_flag_allow_retry_first
Jun 16 2021, 4:50 PM
emaste added inline comments to D30784: fusefs: support EVFILT_WRITE on /dev/fuse.
Jun 16 2021, 4:42 PM