Diffusion FreeBSD src repository 85707cfdaddc

bhyve: avoid updating fbaddr when vm_mmap_memseg fails
85707cfdaddc
Actions

Description

bhyve: avoid updating fbaddr when vm_mmap_memseg fails

In the function pci_fbuf_baraddr the field sc->fbaddr was set with a
user-controlled value, even though the call to vm_mmap_memseg failed.

No security risk as currently sc->fbaddr is not really used in the
source code.

Reported by: Synacktiv
Reviewed by: emaste
Sponsored by: Alpha-Omega Project
Sponsored by: The FreeBSD Foundation
Differential revision: https://reviews.freebsd.org/D46109

Details

Provenance

khorben_defora.org	Authored on Jul 24 2024, 8:51 PM
emaste	Committed on Mon, Aug 26, 8:23 PM

Reviewer

emaste

Differential Revision

Restricted Differential Revision

Parents

rGde9468837c92: sqlite3: Vendor import of sqlite3 3.46.1

Branches

Unknown

Tags

Unknown

Event Timeline

emaste committed rG85707cfdaddc: bhyve: avoid updating fbaddr when vm_mmap_memseg fails (authored by khorben_defora.org).Mon, Aug 26, 8:23 PM

emaste added an edge: Restricted Differential Revision.Mon, Aug 26, 8:26 PM

emaste mentioned this in rG4a81e501337c: bhyve: avoid updating fbaddr when vm_mmap_memseg fails.Tue, Sep 3, 2:54 PM

emaste mentioned this in rG10f7e124eadf: bhyve: avoid updating fbaddr when vm_mmap_memseg fails.

Changes (1)

Path

Size

usr.sbin/

bhyve/

pci_fbuf.c

rG85707cfdaddc

View Options