Page MenuHomeFreeBSD

khorben_defora.org (Pierre Pronchery)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 26 2023, 1:30 PM (6 w, 2 d)

Recent Activity

Mon, Jun 5

khorben_defora.org updated the diff for D40417: openssl: Import the changes specific to FreeBSD.

openssl: Enable support for RFC3779
openssl: Fix typos in manual pages
openssl: Limit the changes to obsolete files to us

Mon, Jun 5, 4:14 PM

Sun, Jun 4

khorben_defora.org requested review of D40417: openssl: Import the changes specific to FreeBSD.
Sun, Jun 4, 7:38 PM

Thu, Jun 1

khorben_defora.org requested review of D40379: libarchive: Avoid a build failure with OpenSSL 3.0.
Thu, Jun 1, 6:53 PM

Wed, May 31

khorben_defora.org updated the test plan for D40365: [PATCH] openssl: Vendor import of OpenSSL-3.0.9.
Wed, May 31, 10:37 PM
khorben_defora.org updated the summary of D40365: [PATCH] openssl: Vendor import of OpenSSL-3.0.9.
Wed, May 31, 10:36 PM
khorben_defora.org requested review of D40365: [PATCH] openssl: Vendor import of OpenSSL-3.0.9.
Wed, May 31, 10:32 PM
khorben_defora.org added a reviewer for D40361: unbound: Request the OpenSSL 1.1 API: ngie.
Wed, May 31, 7:31 PM
khorben_defora.org added a comment to D40361: unbound: Request the OpenSSL 1.1 API.

As per https://github.com/freebsd/freebsd-src/pull/758.

Wed, May 31, 7:00 PM
khorben_defora.org requested review of D40361: unbound: Request the OpenSSL 1.1 API.
Wed, May 31, 6:54 PM
khorben_defora.org accepted D40353: dumpon: update OpenSSL initialization call.
Wed, May 31, 6:08 PM
khorben_defora.org added a comment to D40343: decryptcore: update for OpenSSL 1.1 API.

The documentation from OpenSSL 3 is more clear about the behaviour of OPENSSL_init_crypto() with regard to the OPENSSL_INIT_LOAD_CONFIG option:

With this option an OpenSSL configuration file will be automatically loaded and used by
calling OPENSSL_config(). This is a default option. Note that in OpenSSL 1.1.1 this was the
default for libssl but not for libcrypto (see OPENSSL_init_ssl(3) for further details about
libssl initialisation). In OpenSSL 1.1.0 this was a nondefault option for both libssl and
libcrypto. See the description of OPENSSL_INIT_new(), below.
Wed, May 31, 5:49 PM
khorben_defora.org added a comment to D40343: decryptcore: update for OpenSSL 1.1 API.

In the case of dumpon (similar situation), I found that some initialisation code is in .init in libcrypto.so. I think it comes from ossl_init_base() which in turns calls OPENSSL_cpuid_setup() (caught in gdb below). If I understand it correctly, OPENSSL_init_crypto() makes sure ossl_init_base() has been called or calls it explicitly. But then OPENSSL_init_crypto() also does more than that, and I do not see it being called at all here.

Wed, May 31, 5:40 PM
khorben_defora.org accepted D40355: dumpon: check OPENSSL_init_crypto return value.
Wed, May 31, 5:10 PM
khorben_defora.org added a comment to D40343: decryptcore: update for OpenSSL 1.1 API.

The documentation also says "This is not a default option for libcrypto." and this call is for libcrypto (OPENSSL_init_crypto() and not OPENSSL_init_ssl()) so @def is probably right.

Wed, May 31, 4:50 PM
khorben_defora.org added a comment to D40343: decryptcore: update for OpenSSL 1.1 API.

Are you sure that it is still necessary to call OPENSSL_init_crypto() before entering capability mode?
OpenSSL 1.1 seems to use getentropy(3) on FreeBSD >= 12, or arc4rand(9) otherwise (through sysctl).
Anyway, better safe than sorry.

Wed, May 31, 4:27 PM
khorben_defora.org accepted D39832: x11-clocks/wmitime: Revive port.
Wed, May 31, 3:27 PM

Thu, May 25

khorben_defora.org accepted D40265: libfetch: do not call deprecated OpenSSL functions.

LGTM; and this also builds fine with OpenSSL 3.0.8 in src.

Thu, May 25, 3:49 PM

Wed, May 24

khorben_defora.org added a comment to D40226: ldns: Upgrade to 1.8.3..

With these changes applied on d1639e43c589644510198dc53aef87e8908a1507 (latest main) the build fails for me in usr.bin/drill:

Wed, May 24, 3:45 PM

Tue, May 23

khorben_defora.org abandoned D39833: Modify the Makefile to simplify the port, use snprintf().

Reviewed with https://reviews.freebsd.org/D39832 instead.

Tue, May 23, 4:30 PM
khorben_defora.org added a comment to D40226: ldns: Upgrade to 1.8.3..

I have added this to lib/libldns/Makefile to fix the build with GCC 12, as caught by the CI:

+CWARNFLAGS.parse.c=    ${NO_WUSE_AFTER_FREE}

The build with GCC 12 now fails somewhere else (cddl/lib/libzpool) so I suppose this covers ldns.

Tue, May 23, 4:03 PM

Apr 26 2023

khorben_defora.org updated the diff for D39833: Modify the Makefile to simplify the port, use snprintf().

Remove the WWW line in pkg-descr.

Apr 26 2023, 2:42 PM
khorben_defora.org updated the diff for D39833: Modify the Makefile to simplify the port, use snprintf().

Remove the patch for the Makefile.

Apr 26 2023, 2:30 PM
khorben_defora.org added a reviewer for D39833: Modify the Makefile to simplify the port, use snprintf(): jrm.
Apr 26 2023, 2:16 PM
khorben_defora.org requested review of D39833: Modify the Makefile to simplify the port, use snprintf().
Apr 26 2023, 2:15 PM