Page MenuHomeFreeBSD

khorben_defora.org (Pierre Pronchery)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 26 2023, 1:30 PM (94 w, 4 d)

Recent Activity

Tue, Feb 4

khorben_defora.org accepted D47229: bsdinstall: Switched back to amended single-button finalconfig.

You are right, the old scheme is less confusing.
The changes proposed here look correct to me.

Tue, Feb 4, 2:47 PM

Mon, Jan 20

khorben_defora.org updated the diff for D48167: Introduce the USB umb(4) network driver.

Updated to compile and work with the new ifabi changes.

Mon, Jan 20, 11:00 PM · network, USB

Jan 17 2025

khorben_defora.org added a comment to D48167: Introduce the USB umb(4) network driver.

Thanks for the heads up! Looking into it...

Jan 17 2025, 7:00 PM · network, USB

Jan 10 2025

khorben_defora.org updated the diff for D48167: Introduce the USB umb(4) network driver.

Integrate suggestions from Zhenlei Huang (zlei@); thank you!

Jan 10 2025, 11:31 PM · network, USB

Jan 8 2025

khorben_defora.org added a comment to D48167: Introduce the USB umb(4) network driver.

I'm so excited to test this driver this weekend! Thank you so much for submitting this! All of the suggestions I made are to bring it into alignment with the rest of the freebsd manual and are specified in the manual page style guide, style.mdoc(5). Sorry I'm so late.

Jan 8 2025, 11:24 PM · network, USB
khorben_defora.org updated the diff for D48167: Introduce the USB umb(4) network driver.

This change applies the rest of the changes suggested to the manual pages.

Jan 8 2025, 11:13 PM · network, USB
khorben_defora.org added inline comments to D48167: Introduce the USB umb(4) network driver.
Jan 8 2025, 8:29 PM · network, USB
khorben_defora.org updated the diff for D48167: Introduce the USB umb(4) network driver.

This update to the diff brings:

Jan 8 2025, 8:03 PM · network, USB
khorben_defora.org added a comment to D48167: Introduce the USB umb(4) network driver.

I am currently looking into adding the SPDX license identifier, but it can also be done in a separate review.

Jan 8 2025, 12:53 AM · network, USB
khorben_defora.org added a comment to D48167: Introduce the USB umb(4) network driver.

I think it's fine as-is to go in the tree, it's been two years and I'd like to see this in before -15.

Jan 8 2025, 12:29 AM · network, USB
khorben_defora.org added a reviewer for D48167: Introduce the USB umb(4) network driver: thj.
Jan 8 2025, 12:17 AM · network, USB

Dec 24 2024

khorben_defora.org updated the diff for D48167: Introduce the USB umb(4) network driver.

Address feedback from lwhsu@; thanks!

Dec 24 2024, 12:10 AM · network, USB
khorben_defora.org added inline comments to D48167: Introduce the USB umb(4) network driver.
Dec 24 2024, 12:09 AM · network, USB

Dec 23 2024

khorben_defora.org added a reviewer for D48167: Introduce the USB umb(4) network driver: olce.
Dec 23 2024, 4:50 PM · network, USB

Dec 21 2024

khorben_defora.org requested review of D48167: Introduce the USB umb(4) network driver.
Dec 21 2024, 2:10 AM · network, USB

Dec 6 2024

khorben_defora.org added a comment to D47933: .well-known: import a tentative security.txt.
In D47933#1093012, @concussious.bugzilla_runbox.com wrote:

Oops! You're right. I don't think the field descriptions help it though, the fields are very self explanatory but the comments adds bikeshedable language? This is really an architectural decision for secteam, will certainly result in increased spam, but maybe helpful. So, I'll bow out now.

Dec 6 2024, 12:40 AM

Dec 5 2024

khorben_defora.org added a comment to D47933: .well-known: import a tentative security.txt.

Also note that the contents of this file can be signed with an OpenPGP clear-text signature by the security team, in order to clearly authenticate it as legitimate.

Dec 5 2024, 11:55 PM
khorben_defora.org updated the diff for D47933: .well-known: import a tentative security.txt.

Add descriptions of the fields used, as per the example from securitytxt.org.

Dec 5 2024, 11:51 PM
khorben_defora.org added a comment to D47933: .well-known: import a tentative security.txt.
In D47933#1092988, @concussious.bugzilla_runbox.com wrote:

I really like this concept.
Why are there two policy lines?

Dec 5 2024, 11:47 PM
khorben_defora.org added inline comments to D47933: .well-known: import a tentative security.txt.
Dec 5 2024, 11:44 PM
khorben_defora.org updated the diff for D47933: .well-known: import a tentative security.txt.

Removed the (optional) links for "any security-related job openings in your organisation."

Dec 5 2024, 10:35 PM
khorben_defora.org added a reviewer for D47933: .well-known: import a tentative security.txt: secteam.
Dec 5 2024, 10:01 PM
khorben_defora.org requested review of D47933: .well-known: import a tentative security.txt.
Dec 5 2024, 9:58 PM

Oct 14 2024

khorben_defora.org added a reviewer for D46882: bhyve: buffer overflow in pci_vtcon_control_send: markj.
Oct 14 2024, 6:56 PM
khorben_defora.org updated the diff for D46882: bhyve: buffer overflow in pci_vtcon_control_send.

Moved the sanity check for len to the beginning of pci_vtcon_control_send().

Oct 14 2024, 6:40 PM

Oct 2 2024

khorben_defora.org requested review of D46883: bhyve: mark additional functions as __result_use_check.
Oct 2 2024, 11:05 PM · bhyve
khorben_defora.org requested review of D46882: bhyve: buffer overflow in pci_vtcon_control_send.
Oct 2 2024, 9:51 PM

Sep 8 2024

khorben_defora.org accepted D46601: Drop expired FreeBSD 14.0 support.
Sep 8 2024, 1:36 PM

Aug 2 2024

khorben_defora.org added a comment to D45401: bhyve: avoid a potential deadlock.

What's CID: 1521334?

Aug 2 2024, 9:43 AM

Aug 1 2024

khorben_defora.org abandoned D42146: stand/i386: build a specific loader for PXE boot.
Aug 1 2024, 4:11 PM
khorben_defora.org added a comment to D42146: stand/i386: build a specific loader for PXE boot.
In D42146#1052635, @imp wrote:

So now that we build a smaller loader in general, do we need to build another loader for this?

Aug 1 2024, 4:11 PM

Jun 25 2024

khorben_defora.org added a comment to D45734: platforms/i386: report Pentium Pro as minimum supported x86 processor.

Would it be more clear or accurate to mention the "Pentium MMX" instead or in addition to the Pentium Pro?
It was much more common and known to the public than the Pentium Pro.

Jun 25 2024, 8:21 PM

Jun 14 2024

khorben_defora.org added inline comments to D44670: bsdinstall: implement timezone with bsddialog.
Jun 14 2024, 9:25 PM

Jun 4 2024

khorben_defora.org updated the diff for D45000: release: create a bootable image with the graphical installer.

This avoids an issue with makefs(8) when building without a manifest file. (e.g., when building as root)
Consequently it should work both when using a manifest file as well as without, although it still requires root privileges in both cases, for e.g., chroot(8) and mount(8).

Jun 4 2024, 6:19 PM

May 29 2024

khorben_defora.org updated the summary of D45401: bhyve: avoid a potential deadlock.
May 29 2024, 3:52 PM
khorben_defora.org requested review of D45401: bhyve: avoid a potential deadlock.
May 29 2024, 3:50 PM

May 16 2024

khorben_defora.org updated the test plan for D45223: bhyve: avoid resource leak in error path.
May 16 2024, 5:25 PM
khorben_defora.org requested review of D45223: bhyve: avoid resource leak in error path.
May 16 2024, 5:25 PM

Apr 29 2024

khorben_defora.org requested review of D45000: release: create a bootable image with the graphical installer.
Apr 29 2024, 12:35 AM

Apr 7 2024

khorben_defora.org added a comment to D44670: bsdinstall: implement timezone with bsddialog.

Why do we need a copy of this code rather than just tweaking bsdconfig to support this?

Apr 7 2024, 8:29 PM
khorben_defora.org requested review of D44674: bsdinstall: add support for graphical mode.
Apr 7 2024, 8:24 PM
khorben_defora.org requested review of D44673: bsdinstall: handle command-line options in targets.
Apr 7 2024, 6:52 PM
khorben_defora.org requested review of D44672: bsdinstall: obtain the dialog binary from $DIALOG.
Apr 7 2024, 6:15 PM
khorben_defora.org requested review of D44671: bsdinstall: allow forcing a specific partitioning mode.
Apr 7 2024, 5:44 PM
khorben_defora.org requested review of D44670: bsdinstall: implement timezone with bsddialog.
Apr 7 2024, 5:31 PM

Mar 8 2024

khorben_defora.org requested review of D44280: bsdinstall: implement rootpass with bsddialog.
Mar 8 2024, 2:53 PM
khorben_defora.org requested review of D44279: bsdinstall: implement adduser with bsddialog.
Mar 8 2024, 2:44 PM

Dec 29 2023

khorben_defora.org updated the diff for D43233: bsdinstall: rename "Live CD" to "Live System".

Also updated bin/freebsd-version/freebsd-version.1.

Dec 29 2023, 7:50 PM
khorben_defora.org requested review of D43233: bsdinstall: rename "Live CD" to "Live System".
Dec 29 2023, 6:39 PM

Dec 13 2023

khorben_defora.org added inline comments to D43009: kerberos: Fix numerous segfaults when using weak crypto.
Dec 13 2023, 4:54 PM

Nov 2 2023

khorben_defora.org added a comment to D42433: ino64: Fix incremental builds.
In D42433#968563, @imp wrote:

remove /sys

Nov 2 2023, 5:37 PM

Oct 27 2023

khorben_defora.org requested review of D42381: bsdinstall: add a dialog for network proxy setup.
Oct 27 2023, 4:06 PM
khorben_defora.org abandoned D41750: stand/i386: fix booting over TFTP or NFS.

Focus on D42146 instead.

Oct 27 2023, 1:58 PM
khorben_defora.org retitled D42281: bsdinstall: restore the environment when restarting from bsdinstall: reset the environment when restarting to bsdinstall: restore the environment when restarting.
Oct 27 2023, 12:15 PM
khorben_defora.org updated the diff for D42281: bsdinstall: restore the environment when restarting.

This updated diff:

Oct 27 2023, 11:56 AM

Oct 19 2023

khorben_defora.org added a reviewer for D42281: bsdinstall: restore the environment when restarting: jrtc27.
Oct 19 2023, 6:14 PM
khorben_defora.org added a comment to D42193: [PATCH 1/2] netconfig: report configuration failures.

Should I rebase this patch since D42194 is already merged?

Oct 19 2023, 6:05 PM

Oct 18 2023

khorben_defora.org updated the summary of D42281: bsdinstall: restore the environment when restarting.
Oct 18 2023, 8:23 PM
khorben_defora.org added a reviewer for D42281: bsdinstall: restore the environment when restarting: bapt.
Oct 18 2023, 8:22 PM
khorben_defora.org requested review of D42281: bsdinstall: restore the environment when restarting.
Oct 18 2023, 8:22 PM

Oct 13 2023

khorben_defora.org added a comment to D41306: tzsetup: add support for countries in two continents.

I rebased and updated the commit with the full message at https://github.com/khorben/freebsd-src/tree/khorben/tzsetup-extra.

Oct 13 2023, 5:20 PM
khorben_defora.org added a comment to D41250: hardening: remember the answers to each item.

Thanks; this is now ready to merge from https://github.com/khorben/freebsd-src/tree/khorben/bsdinstall.

Oct 13 2023, 4:44 PM
khorben_defora.org added a reviewer for D42183: bsdinstall: reset the mirror when restarting: bapt.

(I did not mean to remove any reviewer, I guess I re-used an old browser tab without refreshing)

Oct 13 2023, 4:07 PM
khorben_defora.org added a comment to D42194: [PATCH 2/2] netconfig: avoid duplicate entries in rc.conf.

This is in the khorben/bsdinstall-netconfig branch at https://github.com/khorben/freebsd-src/.

Oct 13 2023, 4:05 PM
khorben_defora.org added a comment to D42193: [PATCH 1/2] netconfig: report configuration failures.

This is in the khorben/bsdinstall-netconfig branch at https://github.com/khorben/freebsd-src/.

Oct 13 2023, 4:05 PM
khorben_defora.org removed a reviewer for D42183: bsdinstall: reset the mirror when restarting: bapt.

This is also related to #192194.

Oct 13 2023, 4:01 PM
khorben_defora.org requested review of D42194: [PATCH 2/2] netconfig: avoid duplicate entries in rc.conf.
Oct 13 2023, 3:56 PM
khorben_defora.org requested review of D42193: [PATCH 1/2] netconfig: report configuration failures.
Oct 13 2023, 3:54 PM

Oct 12 2023

khorben_defora.org added a reviewer for D41306: tzsetup: add support for countries in two continents: bapt.
Oct 12 2023, 9:25 PM
khorben_defora.org added a reviewer for D42047: [PATCH 2/2] bsdinstall: revisit the finalconfig step: bapt.
Oct 12 2023, 9:24 PM
khorben_defora.org added a reviewer for D42046: [PATCH 1/2] bsdinstall: revisit the finalconfig step: bapt.
Oct 12 2023, 9:24 PM
khorben_defora.org added a reviewer for D41250: hardening: remember the answers to each item: bapt.
Oct 12 2023, 9:23 PM
khorben_defora.org requested review of D42183: bsdinstall: reset the mirror when restarting.
Oct 12 2023, 9:11 PM

Oct 10 2023

khorben_defora.org requested review of D42146: stand/i386: build a specific loader for PXE boot.
Oct 10 2023, 4:10 PM

Oct 8 2023

khorben_defora.org added a reviewer for D41250: hardening: remember the answers to each item: jrtc27.

(If you don't mind)

Oct 8 2023, 4:01 PM
khorben_defora.org closed D41943: openssl: Vendor import of OpenSSL 3.0.11.

Imported in 315108b81694de474bbc273c0050b195047f5eed.

Oct 8 2023, 3:57 PM
khorben_defora.org updated the diff for D42047: [PATCH 2/2] bsdinstall: revisit the finalconfig step.
  • This now uses break to be more future-proof
  • The commit message now mentions the change in behaviour when selecting unknown actions
Oct 8 2023, 3:54 PM
khorben_defora.org added inline comments to D42047: [PATCH 2/2] bsdinstall: revisit the finalconfig step.
Oct 8 2023, 3:49 PM

Oct 4 2023

khorben_defora.org updated the diff for D42047: [PATCH 2/2] bsdinstall: revisit the finalconfig step.
  • Made "Finish" the default action
  • Renamed the "OK" button to "Select"
Oct 4 2023, 4:57 PM
khorben_defora.org added a comment to D42047: [PATCH 2/2] bsdinstall: revisit the finalconfig step.

Every additional keypress required, especially ones for navigating to the right option, makes an already user-hostile installer have even more friction. I am very strongly opposed to not being able to quickly skip through screens that 99.999999% of users do not need.

Oct 4 2023, 4:25 PM
khorben_defora.org added a comment to D42047: [PATCH 2/2] bsdinstall: revisit the finalconfig step.

Is the new Finish button selected by default?

Oct 4 2023, 3:16 PM

Oct 2 2023

khorben_defora.org abandoned D41298: bsdinstall: revisit the finalconfig step.

Replaced by D42046 and D42047.

Oct 2 2023, 7:55 PM
khorben_defora.org requested review of D42047: [PATCH 2/2] bsdinstall: revisit the finalconfig step.
Oct 2 2023, 7:53 PM
khorben_defora.org updated the summary of D42046: [PATCH 1/2] bsdinstall: revisit the finalconfig step.
Oct 2 2023, 7:52 PM
khorben_defora.org requested review of D42046: [PATCH 1/2] bsdinstall: revisit the finalconfig step.
Oct 2 2023, 7:50 PM
khorben_defora.org added inline comments to D41945: freebsd-update: handle directories changing to files, too.
Oct 2 2023, 6:01 PM
khorben_defora.org added inline comments to D42033: freebsd-update: recreate /var/db/freebsd-update if missing.
Oct 2 2023, 5:59 PM
khorben_defora.org added a comment to D41945: freebsd-update: handle directories changing to files, too.

test for existence of file before removing

to avoid spurious errors

Oct 2 2023, 5:33 PM
khorben_defora.org added inline comments to D41945: freebsd-update: handle directories changing to files, too.
Oct 2 2023, 10:24 AM

Sep 22 2023

khorben_defora.org accepted D41941: ossl: Rebuild the openssl asm.

Looks good to me.

Sep 22 2023, 8:02 PM
khorben_defora.org accepted D41940: aarch64: support BTI and pointer authentication in assembly.

Sounds good to me then!

Sep 22 2023, 7:58 PM
khorben_defora.org added a comment to D41940: aarch64: support BTI and pointer authentication in assembly.

I found information confirming my doubts about the keccak code.

Sep 22 2023, 6:57 PM
khorben_defora.org requested changes to D41940: aarch64: support BTI and pointer authentication in assembly.

Can you review the comment I added about crypto/sha/asm/keccak1600-armv8.pl?

Sep 22 2023, 6:51 PM
khorben_defora.org added a comment to D41940: aarch64: support BTI and pointer authentication in assembly.

We may also want to consider 40c24d74deaad8a0ad7566a68ea5ea757bc3ccef as well, from OpenSSL's Git repository:

Sep 22 2023, 6:33 PM
khorben_defora.org added a comment to D41940: aarch64: support BTI and pointer authentication in assembly.

FWIW this patch does not conflict with the import of OpenSSL 3.0.11 that I am currently preparing (vendor import in D41943).

Sep 22 2023, 3:28 PM
khorben_defora.org requested review of D41943: openssl: Vendor import of OpenSSL 3.0.11.
Sep 22 2023, 3:18 PM

Sep 18 2023

khorben_defora.org added a comment to D41750: stand/i386: fix booting over TFTP or NFS.

I have the impression that with these changes, pxeldr will fail to build if MK_LOADER_LUA is not enabled. I am preparing a new patch where SUBDIR_DEPEND_pxeldr+= loader_lua_nozfs is protected by .if ${MK_LOADER_LUA} != "no", but then pxeldr is still hard-coded to L=loader_lua_nozfs; that feels wrong.

Sep 18 2023, 6:29 PM

Sep 15 2023

khorben_defora.org requested review of D41879: libcrypto: link engines and the legacy provider to libcrypto.
Sep 15 2023, 5:26 PM

Sep 14 2023

khorben_defora.org updated the diff for D41720: libcrypto: fix the FIPS provider on amd64.

Also build aes-586.S for i386.

Sep 14 2023, 5:47 PM

Sep 13 2023

khorben_defora.org updated the diff for D41750: stand/i386: fix booting over TFTP or NFS.
  • Created a single new loader variant, loader_lua_nozfs
  • Hard-coded the PXE loader to use loader_lua_nozfs instead of loader_${LOADER_INTERP}
Sep 13 2023, 2:04 PM