Page MenuHomeFreeBSD

khorben_defora.org (Pierre Pronchery)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 26 2023, 1:30 PM (50 w, 3 d)

Recent Activity

Sun, Apr 7

khorben_defora.org added a comment to D44670: bsdinstall: implement timezone with bsddialog.

Why do we need a copy of this code rather than just tweaking bsdconfig to support this?

Sun, Apr 7, 8:29 PM
khorben_defora.org requested review of D44674: bsdinstall: add support for graphical mode.
Sun, Apr 7, 8:24 PM
khorben_defora.org requested review of D44673: bsdinstall: handle command-line options in targets.
Sun, Apr 7, 6:52 PM
khorben_defora.org requested review of D44672: bsdinstall: obtain the dialog binary from $DIALOG.
Sun, Apr 7, 6:15 PM
khorben_defora.org requested review of D44671: bsdinstall: allow forcing a specific partitioning mode.
Sun, Apr 7, 5:44 PM
khorben_defora.org requested review of D44670: bsdinstall: implement timezone with bsddialog.
Sun, Apr 7, 5:31 PM

Mar 8 2024

khorben_defora.org requested review of D44280: bsdinstall: implement rootpass with bsddialog.
Mar 8 2024, 2:53 PM
khorben_defora.org requested review of D44279: bsdinstall: implement adduser with bsddialog.
Mar 8 2024, 2:44 PM

Dec 29 2023

khorben_defora.org updated the diff for D43233: bsdinstall: rename "Live CD" to "Live System".

Also updated bin/freebsd-version/freebsd-version.1.

Dec 29 2023, 7:50 PM
khorben_defora.org requested review of D43233: bsdinstall: rename "Live CD" to "Live System".
Dec 29 2023, 6:39 PM

Dec 13 2023

khorben_defora.org added inline comments to D43009: kerberos: Fix numerous segfaults when using weak crypto.
Dec 13 2023, 4:54 PM

Nov 2 2023

khorben_defora.org added a comment to D42433: ino64: Fix incremental builds.
In D42433#968563, @imp wrote:

remove /sys

Nov 2 2023, 5:37 PM

Oct 27 2023

khorben_defora.org requested review of D42381: bsdinstall: add a dialog for network proxy setup.
Oct 27 2023, 4:06 PM
khorben_defora.org abandoned D41750: stand/i386: fix booting over TFTP or NFS.

Focus on D42146 instead.

Oct 27 2023, 1:58 PM
khorben_defora.org retitled D42281: bsdinstall: restore the environment when restarting from bsdinstall: reset the environment when restarting to bsdinstall: restore the environment when restarting.
Oct 27 2023, 12:15 PM
khorben_defora.org updated the diff for D42281: bsdinstall: restore the environment when restarting.

This updated diff:

Oct 27 2023, 11:56 AM

Oct 19 2023

khorben_defora.org added a reviewer for D42281: bsdinstall: restore the environment when restarting: jrtc27.
Oct 19 2023, 6:14 PM
khorben_defora.org added a comment to D42193: [PATCH 1/2] netconfig: report configuration failures.

Should I rebase this patch since D42194 is already merged?

Oct 19 2023, 6:05 PM

Oct 18 2023

khorben_defora.org updated the summary of D42281: bsdinstall: restore the environment when restarting.
Oct 18 2023, 8:23 PM
khorben_defora.org added a reviewer for D42281: bsdinstall: restore the environment when restarting: bapt.
Oct 18 2023, 8:22 PM
khorben_defora.org requested review of D42281: bsdinstall: restore the environment when restarting.
Oct 18 2023, 8:22 PM

Oct 13 2023

khorben_defora.org added a comment to D41306: tzsetup: add support for countries in two continents.

I rebased and updated the commit with the full message at https://github.com/khorben/freebsd-src/tree/khorben/tzsetup-extra.

Oct 13 2023, 5:20 PM
khorben_defora.org added a comment to D41250: hardening: remember the answers to each item.

Thanks; this is now ready to merge from https://github.com/khorben/freebsd-src/tree/khorben/bsdinstall.

Oct 13 2023, 4:44 PM
khorben_defora.org added a reviewer for D42183: bsdinstall: reset the mirror when restarting: bapt.

(I did not mean to remove any reviewer, I guess I re-used an old browser tab without refreshing)

Oct 13 2023, 4:07 PM
khorben_defora.org added a comment to D42194: [PATCH 2/2] netconfig: avoid duplicate entries in rc.conf.

This is in the khorben/bsdinstall-netconfig branch at https://github.com/khorben/freebsd-src/.

Oct 13 2023, 4:05 PM
khorben_defora.org added a comment to D42193: [PATCH 1/2] netconfig: report configuration failures.

This is in the khorben/bsdinstall-netconfig branch at https://github.com/khorben/freebsd-src/.

Oct 13 2023, 4:05 PM
khorben_defora.org removed a reviewer for D42183: bsdinstall: reset the mirror when restarting: bapt.

This is also related to #192194.

Oct 13 2023, 4:01 PM
khorben_defora.org requested review of D42194: [PATCH 2/2] netconfig: avoid duplicate entries in rc.conf.
Oct 13 2023, 3:56 PM
khorben_defora.org requested review of D42193: [PATCH 1/2] netconfig: report configuration failures.
Oct 13 2023, 3:54 PM

Oct 12 2023

khorben_defora.org added a reviewer for D41306: tzsetup: add support for countries in two continents: bapt.
Oct 12 2023, 9:25 PM
khorben_defora.org added a reviewer for D42047: [PATCH 2/2] bsdinstall: revisit the finalconfig step: bapt.
Oct 12 2023, 9:24 PM
khorben_defora.org added a reviewer for D42046: [PATCH 1/2] bsdinstall: revisit the finalconfig step: bapt.
Oct 12 2023, 9:24 PM
khorben_defora.org added a reviewer for D41250: hardening: remember the answers to each item: bapt.
Oct 12 2023, 9:23 PM
khorben_defora.org requested review of D42183: bsdinstall: reset the mirror when restarting.
Oct 12 2023, 9:11 PM

Oct 10 2023

khorben_defora.org requested review of D42146: stand/i386: build a specific loader for PXE boot.
Oct 10 2023, 4:10 PM

Oct 8 2023

khorben_defora.org added a reviewer for D41250: hardening: remember the answers to each item: jrtc27.

(If you don't mind)

Oct 8 2023, 4:01 PM
khorben_defora.org closed D41943: openssl: Vendor import of OpenSSL 3.0.11.

Imported in 315108b81694de474bbc273c0050b195047f5eed.

Oct 8 2023, 3:57 PM
khorben_defora.org updated the diff for D42047: [PATCH 2/2] bsdinstall: revisit the finalconfig step.
  • This now uses break to be more future-proof
  • The commit message now mentions the change in behaviour when selecting unknown actions
Oct 8 2023, 3:54 PM
khorben_defora.org added inline comments to D42047: [PATCH 2/2] bsdinstall: revisit the finalconfig step.
Oct 8 2023, 3:49 PM

Oct 4 2023

khorben_defora.org updated the diff for D42047: [PATCH 2/2] bsdinstall: revisit the finalconfig step.
  • Made "Finish" the default action
  • Renamed the "OK" button to "Select"
Oct 4 2023, 4:57 PM
khorben_defora.org added a comment to D42047: [PATCH 2/2] bsdinstall: revisit the finalconfig step.

Every additional keypress required, especially ones for navigating to the right option, makes an already user-hostile installer have even more friction. I am very strongly opposed to not being able to quickly skip through screens that 99.999999% of users do not need.

Oct 4 2023, 4:25 PM
khorben_defora.org added a comment to D42047: [PATCH 2/2] bsdinstall: revisit the finalconfig step.

Is the new Finish button selected by default?

Oct 4 2023, 3:16 PM

Oct 2 2023

khorben_defora.org abandoned D41298: bsdinstall: revisit the finalconfig step.

Replaced by D42046 and D42047.

Oct 2 2023, 7:55 PM
khorben_defora.org requested review of D42047: [PATCH 2/2] bsdinstall: revisit the finalconfig step.
Oct 2 2023, 7:53 PM
khorben_defora.org updated the summary of D42046: [PATCH 1/2] bsdinstall: revisit the finalconfig step.
Oct 2 2023, 7:52 PM
khorben_defora.org requested review of D42046: [PATCH 1/2] bsdinstall: revisit the finalconfig step.
Oct 2 2023, 7:50 PM
khorben_defora.org added inline comments to D41945: freebsd-update: handle directories changing to files, too.
Oct 2 2023, 6:01 PM
khorben_defora.org added inline comments to D42033: freebsd-update: recreate /var/db/freebsd-update if missing.
Oct 2 2023, 5:59 PM
khorben_defora.org added a comment to D41945: freebsd-update: handle directories changing to files, too.

test for existence of file before removing

to avoid spurious errors

Oct 2 2023, 5:33 PM
khorben_defora.org added inline comments to D41945: freebsd-update: handle directories changing to files, too.
Oct 2 2023, 10:24 AM

Sep 22 2023

khorben_defora.org accepted D41941: ossl: Rebuild the openssl asm.

Looks good to me.

Sep 22 2023, 8:02 PM
khorben_defora.org accepted D41940: aarch64: support BTI and pointer authentication in assembly.

Sounds good to me then!

Sep 22 2023, 7:58 PM
khorben_defora.org added a comment to D41940: aarch64: support BTI and pointer authentication in assembly.

I found information confirming my doubts about the keccak code.

Sep 22 2023, 6:57 PM
khorben_defora.org requested changes to D41940: aarch64: support BTI and pointer authentication in assembly.

Can you review the comment I added about crypto/sha/asm/keccak1600-armv8.pl?

Sep 22 2023, 6:51 PM
khorben_defora.org added a comment to D41940: aarch64: support BTI and pointer authentication in assembly.

We may also want to consider 40c24d74deaad8a0ad7566a68ea5ea757bc3ccef as well, from OpenSSL's Git repository:

Sep 22 2023, 6:33 PM
khorben_defora.org added a comment to D41940: aarch64: support BTI and pointer authentication in assembly.

FWIW this patch does not conflict with the import of OpenSSL 3.0.11 that I am currently preparing (vendor import in D41943).

Sep 22 2023, 3:28 PM
khorben_defora.org requested review of D41943: openssl: Vendor import of OpenSSL 3.0.11.
Sep 22 2023, 3:18 PM

Sep 18 2023

khorben_defora.org added a comment to D41750: stand/i386: fix booting over TFTP or NFS.

I have the impression that with these changes, pxeldr will fail to build if MK_LOADER_LUA is not enabled. I am preparing a new patch where SUBDIR_DEPEND_pxeldr+= loader_lua_nozfs is protected by .if ${MK_LOADER_LUA} != "no", but then pxeldr is still hard-coded to L=loader_lua_nozfs; that feels wrong.

Sep 18 2023, 6:29 PM

Sep 15 2023

khorben_defora.org requested review of D41879: libcrypto: link engines and the legacy provider to libcrypto.
Sep 15 2023, 5:26 PM

Sep 14 2023

khorben_defora.org updated the diff for D41720: libcrypto: fix the FIPS provider on amd64.

Also build aes-586.S for i386.

Sep 14 2023, 5:47 PM

Sep 13 2023

khorben_defora.org updated the diff for D41750: stand/i386: fix booting over TFTP or NFS.
  • Created a single new loader variant, loader_lua_nozfs
  • Hard-coded the PXE loader to use loader_lua_nozfs instead of loader_${LOADER_INTERP}
Sep 13 2023, 2:04 PM

Sep 6 2023

khorben_defora.org requested review of D41750: stand/i386: fix booting over TFTP or NFS.
Sep 6 2023, 12:06 AM

Sep 4 2023

khorben_defora.org added a reviewer for D41720: libcrypto: fix the FIPS provider on amd64: emaste.
Sep 4 2023, 6:42 PM
khorben_defora.org abandoned D41719: libcrypto: fix the FIPS provider on amd64.

Submitted again after rebase on -CURRENT.

Sep 4 2023, 6:29 PM
khorben_defora.org requested review of D41720: libcrypto: fix the FIPS provider on amd64.
Sep 4 2023, 6:28 PM
khorben_defora.org requested review of D41719: libcrypto: fix the FIPS provider on amd64.
Sep 4 2023, 6:07 PM

Sep 1 2023

khorben_defora.org abandoned D41668: libcrypto: Further improve Makefile.asm to avoid temporary files.

You are right, with a better look I also see differences with the SHA512 files.

Sep 1 2023, 10:12 AM

Aug 31 2023

khorben_defora.org added reviewers for D41668: libcrypto: Further improve Makefile.asm to avoid temporary files: jhb, emaste.
Aug 31 2023, 11:27 AM
khorben_defora.org abandoned D40379: libarchive: Avoid a build failure with OpenSSL 3.0.
Aug 31 2023, 11:26 AM
khorben_defora.org abandoned D40361: unbound: Request the OpenSSL 1.1 API.
Aug 31 2023, 11:25 AM
khorben_defora.org updated the summary of D41668: libcrypto: Further improve Makefile.asm to avoid temporary files.
Aug 31 2023, 11:20 AM
khorben_defora.org requested review of D41668: libcrypto: Further improve Makefile.asm to avoid temporary files.
Aug 31 2023, 11:13 AM
khorben_defora.org updated the diff for D41306: tzsetup: add support for countries in two continents.
Aug 31 2023, 3:31 AM
khorben_defora.org updated the diff for D41306: tzsetup: add support for countries in two continents.
  • Renamed the new member of struct country
  • Use a switch/case for pass 1 to 3
Aug 31 2023, 3:31 AM
khorben_defora.org accepted D41306: tzsetup: add support for countries in two continents.
Aug 31 2023, 3:31 AM

Aug 29 2023

khorben_defora.org requested changes to D41589: libcrypto: Refactor Makefile.asm so it can be run outside of buildenv.

In my tests the output is identical with and without this revision, except for avoiding the generation of temporary files on i386.
ISTM that the same optimization is possible on arm64, arm, and powerpc{,64,64le} as well by the way; would you consider applying it there as well?
Here is how I test locally: (from secure/lib/libcrypto)

#!/bin/sh
Aug 29 2023, 9:39 PM
khorben_defora.org accepted D41588: Makefile.asm: Simplify variable expansions in generated headers.

To me this looks tidier and also more sensible than before; indeed, why did it set the suffix to .pl only to remove it and add it again?

Aug 29 2023, 8:36 PM
khorben_defora.org abandoned D40365: [PATCH] openssl: Vendor import of OpenSSL-3.0.9.
Aug 29 2023, 8:05 PM

Aug 7 2023

khorben_defora.org added a reviewer for D41250: hardening: remember the answers to each item: emaste.
Aug 7 2023, 1:56 PM
khorben_defora.org added a reviewer for D41306: tzsetup: add support for countries in two continents: emaste.
Aug 7 2023, 1:51 PM
khorben_defora.org added a comment to D41298: bsdinstall: revisit the finalconfig step.

If you're moving code around and modifying it at the same time, please make two commits / revisions so it's much easier to review what's going on. Otherwise you have to flick back and forth between files.

Aug 7 2023, 1:50 PM
khorben_defora.org added a reviewer for D41298: bsdinstall: revisit the finalconfig step: emaste.
Aug 7 2023, 1:48 PM

Aug 3 2023

khorben_defora.org updated the test plan for D41306: tzsetup: add support for countries in two continents.
Aug 3 2023, 8:40 PM
khorben_defora.org requested review of D41306: tzsetup: add support for countries in two continents.
Aug 3 2023, 8:38 PM
khorben_defora.org updated the diff for D41250: hardening: remember the answers to each item.

Re-upload with arc this time (for context)

Aug 3 2023, 6:19 PM
khorben_defora.org added a comment to D41250: hardening: remember the answers to each item.

FYI: D40142

I do not know what the hesitation is there, but I know several people would prefer to see this menu disappear completely.

Thanks, I wasn't aware of this proposal. I can probably improve this patch some more, so that the default settings from the current installation are reflected.

Aug 3 2023, 6:17 PM
khorben_defora.org updated the diff for D41298: bsdinstall: revisit the finalconfig step.

Respect the original copyright for the "finalconfig" code.

Aug 3 2023, 3:45 PM
khorben_defora.org updated the test plan for D41298: bsdinstall: revisit the finalconfig step.
Aug 3 2023, 3:42 PM
khorben_defora.org updated the summary of D41298: bsdinstall: revisit the finalconfig step.
Aug 3 2023, 3:41 PM
khorben_defora.org requested review of D41298: bsdinstall: revisit the finalconfig step.
Aug 3 2023, 3:40 PM
khorben_defora.org updated the diff for D41293: openssl: Vendor import of OpenSSL-3.0.10.

Fix the brief summary in the commit

Aug 3 2023, 2:27 PM

Aug 2 2023

khorben_defora.org added a comment to D41293: openssl: Vendor import of OpenSSL-3.0.10.

review heading is wrong?

Aug 2 2023, 6:45 PM
khorben_defora.org retitled D41293: openssl: Vendor import of OpenSSL-3.0.10 from openssl: Vendor import of OpenSSL-3.0.9 to openssl: Vendor import of OpenSSL-3.0.10.
Aug 2 2023, 6:44 PM
khorben_defora.org added reviewers for D41293: openssl: Vendor import of OpenSSL-3.0.10: ngie, emaste, jkim.
Aug 2 2023, 5:13 PM
khorben_defora.org requested review of D41293: openssl: Vendor import of OpenSSL-3.0.10.
Aug 2 2023, 5:12 PM

Aug 1 2023

khorben_defora.org added a comment to D41250: hardening: remember the answers to each item.

Or let's just let this abomination of a menu finally die...

Aug 1 2023, 9:00 AM

Jul 31 2023

khorben_defora.org added a comment to D41250: hardening: remember the answers to each item.

FYI: D40142

I do not know what the hesitation is there, but I know several people would prefer to see this menu disappear completely.

Jul 31 2023, 6:22 PM
khorben_defora.org updated the diff for D41250: hardening: remember the answers to each item.

With this additional change, the previous settings for all 9 possible hardening options are restored when canceling this menu.

Jul 31 2023, 6:19 PM
khorben_defora.org added a comment to D41250: hardening: remember the answers to each item.

Another improvement would be to add a "Cancel" button to this step, and keep the settings as they were before entering the dialog.

Jul 31 2023, 5:57 PM
khorben_defora.org updated the test plan for D41250: hardening: remember the answers to each item.
Jul 31 2023, 5:48 PM