User Details
- User Since
- Apr 26 2023, 1:30 PM (6 w, 2 d)
Mon, Jun 5
openssl: Enable support for RFC3779
openssl: Fix typos in manual pages
openssl: Limit the changes to obsolete files to us
Sun, Jun 4
Thu, Jun 1
Wed, May 31
The documentation from OpenSSL 3 is more clear about the behaviour of OPENSSL_init_crypto() with regard to the OPENSSL_INIT_LOAD_CONFIG option:
With this option an OpenSSL configuration file will be automatically loaded and used by calling OPENSSL_config(). This is a default option. Note that in OpenSSL 1.1.1 this was the default for libssl but not for libcrypto (see OPENSSL_init_ssl(3) for further details about libssl initialisation). In OpenSSL 1.1.0 this was a nondefault option for both libssl and libcrypto. See the description of OPENSSL_INIT_new(), below.
In the case of dumpon (similar situation), I found that some initialisation code is in .init in libcrypto.so. I think it comes from ossl_init_base() which in turns calls OPENSSL_cpuid_setup() (caught in gdb below). If I understand it correctly, OPENSSL_init_crypto() makes sure ossl_init_base() has been called or calls it explicitly. But then OPENSSL_init_crypto() also does more than that, and I do not see it being called at all here.
The documentation also says "This is not a default option for libcrypto." and this call is for libcrypto (OPENSSL_init_crypto() and not OPENSSL_init_ssl()) so @def is probably right.
Are you sure that it is still necessary to call OPENSSL_init_crypto() before entering capability mode?
OpenSSL 1.1 seems to use getentropy(3) on FreeBSD >= 12, or arc4rand(9) otherwise (through sysctl).
Anyway, better safe than sorry.
Thu, May 25
LGTM; and this also builds fine with OpenSSL 3.0.8 in src.
Wed, May 24
With these changes applied on d1639e43c589644510198dc53aef87e8908a1507 (latest main) the build fails for me in usr.bin/drill:
Tue, May 23
Reviewed with https://reviews.freebsd.org/D39832 instead.
I have added this to lib/libldns/Makefile to fix the build with GCC 12, as caught by the CI:
+CWARNFLAGS.parse.c= ${NO_WUSE_AFTER_FREE}
The build with GCC 12 now fails somewhere else (cddl/lib/libzpool) so I suppose this covers ldns.
Apr 26 2023
Remove the WWW line in pkg-descr.
Remove the patch for the Makefile.