Page MenuHomeFreeBSD
Differential D45401

bhyve: avoid a potential deadlock
ClosedPublic
Actions

Authored by khorben_defora.org on May 29 2024, 3:49 PM.
Tags
None
Referenced Files
F104377279: D45401.id139191.diff
Fri, Dec 6, 9:00 PM
Unknown Object (File)
Sat, Nov 30, 5:52 PM
Unknown Object (File)
Mon, Nov 25, 4:27 PM
Unknown Object (File)
Mon, Nov 25, 4:27 PM
Unknown Object (File)
Sun, Nov 24, 3:18 AM
Unknown Object (File)
Sat, Nov 23, 2:13 AM
Unknown Object (File)
Thu, Nov 21, 7:19 PM
Unknown Object (File)
Thu, Nov 21, 7:13 AM
View All Files
Subscribers
bcran
rgrimes

Details

Reviewers
imp
corvink
markj
Group Reviewers
bhyve
Commits
rG1616f7d4b57b: bhyve: avoid a potential deadlock
rG1f3bfc60550c: bhyve: avoid a potential deadlock
Summary

This unlocks a mutex in an error path, that would otherwise remain locked and potentially cause a deadlock later on.

Reported by: Coverity Scan
CID: 1521334
Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

khorben_defora.org created this revision.May 29 2024, 3:49 PM
Herald added a reviewer: bhyve. · View Herald TranscriptMay 29 2024, 3:49 PM
Herald added subscribers: bcran, rgrimes. · View Herald Transcript
khorben_defora.org requested review of this revision.May 29 2024, 3:49 PM
khorben_defora.org edited the summary of this revision. (Show Details)May 29 2024, 3:52 PM
markj accepted this revision as: markj.May 29 2024, 8:39 PM
This revision is now accepted and ready to land.May 29 2024, 8:39 PM
corvink accepted this revision.Jun 3 2024, 5:57 AM
corvink added a comment.Aug 2 2024, 9:42 AM

What's CID: 1521334?

khorben_defora.org added a comment.Aug 2 2024, 9:43 AM
In D45401#1053575, @corvink wrote:

What's CID: 1521334?

It's the identifier from Coverity for the vulnerability reported.

Closed by commit rG1f3bfc60550c: bhyve: avoid a potential deadlock (authored by khorben_defora.org, committed by corvink). · Explain WhyAug 5 2024, 8:01 AM
This revision was automatically updated to reflect the committed changes.
corvink added a commit: rG1f3bfc60550c: bhyve: avoid a potential deadlock.
corvink added a commit: rG1616f7d4b57b: bhyve: avoid a potential deadlock.Tue, Nov 12, 7:56 AM

Revision Contents
Changeset List

PathSize
usr.sbin/
bhyve/
4 lines

Diff 141820

View Options

usr.sbin/bhyve/tpm_intf_crb.c

Loading...