Page MenuHomeFreeBSD

bcran (Rebecca Cran)
Software Engineer

Projects

User Details

User Since
May 9 2014, 11:24 PM (262 w, 2 d)

Recent Activity

Wed, May 1

bcran committed rP500603: Improve the comment and description for sysutils/uefi-edk2-qemu.
Improve the comment and description for sysutils/uefi-edk2-qemu
Wed, May 1, 6:22 PM

Tue, Apr 30

bcran added a comment to D19869: Add a new uefi-edk2-qemu port..
In D19869#432543, @mat wrote:

Approved with the changes requested.

Tue, Apr 30, 4:43 PM
bcran committed rP500503: sysutils/uefi-edk2-qemu: add new port.
sysutils/uefi-edk2-qemu: add new port
Tue, Apr 30, 4:25 PM
bcran closed D19869: Add a new uefi-edk2-qemu port..
Tue, Apr 30, 4:25 PM

Mon, Apr 29

bcran accepted D20016: Fallback booting pieces.
Mon, Apr 29, 2:26 AM

Sat, Apr 27

bcran added a comment to D20016: Fallback booting pieces.

Could you explain what problem this is solving, please? I don't think I've had a problem with loader.efi finding the FreeBSD installation to boot from.

Sat, Apr 27, 10:37 PM

Fri, Apr 26

bcran closed D20074: Fix tools/boot/ci-qemu-test.sh and make some improvements.
Fri, Apr 26, 2:44 PM
bcran committed rS346748: Fix tools/boot/ci-qemu-test.sh and make some improvements.
Fix tools/boot/ci-qemu-test.sh and make some improvements
Fri, Apr 26, 2:44 PM
bcran updated the summary of D20074: Fix tools/boot/ci-qemu-test.sh and make some improvements.
Fri, Apr 26, 2:30 PM
bcran retitled D20074: Fix tools/boot/ci-qemu-test.sh and make some improvements from Update ci-qemu-test.sh - Update the path to the OVMF file, which is now in /usr/local/share/uefi-edk2-qemu. - Use the more modern q35, pc-q35-3.0 (Q35 + ICH9, 2009) QEMU machine instead of the default, obsolete pc, pc-i440fx-3.0 (i440FX + PIIX... to Fix tools/boot/ci-qemu-test.sh and make some improvements.
Fri, Apr 26, 2:29 PM
bcran created D20074: Fix tools/boot/ci-qemu-test.sh and make some improvements.
Fri, Apr 26, 2:27 PM
bcran added inline comments to D19869: Add a new uefi-edk2-qemu port..
Fri, Apr 26, 1:42 PM
bcran updated the diff for D19869: Add a new uefi-edk2-qemu port..
  • MAKE_ARGS should be =, not += .
Fri, Apr 26, 1:39 PM
bcran updated the diff for D19869: Add a new uefi-edk2-qemu port..
  • Remove duplicated and unneeded lines.
Fri, Apr 26, 1:37 PM

Thu, Apr 25

bcran accepted D20054: Document the UEFI boot loading process.
Thu, Apr 25, 2:48 PM
bcran added inline comments to D20054: Document the UEFI boot loading process.
Thu, Apr 25, 2:48 PM
bcran closed D19914: ACPI SPCR: handle BaudRate=0.
Thu, Apr 25, 2:17 AM · arm64
bcran committed rS346657: ACPI SPCR: handle BaudRate=0.
ACPI SPCR: handle BaudRate=0
Thu, Apr 25, 2:17 AM

Wed, Apr 24

bcran accepted D19914: ACPI SPCR: handle BaudRate=0.
Wed, Apr 24, 10:48 PM · arm64
bcran committed rS346646: Fix install-boot.sh and rootgen.sh UEFI bugs.
Fix install-boot.sh and rootgen.sh UEFI bugs
Wed, Apr 24, 10:35 PM
bcran closed D19992: Fix install-boot.sh to work with rootgen.sh.
Wed, Apr 24, 10:35 PM
bcran updated the diff for D19992: Fix install-boot.sh to work with rootgen.sh.
Wed, Apr 24, 6:41 PM

Tue, Apr 23

bcran added inline comments to D19869: Add a new uefi-edk2-qemu port..
Tue, Apr 23, 5:49 PM
bcran added inline comments to D20016: Fallback booting pieces.
Tue, Apr 23, 2:12 AM
bcran added a comment to D19992: Fix install-boot.sh to work with rootgen.sh.

Could people review this again for the changes I've made, please?

Tue, Apr 23, 12:57 AM

Mon, Apr 22

bcran added inline comments to D20016: Fallback booting pieces.
Mon, Apr 22, 9:32 PM

Sun, Apr 21

bcran added inline comments to D19869: Add a new uefi-edk2-qemu port..
Sun, Apr 21, 5:49 PM
bcran added inline comments to D19992: Fix install-boot.sh to work with rootgen.sh.
Sun, Apr 21, 5:01 AM
bcran updated the diff for D19992: Fix install-boot.sh to work with rootgen.sh.
  • Change the install-boot.sh option to -u to cause it to run efibootmgr etc.
Sun, Apr 21, 5:00 AM
bcran added a comment to D19992: Fix install-boot.sh to work with rootgen.sh.
In D19992#429688, @imp wrote:

It's a persistent communication mechanism that can be used to configure behavior in the boot loader that might otherwise be controlled via UEFI variables.

Sun, Apr 21, 12:59 AM
bcran added a comment to D19992: Fix install-boot.sh to work with rootgen.sh.
In D19992#429679, @imp wrote:

I've also started to create a 'fallback loader' path to try to hash out a good design. I'm thinking that a good design might be to have loader.efi read in \efi\freebsd\loader.env and parse it like the command line with foo=bar variables. This would let us say uefi_rootdev=HD(3,GPT,0f91d7c6-2de5-11e8-b5f1-3cfdfe9d5250,0x619430,0x600000) and have that become / for the new system. The only downside to this is that we have to encode the size and offset of the partition into the device path which doesn't play well with the auto resize code, though we could hack that to update this env :)

Sun, Apr 21, 12:41 AM
bcran added inline comments to D19992: Fix install-boot.sh to work with rootgen.sh.
Sun, Apr 21, 12:40 AM

Sat, Apr 20

bcran updated the diff for D19992: Fix install-boot.sh to work with rootgen.sh.
  • Revert unrelated change
Sat, Apr 20, 8:54 PM
bcran created D19992: Fix install-boot.sh to work with rootgen.sh.
Sat, Apr 20, 8:50 PM

Apr 19 2019

bcran updated the diff for D19869: Add a new uefi-edk2-qemu port..
  • Make changes learned from feedback on D19875 from @mat .
Apr 19 2019, 2:42 AM

Apr 15 2019

bcran updated the diff for D19869: Add a new uefi-edk2-qemu port..
  • Fix portlint errors
Apr 15 2019, 10:50 PM
bcran added a comment to D19869: Add a new uefi-edk2-qemu port..
In D19869#428001, @manu wrote:

There is a lots of portlint error :
FATAL: Makefile: extra item "FLAVORS" placed in the MAINTAINER section.
FATAL: Makefile: extra item "x86_64_PKGNAMESUFFIX" placed in the MAINTAINER section.
FATAL: Makefile: extra item "i386_PKGNAMESUFFIX" placed in the MAINTAINER section.
WARN: Makefile: COMMENT is set externally to this port's Makefile, but this port is not configured as a slave port.
FATAL: Makefile: extra item "MAINTAINER" placed in the LICENSE section.
FATAL: Makefile: extra item "COMMENT" placed in the LICENSE section.
WARN: Makefile: "LICENSE" has to appear earlier.
WARN: Makefile: "ONLY_FOR_ARCHS" has to appear earlier.
WARN: Makefile: "BUILD_DEPENDS" has to appear earlier.
WARN: Makefile: "USES" has to appear earlier.
5 fatal errors and 5 warnings found.

Apr 15 2019, 10:49 PM
bcran added inline comments to D19869: Add a new uefi-edk2-qemu port..
Apr 15 2019, 10:48 PM

Apr 14 2019

bcran added inline comments to D19875: Add sysutils/uefi-edk2-bhyve-devel based on branch bhyve/edk2-stable201903.
Apr 14 2019, 7:40 PM
bcran accepted D19875: Add sysutils/uefi-edk2-bhyve-devel based on branch bhyve/edk2-stable201903.
Apr 14 2019, 7:39 PM
bcran added inline comments to D19869: Add a new uefi-edk2-qemu port..
Apr 14 2019, 5:05 AM
bcran updated the summary of D19869: Add a new uefi-edk2-qemu port..
Apr 14 2019, 5:04 AM
bcran updated the diff for D19869: Add a new uefi-edk2-qemu port..
  • Add support for building i386 as a FLAVOR
  • Install files to share/uefi-edk2-qemu instead of uefi-firmware
Apr 14 2019, 5:02 AM

Apr 13 2019

bcran added a comment to D19869: Add a new uefi-edk2-qemu port..
In D19869#426787, @jhb wrote:

In this case though it isn't the host arch (ARCH) but a target architecture for the binary blob. That does seem like something flavors would handle, but slave ports also work. I thought part of the point of flavors was to make it easier to not have slave ports by encapsulating all the slave ports in a single port.

From what I can see, FLAVORS would work great for the two architectures OVMF runs on, X64 and IA32, but it doesn't work in the situation that someone wants to run X64 OVMF on qemu on their physical ARM64 machine. For that I think I need to figure out the set of cross-tools (aarch64 -> x64) that are needed and add them to the main Makefile.
I've made some progress on that: a BaseTools fix is now upstream (on master), and next will probably be creating a gcc-x64 port to cross-compile OvmfPkg.

Apr 13 2019, 11:25 PM
bcran added a comment to D19869: Add a new uefi-edk2-qemu port..
In D19869#426787, @jhb wrote:

In this case though it isn't the host arch (ARCH) but a target architecture for the binary blob. That does seem like something flavors would handle, but slave ports also work. I thought part of the point of flavors was to make it easier to not have slave ports by encapsulating all the slave ports in a single port.

Apr 13 2019, 11:24 PM

Apr 11 2019

bcran added inline comments to D19869: Add a new uefi-edk2-qemu port..
Apr 11 2019, 3:37 AM
bcran updated the diff for D19869: Add a new uefi-edk2-qemu port..
  • Add port to sysutils Makefile and split PLIST_FILES over two lines.
Apr 11 2019, 3:36 AM
bcran added inline comments to D19869: Add a new uefi-edk2-qemu port..
Apr 11 2019, 3:32 AM

Apr 10 2019

bcran added a comment to D19869: Add a new uefi-edk2-qemu port..
In D19869#426769, @manu wrote:

As for the installed file I don't know which is better between :
${LOCALBASE}/share/uefi-firmware-${ARCH} and ${LOCALBASE}/share/uefi-firmware/<filename>-${ARCH}
But uefi-firmware seems vague no ? maybe ${LOCALBASE}/share/uefi-edk2-qemu/ ?

Apr 10 2019, 6:07 PM
bcran added a comment to D19875: Add sysutils/uefi-edk2-bhyve-devel based on branch bhyve/edk2-stable201903.

I did only smoke tests!! Do you mind do additional tests with different guests?

Apr 10 2019, 5:56 PM
bcran added inline comments to D19875: Add sysutils/uefi-edk2-bhyve-devel based on branch bhyve/edk2-stable201903.
Apr 10 2019, 5:54 PM
bcran added a comment to D19869: Add a new uefi-edk2-qemu port..

I think you will need to rename all the port, not only the PORTNAME.

Apr 10 2019, 3:19 PM
bcran updated the diff for D19869: Add a new uefi-edk2-qemu port..
  • Rename port
Apr 10 2019, 3:18 PM
bcran added inline comments to D19869: Add a new uefi-edk2-qemu port..
Apr 10 2019, 3:16 PM
bcran updated the diff for D19869: Add a new uefi-edk2-qemu port..
  • Rename the port and files to include a -x86_64 suffix
Apr 10 2019, 3:12 PM
bcran added inline comments to D19869: Add a new uefi-edk2-qemu port..
Apr 10 2019, 2:34 PM
bcran added inline comments to D19869: Add a new uefi-edk2-qemu port..
Apr 10 2019, 4:50 AM
bcran added inline comments to D19869: Add a new uefi-edk2-qemu port..
Apr 10 2019, 1:31 AM

Apr 9 2019

bcran updated the diff for D19869: Add a new uefi-edk2-qemu port..
  • Use ${GCC_DEFAULT} to avoid hard-coding the GCC version.
Apr 9 2019, 10:09 PM
bcran updated the summary of D19869: Add a new uefi-edk2-qemu port..
Apr 9 2019, 9:39 PM
bcran created D19869: Add a new uefi-edk2-qemu port..
Apr 9 2019, 9:36 PM

Apr 8 2019

bcran accepted D19400: attempt to load vmm.ko if it's not already loaded (bhyveload).
Apr 8 2019, 9:55 PM
bcran accepted D19840: Style only change: Prefer $() to ``.
Apr 8 2019, 4:51 AM

Apr 2 2019

bcran added a comment to D19787: bhyve: Stop compiling with -O0..
Apr 2 2019, 2:45 AM
bcran added a member for arm64: bcran.
Apr 2 2019, 2:44 AM
bcran added a watcher for bugmeister: bcran.
Apr 2 2019, 2:42 AM
bcran added a member for bhyve: bcran.
Apr 2 2019, 2:42 AM
bcran accepted D19786: bhyve: Fix indentation in uart_emul.c.
Apr 2 2019, 2:41 AM
bcran added a comment to D19787: bhyve: Stop compiling with -O0..

I think we should probably keep this, since by default EDK2 DEBUG builds are built with optimization enabled, which obviously makes debugging via gdb etc. irritating/difficult.
I always have to add -O0 to let me single step through the firmware.

Apr 2 2019, 2:37 AM

Mar 24 2019

bcran added a comment to D19588: Add a new efi-update-loader script and associated man page.

I may have missed it, but will the script or its use during installworld avoid
updating the amd64 EFI area when cross-installing a world that is not
intended to be bootable? If yes, how?

Mar 24 2019, 11:43 PM

Mar 21 2019

bcran updated the diff for D19588: Add a new efi-update-loader script and associated man page.

Fix bugs caused by setting ${esppath} and not unsetting ${espdev}.

Mar 21 2019, 2:08 AM
bcran updated the diff for D19588: Add a new efi-update-loader script and associated man page.
  • Allow use of an ESP that's mounted read-only.
Mar 21 2019, 1:54 AM

Mar 20 2019

bcran added inline comments to D19588: Add a new efi-update-loader script and associated man page.
Mar 20 2019, 7:21 PM
bcran updated the test plan for D19588: Add a new efi-update-loader script and associated man page.
Mar 20 2019, 3:53 AM
bcran updated the diff for D19588: Add a new efi-update-loader script and associated man page.
  • Bug fixes
Mar 20 2019, 3:52 AM
bcran added inline comments to D19588: Add a new efi-update-loader script and associated man page.
Mar 20 2019, 12:28 AM
bcran added inline comments to D19588: Add a new efi-update-loader script and associated man page.
Mar 20 2019, 12:27 AM
bcran updated the diff for D19588: Add a new efi-update-loader script and associated man page.
  • Allow an ESP that's already mounted to be updated.
Mar 20 2019, 12:26 AM

Mar 18 2019

bcran added inline comments to D19588: Add a new efi-update-loader script and associated man page.
Mar 18 2019, 3:45 AM
bcran added inline comments to D19588: Add a new efi-update-loader script and associated man page.
Mar 18 2019, 3:39 AM
bcran added inline comments to D19588: Add a new efi-update-loader script and associated man page.
Mar 18 2019, 3:37 AM
bcran updated the summary of D19588: Add a new efi-update-loader script and associated man page.
Mar 18 2019, 3:36 AM
bcran updated the diff for D19588: Add a new efi-update-loader script and associated man page.

Address review comments.
Only ever update /EFI/BOOT/BOOT${arch}.efi and /EFI/FreeBSD/loader.efi if they already exist and are
the BOOT${arch}.efi file is a FreeBSD boot1.efi or loader.efi.

Mar 18 2019, 3:34 AM
bcran added inline comments to D19588: Add a new efi-update-loader script and associated man page.
Mar 18 2019, 3:11 AM

Mar 17 2019

bcran added inline comments to D19588: Add a new efi-update-loader script and associated man page.
Mar 17 2019, 4:36 PM
bcran added inline comments to D19588: Add a new efi-update-loader script and associated man page.
Mar 17 2019, 4:17 AM
bcran updated the summary of D19588: Add a new efi-update-loader script and associated man page.
Mar 17 2019, 3:16 AM
bcran updated the summary of D19588: Add a new efi-update-loader script and associated man page.
Mar 17 2019, 3:12 AM
bcran updated the diff for D19588: Add a new efi-update-loader script and associated man page.
  • Fix usage output, try and improve some variable names
Mar 17 2019, 3:06 AM
bcran updated the diff for D19588: Add a new efi-update-loader script and associated man page.

Changed the autodetect code to look for all ESPs associated with the root filesystem.

Mar 17 2019, 2:38 AM

Mar 15 2019

bcran added a comment to D19588: Add a new efi-update-loader script and associated man page.

I think, what you need to establish first is what this script is for and what are the use cases. If we are running it from installer, it must only install boot programs on target disk(s). If it is meant to be used as generic update current boot disks, then it has to discover disks related to current root file system. The least we want to happen is that some random disk will get updated.

Mar 15 2019, 3:12 PM
bcran added a comment to D19588: Add a new efi-update-loader script and associated man page.

I'm thinking that instead of looking at all disks in the system it should perhaps only check the disk that contains the root filesystem.
That would avoid the case where for example the script would try and update the install media plugged into a USB port.

Mar 15 2019, 5:09 AM
bcran created D19588: Add a new efi-update-loader script and associated man page.
Mar 15 2019, 3:20 AM

Mar 7 2019

bcran committed rS344862: Document the efivar --load-option option.
Document the efivar --load-option option
Mar 7 2019, 12:01 AM
bcran closed D19263: Document the efivar --load-option option.
Mar 7 2019, 12:01 AM

Mar 6 2019

bcran committed rS344839: Add retry loop around GetMemoryMap call to fix fragmentation bug.
Add retry loop around GetMemoryMap call to fix fragmentation bug
Mar 6 2019, 5:39 AM
bcran closed D19341: Add retry loop around GetMemoryMap call to fix fragmentation bug.
Mar 6 2019, 5:39 AM
bcran added inline comments to D19341: Add retry loop around GetMemoryMap call to fix fragmentation bug.
Mar 6 2019, 5:09 AM

Mar 5 2019

bcran added a comment to D19263: Document the efivar --load-option option.

I like that idea. Except perhaps write BOOT_OPTION as Boot Option.

Mar 5 2019, 7:25 AM
bcran updated the diff for D19341: Add retry loop around GetMemoryMap call to fix fragmentation bug.
  • Remove alignment of sz and rename mmsz to dsz (to match copy.c).
  • Update copy.c to use dsz instead of sizeof(EFI_MEMORY_DESCRIPTOR).
Mar 5 2019, 4:36 AM