Page MenuHomeFreeBSD

bcran (Rebecca Cran)
Software Engineer

Projects

User Details

User Since
May 9 2014, 11:24 PM (370 w, 6 d)

Recent Activity

Mon, May 31

bcran added a comment to D26976: bhyve - ARMv8 implementation.

I tested the code from https://github.com/FreeBSD-UPB/freebsd-src/tree/projects/bhyvearm64/ (as of 2021-05-29) on my SolidRun Honeycomb system and it fails to allocate resources in the gicv3 code when I run kldload vmm.

Mon, May 31, 5:50 AM

May 11 2021

bcran added inline comments to D30212: sysutils/uefi-edk2-xen: introduce port.
May 11 2021, 3:25 PM

May 2 2021

bcran added a comment to D30050: Adds uuid validation to bhyve(8) arg parsing.

With examples like Apple's "goto fail" bug (https://www.imperialviolet.org/2014/02/22/applebug.html) I'm surprised style(9) only allows, and doesn't recommend or mandate braces around single-line statements.

May 2 2021, 11:20 PM
bcran closed D30075: Update sysutils/uefi-edk2-bhyve to edk2-stable202002 release.
May 2 2021, 5:09 PM
bcran committed R11:4cec3f9086f3: sysutils/uefi-edk2-bhyve: Update to edk2-stable202002 tag (authored by bcran).
sysutils/uefi-edk2-bhyve: Update to edk2-stable202002 tag
May 2 2021, 5:09 PM
bcran requested review of D30075: Update sysutils/uefi-edk2-bhyve to edk2-stable202002 release.
May 2 2021, 1:50 AM

Apr 9 2021

bcran added a comment to D29657: bhyve: add SMBIOS Baseboard Information.

I noticed this is against the svn repo:

Repository rS FreeBSD src repository - subversion"

You'll probably want to switch over to Git and rebase this patch.

Apr 9 2021, 4:41 PM
bcran accepted D29657: bhyve: add SMBIOS Baseboard Information.

Just a comment typo: "number of contained objecct handles" - should be "object".

Apr 9 2021, 4:38 PM

Mar 28 2021

bcran closed D29254: sysutils/uefi-edk2-bhyve-csm: only depend on gcc48 for building.
Mar 28 2021, 4:43 AM
bcran committed rP569373: sysutils/uefi-edk2-bhyve-csm: only depend on gcc48 for building.
sysutils/uefi-edk2-bhyve-csm: only depend on gcc48 for building
Mar 28 2021, 4:43 AM

Mar 24 2021

bcran added a comment to D29254: sysutils/uefi-edk2-bhyve-csm: only depend on gcc48 for building.

@manu Sorry, could you re-approve the change please?

Mar 24 2021, 7:58 PM

Mar 20 2021

bcran added a comment to D29254: sysutils/uefi-edk2-bhyve-csm: only depend on gcc48 for building.
In D29254#656248, @manu wrote:

OK I see. Well for now just have a build time dep is better then.
Go ahead and commit this.

Mar 20 2021, 10:24 PM
bcran updated the diff for D29254: sysutils/uefi-edk2-bhyve-csm: only depend on gcc48 for building.

We'll also need to update the port revision.

Mar 20 2021, 10:24 PM

Mar 16 2021

bcran added a comment to D29254: sysutils/uefi-edk2-bhyve-csm: only depend on gcc48 for building.
In D29254#655711, @manu wrote:

Is the 4.8 version required for something ? Otherwise depending on lang/gcc would be better (not really sure if we have some way to do that).

Mar 16 2021, 12:03 PM
bcran added a comment to D29254: sysutils/uefi-edk2-bhyve-csm: only depend on gcc48 for building.

@woodsb02 Could you review and approve this for me, please?

Mar 16 2021, 4:03 AM

Mar 14 2021

bcran added a reviewer for D29254: sysutils/uefi-edk2-bhyve-csm: only depend on gcc48 for building: bhyve.
Mar 14 2021, 5:36 AM
bcran requested review of D29254: sysutils/uefi-edk2-bhyve-csm: only depend on gcc48 for building.
Mar 14 2021, 5:34 AM

Feb 18 2021

bcran added a comment to D19976: bhyve: Support a _VARS.fd file for bootrom.

Now the firmware work has been committed, I'll switch back to working on this.

Feb 18 2021, 3:46 AM
bcran closed D27230: Update bhyve related ports.
Feb 18 2021, 3:02 AM
bcran added a comment to D27230: Update bhyve related ports.

Committed as r565866.

Feb 18 2021, 3:02 AM
bcran committed rP565866: sysutils/uefi-edk2-bhyve*: Update and migrate to Python 3.
sysutils/uefi-edk2-bhyve*: Update and migrate to Python 3
Feb 18 2021, 2:57 AM

Feb 16 2021

bcran added a comment to D27230: Update bhyve related ports.
In D27230#642824, @jhb wrote:

I'm not a ports committer so can't really review the ports part, but I think moving the non-CSM ROM to the newer one seems fine. I think grehan@ has also already signed off on this?

Feb 16 2021, 8:34 PM

Feb 15 2021

bcran added a comment to D27230: Update bhyve related ports.

At this point, I'd like to get this committed as soon as possible so we can move away from gcc 4.8 and python 2.

Feb 15 2021, 6:32 AM
bcran updated the diff for D27230: Update bhyve related ports.

Updated to code from today's master, 2021-02-14.

Feb 15 2021, 6:31 AM

Jan 16 2021

bcran updated subscribers of D27970: bhyve: move 64 bit BAR location to match OVMF assumptions.
Jan 16 2021, 6:28 AM · bhyve
bcran added a comment to D27970: bhyve: move 64 bit BAR location to match OVMF assumptions.

The patch no longer applies against 13-CURRENT: I needed to apply several lines manually.

Jan 16 2021, 6:17 AM · bhyve
bcran updated subscribers of D27970: bhyve: move 64 bit BAR location to match OVMF assumptions.

This works for me. I was seeing an assert failure in pci_emul.c, but it disappeared for some reason.
One person on Slack said they'd like the BAR in a fixed (high) location, so I wouldn't be confident committing this without other people (e.g. @jhb and @grehan ) reviewing it too.

Jan 16 2021, 6:16 AM · bhyve

Jan 5 2021

bcran added a comment to D27970: bhyve: move 64 bit BAR location to match OVMF assumptions.

OVMF puts it at the next 16GB boundary, which might be better.

Jan 5 2021, 8:17 PM · bhyve

Dec 28 2020

bcran added a comment to D27782: uefi.8: mention boot1.efi.

Also, /boot/boot1.efifat is no longer included in -CURRENT.

Dec 28 2020, 2:46 PM
bcran added a comment to D27782: uefi.8: mention boot1.efi.

/boot/boot1.efifat is the 800 KB filesystem image. /boot/boot1.efi is the EFI bootloader application.

Dec 28 2020, 2:43 PM

Dec 26 2020

bcran added a comment to D27230: Update bhyve related ports.

UEFI is configuring an address size less than that which the host CPU supports, because (cc @grehan) :

//
// As guest-physical memory size grows, the permanent PEI RAM requirements
// are dominated by the identity-mapping page tables built by the DXE IPL.
// The DXL IPL keys off of the physical address bits advertized in the CPU
// HOB. To conserve memory, we calculate the minimum address width here.
Dec 26 2020, 7:57 AM
bcran added a comment to D27230: Update bhyve related ports.

@c.koehne_beckhoff.com
I see what's going wrong, and have reproduced the issue on my Threadripper system.
EDK2 firmware configures the maximum address based on the size of guest memory, with a minimum of 64GB (36 bits).
But the PCI code in bhyve puts the BAR at (highest host CPU address / 4) - meaning that on my system it puts it at 64TB.

Dec 26 2020, 7:28 AM

Dec 24 2020

bcran added a comment to D27230: Update bhyve related ports.

I successfully installed and ran Windows 10 with the new firmware today.
So I think the last remaining issue will be the MemAbove4G problem.

Dec 24 2020, 8:12 AM

Dec 23 2020

bcran added a comment to D24066: bhyve: support relocating fbuf and passthru data BARs.

The patch no longer applies cleanly: I had to make some changes.
But after that, I was able to run Ubuntu 20.10 with gEfiMdeModulePkgTokenSpaceGuid.PcdPciDisableBusEnumeration set to TRUE and FALSE with the following command line, which uses both rfb and passthru:

bhyve -AH -s 0:0,hostbridge -s 31:0,lpc -c 1 -m 16G -l bootrom,BHYVE_CODE.fd -l com1,stdio -s 3:0,ahci-hd,bhyve-ubuntu-20_10.img  -s 7,ahci-cd, -s 8,virtio-rnd -s 6,virtio-net,tap0 -s 9,fbuf,rfb=10.0.10.117:5900,w=1920,h=1200 -s 10,xhci,tablet -s 11,passthru,24/0/0 -S guest
Dec 23 2020, 7:52 AM · bhyve
bcran added a comment to D27230: Update bhyve related ports.

Apologies for being absent recently - life took over... but I’ll have some time to look at this again between Xmas and New Year.

I've had a report that Windows 10 crashes (bugchecks) with this firmware, so I need to do more testing (on FreeBSD 11, 12 and 13-CURRENT) before committing it.

Any progress fixing this? Would you like to commit the update using one revision older from upstream that didn’t have this issue?

Dec 23 2020, 6:50 AM
bcran added a comment to D24300: Bhyve: SMBIOS bcdrev calculated from major/minor values.

This was fixed in rS359719, so I think this review should be closed.

Dec 23 2020, 6:28 AM

Dec 22 2020

bcran added a comment to D27230: Update bhyve related ports.
Dec 22 2020, 6:23 AM

Dec 14 2020

bcran added a comment to D27230: Update bhyve related ports.

I've uploaded new binaries to https://people.freebsd.org/~bcran/bhyve/BhyveX64-20201213/ .

Dec 14 2020, 6:53 AM
bcran added a comment to D27230: Update bhyve related ports.

I've had a report that Windows 10 crashes (bugchecks) with this firmware, so I need to do more testing (on FreeBSD 11, 12 and 13-CURRENT) before committing it.

Dec 14 2020, 6:26 AM
bcran updated the diff for D27230: Update bhyve related ports.

Update the version to 20201213 and move the GH tag today's sources

Dec 14 2020, 5:50 AM

Dec 13 2020

bcran committed R9:0bf92d5a47ae: Add news about my commit bit. (authored by bcran).
Add news about my commit bit.
Dec 13 2020, 5:49 PM
bcran committed R9:84cb29044355: Add my PGP key. (authored by bcran).
Add my PGP key.
Dec 13 2020, 5:49 PM
bcran committed R9:2a0c64150a83: Move myself from additional contributors to committers list. (authored by bcran).
Move myself from additional contributors to committers list.
Dec 13 2020, 5:34 PM
bcran committed R9:944aabe6614c: Add myself (authored by bcran).
Add myself
Dec 13 2020, 5:34 PM
bcran committed R9:f07e79d8466a: Add myself. (authored by bcran).
Add myself.
Dec 13 2020, 5:34 PM

Dec 5 2020

bcran added a comment to D27230: Update bhyve related ports.

The CSM port shouldn't really default to a debug build, but I can fix that in a later change since it's existing behavior.

Dec 5 2020, 6:10 AM
bcran added a comment to D27230: Update bhyve related ports.

Thanks Ben!

Dec 5 2020, 6:04 AM
bcran added a comment to D27230: Update bhyve related ports.

Oh I also bumped the PORTEPOCH to 2 to make sure the new version of g20201129 is considered greater than the previous 0.2.

Dec 5 2020, 6:02 AM
bcran updated the diff for D27230: Update bhyve related ports.

Fixed the license lines in uefi-edk2-bhyve, since it uses BSD-2-Clause-Patent.

Dec 5 2020, 5:58 AM

Nov 30 2020

bcran added inline comments to D27230: Update bhyve related ports.
Nov 30 2020, 6:05 AM
bcran updated the diff for D27230: Update bhyve related ports.
  • Install BHYVE.fd as BHYVE_UEFI.fd.
  • Switched version to g20201129 and updated github tag to use the

latest code on master, because it includes several important fixes.

Nov 30 2020, 6:05 AM

Nov 27 2020

bcran closed D27348: Fix bhyve type19 SMBIOS handling to avoid losing 4GB.
Nov 27 2020, 8:00 AM
bcran committed rS368093: Fix bhyve SMBIOS type 19 handling to avoid misreporting total RAM amount.
Fix bhyve SMBIOS type 19 handling to avoid misreporting total RAM amount
Nov 27 2020, 8:00 AM
bcran committed rS368092: bhyve: fix smbiostbl.c style issues and add comment about date format.
bhyve: fix smbiostbl.c style issues and add comment about date format
Nov 27 2020, 7:53 AM

Nov 25 2020

bcran added inline comments to D27348: Fix bhyve type19 SMBIOS handling to avoid losing 4GB.
Nov 25 2020, 7:44 AM

Nov 24 2020

bcran added a comment to D27348: Fix bhyve type19 SMBIOS handling to avoid losing 4GB.

This fixes the amount of memory displayed in the UiApp to be the same as passed on the bhyve command line. Otherwise, 8GB gets displayed as 4, 32GB as 28 etc.

Nov 24 2020, 4:53 AM
bcran requested review of D27348: Fix bhyve type19 SMBIOS handling to avoid losing 4GB.
Nov 24 2020, 4:51 AM

Nov 22 2020

bcran updated the diff for D27230: Update bhyve related ports.

Fixed the CSM port so it actually builds with CSM support.

Nov 22 2020, 6:21 AM
bcran added a comment to D27230: Update bhyve related ports.

I've also updated the name/version fields of the uefi-edk2-bhyve port to be:

PORTNAME=	uefi-edk2-bhyve
DISTVERSIONPREFIX=	edk2-stable
DISTVERSION=	202011
PORTEPOCH=	1
Nov 22 2020, 6:08 AM
bcran updated the diff for D27230: Update bhyve related ports.

Restored the uefi-edk2-bhyve-csm port, with contents from the existing
uefi-edk2-bhyve directory. Changed the installed filename to be
BHYVE_UEFI_CSM.fd.

Nov 22 2020, 6:06 AM

Nov 16 2020

bcran added a comment to D27230: Update bhyve related ports.

Can we keep the CSM one until the bitter end, and build it from the existing repo ?

Nov 16 2020, 4:32 AM
bcran added a reviewer for D27230: Update bhyve related ports: bhyve.
Nov 16 2020, 2:12 AM

Nov 15 2020

bcran requested review of D27230: Update bhyve related ports.
Nov 15 2020, 11:24 PM

Nov 13 2020

bcran closed D27147: bhyve: update smbiostbl.c to bump the versions and release dates.
Nov 13 2020, 7:47 PM
bcran committed rS367651: bhyve: update smbiostbl.c to bump the version and release date.
bhyve: update smbiostbl.c to bump the version and release date
Nov 13 2020, 7:47 PM

Nov 11 2020

bcran updated the diff for D27147: bhyve: update smbiostbl.c to bump the versions and release dates.

Use #defines for the version and date.
Only bump the firmware fields.

Nov 11 2020, 2:57 AM

Nov 9 2020

bcran requested review of D27147: bhyve: update smbiostbl.c to bump the versions and release dates.
Nov 9 2020, 4:59 AM

Sep 17 2020

bcran added inline comments to D26428: Initial support for implementing the bootXXX.efi workaround.
Sep 17 2020, 4:27 PM
bcran added a comment to D26428: Initial support for implementing the bootXXX.efi workaround.

I don't consider UEFI to be basic at all, both are completely different. If you would refer to it as firmware, I would agree, but not to UEFI as BIOS.

Sep 17 2020, 4:23 PM

Sep 10 2020

bcran added a comment to D21281: Work around a bug in the EFI HTTP driver.

Thanks for committing this, @scottph! I've been busy with a new job so haven't had time to work on FreeBSD recently.

Sep 10 2020, 3:49 PM

Apr 21 2020

bcran commandeered D19976: bhyve: Support a _VARS.fd file for bootrom.

@scottph has indicated he no longer has the time/interest in working on this, so I'll take over and work to get it committed.

Apr 21 2020, 11:59 PM

Apr 8 2020

bcran accepted D24300: Bhyve: SMBIOS bcdrev calculated from major/minor values.
Apr 8 2020, 3:24 AM

Apr 6 2020

bcran added a comment to D24066: bhyve: support relocating fbuf and passthru data BARs.

Is this with PcdPciDisableBusEnumeration = TRUE in UEFI ?

Apr 6 2020, 2:57 AM · bhyve

Apr 5 2020

bcran added a comment to D19976: bhyve: Support a _VARS.fd file for bootrom.
In D19976#515732, @mat wrote:

Has this been committed yet?

Apr 5 2020, 6:55 PM
bcran added a comment to D19976: bhyve: Support a _VARS.fd file for bootrom.

@scottph Are you still interested in working on this?

Apr 5 2020, 6:54 PM
bcran added a comment to D24066: bhyve: support relocating fbuf and passthru data BARs.
Apr 5 2020, 5:54 PM · bhyve
bcran accepted D24300: Bhyve: SMBIOS bcdrev calculated from major/minor values.
Apr 5 2020, 5:51 PM
bcran accepted D24276: ci-qemu-test.sh: use pkgbase.

Works great here.

Apr 5 2020, 4:32 AM

Mar 31 2020

bcran committed rS359478: Bhyve: fix SMBIOS Type 17 table generation.
Bhyve: fix SMBIOS Type 17 table generation
Mar 31 2020, 2:37 AM
bcran closed D24107: Bhyve: fix SMBIOS Type 17 table generation.
Mar 31 2020, 2:37 AM

Mar 30 2020

bcran added inline comments to D24107: Bhyve: fix SMBIOS Type 17 table generation.
Mar 30 2020, 10:13 PM
bcran updated the summary of D24107: Bhyve: fix SMBIOS Type 17 table generation.
Mar 30 2020, 8:05 PM
bcran updated the test plan for D24107: Bhyve: fix SMBIOS Type 17 table generation.
Mar 30 2020, 8:05 PM
bcran added inline comments to D24107: Bhyve: fix SMBIOS Type 17 table generation.
Mar 30 2020, 8:00 PM
bcran updated the diff for D24107: Bhyve: fix SMBIOS Type 17 table generation.
  • Change comments to C style.
Mar 30 2020, 8:00 PM
bcran added a comment to D24107: Bhyve: fix SMBIOS Type 17 table generation.

@rgrimes Could you approve the latest patch, or provide comments on what should be changed please?

Mar 30 2020, 7:57 PM

Mar 29 2020

bcran added inline comments to D24107: Bhyve: fix SMBIOS Type 17 table generation.
Mar 29 2020, 3:56 PM
bcran updated the diff for D24107: Bhyve: fix SMBIOS Type 17 table generation.

Upload the full patch.

Mar 29 2020, 3:55 PM

Mar 28 2020

bcran updated the diff for D24107: Bhyve: fix SMBIOS Type 17 table generation.
  • Change overflow error to a warning and truncate type 17 memory size.
Mar 28 2020, 11:33 PM
bcran added a comment to D24107: Bhyve: fix SMBIOS Type 17 table generation.

There is no need to error out on overflow here. The type17 isn't used by most o/s's for determining how much memory is available: there is e820, the EFI memory map, etc etc. Perhaps print an error in bhyve, buit there doesn't seem any point in erroring out.

Mar 28 2020, 11:27 PM
bcran updated the diff for D24107: Bhyve: fix SMBIOS Type 17 table generation.
  • Rework type17 generation and error out on overflow.
Mar 28 2020, 4:53 PM
bcran added inline comments to D24107: Bhyve: fix SMBIOS Type 17 table generation.
Mar 28 2020, 4:52 AM
bcran updated the diff for D24107: Bhyve: fix SMBIOS Type 17 table generation.
  • Revert bumping the SMBIOS version.
Mar 28 2020, 4:45 AM
bcran updated the diff for D24107: Bhyve: fix SMBIOS Type 17 table generation.
  • Fixes based on review feedback.
Mar 28 2020, 4:42 AM
bcran added a comment to D24107: Bhyve: fix SMBIOS Type 17 table generation.
In D24107#532393, @jhb wrote:

That is what the 0x7fff value is for when using extended btw, is to report the max possible size for legacy systems. I agree that we should use the non-extended size when it fits.

Mar 28 2020, 4:19 AM
bcran added a comment to D24107: Bhyve: fix SMBIOS Type 17 table generation.
In D24107#532391, @jhb wrote:

Rebecca is it ok with you if I go create a review to do the bcdrev fix?

Mar 28 2020, 3:14 AM

Mar 27 2020

bcran added inline comments to D24107: Bhyve: fix SMBIOS Type 17 table generation.
Mar 27 2020, 12:15 AM

Mar 26 2020

bcran added inline comments to D24107: Bhyve: fix SMBIOS Type 17 table generation.
Mar 26 2020, 11:57 PM
bcran added inline comments to D24107: Bhyve: fix SMBIOS Type 17 table generation.
Mar 26 2020, 11:36 PM
bcran added a comment to D24107: Bhyve: fix SMBIOS Type 17 table generation.

This calculation seems odd, I see later it is overwritten for large memory, cant we just continue to use extended all the time and leave this set at 0x7fff? Never mind, spec says not. Ok how about doing:

Mar 26 2020, 11:34 PM