Page MenuHomeFreeBSD

bcran (Rebecca Cran)
Software Engineer

Projects

User Details

User Since
May 9 2014, 11:24 PM (301 w, 6 d)

Recent Activity

Yesterday

bcran committed rS358183: dtc: remove unknown option printf, since getopt will print it.
dtc: remove unknown option printf, since getopt will print it
Thu, Feb 20, 9:30 PM
bcran closed D23662: dtc: remove unknown option printf, since getopt will print it.
Thu, Feb 20, 9:30 PM

Sat, Feb 15

bcran added a comment to D23662: dtc: remove unknown option printf, since getopt will print it.

This looks fine, but please submit it as a GitHub PR so that it goes through CI (I can't imagine it failing).

Sat, Feb 15, 7:04 PM

Thu, Feb 13

bcran retitled D23662: dtc: remove unknown option printf, since getopt will print it from dtc: unknown getopt option character is in optopt, not ch to dtc: remove unknown option printf, since getopt will print it.
Thu, Feb 13, 6:41 PM
bcran updated the diff for D23662: dtc: remove unknown option printf, since getopt will print it.

Remove the print statement in the default handler.

Thu, Feb 13, 6:41 PM
bcran added a comment to D23662: dtc: remove unknown option printf, since getopt will print it.

change should also go here: https://github.com/davidchisnall/dtc

Thu, Feb 13, 4:22 PM
bcran created D23662: dtc: remove unknown option printf, since getopt will print it.
Thu, Feb 13, 4:03 PM

Sat, Feb 8

bcran committed rP525557: Revert "sysutils/uefi-edk2-bhyve: update to be same as uefi-edk2-bhyve-devel".
Revert "sysutils/uefi-edk2-bhyve: update to be same as uefi-edk2-bhyve-devel"
Sat, Feb 8, 2:55 PM

Fri, Feb 7

bcran closed D23476: sysutils/uefi-edk2-bhyve: update to be same as uefi-edk2-bhyve-devel and delete -devel port.

Committed in https://svnweb.freebsd.org/ports?view=revision&revision=525460 .

Fri, Feb 7, 6:23 AM
bcran committed rP525460: sysutils/uefi-edk2-bhyve: update to be same as uefi-edk2-bhyve-devel.
sysutils/uefi-edk2-bhyve: update to be same as uefi-edk2-bhyve-devel
Fri, Feb 7, 4:44 AM
bcran closed D23486: sysutils/uefi-edk2-qemu: Replace "python2.7" with "${PYTHON_CMD}".
Fri, Feb 7, 2:55 AM
bcran committed rP525458: sysutils/uefi-edk2-qemu: Replace "python2.7" with "${PYTHON_CMD}".
sysutils/uefi-edk2-qemu: Replace "python2.7" with "${PYTHON_CMD}"
Fri, Feb 7, 2:55 AM

Thu, Feb 6

bcran added a comment to D23486: sysutils/uefi-edk2-qemu: Replace "python2.7" with "${PYTHON_CMD}".

@araujo Could you approve my latest changes please? I ran poudriere and put the successful results at:

Thu, Feb 6, 4:41 PM
bcran added a comment to D23476: sysutils/uefi-edk2-bhyve: update to be same as uefi-edk2-bhyve-devel and delete -devel port.

OK, as soon as the poudriere get the results, share it here.

Thu, Feb 6, 7:28 AM
bcran updated the test plan for D23476: sysutils/uefi-edk2-bhyve: update to be same as uefi-edk2-bhyve-devel and delete -devel port.
Thu, Feb 6, 7:28 AM
bcran added a comment to D23476: sysutils/uefi-edk2-bhyve: update to be same as uefi-edk2-bhyve-devel and delete -devel port.

Did you test it using poudriere?

Thu, Feb 6, 6:27 AM
bcran added a comment to D23476: sysutils/uefi-edk2-bhyve: update to be same as uefi-edk2-bhyve-devel and delete -devel port.
In D23476#516323, @mat wrote:

Fine by me.

Thu, Feb 6, 5:16 AM

Wed, Feb 5

bcran retitled D23486: sysutils/uefi-edk2-qemu: Replace "python2.7" with "${PYTHON_CMD}" from sysutils/uefi-edk2-qemu: Replace "python2.7" with "${PYTHON_CMD}" and use ${WRKSRC} consistently. to sysutils/uefi-edk2-qemu: Replace "python2.7" with "${PYTHON_CMD}".
Wed, Feb 5, 7:58 AM
bcran updated the diff for D23486: sysutils/uefi-edk2-qemu: Replace "python2.7" with "${PYTHON_CMD}".

Simplify change to just the PYTHON_CMD fix.

Wed, Feb 5, 7:44 AM
bcran added a comment to D23486: sysutils/uefi-edk2-qemu: Replace "python2.7" with "${PYTHON_CMD}".

How are you testing these changes that you didn't catch this problem before?

Wed, Feb 5, 3:03 AM

Tue, Feb 4

bcran added a comment to D23486: sysutils/uefi-edk2-qemu: Replace "python2.7" with "${PYTHON_CMD}".

And I know there are several problems with the Makefile, which I've learned through my updates to the uefi-edk2-bhyve port. But I'd like to get this fix committed and then, once the changes to uefi-edk2-bhyve are committed I'll fix the issues with this port based on what I've learned.

Tue, Feb 4, 10:00 PM
bcran added a comment to D23486: sysutils/uefi-edk2-qemu: Replace "python2.7" with "${PYTHON_CMD}".

Unfortunately this has broken the port for anyone without python 2.7 installed. Could somebody approve me to commit this fix please?
@araujo @mat ?

Tue, Feb 4, 9:59 PM
bcran added a comment to D23476: sysutils/uefi-edk2-bhyve: update to be same as uefi-edk2-bhyve-devel and delete -devel port.

Thanks for the feedback, and sorry about all the mistakes!

Tue, Feb 4, 4:19 PM
bcran added inline comments to D23476: sysutils/uefi-edk2-bhyve: update to be same as uefi-edk2-bhyve-devel and delete -devel port.
Tue, Feb 4, 4:17 PM
bcran updated the diff for D23476: sysutils/uefi-edk2-bhyve: update to be same as uefi-edk2-bhyve-devel and delete -devel port.
  • Fix some more issues from the review feedback.
Tue, Feb 4, 4:17 PM

Mon, Feb 3

bcran added inline comments to D23476: sysutils/uefi-edk2-bhyve: update to be same as uefi-edk2-bhyve-devel and delete -devel port.
Mon, Feb 3, 10:10 PM
bcran updated the diff for D23476: sysutils/uefi-edk2-bhyve: update to be same as uefi-edk2-bhyve-devel and delete -devel port.
  • MAKE_ARGS should be earlier in the Makefile
Mon, Feb 3, 10:10 PM
bcran updated the diff for D23476: sysutils/uefi-edk2-bhyve: update to be same as uefi-edk2-bhyve-devel and delete -devel port.
  • Fix variables ordering
Mon, Feb 3, 10:06 PM
bcran retitled D23486: sysutils/uefi-edk2-qemu: Replace "python2.7" with "${PYTHON_CMD}" from Replace "python2.7" with "${PYTHON_CMD}" and use ${WRKSRC} consistently. to sysutils/uefi-edk2-qemu: Replace "python2.7" with "${PYTHON_CMD}" and use ${WRKSRC} consistently..
Mon, Feb 3, 5:21 PM
bcran created D23486: sysutils/uefi-edk2-qemu: Replace "python2.7" with "${PYTHON_CMD}".
Mon, Feb 3, 5:21 PM
bcran added a comment to D23476: sysutils/uefi-edk2-bhyve: update to be same as uefi-edk2-bhyve-devel and delete -devel port.

@mat I've updated the Makefile to be similar to sysutils/uefi-edk2-qemu - which involved removing BASH_CMD (replacing it with just 'bash'), removing USE_GCC and some other changes. I'd appreciate feedback about whether these changes are better or worse!

Mon, Feb 3, 5:07 PM
bcran added inline comments to D23476: sysutils/uefi-edk2-bhyve: update to be same as uefi-edk2-bhyve-devel and delete -devel port.
Mon, Feb 3, 5:04 PM
bcran updated the diff for D23476: sysutils/uefi-edk2-bhyve: update to be same as uefi-edk2-bhyve-devel and delete -devel port.
  • Move DEBUG_VARS, DEBUG_VARS_OFF and HTTP_BOOT_VARS to before OPTIONS
Mon, Feb 3, 5:03 PM
bcran updated the diff for D23476: sysutils/uefi-edk2-bhyve: update to be same as uefi-edk2-bhyve-devel and delete -devel port.
  • Remove sysutils/uefi-edk2-bhyve-devel from sysutils/Makefile
Mon, Feb 3, 5:01 PM
bcran updated the diff for D23476: sysutils/uefi-edk2-bhyve: update to be same as uefi-edk2-bhyve-devel and delete -devel port.
  • Update port Makefile to be similar in style to uefi-edk2-qemu
Mon, Feb 3, 5:00 PM
bcran committed rP525010: sysutils/uefi-edk2-qemu: update to edk2-stable201911.
sysutils/uefi-edk2-qemu: update to edk2-stable201911
Mon, Feb 3, 4:57 AM
bcran closed D23466: sysutils/uefi-edk2-qemu: update to edk2-stable201911.
Mon, Feb 3, 4:57 AM
bcran added a comment to D23466: sysutils/uefi-edk2-qemu: update to edk2-stable201911.

If you will remove the port, why botter to update it and trigger hooks around to rebuild the package?
Focus here, if your intention is to remove the package: https://reviews.freebsd.org/D23476

Mon, Feb 3, 3:32 AM
bcran updated the diff for D23476: sysutils/uefi-edk2-bhyve: update to be same as uefi-edk2-bhyve-devel and delete -devel port.
  • Update MOVED to show that uefi-edk2-bhyve-devel is now uefi-edk2-bhyve
Mon, Feb 3, 3:11 AM
bcran created D23476: sysutils/uefi-edk2-bhyve: update to be same as uefi-edk2-bhyve-devel and delete -devel port.
Mon, Feb 3, 3:07 AM
bcran added a comment to D23466: sysutils/uefi-edk2-qemu: update to edk2-stable201911.

Could a ports committer commit this for me, please?

Mon, Feb 3, 2:38 AM

Sun, Feb 2

bcran added a member for Src Committers: bcran.
Sun, Feb 2, 8:58 PM
bcran added inline comments to D23466: sysutils/uefi-edk2-qemu: update to edk2-stable201911.
Sun, Feb 2, 5:51 PM
bcran updated the diff for D23466: sysutils/uefi-edk2-qemu: update to edk2-stable201911.

Remove PORTREVISION.

Sun, Feb 2, 5:50 PM
bcran updated the diff for D23466: sysutils/uefi-edk2-qemu: update to edk2-stable201911.

Revert unrelated change to sysutils/uefi-edk2-bhyve port

Sun, Feb 2, 2:40 AM
bcran created D23466: sysutils/uefi-edk2-qemu: update to edk2-stable201911.
Sun, Feb 2, 2:38 AM

Jan 17 2020

bcran accepted D23232: Fix regression in bsdinstall post r356740 - partedit errno(2) 21 EISDIR.
Jan 17 2020, 7:42 PM

Jan 15 2020

bcran closed D22979: bsdinstall: Use TMPDIR if set.

Fixed in r356740 (https://svnweb.freebsd.org/base?view=revision&revision=356740).

Jan 15 2020, 12:54 AM
bcran committed rS356740: bsdinstall: Use TMPDIR if set.
bsdinstall: Use TMPDIR if set
Jan 15 2020, 12:45 AM

Jan 14 2020

bcran added a comment to D22979: bsdinstall: Use TMPDIR if set.

Thank you! :)

Jan 14 2020, 5:55 PM

Jan 6 2020

bcran added a comment to D22979: bsdinstall: Use TMPDIR if set.

@bcran Thanks! Would you mind committing this for me? I don't have the bit.

Jan 6 2020, 4:06 PM

Jan 2 2020

bcran accepted D22979: bsdinstall: Use TMPDIR if set.
Jan 2 2020, 3:05 AM

Nov 19 2019

bcran accepted D22432: Add --esp/-E argument to print the currently booted ESP.
Nov 19 2019, 12:24 AM

Oct 17 2019

bcran accepted D22062: Allow loader.efi to identify non-standard boot setup.
Oct 17 2019, 8:31 PM
bcran added a comment to D22062: Allow loader.efi to identify non-standard boot setup.
Oct 17 2019, 8:19 PM

Oct 9 2019

bcran accepted D21930: fix ESP generation for ZFS boot.
Oct 9 2019, 1:39 AM

Sep 27 2019

bcran committed rS352788: MFC r344839:.
MFC r344839:
Sep 27 2019, 5:12 AM

Sep 14 2019

bcran requested changes to D21655: efipart: use page-aligned buffer for BlockIO.
Sep 14 2019, 3:15 PM
bcran added a comment to D21655: efipart: use page-aligned buffer for BlockIO.

Actually yes, this change isn't correct. See https://github.com/tianocore/edk2/blob/master/MdePkg/Library/UefiMemoryAllocationLib/MemoryAllocationLib.c for an example of how to allocate aligned memory (InternalAllocateAlignedPages etc.)

Sep 14 2019, 3:14 PM
bcran accepted D21655: efipart: use page-aligned buffer for BlockIO.
Sep 14 2019, 2:24 AM

Sep 11 2019

bcran committed rP511820: sysutils/uefi-edk2-qemu: Depend on the gcc${GCC_DEFAULT} binary.
sysutils/uefi-edk2-qemu: Depend on the gcc${GCC_DEFAULT} binary
Sep 11 2019, 12:38 PM
bcran closed D21601: Depend on the gcc${GCC_DEFAULT} binary, since only lang/gcc installs gcc..
Sep 11 2019, 12:38 PM

Sep 10 2019

bcran created D21601: Depend on the gcc${GCC_DEFAULT} binary, since only lang/gcc installs gcc..
Sep 10 2019, 9:48 PM
bcran added a comment to D21580: sysutils/uefi-edk2-qemu: GCC should be a build dependency, not runtime.

You have my approve to commit it! Thank you!

Sep 10 2019, 1:52 AM
bcran committed rP511727: sysutils/uefi-edk2-qemu: GCC should be a build dependency, not runtime.
sysutils/uefi-edk2-qemu: GCC should be a build dependency, not runtime
Sep 10 2019, 1:52 AM
bcran closed D21580: sysutils/uefi-edk2-qemu: GCC should be a build dependency, not runtime.
Sep 10 2019, 1:52 AM
bcran added a comment to D21580: sysutils/uefi-edk2-qemu: GCC should be a build dependency, not runtime.

USE_GCC will set build-time and run-time dependency, if we need only build-time dependency the patch looks good to me.

Sep 10 2019, 1:46 AM

Sep 9 2019

bcran updated the diff for D21580: sysutils/uefi-edk2-qemu: GCC should be a build dependency, not runtime.

Fix USES.

Sep 9 2019, 11:27 PM
bcran updated the diff for D21580: sysutils/uefi-edk2-qemu: GCC should be a build dependency, not runtime.

Fix GCC_DEFAULT.

Sep 9 2019, 11:26 PM
bcran created D21580: sysutils/uefi-edk2-qemu: GCC should be a build dependency, not runtime.
Sep 9 2019, 11:23 PM

Sep 4 2019

bcran closed D20562: The efifat files are no longer used: remove the code to build them..
Sep 4 2019, 9:45 PM
bcran committed rS351831: The efifat files are no longer used: remove the code to build them.
The efifat files are no longer used: remove the code to build them
Sep 4 2019, 8:56 PM

Aug 28 2019

bcran added a comment to D20562: The efifat files are no longer used: remove the code to build them..

Restore Makefile.depend

Aug 28 2019, 1:55 AM
bcran added a comment to D20562: The efifat files are no longer used: remove the code to build them..

Is stand/efi/boot1/Makefile.depend supposed to be deleted?

Aug 28 2019, 1:49 AM

Aug 25 2019

bcran added inline comments to D20562: The efifat files are no longer used: remove the code to build them..
Aug 25 2019, 10:38 PM
bcran added a comment to D20562: The efifat files are no longer used: remove the code to build them..

Keep building boot1.efi

Aug 25 2019, 10:37 PM
bcran added a comment to D20562: The efifat files are no longer used: remove the code to build them..
Aug 25 2019, 9:02 PM
bcran added a comment to D20562: The efifat files are no longer used: remove the code to build them..

Since makefs fat support has been committed, proceed with removing all the EFI FAT code.

Aug 25 2019, 9:01 PM

Aug 19 2019

bcran added a comment to D21281: Work around a bug in the EFI HTTP driver.

Huh, I'm seeing some really odd stuff in there right from the very first time we call it, way before the crash (and when connecting using both HTTP and HTTPS):

Aug 19 2019, 6:44 AM
bcran added a comment to D21281: Work around a bug in the EFI HTTP driver.
Aug 19 2019, 1:35 AM

Aug 16 2019

bcran added a comment to D21281: Work around a bug in the EFI HTTP driver.
In D21281#462767, @imp wrote:
Aug 16 2019, 12:36 AM

Aug 15 2019

bcran added a comment to D21281: Work around a bug in the EFI HTTP driver.

Fixed another place where we try and open a file without first calling
efihttp_dev_close and efihttp_dev_open.

Aug 15 2019, 11:35 PM
bcran added inline comments to D21281: Work around a bug in the EFI HTTP driver.
Aug 15 2019, 11:02 PM
bcran added a comment to D21281: Work around a bug in the EFI HTTP driver.

Is this error case something that happens only sometimes? Fetching multiple files is something that has definitely worked for me before.

Aug 15 2019, 10:59 PM
bcran updated the summary of D21281: Work around a bug in the EFI HTTP driver.
Aug 15 2019, 10:00 PM
bcran added reviewers for D21281: Work around a bug in the EFI HTTP driver: kevans, emaste.
Aug 15 2019, 9:59 PM
bcran created D21281: Work around a bug in the EFI HTTP driver.
Aug 15 2019, 9:58 PM

Aug 8 2019

D21016: Reduce size of EFI_STAGING_SIZE to 32 on arm is now accepted and ready to land.
Aug 8 2019, 8:27 PM

Jul 24 2019

bcran added a comment to D19976: bhyve: Support a _VARS.fd file for bootrom.

ping!!!

Jul 24 2019, 10:07 PM

Jun 28 2019

bcran committed rS349494: Add ACPI entries for Synopsys Designware UARTs used on ARM platforms.
Add ACPI entries for Synopsys Designware UARTs used on ARM platforms
Jun 28 2019, 1:19 AM
bcran closed D20765: Add ACPI entries for Synopsys Designware UARTs used on ARM platforms.
Jun 28 2019, 1:19 AM · Contributor Reviews (base), arm64
bcran closed D20775: Add missing ACPI GICv2 MSI/MSI-X attachment.
Jun 28 2019, 1:17 AM · Contributor Reviews (base), arm64
bcran committed rS349493: Add missing ACPI GICv2 MSI/MSI-X attachment.
Add missing ACPI GICv2 MSI/MSI-X attachment
Jun 28 2019, 1:17 AM
bcran accepted D20775: Add missing ACPI GICv2 MSI/MSI-X attachment.
Jun 28 2019, 1:14 AM · Contributor Reviews (base), arm64
bcran added a comment to D20765: Add ACPI entries for Synopsys Designware UARTs used on ARM platforms.
Jun 28 2019, 1:10 AM · Contributor Reviews (base), arm64

Jun 27 2019

bcran added a comment to D16913: vmrun: add -x flag to disable reboot loop.

I'm going through my list of reviews and noticed this one. Does it need more work, or can it be committed?

Jun 27 2019, 10:13 PM
bcran added a comment to D18705: efibootmgr: make generic usage message more readable.

@yuripv Are you still planning to commit this?

Jun 27 2019, 10:11 PM
bcran added a comment to D20776: Increase EFI_STAGING_SIZE to 150MB.

I committed a temporary fix to increase the size to 100MB on x64 in r349471.

Jun 27 2019, 10:07 PM
bcran committed rS349471: Increase EFI_STAGING_SIZE to 100MB on x64.
Increase EFI_STAGING_SIZE to 100MB on x64
Jun 27 2019, 10:06 PM
bcran added inline comments to D20780: Add support for getting early entropy from the UEFI RNG protocol.
Jun 27 2019, 9:05 PM · security, arm64