Page MenuHomeFreeBSD

bcran (Rebecca Cran)
Software Engineer

Projects

User Details

User Since
May 9 2014, 11:24 PM (349 w, 2 d)

Recent Activity

Sat, Jan 16

bcran updated subscribers of D27970: bhyve: move 64 bit BAR location to match OVMF assumptions.
Sat, Jan 16, 6:28 AM · bhyve
bcran added a comment to D27970: bhyve: move 64 bit BAR location to match OVMF assumptions.

The patch no longer applies against 13-CURRENT: I needed to apply several lines manually.

Sat, Jan 16, 6:17 AM · bhyve
bcran updated subscribers of D27970: bhyve: move 64 bit BAR location to match OVMF assumptions.

This works for me. I was seeing an assert failure in pci_emul.c, but it disappeared for some reason.
One person on Slack said they'd like the BAR in a fixed (high) location, so I wouldn't be confident committing this without other people (e.g. @jhb) reviewing it too.

Sat, Jan 16, 6:16 AM · bhyve

Tue, Jan 5

bcran added a comment to D27970: bhyve: move 64 bit BAR location to match OVMF assumptions.

OVMF puts it at the next 16GB boundary, which might be better.

Tue, Jan 5, 8:17 PM · bhyve

Mon, Dec 28

bcran added a comment to D27782: uefi.8: mention boot1.efi.

Also, /boot/boot1.efifat is no longer included in -CURRENT.

Mon, Dec 28, 2:46 PM
bcran added a comment to D27782: uefi.8: mention boot1.efi.

/boot/boot1.efifat is the 800 KB filesystem image. /boot/boot1.efi is the EFI bootloader application.

Mon, Dec 28, 2:43 PM

Sat, Dec 26

bcran added a comment to D27230: Update bhyve related ports.

UEFI is configuring an address size less than that which the host CPU supports, because (cc @grehan) :

//
// As guest-physical memory size grows, the permanent PEI RAM requirements
// are dominated by the identity-mapping page tables built by the DXE IPL.
// The DXL IPL keys off of the physical address bits advertized in the CPU
// HOB. To conserve memory, we calculate the minimum address width here.
Sat, Dec 26, 7:57 AM
bcran added a comment to D27230: Update bhyve related ports.

@c.koehne_beckhoff.com
I see what's going wrong, and have reproduced the issue on my Threadripper system.
EDK2 firmware configures the maximum address based on the size of guest memory, with a minimum of 64GB (36 bits).
But the PCI code in bhyve puts the BAR at (highest host CPU address / 4) - meaning that on my system it puts it at 64TB.

Sat, Dec 26, 7:28 AM

Thu, Dec 24

bcran added a comment to D27230: Update bhyve related ports.

I successfully installed and ran Windows 10 with the new firmware today.
So I think the last remaining issue will be the MemAbove4G problem.

Thu, Dec 24, 8:12 AM

Wed, Dec 23

bcran added a comment to D24066: bhyve: support relocating fbuf and passthru data BARs.

The patch no longer applies cleanly: I had to make some changes.
But after that, I was able to run Ubuntu 20.10 with gEfiMdeModulePkgTokenSpaceGuid.PcdPciDisableBusEnumeration set to TRUE and FALSE with the following command line, which uses both rfb and passthru:

bhyve -AH -s 0:0,hostbridge -s 31:0,lpc -c 1 -m 16G -l bootrom,/home/bcran/src/edk2/Build/BhyveX64/DEBUG_GCC5/FV/BHYVE_CODE.fd -l com1,stdio -s 3:0,ahci-hd,bhyve-ubuntu-20_10.img  -s 7,ahci-cd, -s 8,virtio-rnd -s 6,virtio-net,tap0 -s 9,fbuf,rfb=10.0.10.117:5900,w=1920,h=1200 -s 10,xhci,tablet -s 11,passthru,24/0/0 -S guest
Wed, Dec 23, 7:52 AM · bhyve
bcran added a comment to D27230: Update bhyve related ports.

Apologies for being absent recently - life took over... but I’ll have some time to look at this again between Xmas and New Year.

I've had a report that Windows 10 crashes (bugchecks) with this firmware, so I need to do more testing (on FreeBSD 11, 12 and 13-CURRENT) before committing it.

Any progress fixing this? Would you like to commit the update using one revision older from upstream that didn’t have this issue?

Wed, Dec 23, 6:50 AM
bcran added a comment to D24300: Bhyve: SMBIOS bcdrev calculated from major/minor values.

This was fixed in rS359719, so I think this review should be closed.

Wed, Dec 23, 6:28 AM

Tue, Dec 22

bcran added a comment to D27230: Update bhyve related ports.
Tue, Dec 22, 6:23 AM

Dec 14 2020

bcran added a comment to D27230: Update bhyve related ports.

I've uploaded new binaries to https://people.freebsd.org/~bcran/bhyve/BhyveX64-20201213/ .

Dec 14 2020, 6:53 AM
bcran added a comment to D27230: Update bhyve related ports.

I've had a report that Windows 10 crashes (bugchecks) with this firmware, so I need to do more testing (on FreeBSD 11, 12 and 13-CURRENT) before committing it.

Dec 14 2020, 6:26 AM
bcran updated the diff for D27230: Update bhyve related ports.

Update the version to 20201213 and move the GH tag today's sources

Dec 14 2020, 5:50 AM

Dec 13 2020

bcran committed R9:0bf92d5a47ae: Add news about my commit bit. (authored by bcran).
Add news about my commit bit.
Dec 13 2020, 5:49 PM
bcran committed R9:84cb29044355: Add my PGP key. (authored by bcran).
Add my PGP key.
Dec 13 2020, 5:49 PM
bcran committed R9:2a0c64150a83: Move myself from additional contributors to committers list. (authored by bcran).
Move myself from additional contributors to committers list.
Dec 13 2020, 5:34 PM
bcran committed R9:944aabe6614c: Add myself (authored by bcran).
Add myself
Dec 13 2020, 5:34 PM
bcran committed R9:f07e79d8466a: Add myself. (authored by bcran).
Add myself.
Dec 13 2020, 5:34 PM

Dec 5 2020

bcran added a comment to D27230: Update bhyve related ports.

The CSM port shouldn't really default to a debug build, but I can fix that in a later change since it's existing behavior.

Dec 5 2020, 6:10 AM
bcran added a comment to D27230: Update bhyve related ports.

Thanks Ben!

Dec 5 2020, 6:04 AM
bcran added a comment to D27230: Update bhyve related ports.

Oh I also bumped the PORTEPOCH to 2 to make sure the new version of g20201129 is considered greater than the previous 0.2.

Dec 5 2020, 6:02 AM
bcran updated the diff for D27230: Update bhyve related ports.

Fixed the license lines in uefi-edk2-bhyve, since it uses BSD-2-Clause-Patent.

Dec 5 2020, 5:58 AM

Nov 30 2020

bcran added inline comments to D27230: Update bhyve related ports.
Nov 30 2020, 6:05 AM
bcran updated the diff for D27230: Update bhyve related ports.
  • Install BHYVE.fd as BHYVE_UEFI.fd.
  • Switched version to g20201129 and updated github tag to use the

latest code on master, because it includes several important fixes.

Nov 30 2020, 6:05 AM

Nov 27 2020

bcran closed D27348: Fix bhyve type19 SMBIOS handling to avoid losing 4GB.
Nov 27 2020, 8:00 AM
bcran committed rS368093: Fix bhyve SMBIOS type 19 handling to avoid misreporting total RAM amount.
Fix bhyve SMBIOS type 19 handling to avoid misreporting total RAM amount
Nov 27 2020, 8:00 AM
bcran committed rS368092: bhyve: fix smbiostbl.c style issues and add comment about date format.
bhyve: fix smbiostbl.c style issues and add comment about date format
Nov 27 2020, 7:53 AM

Nov 25 2020

bcran added inline comments to D27348: Fix bhyve type19 SMBIOS handling to avoid losing 4GB.
Nov 25 2020, 7:44 AM

Nov 24 2020

bcran added a comment to D27348: Fix bhyve type19 SMBIOS handling to avoid losing 4GB.

This fixes the amount of memory displayed in the UiApp to be the same as passed on the bhyve command line. Otherwise, 8GB gets displayed as 4, 32GB as 28 etc.

Nov 24 2020, 4:53 AM
bcran requested review of D27348: Fix bhyve type19 SMBIOS handling to avoid losing 4GB.
Nov 24 2020, 4:51 AM

Nov 22 2020

bcran updated the diff for D27230: Update bhyve related ports.

Fixed the CSM port so it actually builds with CSM support.

Nov 22 2020, 6:21 AM
bcran added a comment to D27230: Update bhyve related ports.

I've also updated the name/version fields of the uefi-edk2-bhyve port to be:

PORTNAME=	uefi-edk2-bhyve
DISTVERSIONPREFIX=	edk2-stable
DISTVERSION=	202011
PORTEPOCH=	1
Nov 22 2020, 6:08 AM
bcran updated the diff for D27230: Update bhyve related ports.

Restored the uefi-edk2-bhyve-csm port, with contents from the existing
uefi-edk2-bhyve directory. Changed the installed filename to be
BHYVE_UEFI_CSM.fd.

Nov 22 2020, 6:06 AM

Nov 16 2020

bcran added a comment to D27230: Update bhyve related ports.

Can we keep the CSM one until the bitter end, and build it from the existing repo ?

Nov 16 2020, 4:32 AM
bcran added a reviewer for D27230: Update bhyve related ports: bhyve.
Nov 16 2020, 2:12 AM

Nov 15 2020

bcran requested review of D27230: Update bhyve related ports.
Nov 15 2020, 11:24 PM

Nov 13 2020

bcran closed D27147: bhyve: update smbiostbl.c to bump the versions and release dates.
Nov 13 2020, 7:47 PM
bcran committed rS367651: bhyve: update smbiostbl.c to bump the version and release date.
bhyve: update smbiostbl.c to bump the version and release date
Nov 13 2020, 7:47 PM

Nov 11 2020

bcran updated the diff for D27147: bhyve: update smbiostbl.c to bump the versions and release dates.

Use #defines for the version and date.
Only bump the firmware fields.

Nov 11 2020, 2:57 AM

Nov 9 2020

bcran requested review of D27147: bhyve: update smbiostbl.c to bump the versions and release dates.
Nov 9 2020, 4:59 AM

Sep 17 2020

bcran added inline comments to D26428: Initial support for implementing the bootXXX.efi workaround.
Sep 17 2020, 4:27 PM
bcran added a comment to D26428: Initial support for implementing the bootXXX.efi workaround.

I don't consider UEFI to be basic at all, both are completely different. If you would refer to it as firmware, I would agree, but not to UEFI as BIOS.

Sep 17 2020, 4:23 PM

Sep 10 2020

bcran added a comment to D21281: Work around a bug in the EFI HTTP driver.

Thanks for committing this, @scottph! I've been busy with a new job so haven't had time to work on FreeBSD recently.

Sep 10 2020, 3:49 PM

Apr 21 2020

bcran commandeered D19976: bhyve: Support a _VARS.fd file for bootrom.

@scottph has indicated he no longer has the time/interest in working on this, so I'll take over and work to get it committed.

Apr 21 2020, 11:59 PM

Apr 8 2020

bcran accepted D24300: Bhyve: SMBIOS bcdrev calculated from major/minor values.
Apr 8 2020, 3:24 AM

Apr 6 2020

bcran added a comment to D24066: bhyve: support relocating fbuf and passthru data BARs.

Is this with PcdPciDisableBusEnumeration = TRUE in UEFI ?

Apr 6 2020, 2:57 AM · bhyve

Apr 5 2020

bcran added a comment to D19976: bhyve: Support a _VARS.fd file for bootrom.
In D19976#515732, @mat wrote:

Has this been committed yet?

Apr 5 2020, 6:55 PM
bcran added a comment to D19976: bhyve: Support a _VARS.fd file for bootrom.

@scottph Are you still interested in working on this?

Apr 5 2020, 6:54 PM
bcran added a comment to D24066: bhyve: support relocating fbuf and passthru data BARs.
Apr 5 2020, 5:54 PM · bhyve
bcran accepted D24300: Bhyve: SMBIOS bcdrev calculated from major/minor values.
Apr 5 2020, 5:51 PM
bcran accepted D24276: ci-qemu-test.sh: use pkgbase.

Works great here.

Apr 5 2020, 4:32 AM

Mar 31 2020

bcran committed rS359478: Bhyve: fix SMBIOS Type 17 table generation.
Bhyve: fix SMBIOS Type 17 table generation
Mar 31 2020, 2:37 AM
bcran closed D24107: Bhyve: fix SMBIOS Type 17 table generation.
Mar 31 2020, 2:37 AM

Mar 30 2020

bcran added inline comments to D24107: Bhyve: fix SMBIOS Type 17 table generation.
Mar 30 2020, 10:13 PM
bcran updated the summary of D24107: Bhyve: fix SMBIOS Type 17 table generation.
Mar 30 2020, 8:05 PM
bcran updated the test plan for D24107: Bhyve: fix SMBIOS Type 17 table generation.
Mar 30 2020, 8:05 PM
bcran added inline comments to D24107: Bhyve: fix SMBIOS Type 17 table generation.
Mar 30 2020, 8:00 PM
bcran updated the diff for D24107: Bhyve: fix SMBIOS Type 17 table generation.
  • Change comments to C style.
Mar 30 2020, 8:00 PM
bcran added a comment to D24107: Bhyve: fix SMBIOS Type 17 table generation.

@rgrimes Could you approve the latest patch, or provide comments on what should be changed please?

Mar 30 2020, 7:57 PM

Mar 29 2020

bcran added inline comments to D24107: Bhyve: fix SMBIOS Type 17 table generation.
Mar 29 2020, 3:56 PM
bcran updated the diff for D24107: Bhyve: fix SMBIOS Type 17 table generation.

Upload the full patch.

Mar 29 2020, 3:55 PM

Mar 28 2020

bcran updated the diff for D24107: Bhyve: fix SMBIOS Type 17 table generation.
  • Change overflow error to a warning and truncate type 17 memory size.
Mar 28 2020, 11:33 PM
bcran added a comment to D24107: Bhyve: fix SMBIOS Type 17 table generation.

There is no need to error out on overflow here. The type17 isn't used by most o/s's for determining how much memory is available: there is e820, the EFI memory map, etc etc. Perhaps print an error in bhyve, buit there doesn't seem any point in erroring out.

Mar 28 2020, 11:27 PM
bcran updated the diff for D24107: Bhyve: fix SMBIOS Type 17 table generation.
  • Rework type17 generation and error out on overflow.
Mar 28 2020, 4:53 PM
bcran added inline comments to D24107: Bhyve: fix SMBIOS Type 17 table generation.
Mar 28 2020, 4:52 AM
bcran updated the diff for D24107: Bhyve: fix SMBIOS Type 17 table generation.
  • Revert bumping the SMBIOS version.
Mar 28 2020, 4:45 AM
bcran updated the diff for D24107: Bhyve: fix SMBIOS Type 17 table generation.
  • Fixes based on review feedback.
Mar 28 2020, 4:42 AM
bcran added a comment to D24107: Bhyve: fix SMBIOS Type 17 table generation.
In D24107#532393, @jhb wrote:

That is what the 0x7fff value is for when using extended btw, is to report the max possible size for legacy systems. I agree that we should use the non-extended size when it fits.

Mar 28 2020, 4:19 AM
bcran added a comment to D24107: Bhyve: fix SMBIOS Type 17 table generation.
In D24107#532391, @jhb wrote:

Rebecca is it ok with you if I go create a review to do the bcdrev fix?

Mar 28 2020, 3:14 AM

Mar 27 2020

bcran added inline comments to D24107: Bhyve: fix SMBIOS Type 17 table generation.
Mar 27 2020, 12:15 AM

Mar 26 2020

bcran added inline comments to D24107: Bhyve: fix SMBIOS Type 17 table generation.
Mar 26 2020, 11:57 PM
bcran added inline comments to D24107: Bhyve: fix SMBIOS Type 17 table generation.
Mar 26 2020, 11:36 PM
bcran added a comment to D24107: Bhyve: fix SMBIOS Type 17 table generation.

This calculation seems odd, I see later it is overwritten for large memory, cant we just continue to use extended all the time and leave this set at 0x7fff? Never mind, spec says not. Ok how about doing:

Mar 26 2020, 11:34 PM

Mar 20 2020

bcran added a comment to D24107: Bhyve: fix SMBIOS Type 17 table generation.

You might want to see what happens with > 64GB (or maybe 128GB, can't recall the value). At some point additional tables are required for Windows.

Mar 20 2020, 5:57 PM

Mar 18 2020

bcran added a comment to D24107: Bhyve: fix SMBIOS Type 17 table generation.
Mar 18 2020, 6:55 PM
bcran committed rS359065: Bhyve: log message when rfb client connects.
Bhyve: log message when rfb client connects
Mar 18 2020, 3:17 AM
bcran closed D24098: Bhyve: log message when rfb client connects.
Mar 18 2020, 3:17 AM
bcran committed rS359064: Bhyve: DPRINTF already includes newline, so don't add another.
Bhyve: DPRINTF already includes newline, so don't add another
Mar 18 2020, 3:16 AM
bcran closed D24099: Bhyve: DPRINTF already includes newline, so don't add another.
Mar 18 2020, 3:16 AM
bcran committed rS359063: ath_hal: fix typo in ath_hal_printf.
ath_hal: fix typo in ath_hal_printf
Mar 18 2020, 3:14 AM
bcran retitled D24107: Bhyve: fix SMBIOS Type 17 table generation from Bhyve: log message when rfb client connects to Bhyve: fix SMBIOS Type 17 table generation.
Mar 18 2020, 2:14 AM
bcran updated the diff for D24107: Bhyve: fix SMBIOS Type 17 table generation.

Remove unrelated changes.

Mar 18 2020, 2:13 AM
bcran created D24107: Bhyve: fix SMBIOS Type 17 table generation.
Mar 18 2020, 2:13 AM

Mar 17 2020

bcran added reviewers for D24099: Bhyve: DPRINTF already includes newline, so don't add another: jhb, vmaffione, emaste, seanc, allanjude, imp.
Mar 17 2020, 5:52 PM
bcran created D24099: Bhyve: DPRINTF already includes newline, so don't add another.
Mar 17 2020, 3:16 PM
bcran created D24098: Bhyve: log message when rfb client connects.
Mar 17 2020, 3:11 PM

Feb 20 2020

bcran committed rS358183: dtc: remove unknown option printf, since getopt will print it.
dtc: remove unknown option printf, since getopt will print it
Feb 20 2020, 9:30 PM
bcran closed D23662: dtc: remove unknown option printf, since getopt will print it.
Feb 20 2020, 9:30 PM

Feb 15 2020

bcran added a comment to D23662: dtc: remove unknown option printf, since getopt will print it.

This looks fine, but please submit it as a GitHub PR so that it goes through CI (I can't imagine it failing).

Feb 15 2020, 7:04 PM

Feb 13 2020

bcran retitled D23662: dtc: remove unknown option printf, since getopt will print it from dtc: unknown getopt option character is in optopt, not ch to dtc: remove unknown option printf, since getopt will print it.
Feb 13 2020, 6:41 PM
bcran updated the diff for D23662: dtc: remove unknown option printf, since getopt will print it.

Remove the print statement in the default handler.

Feb 13 2020, 6:41 PM
bcran added a comment to D23662: dtc: remove unknown option printf, since getopt will print it.

change should also go here: https://github.com/davidchisnall/dtc

Feb 13 2020, 4:22 PM
bcran created D23662: dtc: remove unknown option printf, since getopt will print it.
Feb 13 2020, 4:03 PM

Feb 8 2020

bcran committed rP525557: Revert "sysutils/uefi-edk2-bhyve: update to be same as uefi-edk2-bhyve-devel".
Revert "sysutils/uefi-edk2-bhyve: update to be same as uefi-edk2-bhyve-devel"
Feb 8 2020, 2:55 PM

Feb 7 2020

bcran closed D23476: sysutils/uefi-edk2-bhyve: update to be same as uefi-edk2-bhyve-devel and delete -devel port.

Committed in https://svnweb.freebsd.org/ports?view=revision&revision=525460 .

Feb 7 2020, 6:23 AM
bcran committed rP525460: sysutils/uefi-edk2-bhyve: update to be same as uefi-edk2-bhyve-devel.
sysutils/uefi-edk2-bhyve: update to be same as uefi-edk2-bhyve-devel
Feb 7 2020, 4:44 AM
bcran closed D23486: sysutils/uefi-edk2-qemu: Replace "python2.7" with "${PYTHON_CMD}".
Feb 7 2020, 2:55 AM