- User Since
- May 9 2014, 11:24 PM (370 w, 6 d)
Mon, May 31
I tested the code from https://github.com/FreeBSD-UPB/freebsd-src/tree/projects/bhyvearm64/ (as of 2021-05-29) on my SolidRun Honeycomb system and it fails to allocate resources in the gicv3 code when I run kldload vmm.
May 11 2021
May 2 2021
With examples like Apple's "goto fail" bug (https://www.imperialviolet.org/2014/02/22/applebug.html) I'm surprised style(9) only allows, and doesn't recommend or mandate braces around single-line statements.
Apr 9 2021
I noticed this is against the svn repo:
Repository rS FreeBSD src repository - subversion"
You'll probably want to switch over to Git and rebase this patch.
Just a comment typo: "number of contained objecct handles" - should be "object".
Mar 28 2021
Mar 24 2021
@manu Sorry, could you re-approve the change please?
Mar 20 2021
We'll also need to update the port revision.
Mar 16 2021
@woodsb02 Could you review and approve this for me, please?
Mar 14 2021
Feb 18 2021
Now the firmware work has been committed, I'll switch back to working on this.
Committed as r565866.
Feb 16 2021
Feb 15 2021
At this point, I'd like to get this committed as soon as possible so we can move away from gcc 4.8 and python 2.
Updated to code from today's master, 2021-02-14.
Jan 16 2021
The patch no longer applies against 13-CURRENT: I needed to apply several lines manually.
This works for me. I was seeing an assert failure in pci_emul.c, but it disappeared for some reason.
One person on Slack said they'd like the BAR in a fixed (high) location, so I wouldn't be confident committing this without other people (e.g. @jhb and @grehan ) reviewing it too.
Jan 5 2021
OVMF puts it at the next 16GB boundary, which might be better.
Dec 28 2020
Also, /boot/boot1.efifat is no longer included in -CURRENT.
/boot/boot1.efifat is the 800 KB filesystem image. /boot/boot1.efi is the EFI bootloader application.
Dec 26 2020
UEFI is configuring an address size less than that which the host CPU supports, because (cc @grehan) :
// // As guest-physical memory size grows, the permanent PEI RAM requirements // are dominated by the identity-mapping page tables built by the DXE IPL. // The DXL IPL keys off of the physical address bits advertized in the CPU // HOB. To conserve memory, we calculate the minimum address width here.
I see what's going wrong, and have reproduced the issue on my Threadripper system.
EDK2 firmware configures the maximum address based on the size of guest memory, with a minimum of 64GB (36 bits).
But the PCI code in bhyve puts the BAR at (highest host CPU address / 4) - meaning that on my system it puts it at 64TB.
Dec 24 2020
I successfully installed and ran Windows 10 with the new firmware today.
So I think the last remaining issue will be the MemAbove4G problem.
Dec 23 2020
The patch no longer applies cleanly: I had to make some changes.
But after that, I was able to run Ubuntu 20.10 with gEfiMdeModulePkgTokenSpaceGuid.PcdPciDisableBusEnumeration set to TRUE and FALSE with the following command line, which uses both rfb and passthru:
bhyve -AH -s 0:0,hostbridge -s 31:0,lpc -c 1 -m 16G -l bootrom,BHYVE_CODE.fd -l com1,stdio -s 3:0,ahci-hd,bhyve-ubuntu-20_10.img -s 7,ahci-cd, -s 8,virtio-rnd -s 6,virtio-net,tap0 -s 9,fbuf,rfb=10.0.10.117:5900,w=1920,h=1200 -s 10,xhci,tablet -s 11,passthru,24/0/0 -S guest
This was fixed in rS359719, so I think this review should be closed.
Dec 22 2020
Dec 14 2020
I've uploaded new binaries to https://people.freebsd.org/~bcran/bhyve/BhyveX64-20201213/ .
I've had a report that Windows 10 crashes (bugchecks) with this firmware, so I need to do more testing (on FreeBSD 11, 12 and 13-CURRENT) before committing it.
Update the version to 20201213 and move the GH tag today's sources
Dec 13 2020
Dec 5 2020
The CSM port shouldn't really default to a debug build, but I can fix that in a later change since it's existing behavior.
Oh I also bumped the PORTEPOCH to 2 to make sure the new version of g20201129 is considered greater than the previous 0.2.
Fixed the license lines in uefi-edk2-bhyve, since it uses BSD-2-Clause-Patent.
Nov 30 2020
- Install BHYVE.fd as BHYVE_UEFI.fd.
- Switched version to g20201129 and updated github tag to use the
latest code on master, because it includes several important fixes.
Nov 27 2020
Nov 25 2020
Nov 24 2020
This fixes the amount of memory displayed in the UiApp to be the same as passed on the bhyve command line. Otherwise, 8GB gets displayed as 4, 32GB as 28 etc.
Nov 22 2020
Fixed the CSM port so it actually builds with CSM support.
I've also updated the name/version fields of the uefi-edk2-bhyve port to be:
PORTNAME= uefi-edk2-bhyve DISTVERSIONPREFIX= edk2-stable DISTVERSION= 202011 PORTEPOCH= 1
Restored the uefi-edk2-bhyve-csm port, with contents from the existing
uefi-edk2-bhyve directory. Changed the installed filename to be
Nov 16 2020
Nov 15 2020
Nov 13 2020
Nov 11 2020
Use #defines for the version and date.
Only bump the firmware fields.
Nov 9 2020
Sep 17 2020
Sep 10 2020
Thanks for committing this, @scottph! I've been busy with a new job so haven't had time to work on FreeBSD recently.
Apr 21 2020
@scottph has indicated he no longer has the time/interest in working on this, so I'll take over and work to get it committed.
Apr 8 2020
Apr 6 2020
Apr 5 2020
@scottph Are you still interested in working on this?
Mar 31 2020
Mar 30 2020
- Change comments to C style.
@rgrimes Could you approve the latest patch, or provide comments on what should be changed please?
Mar 29 2020
Upload the full patch.
Mar 28 2020
- Change overflow error to a warning and truncate type 17 memory size.
- Rework type17 generation and error out on overflow.
- Revert bumping the SMBIOS version.
- Fixes based on review feedback.