Page MenuHomeFreeBSD

bcran (Rebecca Cran)
Software Engineer

Projects

User Details

User Since
May 9 2014, 11:24 PM (279 w, 2 d)

Recent Activity

Sat, Sep 14

bcran requested changes to D21655: efipart: use page-aligned buffer for BlockIO.
Sat, Sep 14, 3:15 PM
bcran added a comment to D21655: efipart: use page-aligned buffer for BlockIO.

Actually yes, this change isn't correct. See https://github.com/tianocore/edk2/blob/master/MdePkg/Library/UefiMemoryAllocationLib/MemoryAllocationLib.c for an example of how to allocate aligned memory (InternalAllocateAlignedPages etc.)

Sat, Sep 14, 3:14 PM
bcran accepted D21655: efipart: use page-aligned buffer for BlockIO.
Sat, Sep 14, 2:24 AM

Wed, Sep 11

bcran committed rP511820: sysutils/uefi-edk2-qemu: Depend on the gcc${GCC_DEFAULT} binary.
sysutils/uefi-edk2-qemu: Depend on the gcc${GCC_DEFAULT} binary
Wed, Sep 11, 12:38 PM
bcran closed D21601: Depend on the gcc${GCC_DEFAULT} binary, since only lang/gcc installs gcc..
Wed, Sep 11, 12:38 PM

Tue, Sep 10

bcran created D21601: Depend on the gcc${GCC_DEFAULT} binary, since only lang/gcc installs gcc..
Tue, Sep 10, 9:48 PM
bcran added a comment to D21580: sysutils/uefi-edk2-qemu: GCC should be a build dependency, not runtime.

You have my approve to commit it! Thank you!

Tue, Sep 10, 1:52 AM
bcran committed rP511727: sysutils/uefi-edk2-qemu: GCC should be a build dependency, not runtime.
sysutils/uefi-edk2-qemu: GCC should be a build dependency, not runtime
Tue, Sep 10, 1:52 AM
bcran closed D21580: sysutils/uefi-edk2-qemu: GCC should be a build dependency, not runtime.
Tue, Sep 10, 1:52 AM
bcran added a comment to D21580: sysutils/uefi-edk2-qemu: GCC should be a build dependency, not runtime.

USE_GCC will set build-time and run-time dependency, if we need only build-time dependency the patch looks good to me.

Tue, Sep 10, 1:46 AM

Mon, Sep 9

bcran updated the diff for D21580: sysutils/uefi-edk2-qemu: GCC should be a build dependency, not runtime.

Fix USES.

Mon, Sep 9, 11:27 PM
bcran updated the diff for D21580: sysutils/uefi-edk2-qemu: GCC should be a build dependency, not runtime.

Fix GCC_DEFAULT.

Mon, Sep 9, 11:26 PM
bcran created D21580: sysutils/uefi-edk2-qemu: GCC should be a build dependency, not runtime.
Mon, Sep 9, 11:23 PM

Wed, Sep 4

bcran closed D20562: The efifat files are no longer used: remove the code to build them..
Wed, Sep 4, 9:45 PM
bcran committed rS351831: The efifat files are no longer used: remove the code to build them.
The efifat files are no longer used: remove the code to build them
Wed, Sep 4, 8:56 PM

Wed, Aug 28

bcran added a comment to D20562: The efifat files are no longer used: remove the code to build them..

Restore Makefile.depend

Wed, Aug 28, 1:55 AM
bcran added a comment to D20562: The efifat files are no longer used: remove the code to build them..

Is stand/efi/boot1/Makefile.depend supposed to be deleted?

Wed, Aug 28, 1:49 AM

Sun, Aug 25

bcran added inline comments to D20562: The efifat files are no longer used: remove the code to build them..
Sun, Aug 25, 10:38 PM
bcran added a comment to D20562: The efifat files are no longer used: remove the code to build them..

Keep building boot1.efi

Sun, Aug 25, 10:37 PM
bcran added a comment to D20562: The efifat files are no longer used: remove the code to build them..
Sun, Aug 25, 9:02 PM
bcran added a comment to D20562: The efifat files are no longer used: remove the code to build them..

Since makefs fat support has been committed, proceed with removing all the EFI FAT code.

Sun, Aug 25, 9:01 PM

Mon, Aug 19

bcran added a comment to D21281: Work around a bug in the EFI HTTP driver.

Huh, I'm seeing some really odd stuff in there right from the very first time we call it, way before the crash (and when connecting using both HTTP and HTTPS):

Mon, Aug 19, 6:44 AM
bcran added a comment to D21281: Work around a bug in the EFI HTTP driver.
Mon, Aug 19, 1:35 AM

Aug 16 2019

bcran added a comment to D21281: Work around a bug in the EFI HTTP driver.
In D21281#462767, @imp wrote:
Aug 16 2019, 12:36 AM

Aug 15 2019

bcran added a comment to D21281: Work around a bug in the EFI HTTP driver.

Fixed another place where we try and open a file without first calling
efihttp_dev_close and efihttp_dev_open.

Aug 15 2019, 11:35 PM
bcran added inline comments to D21281: Work around a bug in the EFI HTTP driver.
Aug 15 2019, 11:02 PM
bcran added a comment to D21281: Work around a bug in the EFI HTTP driver.

Is this error case something that happens only sometimes? Fetching multiple files is something that has definitely worked for me before.

Aug 15 2019, 10:59 PM
bcran updated the summary of D21281: Work around a bug in the EFI HTTP driver.
Aug 15 2019, 10:00 PM
bcran added reviewers for D21281: Work around a bug in the EFI HTTP driver: kevans, emaste.
Aug 15 2019, 9:59 PM
bcran created D21281: Work around a bug in the EFI HTTP driver.
Aug 15 2019, 9:58 PM

Aug 8 2019

D21016: Reduce size of EFI_STAGING_SIZE to 32 on arm is now accepted and ready to land.
Aug 8 2019, 8:27 PM

Jul 24 2019

bcran added a comment to D19976: bhyve: Support a _VARS.fd file for bootrom.

ping!!!

Jul 24 2019, 10:07 PM

Jun 28 2019

bcran committed rS349494: Add ACPI entries for Synopsys Designware UARTs used on ARM platforms.
Add ACPI entries for Synopsys Designware UARTs used on ARM platforms
Jun 28 2019, 1:19 AM
bcran closed D20765: Add ACPI entries for Synopsys Designware UARTs used on ARM platforms.
Jun 28 2019, 1:19 AM · Contributor Reviews (base), arm64
bcran closed D20775: Add missing ACPI GICv2 MSI/MSI-X attachment.
Jun 28 2019, 1:17 AM · Contributor Reviews (base), arm64
bcran committed rS349493: Add missing ACPI GICv2 MSI/MSI-X attachment.
Add missing ACPI GICv2 MSI/MSI-X attachment
Jun 28 2019, 1:17 AM
bcran accepted D20775: Add missing ACPI GICv2 MSI/MSI-X attachment.
Jun 28 2019, 1:14 AM · Contributor Reviews (base), arm64
bcran added a comment to D20765: Add ACPI entries for Synopsys Designware UARTs used on ARM platforms.
Jun 28 2019, 1:10 AM · Contributor Reviews (base), arm64

Jun 27 2019

bcran added a comment to D16913: vmrun: add -x flag to disable reboot loop.

I'm going through my list of reviews and noticed this one. Does it need more work, or can it be committed?

Jun 27 2019, 10:13 PM
bcran added a comment to D18705: efibootmgr: make generic usage message more readable.

@yuripv Are you still planning to commit this?

Jun 27 2019, 10:11 PM
bcran added a comment to D20776: Increase EFI_STAGING_SIZE to 150MB.

I committed a temporary fix to increase the size to 100MB on x64 in r349471.

Jun 27 2019, 10:07 PM
bcran committed rS349471: Increase EFI_STAGING_SIZE to 100MB on x64.
Increase EFI_STAGING_SIZE to 100MB on x64
Jun 27 2019, 10:06 PM
bcran added inline comments to D20780: Add support for getting early entropy from the UEFI RNG protocol.
Jun 27 2019, 9:05 PM · security, arm64
bcran added a comment to D20765: Add ACPI entries for Synopsys Designware UARTs used on ARM platforms.

I just tried booting with this patch applied and with EDK2 firmware built from master yesterday, and I still don't see any output - both with devicetree and acpi.

Jun 27 2019, 6:49 PM · Contributor Reviews (base), arm64

Jun 26 2019

bcran updated the summary of D20776: Increase EFI_STAGING_SIZE to 150MB.
Jun 26 2019, 9:15 PM
bcran added a comment to D20776: Increase EFI_STAGING_SIZE to 150MB.
  • Only bump EFI_STAGING_SIZE for x64
Jun 26 2019, 9:14 PM
bcran updated the summary of D20776: Increase EFI_STAGING_SIZE to 150MB.
Jun 26 2019, 8:55 PM
bcran created D20776: Increase EFI_STAGING_SIZE to 150MB.
Jun 26 2019, 8:52 PM
D20765: Add ACPI entries for Synopsys Designware UARTs used on ARM platforms is now accepted and ready to land.
Jun 26 2019, 3:09 AM · Contributor Reviews (base), arm64
bcran committed rS349404: Re-enable loader efi http boot and fix dv_open bug if dv_init failed.
Re-enable loader efi http boot and fix dv_open bug if dv_init failed
Jun 26 2019, 3:07 AM

Jun 25 2019

bcran committed rS349395: Disconnect EFI HTTP support.
Disconnect EFI HTTP support
Jun 25 2019, 9:27 PM
D20750: Add SPDX tags to HD Audio device bhyve(8) is now accepted and ready to land.
Jun 25 2019, 2:05 AM

Jun 24 2019

bcran committed rS349349: loader: add HTTP support using UEFI.
loader: add HTTP support using UEFI
Jun 24 2019, 11:19 PM
bcran closed D20643: loader: add HTTP support using UEFI.
Jun 24 2019, 11:19 PM
bcran added a comment to D20643: loader: add HTTP support using UEFI.
  • Added error handling around realloc.
Jun 24 2019, 7:26 PM
bcran updated the summary of D20643: loader: add HTTP support using UEFI.
Jun 24 2019, 7:12 PM
bcran updated the summary of D20643: loader: add HTTP support using UEFI.
Jun 24 2019, 7:11 PM
bcran added a comment to D20643: loader: add HTTP support using UEFI.
  • Fixed a couple more issues
Jun 24 2019, 7:08 PM
bcran updated the summary of D20643: loader: add HTTP support using UEFI.
  • loader: add HTTP support using UEFI
  • Updates per review feedback.
Jun 24 2019, 3:42 AM
bcran removed a reviewer for D20643: loader: add HTTP support using UEFI: bcran.
Jun 24 2019, 3:41 AM
bcran added inline comments to D20643: loader: add HTTP support using UEFI.
Jun 24 2019, 2:53 AM
bcran added inline comments to D20643: loader: add HTTP support using UEFI.
Jun 24 2019, 2:14 AM

Jun 23 2019

bcran added inline comments to D20643: loader: add HTTP support using UEFI.
Jun 23 2019, 11:04 PM
bcran added inline comments to D20643: loader: add HTTP support using UEFI.
Jun 23 2019, 10:56 PM

Jun 22 2019

bcran added a comment to D20643: loader: add HTTP support using UEFI.

I realized one issue: we should perhaps add a configuration option such as LOADER_EFIHTTP_SUPPORT to let people disable this.

Jun 22 2019, 6:49 PM

Jun 19 2019

bcran updated the test plan for D20643: loader: add HTTP support using UEFI.
Jun 19 2019, 6:48 PM
bcran committed rS349201: efinet: Defer exclusively opening the network handles.
efinet: Defer exclusively opening the network handles
Jun 19 2019, 6:47 PM
bcran closed D20642: efinet: Defer exclusively opening the network handles.
Jun 19 2019, 6:47 PM
bcran added a comment to D20562: The efifat files are no longer used: remove the code to build them..
Jun 19 2019, 4:48 PM

Jun 15 2019

bcran updated the test plan for D20643: loader: add HTTP support using UEFI.
Jun 15 2019, 3:21 AM

Jun 14 2019

bcran updated the test plan for D20643: loader: add HTTP support using UEFI.
Jun 14 2019, 9:14 PM
bcran added reviewers for D20642: efinet: Defer exclusively opening the network handles: scottph, imp, tsoome, emaste, kevans.
Jun 14 2019, 9:12 PM
bcran updated the summary of D20643: loader: add HTTP support using UEFI.
Jun 14 2019, 9:10 PM

Jun 11 2019

bcran added a comment to D20562: The efifat files are no longer used: remove the code to build them..

Is there a way to build the efi fs this without root? I build images in a Jenkins instance to test FreeBSD/arm64 on various simulators and would prefer to not need to give the Jenkins user sudo access.

Jun 11 2019, 2:57 PM

Jun 10 2019

bcran updated the diff for D20562: The efifat files are no longer used: remove the code to build them..

Removed tmpl.xz files and updated ObsoleteFiles.inc and OptionalObsoleteFiles.inc

Jun 10 2019, 2:18 AM
bcran added inline comments to D20562: The efifat files are no longer used: remove the code to build them..
Jun 10 2019, 12:36 AM

Jun 8 2019

bcran created D20562: The efifat files are no longer used: remove the code to build them..
Jun 8 2019, 9:19 PM
bcran accepted D20547: Split boot1 in half and use the useful half for gptboot.efi.
Jun 8 2019, 6:09 AM
bcran added inline comments to D20547: Split boot1 in half and use the useful half for gptboot.efi.
Jun 8 2019, 6:09 AM
bcran added inline comments to D20547: Split boot1 in half and use the useful half for gptboot.efi.
Jun 8 2019, 2:35 AM

Jun 1 2019

bcran committed rS348499: Fix comment parsing in interp_simple.c.
Fix comment parsing in interp_simple.c
Jun 1 2019, 7:47 PM
bcran closed D20491: Fix comment parsing in interp_simple.c.
Jun 1 2019, 7:47 PM
bcran created D20491: Fix comment parsing in interp_simple.c.
Jun 1 2019, 4:11 AM

May 1 2019

bcran committed rP500603: Improve the comment and description for sysutils/uefi-edk2-qemu.
Improve the comment and description for sysutils/uefi-edk2-qemu
May 1 2019, 6:22 PM

Apr 30 2019

bcran added a comment to D19869: Add a new uefi-edk2-qemu port..
In D19869#432543, @mat wrote:

Approved with the changes requested.

Apr 30 2019, 4:43 PM
bcran committed rP500503: sysutils/uefi-edk2-qemu: add new port.
sysutils/uefi-edk2-qemu: add new port
Apr 30 2019, 4:25 PM
bcran closed D19869: Add a new uefi-edk2-qemu port..
Apr 30 2019, 4:25 PM

Apr 29 2019

bcran accepted D20016: Fallback booting pieces.
Apr 29 2019, 2:26 AM

Apr 27 2019

bcran added a comment to D20016: Fallback booting pieces.

Could you explain what problem this is solving, please? I don't think I've had a problem with loader.efi finding the FreeBSD installation to boot from.

Apr 27 2019, 10:37 PM

Apr 26 2019

bcran closed D20074: Fix tools/boot/ci-qemu-test.sh and make some improvements.
Apr 26 2019, 2:44 PM
bcran committed rS346748: Fix tools/boot/ci-qemu-test.sh and make some improvements.
Fix tools/boot/ci-qemu-test.sh and make some improvements
Apr 26 2019, 2:44 PM
bcran updated the summary of D20074: Fix tools/boot/ci-qemu-test.sh and make some improvements.
Apr 26 2019, 2:30 PM
bcran retitled D20074: Fix tools/boot/ci-qemu-test.sh and make some improvements from Update ci-qemu-test.sh - Update the path to the OVMF file, which is now in /usr/local/share/uefi-edk2-qemu. - Use the more modern q35, pc-q35-3.0 (Q35 + ICH9, 2009) QEMU machine instead of the default, obsolete pc, pc-i440fx-3.0 (i440FX + PIIX... to Fix tools/boot/ci-qemu-test.sh and make some improvements.
Apr 26 2019, 2:29 PM
bcran created D20074: Fix tools/boot/ci-qemu-test.sh and make some improvements.
Apr 26 2019, 2:27 PM
bcran added inline comments to D19869: Add a new uefi-edk2-qemu port..
Apr 26 2019, 1:42 PM
bcran updated the diff for D19869: Add a new uefi-edk2-qemu port..
  • MAKE_ARGS should be =, not += .
Apr 26 2019, 1:39 PM
bcran updated the diff for D19869: Add a new uefi-edk2-qemu port..
  • Remove duplicated and unneeded lines.
Apr 26 2019, 1:37 PM

Apr 25 2019

bcran accepted D20054: Document the UEFI boot loading process.
Apr 25 2019, 2:48 PM
bcran added inline comments to D20054: Document the UEFI boot loading process.
Apr 25 2019, 2:48 PM
bcran closed D19914: ACPI SPCR: handle BaudRate=0.
Apr 25 2019, 2:17 AM · arm64