Page MenuHomeFreeBSD

bcran (Rebecca Cran)
Software Engineer

Projects

User Details

User Since
May 9 2014, 11:24 PM (447 w, 10 h)

Recent Activity

Sep 19 2022

bcran requested review of D36627: Improve error message in pci_host_acpi_get_ecam_resource.
Sep 19 2022, 12:10 AM

Jun 13 2022

bcran added a comment to D35419: Fix MOVED entry for sysutils/uefi-edk2-qemu to sysutils/edk2.
In D35419#803280, @bapt wrote:

this will at best not work, it might even break some of the tools which are using MOVED

Jun 13 2022, 6:36 PM
bcran updated the diff for D35419: Fix MOVED entry for sysutils/uefi-edk2-qemu to sysutils/edk2.

Change the MOVED entry and add a section to UPDATING.

Jun 13 2022, 6:35 PM
bcran closed D35408: sysutils/edk2: Add qemu_x64 and qemu_i386 as new FLAVORs of edk2.
Jun 13 2022, 6:35 PM

Jun 6 2022

bcran requested review of D35419: Fix MOVED entry for sysutils/uefi-edk2-qemu to sysutils/edk2.
Jun 6 2022, 11:38 PM
bcran committed R11:177204e3190b: sysutils/edk2: Add qemu_x64 and qemu_i386 as new FLAVORs of edk2 (authored by bcran).
sysutils/edk2: Add qemu_x64 and qemu_i386 as new FLAVORs of edk2
Jun 6 2022, 11:34 PM
bcran updated the diff for D35408: sysutils/edk2: Add qemu_x64 and qemu_i386 as new FLAVORs of edk2.

Add ONLY_FOR_ARCH lines and revert i386 addition at top

Jun 6 2022, 4:00 PM
bcran retitled D35408: sysutils/edk2: Add qemu_x64 and qemu_i386 as new FLAVORs of edk2 from sysutils/edk2: Add qemu as a new FLAVOR of edk2 to sysutils/edk2: Add qemu_x64 and qemu_i386 as new FLAVORs of edk2.
Jun 6 2022, 3:29 AM
bcran updated the diff for D35408: sysutils/edk2: Add qemu_x64 and qemu_i386 as new FLAVORs of edk2.

Add separate qemu_x64 and qemu_i386 flavors.

Jun 6 2022, 3:28 AM

Jun 5 2022

bcran added a comment to D35408: sysutils/edk2: Add qemu_x64 and qemu_i386 as new FLAVORs of edk2.

I'm not sure how to handle the fact that qemu (OVMF) firmware can be built for both x86_64 and i386.
The existing port uses FLAVOR, but since sysutils/edk2 already uses FLAVOR for the platform, I'm not sure how selecting the architecture should be done.

Jun 5 2022, 8:55 PM
bcran retitled D35408: sysutils/edk2: Add qemu_x64 and qemu_i386 as new FLAVORs of edk2 from sysutils/edk2: Add edk2 as a new FLAVOR of edk2 to sysutils/edk2: Add qemu as a new FLAVOR of edk2.
Jun 5 2022, 8:55 PM
bcran updated the diff for D35408: sysutils/edk2: Add qemu_x64 and qemu_i386 as new FLAVORs of edk2.

Fix summary.

Jun 5 2022, 8:54 PM
bcran requested review of D35408: sysutils/edk2: Add qemu_x64 and qemu_i386 as new FLAVORs of edk2.
Jun 5 2022, 8:51 PM

May 26 2022

bcran added a comment to D35321: Update sysutils/Makefile to remove deleted port uefi-edk2-bhyve.

Hi Rebecca, changes like this don't need review. It's best to commit them as quickly as possible since otherwise make index is broken.

May 26 2022, 6:52 PM
bcran requested review of D35321: Update sysutils/Makefile to remove deleted port uefi-edk2-bhyve.
May 26 2022, 2:38 AM

May 25 2022

bcran closed D35148: sysutils/edk2: Add bhyve as a new FLAVOR of edk2.
May 25 2022, 7:45 PM
bcran added a comment to D35148: sysutils/edk2: Add bhyve as a new FLAVOR of edk2.

Committed in https://cgit.freebsd.org/ports/commit/?id=2e6a6ccd15d1c2b83ea238325b9feddff4f8eaa7

May 25 2022, 7:45 PM
bcran committed R11:2e6a6ccd15d1: sysutils/edk2: Add bhyve as a new FLAVOR of edk2 (authored by bcran).
sysutils/edk2: Add bhyve as a new FLAVOR of edk2
May 25 2022, 7:34 PM
bcran updated the summary of D35148: sysutils/edk2: Add bhyve as a new FLAVOR of edk2.
May 25 2022, 2:10 AM
bcran updated the diff for D35148: sysutils/edk2: Add bhyve as a new FLAVOR of edk2.

Updated sysutils/bhyve-firmware to depend on edk2@bhyve

May 25 2022, 2:09 AM

May 21 2022

bcran abandoned D35053: sysutils/uefi-edk2-qemu: Update to upstream edk2-stable202202.
May 21 2022, 9:02 PM
bcran added a comment to D35053: sysutils/uefi-edk2-qemu: Update to upstream edk2-stable202202.

Hi Rebecca, intuitively this look good and you being our resident expert - do you want to go ahead and commit this?

May 21 2022, 9:02 PM

May 16 2022

bcran added a comment to D35148: sysutils/edk2: Add bhyve as a new FLAVOR of edk2.

Urgh, I remembered just in time about sysutils/bhyve-firmware that will also need updated.

May 16 2022, 3:43 PM
bcran updated the diff for D35148: sysutils/edk2: Add bhyve as a new FLAVOR of edk2.

Added entry to MOVED.

May 16 2022, 1:12 PM
bcran updated the diff for D35148: sysutils/edk2: Add bhyve as a new FLAVOR of edk2.

Actually deleted sysutils/uefi-edk2-bhyve this time.

May 16 2022, 1:08 PM

May 15 2022

bcran added a comment to D35148: sysutils/edk2: Add bhyve as a new FLAVOR of edk2.
In D35148#797304, @manu wrote:

You probably need a CONFLICT too for this flavor this you install links at the place of the other port.

May 15 2022, 6:05 PM
bcran updated the diff for D35148: sysutils/edk2: Add bhyve as a new FLAVOR of edk2.

Deleted sysutils/uefi-edk2-bhyve and added an entry to MOVED.

May 15 2022, 6:04 PM

May 9 2022

bcran added inline comments to D35148: sysutils/edk2: Add bhyve as a new FLAVOR of edk2.
May 9 2022, 1:09 AM
bcran updated the diff for D35148: sysutils/edk2: Add bhyve as a new FLAVOR of edk2.

Fixed Makefile

May 9 2022, 1:08 AM

May 8 2022

bcran added inline comments to D35148: sysutils/edk2: Add bhyve as a new FLAVOR of edk2.
May 8 2022, 7:33 PM
bcran added a comment to D35148: sysutils/edk2: Add bhyve as a new FLAVOR of edk2.

As I mentioned in the summary, the following code doesn't do what I want it to: it doesn't create /usr/local/share/uefi-firmware.

May 8 2022, 2:08 AM
bcran requested review of D35148: sysutils/edk2: Add bhyve as a new FLAVOR of edk2.
May 8 2022, 2:07 AM

Apr 25 2022

bcran updated the diff for D35053: sysutils/uefi-edk2-qemu: Update to upstream edk2-stable202202.

Keep USE_GCC

Apr 25 2022, 1:51 AM
bcran requested review of D35053: sysutils/uefi-edk2-qemu: Update to upstream edk2-stable202202.
Apr 25 2022, 1:37 AM

Dec 21 2021

bcran added a comment to D33391: Update sysutils/uefi-edk2-bhyve for edk2-stable202111.

Could I get approval from a port committer for this please?

Dec 21 2021, 8:09 PM

Dec 12 2021

bcran updated the diff for D33391: Update sysutils/uefi-edk2-bhyve for edk2-stable202111.

Keep PORTEPOCH at 2.

Dec 12 2021, 9:54 PM
bcran added a comment to D33391: Update sysutils/uefi-edk2-bhyve for edk2-stable202111.

Is it valid to reset PORTEPOCH to 1 when updating the PORTVERSION?

Dec 12 2021, 9:16 PM
bcran requested review of D33391: Update sysutils/uefi-edk2-bhyve for edk2-stable202111.
Dec 12 2021, 9:09 PM
bcran committed rG866036f46c6e: bhyve: Support a _VARS.fd file for bootrom (authored by bcran).
bhyve: Support a _VARS.fd file for bootrom
Dec 12 2021, 3:09 PM
bcran closed D19976: bhyve: Support a _VARS.fd file for bootrom.
Dec 12 2021, 3:08 PM

Dec 5 2021

bcran updated the diff for D19976: bhyve: Support a _VARS.fd file for bootrom.

Remove romfile_dup. Fix strdup/strsep.

Dec 5 2021, 3:11 AM
bcran added inline comments to D19976: bhyve: Support a _VARS.fd file for bootrom.
Dec 5 2021, 3:10 AM

Dec 1 2021

bcran added inline comments to D19976: bhyve: Support a _VARS.fd file for bootrom.
Dec 1 2021, 3:20 AM
bcran updated the diff for D19976: bhyve: Support a _VARS.fd file for bootrom.

Put allocations on one line.
Added {}.
Removed gpa variable, and used gpa_alloctop instead.

Dec 1 2021, 3:19 AM

Nov 28 2021

bcran updated the diff for D19976: bhyve: Support a _VARS.fd file for bootrom.

man page updates.

Nov 28 2021, 11:00 PM
bcran added inline comments to D19976: bhyve: Support a _VARS.fd file for bootrom.
Nov 28 2021, 10:59 PM
bcran updated the diff for D19976: bhyve: Support a _VARS.fd file for bootrom.

Fix romfile[,varfile] in man page.

Nov 28 2021, 7:23 PM
bcran updated the diff for D19976: bhyve: Support a _VARS.fd file for bootrom.

Add back checks for var_size and total_size.

Nov 28 2021, 5:08 PM
bcran updated the diff for D19976: bhyve: Support a _VARS.fd file for bootrom.

Fix tabs vs spaces.

Nov 28 2021, 4:43 PM
bcran updated the diff for D19976: bhyve: Support a _VARS.fd file for bootrom.

Update code to work against FreeBSD-CURRENT.

Nov 28 2021, 4:36 PM

Oct 21 2021

bcran committed rG35175e100add: bhyve: Bump the SMBIOS firmware version to 14.0 for 14-CURRENT (authored by bcran).
bhyve: Bump the SMBIOS firmware version to 14.0 for 14-CURRENT
Oct 21 2021, 4:16 AM
bcran closed D32534: bhyve: Bump the SMBIOS firmware version to 14.0 for 14-CURRENT.
Oct 21 2021, 4:15 AM
bcran accepted D32334: uefi(8): loader.efi does not search for loader.efi.
Oct 21 2021, 2:21 AM

Oct 17 2021

bcran requested review of D32534: bhyve: Bump the SMBIOS firmware version to 14.0 for 14-CURRENT.
Oct 17 2021, 10:30 AM

Jul 20 2021

bcran abandoned D31008: Reduce verbosity of the mrsas driver.
Jul 20 2021, 6:48 PM

Jul 7 2021

bcran added a reviewer for D31008: Reduce verbosity of the mrsas driver: sumit.saxena_broadcom.com.
Jul 7 2021, 4:19 PM

Jul 5 2021

bcran added a reviewer for D31008: Reduce verbosity of the mrsas driver: cam.
Jul 5 2021, 8:05 PM

Jul 3 2021

bcran updated the summary of D31008: Reduce verbosity of the mrsas driver.
Jul 3 2021, 4:38 AM
bcran retitled D31008: Reduce verbosity of the mrsas driver from Reduce verbosity of the mrsas driver I expect this is just a starting point for further discussion. The mrsas driver appears to me to be excessively verbose, so I've made an initial patch to move some of the lines that appear more to be debugging... to Reduce verbosity of the mrsas driver.
Jul 3 2021, 4:37 AM
bcran requested review of D31008: Reduce verbosity of the mrsas driver.
Jul 3 2021, 4:36 AM

May 31 2021

bcran added a comment to D26976: bhyve - ARMv8 implementation.

I tested the code from https://github.com/FreeBSD-UPB/freebsd-src/tree/projects/bhyvearm64/ (as of 2021-05-29) on my SolidRun Honeycomb system and it fails to allocate resources in the gicv3 code when I run kldload vmm.

May 31 2021, 5:50 AM

May 11 2021

bcran added inline comments to D30212: sysutils/uefi-edk2-xen: introduce port.
May 11 2021, 3:25 PM

May 2 2021

bcran added a comment to D30050: Adds uuid validation to bhyve(8) arg parsing.

With examples like Apple's "goto fail" bug (https://www.imperialviolet.org/2014/02/22/applebug.html) I'm surprised style(9) only allows, and doesn't recommend or mandate braces around single-line statements.

May 2 2021, 11:20 PM
bcran closed D30075: Update sysutils/uefi-edk2-bhyve to edk2-stable202002 release.
May 2 2021, 5:09 PM
bcran committed R11:4cec3f9086f3: sysutils/uefi-edk2-bhyve: Update to edk2-stable202002 tag (authored by bcran).
sysutils/uefi-edk2-bhyve: Update to edk2-stable202002 tag
May 2 2021, 5:09 PM
bcran requested review of D30075: Update sysutils/uefi-edk2-bhyve to edk2-stable202002 release.
May 2 2021, 1:50 AM

Apr 9 2021

bcran added a comment to D29657: bhyve: add SMBIOS Baseboard Information.

I noticed this is against the svn repo:

Repository rS FreeBSD src repository - subversion"

You'll probably want to switch over to Git and rebase this patch.

Apr 9 2021, 4:41 PM
bcran accepted D29657: bhyve: add SMBIOS Baseboard Information.

Just a comment typo: "number of contained objecct handles" - should be "object".

Apr 9 2021, 4:38 PM

Mar 28 2021

bcran closed D29254: sysutils/uefi-edk2-bhyve-csm: only depend on gcc48 for building.
Mar 28 2021, 4:43 AM
bcran committed rP569373: sysutils/uefi-edk2-bhyve-csm: only depend on gcc48 for building.
sysutils/uefi-edk2-bhyve-csm: only depend on gcc48 for building
Mar 28 2021, 4:43 AM

Mar 24 2021

bcran added a comment to D29254: sysutils/uefi-edk2-bhyve-csm: only depend on gcc48 for building.

@manu Sorry, could you re-approve the change please?

Mar 24 2021, 7:58 PM

Mar 20 2021

bcran added a comment to D29254: sysutils/uefi-edk2-bhyve-csm: only depend on gcc48 for building.
In D29254#656248, @manu wrote:

OK I see. Well for now just have a build time dep is better then.
Go ahead and commit this.

Mar 20 2021, 10:24 PM
bcran updated the diff for D29254: sysutils/uefi-edk2-bhyve-csm: only depend on gcc48 for building.

We'll also need to update the port revision.

Mar 20 2021, 10:24 PM

Mar 16 2021

bcran added a comment to D29254: sysutils/uefi-edk2-bhyve-csm: only depend on gcc48 for building.
In D29254#655711, @manu wrote:

Is the 4.8 version required for something ? Otherwise depending on lang/gcc would be better (not really sure if we have some way to do that).

Mar 16 2021, 12:03 PM
bcran added a comment to D29254: sysutils/uefi-edk2-bhyve-csm: only depend on gcc48 for building.

@woodsb02 Could you review and approve this for me, please?

Mar 16 2021, 4:03 AM

Mar 14 2021

bcran added a reviewer for D29254: sysutils/uefi-edk2-bhyve-csm: only depend on gcc48 for building: bhyve.
Mar 14 2021, 5:36 AM
bcran requested review of D29254: sysutils/uefi-edk2-bhyve-csm: only depend on gcc48 for building.
Mar 14 2021, 5:34 AM

Feb 18 2021

bcran added a comment to D19976: bhyve: Support a _VARS.fd file for bootrom.

Now the firmware work has been committed, I'll switch back to working on this.

Feb 18 2021, 3:46 AM
bcran closed D27230: Update bhyve related ports.
Feb 18 2021, 3:02 AM
bcran added a comment to D27230: Update bhyve related ports.

Committed as r565866.

Feb 18 2021, 3:02 AM
bcran committed rP565866: sysutils/uefi-edk2-bhyve*: Update and migrate to Python 3.
sysutils/uefi-edk2-bhyve*: Update and migrate to Python 3
Feb 18 2021, 2:57 AM

Feb 16 2021

bcran added a comment to D27230: Update bhyve related ports.
In D27230#642824, @jhb wrote:

I'm not a ports committer so can't really review the ports part, but I think moving the non-CSM ROM to the newer one seems fine. I think grehan@ has also already signed off on this?

Feb 16 2021, 8:34 PM

Feb 15 2021

bcran added a comment to D27230: Update bhyve related ports.

At this point, I'd like to get this committed as soon as possible so we can move away from gcc 4.8 and python 2.

Feb 15 2021, 6:32 AM
bcran updated the diff for D27230: Update bhyve related ports.

Updated to code from today's master, 2021-02-14.

Feb 15 2021, 6:31 AM

Jan 16 2021

bcran updated subscribers of D27970: bhyve: move 64 bit BAR location to match OVMF assumptions.
Jan 16 2021, 6:28 AM · bhyve
bcran added a comment to D27970: bhyve: move 64 bit BAR location to match OVMF assumptions.

The patch no longer applies against 13-CURRENT: I needed to apply several lines manually.

Jan 16 2021, 6:17 AM · bhyve
bcran updated subscribers of D27970: bhyve: move 64 bit BAR location to match OVMF assumptions.

This works for me. I was seeing an assert failure in pci_emul.c, but it disappeared for some reason.
One person on Slack said they'd like the BAR in a fixed (high) location, so I wouldn't be confident committing this without other people (e.g. @jhb and @grehan ) reviewing it too.

Jan 16 2021, 6:16 AM · bhyve

Jan 5 2021

bcran added a comment to D27970: bhyve: move 64 bit BAR location to match OVMF assumptions.

OVMF puts it at the next 16GB boundary, which might be better.

Jan 5 2021, 8:17 PM · bhyve

Dec 28 2020

bcran added a comment to D27782: uefi.8: mention boot1.efi.

Also, /boot/boot1.efifat is no longer included in -CURRENT.

Dec 28 2020, 2:46 PM
bcran added a comment to D27782: uefi.8: mention boot1.efi.

/boot/boot1.efifat is the 800 KB filesystem image. /boot/boot1.efi is the EFI bootloader application.

Dec 28 2020, 2:43 PM

Dec 26 2020

bcran added a comment to D27230: Update bhyve related ports.

UEFI is configuring an address size less than that which the host CPU supports, because (cc @grehan) :

//
// As guest-physical memory size grows, the permanent PEI RAM requirements
// are dominated by the identity-mapping page tables built by the DXE IPL.
// The DXL IPL keys off of the physical address bits advertized in the CPU
// HOB. To conserve memory, we calculate the minimum address width here.
Dec 26 2020, 7:57 AM
bcran added a comment to D27230: Update bhyve related ports.

@c.koehne_beckhoff.com
I see what's going wrong, and have reproduced the issue on my Threadripper system.
EDK2 firmware configures the maximum address based on the size of guest memory, with a minimum of 64GB (36 bits).
But the PCI code in bhyve puts the BAR at (highest host CPU address / 4) - meaning that on my system it puts it at 64TB.

Dec 26 2020, 7:28 AM

Dec 24 2020

bcran added a comment to D27230: Update bhyve related ports.

I successfully installed and ran Windows 10 with the new firmware today.
So I think the last remaining issue will be the MemAbove4G problem.

Dec 24 2020, 8:12 AM

Dec 23 2020

bcran added a comment to D24066: bhyve: support relocating fbuf and passthru data BARs.

The patch no longer applies cleanly: I had to make some changes.
But after that, I was able to run Ubuntu 20.10 with gEfiMdeModulePkgTokenSpaceGuid.PcdPciDisableBusEnumeration set to TRUE and FALSE with the following command line, which uses both rfb and passthru:

bhyve -AH -s 0:0,hostbridge -s 31:0,lpc -c 1 -m 16G -l bootrom,BHYVE_CODE.fd -l com1,stdio -s 3:0,ahci-hd,bhyve-ubuntu-20_10.img  -s 7,ahci-cd, -s 8,virtio-rnd -s 6,virtio-net,tap0 -s 9,fbuf,rfb=10.0.10.117:5900,w=1920,h=1200 -s 10,xhci,tablet -s 11,passthru,24/0/0 -S guest
Dec 23 2020, 7:52 AM · bhyve
bcran added a comment to D27230: Update bhyve related ports.

Apologies for being absent recently - life took over... but I’ll have some time to look at this again between Xmas and New Year.

I've had a report that Windows 10 crashes (bugchecks) with this firmware, so I need to do more testing (on FreeBSD 11, 12 and 13-CURRENT) before committing it.

Any progress fixing this? Would you like to commit the update using one revision older from upstream that didn’t have this issue?

Dec 23 2020, 6:50 AM
bcran added a comment to D24300: Bhyve: SMBIOS bcdrev calculated from major/minor values.

This was fixed in rS359719, so I think this review should be closed.

Dec 23 2020, 6:28 AM

Dec 22 2020

bcran added a comment to D27230: Update bhyve related ports.
In D27230#617382, @c.koehne_beckhoff.com wrote:
Dec 22 2020, 6:23 AM

Dec 14 2020

bcran added a comment to D27230: Update bhyve related ports.

I've uploaded new binaries to https://people.freebsd.org/~bcran/bhyve/BhyveX64-20201213/ .

Dec 14 2020, 6:53 AM
bcran added a comment to D27230: Update bhyve related ports.

I've had a report that Windows 10 crashes (bugchecks) with this firmware, so I need to do more testing (on FreeBSD 11, 12 and 13-CURRENT) before committing it.

Dec 14 2020, 6:26 AM
bcran updated the diff for D27230: Update bhyve related ports.

Update the version to 20201213 and move the GH tag today's sources

Dec 14 2020, 5:50 AM