arm64: Connect bhyve and libvmmapi to the build
ClosedPublic
Actions

Also need an update to tools/build/options/WITHOUT_BHYVE it looks like
I'm not sure why bhyve was done the way it was though, rather than having MK_BHYVE default be set based on arch.

Update the src.conf.5 description for WITH_BHYVE.

Harbormaster completed remote builds in B53448: Diff 126904.Sep 5 2023, 6:38 PM

emaste accepted this revision.Sep 5 2023, 6:40 PM

This revision is now accepted and ready to land.Sep 5 2023, 6:40 PM

I still have a couple of WIP patches: one to update the bhyve man page a bit, and another to update option parsing and usage strings. There are quite a few further TODOs: gdb support, PCI passthrough support, ACPI support. I've started working on the gdb stub in the background.

I still have a couple of WIP patches: one to update the bhyve man page a bit, and another to update option parsing and usage strings.

Yeah, I assumed this change will go in towards the end of the series, but it looks good to me when you're ready to push it.

jhb accepted this revision.Sep 5 2023, 10:08 PM

corvink accepted this revision.Sep 6 2023, 9:29 AM

andrew accepted this revision.Sep 6 2023, 9:41 AM

The change to usr.sbin/Makefile.aarch64 no longer applies following commit 773606fcdfae00a3f850bcd39969a63d9a8fb129.
I'm probably missing something since I'm just catching up with this work, but 'make buildworld' fails in usr.sbin/bhyve:

===> usr.sbin/bhyve (includes)
make[4]: "/home/bcran/src/usr.sbin/bhyve/Makefile" line 68: Could not find aarch64/Makefile.inc
make[4]: Fatal errors encountered -- cannot continue
make[4]: stopped in /home/bcran/src/usr.sbin/bhyve

Rebase

This revision now requires review to proceed.Oct 30 2023, 1:16 PM

Harbormaster completed remote builds in B54209: Diff 129514.Oct 30 2023, 1:16 PM

corvink accepted this revision.Oct 30 2023, 2:12 PM

This revision is now accepted and ready to land.Oct 30 2023, 2:12 PM

emaste accepted this revision.Oct 30 2023, 2:24 PM

I've just applied the latest version of this patch but it's still looking for aarch64/Makefile.inc both during a "make buildworld" and a "make" in usr.sbin/bhyve on my Ampere system:

bcran@gluon:~/src/freebsd/usr.sbin/bhyve % make
make: "/home/bcran/src/freebsd/usr.sbin/bhyve/Makefile" line 68: Could not find aarch64/Makefile.inc
make: Fatal errors encountered -- cannot continue
make: stopped in /home/bcran/src/freebsd/usr.sbin/bhyve

In D41742#969228, @bcran wrote:
I've just applied the latest version of this patch but it's still looking for aarch64/Makefile.inc both during a "make buildworld" and a "make" in usr.sbin/bhyve on my Ampere system:
bcran@gluon:~/src/freebsd/usr.sbin/bhyve % make
make: "/home/bcran/src/freebsd/usr.sbin/bhyve/Makefile" line 68: Could not find aarch64/Makefile.inc
make: Fatal errors encountered -- cannot continue
make: stopped in /home/bcran/src/freebsd/usr.sbin/bhyve

This is just one patch of a few that are required: see the "stack" tab. The full patch series is available at https://github.com/markjdb/freebsd/tree/bhyvearm64-upstream

Closed by commit rG11c79f9e358d: arm64: Connect bhyve and libvmmapi to the build (authored by markj). · Explain WhyWed, Apr 10, 3:20 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG11c79f9e358d: arm64: Connect bhyve and libvmmapi to the build.