bhyve: Rename a pci_cfgrw() parameter
ClosedPublic
Actions

Authored by markj on Jun 23 2023, 10:03 PM.

Details

Reviewers

jhb
corvink

Group Reviewers

bhyve

Commits

rGb16a120b3b9b: bhyve: Rename a pci_cfgrw() parameter
rGf4841d8af0cd: bhyve: Rename a pci_cfgrw() parameter

Summary

pci_cfgrw() may be called via a write to the extended config space,
which is memory-mapped. In this case, the name "eax" is misleading.
Give it a more generic name. No functional change intended.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Jun 23 2023, 10:03 PM

Herald added a reviewer: bhyve. · View Herald TranscriptJun 23 2023, 10:03 PM

Herald added subscribers: bcran, rgrimes, imp. · View Herald Transcript

markj requested review of this revision.Jun 23 2023, 10:03 PM

markj added a child revision: D40733: bhyve: Move MSR emulation into amd64/.

Harbormaster completed remote builds in B52266: Diff 123696.Jun 23 2023, 10:03 PM

markj added a parent revision: D40556: bhyve: Split vmexit handling into a separate file.Jun 23 2023, 10:04 PM

corvink accepted this revision.Jun 26 2023, 6:02 AM

This revision is now accepted and ready to land.Jun 26 2023, 6:02 AM

jhb accepted this revision.Jun 27 2023, 7:04 PM

Closed by commit rGf4841d8af0cd: bhyve: Rename a pci_cfgrw() parameter (authored by markj). · Explain WhyJun 28 2023, 8:47 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rGf4841d8af0cd: bhyve: Rename a pci_cfgrw() parameter.

markj added a commit: rGb16a120b3b9b: bhyve: Rename a pci_cfgrw() parameter.Jul 5 2023, 1:08 PM

Revision Contents
Changeset List

Path

Size

usr.sbin/

bhyve/

pci_emul.c

34 lines

Diff 123928

View Options

bhyve: Rename a pci_cfgrw() parameterClosedPublicActions