Differential D41001

libvmmapi: Split the ioctl list into MI and MD lists
ClosedPublic
Actions

Authored by markj on Jul 12 2023, 1:53 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, May 16, 9:12 PM

	Unknown Object (File)
	Sat, May 11, 12:03 AM

	Unknown Object (File)
	Thu, May 2, 3:31 PM

	Unknown Object (File)
	Thu, May 2, 2:13 PM

	Unknown Object (File)
	Sat, Apr 27, 12:34 PM

	Unknown Object (File)
	Sat, Apr 27, 12:34 PM

	Unknown Object (File)
	Sat, Apr 27, 12:33 PM

	Unknown Object (File)
	Sat, Apr 27, 10:58 AM

View All 19 Files

Subscribers

Details

Reviewers

jhb
corvink
andrew

Group Reviewers

Commits

rG7f00e46b85e8: libvmmapi: Split the ioctl list into MI and MD lists

Summary

To enable use in capability mode, libvmmapi needs a list of all the
ioctls that might be invoked on the vmm device handle. Some of these
ioctls are amd64-specific. Move the ioctl list to vmmapi_machdep.c and
define a list of MI ioctls so that the arm64 port can build its own list
without duplicating common ioctls. No functional change intended.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Jul 12 2023, 1:53 PM

Herald added a reviewer: bhyve. · View Herald TranscriptJul 12 2023, 1:53 PM

Herald added subscribers: rgrimes, imp. · View Herald Transcript

markj requested review of this revision.Jul 12 2023, 1:53 PM

Harbormaster completed remote builds in B52594: Diff 124563.Jul 12 2023, 1:53 PM

markj added a parent revision: D41000: libvmmapi: Move VM capability names to vmmapi_machdep.c.Jul 12 2023, 1:53 PM

markj added a child revision: D41002: libvmmapi: Move more amd64-specific ioctl wrappers to vmmapi_machdep.c.

jhb added inline comments.Jul 12 2023, 6:55 PM

lib/libvmmapi/amd64/vmmapi_machdep.c
82	Does only VM_MD_IOCTLS differ on arm64? That might motivate wanting a vmmap_internal_machdep.h or the like instead?

jhb accepted this revision.Jul 12 2023, 6:57 PM

jhb added inline comments.

lib/libvmmapi/amd64/vmmapi_machdep.c
82	Ok, based on the ppt.c review, I'm guessing arm64 won't have VM_PPT_IOCTLS.

This revision is now accepted and ready to land.Jul 12 2023, 6:57 PM

corvink accepted this revision.Jul 13 2023, 6:43 AM

markj marked 2 inline comments as done.Jul 17 2023, 3:53 PM

markj added inline comments.

lib/libvmmapi/amd64/vmmapi_machdep.c
82	Right, no PCI passthrough support on arm64 for now.

Closed by commit rG7f00e46b85e8: libvmmapi: Split the ioctl list into MI and MD lists (authored by markj). · Explain WhyApr 10 2024, 3:19 PM

This revision was automatically updated to reflect the committed changes.

markj marked an inline comment as done.

markj added a commit: rG7f00e46b85e8: libvmmapi: Split the ioctl list into MI and MD lists.

Revision Contents
Changeset List

Path

Size

lib/

libvmmapi/

amd64/

vmmapi_machdep.c

34 lines

48 lines

37 lines

Diff 136853

lib/libvmmapi/amd64/vmmapi_machdep.c

Loading...

lib/libvmmapi/internal.h

Loading...

lib/libvmmapi/vmmapi.c

Loading...