Page MenuHomeFreeBSD

libvmmapi: Split the ioctl list into MI and MD lists
AcceptedPublic

Authored by markj on Jul 12 2023, 1:53 PM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 20 2023, 2:05 AM
Unknown Object (File)
Dec 11 2023, 4:28 AM
Unknown Object (File)
Sep 3 2023, 2:37 PM
Unknown Object (File)
Aug 27 2023, 2:53 PM
Unknown Object (File)
Aug 14 2023, 2:09 PM
Unknown Object (File)
Aug 14 2023, 2:09 AM
Unknown Object (File)
Aug 13 2023, 12:41 PM
Unknown Object (File)
Jul 15 2023, 8:53 PM
Subscribers

Details

Reviewers
jhb
corvink
andrew
Group Reviewers
bhyve
Summary

To enable use in capability mode, libvmmapi needs a list of all the
ioctls that might be invoked on the vmm device handle. Some of these
ioctls are amd64-specific. Move the ioctl list to vmmapi_machdep.c and
define a list of MI ioctls so that the arm64 port can build its own list
without duplicating common ioctls. No functional change intended.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 52594
Build 49485: arc lint + arc unit

Event Timeline

markj requested review of this revision.Jul 12 2023, 1:53 PM
lib/libvmmapi/amd64/vmmapi_machdep.c
81

Does only VM_MD_IOCTLS differ on arm64? That might motivate wanting a vmmap_internal_machdep.h or the like instead?

jhb added inline comments.
lib/libvmmapi/amd64/vmmapi_machdep.c
81

Ok, based on the ppt.c review, I'm guessing arm64 won't have VM_PPT_IOCTLS.

This revision is now accepted and ready to land.Jul 12 2023, 6:57 PM
markj added inline comments.
lib/libvmmapi/amd64/vmmapi_machdep.c
81

Right, no PCI passthrough support on arm64 for now.