Page MenuHomeFreeBSD

bhyve: Add PL011 UART emulation
AcceptedPublic

Authored by markj on Jul 12 2023, 1:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 18 2024, 12:49 AM
Unknown Object (File)
Dec 20 2023, 4:29 AM
Unknown Object (File)
Dec 18 2023, 5:40 PM
Unknown Object (File)
Dec 16 2023, 4:36 PM
Unknown Object (File)
Dec 11 2023, 4:30 AM
Unknown Object (File)
Nov 21 2023, 3:30 AM
Unknown Object (File)
Nov 20 2023, 9:48 PM
Unknown Object (File)
Nov 20 2023, 9:21 PM

Details

Reviewers
jhb
corvink
andrew
Group Reviewers
bhyve
Summary

This is to be used instead of the existing ns16550 emulation, with which
it shares backend code from uart_backend.c.

Obtained from https://github.com/zxombie/freebsd/tree/bhyvearm64

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 52590
Build 49481: arc lint + arc unit

Event Timeline

markj requested review of this revision.Jul 12 2023, 1:52 PM
jhb added inline comments.
usr.sbin/bhyve/uart_emul.h
40

Maybe fix this part in the original commit adding uart_backend.c?

This revision is now accepted and ready to land.Jul 12 2023, 6:50 PM
corvink added inline comments.
usr.sbin/bhyve/aarch64/uart_pl011.c
1

Is the ns16550 and pl011 uart really MD? amd64 may make use of ns16550 while arm64 makes use of pl011 by default. However, if both emulations can be used on both architectures, we shouldn't move the code to amd64/ or aarch64/.

markj added inline comments.
usr.sbin/bhyve/aarch64/uart_pl011.c
1

Yes, I probably should keep them in the base directory. Originally I added uart_pl011.c to aarch64 because it was somewhat coupled to the FDT builder.