Page MenuHomeFreeBSD

bhyve: Build the HPET ACPI table on amd64 only
ClosedPublic

Authored by markj on Jul 12 2023, 1:51 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Feb 6, 1:34 AM
Unknown Object (File)
Jan 20 2024, 4:05 AM
Unknown Object (File)
Dec 22 2023, 11:47 PM
Unknown Object (File)
Dec 11 2023, 4:33 AM
Unknown Object (File)
Oct 4 2023, 11:30 PM
Unknown Object (File)
Sep 1 2023, 5:54 AM
Unknown Object (File)
Aug 27 2023, 2:53 PM
Unknown Object (File)
Aug 14 2023, 2:31 PM
Subscribers

Details

Summary

There is no HPET on arm64 and vm_get_hpet_capabilities() is not
implemented there. Move the vm_get_hpet_capabilities() call into
build_hpet(): I cannot see a downside, and doing so eliminates a global
variable and reduces the amount of code that needs to be conditionally
compiled. No functional change intended.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Jul 12 2023, 6:43 PM
corvink added inline comments.
usr.sbin/bhyve/acpi.c
536

Not sure if you remove these ifdefs in a subsequent commit. I'd prefer removing them. Therefore, we can add a build_platform_tables function or we can use a linker set.

usr.sbin/bhyve/acpi.c
536

I haven't removed them yet. I'm working on getting arm64 booting with ACPI instead of a FDT. I'll try to find a nicer way to handle this.

This revision was automatically updated to reflect the committed changes.