bhyve: Build the HPET ACPI table on amd64 only
ClosedPublic
Actions

Authored by markj on Jul 12 2023, 1:51 PM.

Details

Reviewers

jhb
corvink
andrew

Group Reviewers

bhyve

Commits

rGa43a3efa5ab1: bhyve: Build the HPET ACPI table on amd64 only
rG83b003fbe965: bhyve: Build the HPET ACPI table on amd64 only

Summary

There is no HPET on arm64 and vm_get_hpet_capabilities() is not
implemented there. Move the vm_get_hpet_capabilities() call into
build_hpet(): I cannot see a downside, and doing so eliminates a global
variable and reduces the amount of code that needs to be conditionally
compiled. No functional change intended.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Jul 12 2023, 1:51 PM

Herald added a reviewer: bhyve. · View Herald TranscriptJul 12 2023, 1:51 PM

Herald added subscribers: bcran, rgrimes, imp. · View Herald Transcript

Harbormaster completed remote builds in B52583: Diff 124552.Jul 12 2023, 1:51 PM

markj requested review of this revision.Jul 12 2023, 1:51 PM

markj added a parent revision: D40989: bhyve: Move most early initialization into an MD routine.

markj added a child revision: D40991: bhyve: Move the vm_inject_fault() implementation to vmexit.c.

jhb accepted this revision.Jul 12 2023, 6:43 PM

This revision is now accepted and ready to land.Jul 12 2023, 6:43 PM

corvink accepted this revision.Jul 13 2023, 5:52 AM

corvink added inline comments.

usr.sbin/bhyve/acpi.c
536	Not sure if you remove these ifdefs in a subsequent commit. I'd prefer removing them. Therefore, we can add a `build_platform_tables` function or we can use a linker set.