Page MenuHomeFreeBSD

bhyve: Compile some device models only on amd64
ClosedPublic

Authored by markj on Jun 23 2023, 10:03 PM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 20 2023, 8:21 AM
Unknown Object (File)
Dec 11 2023, 4:30 AM
Unknown Object (File)
Nov 21 2023, 5:29 AM
Unknown Object (File)
Nov 21 2023, 5:14 AM
Unknown Object (File)
Nov 13 2023, 12:53 AM
Unknown Object (File)
Nov 11 2023, 2:36 PM
Unknown Object (File)
Nov 11 2023, 12:57 AM
Unknown Object (File)
Nov 10 2023, 2:59 PM

Details

Summary

These models register legacy PCI interrupts, which won't be supported in
the arm64 port. In principle it should be possible to make these models
work on arm64 with a bit of effort, so don't move the sources to the
amd64 subdirectory.

No functional change intended.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Jun 26 2023, 6:05 AM
jhb added inline comments.
usr.sbin/bhyve/amd64/Makefile.inc
13

I kind of feel like this one might be x86 specific, though I think it's also QEMU specific?

markj added inline comments.
usr.sbin/bhyve/amd64/Makefile.inc
13

pctestdev? As I understand it's used to support KVM unit tests. Currently it's amd64-specific since it registers an I/O port space but I think it might be used for an arm64 port of the same tests? I think @andrew would know more.

usr.sbin/bhyve/amd64/Makefile.inc
13

Yeah, pctestdev. It's easy enough to move back later if we find QEMU supports it on arm64.

usr.sbin/bhyve/amd64/Makefile.inc
13

pc-testdev is x86/amd64 only. We have to implement another qemu testdev for arm64. See

https://www.linux-kvm.org/page/KVM-unit-tests#Testdevs