User Details
- User Since
- Mar 12 2014, 1:00 AM (522 w, 6 d)
Yesterday
Overall I like it, but maybe we need a way to define keys for all flavors of a package. See my inline comment about ssh.
This diff is hard to read. :( For instance, why not split the changes to unp_internalize() and unp_addsockcred() into different patches?
Fri, Mar 15
Sat, Mar 9
Thu, Mar 7
Tue, Mar 5
Wed, Feb 21
I don't have any more comments. Thank you for working on this!
Handle Brooks' comments.
Tue, Feb 20
Mon, Feb 19
Seems fine to me, I just pointed out some style bugs.
Sun, Feb 18
Approved.
Approved.
Seems reasonable to me.
Feb 17 2024
Could you please explain the underlying problem that's fixed here?
Feb 16 2024
Feb 15 2024
Feb 14 2024
Feb 13 2024
Feb 12 2024
I wonder if using make(1) is really a good choice for this. Doing things like computing the RAM size of the VM in make feels awkward. There's also no good way to see what parameters are available to developers, and the framework is not friendly to user error (e.g., misspelling a variable name on the command line means that make will silently do the wrong thing). There is no namespacing for parameters (parameters for the build, VM boot, and the test itself are all mixed together).
Check for -g[0-3] as well.