- User Since
- Mar 12 2014, 1:00 AM (247 w, 6 d)
I would suggest explaining the difference between -o cpu and -o core in the description of the -o option.
Sorry to nag, but did you get a chance to test this?
Sun, Dec 9
Sat, Dec 8
- Disable casper in the rescue build.
Fri, Dec 7
- Get rid of the (inconsistently used) predicates and just use inline tests.
- Address feedback from cem.
- Further cleanup based on feedback.
Thu, Dec 6
Update the zopen.3 man page.
Wed, Dec 5
@pho has a number of gmirror stress tests. Peter, do you mind giving this patch a try?
Most of my inline comments are nits, but: I don't really understand how the wakeup() mechanism works with the per-CPU caches. Threads may remain asleep on "zonelimit" indefinitely if uz_items == uz_maxitems but active threads are able to avoid the slow path. Before, the ZFLAG_FULL check in the zfree fast path handled this. Is there anything preventing starvation?
Tue, Dec 4
- Fix an off-by-one.
- Retire INP_PCBLBGROUP_PORTHASH. It's identical to INP_PCBPORTHASH, and because we now size the hash tables accurately, it would be nice to consistently use the same port hash everywhere.
- Attempt to handle all of the bugs that Alan pointed out.
Mon, Dec 3
I suspect that the anon clustering will interact suboptimally with the jemalloc behaviour discussed in D16501 and elsewhere. In particular, jemalloc will unmap small regions of the address space, leaving holes. With clustering, those holes won't be reused since we no longer perform a first-fit search. IMO it would be worth reconsidering how anon_loc works; rather than advancing it after each successful clustering, maybe it should be constant after the initialization to a non-zero value, so that we attempt to fill holes with new mappings before extending the clustered region further. I do not think this needs to be done prior to commit though.
Address some of the feedback. I left replies for the rest.
Address remaining issues:
- Generalize the probe service to all unconnected sendmsg() calls. I had been creating one pre-connected socket per interface, but that only works if the interface is up when rtsold starts. If it comes up after we enter capability mode, we're stuck.
- We can't call getifaddrs() in capability mode. (The SIOCGIFINFO ioctl does effectively the same thing, though, and is permitted in capability mode.) For now, just add yet another casper service to get the address flags of the link-local address on a specified interface.
Explicitly bzero 32bit compat register structures in sys_ptrace().
- Zero out reg structs in procfs too.
This mostly LGTM, a couple of nits inline.