• Address feedback, verb -> command in the usage message.

In D28334#633784, @debdrup wrote:

I might also be convinced to write a git-arc(8) man-page. ;)

I think maybe we should revert the change, if it is truly unfounded and was only observed on 12. If this wasn't ever a problem on CURRENT, the commit message rationale is wrong and misleading. Reverting is the canonical way to correct that kind of thing.

In D28260#632587, @markj wrote:

In D28260#632585, @cem wrote:

Wait, kldxref should be ordering these correctly since rS348309. Why isn't it?

Probably because I hit this issue on stable/12 and didn't notice that kldxref was fixed.

In D28260#632585, @cem wrote:

Wait, kldxref should be ordering these correctly since rS348309. Why isn't it?

LGTM with the modifications you proposed.

In D26538#632166, @jmg wrote:

I know this was closed and committed, but I want to get some more discussion on this.

I happen to be reviewing this for my own code (to get at _hwassist), and noticed that the code does not check how much space the program allocated for the if_data structure. This means that as the interface stands, it cannot be expanded, ever in the future, as it'll break old programs when they use this.

In D28194#631525, @jhb wrote:

Perhaps update crypto_request.9 as well?

Remove VM_KMEM_SIZE_MIN as well.

Sorry for not catching this.

In D28155#629666, @vsasjason_gmail.com wrote:

Unfortunately, diff isn't finished yet. Following removal from $4 an appropriate entry to $3 should be added as well.

In D28160#630053, @ae wrote:

I think the patch in D28187 is better. You need to release reference to SP when error occurs before ipsec4_process_packet().