- User Since
- Mar 12 2014, 1:00 AM (288 w, 3 d)
Wed, Sep 18
I think I've brought this up before, but I would like it if the VM had a generic per-2MB page structure. We already have several in vm_reserv and the pmap, and IMO it would be a good place to maintain a "compound" busy state, rather than in the object. I worry that a mechanism to block the busying of all pages in an object will inhibit concurrency and lead to transient latency spikes. I don't object to the current approach though.
Tue, Sep 17
I have no objections to the change in principle, it's a nice cleanup. It would cause a massive amount of churn: we have about 2000 uses of mtod() in the tree, and downstream trees will have many thousands more. I think such a change deserves a wider discussion on -arch or so.
I don't see why this is sufficient. If the unlocked translation attempt fails, e.g., because the mapping is being promoted or demoted a second time, we may still attempt to acquire a mutex in a scenario where that is not allowed.
Mon, Sep 16
Sun, Sep 15
Restore lost comment.
Why did you change the meaning of -I instead of putting the new functionality under a new option?
Fri, Sep 13
I have no objection to this with a separate header and man page. It does seem convenient to have a map structure that can be copied with memcpy() or copyout() or so.
- Remove PMAP_PA_ADDRESS.
Thu, Sep 12
Address most of the feedback from Jeff.
Any reason not to commit this?
Does this fix an observed bug? The waiter bit should only be set if the counter value is non-zero, so the comparisons with 0 should work correctly regardless. I agree with the change though.
Wed, Sep 11
Tue, Sep 10
The change LGTM. I would consider keeping the vm_fault() wrapper for vm_fault_hold(), to avoid churn if vm_fault_hold() ever needs to grow additional arguments.
The comment I made in D21482 about configuration from outside vnet0 really belongs here, but the change otherwise LGTM.
Mon, Sep 9
Sun, Sep 8
Sorry for the delay.