Page MenuHomeFreeBSD

markj (Mark Johnston)
User

Projects (8)

User Details

User Since
Mar 12 2014, 1:00 AM (540 w, 6 d)

Recent Activity

Today

markj accepted D45812: malloc(9): extend contigmalloc(9) by a "slab cookie".
Tue, Jul 23, 6:36 PM
markj accepted D46093: kern_malloc: remove '.' and '\n' from KASSERT/panic.
Tue, Jul 23, 6:31 PM
markj committed rG97d88163d468: ktls: Remove the socket parameter to ktls_ocf_try() (authored by markj).
ktls: Remove the socket parameter to ktls_ocf_try()
Tue, Jul 23, 1:20 PM
markj committed rGf5fabf3dcfb6: socket: Simplify synchronization in soreceive_stream() (authored by markj).
socket: Simplify synchronization in soreceive_stream()
Tue, Jul 23, 1:20 PM
markj committed rG030cbcc4c231: if_urndis: Organize buffer layouts more naturally (authored by markj).
if_urndis: Organize buffer layouts more naturally
Tue, Jul 23, 1:20 PM
markj committed rGb14a49128381: ktls: Fix races that can lead to double initialization (authored by markj).
ktls: Fix races that can lead to double initialization
Tue, Jul 23, 1:20 PM
markj committed rG4d8e3fafda19: ndp: Fix libxo formatting for the prefix expiry string (authored by markj).
ndp: Fix libxo formatting for the prefix expiry string
Tue, Jul 23, 1:20 PM
markj committed rG88c041e4870c: socket: Pass capsicum rights down to socket option handlers (authored by markj).
socket: Pass capsicum rights down to socket option handlers
Tue, Jul 23, 1:20 PM
markj accepted D46039: vnet tests: verify that we can load if_epair and if_bridge.
Tue, Jul 23, 1:11 PM
markj added a comment to D45163: vm: Allow kstack pages to come from different domains.

According to the the 15.0 planning document, we want to get rid of swapping out kernel stacks entirely (listed by @markj).
If that's still the case, we can drop this patch entirely and just retire vm_thread_swap{out, in}.

Tue, Jul 23, 1:07 PM
markj accepted D46070: mitigations(7): note that FORTIFY_SOURCE must be set in the env.
Tue, Jul 23, 1:00 PM
markj accepted D46063: vm: Retire vm_page_alloc_freelist{,_domain}().
Tue, Jul 23, 1:00 PM
markj accepted D45812: malloc(9): extend contigmalloc(9) by a "slab cookie".

Looks good, I like this change.

Tue, Jul 23, 12:59 PM

Yesterday

markj accepted D46061: iflib: Simplify iflib_legacy_setup.
Mon, Jul 22, 10:39 PM
markj added a comment to D46063: vm: Retire vm_page_alloc_freelist{,_domain}().

The removed functions are also documented in share/man/man9/vm_page_alloc.9 (and have MLINKS in share/man/man9/Makefile).

Mon, Jul 22, 10:34 PM
markj added a comment to D45982: snd_hdsp*: Free up channel resources in case of CHANNEL_INIT() failure.

While testing with snd_hdspe I ran into the following warning, but I can't really make sense of it:

Jul 21 17:36:14 current kernel: uma_zalloc_debug: zone "malloc-16384" with the following non-sleepable locks
held:

This is a consequence of the fact that sndstat_read() works by allocating an sbuf, which may grow as data is added, then copying out the resulting buffer via uiomove().

In general, blocking memory allocations are not permitted while holding a mtx(9) mutex, hence the warning. To work around this, one would typically add a "drain" callback function to the sbuf, that it calls to write out data once the buffer is full. In this case, the callback would write out buffered data via uiomove(), after which the buffer can be reused and thus doesn't need to grow. See sbuf_set_drain(9).

I will take care of this. Thanks.

Mon, Jul 22, 2:22 PM
markj added inline comments to D45979: sound: Fix memory leak in chn_init().
Mon, Jul 22, 2:03 PM
markj added a comment to D45969: sound examples: Add sndstat nvlist example.

What does the example program actually do? It would be useful to have an explanation somewhere in the file.

It showcases how the sndstat nvlist interface can be used to extract all the information currently available. The man page already include a basic example section, but I think it's nice to have this program as well which can be run immediately and show how every single field can be fetched.

Mon, Jul 22, 2:02 PM
markj added a comment to D46020: nd6: Fix the routing table subscription.

Ty for working on that! IIRC the idea of rib_decompose_notification was to provide the same handling for both multipath and non-multipath routes for the callers that care only about specific paths. I'd rather add the relevant callback to the rib_decompose_notification() and not touch nd6_subscription_cb code.

To be clear, you are asking me to:

  • make rib_decompose_notification() work for non-multipath nexthops, i.e., just remove the NH_IS_NHGRP() checks
  • move rib_decompose_notification() out of the ROUTE_MPATH ifdef
  • fix up existing callers

?

Mon, Jul 22, 1:53 PM
markj updated the diff for D46020: nd6: Fix the routing table subscription.

Avoid invoking the callback twice for multipath routes.

Mon, Jul 22, 1:52 PM
markj committed rGf48bfa248f39: axgbe: Remove a nonsensical use of kernel_sysctlbyname() (authored by markj).
axgbe: Remove a nonsensical use of kernel_sysctlbyname()
Mon, Jul 22, 12:56 AM
markj committed rG73ee1909bfcf: netlink: Wrap long lines (authored by markj).
netlink: Wrap long lines
Mon, Jul 22, 12:56 AM
markj committed rGc1dd895406a8: sched tests: Avoid underflow when maxcpuid == 0 (authored by markj).
sched tests: Avoid underflow when maxcpuid == 0
Mon, Jul 22, 12:56 AM
markj committed rGa8a1633e34f1: lockf tests: Fix a race (authored by markj).
lockf tests: Fix a race
Mon, Jul 22, 12:56 AM
markj committed rG239c9c6de125: hptiop: Use device_set_descf() (authored by markj).
hptiop: Use device_set_descf()
Mon, Jul 22, 12:56 AM
markj committed rG3985e96ac5c6: route: Wrap long lines (authored by markj).
route: Wrap long lines
Mon, Jul 22, 12:56 AM
markj committed rG7d521f0a61ff: buf_ring: Make buf_ring.h amenable to userspace compilation (authored by markj).
buf_ring: Make buf_ring.h amenable to userspace compilation
Mon, Jul 22, 12:56 AM
markj committed rGdc1f4c3d9aab: libdtrace: Use designated initializers for modules ops tables (authored by markj).
libdtrace: Use designated initializers for modules ops tables
Mon, Jul 22, 12:56 AM
markj added a comment to D45982: snd_hdsp*: Free up channel resources in case of CHANNEL_INIT() failure.

While testing with snd_hdspe I ran into the following warning, but I can't really make sense of it:

Jul 21 17:36:14 current kernel: uma_zalloc_debug: zone "malloc-16384" with the following non-sleepable locks
held:
Mon, Jul 22, 12:54 AM
markj accepted D46057: vm: Retire kmem_arena.

Out-of-tree code can make the same change, no need for a __FreeBSD_version bump I think. stable/11 is the last branch where kmem_arena is a distinct entity.

Mon, Jul 22, 12:49 AM

Sun, Jul 21

markj added a comment to D46020: nd6: Fix the routing table subscription.

Ty for working on that! IIRC the idea of rib_decompose_notification was to provide the same handling for both multipath and non-multipath routes for the callers that care only about specific paths. I'd rather add the relevant callback to the rib_decompose_notification() and not touch nd6_subscription_cb code.

Sun, Jul 21, 5:23 PM
markj added a comment to D45985: sound: Simplify chn_init().

This is hard to review. I can't see any problems, but there are lots of things mixed in so it's hard to be confident. If you are happy with the change, I think you should just go ahead.

Sun, Jul 21, 4:50 PM
markj accepted D45970: vm: Introduce {VM_ALLOC, PG}_NOFREE flags.
Sun, Jul 21, 4:49 PM
markj added inline comments to D45863: vm: Introduce reservation-aware NOFREE page allocation routine.
Sun, Jul 21, 4:47 PM
markj accepted D45998: pmap_growkernel: Use VM_ALLOC_NOFREE when allocating pagetable pages.
Sun, Jul 21, 4:37 PM
markj accepted D45997: vm: Add a KVA arena for M_NEVERFREED allocations.
Sun, Jul 21, 4:36 PM
markj added inline comments to D45901: sound tests: Add sndstat nvlist ATF test.
Sun, Jul 21, 4:34 PM
markj added a comment to D45974: mixer(8): Add tests.

however I am not really sure what is the suggested way of loading and unloading a kernel module in ATF script.

Sun, Jul 21, 4:32 PM
markj added a comment to D45969: sound examples: Add sndstat nvlist example.

What does the example program actually do? It would be useful to have an explanation somewhere in the file.

Sun, Jul 21, 4:27 PM
markj accepted D45982: snd_hdsp*: Free up channel resources in case of CHANNEL_INIT() failure.
Sun, Jul 21, 4:23 PM
markj accepted D45968: sound examples: Organize files in directories.
Sun, Jul 21, 4:17 PM
markj accepted D45986: sound: Remove unused defines from pcm/sound.h.
Sun, Jul 21, 4:15 PM
markj accepted D45979: sound: Fix memory leak in chn_init().
Sun, Jul 21, 4:13 PM
markj accepted D45984: sound: Remove unused FEEDER_DEBUG.
Sun, Jul 21, 4:13 PM

Sat, Jul 20

markj added inline comments to D46039: vnet tests: verify that we can load if_epair and if_bridge.
Sat, Jul 20, 2:20 PM
markj accepted D46040: netpfil tests: run in parallel.
Sat, Jul 20, 2:16 PM

Fri, Jul 19

markj accepted D46041: kyua: fix gcc13 builds.

This is absolutely the wrong fix, but my C++ isn't good enough to plumb why the noreturn annotations are mismatched.

Fri, Jul 19, 4:09 PM
markj added a reviewer for D46041: kyua: fix gcc13 builds: igor.ostapenko_pm.me.
Fri, Jul 19, 4:07 PM

Thu, Jul 18

markj accepted D46030: axgbe: drop unused function.
Thu, Jul 18, 10:09 PM
markj added a comment to D46022: xgbe: use standard rounddown_pow_of_two.

Assuming it came directly from the commit log message, the title should start with "axgbe:".

Thu, Jul 18, 6:28 PM
markj accepted D46022: xgbe: use standard rounddown_pow_of_two.
Thu, Jul 18, 6:26 PM
markj requested review of D46020: nd6: Fix the routing table subscription.
Thu, Jul 18, 3:22 PM
markj committed rGf029f6277996: zdb: Fix printf formatting of a uint64_t (authored by markj).
zdb: Fix printf formatting of a uint64_t
Thu, Jul 18, 2:55 PM
markj committed rG2aeb3e204af3: zdb: Chase a missing library dependency (authored by markj).
zdb: Chase a missing library dependency
Thu, Jul 18, 2:11 PM
markj closed D45865: kyua: Add FreeBSD Jail execution environment support.
Thu, Jul 18, 1:20 PM
markj committed rG257e70f1d5ee: kyua: Add FreeBSD Jail execution environment support (authored by igor.ostapenko_pm.me).
kyua: Add FreeBSD Jail execution environment support
Thu, Jul 18, 1:20 PM
markj added a comment to D45865: kyua: Add FreeBSD Jail execution environment support.

This modifies config file support slightly. Please bump the schema version and add appropriate tests for the new config schema vs the old config schema.

Thu, Jul 18, 1:19 PM

Wed, Jul 17

markj accepted D45999: pipe: keep uio_iovcnt consistent.
Wed, Jul 17, 7:00 PM
markj added inline comments to D45993: Add qemufwcfg driver and FUSE filesystem..
Wed, Jul 17, 2:02 PM
markj added inline comments to D45993: Add qemufwcfg driver and FUSE filesystem..
Wed, Jul 17, 1:29 PM

Tue, Jul 16

markj added inline comments to D45967: sound: Implement dummy driver.
Tue, Jul 16, 7:15 PM
markj added inline comments to D45967: sound: Implement dummy driver.
Tue, Jul 16, 6:42 PM
markj added a comment to D45865: kyua: Add FreeBSD Jail execution environment support.

@igor.ostapenko_pm.me could you please send me a git-formatted patch that I can apply? I ran this through a build tinderbox and the regression test suite, and it's ready to be committed.

Tue, Jul 16, 6:11 PM

Mon, Jul 15

markj committed rGb3877767883e: ndp: Fix libxo formatting for the prefix expiry string (authored by markj).
ndp: Fix libxo formatting for the prefix expiry string
Mon, Jul 15, 8:23 PM
markj accepted D45978: kern: zero out stack buffer after copying out random bits.
Mon, Jul 15, 4:16 PM
markj accepted D45976: Collection of fixes for _FORTIFY_SOURCE.
Mon, Jul 15, 3:49 PM
markj committed rG6af3d5996244: cxgbe: Flush transmitted packets more regularly in netmap mode (authored by markj).
cxgbe: Flush transmitted packets more regularly in netmap mode
Mon, Jul 15, 3:29 PM
markj added inline comments to D45976: Collection of fixes for _FORTIFY_SOURCE.
Mon, Jul 15, 1:44 PM
markj committed rG355a797dfaee: man9: Add an MLINK for taskqueue_enqueue_timeout_sbt.9 (authored by markj).
man9: Add an MLINK for taskqueue_enqueue_timeout_sbt.9
Mon, Jul 15, 1:40 PM
markj committed rG7e32f871b7dd: taskqueue: Move the timeout_task definition to _task.h (authored by markj).
taskqueue: Move the timeout_task definition to _task.h
Mon, Jul 15, 1:40 PM
markj added inline comments to D45950: vtnet: Fix an LOR in the input path.
Mon, Jul 15, 1:38 PM
markj added a comment to D45950: vtnet: Fix an LOR in the input path.

Is this safe? I think so, but I confess that I don't know the low level details in this driver very well.

Mon, Jul 15, 1:36 PM

Sun, Jul 14

markj committed rGe536b197c0cf: netlink: Wrap long lines (authored by markj).
netlink: Wrap long lines
Sun, Jul 14, 6:31 PM
markj committed rGec1b18c7353a: route: Wrap long lines (authored by markj).
route: Wrap long lines
Sun, Jul 14, 6:31 PM
markj committed rG1c64b3aba3d0: hptiop: Use device_set_descf() (authored by markj).
hptiop: Use device_set_descf()
Sun, Jul 14, 6:31 PM
markj committed rGd254651de392: axgbe: Remove a nonsensical use of kernel_sysctlbyname() (authored by markj).
axgbe: Remove a nonsensical use of kernel_sysctlbyname()
Sun, Jul 14, 6:31 PM
markj committed rGdc8357de606a: gnop tests: Serialize (authored by markj).
gnop tests: Serialize
Sun, Jul 14, 6:31 PM
markj committed rG498b3b494b8b: lockf tests: Fix a race (authored by markj).
lockf tests: Fix a race
Sun, Jul 14, 6:31 PM
markj committed rGab27e232b14c: socket tests: Serialize sonewconn_overflow (authored by markj).
socket tests: Serialize sonewconn_overflow
Sun, Jul 14, 6:30 PM
markj committed rG5b98bd30686a: sched tests: Avoid underflow when maxcpuid == 0 (authored by markj).
sched tests: Avoid underflow when maxcpuid == 0
Sun, Jul 14, 6:30 PM
markj committed rG7cd91315911d: vmm: Conditionalize addition of opt_*.h headers (authored by markj).
vmm: Conditionalize addition of opt_*.h headers
Sun, Jul 14, 6:30 PM
markj closed D45964: vmm: Conditionalize addition of opt_*.h headers.
Sun, Jul 14, 6:30 PM
markj committed rG4ea42d9d468b: libc/tests: Further refine the condition for installing h_raw (authored by markj).
libc/tests: Further refine the condition for installing h_raw
Sun, Jul 14, 4:45 PM
markj committed rGa3e706fd422a: libc/tests: Fix installation without MK_TOOLCHAIN (authored by markj).
libc/tests: Fix installation without MK_TOOLCHAIN
Sun, Jul 14, 4:45 PM
markj committed rG7126da66e484: lagg: Fix a teardown race (authored by markj).
lagg: Fix a teardown race
Sun, Jul 14, 4:44 PM
markj committed rG9ab7f84be600: dtrace: Add a partial implementation of dtrace_getarg() on arm64 (authored by markj).
dtrace: Add a partial implementation of dtrace_getarg() on arm64
Sun, Jul 14, 4:44 PM
markj accepted D45971: fibs: Suppress the WARNING message for the setups with multiple fibs.
Sun, Jul 14, 4:11 PM
markj accepted D45910: DMAR pagetable free: handle ref_count special references.
Sun, Jul 14, 4:05 PM

Sat, Jul 13

markj added inline comments to D45910: DMAR pagetable free: handle ref_count special references.
Sat, Jul 13, 5:08 PM
markj accepted D45966: amd64 pmap_allocpte_nosleep(): stop testing tautological condition.
Sat, Jul 13, 4:53 PM

Fri, Jul 12

markj requested review of D45964: vmm: Conditionalize addition of opt_*.h headers.
Fri, Jul 12, 6:03 PM
markj added inline comments to D45910: DMAR pagetable free: handle ref_count special references.
Fri, Jul 12, 2:45 PM
markj added inline comments to D45863: vm: Introduce reservation-aware NOFREE page allocation routine.
Fri, Jul 12, 2:34 PM

Thu, Jul 11

markj accepted D45940: include: de-macro __ssp_overlap(), improve semantics and checking.
Thu, Jul 11, 8:39 PM
markj committed rGd68d12481778: arm: Add evdev to the TEGRA124 config (authored by markj).
arm: Add evdev to the TEGRA124 config
Thu, Jul 11, 7:33 PM
markj committed rGa161269b2451: buf_ring: Make buf_ring.h amenable to userspace compilation (authored by markj).
buf_ring: Make buf_ring.h amenable to userspace compilation
Thu, Jul 11, 7:33 PM
markj closed D45869: buf_ring: Make buf_ring.h amenable to userspace compilation.
Thu, Jul 11, 7:32 PM
markj added inline comments to D45910: DMAR pagetable free: handle ref_count special references.
Thu, Jul 11, 7:10 PM
markj accepted D45682: include: ssp: fortify <wchar.h>.
Thu, Jul 11, 7:06 PM
markj added inline comments to D45940: include: de-macro __ssp_overlap(), improve semantics and checking.
Thu, Jul 11, 7:05 PM