markj (Mark Johnston)
User

Projects

User Details

User Since
Mar 12 2014, 1:00 AM (184 w, 1 d)

Recent Activity

Today

markj committed rS323880: Simplify i915_gem_wire_page() and avoid unneeded page-busying..
Simplify i915_gem_wire_page() and avoid unneeded page-busying.
Thu, Sep 21, 10:16 PM
markj committed rS323863: MFC r323439:.
MFC r323439:
Thu, Sep 21, 12:37 PM
markj updated subscribers of D11943: Modify vm_page_wire() to not dequeue the specified page.
Thu, Sep 21, 12:31 PM
markj updated the diff for D11943: Modify vm_page_wire() to not dequeue the specified page.
  • Make vm_page_unwire(PQ_NONE) dequeue the page.
  • Deindent the vm_page_wire() herald comment to match that of vm_page_unwire().
Thu, Sep 21, 10:43 AM

Sun, Sep 17

markj committed rS323677: MFC r322405, r322406:.
MFC r322405, r322406:
Sun, Sep 17, 3:45 PM
markj committed rS323676: Implement mmu_page_init for AIM platforms..
Implement mmu_page_init for AIM platforms.
Sun, Sep 17, 3:40 PM

Fri, Sep 15

markj committed rS323613: Include _bitset.h to get BITSET_DEFINE, used to define struct slabbits..
Include _bitset.h to get BITSET_DEFINE, used to define struct slabbits.
Fri, Sep 15, 2:59 PM
markj added inline comments to D9463: gmirror: treat ENXIO as disk disconnect, not media error.
Fri, Sep 15, 1:52 PM
markj committed rS323606: MFC r323498:.
MFC r323498:
Fri, Sep 15, 12:35 AM

Thu, Sep 14

markj committed rS323567: MFC r323280:.
MFC r323280:
Thu, Sep 14, 12:33 AM

Wed, Sep 13

markj committed rS323564: Widen uk_pgoff, the slab header offset field..
Widen uk_pgoff, the slab header offset field.
Wed, Sep 13, 9:54 PM
markj committed rS323544: Fix a logic error in the item size calculation for internal UMA zones..
Fix a logic error in the item size calculation for internal UMA zones.
Wed, Sep 13, 3:45 PM
markj closed D12342: Fix keg_large_init() for internal zones.
Wed, Sep 13, 3:45 PM
markj accepted D9463: gmirror: treat ENXIO as disk disconnect, not media error.
Wed, Sep 13, 2:54 PM
markj accepted D11968: Simplify blist initialization.
Wed, Sep 13, 2:26 PM

Tue, Sep 12

markj committed rS323498: Add a O_CLOEXEC use missed in r323166..
Add a O_CLOEXEC use missed in r323166.
Tue, Sep 12, 2:38 PM
markj added reviewers for D12342: Fix keg_large_init() for internal zones: alc, kib, jeff, avg.
Tue, Sep 12, 2:34 PM
markj abandoned D12341: Fix keg_large_init() for internal zones.
Tue, Sep 12, 2:32 PM
markj created D12342: Fix keg_large_init() for internal zones.
Tue, Sep 12, 2:32 PM
markj created D12341: Fix keg_large_init() for internal zones.
Tue, Sep 12, 2:28 PM
markj committed rS323495: MFC r323166:.
MFC r323166:
Tue, Sep 12, 1:48 PM
markj accepted D12334: Fix DTrace test tst_inet_ntop_d: remove definitions which are already in libdtrace.

LGTM, thanks Li-Wen.

Tue, Sep 12, 1:25 PM

Mon, Sep 11

markj accepted D12320: x86 MCA: Extract CMCI support predicate into function.
Mon, Sep 11, 6:07 PM
markj accepted D12321: MCA: Expand AMD Thresholding support to cover all banks.

Looks ok, but this code is pretty foreign to me. Could you point me to the doc(s) you consult for this stuff?

Mon, Sep 11, 6:07 PM
markj added inline comments to D12320: x86 MCA: Extract CMCI support predicate into function.
Mon, Sep 11, 5:50 PM
markj committed rS323439: Provide an error message if KTR symbols in a vmcore cannot be resolved..
Provide an error message if KTR symbols in a vmcore cannot be resolved.
Mon, Sep 11, 3:19 PM

Sun, Sep 10

markj added inline comments to D11943: Modify vm_page_wire() to not dequeue the specified page.
Sun, Sep 10, 8:20 PM
markj added inline comments to D11943: Modify vm_page_wire() to not dequeue the specified page.
Sun, Sep 10, 8:12 PM
markj updated the diff for D11943: Modify vm_page_wire() to not dequeue the specified page.
  • Address review comments; restore wire_count check in vm_pageout_cluster()
Sun, Sep 10, 8:06 PM
markj accepted D12281: Move vmmeter atomic counters into dedicated cache lines.

I think it'd be logical to move v_free_count as well, even if it doesn't make a difference now. The fields around it are read-mostly and generally are accessed only during memory shortages, but that might not be true in the future.

Sun, Sep 10, 6:43 PM
markj added a comment to D12281: Move vmmeter atomic counters into dedicated cache lines.
In D12281#255012, @mjg wrote:

The original fields are no longer named and compilation is ought to fail. As for code which wont be recompiled, your approach suffers the same problem by definition - since the layout of the struct has changed, old offsets don't fit. Short of proper ABI compatibility detection on module load there is nothing which can be done here.

Sun, Sep 10, 1:12 PM

Sat, Sep 9

markj added a comment to D12281: Move vmmeter atomic counters into dedicated cache lines.

Why can't you annotate the fields with __aligned(CACHE_LINE_SIZE), like:

Sat, Sep 9, 3:04 PM

Fri, Sep 8

markj added a comment to D11723: Add support for compressed kernel dumps..

(I'm holding off on this for a bit longer as I re-port netdump to HEAD. netdump is a bit different from a regular dump device since it doesn't have a fixed size, and I'm trying to avoid painting myself into a corner by assuming too much about how the dump device works.)

Fri, Sep 8, 8:15 PM

Thu, Sep 7

markj committed rS323290: Speed up vm_page_array initialization..
Speed up vm_page_array initialization.
Thu, Sep 7, 9:43 PM
markj closed D12248: Speed up vm_page_array initialization..
Thu, Sep 7, 9:43 PM
markj committed rS323280: Fix indentation..
Fix indentation.
Thu, Sep 7, 7:15 PM
markj updated the diff for D12248: Speed up vm_page_array initialization..
  • Adress review feedback.
Thu, Sep 7, 4:50 PM
markj added a comment to D12241: Add a set of D defines based on the contents of socket.h.

Also missing a makefile update.

Thu, Sep 7, 2:23 AM
markj added a comment to D12241: Add a set of D defines based on the contents of socket.h.

This should go in cddl/lib/libdtrace so that it gets included automatically like the rest of the libraries. Otherwise it seems ok to me.

Thu, Sep 7, 2:23 AM

Wed, Sep 6

markj added reviewers for D12248: Speed up vm_page_array initialization.: alc, kib.
Wed, Sep 6, 6:33 PM
markj created D12248: Speed up vm_page_array initialization..
Wed, Sep 6, 6:29 PM
markj committed rS323227: Avoid keeping a dangling pointer when the mappings array is resized..
Avoid keeping a dangling pointer when the mappings array is resized.
Wed, Sep 6, 4:24 PM
markj accepted D12239: Makefile.inc1: bump elf tool chain version check after PR 215350 fix.

LGTM

Wed, Sep 6, 1:26 AM

Tue, Sep 5

markj committed rS323191: Release rlibby from mentorship..
Release rlibby from mentorship.
Tue, Sep 5, 6:13 PM
markj committed rS323182: MFC r319933:.
MFC r319933:
Tue, Sep 5, 1:55 PM
markj committed rS323181: MFC r319934:.
MFC r319934:
Tue, Sep 5, 1:54 PM
markj committed rS323180: MFC r321963:.
MFC r321963:
Tue, Sep 5, 1:52 PM
markj committed rS323179: MFC r322987:.
MFC r322987:
Tue, Sep 5, 1:40 PM
markj added a comment to D12212: bhyve: actually call bhyve_caph_cache_catpages.

Approved

Tue, Sep 5, 1:19 PM
markj accepted D12227: Fixup compilation and enable dtrace support for mips64.
Tue, Sep 5, 1:39 AM
markj committed rS323166: Use O_CLOEXEC when opening persistent handles in libdtrace..
Use O_CLOEXEC when opening persistent handles in libdtrace.
Tue, Sep 5, 12:11 AM

Mon, Sep 4

markj added a comment to D12219: libefivar: -fno-strict-aliasing.

Approved

Mon, Sep 4, 3:26 PM
markj added a comment to D12222: gnu binutils: FSGSBASE assembly/disassembly.

Approved

Mon, Sep 4, 3:20 PM

Wed, Aug 30

markj committed rS323012: MFC r322773-r322775:.
MFC r322773-r322775:
Wed, Aug 30, 2:08 AM

Tue, Aug 29

markj added inline comments to D11943: Modify vm_page_wire() to not dequeue the specified page.
Tue, Aug 29, 2:21 PM
markj added inline comments to D11943: Modify vm_page_wire() to not dequeue the specified page.
Tue, Aug 29, 3:49 AM

Mon, Aug 28

markj committed rS322987: Synchronize page laundering with pmap_extract_and_hold()..
Synchronize page laundering with pmap_extract_and_hold().
Mon, Aug 28, 10:11 PM
markj closed D12084: Synchronize page laundering with pmap_extract_and_hold() by committing rS322987: Synchronize page laundering with pmap_extract_and_hold()..
Mon, Aug 28, 10:11 PM
markj accepted D12134: Update vm object lock assertions in the swap pager.
Mon, Aug 28, 2:16 PM

Sat, Aug 26

markj accepted D12134: Update vm object lock assertions in the swap pager.
Sat, Aug 26, 11:02 PM
markj added a comment to D12133: amd64: drop q suffix from rd[fg]sbase for gas compatibility.

Approved

Sat, Aug 26, 11:02 PM
markj added a comment to D12107: crunchgen: quiet -Wmissing-prototypes.

Approved

Sat, Aug 26, 3:09 PM
markj accepted D12126: Allow vdrop() of a vnode not yet on the per-mount list after r306512..
Sat, Aug 26, 2:58 PM

Wed, Aug 23

markj committed rS322816: Set the bus number field when attaching a PCI device..
Set the bus number field when attaching a PCI device.
Wed, Aug 23, 4:50 PM
markj added inline comments to D10021: KMS DRM port.
Wed, Aug 23, 4:41 PM
markj added inline comments to D10021: KMS DRM port.
Wed, Aug 23, 3:58 PM

Aug 22 2017

markj committed rS322795: Add some miscellaneous definitions to support the DRM drivers..
Add some miscellaneous definitions to support the DRM drivers.
Aug 22 2017, 5:13 PM

Aug 21 2017

markj added inline comments to D12019: subr_smp: Clean up topology analysis, add additional layers.
Aug 21 2017, 11:52 PM
markj accepted D12019: subr_smp: Clean up topology analysis, add additional layers.
Aug 21 2017, 11:37 PM
markj committed rS322775: Use an updated copy of the CDDL header boilerplate from illumos..
Use an updated copy of the CDDL header boilerplate from illumos.
Aug 21 2017, 10:27 PM
markj committed rS322774: Add a regression test for r322773..
Add a regression test for r322773.
Aug 21 2017, 9:59 PM
markj committed rS322773: Fix an off-by-two in the llquantize() action parameter validation..
Fix an off-by-two in the llquantize() action parameter validation.
Aug 21 2017, 9:56 PM

Aug 20 2017

markj committed rS322714: Define prefetch() only if it hasn't already been defined..
Define prefetch() only if it hasn't already been defined.
Aug 20 2017, 1:42 AM
markj committed rS322713: Add a couple of trivial headers to the LinuxKPI..
Add a couple of trivial headers to the LinuxKPI.
Aug 20 2017, 1:40 AM

Aug 19 2017

markj added inline comments to D11943: Modify vm_page_wire() to not dequeue the specified page.
Aug 19 2017, 9:37 PM
markj added reviewers for D12084: Synchronize page laundering with pmap_extract_and_hold(): alc, kib.
Aug 19 2017, 9:35 PM
markj created D12084: Synchronize page laundering with pmap_extract_and_hold().
Aug 19 2017, 9:33 PM
markj added inline comments to D11943: Modify vm_page_wire() to not dequeue the specified page.
Aug 19 2017, 6:00 AM

Aug 18 2017

markj accepted D12019: subr_smp: Clean up topology analysis, add additional layers.

Looks ok to me, but I'm not very familiar with this code. I haven't hit any problems with it on a dual-package Xeon system.

Aug 18 2017, 9:42 PM
markj committed rS322673: MFC r322391:.
MFC r322391:
Aug 18 2017, 8:21 PM
markj added inline comments to D12019: subr_smp: Clean up topology analysis, add additional layers.
Aug 18 2017, 6:24 PM
markj committed rS322646: Remove some unneeded subroutines for padding writes to dump devices..
Remove some unneeded subroutines for padding writes to dump devices.
Aug 18 2017, 4:07 AM
markj closed D11647: Remove some unneeded subroutines for padding writes to dump devices. by committing rS322646: Remove some unneeded subroutines for padding writes to dump devices..
Aug 18 2017, 4:07 AM
markj committed rS322645: Rename mkdumpheader() and group EKCD functions in kern_shutdown.c..
Rename mkdumpheader() and group EKCD functions in kern_shutdown.c.
Aug 18 2017, 4:04 AM
markj closed D11603: Shift some of the EKCD funcs around to keep them grouped together. by committing rS322645: Rename mkdumpheader() and group EKCD functions in kern_shutdown.c..
Aug 18 2017, 4:04 AM
markj committed rS322644: Factor out duplicated kernel dump code into dump_{start,finish}()..
Factor out duplicated kernel dump code into dump_{start,finish}().
Aug 18 2017, 3:52 AM
markj closed D11584: Factor out common kerneldump code into dump_start()/dump_finish(). by committing rS322644: Factor out duplicated kernel dump code into dump_{start,finish}()..
Aug 18 2017, 3:52 AM

Aug 17 2017

markj committed rS322623: MFC r322383:.
MFC r322383:
Aug 17 2017, 5:12 PM

Aug 16 2017

markj added a comment to D12021: aesni: quiet -Wcast-qual.

Approved

Aug 16 2017, 7:01 PM
markj committed rS322567: Add device resource management fields to struct device..
Add device resource management fields to struct device.
Aug 16 2017, 6:34 AM

Aug 15 2017

markj added inline comments to D11943: Modify vm_page_wire() to not dequeue the specified page.
Aug 15 2017, 9:21 PM
markj committed rS322547: Add vm_page_alloc_after()..
Add vm_page_alloc_after().
Aug 15 2017, 4:40 PM
markj closed D11984: Add vm_page_alloc_after() by committing rS322547: Add vm_page_alloc_after()..
Aug 15 2017, 4:40 PM
markj updated the diff for D11984: Add vm_page_alloc_after().
  • Eliminate bogus initialization.
Aug 15 2017, 3:39 AM
markj added inline comments to D11943: Modify vm_page_wire() to not dequeue the specified page.
Aug 15 2017, 3:04 AM
markj updated the diff for D11943: Modify vm_page_wire() to not dequeue the specified page.
  • Reference pages in PQ_ACTIVE upon unwiring them.
  • Remove wire_count checks from the page-clustering code.
  • Simplify the wire_count checking in vm_pageout_launder().
  • Hold off on adding a large comment to vm_page.h for now.
Aug 15 2017, 3:00 AM
markj added inline comments to D11984: Add vm_page_alloc_after().
Aug 15 2017, 2:57 AM
markj updated the diff for D11984: Add vm_page_alloc_after().
  • Reorder arguments to vm_page_alloc_after()
  • Use vm_radix_lookup_le() to initialize mpred
Aug 15 2017, 2:57 AM

Aug 11 2017

markj committed rS322417: MFH at r322416..
MFH at r322416.
Aug 11 2017, 10:41 PM
markj added inline comments to D11984: Add vm_page_alloc_after().
Aug 11 2017, 10:12 PM