Page MenuHomeFreeBSD

markj (Mark Johnston)
User

Projects

User Details

User Since
Mar 12 2014, 1:00 AM (297 w, 2 d)

Recent Activity

Yesterday

markj updated the diff for D22392: Fix locking in vm_reserv_reclaim_contig()..

Change locking vm_reserv_reclaim_inactive() following a suggestion
from Jeff: instead of using the scan lock, take the domain lock
and reclaim from the first reservation where trylock succeeds.
Drop the domain lock as soon as the reservation as dequeued. This
way we avoid holding any domain-global reservation locks while the
reservation is being broken.

Thu, Nov 21, 9:17 PM
markj accepted D22470: Partial refactoring of uma_zalloc_arg()..
Thu, Nov 21, 8:54 PM
markj committed rS354927: MFC r354201, r354276, r354492-r354517, r354562:.
MFC r354201, r354276, r354492-r354517, r354562:
Thu, Nov 21, 12:34 AM
markj committed rS354926: Avoid relying on pollution from libcasper.h..
Avoid relying on pollution from libcasper.h.
Thu, Nov 21, 12:17 AM

Wed, Nov 20

markj accepted D22453: Set VTOSLAB when we set OFFPAGE so that we don't use the hash..
Wed, Nov 20, 1:41 AM

Tue, Nov 19

markj accepted D22440: bhyve: virtio-net: disable receive until features are negotiated.
Tue, Nov 19, 5:51 PM
markj updated the diff for D22396: Simplify vm_pageout_init_domain() and add a "big picture" comment..

Hopefully address all of the feedback.

Tue, Nov 19, 1:37 AM
markj added a comment to D22396: Simplify vm_pageout_init_domain() and add a "big picture" comment..

I can't comment on the accuracy of any of this, but I can channel my 9th grade English teacher, Mrs. Weaver. There's some more passive voice in there (is awakened? by who?), but you're probably more interested in technical feedback.

Tue, Nov 19, 1:37 AM
markj added inline comments to D22396: Simplify vm_pageout_init_domain() and add a "big picture" comment..
Tue, Nov 19, 12:30 AM

Mon, Nov 18

markj accepted D22440: bhyve: virtio-net: disable receive until features are negotiated.

Seems ok to me.

Mon, Nov 18, 9:58 PM
markj accepted D22440: bhyve: virtio-net: disable receive until features are negotiated.
Mon, Nov 18, 9:51 PM
markj added inline comments to D22393: Revise the page cache size policy..
Mon, Nov 18, 9:42 PM
markj committed rS354829: Add a "B" suffix to memory quantities in top(1) output..
Add a "B" suffix to memory quantities in top(1) output.
Mon, Nov 18, 8:55 PM
markj updated the diff for D22394: Update the checks in vm_page_zone_import()..

Handle Alan's notes.

Mon, Nov 18, 8:04 PM
markj committed rS354826: Set MALLOC_DEBUG_MAXZONES=1 in GENERIC-NODEBUG configurations..
Set MALLOC_DEBUG_MAXZONES=1 in GENERIC-NODEBUG configurations.
Mon, Nov 18, 8:03 PM
markj accepted D22431: Add x86 msr tweak KPI..
Mon, Nov 18, 7:56 PM
markj committed rS354824: Fix grammar in gpart.8..
Fix grammar in gpart.8.
Mon, Nov 18, 7:06 PM
markj added a comment to D22394: Update the checks in vm_page_zone_import()..
In D22394#490201, @jeff wrote:

We run all of our paging threads constantly now. I would prefer not to disable creating cache buckets from pageproc unless we're in low memory situation. Even then it may be preferable to simply flush the buckets at the end of paging in that case.

Mon, Nov 18, 7:02 PM
markj accepted D22348: When traversing vm_map entries, don't look up the same neighbor twice.
Mon, Nov 18, 6:53 PM
markj closed D21768: Remove the wire_count field from struct vm_page..

This was committed as r352688.

Mon, Nov 18, 6:39 PM
markj closed D21875: Inconsistencies in DOF sections headers and sections.
Mon, Nov 18, 6:34 PM
markj committed rS354822: Fix inconsistencies in anonymous DOF files..
Fix inconsistencies in anonymous DOF files.
Mon, Nov 18, 6:34 PM
markj committed rS354821: Group per-domain reservation data in the same structure..
Group per-domain reservation data in the same structure.
Mon, Nov 18, 6:26 PM
markj closed D22391: vm_reserv: Group per-domain data in the same structure..
Mon, Nov 18, 6:26 PM
markj added a comment to D22392: Fix locking in vm_reserv_reclaim_contig()..
In D22392#490198, @jeff wrote:

I don't see the lock leak? again or continue both expect the lock held.

Mon, Nov 18, 6:23 PM
markj committed rS354820: Widen the vm_page aflags field to 16 bits..
Widen the vm_page aflags field to 16 bits.
Mon, Nov 18, 6:22 PM
markj closed D22397: Widen aflags to 16 bits..
Mon, Nov 18, 6:22 PM
markj committed rS354819: MFC r353729:.
MFC r353729:
Mon, Nov 18, 5:19 PM
markj added inline comments to D22423: Only insert objects into a shadow list if they can later be collapsed..
Mon, Nov 18, 5:17 PM
markj accepted D22119: Add a constant OBJ_ANONYMOUS flag to optimize out some locking..
Mon, Nov 18, 5:08 PM
markj accepted D22431: Add x86 msr tweak KPI..
Mon, Nov 18, 4:25 PM
markj accepted D22186: Remove unnecessary object locking from the vnode pager..
Mon, Nov 18, 4:15 PM
markj accepted D22403: [PowerPC] ELFv2 libdtrace support (userland side).
Mon, Nov 18, 3:45 PM · DTrace, PowerPC
markj added inline comments to D22431: Add x86 msr tweak KPI..
Mon, Nov 18, 3:42 PM
markj closed D22142: Implement vm.pmap.kernel_maps for arm64..
Mon, Nov 18, 3:37 PM
markj committed rS354816: Implement vm.pmap.kernel_maps for arm64..
Implement vm.pmap.kernel_maps for arm64.
Mon, Nov 18, 3:37 PM
markj closed D22141: Let arm64 pmap_qenter() and pmap_kenter() unconditionally set NX..
Mon, Nov 18, 3:37 PM
markj committed rS354815: Let arm64 pmap_qenter() and pmap_kenter() unconditionally set NX..
Let arm64 pmap_qenter() and pmap_kenter() unconditionally set NX.
Mon, Nov 18, 3:37 PM
markj committed rS354814: MFC r353672:.
MFC r353672:
Mon, Nov 18, 3:28 PM
markj committed rS354813: MFC r354629:.
MFC r354629:
Mon, Nov 18, 3:28 PM

Sat, Nov 16

markj updated the diff for D22397: Widen aflags to 16 bits..

Address feedback.

Sat, Nov 16, 5:42 PM
markj added inline comments to D22397: Widen aflags to 16 bits..
Sat, Nov 16, 5:42 PM
markj added inline comments to D22395: Reclaim memory from UMA if the page daemon is struggling..
Sat, Nov 16, 5:42 PM
markj added inline comments to D22394: Update the checks in vm_page_zone_import()..
Sat, Nov 16, 5:42 PM
markj updated the diff for D22392: Fix locking in vm_reserv_reclaim_contig()..

Address feedback.

Sat, Nov 16, 5:41 PM
markj added inline comments to D22392: Fix locking in vm_reserv_reclaim_contig()..
Sat, Nov 16, 5:41 PM
markj added inline comments to D22391: vm_reserv: Group per-domain data in the same structure..
Sat, Nov 16, 5:40 PM

Fri, Nov 15

markj added reviewers for D22397: Widen aflags to 16 bits.: alc, kib, dougm, jeff.
Fri, Nov 15, 11:49 PM
markj added reviewers for D22396: Simplify vm_pageout_init_domain() and add a "big picture" comment.: alc, kib, dougm, jeff.
Fri, Nov 15, 11:49 PM
markj added reviewers for D22395: Reclaim memory from UMA if the page daemon is struggling.: alc, dougm, jeff, kib.
Fri, Nov 15, 11:49 PM
markj added reviewers for D22394: Update the checks in vm_page_zone_import().: alc, dougm, jeff, kib.
Fri, Nov 15, 11:49 PM
markj added reviewers for D22393: Revise the page cache size policy.: alc, kib, jeff, dougm, gallatin, glebius.
Fri, Nov 15, 11:49 PM
markj added reviewers for D22392: Fix locking in vm_reserv_reclaim_contig().: alc, kib, dougm, jeff.
Fri, Nov 15, 11:48 PM
markj added reviewers for D22391: vm_reserv: Group per-domain data in the same structure.: alc, kib, dougm, jeff.
Fri, Nov 15, 11:48 PM
markj created D22397: Widen aflags to 16 bits..
Fri, Nov 15, 11:47 PM
markj created D22396: Simplify vm_pageout_init_domain() and add a "big picture" comment..
Fri, Nov 15, 11:46 PM
markj created D22395: Reclaim memory from UMA if the page daemon is struggling..
Fri, Nov 15, 11:46 PM
markj created D22394: Update the checks in vm_page_zone_import()..
Fri, Nov 15, 11:46 PM
markj created D22393: Revise the page cache size policy..
Fri, Nov 15, 11:45 PM
markj created D22392: Fix locking in vm_reserv_reclaim_contig()..
Fri, Nov 15, 11:45 PM
markj created D22391: vm_reserv: Group per-domain data in the same structure..
Fri, Nov 15, 11:45 PM
markj accepted D22379: Add STKGAP disable fctl flag..
Fri, Nov 15, 9:53 PM
markj added inline comments to D22379: Add STKGAP disable fctl flag..
Fri, Nov 15, 9:37 PM
markj accepted D22379: Add STKGAP disable fctl flag..
Fri, Nov 15, 9:28 PM
markj added inline comments to D22379: Add STKGAP disable fctl flag..
Fri, Nov 15, 8:43 PM
markj accepted D22348: When traversing vm_map entries, don't look up the same neighbor twice.

It would be nice if the loop variable names were more consistent: in some places we use prev_entry/entry, in others it's temp_entry/current or entry/current, etc.. I think I prefer prev_entry/entry, FWIW. Anyway, that does not block this patch.

Fri, Nov 15, 8:37 PM
markj accepted D22388: Teach arm64's pmap_remove_all() to skip pmap_invalidate_page() unless ATTR_AF is set.
Fri, Nov 15, 7:23 PM

Wed, Nov 13

markj added inline comments to D21964: Make vm_map a threaded tree.
Wed, Nov 13, 3:36 PM
markj accepted D22347: hide map entry next and prev fields.

Thanks. If you plan to commit this patch on its own, I'd suggest adding a comment above defer_next, even though that definition would be deleted shortly after.

Wed, Nov 13, 3:24 PM

Tue, Nov 12

markj added a comment to D20722: uma: trash memory when ctor/dtor supplied too.

Ryan, are you planning to commit this at some point?

Sorry, got busy for a bit. Yes, let me make sure test and make sure it is still current, and then I'll try to get it in by this weekend.

Tue, Nov 12, 7:03 PM
markj added a comment to D20722: uma: trash memory when ctor/dtor supplied too.

Ryan, are you planning to commit this at some point?

Tue, Nov 12, 5:55 PM
markj accepted D22321: i386: stop guessing the address of the trap frame in ddb backtrace..
Tue, Nov 12, 3:50 PM
markj added a comment to D21964: Make vm_map a threaded tree.

I read through this a couple of times and it seems fine to me. You might consider breaking this into several patches, the first of which introduces vm_map_entry_{pred,succ}() as wrappers for direct accesses of entry->next and entry->pred and converts existing code to use them.

Tue, Nov 12, 3:38 PM
markj added inline comments to D21927: plic: fix context calculation.
Tue, Nov 12, 3:17 PM

Mon, Nov 11

markj accepted D22286: bhyve: rework mevent processing to fix a race condition.
Mon, Nov 11, 10:59 PM
markj closed D22261: Fix handling of PIPE_EOF in the direct write path..
Mon, Nov 11, 8:44 PM
markj committed rS354629: Fix handling of PIPE_EOF in the direct write path..
Fix handling of PIPE_EOF in the direct write path.
Mon, Nov 11, 8:44 PM
markj accepted D22286: bhyve: rework mevent processing to fix a race condition.
Mon, Nov 11, 8:09 PM
markj added inline comments to D22142: Implement vm.pmap.kernel_maps for arm64..
Mon, Nov 11, 2:46 PM
markj updated the diff for D22142: Implement vm.pmap.kernel_maps for arm64..

Count contiguous l3 ranges.

Mon, Nov 11, 2:43 PM
markj added a comment to D22261: Fix handling of PIPE_EOF in the direct write path..
In D22261#487620, @pho wrote:

I completed a full stress2 test with D22261.64008.diff.
The only problem I saw was this (unrelated) panic: https://people.freebsd.org/~pho/stress/log/mark107.txt

Mon, Nov 11, 2:33 PM
markj committed rS354608: MFC r353935, r354402:.
MFC r353935, r354402:
Mon, Nov 11, 2:07 PM
markj accepted D22298: Record part of the owner struct thread pointer into busy_lock..

I'd find the name VPB_CURTHREAD_EXCLUSIVE more intuitive.

Mon, Nov 11, 2:05 PM
markj accepted D22303: db_nextframe/i386: reduce the number of special frame types.
Mon, Nov 11, 2:00 PM
markj added a comment to D22304: gnop: add the option for adding a suffix to the name of the device.

Why don't we just have a "name" parameter that determines the entire gnop provider name?

Mon, Nov 11, 1:39 PM
markj accepted D22286: bhyve: rework mevent processing to fix a race condition.
Mon, Nov 11, 1:28 PM

Sun, Nov 10

markj accepted D22302: amd64: move gdt into pcpu.
Sun, Nov 10, 7:10 PM
markj added a comment to D21875: Inconsistencies in DOF sections headers and sections.

This makes sense to me, thanks. I'll commit it in a day or two if no one else jumps in.

Cool. It's only a minor thing but we are increasingly relying on correct knowledge of the internals of DIF and DOF to do our work on distribution.

Is there a "Sponsored by:" tag you'd like added to the commit message?

I'll just double check with Robert, I've just got a letter about contract extension. I think this is funded differently. Robert says DARPA/AFRL ATM, so some/all of the following blurb?
This software was developed by BAE Systems, the University of Cambridge Computer Laboratory, and Memorial University under DARPA/AFRL contract FA8650-15-C-7558 ("CADETS"), as part of the DARPA Transparent Computing (TC) research program.
Let me know if I should be putting this somewhere I couldn't see a way I can add this.

Sun, Nov 10, 3:45 PM
markj added inline comments to D22302: amd64: move gdt into pcpu.
Sun, Nov 10, 3:37 PM
markj accepted D22305: db_nextframe/amd64: remove TRAP_INTERRUPT frame type.
Sun, Nov 10, 3:19 PM
markj added a comment to D22141: Let arm64 pmap_qenter() and pmap_kenter() unconditionally set NX..

Can you commit this or shall I commit D22241 first? They conflict as they both change pmap_qenter() and pmap_kenter().

Sun, Nov 10, 12:18 AM

Fri, Nov 8

markj added a comment to D21573: Hwpmc log file is not cleaned after profile session is completed.

I spent some more time looking at this today. This change can't be committed:

  • pmclog_close() logs an EOF message causes the logging thread to flush all pending buffers and exit. pmclog_close() returns without waiting for the flush to complete: this is necessary because the logging thread might be writing to a pipe, and we need the calling thread to go back and read from it. But, clearing PMC_PO_OWNS_LOGFILE without waiting may cause the logging thread to exit before it logs EOF, and this breaks some existing applications.
  • pmclog_close() doesn't fdrop() the log file reference, so by clearing PMC_PO_OWNS_LOGFILE the change allows unprivileged users to trigger a refcount leak.
Fri, Nov 8, 10:34 PM
markj committed rS354562: Add new iwm(4) files to sys/conf/files..
Add new iwm(4) files to sys/conf/files.
Fri, Nov 8, 8:48 PM
markj committed rS354521: Document iwm(4) support for 9000-series devices..
Document iwm(4) support for 9000-series devices.
Fri, Nov 8, 12:01 AM

Thu, Nov 7

markj committed rS354517: Update iwm and iwmfw man pages with info about 9000-series chips..
Update iwm and iwmfw man pages with info about 9000-series chips.
Thu, Nov 7, 11:39 PM
markj committed rS354516: iwm: Sync device initialization and reset code with iwlwifi..
iwm: Sync device initialization and reset code with iwlwifi.
Thu, Nov 7, 11:39 PM
markj committed rS354515: iwm: Implement support for scans with "adaptive" dwell time..
iwm: Implement support for scans with "adaptive" dwell time.
Thu, Nov 7, 11:39 PM
markj committed rS354514: iwm: Use the default station for all transmits..
iwm: Use the default station for all transmits.
Thu, Nov 7, 11:38 PM
markj committed rS354513: iwm: Set flag for pad bytes in offload_assist..
iwm: Set flag for pad bytes in offload_assist.
Thu, Nov 7, 11:38 PM
markj committed rS354512: iwm: Use antenna B for TX on 9000-series chips..
iwm: Use antenna B for TX on 9000-series chips.
Thu, Nov 7, 11:38 PM