Page MenuHomeFreeBSD

markj (Mark Johnston)
User

Projects (6)

User Details

User Since
Mar 12 2014, 1:00 AM (358 w, 5 d)

Recent Activity

Today

markj updated the diff for D28334: Add git-arc.
  • Address feedback, verb -> command in the usage message.
Mon, Jan 25, 7:19 PM
markj added a comment to D28334: Add git-arc.

I might also be convinced to write a git-arc(8) man-page. ;)

Mon, Jan 25, 7:19 PM
markj requested review of D28334: Add git-arc.
Mon, Jan 25, 5:24 PM
markj committed R10:5071cbacfb34: safexcel: Simplify request allocation (authored by markj).
safexcel: Simplify request allocation
Mon, Jan 25, 2:23 PM
markj committed R10:804d63c0ee8f: safexcel: Handle command/result descriptor exhaustion gracefully (authored by markj).
safexcel: Handle command/result descriptor exhaustion gracefully
Mon, Jan 25, 2:23 PM
markj committed R10:24ee73604483: safexcel: Add counters for some resource exhaustion conditions (authored by markj).
safexcel: Add counters for some resource exhaustion conditions
Mon, Jan 25, 2:22 PM
markj committed R10:5ade41213f19: safexcel: Dispatch requests to the current CPU's ring (authored by markj).
safexcel: Dispatch requests to the current CPU's ring
Mon, Jan 25, 2:22 PM
markj added inline comments to D27413: firmware(9): extend firmware_get () by a "no warn" flag..
Mon, Jan 25, 2:05 PM

Yesterday

markj added inline comments to D28311: vm_map_protect.9: update after code changes.
Sun, Jan 24, 4:34 PM

Sat, Jan 23

markj added a reverting change for R10:aa37baf3d7cf: Define PNP info after defining driver modules: R10:519b64e27fdd: Revert "Define PNP info after defining driver modules".
Sat, Jan 23, 4:03 PM
markj committed R10:519b64e27fdd: Revert "Define PNP info after defining driver modules" (authored by markj).
Revert "Define PNP info after defining driver modules"
Sat, Jan 23, 4:03 PM
markj committed R10:80a5b8512a2c: kldxref(8): Sort MDT_MODULE info first in linker.hints output (authored by cem).
kldxref(8): Sort MDT_MODULE info first in linker.hints output
Sat, Jan 23, 4:03 PM
markj added a reverting change for D28260: Define PNP info after defining driver modules: R10:519b64e27fdd: Revert "Define PNP info after defining driver modules".
Sat, Jan 23, 4:02 PM

Fri, Jan 22

markj added a comment to D28260: Define PNP info after defining driver modules.

I think maybe we should revert the change, if it is truly unfounded and was only observed on 12. If this wasn't ever a problem on CURRENT, the commit message rationale is wrong and misleading. Reverting is the canonical way to correct that kind of thing.

Fri, Jan 22, 9:47 PM
markj added a comment to D28260: Define PNP info after defining driver modules.
In D28260#632585, @cem wrote:

Wait, kldxref should be ordering these correctly since rS348309. Why isn't it?

Probably because I hit this issue on stable/12 and didn't notice that kldxref was fixed.

Fri, Jan 22, 2:24 AM
markj added a comment to D28260: Define PNP info after defining driver modules.
In D28260#632585, @cem wrote:

Wait, kldxref should be ordering these correctly since rS348309. Why isn't it?

Fri, Jan 22, 1:49 AM

Thu, Jan 21

markj committed R10:1a05d9519de6: libcasper/cap_grp tests: Reset the group database handle (authored by markj).
libcasper/cap_grp tests: Reset the group database handle
Thu, Jan 21, 7:31 PM
markj committed R10:48a186863431: libc/nss: Ensure that setgroupent(3) actually works as advertised (authored by markj).
libc/nss: Ensure that setgroupent(3) actually works as advertised
Thu, Jan 21, 7:31 PM
markj committed R10:6e411d8b14ec: libc/nss tests: Add regression tests for commit 55444c823e1f (authored by markj).
libc/nss tests: Add regression tests for commit 55444c823e1f
Thu, Jan 21, 7:31 PM
markj committed R10:5619d49e07d3: libc/nss: Restore iterator state when doing passwd/group lookups (authored by markj).
libc/nss: Restore iterator state when doing passwd/group lookups
Thu, Jan 21, 7:31 PM
markj committed R10:7abc10098b3d: libc/nss tests: Fix getpw and getgr single-pass tests (authored by markj).
libc/nss tests: Fix getpw and getgr single-pass tests
Thu, Jan 21, 7:31 PM
markj committed R10:ed14c69d5679: libc/nss tests: Style (authored by markj).
libc/nss tests: Style
Thu, Jan 21, 7:31 PM
markj committed R10:aa37baf3d7cf: Define PNP info after defining driver modules (authored by markj).
Define PNP info after defining driver modules
Thu, Jan 21, 7:31 PM
markj closed D28260: Define PNP info after defining driver modules.
Thu, Jan 21, 7:31 PM
markj accepted D28233: Fix a few UBSan errors in bootstrap-tools.

LGTM with the modifications you proposed.

Thu, Jan 21, 3:01 PM
markj accepted D28026: arm64: Improve DDB backtrace support.
Thu, Jan 21, 2:54 PM
markj added a comment to D26538: Add SIOCGIFDATA.
In D26538#632166, @jmg wrote:

I know this was closed and committed, but I want to get some more discussion on this.

I happen to be reviewing this for my own code (to get at _hwassist), and noticed that the code does not check how much space the program allocated for the if_data structure. This means that as the interface stands, it cannot be expanded, ever in the future, as it'll break old programs when they use this.

Thu, Jan 21, 2:49 PM
markj committed R10:920d22cca1a2: iwm(4): Add support for Intel Killer(R) Wireless-AC 1550i (authored by markj).
iwm(4): Add support for Intel Killer(R) Wireless-AC 1550i
Thu, Jan 21, 2:41 PM

Wed, Jan 20

markj updated the test plan for D28260: Define PNP info after defining driver modules.
Wed, Jan 20, 7:48 PM
markj requested review of D28260: Define PNP info after defining driver modules.
Wed, Jan 20, 7:48 PM
markj added inline comments to D28233: Fix a few UBSan errors in bootstrap-tools.
Wed, Jan 20, 2:36 PM
markj committed R10:4dc1b17dbb9f: ktls: Improve handling of the bind_threads tunable a bit (authored by markj).
ktls: Improve handling of the bind_threads tunable a bit
Wed, Jan 20, 2:34 AM
markj committed R10:8adcc757b82c: opencrypto: Add comments describing the new crypto_session layout (authored by markj).
opencrypto: Add comments describing the new crypto_session layout
Wed, Jan 20, 2:34 AM
markj closed D28161: ktls: Improve handling of the bind_threads tunable a bit.
Wed, Jan 20, 2:33 AM
markj accepted D28219: Restrict supported alignment for malloc_domainset_aligned(9) to PAGE_SIZE..
Wed, Jan 20, 2:13 AM
markj closed D28225: Set VM_KMEM_SIZE_SCALE to 1 on riscv and arm64.
Wed, Jan 20, 1:38 AM
markj committed R10:3e3eb5f45f33: arm64, riscv: Set VM_KMEM_SIZE_SCALE to 1 (authored by markj).
arm64, riscv: Set VM_KMEM_SIZE_SCALE to 1
Wed, Jan 20, 1:38 AM
markj closed D28162: arm64: Stop setting VM_BCACHE_SIZE_MAX.
Wed, Jan 20, 1:37 AM
markj committed R10:089eafaff3ec: arm64: Stop setting VM_BCACHE_SIZE_MAX (authored by markj).
arm64: Stop setting VM_BCACHE_SIZE_MAX
Wed, Jan 20, 1:37 AM
markj closed D28159: opencrypto: Fix assignment of crypto completions to worker threads.
Wed, Jan 20, 1:37 AM
markj committed R10:98d788c867b9: opencrypto: Fix assignment of crypto completions to worker threads (authored by markj).
opencrypto: Fix assignment of crypto completions to worker threads
Wed, Jan 20, 1:37 AM
markj closed D28158: opencrypto: Embed the driver softc in the session structure.
Wed, Jan 20, 1:36 AM
markj committed R10:d1816248899a: opencrypto: Embed the driver softc in the session structure (authored by markj).
opencrypto: Embed the driver softc in the session structure
Wed, Jan 20, 1:36 AM
markj added a comment to D28194: opencrypto: Introduce crypto_dispatch_async().
In D28194#631525, @jhb wrote:

Perhaps update crypto_request.9 as well?

Wed, Jan 20, 1:18 AM

Tue, Jan 19

markj added inline comments to D28195: ktls: Avoid wakeups and locking for synchronous callbacks.
Tue, Jan 19, 7:52 PM
markj committed R10:a45d90561696: ppbus: Fix the direction of the PPISEPPA ioctl (authored by markj).
ppbus: Fix the direction of the PPISEPPA ioctl
Tue, Jan 19, 12:46 AM
markj updated the diff for D28225: Set VM_KMEM_SIZE_SCALE to 1 on riscv and arm64.

Remove VM_KMEM_SIZE_MIN as well.

Tue, Jan 19, 12:35 AM

Mon, Jan 18

markj committed R10:098c902b5202: aesni: Ensure that key schedules are aligned (authored by markj).
aesni: Ensure that key schedules are aligned
Mon, Jan 18, 10:09 PM
markj committed R10:5bdb8b273aaf: safexcel: Maintain per-session context records (authored by markj).
safexcel: Maintain per-session context records
Mon, Jan 18, 10:09 PM
markj committed R10:1a6ffed5d73a: safexcel: Simplify request allocation (authored by markj).
safexcel: Simplify request allocation
Mon, Jan 18, 10:09 PM
markj committed R10:b7e27af36b7d: safexcel: Handle command/result descriptor exhaustion gracefully (authored by markj).
safexcel: Handle command/result descriptor exhaustion gracefully
Mon, Jan 18, 10:09 PM
markj committed R10:0371c3faaa24: safexcel: Add counters for some resource exhaustion conditions (authored by markj).
safexcel: Add counters for some resource exhaustion conditions
Mon, Jan 18, 10:09 PM
markj committed R10:e934d455ba37: safexcel: Dispatch requests to the current CPU's ring (authored by markj).
safexcel: Dispatch requests to the current CPU's ring
Mon, Jan 18, 10:09 PM
markj closed D28157: aesni: Ensure that key schedules are aligned.
Mon, Jan 18, 10:08 PM
markj committed R10:4af932354260: linuxkpi: Fix the shrinker scan target (authored by markj).
linuxkpi: Fix the shrinker scan target
Mon, Jan 18, 10:08 PM
markj closed D28224: linuxkpi: Fix the shrinker scan target.
Mon, Jan 18, 10:08 PM
markj accepted D28219: Restrict supported alignment for malloc_domainset_aligned(9) to PAGE_SIZE..
Mon, Jan 18, 9:56 PM
markj added inline comments to D28219: Restrict supported alignment for malloc_domainset_aligned(9) to PAGE_SIZE..
Mon, Jan 18, 9:09 PM
markj committed R10:6d0a2f9d2ffc: msdosfs: Fix a leak of dirent padding bytes (authored by markj).
msdosfs: Fix a leak of dirent padding bytes
Mon, Jan 18, 7:16 PM
markj added reviewers for D28225: Set VM_KMEM_SIZE_SCALE to 1 on riscv and arm64: kib, alc, riscv, arm64.
Mon, Jan 18, 6:48 PM
markj requested review of D28225: Set VM_KMEM_SIZE_SCALE to 1 on riscv and arm64.
Mon, Jan 18, 6:47 PM
markj accepted D28219: Restrict supported alignment for malloc_domainset_aligned(9) to PAGE_SIZE..
Mon, Jan 18, 6:24 PM
markj added a reviewer for D28224: linuxkpi: Fix the shrinker scan target: manu.
Mon, Jan 18, 5:58 PM
markj requested review of D28224: linuxkpi: Fix the shrinker scan target.
Mon, Jan 18, 5:58 PM
markj committed R10:94a5e942b0b6: qat: Free counters during detach (authored by markj).
qat: Free counters during detach
Mon, Jan 18, 5:33 PM
markj committed R10:59f0f60327ad: qat: Count request allocation failures (authored by markj).
qat: Count request allocation failures
Mon, Jan 18, 5:33 PM
markj committed R10:36dfe8cb2581: qat: Fix DH895XCC firmware module autoloading (authored by markj).
qat: Fix DH895XCC firmware module autoloading
Mon, Jan 18, 5:33 PM
markj committed R10:7f1032dff07a: libdtrace: Format USDT symbols correctly based on symbol binding (authored by markj).
libdtrace: Format USDT symbols correctly based on symbol binding
Mon, Jan 18, 5:33 PM
markj committed R10:6181f2fcf6a4: mvneta: Acquire the softc lock before clearing the MIB (authored by markj).
mvneta: Acquire the softc lock before clearing the MIB
Mon, Jan 18, 5:33 PM
markj committed R10:3160b2d53b38: mvneta: Fix 64-bit MIB reads (authored by markj).
mvneta: Fix 64-bit MIB reads
Mon, Jan 18, 5:33 PM
markj added a comment to D28219: Restrict supported alignment for malloc_domainset_aligned(9) to PAGE_SIZE..

Sorry for not catching this.

Mon, Jan 18, 3:06 PM

Sat, Jan 16

markj updated the summary of D28195: ktls: Avoid wakeups and locking for synchronous callbacks.
Sat, Jan 16, 7:00 PM
markj added a reviewer for D28194: opencrypto: Introduce crypto_dispatch_async(): jhb.
Sat, Jan 16, 6:59 PM
markj requested review of D28195: ktls: Avoid wakeups and locking for synchronous callbacks.
Sat, Jan 16, 6:59 PM
markj requested review of D28194: opencrypto: Introduce crypto_dispatch_async().
Sat, Jan 16, 6:59 PM
markj added a comment to D28155: Remove EN-20:21.ipfw from the list of open issues.

Unfortunately, diff isn't finished yet. Following removal from $4 an appropriate entry to $3 should be added as well.

Sat, Jan 16, 3:32 PM
markj abandoned D28160: netipsec: Fix handling of unmapped mbufs.
In D28160#630053, @ae wrote:

I think the patch in D28187 is better. You need to release reference to SP when error occurs before ipsec4_process_packet().

Sat, Jan 16, 3:31 PM

Fri, Jan 15

markj accepted D28185: cat: restore errno.
Fri, Jan 15, 9:00 PM
markj added inline comments to D28185: cat: restore errno.
Fri, Jan 15, 8:47 PM
markj accepted D28183: arm64: Clear FPU flags in the pcb in cpu_copy_thread()..
Fri, Jan 15, 7:11 PM
markj accepted D28182: arm64: Trim duplicate code from cpu_fork_kthread_handler()..
Fri, Jan 15, 7:09 PM
markj accepted D28083: cat: capsicumize it.
Fri, Jan 15, 6:51 PM
markj accepted D28147: Add malloc_domainset_aligned(9) and use it in x86 busdma bounce..
Fri, Jan 15, 4:26 PM
markj accepted D27621: Extract the logic from pmap_kextract.
Fri, Jan 15, 4:25 PM
markj added inline comments to D27621: Extract the logic from pmap_kextract.
Fri, Jan 15, 3:17 PM

Thu, Jan 14

markj added inline comments to D28159: opencrypto: Fix assignment of crypto completions to worker threads.
Thu, Jan 14, 5:41 PM
markj committed R10:6483fc224b1a: qat: Free counters during detach (authored by markj).
qat: Free counters during detach
Thu, Jan 14, 4:47 PM
markj committed R10:a33b29a0447b: qat: Count request allocation failures (authored by markj).
qat: Count request allocation failures
Thu, Jan 14, 4:47 PM
markj committed R10:95ee7d9b879c: qat: Fix DH895XCC firmware module autoloading (authored by markj).
qat: Fix DH895XCC firmware module autoloading
Thu, Jan 14, 4:47 PM
markj committed R10:e3d06599bc06: libifconfig: Add a symbol map (authored by markj).
libifconfig: Add a symbol map
Thu, Jan 14, 4:46 PM
markj committed R10:90cc8706ccb2: iwm(4): Add support for Intel Killer(R) Wireless-AC 1550i (authored by markj).
iwm(4): Add support for Intel Killer(R) Wireless-AC 1550i
Thu, Jan 14, 4:46 PM
markj closed D28119: libifconfig: Add a symbol map.
Thu, Jan 14, 4:46 PM
markj added reviewers for D28162: arm64: Stop setting VM_BCACHE_SIZE_MAX: andrew, kib.
Thu, Jan 14, 4:37 PM
markj added reviewers for D28161: ktls: Improve handling of the bind_threads tunable a bit: jhb, gallatin.
Thu, Jan 14, 4:37 PM
markj added reviewers for D28160: netipsec: Fix handling of unmapped mbufs: jhb, gallatin.
Thu, Jan 14, 4:37 PM
markj requested review of D28162: arm64: Stop setting VM_BCACHE_SIZE_MAX.
Thu, Jan 14, 4:37 PM
markj requested review of D28161: ktls: Improve handling of the bind_threads tunable a bit.
Thu, Jan 14, 4:36 PM
markj requested review of D28160: netipsec: Fix handling of unmapped mbufs.
Thu, Jan 14, 4:36 PM
markj added reviewers for D28159: opencrypto: Fix assignment of crypto completions to worker threads: cem, jhb.
Thu, Jan 14, 4:36 PM
markj added a reviewer for D28158: opencrypto: Embed the driver softc in the session structure: cem.
Thu, Jan 14, 4:36 PM