User Details
- User Since
- Mar 12 2014, 1:00 AM (497 w, 1 d)
Mon, Sep 18
Note that the change as-is isn't complete: after a slab is allocated, a per-CPU bucket will be populated with some items from the cache, and kasan_mark_item_invalid() will overwrite the state bytes, setting them back to KASAN_UMA_FREED even though they are still conceptually still in the NEVERUSED state.
Sun, Sep 17
Sat, Sep 16
I've been able to trigger an sbwait() assertion failure in the receive path when running KTLS tests, but only when running tests in parallel in QEMU. I believe the problem is the following: KTLS introduces a state for received data wherein it is being decrypted but is not yet queued in the socket buffer. In this case (sb_tlsdcc != 0), we can end up calling sbwait() with CANTRECVMORE set because that sleep/wakeup mechanism is used to signal completion of decryption operations.
Fri, Sep 15
arm64 doesn't need any changes?
The overall idea seems ok to me for what it's worth, my comments are about cosmetic issues.
Thu, Sep 14
Wed, Sep 13
Tue, Sep 12
Fix the in-kernel build.
Sat, Sep 9
So far I mostly just looked at the cheat locks.
Looks good to me. Thanks for working on this.
Fri, Sep 8
The bhyve manual page needs to be updated as well.
Thu, Sep 7
Wed, Sep 6
Address review comments.
Perhaps its own man page is warranted in order to avoid polluting dtrace(1)?
Restore PCI b/s/f tuple parameters.
Restore PCI b/s/f tuple parameters.
The main diff looks ok to me, I just don't understand the alignment change.
Please make sure to bump __FreeBSD_version in sys/param.h in this commit. The layout change would affect some out-of-tree kernel modules, requiring them to be recompiled.
Tue, Sep 5
I still have a couple of WIP patches: one to update the bhyve man page a bit, and another to update option parsing and usage strings. There are quite a few further TODOs: gdb support, PCI passthrough support, ACPI support. I've started working on the gdb stub in the background.
Update the src.conf.5 description for WITH_BHYVE.
Make vmexit_hyp() a stub. Translation faults are handled in the kernel.
Mon, Sep 4
Fri, Sep 1
Thu, Aug 31
Seems ok to me, but:
@melifaro does this change seem correct to you?
Include <sys/time.h> instead of <sys/timespec.h>. This causes intentional namespace pollution that mimics Linux.