libusb: implement libusb_setlocale to support different locale of error message as upstream does

[aokblast]

Summary

Currently, we only support English and Mandarine as I don't speak other language

The upstream libsub only use first two character to identify a language locale so we would like to follow with them.

Also, we cannot bring upstream GPL language string back as it will violate the GPL License.

[aokblast]

@rcyu Could you please help me check the Mandarine locale?

[aokblast]

Fix indent

[aokblast]

Fix indent

[toto6038_gmail.com]

lib/libusb/libusb10.c

113

114

115

116

118

Just in case someone may wonder how this term is translated. Under informal communication, the word "pipe" usually remains untranslated, but if it has to be translated I think Microsoft's translation convention fits well. Please see here.

[kevans]

lib/libusb/libusb10.c

92

I don't insist, but it might be a good idea to use array initializers here ([-LIBUSB_ERROR_COUNT] = "...")

1790

I think we should spell 13 here as LIBUSB_ERROR_COUNT - 1

1792

Parenthesized return value, as per style(9). While I'm thinking about this, I wonder if we should allow for holes in the translations. I'm thinking mainly for cases where we might add another error in the future; we'll have a NULL slot in other language maps until they get converted, and it probably makes sense to fallback to the english context for those individual entries.

1894

nitems(libusb_language_ctx) and drop the local, please -- macro exists in sys/param.h if you need to pull that in.

1898

Instead of breaking here, you might consider just setting default_language_context and returning LIBUSB_SUCCESS immediately, then assume the post-loop bits are an error path.

lib/libusb/libusb10.h

145

This formatting is valid, but I think it's a little jarring... IMO we should move the comment to the line above so that we don't have to wrap the name to the next line.

[toto6038_gmail.com]

lib/libusb/libusb10.c

118

The link opens Microsoft Terminology Search. {F119859017}

[aokblast]

Fix comments' problem and add manual

[aokblast]

Fix format

[kevans]

Almost there- let's bring in manpages to sanity check the manpage revision.

lib/libusb/libusb.3

113

New sentences should begin on a new line

lib/libusb/libusb10.c

1889

It's also acceptable to move the declaration down to the for loop entirely these days, if you'd like.

[pauamma_gundo.com]

lib/libusb/libusb.3

113

114

lib/libusb/libusb10.c

1883–1884

[kevans]

lib/libusb/libusb.3

110

[aokblast]

Fix comments

[aokblast]

lib/libusb/libusb10.c

1889

I would like to leave it in the same place as it follws the style.

[kevans]

I think I'm happy with the implementation, but I would like to see independent sign-off on the finished Mandarin translations and manpage.

lib/libusb/libusb10.c

1889

👍

[ziaee]

lib/libusb/libusb.3

111–113

Maybe?

114

[aokblast]

Update English manual

[aokblast]

Please use this patch to merge. https://github.com/aokblast/freebsd-src/commit/ff36a394a7e84e2576db83f1ef5f28cd61e36366.patch Thanks!

[ziaee]

lib/libusb/libusb.3

118

"Therefore" and "That means" have the same meaning, so you don't need to use both here.

[aokblast]

Fix comment

[markj]

lib/libusb/libusb10.c

49

sys/param.h is special, see style(9). It should always come first in the include list. All of the sys/* includes should appear before the rest, but that is an unrelated change. You should just add sys/param.h to the beginning for now, just before ctype.h.

1784

1893

Won't libusb_setlocale("abc") cause a segfault here? strchr() returns NULL if no match is found.

[ziaee]

Ok, with these little nits, the manpage looks good to me.

lib/libusb/libusb.3

117

Stray capitalization

120

Macro lines need a space before the final punctuation.

[aokblast]

Minor fixes

[aokblast]

Fix author name.

[markj]

Approved.

In D50820#1163168, @aokblast wrote:

Please use this patch to merge. https://github.com/aokblast/freebsd-src/commit/ff36a394a7e84e2576db83f1ef5f28cd61e36366.patch Thanks!

There is a typo in the commit message, Mandarine->Mandarin.