I decided I will completly rework big parts of the code, I will reopen a review when ready, I don't want to waste your time, in the mean time, thank you all for the review so far.

Handle partial non-blocking read on the control socket
Add forgotten support for proper shutdown (oups)

Handle errors from setsid() and chdir("/"), just in case

Activate the reaper for all kind of legacy scripts
Fixes some tokenizer issue
xread now can take a timeout parameter
rcctl status now prints the nojail and nostart status
fix a bunch of tests
dangerous env vars concept removed
varity the PROC_REAP_STATUS
use waitid instead of waitpid

In D56835#1321082, @vsasjason_gmail.com wrote:

Will it help sshd to start without being indefinitely blocked by e.g. mysqld? That would be enough of a reason for me personally to switch to this thing immediately.

improve experience when dealing with legacy script:
better output of the rcctl command, and fix all bugs dealing with local_unbound
reported so far

more work on zombies
show resources for legacy scripts

Handle cases when a user explicitly set /var/run a tmpfs in the fstab

Add boot time looging by popular demand

reap hard; this time I hope it should be fine for your case @otis

actually properly read ziaee's comments

address @ziaee comments

In D56835#1320939, @arrowd wrote:

In D56835#1311164, @imp wrote:

I'd like to echo the user requirement. I have not current need for it at $WORK, but can see a need in the future. Having the ability for users to tie into the startup, running as themselves, much like we allow users to add jobs to cron, at, etc would be a useful, but not gating, feature.

I believe that user units is actually an orthogonal feature of the system service manager. If we are to implement user units, IMO, it should be a cross-platform project that consumes pristine systemd unit descriptions and hooks into the OS via PAM. It doesn't even has to be a part of base, because only uses of user units I stumbled upon so far were coming from ports.

I'm working on a systemd-logind replacement, which will fill the user units hole nicely, but there is a ton of work to do.

In D56835#1320727, @ngie wrote:

Please add [explicit? implicit?] versioning information to the schema and UCL files -- otherwise you risk problems when upgrading/downgrading schema/unit files.

In D56835#1320723, @ngie wrote:

In D56835#1320540, @bapt wrote:

In D56835#1320487, @ngie wrote:

In D56835#1320486, @ngie wrote:

This is a lot of greenfield code. Simple architectural question: is there a reason why this was written in C instead of C++? C++ wouldn't provide all of the functionality, but it would provide access to a number of data structures and algorithms that aren't available in C.

This comment is coming from a place of seeing and dealing with the complexity associated with libatf-c vs libatf-c++ -- the former has a number of complicated forms of memory management and data structures that simply do not need to exist with libatf-c++.

I don't know how to code in c++.

:(. Is this project available on a branch that I can help contribute to? I really want to leverage C++ to avoid a lot of wheel reinventing with the daemon.

In D56835#1320536, @otis wrote:

And, when invoked as /sbin/rcd on a live system, I'm getting:

1700  -  Is    0:00.02 |-- rcd -v
2599  -  Z     0:00.00 | |-- <defunct>
2600  -  Z     0:00.00 | |-- <defunct>
2601  -  Z     0:00.00 | |-- <defunct>
2602  -  Z     0:00.00 | |-- <defunct>
2603  -  Z     0:00.00 | |-- <defunct>
3180  -  Z     0:00.00 | |-- <defunct>
3182  -  Z     0:00.00 | |-- <defunct>
3185  -  Z     0:00.00 | |-- <defunct>
3228  -  I     0:00.00 | |-- rcd-exec: reaper: syslogd (pid 3378) (rcd-exec)
3371  -  SCs   0:00.00 | | |-- /usr/sbin/syslogd -s
3376  -  I     0:00.00 | | |-- syslogd: syslogd.casper (syslogd)
3378  -  Is    0:00.00 | | `-- syslogd: system.net (syslogd)
3359  -  Z     0:00.00 | |-- <defunct>
3361  -  Z     0:00.00 | |-- <defunct>
3362  -  Z     0:00.00 | |-- <defunct>
3364  -  Z     0:00.00 | |-- <defunct>
3365  -  Z     0:00.00 | |-- <defunct>
3368  -  Z     0:00.00 | |-- <defunct>
3536  -  I     0:00.00 | `-- rcd-exec: reaper: cron (pid 3715) (rcd-exec)
3715  -  Ss    0:00.00 |   `-- /usr/sbin/cron -s

too many defuct processes.

Address zombie in legacy mode
add xpdwait for EINTR

In D56835#1320440, @jilles wrote:

This looks very cool, and a lot of work.

I would like to see that service(8) detects that rcd is being used and invokes rcctl instead of rc.d scripts. This way, service(8) can be used to start/restart/etc things without needing to know how init works on the system.

Address @jilles comments

In D56835#1320487, @ngie wrote:

In D56835#1320486, @ngie wrote:

This is a lot of greenfield code. Simple architectural question: is there a reason why this was written in C instead of C++? C++ wouldn't provide all of the functionality, but it would provide access to a number of data structures and algorithms that aren't available in C.

This comment is coming from a place of seeing and dealing with the complexity associated with libatf-c vs libatf-c++ -- the former has a number of complicated forms of memory management and data structures that simply do not need to exist with libatf-c++.

fix xmalloc conversion to use longjmp, now this is define per use
case so only the use in rcd is using longjmp

Address @kib's comments

address kevens comments

committed

fix missed initialization of printline_last_flush