Have you proposed this patch to upstream? ingo@openbsd.org is very responsive and should reply back quickly, before adding any custom patch I prefer it to be discussed with upstream first. (don't hesitate to CC me)

It's a pitty we can't be consistent and have a libdata equivalent for compat libraries, but on the other hand I don't have better proposal that what is proposed here.

In fact this change does not make sense, to be able to have dhclient properly set the routing table in the right fib, the way to do it is the following: 1. tag your iface: ifconfig $iface fib X, 2/ run dhclient in the right fib: setfib X $iface and that's all, route if fib aware already, and ifconfig is also fib aware as long as the fib is already set on the iface.

https://github.com/freebsd/pkg/commit/ce75303c613f2f5d04fdd7c9edd6f4cd40eb9dac this should fix this specific case

LGTM

as for the URL, this is weird, I will investigate, thank you for reporting.

I do like what I see, I feel like with some little pkg hacking I can ease the life of this trigger, but I need to know more what you would expect ;)

other than a small remark, it looks good to me

simple remark, not mandatory to follow ;), otherwise LGTM

LGTM

LGTM

Catchup with gconf changes