Enable usbhid by default
Needs ReviewPublic
Actions

Authored by manu on Thu, Jun 20, 8:11 AM.

Details

Reviewers

andrew
wulf
bapt

Summary

Use usbhid by default and not the old HID stack.
This should be a no functional changes for most users, just the
devices name will change.
If you use fido/u2f keys it's known to not work so you can disable this
by setting hw.usbhid.enable=0 in loader.conf
For users using old touchscreen (like some ELO ones) this avoid using webcamd
as hmt(4) will work fine on them.

Sponsored by: Beckhoff Automation GmbH & Co. KG

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

manu created this revision.Thu, Jun 20, 8:11 AM

Herald added a reviewer: andrew. · View Herald TranscriptThu, Jun 20, 8:11 AM

Herald added a reviewer: andrew. · View Herald Transcript

Herald added subscribers: riscv, jhibbits, emaste, imp. · View Herald Transcript

manu requested review of this revision.Thu, Jun 20, 8:11 AM

Harbormaster completed remote builds in B58263: Diff 140024.Thu, Jun 20, 8:11 AM

manu added a parent revision: D45658: conf: Add hkbd and hms to GENERIC* kernel configs.Thu, Jun 20, 8:11 AM

manu added a reviewer: wulf.Thu, Jun 20, 8:11 AM

bapt accepted this revision.Fri, Jun 21, 12:14 PM

This revision is now accepted and ready to land.Fri, Jun 21, 12:14 PM

LGTM.

But there are still 2 known regressions

Some FIDO/U2f keys does not works stable. See https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=265528 and https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=263995. I Did a fix D41639 but I still think that it can be improved.
USB mices will not work in VT as moused does not support evdev protocol. I made evdev-awared version of moused. It works (and supports touchpads) but it is not ready to replace our basesystem daemon yet. May be I need just create a port for beginning?

In D45659#1041872, @wulf wrote:

LGTM.

But there are still 2 known regressions

Some FIDO/U2f keys does not works stable. See https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=265528 and https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=263995. I Did a fix D41639 but I still think that it can be improved.

USB mices will not work in VT as moused does not support evdev protocol. I made evdev-awared version of moused. It works (and supports touchpads) but it is not ready to replace our basesystem daemon yet. May be I need just create a port for beginning?

Thanks, I wasn't aware of those two issues, I'll have a look at those in the next few (working) days. For now I'll hold on on commiting this.

imp added inline comments.Fri, Jun 21, 8:29 PM

sys/amd64/conf/GENERIC
328 ↗	(On Diff #140024)	Why not add hkbd, rather than change ukbd to hkbd?

In D45659#1041872, @wulf wrote:

I made evdev-awared version of moused. It works (and supports touchpads) but it is not ready to replace our basesystem daemon yet. May be I need just create a port for beginning?

I forgot about link: https://github.com/wulf7/moused

wulf added inline comments.Fri, Jun 21, 9:05 PM

sys/amd64/conf/GENERIC
328 ↗	(On Diff #140024)	Why not add hkbd, rather than change ukbd to hkbd? That makes sense. To not burn bridges for binary images for some time.

manu added inline comments.Sat, Jun 22, 2:25 PM

sys/amd64/conf/GENERIC
328 ↗	(On Diff #140024)	I'll try to boot this kernel with the sysctl to 0 to check if ukbd still works correctly (it should), if that's the case yes that's probably better, at least at the beginning.