Page MenuHomeFreeBSD

Enable usbhid by default
Needs ReviewPublic

Authored by manu on Jun 20 2024, 8:11 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jan 5, 3:58 PM
Unknown Object (File)
Thu, Dec 26, 2:44 PM
Unknown Object (File)
Tue, Dec 24, 8:59 PM
Unknown Object (File)
Dec 2 2024, 12:59 AM
Unknown Object (File)
Nov 30 2024, 2:26 PM
Unknown Object (File)
Nov 25 2024, 7:44 AM
Unknown Object (File)
Nov 23 2024, 7:05 AM
Unknown Object (File)
Nov 22 2024, 8:44 AM

Details

Reviewers
andrew
wulf
bapt
Summary

Use usbhid by default and not the old HID stack.
This should be a no functional changes for most users, just the
devices name will change.
If you use fido/u2f keys it's known to not work so you can disable this
by setting hw.usbhid.enable=0 in loader.conf
For users using old touchscreen (like some ELO ones) this avoid using webcamd
as hmt(4) will work fine on them.

Sponsored by: Beckhoff Automation GmbH & Co. KG

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

manu requested review of this revision.Jun 20 2024, 8:11 AM
This revision is now accepted and ready to land.Jun 21 2024, 12:14 PM

LGTM.

But there are still 2 known regressions

  1. Some FIDO/U2f keys does not works stable. See https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=265528 and https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=263995. I Did a fix D41639 but I still think that it can be improved.
  2. USB mices will not work in VT as moused does not support evdev protocol. I made evdev-awared version of moused. It works (and supports touchpads) but it is not ready to replace our basesystem daemon yet. May be I need just create a port for beginning?

LGTM.

But there are still 2 known regressions

  1. Some FIDO/U2f keys does not works stable. See https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=265528 and https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=263995. I Did a fix D41639 but I still think that it can be improved.
  2. USB mices will not work in VT as moused does not support evdev protocol. I made evdev-awared version of moused. It works (and supports touchpads) but it is not ready to replace our basesystem daemon yet. May be I need just create a port for beginning?

Thanks, I wasn't aware of those two issues, I'll have a look at those in the next few (working) days. For now I'll hold on on commiting this.

sys/amd64/conf/GENERIC
328 ↗(On Diff #140024)

Why not add hkbd, rather than change ukbd to hkbd?

I made evdev-awared version of moused. It works (and supports touchpads) but it is not ready to replace our basesystem daemon yet. May be I need just create a port for beginning?

I forgot about link: https://github.com/wulf7/moused

sys/amd64/conf/GENERIC
328 ↗(On Diff #140024)

Why not add hkbd, rather than change ukbd to hkbd?

That makes sense. To not burn bridges for binary images for some time.

sys/amd64/conf/GENERIC
328 ↗(On Diff #140024)

I'll try to boot this kernel with the sysctl to 0 to check if ukbd still works correctly (it should), if that's the case yes that's probably better, at least at the beginning.

sys/amd64/conf/GENERIC
328 ↗(On Diff #140024)

It's the usual conservative approach. This will also let people file bug reports more easily.

manu edited the summary of this revision. (Show Details)
This revision now requires review to proceed.Jun 24 2024, 4:59 AM