Enable usbhid by default

[emaste]

Summary

Use usbhid by default and not the old HID stack.
This should be a no functional changes for most users, just the
devices name will change.
If you use fido/u2f keys it's known to not work so you can disable this
by setting hw.usbhid.enable=0 in loader.conf
For users using old touchscreen (like some ELO ones) this avoid using webcamd
as hmt(4) will work fine on them.

Sponsored by: Beckhoff Automation GmbH & Co. KG

[wulf]

LGTM.

But there are still 2 known regressions

1. Some FIDO/U2f keys does not works stable. See https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=265528 and https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=263995. I Did a fix D41639 but I still think that it can be improved.
2. USB mices will not work in VT as moused does not support evdev protocol. I made evdev-awared version of moused. It works (and supports touchpads) but it is not ready to replace our basesystem daemon yet. May be I need just create a port for beginning?

[manu]

In D45659#1041872, @wulf wrote:

LGTM.

But there are still 2 known regressions

1. Some FIDO/U2f keys does not works stable. See https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=265528 and https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=263995. I Did a fix D41639 but I still think that it can be improved.
2. USB mices will not work in VT as moused does not support evdev protocol. I made evdev-awared version of moused. It works (and supports touchpads) but it is not ready to replace our basesystem daemon yet. May be I need just create a port for beginning?

Thanks, I wasn't aware of those two issues, I'll have a look at those in the next few (working) days. For now I'll hold on on commiting this.

[imp]

sys/amd64/conf/GENERIC

328 ↗

(On Diff #140024)

Why not add hkbd, rather than change ukbd to hkbd?

[wulf]

In D45659#1041872, @wulf wrote:

I made evdev-awared version of moused. It works (and supports touchpads) but it is not ready to replace our basesystem daemon yet. May be I need just create a port for beginning?

I forgot about link: https://github.com/wulf7/moused

[wulf]

sys/amd64/conf/GENERIC

328 ↗

(On Diff #140024)

Why not add hkbd, rather than change ukbd to hkbd?

That makes sense. To not burn bridges for binary images for some time.

[manu]

sys/amd64/conf/GENERIC

328 ↗

(On Diff #140024)

I'll try to boot this kernel with the sysctl to 0 to check if ukbd still works correctly (it should), if that's the case yes that's probably better, at least at the beginning.

[imp]

sys/amd64/conf/GENERIC

328 ↗

(On Diff #140024)

It's the usual conservative approach. This will also let people file bug reports more easily.

[emaste]

sys/dev/usb/input/usbhid.c

81

from SYSCTL(9)

/*
 * Example of a variable integer value.  Notice that the control
 * flags are CTLFLAG_RW, the variable pointer is set, and the
 * value is 0.
 */
static int      doingcache = 1;         /* 1 => enable the cache */
SYSCTL_INT(_debug, OID_AUTO, vfscache, CTLFLAG_RW, &doingcache, 0,
    "Enable name cache");

[emaste]

Default text in share/man/man4/usbhid.4 needs to be updated too

[emaste]

Change default in man page

[emaste]

There are some regressions still (e.g. fido/u2f as noted). This change will need relnotes, an updating entry, and a heads-up mail.

[wulf]

IMO we can go forward and commit this change before code slush..
FIDO/U2F driver is under review. And moused is in a good enough shape to be widely tested. Both of them are minor changes and i think can be committed after August 8.