manu (Emmanuel Vadot)
User

Projects

User Details

User Since
Apr 24 2016, 4:47 PM (113 w, 9 h)

Recent Activity

Sat, Jun 23

manu committed rS335582: aw_mmc: Fix style(9) after r335476.
aw_mmc: Fix style(9) after r335476
Sat, Jun 23, 3:05 PM
manu committed rS335581: allwinner: clkng: Correct mux width and flags.
allwinner: clkng: Correct mux width and flags
Sat, Jun 23, 3:04 PM

Wed, Jun 20

manu committed rS335446: Add pmap_mapdev_attr for arm64.
Add pmap_mapdev_attr for arm64
Wed, Jun 20, 4:07 PM
manu closed D15294: Add pmap_mapdev_attr for arm64.
Wed, Jun 20, 4:07 PM
manu committed rS335445: if_rk_dwc: Disable setting delays for now.
if_rk_dwc: Disable setting delays for now
Wed, Jun 20, 3:27 PM
manu committed rS335444: rk_gpio: Read the correct register for gpio read.
rk_gpio: Read the correct register for gpio read
Wed, Jun 20, 2:46 PM
manu committed rS335443: if_rk_dwc: Fix delays handling.
if_rk_dwc: Fix delays handling
Wed, Jun 20, 2:45 PM
manu added a comment to D15891: Add MMCCAM support to AllWinner MMC driver.

It seems to work fine on pine64-lts.
So when my comments are resolved I think you could commit this (with the patch I sent you for arm64).

Wed, Jun 20, 8:38 AM
manu added inline comments to D15891: Add MMCCAM support to AllWinner MMC driver.
Wed, Jun 20, 8:37 AM
manu added inline comments to D15891: Add MMCCAM support to AllWinner MMC driver.
Wed, Jun 20, 7:47 AM

Mon, Jun 18

manu accepted D15892: Use information about max data size that the controller is able to operate.

The Allwinner part seems ok.

Mon, Jun 18, 9:57 PM
manu added a comment to D15891: Add MMCCAM support to AllWinner MMC driver.

This looks okay for me except one comment.
But due to the fact that I/We had a lot of problems with different revision of the hardware IP let me test on different SoC before commiting.
Also I won't set this review as accepted as I don't know anything about CAM.

Mon, Jun 18, 9:40 PM
manu added a comment to D15884: u-boot-: Switch to uboot@FreeBSD.Org for the maintainer.
In D15884#336074, @imp wrote:

These all look good. Maybe consider MAINTAINER?= uboot@freebsd.org in the master file?

Mon, Jun 18, 7:53 PM
manu created D15885: u-boot-riotboard: Add port for this board.
Mon, Jun 18, 5:51 PM
manu created D15884: u-boot-: Switch to uboot@FreeBSD.Org for the maintainer.
Mon, Jun 18, 4:33 PM
manu created D15883: u-boot-: Update pkg-descr to be up to date.
Mon, Jun 18, 4:33 PM
manu removed a watcher for Intel Networking: manu.
Mon, Jun 18, 2:59 PM

Sat, Jun 16

manu committed rS315045: drm(old): Remove i915 and radeon drivers.
drm(old): Remove i915 and radeon drivers
Sat, Jun 16, 5:08 PM
manu closed D5614: drm(old): Remove i915 and radeon drivers.
Sat, Jun 16, 5:08 PM

Fri, Jun 15

manu committed rS335190: allwinner: ccung: Fully subclass the clock drivers.
allwinner: ccung: Fully subclass the clock drivers
Fri, Jun 15, 8:36 AM

Thu, Jun 14

manu committed rS335170: mx25l: compat_data is only defined when FDT is.
mx25l: compat_data is only defined when FDT is
Thu, Jun 14, 7:01 PM
manu accepted D15810: aw_ccung: Add a10/a20 support.

Well in fact just commit it, it's better to have a few broken clocks that nothing at all.
I accept the review but do not add me to reviewed-by as I haven't read the clock definition.

Thu, Jun 14, 5:40 PM
manu added a comment to D15810: aw_ccung: Add a10/a20 support.
In D15810#334274, @manu wrote:

I prefer spliting the A10 and A20 right now even if for now they are the same.

As in, duplicate all of these common clocks? There's only like five extra clocks that the a20 has, so I was planning on just doing something slightly different in ccu_a20_register_clocks after registering all of the common/a10 clocks.

Thu, Jun 14, 5:34 PM
manu committed rS335161: arm timer: Use the default get_cntxct by default.
arm timer: Use the default get_cntxct by default
Thu, Jun 14, 5:32 PM
manu added a comment to D15810: aw_ccung: Add a10/a20 support.

I prefer spliting the A10 and A20 right now even if for now they are the same.

Thu, Jun 14, 5:24 PM
manu committed rS335159: mx25l: Add pnp info.
mx25l: Add pnp info
Thu, Jun 14, 5:21 PM
manu committed rS335158: spi: Add SPIBUS_PNP_INFO macro.
spi: Add SPIBUS_PNP_INFO macro
Thu, Jun 14, 5:21 PM
manu committed rS335157: aw_spi: Add pnp info.
aw_spi: Add pnp info
Thu, Jun 14, 5:19 PM
manu committed rS335156: arm timer: Add workaround for Allwinner A64 timer.
arm timer: Add workaround for Allwinner A64 timer
Thu, Jun 14, 5:18 PM
manu accepted D15806: aw_ccung: Support clock factors where factor=0, factor is effectively 1.
Thu, Jun 14, 5:11 PM
manu added a comment to D15806: aw_ccung: Support clock factors where factor=0, factor is effectively 1.

Looks fine

Thu, Jun 14, 5:11 PM
manu requested changes to D15800: Put the OTG entry in /etc/devd/otg.conf instead of /etc/devd.conf.

Why simply not add the file to the repo and copy it ?
Something like in share/example

Thu, Jun 14, 2:56 PM
manu committed rS335124: rk_i2c: Add manpage for this driver.
rk_i2c: Add manpage for this driver
Thu, Jun 14, 8:00 AM
manu committed rS335121: dts: Update our copy to Linux 4.17.
dts: Update our copy to Linux 4.17
Thu, Jun 14, 7:13 AM
manu committed rS335122: Remove myself.
Remove myself
Thu, Jun 14, 7:13 AM
manu committed rS335120: raise my limit for dts import.
raise my limit for dts import
Thu, Jun 14, 7:10 AM
manu committed rS335119: dts: Tag import.
dts: Tag import
Thu, Jun 14, 7:02 AM
manu committed rS335118: dts: Import files from Linux 4.17.
dts: Import files from Linux 4.17
Thu, Jun 14, 6:57 AM
manu committed rS335115: Add modules/rockchip.
Add modules/rockchip
Thu, Jun 14, 6:41 AM
manu committed rS335114: rk_i2c: Add driver for the I2C controller present in RockChip SoC.
rk_i2c: Add driver for the I2C controller present in RockChip SoC
Thu, Jun 14, 6:39 AM
manu committed rS335113: rk3328: Add support for the i2c clocks.
rk3328: Add support for the i2c clocks
Thu, Jun 14, 6:34 AM
manu committed rS335112: if_dwc_rk: Add DesignWare driver for RockChip SoCs..
if_dwc_rk: Add DesignWare driver for RockChip SoCs.
Thu, Jun 14, 6:28 AM
manu committed rS335109: rk_armclk: Add the write mask to the register mux value.
rk_armclk: Add the write mask to the register mux value
Thu, Jun 14, 5:47 AM
manu committed rS335108: rk_pll: Add support for mode.
rk_pll: Add support for mode
Thu, Jun 14, 5:44 AM
manu committed rS335107: rk_pinctrl: Only add gpio subnode.
rk_pinctrl: Only add gpio subnode
Thu, Jun 14, 5:41 AM

Tue, Jun 12

manu closed D15770: simplebus pnp: Do not generate pnp info is the bus status is not okay.
Tue, Jun 12, 8:03 PM
manu committed rS335014: simplebus pnp: Do not generate pnp info is the bus status is not okay.
simplebus pnp: Do not generate pnp info is the bus status is not okay
Tue, Jun 12, 8:03 PM
manu accepted D15745: Rework PSCI so it only searches for the call function once..
Tue, Jun 12, 1:54 PM
manu committed rS334996: arm64: rockchip: Correctly set armclk.
arm64: rockchip: Correctly set armclk
Tue, Jun 12, 11:47 AM
manu created D15770: simplebus pnp: Do not generate pnp info is the bus status is not okay.
Tue, Jun 12, 6:09 AM

Thu, Jun 7

manu accepted D15680: Have ofw_fdt_getprop() return the actual size of the value on success.
Thu, Jun 7, 1:45 PM

Wed, Jun 6

manu added reviewers for D15684: Add a driver for the BCM2835 Mini-UART: ARM, arm64.
Wed, Jun 6, 11:03 PM

Thu, May 31

manu committed rS334436: aw_mmc: Get max-frequency from the dtb.
aw_mmc: Get max-frequency from the dtb
Thu, May 31, 3:42 PM
manu committed rS334435: aw_mmc: Use the DEVMETHOD vccq for the IO line voltage.
aw_mmc: Use the DEVMETHOD vccq for the IO line voltage
Thu, May 31, 3:41 PM
manu committed rS334434: aw_mmc: Rework DMA.
aw_mmc: Rework DMA
Thu, May 31, 3:39 PM
manu committed rS334433: aw_mmc: Rename clock register defines consistently.
aw_mmc: Rename clock register defines consistently
Thu, May 31, 3:36 PM

Wed, May 30

manu committed rS334386: regulator: Fix typo (shuting/shutting).
regulator: Fix typo (shuting/shutting)
Wed, May 30, 3:32 PM

Mon, May 28

manu committed rS334297: arm64: fix atomic_fcmpset_16.
arm64: fix atomic_fcmpset_16
Mon, May 28, 9:05 PM
manu committed rS334295: arm64: Add atomic_fcmpset_8 and atomic_fcmpset_16.
arm64: Add atomic_fcmpset_8 and atomic_fcmpset_16
Mon, May 28, 8:29 PM

May 25 2018

manu accepted D15569: Fix building GENERIC-MMCCAM on arm64.

s/all SDHCI/all MMC/

May 25 2018, 3:44 PM · arm64

May 23 2018

manu committed rS334112: arm64: rockchip: Add proper armclock support.
arm64: rockchip: Add proper armclock support
May 23 2018, 7:07 PM

May 22 2018

manu accepted D15518: Handle reserved memory with the no-map property.
May 22 2018, 1:58 PM
manu committed rS334041: bus_dma(9): Correct arm64 BUS_DMA_COHERENT implementation note.
bus_dma(9): Correct arm64 BUS_DMA_COHERENT implementation note
May 22 2018, 1:45 PM
manu committed rS334034: bus_dma(9): arm64 implementation notes.
bus_dma(9): arm64 implementation notes
May 22 2018, 11:18 AM

May 21 2018

manu committed rS334007: devd: Always install devmatch.conf.
devd: Always install devmatch.conf
May 21 2018, 9:45 PM
manu committed rS334006: aw_mmc: Correctly reset the mmc controller.
aw_mmc: Correctly reset the mmc controller
May 21 2018, 9:15 PM
manu committed rS333976: release: arm64: Use loader.efi as bootaa64.efi for RPI3 and PINE64.
release: arm64: Use loader.efi as bootaa64.efi for RPI3 and PINE64
May 21 2018, 11:58 AM

May 19 2018

manu accepted D15465: Enable kernel dump options on most architectures..

Ok for me on arm64, dump is in zstd format and compress ok (kgdb coredump but it does it too for standard dumps so the issue is elsewhere)

May 19 2018, 6:27 PM

May 17 2018

manu added a comment to D15465: Enable kernel dump options on most architectures..

It seems that dump on arm64 currently doesn't work so I can't say if any of this options will be a benefit or not on this platform.

May 17 2018, 7:54 PM
manu committed rS333756: release: rpi3: Copy the special rpi3 config.txt.
release: rpi3: Copy the special rpi3 config.txt
May 17 2018, 7:10 PM
manu committed rS333739: MFC r333737:.
MFC r333737:
May 17 2018, 5:00 PM
manu committed rS333737: release: arm: Format FAT partition as FAT16.
release: arm: Format FAT partition as FAT16
May 17 2018, 4:21 PM
manu committed rS333716: aw_spi: Fix some silly clock mistake.
aw_spi: Fix some silly clock mistake
May 17 2018, 2:51 PM
manu committed rS333711: aw_spi: Fix manpages.
aw_spi: Fix manpages
May 17 2018, 11:53 AM
manu committed rS333710: aw_spi: Add manpage for this driver.
aw_spi: Add manpage for this driver
May 17 2018, 10:26 AM
manu committed rS333709: alwinner: Add missing files in r333708.
alwinner: Add missing files in r333708
May 17 2018, 10:25 AM
manu committed rS333708: allwinner: Add h3 spi driver.
allwinner: Add h3 spi driver
May 17 2018, 10:20 AM
manu committed rS333706: mx25l: Add mx25l1606e.
mx25l: Add mx25l1606e
May 17 2018, 10:13 AM

May 16 2018

manu created D15450: mx25l: Only check once if the device is ready.
May 16 2018, 2:41 PM

May 15 2018

manu closed D15401: sysutils/rpi-firware Update to 1.20180328.
May 15 2018, 5:20 PM
manu committed rP470037: sysutils/rpi-firware Update to 1.20180328.
sysutils/rpi-firware Update to 1.20180328
May 15 2018, 5:20 PM

May 12 2018

manu created D15401: sysutils/rpi-firware Update to 1.20180328.
May 12 2018, 3:01 PM
manu committed rS333556: aw_mmc: Rework regulator handling.
aw_mmc: Rework regulator handling
May 12 2018, 1:14 PM
manu committed rS333555: aw_mmc: Do not fully init the controller in attach.
aw_mmc: Do not fully init the controller in attach
May 12 2018, 1:13 PM
manu committed rS333554: aw_mmc: Remove hardware reset.
aw_mmc: Remove hardware reset
May 12 2018, 1:13 PM
manu committed rS333553: aw_mmc: Read interrupt register value before writing to it.
aw_mmc: Read interrupt register value before writing to it
May 12 2018, 1:12 PM

May 10 2018

manu committed rS333455: arm64: Add ALT_BREAK_TO_DEBUGGER to GENERIC.
arm64: Add ALT_BREAK_TO_DEBUGGER to GENERIC
May 10 2018, 9:38 AM

May 9 2018

manu resigned from D15366: Replace if_addr_lock rwlock with epoch + mutex.

Not allwinner specific, hoping this will remove my blocking.

May 9 2018, 6:56 AM

May 8 2018

manu accepted D15359: DTrace aarch64: Avoid calling unwind_frame() in the probe context.

Ok for me, also tested on pine64

May 8 2018, 8:41 PM · arm64, DTrace

May 7 2018

manu committed rS333320: clk: clk_set_assigned: Skip frequency of value 0.
clk: clk_set_assigned: Skip frequency of value 0
May 7 2018, 9:42 AM
manu committed rS333319: arm64: rockchip: cru: Call clk_set_assigned.
arm64: rockchip: cru: Call clk_set_assigned
May 7 2018, 7:31 AM
manu committed rS333318: clk: Add support for assigned-clock-rates.
clk: Add support for assigned-clock-rates
May 7 2018, 7:30 AM
manu committed rS333317: arm64: rockchip: clk: Add support to reparent to clk_composite.
arm64: rockchip: clk: Add support to reparent to clk_composite
May 7 2018, 7:30 AM
manu committed rS333316: arm64: rk3328: Add pll rates tables.
arm64: rk3328: Add pll rates tables
May 7 2018, 7:29 AM
manu committed rS333315: arm64: rk: Add support for setting pll rate.
arm64: rk: Add support for setting pll rate
May 7 2018, 7:28 AM
manu committed rS333314: arm64: rockchip: rk3328: Add armclk clock.
arm64: rockchip: rk3328: Add armclk clock
May 7 2018, 7:27 AM

May 6 2018

manu committed rS333305: am335x_prcm: Delay the frequencies read check.
am335x_prcm: Delay the frequencies read check
May 6 2018, 2:37 PM

May 4 2018

manu added inline comments to D15067: spigen overlays for RPI-B, RPI-2 in base (was: possible new port for spigen overlay for Raspberry Pi).
May 4 2018, 3:35 PM
manu created D15294: Add pmap_mapdev_attr for arm64.
May 4 2018, 1:01 PM

May 1 2018

manu committed rS333138: uart_snps: Add early printf support.
uart_snps: Add early printf support
May 1 2018, 1:57 PM