Page MenuHomeFreeBSD

manu (Emmanuel Vadot)
User

Projects (8)

User Details

User Since
Apr 24 2016, 4:47 PM (247 w, 13 h)

Recent Activity

Yesterday

manu accepted D28167: pkgbase: differentiate package versions for ALPHA/BETA/PRERELEASE/RC phases.
Sun, Jan 17, 8:57 PM
manu committed R10:e7ffa3b5ce04: Import devicetree files from Linux 5.10 (authored by manu).
Import devicetree files from Linux 5.10
Sun, Jan 17, 6:04 PM
manu committed rP561841: sysutils/rpi-firmware: Update to g20210111.
sysutils/rpi-firmware: Update to g20210111
Sun, Jan 17, 5:41 PM
manu accepted D28190: pkgbase: default to installing all specified kernels.
Sun, Jan 17, 4:53 PM
manu committed R10:d002814d6b8e: loader: Use TERM_EMU for arm and arm64 (authored by manu).
loader: Use TERM_EMU for arm and arm64
Sun, Jan 17, 4:47 PM
manu closed D28153: loader: Use TERM_EMU for arm and arm64.
Sun, Jan 17, 4:46 PM
manu committed R10:0f2434ea000e: loader: Partial revert of 987eabdc2ae1 (authored by manu).
loader: Partial revert of 987eabdc2ae1
Sun, Jan 17, 4:43 PM
manu requested changes to D28167: pkgbase: differentiate package versions for ALPHA/BETA/PRERELEASE/RC phases.
In D28167#629540, @kib wrote:

I should revise the message to mention this, but this is accounted for in the form of what we'd typically call a port revision:

root@viper:/usr/src# make -f Makefile.inc1 TARGET=amd64 TARGET_ARCH=amd64 _BRANCH=RELEASE -V PKG_VERSION
13.0
root@viper:/usr/src# make -f Makefile.inc1 TARGET=amd64 TARGET_ARCH=amd64 _BRANCH=RELEASE-p1 -V PKG_VERSION
13.0_1
root@viper:/usr/src# pkg version -t 13.0 13.0_1
<

This is not how ports collection typically works, from my (user) perspective. _N only means some change to the package itself, and not to the software that was packaged. Glen' suggestion is more aligned and allows to clearly see that there was a patch on RELEASE branch vs. some (minor) fix to some packaging issue.

It could mean both if we end up backporting a fix or optimization that's worth importing without hopping forward to the version it's backported from -- that said, I have no objection to making this 13.0p1 instead to more closely match SA/EN literature since 13.0 < 13.0p1 < 13.1 still holds true, and it's still clear what it means.

Sun, Jan 17, 4:08 PM
manu committed rP561813: drm-{current,devel}-kmod: Update to latest sources.
drm-{current,devel}-kmod: Update to latest sources
Sun, Jan 17, 11:56 AM
manu committed R10:ec25b6fa5ffd: LinuxKPI: Reimplement irq_work queue on top of fast taskqueue (authored by wulf).
LinuxKPI: Reimplement irq_work queue on top of fast taskqueue
Sun, Jan 17, 11:49 AM
manu committed R10:72c551930be1: Bump __FreeBSD_version after linuxkpi changes (authored by manu).
Bump __FreeBSD_version after linuxkpi changes
Sun, Jan 17, 11:49 AM
manu closed D27171: LinuxKPI: Reimplement irq_work queue on top of fast taskqueue.
Sun, Jan 17, 11:48 AM

Sat, Jan 16

manu committed R10:8ca9ff4f28d2: mips: Fix build by using the correct device-tree include path (authored by manu).
mips: Fix build by using the correct device-tree include path
Sat, Jan 16, 10:35 AM
manu committed R10:a0ee5920bee2: mips: Add the device-tree path to the include paths (authored by manu).
mips: Add the device-tree path to the include paths
Sat, Jan 16, 10:35 AM
manu committed R10:fa67846c6f52: riscv: Fix build by using the correct device-tree include path (authored by manu).
riscv: Fix build by using the correct device-tree include path
Sat, Jan 16, 10:35 AM
manu committed R10:384bd0b5b0c4: riscv: Add the device-tree path to the include path (authored by manu).
riscv: Add the device-tree path to the include path
Sat, Jan 16, 10:35 AM

Fri, Jan 15

manu added a comment to D26598: linuxkpi: upstream drm-kmod conflicting changes.

TBH this is to big for me to review, if you could split the review based on the commits (as I hope you didn't commit this whole thing in one commit) that would be easier to review.

Fri, Jan 15, 7:27 PM
manu committed R10:7c84a7405bee: Remove the old dts imported tree. (authored by manu).
Remove the old dts imported tree.
Fri, Jan 15, 7:13 PM
manu committed R10:efdf807990c3: Switch to the new device-tree vendor tree (authored by manu).
Switch to the new device-tree vendor tree
Fri, Jan 15, 7:12 PM
manu committed R10:955b980bdfb2: gpiokeys: Use the new device-tree vendor include (authored by manu).
gpiokeys: Use the new device-tree vendor include
Fri, Jan 15, 7:11 PM
manu committed R10:c38fe8789a17: arm64: Directly use #include <dt-binding/...> (authored by manu).
arm64: Directly use #include <dt-binding/...>
Fri, Jan 15, 7:11 PM
manu committed R10:19775aa7bc35: Re-apply f81b2b9a8abd to the new device-tree import (authored by manu).
Re-apply f81b2b9a8abd to the new device-tree import
Fri, Jan 15, 7:11 PM
manu committed R10:78abc9e2e6ed: Revert upstream commit 27c90e5e48d0 (authored by manu).
Revert upstream commit 27c90e5e48d0
Fri, Jan 15, 7:10 PM
manu committed R10:8a7a4683b083: arm: arm64: Directly use #include <dt-binding/...> (authored by manu).
arm: arm64: Directly use #include <dt-binding/...>
Fri, Jan 15, 1:59 PM
manu committed R10:58e169ab14cf: arm64: Add the dts include directory to the includes dir (authored by manu).
arm64: Add the dts include directory to the includes dir
Fri, Jan 15, 1:59 PM
manu committed R10:c66ec88fed84: Add 'sys/contrib/device-tree/' from commit… (authored by manu).
Add 'sys/contrib/device-tree/' from commit…
Fri, Jan 15, 11:32 AM

Thu, Jan 14

manu added a comment to D27414: linuxkpi: add firmware loading support.
In D27414#629460, @bz wrote:

@manu, did we come to the conclusion last year that currently doing this all natively was not always working and we are going with this one as the next (first) step? I'd love to commit this as soon as firmware(9) changes are in and D26598 is updated and accepted, so that we don't have to update DRM ports too often.

Thu, Jan 14, 8:15 PM
manu accepted D28167: pkgbase: differentiate package versions for ALPHA/BETA/PRERELEASE/RC phases.
Thu, Jan 14, 8:13 PM
manu committed R10:5ee353c36d3c: Import device tree files from Linux 5.9 (authored by manu).
Import device tree files from Linux 5.9
Thu, Jan 14, 3:27 PM
manu added a reverting change for D20734: pkgbase: differentiate package versions for ALPHA/BETA/PRERELEASE/RC phases (part 2): R10:03cab14ea3a8: Revert "pkgbase: differentiate package versions for ALPHA/BETA/PRERELEASE/RC….
Thu, Jan 14, 1:18 PM · pkgbase
manu added a reverting change for R10:aef769614f92: pkgbase: differentiate package versions for ALPHA/BETA/PRERELEASE/RC phases: R10:03cab14ea3a8: Revert "pkgbase: differentiate package versions for ALPHA/BETA/PRERELEASE/RC….
Thu, Jan 14, 1:18 PM
manu committed R10:03cab14ea3a8: Revert "pkgbase: differentiate package versions for ALPHA/BETA/PRERELEASE/RC… (authored by manu).
Revert "pkgbase: differentiate package versions for ALPHA/BETA/PRERELEASE/RC…
Thu, Jan 14, 1:18 PM
manu added a comment to D20734: pkgbase: differentiate package versions for ALPHA/BETA/PRERELEASE/RC phases (part 2).

Push with a rebase and a few modif (PRERELEASE didn't worked).

Thu, Jan 14, 1:01 PM · pkgbase
manu committed R10:aef769614f92: pkgbase: differentiate package versions for ALPHA/BETA/PRERELEASE/RC phases (authored by manu).
pkgbase: differentiate package versions for ALPHA/BETA/PRERELEASE/RC phases
Thu, Jan 14, 1:00 PM
manu closed D20734: pkgbase: differentiate package versions for ALPHA/BETA/PRERELEASE/RC phases (part 2).
Thu, Jan 14, 1:00 PM · pkgbase
manu added a comment to D28104: allwinner: simplify axp81x read/write.

Yeah I remember now.
RSB isn't really i2c and we can't use those (I was sure that I tested at some point).
using this code will boot but will fail as soon as we try to change the cpu freq (when we try to talk to the PMIC)
root@pine64-lts:~ # sysctl dev.cpu.0.freq=1152
dev.cpu.0.freq: iichb0: RTA not known for address 0x23
axp8xx_pmu0: Setting vdd-cpux (dcdc2) to 1300000<->1300000
<hang here>
Since we cannot communicate with the PMIC we will hang as soon as the CPU reaches the desired freq and not have the correct needed voltage.

Thu, Jan 14, 12:41 PM
manu added reviewers for D28153: loader: Use TERM_EMU for arm and arm64: ARM, arm64.
Thu, Jan 14, 11:51 AM
manu requested review of D28153: loader: Use TERM_EMU for arm and arm64.
Thu, Jan 14, 11:50 AM
manu accepted D28152: Split out the NODEBUG options to a common file.

Not tested but LGTM

Thu, Jan 14, 11:18 AM

Wed, Jan 13

manu accepted D28139: elfctl: prefix disable flags with "no".
Wed, Jan 13, 6:20 PM
manu committed R10:6003bf9290cd: dwwdt: Add PNP info for the driver (authored by manu).
dwwdt: Add PNP info for the driver
Wed, Jan 13, 5:45 PM
manu committed R10:0a05676b44ae: Add driver for Synopsys Designware Watchdog timer. (authored by manu).
Add driver for Synopsys Designware Watchdog timer.
Wed, Jan 13, 5:45 PM
manu closed D26761: Add driver for Synopsys Designware Watchdog timer..
Wed, Jan 13, 5:44 PM
manu committed rP561457: graphics/drm-{current,devel}-kmod: Update to latest source.
graphics/drm-{current,devel}-kmod: Update to latest source
Wed, Jan 13, 11:22 AM
manu added a comment to D28104: allwinner: simplify axp81x read/write.

Mhm, I don't remember if there was a reason I didn't do that or if iicdev_read/write didn't exists at the time.
Looks ok but give me a few days to test.

Wed, Jan 13, 8:44 AM

Tue, Jan 12

manu committed rP561324: graphics/libdrm: Fix manpages generation.
graphics/libdrm: Fix manpages generation
Tue, Jan 12, 12:41 PM
manu committed rP561321: graphics/drm-current-kmod: Update to latest source after linuxkpi update in base.
graphics/drm-current-kmod: Update to latest source after linuxkpi update in base
Tue, Jan 12, 12:30 PM
manu committed rP561320: graphics/drm-devel-kmod: Update to latest source after linuxkpi update in base.
graphics/drm-devel-kmod: Update to latest source after linuxkpi update in base
Tue, Jan 12, 12:21 PM
manu committed R10:35a39dc5b349: Bump __FreeBSD_version after linuxkpi changes (authored by manu).
Bump __FreeBSD_version after linuxkpi changes
Tue, Jan 12, 11:44 AM
manu committed R10:11d62b6f31ab: linuxkpi: add kernel_fpu_begin/kernel_fpu_end (authored by manu).
linuxkpi: add kernel_fpu_begin/kernel_fpu_end
Tue, Jan 12, 11:44 AM
manu committed R10:2c95fb753fb2: linuxkpi: Add shrinker support (authored by manu).
linuxkpi: Add shrinker support
Tue, Jan 12, 11:43 AM
manu committed R10:105a37cac76b: linuxkpi: Add more pci functions needed by DRM (authored by manu).
linuxkpi: Add more pci functions needed by DRM
Tue, Jan 12, 11:43 AM
manu committed R10:8517a547a052: pci: Add pci_find_class_from (authored by manu).
pci: Add pci_find_class_from
Tue, Jan 12, 11:43 AM
manu closed D28061: linuxkpi: add kernel_fpu_begin/kernel_fpu_end.
Tue, Jan 12, 11:43 AM · linuxkpi
manu closed D27728: linuxkpi: Add shrinker support.
Tue, Jan 12, 11:43 AM
manu closed D27550: linuxkpi: Add more pci functions needed by DRM.
Tue, Jan 12, 11:43 AM
manu closed D27549: pci: Add pci_find_class_from.
Tue, Jan 12, 11:43 AM
manu accepted D28061: linuxkpi: add kernel_fpu_begin/kernel_fpu_end.

Thanks, will comit this today.

Tue, Jan 12, 11:02 AM · linuxkpi
manu committed rP561311: graphics/libdrm: Update to 2.4.104.
graphics/libdrm: Update to 2.4.104
Tue, Jan 12, 10:43 AM

Wed, Jan 6

manu accepted D27960: linuxkpi: handle ARI.

Works for me.

Wed, Jan 6, 2:30 PM
manu added a comment to D27960: linuxkpi: handle ARI.

@kib We have a special flag for the DRM case. See pdrv->isdrm .

Wed, Jan 6, 10:29 AM
manu added inline comments to D27960: linuxkpi: handle ARI.
Wed, Jan 6, 10:02 AM
manu added inline comments to D27960: linuxkpi: handle ARI.
Wed, Jan 6, 9:20 AM

Tue, Jan 5

manu committed R10:cb00fc7c4d92: arm64: genet: Add bcm2711-genet-v5 compatible (authored by manu).
arm64: genet: Add bcm2711-genet-v5 compatible
Tue, Jan 5, 7:52 PM
manu accepted D27965: devel/libepoll-shim: update to 0.0.20201229.

I would have prefered the first solution that you posted TBH but ok.

Tue, Jan 5, 11:03 AM
manu added inline comments to D27965: devel/libepoll-shim: update to 0.0.20201229.
Tue, Jan 5, 10:10 AM

Mon, Jan 4

manu committed R10:e5df46055add: arm64: rockchip: rk_clk_mux: Tell the clk framework if we didn't change the… (authored by manu).
arm64: rockchip: rk_clk_mux: Tell the clk framework if we didn't change the…
Mon, Jan 4, 4:32 PM
manu committed R10:f61a3898bb98: include: Use INCSGROUPS for a few files (authored by manu).
include: Use INCSGROUPS for a few files
Mon, Jan 4, 3:37 PM
manu committed R10:b6cc69322a77: include: Tag the last includes files as part of the -dev package (authored by manu).
include: Tag the last includes files as part of the -dev package
Mon, Jan 4, 3:37 PM
manu closed D27612: include: Use INCSGROUPS for a few files.
Mon, Jan 4, 3:37 PM
manu closed D27618: include: Tag the last includes files as part of the -dev package.
Mon, Jan 4, 3:37 PM
manu committed R10:4401fa9bf1a3: pkgbase: rename PKGSIGNKEY to PKG_REPO_SIGNING_KEY (authored by manu).
pkgbase: rename PKGSIGNKEY to PKG_REPO_SIGNING_KEY
Mon, Jan 4, 3:26 PM
manu committed R10:53a27d89551e: bsd.incs.mk: Add support to override tags for a specific include group (authored by manu).
bsd.incs.mk: Add support to override tags for a specific include group
Mon, Jan 4, 3:26 PM
manu committed R10:e3ff9a1f2ed6: pkgbase: Put the last rc files in the rc package (authored by manu).
pkgbase: Put the last rc files in the rc package
Mon, Jan 4, 3:26 PM
manu committed R10:066a8c691e67: pkgbase: Install atf and kyua in the tests package (authored by manu).
pkgbase: Install atf and kyua in the tests package
Mon, Jan 4, 3:26 PM
manu committed R10:b0995124cd97: pkgbase: Install libxo test files in the tests package (authored by manu).
pkgbase: Install libxo test files in the tests package
Mon, Jan 4, 3:26 PM
manu closed D27690: rename PKGSIGNKEY to PKG_REPO_SIGNING_KEY.
Mon, Jan 4, 3:26 PM · manpages, pkgbase
manu committed R10:a22cde7c029d: pkgbase: Put ppp in it's own package (authored by manu).
pkgbase: Put ppp in it's own package
Mon, Jan 4, 3:26 PM
manu committed R10:735a585e80b9: mk: Set the DIR tags based on the files one (authored by manu).
mk: Set the DIR tags based on the files one
Mon, Jan 4, 3:26 PM
manu closed D27611: bsd.incs.mk: Add support to override tags for a specific include group.
Mon, Jan 4, 3:26 PM
manu committed R10:c92017ce5b49: pkgbase: Put libalias in the natd package (authored by manu).
pkgbase: Put libalias in the natd package
Mon, Jan 4, 3:26 PM
manu closed D27718: pkgbase: Put the last rc files in the rc package.
Mon, Jan 4, 3:26 PM
manu closed D27714: pkgbase: Install atf and kyua in the tests package.
Mon, Jan 4, 3:26 PM
manu committed R10:6b68fdbbf7be: pkgbase: Put zoneinfo file in their own package (authored by manu).
pkgbase: Put zoneinfo file in their own package
Mon, Jan 4, 3:26 PM
manu committed R10:2d486ba15f33: pkgbase: Move bectl to the runtime package (authored by manu).
pkgbase: Move bectl to the runtime package
Mon, Jan 4, 3:26 PM
manu closed D27713: pkgbase: Install libxo test files in the tests package.
Mon, Jan 4, 3:26 PM
manu closed D27711: pkgbase: Put ppp in it's own package.
Mon, Jan 4, 3:26 PM
manu closed D27712: mk: Set the DIR tags based on the files one.
Mon, Jan 4, 3:26 PM
manu closed D27710: pkgbase: Put libalias in the natd package.
Mon, Jan 4, 3:25 PM
manu closed D27708: pkgbase: Move bectl to the runtime package.
Mon, Jan 4, 3:25 PM
manu closed D27709: pkgbase: Put zoneinfo file in their own package.
Mon, Jan 4, 3:25 PM
manu added a comment to D27709: pkgbase: Put zoneinfo file in their own package.

My general preference is that we don't go too far down the path of a huge number of small packages, but even so I think zoneinfo makes sense to be in a separate package since it will be updated relatively frequently.

Mon, Jan 4, 2:26 PM
manu added a comment to D27711: pkgbase: Put ppp in it's own package.

OK, although IMO we could just put ppp and natd in the same package - I just don't know what we should name it then.

Mon, Jan 4, 2:11 PM
manu added a comment to D27550: linuxkpi: Add more pci functions needed by DRM.

I'm good with the changes, but please wait for Konstantin to accept it too. He is the PCI expert.

Mon, Jan 4, 10:09 AM
manu added a comment to D27550: linuxkpi: Add more pci functions needed by DRM.

@kib @hselasky is the code ok for you now ?
I think I've address everything ARI related.

Mon, Jan 4, 9:56 AM

Sat, Jan 2

manu added inline comments to D27887: hid: Import functions and constants required by new subsystem.
Sat, Jan 2, 3:47 PM
manu added a comment to D26853: RPI4: enable USB-boot for the 8GB-model etc.
In D26853#623275, @manu wrote:

reclaimed and reopened since, as far as I know and according to the mailing list , this issue isn't yet solved.
if I'm wrong, you can just close it again :-)

Still wrong since this dtb isn't used for the images.
Also mail on the ML seems to indicate a u-boot problem and u-boot will never use this DTB.

Sat, Jan 2, 3:04 PM
manu updated the diff for D27728: linuxkpi: Add shrinker support.
Sat, Jan 2, 1:50 PM
manu accepted D27887: hid: Import functions and constants required by new subsystem.
Sat, Jan 2, 1:00 PM
manu added a comment to D26853: RPI4: enable USB-boot for the 8GB-model etc.

reclaimed and reopened since, as far as I know and according to the mailing list , this issue isn't yet solved.
if I'm wrong, you can just close it again :-)

Sat, Jan 2, 11:40 AM