Page MenuHomeFreeBSD

manu (Emmanuel Vadot)
User

Projects

User Details

User Since
Apr 24 2016, 4:47 PM (164 w, 1 d)

Recent Activity

Yesterday

D20651: pkgbase: differentiate package versions for ALPHA/BETA/PRERELEASE/RC phases is now accepted and ready to land.
Sun, Jun 16, 10:58 AM · pkgbase

Sat, Jun 15

manu added inline comments to D20651: pkgbase: differentiate package versions for ALPHA/BETA/PRERELEASE/RC phases.
Sat, Jun 15, 9:46 PM · pkgbase

Wed, Jun 12

manu committed rS348990: mtree: Restore mode for /var/spool/lock and opielocks.
mtree: Restore mode for /var/spool/lock and opielocks
Wed, Jun 12, 11:34 AM
manu committed rS348983: pkgbase: Add some tags to files installed in distribution target.
pkgbase: Add some tags to files installed in distribution target
Wed, Jun 12, 9:18 AM
manu closed D20607: pkgbase: Add some tags to files installed in distribution target.
Wed, Jun 12, 9:18 AM
manu committed rS348982: pkgbase: Add the correct package for sendmail configuration files.
pkgbase: Add the correct package for sendmail configuration files
Wed, Jun 12, 9:17 AM
manu closed D20606: pkgbase: Add the correct package for sendmail configuration files.
Wed, Jun 12, 9:17 AM
manu committed rS348981: pkgbase: Set a default package=runtime for var directories.
pkgbase: Set a default package=runtime for var directories
Wed, Jun 12, 9:17 AM
manu closed D20605: pkgbase: Set a default package=runtime for var directories.
Wed, Jun 12, 9:17 AM

Tue, Jun 11

manu created D20607: pkgbase: Add some tags to files installed in distribution target.
Tue, Jun 11, 4:20 PM
manu created D20606: pkgbase: Add the correct package for sendmail configuration files.
Tue, Jun 11, 4:19 PM
manu created D20605: pkgbase: Set a default package=runtime for var directories.
Tue, Jun 11, 4:19 PM

Fri, May 31

manu updated the diff for D20347: efirt: Add efi_memory_attribute.

Forgot to write to out if no other pages were found.

Fri, May 31, 9:15 AM
manu added a comment to D20347: efirt: Add efi_memory_attribute.
In D20347#441879, @kib wrote:
In D20347#441878, @manu wrote:
In D20347#441757, @kib wrote:

This all looks fine, except one detail. I reviewed UEFI 2.8 description of EFI_BOOT_SERVICES.GetMemoryMap() but did not found a mention that they require the map ordered by phys address. Did you miss the code to sort the map ?

In chapter 4.6, EFI_MEMORY_ATTRIBUTES_TABLE it is said : The list must be sorted by physical start address in ascending order.

I am even more confused. The description said that about EFI_MEMORY_ATTRIBUTE, not about memory map. And you correctly use memory map, because MEMORY_ATTRIBUTE seems to be some after-thought patch only applicable to EFI runtime code and data.

Fri, May 31, 8:32 AM
manu updated the diff for D20347: efirt: Add efi_memory_attribute.

qsort the efi map
If out is supplied, search for the last page with the same attributes as the requested out and write the address in out.

Fri, May 31, 8:32 AM

Thu, May 30

manu added a comment to D20347: efirt: Add efi_memory_attribute.
In D20347#441757, @kib wrote:

This all looks fine, except one detail. I reviewed UEFI 2.8 description of EFI_BOOT_SERVICES.GetMemoryMap() but did not found a mention that they require the map ordered by phys address. Did you miss the code to sort the map ?

Thu, May 30, 11:17 AM

Wed, May 29

manu updated the diff for D20347: efirt: Add efi_memory_attribute.

return (0) -> return (false)

Wed, May 29, 4:14 PM
manu updated the diff for D20347: efirt: Add efi_memory_attribute.

Use bsearch and address kib's comments.

Wed, May 29, 3:14 PM

Tue, May 28

manu added a comment to D20348: arm64: pmap: Try to find the correct attribute.

You could build a table of descriptors with EFI_MD_ATTR_RT set, sorted by md_virt value, and do a binary search on that table to find which range, and thus which descriptor, had the address you're looking for.
I don't know anything about EFI, so I don't know if the ranges come in sorted order already, or whether we'd have to sort them. And I don't know if this is something that could be done once in efirt.c:efi_init, or would need to be done in efirt_machdep.c:eft_create_1t1_map for each architecture. In any case, it seems not too hard to replace a linear search with a binary search.

Tue, May 28, 5:51 AM
manu accepted D20412: arm32 support for inline ffs, fls.

LGTM, I'll try to find to time to test today on armv7 and armv6.

Tue, May 28, 5:47 AM

Mon, May 27

manu added a comment to D20348: arm64: pmap: Try to find the correct attribute.

So with a pctrie (I can post the code somewhere if you want) I have 14 non-leaf node
db> show pctrienode efi_map_trie_zone
node 0xffff000000ad3f90, owner fffffd0010d0b540, children count 19408, level 4305:
slot: 0, val: 0xffff000001568060, value: 0, clev: 4305
slot: 1, val: 0xbfffd3ff18, value: 0, clev: 4305
slot: 2, val: 0xbfffd3fb18, value: 0, clev: 4305
slot: 3, val: 0xfffffdbf7fd30018, value: 0, clev: 4305
slot: 5, val: 0xffff000000760795, value: 0xffff000000760794, clev: 4305
slot: 6, val: 0x1030000, value: 0, clev: 4305
slot: 7, val: 0xfffffdbf6a38b200, value: 0, clev: 4305
slot: 9, val: 0xfffffd00101a2c40, value: 0, clev: 4305
slot: 10, val: 0xfffffd0010b9e400, value: 0, clev: 4305
slot: 12, val: 0x1dcd6500, value: 0, clev: 4305
slot: 13, val: 0xfffffd0010b9e380, value: 0, clev: 4305
slot: 14, val: 0xfffffd0010b9d200, value: 0, clev: 4305

Mon, May 27, 6:15 PM
manu updated the diff for D20347: efirt: Add efi_memory_attribute.

Address kib comments.
Note that based on some comment on D20348 I might change this revision so efi_memory_attribute won't use the efi map directly.

Mon, May 27, 2:22 PM
manu added inline comments to D20348: arm64: pmap: Try to find the correct attribute.
Mon, May 27, 1:40 PM

Thu, May 23

manu committed rS348196: loader: Remove unused variable.
loader: Remove unused variable
Thu, May 23, 8:04 PM
manu added inline comments to D20347: efirt: Add efi_memory_attribute.
Thu, May 23, 7:35 PM
manu committed rS348194: loader: Add pnp functions for autoloading modules based on linker.hints.
loader: Add pnp functions for autoloading modules based on linker.hints
Thu, May 23, 7:27 PM
manu closed D19498: loader: Add pnp functions for autoloading modules based on linker.hints.
Thu, May 23, 7:27 PM
manu committed rS348182: arm: allwinner: Remove frac mode from NM clk.
arm: allwinner: Remove frac mode from NM clk
Thu, May 23, 5:37 PM
manu committed rS348181: arm: allwinner: clk: Use the new frac clock.
arm: allwinner: clk: Use the new frac clock
Thu, May 23, 5:36 PM
manu committed rS348180: arm: allwinner: clk: Add new clock aw_clk_frac.
arm: allwinner: clk: Add new clock aw_clk_frac
Thu, May 23, 5:35 PM
manu committed rS348179: allwinner: aw_ccu: Add some debug printfs (disabled by default).
allwinner: aw_ccu: Add some debug printfs (disabled by default)
Thu, May 23, 5:34 PM
manu accepted D20382: Define macros to make it easier to define bus-specific pnpinfo for FDT systems.
Thu, May 23, 3:42 PM
manu committed rS348165: etcupdate: Add missing directory when building the tree.
etcupdate: Add missing directory when building the tree
Thu, May 23, 2:05 PM
manu committed rS348151: etcupdate: Fix -p after the move of the passwd related files.
etcupdate: Fix -p after the move of the passwd related files
Thu, May 23, 7:59 AM
manu updated the diff for D20348: arm64: pmap: Try to find the correct attribute.

remove a blank line removal.

Thu, May 23, 6:58 AM
manu committed rS348150: pkgbase: Remove etc/zfs from being packaged.
pkgbase: Remove etc/zfs from being packaged
Thu, May 23, 6:54 AM
manu retitled D20348: arm64: pmap: Try to find the correct attribute from arm64: pmap_mapbios: Try to find the correct attribute to arm64: pmap: Try to find the correct attribute.
Thu, May 23, 6:51 AM
manu updated the diff for D20349: arm64: efi: Map memory IO region as device.

Default to DEVICE and while here check is XP atttribute is set and set UXN/PXN if it is.

Thu, May 23, 6:44 AM
manu updated the diff for D20348: arm64: pmap: Try to find the correct attribute.

Correct the mapping in pmap_kenter based on the requested one and the one in the efi map

Thu, May 23, 6:43 AM
manu updated the diff for D20347: efirt: Add efi_memory_attribute.
Thu, May 23, 3:00 AM
manu accepted D20357: Use ACPI SPCR on x86.

good for me, please just commit with the baudrate 0 comment preserved, I'm sure this will help someone in the future.

Thu, May 23, 1:10 AM
manu added inline comments to D20357: Use ACPI SPCR on x86.
Thu, May 23, 12:56 AM

Wed, May 22

manu added inline comments to D20347: efirt: Add efi_memory_attribute.
Wed, May 22, 10:15 AM
manu updated the diff for D20347: efirt: Add efi_memory_attribute.

Add helper function that get the memory map from efi.
Remove some debugs printf that weren't supposed to be there.

Wed, May 22, 10:14 AM
manu added a comment to D20348: arm64: pmap: Try to find the correct attribute.
In D20348#438893, @kib wrote:
In D20348#438886, @manu wrote:
In D20348#438878, @kib wrote:

I think this change should be somewhat improved by taking the most strong attr mode between pair of what is reported by UEFI memory map, and what is requested by a caller. For instance, if caller requests uncacheable, while UEFI reports write-combining, uncacheable should win.

I don't really understand, the caller of pmap_mapbios never request the mapping attr.

I mean that any mapping created by pmap_mapXXX() functions should take the UEFI map attributes. In particular, pmap should not change DMAP attributes in a way incompatible with the firmware requirements.

Wed, May 22, 9:53 AM
manu added a comment to D20348: arm64: pmap: Try to find the correct attribute.
In D20348#438878, @kib wrote:

Can you do the same for amd64 ?

Wed, May 22, 9:22 AM
manu added inline comments to D20347: efirt: Add efi_memory_attribute.
Wed, May 22, 9:08 AM
manu committed rS348107: pkgbase: Really move login.access.
pkgbase: Really move login.access
Wed, May 22, 7:42 AM
manu committed rS348106: pkgbase: Really move termcap.small.
pkgbase: Really move termcap.small
Wed, May 22, 7:41 AM
manu committed rS348105: pkgbase: Really move rc.sendmail.
pkgbase: Really move rc.sendmail
Wed, May 22, 7:40 AM
manu committed rS348104: pkgbase: Really move rc.bsdextended.
pkgbase: Really move rc.bsdextended
Wed, May 22, 7:40 AM
manu committed rS348103: pkgbase: Really move rc.firewall.
pkgbase: Really move rc.firewall
Wed, May 22, 7:39 AM
manu committed rS348102: pkgbase: Move login.access to usb.bin/login.
pkgbase: Move login.access to usb.bin/login
Wed, May 22, 7:23 AM
manu committed rS348101: pkgbase: Move termcap.small to share/termcap.
pkgbase: Move termcap.small to share/termcap
Wed, May 22, 7:22 AM
manu committed rS348100: pkgbase: Move rc.sendmail to libexec/rc.
pkgbase: Move rc.sendmail to libexec/rc
Wed, May 22, 7:22 AM
manu committed rS348099: pkgbase: Move rc.bsdextended to libexec/rc.
pkgbase: Move rc.bsdextended to libexec/rc
Wed, May 22, 7:21 AM
manu committed rS348098: pkgbase: Move rc.firewall to libexec/rc.
pkgbase: Move rc.firewall to libexec/rc
Wed, May 22, 7:21 AM
manu created D20349: arm64: efi: Map memory IO region as device.
Wed, May 22, 5:08 AM
manu added a reviewer for D20347: efirt: Add efi_memory_attribute: andrew.
Wed, May 22, 5:07 AM
manu created D20348: arm64: pmap: Try to find the correct attribute.
Wed, May 22, 5:07 AM
manu created D20347: efirt: Add efi_memory_attribute.
Wed, May 22, 5:06 AM

May 17 2019

manu committed rS347930: pci: ecam: Correctly parse memory and IO region.
pci: ecam: Correctly parse memory and IO region
May 17 2019, 5:05 PM
manu closed D20214: pci: ecam: Correctly parse memory and IO region.
May 17 2019, 5:05 PM
manu committed rS347929: pci: ecam: Do not warn on mismatch of bus_end.
pci: ecam: Do not warn on mismatch of bus_end
May 17 2019, 5:04 PM
manu closed D20213: pci: ecam: Do not warn on mismatch of bus_end.
May 17 2019, 5:04 PM

May 16 2019

manu accepted D20279: Fix mergemaster after r347638 and the master.passwd / group move.
May 16 2019, 7:46 PM
manu accepted D20279: Fix mergemaster after r347638 and the master.passwd / group move.
May 16 2019, 6:27 PM

May 15 2019

manu accepted D16728: Move master.passwd and group to lib/libc/gen/.
May 15 2019, 3:26 PM
manu accepted D20262: Add common support functions for USB devices configured via FDT data..
May 15 2019, 1:11 PM

May 13 2019

manu committed rS347522: Revert r347356 and r347371.
Revert r347356 and r347371
May 13 2019, 12:38 PM

May 12 2019

manu committed rS347512: arm: allwinner: aw_clk_nm: Don't reparent the clock if we didn't ask.
arm: allwinner: aw_clk_nm: Don't reparent the clock if we didn't ask
May 12 2019, 3:27 PM

May 11 2019

manu committed rS347491: twsi: Calculate the clock param based on the bus frequency.
twsi: Calculate the clock param based on the bus frequency
May 11 2019, 3:04 PM
manu committed rS347490: allwinner: clk: sun8i_r: Correct resets.
allwinner: clk: sun8i_r: Correct resets
May 11 2019, 3:03 PM
manu committed rS347489: allwinner: clk: prediv_mux: Init the current parent.
allwinner: clk: prediv_mux: Init the current parent
May 11 2019, 3:02 PM

May 10 2019

manu committed rS347442: arm64: rockchip: Don't always put PLL to normal mode.
arm64: rockchip: Don't always put PLL to normal mode
May 10 2019, 4:45 PM
manu closed D20174: arm64: rockchip: Don't always put PLL to normal mode.
May 10 2019, 4:45 PM
manu committed rS347441: efibootmgr: Do not add the new boot entry in dry-run is specified.
efibootmgr: Do not add the new boot entry in dry-run is specified
May 10 2019, 4:44 PM
manu closed D20212: efibootmgr: Do not add the new boot entry in dry-run is specified.
May 10 2019, 4:44 PM
manu closed D20144: ahci: Check if bus is cache-coherent.
May 10 2019, 4:44 PM
manu committed rS347440: ahci: Check if bus is cache-coherent.
ahci: Check if bus is cache-coherent
May 10 2019, 4:44 PM

May 9 2019

manu created D20214: pci: ecam: Correctly parse memory and IO region.
May 9 2019, 1:37 PM
manu created D20213: pci: ecam: Do not warn on mismatch of bus_end.
May 9 2019, 1:36 PM
manu created D20212: efibootmgr: Do not add the new boot entry in dry-run is specified.
May 9 2019, 1:01 PM

May 8 2019

manu committed rS347371: etc/Makefile: Remove empty newline.
etc/Makefile: Remove empty newline
May 8 2019, 9:26 PM
manu committed rS347366: dts: Import files from Linux 5.1.
dts: Import files from Linux 5.1
May 8 2019, 7:29 PM
manu committed rS347364: Tag import of DTS files from Linux 5.1.
Tag import of DTS files from Linux 5.1
May 8 2019, 7:06 PM
manu committed rS347363: Import Linux 5.1 DTS files.
Import Linux 5.1 DTS files
May 8 2019, 7:01 PM
manu committed rS347362: dtb: allwinner: Add the pinebook dtb to the build.
dtb: allwinner: Add the pinebook dtb to the build
May 8 2019, 6:56 PM
manu committed rS347356: pkgbase: Deal with the last etc files.
pkgbase: Deal with the last etc files
May 8 2019, 5:47 PM
manu closed D20173: pkgbase: Deal with the last etc files.
May 8 2019, 5:47 PM
manu committed rS347343: Add support for USB 3.0 XHCI via ACPI.
Add support for USB 3.0 XHCI via ACPI
May 8 2019, 3:43 PM
manu closed D19986: Add support for USB 3.0 XHCI via ACPI.
May 8 2019, 3:43 PM · arm64, Contributor Reviews (base)
manu accepted D19986: Add support for USB 3.0 XHCI via ACPI.

Tinh Nguyen from Ampere tested and it doesn't seems to make usb working (xhci controller is discovered but nothing more), I've tried on my overdrive in FDT mode and it works.
In acpi mode this doesn't but it doesn't without this patch too, looks like the acpi table is missing info about interrupts, I'll do one more test on the macchiatobin and then commit this.

May 8 2019, 2:05 PM · arm64, Contributor Reviews (base)

May 7 2019

manu added a comment to D20173: pkgbase: Deal with the last etc files.
In D20173#434910, @brd wrote:

I would rather just finish moving these as appropriate.. but I can do that later if you want to get this in sooner.

May 7 2019, 5:05 PM
manu accepted D19986: Add support for USB 3.0 XHCI via ACPI.
May 7 2019, 7:40 AM · arm64, Contributor Reviews (base)

May 6 2019

manu created D20174: arm64: rockchip: Don't always put PLL to normal mode.
May 6 2019, 8:24 PM
manu created D20173: pkgbase: Deal with the last etc files.
May 6 2019, 7:14 PM

May 4 2019

manu requested changes to D20156: Add support for RK3399 emmc.

It missed the phy, so currently this works because u-boot already setup it for us.

May 4 2019, 11:35 AM

May 2 2019

manu closed D17206: devel/arm-none-eabi-gcc: Unbreak on arm64.

Commited as r481798

May 2 2019, 7:39 PM
manu committed rS347024: dtb: Include RK3399 RockPro64 DTS in kernel build.
dtb: Include RK3399 RockPro64 DTS in kernel build
May 2 2019, 5:04 PM