LGTM, just one comment and we're good.

The clocks are the same for rk805 so please prefix all function rk805 instead of rk808.
Otherwise looks good.

Now they are parsed but you don't use them.
See https://cgit.freebsd.org/src/commit/sys/arm/allwinner/aw_mmc.c?id=9ed8321078444aea2a90a361f91e54065d5daf21 for how to use it.

In D30103#676127, @andrew wrote:

We don't have a device_t to use this early so would need to create a driver to attach to the same node later in the boot. One of the problems is it's a child of /chosen so doesn't get probed. For testing I created a chosen driver we could use that attaches to the chosen node and adds any children it finds.

In D30103#676103, @andrew wrote:

I can easily add more formats, although can't test the clocks as I don't have hardware that has the clocks property.

I don't think it make much sense to commit that without all formats supported and clocks, efifb should be good enough instead. (and yes I know that it's not on the mac blah that you're working on :P )

In D30067#675487, @jbeich wrote:

Ping. Getting this port up-to-date is important for upstream CI of consumers.

I'll also add a note in UPDATING that for pkgbase users they will need to pkg install -f FreeBSD-openssl before pkg upgrade.
Otherwise everything goes boom.

Add libcrypto too

In D30088#675180, @me_igalic.co wrote:

how will this behave on pkg upgrade?

I forgot libcrypto, will update later today.

Add openssl comment and desc in Makefile.package

In D30081#675021, @me_igalic.co wrote:

perhaps an entry in release/packages/Makefile.package
could be useful

Maybe it would be simpler and more clear to have a new memory type for struct resource for PCI config region that all the bus_* routines will know ?

Do you plan to continue working on this ?

There is a property in the DTS for that :
https://cgit.freebsd.org/src/tree/sys/contrib/device-tree/src/arm64/altera/socfpga_stratix10_socdk.dts#n111
And we parse this in :
https://cgit.freebsd.org/src/tree/sys/dev/mmc/mmc_fdt_helpers.c#n124
And :
https://cgit.freebsd.org/src/tree/sys/dev/mmc/host/dwmmc.c#n530

LGTM
But since the docs about this part isn't up to date just wait that someone from docs review this.

In D29883#672874, @markj wrote:

In D29883#672527, @manu wrote:

I don't remember why I did this but yes this solve some dependencies issues.

Ok, thanks. I think I will go ahead and commit this with a generous MFC period to see if I break anything. The original name mangling was added long enough ago that I want to believe that whatever problem it solved no longer exists.

Same comment as Hans :)
And please bump FreeBSD_version so we can check this in the drm-devel-kmod in the near futur.

I don't remember why I did this but yes this solve some dependencies issues.

Don't forget the Approved by: manu (mentor) in the commit.

What's the difference between this and making an non-optional requirement for the file ?
Is it just to have a nicer error message than a linker error ?
Looking at D29849 it seems that the same thing could be achieve by adding "iflib" in every em(4) related file and since em(4)
needs iflib I think that's the proper way of "fixing" this problem.

We talked on irc but here is the brief version :

For the 1.2V report it's probably the same problem as the one fixed by 1a96c1434f4b4487126f13ede29e67ad44a8776a

In D29758#667519, @avg wrote:

Is this the information you asked for?

# camcontrol devlist -v       
scbus0 on aw_mmc_sim0 bus 0:
scbus1 on aw_mmc_sim1 bus 0:
<SDIO card>                        at scbus1 target 0 lun 0 (sdiob0,pass1)
scbus2 on aw_mmc_sim2 bus 0:
<MMCHC 8GME4R 0.1 SN 4DAD8E5D MFG 09/200>  at scbus2 target 0 lun 0 (sdda0,pass0)
scbus-1 on xpt0 bus 0:
<>                                 at scbus-1 target -1 lun ffffffff (xpt0)

# camcontrol mmcsdcmd 2:0:0 -I
Host controller information
Host OCR: 0x300000
Min frequency: 400 KHz
Max frequency: 52 MHz
Supported bus width:
 4 bit
 8 bit
Supported operating modes:
 Can do High Speed transfers
Supported VCCQ voltages:
 3.3V
Current settings:
 Bus width: 8 bit
 Freq: 52.000 MHz (high-speed timing)
 VCCQ: 1.2V

What is the resulting chosen mode ? You can query with camcontrol
I have no problem with DDR52 on all my boards and I don't remember if anything else was missing to have proper hs200 on all Allwinner boards.

In D29664#665280, @jbeich wrote:

Landed as series of commits. Phabricator doesn't track Git-based ports/ repo yet.

For Submitted-by you can git commit --author=...

Not all changes can be split into logical units authored by a single person. In this case splitting was possible. Can I expect the same from x11 team? ;)

LGTM
For Submitted-by you can git commit --author=...

Small nits but otherwise lgtm

I'll leave this for a few days in case someone have an objection.

That doesn't seems to be specific to the Apple hardware but to the intel controller.
Linux notes that after changing CS one should wait 2 clock cycles (spi controller clock).
Our driver doesn't seems to do anything about clock and just hardcode based on the one found on the MinowBoard.
Anyway, that seems more controller specific than SPI specific so I'm not sure that this is the correct approach.

LGTM
There don't seems to be drm firmware with '-' in it btw.

Obtain from linux seems a bit much for me, it's just pci id that you're adding.
Otherwise looks good.

done :)