In that case we can also remove all the shell redirection since we do not echo anymore and the log functions can just echo directly.
Otherwise lgtm

In D40012#911091, @imp wrote:

I'm told that my assertions that this never worked may have been in error... I need to explore a bit more before I do this.

In D39886#910471, @ashafer_badland.io wrote:

Here's the rundown of my testing: on my three laptops things look to be working as I expected. I don't replicate anything like what you're seeing on the single-GPU system but I'll get to that later and maybe we can figure out what your issue is. Here's what I see:

• On my single-GPU Intel laptop it starts properly with no xorg.conf or 20-intel.conf.
• On my Intel+NVIDIA PRIME laptop it works with no xorg.conf.
  • 20-intel.conf is not required if nvidia-drm.ko is loaded, the 20-nvidia-drm-outputclass.conf from the blog post is however.
  • If nvidia-drm.ko is not loaded, then the X server sees two devices and isn't sure which one to use, so it bails and tells you to specify frambuffer busIDs. This is where 20-intel.conf will fix things, as it tells X which one to use. I'll have to check out on Linux if this is the same behavior. I wouldn't be surprised if it is since they usually expect nvidia-drm to be present therefore avoiding the issue, but we'll see.
• On my Intel+NVIDIA PRIME laptop your skeleton xorg.conf from your last comment works fine.
• On my AMD+NVIDIA PRIME laptop it works with no xorg.conf, configs from the blog post.

In D39886#910260, @vishwin wrote:

[ 77.134] (II) modeset(0): glamor X acceleration enabled on Mesa Intel(R) UHD Graphics 600 (GLK 2)
[ 77.134] (II) modeset(0): glamor initialized
[ 77.134] (==) modeset(0): VariableRefresh: disabled
[ 77.134] (==) modeset(0): AsyncFlipSecondaries: disabled
[ 77.156] (II) modeset(0): Output HDMI-1 has no monitor section
[ 77.156] (II) modeset(0): Output DP-1 has no monitor section
[ 77.180] (II) modeset(0): EDID for output HDMI-1

<snip>

[ 77.197] (II) modeset(G0): glamor X acceleration enabled on Mesa Intel(R) UHD Graphics 600 (GLK 2)
[ 77.198] (II) modeset(G0): glamor initialized
[ 77.198] (II) modeset(G0): Output HDMI-1-1 has no monitor section
[ 77.198] (II) modeset(G0): Output DP-1-1 has no monitor section
[ 77.199] (II) modeset(G0): EDID for output HDMI-1-1

The above portions of the log you added show HDMI-1 and HDMI-1-1 outputs. These correspond to the modeset(0) and modeset(G0) cards that X detects. I find this odd since this "G0" name usually refers to the second GPU in a hybrid graphics laptop, but in your case they are using the same Intel card. This is for the single GPU Intel system correct? I do not see this pattern on mine. Any more details you can provide about the machine?

Can you please try with libudev-devd 0.5.1, the latest in ports, if you aren't already? It has a fix for autoconfiguration that I haven't seen cause your error message but still might affect you. I should probably the dependency from xorg-server to require udev 0.5.1, especially if that's your missing piece.

In D39886#910260, @vishwin wrote:

Also fails on a system with only one GPU, an Intel integrated:

[    76.839]
X.Org X Server 1.21.1.8
X Protocol Version 11, Revision 0
[    76.839] Current Operating System: FreeBSD lehman 14.0-CURRENT FreeBSD 14.0-CURRENT #4 main-n262658-b347c2284603: Sat Apr 29 09:15:44 EDT 2023     root@lehman:/usr/obj/usr/src/amd64.amd64/sys/ODYSSEY amd64
[    76.839]
[    76.839] Current version of pixman: 0.42.2
[    76.839]    Before reporting problems, check http://wiki.x.org
        to make sure that you have the latest version.
[    76.840] Markers: (--) probed, (**) from config file, (==) default setting,
        (++) from command line, (!!) notice, (II) informational,
        (WW) warning, (EE) error, (NI) not implemented, (??) unknown.
[    76.841] (==) Log file: "/var/log/Xorg.0.log", Time: Fri May  5 18:03:36 2023
[    76.841] (==) Using system config directory "/usr/local/share/X11/xorg.conf.d"
[    76.842] (==) No Layout section.  Using the first Screen section.
[    76.842] (==) No screen section available. Using defaults.
[    76.842] (**) |-->Screen "Default Screen Section" (0)
[    76.842] (**) |   |-->Monitor "<default monitor>"
[    76.843] (==) No monitor specified for screen "Default Screen Section".
        Using a default monitor configuration.
[    76.843] (==) Automatically adding devices
[    76.843] (==) Automatically enabling devices
[    76.844] (==) Automatically adding GPU devices
[    76.844] (==) Automatically binding GPU devices
[    76.844] (==) Max clients allowed: 256, resource mask: 0x1fffff
[    76.844] (==) FontPath set to:
        /usr/local/share/fonts/misc/,
        /usr/local/share/fonts/TTF/,
        /usr/local/share/fonts/OTF/,
        /usr/local/share/fonts/Type1/,
        /usr/local/share/fonts/100dpi/,
        /usr/local/share/fonts/75dpi/,
        catalogue:/usr/local/etc/X11/fontpath.d
[    76.844] (==) ModulePath set to "/usr/local/lib/xorg/modules"
[    76.844] (II) The server relies on udev to provide the list of input devices.
        If no devices become available, reconfigure udev or disable AutoAddDevices.
[    76.844] (II) Module ABI versions:
[    76.844]    X.Org ANSI C Emulation: 0.4
[    76.844]    X.Org Video Driver: 25.2
[    76.844]    X.Org XInput driver : 24.4
[    76.845]    X.Org Server Extension : 10.0
[    76.856] (II) xfree86: Adding drm device (/dev/dri/card0)
[    76.856] (II) Platform probe for /dev/dri/card0
[    76.868] (--) PCI:*(0@0:2:0) 8086:3185:8086:2212 rev 3, Mem @ 0xa0000000/16777216, 0x90000000/268435456, I/O @ 0x0000f000/64, BIOS @ 0x????????/65536
[    76.868] (II) LoadModule: "glx"
[    76.869] (II) Loading /usr/local/lib/xorg/modules/extensions/libglx.so
[    76.872] (II) Module glx: vendor="X.Org Foundation"
[    76.872]    compiled for 1.21.1.8, module version = 1.0.0
[    76.872]    ABI class: X.Org Server Extension, version 10.0
[    76.872] (==) Matched intel as autoconfigured driver 0
[    76.872] (==) Matched modesetting as autoconfigured driver 1
[    76.872] (==) Matched scfb as autoconfigured driver 2
[    76.872] (==) Matched vesa as autoconfigured driver 3
[    76.872] (==) Assigned the driver to the xf86ConfigLayout
[    76.872] (II) LoadModule: "intel"
[    76.874] (WW) Warning, couldn't open module intel
[    76.874] (EE) Failed to load module "intel" (module does not exist, 0)
[    76.874] (II) LoadModule: "modesetting"
[    76.874] (II) Loading /usr/local/lib/xorg/modules/drivers/modesetting_drv.so
[    76.876] (II) Module modesetting: vendor="X.Org Foundation"
[    76.876]    compiled for 1.21.1.8, module version = 1.21.1
[    76.876]    Module class: X.Org Video Driver
[    76.876]    ABI class: X.Org Video Driver, version 25.2
[    76.876] (II) LoadModule: "scfb"
[    76.877] (II) Loading /usr/local/lib/xorg/modules/drivers/scfb_drv.so
[    76.877] (II) Module scfb: vendor="X.Org Foundation"
[    76.877]    compiled for 1.21.1.8, module version = 0.0.5
[    76.877]    ABI class: X.Org Video Driver, version 25.2
[    76.877] (II) LoadModule: "vesa"
[    76.878] (II) Loading /usr/local/lib/xorg/modules/drivers/vesa_drv.so
[    76.878] (II) Module vesa: vendor="X.Org Foundation"
[    76.878]    compiled for 1.21.1.8, module version = 2.5.0
[    76.878]    Module class: X.Org Video Driver
[    76.878]    ABI class: X.Org Video Driver, version 25.2
[    76.879] (II) modesetting: Driver for Modesetting Kernel Drivers: kms
[    76.879] (II) scfb: driver for wsdisplay framebuffer: scfb
[    76.879] (II) VESA: driver for VESA chipsets: vesa
[    76.879] (--) Using syscons driver with X support (version 2.0)
[    76.879] (--) using VT number 9

[    76.901] (**) modeset(0): claimed PCI slot 0@0:2:0
[    76.901] (II) modeset(0): using default device
[    76.901] (WW) Falling back to old probe method for scfb
[    76.901] scfb trace: probe start
[    76.901] scfb trace: probe done
[    76.917] (II) modeset(G0): using drv /dev/dri/card0
[    76.917] (WW) VGA arbiter: cannot open kernel arbiter, no multi-card support
[    76.918] (II) modeset(0): Creating default Display subsection in Screen section
        "Default Screen Section" for depth/fbbpp 24/32
[    76.918] (==) modeset(0): Depth 24, (==) framebuffer bpp 32
[    76.918] (==) modeset(0): RGB weight 888
[    76.918] (==) modeset(0): Default visual is TrueColor
[    76.918] (II) Loading sub module "glamoregl"
[    76.918] (II) LoadModule: "glamoregl"
[    76.919] (II) Loading /usr/local/lib/xorg/modules/libglamoregl.so
[    76.942] (II) Module glamoregl: vendor="X.Org Foundation"
[    76.942]    compiled for 1.21.1.8, module version = 1.0.1
[    76.942]    ABI class: X.Org ANSI C Emulation, version 0.4
[    77.134] (II) modeset(0): glamor X acceleration enabled on Mesa Intel(R) UHD Graphics 600 (GLK 2)
[    77.134] (II) modeset(0): glamor initialized
[    77.134] (==) modeset(0): VariableRefresh: disabled
[    77.134] (==) modeset(0): AsyncFlipSecondaries: disabled
[    77.156] (II) modeset(0): Output HDMI-1 has no monitor section
[    77.156] (II) modeset(0): Output DP-1 has no monitor section
[    77.180] (II) modeset(0): EDID for output HDMI-1
[    77.180] (II) modeset(0): Manufacturer: DEL  Model: 400d  Serial#: 1095914804
[    77.180] (II) modeset(0): Year: 2005  Week: 38
[    77.180] (II) modeset(0): EDID Version: 1.3
[    77.180] (II) modeset(0): Digital Display Input
[    77.180] (II) modeset(0): Max Image Size [cm]: horiz.: 38  vert.: 31
[    77.180] (II) modeset(0): Gamma: 2.20
[    77.180] (II) modeset(0): DPMS capabilities: StandBy Suspend Off
[    77.180] (II) modeset(0): Supported color encodings: RGB 4:4:4 YCrCb 4:4:4
[    77.180] (II) modeset(0): Default color space is primary color space
[    77.180] (II) modeset(0): First detailed timing is preferred mode
[    77.180] (II) modeset(0): redX: 0.640 redY: 0.330   greenX: 0.300 greenY: 0.600
[    77.180] (II) modeset(0): blueX: 0.150 blueY: 0.060   whiteX: 0.313 whiteY: 0.329
[    77.180] (II) modeset(0): Supported established timings:
[    77.180] (II) modeset(0): 720x400@70Hz
[    77.180] (II) modeset(0): 640x480@60Hz
[    77.181] (II) modeset(0): 640x480@75Hz
[    77.181] (II) modeset(0): 800x600@60Hz
[    77.181] (II) modeset(0): 800x600@75Hz
[    77.181] (II) modeset(0): 1024x768@60Hz
[    77.181] (II) modeset(0): 1024x768@75Hz
[    77.181] (II) modeset(0): 1280x1024@75Hz
[    77.181] (II) modeset(0): Manufacturer's mask: 0
[    77.181] (II) modeset(0): Supported standard timings:
[    77.181] (II) modeset(0): #0: hsize: 1152  vsize 864  refresh: 75  vid: 20337
[    77.181] (II) modeset(0): #1: hsize: 1280  vsize 1024  refresh: 60  vid: 32897
[    77.181] (II) modeset(0): Supported detailed timing:
[    77.181] (II) modeset(0): clock: 108.0 MHz   Image Size:  376 x 301 mm
[    77.181] (II) modeset(0): h_active: 1280  h_sync: 1328  h_sync_end 1440 h_blank_end 1688 h_border: 0
[    77.181] (II) modeset(0): v_active: 1024  v_sync: 1025  v_sync_end 1028 v_blanking: 1066 v_border: 0
[    77.181] (II) modeset(0): Serial No: T611659DARU4
[    77.181] (II) modeset(0): Monitor name: DELL 1905FP
[    77.181] (II) modeset(0): Ranges: V min: 56 V max: 76 Hz, H min: 30 H max: 81 kHz, PixClock max 145 MHz
[    77.181] (II) modeset(0): EDID (in hex):
[    77.181] (II) modeset(0):   00ffffffffffff0010ac0d4034555241
[    77.181] (II) modeset(0):   260f010380261f78eeee95a3544c9926
[    77.181] (II) modeset(0):   0f5054a54b00714f8180010101010101
[    77.181] (II) modeset(0):   010101010101302a009851002a403070
[    77.182] (II) modeset(0):   1300782d1100001e000000ff00543631
[    77.182] (II) modeset(0):   3136353944415255340a000000fc0044
[    77.182] (II) modeset(0):   454c4c203139303546500a20000000fd
[    77.182] (II) modeset(0):   00384c1e510e000a20202020202000c7
[    77.182] (II) modeset(0): Printing probed modes for output HDMI-1
[    77.182] (II) modeset(0): Modeline "1280x1024"x60.0  108.00  1280 1328 1440 1688  1024 1025 1028 1066 +hsync +vsync (64.0 kHz eP)
[    77.182] (II) modeset(0): Modeline "1280x1024"x75.0  135.00  1280 1296 1440 1688  1024 1025 1028 1066 +hsync +vsync (80.0 kHz e)
[    77.182] (II) modeset(0): Modeline "1152x864"x75.0  108.00  1152 1216 1344 1600  864 865 868 900 +hsync +vsync (67.5 kHz e)
[    77.182] (II) modeset(0): Modeline "1024x768"x75.0   78.75  1024 1040 1136 1312  768 769 772 800 +hsync +vsync (60.0 kHz e)
[    77.182] (II) modeset(0): Modeline "1024x768"x60.0   65.00  1024 1048 1184 1344  768 771 777 806 -hsync -vsync (48.4 kHz e)
[    77.182] (II) modeset(0): Modeline "800x600"x75.0   49.50  800 816 896 1056  600 601 604 625 +hsync +vsync (46.9 kHz e)
[    77.182] (II) modeset(0): Modeline "800x600"x60.3   40.00  800 840 968 1056  600 601 605 628 +hsync +vsync (37.9 kHz e)
[    77.182] (II) modeset(0): Modeline "640x480"x75.0   31.50  640 656 720 840  480 481 484 500 -hsync -vsync (37.5 kHz e)
[    77.182] (II) modeset(0): Modeline "640x480"x59.9   25.18  640 656 752 800  480 490 492 525 -hsync -vsync (31.5 kHz e)
[    77.182] (II) modeset(0): Modeline "720x400"x70.1   28.32  720 738 846 900  400 412 414 449 -hsync +vsync (31.5 kHz e)
[    77.182] (II) modeset(0): EDID for output DP-1
[    77.182] (II) modeset(0): Output HDMI-1 connected
[    77.182] (II) modeset(0): Output DP-1 disconnected
[    77.183] (II) modeset(0): Using exact sizes for initial modes
[    77.183] (II) modeset(0): Output HDMI-1 using initial mode 1280x1024 +0+0
[    77.183] (==) modeset(0): Using gamma correction (1.0, 1.0, 1.0)
[    77.183] (==) modeset(0): DPI set to (96, 96)
[    77.183] (II) Loading sub module "fb"
[    77.183] (II) LoadModule: "fb"
[    77.183] (II) Module "fb" already built-in
[    77.183] (==) modeset(G0): Depth 24, (==) framebuffer bpp 32
[    77.183] (==) modeset(G0): RGB weight 888
[    77.183] (==) modeset(G0): Default visual is TrueColor
[    77.183] (II) Loading sub module "glamoregl"
[    77.183] (II) LoadModule: "glamoregl"
[    77.183] (II) Loading /usr/local/lib/xorg/modules/libglamoregl.so
[    77.183] (II) Module glamoregl: vendor="X.Org Foundation"
[    77.184]    compiled for 1.21.1.8, module version = 1.0.1
[    77.184]    ABI class: X.Org ANSI C Emulation, version 0.4
[    77.197] (II) modeset(G0): glamor X acceleration enabled on Mesa Intel(R) UHD Graphics 600 (GLK 2)
[    77.198] (II) modeset(G0): glamor initialized
[    77.198] (II) modeset(G0): Output HDMI-1-1 has no monitor section
[    77.198] (II) modeset(G0): Output DP-1-1 has no monitor section
[    77.199] (II) modeset(G0): EDID for output HDMI-1-1
[    77.199] (II) modeset(G0): Manufacturer: DEL  Model: 400d  Serial#: 1095914804
[    77.199] (II) modeset(G0): Year: 2005  Week: 38
[    77.199] (II) modeset(G0): EDID Version: 1.3
[    77.199] (II) modeset(G0): Digital Display Input
[    77.199] (II) modeset(G0): Max Image Size [cm]: horiz.: 38  vert.: 31
[    77.200] (II) modeset(G0): Gamma: 2.20
[    77.200] (II) modeset(G0): DPMS capabilities: StandBy Suspend Off
[    77.200] (II) modeset(G0): Supported color encodings: RGB 4:4:4 YCrCb 4:4:4
[    77.200] (II) modeset(G0): Default color space is primary color space
[    77.200] (II) modeset(G0): First detailed timing is preferred mode
[    77.200] (II) modeset(G0): redX: 0.640 redY: 0.330   greenX: 0.300 greenY: 0.600
[    77.200] (II) modeset(G0): blueX: 0.150 blueY: 0.060   whiteX: 0.313 whiteY: 0.329
[    77.200] (II) modeset(G0): Supported established timings:
[    77.200] (II) modeset(G0): 720x400@70Hz
[    77.200] (II) modeset(G0): 640x480@60Hz
[    77.200] (II) modeset(G0): 640x480@75Hz
[    77.200] (II) modeset(G0): 800x600@60Hz
[    77.200] (II) modeset(G0): 800x600@75Hz
[    77.200] (II) modeset(G0): 1024x768@60Hz
[    77.200] (II) modeset(G0): 1024x768@75Hz
[    77.200] (II) modeset(G0): 1280x1024@75Hz
[    77.200] (II) modeset(G0): Manufacturer's mask: 0
[    77.200] (II) modeset(G0): Supported standard timings:
[    77.200] (II) modeset(G0): #0: hsize: 1152  vsize 864  refresh: 75  vid: 20337
[    77.201] (II) modeset(G0): #1: hsize: 1280  vsize 1024  refresh: 60  vid: 32897
[    77.201] (II) modeset(G0): Supported detailed timing:
[    77.201] (II) modeset(G0): clock: 108.0 MHz   Image Size:  376 x 301 mm
[    77.201] (II) modeset(G0): h_active: 1280  h_sync: 1328  h_sync_end 1440 h_blank_end 1688 h_border: 0
[    77.201] (II) modeset(G0): v_active: 1024  v_sync: 1025  v_sync_end 1028 v_blanking: 1066 v_border: 0
[    77.201] (II) modeset(G0): Serial No: T611659DARU4
[    77.201] (II) modeset(G0): Monitor name: DELL 1905FP
[    77.201] (II) modeset(G0): Ranges: V min: 56 V max: 76 Hz, H min: 30 H max: 81 kHz, PixClock max 145 MHz
[    77.201] (II) modeset(G0): EDID (in hex):
[    77.201] (II) modeset(G0):  00ffffffffffff0010ac0d4034555241
[    77.201] (II) modeset(G0):  260f010380261f78eeee95a3544c9926
[    77.201] (II) modeset(G0):  0f5054a54b00714f8180010101010101
[    77.201] (II) modeset(G0):  010101010101302a009851002a403070
[    77.201] (II) modeset(G0):  1300782d1100001e000000ff00543631
[    77.201] (II) modeset(G0):  3136353944415255340a000000fc0044
[    77.201] (II) modeset(G0):  454c4c203139303546500a20000000fd
[    77.201] (II) modeset(G0):  00384c1e510e000a20202020202000c7
[    77.202] (II) modeset(G0): Printing probed modes for output HDMI-1-1
[    77.202] (II) modeset(G0): Modeline "1280x1024"x60.0  108.00  1280 1328 1440 1688  1024 1025 1028 1066 +hsync +vsync (64.0 kHz eP)
[    77.202] (II) modeset(G0): Modeline "1280x1024"x75.0  135.00  1280 1296 1440 1688  1024 1025 1028 1066 +hsync +vsync (80.0 kHz e)
[    77.202] (II) modeset(G0): Modeline "1152x864"x75.0  108.00  1152 1216 1344 1600  864 865 868 900 +hsync +vsync (67.5 kHz e)
[    77.202] (II) modeset(G0): Modeline "1024x768"x75.0   78.75  1024 1040 1136 1312  768 769 772 800 +hsync +vsync (60.0 kHz e)
[    77.202] (II) modeset(G0): Modeline "1024x768"x60.0   65.00  1024 1048 1184 1344  768 771 777 806 -hsync -vsync (48.4 kHz e)
[    77.202] (II) modeset(G0): Modeline "800x600"x75.0   49.50  800 816 896 1056  600 601 604 625 +hsync +vsync (46.9 kHz e)
[    77.202] (II) modeset(G0): Modeline "800x600"x60.3   40.00  800 840 968 1056  600 601 605 628 +hsync +vsync (37.9 kHz e)
[    77.202] (II) modeset(G0): Modeline "640x480"x75.0   31.50  640 656 720 840  480 481 484 500 -hsync -vsync (37.5 kHz e)
[    77.202] (II) modeset(G0): Modeline "640x480"x59.9   25.18  640 656 752 800  480 490 492 525 -hsync -vsync (31.5 kHz e)
[    77.202] (II) modeset(G0): Modeline "720x400"x70.1   28.32  720 738 846 900  400 412 414 449 -hsync +vsync (31.5 kHz e)
[    77.202] (II) modeset(G0): EDID for output DP-1-1
[    77.202] (==) modeset(G0): Using gamma correction (1.0, 1.0, 1.0)
[    77.202] (==) modeset(G0): DPI set to (96, 96)
[    77.202] (II) Loading sub module "fb"
[    77.202] (II) LoadModule: "fb"
[    77.202] (II) Module "fb" already built-in
[    77.202] (II) UnloadModule: "scfb"
[    77.203] (II) Unloading scfb
[    77.203] (II) UnloadModule: "vesa"
[    77.203] (II) Unloading vesa
[    77.382] (==) modeset(0): Backing store enabled
[    77.382] (==) modeset(0): Silken mouse enabled
[    77.484] (II) modeset(0): Initializing kms color map for depth 24, 8 bpc.
[    77.484] (==) modeset(0): DPMS enabled
[    77.485] (II) modeset(0): [DRI2] Setup complete
[    77.485] (II) modeset(0): [DRI2]   DRI driver: iris
[    77.485] (II) modeset(0): [DRI2]   VDPAU driver: va_gl
[    77.485] (EE) modeset(G0): drmSetMaster failed: Device busy
[    77.485] (EE)
Fatal server error:
[    77.485] (EE) AddScreen/ScreenInit failed for gpu driver 0 -1
[    77.485] (EE)
[    77.485] (EE)
Please consult the The X.Org Foundation support
         at http://wiki.x.org
 for help.
[    77.485] (EE) Please also check the log file at "/var/log/Xorg.0.log" for additional information.
[    77.485] (EE)
[    77.502] (EE) Server terminated with error (1). Closing log file.

Same result on a more recent -CURRENT, dated after the commit introducing this update.

LGTM, will commit later today.

LGTM but you need to bump PORTREVISION too.
And maybe merge D39887 in so we will not bump PORTREVISION twice ?

In D39825#907787, @imp wrote:

In D39825#907766, @manu wrote:

In D39825#907763, @imp wrote:

is there any way to leverage the firmware system to do this? Eg, when a firmware can't be found, then a script likes this asking for it by name. We can then use that to lookup what packageg to download, no?

I don't think that's possible as the firmware subsystem is all kernel and we can't call this script from it (well it's not good to to that :P)

They said that about device matching too :)

You can create a devd event to indicate firmware loading failure, and later use that to work things out. Short term the catalog may work (and that may be fine for 14.0), but longer term I think we'll need to cope with things like this.

In D39825#907763, @imp wrote:

is there any way to leverage the firmware system to do this? Eg, when a firmware can't be found, then a script likes this asking for it by name. We can then use that to lookup what packageg to download, no?

In D39825#907729, @bz wrote:

Can we do "bus"_"class"_"drivername" at least then -- though that doesn't work on the search parts so easily as you have to iterate over all the matching bus_class_* files.

That's what's done here no ?

I was under the assumption that pci_get_vendor() returns a vendor name and not a driver name?

In D39825#907702, @bz wrote:

In D39825#907514, @manu wrote:

In D39825#907512, @bz wrote:

I understand the idea. There's several drawback here for wifi:

(1) class information is (at times) useless for wifi cards - on one machine I see (for various vendors):

1 class=0x000280
3 class=0x028000
1 class=0xff0000

I don't see any problems here with intel cards.

This example is from Atheros (QCA) and Mediatek. I don't even know what 0xff0000 is for a class. 0x000280 pciconf calls "old" (or maybe just done wrongly?)

We can always expand the script later to check the pciids with another table if class matching wasn't a success.
The advantage of splitting by class is that we have smaller files to read/modify to add new devices.

(2) Certain cards have "oddities" in that they probe further; for Intel I added a sysctl to export that in order to create iwlwififw.4 which I'd probably use (to script) building the mapping table.

I'm not following.

There are cards which beyond PCI ID checks do further checks and depending on other parts switch firmware. So you can have same PCI ID checks and different firmware.

Remove arm_install_uboot_bbb too

In D39825#907512, @bz wrote:

I understand the idea. There's several drawback here for wifi:

(1) class information is (at times) useless for wifi cards - on one machine I see (for various vendors):

1 class=0x000280
3 class=0x028000
1 class=0xff0000

Do not loop to install packages.

I don't think that it make sense.
The SoC even if make by the same company don't have the same peripherals and are very different.

In D39825#906522, @lwhsu wrote:

Does it make sense if we move the mapping to an external place like download.freebsd.org or somewhere else? (We can even create firmware.freebsd.org if needed.)

I'll update UPDATING after that as this will likely break existing installation.

Looks similar to what I had locally.

Thanks, I had this too but didn't had time to submit the review.

LGTM but fix your commit message to say unused instead of used

In D39323#895586, @hselasky wrote:

I think doing a functional function trace is mandatory before this commit, seeing what code is calling into what code, and what locks are in use.

If you need help ask, @zlei .

What @gbe reports clearly shows we can do better than just pushing changes and waiting for others to fix them.

--HPS

What's the reason for armv6 ?

In D39283#895490, @val_packett.cool wrote:

Yeah, I solved the same problem in drm initially by writing a dummy driver too, but now it's been replaced by FB_FLAG_NOWRITE.
This is how we're doing it, it's a bit annoying that we have to check the driver and reach into its softc, ideally flags like that would be a more outer-level thing somehow (?)

In D39323#895452, @ray wrote:

Hi guys,
basically, I agree with Hans and not sure it will behave well w/o spinlock.
But that way VT will be faster and machine performance will be better.
/me vote to try

Last version still work on my laptop.

Fix the issue for me on my whiskeylake laptop.