Page MenuHomeFreeBSD

manu (Emmanuel Vadot)
User

Projects

User Details

User Since
Apr 24 2016, 4:47 PM (155 w, 6 d)

Recent Activity

Fri, Apr 19

manu accepted D19869: Add a new uefi-edk2-qemu port..

LGTM

Fri, Apr 19, 7:31 AM

Wed, Apr 17

manu committed rS346334: arm: allwinner: Fix audio for Allwinner H3/H5.
arm: allwinner: Fix audio for Allwinner H3/H5
Wed, Apr 17, 9:45 PM
manu closed D19910: Fix audio for Allwinner H3/H5.
Wed, Apr 17, 9:45 PM
manu committed rP499209: atf: Update to v2.1.
atf: Update to v2.1
Wed, Apr 17, 8:40 PM
manu committed rS346332: ofw_graph: Add functions for graph bindings.
ofw_graph: Add functions for graph bindings
Wed, Apr 17, 8:09 PM
manu closed D19877: ofw_graph: Add functions for graph bindings.
Wed, Apr 17, 8:09 PM

Tue, Apr 16

manu committed rS346305: arm: allwinner: Makes more device optional.
arm: allwinner: Makes more device optional
Tue, Apr 16, 10:43 PM
manu committed rS346298: config: Only warn if duplicate option/device comes from the same file.
config: Only warn if duplicate option/device comes from the same file
Tue, Apr 16, 8:08 PM
manu closed D19424: config: Only warn if duplicate option/device comes from the same file.
Tue, Apr 16, 8:08 PM
manu committed rS346297: arm: Order files.arm to have cloudabi and annapurna sections.
arm: Order files.arm to have cloudabi and annapurna sections
Tue, Apr 16, 8:06 PM
manu committed rS346295: arm: Add kern_clocksource.c directly in files.arm.
arm: Add kern_clocksource.c directly in files.arm
Tue, Apr 16, 8:04 PM
manu committed rS346293: allwinner: clk: Garbage collect old clock implementation.
allwinner: clk: Garbage collect old clock implementation
Tue, Apr 16, 7:38 PM
manu committed rP499100: u-boot: Fix efi booting for arm32.
u-boot: Fix efi booting for arm32
Tue, Apr 16, 5:10 PM
manu committed rS346272: aw_syscon: Add a new compatible.
aw_syscon: Add a new compatible
Tue, Apr 16, 12:40 PM
manu committed rS346271: aw_rtc: Register the clocks.
aw_rtc: Register the clocks
Tue, Apr 16, 12:39 PM

Mon, Apr 15

manu added a comment to D19869: Add a new uefi-edk2-qemu port..

There is a lots of portlint error :
FATAL: Makefile: extra item "FLAVORS" placed in the MAINTAINER section.
FATAL: Makefile: extra item "x86_64_PKGNAMESUFFIX" placed in the MAINTAINER section.
FATAL: Makefile: extra item "i386_PKGNAMESUFFIX" placed in the MAINTAINER section.
WARN: Makefile: COMMENT is set externally to this port's Makefile, but this port is not configured as a slave port.
FATAL: Makefile: extra item "MAINTAINER" placed in the LICENSE section.
FATAL: Makefile: extra item "COMMENT" placed in the LICENSE section.
WARN: Makefile: "LICENSE" has to appear earlier.
WARN: Makefile: "ONLY_FOR_ARCHS" has to appear earlier.
WARN: Makefile: "BUILD_DEPENDS" has to appear earlier.
WARN: Makefile: "USES" has to appear earlier.
5 fatal errors and 5 warnings found.

Mon, Apr 15, 5:35 PM
manu added inline comments to D19910: Fix audio for Allwinner H3/H5.
Mon, Apr 15, 5:13 PM

Wed, Apr 10

manu committed rP498603: sysutils/u-boot: Update to 2019.04.
sysutils/u-boot: Update to 2019.04
Wed, Apr 10, 9:17 PM
manu committed rS346099: arm: dtb: Compile the Linux DTS for pandaboards.
arm: dtb: Compile the Linux DTS for pandaboards
Wed, Apr 10, 8:11 PM
manu committed rS346096: arm: kernel: Remove old kernel configs.
arm: kernel: Remove old kernel configs
Wed, Apr 10, 7:27 PM
manu committed rS346095: arm: dts: Remove some old DTS.
arm: dts: Remove some old DTS
Wed, Apr 10, 7:18 PM
manu created D19877: ofw_graph: Add functions for graph bindings.
Wed, Apr 10, 7:03 PM
manu committed rS346092: Import DTS files from Linux 5.0.
Import DTS files from Linux 5.0
Wed, Apr 10, 6:16 PM
manu committed rS346090: Tag import of DTS files from Linux 5.0.
Tag import of DTS files from Linux 5.0
Wed, Apr 10, 5:59 PM
manu committed rS346089: Import DTS files from Linux 5.0.
Import DTS files from Linux 5.0
Wed, Apr 10, 5:57 PM
manu updated subscribers of D19869: Add a new uefi-edk2-qemu port..
In D19869#426773, @jhb wrote:

Or instead of slave ports, flavors, where each target arch was a separate flavor. In that case you would keep the port name as it was and just append ARCH to the page name as it's flavor name.

Wed, Apr 10, 5:39 PM
manu requested changes to D19869: Add a new uefi-edk2-qemu port..

As said on irc we want multiple version of this package for each arch.
Since we also want all the edk2 arch available for all FreeBSD arch the best way is to convert the port to a master/slave scheme.
You will have sysutils/uefi-edk2-qemu as the master port and sysutils/uefi-edk2-qemu-${ARCH} for each available arch.
The slave ports will select which compiler to use based on the host and target.

Wed, Apr 10, 5:13 PM
manu added a reviewer for D19869: Add a new uefi-edk2-qemu port.: manu.
Wed, Apr 10, 2:48 PM

Mon, Apr 8

manu abandoned D13619: axp209: move driver to sys/dev/pmic.
Mon, Apr 8, 4:08 PM

Fri, Apr 5

manu committed rS345951: twsi: Use config_intrhook_oneshot instead of config_intrhook_establish.
twsi: Use config_intrhook_oneshot instead of config_intrhook_establish
Fri, Apr 5, 3:53 PM
manu committed rS345948: twsi: Add interrupt mode.
twsi: Add interrupt mode
Fri, Apr 5, 2:44 PM

Wed, Apr 3

manu accepted D19814: Use 'phy-handle' in FDT to find PHY address.

LGTM.

Wed, Apr 3, 8:31 PM
manu added inline comments to D19814: Use 'phy-handle' in FDT to find PHY address.
Wed, Apr 3, 7:21 PM
manu added inline comments to D19814: Use 'phy-handle' in FDT to find PHY address.
Wed, Apr 3, 7:14 PM
manu added inline comments to D19814: Use 'phy-handle' in FDT to find PHY address.
Wed, Apr 3, 7:11 PM

Mon, Apr 1

manu added inline comments to D19498: loader: Add pnp functions for autoloading modules based on linker.hints.
Mon, Apr 1, 3:18 PM

Fri, Mar 29

manu committed rS345711: arm: allwinner: clk: Fix nm_recalc.
arm: allwinner: clk: Fix nm_recalc
Fri, Mar 29, 7:40 PM
manu updated the diff for D19424: config: Only warn if duplicate option/device comes from the same file.
Fri, Mar 29, 9:29 AM

Wed, Mar 27

manu committed rS345584: pkgbase: Use uname as ABI_FILE.
pkgbase: Use uname as ABI_FILE
Wed, Mar 27, 5:56 PM

Mar 21 2019

manu added a comment to D16892: add pci support at rt1310.

Herald doesn't like this ...
Consider it ok from me for dts changes.

Mar 21 2019, 7:32 AM
manu removed a reviewer for D16892: add pci support at rt1310: manu.
Mar 21 2019, 7:32 AM
manu added a comment to D16892: add pci support at rt1310.

Remove myself from blocking reviewer.

Mar 21 2019, 7:31 AM
manu removed a reviewer for D16892: add pci support at rt1310: manu.
Mar 21 2019, 7:31 AM
manu added a comment to D15955: Discover cards on boot.
In D15955#357900, @manu wrote:

Quoting myself :
20:51 < manu> I'm not sure this is the right solution
20:52 < manu
> it seems that it's cam only code
20:52 < manu__> so I don't understand why it's not in a generic function

The correct solution is implementing proper card insertion detection. This is, however, out of scope for this change. I'm just replicating the way it's implemented for mmc(4) in this driver, for now.

Mar 21 2019, 2:03 AM
manu committed rS345358: MFC r345159:.
MFC r345159:
Mar 21 2019, 1:16 AM

Mar 17 2019

manu added inline comments to D19588: Add a new efi-update-loader script and associated man page.
Mar 17 2019, 3:21 AM

Mar 14 2019

manu committed rS345159: pkgbase: Use uname as ABI_FILE.
pkgbase: Use uname as ABI_FILE
Mar 14 2019, 10:08 PM

Mar 8 2019

manu accepted D19036: Update mvneta/e6000sw for new style Distributed Switch Architecture Device Tree Bindings.
In D19036#417431, @mw wrote:
In D19036#417396, @manu wrote:

It looks ok for me now but could you please separate the change for drivers and GENERIC kernel config ?
Thanks.

I'll do this when commiting, no need to resubmit. I need to only check if clearfog continues to work with this.

Mar 8 2019, 8:11 AM · network, ARM, arm64

Mar 7 2019

manu added a comment to D19036: Update mvneta/e6000sw for new style Distributed Switch Architecture Device Tree Bindings.

It looks ok for me now but could you please separate the change for drivers and GENERIC kernel config ?
Thanks.

Mar 7 2019, 9:31 PM · network, ARM, arm64
manu committed rS344895: arm64: allwinner: a64: Add TCON clock.
arm64: allwinner: a64: Add TCON clock
Mar 7 2019, 7:32 PM
manu committed rS344894: arm64: allwinner: Add CCU DE2.
arm64: allwinner: Add CCU DE2
Mar 7 2019, 7:30 PM
manu committed rS344893: arm: allwinner: Fix NM clock recalc.
arm: allwinner: Fix NM clock recalc
Mar 7 2019, 7:28 PM
manu created D19498: loader: Add pnp functions for autoloading modules based on linker.hints.
Mar 7 2019, 7:00 PM
manu committed rS344892: stand/common/module: Apply style(9).
stand/common/module: Apply style(9)
Mar 7 2019, 6:57 PM

Mar 1 2019

manu added inline comments to D19424: config: Only warn if duplicate option/device comes from the same file.
Mar 1 2019, 5:45 PM
manu added inline comments to D19424: config: Only warn if duplicate option/device comes from the same file.
Mar 1 2019, 5:25 PM
manu created D19424: config: Only warn if duplicate option/device comes from the same file.
Mar 1 2019, 5:24 PM
manu committed rS344699: arm64: rockchip: rk3399_pll: Fix the recalc function.
arm64: rockchip: rk3399_pll: Fix the recalc function
Mar 1 2019, 1:05 PM

Feb 28 2019

manu accepted D19404: Add hw.ncpu to arm64.
Feb 28 2019, 1:38 PM
manu accepted D19389: Split out the attachment from the generic-ehci driver.

LGTM

Feb 28 2019, 1:27 PM

Feb 27 2019

manu committed rS344638: Fix armv6/armv7 build after the move from xhci_mv to generic_xhci.
Fix armv6/armv7 build after the move from xhci_mv to generic_xhci
Feb 27 2019, 10:01 PM
manu committed rS344635: drm: Remove empty directories.
drm: Remove empty directories
Feb 27 2019, 9:11 PM
manu added a comment to D19335: Add USB 3.0 support for Rockchip RK3328/RK3399 SoC.

I've just commited my mv_xhci to generic_xhci patch, now we need a proper dwc3 driver.

Feb 27 2019, 9:08 PM · arm64
manu committed rS344634: xhci_mv: Move the driver to generic_xhci.
xhci_mv: Move the driver to generic_xhci
Feb 27 2019, 9:04 PM
manu committed rS344633: usb_nop_xceiv: Add support for this pseudo device.
usb_nop_xceiv: Add support for this pseudo device
Feb 27 2019, 8:52 PM
manu added inline comments to D19335: Add USB 3.0 support for Rockchip RK3328/RK3399 SoC.
Feb 27 2019, 5:51 PM · arm64
manu added a comment to D19336: Enable SD/MMC (microSD and eMMC controllers) on the Rockchip RK3399 SoC.

Just looking at https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt?id=4436a3711e3249840e0679e92d3c951bcaf25515#n64
The driver needs to handle phy (and we need a phy driver), the arasan,soc-ctl-syscon property (whatever it is used for) and deal with clocks.
So for me the mmc patch is a no go for now.
I've commited my sd patch in r344626 and r344627

Feb 27 2019, 5:35 PM · arm64
manu committed rS344627: mmc: dwmmc: Match on "rockchip,rk3288-dw-mshc" compatible.
mmc: dwmmc: Match on "rockchip,rk3288-dw-mshc" compatible
Feb 27 2019, 5:30 PM
manu committed rS344626: arm64: rockchip: rk3399_clk: Add sd clock definitions.
arm64: rockchip: rk3399_clk: Add sd clock definitions
Feb 27 2019, 5:29 PM
manu added a comment to D19389: Split out the attachment from the generic-ehci driver.

This miss all the ext_resources stuff (phy, clocks) but that could be added later I guess.
Don't you need to DECLARE_CLASS and DEFINE_CLASS_0 ? (This stuff was always obscure to me ...)
Otherwise looks good for me.

Feb 27 2019, 5:13 PM
manu committed rS344623: arm64: rockchip: clk_pll: Multiple improvement.
arm64: rockchip: clk_pll: Multiple improvement
Feb 27 2019, 2:20 PM
manu added a comment to D19380: build SD images for boards.

I don't think this is a good approach.
My goal for this is :

Feb 27 2019, 11:21 AM

Feb 26 2019

manu committed rS344590: arm64: rockchip: rk3399_pll: Fix copy paste.
arm64: rockchip: rk3399_pll: Fix copy paste
Feb 26 2019, 5:20 PM
manu committed rS344589: arm64: rockchip: rk3399_pll: Switch to slow mode when changing the freq.
arm64: rockchip: rk3399_pll: Switch to slow mode when changing the freq
Feb 26 2019, 5:09 PM
manu committed rS344585: arm64: rockchip: rk_pinctrl: Fix two banks in RK3328.
arm64: rockchip: rk_pinctrl: Fix two banks in RK3328
Feb 26 2019, 3:29 PM
manu committed rS344580: arm64: rockchip: rk805: Map the regulator.
arm64: rockchip: rk805: Map the regulator
Feb 26 2019, 1:18 PM
manu committed rS344579: arm64: rockchip: rk805: Add LDO regulators.
arm64: rockchip: rk805: Add LDO regulators
Feb 26 2019, 1:17 PM
manu committed rS344578: arm64: rockchip: rk3328_pll: Multiple improvement.
arm64: rockchip: rk3328_pll: Multiple improvement
Feb 26 2019, 1:16 PM
manu committed rS344577: arm64: rockchip: clk: ARM CLK improvement.
arm64: rockchip: clk: ARM CLK improvement
Feb 26 2019, 1:15 PM
manu committed rS344576: arm64: rockchip: clk: rk_clk_composite: Properly use the mask bits.
arm64: rockchip: clk: rk_clk_composite: Properly use the mask bits
Feb 26 2019, 1:15 PM

Feb 25 2019

manu added a comment to D19336: Enable SD/MMC (microSD and eMMC controllers) on the Rockchip RK3399 SoC.

You missed the gate for hclk_sdmmc (in CRU_CLKGATE_CON33) and maybe more.
The SD clocks matches what I have in my patch locally.
With r344527 commited sd is faster on RK3328, I'll test on RK3399 and commit my patch after.

Feb 25 2019, 5:57 PM · arm64
manu committed rS344527: arm64: rockchip: clk: Set the write mask when setting the clock mux.
arm64: rockchip: clk: Set the write mask when setting the clock mux
Feb 25 2019, 5:40 PM
manu committed rP493851: sysutils/dtc: Update to 1.4.7.
sysutils/dtc: Update to 1.4.7
Feb 25 2019, 12:13 PM
manu added a comment to D19336: Enable SD/MMC (microSD and eMMC controllers) on the Rockchip RK3399 SoC.

I have a patch locally that enable sd on rk3399, but I wanted to make the driver better before committing. I haven't check your clocks in this patch.
If you didn't test eMMC don't add it to your patch, I haven't looked at the arasan controller yet but I'm sure that if there is a different compatible it's because we need to do more work than just matching on the compatible.
Thanks

Feb 25 2019, 10:14 AM · arm64
manu added a comment to D19335: Add USB 3.0 support for Rockchip RK3328/RK3399 SoC.

I have a local patch that I need to finish to do the switch from marvell xhci to generic-xhci, it also handle the phy properly. So I will try to do that this week and you can then rebase your work on it.
For the snps,dwc3 I think the better way is to add a different file, it's a big controller that can do a lot of thing and this doesn't belong in generic-xhci.
You also need to handle the drmode, on the RockPro64 you have two dwc3, one in host mode and one in otg mode.

Feb 25 2019, 10:11 AM · arm64

Feb 18 2019

manu committed rP493265: New port: sysutils/u-boot-clearfog.
New port: sysutils/u-boot-clearfog
Feb 18 2019, 3:02 PM
manu closed D19230: New port: sysutils/u-boot-clearfog.
Feb 18 2019, 3:02 PM
manu accepted D19230: New port: sysutils/u-boot-clearfog.
Feb 18 2019, 3:00 PM
manu added inline comments to D19046: Rockchip RK3399 PWM driver.
Feb 18 2019, 2:03 PM · arm64
manu added a comment to D16409: Minor cleanup of sysutils/u-boot patches.

The changes were commited a while ago.

Feb 18 2019, 8:36 AM

Feb 16 2019

manu accepted D19212: Add sysctl for battery charging current.

Thanks, looks good for me.

Feb 16 2019, 4:42 PM

Feb 15 2019

manu accepted D19126: Fix a regression for devel/amd64-gcc introduced in r488642..
Feb 15 2019, 9:59 PM
manu accepted D19125: devel/arm-none-eabi-gcc: Add missing plist entries..
Feb 15 2019, 9:50 PM
manu accepted D19196: Per discussions on arch@ and elsewhere, retire drm module / drives..

accept with just the comment on removing MODULE_DRM2 from __DEFAULT_NO_OPTIONS

Feb 15 2019, 9:08 AM

Feb 14 2019

manu added inline comments to D19196: Per discussions on arch@ and elsewhere, retire drm module / drives..
Feb 14 2019, 10:10 PM

Feb 13 2019

manu added inline comments to D19036: Update mvneta/e6000sw for new style Distributed Switch Architecture Device Tree Bindings.
Feb 13 2019, 1:12 PM · network, ARM, arm64

Feb 11 2019

manu accepted D19145: Expose AXP803 related sensors values via sysctl.
Feb 11 2019, 2:23 PM
manu added inline comments to D19145: Expose AXP803 related sensors values via sysctl.
Feb 11 2019, 1:44 PM

Feb 10 2019

manu committed rS343950: arm64: Fix compile when removing SOC_ROCKCHIP_* options.
arm64: Fix compile when removing SOC_ROCKCHIP_* options
Feb 10 2019, 8:14 AM

Feb 9 2019

manu accepted D19116: AXP803 related events support.
Feb 9 2019, 1:52 PM