- User Since
- Apr 24 2016, 4:47 PM (263 w, 1 d)
Fri, May 7
LGTM, just one comment and we're good.
Thu, May 6
The clocks are the same for rk805 so please prefix all function rk805 instead of rk808.
Otherwise looks good.
Wed, May 5
Now they are parsed but you don't use them.
See https://cgit.freebsd.org/src/commit/sys/arm/allwinner/aw_mmc.c?id=9ed8321078444aea2a90a361f91e54065d5daf21 for how to use it.
I don't think it make much sense to commit that without all formats supported and clocks, efifb should be good enough instead. (and yes I know that it's not on the mac blah that you're working on :P )
Tue, May 4
Mon, May 3
I'll also add a note in UPDATING that for pkgbase users they will need to pkg install -f FreeBSD-openssl before pkg upgrade.
Otherwise everything goes boom.
Add libcrypto too
I forgot libcrypto, will update later today.
Sun, May 2
Add openssl comment and desc in Makefile.package
Maybe it would be simpler and more clear to have a new memory type for struct resource for PCI config region that all the bus_* routines will know ?
Sat, May 1
Do you plan to continue working on this ?
Thu, Apr 29
Wed, Apr 28
Tue, Apr 27
Mon, Apr 26
There is a property in the DTS for that :
And we parse this in :
But since the docs about this part isn't up to date just wait that someone from docs review this.
Same comment as Hans :)
And please bump FreeBSD_version so we can check this in the drm-devel-kmod in the near futur.
Sun, Apr 25
I don't remember why I did this but yes this solve some dependencies issues.
Thu, Apr 22
Wed, Apr 21
Don't forget the Approved by: manu (mentor) in the commit.
Tue, Apr 20
What's the difference between this and making an non-optional requirement for the file ?
Is it just to have a nicer error message than a linker error ?
Looking at D29849 it seems that the same thing could be achieve by adding "iflib" in every em(4) related file and since em(4)
needs iflib I think that's the proper way of "fixing" this problem.
Mon, Apr 19
Fri, Apr 16
We talked on irc but here is the brief version :
Thu, Apr 15
Wed, Apr 14
For the 1.2V report it's probably the same problem as the one fixed by 1a96c1434f4b4487126f13ede29e67ad44a8776a
What is the resulting chosen mode ? You can query with camcontrol
I have no problem with DDR52 on all my boards and I don't remember if anything else was missing to have proper hs200 on all Allwinner boards.
Tue, Apr 13
Mon, Apr 12
Sun, Apr 11
Apr 9 2021
For Submitted-by you can git commit --author=...
Apr 7 2021
Apr 6 2021
Small nits but otherwise lgtm
Apr 2 2021
I'll leave this for a few days in case someone have an objection.
Apr 1 2021
That doesn't seems to be specific to the Apple hardware but to the intel controller.
Linux notes that after changing CS one should wait 2 clock cycles (spi controller clock).
Our driver doesn't seems to do anything about clock and just hardcode based on the one found on the MinowBoard.
Anyway, that seems more controller specific than SPI specific so I'm not sure that this is the correct approach.
There don't seems to be drm firmware with '-' in it btw.
Mar 30 2021
Mar 29 2021
Mar 28 2021
Mar 27 2021
Obtain from linux seems a bit much for me, it's just pci id that you're adding.
Otherwise looks good.