Page MenuHomeFreeBSD

manu (Emmanuel Vadot)
User

Projects (7)

User Details

User Since
Apr 24 2016, 4:47 PM (283 w, 22 h)

Recent Activity

Fri, Sep 24

manu accepted D32092: LinuxKPI: install linux/poison.h header.
Fri, Sep 24, 10:12 AM
manu added a comment to D32092: LinuxKPI: install linux/poison.h header.

I'd like you to add a proper 2-clause BSD license there.

Fri, Sep 24, 10:12 AM

Thu, Sep 23

manu accepted D32069: LinuxKPI: stub anon_inode_getfile.
Thu, Sep 23, 5:48 AM
manu accepted D32067: LinuxKPI: Call release handler when file is destroyed with fput().
Thu, Sep 23, 5:46 AM
manu accepted D32066: LinuxKPI: allocate current before taking shrinkers lock.
Thu, Sep 23, 5:45 AM

Wed, Sep 22

manu added a comment to D30387: Make the code consistent with the comments.

I'm not against this being commited but I'd like to understand why it's needed.
IIRC @mmel said this has to do with bounce buffer (and the comment seems to agree, is there somewhere I can read about this ?

Wed, Sep 22, 7:35 AM

Tue, Sep 21

manu committed R10:559f60214b74: dwmmc: Remove dwmmc_setup_bus call from start_cmd (authored by manu).
dwmmc: Remove dwmmc_setup_bus call from start_cmd
Tue, Sep 21, 4:18 PM
manu committed R10:af32e2cc32b2: dwmmc: Properly implement power_off/power_up (authored by manu).
dwmmc: Properly implement power_off/power_up
Tue, Sep 21, 4:18 PM

Fri, Sep 17

manu accepted D31999: LinuxKPI: Add more #ifdef VM_MEMATTR_WRITE_COMBINING guards.
Fri, Sep 17, 6:06 AM

Wed, Sep 15

manu accepted D31972: Sync 13-STABLE and 14-CURRENT images links with reality.

LGTM

Wed, Sep 15, 6:28 PM
manu committed R10:78bf40e10c5a: arm: rockchip: rk3288: Use the macros that already exists in rk_cru.h (authored by manu).
arm: rockchip: rk3288: Use the macros that already exists in rk_cru.h
Wed, Sep 15, 6:12 PM
manu committed R10:548a706608d7: arm64: rockchip: rk3328: Add watchdog clock (authored by manu).
arm64: rockchip: rk3328: Add watchdog clock
Wed, Sep 15, 5:11 PM
manu committed R10:cc2f9bbbad3b: arm64: rockchip: rk3328: Finish implementing clocks (authored by manu).
arm64: rockchip: rk3328: Finish implementing clocks
Wed, Sep 15, 4:53 PM
manu committed R10:deff1fb3dccb: arm64: rockchip: clk: Add MUXRAW macros (authored by manu).
arm64: rockchip: clk: Add MUXRAW macros
Wed, Sep 15, 4:53 PM
manu committed R10:731e418bd748: arm64: rockchip: clk_mux: Add support for mux in GRF type clock (authored by manu).
arm64: rockchip: clk_mux: Add support for mux in GRF type clock
Wed, Sep 15, 4:53 PM

Tue, Sep 14

manu committed R11:72629b6891c8: ports-mgmt/pkg-devel: Fix packaging from poudriere (authored by manu).
ports-mgmt/pkg-devel: Fix packaging from poudriere
Tue, Sep 14, 11:52 AM
manu committed R11:6198006bca7f: ports-mgmt/pkg-devel: Fix package when SAN is on (authored by manu).
ports-mgmt/pkg-devel: Fix package when SAN is on
Tue, Sep 14, 10:53 AM
manu committed R11:4f3befc2a362: ports-mgmt/pkg-devel: Add an option for building with sanitizer (authored by manu).
ports-mgmt/pkg-devel: Add an option for building with sanitizer
Tue, Sep 14, 10:10 AM

Mon, Sep 13

manu accepted D31942: <linux/overflow.h>: Don't use __has_builtin()..

I was asked to add those checks in D25015 but if all the compiler that we support have those it's good for me (that was my guess at the time but didn't bother to check).

Mon, Sep 13, 6:33 PM

Thu, Sep 9

manu committed R10:06cce53d5623: pkgbase: Move back mlxcontrol in the default package (authored by manu).
pkgbase: Move back mlxcontrol in the default package
Thu, Sep 9, 6:17 AM

Wed, Sep 8

manu added a comment to D31134: Add FriendlyArm NanoPi R4S config for generation of release images.

IMHO it would be better to not add new images for a specific board but instead do a GENERICSD image like I did for armv7.
Something with a GPT scheme and the same gap between start of card and first partition like ROCKPRO64 would suit any board compliant with GPT (all but earlier RPI4 and all RPI3).
Also since there is still some problem with the MAC address like you said that will be a very bad first impression for someone who tries the image.

Wed, Sep 8, 11:56 AM

Tue, Sep 7

manu committed R10:b5be5c35dbaf: pkgbase: Create a FreeBSD-ftp package (authored by manu).
pkgbase: Create a FreeBSD-ftp package
Tue, Sep 7, 9:53 AM
manu committed R10:88ba5e895551: pkgbase: Create a vt-data package (authored by manu).
pkgbase: Create a vt-data package
Tue, Sep 7, 9:53 AM
manu committed R10:db953e8b9775: pkgbase: Create a FreeBSD-hyperv package (authored by manu).
pkgbase: Create a FreeBSD-hyperv package
Tue, Sep 7, 9:53 AM
manu committed R10:d8d41d3b8429: pkgbase: Remove libefivar package and add a efi-tools one (authored by manu).
pkgbase: Remove libefivar package and add a efi-tools one
Tue, Sep 7, 9:53 AM
manu committed R10:dfa9131d7091: pkgbase: Remove FreeBSD-libregex package (authored by manu).
pkgbase: Remove FreeBSD-libregex package
Tue, Sep 7, 9:53 AM
manu committed R10:a30235a4c360: pkgbase: Create a FreeBSD-kerberos package (authored by manu).
pkgbase: Create a FreeBSD-kerberos package
Tue, Sep 7, 9:53 AM
manu committed R10:30975efbaff0: pkgbase: Put libbsdxml in FreeBSD-runtime (authored by manu).
pkgbase: Put libbsdxml in FreeBSD-runtime
Tue, Sep 7, 9:53 AM
manu closed D31794: pkgbase: Create a FreeBSD-ftp package.
Tue, Sep 7, 9:53 AM
manu closed D31803: pkgbase: Remove libefivar package and add a efi-tools one.
Tue, Sep 7, 9:53 AM
manu committed R10:cab6a39d7b34: pkgbase: Create a FreeBSD-rdma package (authored by manu).
pkgbase: Create a FreeBSD-rdma package
Tue, Sep 7, 9:53 AM
manu closed D31805: pkgbase: Create a FreeBSD-hyperv package.
Tue, Sep 7, 9:53 AM
manu committed R10:27a7ae0ce00f: pkgbase: Create a syscons-data package (authored by manu).
pkgbase: Create a syscons-data package
Tue, Sep 7, 9:53 AM
manu closed D31802: pkgbase: Remove FreeBSD-libregex package.
Tue, Sep 7, 9:53 AM
manu committed R10:a3266ba2697a: pkgbase: Create a FreeBSD-dwatch package (authored by manu).
pkgbase: Create a FreeBSD-dwatch package
Tue, Sep 7, 9:53 AM
manu closed D31801: pkgbase: Create a FreeBSD-kerberos package.
Tue, Sep 7, 9:53 AM
manu committed R10:80645e1ce557: pkgbase: Create a mlx-tools package (authored by manu).
pkgbase: Create a mlx-tools package
Tue, Sep 7, 9:53 AM
manu closed D31800: pkgbase: Put libbsdxml in FreeBSD-runtime.
Tue, Sep 7, 9:53 AM
manu committed R10:b8876cac2d23: pkgbase: Create a cxgbe-tools package (authored by manu).
pkgbase: Create a cxgbe-tools package
Tue, Sep 7, 9:53 AM
manu committed R10:0818f499bc28: pkgbase: Move spppcontrol to FreeBSD-ppp (authored by manu).
pkgbase: Move spppcontrol to FreeBSD-ppp
Tue, Sep 7, 9:53 AM
manu closed D31799: pkgbase: Create a FreeBSD-rdma package.
Tue, Sep 7, 9:53 AM
manu committed R10:c7fd29f0f29a: pkgbase: Create a FreeBSD-telnet package (authored by manu).
pkgbase: Create a FreeBSD-telnet package
Tue, Sep 7, 9:53 AM
manu closed D31798: pkgbase: Create a syscons-data package.
Tue, Sep 7, 9:53 AM
manu closed D31797: pkgbase: Create a vt-data package.
Tue, Sep 7, 9:53 AM
manu committed R10:d22072a7d5e6: pkgbase: Create a FreeBSD-ggate package (authored by manu).
pkgbase: Create a FreeBSD-ggate package
Tue, Sep 7, 9:53 AM
manu closed D31796: pkgbase: Create a FreeBSD-dwatch package.
Tue, Sep 7, 9:53 AM
manu closed D31795: pkgbase: Create a mlx-tools package.
Tue, Sep 7, 9:53 AM
manu closed D31793: pkgbase: Create a cxbge-tools package.
Tue, Sep 7, 9:52 AM
manu closed D31792: pkgbase: Move spppcontrol to FreeBSD-ppp.
Tue, Sep 7, 9:52 AM
manu closed D31791: pkgbase: Create a FreeBSD-telnet package.
Tue, Sep 7, 9:52 AM
manu closed D31790: pkgbase: Create a FreeBSD-ggate package.
Tue, Sep 7, 9:52 AM

Thu, Sep 2

manu added a comment to D31299: Pine Quartz64 clock driver.
In D31299#707789, @sos wrote:

No you most certainly can not return EINVAL when it is zero :) it will panic the kernel: panic: clknode_refresh_cache failed for 'sclk_audpwm_frac
But returning 0 and a frequency of zero will make it "do the right thing" later when the clock comes available.
Have you tried it on your board ?

Thu, Sep 2, 3:59 PM
manu requested review of D31805: pkgbase: Create a FreeBSD-hyperv package.
Thu, Sep 2, 3:16 PM
manu updated the diff for D31794: pkgbase: Create a FreeBSD-ftp package.

Really upload correct diff.

Thu, Sep 2, 3:15 PM
manu added a comment to D31794: pkgbase: Create a FreeBSD-ftp package.

Meh, didn't split the commit, be right back :)

Thu, Sep 2, 3:10 PM
manu updated the diff for D31794: pkgbase: Create a FreeBSD-ftp package.

Upload correct diff.

Thu, Sep 2, 3:09 PM
manu added a comment to D31791: pkgbase: Create a FreeBSD-telnet package.

Similar comment as another review, I wonder if we shouldn't drop telnetd entirely. But this makes sense for now.

Thu, Sep 2, 2:55 PM
manu updated the diff for D31795: pkgbase: Create a mlx-tools package.

Fix the nfs comment.

Thu, Sep 2, 2:52 PM
manu requested review of D31803: pkgbase: Remove libefivar package and add a efi-tools one.
Thu, Sep 2, 2:51 PM
manu requested review of D31802: pkgbase: Remove FreeBSD-libregex package.
Thu, Sep 2, 2:51 PM
manu requested review of D31801: pkgbase: Create a FreeBSD-kerberos package.
Thu, Sep 2, 2:50 PM
manu requested review of D31800: pkgbase: Put libbsdxml in FreeBSD-runtime.
Thu, Sep 2, 2:49 PM
manu requested review of D31799: pkgbase: Create a FreeBSD-rdma package.
Thu, Sep 2, 2:49 PM
manu requested review of D31798: pkgbase: Create a syscons-data package.
Thu, Sep 2, 2:48 PM
manu requested review of D31797: pkgbase: Create a vt-data package.
Thu, Sep 2, 2:48 PM
manu requested review of D31796: pkgbase: Create a FreeBSD-dwatch package.
Thu, Sep 2, 2:47 PM
manu requested review of D31795: pkgbase: Create a mlx-tools package.
Thu, Sep 2, 2:46 PM
manu requested review of D31794: pkgbase: Create a FreeBSD-ftp package.
Thu, Sep 2, 2:45 PM
manu requested review of D31793: pkgbase: Create a cxbge-tools package.
Thu, Sep 2, 2:45 PM
manu requested review of D31792: pkgbase: Move spppcontrol to FreeBSD-ppp.
Thu, Sep 2, 2:44 PM
manu requested review of D31791: pkgbase: Create a FreeBSD-telnet package.
Thu, Sep 2, 2:43 PM
manu requested review of D31790: pkgbase: Create a FreeBSD-ggate package.
Thu, Sep 2, 2:43 PM

Aug 28 2021

manu accepted D31706: sh: improve emacs mode.

Not tested but looks good :)

Aug 28 2021, 1:23 PM

Aug 26 2021

manu added a comment to D31598: mmc_helper: add mmc_helper and rename mmc_fdt_helper to mmc_helper.

I've added the macro. Should I revert the changes in other drivers? I didn't do it now, cause I think this could encourage people to use the new structure.

Aug 26 2021, 8:34 AM
manu accepted D31598: mmc_helper: add mmc_helper and rename mmc_fdt_helper to mmc_helper.
Aug 26 2021, 8:34 AM

Aug 25 2021

manu added a comment to D31598: mmc_helper: add mmc_helper and rename mmc_fdt_helper to mmc_helper.

I can add a macro like this somewhere in mmc_fdt_helper.h header, to keep it backwards compatible.

#define mmc_fdt_helper mmc_helper
Aug 25 2021, 2:41 PM
manu accepted D31597: device: add device_get_property and device_has_property.
Aug 25 2021, 2:40 PM
manu accepted D31673: LinuxKPI: Remove FreeBSD struct resource from all LKPI headers.
Aug 25 2021, 9:22 AM
manu accepted D31672: LinuxKPI: Implement get_file_rcu().
Aug 25 2021, 9:20 AM
manu accepted D31674: LinuxKPI: implement _IOC_TYPE and _IOC_NR macros in linux/ioctl.h.
Aug 25 2021, 9:19 AM

Aug 19 2021

manu committed R10:c432a007529f: pkgbase: Fix cherry-pick conflict (authored by manu).
pkgbase: Fix cherry-pick conflict
Aug 19 2021, 7:11 AM
manu committed R10:17fe7de111dd: pkgbase: Fix building out-of-tree manual pages (authored by jkim).
pkgbase: Fix building out-of-tree manual pages
Aug 19 2021, 7:09 AM

Aug 18 2021

manu added a comment to D31598: mmc_helper: add mmc_helper and rename mmc_fdt_helper to mmc_helper.

Code looks ok but that will break out of tree drivers (even if I'm sure that no such out of tree drivers using mmc_fdt_helpers exists) so I'm not too sure about this change.

Aug 18 2021, 5:46 PM
manu accepted D31597: device: add device_get_property and device_has_property.

LGTM but that should be documented somewhere (tm)

Aug 18 2021, 5:43 PM
manu accepted D31596: acpica: add ACPI_GET_PROPERTY to access Device Specific Data (DSD).

LGTM but I'm not an ACPI expert.

Aug 18 2021, 5:42 PM

Aug 17 2021

manu accepted D31581: if_mvneta: Build the driver as a kernel module.
Aug 17 2021, 12:17 PM
manu accepted D31580: e6000sw: Build the driver as a kernel module.
Aug 17 2021, 8:57 AM
manu added inline comments to D31581: if_mvneta: Build the driver as a kernel module.
Aug 17 2021, 8:54 AM

Aug 16 2021

manu committed R10:e6a32ddf3ff9: pkgbase: Add nfsiod to the FreeBSD-nfs package (authored by manu).
pkgbase: Add nfsiod to the FreeBSD-nfs package
Aug 16 2021, 4:17 PM
manu committed R10:1516cd873510: pkgbase: make only vital packages vital, not their sub-packages (authored by me_igalic.co).
pkgbase: make only vital packages vital, not their sub-packages
Aug 16 2021, 4:17 PM
manu committed R10:e99783747e49: pkgbase: Add an src.conf option for splitting man pages (authored by manu).
pkgbase: Add an src.conf option for splitting man pages
Aug 16 2021, 4:14 PM
manu committed R10:920a66c0a3b8: arm64: Only check for freebsd,dts-version if we are booted in FDT mode. (authored by manu).
arm64: Only check for freebsd,dts-version if we are booted in FDT mode.
Aug 16 2021, 4:12 PM
manu committed R10:5c010b3aa7c7: arm64: Check dtb version against the one we're expecting to find (authored by manu).
arm64: Check dtb version against the one we're expecting to find
Aug 16 2021, 4:12 PM

Aug 15 2021

manu accepted D31407: sdhci_xenon: add AP807 compatible string.
Aug 15 2021, 2:05 PM
manu accepted D31409: sdhci_xenon: remove redundant code in property parsing.
Aug 15 2021, 2:04 PM
manu accepted D31465: Make libglvnd a LIB_DEPEND in various usages.
Aug 15 2021, 2:03 PM

Aug 9 2021

manu accepted D31408: mmc_fdt_helper: correct typo in dts property name 'no-1-8-v'.
Aug 9 2021, 7:11 AM

Aug 6 2021

manu committed R10:b542c9e42ba4: modules: felix: Add needed dependencies (authored by manu).
modules: felix: Add needed dependencies
Aug 6 2021, 1:22 PM
manu committed R10:86c71e97d19f: pkgbase: locales: Also tag the files dir (authored by manu).
pkgbase: locales: Also tag the files dir
Aug 6 2021, 12:39 PM
manu committed R10:e06b8f112803: pkgbase: Add nfsiod to the FreeBSD-nfs package (authored by manu).
pkgbase: Add nfsiod to the FreeBSD-nfs package
Aug 6 2021, 12:38 PM