manu (Emmanuel Vadot)
User

Projects

User Details

User Since
Apr 24 2016, 4:47 PM (90 w, 3 d)

Recent Activity

Tue, Jan 16

manu accepted D13893: libfdt: Update to 1.4.6, switch stand/fdt over to using libfdt for overlay support.
Tue, Jan 16, 9:05 PM
manu accepted D13922: stand: Add /boot/overlays to allow separation of overlays from base FDT.
Tue, Jan 16, 9:54 AM

Sun, Jan 14

manu committed rS327979: allwinner: mmc: Multiple improvement.
allwinner: mmc: Multiple improvement
Sun, Jan 14, 10:05 PM

Sat, Jan 13

manu accepted D13793: Introduce aw_syscon(4) for earlier attachment.
Sat, Jan 13, 5:15 PM
manu committed rS327922: dwmmc_hisi: Fix build when option MMCCAM is defined.
dwmmc_hisi: Fix build when option MMCCAM is defined
Sat, Jan 13, 2:11 PM

Fri, Jan 12

manu added a comment to D13861: Add support for booting FreeBSD kernel directly from U_Boot using booti command..

Reading https://github.com/torvalds/linux/blob/master/Documentation/arm64/booting.txt it should be LINUX_BOOT_ABI and not UBOOT_BOOT_ABI

Fri, Jan 12, 7:35 PM
manu added a comment to D13858: 1 << 31 redux.

arm/allwinner looks fine.

Fri, Jan 12, 6:55 AM

Thu, Jan 11

manu accepted D13777: if_awg: Support new emac bindings.
Thu, Jan 11, 6:13 AM

Sun, Jan 7

manu added a comment to D13777: if_awg: Support new emac bindings.

And Tested on Pine64-LTS (with dts from sunxi/for-next https://git.kernel.org/pub/scm/linux/kernel/git/sunxi/linux.git/tree/arch/arm64/boot/dts/allwinner?h=sunxi/for-next)

Sun, Jan 7, 3:08 PM

Sat, Jan 6

manu added a comment to D13777: if_awg: Support new emac bindings.

All test were done using linux 4.15-rc6 dts with u-boot from ports. Booted from sdcard or netbooted.

Sat, Jan 6, 8:43 PM
manu requested changes to D13777: if_awg: Support new emac bindings.

Works for me :

Sat, Jan 6, 8:43 PM
manu committed rS327636: arm64: Remove old clock driver for Allwinner 64bit SoC.
arm64: Remove old clock driver for Allwinner 64bit SoC
Sat, Jan 6, 8:32 PM

Thu, Jan 4

manu accepted D13296: if_awg: Use syscon driver if it's specified instead of passing in syscon register.
Thu, Jan 4, 4:37 PM
manu accepted D13761: sysutils/dtc: Update to 1.4.6 and add test support.

Looks good to me but I'm not a port commiter.
As long as you tested a arm32 and arm64 u-boot, different arch and FreeBSD version I'm ok.

Thu, Jan 4, 7:34 AM

Mon, Jan 1

manu updated the diff for D13620: aw_usbphy: Add manual page for this driver..

Only install for arm/arm64

Mon, Jan 1, 2:14 PM
manu updated the diff for D13628: aw_rsb: Add man page for this driver.

Put .Nd on the same line

Mon, Jan 1, 2:11 PM
manu updated the diff for D13628: aw_rsb: Add man page for this driver.

Correct man page and only install for arm/arm64

Mon, Jan 1, 2:10 PM
manu abandoned D13577: loader.efi: Don't fail if we cannot find the current device.

This is a hack, I'll keep it locally if I need it.

Mon, Jan 1, 2:05 PM
manu added a comment to D13020: If device path returns NULL, don't use it..

@imp can you close this review ?

Mon, Jan 1, 2:04 PM
manu accepted D13720: aw_sid: Add man page for this driver.

Ok for me but please wait that someone from the manpage group accept it before commiting it.

Mon, Jan 1, 2:03 PM

Sat, Dec 30

manu committed rS327392: dwmmc: Fully subclass driver.
dwmmc: Fully subclass driver
Sat, Dec 30, 10:01 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Sat, Dec 30, 10:01 PM

Thu, Dec 28

manu accepted D13664: stand/fdt: Consistently apply fdt_overlays.
Thu, Dec 28, 3:14 PM
manu added inline comments to D13664: stand/fdt: Consistently apply fdt_overlays.
Thu, Dec 28, 2:52 PM
manu added a comment to D13659: stand/fdt: Fix loading of multiple fdt_overlays.

Did you test multiple overlays targeting the same node ?
Last time I talk to gonzo@ about he came to the conclusion that we need to update libfdt in our tree and use their overlay implementation.

Thu, Dec 28, 7:33 AM
manu committed rS327280: Revert r327250 as it broke the build for some armv6 kernel and all armv4/5.
Revert r327250 as it broke the build for some armv6 kernel and all armv4/5
Thu, Dec 28, 7:31 AM

Wed, Dec 27

manu committed rS327251: arm: hdmi_if.m is already in files.arm.
arm: hdmi_if.m is already in files.arm
Wed, Dec 27, 9:58 PM
manu committed rS327250: arm: Add kern/kern_clocksource.c to files.arm.
arm: Add kern/kern_clocksource.c to files.arm
Wed, Dec 27, 9:40 PM
manu committed rS327239: ctl: Correct comment in ctl_worker_thread.
ctl: Correct comment in ctl_worker_thread
Wed, Dec 27, 3:39 PM
manu added a comment to D13645: Make vt(4) palette configurable.

It should be documented in loader.conf(5), otherwise looks okay.

Wed, Dec 27, 8:54 AM

Tue, Dec 26

manu updated the diff for D13625: sys/arm/lpc: Remove support for it.

Also remove uart_dev_lpc

Tue, Dec 26, 5:14 PM
manu added a comment to D13625: sys/arm/lpc: Remove support for it.
In D13625#285111, @ian wrote:

I'm fine with the removal, I've never heard from a single person that used this platform. The only mention of it on the arm@ list was a request in 2010, before we actually imported the current lpc code.

Tue, Dec 26, 5:10 PM
manu committed rS327216: man4: Move back allwinner man page to share/man/man4.
man4: Move back allwinner man page to share/man/man4
Tue, Dec 26, 4:51 PM
manu committed rS327210: Move arm specific man page to man4.arm subfolder.
Move arm specific man page to man4.arm subfolder
Tue, Dec 26, 4:13 PM
manu committed rS327207: arm64: a10_gpio.c and a10_mmc.c were renamed aw_gpio.c and aw_mmc.c.
arm64: a10_gpio.c and a10_mmc.c were renamed aw_gpio.c and aw_mmc.c
Tue, Dec 26, 3:35 PM
manu committed rS327202: arm: a10_gpio.c was renamed aw_gpio.c.
arm: a10_gpio.c was renamed aw_gpio.c
Tue, Dec 26, 2:34 PM
manu created D13638: arm: Move all required options from GENERIC to std.armv7.
Tue, Dec 26, 1:54 PM
manu added a comment to D13624: arm: Split GENERIC into vendor files.
In D13624#284912, @imp wrote:
In D13624#284888, @manu wrote:
In D13624#284876, @imp wrote:

I like this.

Have you consider the testing requirements for making sure that one can write a config file with these w/o them breaking over time?

The only "bad" thing that could happen is that someone add a "device blah" in multiple vendor file and so config will warn.
If every change to the GENERIC file is to add a generic driver and every change to a vendor file is to add a vendor driver everything is fine (tm).
I have other plan for config to allow a much better conf files but for now it's still in my brain.

So you don't plan to write a script to generate a GENERIC that has all the 'other' std.foo lines commented out for each std.foo type to make sure that compiles?

Tue, Dec 26, 1:50 PM
manu added a comment to D13619: axp209: move driver to sys/dev/pmic.

imho, we should put platform specialized drivers to dev subtree only if given driver can be reused on multiple platforms. I personally vote for not moving it.

Tue, Dec 26, 1:28 PM
manu committed rS327199: Allwinner: gpio: Rename driver to aw_gpio and add man page for it.
Allwinner: gpio: Rename driver to aw_gpio and add man page for it
Tue, Dec 26, 12:11 PM
manu closed D13617: Allwinner: gpio rename driver to aw_gpio and add man page for it.
Tue, Dec 26, 12:11 PM
manu committed rS327198: Allwinner: mmc: Rename driver to aw_mmc and add a man page for it.
Allwinner: mmc: Rename driver to aw_mmc and add a man page for it
Tue, Dec 26, 12:07 PM
manu closed D13616: Allwinner: mmc: rename driver to aw_mmc and add man page for it.
Tue, Dec 26, 12:07 PM
manu updated the diff for D13619: axp209: move driver to sys/dev/pmic.

Address bcr@ comments.

Tue, Dec 26, 11:37 AM
manu added a comment to D13625: sys/arm/lpc: Remove support for it.
In D13625#284904, @br wrote:

ssd1289 is an external LCD controller and not a part of NXP LPC SoC. It may be useful for other boards.
May be we should move it somewhere?

Tue, Dec 26, 11:32 AM
manu added a comment to D13625: sys/arm/lpc: Remove support for it.

This is the hardware supported it seems : https://www.embeddedartists.com/products/kits/lpc3250_kit.php

Tue, Dec 26, 11:30 AM
manu updated the diff for D13619: axp209: move driver to sys/dev/pmic.

Correct man page based on mandoc -Tlint

Tue, Dec 26, 11:02 AM
manu committed rS327197: aw_rtc.4: Correct some error/style found by mandoc -Tlint.
aw_rtc.4: Correct some error/style found by mandoc -Tlint
Tue, Dec 26, 11:00 AM
manu updated the diff for D13616: Allwinner: mmc: rename driver to aw_mmc and add man page for it.

Update to latest head and correct man page based on mandoc -Tlint

Tue, Dec 26, 10:57 AM
manu updated the diff for D13617: Allwinner: gpio rename driver to aw_gpio and add man page for it.

Rebase on head a correct man page based on mandoc -Tlint

Tue, Dec 26, 10:53 AM
manu updated the diff for D13628: aw_rsb: Add man page for this driver.

Rebase on latest head

Tue, Dec 26, 10:42 AM
manu updated the diff for D13628: aw_rsb: Add man page for this driver.

I've only written the man page.

Tue, Dec 26, 10:39 AM
manu updated the diff for D13628: aw_rsb: Add man page for this driver.

Correct some stuff based on comments and mandoc -Tlint

Tue, Dec 26, 10:37 AM

Mon, Dec 25

manu added a comment to D13624: arm: Split GENERIC into vendor files.
In D13624#284876, @imp wrote:

I like this.

Have you consider the testing requirements for making sure that one can write a config file with these w/o them breaking over time?

Mon, Dec 25, 11:29 PM
manu added a comment to D13625: sys/arm/lpc: Remove support for it.
In D13625#284875, @imp wrote:

Is there any better justification than "it's old" for removing it? It seems like it might be a good one to have go, but what's the hardware support we'd be losing, who did the original work? Do we know if it still works?

Chances are answering these questions will push me into the 'delete' category, but mere age isn't an indication it needs to go.

Mon, Dec 25, 11:24 PM
manu updated the diff for D13628: aw_rsb: Add man page for this driver.

assert some bjk@ comments.

Mon, Dec 25, 11:06 PM
manu committed rS327185: aw_rsb.4: Remove useless .Re.
aw_rsb.4: Remove useless .Re
Mon, Dec 25, 11:01 PM
manu added inline comments to D13628: aw_rsb: Add man page for this driver.
Mon, Dec 25, 10:58 PM
manu added inline comments to D13628: aw_rsb: Add man page for this driver.
Mon, Dec 25, 10:55 PM
manu updated the diff for D13628: aw_rsb: Add man page for this driver.

s/developped/developed/

Mon, Dec 25, 10:39 PM
manu created D13628: aw_rsb: Add man page for this driver.
Mon, Dec 25, 10:35 PM
manu created D13627: sys/arm/amlogic: remove support for it.
Mon, Dec 25, 10:20 PM
manu committed rS327184: Change the remaining files using my personnal email address to my freebsd one.
Change the remaining files using my personnal email address to my freebsd one
Mon, Dec 25, 10:09 PM
manu created D13625: sys/arm/lpc: Remove support for it.
Mon, Dec 25, 9:54 PM
manu created D13624: arm: Split GENERIC into vendor files.
Mon, Dec 25, 9:26 PM
manu committed rS327180: aw_rtc: Add man page for this driver.
aw_rtc: Add man page for this driver
Mon, Dec 25, 7:42 PM
manu closed D13621: aw_rtc: Add man page for this driver.
Mon, Dec 25, 7:42 PM
manu updated the diff for D13616: Allwinner: mmc: rename driver to aw_mmc and add man page for it.

s/string/strings/

Mon, Dec 25, 6:44 PM
manu updated the diff for D13617: Allwinner: gpio rename driver to aw_gpio and add man page for it.

s/string/strings/

Mon, Dec 25, 6:43 PM
manu updated the diff for D13620: aw_usbphy: Add manual page for this driver..

s/string/strings/

Mon, Dec 25, 6:42 PM
manu updated the diff for D13621: aw_rtc: Add man page for this driver.

s/string/strings/

Mon, Dec 25, 6:40 PM
manu updated the diff for D13620: aw_usbphy: Add manual page for this driver..

Use compatible strings instead of a list of SoC.

Mon, Dec 25, 6:01 PM
manu updated the diff for D13621: aw_rtc: Add man page for this driver.

Use compatible strings instead of a list of SoC.

Mon, Dec 25, 5:57 PM
manu updated the diff for D13617: Allwinner: gpio rename driver to aw_gpio and add man page for it.

Use compatibles string instead of a list of supported SoC.

Mon, Dec 25, 5:32 PM
manu updated the diff for D13616: Allwinner: mmc: rename driver to aw_mmc and add man page for it.

Use "SD/MMC" instead of only MMC (noted by jmcneill@)
Document the sysctl (noted by jmcneill@)

Mon, Dec 25, 5:14 PM
manu updated the diff for D13616: Allwinner: mmc: rename driver to aw_mmc and add man page for it.

Use compatible string instead of a list of SoC.

Mon, Dec 25, 5:02 PM
manu created D13621: aw_rtc: Add man page for this driver.
Mon, Dec 25, 4:52 PM
manu created D13620: aw_usbphy: Add manual page for this driver..
Mon, Dec 25, 4:47 PM
manu committed rS327176: allwinner: aw_usbphy is also needed for ohci.
allwinner: aw_usbphy is also needed for ohci
Mon, Dec 25, 4:40 PM
manu committed rS327175: Allwinner: Remove unused aw_console driver..
Allwinner: Remove unused aw_console driver.
Mon, Dec 25, 4:27 PM
manu created D13619: axp209: move driver to sys/dev/pmic.
Mon, Dec 25, 4:24 PM
manu created D13617: Allwinner: gpio rename driver to aw_gpio and add man page for it.
Mon, Dec 25, 3:36 PM
manu added a comment to D13616: Allwinner: mmc: rename driver to aw_mmc and add man page for it.

The review is mostly for the manpage.

Mon, Dec 25, 3:18 PM
manu created D13616: Allwinner: mmc: rename driver to aw_mmc and add man page for it.
Mon, Dec 25, 3:17 PM
manu created D13615: dwmmc: Fully subclass the driver.
Mon, Dec 25, 2:36 PM

Thu, Dec 21

manu created D13577: loader.efi: Don't fail if we cannot find the current device.
Thu, Dec 21, 8:07 PM

Wed, Dec 20

manu committed rP456855: sysutils/atf-allwinner: Update to 20171017.
sysutils/atf-allwinner: Update to 20171017
Wed, Dec 20, 8:37 PM
manu closed D13560: sysutils/atf-allwinner: Update to 20171017.
Wed, Dec 20, 8:37 PM
manu committed rP456853: Add sysutils/u-boot-a64-olinuxino.
Add sysutils/u-boot-a64-olinuxino
Wed, Dec 20, 8:36 PM
manu closed D13562: Add sysutils/u-boot-a64-olinuxino.
Wed, Dec 20, 8:36 PM
manu updated the diff for D13562: Add sysutils/u-boot-a64-olinuxino.

Hook up the port to the build

Wed, Dec 20, 8:21 PM
manu created D13562: Add sysutils/u-boot-a64-olinuxino.
Wed, Dec 20, 8:11 PM
manu created D13560: sysutils/atf-allwinner: Update to 20171017.
Wed, Dec 20, 7:53 PM

Tue, Dec 19

manu accepted D13543: Cleanup u-boot-tools.
Tue, Dec 19, 3:05 PM

Dec 18 2017

manu committed rS326951: MFC r312914, r322694.
MFC r312914, r322694
Dec 18 2017, 8:18 PM
manu committed rP456671: Add new port sysutils/u-boot-tools.
Add new port sysutils/u-boot-tools
Dec 18 2017, 7:20 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Dec 18 2017, 7:20 PM
manu added a comment to D13455: u-boot-tools: Add new ports u-boot-tools.

Ping

Dec 18 2017, 2:16 PM
manu added reviewers for D13521: syscon: Introduce kobj and split out fdt bits: ARM, arm64.
Dec 18 2017, 12:30 PM

Dec 12 2017

manu committed rP456178: Add sysutils/u-boot-orangepi-pc2.
Add sysutils/u-boot-orangepi-pc2
Dec 12 2017, 6:06 PM