Page MenuHomeFreeBSD

manu (Emmanuel Vadot)
User

Projects

User Details

User Since
Apr 24 2016, 4:47 PM (213 w, 5 d)

Recent Activity

Wed, May 27

manu committed rS361551: linuxkpi: Add kstrtou16.
linuxkpi: Add kstrtou16
Wed, May 27, 11:42 AM
manu committed rS361550: linuxkpi: Add rcu_swap_protected.
linuxkpi: Add rcu_swap_protected
Wed, May 27, 10:01 AM
manu added a comment to D24954: linuxkpi: Add rcu_swap_protected.

ping

Wed, May 27, 9:32 AM
manu added a comment to D24996: linuxkpi: Add kstrtou16.

ping

Wed, May 27, 9:32 AM
manu committed rS361549: linuxkpi: Add overflow.h.
linuxkpi: Add overflow.h
Wed, May 27, 9:32 AM
manu closed D25015: linuxkpi: Add overflow.h.
Wed, May 27, 9:32 AM
manu added inline comments to D25015: linuxkpi: Add overflow.h.
Wed, May 27, 9:19 AM
manu updated the diff for D25015: linuxkpi: Add overflow.h.

Add #error if the compiler doesn't have the required builtin.

Wed, May 27, 9:18 AM
manu requested review of D25023: libdrm: Update to 2.4.102.
Wed, May 27, 8:58 AM
manu added inline comments to D25015: linuxkpi: Add overflow.h.
Wed, May 27, 8:50 AM
manu added inline comments to D25015: linuxkpi: Add overflow.h.
Wed, May 27, 8:40 AM
manu updated the diff for D25015: linuxkpi: Add overflow.h.

Only add the macros if the compiler have the builtin.
Old compiler aren't supported.

Wed, May 27, 8:27 AM
manu added inline comments to D25020: graphics/mesa-libs: enable libglvnd support.
Wed, May 27, 8:01 AM

Tue, May 26

manu added a comment to D25015: linuxkpi: Add overflow.h.

Should there be an ifdef for LINT builds?

Tue, May 26, 11:50 AM
manu requested review of D25015: linuxkpi: Add overflow.h.
Tue, May 26, 10:57 AM

Mon, May 25

manu accepted D24176: pkgbase: Remove the last users of the FreeBSD-example package.
Mon, May 25, 1:06 PM
manu committed rS361452: linuxkpi: Fix mod_timer and del_timer_sync.
linuxkpi: Fix mod_timer and del_timer_sync
Mon, May 25, 12:46 PM
manu closed D24983: linuxkpi: Fix mod_timer and del_timer_sync.
Mon, May 25, 12:46 PM
manu committed rS361450: linuxkpi: Add refcount.h.
linuxkpi: Add refcount.h
Mon, May 25, 12:44 PM
manu closed D24985: linuxkpi: Add refcount.h.
Mon, May 25, 12:44 PM
manu committed rS361449: linuxkpi: Add __same_type and __must_be_array macros.
linuxkpi: Add __same_type and __must_be_array macros
Mon, May 25, 12:43 PM
manu updated the diff for D24983: linuxkpi: Fix mod_timer and del_timer_sync.
Mon, May 25, 9:40 AM
manu added inline comments to D24983: linuxkpi: Fix mod_timer and del_timer_sync.
Mon, May 25, 9:31 AM
manu updated the diff for D24983: linuxkpi: Fix mod_timer and del_timer_sync.
Mon, May 25, 8:51 AM

Sun, May 24

manu added inline comments to D24983: linuxkpi: Fix mod_timer and del_timer_sync.
Sun, May 24, 10:07 PM
manu added inline comments to D24983: linuxkpi: Fix mod_timer and del_timer_sync.
Sun, May 24, 9:36 PM
manu added inline comments to D24987: Update platform docs for arm.
Sun, May 24, 8:34 PM
manu added inline comments to D24987: Update platform docs for arm.
Sun, May 24, 8:18 PM
manu requested review of D24985: linuxkpi: Add refcount.h.
Sun, May 24, 4:12 PM
manu requested review of D24983: linuxkpi: Fix mod_timer and del_timer_sync.
Sun, May 24, 4:11 PM
manu committed rP536403: graphics/drm-devel-kmod: Update to latest 5.2.
graphics/drm-devel-kmod: Update to latest 5.2
Sun, May 24, 1:33 PM
manu added a comment to D24917: Add ACPI attachment for the Vybrid VF610 I2C controller.

Looks like this needs to wait until there's some way to get the clock without devicetree (I guess Linux runs with fdt+acpi both to make it work..)

Sun, May 24, 1:00 PM · arm64, ARM

Sat, May 23

manu committed rS361422: bbr: Use arc4random_uniform from libkern..
bbr: Use arc4random_uniform from libkern.
Sat, May 23, 7:52 PM
manu committed rS361419: linuxkpi: Add prandom_u32_max.
linuxkpi: Add prandom_u32_max
Sat, May 23, 5:52 PM
manu closed D24962: libkern: Add arc4random_uniform.
Sat, May 23, 5:51 PM
manu committed rS361418: libkern: Add arc4random_uniform.
libkern: Add arc4random_uniform
Sat, May 23, 5:51 PM
manu updated the diff for D24962: libkern: Add arc4random_uniform.
Sat, May 23, 12:08 PM

Fri, May 22

manu accepted D24353: Add GPIO support for QorIQ boards..
Fri, May 22, 8:32 PM
manu accepted D24361: Introduce VF610 I2C controller support..
Fri, May 22, 8:31 PM
manu accepted D24466: Introduce a driver for NXP LS10xx SoC AHCI..
Fri, May 22, 8:31 PM
manu added a comment to D24962: libkern: Add arc4random_uniform.
In D24962#549612, @cem wrote:

Hm, libc version is (or was) a separate file with a different copyright. Usual pattern in libkern is to just copy the libc files to libkern verbatim and only fixup as needed to compile. I don't know that we always have to do that, but we should at least confirm the arc4random_uniform copyright follows the code.

Fri, May 22, 5:32 PM
manu requested review of D24962: libkern: Add arc4random_uniform.
Fri, May 22, 5:21 PM
manu accepted D24352: Add LS1046A clockgen driver..
Fri, May 22, 3:35 PM
manu added a comment to D24352: Add LS1046A clockgen driver..

Just go with NXP_LS, if there is any problem later we'll handle it at this moment.

Fri, May 22, 3:35 PM
manu added a comment to D24352: Add LS1046A clockgen driver..
In D24352#549462, @mmel wrote:

The LS family has too many members and can share 99% of the code. It seems unnecessary for me to have the option for each individual variant. How about 'SOC_NXP_LS' ?

Fri, May 22, 2:36 PM

Thu, May 21

manu committed rS361343: linuxkpi: Add rcu_work functions.
linuxkpi: Add rcu_work functions
Thu, May 21, 8:19 PM
manu closed D24942: linuxkpi: Add rcu_work functions..
Thu, May 21, 8:19 PM
manu updated the diff for D24942: linuxkpi: Add rcu_work functions..
Thu, May 21, 6:55 PM
manu requested review of D24942: linuxkpi: Add rcu_work functions..
Thu, May 21, 2:56 PM

Tue, May 19

manu committed rS361247: linuxkpi: Add irq_work.h.
linuxkpi: Add irq_work.h
Tue, May 19, 9:04 AM
manu closed D24859: linuxkpi: Add irq_work.h.
Tue, May 19, 9:04 AM
manu committed rS361246: linuxkpi: add pci_dev_present.
linuxkpi: add pci_dev_present
Tue, May 19, 8:44 AM
manu committed rS361245: linuxkpi: Add __init_waitqueue_head.
linuxkpi: Add __init_waitqueue_head
Tue, May 19, 8:43 AM

Sun, May 17

manu committed rS361140: linuxkpi: Add offsetofend macro.
linuxkpi: Add offsetofend macro
Sun, May 17, 8:15 PM
manu committed rS361139: linuxkpi: Add __mutex_init.
linuxkpi: Add __mutex_init
Sun, May 17, 8:12 PM
manu committed rS361138: linuxkpi: Add atomic_dec_and_mutex_lock.
linuxkpi: Add atomic_dec_and_mutex_lock
Sun, May 17, 8:09 PM

Sat, May 16

manu added a comment to D24798: linuxkpi: add synchronize_srcu_expedited.

It is fine.

Sat, May 16, 2:19 PM
manu added a comment to D24859: linuxkpi: Add irq_work.h.

Don't forget to add LinuxKPI to the commit message and MFC after.

Sat, May 16, 11:26 AM
manu added a reviewer for D24859: linuxkpi: Add irq_work.h: emaste.
Sat, May 16, 11:04 AM
manu requested review of D24859: linuxkpi: Add irq_work.h.
Sat, May 16, 10:59 AM
manu accepted D24796: linuxkpi: add pci_dev_present and an srcu function for drm5.2.
Sat, May 16, 10:25 AM
manu added a comment to D24798: linuxkpi: add synchronize_srcu_expedited.

I think that the expedited funcs do more than a simple sync but I'm not able to tell what for now ...
What do you think about this @hselasky ?

Sat, May 16, 10:25 AM

Fri, May 15

manu accepted D24364: Introduce support for Epson RX-8803 RTC.
Fri, May 15, 5:49 PM
manu accepted D24363: Add TCA6416 GPIO expander support..
Fri, May 15, 5:49 PM
manu added inline comments to D24353: Add GPIO support for QorIQ boards..
Fri, May 15, 10:14 AM
manu accepted D24361: Introduce VF610 I2C controller support..

LGTM

Fri, May 15, 10:12 AM
manu accepted D24363: Add TCA6416 GPIO expander support..

Would you mind moving this driver to a gpio subdirectory (sys/dev/iicbus/gpio) ?
We've been talking with @ian and @imp doing that for existing drivers.
Otherwise LGTM.

Fri, May 15, 10:11 AM
manu accepted D24364: Introduce support for Epson RX-8803 RTC.

Would you mind moving the driver to a rtc subdirectory (sys/dev/iicbus/rtc/) ?
We've been talking with @ian and @imp about doing that for existing drivers.
Otherwise looks good to me.

Fri, May 15, 10:10 AM
manu accepted D24466: Introduce a driver for NXP LS10xx SoC AHCI..
Fri, May 15, 10:08 AM

Wed, May 13

manu committed rS361007: linuxkpi: Add EBADRQC to errno.h.
linuxkpi: Add EBADRQC to errno.h
Wed, May 13, 7:49 AM

Sun, May 10

manu committed rS360872: qnlx: Do not redifines types..
qnlx: Do not redifines types.
Sun, May 10, 2:09 PM
manu committed rS360871: linuxkpi: Really add bitmap_alloc and bitmap_zalloc.
linuxkpi: Really add bitmap_alloc and bitmap_zalloc
Sun, May 10, 1:12 PM
manu committed rS360870: linuxkpi: Add bitmap_alloc and bitmap_free.
linuxkpi: Add bitmap_alloc and bitmap_free
Sun, May 10, 1:07 PM
manu retitled D24794: linuxkpi: Add bitmap_alloc and bitmap_free from linuxkpi: Add bitmap_free to linuxkpi: Add bitmap_alloc and bitmap_free.
Sun, May 10, 10:39 AM

Sat, May 9

manu committed rS360851: linuxkpi: Add bitmap_copy and bitmap_andnot.
linuxkpi: Add bitmap_copy and bitmap_andnot
Sat, May 9, 5:53 PM
manu closed D24782: linuxkpi: Add bitmap_copy and bitmap_andnot.
Sat, May 9, 5:53 PM
manu requested review of D24782: linuxkpi: Add bitmap_copy and bitmap_andnot.
Sat, May 9, 4:54 PM

Thu, May 7

manu committed rS360796: Bump __FreeBSD_version after linuxkpi changes.
Bump __FreeBSD_version after linuxkpi changes
Thu, May 7, 7:52 PM
manu committed rS360787: linuxkpi: Add pci_iomap and pci_iounmap.
linuxkpi: Add pci_iomap and pci_iounmap
Thu, May 7, 5:01 PM
manu closed D24696: linuxkpi: Add pci_iomap and pci_iounmap.
Thu, May 7, 5:01 PM

Wed, May 6

manu added inline comments to D24696: linuxkpi: Add pci_iomap and pci_iounmap.
Wed, May 6, 3:22 PM
manu added inline comments to D24696: linuxkpi: Add pci_iomap and pci_iounmap.
Wed, May 6, 1:55 PM

Tue, May 5

manu added a comment to D24726: Add sysutils/u-boot-qemu-arm64.

You forgot to add it in sysutils/Makefie.
Otherwise it looks good.

Tue, May 5, 9:32 PM
manu added a comment to D24696: linuxkpi: Add pci_iomap and pci_iounmap.

Please also add "LinuxKPI" somewhere in the commit message.

Tue, May 5, 12:13 PM
manu added a comment to D24696: linuxkpi: Add pci_iomap and pci_iounmap.

Assuming the API is only used during PCI enumeration.

Don't forget to MFC!

Tue, May 5, 12:13 PM
manu updated the test plan for D24696: linuxkpi: Add pci_iomap and pci_iounmap.
Tue, May 5, 11:03 AM
manu updated the diff for D24696: linuxkpi: Add pci_iomap and pci_iounmap.

Add free region

Tue, May 5, 10:44 AM
manu requested review of D24696: linuxkpi: Add pci_iomap and pci_iounmap.
Tue, May 5, 10:41 AM

Mon, May 4

manu accepted D24653: acpi_video: try our best to work on systems without non-essential methods.
Mon, May 4, 1:55 PM
manu accepted D24653: acpi_video: try our best to work on systems without non-essential methods.
In D24653#543367, @avg wrote:

Yeah, I think that it is better to use _BQC whenever it is actually provided because there can be multiple ways to control the brightness.
The more I look into this the more quirks I discover.
Some systems handle brightness keys completely in firmware, some post ACPI events, some post custom events via WMI.
On some systems _BCM actually changes the brightness (it's handled by the firmware); on some systems _BCM is just another level of indirection -- it just posts more events to be handled elsewhere (e.g., via ATIF with AMD's video).
I think that Linux drifts towards converting brightness events to evdev brightness key events and then letting the userland handle those keys. The actual brightness controls are exposed as sysfs backlight nodes and they cab be hooked to ACPI video (_BCM) or directly to graphics drivers or something vendor specific, etc.

So, I wanted to be very conservative with my change and just let acpi_video work (as best as it can) on my system.

Mon, May 4, 8:26 AM

Sun, May 3

manu committed rP533769: devel/aarch64-none-elf-gcc: Add binutils dependency.
devel/aarch64-none-elf-gcc: Add binutils dependency
Sun, May 3, 11:36 AM

Sat, May 2

manu added a comment to D24653: acpi_video: try our best to work on systems without non-essential methods.
In D24653#542928, @manu wrote:

Maybe it would be more clean to request the current level with _BCQ at attach and never deal with the method after, only the cached value ?
I don't see why we would want to call this method over using the cache value after boot.
Otherwise looks good to me.
I think that the _DCS/_DGS fix could be done in another commit though.

Sat, May 2, 11:20 AM
manu added a comment to D24653: acpi_video: try our best to work on systems without non-essential methods.

Maybe it would be more clean to request the current level with _BCQ at attach and never deal with the method after, only the cached value ?
I don't see why we would want to call this method over using the cache value after boot.
Otherwise looks good to me.
I think that the _DCS/_DGS fix could be done in another commit though.

Sat, May 2, 11:15 AM

Thu, Apr 30

manu committed rP533476: sysutils/u-boot-tools: Mark broken with libressl.
sysutils/u-boot-tools: Mark broken with libressl
Thu, Apr 30, 8:45 PM
manu added a comment to D24466: Introduce a driver for NXP LS10xx SoC AHCI..

There is no clock enabling here but the dtsi have a clock property.

Thu, Apr 30, 8:26 PM
manu added inline comments to D24352: Add LS1046A clockgen driver..
Thu, Apr 30, 8:22 PM
manu added a comment to D24351: Add QorIQ platform clockgen driver..

It's a bit hard to review without knowing the clock topology, is that something that you can share or can you describe it a bit ?
From what I understand of the code there is N pll based on the number of divider ?
Does all those PLLs really exists ?

Thu, Apr 30, 8:16 PM
manu added inline comments to D24353: Add GPIO support for QorIQ boards..
Thu, Apr 30, 7:58 PM
manu added inline comments to D24361: Introduce VF610 I2C controller support..
Thu, Apr 30, 7:47 PM

Apr 29 2020

manu committed rP533381: devel/aarch64-none-elf-gcc: Fix building plugins.
devel/aarch64-none-elf-gcc: Fix building plugins
Apr 29 2020, 5:18 PM