Page MenuHomeFreeBSD

manu (Emmanuel Vadot)
User

Projects (7)

User Details

User Since
Apr 24 2016, 4:47 PM (230 w, 3 d)

Recent Activity

Tue, Sep 22

manu committed rP549599: ports-mgmt/pkg: Update to 1.15.6.
ports-mgmt/pkg: Update to 1.15.6
Tue, Sep 22, 2:15 PM
manu committed rP549596: ports-mgmt/pkg: Update to 15.99.2.
ports-mgmt/pkg: Update to 15.99.2
Tue, Sep 22, 2:13 PM

Mon, Sep 21

manu updated the diff for D25984: pkgbase: Add incremental package.

Forgot to uncomment a line, we need the stage-package dep.

Mon, Sep 21, 3:36 PM
manu updated the summary of D25984: pkgbase: Add incremental package.
Mon, Sep 21, 3:01 PM
manu updated the diff for D25984: pkgbase: Add incremental package.

Use pkg query '%X' to have the internal package checksum, any changes to a package except the version will produce a different hash.

Mon, Sep 21, 3:00 PM
manu committed rP549447: ports-mgmt/pkg: Update to 1.15.5.
ports-mgmt/pkg: Update to 1.15.5
Mon, Sep 21, 2:54 PM
manu committed rP549446: ports-mgmt/pkg: Update to 1.15.99.1.
ports-mgmt/pkg: Update to 1.15.99.1
Mon, Sep 21, 2:51 PM
manu committed rP549424: Fix nvidia-driver* after r548950.
Fix nvidia-driver* after r548950
Mon, Sep 21, 9:05 AM

Sun, Sep 20

manu committed rS365927: arm: allwinner: aw_nmi: Fix wrong logic when we disable the nmi.
arm: allwinner: aw_nmi: Fix wrong logic when we disable the nmi
Sun, Sep 20, 4:12 PM

Sat, Sep 19

manu committed rP548949: mesa: Remove sparc64 patches.
mesa: Remove sparc64 patches
Sat, Sep 19, 9:39 AM
manu closed D26461: mesa-libs: Add glesv1 lib.
Sat, Sep 19, 9:34 AM
manu committed rP548950: mesa-libs: Add glesv1 lib.
mesa-libs: Add glesv1 lib
Sat, Sep 19, 9:34 AM
manu closed D26460: mesa: Remove sparc64 patches.
Sat, Sep 19, 9:34 AM

Thu, Sep 17

manu added a comment to D26460: mesa: Remove sparc64 patches.

Mabye put a NOT_FOR_ARCHS=sparc64 and NOT_FOR_ARCHS_REASON=not supported or something in mesa-dri/Makefile.common. Just in case someone is brave enough to try building this on sparc64.

Thu, Sep 17, 3:51 PM
manu added a comment to D26461: mesa-libs: Add glesv1 lib.

libepoxy is ok.
Why did you though there could be a problem ?

Thu, Sep 17, 3:50 PM
manu requested review of D26461: mesa-libs: Add glesv1 lib.
Thu, Sep 17, 3:18 PM
manu requested review of D26460: mesa: Remove sparc64 patches.
Thu, Sep 17, 3:17 PM
manu accepted D26459: Add dtb/sifive module.
Thu, Sep 17, 1:19 PM
manu committed rP548829: mesa*: Only add x11 dependancy if it's requested.
mesa*: Only add x11 dependancy if it's requested
Thu, Sep 17, 9:22 AM
manu closed D26438: mesa*: Only add x11 dependancy if it's requested.
Thu, Sep 17, 9:22 AM

Wed, Sep 16

manu added a comment to D25793: 10Gigabit Ethernet driver for AMD SoC.

It's a logging mistake @manu. I will correct it accordingly. Each nibble in that value denotes a port status. When you say you are touching only ax0, I see the correct nibble reflecting the change (bits[15:12]). From the values you showed here, looks like your SFP module is detected, but Link is still not. Is the link connected?

Wed, Sep 16, 5:07 PM
manu updated the diff for D26253: linuxkpi: Add backlight support.

Add support for GETINFO and free backlight data.

Wed, Sep 16, 4:33 PM
manu updated the diff for D26252: Add pwm_backlight.

Add GETINFO support.

Wed, Sep 16, 4:33 PM
manu updated the diff for D26251: Add backlight(8).

Add support for -i to query backlight info.

Wed, Sep 16, 4:32 PM
manu updated the diff for D26250: Add backlight subsystem.

Add GETINFO ioctl to get the backlight name and type.

Wed, Sep 16, 4:30 PM
manu added a comment to D25793: 10Gigabit Ethernet driver for AMD SoC.

So I feel a bit dumb but I now know why I it didn't worked.
Naming of interfaces is of course not the same on the panel but what made me confuse is if I remove/insert the module in the slot that correspond to ax0 I have :
ax3: xgbe_phy_sfp_signals: sfp_gpio_inputs: 0x7220
ax3: xgbe_phy_sfp_signals: sfp_gpio_inputs: 0x2220
Which lead me to think that I was using the right interface.
So TLDR inserting/removing a module in any of the 4 slot always prints info for ax3.
Do you have any idea what's going on ?

Wed, Sep 16, 1:41 PM
manu added inline comments to D26252: Add pwm_backlight.
Wed, Sep 16, 11:10 AM
manu added inline comments to D26438: mesa*: Only add x11 dependancy if it's requested.
Wed, Sep 16, 7:13 AM
manu added a member for desktop: manu.
Wed, Sep 16, 7:05 AM

Tue, Sep 15

manu requested review of D26438: mesa*: Only add x11 dependancy if it's requested.
Tue, Sep 15, 3:01 PM
manu added a reviewer for D26437: graphics/cairo: Allow GLESv2 backend as an options: desktop.
Tue, Sep 15, 2:06 PM
manu requested review of D26437: graphics/cairo: Allow GLESv2 backend as an options.
Tue, Sep 15, 2:06 PM
manu committed rP548731: x11/havoc: Add new port.
x11/havoc: Add new port
Tue, Sep 15, 1:42 PM

Mon, Sep 14

manu committed rP548601: graphics/drm*kmod: Update to latest upstream.
graphics/drm*kmod: Update to latest upstream
Mon, Sep 14, 9:46 AM
manu committed rP548598: graphics/gpu-firmware-kmod: Update to latest commit.
graphics/gpu-firmware-kmod: Update to latest commit
Mon, Sep 14, 9:21 AM
manu closed D26396: graphics/piglit: Update to latest upstream.
Mon, Sep 14, 7:50 AM
manu committed rP548592: graphics/piglit: Update to latest upstream.
graphics/piglit: Update to latest upstream
Mon, Sep 14, 7:50 AM

Fri, Sep 11

manu removed a reviewer for D25793: 10Gigabit Ethernet driver for AMD SoC: manu_bidouilliste.com.
Fri, Sep 11, 7:30 AM
manu added a comment to D25793: 10Gigabit Ethernet driver for AMD SoC.

Log with debug_level=3 : https://reviews.freebsd.org/P423

Fri, Sep 11, 7:30 AM
manu created P423 if_axp.
Fri, Sep 11, 7:28 AM

Thu, Sep 10

manu added inline comments to D26396: graphics/piglit: Update to latest upstream.
Thu, Sep 10, 6:32 PM
manu updated the diff for D26396: graphics/piglit: Update to latest upstream.

address @tcberner's comments.

Thu, Sep 10, 6:32 PM
manu requested review of D26396: graphics/piglit: Update to latest upstream.
Thu, Sep 10, 6:21 PM
manu added a comment to D25793: 10Gigabit Ethernet driver for AMD SoC.

Fine @manu .

I only have finisar ftlx8574d3bcl for now, do you have a known model that is supposed to work ?
Also can you make the printf not in a loop ?

We have tested with Finisar 10G SFP-to-Optical modules (not RJ45). Other than that, we have tested with 10G FS, Prolabs and 10GTek (all SFP-to-RJ45). I will make the change to print that log only once and other changes I mentioned before and submit a new patch tomorrow.

Thu, Sep 10, 5:07 PM
manu added a comment to D25793: 10Gigabit Ethernet driver for AMD SoC.

Hi @manu, Thanks for trying the patch and making other necessary changes. Sorry, I missed to make that change MPASS (nrxqs == 2) when I submitted the v4 patch.

Regarding the log

'ax0: xgbe_phy_reset: no phydev'

This is normal before the interface is brought up. Not an issue. This log may be confusing. I will change that to verbose level log in the future patches.

Thu, Sep 10, 4:35 PM
manu committed rP548210: graphics/drm-current-kmod: Add a patch.
graphics/drm-current-kmod: Add a patch
Thu, Sep 10, 4:20 PM
manu committed rP548209: graphics/drm-current-kmod: Add forgotten file.
graphics/drm-current-kmod: Add forgotten file
Thu, Sep 10, 4:09 PM
manu committed rP548208: graphics/drm-current-kmod: Update to drm_v5.4.62.
graphics/drm-current-kmod: Update to drm_v5.4.62
Thu, Sep 10, 3:36 PM
manu closed D26367: graphics/drm-current-kmod: Update to drm_v5.4.62.
Thu, Sep 10, 3:36 PM
manu added a comment to D25793: 10Gigabit Ethernet driver for AMD SoC.

I've just tested on my machine, an IEI Puzzle. (Sorry it took so long).
I needed this to have the driver compiled and loading : https://reviews.freebsd.org/P422

Thu, Sep 10, 2:59 PM
manu created P422 if_axp.
Thu, Sep 10, 2:56 PM

Wed, Sep 9

manu added inline comments to D26367: graphics/drm-current-kmod: Update to drm_v5.4.62.
Wed, Sep 9, 2:12 PM
manu updated the diff for D26367: graphics/drm-current-kmod: Update to drm_v5.4.62.

Address @zeising's comments.

Wed, Sep 9, 12:36 PM
manu added a comment to D26367: graphics/drm-current-kmod: Update to drm_v5.4.62.
In D26367#586347, @manu wrote:

One small nit above, nothing important.

As a side note, I wonder if we really should keep the SOURCE option enabled, it has caused issues in the past when people first do a buildkernel (with the old sources) and then update ports and think they have the new stuff, while still loading the old module built with buildkernel.

Well, installing the source will always causes problems when you update ports/package after building kernel but can help (sometimes) if nothing in base breaks building the module but it needs to be recompiled. It's the best solution that we have right now.

We've had several support cases where there's been confusion as to which module was loaded because of this. But this discussion is bigger than this review, and not something that should prevent the update from happening. :)

Wed, Sep 9, 11:56 AM
manu added a comment to D26367: graphics/drm-current-kmod: Update to drm_v5.4.62.

One more thing, can you update the version check in graphics/drm-kmod/Makefile as well?

Wed, Sep 9, 11:42 AM
manu added a comment to D26367: graphics/drm-current-kmod: Update to drm_v5.4.62.

One small nit above, nothing important.

As a side note, I wonder if we really should keep the SOURCE option enabled, it has caused issues in the past when people first do a buildkernel (with the old sources) and then update ports and think they have the new stuff, while still loading the old module built with buildkernel.

Wed, Sep 9, 11:38 AM
manu accepted D26348: aw_usbphy: add support for device mode operation.
Wed, Sep 9, 10:12 AM
manu added a reviewer for D26367: graphics/drm-current-kmod: Update to drm_v5.4.62: emaste.
Wed, Sep 9, 9:15 AM
manu requested review of D26367: graphics/drm-current-kmod: Update to drm_v5.4.62.
Wed, Sep 9, 9:15 AM
manu added a comment to D26365: stand/reloc_elf: Handle relative relocations for arm{,64} and riscv.

Thanks !
My investigation of this problem 1 year ago lead me to think it was relocation related but I'm clueless on how that work.
I'll try to test that asap (especially arm where I don't think we had a problem).

Wed, Sep 9, 6:43 AM

Mon, Sep 7

manu accepted D24065: Add Arm pl061 GPIO driver.

LGTM

Mon, Sep 7, 4:41 PM
manu accepted D26350: x11/lib{wacom,input}: update to 1.5 / 1.16.1.

LGTM

Mon, Sep 7, 11:04 AM
manu added a comment to D25984: pkgbase: Add incremental package.

I'll update this review so we use pkg query '%X' from pkg 1.15 to get the internal checksum of the package and check if we need to update it.

Mon, Sep 7, 10:05 AM
manu committed rP547886: ports-mgmt/pkg: Update to 1.15.
ports-mgmt/pkg: Update to 1.15
Mon, Sep 7, 10:02 AM

Sun, Sep 6

manu accepted D26338: Correct COMMENT of devel/*-elf-gcc.
Sun, Sep 6, 2:04 PM

Sat, Sep 5

manu added a comment to D26338: Correct COMMENT of devel/*-elf-gcc.

BTW, why is the name of riscv32-unknown-elf-gcc different from others?

Sat, Sep 5, 8:18 PM
manu added a comment to D26338: Correct COMMENT of devel/*-elf-gcc.

arm-none-eabi-gcc is missing

Sat, Sep 5, 6:18 PM
manu accepted D26329: arm64: fix incorrect HWCAP definitions.
Sat, Sep 5, 4:12 PM
manu committed rP547650: graphics/drm-devel-kmod: Require latest gpu-firmware.
graphics/drm-devel-kmod: Require latest gpu-firmware
Sat, Sep 5, 2:01 PM
manu committed rP547649: graphics/drm-devel-kmod: Update to v5.4.62.
graphics/drm-devel-kmod: Update to v5.4.62
Sat, Sep 5, 1:25 PM

Fri, Sep 4

manu added inline comments to D26250: Add backlight subsystem.
Fri, Sep 4, 5:27 PM

Thu, Sep 3

manu updated the diff for D26274: drm2: Move files to files.arm and remove the obsolete message.
Thu, Sep 3, 3:48 PM
manu added a comment to D25598: release: Add an image for CI.

ping ?

Thu, Sep 3, 3:36 PM
manu added a comment to D26253: linuxkpi: Add backlight support.

No this is the right place for _if.h files.

Thu, Sep 3, 12:47 PM
manu updated the diff for D26253: linuxkpi: Add backlight support.

Add backlight_if.h to LINUXKPI_GENSRC variable.

Thu, Sep 3, 12:45 PM
manu updated the diff for D26250: Add backlight subsystem.

Add backlight.9 here.

Thu, Sep 3, 12:40 PM
manu updated the diff for D26251: Add backlight(8).

Don't add the man9 page here

Thu, Sep 3, 12:40 PM
manu updated the diff for D26253: linuxkpi: Add backlight support.

Address @hselasky's comments.

Thu, Sep 3, 12:35 PM
manu committed rP547440: drm-devel-kmod: Update to 5.4.58.g20200818.
drm-devel-kmod: Update to 5.4.58.g20200818
Thu, Sep 3, 12:19 PM
manu accepted D26307: aw_clk_nm: fix incorrect use of abs().
Thu, Sep 3, 10:31 AM
manu accepted D26309: twsi: use tsleep instead of pause for better responsiveness.
Thu, Sep 3, 9:33 AM
manu added a comment to D26309: twsi: use tsleep instead of pause for better responsiveness.

Ah, didn't knew that, thanks for finding this.

Thu, Sep 3, 9:33 AM
manu accepted D26308: twsi: some variants clear interrupt flag by writing 0, others by writing 1.

Mhm I was sure that the read was needed and I think it was H3 that I tested that with, but since you have H3 I guess I was wrong.

Thu, Sep 3, 9:31 AM
manu added a comment to D26307: aw_clk_nm: fix incorrect use of abs().

Thanks, I had no time to fix this.
abs is used on more clock drivers for allwinner so I think that adding the inline function to aw_clk.h would be better.

Thu, Sep 3, 9:28 AM

Wed, Sep 2

manu added a comment to D26226: ng_ether: Enter NET_EPOCH where required.

Thanks a lot.

Wed, Sep 2, 8:30 AM

Tue, Sep 1

manu added a comment to D26277: linuxkpi: firmware.
In D26277#584197, @bz wrote:
In D26277#584196, @manu wrote:
In D26277#584194, @bz wrote:
In D26277#584193, @manu wrote:
In D26277#584190, @bz wrote:
In D26277#584185, @bz wrote:
In D26277#584141, @manu wrote:

Note that this commit, once approved, should be synced with ports update to drm-current-kmod and drm-devel-kmod.

I'll do the due-diligens based on the URL you gave me earlier to see what else we have as common code; which of the branches there do I need to check?

Then we can put it all up (either yours or mine) in here for review, cross-check that all still works and get it into FreeBSD in one go, which should make checking in ports for available functionality in base a lot easier. In other words, I'll not push this into head alone if there's other stuff.

Question: given the linux_firmware.c file there has no author or license on it, do I have to assume the files there are indeed as the directory tree suggests gplv2? Because if they are I don't want to go near their contents.

No, if you look at the history it was imported by markj from drm-next, mmacy is the author I think

Cool. Which branches should I all check or is the linuxkpi basically identical?

The firmware part is identical everywhere (even at https://github.com/FreeBSDDesktop/kms-drm)

And the rest of all the linuxkpi changes. I have a ton sitting here locally. Hence my question, which branches to all check in your trees.

Tue, Sep 1, 6:35 PM
manu added a comment to D26277: linuxkpi: firmware.
In D26277#584194, @bz wrote:
In D26277#584193, @manu wrote:
In D26277#584190, @bz wrote:
In D26277#584185, @bz wrote:
In D26277#584141, @manu wrote:

Note that this commit, once approved, should be synced with ports update to drm-current-kmod and drm-devel-kmod.

I'll do the due-diligens based on the URL you gave me earlier to see what else we have as common code; which of the branches there do I need to check?

Then we can put it all up (either yours or mine) in here for review, cross-check that all still works and get it into FreeBSD in one go, which should make checking in ports for available functionality in base a lot easier. In other words, I'll not push this into head alone if there's other stuff.

Question: given the linux_firmware.c file there has no author or license on it, do I have to assume the files there are indeed as the directory tree suggests gplv2? Because if they are I don't want to go near their contents.

No, if you look at the history it was imported by markj from drm-next, mmacy is the author I think

Cool. Which branches should I all check or is the linuxkpi basically identical?

Tue, Sep 1, 6:29 PM
manu added a comment to D26277: linuxkpi: firmware.
In D26277#584190, @bz wrote:
In D26277#584185, @bz wrote:
In D26277#584141, @manu wrote:

Note that this commit, once approved, should be synced with ports update to drm-current-kmod and drm-devel-kmod.

I'll do the due-diligens based on the URL you gave me earlier to see what else we have as common code; which of the branches there do I need to check?

Then we can put it all up (either yours or mine) in here for review, cross-check that all still works and get it into FreeBSD in one go, which should make checking in ports for available functionality in base a lot easier. In other words, I'll not push this into head alone if there's other stuff.

Question: given the linux_firmware.c file there has no author or license on it, do I have to assume the files there are indeed as the directory tree suggests gplv2? Because if they are I don't want to go near their contents.

Tue, Sep 1, 6:10 PM
manu added a comment to D26277: linuxkpi: firmware.

Note that this commit, once approved, should be synced with ports update to drm-current-kmod and drm-devel-kmod.

Tue, Sep 1, 4:38 PM
manu added inline comments to D26277: linuxkpi: firmware.
Tue, Sep 1, 4:30 PM
manu added inline comments to D26277: linuxkpi: firmware.
Tue, Sep 1, 4:04 PM
manu added a comment to D26274: drm2: Move files to files.arm and remove the obsolete message.
In D26274#584056, @mmel wrote:

imho, also drm2 option should be moved to options.arm. otherwise, NOTES kernels may fail. I'm OK with rest

Tue, Sep 1, 3:52 PM
manu added inline comments to D26277: linuxkpi: firmware.
Tue, Sep 1, 3:50 PM
manu accepted D26275: Improve drm deprecation message.

LGTM.
Note that it would be better to direct commit to 12, no need to first commit to 13.
This will be, anyway, removed by D26274

Tue, Sep 1, 3:17 PM
manu added a reviewer for D26275: Improve drm deprecation message: mmel.
Tue, Sep 1, 3:00 PM
manu added inline comments to D26275: Improve drm deprecation message.
Tue, Sep 1, 3:00 PM
manu updated the summary of D26274: drm2: Move files to files.arm and remove the obsolete message.
Tue, Sep 1, 2:46 PM
manu requested review of D26274: drm2: Move files to files.arm and remove the obsolete message.
Tue, Sep 1, 2:45 PM
manu added a comment to D26153: SDHCI: Introduce a driver for NXP QorIQ LS10xx SoCs..

Regarding the partitions: it would be interesting to see the output of ls /dev/sdda* on MMCCAM kernel, probably the partitions got detected but not printed on boot.

With GENERIC-MMCCAM, my kernel failed to mount a rootfs located on an unrelated usb drive (perhaps this hints towards a bigger issue?), so I wasn't able to properly inspect the mmc partitions from userspace. I did however list all available drives via mountroot and there were no partitions listed for sdda0.

Tue, Sep 1, 12:37 PM
manu accepted D26153: SDHCI: Introduce a driver for NXP QorIQ LS10xx SoCs..
Tue, Sep 1, 11:40 AM