Page MenuHomeFreeBSD

manu (Emmanuel Vadot)
User

Projects (8)

User Details

User Since
Apr 24 2016, 4:47 PM (263 w, 1 d)

Recent Activity

Fri, May 7

manu accepted D30169: rpi_ft5406: Recognize raspberrypi,firmware-ts touchscreen.
Fri, May 7, 10:08 PM
manu accepted D30165: 'port' property support.
Fri, May 7, 9:55 PM
manu added a comment to D30169: rpi_ft5406: Recognize raspberrypi,firmware-ts touchscreen.

LGTM, just one comment and we're good.

Fri, May 7, 9:55 PM

Thu, May 6

manu accepted D26870: arm64: rockchip, implement the two rk808 clocks.
Thu, May 6, 3:29 PM
manu added a comment to D26870: arm64: rockchip, implement the two rk808 clocks.

The clocks are the same for rk805 so please prefix all function rk805 instead of rk808.
Otherwise looks good.

Thu, May 6, 2:57 PM

Wed, May 5

manu accepted D30123: sdhci_fsl_fdt.c: Read supported voltages from dts..
Wed, May 5, 3:46 PM
manu added a comment to D30122: sdhci_fsl_fdt.c: Add a missing call to mmc_fdt_parse..

Now they are parsed but you don't use them.
See https://cgit.freebsd.org/src/commit/sys/arm/allwinner/aw_mmc.c?id=9ed8321078444aea2a90a361f91e54065d5daf21 for how to use it.

Wed, May 5, 3:41 PM
manu accepted D30121: sdhci_fsl_fdt.c: Add support for LS1028a..
Wed, May 5, 3:39 PM
manu accepted D30120: sdhci_fsl_fdt.c: Specify base clk divisor per SoC. .
Wed, May 5, 3:39 PM
manu added a comment to D30103: Add a simple-framebuffer vt driver.

We don't have a device_t to use this early so would need to create a driver to attach to the same node later in the boot. One of the problems is it's a child of /chosen so doesn't get probed. For testing I created a chosen driver we could use that attaches to the chosen node and adds any children it finds.

Wed, May 5, 9:02 AM
manu added a comment to D30103: Add a simple-framebuffer vt driver.

I can easily add more formats, although can't test the clocks as I don't have hardware that has the clocks property.

Wed, May 5, 8:27 AM
manu added a comment to D30103: Add a simple-framebuffer vt driver.

I don't think it make much sense to commit that without all formats supported and clocks, efifb should be good enough instead. (and yes I know that it's not on the mac blah that you're working on :P )

Wed, May 5, 7:55 AM

Tue, May 4

manu accepted D30067: graphics/wayland-protocols: update to 1.21.

Ping. Getting this port up-to-date is important for upstream CI of consumers.

Tue, May 4, 7:10 AM

Mon, May 3

manu added a comment to D30081: pkgbase: Put openssl in its own package.

I'll also add a note in UPDATING that for pkgbase users they will need to pkg install -f FreeBSD-openssl before pkg upgrade.
Otherwise everything goes boom.

Mon, May 3, 12:03 PM
manu updated the diff for D30081: pkgbase: Put openssl in its own package.

Add libcrypto too

Mon, May 3, 12:02 PM
manu added a comment to D30088: pkgbase: Move librt to clibs.

how will this behave on pkg upgrade?

Mon, May 3, 11:59 AM
manu added a comment to D30081: pkgbase: Put openssl in its own package.

I forgot libcrypto, will update later today.

Mon, May 3, 9:34 AM
manu added a reviewer for D30088: pkgbase: Move librt to clibs: pkgbase.
Mon, May 3, 8:27 AM
manu requested review of D30088: pkgbase: Move librt to clibs.
Mon, May 3, 8:27 AM

Sun, May 2

manu updated the diff for D30081: pkgbase: Put openssl in its own package.

Add openssl comment and desc in Makefile.package

Sun, May 2, 8:04 PM
manu added a comment to D30081: pkgbase: Put openssl in its own package.

perhaps an entry in release/packages/Makefile.package
could be useful

Sun, May 2, 8:01 PM
manu updated the test plan for D30081: pkgbase: Put openssl in its own package.
Sun, May 2, 7:43 PM
manu requested review of D30081: pkgbase: Put openssl in its own package.
Sun, May 2, 7:43 PM
manu added a comment to D30079: Map arm64 pci config memory as non-posted.

Maybe it would be simpler and more clear to have a new memory type for struct resource for PCI config region that all the bus_* routines will know ?

Sun, May 2, 1:25 PM
manu added inline comments to D30038: mmccam: Add two new XPT for MMC and use them in mmc_sim and sdhci.
Sun, May 2, 9:16 AM
manu accepted D30075: Update sysutils/uefi-edk2-bhyve to edk2-stable202002 release.
Sun, May 2, 9:12 AM

Sat, May 1

manu added a comment to D26870: arm64: rockchip, implement the two rk808 clocks.

Do you plan to continue working on this ?

Sat, May 1, 1:51 PM

Thu, Apr 29

manu updated the test plan for D30038: mmccam: Add two new XPT for MMC and use them in mmc_sim and sdhci.
Thu, Apr 29, 3:54 PM
manu added reviewers for D30038: mmccam: Add two new XPT for MMC and use them in mmc_sim and sdhci: kibab, imp.
Thu, Apr 29, 3:53 PM
manu requested review of D30038: mmccam: Add two new XPT for MMC and use them in mmc_sim and sdhci.
Thu, Apr 29, 3:53 PM

Wed, Apr 28

manu accepted D30005: pkg(7): replace usage of sbuf(9) with open_memstream(3).
Wed, Apr 28, 9:58 AM

Tue, Apr 27

manu committed R10:f77d8d10115b: dwc: Use mii_fdt function (authored by manu).
dwc: Use mii_fdt function
Tue, Apr 27, 5:08 PM
manu committed R10:80020d788834: mmccam: probe*: Style(9) (authored by manu).
mmccam: probe*: Style(9)
Tue, Apr 27, 5:04 PM
manu committed R10:e017c1c92c99: mmcprobe_done: Style(9) (authored by manu).
mmcprobe_done: Style(9)
Tue, Apr 27, 5:04 PM
manu committed R10:7cbdf8a05db7: dwmmc: Add \n to a debug printf (authored by manu).
dwmmc: Add \n to a debug printf
Tue, Apr 27, 5:02 PM
manu committed R10:2671bdb540c5: allwinner: aw_mmc: Convert driver to use the mmc_sim interface (authored by manu).
allwinner: aw_mmc: Convert driver to use the mmc_sim interface
Tue, Apr 27, 5:02 PM
manu committed R10:f1cc48e5da50: mmc: dwmmc: Convert driver to use the mmc_sim interface (authored by manu).
mmc: dwmmc: Convert driver to use the mmc_sim interface
Tue, Apr 27, 5:02 PM
manu committed R10:47bde7925b41: mmccam: Add mmc_sim, a generic sim for mmc driver to use (authored by manu).
mmccam: Add mmc_sim, a generic sim for mmc driver to use
Tue, Apr 27, 5:02 PM
manu closed D27487: mmc: dwmmc: Convert driver to use the mmc_sim interface.
Tue, Apr 27, 5:01 PM
manu closed D27486: allwinner: aw_mmc: Convert driver to use the mmc_sim interface.
Tue, Apr 27, 5:01 PM
manu closed D27485: mmccam: Add mmc_sim, a generic sim for mmc driver to use.
Tue, Apr 27, 5:01 PM

Mon, Apr 26

manu accepted D29999: fix dwmmc card detect.
Mon, Apr 26, 8:57 PM
manu added inline comments to D29999: fix dwmmc card detect.
Mon, Apr 26, 8:48 PM
manu requested changes to D29999: fix dwmmc card detect.
Mon, Apr 26, 7:39 PM
manu added a comment to D29999: fix dwmmc card detect.

There is a property in the DTS for that :
https://cgit.freebsd.org/src/tree/sys/contrib/device-tree/src/arm64/altera/socfpga_stratix10_socdk.dts#n111
And we parse this in :
https://cgit.freebsd.org/src/tree/sys/dev/mmc/mmc_fdt_helpers.c#n124
And :
https://cgit.freebsd.org/src/tree/sys/dev/mmc/host/dwmmc.c#n530

Mon, Apr 26, 7:39 PM
manu added inline comments to D29998: linuxkpi: Conform to style(9) in atomic_dec_and_lock_irqsave().
Mon, Apr 26, 5:20 PM
manu accepted D29996: Add committer entries for myself, OH.

LGTM
But since the docs about this part isn't up to date just wait that someone from docs review this.

Mon, Apr 26, 5:19 PM
manu added a reviewer for D29996: Add committer entries for myself, OH: Doc Committers.
Mon, Apr 26, 5:18 PM
manu accepted D29883: Remove name mangling in generate-ucl.sh.
In D29883#672527, @manu wrote:

I don't remember why I did this but yes this solve some dependencies issues.

Ok, thanks. I think I will go ahead and commit this with a generous MFC period to see if I break anything. The original name mangling was added long enough ago that I want to believe that whatever problem it solved no longer exists.

Mon, Apr 26, 1:10 PM
manu accepted D29822: devel/libepoll-shim: update to 0.0.20210418.
Mon, Apr 26, 12:41 PM
manu accepted D29988: linuxkpi: Implement atomic_dec_and_lock_irqsave().

Same comment as Hans :)
And please bump FreeBSD_version so we can check this in the drm-devel-kmod in the near futur.

Mon, Apr 26, 7:43 AM
manu accepted D29987: linuxkpi: Implement the wait_event_interruptible macro.
Mon, Apr 26, 7:42 AM

Sun, Apr 25

manu added a comment to D29883: Remove name mangling in generate-ucl.sh.

I don't remember why I did this but yes this solve some dependencies issues.

Sun, Apr 25, 2:29 PM

Thu, Apr 22

manu accepted D29923: arm: add a release conf for distribution files.
Thu, Apr 22, 1:53 PM

Wed, Apr 21

manu accepted D29890: Add myself as src commiters.

Don't forget the Approved by: manu (mentor) in the commit.

Wed, Apr 21, 5:01 PM

Tue, Apr 20

manu added a comment to D29848: config: create a 'requires' keyword for files file processing.

What's the difference between this and making an non-optional requirement for the file ?
Is it just to have a nicer error message than a linker error ?
Looking at D29849 it seems that the same thing could be achieve by adding "iflib" in every em(4) related file and since em(4)
needs iflib I think that's the proper way of "fixing" this problem.

Tue, Apr 20, 7:45 AM

Mon, Apr 19

manu committed R11:cdbfe8c1c983: graphics/drm-fbsd13-kmod: Update to 5.4.92.g20210419 (authored by manu).
graphics/drm-fbsd13-kmod: Update to 5.4.92.g20210419
Mon, Apr 19, 8:20 AM
manu committed R11:7c1c47427fb7: graphics/drm-{current,devel}-kmod: Update to 5.4.92.g20210419 (authored by manu).
graphics/drm-{current,devel}-kmod: Update to 5.4.92.g20210419
Mon, Apr 19, 8:19 AM
manu committed R11:2a988f4b237f: graphics/drm-fbsd13-kmod: Update to 5.4.92.g20210419 (authored by manu).
graphics/drm-fbsd13-kmod: Update to 5.4.92.g20210419
Mon, Apr 19, 8:19 AM

Fri, Apr 16

manu added a reviewer for D29313: arm64: initial support for px30 and rk3326: arm64.
Fri, Apr 16, 8:01 AM
manu updated subscribers of D29313: arm64: initial support for px30 and rk3326.

We talked on irc but here is the brief version :

Fri, Apr 16, 8:01 AM

Thu, Apr 15

manu committed R10:f41efc453ab5: Fix build with WITHOUT_AUDIT=yes in src.conf (authored by manu).
Fix build with WITHOUT_AUDIT=yes in src.conf
Thu, Apr 15, 12:13 PM

Wed, Apr 14

manu accepted D29759: Switch the EFI virtual address to a uint64_t.
Wed, Apr 14, 8:04 PM
manu added a comment to D29758: mmc_da: restore HS200 support that was present in MMCCAM branch.

For the 1.2V report it's probably the same problem as the one fixed by 1a96c1434f4b4487126f13ede29e67ad44a8776a

Wed, Apr 14, 7:54 PM
manu added a comment to D29758: mmc_da: restore HS200 support that was present in MMCCAM branch.
In D29758#667519, @avg wrote:

Is this the information you asked for?

# camcontrol devlist -v       
scbus0 on aw_mmc_sim0 bus 0:
scbus1 on aw_mmc_sim1 bus 0:
<SDIO card>                        at scbus1 target 0 lun 0 (sdiob0,pass1)
scbus2 on aw_mmc_sim2 bus 0:
<MMCHC 8GME4R 0.1 SN 4DAD8E5D MFG 09/200>  at scbus2 target 0 lun 0 (sdda0,pass0)
scbus-1 on xpt0 bus 0:
<>                                 at scbus-1 target -1 lun ffffffff (xpt0)

# camcontrol mmcsdcmd 2:0:0 -I
Host controller information
Host OCR: 0x300000
Min frequency: 400 KHz
Max frequency: 52 MHz
Supported bus width:
 4 bit
 8 bit
Supported operating modes:
 Can do High Speed transfers
Supported VCCQ voltages:
 3.3V
Current settings:
 Bus width: 8 bit
 Freq: 52.000 MHz (high-speed timing)
 VCCQ: 1.2V
Wed, Apr 14, 4:28 PM
manu added a comment to D29758: mmc_da: restore HS200 support that was present in MMCCAM branch.

What is the resulting chosen mode ? You can query with camcontrol
I have no problem with DDR52 on all my boards and I don't remember if anything else was missing to have proper hs200 on all Allwinner boards.

Wed, Apr 14, 1:48 PM
manu committed R10:0c80ad2dc689: arm: Add no-cftconvert for sdma-imx6 files (authored by manu).
arm: Add no-cftconvert for sdma-imx6 files
Wed, Apr 14, 1:45 PM

Tue, Apr 13

manu committed R11:23351ba6e55b: x11/xorg-server: Update to 1.20.11 (authored by manu).
x11/xorg-server: Update to 1.20.11
Tue, Apr 13, 7:46 PM
manu committed R11:fdd94741382f: x11/xorg-server: Update to 1.20.11 (authored by manu).
x11/xorg-server: Update to 1.20.11
Tue, Apr 13, 3:51 PM
manu committed R11:f7859bc73471: security/vuxml: Document xorg-server vuln (authored by manu).
security/vuxml: Document xorg-server vuln
Tue, Apr 13, 3:51 PM

Mon, Apr 12

manu accepted D29722: Add a way to map arm64 non-posted device memory.
Mon, Apr 12, 4:04 PM
manu accepted D29722: Add a way to map arm64 non-posted device memory.
Mon, Apr 12, 11:51 AM
manu added inline comments to D29722: Add a way to map arm64 non-posted device memory.
Mon, Apr 12, 11:34 AM
manu committed R10:9f7ff9fe8450: Remove tmpfs size and properly format generated fstab for arm (authored by daniel.engberg.lists_pyret.net).
Remove tmpfs size and properly format generated fstab for arm
Mon, Apr 12, 3:49 AM

Sun, Apr 11

manu accepted D29707: Remove versatile support.
Sun, Apr 11, 7:30 PM

Apr 9 2021

manu accepted D29675: linuxkpi: Fix pcie_set_readrq().
Apr 9 2021, 3:49 PM
manu added a comment to D29664: x11/libxkbcommon: update to 1.2.1.

Landed as series of commits. Phabricator doesn't track Git-based ports/ repo yet.

For Submitted-by you can git commit --author=...

Not all changes can be split into logical units authored by a single person. In this case splitting was possible. Can I expect the same from x11 team? ;)

Apr 9 2021, 12:50 PM
manu accepted D29664: x11/libxkbcommon: update to 1.2.1.
Apr 9 2021, 8:00 AM
manu added a comment to D29664: x11/libxkbcommon: update to 1.2.1.

LGTM
For Submitted-by you can git commit --author=...

Apr 9 2021, 8:00 AM

Apr 7 2021

manu accepted D29624: Remove the last users of ARM_TP_ADDRESS.
Apr 7 2021, 12:15 PM

Apr 6 2021

manu accepted D29492: Add more inodes to VM images by having makefs allocate extra inodes when making images with free space..

Small nits but otherwise lgtm

Apr 6 2021, 1:09 PM
manu committed R9:07d43e86a81a: pgpkeys: Add my new gpg key (authored by manu).
pgpkeys: Add my new gpg key
Apr 6 2021, 10:04 AM

Apr 2 2021

manu accepted D29547: am335x_ehrpwm.c add support for flags (PWM_POLARITY_INVERTED).
Apr 2 2021, 1:21 PM · ARM
manu accepted D29546: am335x_ehrpwm.c remove sysctl interface.

I'll leave this for a few days in case someone have an objection.

Apr 2 2021, 1:19 PM · ARM

Apr 1 2021

manu added a comment to D29534: spibus: add cs_delay ivar.

That doesn't seems to be specific to the Apple hardware but to the intel controller.
Linux notes that after changing CS one should wait 2 clock cycles (spi controller clock).
Our driver doesn't seems to do anything about clock and just hardcode based on the one found on the MinowBoard.
Anyway, that seems more controller specific than SPI specific so I'm not sure that this is the correct approach.

Apr 1 2021, 3:22 PM
manu added a comment to D29514: LinuxKPI: treat firmware file names more lenient.

LGTM
There don't seems to be drm firmware with '-' in it btw.

Apr 1 2021, 6:27 AM

Mar 30 2021

manu added inline comments to D28803: arm64: Don't rely on firmware interrupt mapping in ICU.
Mar 30 2021, 4:01 PM
manu added inline comments to D28803: arm64: Don't rely on firmware interrupt mapping in ICU.
Mar 30 2021, 3:50 PM
manu committed R10:8ebda6e44bb6: efifb,vbefb: implement vd_fini (authored by greg_unrelenting.technology).
efifb,vbefb: implement vd_fini
Mar 30 2021, 3:49 PM
manu closed D29020: efifb,vbefb: implement vd_fini.
Mar 30 2021, 3:48 PM

Mar 29 2021

manu accepted D29490: Update 13.0 aarch SD card images based on actual filenames.
Mar 29 2021, 9:26 PM

Mar 28 2021

manu committed R10:d6616e3dbaee: release: amd64: Fix ISO/USB hybrid image (authored by manu).
release: amd64: Fix ISO/USB hybrid image
Mar 28 2021, 6:56 PM
manu committed R10:1c1ff7979571: pkgbase: make only vital packages vital, not their sub-packages (authored by me_igalic.co).
pkgbase: make only vital packages vital, not their sub-packages
Mar 28 2021, 10:19 AM
manu closed D29224: make only vital packages vital, not their sub-packages.
Mar 28 2021, 10:19 AM · pkgbase

Mar 27 2021

manu accepted D27859: ichsmb: Add support for Intel Comet Lake and Tiger Lake.

Obtain from linux seems a bit much for me, it's just pci id that you're adding.
Otherwise looks good.

Mar 27 2021, 8:55 PM
manu committed R10:90d2f7c413f9: release: amd64: Fix ISO/USB hybrid image (authored by manu).
release: amd64: Fix ISO/USB hybrid image
Mar 27 2021, 11:10 AM
manu committed R10:08639983e038: release: amd64: Fix ISO/USB hybrid image (authored by manu).
release: amd64: Fix ISO/USB hybrid image
Mar 27 2021, 11:10 AM

Mar 26 2021

manu accepted D29426: Add a @touch to replace all the @exec touch.
Mar 26 2021, 5:23 PM

Mar 25 2021

manu accepted D29422: x11/libxkbcommon: update to 1.1.0.
Mar 25 2021, 5:27 PM

Mar 24 2021

manu accepted D29254: sysutils/uefi-edk2-bhyve-csm: only depend on gcc48 for building.

done :)

Mar 24 2021, 8:01 PM