Page MenuHomeFreeBSD

manu (Emmanuel Vadot)
User

Projects

User Details

User Since
Apr 24 2016, 4:47 PM (199 w, 2 d)

Recent Activity

Mon, Feb 17

manu accepted D23644: graphics/wayland: convert to USES=meson.
Mon, Feb 17, 8:18 PM
manu committed rP526382: lang/beignet: Set deprecated and expiration date.
lang/beignet: Set deprecated and expiration date
Mon, Feb 17, 5:55 PM
manu committed rP526380: x11-drivers/xf86-video-scfb: update to 0.0.5.
x11-drivers/xf86-video-scfb: update to 0.0.5
Mon, Feb 17, 4:32 PM

Sun, Feb 16

manu updated subscribers of D23715: devel/libudev-devd: update to 0.4.0.2.

@zeising could you merge the github MR and roll a new release please ?
The review could be updated after that.
Thanks.

Sun, Feb 16, 1:03 PM

Sat, Feb 15

manu committed rP526238: devel/nextpnr: Mark broken for i386.
devel/nextpnr: Mark broken for i386
Sat, Feb 15, 7:52 PM
manu added a comment to D23696: graphics/wayland: replace posix_fallocate hack with a proper fix.
In D23696#520296, @manu wrote:
In D23696#520294, @manu wrote:

Stalled until someone can reproduce the original issue. I dogfood XDG_RUNTIME_DIR=/var/run/$USER on tmpfs(5). Sway works fine even after changing XDG_RUNTIME_DIR to point to a directory on ZFS

With your patches you mean ?

Without the hack and my patches from here. However, I can't rely on my QA alone as I have a number of patches against kernel/userland/ports/etc.

Ok, I'll try on my machine.

Sat, Feb 15, 7:11 PM
manu added a comment to D23696: graphics/wayland: replace posix_fallocate hack with a proper fix.
In D23696#520294, @manu wrote:

Stalled until someone can reproduce the original issue. I dogfood XDG_RUNTIME_DIR=/var/run/$USER on tmpfs(5). Sway works fine even after changing XDG_RUNTIME_DIR to point to a directory on ZFS

With your patches you mean ?

Without the hack and my patches from here. However, I can't rely on my QA alone as I have a number of patches against kernel/userland/ports/etc.

Sat, Feb 15, 4:33 PM
manu added a comment to D23696: graphics/wayland: replace posix_fallocate hack with a proper fix.

Stalled until someone can reproduce the original issue. I dogfood XDG_RUNTIME_DIR=/var/run/$USER on tmpfs(5). Sway works fine even after changing XDG_RUNTIME_DIR to point to a directory on ZFS

Sat, Feb 15, 4:18 PM
manu added a comment to D23696: graphics/wayland: replace posix_fallocate hack with a proper fix.

Looks promising, let's wait a bit for upstream to at least ack the patches.

Sat, Feb 15, 4:03 PM
manu accepted D23686: x11/libxkbcommon: update to 0.10.0.

Yeah Niclas directed me to the meson lines WRT wayland.
LGTM.

Sat, Feb 15, 3:13 PM
manu added a comment to D23653: lang/rust: add WEBASM (WebAssembly) option.

Approved-by: manu (mentor)

Sat, Feb 15, 2:04 PM
manu added a comment to D23686: x11/libxkbcommon: update to 0.10.0.

I'm not super familiar with this lib and how it works but we compile it with --disable-wayland so I'm wondering why this swich is set and how it worked for you. Could you explain more on this ?
Otherwise patch looks good to me.

Sat, Feb 15, 2:03 PM
manu added inline comments to D23644: graphics/wayland: convert to USES=meson.
Sat, Feb 15, 1:57 PM

Fri, Feb 14

manu added a comment to D23643: graphics/wayland: Update to 1.18.

Build finished, tested ok with sway so I think we're good to go.

Fri, Feb 14, 11:06 AM
manu accepted D23643: graphics/wayland: Update to 1.18.

LGTM
I've started a build to test on my laptops later today.
ping @zeising for x11 approval.

Fri, Feb 14, 9:09 AM

Thu, Feb 13

manu added a member for x11: manu.
Thu, Feb 13, 2:48 PM

Wed, Feb 12

manu accepted D23650: lang/rust: strip libraries.

LGTM

Wed, Feb 12, 4:50 PM
manu accepted D23649: lang/rust: trim whitespace.

Just commit trivial stuff like this.

Wed, Feb 12, 4:50 PM

Sun, Feb 9

manu added a comment to D23592: Import DTS files tux_5.5_bcm RPI4.

Note that we also use dtb from the rpi-firmware package for RPI* board.

Sun, Feb 9, 4:47 PM
manu added a comment to D23592: Import DTS files tux_5.5_bcm RPI4.

I do import DTS files by bulk.
I'll deal with 5.5 import next week.

Sun, Feb 9, 4:46 PM

Tue, Feb 4

manu committed rP525130: devel/riscv32-unknown-elf-gcc: Add new port.
devel/riscv32-unknown-elf-gcc: Add new port
Tue, Feb 4, 8:41 AM
manu committed rP525129: devel/binutils: Add support for riscv32-unknown-elf.
devel/binutils: Add support for riscv32-unknown-elf
Tue, Feb 4, 8:39 AM

Mon, Feb 3

manu committed rP525030: devel/lattice-ice40-examples-hx8k: Take maintainer's ship.
devel/lattice-ice40-examples-hx8k: Take maintainer's ship
Mon, Feb 3, 12:04 PM
manu committed rP525029: devel/lattice-ice40-examples-hx1k: Take maintainer's ship.
devel/lattice-ice40-examples-hx1k: Take maintainer's ship
Mon, Feb 3, 12:03 PM
manu committed rP525027: devel/icestorm: Take maintainer's ship.
devel/icestorm: Take maintainer's ship
Mon, Feb 3, 11:15 AM

Wed, Jan 29

manu accepted D23415: pkgbase: generate dependencies in generate-ucl.sh.
Wed, Jan 29, 8:22 PM
manu added a reviewer for D23415: pkgbase: generate dependencies in generate-ucl.sh: pkgbase.
Wed, Jan 29, 7:48 PM
manu accepted D23352: pkgbase: fix caroot packaging and add post-install script.
Wed, Jan 29, 1:46 PM

Tue, Jan 28

manu accepted D23386: Provide support for fdevname(3) on linuxkpi-backed devices..

Thanks, works great now.

Tue, Jan 28, 8:37 AM
manu added a comment to D23386: Provide support for fdevname(3) on linuxkpi-backed devices..

Tested with both /dev/drm/0 and /dev/dri/card0 (which is a link to /dev/drm/0) and fdevname just returns "drm".
Which is better than NULL but mostly useless for libdrm use case.
But that might be the way those dev are created in drm-kmod.

Tue, Jan 28, 8:13 AM

Mon, Jan 27

manu committed rP524267: devel/aarch64-none-elf-gcc: Take maintainer ship.
devel/aarch64-none-elf-gcc: Take maintainer ship
Mon, Jan 27, 5:32 PM

Mon, Jan 20

manu accepted D23286: Change my mail address to mikael@FreeBSD.org.
Mon, Jan 20, 8:05 PM

Jan 19 2020

manu committed rS356895: zilinx/zy7_qspi: Add a qspi driver for Zynq platforms..
zilinx/zy7_qspi: Add a qspi driver for Zynq platforms.
Jan 19 2020, 8:05 PM
manu closed D14698: [new driver] zilinx/zy7_qspi: Add a qspi driver for Zynq platforms..
Jan 19 2020, 8:05 PM · ARM
manu accepted D14698: [new driver] zilinx/zy7_qspi: Add a qspi driver for Zynq platforms..
Jan 19 2020, 7:59 PM · ARM
manu committed rS356893: rk805: Add a regnode_init method.
rk805: Add a regnode_init method
Jan 19 2020, 7:57 PM
manu closed D23216: rk805: Add a regnode_init method.
Jan 19 2020, 7:57 PM
manu created D23268: aw_mmc: Add support to card detection.
Jan 19 2020, 7:55 PM
manu created D23267: Add mmc_fdt_helpers.
Jan 19 2020, 7:54 PM
manu committed rS356891: arm: allwinner: Add GPIO Interrupt support.
arm: allwinner: Add GPIO Interrupt support
Jan 19 2020, 7:51 PM
manu committed rS356888: arm: allwinner: Fix padconf for interrupts information.
arm: allwinner: Fix padconf for interrupts information
Jan 19 2020, 7:15 PM

Jan 18 2020

manu accepted D23255: pkgbase: cache pkg ABI for all world/kernel packages.

LGTM

Jan 18 2020, 10:30 PM
manu committed rP523423: mail/opensmtpd-filter-senderscore: New port.
mail/opensmtpd-filter-senderscore: New port
Jan 18 2020, 4:19 PM
manu committed rP523421: mail/opensmtpd-filter-rspamd: New Port.
mail/opensmtpd-filter-rspamd: New Port
Jan 18 2020, 4:17 PM

Jan 17 2020

manu accepted D23226: Add myself (mikael) as a ports commiter.
Jan 17 2020, 10:37 AM
manu accepted D23227: Add myself (mikael) as a ports commiter / Mentor and Mentee Information.
Jan 17 2020, 10:25 AM
manu added a comment to D23085: DRM: Add DRM core files and DRMKPI.

Probably I asked already, but can the DRMKPI be used at the same time another driver is using the LinuxKPI?

Jan 17 2020, 9:37 AM
manu added inline comments to D14698: [new driver] zilinx/zy7_qspi: Add a qspi driver for Zynq platforms..
Jan 17 2020, 9:27 AM · ARM

Jan 16 2020

manu committed rS356813: dwmmc: Remove max_hz from the softc.
dwmmc: Remove max_hz from the softc
Jan 16 2020, 9:51 PM
manu added a comment to D23085: DRM: Add DRM core files and DRMKPI.

OK, I'll see if I can spend some time tomorrow to look at the code. Thank you!

Jan 16 2020, 9:30 PM
manu abandoned D15085: vm: uma_core: Test that uk_free_slab isn't empty before fetching the first element.
Jan 16 2020, 9:29 PM
manu abandoned D13395: devfs: Add siphash comparison.
Jan 16 2020, 9:28 PM
manu added a comment to D13395: devfs: Add siphash comparison.

No plan to update this now.

Jan 16 2020, 9:28 PM
manu added a comment to D15085: vm: uma_core: Test that uk_free_slab isn't empty before fetching the first element.

No plan to update this now.

Jan 16 2020, 9:28 PM
manu abandoned D15049: zfs: Correct reading of .zfs directory.
Jan 16 2020, 9:27 PM
manu added a comment to D15049: zfs: Correct reading of .zfs directory.

No plan to update this now.

Jan 16 2020, 9:27 PM
manu abandoned D13394: devfs: Remove devfs_pathpath.

No plan to update this anymore.

Jan 16 2020, 9:26 PM
manu abandoned D13624: arm: Split GENERIC into vendor files.

outdated

Jan 16 2020, 9:25 PM
manu committed rS356808: arm64: rockchip: Add RK3399 PWM driver.
arm64: rockchip: Add RK3399 PWM driver
Jan 16 2020, 9:25 PM
manu closed D19046: Rockchip RK3399 PWM driver.
Jan 16 2020, 9:25 PM · arm64
manu committed rS356807: arm64: rockchip: Add new interface for rk_pinctrl.
arm64: rockchip: Add new interface for rk_pinctrl
Jan 16 2020, 9:21 PM
manu closed D22849: arm64: rockchip: Add interface for rk_pinctrl.
Jan 16 2020, 9:21 PM
manu closed D23093: fdt_pinctrl: Add new methods for gpios.
Jan 16 2020, 9:19 PM
manu committed rS356806: fdt_pinctrl: Add new methods for gpios.
fdt_pinctrl: Add new methods for gpios
Jan 16 2020, 9:19 PM
manu created D23216: rk805: Add a regnode_init method.
Jan 16 2020, 9:17 PM
manu added inline comments to D14698: [new driver] zilinx/zy7_qspi: Add a qspi driver for Zynq platforms..
Jan 16 2020, 9:04 PM · ARM
manu abandoned D23007: regulator: Set correct uvolt value in regnode_set_constraint.

Changes will be made to the rk805 driver instead.

Jan 16 2020, 9:01 PM
manu committed rS356803: regulator_fixed: Add a get_voltage method.
regulator_fixed: Add a get_voltage method
Jan 16 2020, 8:52 PM
manu closed D23003: regulator_fixed: Add a get_voltage method.
Jan 16 2020, 8:52 PM
manu committed rS356802: arm: allwinner: ahci: target-supply is optional.
arm: allwinner: ahci: target-supply is optional
Jan 16 2020, 8:19 PM
manu committed rS356800: arm: allwinner: Add support for bank supply.
arm: allwinner: Add support for bank supply
Jan 16 2020, 8:03 PM
manu committed rS356799: axp8xx: Add a regnode_init method.
axp8xx: Add a regnode_init method
Jan 16 2020, 7:59 PM
manu committed rS356798: axp8xx: Add missing voltage regulators offset.
axp8xx: Add missing voltage regulators offset
Jan 16 2020, 7:58 PM
manu added a comment to D22060: Fixes and updates to Zynq u-boot ports.

I'll look into submitting the fix to u-boot but it won't appear until 2020.04.

Jan 16 2020, 5:28 PM
manu committed rP523251: Welcome Mikael Urankar (mikael@) as new ports commiter..
Welcome Mikael Urankar (mikael@) as new ports commiter.
Jan 16 2020, 5:15 PM
manu added a comment to D22060: Fixes and updates to Zynq u-boot ports.

This is pity that this patch get abandoned. If this patch fixes the issue, we can certainly readd these ports. @skibo and @manu , are you still interested in checking this?

Jan 16 2020, 3:00 PM

Jan 15 2020

manu accepted D23192: 2020-02-29 retire in-tree GPL dtc.
Jan 15 2020, 4:23 PM

Jan 14 2020

manu added a comment to D23093: fdt_pinctrl: Add new methods for gpios.
In D23093#507777, @ian wrote:

What kind of flags go into the flags arg? I suspect the quick answer is GPIO flags. The more complete answer is probably "some subset of gpio flags which differs from one device to another". That leads to the question of what to do on an attempt to set multiple flags where some are supported and some aren't.

Jan 14 2020, 10:02 AM

Jan 13 2020

manu committed rP522883: games/vvvvvv: Mark it only for amd64 until I test it on different arches.
games/vvvvvv: Mark it only for amd64 until I test it on different arches
Jan 13 2020, 12:29 PM

Jan 12 2020

manu added a comment to D23145: dwc(4) Ethernet MAC address setting/generating.
In D23145#507267, @manu wrote:
In D23145#507266, @bz wrote:

If it were to become a "generic" function, where would we put it?

No idea :)

I'd be tempted to stick such a thing in ^/sys/dev/fdt/fdt_common.c, since it's (edit: not) hooking much into ethernet stuff -- just determining a MAC address to use for a given node.

Jan 12 2020, 5:28 PM
manu added a comment to D23145: dwc(4) Ethernet MAC address setting/generating.
In D23145#507266, @bz wrote:
In D23145#507260, @manu wrote:

The bindings (https://github.com/torvalds/linux/blob/master/Documentation/devicetree/bindings/net/ethernet-controller.yaml#L16) seems to indicate
that mac-address should be used if it exists and is prefered to local-mac-address.
Maybe change dwc_get_hwaddr_fdt to handle that and make it a generic helper ?

Should we support both as USB does here? https://svnweb.freebsd.org/base/head/sys/dev/usb/usb_fdt_support.c?annotate=347974#l100

Jan 12 2020, 5:01 PM
manu added a comment to D23145: dwc(4) Ethernet MAC address setting/generating.

The bindings (https://github.com/torvalds/linux/blob/master/Documentation/devicetree/bindings/net/ethernet-controller.yaml#L16) seems to indicate
that mac-address should be used if it exists and is prefered to local-mac-address.
Maybe change dwc_get_hwaddr_fdt to handle that and make it a generic helper ?

Jan 12 2020, 3:09 PM

Jan 11 2020

manu committed rS356637: arm64: allwinner: dtso: Add spi0 spigen DTSO.
arm64: allwinner: dtso: Add spi0 spigen DTSO
Jan 11 2020, 6:36 PM
manu committed rP522693: games/vvvvvv: New port.
games/vvvvvv: New port
Jan 11 2020, 3:55 PM
manu accepted D22213: regulator: small enhancements to regulator_shutdown.
Jan 11 2020, 3:13 PM

Jan 10 2020

manu committed rS356610: arm: allwinner: axp209: Add regnode_status method.
arm: allwinner: axp209: Add regnode_status method
Jan 10 2020, 6:53 PM
manu committed rS356609: twsi: Rework how we handle the i2c messages.
twsi: Rework how we handle the i2c messages
Jan 10 2020, 6:52 PM
manu added a comment to D23085: DRM: Add DRM core files and DRMKPI.

We simply have slightly different conditions a so we must take drmkpi as adaptation, not emulation, layer.

Why not keep the emulation for everything that's already in linuxkpi/drm-kmod, while adding adaptation for the FDT stuff and other missing parts?!

Jan 10 2020, 5:12 PM
manu accepted D23112: a10_ahci: grab the target-supply regulator and enable it.

LGTM.
Not sure about the LDO3 patch, I don't see it used on the schematics (http://dl.cubieboard.org/model/CubieBoard1/Hardware/cubieboard_schematic_2012-08-08.pdf)

Jan 10 2020, 10:42 AM

Jan 9 2020

manu added a comment to D23085: DRM: Add DRM core files and DRMKPI.

Can you use the port-drm driver at the same time as base DRM? Some people use PCI graphics adapters with ARM.

Jan 9 2020, 11:31 AM
manu added a comment to D23085: DRM: Add DRM core files and DRMKPI.

Is the ports drm graphics drivers intended to be switched over to this framework, or is it only for ARM kernel drivers?

Jan 9 2020, 11:05 AM

Jan 8 2020

manu updated the diff for D19046: Rockchip RK3399 PWM driver.

Handle clock errors.

Jan 8 2020, 8:14 PM · arm64
manu updated the diff for D22849: arm64: rockchip: Add interface for rk_pinctrl.

Use the new fdt_pinctrl methods.

Jan 8 2020, 7:27 PM
manu created D23093: fdt_pinctrl: Add new methods for gpios.
Jan 8 2020, 7:26 PM
manu added a comment to D23085: DRM: Add DRM core files and DRMKPI.
In D23085#505975, @bcr wrote:

Do you need any specific actions from the core team or was core only added as reviewer because Phabricator tried to be smart (too much mention of the word "core" in a different context)?
Let us know if we need to discuss/decide something.

Jan 8 2020, 4:31 PM
manu added a comment to D23085: DRM: Add DRM core files and DRMKPI.

I've pushed some change here : https://github.com/evadot/freebsd/commits/drm_arm_v5.4-rebase-linuxkpi

Jan 8 2020, 3:29 PM
manu added a comment to D23085: DRM: Add DRM core files and DRMKPI.

That might be a good solution yes.
For now this doesn't work as a module, the main reason is that I could never make my drm driver works as a module for a few reasons :

Doesn't matter. Just make corresponding kernel options, like the existing COMPAT_LINUXKPI .
options COMPAT_LINUXKPI_BASE
options COMPAT_LINUXKPI_NET
options COMPAT_LINUXKPI_DRM
...
and so on.

Jan 8 2020, 1:40 PM
manu added a comment to D23085: DRM: Add DRM core files and DRMKPI.
Is it possible to add this driver as part of the existing KMS DRM driver?

What do you mean ?

I mean as a part of https://github.com/FreeBSDDesktop/kms-drm .
--HPS

Jan 8 2020, 1:39 PM
manu added a comment to D23085: DRM: Add DRM core files and DRMKPI.

Also keep in mind that we can split out network related functions from the LinuxKPI, in an own linuxkpi_net .
Like:
linuxkpi_base.ko
linuxkpi_net.ko
linuxkpi_drm.ko
linuxkpi_gplv2.ko
and so on.
This would be the right approach forward.

Jan 8 2020, 1:20 PM
manu added a comment to D23085: DRM: Add DRM core files and DRMKPI.
In D23085#505935, @manu wrote:

drmkpi/ : A somewhat stripped down copy of linuxkpi The reasons for having a copy are :
The full linuxkpi is usefull for importing drivers from Linux, but for FreeBSD drivers it adds some useless stuff like a linux_dev for each device.

I really don't like this.
How many are the differences?
The currently layout of sys/compat/linuxkpi , was exactly made so that you could overlay different versions of LinuxKPI, having one base LinuxKPI. We should try to build on that. Your approach likely also breaks the kernel linker, which currently doesn't care if you have multiple symbols with same name. What happens if you load drmkpi and linuxkpi at the same time?
Please integrate drmkpi within the sys/compat/linuxkpi folder, like this:

1) Create sys/compat/linuxkpi/basedrm/xxxx  include and src
2) use #include_next <> where approprate.

--HPS

That would mean creating a .h for every file but I guess this is cleaner, I'll have a look at this.

If the files are identical, then you don't need any wrapper, using include "basedrm" first, then "common" afterwards.

Jan 8 2020, 1:18 PM