rf

a couple of comments:

In D56632#1307030, @lukas.engelhardt_gmx.de wrote:

Once this lands we might be able to use the VERSION_MINOR environment variable.
I will try to test this, but if i understand correctly this should be fixed with latest pkg Version?

remove an unused prototype

improve buffer handling

re: pointer arithmetic, i have a better idea of how to do this, but let's
see if this is a better way to handle shutdown in the mean time.

use uint8_t for bitfields

fix big-endian systems

i haven't tested this, but the changes as described seem reasonable to me.

rebase

rebase

rebase

actually update

rebase on current main

one potential issue here is that the user might not realise why their new packages aren't being used if the version number didn't change. but the previous behaviour does not seem intentional, and i think this is better than an error.

In D56717#1299810, @jlduran wrote:

I recently learned that the official term is freebsd-base(7).

rf

rf

only set PATH_LOCALE on FreeBSD

i'm always up for a good set -e.

use ln -n instead

i think ${PKG_ALTABI} definitely needs -h here. that will break Linux, but i'm fairly sure the pkgbase release stuff doesn't work on Linux anyway.

accidentally opened a duplicate review for this (D56657 is the right one), sorry.

In D56653#1297844, @dim wrote:

If this doesn't happen too often across the tree, I'm fine with this approach. If there are more, it may make sense to put a generic macro (e.g. NO_WTYPEDEF_REDEFINITION) in bsd.sys.mk, like we have done for some other annoying warnings.

i don't feel competent to review this (i don't own the hardware and know nothing about it) but @thj has committed to if_awg recently and might be able to help.

since ARMADAXP is a Marvell SoC and if_awg is an Allwinner IC, it's quite possible this combination has never been used by anyone. but, this does currently break the build, and this fix is simpler than either removing DEVICE_POLLING from ARMADAXP or removing polling support from awg.