Enable macros and includes by default as this is breaking package
building on HEAD.
Reported by: ivy
Fixes: abda442d92fd ("contrib/libucl: Import libucl 0.9.3")
Differential D56294
libucl: Revert to old behavior of macros Authored by bofh on Tue, Apr 7, 6:29 PM.
Details Enable macros and includes by default as this is breaking package Reported by: ivy
Diff Detail
Event TimelineComment Actions i think we need this for now, but we should back it out at some point to return to the upstream behaviour -- my preference would be after 15.0 is EOL (September), unless anyone prefers another plan. Comment Actions I have tried to revert the default behavior only. @ivy Can you check if this helps? Somehow my local head in the office is in a messy stage and I cannot complete a buildworld. If this does not help then we will revert the libucl upgrade. Comment Actions We will think about that bridge when we need to cross that river. But for now I am no longer pushing my staged 0.9.4. Comment Actions I think my only concern here is that we commit to no sooner than 15.0 EOL, and that we do note to revisit it later. The reality is that this small local diff is unlikely to cause you any heartburn in future libucl updates, and our flua consumers are both few and aware of the caveat. Comment Actions tested:
so this all looks fine. |