Page MenuHomeFreeBSD

des (Dag-Erling Smørgrav)
Committer

Projects

User Details

User Since
May 17 2014, 3:06 AM (471 w, 3 d)

Recent Activity

Today

des added a comment to D40281: dd(1): block SIGINT while non-async-signal safe code is executing.

You are now blocking SIGINT whenever dd is not performing primary I/O. I don't think that's right.

Tue, May 30, 6:26 PM

Yesterday

des updated the diff for D40285: libtacplus: Allow additional AV pairs to be configured..

Shorten man page, add UPDATING entry.

Mon, May 29, 3:28 PM
des added inline comments to D40285: libtacplus: Allow additional AV pairs to be configured..
Mon, May 29, 3:03 PM
des added inline comments to D40285: libtacplus: Allow additional AV pairs to be configured..
Mon, May 29, 2:01 PM

Fri, May 26

des updated the diff for D40285: libtacplus: Allow additional AV pairs to be configured..

Fix brain glitch in man page.

Fri, May 26, 4:40 PM
des requested review of D40285: libtacplus: Allow additional AV pairs to be configured..
Fri, May 26, 4:39 PM

Thu, May 25

des committed rG9f35eb8f96a5: ctags: Recognize __attribute__ in function declarations. (authored by des).
ctags: Recognize __attribute__ in function declarations.
Thu, May 25, 6:17 PM
des closed D40264: ctags: Recognize __attribute__ in function declarations..
Thu, May 25, 6:17 PM
des added inline comments to D40264: ctags: Recognize __attribute__ in function declarations..
Thu, May 25, 4:31 PM
des requested review of D40264: ctags: Recognize __attribute__ in function declarations..
Thu, May 25, 2:28 PM
des committed rG430d064ba5b0: ctags: Support writing to stdout instead of a file. (authored by des).
ctags: Support writing to stdout instead of a file.
Thu, May 25, 1:26 PM
des closed D40237: ctags: Support writing to stdout instead of a file..
Thu, May 25, 1:26 PM

Wed, May 24

des closed D40226: ldns: Upgrade to 1.8.3..
Wed, May 24, 4:06 PM
des committed rG5afab0e5e56f: ldns: Upgrade to 1.8.3. (authored by des).
ldns: Upgrade to 1.8.3.
Wed, May 24, 3:51 PM
des added a comment to D40226: ldns: Upgrade to 1.8.3..

BTW, I wonder if we should bump SHLIB_MAJOR. Is there an easy way to check?

Wed, May 24, 3:00 PM
des updated the diff for D40226: ldns: Upgrade to 1.8.3..

No need for NO_WERROR now.

Wed, May 24, 2:58 PM
des added a comment to D40226: ldns: Upgrade to 1.8.3..

I did not need to change anything in usr.bin/drill to build; did I miss anything?

Wed, May 24, 2:57 PM
des updated the diff for D40226: ldns: Upgrade to 1.8.3..

Fix gcc build as per @khorben_defora.org.

Wed, May 24, 2:55 PM

Tue, May 23

des requested review of D40237: ctags: Support writing to stdout instead of a file..
Tue, May 23, 4:51 PM
des committed rG506321178137: ctags: Error out if writing to stdout failed. (authored by des).
ctags: Error out if writing to stdout failed.
Tue, May 23, 3:32 PM
des closed D40200: ctags: Error out if writing to stdout failed..
Tue, May 23, 3:32 PM
des added reviewers for D40226: ldns: Upgrade to 1.8.3.: emaste, khorben_defora.org.
Tue, May 23, 8:44 AM
des updated the diff for D40226: ldns: Upgrade to 1.8.3..

Remove man pages.

Tue, May 23, 8:42 AM
des requested review of D40226: ldns: Upgrade to 1.8.3..
Tue, May 23, 8:41 AM

Mon, May 22

des requested review of D40200: ctags: Error out if writing to stdout failed..
Mon, May 22, 10:48 AM
des committed rGc8d84fa75eef: pam_tacplus: Mention nss_tacplus in the manual page. (authored by des).
pam_tacplus: Mention nss_tacplus in the manual page.
Mon, May 22, 10:45 AM
des closed D40135: pam_tacplus: Mention nss_tacplus in the manual page..
Mon, May 22, 10:45 AM
des committed rG6c5cdba1bafe: Add nss_tacplus, a TACACS+ NSS module. (authored by des).
Add nss_tacplus, a TACACS+ NSS module.
Mon, May 22, 10:45 AM
des closed D40133: Add nss_tacplus, a TACACS+ NSS module..
Mon, May 22, 10:45 AM
des closed D40132: taclib: 0 (not set) is a valid auth type in authorization requests..
Mon, May 22, 10:45 AM
des committed rG951beab15d39: taclib: 0 (not set) is a valid auth type in authorization requests. (authored by des).
taclib: 0 (not set) is a valid auth type in authorization requests.
Mon, May 22, 10:45 AM

Wed, May 17

des requested review of D40135: pam_tacplus: Mention nss_tacplus in the manual page..
Wed, May 17, 2:19 PM
des added inline comments to D40133: Add nss_tacplus, a TACACS+ NSS module..
Wed, May 17, 2:13 PM
des updated the diff for D40133: Add nss_tacplus, a TACACS+ NSS module..

Fix type issue.

Wed, May 17, 1:50 PM
des added a reviewer for D40133: Add nss_tacplus, a TACACS+ NSS module.: manpages.
Wed, May 17, 12:10 PM
des requested review of D40133: Add nss_tacplus, a TACACS+ NSS module..
Wed, May 17, 12:10 PM
des requested review of D40132: taclib: 0 (not set) is a valid auth type in authorization requests..
Wed, May 17, 12:09 PM

Tue, May 16

des added inline comments to D40043: tsort: Add unit tests..
Tue, May 16, 2:44 PM

Thu, May 11

des committed rG27e74c8fff35: md5: Add missing <errno.h>. (authored by des).
md5: Add missing <errno.h>.
Thu, May 11, 6:24 AM
des closed D40051: md5: Add missing <errno.h>..
Thu, May 11, 6:24 AM

Wed, May 10

des requested review of D40051: md5: Add missing <errno.h>..
Wed, May 10, 6:52 PM
des committed rG09aee570980b: tsort: Add unit tests. (authored by des).
tsort: Add unit tests.
Wed, May 10, 1:46 PM
des committed rG00de65aaed3a: md5: Add missing references to sha384. (authored by des).
md5: Add missing references to sha384.
Wed, May 10, 1:46 PM
des committed rGb55bc49e8694: tsort: Replace bcopy() with memcpy(). (authored by des).
tsort: Replace bcopy() with memcpy().
Wed, May 10, 1:46 PM
des closed D40032: md5: Add missing references to sha384..
Wed, May 10, 1:46 PM
des closed D40043: tsort: Add unit tests..
Wed, May 10, 1:46 PM
des closed D40042: tsort: Replace bcopy() with memcpy()..
Wed, May 10, 1:46 PM
des added inline comments to D40043: tsort: Add unit tests..
Wed, May 10, 1:43 PM
des added a reviewer for D40043: tsort: Add unit tests.: tests.
Wed, May 10, 1:17 PM
des requested review of D40043: tsort: Add unit tests..
Wed, May 10, 1:15 PM
des requested review of D40042: tsort: Replace bcopy() with memcpy()..
Wed, May 10, 1:15 PM
des requested review of D40032: md5: Add missing references to sha384..
Wed, May 10, 10:09 AM
des committed rGfacc213643f8: md5: Don't increment a bool. (authored by des).
md5: Don't increment a bool.
Wed, May 10, 9:27 AM
des committed rG90eaf4b2f98f: md5: Include <osreldate.h> for __FreeBSD_version. (authored by des).
md5: Include <osreldate.h> for __FreeBSD_version.
Wed, May 10, 9:27 AM
des committed rGf1ceb05a469f: md5: Fix input error check. (authored by des).
md5: Fix input error check.
Wed, May 10, 9:27 AM
des closed D40020: md5: Don't increment a bool..
Wed, May 10, 9:27 AM
des closed D40018: md5: Include <osreldate.h> for __FreeBSD_version..
Wed, May 10, 9:27 AM
des closed D40017: md5: Fix input error check..
Wed, May 10, 9:27 AM

Tue, May 9

des updated the diff for D40018: md5: Include <osreldate.h> for __FreeBSD_version..

We still need <sys/param.h>.

Tue, May 9, 4:41 PM
des retitled D40018: md5: Include <osreldate.h> for __FreeBSD_version. from md5: Use <osreldate.h> instead of <sys/param.h> to md5: Include <osreldate.h> for __FreeBSD_version..
Tue, May 9, 4:40 PM
des requested review of D40020: md5: Don't increment a bool..
Tue, May 9, 11:27 AM
des requested review of D40019: freebsd-version: Remove -j option..
Tue, May 9, 10:47 AM
des added a comment to D40015: md5: attempt fixing cross-builds in github ci.

See D40018 instead.

Tue, May 9, 10:08 AM
des requested review of D40018: md5: Include <osreldate.h> for __FreeBSD_version..
Tue, May 9, 10:00 AM
des updated the diff for D40017: md5: Fix input error check..

Remove unnecessary cast.

Tue, May 9, 9:51 AM
des added inline comments to D40017: md5: Fix input error check..
Tue, May 9, 9:50 AM
des requested review of D40017: md5: Fix input error check..
Tue, May 9, 7:30 AM

Mon, May 8

des committed rG4849767cb16a: md5: Improve compatibility. (authored by des).
md5: Improve compatibility.
Mon, May 8, 8:06 AM
des closed D39446: md5: Improve compatibility..
Mon, May 8, 8:06 AM
des added a comment to D39992: git-arc: Add -c flag to patch to commit the change.

How does this differ from git arc stage?

Mon, May 8, 6:37 AM

Sat, May 6

des updated the diff for D39446: md5: Improve compatibility..

Explain why shasum is commented out of the Makefile.

Sat, May 6, 7:18 PM
des committed rG7c067d5b823d: renice: Avoid segfault if -n flag is given without argument. (authored by des).
renice: Avoid segfault if -n flag is given without argument.
Sat, May 6, 2:43 PM
des added a comment to D37404: wg.8: Rewrite the manual page.
In D37404#905422, @gbe wrote:

Do you know a good mdoc replacement for the roff macros "\fI $String \fP"?

Sat, May 6, 2:16 PM
des added a comment to D27318: freebsd-version(1): present -v option, to print verbose output.

You seem to want to see some sort of conspiracy in this situation but have you considered the possibility that nobody wants to approve this review simply because _it's bad_?

Sat, May 6, 1:35 PM
des accepted D39973: freebsd-update: Fix merging already-updated files.

Can confirm that it fixes the issue for me.

Sat, May 6, 1:16 PM

Fri, May 5

des updated the summary of D39446: md5: Improve compatibility..
Fri, May 5, 9:04 PM
des updated the diff for D39446: md5: Improve compatibility..
  • In bits mode, check that the length is a multiple of 8.
  • Remove unused test files.
  • Don't install shasum for now.
  • Improve the man page.
Fri, May 5, 3:01 PM
des committed rG5807f35c541c: dd: Fix SIGINT handling. (authored by des).
dd: Fix SIGINT handling.
Fri, May 5, 12:45 PM
des committed rGdabef9818f32: dd: Tidy up the tests. (authored by des).
dd: Tidy up the tests.
Fri, May 5, 12:45 PM
des closed D39641: dd: Fix SIGINT handling..
Fri, May 5, 12:45 PM
des closed D39711: dd: Tidy up the tests..
Fri, May 5, 12:45 PM

Thu, May 4

des committed rGcb46f47c7969: tsort: Error out if writing to stdout failed. (authored by des).
tsort: Error out if writing to stdout failed.
Thu, May 4, 6:53 PM
des committed rG5903d9c00b75: ncal: Error out if writing to stdout failed. (authored by des).
ncal: Error out if writing to stdout failed.
Thu, May 4, 6:53 PM
des closed D39959: tsort: Error out if writing to stdout failed..
Thu, May 4, 6:53 PM
des closed D39958: ncal: Error out if writing to stdout failed..
Thu, May 4, 6:53 PM
des requested review of D39959: tsort: Error out if writing to stdout failed..
Thu, May 4, 3:10 PM
des requested review of D39958: ncal: Error out if writing to stdout failed..
Thu, May 4, 3:10 PM

Mon, May 1

des committed R11:c3def8cdee61: security/opie: Update to 1.20230501 (build fix). (authored by des).
security/opie: Update to 1.20230501 (build fix).
Mon, May 1, 4:01 PM
des updated the summary of D39641: dd: Fix SIGINT handling..
Mon, May 1, 1:37 PM
des updated the diff for D39641: dd: Fix SIGINT handling..

Check termination flag before blocking operations as well as after.

Mon, May 1, 1:31 PM
des added a comment to D39641: dd: Fix SIGINT handling..
In D39641#906525, @kib wrote:

It seems that the easiest way to handle the issue is to block SIGINFO on the program start, then unblock it right before doing a syscall, and blocking after the return from syscall. This way you know that the signal delivery cannot interrupt any of the signal-unsafe function calls. The signal handler would print summary and terminate the process. Note that this is still not POSIX-compliant, but our implementation (as well as any reasonable Unix) guarantees that it is safe to do anything in signal handler if you did not interrupted not-async-signal-safe function.

Mon, May 1, 1:16 PM

Apr 26 2023

des committed rG6f3c2f41b18b: tzcode: Clean up the ctime(3) manual page. (authored by des).
tzcode: Clean up the ctime(3) manual page.
Apr 26 2023, 11:12 AM
des committed rG75411d157232: Update tzcode to 2023c. (authored by des).
Update tzcode to 2023c.
Apr 26 2023, 11:12 AM
des closed D39714: tzcode: Clean up the ctime(3) manual page..
Apr 26 2023, 11:11 AM
des closed D39712: Update tzcode to 2023c..
Apr 26 2023, 11:11 AM
des added a comment to D39641: dd: Fix SIGINT handling..
In D39641#904361, @kib wrote:

Note that such signal handling makes the program behavior strange. Suppose that the signal was delivered in time when the code was executing, not during the read or write syscall. Then, you enter the next read/write call, and only after it returns, the new code reacts to the ctrl-C request. This would annoy users if they operate over a slow device.

Apr 26 2023, 8:51 AM

Apr 20 2023

des added a reviewer for D39711: dd: Tidy up the tests.: Klara.
Apr 20 2023, 7:50 PM
des added a comment to D39715: tzcode: Expose and document offtime() and offtime_r()..

See D39712#903737 for background.

Apr 20 2023, 11:44 AM
des requested review of D39715: tzcode: Expose and document offtime() and offtime_r()..
Apr 20 2023, 11:42 AM
des requested review of D39714: tzcode: Clean up the ctime(3) manual page..
Apr 20 2023, 11:42 AM