Page MenuHomeFreeBSD
People des

des (Dag-Erling Smørgrav)
Committer

Projects

User Details

User Since
May 17 2014, 3:06 AM (551 w, 1 d)

Recent Activity
View All

Sat, Dec 7

des updated the diff for D47977: strptime: Fix day-of-week calculation..

tweak

Sat, Dec 7, 1:43 PM
des requested review of D47977: strptime: Fix day-of-week calculation..
Sat, Dec 7, 1:35 PM

Wed, Dec 4

des added a reverting change for rG3ee87f8a4d7a: stress2: Use tests as the default test user.: rG00fce6284aaa: Revert "stress2: Use tests as the default test user.".
Wed, Dec 4, 4:13 PM
des committed rG00fce6284aaa: Revert "stress2: Use tests as the default test user." (authored by des).
Revert "stress2: Use tests as the default test user."
Wed, Dec 4, 4:13 PM
des added a reverting change for D47875: stress2: Use tests as the default test user.: rG00fce6284aaa: Revert "stress2: Use tests as the default test user.".
Wed, Dec 4, 4:13 PM
des added a comment to D47876: stress2: Fix expected output for tmpfs24..
In D47876#1092296, @pho wrote:
In D47876#1092295, @des wrote:

Look again. There _is_ a hole at the end of the file.

No, sorry. There is not a zero length hole *at the end of the file*.

Wed, Dec 4, 3:38 PM
des committed rG65d5e55e2413: stress2: Fix expected output for tmpfs24. (authored by des).
stress2: Fix expected output for tmpfs24.
Wed, Dec 4, 1:14 PM
des committed rG3ee87f8a4d7a: stress2: Use tests as the default test user. (authored by des).
stress2: Use tests as the default test user.
Wed, Dec 4, 1:14 PM
des closed D47876: stress2: Fix expected output for tmpfs24..
Wed, Dec 4, 1:14 PM
des closed D47875: stress2: Use tests as the default test user..
Wed, Dec 4, 1:13 PM
des added a comment to D47876: stress2: Fix expected output for tmpfs24..

Look again. There _is_ a hole at the end of the file.

Wed, Dec 4, 1:03 PM
des added a comment to D47875: stress2: Use tests as the default test user..

I only needed to run tmpfs24 which does not use $testuser but refuses to run if it is not defined. This patch does not fix every broken test, but it fixes some of them.

Wed, Dec 4, 1:02 PM

Tue, Dec 3

des added a comment to D47876: stress2: Fix expected output for tmpfs24..
In D47876#1091682, @pho wrote:

I too have been thinking about removing the "Missing EOF hole" comment, but stalled because I still am not sure that the output is correct.
Isn't there supposed to be a virtual hole at the end of a file?

Tue, Dec 3, 10:51 AM
des added a comment to D47875: stress2: Use tests as the default test user..

Use su -m.

Tue, Dec 3, 10:49 AM
des requested review of D47876: stress2: Fix expected output for tmpfs24..
Tue, Dec 3, 8:35 AM
des requested review of D47875: stress2: Use tests as the default test user..
Tue, Dec 3, 8:35 AM

Tue, Nov 26

des committed rG6748d4e0eb8a: tests: Add regression test for ppoll() / pselect() race. (authored by des).
tests: Add regression test for ppoll() / pselect() race.
Tue, Nov 26, 8:37 PM
des closed D47738: tests: Demonstrate a bug in ppoll() and pselect()..
Tue, Nov 26, 8:37 PM
des added a comment to D47767: swap_pager: fix seek_data with invalid first page.
In D47767#1089263, @markj wrote:

In mail thread, @des suggests that the problem exists on stable/14 as well, but the above-mentioned commit is not present there, so at least one of the two claims is wrong. Which one is it?

Tue, Nov 26, 7:56 PM

Mon, Nov 25

des accepted D47741: kern: restore signal mask before ast() for pselect/ppoll.

I can confirm that this fixes the test cases in D47738.

Mon, Nov 25, 7:44 PM
des updated the diff for D47738: tests: Demonstrate a bug in ppoll() and pselect()..

Further unsimplify

Mon, Nov 25, 7:39 PM
des updated the diff for D47738: tests: Demonstrate a bug in ppoll() and pselect()..

Unsimplify

Mon, Nov 25, 7:36 PM
des added a comment to D47738: tests: Demonstrate a bug in ppoll() and pselect()..

Sorry, I appear to have oversimplified the test case, I will amend it shortly

Mon, Nov 25, 7:18 PM
des requested review of D47738: tests: Demonstrate a bug in ppoll() and pselect()..
Mon, Nov 25, 5:16 PM

Fri, Nov 22

des added a comment to D46876: Remove the OpenBSD derived bc and dc programs (not built by default).

ping @se

Fri, Nov 22, 7:14 PM

Tue, Nov 19

des closed D47569: mv: Convert tests to ATF..
Tue, Nov 19, 8:54 PM
des added inline comments to D47641: save-entropy: Fix the guard to avoid non-digits.
Tue, Nov 19, 6:01 PM
des committed rG80b9b4dacd65: gpiospi: Fix module dependencies. (authored by des).
gpiospi: Fix module dependencies.
Tue, Nov 19, 5:54 PM
des committed rG5d7079bedcca: gpiospi: Fix module dependencies. (authored by des).
gpiospi: Fix module dependencies.
Tue, Nov 19, 11:41 AM
des committed rG3bcbd391dd7e: gpiospi: Fix module dependencies. (authored by des).
gpiospi: Fix module dependencies.
Tue, Nov 19, 11:41 AM
des committed rG2822a7953316: mv: Convert tests to ATF. (authored by des).
mv: Convert tests to ATF.
Tue, Nov 19, 9:30 AM
des committed rGd4fb5984ab0b: mv: Add test cases for command-line options. (authored by des).
mv: Add test cases for command-line options.
Tue, Nov 19, 9:30 AM
des committed rGdc6105ebedcf: mv: More style nits. (authored by des).
mv: More style nits.
Tue, Nov 19, 9:30 AM
des closed D47582: mv: Add test cases for command-line options..
Tue, Nov 19, 9:30 AM
des closed D47568: mv: More style nits..
Tue, Nov 19, 9:29 AM
des added a comment to D47470: poc of atf_require_kld.
In D47470#1085369, @markj wrote:

What is your intention with the patch?

Tue, Nov 19, 9:24 AM

Mon, Nov 18

des added a comment to D47582: mv: Add test cases for command-line options..

ping @asomers

Mon, Nov 18, 6:19 PM
des added inline comments to D47641: save-entropy: Fix the guard to avoid non-digits.
Mon, Nov 18, 12:02 PM

Fri, Nov 15

des committed rG79af8f72b3af: gpiospi: Fix module dependencies. (authored by des).
gpiospi: Fix module dependencies.
Fri, Nov 15, 5:56 AM
des closed D47570: gpiospi: Fix module dependencies..
Fri, Nov 15, 5:55 AM
des added inline comments to D47582: mv: Add test cases for command-line options..
Fri, Nov 15, 1:14 AM
des updated the diff for D47582: mv: Add test cases for command-line options..

require.user root

Fri, Nov 15, 1:14 AM

Thu, Nov 14

des requested review of D47582: mv: Add test cases for command-line options..
Thu, Nov 14, 8:13 PM
des updated the diff for D47569: mv: Convert tests to ATF..

descriptive names

Thu, Nov 14, 7:43 PM
des committed rGb697835ce614: Improve reliability of stdout tests. (authored by des).
Improve reliability of stdout tests.
Thu, Nov 14, 7:42 PM
des closed D47572: Improve reliability of stdout tests..
Thu, Nov 14, 7:42 PM
des updated the diff for D47569: mv: Convert tests to ATF..

rm cvt.pl

Thu, Nov 14, 6:14 PM
des added a comment to D47569: mv: Convert tests to ATF..
In D47569#1085032, @asomers wrote:

Shouldn't you delete cvt.pl? That looks like a one-time script to me.

Thu, Nov 14, 6:13 PM
des requested review of D47572: Improve reliability of stdout tests..
Thu, Nov 14, 4:46 PM
des updated the diff for D47569: mv: Convert tests to ATF..

review feedback

Thu, Nov 14, 4:35 PM
des added inline comments to D47568: mv: More style nits..
Thu, Nov 14, 4:34 PM
des added inline comments to D47569: mv: Convert tests to ATF..
Thu, Nov 14, 4:19 PM
des added a reviewer for D47569: mv: Convert tests to ATF.: tests.
Thu, Nov 14, 4:18 PM
des requested review of D47570: gpiospi: Fix module dependencies..
Thu, Nov 14, 11:33 AM
des requested review of D47569: mv: Convert tests to ATF..
Thu, Nov 14, 11:31 AM
des requested review of D47568: mv: More style nits..
Thu, Nov 14, 11:31 AM
des updated the diff for D47470: poc of atf_require_kld.
  • #ifdef __FreeBSD__
  • s/kld/module/g
  • Avoid linking libatf with libutil
Thu, Nov 14, 11:30 AM

Wed, Nov 13

des committed rGb210c33a91ee: mv: Type and style nits. (authored by des).
mv: Type and style nits.
Wed, Nov 13, 1:50 PM
des closed D47537: mv: Type and style nits..
Wed, Nov 13, 1:50 PM
des added a comment to D47470: poc of atf_require_kld.

No. I had done the work already and posted the review when I saw your email to avoid having someone else waste their time reproducing it.

Wed, Nov 13, 1:43 PM
des updated the diff for D47537: mv: Type and style nits..

more

Wed, Nov 13, 1:28 PM
des retitled D47537: mv: Type and style nits. from mv: Type nit. to mv: Type and style nits..
Wed, Nov 13, 1:28 PM
des requested review of D47537: mv: Type and style nits..
Wed, Nov 13, 1:25 PM

Mon, Nov 11

des added a comment to D47470: poc of atf_require_kld.

You seem to have me confused with a GSoC student. Do you want to try again?

Mon, Nov 11, 4:19 PM

Nov 7 2024

des updated the diff for D47470: poc of atf_require_kld.

require

Nov 7 2024, 12:23 AM
des updated the diff for D47470: poc of atf_require_kld.

missing stuff

Nov 7 2024, 12:12 AM

Nov 6 2024

des requested review of D47470: poc of atf_require_kld.
Nov 6 2024, 11:58 PM
des added inline comments to D47289: git-arc: Trap on every mktemp.
Nov 6 2024, 11:43 PM
des added inline comments to D47289: git-arc: Trap on every mktemp.
Nov 6 2024, 9:18 AM

Nov 1 2024

des closed D47382: fts: Simplify fts_alloc() and use calloc()..
Nov 1 2024, 3:53 PM
des committed rG79679a18eacb: fts: Simplify fts_alloc() and use calloc(). (authored by des).
fts: Simplify fts_alloc() and use calloc().
Nov 1 2024, 3:53 PM
des accepted D47377: sed: fix commandline-given expression when -e is not used.
Nov 1 2024, 2:37 PM
des requested review of D47382: fts: Simplify fts_alloc() and use calloc()..
Nov 1 2024, 1:06 PM
des added inline comments to D46547: Provide an option to turn off FTP anonymous usage.
Nov 1 2024, 9:00 AM

Oct 31 2024

des closed D47309: malloc(9): assert wait flags..
Oct 31 2024, 12:43 AM
des committed rGd0f9b0bd19bf: malloc(9): assert wait flags. (authored by des).
malloc(9): assert wait flags.
Oct 31 2024, 12:43 AM

Oct 29 2024

des accepted D47289: git-arc: Trap on every mktemp.

lgtm but I would suggest waiting for @markj to approve as well

Oct 29 2024, 5:42 PM
des updated the diff for D47309: malloc(9): assert wait flags..

operator precedence

Oct 29 2024, 5:40 PM

Oct 28 2024

des updated the diff for D47309: malloc(9): assert wait flags..

trim stray newlines

Oct 28 2024, 2:57 PM
des requested review of D47309: malloc(9): assert wait flags..
Oct 28 2024, 2:56 PM
des requested changes to D47289: git-arc: Trap on every mktemp.
Oct 28 2024, 2:44 PM
des added inline comments to D46781: git-arc: Make patch with reviewers more portable.
Oct 28 2024, 2:39 PM

Oct 25 2024

des added inline comments to D46767: git-arc: Do not echo unescaped literals to jq.
Oct 25 2024, 2:06 PM
des added inline comments to D46781: git-arc: Make patch with reviewers more portable.
Oct 25 2024, 1:59 PM

Oct 24 2024

des requested changes to D47274: git-arc: Use printf instead of echo.

revert everything except the three places I commented

Oct 24 2024, 11:21 AM

Oct 15 2024

des committed rG80c9caa46b1e: env: Add a handful of test cases. (authored by des).
env: Add a handful of test cases.
Oct 15 2024, 6:31 AM
des committed rG11b0b75a9fba: cmp: Style and type issues. (authored by des).
cmp: Style and type issues.
Oct 15 2024, 6:31 AM
des committed rG08e8554c4a39: env: Add a handful of test cases. (authored by des).
env: Add a handful of test cases.
Oct 15 2024, 6:30 AM
des committed rG02a8a4e4eb25: cmp: Style and type issues. (authored by des).
cmp: Style and type issues.
Oct 15 2024, 6:30 AM
des committed rG54cb2f5b8b89: sysctl.8: fix format typo (authored by igoro).
sysctl.8: fix format typo
Oct 15 2024, 5:20 AM
des committed rG76c656bd97b7: sysctl.8: fix format typo (authored by igoro).
sysctl.8: fix format typo
Oct 15 2024, 5:20 AM

Oct 9 2024

des committed rG3c37828ee187: cmp: Check the status of stdout. (authored by des).
cmp: Check the status of stdout.
Oct 9 2024, 12:12 PM
des committed rGd350e8d795d5: cmp: Style and type issues. (authored by des).
cmp: Style and type issues.
Oct 9 2024, 12:12 PM
des closed D47020: cmp: Check the status of stdout..
Oct 9 2024, 12:12 PM
des closed D47019: cmp: Style and type issues..
Oct 9 2024, 12:12 PM
des added a comment to D46957: devel/readline: Fix build for dependent ports..

It's not trying to detect varargs support, it's trying to detect support for __attribute__((__format__)).

Oct 9 2024, 12:10 PM
des closed D46957: devel/readline: Fix build for dependent ports..
Oct 9 2024, 12:07 PM
des committed R11:6d04fa18daaa: devel/readline: Fix build for dependent ports. (authored by des).
devel/readline: Fix build for dependent ports.
Oct 9 2024, 12:07 PM
des updated the diff for D47020: cmp: Check the status of stdout..

more thorough testing

Oct 9 2024, 10:17 AM
des updated the summary of D47020: cmp: Check the status of stdout..
Oct 9 2024, 9:59 AM