In D57316#1313745, @ngie wrote:

This "fixes" the issue, but the tests should also be intelligent enough to understand when the OPENSSL_KTLS feature isn't present and skip the tests if the feature isn't present in the kernel (see ATF_REQUIRE_FEATURE, etc).

please mark obsolete comments as done and fix the remaining four issues

@kib is RLIMIT_PIPEBUF meant to be a count or a size?

Looking at the kernel code, it looks like RLIMIT_PIPEBUF really is a count, not a size. The getrlimit(2) manual page lists it as a size. So I should correct the documentation instead. RLIMIT_KQUEUES is definitely not a size though.

In D57326#1313548, @asomers wrote:

In D57326#1313547, @des wrote:

In D57326#1313542, @asomers wrote:

Why?

options was never correct, it has always been instr. I assume whoever first wrote the page copy-pasted fts_children() and forgot to adjust options to instr.

Crucially, functions that take an options argument accept multiple value bitwise-or'ed together, while fts_set() accepts only one value at a time.

The prototype at the top of the man page documents the argument as being named "options". And the header file does not contradict that. So "options" is definitely the name of the argument, and change e030e4e73fe7 was correct. Whether it _should_ be named that is a different question. I would not describe this change of yours as a reversion.

In D57326#1313542, @asomers wrote:

Why?

type

Please don't, I need these tests to remain portable.

nit

differentiate iscsi / nvmeof

one more