Page MenuHomeFreeBSD

ngie (Enji Cooper)
User

Projects

User Details

User Since
Aug 2 2014, 8:08 AM (636 w, 5 d)

Recent Activity

Yesterday

ngie added a comment to D60671: Remove the i386 kernel and i386-only device drivers.

Just a couple questions about sys/*crypto. If the headers came from OpenSSL, I think we're ok leaving them be..?

Wed, Oct 14, 9:57 PM
ngie added a comment to D60702: tests: Add Linuxulator regression test infrastructure.

Thank you for this, but I'm wondering if the functional testing for Linux syscalls are better suited for LTP. I'm not as active with that project as I used to be, but I'm still able to contribute there. There is some support missing from FreeBSD that would need to be added in order to make those tests work (/dev/loop), and some of the tests assume explicit Linux support which FreeBSD lacks (SCHED_EXT, etc), but there might be some items that can be gleaned from that project that allows us to avoid reinventing the wheel too much.
Treating this as a simple smoke test though for Linuxulator would be ok, but I want to make sure the tests are constrained to smoke tests and we don't go reinventing the wheel too much.

Wed, Oct 14, 9:52 PM
ngie added inline comments to D58867: acpi_apple: Apple platform ACPI driver,.
Wed, Oct 14, 9:52 PM · apple (x86), drivers
ngie added inline comments to D60540: thunderbolt: NHI resume routine.
Wed, Oct 14, 9:14 PM
ngie added inline comments to D60540: thunderbolt: NHI resume routine.
Wed, Oct 14, 9:12 PM
ngie accepted D60707: ggate: fix test intermittency.
Wed, Oct 14, 8:54 PM

Mon, Oct 12

ngie added a comment to D59879: atf/FREEBSD-upgrade: update document/rewrite in Markdown.

@ziaee: Ping?

Mon, Oct 12, 7:57 AM
ngie added a comment to D57894: www/mod_security: make YAJL support optional.

@joneum : ping?

Mon, Oct 12, 5:40 AM
ngie added a comment to D60214: linux: implement sched_getattr().

@olce : ping (non-urgent)?

Mon, Oct 12, 5:37 AM

Sun, Oct 11

ngie added inline comments to D50352: build: Emit a warning for build targets run as root.
Sun, Oct 11, 10:05 PM
ngie added inline comments to D60590: periodic: clean up security/100.chksetuid.
Sun, Oct 11, 10:01 PM
ngie added inline comments to D60590: periodic: clean up security/100.chksetuid.
Sun, Oct 11, 7:51 PM
ngie added inline comments to D60590: periodic: clean up security/100.chksetuid.
Sun, Oct 11, 7:49 PM
ngie added a comment to D60616: Makefile.inc1: Demote root build message to .info.

Can this be applied to /Makefile.inc1 instead?

Sun, Oct 11, 7:47 PM

Sat, Oct 10

ngie added a comment to D60551: man: Link mgb.4 to if_mgb.4.

There's no reason for mgb to be x86-only

Sat, Oct 10, 10:18 PM
ngie added a comment to D60590: periodic: clean up security/100.chksetuid.

@emaste : I added you to the subscriber list so you can maybe give a thumbs up on the SPDX ID changes.

Sat, Oct 10, 6:19 PM
ngie added a reviewer for D60590: periodic: clean up security/100.chksetuid: jilles.
Sat, Oct 10, 6:18 PM
ngie requested review of D60590: periodic: clean up security/100.chksetuid.
Sat, Oct 10, 6:17 PM
ngie committed rG8a7df6c58d54: tests/libc: only build brk_test where libc provides sbrk (authored by zhaoxiaoqiang007_gmail.com).
tests/libc: only build brk_test where libc provides sbrk
Sat, Oct 10, 5:46 PM
ngie closed D60357: tests/libc: only build brk_test where libc provides sbrk.
Sat, Oct 10, 5:46 PM
ngie accepted D60357: tests/libc: only build brk_test where libc provides sbrk.

Seems reasonable to me.

Sat, Oct 10, 5:44 PM
ngie committed rGd45f069002f2: tests/libc: use an allowlist for sbrk in NetBSD-derived tests (authored by zhaoxiaoqiang007_gmail.com).
tests/libc: use an allowlist for sbrk in NetBSD-derived tests
Sat, Oct 10, 5:44 PM
ngie added a reverting change for rG36b849b5c764: tests/libc: use an allowlist for sbrk in NetBSD-derived tests: rGe8431fae655b: Revert "tests/libc: use an allowlist for sbrk in NetBSD-derived tests".
Sat, Oct 10, 5:44 PM
ngie closed D60358: tests/libc: use an allowlist for sbrk in NetBSD-derived tests.
Sat, Oct 10, 5:44 PM
ngie committed rGe8431fae655b: Revert "tests/libc: use an allowlist for sbrk in NetBSD-derived tests" (authored by ngie).
Revert "tests/libc: use an allowlist for sbrk in NetBSD-derived tests"
Sat, Oct 10, 5:43 PM
ngie added a reverting change for D60358: tests/libc: use an allowlist for sbrk in NetBSD-derived tests: rGe8431fae655b: Revert "tests/libc: use an allowlist for sbrk in NetBSD-derived tests".
Sat, Oct 10, 5:43 PM
ngie updated the summary of D60358: tests/libc: use an allowlist for sbrk in NetBSD-derived tests.
Sat, Oct 10, 5:43 PM
ngie reopened D60358: tests/libc: use an allowlist for sbrk in NetBSD-derived tests.
Sat, Oct 10, 5:43 PM
ngie committed rG36b849b5c764: tests/libc: use an allowlist for sbrk in NetBSD-derived tests (authored by zhaoxiaoqiang007_gmail.com).
tests/libc: use an allowlist for sbrk in NetBSD-derived tests
Sat, Oct 10, 5:43 PM
ngie closed D60358: tests/libc: use an allowlist for sbrk in NetBSD-derived tests.
Sat, Oct 10, 5:42 PM
ngie accepted D60358: tests/libc: use an allowlist for sbrk in NetBSD-derived tests.

The aarch64 and riscv portions of the diff are unannotated FreeBSD modifications -- this is ok, but this really should be cleaned up in a future revision:

  1. https://github.com/ngie-eign/freebsd-src.project-tracking/issues/1
  2. https://github.com/ngie-eign/freebsd-src.project-tracking/issues/2
Sat, Oct 10, 5:38 PM
ngie added inline comments to D58737: net/ieee_oui.h: clarify how `OUI_FREEBSD_BASE` is managed.
Sat, Oct 10, 5:20 PM
ngie updated the diff for D58737: net/ieee_oui.h: clarify how `OUI_FREEBSD_BASE` is managed.

Normalize multiline comment header

Sat, Oct 10, 4:44 PM
ngie updated subscribers of D60555: ckdint.h: fix cross-build with older toolchains.

Oddly enough this doesn't fail 100% of the time with our GHA workflows. I don't know why...
I found this issue when reviewing one of @seuros' commits: https://github.com/freebsd/freebsd-src/actions/runs/37836150968/job/113513585413 .

Sat, Oct 10, 4:04 PM
ngie added inline comments to D58737: net/ieee_oui.h: clarify how `OUI_FREEBSD_BASE` is managed.
Sat, Oct 10, 4:04 PM
ngie added reviewers for D60577: linux: add constants for more Linux scheduling policies: olce, Linux Emulation.
Sat, Oct 10, 7:38 AM
ngie requested review of D60577: linux: add constants for more Linux scheduling policies.
Sat, Oct 10, 7:38 AM
ngie committed rG7a48c3fd3e6e: acl(9): expound on NFSv4 constants' meanings (authored by ngie).
acl(9): expound on NFSv4 constants' meanings
Sat, Oct 10, 7:29 AM
ngie closed D58736: acl(9): expound on NFSv4 constants' meanings.
Sat, Oct 10, 7:29 AM
ngie updated the diff for D58737: net/ieee_oui.h: clarify how `OUI_FREEBSD_BASE` is managed.

Tweak comment wording

Sat, Oct 10, 7:23 AM
ngie updated the summary of D58737: net/ieee_oui.h: clarify how `OUI_FREEBSD_BASE` is managed.
Sat, Oct 10, 7:21 AM
ngie retitled D58737: net/ieee_oui.h: clarify how `OUI_FREEBSD_BASE` is managed from net/ieee_oui.h: clarify FreeBSD Foundation's relationship with `OUI_FREEBSD_BASE` to net/ieee_oui.h: clarify how `OUI_FREEBSD_BASE` is managed.
Sat, Oct 10, 7:19 AM
ngie retitled D58737: net/ieee_oui.h: clarify how `OUI_FREEBSD_BASE` is managed from Note that the Foundation setup `OUI_FREEBSD_BASE` to net/ieee_oui.h: clarify FreeBSD Foundation's relationship with `OUI_FREEBSD_BASE`.
Sat, Oct 10, 7:18 AM
ngie added inline comments to D58737: net/ieee_oui.h: clarify how `OUI_FREEBSD_BASE` is managed.
Sat, Oct 10, 7:17 AM
ngie committed rG62e958df018a: zfs: drop duplicate `vfs.zfs.metaslab.condense_pct` sysctl (authored by longros).
zfs: drop duplicate `vfs.zfs.metaslab.condense_pct` sysctl
Sat, Oct 10, 7:14 AM
ngie added a comment to D57721: zfs: drop duplicate vfs.zfs.metaslab.condense_pct sysctl.
In D57721#1388980, @chris.longros_gmail.com wrote:

Any news regarding this review ? :)

Sat, Oct 10, 7:14 AM
ngie closed D57721: zfs: drop duplicate vfs.zfs.metaslab.condense_pct sysctl.
Sat, Oct 10, 7:13 AM
ngie reopened D60394: linux: implement fchmodat2 syscall.
Sat, Oct 10, 1:31 AM
ngie updated the diff for D58736: acl(9): expound on NFSv4 constants' meanings.

Remove dash in RFC (this seems to be status quo for RFC references).

Sat, Oct 10, 1:25 AM
ngie updated the diff for D58736: acl(9): expound on NFSv4 constants' meanings.
  • Change descriptions to better match RFC-8881.
  • Provide a link to RFC-8881 for further review.
Sat, Oct 10, 1:20 AM
ngie updated the summary of D58737: net/ieee_oui.h: clarify how `OUI_FREEBSD_BASE` is managed.
Sat, Oct 10, 12:18 AM
ngie retitled D58737: net/ieee_oui.h: clarify how `OUI_FREEBSD_BASE` is managed from ether_gen_addr(9): fix `OUI_FREEBSD_BASE` description to Note that the Foundation setup `OUI_FREEBSD_BASE`.
Sat, Oct 10, 12:18 AM
ngie updated the diff for D58737: net/ieee_oui.h: clarify how `OUI_FREEBSD_BASE` is managed.
  • Remove manpage portion of the diff.
  • Expand on the fact that the FF setup OUI_FREEBSD_BASE in the header, like mentioned earlier.
Sat, Oct 10, 12:17 AM

Fri, Oct 9

ngie added inline comments to D60214: linux: implement sched_getattr().
Fri, Oct 9, 11:58 PM
ngie updated the summary of D60214: linux: implement sched_getattr().
Fri, Oct 9, 9:29 PM
ngie updated the summary of D60555: ckdint.h: fix cross-build with older toolchains.
Fri, Oct 9, 9:16 PM
ngie added reviewers for D60555: ckdint.h: fix cross-build with older toolchains: des, markj.
Fri, Oct 9, 9:15 PM
ngie requested review of D60555: ckdint.h: fix cross-build with older toolchains.
Fri, Oct 9, 9:15 PM
ngie added inline comments to D50352: build: Emit a warning for build targets run as root.
Fri, Oct 9, 6:42 PM
ngie accepted D49453: USB4 initial work on suspend routine.
Fri, Oct 9, 4:51 PM · USB
ngie added a comment to D49453: USB4 initial work on suspend routine.

If you could mention the bug (once) in the code, that would be helpful and I'm happy to provide a ship-it.

Fri, Oct 9, 4:49 AM · USB

Thu, Oct 8

ngie added inline comments to D60446: kyua: Fixes after vendor merge.
Thu, Oct 8, 6:40 AM
ngie accepted D60446: kyua: Fixes after vendor merge.

Please submit this change upstream so I can integrate them into the next release.
I ran into so many conflicts that I just chose the upstream version of files by default. I want to get out of that habit by getting things to converge again between the copy in the FreeBSD src tree and on GitHub.

Thu, Oct 8, 6:25 AM

Wed, Oct 7

ngie added inline comments to D60214: linux: implement sched_getattr().
Wed, Oct 7, 6:52 PM
ngie committed rGef947bb97302: LinuxKPI: firmware: remove `enoentok` logic in `*firmware_request(..)` (authored by ngie).
LinuxKPI: firmware: remove `enoentok` logic in `*firmware_request(..)`
Wed, Oct 7, 6:25 PM
ngie closed D58451: linux_firmware: remove `enoentok` logic in `*firmware_request(..)`.
Wed, Oct 7, 6:25 PM
ngie committed rG26eb328b52c3: contrib/kyua: commit generated files (authored by ngie).
contrib/kyua: commit generated files
Wed, Oct 7, 6:05 PM
ngie committed rGb836604e126d: contrib/kyua: commit Makefile changes for version update (authored by ngie).
contrib/kyua: commit Makefile changes for version update
Wed, Oct 7, 5:57 PM
ngie committed rGeb8f69902f7d: contrib/kyua: update to 0.15.0 (authored by ngie).
contrib/kyua: update to 0.15.0
Wed, Oct 7, 5:53 PM
ngie added a comment to D59879: atf/FREEBSD-upgrade: update document/rewrite in Markdown.

@ziaee: Ping?

Wed, Oct 7, 5:29 PM
ngie committed rG144afd05f8a2: kyua: import kyua-0.15.0 (authored by ngie).
kyua: import kyua-0.15.0
Wed, Oct 7, 5:20 PM
ngie added inline comments to D60097: arm64: enable ossl accelerated AES-GCM on arm64.
Wed, Oct 7, 2:55 PM
ngie accepted D60368: whereis(1): Fix sourcedirs array size calculation.

I trust that works, but I feel like the code is more obfuscated now. Nevertheless, this needs more tests before making more extensive changes.

Wed, Oct 7, 2:52 PM
ngie added inline comments to D60368: whereis(1): Fix sourcedirs array size calculation.
Wed, Oct 7, 2:43 PM
ngie accepted D60419: mkimg: Use reallocf.
Wed, Oct 7, 12:48 PM

Tue, Oct 6

ngie added inline comments to D60214: linux: implement sched_getattr().
Tue, Oct 6, 4:41 PM
ngie updated the diff for D60214: linux: implement sched_getattr().
  • Fix security issue spotted by @markj in previous revision.
  • Reduce diff (@olce).
  • Implement BSD .sched_policy to Linux .sched_policy mapping.
Tue, Oct 6, 4:38 PM
ngie added inline comments to D60214: linux: implement sched_getattr().
Tue, Oct 6, 4:28 PM
ngie added inline comments to D60391: linux: implement basic `sched_setattr` syscall.
Tue, Oct 6, 4:19 PM
ngie added a comment to D60397: openssl: make libcrypto export the same symbols as upstream.

Do you have any script which could be used to verify the linker script after future imports?

Tue, Oct 6, 4:11 PM
ngie added inline comments to D60214: linux: implement sched_getattr().
Tue, Oct 6, 4:00 PM
ngie added inline comments to D60214: linux: implement sched_getattr().
Tue, Oct 6, 3:30 PM
ngie reopened D60214: linux: implement sched_getattr().
Tue, Oct 6, 3:28 PM
ngie updated subscribers of D60214: linux: implement sched_getattr().
Tue, Oct 6, 3:26 PM
ngie added inline comments to D60398: openssl: build the legacy provider the way upstream does.
Tue, Oct 6, 3:01 PM
ngie closed D60394: linux: implement fchmodat2 syscall.
Tue, Oct 6, 1:42 PM
ngie added a reverting change for rGc070ec923e2f: linux: implement fchmodat2 syscall: rG4abfb452ea2d: Revert "linux: implement fchmodat2 syscall".
Tue, Oct 6, 4:52 AM
ngie committed rG4abfb452ea2d: Revert "linux: implement fchmodat2 syscall" (authored by ngie).
Revert "linux: implement fchmodat2 syscall"
Tue, Oct 6, 4:52 AM
ngie added a reverting change for D60394: linux: implement fchmodat2 syscall: rG4abfb452ea2d: Revert "linux: implement fchmodat2 syscall".
Tue, Oct 6, 4:52 AM
ngie committed rGc070ec923e2f: linux: implement fchmodat2 syscall (authored by ngie).
linux: implement fchmodat2 syscall
Tue, Oct 6, 4:51 AM
ngie committed rG32f5a9f3fb51: Revert "linux: implement sched_getattr()" (authored by ngie).
Revert "linux: implement sched_getattr()"
Tue, Oct 6, 4:51 AM
ngie added a reverting change for rGbb5f10e51bd5: linux: implement sched_getattr(): rG32f5a9f3fb51: Revert "linux: implement sched_getattr()".
Tue, Oct 6, 4:51 AM
ngie added a reverting change for D60214: linux: implement sched_getattr(): rG32f5a9f3fb51: Revert "linux: implement sched_getattr()".
Tue, Oct 6, 4:51 AM
ngie edited P720 Command-Line Input.
Tue, Oct 6, 4:30 AM
ngie updated the test plan for D60394: linux: implement fchmodat2 syscall.
Tue, Oct 6, 4:29 AM
ngie created P720 Command-Line Input.
Tue, Oct 6, 4:29 AM
ngie accepted D60396: openssl: configure with --openssldir=/etc/ssl.

Please add an MFC timer for this change.

Tue, Oct 6, 4:26 AM
ngie updated the diff for D60394: linux: implement fchmodat2 syscall.

ANNNNNNNDDDD... update arm64's linux32 syscalls.master file.

Tue, Oct 6, 4:21 AM
ngie updated the summary of D60394: linux: implement fchmodat2 syscall.
Tue, Oct 6, 3:35 AM
ngie updated the diff for D60394: linux: implement fchmodat2 syscall.

Add missing pieces for fchmodat2 in all architectures

Tue, Oct 6, 3:33 AM