In D52861#1288825, @thj wrote:

I said I would help Aymeric with this review, from a quick read it seems fine. I haven't thrown it at hardware and I'm not really that familiar with the TB/USB4 side of things.

@ngie would you be able to suggest a review that adds the minimum functionality you need?

I'm not really one to push on reviews, but in this case Aymeric has been pretty clear with why this code isn't really something to have in tree.
As this is holding back s0iX support I think we should land this change and revisit TB3, or minimal TB3 support when we have active patches.

@imp : ping?

Install the 64-bit library pkg-config file as well

@guest-seuros : could you please reply to my comments?

@sunpoet updated the component in the interim. Abandoning...

Use __diagused instead of diagnostic popping, etc.

hkey_sound_mute calls ACPI_SERIAL_ASSERT(..), which I assume is where things panic. This is a pretty straightforward change.

Add an MMIO guard at the top of asmc_key_dump(): delegate to
asmc_key_dump_by_index() + asmc_key_read() for MMIO devices,
consistent with the rest of the T2 code paths.

Having a more explicit statement for T2 Macs vs non-T2 Macs would be a good idea.

This hints at needing the patches/driver available in https://github.com/t2linux/linux-t2-patches/tree/main (please note that the driver isn't technically GPLv2; I can add more details later if needed).

Please note that the new version requires _rust_. That's a pretty large dependency to require for CI, which doesn't exist already today.
This is part of the reason why I was more keen on doing python+pytest integration: python is more common in CI and pytest is on the docket for kyua integration (it's on my TODO list because I want the atf_python stuff to go away...).

@khorben : yes! Sorry for not accepting this sooner!

In D56589#1296252, @khorben wrote:

I gave the copyright back to pkgconf, as the comment and description primarily come from the pkgconf project.

While there, I also updated the SPDX-License-Identifier to pkgconf, as per the discussion here, and confirmed at https://spdx.org/licenses/pkgconf.html.

This is good, but I would consider breaking down pkgconf into separate components, e.g., the library, the pkgconf tool, and the bomtool. All of these things are dependent on one another, but some folks might not want nor need to have pkgconf in base in order to build custom versions of pkgconf, et al.

In D56589#1295930, @khorben wrote:

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=294724 confirms this patch to be fixing the build issue.

Abandoning in favor of D56589.