Page MenuHomeFreeBSD

ngie (Enji Cooper)
User

Projects

User Details

User Since
Aug 2 2014, 8:08 AM (359 w, 12 h)

Recent Activity

Mon, Jun 14

ngie added inline comments to D26931: Hook atf-lua tests up to the build.
Mon, Jun 14, 6:08 PM
ngie requested changes to D26931: Hook atf-lua tests up to the build.
Mon, Jun 14, 6:07 PM

May 11 2021

ngie added a comment to D30217: sort: Make NetBSD sort tests compatible with sort. .

These are a lot of changes to an upstream (NetBSD) provided file without good annotations (please look for "Begin FreeBSD" elsewhere).

May 11 2021, 7:20 PM

Apr 21 2021

ngie added a comment to D29750: rc: make 'ddb' and 'dumpon' require disks, not the other way around.

So either I'm missing something, or the sort order in rcorder(8) isn't particularly stable, which makes this comparison not very useful.

Apr 21 2021, 9:21 PM

Apr 16 2021

ngie accepted D29039: Allow lib/msun/logarithm_test to pass on ld128 platforms.

Not my domain of expertise. Maybe someone like @dim or Steve Kargl would have better input 🤷...

Apr 16 2021, 8:11 PM

Apr 14 2021

ngie added a comment to D29750: rc: make 'ddb' and 'dumpon' require disks, not the other way around.

This needs to be run through rcorder to ensure things haven't been broken. Please add the output of this information to the CR.

Apr 14 2021, 5:03 PM

Apr 12 2021

ngie accepted D29566: lpd: Add -F flag to prevent daemonizing.

Macro surewhynot:

Apr 12 2021, 2:39 PM

Mar 1 2021

ngie accepted D28997: Allow ssp_test:read to pass more reliably.

LGTM!

Mar 1 2021, 6:03 PM

Feb 26 2021

ngie added a comment to D28798: Convert the msun tests to ATF.

Does this look okay now?

Feb 26 2021, 3:08 AM
ngie accepted D28884: Remove XFAILs from fmaxmin test.
Feb 26 2021, 3:07 AM

Feb 25 2021

ngie added a comment to D28884: Remove XFAILs from fmaxmin test.

Yes that should also be removed. Will update

Feb 25 2021, 5:13 AM

Feb 24 2021

ngie added a comment to D28884: Remove XFAILs from fmaxmin test.

Is the affected_by_bug_208703 #define still relevant, i.e., should it be removed?

Feb 24 2021, 12:53 AM

Feb 23 2021

ngie added a comment to D28884: Remove XFAILs from fmaxmin test.
In D28884#646868, @ngie wrote:

Can you please post the test results to prove that this works now?

Feb 23 2021, 6:31 PM
ngie accepted D28577: While building libm, turn off any math-related compiler builtins.

Ah, nevermind. I didn't see the "Testing Done" section before leaving a comment.

Feb 23 2021, 6:26 PM
ngie added a comment to D28577: While building libm, turn off any math-related compiler builtins.

This seems ok, but I'd like to see test results for the entire set of libm tests after this change.

Feb 23 2021, 6:24 PM
ngie requested changes to D28884: Remove XFAILs from fmaxmin test.

Can you please post the test results to prove that this works now?

Feb 23 2021, 6:23 PM
ngie requested changes to D28798: Convert the msun tests to ATF.

This conversion is on the right direction, but incomplete.

Feb 23 2021, 4:52 AM
ngie accepted D28788: lib/msun/ctrig_test: Print the mismatched values on failure.
Feb 23 2021, 4:13 AM

Feb 12 2021

ngie accepted D28478: lib/libc/tests/rpc: Correctly set timeout.

Macro goatforit:

Feb 12 2021, 6:45 PM

Feb 4 2021

ngie added a comment to D28480: bin/pkill: Fix {pgrep,pkill}-j_test.sh.

Oh, I see now based on the description.

Feb 4 2021, 4:38 PM
ngie added a comment to D28480: bin/pkill: Fix {pgrep,pkill}-j_test.sh.

The shellcheck warning fixes are great (I'll happily stamp that diff)!

Feb 4 2021, 4:35 PM
ngie requested changes to D28478: lib/libc/tests/rpc: Correctly set timeout.

Could you please wrap the changes in #ifdef __FreeBSD__ so it'd be easier for me to upstream to NetBSD?

Feb 4 2021, 4:31 PM
ngie requested changes to D28479: lib/libc/tests/rpc: Start rpcbind(8) if needed.

I don't think this is a good idea. Tests really shouldn't be starting services because it can make the tests more flaky, it can mutate system state, and might interfere with other service management systems, like Isilon has on OneFS.

Feb 4 2021, 4:30 PM

Feb 3 2021

ngie accepted D28398: du_test: Skip three tests if sparse files are not supported.

This might be a good thing to add to a general purpose library.

Feb 3 2021, 3:47 PM
ngie accepted D28414: atf: Fix ATF_BUILD_* values when not using the bootstrap compiler.

I agree with @brooks ; the functionality that involves compiling as part of tests is very dubious functionality that should be removed.

Feb 3 2021, 3:52 AM

Jan 28 2021

ngie requested changes to D28398: du_test: Skip three tests if sparse files are not supported.

This isn't the right approach; please use getconf MIN_HOLE_SIZE instead, like the ls tests do

83 create_test_inputs2()
84 {
85         create_test_dir
86 
87         if ! getconf MIN_HOLE_SIZE "$(pwd)"; then
88             echo "getconf MIN_HOLE_SIZE $(pwd) failed; sparse files probably" \
89                  "not supported by file system"
90             mount
91             atf_skip "Test's work directory does not support sparse files;" \
92                      "try with a different TMPDIR?"
93         fi
Jan 28 2021, 11:11 PM
ngie accepted D28397: Avoid double output in fenv_test.
Jan 28 2021, 11:07 PM

Jan 11 2021

ngie added a comment to D28097: include tmpfs mount into FILESYSTEMS.

@glebius: please also run rcorder libexec/rc/rc.d/* to confirm that the changes work.

Jan 11 2021, 9:03 PM
ngie accepted D28097: include tmpfs mount into FILESYSTEMS.

Could you please update the commit message to reflect the changes being made?

Jan 11 2021, 9:02 PM

Jan 9 2021

ngie added inline comments to D27848: Try to favor etcupdate(8) over mergemaster(8) in the handbook.
Jan 9 2021, 3:08 PM
ngie added inline comments to D28062: Change procedure in UPDATING to use etcupdate(8) over mergemaster(8).
Jan 9 2021, 3:01 PM
ngie added a comment to D28062: Change procedure in UPDATING to use etcupdate(8) over mergemaster(8).

Could you please add PR: 252417 to the commit message?

Jan 9 2021, 3:01 PM
ngie accepted D28045: build: `make check`: use a PATH search instead for Kyua.

The reason why I hardcoded the path was to reduce redundant $PATH lookups and to ensure that random kyua(1) binaries wouldn't get picked up from someone's environment, increasing overall determinism of the target.

Jan 9 2021, 2:56 PM

Jan 6 2021

ngie accepted D27984: du: tests: make H_flag tests more strict about output requirements.

Macro stlgtm:

Jan 6 2021, 5:08 PM
ngie accepted D27983: du: tests: fix the H_flag test (primarily grep usage).

Is there a reason why tr is being changed to sed?

Jan 6 2021, 1:54 AM

Dec 11 2020

ngie committed rS368547: timespec_get(3): sort SEE ALSO correctly.
timespec_get(3): sort SEE ALSO correctly
Dec 11 2020, 2:23 AM
ngie committed rS368546: cpuset{,_getaffinity,_getdomain}.2: fix SEE ALSO.
cpuset{,_getaffinity,_getdomain}.2: fix SEE ALSO
Dec 11 2020, 1:53 AM
ngie committed rS368537: aio_suspend.2: properly canonicalize .Dd.
aio_suspend.2: properly canonicalize .Dd
Dec 11 2020, 12:28 AM
ngie committed rS368536: cap_enter(2): fix CAVEATS section.
cap_enter(2): fix CAVEATS section
Dec 11 2020, 12:26 AM
ngie committed rS368534: posix_spawn(3): fix section that references `vfork`.
posix_spawn(3): fix section that references `vfork`
Dec 11 2020, 12:20 AM
ngie committed rS368533: getentropy(3): sort SEE ALSO sections.
getentropy(3): sort SEE ALSO sections
Dec 11 2020, 12:16 AM
ngie committed rS368532: arc4random(3): fix .Xr issues.
arc4random(3): fix .Xr issues
Dec 11 2020, 12:13 AM

Dec 8 2020

ngie committed rS368436: extattr_get_file(20: bump .Dd.
extattr_get_file(20: bump .Dd
Dec 8 2020, 4:18 AM
ngie committed rS368435: extattr_get_file(2): clarify RETURN VALUES.
extattr_get_file(2): clarify RETURN VALUES
Dec 8 2020, 4:16 AM
ngie committed rS368434: extattr_get_file(2): fix more formatting.
extattr_get_file(2): fix more formatting
Dec 8 2020, 4:05 AM
ngie committed rS368433: extattr_get_file(2): sort syscalls alphabetically.
extattr_get_file(2): sort syscalls alphabetically
Dec 8 2020, 4:01 AM
ngie committed rS368432: lio_listio(2): fix manlint error.
lio_listio(2): fix manlint error
Dec 8 2020, 3:48 AM
ngie committed rS368431: extattr_get_fd(2): fix manlint errors.
extattr_get_fd(2): fix manlint errors
Dec 8 2020, 3:43 AM

Nov 18 2020

ngie added inline comments to D26473: Significantly speed up libthr/mutex_test and make more reliable.
Nov 18 2020, 5:52 AM
ngie accepted D26473: Significantly speed up libthr/mutex_test and make more reliable.

Non-blocking thought: can this use sem_post/sem_(timed)?wait instead of spinning in busy-loops waiting for threads to start?

Nov 18 2020, 5:51 AM
ngie accepted D27202: msun tests: use standard floating-point exception flags on lrint and fenv tests.
Nov 18 2020, 5:46 AM · PowerPC

Nov 5 2020

ngie committed rS367399: snmpmod(3): fix typo under the COMMUNITIES section.
snmpmod(3): fix typo under the COMMUNITIES section
Nov 5 2020, 9:37 PM

Oct 30 2020

ngie requested changes to D26220: Improve test coverage for sbuf.

This change does more than advertised in the CR description (which doesn't describe as much as the commit message should).

Oct 30 2020, 7:49 PM · tests
ngie updated subscribers of D26220: Improve test coverage for sbuf.
Oct 30 2020, 7:23 PM · tests

Oct 28 2020

ngie added a comment to D26932: jail(3lua): Add some basic tests.

I'll look through the rest of the review later.

Oct 28 2020, 5:12 PM

Oct 26 2020

ngie requested changes to D26930: atf.tests.mk: add bits needed for adding tests that use atf-lua.

I should have marked this as "Request Changes" in the last message :/...

Oct 26 2020, 3:50 PM
ngie added a comment to D26930: atf.tests.mk: add bits needed for adding tests that use atf-lua.

Wait... Lua? what Lua tests are you planning to add (for the bootloader)?

Oct 26 2020, 3:50 PM

Oct 20 2020

ngie accepted D26751: Significantly reduce compile time for googletest internal tests.

No blocking concerns.

Oct 20 2020, 7:02 PM

Oct 19 2020

ngie added a comment to D26751: Significantly reduce compile time for googletest internal tests.
In D26751#599033, @dim wrote:

Might as well go full -O0. :)

Running the tests at -O2 in QEMU amd64 took:
44.52 real 27.28 user 13.96 sys
Changing it to -O1 makes it
91.80 real 73.32 user 14.28 sys
and -O0 results in
109.46 real 90.08 user 14.38 sys

So we might as well use -O0 since it doesn't seem to make much of a run time difference but has a big impact on compile time :)

Oct 19 2020, 10:53 PM

Oct 15 2020

ngie added inline comments to D26067: Don't build googletest internal tests by default.
Oct 15 2020, 5:52 AM
ngie requested changes to D26067: Don't build googletest internal tests by default.
Oct 15 2020, 5:49 AM
ngie accepted D26760: Enable SUBDIR_PARALLEL for lib/googletest.
Oct 15 2020, 5:42 AM
ngie accepted D26789: [tests] Fix itimer test warning-errors on gcc-6.4.

This LGTM.

Oct 15 2020, 5:41 AM

Oct 6 2020

ngie accepted D26695: Do not allow to use O_BENEATH as an oracle..
Oct 6 2020, 7:16 PM

Oct 4 2020

ngie added a comment to D26632: Check for built-in tmpfs module.

LGTM!

Oct 4 2020, 10:00 PM

Oct 1 2020

ngie closed D20330: Eliminate duplicate `afterinstallconfigs` target.
Oct 1 2020, 4:37 PM
ngie committed rS366327: Eliminate duplicate `afterinstallconfigs` target.
Eliminate duplicate `afterinstallconfigs` target
Oct 1 2020, 4:37 PM
ngie added inline comments to D26616: zgrep: fix exit status with multiple files.
Oct 1 2020, 4:24 PM
ngie accepted D26616: zgrep: fix exit status with multiple files.

Macro shipit:

Oct 1 2020, 4:23 PM

Sep 30 2020

ngie added inline comments to D26473: Significantly speed up libthr/mutex_test and make more reliable.
Sep 30 2020, 9:12 PM

Sep 28 2020

ngie added a comment to D26549: Enabling SO_LINGER to the so_reuseport_lb_test regression tests.

The change is good from a technical standpoint, but some of the documentation could be a bit more polished.

Sep 28 2020, 3:05 PM

Sep 18 2020

ngie added a comment to D26473: Significantly speed up libthr/mutex_test and make more reliable.

Please add __FreeBSD__ around any test modifications; it makes it easier for folks to upstream the changes as we're 3 years out of date.

Sep 18 2020, 4:23 PM
ngie added inline comments to D26445: fix setitimer test for returned it_value.
Sep 18 2020, 6:40 AM

Sep 13 2020

ngie accepted D26397: build: provide a default WARNS for src builds.

surewhynot

Sep 13 2020, 11:51 PM

Sep 7 2020

ngie added a comment to D26278: Various fixes to the load() function..

Macro lgtm:

Sep 7 2020, 4:30 PM
ngie added a comment to D26281: Pass a valid mode with O_CREATE to open(2)..

Macro lgtm:

Sep 7 2020, 4:29 PM
ngie added a comment to D26333: Make zpool on GELI work again..

Macro stlgtm:

Sep 7 2020, 4:28 PM

Aug 20 2020

ngie requested changes to D26067: Don't build googletest internal tests by default.

Please use WITH_GOOGLETEST_INTERNAL_TESTS or something similar and default to on, since it seems to be limited to that case.

Aug 20 2020, 4:47 PM

Aug 10 2020

ngie added a comment to D25533: clear_tmp: Remove all chflags bits in /tmp before the clear proccess is initiated.

This shouldn't be committed to head.

Aug 10 2020, 4:41 PM

Aug 5 2020

ngie updated subscribers of D25935: skip sbin/route jail test if jail not installed.

I was a bit surprised to learn that this code relies on the jq utility from ports, by the way:

$ grep -r jq sbin/route/tests/
sbin/route/tests/utils.subr:    gateway=$(echo $result | jq -r ${query}.gateway)
sbin/route/tests/basic.sh:      atf_set require.progs jq
sbin/route/tests/basic.sh:      atf_set require.progs jq

I wish we had a tool capable of ingesting json in base :/...

Aug 5 2020, 6:01 PM

Jul 31 2020

ngie requested changes to D25896: Make capsicum test cases fine-grained.

NAK. I need to add Googletest support to kyua. Now that kyua has been forked, this is straightforward.

Jul 31 2020, 6:59 AM

Jul 25 2020

ngie committed rS363530: MFhead@r363529.
MFhead@r363529
Jul 25 2020, 5:27 PM
ngie committed rS363529: MFhead@r363528.
MFhead@r363528
Jul 25 2020, 4:35 PM

Jul 23 2020

ngie added inline comments to D25431: Add a few atf tests for sendfile, with and without I/O errors..
Jul 23 2020, 1:01 AM
ngie added a comment to D25431: Add a few atf tests for sendfile, with and without I/O errors..

Curious... is there a reason why this was added in addition to lib/libc/tests/sys/sendfile_test.c?

Jul 23 2020, 12:57 AM

Jul 21 2020

ngie added a comment to D25682: tests/sys/opencrypto: use python3.

This should work, for sure.

Jul 21 2020, 11:26 PM

Jul 12 2020

ngie committed rS363132: Don't leave `path` behind when executing `:chflags_success`.
Don't leave `path` behind when executing `:chflags_success`
Jul 12 2020, 5:17 PM
ngie closed D25561: Don't leave `path` behind when executing `:chflags_success`.
Jul 12 2020, 5:17 PM
ngie added inline comments to D25561: Don't leave `path` behind when executing `:chflags_success`.
Jul 12 2020, 5:11 PM

Jul 11 2020

ngie updated the diff for D25561: Don't leave `path` behind when executing `:chflags_success`.

Use UF_OFFLINE instead of SF_IMMUTABLE, as recommended by @asomers.

Jul 11 2020, 2:56 PM
ngie updated the summary of D25561: Don't leave `path` behind when executing `:chflags_success`.
Jul 11 2020, 2:55 PM

Jul 10 2020

ngie added a comment to D25561: Don't leave `path` behind when executing `:chflags_success`.

Instead of clearing flags, which might not be possible in a higher securelevel, how about just using UF_OFFLINE instead of SF_IMMUTABLE? That's what some of the other test cases do. The test doesn't care what the flag actually is; it just needs to be something.

Jul 10 2020, 11:31 PM

Jul 4 2020

ngie added a reviewer for D25561: Don't leave `path` behind when executing `:chflags_success`: tests.
Jul 4 2020, 5:00 PM
ngie requested review of D25561: Don't leave `path` behind when executing `:chflags_success`.
Jul 4 2020, 4:59 PM

Jun 24 2020

ngie closed D25302: Add `kern.features.witness`.
Jun 24 2020, 6:51 PM
ngie committed rS362591: Add `kern.features.witness`.
Add `kern.features.witness`
Jun 24 2020, 6:51 PM
ngie updated the test plan for D25302: Add `kern.features.witness`.
Jun 24 2020, 6:49 PM
ngie accepted D25419: Enable long double tests on RISC-V.

LGTM!

Jun 24 2020, 3:32 AM
ngie added a comment to D24613: skip bectl jail test if jail not installed.

LGTM

Jun 24 2020, 3:31 AM

Jun 23 2020

ngie updated the diff for D25302: Add `kern.features.witness`.

The FEATURE call should be moved down.

Jun 23 2020, 3:27 AM