Formerly known as "Garrett".
User Details
User Details
- User Since
- Aug 2 2014, 8:08 AM (227 w, 3 d)
Sun, Dec 9
Sun, Dec 9
ngie added a comment to D18490: netmap: add suite of unit tests.
(In addition to what @asomers said...)
Thu, Dec 6
Thu, Dec 6
Oct 13 2018
Oct 13 2018
ngie added inline comments to D17546: connect libc/tests/time to the build.
This still fails for century/year conversions indicating issues with our strptime that need to be taken care of.
Nov 7 2017
Nov 7 2017
Remove unnecessary src.opts.mk .include
Handle arm/armv[67] hosted/targeted builds gracefully
Use bsd.compiler.mk instead of src.opts.mk
Nov 6 2017
Nov 6 2017
ngie committed rS325470: Fix typo in bsd.opts.mk with force setting MK_MAKE_CHECK_TEST_WITH_COVERAGE:= no.
Fix typo in bsd.opts.mk with force setting MK_MAKE_CHECK_TEST_WITH_COVERAGE:= no
Forgot to use //g with my replace in r325465
Default GCOV_PREFIX to DESTDIR, use gather_coverage from DESTDIR, etc
Chase the gcno -> gcda bsd.lib.mk changes I made in a previous commit
Try a subtley different approach to the .pico and .ppico rules
Refactor how PIC_OBJS is defined/used; remove beforelinking dependency
Nov 5 2017
Nov 5 2017
ngie committed rS325450: Fix cosmetic nit when printing out "override $mode" and "$owner/$group ...".
Fix cosmetic nit when printing out "override $mode" and "$owner/$group ..."
ngie committed rS325449: Choose a simpler, more philosophically correct version for CRTARCH with armv[67].
Choose a simpler, more philosophically correct version for CRTARCH with armv[67]
ngie added a comment to D11824: syslog(3): example error log message should use LOG_ERR level (PR 216756).
ngie committed rS325443: Fix paths for cross-built versions of lib/libclang_rt and hardfloat arm variants.
Fix paths for cross-built versions of lib/libclang_rt and hardfloat arm variants
ngie committed rS325442: Support compiling lib/libclang_rt/profile a bit more with recent versions of gcc.
Support compiling lib/libclang_rt/profile a bit more with recent versions of gcc
Set PIC_OBJS immediately as a test for fixing libc_pic.a
ngie committed rS325431: This should rely on .o, not .pico.
This should rely on .o, not .pico
ngie committed rS325430: _COV_FLAG only needs to be omitted from build rules that use SHARED_C(XX)?FLAGS.
_COV_FLAG only needs to be omitted from build rules that use SHARED_C(XX)?FLAGS
Add OLD_FILES/OLD_LIBS entries for TARGET/TARGET_ARCH == arm/armv[67]
Define CRTARCH to armhf when TARGET/TARGET_ARCH are set to arm/armv[67]
.S.ppico should omit ${_COV_FLAG}, not .S.pico
Omit _COV_FLAG from PO_C(XX)FLAGS and from .S.ppico static targets
Nov 4 2017
Nov 4 2017
Oct 31 2017
Oct 31 2017
Checkpoint work to integrate coverage and make check together
Start hacking away with GCOV_PREFIX
Add MK_MAKE_CHECK_WITH_COVERAGE, reliant on MK_COVERAGE and…
ngie committed rS325213: Polish up end-user messages.
Polish up end-user messages
Start adding in simple wrapper around lgov/genhtml called gather_coverage
ngie committed rS325211: Fold all of the MK_COVERAGE _prereq_libs logic up. None of the deleted logic….
Fold all of the MK_COVERAGE _prereq_libs logic up. None of the deleted logic…
The append to _startup_libs was bogus; remove it
Add `static` to `cap_setgrent` prototype in !WITH_CASPER case
Remove c++ COMPILER_FEATURES check; it's not needed
Don't override MK_COVERAGE from bsd.opts.mk in the CLANG_IS_CC case
Shuffle MK_COVERAGE conditionals around
I'm fine with this change. It's pretty straightforward.
Oct 30 2017
Oct 30 2017
Throwing something else at the wall, seeing if it will stick
ngie committed rS325144: Let's see if the dependent relationship between MK_COVERAGE and MK_DEBUG_FILES.
Let's see if the dependent relationship between MK_COVERAGE and MK_DEBUG_FILES
Sort for consistency with bsd.prog.mk
Remove redundant DEFAULT_NO_OPTIONS specification for MK_COVERAGE
Remove the WMAKEENV forcing of MK_COVERAGE to no
Let's try enforcing profile_rt's build this way
Revert r325128; would break buildworld without TARGET_ARCH
ngie committed rS325128: Don't try overriding TARGET_ARCH from llvm.build.mk; rely on sys.mk's definition.
Don't try overriding TARGET_ARCH from llvm.build.mk; rely on sys.mk's definition
ngie committed rS325127: Pass down WANT_COMPILER_TYPE for debugging purposes and for sanity purposes.
Pass down WANT_COMPILER_TYPE for debugging purposes and for sanity purposes
Remove unnecessary C in .fwo file I accidentally made consistent
Fix a bad copy-paste (8000C -> 8265) done in r325122
Reference iwm8265fw support in iwm(4) as well
Fill in the blanks for iwm8265fw(4) rules, missed in r324434
ngie committed rS325121: iwmfw(4): update support info.
iwmfw(4): update support info
Oct 26 2017
Oct 26 2017
Remove unnecessary :U when testing COMPILER_FEATURES
Oct 25 2017
Oct 25 2017
Try setting MK_COVERAGE in WMAKEENV
I guess I have to use COMPILER_FEATURES, not X_COMPILER_FEATURES with…
Oct 23 2017
Oct 23 2017
ngie committed rS324931: Don't expand _coverage_libs.
Don't expand _coverage_libs
More trying to quash the stupidity of gcc 4.2.1
ngie committed rS324929: Clean up trailing whitespace.
Clean up trailing whitespace
Don't require ${DESTDIR}${_gcno_dir} until install
Diff reduce and try to apply MK_COVERAGE only against c++11 compilers
ngie committed rS324922: Move MK_COVERAGE fu before .include <bsd.mkopt.mk> so it's actually usable.
Move MK_COVERAGE fu before .include <bsd.mkopt.mk> so it's actually usable
Fix tabs before the style police nags me
Every day I'm shuffling (comments) to diff reduce
In the search of a perfect knob pairing
ngie committed rS324911: Fix an omission in a comment.
Fix an omission in a comment
ngie committed rS324910: Congrats riscv* : you unlike millions of americans will have coverage, even.
Congrats riscv* : you unlike millions of americans will have coverage, even
Die. Die. Die. Tinderbox failures on mips/powerpc
mips, you cause me too much grief with make tinderbox. Try this instead
ngie committed rS324904: Use BROKEN_OPTIONS for MK_COVERAGE=no so it will be documented in src.conf(5).
Use BROKEN_OPTIONS for MK_COVERAGE=no so it will be documented in src.conf(5)
Trying to get libgcov to work was a stupid, stupid rabbit hole to go down
Let's just nip gcc 4.2.1 in the bud and say MK_COVERAGE=no
ngie committed rS324901: Fix typo in previous commit.
Fix typo in previous commit