Page MenuHomeFreeBSD

ngie (Enji Cooper)
User

Projects

User Details

User Since
Aug 2 2014, 8:08 AM (271 w, 5 d)

Recent Activity

Sat, Sep 28

ngie updated the test plan for D21654: Upgrade devel/py-mock from 2.0.0 to 3.0.5 and fix "make test" target.
Sat, Sep 28, 1:22 AM
ngie edited P323 Masterwork From Distant Lands.
Sat, Sep 28, 1:19 AM

Fri, Sep 27

ngie accepted D21820: Fix coredump_phnum_test when kern.compress_user_cores != 0.

Macro like:

Fri, Sep 27, 10:02 PM

Thu, Sep 26

ngie updated the test plan for D21654: Upgrade devel/py-mock from 2.0.0 to 3.0.5 and fix "make test" target.
Thu, Sep 26, 11:50 PM

Tue, Sep 24

ngie accepted D21776: Fix sys/kern/coredump_phnum_test in case of kern.compress_user_cores=1.

allow_sysctl_side_effects is set in the test already — LGTM!
Macro goforit:

Tue, Sep 24, 4:08 PM

Thu, Sep 19

ngie added a comment to D21259: Upgrade devel/distcc to 3.3.3 and add pump support.

@fernape: could you please take this revision so I can sign off on the change?

Thu, Sep 19, 4:21 PM
ngie abandoned D19906: Add some simple regression tests for /sbin/rcorder.

Abandoning this revision.

Thu, Sep 19, 4:20 PM
ngie added a reviewer for D20330: Eliminate duplicate `afterinstallconfigs` target: bapt.
Thu, Sep 19, 4:19 PM
ngie added a comment to D20330: Eliminate duplicate `afterinstallconfigs` target.

Still an issue:

$ (cd ~/svn/freebsd/base/head/; svnversion; make -C lib/libc buildenv)
352519
make: "/home/ngie/svn/freebsd/base/head/lib/libc/net/Makefile.inc" line 130: warning: duplicate script for target "afterinstallconfig" ignored
make: "/home/ngie/svn/freebsd/base/head/lib/libc/gen/Makefile.inc" line 554: warning: using previous script for "afterinstallconfig" defined here
Entering world for amd64:amd64
Thu, Sep 19, 4:18 PM
ngie abandoned D19997: MFC r324736:.
In D19997#468014, @mjg wrote:

So this is not in stable/11 and it probably is not important to get there. It is in 12.0 Can this be closed?

Thu, Sep 19, 4:13 PM
ngie edited P313 Masterwork From Distant Lands.
Thu, Sep 19, 4:47 AM
ngie edited P312 Masterwork From Distant Lands.
Thu, Sep 19, 4:44 AM
ngie updated the diff for D21654: Upgrade devel/py-mock from 2.0.0 to 3.0.5 and fix "make test" target.

Restore the previous RUN_DEPENDS logic

Thu, Sep 19, 4:27 AM

Wed, Sep 18

ngie added a comment to D21654: Upgrade devel/py-mock from 2.0.0 to 3.0.5 and fix "make test" target.

Hi ngie,
Can you please complete build testing ("poudriere bulk -j 12amd64 -t devel/py-buildbot-www devel/py-oslotest ...") for the following ports which depend on this port?
As shown by https://www.freshports.org/devel/py-mock:

This port is required by:

for Build
        devel/py-buildbot-www
        devel/py-oslotest
        graphics/qgis
        graphics/qgis-ltr
        security/py-keystone
for Run
        audio/py-gmusicapi
        devel/py-oslotest
        devel/py-pytest-shutil
        devel/py-responses
        devel/py-sure
        devel/py-vsts-cd-manager
        graphics/qgis
        graphics/qgis-ltr
        science/py-MDAnalysis
        science/py-MDAnalysisTests
        security/py-certbot-apache
        security/py-certbot-dns-cloudflare
        security/py-certbot-dns-cloudxns
        security/py-certbot-dns-digitalocean
        security/py-certbot-dns-dnsimple
        security/py-certbot-dns-dnsmadeeasy
        security/py-certbot-dns-gehirn
        security/py-certbot-dns-google
        security/py-certbot-dns-linode
        security/py-certbot-dns-luadns
        security/py-certbot-dns-nsone
        security/py-certbot-dns-ovh
        security/py-certbot-dns-rfc2136
        security/py-certbot-dns-route53
        security/py-certbot-dns-sakuracloud
        security/py-certbot-nginx
        sysutils/py-azure-cli
        sysutils/py-azure-cli-batchai
        textproc/py-mkdocs
        www/py-kallithea
        www/py-rhodecode
Wed, Sep 18, 2:36 PM
ngie updated the summary of D21654: Upgrade devel/py-mock from 2.0.0 to 3.0.5 and fix "make test" target.
Wed, Sep 18, 2:14 PM
ngie retitled D21654: Upgrade devel/py-mock from 2.0.0 to 3.0.5 and fix "make test" target from Upgrade devel/py-mock from 2.0.0 to 3.0.5 to Upgrade devel/py-mock from 2.0.0 to 3.0.5 and fix "make test" target.
Wed, Sep 18, 2:12 PM
ngie updated the diff for D21654: Upgrade devel/py-mock from 2.0.0 to 3.0.5 and fix "make test" target.

Remove devel/py-tox dependency

Wed, Sep 18, 2:10 PM
ngie updated the diff for D21654: Upgrade devel/py-mock from 2.0.0 to 3.0.5 and fix "make test" target.

Update the diff after feedback received and to fix the test target
by using github to pull down the sources and pytest to run the tests,
like tox.ini does.

Wed, Sep 18, 2:09 PM
ngie added inline comments to D21654: Upgrade devel/py-mock from 2.0.0 to 3.0.5 and fix "make test" target.
Wed, Sep 18, 2:08 PM
ngie updated the summary of D21654: Upgrade devel/py-mock from 2.0.0 to 3.0.5 and fix "make test" target.
Wed, Sep 18, 2:06 PM
ngie updated the summary of D21654: Upgrade devel/py-mock from 2.0.0 to 3.0.5 and fix "make test" target.
Wed, Sep 18, 2:02 PM
ngie edited P311 Masterwork From Distant Lands.
Wed, Sep 18, 1:59 PM
ngie edited P310 Masterwork From Distant Lands.
Wed, Sep 18, 1:58 PM
ngie edited P309 Masterwork From Distant Lands.
Wed, Sep 18, 1:54 PM

Sep 14 2019

ngie updated the summary of D21654: Upgrade devel/py-mock from 2.0.0 to 3.0.5 and fix "make test" target.
Sep 14 2019, 12:17 AM
ngie created D21654: Upgrade devel/py-mock from 2.0.0 to 3.0.5 and fix "make test" target.
Sep 14 2019, 12:15 AM

Sep 4 2019

ngie accepted D21519: procstat/tests: Fix flakiness by waiting for program to start.

Thank you for fixing my flaky test (and for teaching me a new tidbit about shell support)!

Sep 4 2019, 2:20 PM

Aug 24 2019

ngie added inline comments to D21259: Upgrade devel/distcc to 3.3.3 and add pump support.
Aug 24 2019, 2:36 AM
ngie added a comment to D21259: Upgrade devel/distcc to 3.3.3 and add pump support.

I'll take a closer look at this sometime this weekend..

Aug 24 2019, 2:35 AM

Aug 23 2019

ngie updated the summary of D21259: Upgrade devel/distcc to 3.3.3 and add pump support.
Aug 23 2019, 4:18 PM
ngie added a comment to D21259: Upgrade devel/distcc to 3.3.3 and add pump support.
  • Shuffle around installing the README files (they shouldn't be reliant on PUMP support)
  • Fix the duplicate prefixing of distcc in ETCDIR.
Aug 23 2019, 4:08 PM
ngie added a comment to D21259: Upgrade devel/distcc to 3.3.3 and add pump support.

Hi Enjie,
Sorry for the last commit.
I arc patched this review and tested in poudriere for {11.2,12.0}{amd64}{i386} and I'm seeing pkg-plist issues:

===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: etc/default/distcc
Error: Orphaned: %%ETCDIR%%/clients.allow
Error: Orphaned: %%ETCDIR%%/commands.allow.sh
Error: Orphaned: %%ETCDIR%%/hosts
Error: Orphaned: man/man1/include_server.1.gz
Error: Orphaned: man/man1/lsdistcc.1.gz
Error: Orphaned: man/man1/pump.1.gz
Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/COPYING
Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/README.pump
Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/TODO
Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/example/README
Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/example/default
Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/example/hosts.allow
Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/example/init
Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/example/init-suse
Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/example/logrotate
Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/example/services
Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/example/xinetd
Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/protocol-3-impl.txt
Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/protocol-3.txt
Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/protocol-gssapi.txt
Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/survey.txt
===> Checking for items in pkg-plist which are not in STAGEDIR
===> Error: Plist issues found.

Do you see the same?

Aug 23 2019, 4:03 PM
ngie retitled D21259: Upgrade devel/distcc to 3.3.3 and add pump support from Upgrade devel/distcc to 3.3.2 and add pump support to Upgrade devel/distcc to 3.3.3 and add pump support.
Aug 23 2019, 4:00 PM
ngie added a comment to D21259: Upgrade devel/distcc to 3.3.3 and add pump support.

Address some of @fernape's concerns and all of @mat's concerns

Aug 23 2019, 3:59 PM
ngie added a comment to D21259: Upgrade devel/distcc to 3.3.3 and add pump support.

I have a new patch that addresses some of the things pointed by @mat and updates the port to 3.3.3 (recently released).
Since I'm not the creator of the review I don't know if it is OK to just arc diff --update this?

Aug 23 2019, 3:29 PM

Aug 16 2019

D21279: Update pthread_cond_timedwait() test to current NetBSD version is now accepted and ready to land.

Macro lgtm:

Aug 16 2019, 4:45 AM

Aug 14 2019

ngie added inline comments to D21259: Upgrade devel/distcc to 3.3.3 and add pump support.
Aug 14 2019, 3:29 PM
ngie added a comment to D21259: Upgrade devel/distcc to 3.3.3 and add pump support.

Remove unnecessary upstream divergence with GZIP call

Aug 14 2019, 6:25 AM
ngie added a comment to D21259: Upgrade devel/distcc to 3.3.3 and add pump support.

Install pump with INSTALL_SCRIPT, not INSTALL_PROGRAM, so STRIP can be enabled again

Aug 14 2019, 6:00 AM
ngie edited P299 Masterwork From Distant Lands.
Aug 14 2019, 5:58 AM
ngie added a comment to D21259: Upgrade devel/distcc to 3.3.3 and add pump support.

Mute gzip --help noise by redirecting stderr to /dev/null

Aug 14 2019, 5:54 AM
ngie updated the test plan for D21259: Upgrade devel/distcc to 3.3.3 and add pump support.
Aug 14 2019, 5:53 AM
ngie edited P298 Masterwork From Distant Lands.
Aug 14 2019, 5:53 AM
ngie updated the test plan for D21259: Upgrade devel/distcc to 3.3.3 and add pump support.
Aug 14 2019, 5:44 AM
ngie updated the test plan for D21259: Upgrade devel/distcc to 3.3.3 and add pump support.
Aug 14 2019, 5:44 AM
ngie edited P297 Masterwork From Distant Lands.
Aug 14 2019, 5:43 AM
ngie updated the summary of D21259: Upgrade devel/distcc to 3.3.3 and add pump support.
Aug 14 2019, 5:43 AM
ngie created D21259: Upgrade devel/distcc to 3.3.3 and add pump support.
Aug 14 2019, 5:42 AM

Aug 10 2019

ngie committed rS350837: tests/sys/opencrypto: enable armv8crypto on aarch64.
tests/sys/opencrypto: enable armv8crypto on aarch64
Aug 10 2019, 3:54 PM
ngie closed D21018: tests/sys/opencrypto: enable armv8crypto.
Aug 10 2019, 3:53 PM · arm64

Aug 7 2019

ngie committed rS350672: MFhead@r350671.
MFhead@r350671
Aug 7 2019, 4:09 AM

Aug 5 2019

D21161: indent: rename a test data file is now accepted and ready to land.
An internal tool at Isilon expects files named *.list to be in a
certain format, which this file is not. Rename it.

*facepalm* this is really happening? Oy...

Aug 5 2019, 2:13 AM

Aug 3 2019

ngie committed rS350564: MFhead@r350563.
MFhead@r350563
Aug 3 2019, 10:43 PM

Jul 22 2019

ngie added a comment to D21018: tests/sys/opencrypto: enable armv8crypto.

Could you please test this change out on amd64?

Jul 22 2019, 4:15 PM · arm64

Jul 18 2019

ngie committed rS350107: MFhead@r350106.
MFhead@r350106
Jul 18 2019, 4:50 AM

Jul 16 2019

ngie added a comment to D20972: Add missing permissions in open(2) calls with O_CREAT..

This is totally fine —- as long as the upstream commits are referenced, I’m ok with that (my concern is with changes not being communicated beforehand and having to reverse engineer where and how to upstream them to the other projects, since things tend to change from time to time).

Jul 16 2019, 10:15 PM

Jul 15 2019

D20943: Fix test for lib/libc/net/servent_test is now accepted and ready to land.

lgtm

Jul 15 2019, 4:19 PM
ngie added a comment to D20943: Fix test for lib/libc/net/servent_test.
In D20943#453979, @ngie wrote:

Good eye!
Could you please adjust the script from the Makefile so this script doesn’t need to diverge from upstream?

What do you man by adjusting the script from the Makefile ?
Do you mean modifying lib/libc/tests/net/Makefile to add an action to rename services.cdb ?

Jul 15 2019, 3:10 PM

Jul 12 2019

D20943: Fix test for lib/libc/net/servent_test now requires changes to proceed.

Good eye!

Jul 12 2019, 11:49 PM

Jul 10 2019

ngie added a comment to D20894: Correct definitions in sys.opencrypto.runtests.main for 32bit platform.

This should actually be obtained via ctypes.

Jul 10 2019, 5:02 AM

May 27 2019

ngie updated subscribers of D20344: Add deprecation warnings for weaker algorithms to geli(4)..

A change related to this broke CI (example):

...
Fail: incorrect exit status: 1, expected: 0
stdout:
May 27 2019, 4:41 AM
ngie updated subscribers of D19298: AESNI version of CCM+CBC-MAC.
  1. This broke the build with gcc:
11:40:34 --- all_subdir_aesni ---
11:40:34 /workspace/src/sys/crypto/aesni/aesni_ccm.c: In function 'xor_and_encrypt':
11:40:34 /workspace/src/sys/crypto/aesni/aesni_ccm.c:61:18: error: incompatible types when initializing type '__m128 {aka __vector(4) float}' using type '__m128i {aka __vector(2) long long int}'
11:40:34   __m128 retval = _mm_xor_si128(a, b);
11:40:34                   ^~~~~~~~~~~~~
11:40:34 /workspace/src/sys/crypto/aesni/aesni_ccm.c:63:21: error: incompatible type for argument 3 of 'aesni_enc'
11:40:34   retval = AESNI_ENC(retval, k, nr);
11:40:34                      ^
11:40:34 /workspace/src/sys/crypto/aesni/aesni_ccm.c:47:64: note: in definition of macro 'AESNI_ENC'
11:40:34  #define AESNI_ENC(d, k, nr) aesni_enc(nr-1, (const __m128i*)k, d)
11:40:34                                                                 ^
11:40:34 In file included from /workspace/src/sys/crypto/aesni/aesni_ccm.c:46:0:
11:40:34 /workspace/src/sys/crypto/aesni/aesencdec.h:115:1: note: expected '__m128i {aka const __vector(2) long long int}' but argument is of type '__m128 {aka __vector(4) float}'
11:40:34  aesni_enc(int rounds, const __m128i *keysched, const __m128i from)
11:40:34  ^~~~~~~~~
11:40:34 /workspace/src/sys/crypto/aesni/aesni_ccm.c:64:9: error: incompatible types when returning type '__m128 {aka __vector(4) float}' but '__m128i {aka __vector(2) long long int}' was expected
11:40:34   return (retval);
11:40:34          ^
11:40:34 /workspace/src/sys/crypto/aesni/aesni_ccm.c:65:1: error: control reaches end of non-void function [-Werror=return-type]
11:40:34  }
11:40:34  ^
  1. Why was this committed without signoff from someone on secteam (CC: secteam)?
May 27 2019, 12:19 AM

May 23 2019

ngie committed rS348142: Ensure that coverage-capable linkers only include lld right now.
Ensure that coverage-capable linkers only include lld right now
May 23 2019, 1:48 AM
ngie committed rS348140: MFC r346431,r347417,r348019:.
MFC r346431,r347417,r348019:
May 23 2019, 1:25 AM
ngie committed rS348139: Regenerate src.conf(5) after r348138.
Regenerate src.conf(5) after r348138
May 23 2019, 1:13 AM
ngie committed rS348138: MFC r345203,r345205,r345353,r345645,r345708,r345709,r345735,r345770,r346081….
MFC r345203,r345205,r345353,r345645,r345708,r345709,r345735,r345770,r346081…
May 23 2019, 1:09 AM
ngie committed rS348137: Revert r348136.
Revert r348136
May 23 2019, 12:59 AM
ngie committed rS348136: MFC r345203,r345205,r345353,r345645,r345708,r345709,r345735,r345770,r346574….
MFC r345203,r345205,r345353,r345645,r345708,r345709,r345735,r345770,r346574…
May 23 2019, 12:56 AM

May 21 2019

ngie edited P259 Masterwork From Distant Lands.
May 21 2019, 5:05 AM
ngie created D20330: Eliminate duplicate `afterinstallconfigs` target.
May 21 2019, 4:52 AM
ngie committed rS348048: MFhead@r348047.
MFhead@r348047
May 21 2019, 4:42 AM
ngie committed rS348047: Add my name to the copyright.
Add my name to the copyright
May 21 2019, 4:41 AM
ngie committed rS348045: Follow up to r348042: cast `aad` to a byte array.
Follow up to r348042: cast `aad` to a byte array
May 21 2019, 4:41 AM
ngie committed rS348046: MFhead@r348045.
MFhead@r348045
May 21 2019, 4:41 AM
ngie committed rS348044: Diff reduce with ^/head.
Diff reduce with ^/head
May 21 2019, 4:41 AM
ngie committed rS348042: Fix encoding issues with python 3.
Fix encoding issues with python 3
May 21 2019, 4:41 AM
ngie committed rS348043: MFhead@r348042.
MFhead@r348042
May 21 2019, 4:41 AM
ngie committed rS348041: Leverage `str_to_ascii(..)` in `_findop(..)` when encoding `fop.name`.
Leverage `str_to_ascii(..)` in `_findop(..)` when encoding `fop.name`
May 21 2019, 3:06 AM
ngie committed rS348039: Remove spurious newline.
Remove spurious newline
May 21 2019, 2:49 AM
ngie committed rS348038: MFhead@r348037.
MFhead@r348037
May 21 2019, 2:46 AM
ngie committed rS348037: Rename Crypto._to_bytes to Crypto.str_to_ascii and push it into the module….
Rename Crypto._to_bytes to Crypto.str_to_ascii and push it into the module…
May 21 2019, 2:44 AM
ngie committed rS348032: Fix `KAT(CCM)?Parser` file descriptor leaks.
Fix `KAT(CCM)?Parser` file descriptor leaks
May 21 2019, 2:30 AM
ngie committed rS348031: Squash deprecation warning related to array.array(..).tostring().
Squash deprecation warning related to array.array(..).tostring()
May 21 2019, 2:14 AM
ngie committed rS348030: Fix remaining encoding issues with python 3.
Fix remaining encoding issues with python 3
May 21 2019, 2:02 AM
ngie committed rS348029: MFhead@r348028.
MFhead@r348028
May 21 2019, 1:56 AM
ngie committed rS348025: Unbreak the build when `ELF_VERBOSE` is defined after r348005.
Unbreak the build when `ELF_VERBOSE` is defined after r348005
May 21 2019, 12:47 AM
ngie committed rS348024: Followup to r347996.
Followup to r347996
May 21 2019, 12:30 AM
ngie committed rS348023: MFhead@r348022.
MFhead@r348022
May 21 2019, 12:08 AM

May 20 2019

ngie committed rS348021: Don't raise StopIteration when complete; a bare return suffices.
Don't raise StopIteration when complete; a bare return suffices
May 20 2019, 10:37 PM
ngie committed rS348019: Allow the end-user to pass along arguments to cryptotest.py via….
Allow the end-user to pass along arguments to cryptotest.py via…
May 20 2019, 10:32 PM
ngie committed rS348017: Fix up KatCCMParser test usage.
Fix up KatCCMParser test usage
May 20 2019, 10:21 PM
ngie committed rS348015: Apply r346610 to `self.runSHA` to unbreak the test(s).
Apply r346610 to `self.runSHA` to unbreak the test(s)
May 20 2019, 10:03 PM
ngie committed rS348014: Add backwards compatibility method for python 2.x.
Add backwards compatibility method for python 2.x
May 20 2019, 9:55 PM
ngie added inline comments to D20124: Mention atf(7) in tests(7).
May 20 2019, 8:56 PM
ngie requested changes to D20124: Mention atf(7) in tests(7).
May 20 2019, 8:55 PM
ngie committed rS347997: MFhead@r347996.
MFhead@r347996
May 20 2019, 4:39 PM
ngie committed rS347996: Replace uses of `foo.(de|en)code('hex')` with `binascii.(un)?hexlify(foo)`.
Replace uses of `foo.(de|en)code('hex')` with `binascii.(un)?hexlify(foo)`
May 20 2019, 4:38 PM
ngie committed rS347994: Replace more instances of .decode('hex') with binascii.unhexlify for py3….
Replace more instances of .decode('hex') with binascii.unhexlify for py3…
May 20 2019, 4:23 PM
ngie committed rS347993: Fix some improper binascii conversions.
Fix some improper binascii conversions
May 20 2019, 4:16 PM
ngie committed rS347987: MFhead@r347986.
MFhead@r347986
May 20 2019, 8:02 AM