♟ ngie

Abandoning review based on in-depth analysis from @tuexen.

Use `range` instead of `xrange`

Fix typo: `Plen` should be `plen`

Don't leak `fd` when manipulating the device via `_getdev()`

except EnvironmentError, e -> except EnvironmentError as e for py3 compat

Reapply whitespace style changes from r346443 after recent changes to…

In D20017#430611, @lwhsu wrote:

ncat is from nmap port and has nothing to do with nc, their names are similar but they are different things.
It's fine to install tests requirements from ports, after all, kyua is installed from ports and it's an essential tool for running the tests.
For marking the tests, what I was saying is "skip the tests (and not report failure) when there is no nmap (ncat) installed, and have a message to users to install nmap."

In D20017#430585, @tuexen wrote:

In D20017#430241, @lwhsu wrote:

OK, I just check we have nmap in the test vm image and it does the work: https://github.com/freebsd/freebsd-ci/commit/689e19c8c71e1892f476c9ef9392f6b443d0ed15
The other failures are due to some perl stuff which I haven't had time on it: https://ci.freebsd.org/job/FreeBSD-head-amd64-dtrace_test/lastCompletedBuild/testReport/common.ip/t_dtrace_contrib/tst_ipv4localsctp_ksh/

I'm debugging this now. Seems to be a kernel issue. Will let you know once I have understood and fixed the issue.
Is using ncat and issue?

In D20017#430242, @lwhsu wrote:

I'd prefer let's fix these test cases.

Don't forget sys import!

Ugh. Deal with encoding/decoding UTF-8 strings to bytes as needed

Chase more needed `.{de,en}code()` -> `binascii.(un)?hexlify` changes

KATParser: don't leak `self.fp`

Ok, let's proceed with this change. I'll work on fixing the style issues on my branch.

@olivier: Approved! Please be sure to update the commit message before you commit. Thank you so very much <3!

Backport patch to fix error check with access(3) failures

Remove a superfluous `)`

Update the comment above the coverage COMPILER_FEATURES test

Add `coverage` to *COMPILER_FEATURES variable to bsd.compiler.mk and test for it

Committed as rS346574 and rS346576.

Build libclang_rt/profile on all clang-supported architectures

Move the SUBDIR+= profile outside the architecture dependent blocks

Prune branch, merged as r346574 and r346576

Fix up CXXSTD support originally added in r345708

Rework CXXSTD setting via r345708

Update the spelling of my name (continuation of r346571)

Update the spelling of my name

Fix sys.kern.coredump_phnum_test.coredump_phnum on i386

In D20005#429909, @lwhsu wrote:

Thanks for the better fix. BTW, I still think these checks would be better to be rewritten as getting the real number and compare with 65535.

Fix `get_int_via_sysctlbyname(..)` on Jenkins

I've proposed a different solution in D20005.

MFC r339473,r340075,r342918,r343592,r343593,r343614,r343665,r343669:

Switch the conditional to only disable COVERAGE/COVERAGE_SUPPORT when not…

Rely on the MACHINE_CPUARCH, etc logic in lib/libclang_rt

Really compile profile/ on all clang-supported arches

This moved SUBDIR+= profile inside another .if block :/...

Only try building lib/libclang_rt/profile if MK_CLANG != no

Import patch from D19895 for reworking how CXXSTD is handled

Use CFLAGS instead of CXXFLAGS for -fvisibility=default

Comment out checks that are causing failures on ^/stable/11, post-r337133

Sidenote: given that it's been over 2 weeks since you put this out for review, I think you can put in Reviewed by: jmg (maintainer timeout).

Requesting changes because there are a handful of non-style nits that should be resolved before this is committed to ^/head .

LGTM! Please commit this change to ^/head.

Fix accidental diff update in last revision

That's not what I wanted to do >_>...

Build libclang_rt/profile on all clang-supported architectures

Quick branch for hacking on getting python3 support to work for…

Fix up `kern.cryptodevallowsoft` handling

Replace `str.{decode,encode}("hex")` with binascii.(un)?hexlify

Use py3 compatible method for catching exceptions

Hack away at runtests

tests/sys/opencrypto: fix whitespace per PEP8

MFC r345644,r346061:

In D19906#427977, @asomers wrote:

That's a lot of tiny files! Would it be possible and desirable to reduce the file count by using here documents or something?

I reworded the commit message/review name. Please use -g, not -d.

Fix warnings with lib/libpmc

Handle more missing changes to bsd.lib.mk for installing .gcno files

Port MK_COVERAGE changes over to bsd.lib.mk

Try again with a patched libcurl

Let's try triggering the issue in bug 233177 again

Sort the Makefile variables per style.Makefile(9)

Take a more relaxed approach to CXXSTD

ngie (Enji Cooper)
User

Projects

User Details

Recent Activity
View All

Yesterday

Tue, Apr 23

Mon, Apr 22

Sun, Apr 21

Sat, Apr 20

Tue, Apr 16

Mon, Apr 15

Sun, Apr 14

Sat, Apr 13

Fri, Apr 12

ngie (Enji Cooper)User