Page MenuHomeFreeBSD

ngie (Enji Cooper)
User

Projects

User Details

User Since
Aug 2 2014, 8:08 AM (263 w, 2 d)

Recent Activity

Fri, Aug 16

D21279: Update pthread_cond_timedwait() test to current NetBSD version is now accepted and ready to land.

Macro lgtm:

Fri, Aug 16, 4:45 AM

Wed, Aug 14

ngie added inline comments to D21259: Upgrade devel/distcc to 3.3.2 and add pump support.
Wed, Aug 14, 3:29 PM
ngie added a comment to D21259: Upgrade devel/distcc to 3.3.2 and add pump support.

Remove unnecessary upstream divergence with GZIP call

Wed, Aug 14, 6:25 AM
ngie added a comment to D21259: Upgrade devel/distcc to 3.3.2 and add pump support.

Install pump with INSTALL_SCRIPT, not INSTALL_PROGRAM, so STRIP can be enabled again

Wed, Aug 14, 6:00 AM
ngie edited P299 Masterwork From Distant Lands.
Wed, Aug 14, 5:58 AM
ngie added a comment to D21259: Upgrade devel/distcc to 3.3.2 and add pump support.

Mute gzip --help noise by redirecting stderr to /dev/null

Wed, Aug 14, 5:54 AM
ngie updated the test plan for D21259: Upgrade devel/distcc to 3.3.2 and add pump support.
Wed, Aug 14, 5:53 AM
ngie edited P298 Masterwork From Distant Lands.
Wed, Aug 14, 5:53 AM
ngie updated the test plan for D21259: Upgrade devel/distcc to 3.3.2 and add pump support.
Wed, Aug 14, 5:44 AM
ngie updated the test plan for D21259: Upgrade devel/distcc to 3.3.2 and add pump support.
Wed, Aug 14, 5:44 AM
ngie edited P297 Masterwork From Distant Lands.
Wed, Aug 14, 5:43 AM
ngie updated the summary of D21259: Upgrade devel/distcc to 3.3.2 and add pump support.
Wed, Aug 14, 5:43 AM
ngie created D21259: Upgrade devel/distcc to 3.3.2 and add pump support.
Wed, Aug 14, 5:42 AM

Sat, Aug 10

ngie committed rS350837: tests/sys/opencrypto: enable armv8crypto on aarch64.
tests/sys/opencrypto: enable armv8crypto on aarch64
Sat, Aug 10, 3:54 PM
ngie closed D21018: tests/sys/opencrypto: enable armv8crypto.
Sat, Aug 10, 3:53 PM · arm64

Wed, Aug 7

ngie committed rS350672: MFhead@r350671.
MFhead@r350671
Wed, Aug 7, 4:09 AM

Mon, Aug 5

D21161: indent: rename a test data file is now accepted and ready to land.
An internal tool at Isilon expects files named *.list to be in a
certain format, which this file is not. Rename it.

*facepalm* this is really happening? Oy...

Mon, Aug 5, 2:13 AM

Sat, Aug 3

ngie committed rS350564: MFhead@r350563.
MFhead@r350563
Sat, Aug 3, 10:43 PM

Mon, Jul 22

ngie added a comment to D21018: tests/sys/opencrypto: enable armv8crypto.

Could you please test this change out on amd64?

Mon, Jul 22, 4:15 PM · arm64

Jul 18 2019

ngie committed rS350107: MFhead@r350106.
MFhead@r350106
Jul 18 2019, 4:50 AM

Jul 16 2019

ngie added a comment to D20972: Add missing permissions in open(2) calls with O_CREAT..

This is totally fine —- as long as the upstream commits are referenced, I’m ok with that (my concern is with changes not being communicated beforehand and having to reverse engineer where and how to upstream them to the other projects, since things tend to change from time to time).

Jul 16 2019, 10:15 PM

Jul 15 2019

D20943: Fix test for lib/libc/net/servent_test is now accepted and ready to land.

lgtm

Jul 15 2019, 4:19 PM
ngie added a comment to D20943: Fix test for lib/libc/net/servent_test.
In D20943#453979, @ngie wrote:

Good eye!
Could you please adjust the script from the Makefile so this script doesn’t need to diverge from upstream?

What do you man by adjusting the script from the Makefile ?
Do you mean modifying lib/libc/tests/net/Makefile to add an action to rename services.cdb ?

Jul 15 2019, 3:10 PM

Jul 12 2019

D20943: Fix test for lib/libc/net/servent_test now requires changes to proceed.

Good eye!

Jul 12 2019, 11:49 PM

Jul 10 2019

ngie added a comment to D20894: Correct definitions in sys.opencrypto.runtests.main for 32bit platform.

This should actually be obtained via ctypes.

Jul 10 2019, 5:02 AM

May 27 2019

ngie updated subscribers of D20344: Add deprecation warnings for weaker algorithms to geli(4)..

A change related to this broke CI (example):

...
Fail: incorrect exit status: 1, expected: 0
stdout:
May 27 2019, 4:41 AM
ngie updated subscribers of D19298: AESNI version of CCM+CBC-MAC.
  1. This broke the build with gcc:
11:40:34 --- all_subdir_aesni ---
11:40:34 /workspace/src/sys/crypto/aesni/aesni_ccm.c: In function 'xor_and_encrypt':
11:40:34 /workspace/src/sys/crypto/aesni/aesni_ccm.c:61:18: error: incompatible types when initializing type '__m128 {aka __vector(4) float}' using type '__m128i {aka __vector(2) long long int}'
11:40:34   __m128 retval = _mm_xor_si128(a, b);
11:40:34                   ^~~~~~~~~~~~~
11:40:34 /workspace/src/sys/crypto/aesni/aesni_ccm.c:63:21: error: incompatible type for argument 3 of 'aesni_enc'
11:40:34   retval = AESNI_ENC(retval, k, nr);
11:40:34                      ^
11:40:34 /workspace/src/sys/crypto/aesni/aesni_ccm.c:47:64: note: in definition of macro 'AESNI_ENC'
11:40:34  #define AESNI_ENC(d, k, nr) aesni_enc(nr-1, (const __m128i*)k, d)
11:40:34                                                                 ^
11:40:34 In file included from /workspace/src/sys/crypto/aesni/aesni_ccm.c:46:0:
11:40:34 /workspace/src/sys/crypto/aesni/aesencdec.h:115:1: note: expected '__m128i {aka const __vector(2) long long int}' but argument is of type '__m128 {aka __vector(4) float}'
11:40:34  aesni_enc(int rounds, const __m128i *keysched, const __m128i from)
11:40:34  ^~~~~~~~~
11:40:34 /workspace/src/sys/crypto/aesni/aesni_ccm.c:64:9: error: incompatible types when returning type '__m128 {aka __vector(4) float}' but '__m128i {aka __vector(2) long long int}' was expected
11:40:34   return (retval);
11:40:34          ^
11:40:34 /workspace/src/sys/crypto/aesni/aesni_ccm.c:65:1: error: control reaches end of non-void function [-Werror=return-type]
11:40:34  }
11:40:34  ^
  1. Why was this committed without signoff from someone on secteam (CC: secteam)?
May 27 2019, 12:19 AM

May 23 2019

ngie committed rS348142: Ensure that coverage-capable linkers only include lld right now.
Ensure that coverage-capable linkers only include lld right now
May 23 2019, 1:48 AM
ngie committed rS348140: MFC r346431,r347417,r348019:.
MFC r346431,r347417,r348019:
May 23 2019, 1:25 AM
ngie committed rS348139: Regenerate src.conf(5) after r348138.
Regenerate src.conf(5) after r348138
May 23 2019, 1:13 AM
ngie committed rS348138: MFC r345203,r345205,r345353,r345645,r345708,r345709,r345735,r345770,r346081….
MFC r345203,r345205,r345353,r345645,r345708,r345709,r345735,r345770,r346081…
May 23 2019, 1:09 AM
ngie committed rS348137: Revert r348136.
Revert r348136
May 23 2019, 12:59 AM
ngie committed rS348136: MFC r345203,r345205,r345353,r345645,r345708,r345709,r345735,r345770,r346574….
MFC r345203,r345205,r345353,r345645,r345708,r345709,r345735,r345770,r346574…
May 23 2019, 12:56 AM

May 21 2019

ngie edited P259 Masterwork From Distant Lands.
May 21 2019, 5:05 AM
ngie created D20330: Eliminate duplicate `afterinstallconfigs` target.
May 21 2019, 4:52 AM
ngie committed rS348048: MFhead@r348047.
MFhead@r348047
May 21 2019, 4:42 AM
ngie committed rS348047: Add my name to the copyright.
Add my name to the copyright
May 21 2019, 4:41 AM
ngie committed rS348045: Follow up to r348042: cast `aad` to a byte array.
Follow up to r348042: cast `aad` to a byte array
May 21 2019, 4:41 AM
ngie committed rS348046: MFhead@r348045.
MFhead@r348045
May 21 2019, 4:41 AM
ngie committed rS348044: Diff reduce with ^/head.
Diff reduce with ^/head
May 21 2019, 4:41 AM
ngie committed rS348042: Fix encoding issues with python 3.
Fix encoding issues with python 3
May 21 2019, 4:41 AM
ngie committed rS348043: MFhead@r348042.
MFhead@r348042
May 21 2019, 4:41 AM
ngie committed rS348041: Leverage `str_to_ascii(..)` in `_findop(..)` when encoding `fop.name`.
Leverage `str_to_ascii(..)` in `_findop(..)` when encoding `fop.name`
May 21 2019, 3:06 AM
ngie committed rS348039: Remove spurious newline.
Remove spurious newline
May 21 2019, 2:49 AM
ngie committed rS348038: MFhead@r348037.
MFhead@r348037
May 21 2019, 2:46 AM
ngie committed rS348037: Rename Crypto._to_bytes to Crypto.str_to_ascii and push it into the module….
Rename Crypto._to_bytes to Crypto.str_to_ascii and push it into the module…
May 21 2019, 2:44 AM
ngie committed rS348032: Fix `KAT(CCM)?Parser` file descriptor leaks.
Fix `KAT(CCM)?Parser` file descriptor leaks
May 21 2019, 2:30 AM
ngie committed rS348031: Squash deprecation warning related to array.array(..).tostring().
Squash deprecation warning related to array.array(..).tostring()
May 21 2019, 2:14 AM
ngie committed rS348030: Fix remaining encoding issues with python 3.
Fix remaining encoding issues with python 3
May 21 2019, 2:02 AM
ngie committed rS348029: MFhead@r348028.
MFhead@r348028
May 21 2019, 1:56 AM
ngie committed rS348025: Unbreak the build when `ELF_VERBOSE` is defined after r348005.
Unbreak the build when `ELF_VERBOSE` is defined after r348005
May 21 2019, 12:47 AM
ngie committed rS348024: Followup to r347996.
Followup to r347996
May 21 2019, 12:30 AM
ngie committed rS348023: MFhead@r348022.
MFhead@r348022
May 21 2019, 12:08 AM

May 20 2019

ngie committed rS348021: Don't raise StopIteration when complete; a bare return suffices.
Don't raise StopIteration when complete; a bare return suffices
May 20 2019, 10:37 PM
ngie committed rS348019: Allow the end-user to pass along arguments to cryptotest.py via….
Allow the end-user to pass along arguments to cryptotest.py via…
May 20 2019, 10:32 PM
ngie committed rS348017: Fix up KatCCMParser test usage.
Fix up KatCCMParser test usage
May 20 2019, 10:21 PM
ngie committed rS348015: Apply r346610 to `self.runSHA` to unbreak the test(s).
Apply r346610 to `self.runSHA` to unbreak the test(s)
May 20 2019, 10:03 PM
ngie committed rS348014: Add backwards compatibility method for python 2.x.
Add backwards compatibility method for python 2.x
May 20 2019, 9:55 PM
ngie added inline comments to D20124: Mention atf(7) in tests(7).
May 20 2019, 8:56 PM
ngie requested changes to D20124: Mention atf(7) in tests(7).
May 20 2019, 8:55 PM
ngie committed rS347997: MFhead@r347996.
MFhead@r347996
May 20 2019, 4:39 PM
ngie committed rS347996: Replace uses of `foo.(de|en)code('hex')` with `binascii.(un)?hexlify(foo)`.
Replace uses of `foo.(de|en)code('hex')` with `binascii.(un)?hexlify(foo)`
May 20 2019, 4:38 PM
ngie committed rS347994: Replace more instances of .decode('hex') with binascii.unhexlify for py3….
Replace more instances of .decode('hex') with binascii.unhexlify for py3…
May 20 2019, 4:23 PM
ngie committed rS347993: Fix some improper binascii conversions.
Fix some improper binascii conversions
May 20 2019, 4:16 PM
ngie committed rS347987: MFhead@r347986.
MFhead@r347986
May 20 2019, 8:02 AM

May 15 2019

ngie committed rS347611: MFC r347075:.
MFC r347075:
May 15 2019, 7:51 AM
ngie committed rS347610: MFC r320009,r347075:.
MFC r320009,r347075:
May 15 2019, 7:51 AM
ngie committed rS347608: Include bsd.linker.mk in bsd.{lib,prog}.mk to access LINKER_* vars.
Include bsd.linker.mk in bsd.{lib,prog}.mk to access LINKER_* vars
May 15 2019, 4:34 AM
ngie committed rS347607: Verify that the linker supports the DWARF v4 spec.
Verify that the linker supports the DWARF v4 spec
May 15 2019, 4:24 AM

May 14 2019

ngie committed rS347599: MFhead@r347598.
MFhead@r347598
May 14 2019, 11:29 PM
ngie committed rS347598: Force MK_COVERAGE{,_SUPPORT} off on arm/armv6.
Force MK_COVERAGE{,_SUPPORT} off on arm/armv6
May 14 2019, 11:28 PM
ngie committed rS347560: MFhead@r347559.
MFhead@r347559
May 14 2019, 3:52 AM

May 10 2019

ngie committed rS347421: MFhead@r347417.
MFhead@r347417
May 10 2019, 1:24 AM
ngie committed rS347417: Refactor tests/sys/opencrypto/runtests.
Refactor tests/sys/opencrypto/runtests
May 10 2019, 12:03 AM

May 9 2019

ngie committed rS347400: MFhead@r347399.
MFhead@r347399
May 9 2019, 5:47 PM
ngie committed rS347399: Document COMPILER_FEATURES:Mcoverage in the comment header.
Document COMPILER_FEATURES:Mcoverage in the comment header
May 9 2019, 5:35 PM
ngie committed rS347398: Remove unnecessary duplicate MK_COVERAGE{,_SUPPORT}=no setting for C++11-only.
Remove unnecessary duplicate MK_COVERAGE{,_SUPPORT}=no setting for C++11-only
May 9 2019, 5:20 PM
ngie committed rS347397: MFC r346578:.
MFC r346578:
May 9 2019, 5:03 PM
ngie committed rS347396: MFC r346578:.
MFC r346578:
May 9 2019, 5:02 PM

May 8 2019

ngie accepted D20186: Add simple regression tests for tree(3)..

seemslegit

May 8 2019, 11:31 PM
ngie created Image Macro "seemslegit".
May 8 2019, 11:31 PM
ngie created Image Macro "byefelicia".
May 8 2019, 11:30 PM

May 7 2019

ngie added a comment to D20092: [new port] devel/linux-ltp: Linux Test Project (openSUSE Leap 42.3).
In D20092#433990, @ngie wrote:

This looks good to me (not a ports committer though, so just reviewing the change).
As a volunteer/co-maintainer on the LTP project, your suggestions make sense.
The only thing that I would do is install LTP to /compat/linux/opt, if at all possible. If not, we can come up with a better way to build/relocate LTP (I wrote the current build system about a decade ago for the project).

But it does install to /compat/linux/opt - except for the documentation (where it follows Linux conventions) and two binaries - not sure what's going on with those two.

May 7 2019, 3:48 PM
ngie accepted D19908: Provide accounting of user-wired pages..

The user space and test changes all look great. I’ll defer to someone else (like kib@) about the VM changes.

May 7 2019, 12:49 AM

May 4 2019

ngie committed rS347076: MFhead@r347075.
MFhead@r347075
May 4 2019, 2:11 AM
ngie committed rS347075: Fix `clang -Wcast-qual` issues.
Fix `clang -Wcast-qual` issues
May 4 2019, 2:09 AM
ngie edited P257 Masterwork From Distant Lands.
May 4 2019, 1:50 AM

May 3 2019

ngie added a comment to D20005: Fix sys.kern.coredump_phnum_test.coredump_phnum on i386.
In D20005#430003, @cem wrote:

It's not a static number, AFAICT, depending on how the kernel maps libraries or waves hands does stuff with virtual memory. Hence the sloppy 66xxx match. I think @lwhsu's proposal is something like atf_check [ "$num" -gt 65535 ], which verifies that the number exceeds the lower 16 bit limit (which is the coredump feature the regression test is attempting to verify).

May 3 2019, 10:23 PM
ngie accepted D20092: [new port] devel/linux-ltp: Linux Test Project (openSUSE Leap 42.3).

This looks good to me (not a ports committer though, so just reviewing the change).

May 3 2019, 9:20 PM

May 2 2019

ngie edited P256 Masterwork From Distant Lands.
May 2 2019, 3:13 PM
ngie committed rS347018: Guard against cases where GCNOS would be empty, resulting in failed builds.
Guard against cases where GCNOS would be empty, resulting in failed builds
May 2 2019, 2:40 PM
ngie committed rS347014: Don't try building coverage binaries with crunchgen.
Don't try building coverage binaries with crunchgen
May 2 2019, 4:16 AM
ngie committed rS347011: Compile lib/libclang_rt/profile if MK_CLANG == no.
Compile lib/libclang_rt/profile if MK_CLANG == no
May 2 2019, 2:08 AM

May 1 2019

ngie added a comment to D20124: Mention atf(7) in tests(7).
In D20124#433272, @ngie wrote:

I’m a bit ambivalent about this change, because it’s up on the wiki in greater detail: https://wiki.freebsd.org/TestingFreeBSD . kyua(1) references atf(7) IIRC, but it’s a level of indirection.
My point is, I’d personally prefer not mentioning just ATF in tests(7), but I want it to be enough of a living document where multiple sources can contribute to it, but mentioning the wiki page doesn’t seem like something that’s generally done from a manpage because the location and content in a wiki page can change.

May 1 2019, 9:48 PM
ngie added a comment to D20124: Mention atf(7) in tests(7).

I’m a bit ambivalent about this change, because it’s up on the wiki in greater detail: https://wiki.freebsd.org/TestingFreeBSD . kyua(1) references atf(7) IIRC, but it’s a level of indirection.

May 1 2019, 8:50 PM
ngie accepted D20125: Add MLINKS to atf-c.3.

Macro thankyou_dog:

May 1 2019, 1:20 PM

Apr 30 2019

ngie accepted D20111: directory.3: add a STANDARDS section.

lgtm

Apr 30 2019, 6:31 PM

Apr 29 2019

ngie committed rS346936: MFC r345351:.
MFC r345351:
Apr 29 2019, 11:07 PM
ngie committed rS346927: MFC r345351:.
MFC r345351:
Apr 29 2019, 8:53 PM
ngie committed rS346926: MFhead@r346925.
MFhead@r346925
Apr 29 2019, 8:22 PM