Page MenuHomeFreeBSD

ngie (Enji Cooper)
User

Projects

User Details

User Since
Aug 2 2014, 8:08 AM (325 w, 6 d)

Recent Activity

Wed, Oct 28

ngie added a comment to D26932: jail(3lua): Add some basic tests.

I'll look through the rest of the review later.

Wed, Oct 28, 5:12 PM

Mon, Oct 26

ngie requested changes to D26930: atf.tests.mk: add bits needed for adding tests that use atf-lua.

I should have marked this as "Request Changes" in the last message :/...

Mon, Oct 26, 3:50 PM
ngie added a comment to D26930: atf.tests.mk: add bits needed for adding tests that use atf-lua.

Wait... Lua? what Lua tests are you planning to add (for the bootloader)?

Mon, Oct 26, 3:50 PM

Tue, Oct 20

ngie accepted D26751: Significantly reduce compile time for googletest internal tests.

No blocking concerns.

Tue, Oct 20, 7:02 PM

Mon, Oct 19

ngie added a comment to D26751: Significantly reduce compile time for googletest internal tests.
In D26751#599033, @dim wrote:

Might as well go full -O0. :)

Running the tests at -O2 in QEMU amd64 took:
44.52 real 27.28 user 13.96 sys
Changing it to -O1 makes it
91.80 real 73.32 user 14.28 sys
and -O0 results in
109.46 real 90.08 user 14.38 sys

So we might as well use -O0 since it doesn't seem to make much of a run time difference but has a big impact on compile time :)

Mon, Oct 19, 10:53 PM

Thu, Oct 15

ngie added inline comments to D26067: Don't build googletest internal tests by default.
Thu, Oct 15, 5:52 AM
ngie requested changes to D26067: Don't build googletest internal tests by default.
Thu, Oct 15, 5:49 AM
ngie accepted D26760: Enable SUBDIR_PARALLEL for lib/googletest.
Thu, Oct 15, 5:42 AM
ngie accepted D26789: [tests] Fix itimer test warning-errors on gcc-6.4.

This LGTM.

Thu, Oct 15, 5:41 AM

Tue, Oct 6

ngie accepted D26695: Do not allow to use O_BENEATH as an oracle..
Tue, Oct 6, 7:16 PM

Sun, Oct 4

ngie added a comment to D26632: Check for built-in tmpfs module.

LGTM!

Sun, Oct 4, 10:00 PM

Thu, Oct 1

ngie closed D20330: Eliminate duplicate `afterinstallconfigs` target.
Thu, Oct 1, 4:37 PM
ngie committed rS366327: Eliminate duplicate `afterinstallconfigs` target.
Eliminate duplicate `afterinstallconfigs` target
Thu, Oct 1, 4:37 PM
ngie added inline comments to D26616: zgrep: fix exit status with multiple files.
Thu, Oct 1, 4:24 PM
ngie accepted D26616: zgrep: fix exit status with multiple files.

Macro shipit:

Thu, Oct 1, 4:23 PM

Wed, Sep 30

ngie added inline comments to D26473: Significantly speed up libthr/mutex_test and make more reliable.
Wed, Sep 30, 9:12 PM

Sep 28 2020

ngie added a comment to D26549: Enabling SO_LINGER to the so_reuseport_lb_test regression tests.

The change is good from a technical standpoint, but some of the documentation could be a bit more polished.

Sep 28 2020, 3:05 PM

Sep 18 2020

ngie added a comment to D26473: Significantly speed up libthr/mutex_test and make more reliable.

Please add __FreeBSD__ around any test modifications; it makes it easier for folks to upstream the changes as we're 3 years out of date.

Sep 18 2020, 4:23 PM
ngie added inline comments to D26445: fix setitimer test for returned it_value.
Sep 18 2020, 6:40 AM

Sep 13 2020

ngie accepted D26397: build: provide a default WARNS for src builds.

surewhynot

Sep 13 2020, 11:51 PM

Sep 7 2020

ngie added a comment to D26278: Various fixes to the load() function..

Macro lgtm:

Sep 7 2020, 4:30 PM
ngie added a comment to D26281: Pass a valid mode with O_CREATE to open(2)..

Macro lgtm:

Sep 7 2020, 4:29 PM
ngie added a comment to D26333: Make zpool on GELI work again..

Macro stlgtm:

Sep 7 2020, 4:28 PM

Aug 20 2020

ngie requested changes to D26067: Don't build googletest internal tests by default.

Please use WITH_GOOGLETEST_INTERNAL_TESTS or something similar and default to on, since it seems to be limited to that case.

Aug 20 2020, 4:47 PM

Aug 10 2020

ngie added a comment to D25533: clear_tmp: Remove all chflags bits in /tmp before the clear proccess is initiated.

This shouldn't be committed to head.

Aug 10 2020, 4:41 PM

Aug 5 2020

ngie updated subscribers of D25935: skip sbin/route jail test if jail not installed.

I was a bit surprised to learn that this code relies on the jq utility from ports, by the way:

$ grep -r jq sbin/route/tests/
sbin/route/tests/utils.subr:    gateway=$(echo $result | jq -r ${query}.gateway)
sbin/route/tests/basic.sh:      atf_set require.progs jq
sbin/route/tests/basic.sh:      atf_set require.progs jq

I wish we had a tool capable of ingesting json in base :/...

Aug 5 2020, 6:01 PM

Jul 31 2020

ngie requested changes to D25896: Make capsicum test cases fine-grained.

NAK. I need to add Googletest support to kyua. Now that kyua has been forked, this is straightforward.

Jul 31 2020, 6:59 AM

Jul 25 2020

ngie committed rS363530: MFhead@r363529.
MFhead@r363529
Jul 25 2020, 5:27 PM
ngie committed rS363529: MFhead@r363528.
MFhead@r363528
Jul 25 2020, 4:35 PM

Jul 23 2020

ngie added inline comments to D25431: Add a few atf tests for sendfile, with and without I/O errors..
Jul 23 2020, 1:01 AM
ngie added a comment to D25431: Add a few atf tests for sendfile, with and without I/O errors..

Curious... is there a reason why this was added in addition to lib/libc/tests/sys/sendfile_test.c?

Jul 23 2020, 12:57 AM

Jul 21 2020

ngie added a comment to D25682: tests/sys/opencrypto: use python3.

This should work, for sure.

Jul 21 2020, 11:26 PM

Jul 12 2020

ngie committed rS363132: Don't leave `path` behind when executing `:chflags_success`.
Don't leave `path` behind when executing `:chflags_success`
Jul 12 2020, 5:17 PM
ngie closed D25561: Don't leave `path` behind when executing `:chflags_success`.
Jul 12 2020, 5:17 PM
ngie added inline comments to D25561: Don't leave `path` behind when executing `:chflags_success`.
Jul 12 2020, 5:11 PM

Jul 11 2020

ngie updated the diff for D25561: Don't leave `path` behind when executing `:chflags_success`.

Use UF_OFFLINE instead of SF_IMMUTABLE, as recommended by @asomers.

Jul 11 2020, 2:56 PM
ngie updated the summary of D25561: Don't leave `path` behind when executing `:chflags_success`.
Jul 11 2020, 2:55 PM

Jul 10 2020

ngie added a comment to D25561: Don't leave `path` behind when executing `:chflags_success`.

Instead of clearing flags, which might not be possible in a higher securelevel, how about just using UF_OFFLINE instead of SF_IMMUTABLE? That's what some of the other test cases do. The test doesn't care what the flag actually is; it just needs to be something.

Jul 10 2020, 11:31 PM

Jul 4 2020

ngie added a reviewer for D25561: Don't leave `path` behind when executing `:chflags_success`: tests.
Jul 4 2020, 5:00 PM
ngie requested review of D25561: Don't leave `path` behind when executing `:chflags_success`.
Jul 4 2020, 4:59 PM

Jun 24 2020

ngie closed D25302: Add `kern.features.witness`.
Jun 24 2020, 6:51 PM
ngie committed rS362591: Add `kern.features.witness`.
Add `kern.features.witness`
Jun 24 2020, 6:51 PM
ngie updated the test plan for D25302: Add `kern.features.witness`.
Jun 24 2020, 6:49 PM
ngie accepted D25419: Enable long double tests on RISC-V.

LGTM!

Jun 24 2020, 3:32 AM
ngie added a comment to D24613: skip bectl jail test if jail not installed.

LGTM

Jun 24 2020, 3:31 AM

Jun 23 2020

ngie updated the diff for D25302: Add `kern.features.witness`.

The FEATURE call should be moved down.

Jun 23 2020, 3:27 AM
ngie requested review of D25302: Add `kern.features.witness`.
Jun 23 2020, 3:22 AM

Jun 20 2020

ngie added a comment to D25339: Update tests(7) as it was imported to base in r359260.

I appreciate this update.

Jun 20 2020, 2:01 AM

Jun 16 2020

ngie added inline comments to D24830: sendfile_test: Finish to implement linear probing to find a free port .
Jun 16 2020, 10:08 PM
ngie updated the summary of D25302: Add `kern.features.witness`.
Jun 16 2020, 9:18 PM
ngie retitled D25302: Add `kern.features.witness` from Add kern.features.witness to Add `kern.features.witness`.
Jun 16 2020, 9:18 PM
ngie updated the test plan for D25302: Add `kern.features.witness`.
Jun 16 2020, 9:17 PM

May 14 2020

ngie accepted D24844: libc/resolv: attempt to fix the test under WARNS=6.

Thank you!

May 14 2020, 8:22 PM
ngie created Image Macro "surewhynot".
May 14 2020, 8:21 PM

May 13 2020

ngie requested changes to D24830: sendfile_test: Finish to implement linear probing to find a free port .
May 13 2020, 10:23 PM

Apr 18 2020

ngie requested changes to D24395: pw: add new configuration keyword logmode in pw.conf.

The change looks good functionally. My comments are mostly about the documentation/tests.

Apr 18 2020, 12:05 AM

Apr 12 2020

ngie committed rS359817: Merge ^/vendor/googletest/dist@r345048.
Merge ^/vendor/googletest/dist@r345048
Apr 12 2020, 3:11 AM
ngie committed rS359816: MFhead@r359814.
MFhead@r359814
Apr 12 2020, 2:50 AM

Apr 10 2020

ngie added a comment to D24306: Always install backward compatibility timezones, as they are installed on all major Linux distributions as well as NetBSD and OpenBSD..

does not mean we should remove these links.

We already removed them. In 1994. What you're doing is adding them back, which is not a harmless change.

Plus, this is not only affecting PostgreSQL

Do you have a non-hypothetical example of this?

Apr 10 2020, 7:05 PM

Apr 9 2020

ngie committed rS359734: Backport a -Wsign-compare fix for `ArrayAsVector`.
Backport a -Wsign-compare fix for `ArrayAsVector`
Apr 9 2020, 2:01 AM
ngie committed rS359733: Copy ^/vendor/google/googletest/dist to ^/vendor/google/googletest/1.10.0.
Copy ^/vendor/google/googletest/dist to ^/vendor/google/googletest/1.10.0
Apr 9 2020, 1:56 AM
ngie committed rS359732: Import GoogleTest 1.10.0.
Import GoogleTest 1.10.0
Apr 9 2020, 1:56 AM

Apr 6 2020

ngie accepted D24306: Always install backward compatibility timezones, as they are installed on all major Linux distributions as well as NetBSD and OpenBSD..

Macro goatforit:

Apr 6 2020, 1:02 AM

Apr 2 2020

ngie added inline comments to D24257: mac_bsdextended: ATFify the tests.
Apr 2 2020, 5:11 AM
ngie added a comment to D21259: Upgrade devel/distcc to 3.3.3 and add pump support.
In D21259#473832, @ngie wrote:

@fernape: could you please take this revision so I can sign off on the change?

Yes.

I would like to hear comments from @mat and others about the change though.

Apr 2 2020, 5:00 AM
ngie added a comment to D24257: mac_bsdextended: ATFify the tests.

This is a precondition to fixing bug 244229

Apr 2 2020, 4:59 AM

Mar 31 2020

ngie added a comment to D24224: Create EX_*.3 manual page links to sysexits.3.
In D24224#533296, @0mp wrote:

After a quick chat with some other developers it looks like we would actually want to deprecate sysexits.

Mar 31 2020, 6:55 PM

Mar 29 2020

ngie committed rS359430: MFhead@r359429.
MFhead@r359429
Mar 29 2020, 11:33 PM
ngie added a comment to D24218: security/py-pylibacl: Update to 0.5.4.
  • Please confirm portlint and poudriere (Py 2.x and Py 3.x) pass (ive added bullet points for these in TEST PLAN section)
Mar 29 2020, 11:28 PM
ngie updated the test plan for D24218: security/py-pylibacl: Update to 0.5.4.
Mar 29 2020, 11:05 PM
ngie updated the diff for D24218: security/py-pylibacl: Update to 0.5.4.

Update generated patch

Mar 29 2020, 11:03 PM
ngie added a reviewer for D24218: security/py-pylibacl: Update to 0.5.4: koobs.
Mar 29 2020, 10:15 PM
ngie created D24218: security/py-pylibacl: Update to 0.5.4.
Mar 29 2020, 10:14 PM
ngie committed rS359417: Revert r359385-r359387.
Revert r359385-r359387
Mar 29 2020, 2:40 AM

Mar 28 2020

ngie committed rS359387: The .PATH throbbing I added in r359385 is no longer required.
The .PATH throbbing I added in r359385 is no longer required
Mar 28 2020, 1:16 AM
ngie committed rS359386: Follow up to r359385.
Follow up to r359385
Mar 28 2020, 1:15 AM
ngie committed rS359385: Check in the generated copies of the manpages.
Check in the generated copies of the manpages
Mar 28 2020, 1:08 AM
ngie committed rS359384: MFhead@r359383.
MFhead@r359383
Mar 28 2020, 12:42 AM
ngie committed rS359383: MFhead@r359382.
MFhead@r359382
Mar 28 2020, 12:39 AM

Mar 27 2020

ngie committed rS359350: MFhead@r359345.
MFhead@r359345
Mar 27 2020, 3:32 AM

Mar 26 2020

ngie committed rS359345: MFhead@r359342.
MFhead@r359342
Mar 26 2020, 10:25 PM

Mar 12 2020

ngie edited P374 Masterwork From Distant Lands.
Mar 12 2020, 9:45 PM
ngie edited P373 Masterwork From Distant Lands.
Mar 12 2020, 9:45 PM
ngie committed rS358915: Open branch for importing googletest 1.10.0.
Open branch for importing googletest 1.10.0
Mar 12 2020, 4:42 PM
ngie committed rS358912: Remove /usr/share/snmp/defs/tc.def with delete-old if MK_BSNMP == no.
Remove /usr/share/snmp/defs/tc.def with delete-old if MK_BSNMP == no
Mar 12 2020, 4:06 PM

Feb 26 2020

ngie added inline comments to D23783: lib/libkvm: add kvm_read test.
Feb 26 2020, 4:08 AM · tests, PowerPC

Feb 24 2020

ngie added a comment to D23783: lib/libkvm: add kvm_read test.
In D23783#523422, @ngie wrote:

One thing that isn't clear is why this sanity check is needed. Is this being specifically for platform integration issue with PowerPC64, or is there another better reason for why this needs to be done given the API? If for the latter reason and the item is well-documented, please add it. If not, this doesn't seem to serve much value and might be better implemented as a platform-specific regression test.

Please test this on amd64 as well as a sanity check, second.

Feb 24 2020, 5:01 PM · tests, PowerPC
ngie requested changes to D23783: lib/libkvm: add kvm_read test.

One thing that isn't clear is why this sanity check is needed. Is this being specifically for platform integration issue with PowerPC64, or is there another better reason for why this needs to be done given the API? If for the latter reason and the item is well-documented, please add it. If not, this doesn't seem to serve much value and might be better implemented as a platform-specific regression test.

Feb 24 2020, 4:49 PM · tests, PowerPC

Nov 18 2019

ngie accepted D22427: bsnmp: Fix operator precedence in error check in table_check_response.

Macro lgtm:

Nov 18 2019, 5:54 PM

Nov 14 2019

ngie committed rP517602: Upgrade devel/py-mock from 2.0.0 to 3.0.5 and fix "make test" target.
Upgrade devel/py-mock from 2.0.0 to 3.0.5 and fix "make test" target
Nov 14 2019, 5:12 PM
ngie closed D21654: Upgrade devel/py-mock from 2.0.0 to 3.0.5 and fix "make test" target.
Nov 14 2019, 5:12 PM

Nov 7 2019

ngie added a comment to D22272: Build tests-dbg.txz distfile.
In D22272#486919, @gjb wrote:

Has it been confirmed that the tests-dbg.txz file in fact contains files? I removed it from the list of EXTRA_DISTRIBUTIONS in r278486 because it resulted in an archive that did not have any content.

Nov 7 2019, 5:11 PM
ngie accepted D22272: Build tests-dbg.txz distfile.

The changes are great!

Nov 7 2019, 5:10 PM

Nov 5 2019

ngie added inline comments to D21654: Upgrade devel/py-mock from 2.0.0 to 3.0.5 and fix "make test" target.
Nov 5 2019, 6:37 PM
ngie updated the diff for D21654: Upgrade devel/py-mock from 2.0.0 to 3.0.5 and fix "make test" target.

Remove unnecessary GitHub boilerplate noted by @bdrewery and @Vladimir.Chukharev_gmail.com .

Nov 5 2019, 6:37 PM
ngie added inline comments to D21654: Upgrade devel/py-mock from 2.0.0 to 3.0.5 and fix "make test" target.
Nov 5 2019, 5:53 PM
ngie updated the diff for D21654: Upgrade devel/py-mock from 2.0.0 to 3.0.5 and fix "make test" target.

Oh wait... GitHub was required because the release tarball doesn't contain the tests.

Nov 5 2019, 5:50 PM
ngie updated the diff for D21654: Upgrade devel/py-mock from 2.0.0 to 3.0.5 and fix "make test" target.

Use CHEESESHOP again.

Nov 5 2019, 5:47 PM
ngie added a comment to D21654: Upgrade devel/py-mock from 2.0.0 to 3.0.5 and fix "make test" target.
In D21654#482501, @ngie wrote:

The poudriere test completeness is unclear to me. It may seem like a big ask but I'm sure you understand the bound version dependency problem between python ports. I think you did run it but your paste was cut off or something. Just confirm you ran as Ben requested and I'll +1 this.

Nov 5 2019, 5:44 PM
ngie committed rS354361: Remove picobsd(8) via `make delete-old`.
Remove picobsd(8) via `make delete-old`
Nov 5 2019, 5:33 PM