Page MenuHomeFreeBSD

ngie (Enji Cooper)
User

Projects

User Details

User Since
Aug 2 2014, 8:08 AM (254 w, 2 d)

Recent Activity

Mon, May 27

ngie updated subscribers of D20344: Add deprecation warnings for weaker algorithms to geli(4)..

A change related to this broke CI (example):

...
Fail: incorrect exit status: 1, expected: 0
stdout:
Mon, May 27, 4:41 AM
ngie updated subscribers of D19298: AESNI version of CCM+CBC-MAC.
  1. This broke the build with i386:
11:40:34 --- all_subdir_aesni ---
11:40:34 /workspace/src/sys/crypto/aesni/aesni_ccm.c: In function 'xor_and_encrypt':
11:40:34 /workspace/src/sys/crypto/aesni/aesni_ccm.c:61:18: error: incompatible types when initializing type '__m128 {aka __vector(4) float}' using type '__m128i {aka __vector(2) long long int}'
11:40:34   __m128 retval = _mm_xor_si128(a, b);
11:40:34                   ^~~~~~~~~~~~~
11:40:34 /workspace/src/sys/crypto/aesni/aesni_ccm.c:63:21: error: incompatible type for argument 3 of 'aesni_enc'
11:40:34   retval = AESNI_ENC(retval, k, nr);
11:40:34                      ^
11:40:34 /workspace/src/sys/crypto/aesni/aesni_ccm.c:47:64: note: in definition of macro 'AESNI_ENC'
11:40:34  #define AESNI_ENC(d, k, nr) aesni_enc(nr-1, (const __m128i*)k, d)
11:40:34                                                                 ^
11:40:34 In file included from /workspace/src/sys/crypto/aesni/aesni_ccm.c:46:0:
11:40:34 /workspace/src/sys/crypto/aesni/aesencdec.h:115:1: note: expected '__m128i {aka const __vector(2) long long int}' but argument is of type '__m128 {aka __vector(4) float}'
11:40:34  aesni_enc(int rounds, const __m128i *keysched, const __m128i from)
11:40:34  ^~~~~~~~~
11:40:34 /workspace/src/sys/crypto/aesni/aesni_ccm.c:64:9: error: incompatible types when returning type '__m128 {aka __vector(4) float}' but '__m128i {aka __vector(2) long long int}' was expected
11:40:34   return (retval);
11:40:34          ^
11:40:34 /workspace/src/sys/crypto/aesni/aesni_ccm.c:65:1: error: control reaches end of non-void function [-Werror=return-type]
11:40:34  }
11:40:34  ^
  1. Why didn't someone from secteam sign off on this change (CC: secteam)?
Mon, May 27, 12:19 AM

Thu, May 23

ngie committed rS348142: Ensure that coverage-capable linkers only include lld right now.
Ensure that coverage-capable linkers only include lld right now
Thu, May 23, 1:48 AM
ngie committed rS348140: MFC r346431,r347417,r348019:.
MFC r346431,r347417,r348019:
Thu, May 23, 1:25 AM
ngie committed rS348139: Regenerate src.conf(5) after r348138.
Regenerate src.conf(5) after r348138
Thu, May 23, 1:13 AM
ngie committed rS348138: MFC r345203,r345205,r345353,r345645,r345708,r345709,r345735,r345770,r346081….
MFC r345203,r345205,r345353,r345645,r345708,r345709,r345735,r345770,r346081…
Thu, May 23, 1:09 AM
ngie committed rS348137: Revert r348136.
Revert r348136
Thu, May 23, 12:59 AM
ngie committed rS348136: MFC r345203,r345205,r345353,r345645,r345708,r345709,r345735,r345770,r346574….
MFC r345203,r345205,r345353,r345645,r345708,r345709,r345735,r345770,r346574…
Thu, May 23, 12:56 AM

Tue, May 21

ngie edited P259 Masterwork From Distant Lands.
Tue, May 21, 5:05 AM
ngie created D20330: Eliminate duplicate `afterinstallconfigs` target.
Tue, May 21, 4:52 AM
ngie committed rS348048: MFhead@r348047.
MFhead@r348047
Tue, May 21, 4:42 AM
ngie committed rS348047: Add my name to the copyright.
Add my name to the copyright
Tue, May 21, 4:41 AM
ngie committed rS348045: Follow up to r348042: cast `aad` to a byte array.
Follow up to r348042: cast `aad` to a byte array
Tue, May 21, 4:41 AM
ngie committed rS348046: MFhead@r348045.
MFhead@r348045
Tue, May 21, 4:41 AM
ngie committed rS348044: Diff reduce with ^/head.
Diff reduce with ^/head
Tue, May 21, 4:41 AM
ngie committed rS348042: Fix encoding issues with python 3.
Fix encoding issues with python 3
Tue, May 21, 4:41 AM
ngie committed rS348043: MFhead@r348042.
MFhead@r348042
Tue, May 21, 4:41 AM
ngie committed rS348041: Leverage `str_to_ascii(..)` in `_findop(..)` when encoding `fop.name`.
Leverage `str_to_ascii(..)` in `_findop(..)` when encoding `fop.name`
Tue, May 21, 3:06 AM
ngie committed rS348039: Remove spurious newline.
Remove spurious newline
Tue, May 21, 2:49 AM
ngie committed rS348038: MFhead@r348037.
MFhead@r348037
Tue, May 21, 2:46 AM
ngie committed rS348037: Rename Crypto._to_bytes to Crypto.str_to_ascii and push it into the module….
Rename Crypto._to_bytes to Crypto.str_to_ascii and push it into the module…
Tue, May 21, 2:44 AM
ngie committed rS348032: Fix `KAT(CCM)?Parser` file descriptor leaks.
Fix `KAT(CCM)?Parser` file descriptor leaks
Tue, May 21, 2:30 AM
ngie committed rS348031: Squash deprecation warning related to array.array(..).tostring().
Squash deprecation warning related to array.array(..).tostring()
Tue, May 21, 2:14 AM
ngie committed rS348030: Fix remaining encoding issues with python 3.
Fix remaining encoding issues with python 3
Tue, May 21, 2:02 AM
ngie committed rS348029: MFhead@r348028.
MFhead@r348028
Tue, May 21, 1:56 AM
ngie committed rS348025: Unbreak the build when `ELF_VERBOSE` is defined after r348005.
Unbreak the build when `ELF_VERBOSE` is defined after r348005
Tue, May 21, 12:47 AM
ngie committed rS348024: Followup to r347996.
Followup to r347996
Tue, May 21, 12:30 AM
ngie committed rS348023: MFhead@r348022.
MFhead@r348022
Tue, May 21, 12:08 AM

Mon, May 20

ngie committed rS348021: Don't raise StopIteration when complete; a bare return suffices.
Don't raise StopIteration when complete; a bare return suffices
Mon, May 20, 10:37 PM
ngie committed rS348019: Allow the end-user to pass along arguments to cryptotest.py via….
Allow the end-user to pass along arguments to cryptotest.py via…
Mon, May 20, 10:32 PM
ngie committed rS348017: Fix up KatCCMParser test usage.
Fix up KatCCMParser test usage
Mon, May 20, 10:21 PM
ngie committed rS348015: Apply r346610 to `self.runSHA` to unbreak the test(s).
Apply r346610 to `self.runSHA` to unbreak the test(s)
Mon, May 20, 10:03 PM
ngie committed rS348014: Add backwards compatibility method for python 2.x.
Add backwards compatibility method for python 2.x
Mon, May 20, 9:55 PM
ngie added inline comments to D20124: Mention atf(7) in tests(7).
Mon, May 20, 8:56 PM
ngie requested changes to D20124: Mention atf(7) in tests(7).
Mon, May 20, 8:55 PM
ngie committed rS347997: MFhead@r347996.
MFhead@r347996
Mon, May 20, 4:39 PM
ngie committed rS347996: Replace uses of `foo.(de|en)code('hex')` with `binascii.(un)?hexlify(foo)`.
Replace uses of `foo.(de|en)code('hex')` with `binascii.(un)?hexlify(foo)`
Mon, May 20, 4:38 PM
ngie committed rS347994: Replace more instances of .decode('hex') with binascii.unhexlify for py3….
Replace more instances of .decode('hex') with binascii.unhexlify for py3…
Mon, May 20, 4:23 PM
ngie committed rS347993: Fix some improper binascii conversions.
Fix some improper binascii conversions
Mon, May 20, 4:16 PM
ngie committed rS347987: MFhead@r347986.
MFhead@r347986
Mon, May 20, 8:02 AM

May 15 2019

ngie committed rS347611: MFC r347075:.
MFC r347075:
May 15 2019, 7:51 AM
ngie committed rS347610: MFC r320009,r347075:.
MFC r320009,r347075:
May 15 2019, 7:51 AM
ngie committed rS347608: Include bsd.linker.mk in bsd.{lib,prog}.mk to access LINKER_* vars.
Include bsd.linker.mk in bsd.{lib,prog}.mk to access LINKER_* vars
May 15 2019, 4:34 AM
ngie committed rS347607: Verify that the linker supports the DWARF v4 spec.
Verify that the linker supports the DWARF v4 spec
May 15 2019, 4:24 AM

May 14 2019

ngie committed rS347599: MFhead@r347598.
MFhead@r347598
May 14 2019, 11:29 PM
ngie committed rS347598: Force MK_COVERAGE{,_SUPPORT} off on arm/armv6.
Force MK_COVERAGE{,_SUPPORT} off on arm/armv6
May 14 2019, 11:28 PM
ngie committed rS347560: MFhead@r347559.
MFhead@r347559
May 14 2019, 3:52 AM

May 10 2019

ngie committed rS347421: MFhead@r347417.
MFhead@r347417
May 10 2019, 1:24 AM
ngie committed rS347417: Refactor tests/sys/opencrypto/runtests.
Refactor tests/sys/opencrypto/runtests
May 10 2019, 12:03 AM

May 9 2019

ngie committed rS347400: MFhead@r347399.
MFhead@r347399
May 9 2019, 5:47 PM
ngie committed rS347399: Document COMPILER_FEATURES:Mcoverage in the comment header.
Document COMPILER_FEATURES:Mcoverage in the comment header
May 9 2019, 5:35 PM
ngie committed rS347398: Remove unnecessary duplicate MK_COVERAGE{,_SUPPORT}=no setting for C++11-only.
Remove unnecessary duplicate MK_COVERAGE{,_SUPPORT}=no setting for C++11-only
May 9 2019, 5:20 PM
ngie committed rS347397: MFC r346578:.
MFC r346578:
May 9 2019, 5:03 PM
ngie committed rS347396: MFC r346578:.
MFC r346578:
May 9 2019, 5:02 PM

May 8 2019

ngie accepted D20186: Add simple regression tests for tree(3)..

seemslegit

May 8 2019, 11:31 PM
ngie created Image Macro "seemslegit".
May 8 2019, 11:31 PM
ngie created Image Macro "byefelicia".
May 8 2019, 11:30 PM

May 7 2019

ngie added a comment to D20092: [new port] devel/linux-ltp: Linux Test Project (openSUSE Leap 42.3).
In D20092#433990, @ngie wrote:

This looks good to me (not a ports committer though, so just reviewing the change).
As a volunteer/co-maintainer on the LTP project, your suggestions make sense.
The only thing that I would do is install LTP to /compat/linux/opt, if at all possible. If not, we can come up with a better way to build/relocate LTP (I wrote the current build system about a decade ago for the project).

But it does install to /compat/linux/opt - except for the documentation (where it follows Linux conventions) and two binaries - not sure what's going on with those two.

May 7 2019, 3:48 PM
ngie accepted D19908: Provide accounting of user-wired pages..

The user space and test changes all look great. I’ll defer to someone else (like kib@) about the VM changes.

May 7 2019, 12:49 AM

May 4 2019

ngie committed rS347076: MFhead@r347075.
MFhead@r347075
May 4 2019, 2:11 AM
ngie committed rS347075: Fix `clang -Wcast-qual` issues.
Fix `clang -Wcast-qual` issues
May 4 2019, 2:09 AM
ngie edited P257 Masterwork From Distant Lands.
May 4 2019, 1:50 AM

May 3 2019

ngie added a comment to D20005: Fix sys.kern.coredump_phnum_test.coredump_phnum on i386.
In D20005#430003, @cem wrote:

It's not a static number, AFAICT, depending on how the kernel maps libraries or waves hands does stuff with virtual memory. Hence the sloppy 66xxx match. I think @lwhsu's proposal is something like atf_check [ "$num" -gt 65535 ], which verifies that the number exceeds the lower 16 bit limit (which is the coredump feature the regression test is attempting to verify).

May 3 2019, 10:23 PM
ngie accepted D20092: [new port] devel/linux-ltp: Linux Test Project (openSUSE Leap 42.3).

This looks good to me (not a ports committer though, so just reviewing the change).

May 3 2019, 9:20 PM

May 2 2019

ngie edited P256 Masterwork From Distant Lands.
May 2 2019, 3:13 PM
ngie committed rS347018: Guard against cases where GCNOS would be empty, resulting in failed builds.
Guard against cases where GCNOS would be empty, resulting in failed builds
May 2 2019, 2:40 PM
ngie committed rS347014: Don't try building coverage binaries with crunchgen.
Don't try building coverage binaries with crunchgen
May 2 2019, 4:16 AM
ngie committed rS347011: Compile lib/libclang_rt/profile if MK_CLANG == no.
Compile lib/libclang_rt/profile if MK_CLANG == no
May 2 2019, 2:08 AM

May 1 2019

ngie added a comment to D20124: Mention atf(7) in tests(7).
In D20124#433272, @ngie wrote:

I’m a bit ambivalent about this change, because it’s up on the wiki in greater detail: https://wiki.freebsd.org/TestingFreeBSD . kyua(1) references atf(7) IIRC, but it’s a level of indirection.
My point is, I’d personally prefer not mentioning just ATF in tests(7), but I want it to be enough of a living document where multiple sources can contribute to it, but mentioning the wiki page doesn’t seem like something that’s generally done from a manpage because the location and content in a wiki page can change.

May 1 2019, 9:48 PM
ngie added a comment to D20124: Mention atf(7) in tests(7).

I’m a bit ambivalent about this change, because it’s up on the wiki in greater detail: https://wiki.freebsd.org/TestingFreeBSD . kyua(1) references atf(7) IIRC, but it’s a level of indirection.

May 1 2019, 8:50 PM
ngie accepted D20125: Add MLINKS to atf-c.3.

Macro thankyou_dog:

May 1 2019, 1:20 PM

Apr 30 2019

ngie accepted D20111: directory.3: add a STANDARDS section.

lgtm

Apr 30 2019, 6:31 PM

Apr 29 2019

ngie committed rS346936: MFC r345351:.
MFC r345351:
Apr 29 2019, 11:07 PM
ngie committed rS346927: MFC r345351:.
MFC r345351:
Apr 29 2019, 8:53 PM
ngie committed rS346926: MFhead@r346925.
MFhead@r346925
Apr 29 2019, 8:22 PM
ngie committed rS346925: MFhead@r346924.
MFhead@r346924
Apr 29 2019, 8:19 PM
ngie committed rS346924: Pass `MK_COVERAGE_SUPPORT` from _libraries instead of libraries.
Pass `MK_COVERAGE_SUPPORT` from _libraries instead of libraries
Apr 29 2019, 8:18 PM
ngie resigned from D20092: [new port] devel/linux-ltp: Linux Test Project (openSUSE Leap 42.3).

I'm ok with the changes, but there are some kinks that should probably be worked out before committing this.

Apr 29 2019, 8:04 PM
ngie committed rS346920: MFC r346571,r346572:.
MFC r346571,r346572:
Apr 29 2019, 7:36 PM
ngie committed rS346919: MFC r345723:.
MFC r345723:
Apr 29 2019, 7:35 PM
ngie committed rS346918: MFC r346571,r346572:.
MFC r346571,r346572:
Apr 29 2019, 7:34 PM
ngie committed rS346917: MFC r345723:.
MFC r345723:
Apr 29 2019, 7:32 PM
ngie committed rS346912: MFC r346539:.
MFC r346539:
Apr 29 2019, 7:12 PM
ngie committed rS346911: MFC r346539:.
MFC r346539:
Apr 29 2019, 7:12 PM
ngie committed rS346909: MFC r346542:.
MFC r346542:
Apr 29 2019, 7:10 PM
ngie committed rS346904: Update/reformat maintainer entries that I am a part of.
Update/reformat maintainer entries that I am a part of
Apr 29 2019, 6:49 PM

Apr 28 2019

ngie accepted D20078: fsx: seed more randomly with the -S0 option.

thankyou_dog

Apr 28 2019, 5:24 PM
ngie created Image Macro "thankyou_dog".
Apr 28 2019, 5:24 PM
ngie requested changes to D20092: [new port] devel/linux-ltp: Linux Test Project (openSUSE Leap 42.3).

I don't think benchmarks is an appropriate category. LTP consists primarily of functional and crash tests.

Apr 28 2019, 5:11 PM
ngie accepted D20078: fsx: seed more randomly with the -S0 option.

This change is very reasonable.

Apr 28 2019, 5:09 PM
ngie committed rS346809: Fix "make universe" pathing by adding a missing tmp path component.
Fix "make universe" pathing by adding a missing tmp path component
Apr 28 2019, 9:41 AM
ngie committed rS346801: MFhead@r346800.
MFhead@r346800
Apr 28 2019, 2:27 AM
ngie committed rS346800: Handle installing the coverage libraries to the directory used by.
Handle installing the coverage libraries to the directory used by
Apr 28 2019, 2:24 AM

Apr 26 2019

ngie committed rS346738: Make --coverage work by building the coverage libraries for the toolchain prior….
Make --coverage work by building the coverage libraries for the toolchain prior…
Apr 26 2019, 11:29 AM
ngie committed rS346736: Revert -target -> -target= change from r346732.
Revert -target -> -target= change from r346732
Apr 26 2019, 9:06 AM
ngie committed rS346735: Fix another typo from r346732 (lib/clang_rt/profile -> lib/libclang_rt/profile).
Fix another typo from r346732 (lib/clang_rt/profile -> lib/libclang_rt/profile)
Apr 26 2019, 9:03 AM
ngie committed rS346734: Use CROSSENV when building `_coverage_libs` instead of just a part of CFLAGS.
Use CROSSENV when building `_coverage_libs` instead of just a part of CFLAGS
Apr 26 2019, 8:16 AM
ngie committed rS346733: Fix typo introduced in r346732 (.endif -> .endfor).
Fix typo introduced in r346732 (.endif -> .endfor)
Apr 26 2019, 8:03 AM
ngie committed rS346732: Retry building lib/libclang_rt/profile for buildworld.
Retry building lib/libclang_rt/profile for buildworld
Apr 26 2019, 7:43 AM
ngie committed rS346731: MFhead@r346730.
MFhead@r346730
Apr 26 2019, 6:59 AM