Page MenuHomeFreeBSD

ngie (Enji Cooper)
User

Projects

User Details

User Since
Aug 2 2014, 8:08 AM (304 w, 4 d)

Recent Activity

Thu, May 14

ngie accepted D24844: libc/resolv: attempt to fix the test under WARNS=6.

surewhynot

Thu, May 14, 8:22 PM
ngie created Image Macro "surewhynot".
Thu, May 14, 8:21 PM

Wed, May 13

ngie requested changes to D24830: sendfile_test: Finish to implement linear probing to find a free port .
Wed, May 13, 10:23 PM

Apr 18 2020

ngie requested changes to D24395: pw: add new configuration keyword logmode in pw.conf.

The change looks good functionally. My comments are mostly about the documentation/tests.

Apr 18 2020, 12:05 AM

Apr 12 2020

ngie committed rS359817: Merge ^/vendor/googletest/dist@r345048.
Merge ^/vendor/googletest/dist@r345048
Apr 12 2020, 3:11 AM
ngie committed rS359816: MFhead@r359814.
MFhead@r359814
Apr 12 2020, 2:50 AM

Apr 10 2020

ngie added a comment to D24306: Always install backward compatibility timezones, as they are installed on all major Linux distributions as well as NetBSD and OpenBSD..

does not mean we should remove these links.

We already removed them. In 1994. What you're doing is adding them back, which is not a harmless change.

Plus, this is not only affecting PostgreSQL

Do you have a non-hypothetical example of this?

Apr 10 2020, 7:05 PM

Apr 9 2020

ngie committed rS359734: Backport a -Wsign-compare fix for `ArrayAsVector`.
Backport a -Wsign-compare fix for `ArrayAsVector`
Apr 9 2020, 2:01 AM
ngie committed rS359733: Copy ^/vendor/google/googletest/dist to ^/vendor/google/googletest/1.10.0.
Copy ^/vendor/google/googletest/dist to ^/vendor/google/googletest/1.10.0
Apr 9 2020, 1:56 AM
ngie committed rS359732: Import GoogleTest 1.10.0.
Import GoogleTest 1.10.0
Apr 9 2020, 1:56 AM

Apr 6 2020

ngie accepted D24306: Always install backward compatibility timezones, as they are installed on all major Linux distributions as well as NetBSD and OpenBSD..

Macro goatforit:

Apr 6 2020, 1:02 AM

Apr 2 2020

ngie added inline comments to D24257: mac_bsdextended: ATFify the tests.
Apr 2 2020, 5:11 AM
ngie added a comment to D21259: Upgrade devel/distcc to 3.3.3 and add pump support.
In D21259#473832, @ngie wrote:

@fernape: could you please take this revision so I can sign off on the change?

Yes.

I would like to hear comments from @mat and others about the change though.

Apr 2 2020, 5:00 AM
ngie added a comment to D24257: mac_bsdextended: ATFify the tests.

This is a precondition to fixing bug 244229

Apr 2 2020, 4:59 AM

Mar 31 2020

ngie added a comment to D24224: Create EX_*.3 manual page links to sysexits.3.
In D24224#533296, @0mp wrote:

After a quick chat with some other developers it looks like we would actually want to deprecate sysexits.

Mar 31 2020, 6:55 PM

Mar 29 2020

ngie committed rS359430: MFhead@r359429.
MFhead@r359429
Mar 29 2020, 11:33 PM
ngie added a comment to D24218: security/py-pylibacl: Update to 0.5.4.
  • Please confirm portlint and poudriere (Py 2.x and Py 3.x) pass (ive added bullet points for these in TEST PLAN section)
Mar 29 2020, 11:28 PM
ngie updated the test plan for D24218: security/py-pylibacl: Update to 0.5.4.
Mar 29 2020, 11:05 PM
ngie updated the diff for D24218: security/py-pylibacl: Update to 0.5.4.

Update generated patch

Mar 29 2020, 11:03 PM
ngie added a reviewer for D24218: security/py-pylibacl: Update to 0.5.4: koobs.
Mar 29 2020, 10:15 PM
ngie created D24218: security/py-pylibacl: Update to 0.5.4.
Mar 29 2020, 10:14 PM
ngie committed rS359417: Revert r359385-r359387.
Revert r359385-r359387
Mar 29 2020, 2:40 AM

Mar 28 2020

ngie committed rS359387: The .PATH throbbing I added in r359385 is no longer required.
The .PATH throbbing I added in r359385 is no longer required
Mar 28 2020, 1:16 AM
ngie committed rS359386: Follow up to r359385.
Follow up to r359385
Mar 28 2020, 1:15 AM
ngie committed rS359385: Check in the generated copies of the manpages.
Check in the generated copies of the manpages
Mar 28 2020, 1:08 AM
ngie committed rS359384: MFhead@r359383.
MFhead@r359383
Mar 28 2020, 12:42 AM
ngie committed rS359383: MFhead@r359382.
MFhead@r359382
Mar 28 2020, 12:39 AM

Mar 27 2020

ngie committed rS359350: MFhead@r359345.
MFhead@r359345
Mar 27 2020, 3:32 AM

Mar 26 2020

ngie committed rS359345: MFhead@r359342.
MFhead@r359342
Mar 26 2020, 10:25 PM

Mar 12 2020

ngie edited P374 Masterwork From Distant Lands.
Mar 12 2020, 9:45 PM
ngie edited P373 Masterwork From Distant Lands.
Mar 12 2020, 9:45 PM
ngie committed rS358915: Open branch for importing googletest 1.10.0.
Open branch for importing googletest 1.10.0
Mar 12 2020, 4:42 PM
ngie committed rS358912: Remove /usr/share/snmp/defs/tc.def with delete-old if MK_BSNMP == no.
Remove /usr/share/snmp/defs/tc.def with delete-old if MK_BSNMP == no
Mar 12 2020, 4:06 PM

Feb 26 2020

ngie added inline comments to D23783: lib/libkvm: add kvm_read test.
Feb 26 2020, 4:08 AM · PowerPC

Feb 24 2020

ngie added a comment to D23783: lib/libkvm: add kvm_read test.
In D23783#523422, @ngie wrote:

One thing that isn't clear is why this sanity check is needed. Is this being specifically for platform integration issue with PowerPC64, or is there another better reason for why this needs to be done given the API? If for the latter reason and the item is well-documented, please add it. If not, this doesn't seem to serve much value and might be better implemented as a platform-specific regression test.

Please test this on amd64 as well as a sanity check, second.

Feb 24 2020, 5:01 PM · PowerPC
ngie requested changes to D23783: lib/libkvm: add kvm_read test.

One thing that isn't clear is why this sanity check is needed. Is this being specifically for platform integration issue with PowerPC64, or is there another better reason for why this needs to be done given the API? If for the latter reason and the item is well-documented, please add it. If not, this doesn't seem to serve much value and might be better implemented as a platform-specific regression test.

Feb 24 2020, 4:49 PM · PowerPC

Nov 18 2019

ngie accepted D22427: bsnmp: Fix operator precedence in error check in table_check_response.

Macro lgtm:

Nov 18 2019, 5:54 PM

Nov 14 2019

ngie committed rP517602: Upgrade devel/py-mock from 2.0.0 to 3.0.5 and fix "make test" target.
Upgrade devel/py-mock from 2.0.0 to 3.0.5 and fix "make test" target
Nov 14 2019, 5:12 PM
ngie closed D21654: Upgrade devel/py-mock from 2.0.0 to 3.0.5 and fix "make test" target.
Nov 14 2019, 5:12 PM

Nov 7 2019

ngie added a comment to D22272: Build tests-dbg.txz distfile.
In D22272#486919, @gjb wrote:

Has it been confirmed that the tests-dbg.txz file in fact contains files? I removed it from the list of EXTRA_DISTRIBUTIONS in r278486 because it resulted in an archive that did not have any content.

Nov 7 2019, 5:11 PM
ngie accepted D22272: Build tests-dbg.txz distfile.

The changes are great!

Nov 7 2019, 5:10 PM

Nov 5 2019

ngie added inline comments to D21654: Upgrade devel/py-mock from 2.0.0 to 3.0.5 and fix "make test" target.
Nov 5 2019, 6:37 PM
ngie updated the diff for D21654: Upgrade devel/py-mock from 2.0.0 to 3.0.5 and fix "make test" target.

Remove unnecessary GitHub boilerplate noted by @bdrewery and @Vladimir.Chukharev_gmail.com .

Nov 5 2019, 6:37 PM
ngie added inline comments to D21654: Upgrade devel/py-mock from 2.0.0 to 3.0.5 and fix "make test" target.
Nov 5 2019, 5:53 PM
ngie updated the diff for D21654: Upgrade devel/py-mock from 2.0.0 to 3.0.5 and fix "make test" target.

Oh wait... GitHub was required because the release tarball doesn't contain the tests.

Nov 5 2019, 5:50 PM
ngie updated the diff for D21654: Upgrade devel/py-mock from 2.0.0 to 3.0.5 and fix "make test" target.

Use CHEESESHOP again.

Nov 5 2019, 5:47 PM
ngie added a comment to D21654: Upgrade devel/py-mock from 2.0.0 to 3.0.5 and fix "make test" target.
In D21654#482501, @ngie wrote:

The poudriere test completeness is unclear to me. It may seem like a big ask but I'm sure you understand the bound version dependency problem between python ports. I think you did run it but your paste was cut off or something. Just confirm you ran as Ben requested and I'll +1 this.

Nov 5 2019, 5:44 PM
ngie committed rS354361: Remove picobsd(8) via `make delete-old`.
Remove picobsd(8) via `make delete-old`
Nov 5 2019, 5:33 PM

Oct 31 2019

ngie updated the diff for D21654: Upgrade devel/py-mock from 2.0.0 to 3.0.5 and fix "make test" target.

Use the PORTVERSION for GH_TAGNAME instead of a full hash

Oct 31 2019, 3:51 PM

Oct 18 2019

ngie added a comment to D21654: Upgrade devel/py-mock from 2.0.0 to 3.0.5 and fix "make test" target.

@bdrewery, @mat, @woodsb02: ping?

Oct 18 2019, 6:43 PM

Sep 28 2019

ngie updated the test plan for D21654: Upgrade devel/py-mock from 2.0.0 to 3.0.5 and fix "make test" target.
Sep 28 2019, 1:22 AM
ngie edited P323 Masterwork From Distant Lands.
Sep 28 2019, 1:19 AM

Sep 27 2019

ngie accepted D21820: Fix coredump_phnum_test when kern.compress_user_cores != 0.

Macro like:

Sep 27 2019, 10:02 PM

Sep 26 2019

ngie updated the test plan for D21654: Upgrade devel/py-mock from 2.0.0 to 3.0.5 and fix "make test" target.
Sep 26 2019, 11:50 PM

Sep 24 2019

ngie accepted D21776: Fix sys/kern/coredump_phnum_test in case of kern.compress_user_cores=1.

allow_sysctl_side_effects is set in the test already — LGTM!
Macro goforit:

Sep 24 2019, 4:08 PM

Sep 19 2019

ngie added a comment to D21259: Upgrade devel/distcc to 3.3.3 and add pump support.

@fernape: could you please take this revision so I can sign off on the change?

Sep 19 2019, 4:21 PM
ngie abandoned D19906: Add some simple regression tests for /sbin/rcorder.

Abandoning this revision.

Sep 19 2019, 4:20 PM
ngie added a reviewer for D20330: Eliminate duplicate `afterinstallconfigs` target: bapt.
Sep 19 2019, 4:19 PM
ngie added a comment to D20330: Eliminate duplicate `afterinstallconfigs` target.

Still an issue:

$ (cd ~/svn/freebsd/base/head/; svnversion; make -C lib/libc buildenv)
352519
make: "/home/ngie/svn/freebsd/base/head/lib/libc/net/Makefile.inc" line 130: warning: duplicate script for target "afterinstallconfig" ignored
make: "/home/ngie/svn/freebsd/base/head/lib/libc/gen/Makefile.inc" line 554: warning: using previous script for "afterinstallconfig" defined here
Entering world for amd64:amd64
Sep 19 2019, 4:18 PM
ngie abandoned D19997: MFC r324736:.
In D19997#468014, @mjg wrote:

So this is not in stable/11 and it probably is not important to get there. It is in 12.0 Can this be closed?

Sep 19 2019, 4:13 PM
ngie edited P313 Masterwork From Distant Lands.
Sep 19 2019, 4:47 AM
ngie edited P312 Masterwork From Distant Lands.
Sep 19 2019, 4:44 AM
ngie updated the diff for D21654: Upgrade devel/py-mock from 2.0.0 to 3.0.5 and fix "make test" target.

Restore the previous RUN_DEPENDS logic

Sep 19 2019, 4:27 AM

Sep 18 2019

ngie added a comment to D21654: Upgrade devel/py-mock from 2.0.0 to 3.0.5 and fix "make test" target.

Hi ngie,

Can you please complete build testing ("poudriere bulk -j 12amd64 -t devel/py-buildbot-www devel/py-oslotest ...") for the following ports which depend on this port?

As shown by https://www.freshports.org/devel/py-mock:

This port is required by:

for Build

        devel/py-buildbot-www
        devel/py-oslotest
        graphics/qgis
        graphics/qgis-ltr
        security/py-keystone

for Run

        audio/py-gmusicapi
        devel/py-oslotest
        devel/py-pytest-shutil
        devel/py-responses
        devel/py-sure
        devel/py-vsts-cd-manager
        graphics/qgis

        graphics/qgis-ltr
        science/py-MDAnalysis
        science/py-MDAnalysisTests
        security/py-certbot-apache
        security/py-certbot-dns-cloudflare
        security/py-certbot-dns-cloudxns
        security/py-certbot-dns-digitalocean
        security/py-certbot-dns-dnsimple
        security/py-certbot-dns-dnsmadeeasy
        security/py-certbot-dns-gehirn
        security/py-certbot-dns-google
        security/py-certbot-dns-linode
        security/py-certbot-dns-luadns
        security/py-certbot-dns-nsone
        security/py-certbot-dns-ovh
        security/py-certbot-dns-rfc2136
        security/py-certbot-dns-route53
        security/py-certbot-dns-sakuracloud
        security/py-certbot-nginx
        sysutils/py-azure-cli
        sysutils/py-azure-cli-batchai
        textproc/py-mkdocs
        www/py-kallithea
        www/py-rhodecode
Sep 18 2019, 2:36 PM
ngie updated the summary of D21654: Upgrade devel/py-mock from 2.0.0 to 3.0.5 and fix "make test" target.
Sep 18 2019, 2:14 PM
ngie retitled D21654: Upgrade devel/py-mock from 2.0.0 to 3.0.5 and fix "make test" target from Upgrade devel/py-mock from 2.0.0 to 3.0.5 to Upgrade devel/py-mock from 2.0.0 to 3.0.5 and fix "make test" target.
Sep 18 2019, 2:12 PM
ngie updated the diff for D21654: Upgrade devel/py-mock from 2.0.0 to 3.0.5 and fix "make test" target.

Remove devel/py-tox dependency

Sep 18 2019, 2:10 PM
ngie updated the diff for D21654: Upgrade devel/py-mock from 2.0.0 to 3.0.5 and fix "make test" target.

Update the diff after feedback received and to fix the test target
by using github to pull down the sources and pytest to run the tests,
like tox.ini does.

Sep 18 2019, 2:09 PM
ngie added inline comments to D21654: Upgrade devel/py-mock from 2.0.0 to 3.0.5 and fix "make test" target.
Sep 18 2019, 2:08 PM
ngie updated the summary of D21654: Upgrade devel/py-mock from 2.0.0 to 3.0.5 and fix "make test" target.
Sep 18 2019, 2:06 PM
ngie updated the summary of D21654: Upgrade devel/py-mock from 2.0.0 to 3.0.5 and fix "make test" target.
Sep 18 2019, 2:02 PM
ngie edited P311 Masterwork From Distant Lands.
Sep 18 2019, 1:59 PM
ngie edited P310 Masterwork From Distant Lands.
Sep 18 2019, 1:58 PM
ngie edited P309 Masterwork From Distant Lands.
Sep 18 2019, 1:54 PM

Sep 14 2019

ngie updated the summary of D21654: Upgrade devel/py-mock from 2.0.0 to 3.0.5 and fix "make test" target.
Sep 14 2019, 12:17 AM
ngie created D21654: Upgrade devel/py-mock from 2.0.0 to 3.0.5 and fix "make test" target.
Sep 14 2019, 12:15 AM

Sep 4 2019

ngie accepted D21519: procstat/tests: Fix flakiness by waiting for program to start.

Thank you for fixing my flaky test (and for teaching me a new tidbit about shell support)!

Sep 4 2019, 2:20 PM

Aug 24 2019

ngie added inline comments to D21259: Upgrade devel/distcc to 3.3.3 and add pump support.
Aug 24 2019, 2:36 AM
ngie added a comment to D21259: Upgrade devel/distcc to 3.3.3 and add pump support.

I'll take a closer look at this sometime this weekend..

Aug 24 2019, 2:35 AM

Aug 23 2019

ngie updated the summary of D21259: Upgrade devel/distcc to 3.3.3 and add pump support.
Aug 23 2019, 4:18 PM
ngie added a comment to D21259: Upgrade devel/distcc to 3.3.3 and add pump support.
  • Shuffle around installing the README files (they shouldn't be reliant on PUMP support)
  • Fix the duplicate prefixing of distcc in ETCDIR.
Aug 23 2019, 4:08 PM
ngie added a comment to D21259: Upgrade devel/distcc to 3.3.3 and add pump support.

Hi Enjie,

Sorry for the last commit.

I arc patched this review and tested in poudriere for {11.2,12.0}{amd64}{i386} and I'm seeing pkg-plist issues:

===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: etc/default/distcc
Error: Orphaned: %%ETCDIR%%/clients.allow
Error: Orphaned: %%ETCDIR%%/commands.allow.sh
Error: Orphaned: %%ETCDIR%%/hosts
Error: Orphaned: man/man1/include_server.1.gz
Error: Orphaned: man/man1/lsdistcc.1.gz
Error: Orphaned: man/man1/pump.1.gz
Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/COPYING
Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/README.pump
Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/TODO
Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/example/README
Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/example/default
Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/example/hosts.allow
Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/example/init
Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/example/init-suse
Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/example/logrotate
Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/example/services
Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/example/xinetd
Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/protocol-3-impl.txt
Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/protocol-3.txt
Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/protocol-gssapi.txt
Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/survey.txt
===> Checking for items in pkg-plist which are not in STAGEDIR
===> Error: Plist issues found.

Do you see the same?

Aug 23 2019, 4:03 PM
ngie retitled D21259: Upgrade devel/distcc to 3.3.3 and add pump support from Upgrade devel/distcc to 3.3.2 and add pump support to Upgrade devel/distcc to 3.3.3 and add pump support.
Aug 23 2019, 4:00 PM
ngie added a comment to D21259: Upgrade devel/distcc to 3.3.3 and add pump support.

Address some of @fernape's concerns and all of @mat's concerns

Aug 23 2019, 3:59 PM
ngie added a comment to D21259: Upgrade devel/distcc to 3.3.3 and add pump support.

I have a new patch that addresses some of the things pointed by @mat and updates the port to 3.3.3 (recently released).

Since I'm not the creator of the review I don't know if it is OK to just arc diff --update this?

Aug 23 2019, 3:29 PM

Aug 16 2019

D21279: Update pthread_cond_timedwait() test to current NetBSD version is now accepted and ready to land.

Macro lgtm:

Aug 16 2019, 4:45 AM

Aug 14 2019

ngie added inline comments to D21259: Upgrade devel/distcc to 3.3.3 and add pump support.
Aug 14 2019, 3:29 PM
ngie added a comment to D21259: Upgrade devel/distcc to 3.3.3 and add pump support.

Remove unnecessary upstream divergence with GZIP call

Aug 14 2019, 6:25 AM
ngie added a comment to D21259: Upgrade devel/distcc to 3.3.3 and add pump support.

Install pump with INSTALL_SCRIPT, not INSTALL_PROGRAM, so STRIP can be enabled again

Aug 14 2019, 6:00 AM
ngie edited P299 Masterwork From Distant Lands.
Aug 14 2019, 5:58 AM
ngie added a comment to D21259: Upgrade devel/distcc to 3.3.3 and add pump support.

Mute gzip --help noise by redirecting stderr to /dev/null

Aug 14 2019, 5:54 AM
ngie updated the test plan for D21259: Upgrade devel/distcc to 3.3.3 and add pump support.
Aug 14 2019, 5:53 AM
ngie edited P298 Masterwork From Distant Lands.
Aug 14 2019, 5:53 AM
ngie updated the test plan for D21259: Upgrade devel/distcc to 3.3.3 and add pump support.
Aug 14 2019, 5:44 AM
ngie updated the test plan for D21259: Upgrade devel/distcc to 3.3.3 and add pump support.
Aug 14 2019, 5:44 AM
ngie edited P297 Masterwork From Distant Lands.
Aug 14 2019, 5:43 AM
ngie updated the summary of D21259: Upgrade devel/distcc to 3.3.3 and add pump support.
Aug 14 2019, 5:43 AM
ngie created D21259: Upgrade devel/distcc to 3.3.3 and add pump support.
Aug 14 2019, 5:42 AM

Aug 10 2019

ngie committed rS350837: tests/sys/opencrypto: enable armv8crypto on aarch64.
tests/sys/opencrypto: enable armv8crypto on aarch64
Aug 10 2019, 3:54 PM
ngie closed D21018: tests/sys/opencrypto: enable armv8crypto.
Aug 10 2019, 3:53 PM · arm64