Page MenuHomeFreeBSD

ngie (Enji Cooper)
User

Projects

User Details

User Since
Aug 2 2014, 8:08 AM (237 w, 4 d)

Recent Activity

Today

ngie committed rS344416: Build death tests programmatically.
Build death tests programmatically
Thu, Feb 21, 3:37 AM
ngie committed rS344415: Fix a typo.
Fix a typo
Thu, Feb 21, 3:36 AM

Yesterday

ngie committed rS344380: Correct gmock/gtest expectations w.r.t. C++11/RTTI.
Correct gmock/gtest expectations w.r.t. C++11/RTTI
Wed, Feb 20, 8:10 PM
ngie committed rS344350: Fix test compilation for gmock_main tests, similar to r344345.
Fix test compilation for gmock_main tests, similar to r344345
Wed, Feb 20, 9:34 AM
ngie committed rS344349: Fix test compilation for gmock tests, similar to r344345.
Fix test compilation for gmock tests, similar to r344345
Wed, Feb 20, 8:04 AM
ngie committed rS344348: Add glue Makefile.inc to make the next hop to the googletest/Makefile.inc.
Add glue Makefile.inc to make the next hop to the googletest/Makefile.inc
Wed, Feb 20, 8:01 AM
ngie committed rS344347: Oh wait... those helper programs were for the py tests.
Oh wait... those helper programs were for the py tests
Wed, Feb 20, 7:53 AM
ngie committed rS344346: Apply lessons learned in r344345 on gtest_main tests.
Apply lessons learned in r344345 on gtest_main tests
Wed, Feb 20, 7:49 AM
ngie committed rS344345: Fix gtest test compilation and build more tests.
Fix gtest test compilation and build more tests
Wed, Feb 20, 7:30 AM
ngie committed rS344344: Don't hardcode the source filename.
Don't hardcode the source filename
Wed, Feb 20, 7:21 AM
ngie committed rS344342: Add more port-related flags to Makefile.inc.
Add more port-related flags to Makefile.inc
Wed, Feb 20, 6:54 AM
ngie committed rS344341: Fix the pathing for the header files.
Fix the pathing for the header files
Wed, Feb 20, 6:53 AM
ngie committed rS344339: Sprinkle `${HAS_TESTS}` in Makefiles.
Sprinkle `${HAS_TESTS}` in Makefiles
Wed, Feb 20, 6:03 AM
ngie committed rS344338: Add entries in BSD.tests.dist for the googletest test dirs.
Add entries in BSD.tests.dist for the googletest test dirs
Wed, Feb 20, 5:56 AM
ngie committed rS344336: Add glue Makefile for tests under lib/googletest/....
Add glue Makefile for tests under lib/googletest/...
Wed, Feb 20, 3:07 AM
ngie removed reviewers for D19261: Import capsicum-test into ^/vendor/google/capsicum-test/dist: rwatson, manpages.
Wed, Feb 20, 2:36 AM
ngie retitled D19261: Import capsicum-test into ^/vendor/google/capsicum-test/dist from Import capsicum-test into ^/vendor/google/capsicum-test to Import capsicum-test into ^/vendor/google/capsicum-test/dist.
Wed, Feb 20, 2:35 AM
ngie created D19261: Import capsicum-test into ^/vendor/google/capsicum-test/dist.
Wed, Feb 20, 2:34 AM
ngie updated the diff for D18950: Remove references to pdwait4(2) and `CAP_PDWAIT` from rights(4).

Update the commit message and reference the bug in sys/capsicum.h

Wed, Feb 20, 2:01 AM
ngie retitled D18950: Remove references to pdwait4(2) and `CAP_PDWAIT` from rights(4) from Remove references to pdwait4(2) and `CAP_PDWAIT` to Remove references to pdwait4(2) and `CAP_PDWAIT` from rights(4).
Wed, Feb 20, 1:58 AM
ngie updated the diff for D18950: Remove references to pdwait4(2) and `CAP_PDWAIT` from rights(4).

Remove CAP_PDWAIT from rights(4) and add a comment to sys/capsicum.h instead of removing the constant.

Wed, Feb 20, 1:50 AM
ngie committed rS344330: Document `GTESTS` variable in googletest.test.mk.
Document `GTESTS` variable in googletest.test.mk
Wed, Feb 20, 1:13 AM
ngie committed rS344329: Use `GTESTS` instead of `PLAIN_TESTS_CXX`.
Use `GTESTS` instead of `PLAIN_TESTS_CXX`
Wed, Feb 20, 1:11 AM
ngie committed rS344328: Add googletest.test.mk and integrate into bsd.test.mk.
Add googletest.test.mk and integrate into bsd.test.mk
Wed, Feb 20, 1:09 AM
ngie committed rS344327: Build/install cddl/usr.sbin/zfsd/tests if MK_GOOGLETEST != no.
Build/install cddl/usr.sbin/zfsd/tests if MK_GOOGLETEST != no
Wed, Feb 20, 12:41 AM
ngie committed rS344326: Rely on gmock/gtest integration done in branch.
Rely on gmock/gtest integration done in branch
Wed, Feb 20, 12:40 AM
ngie committed rS344324: Fix up dependency finding for libg{mock,test}_main.
Fix up dependency finding for libg{mock,test}_main
Wed, Feb 20, 12:19 AM
ngie committed rS344323: Unconditionally build/install libg{mock,test}_main.
Unconditionally build/install libg{mock,test}_main
Wed, Feb 20, 12:15 AM
ngie committed rS344322: MK_GOOGLETEST should be enabled/disabled based on MK_TESTS_SUPPORT.
MK_GOOGLETEST should be enabled/disabled based on MK_TESTS_SUPPORT
Wed, Feb 20, 12:12 AM
ngie committed rS344321: Fix typos.
Fix typos
Wed, Feb 20, 12:11 AM

Tue, Feb 19

ngie added inline comments to D19260: gcov support.
Tue, Feb 19, 11:36 PM
ngie committed rS344313: Add missing INCSGROUPS definition.
Add missing INCSGROUPS definition
Tue, Feb 19, 10:46 PM
ngie committed rS344312: Add MK_GOOGLETEST option for building/installing gmock/gtest.
Add MK_GOOGLETEST option for building/installing gmock/gtest
Tue, Feb 19, 10:40 PM
ngie committed rS344311: Add .Lb references for gmock/gtest.
Add .Lb references for gmock/gtest
Tue, Feb 19, 10:35 PM
ngie committed rS344310: Make `server_cat(..)` handle short receives.
Make `server_cat(..)` handle short receives
Tue, Feb 19, 10:19 PM
ngie closed D19188: Make `server_cat(..)` handle short receives.
Tue, Feb 19, 10:19 PM
ngie added inline comments to D19188: Make `server_cat(..)` handle short receives.
Tue, Feb 19, 7:26 PM
ngie committed rS344271: MFhead@r344270.
MFhead@r344270
Tue, Feb 19, 3:47 AM

Mon, Feb 18

ngie added a comment to D19174: MFC r343845:.

@emaste, @jtl: ping?

Mon, Feb 18, 11:44 AM
ngie added a comment to D18950: Remove references to pdwait4(2) and `CAP_PDWAIT` from rights(4).

@emaste, @jtl: ping?

Mon, Feb 18, 11:44 AM
ngie updated the test plan for D19188: Make `server_cat(..)` handle short receives.
Mon, Feb 18, 11:43 AM
ngie added a comment to D19188: Make `server_cat(..)` handle short receives.

@emaste, @jtl: ping?

Mon, Feb 18, 10:42 AM
ngie updated the diff for D19188: Make `server_cat(..)` handle short receives.

Address @emaste's comments

Mon, Feb 18, 9:31 AM

Thu, Feb 14

ngie added inline comments to D19188: Make `server_cat(..)` handle short receives.
Thu, Feb 14, 1:32 AM
ngie created D19188: Make `server_cat(..)` handle short receives.
Thu, Feb 14, 1:04 AM

Wed, Feb 13

ngie committed rS344078: Import GoogleTest 1.8.1 into the vendor tree under `^/google/googletest/dist`.
Import GoogleTest 1.8.1 into the vendor tree under `^/google/googletest/dist`
Wed, Feb 13, 5:53 AM
ngie added reviewers for D19174: MFC r343845:: emaste, jtl.
Wed, Feb 13, 5:49 AM
ngie closed D18622: Import GoogleTest 1.8.1 into the vendor tree under `^/google/googletest/dist`.

Committed as rS344078.

Wed, Feb 13, 5:49 AM
ngie committed rS344087: Compile the tests without -Werror for now.
Compile the tests without -Werror for now
Wed, Feb 13, 5:41 AM
ngie committed rS344086: Merge build glue for libraries and tests done on github.
Merge build glue for libraries and tests done on github
Wed, Feb 13, 4:58 AM
ngie committed rS344081: Create a project branch for importing googletest 1.8.1.
Create a project branch for importing googletest 1.8.1
Wed, Feb 13, 3:10 AM
ngie committed rS344082: Copy googletest 1.8.1 from ^/vendor/google/googletest/1.8.1 to ....
Copy googletest 1.8.1 from ^/vendor/google/googletest/1.8.1 to ...
Wed, Feb 13, 2:47 AM
ngie committed rS344080: Reinforce my size limit again post-r34407[89].
Reinforce my size limit again post-r34407[89]
Wed, Feb 13, 2:24 AM
ngie committed rS344079: Copy ^/vendor/google/googletest/dist to ^/vendor/google/googletest/1.8.1.
Copy ^/vendor/google/googletest/dist to ^/vendor/google/googletest/1.8.1
Wed, Feb 13, 2:22 AM
ngie committed rS344077: Remove my size limit in order to import https://reviews.freebsd.org/D18622.
Remove my size limit in order to import https://reviews.freebsd.org/D18622
Wed, Feb 13, 2:16 AM
ngie created D19174: MFC r343845:.
Wed, Feb 13, 1:39 AM

Tue, Feb 12

ngie committed rS344068: MFC r342598:.
MFC r342598:
Tue, Feb 12, 11:37 PM
ngie closed D19157: MFC r342598:.
Tue, Feb 12, 11:37 PM
ngie committed rS344067: Fix up concurrent test zpool setup and teardown.
Fix up concurrent test zpool setup and teardown
Tue, Feb 12, 11:36 PM
ngie closed D19024: Fix up concurrent test zpool setup and teardown.
Tue, Feb 12, 11:36 PM
ngie closed D19158: Add rc.resume(8) alias for rc(8) to fix the manpage cross references.
Tue, Feb 12, 11:33 PM
ngie committed rS344066: Add rc.resume(8) alias for rc(8) to fix the manpage cross references.
Add rc.resume(8) alias for rc(8) to fix the manpage cross references
Tue, Feb 12, 11:33 PM
ngie committed rS344041: Bump `__FreeBSD_version__` for r343891.
Bump `__FreeBSD_version__` for r343891
Tue, Feb 12, 3:32 AM
ngie closed D19154: Bump `__FreeBSD_version__` for r343891.
Tue, Feb 12, 3:32 AM
ngie retitled D19158: Add rc.resume(8) alias for rc(8) to fix the manpage cross references from Install rc(8) to rc.resume(8) to fix the manpage cross references to Add rc.resume(8) alias for rc(8) to fix the manpage cross references.
Tue, Feb 12, 3:28 AM
ngie updated the summary of D19158: Add rc.resume(8) alias for rc(8) to fix the manpage cross references.
Tue, Feb 12, 3:27 AM
ngie added a reviewer for D19158: Add rc.resume(8) alias for rc(8) to fix the manpage cross references: eugen_grosbein.net.
Tue, Feb 12, 3:25 AM
ngie created D19158: Add rc.resume(8) alias for rc(8) to fix the manpage cross references.
Tue, Feb 12, 3:25 AM
ngie added reviewers for D19157: MFC r342598:: emaste, jtl.
Tue, Feb 12, 3:15 AM
ngie created D19157: MFC r342598:.
Tue, Feb 12, 3:15 AM
ngie committed rS344040: MFC r342904:.
MFC r342904:
Tue, Feb 12, 3:13 AM
ngie closed D19156: MFC r342904:.
Tue, Feb 12, 3:13 AM
ngie closed D19155: MFC r342904:.
Tue, Feb 12, 3:12 AM
ngie committed rS344039: MFC r342904:.
MFC r342904:
Tue, Feb 12, 3:12 AM
ngie added reviewers for D19156: MFC r342904:: emaste, jtl.
Tue, Feb 12, 3:07 AM
ngie added reviewers for D19155: MFC r342904:: emaste, jtl.
Tue, Feb 12, 3:07 AM
ngie created D19156: MFC r342904:.
Tue, Feb 12, 3:06 AM
ngie created D19155: MFC r342904:.
Tue, Feb 12, 3:06 AM
ngie committed rS344038: MFC r339343,r343444:.
MFC r339343,r343444:
Tue, Feb 12, 2:57 AM
ngie closed D19150: MFC r339343,r343444:.
Tue, Feb 12, 2:57 AM
ngie committed rS344037: MFC r343444:.
MFC r343444:
Tue, Feb 12, 2:57 AM
ngie closed D19151: MFC r343444:.
Tue, Feb 12, 2:57 AM
ngie added a comment to D19151: MFC r343444:.
In D19151#409812, @jtl wrote:

I assume this is the stable/12 version of D19150?

Tue, Feb 12, 2:54 AM
ngie added inline comments to D19024: Fix up concurrent test zpool setup and teardown.
Tue, Feb 12, 2:50 AM
ngie updated the summary of D19024: Fix up concurrent test zpool setup and teardown.
Tue, Feb 12, 2:49 AM

Mon, Feb 11

ngie created D19154: Bump `__FreeBSD_version__` for r343891.
Mon, Feb 11, 11:56 PM
ngie added reviewers for D19151: MFC r343444:: emaste, jtl.
Mon, Feb 11, 9:46 PM
ngie created D19151: MFC r343444:.
Mon, Feb 11, 9:45 PM
ngie added reviewers for D19150: MFC r339343,r343444:: emaste, jtl.
Mon, Feb 11, 9:45 PM
ngie created D19150: MFC r339343,r343444:.
Mon, Feb 11, 9:44 PM

Fri, Feb 8

ngie accepted D19096: Fix renameat(2) for CAPABILITIES kernels..
Fri, Feb 8, 12:55 AM
ngie added a comment to D19096: Fix renameat(2) for CAPABILITIES kernels..

Thanks so much!

Fri, Feb 8, 12:54 AM

Wed, Feb 6

ngie added a comment to D18950: Remove references to pdwait4(2) and `CAP_PDWAIT` from rights(4).

Not documenting it (as in rS320058) is reasonable, but I'm less sure about removing the bit definition unless we're certain we never intend to implement it.

Wed, Feb 6, 10:27 PM
ngie updated the diff for D18950: Remove references to pdwait4(2) and `CAP_PDWAIT` from rights(4).

Chase proposed change by updating CAP_ALL1/CAP_UNUSED1_22 with the removed cap bit.

Wed, Feb 6, 9:50 PM
ngie updated the summary of D18950: Remove references to pdwait4(2) and `CAP_PDWAIT` from rights(4).
Wed, Feb 6, 9:25 PM
ngie committed rS343845: Clean up all directories created by `make hier`.
Clean up all directories created by `make hier`
Wed, Feb 6, 9:24 PM
ngie closed D18641: Clean up all directories created by `make hier`.
Wed, Feb 6, 9:24 PM

Tue, Feb 5

ngie updated the test plan for D18950: Remove references to pdwait4(2) and `CAP_PDWAIT` from rights(4).
Tue, Feb 5, 6:14 PM
ngie abandoned D18623: Address the fact that errors from `copyout(9)` are not properly percolated up on failure.

Abandoning this diff in favor of the documentation clarification in rS343444.

Tue, Feb 5, 6:13 PM
ngie added a comment to D18950: Remove references to pdwait4(2) and `CAP_PDWAIT` from rights(4).

I think rS339356 is the wrong rev

Tue, Feb 5, 8:18 AM