User Details
- User Since
- Aug 2 2014, 8:08 AM (342 w, 4 d)
Yesterday
Is the affected_by_bug_208703 #define still relevant?
Tue, Feb 23
Ah, nevermind. I didn't see the "Testing Done" section before leaving a comment.
This seems ok, but I'd like to see test results for the entire set of libm tests after this change.
Can you please post the test results to prove that this works now?
This conversion is on the right direction, but incomplete.
Fri, Feb 12
Thu, Feb 4
Oh, I see now based on the description.
The shellcheck warning fixes are great (I'll happily stamp that diff)!
Could you please wrap the changes in #ifdef __FreeBSD__ so it'd be easier for me to upstream to NetBSD?
I don't think this is a good idea. Tests really shouldn't be starting services because it can make the tests more flaky, it can mutate system state, and might interfere with other service management systems, like Isilon has on OneFS.
Wed, Feb 3
This might be a good thing to add to a general purpose library.
I agree with @brooks ; the functionality that involves compiling as part of tests is very dubious functionality that should be removed.
Thu, Jan 28
This isn't the right approach; please use getconf MIN_HOLE_SIZE instead, like the ls tests do
83 create_test_inputs2() 84 { 85 create_test_dir 86 87 if ! getconf MIN_HOLE_SIZE "$(pwd)"; then 88 echo "getconf MIN_HOLE_SIZE $(pwd) failed; sparse files probably" \ 89 "not supported by file system" 90 mount 91 atf_skip "Test's work directory does not support sparse files;" \ 92 "try with a different TMPDIR?" 93 fi
Jan 11 2021
@glebius: please also run rcorder libexec/rc/rc.d/* to confirm that the changes work.
Could you please update the commit message to reflect the changes being made?
Jan 9 2021
Could you please add PR: 252417 to the commit message?
The reason why I hardcoded the path was to reduce redundant $PATH lookups and to ensure that random kyua(1) binaries wouldn't get picked up from someone's environment, increasing overall determinism of the target.
Jan 6 2021
Is there a reason why tr is being changed to sed?
Dec 11 2020
Dec 8 2020
Nov 18 2020
Non-blocking thought: can this use sem_post/sem_(timed)?wait instead of spinning in busy-loops waiting for threads to start?
Nov 5 2020
Oct 30 2020
This change does more than advertised in the CR description (which doesn't describe as much as the commit message should).
Oct 28 2020
I'll look through the rest of the review later.
Oct 26 2020
I should have marked this as "Request Changes" in the last message :/...
Wait... Lua? what Lua tests are you planning to add (for the bootloader)?
Oct 20 2020
No blocking concerns.
Oct 19 2020
Oct 15 2020
This LGTM.
Oct 6 2020
Oct 4 2020
Oct 1 2020
Sep 30 2020
Sep 28 2020
The change is good from a technical standpoint, but some of the documentation could be a bit more polished.
Sep 18 2020
Please add __FreeBSD__ around any test modifications; it makes it easier for folks to upstream the changes as we're 3 years out of date.
Sep 13 2020
Sep 7 2020
Aug 20 2020
Please use WITH_GOOGLETEST_INTERNAL_TESTS or something similar and default to on, since it seems to be limited to that case.
Aug 10 2020
This shouldn't be committed to head.
Aug 5 2020
I was a bit surprised to learn that this code relies on the jq utility from ports, by the way:
$ grep -r jq sbin/route/tests/ sbin/route/tests/utils.subr: gateway=$(echo $result | jq -r ${query}.gateway) sbin/route/tests/basic.sh: atf_set require.progs jq sbin/route/tests/basic.sh: atf_set require.progs jq
I wish we had a tool capable of ingesting json in base :/...
Jul 31 2020
NAK. I need to add Googletest support to kyua. Now that kyua has been forked, this is straightforward.
Jul 25 2020
Jul 23 2020
Curious... is there a reason why this was added in addition to lib/libc/tests/sys/sendfile_test.c?
Jul 21 2020
This should work, for sure.
Jul 12 2020
Jul 11 2020
Use UF_OFFLINE instead of SF_IMMUTABLE, as recommended by @asomers.
Jul 10 2020
Jul 4 2020
Jun 24 2020
Jun 23 2020
The FEATURE call should be moved down.
Jun 20 2020
I appreciate this update.
Jun 16 2020
May 14 2020
Thank you!
May 13 2020
Apr 18 2020
The change looks good functionally. My comments are mostly about the documentation/tests.