- User Since
- Aug 2 2014, 8:08 AM (246 w, 4 d)
Abandoning review based on in-depth analysis from @tuexen.
Tue, Apr 23
Ok, let's proceed with this change. I'll work on fixing the style issues on my branch.
@olivier: Approved! Please be sure to update the commit message before you commit. Thank you so very much <3!
Mon, Apr 22
Move the SUBDIR+= profile outside the architecture dependent blocks
I've proposed a different solution in D20005.
This moved SUBDIR+= profile inside another .if block :/...
Sun, Apr 21
Sidenote: given that it's been over 2 weeks since you put this out for review, I think you can put in Reviewed by: jmg (maintainer timeout).
Requesting changes because there are a handful of non-style nits that should be resolved before this is committed to ^/head .
LGTM! Please commit this change to ^/head.
Fix accidental diff update in last revision
That's not what I wanted to do >_>...
Sat, Apr 20
Tue, Apr 16
Mon, Apr 15
I reworded the commit message/review name. Please use -g, not -d.
Sun, Apr 14
Sat, Apr 13
Try again with a patched libcurl
Let's try triggering the issue in bug 233177 again
Sort the Makefile variables per style.Makefile(9)