Page MenuHomeFreeBSD

ngie (Enji Cooper)
User

Projects

User Details

User Since
Aug 2 2014, 8:08 AM (246 w, 4 d)

Recent Activity

Yesterday

ngie abandoned D20017: Expect *localsctp* to fail.

Abandoning review based on in-depth analysis from @tuexen.

Wed, Apr 24, 1:27 PM
ngie committed rS346627: Use `range` instead of `xrange`.
Use `range` instead of `xrange`
Wed, Apr 24, 5:52 AM
ngie committed rS346626: Fix typo: `Plen` should be `plen`.
Fix typo: `Plen` should be `plen`
Wed, Apr 24, 5:50 AM
ngie committed rS346625: Don't leak `fd` when manipulating the device via `_getdev()`.
Don't leak `fd` when manipulating the device via `_getdev()`
Wed, Apr 24, 5:47 AM
ngie committed rS346623: Chase PEP-3110.
Chase PEP-3110
Wed, Apr 24, 4:50 AM
ngie committed rS346622: except EnvironmentError, e -> except EnvironmentError as e for py3 compat.
except EnvironmentError, e -> except EnvironmentError as e for py3 compat
Wed, Apr 24, 4:45 AM
ngie committed rS346621: MFhead@r346620.
MFhead@r346620
Wed, Apr 24, 4:44 AM
ngie committed rS346620: Reapply whitespace style changes from r346443 after recent changes to….
Reapply whitespace style changes from r346443 after recent changes to…
Wed, Apr 24, 4:40 AM
ngie added a comment to D20017: Expect *localsctp* to fail.

ncat is from nmap port and has nothing to do with nc, their names are similar but they are different things.
It's fine to install tests requirements from ports, after all, kyua is installed from ports and it's an essential tool for running the tests.
For marking the tests, what I was saying is "skip the tests (and not report failure) when there is no nmap (ncat) installed, and have a message to users to install nmap."

Wed, Apr 24, 1:17 AM

Tue, Apr 23

ngie added a comment to D20017: Expect *localsctp* to fail.

OK, I just check we have nmap in the test vm image and it does the work: https://github.com/freebsd/freebsd-ci/commit/689e19c8c71e1892f476c9ef9392f6b443d0ed15
The other failures are due to some perl stuff which I haven't had time on it: https://ci.freebsd.org/job/FreeBSD-head-amd64-dtrace_test/lastCompletedBuild/testReport/common.ip/t_dtrace_contrib/tst_ipv4localsctp_ksh/

I'm debugging this now. Seems to be a kernel issue. Will let you know once I have understood and fixed the issue.
Is using ncat and issue?

Tue, Apr 23, 10:48 PM
ngie added a comment to D20017: Expect *localsctp* to fail.

I'd prefer let's fix these test cases.

Tue, Apr 23, 10:47 PM
ngie updated the summary of D20017: Expect *localsctp* to fail.
Tue, Apr 23, 10:45 PM
ngie committed rS346613: Don't forget sys import!.
Don't forget sys import!
Tue, Apr 23, 10:43 PM
ngie committed rS346612: Ugh. Deal with encoding/decoding UTF-8 strings to bytes as needed.
Ugh. Deal with encoding/decoding UTF-8 strings to bytes as needed
Tue, Apr 23, 10:43 PM
ngie committed rS346611: Chase more needed `.{de,en}code()` -> `binascii.(un)?hexlify` changes.
Chase more needed `.{de,en}code()` -> `binascii.(un)?hexlify` changes
Tue, Apr 23, 10:40 PM
ngie committed rS346610: KATParser: don't leak `self.fp`.
KATParser: don't leak `self.fp`
Tue, Apr 23, 10:38 PM
ngie added inline comments to D19978: Test the AES-CCM test vectors from the NIST Known Answer Tests..
Tue, Apr 23, 10:25 PM
ngie accepted D19978: Test the AES-CCM test vectors from the NIST Known Answer Tests..

Ok, let's proceed with this change. I'll work on fixing the style issues on my branch.

Tue, Apr 23, 10:24 PM
ngie accepted D19958: Skip test component_selection:run_latest_genid if gmirror/gnop GEOM classes aren't available.

@olivier: Approved! Please be sure to update the commit message before you commit. Thank you so very much <3!

Tue, Apr 23, 7:59 PM
ngie retitled D19958: Skip test component_selection:run_latest_genid if gmirror/gnop GEOM classes aren't available from Skip test component_selection:run_latest_genid if gmirror/gnop GEOMclasses aren't available to Skip test component_selection:run_latest_genid if gmirror/gnop GEOM classes aren't available.
Tue, Apr 23, 7:58 PM
ngie added inline comments to D19958: Skip test component_selection:run_latest_genid if gmirror/gnop GEOM classes aren't available.
Tue, Apr 23, 2:49 PM
ngie requested changes to D19958: Skip test component_selection:run_latest_genid if gmirror/gnop GEOM classes aren't available.
Tue, Apr 23, 2:47 PM

Mon, Apr 22

ngie committed rP499695: Backport patch to fix error check with access(3) failures.
Backport patch to fix error check with access(3) failures
Mon, Apr 22, 11:34 PM
ngie closed D20002: Backport patch to fix error check with access(3) failures.
Mon, Apr 22, 11:34 PM
ngie updated the test plan for D20017: Expect *localsctp* to fail.
Mon, Apr 22, 10:33 PM
ngie created D20017: Expect *localsctp* to fail.
Mon, Apr 22, 10:28 PM
ngie committed rS346585: Remove a superfluous `)`.
Remove a superfluous `)`
Mon, Apr 22, 9:28 PM
ngie committed rS346584: Update the comment above the coverage COMPILER_FEATURES test.
Update the comment above the coverage COMPILER_FEATURES test
Mon, Apr 22, 9:26 PM
ngie committed rS346583: Add `coverage` to *COMPILER_FEATURES variable to bsd.compiler.mk and test for it.
Add `coverage` to *COMPILER_FEATURES variable to bsd.compiler.mk and test for it
Mon, Apr 22, 9:24 PM
ngie closed D19895: Fix up CXXSTD support, added in r345708.

Committed as rS346574 and rS346576.

Mon, Apr 22, 7:58 PM
ngie committed rS346578: Build libclang_rt/profile on all clang-supported architectures.
Build libclang_rt/profile on all clang-supported architectures
Mon, Apr 22, 7:21 PM
ngie closed D20003: Build libclang_rt/profile on all clang-supported architectures.
Mon, Apr 22, 7:21 PM
ngie updated the diff for D20003: Build libclang_rt/profile on all clang-supported architectures.

Move the SUBDIR+= profile outside the architecture dependent blocks

Mon, Apr 22, 7:18 PM
ngie committed rS346577: Prune branch, merged as r346574 and r346576.
Prune branch, merged as r346574 and r346576
Mon, Apr 22, 7:03 PM
ngie committed rS346576: Fix up CXXSTD support originally added in r345708.
Fix up CXXSTD support originally added in r345708
Mon, Apr 22, 6:40 PM
ngie committed rS346574: Rework CXXSTD setting via r345708.
Rework CXXSTD setting via r345708
Mon, Apr 22, 6:39 PM
ngie committed rS346572: Update the spelling of my name (continuation of r346571).
Update the spelling of my name (continuation of r346571)
Mon, Apr 22, 6:05 PM
ngie committed rS346571: Update the spelling of my name.
Update the spelling of my name
Mon, Apr 22, 5:52 PM
ngie committed rS346542: Fix sys.kern.coredump_phnum_test.coredump_phnum on i386.
Fix sys.kern.coredump_phnum_test.coredump_phnum on i386
Mon, Apr 22, 11:21 AM
ngie closed D20005: Fix sys.kern.coredump_phnum_test.coredump_phnum on i386.
Mon, Apr 22, 11:21 AM
ngie added a comment to D20005: Fix sys.kern.coredump_phnum_test.coredump_phnum on i386.

Thanks for the better fix. BTW, I still think these checks would be better to be rewritten as getting the real number and compare with 65535.

Mon, Apr 22, 11:17 AM
ngie committed rS346539: Fix `get_int_via_sysctlbyname(..)` on Jenkins.
Fix `get_int_via_sysctlbyname(..)` on Jenkins
Mon, Apr 22, 11:09 AM
ngie added a comment to D18495: Fix sys.kern.coredump_phnum_test.coredump_phnum on i386.

I've proposed a different solution in D20005.

Mon, Apr 22, 10:15 AM
ngie created D20005: Fix sys.kern.coredump_phnum_test.coredump_phnum on i386.
Mon, Apr 22, 10:14 AM
ngie committed rS346536: MFC r339473,r340075,r342918,r343592,r343593,r343614,r343665,r343669:.
MFC r339473,r340075,r342918,r343592,r343593,r343614,r343665,r343669:
Mon, Apr 22, 8:59 AM
ngie committed rS346534: Switch the conditional to only disable COVERAGE/COVERAGE_SUPPORT when not….
Switch the conditional to only disable COVERAGE/COVERAGE_SUPPORT when not…
Mon, Apr 22, 8:22 AM
ngie committed rS346533: Rely on the MACHINE_CPUARCH, etc logic in lib/libclang_rt.
Rely on the MACHINE_CPUARCH, etc logic in lib/libclang_rt
Mon, Apr 22, 8:02 AM
ngie committed rS346532: Really compile profile/ on all clang-supported arches.
Really compile profile/ on all clang-supported arches
Mon, Apr 22, 7:59 AM
ngie planned changes to D20003: Build libclang_rt/profile on all clang-supported architectures.

This moved SUBDIR+= profile inside another .if block :/...

Mon, Apr 22, 7:56 AM
ngie committed rS346531: Only try building lib/libclang_rt/profile if MK_CLANG != no.
Only try building lib/libclang_rt/profile if MK_CLANG != no
Mon, Apr 22, 7:33 AM
ngie committed rS346529: Import patch from D19895 for reworking how CXXSTD is handled.
Import patch from D19895 for reworking how CXXSTD is handled
Mon, Apr 22, 7:17 AM
ngie committed rS346528: Revert r346527.
Revert r346527
Mon, Apr 22, 7:13 AM
ngie committed rS346527: Use CFLAGS instead of CXXFLAGS for -fvisibility=default.
Use CFLAGS instead of CXXFLAGS for -fvisibility=default
Mon, Apr 22, 6:59 AM
ngie retitled D20003: Build libclang_rt/profile on all clang-supported architectures from Build libclang_rt/profile on all clang-supported architectures <<Replace this line with your revision title> to Build libclang_rt/profile on all clang-supported architectures.
Mon, Apr 22, 5:57 AM
ngie created D20003: Build libclang_rt/profile on all clang-supported architectures.
Mon, Apr 22, 5:57 AM
ngie created D20002: Backport patch to fix error check with access(3) failures.
Mon, Apr 22, 5:36 AM
ngie committed rS346515: Comment out checks that are causing failures on ^/stable/11, post-r337133.
Comment out checks that are causing failures on ^/stable/11, post-r337133
Mon, Apr 22, 3:20 AM
ngie closed D19998: Comment out test checks that are causing failures on ^/stable/11, post r337133.
Mon, Apr 22, 3:20 AM

Sun, Apr 21

ngie added a comment to D19853: [security/nist-kat]: Add AES-CCM and plain SHA digest test vectors..

Sidenote: given that it's been over 2 weeks since you put this out for review, I think you can put in Reviewed by: jmg (maintainer timeout).

Sun, Apr 21, 10:06 PM
ngie accepted D19853: [security/nist-kat]: Add AES-CCM and plain SHA digest test vectors..
Sun, Apr 21, 10:05 PM
ngie requested changes to D19978: Test the AES-CCM test vectors from the NIST Known Answer Tests..

Requesting changes because there are a handful of non-style nits that should be resolved before this is committed to ^/head .

Sun, Apr 21, 9:55 PM
ngie accepted D19977: Use more descriptive algorithm names in skip messages..

LGTM! Please commit this change to ^/head.

Sun, Apr 21, 9:34 PM
ngie updated the diff for D19997: MFC r324736:.

Fix accidental diff update in last revision

Sun, Apr 21, 9:11 PM
ngie created D19998: Comment out test checks that are causing failures on ^/stable/11, post r337133.
Sun, Apr 21, 9:08 PM
ngie added a comment to D19997: MFC r324736:.

That's not what I wanted to do >_>...

Sun, Apr 21, 9:02 PM
ngie updated the diff for D19997: MFC r324736:.

Update the comment

Sun, Apr 21, 9:02 PM
ngie added a reviewer for D19997: MFC r324736:: mjg.
Sun, Apr 21, 8:31 PM
ngie created D19997: MFC r324736:.
Sun, Apr 21, 8:30 PM
ngie committed rS346493: MFhead@r346492.
MFhead@r346492
Sun, Apr 21, 7:32 PM
ngie committed rS346492: Build libclang_rt/profile on all clang-supported architectures.
Build libclang_rt/profile on all clang-supported architectures
Sun, Apr 21, 7:26 PM

Sat, Apr 20

ngie committed rS346452: Revert r346443.
Revert r346443
Sat, Apr 20, 4:37 PM
ngie committed rS346444: Quick branch for hacking on getting python3 support to work for….
Quick branch for hacking on getting python3 support to work for…
Sat, Apr 20, 4:32 PM
ngie committed rS346451: Fix up `kern.cryptodevallowsoft` handling.
Fix up `kern.cryptodevallowsoft` handling
Sat, Apr 20, 4:28 PM
ngie committed rS346449: Replace `str.{decode,encode}("hex")` with binascii.(un)?hexlify.
Replace `str.{decode,encode}("hex")` with binascii.(un)?hexlify
Sat, Apr 20, 4:08 PM
ngie committed rS346447: Use py3 compatible method for catching exceptions.
Use py3 compatible method for catching exceptions
Sat, Apr 20, 4:05 PM
ngie committed rS346446: Hack away at runtests.
Hack away at runtests
Sat, Apr 20, 4:01 PM
ngie committed rS346443: tests/sys/opencrypto: fix whitespace per PEP8.
tests/sys/opencrypto: fix whitespace per PEP8
Sat, Apr 20, 3:43 PM
ngie added inline comments to D19895: Fix up CXXSTD support, added in r345708.
Sat, Apr 20, 1:08 PM

Tue, Apr 16

ngie committed rS346257: MFC r345644,r346061:.
MFC r345644,r346061:
Tue, Apr 16, 1:03 AM
ngie committed rS346256: MFC r345644,r346061:.
MFC r345644,r346061:
Tue, Apr 16, 1:03 AM

Mon, Apr 15

ngie added a comment to D19906: Add some simple regression tests for /sbin/rcorder.

That's a lot of tiny files! Would it be possible and desirable to reduce the file count by using here documents or something?

Mon, Apr 15, 7:51 PM
ngie accepted D19915: Drop -g from CFLAGS for zfsd(8).

I reworded the commit message/review name. Please use -g, not -d.

Mon, Apr 15, 7:15 PM
ngie retitled D19915: Drop -g from CFLAGS for zfsd(8) from Drop -d from CFLAGS for zfsd(8) to Drop -g from CFLAGS for zfsd(8).
Mon, Apr 15, 7:14 PM

Sun, Apr 14

ngie added inline comments to D19895: Fix up CXXSTD support, added in r345708.
Sun, Apr 14, 2:57 AM
ngie created D19906: Add some simple regression tests for /sbin/rcorder.
Sun, Apr 14, 2:40 AM
ngie committed rS346196: Fix warnings with lib/libpmc.
Fix warnings with lib/libpmc
Sun, Apr 14, 12:07 AM
ngie closed D19851: Fix warnings with lib/libpmc.
Sun, Apr 14, 12:07 AM
ngie updated the summary of D19851: Fix warnings with lib/libpmc.
Sun, Apr 14, 12:04 AM

Sat, Apr 13

ngie committed rS346195: Handle more missing changes to bsd.lib.mk for installing .gcno files.
Handle more missing changes to bsd.lib.mk for installing .gcno files
Sat, Apr 13, 11:52 PM
ngie committed rS346193: Port MK_COVERAGE changes over to bsd.lib.mk.
Port MK_COVERAGE changes over to bsd.lib.mk
Sat, Apr 13, 11:32 PM
ngie updated the summary of D19895: Fix up CXXSTD support, added in r345708.
Sat, Apr 13, 9:07 AM
ngie updated the summary of D19895: Fix up CXXSTD support, added in r345708.
Sat, Apr 13, 9:06 AM
ngie created D19895: Fix up CXXSTD support, added in r345708.
Sat, Apr 13, 9:04 AM
ngie updated the diff for D19851: Fix warnings with lib/libpmc.

Try again with a patched libcurl

Sat, Apr 13, 7:57 AM
ngie updated the diff for D19851: Fix warnings with lib/libpmc.

Let's try triggering the issue in bug 233177 again

Sat, Apr 13, 7:16 AM
ngie updated the diff for D19851: Fix warnings with lib/libpmc.

Sort the Makefile variables per style.Makefile(9)

Sat, Apr 13, 6:51 AM
ngie updated the summary of D19851: Fix warnings with lib/libpmc.
Sat, Apr 13, 6:26 AM
ngie added inline comments to D19851: Fix warnings with lib/libpmc.
Sat, Apr 13, 6:20 AM
ngie added inline comments to D19851: Fix warnings with lib/libpmc.
Sat, Apr 13, 6:08 AM

Fri, Apr 12

ngie committed rS346148: Take a more relaxed approach to CXXSTD.
Take a more relaxed approach to CXXSTD
Fri, Apr 12, 5:43 AM