User Details
- User Since
- Aug 2 2014, 8:08 AM (636 w, 5 d)
Yesterday
Just a couple questions about sys/*crypto. If the headers came from OpenSSL, I think we're ok leaving them be..?
Thank you for this, but I'm wondering if the functional testing for Linux syscalls are better suited for LTP. I'm not as active with that project as I used to be, but I'm still able to contribute there. There is some support missing from FreeBSD that would need to be added in order to make those tests work (/dev/loop), and some of the tests assume explicit Linux support which FreeBSD lacks (SCHED_EXT, etc), but there might be some items that can be gleaned from that project that allows us to avoid reinventing the wheel too much.
Treating this as a simple smoke test though for Linuxulator would be ok, but I want to make sure the tests are constrained to smoke tests and we don't go reinventing the wheel too much.
Mon, Oct 12
@joneum : ping?
@olce : ping (non-urgent)?
Sun, Oct 11
Can this be applied to /Makefile.inc1 instead?
Sat, Oct 10
@emaste : I added you to the subscriber list so you can maybe give a thumbs up on the SPDX ID changes.
Seems reasonable to me.
The aarch64 and riscv portions of the diff are unannotated FreeBSD modifications -- this is ok, but this really should be cleaned up in a future revision:
Normalize multiline comment header
Oddly enough this doesn't fail 100% of the time with our GHA workflows. I don't know why...
I found this issue when reviewing one of @seuros' commits: https://github.com/freebsd/freebsd-src/actions/runs/37836150968/job/113513585413 .
Tweak comment wording
Remove dash in RFC (this seems to be status quo for RFC references).
- Change descriptions to better match RFC-8881.
- Provide a link to RFC-8881 for further review.
- Remove manpage portion of the diff.
- Expand on the fact that the FF setup OUI_FREEBSD_BASE in the header, like mentioned earlier.
Fri, Oct 9
If you could mention the bug (once) in the code, that would be helpful and I'm happy to provide a ship-it.
Thu, Oct 8
Please submit this change upstream so I can integrate them into the next release.
I ran into so many conflicts that I just chose the upstream version of files by default. I want to get out of that habit by getting things to converge again between the copy in the FreeBSD src tree and on GitHub.
Wed, Oct 7
@ziaee: Ping?
I trust that works, but I feel like the code is more obfuscated now. Nevertheless, this needs more tests before making more extensive changes.
Tue, Oct 6
Please add an MFC timer for this change.
ANNNNNNNDDDD... update arm64's linux32 syscalls.master file.
Add missing pieces for fchmodat2 in all architectures