Page MenuHomeFreeBSD

ngie (Enji Cooper)
User

Projects

User Details

User Since
Aug 2 2014, 8:08 AM (406 w, 4 d)

Recent Activity

Sat, Apr 30

ngie added a comment to D34934: sbin/devfs: Correct usage.

In retrospect, I should have removed/edited the metadata in the commit message. It looks nice on Phabricator, but it looks less nice in raw git/email form.

Sat, Apr 30, 6:04 PM
ngie committed R10:f9f42a709b2b: sbin/devfs: Correct usage (authored by ngie).
sbin/devfs: Correct usage
Sat, Apr 30, 6:01 PM
ngie closed D34934: sbin/devfs: Correct usage.
Sat, Apr 30, 6:00 PM
ngie accepted D34934: sbin/devfs: Correct usage.
Sat, Apr 30, 5:48 PM

Apr 11 2022

ngie committed R10:567378cc0796: Fix OID format for `vm.swap_reserved` and `vm.swap_total` (authored by ngie).
Fix OID format for `vm.swap_reserved` and `vm.swap_total`
Apr 11 2022, 2:09 AM
ngie committed R10:368552395021: Don't leave `path` behind when executing `:chflags_success` (authored by ngie).
Don't leave `path` behind when executing `:chflags_success`
Apr 11 2022, 2:09 AM
ngie committed R10:07215e767195: Remove /usr/share/snmp/defs/tc.def with delete-old if MK_BSNMP == no (authored by ngie).
Remove /usr/share/snmp/defs/tc.def with delete-old if MK_BSNMP == no
Apr 11 2022, 2:09 AM
ngie closed D34877: Fix OID format for `vm.swap_reserved` and `vm.swap_total`.
Apr 11 2022, 2:09 AM
ngie committed R10:52122fa0968f: Add `kern.features.witness` (authored by ngie).
Add `kern.features.witness`
Apr 11 2022, 2:08 AM
ngie committed R10:62b553d4817a: snmpmod(3): fix typo under the COMMUNITIES section (authored by ngie).
snmpmod(3): fix typo under the COMMUNITIES section
Apr 11 2022, 2:08 AM
ngie committed R10:22cf7f752f45: lio_listio(2): fix manlint error (authored by ngie).
lio_listio(2): fix manlint error
Apr 11 2022, 2:08 AM
ngie committed R10:bb82803de0aa: extattr_get_file(2): fix more formatting (authored by ngie).
extattr_get_file(2): fix more formatting
Apr 11 2022, 2:08 AM
ngie committed R10:0c59a94dd500: extattr_get_file(20: bump .Dd (authored by ngie).
extattr_get_file(20: bump .Dd
Apr 11 2022, 2:08 AM
ngie committed R10:57d53eb6832f: extattr_get_file(2): clarify RETURN VALUES (authored by ngie).
extattr_get_file(2): clarify RETURN VALUES
Apr 11 2022, 2:08 AM
ngie committed R10:389d0259ed16: extattr_get_file(2): sort syscalls alphabetically (authored by ngie).
extattr_get_file(2): sort syscalls alphabetically
Apr 11 2022, 2:08 AM
ngie committed R10:4ddaa69aada0: extattr_get_fd(2): fix manlint errors (authored by ngie).
extattr_get_fd(2): fix manlint errors
Apr 11 2022, 2:08 AM
ngie committed R10:1b60c4e671d3: timespec_get(3): sort SEE ALSO correctly (authored by ngie).
timespec_get(3): sort SEE ALSO correctly
Apr 11 2022, 2:08 AM
ngie committed R10:67c9a9a0ec69: aio_suspend.2: properly canonicalize .Dd (authored by ngie).
aio_suspend.2: properly canonicalize .Dd
Apr 11 2022, 1:21 AM
ngie committed R10:43b37c42d287: cpuset{,_getaffinity,_getdomain}.2: fix SEE ALSO (authored by ngie).
cpuset{,_getaffinity,_getdomain}.2: fix SEE ALSO
Apr 11 2022, 1:21 AM
ngie committed R10:f639b46fca60: getentropy(3): sort SEE ALSO sections (authored by ngie).
getentropy(3): sort SEE ALSO sections
Apr 11 2022, 1:21 AM
ngie committed R10:beb0de9a845e: posix_spawn(3): fix section that references `vfork` (authored by ngie).
posix_spawn(3): fix section that references `vfork`
Apr 11 2022, 1:20 AM
ngie committed R10:674f15c3d5fa: cap_enter(2): fix CAVEATS section (authored by ngie).
cap_enter(2): fix CAVEATS section
Apr 11 2022, 1:20 AM
ngie added reviewers for D34877: Fix OID format for `vm.swap_reserved` and `vm.swap_total`: alc, dougm, kib, markj, cem.
Apr 11 2022, 12:37 AM
ngie requested review of D34877: Fix OID format for `vm.swap_reserved` and `vm.swap_total`.
Apr 11 2022, 12:35 AM

Feb 24 2022

ngie accepted D34336: fusefs: fix a cached attributes bug during directory rename.

It feels so weird reading modern C++ again.

Feb 24 2022, 4:58 AM

Feb 1 2022

ngie added a comment to D34116: newfs_msdos: fix type of kern.maxphys; connect ATF test from NetBSD.

This could also be handled in the Makefile to avoid having to dance around FreeBSD vs NetBSD in the test, since I assume we'll never upstream the utility name item and will always deviate from NetBSD.

Feb 1 2022, 2:43 AM

Dec 22 2021

ngie added a comment to D33493: libc: add some tests for localtime().

I understand and appreciate what you're striving for, but a major word of caution: tests that involve this degree of complexity have lower determinism, reducing the level of trust in a given test over the long run.

Dec 22 2021, 4:36 AM

Nov 29 2021

ngie added inline comments to D33143: Add posix_spawn_file_actions_{addchdir,addfchdir,addclosefrom}_np.
Nov 29 2021, 3:48 AM

Nov 28 2021

ngie added inline comments to D33143: Add posix_spawn_file_actions_{addchdir,addfchdir,addclosefrom}_np.
Nov 28 2021, 5:00 PM
ngie accepted D33143: Add posix_spawn_file_actions_{addchdir,addfchdir,addclosefrom}_np.

Tests look good! Thank you 💚!

Nov 28 2021, 4:51 PM

Nov 9 2021

ngie added a comment to D32496: test: sys/sysctl.h is standalone.

Also, this seems like (and I'm going to regret saying this) something that a system like autoconf might excel at (*shudders*).

Nov 9 2021, 1:57 AM
ngie added a comment to D32496: test: sys/sysctl.h is standalone.

There are/were other facilities in ATF that supported compile-time testing, but I think they should be removed, not expanded on.

Nov 9 2021, 1:56 AM
ngie added a comment to D31376: awk: Move to using two sets of tests.

Plus upstream has ../a.out: instead of awk: in the
output. Not sure how to deal with this yet, so I've not proposed
anything upstream.

Nov 9 2021, 1:53 AM
ngie added a comment to D31376: awk: Move to using two sets of tests.

I'm sorry for not responding sooner.. just one comment (otherwise, it looks great!).

Nov 9 2021, 1:50 AM

Jul 9 2021

ngie added a comment to D31084: Add python atf support. Add example rtsock tests..
In D31084#700128, @ngie wrote:

While here: have you investigated pytest? It’s far more extensible and pluggable than unittest.

In general I agree that using a well supported unit test framework seems like it would be better. However, that might require adjusting kyua to parse the output of those tests.
It would be great if we had a simpler test runner than kyua, but changing that would require some significant work.
Maybe another option would be to somehow adjust/parse pytest output? Or we could add support for reading JUnit XML output to kyua.

Seems like there is already an existing TAP output plugin for pytest https://github.com/python-tap/pytest-tap, maybe that could be used for python tests (kyua can already parse TAP output).

Jul 9 2021, 12:08 PM
ngie added a comment to D31084: Add python atf support. Add example rtsock tests..

While here: have you investigated pytest? It’s far more extensible and pluggable than unittest.

Jul 9 2021, 11:42 AM
ngie added a comment to D31084: Add python atf support. Add example rtsock tests..

This, seems like a bit of a misnomer. ATF integration isn’t done: instead unittest is being executed and faking metadata output to sort of act like ATF, but not completely. I would clarify this fact in the commit to avoid overselling what’s being provided.

Jul 9 2021, 11:38 AM

Jun 14 2021

ngie added inline comments to D26931: Hook atf-lua tests up to the build.
Jun 14 2021, 6:08 PM
ngie requested changes to D26931: Hook atf-lua tests up to the build.
Jun 14 2021, 6:07 PM

May 11 2021

ngie added a comment to D30217: sort: Make NetBSD sort tests compatible with sort. .

These are a lot of changes to an upstream (NetBSD) provided file without good annotations (please look for "Begin FreeBSD" elsewhere).

May 11 2021, 7:20 PM

Apr 21 2021

ngie added a comment to D29750: rc: make 'ddb' and 'dumpon' require disks, not the other way around.

So either I'm missing something, or the sort order in rcorder(8) isn't particularly stable, which makes this comparison not very useful.

Apr 21 2021, 9:21 PM

Apr 16 2021

ngie accepted D29039: Allow lib/msun/logarithm_test to pass on ld128 platforms.

Not my domain of expertise. Maybe someone like @dim or Steve Kargl would have better input 🤷...

Apr 16 2021, 8:11 PM

Apr 14 2021

ngie added a comment to D29750: rc: make 'ddb' and 'dumpon' require disks, not the other way around.

This needs to be run through rcorder to ensure things haven't been broken. Please add the output of this information to the CR.

Apr 14 2021, 5:03 PM

Apr 12 2021

ngie accepted D29566: lpd: Add -F flag to prevent daemonizing.

Macro surewhynot:

Apr 12 2021, 2:39 PM

Mar 1 2021

ngie accepted D28997: Allow ssp_test:read to pass more reliably.

LGTM!

Mar 1 2021, 6:03 PM

Feb 26 2021

ngie added a comment to D28798: Convert the msun tests to ATF.

Does this look okay now?

Feb 26 2021, 3:08 AM
ngie accepted D28884: Remove XFAILs from fmaxmin test.
Feb 26 2021, 3:07 AM

Feb 25 2021

ngie added a comment to D28884: Remove XFAILs from fmaxmin test.

Yes that should also be removed. Will update

Feb 25 2021, 5:13 AM

Feb 24 2021

ngie added a comment to D28884: Remove XFAILs from fmaxmin test.

Is the affected_by_bug_208703 #define still relevant, i.e., should it be removed?

Feb 24 2021, 12:53 AM

Feb 23 2021

ngie added a comment to D28884: Remove XFAILs from fmaxmin test.
In D28884#646868, @ngie wrote:

Can you please post the test results to prove that this works now?

Feb 23 2021, 6:31 PM
ngie accepted D28577: While building libm, turn off any math-related compiler builtins.

Ah, nevermind. I didn't see the "Testing Done" section before leaving a comment.

Feb 23 2021, 6:26 PM
ngie added a comment to D28577: While building libm, turn off any math-related compiler builtins.

This seems ok, but I'd like to see test results for the entire set of libm tests after this change.

Feb 23 2021, 6:24 PM
ngie requested changes to D28884: Remove XFAILs from fmaxmin test.

Can you please post the test results to prove that this works now?

Feb 23 2021, 6:23 PM
ngie requested changes to D28798: Convert the msun tests to ATF.

This conversion is on the right direction, but incomplete.

Feb 23 2021, 4:52 AM
ngie accepted D28788: lib/msun/ctrig_test: Print the mismatched values on failure.
Feb 23 2021, 4:13 AM

Feb 12 2021

ngie accepted D28478: lib/libc/tests/rpc: Correctly set timeout.

Macro goatforit:

Feb 12 2021, 6:45 PM

Feb 4 2021

ngie added a comment to D28480: bin/pkill: Fix {pgrep,pkill}-j_test.sh.

Oh, I see now based on the description.

Feb 4 2021, 4:38 PM
ngie added a comment to D28480: bin/pkill: Fix {pgrep,pkill}-j_test.sh.

The shellcheck warning fixes are great (I'll happily stamp that diff)!

Feb 4 2021, 4:35 PM
ngie requested changes to D28478: lib/libc/tests/rpc: Correctly set timeout.

Could you please wrap the changes in #ifdef __FreeBSD__ so it'd be easier for me to upstream to NetBSD?

Feb 4 2021, 4:31 PM
ngie requested changes to D28479: lib/libc/tests/rpc: Start rpcbind(8) if needed.

I don't think this is a good idea. Tests really shouldn't be starting services because it can make the tests more flaky, it can mutate system state, and might interfere with other service management systems, like Isilon has on OneFS.

Feb 4 2021, 4:30 PM

Feb 3 2021

ngie accepted D28398: du_test: Skip three tests if sparse files are not supported.

This might be a good thing to add to a general purpose library.

Feb 3 2021, 3:47 PM
ngie accepted D28414: atf: Fix ATF_BUILD_* values when not using the bootstrap compiler.

I agree with @brooks ; the functionality that involves compiling as part of tests is very dubious functionality that should be removed.

Feb 3 2021, 3:52 AM

Jan 28 2021

ngie requested changes to D28398: du_test: Skip three tests if sparse files are not supported.

This isn't the right approach; please use getconf MIN_HOLE_SIZE instead, like the ls tests do

83 create_test_inputs2()
84 {
85         create_test_dir
86 
87         if ! getconf MIN_HOLE_SIZE "$(pwd)"; then
88             echo "getconf MIN_HOLE_SIZE $(pwd) failed; sparse files probably" \
89                  "not supported by file system"
90             mount
91             atf_skip "Test's work directory does not support sparse files;" \
92                      "try with a different TMPDIR?"
93         fi
Jan 28 2021, 11:11 PM
ngie accepted D28397: Avoid double output in fenv_test.
Jan 28 2021, 11:07 PM

Jan 11 2021

ngie added a comment to D28097: include tmpfs mount into FILESYSTEMS.

@glebius: please also run rcorder libexec/rc/rc.d/* to confirm that the changes work.

Jan 11 2021, 9:03 PM
ngie accepted D28097: include tmpfs mount into FILESYSTEMS.

Could you please update the commit message to reflect the changes being made?

Jan 11 2021, 9:02 PM

Jan 9 2021

ngie added inline comments to D27848: Try to favor etcupdate(8) over mergemaster(8) in the handbook.
Jan 9 2021, 3:08 PM
ngie added inline comments to D28062: UPDATING: Change update procedure to use etcupdate(8) over mergemaster(8).
Jan 9 2021, 3:01 PM
ngie added a comment to D28062: UPDATING: Change update procedure to use etcupdate(8) over mergemaster(8).

Could you please add PR: 252417 to the commit message?

Jan 9 2021, 3:01 PM
ngie accepted D28045: build: `make check`: use a PATH search instead for Kyua.

The reason why I hardcoded the path was to reduce redundant $PATH lookups and to ensure that random kyua(1) binaries wouldn't get picked up from someone's environment, increasing overall determinism of the target.

Jan 9 2021, 2:56 PM

Jan 6 2021

ngie accepted D27984: du: tests: make H_flag tests more strict about output requirements.

Macro stlgtm:

Jan 6 2021, 5:08 PM
ngie accepted D27983: du: tests: fix the H_flag test (primarily grep usage).

Is there a reason why tr is being changed to sed?

Jan 6 2021, 1:54 AM

Dec 11 2020

ngie committed rS368547: timespec_get(3): sort SEE ALSO correctly.
timespec_get(3): sort SEE ALSO correctly
Dec 11 2020, 2:23 AM
ngie committed rS368546: cpuset{,_getaffinity,_getdomain}.2: fix SEE ALSO.
cpuset{,_getaffinity,_getdomain}.2: fix SEE ALSO
Dec 11 2020, 1:53 AM
ngie committed rS368537: aio_suspend.2: properly canonicalize .Dd.
aio_suspend.2: properly canonicalize .Dd
Dec 11 2020, 12:28 AM
ngie committed rS368536: cap_enter(2): fix CAVEATS section.
cap_enter(2): fix CAVEATS section
Dec 11 2020, 12:26 AM
ngie committed rS368534: posix_spawn(3): fix section that references `vfork`.
posix_spawn(3): fix section that references `vfork`
Dec 11 2020, 12:20 AM
ngie committed rS368533: getentropy(3): sort SEE ALSO sections.
getentropy(3): sort SEE ALSO sections
Dec 11 2020, 12:16 AM
ngie committed rS368532: arc4random(3): fix .Xr issues.
arc4random(3): fix .Xr issues
Dec 11 2020, 12:13 AM

Dec 8 2020

ngie committed rS368436: extattr_get_file(20: bump .Dd.
extattr_get_file(20: bump .Dd
Dec 8 2020, 4:18 AM
ngie committed rS368435: extattr_get_file(2): clarify RETURN VALUES.
extattr_get_file(2): clarify RETURN VALUES
Dec 8 2020, 4:16 AM
ngie committed rS368434: extattr_get_file(2): fix more formatting.
extattr_get_file(2): fix more formatting
Dec 8 2020, 4:05 AM
ngie committed rS368433: extattr_get_file(2): sort syscalls alphabetically.
extattr_get_file(2): sort syscalls alphabetically
Dec 8 2020, 4:01 AM
ngie committed rS368432: lio_listio(2): fix manlint error.
lio_listio(2): fix manlint error
Dec 8 2020, 3:48 AM
ngie committed rS368431: extattr_get_fd(2): fix manlint errors.
extattr_get_fd(2): fix manlint errors
Dec 8 2020, 3:43 AM

Nov 18 2020

ngie added inline comments to D26473: Significantly speed up libthr/mutex_test and make more reliable.
Nov 18 2020, 5:52 AM
ngie accepted D26473: Significantly speed up libthr/mutex_test and make more reliable.

Non-blocking thought: can this use sem_post/sem_(timed)?wait instead of spinning in busy-loops waiting for threads to start?

Nov 18 2020, 5:51 AM
ngie accepted D27202: msun tests: use standard floating-point exception flags on lrint and fenv tests.
Nov 18 2020, 5:46 AM · PowerPC

Nov 5 2020

ngie committed rS367399: snmpmod(3): fix typo under the COMMUNITIES section.
snmpmod(3): fix typo under the COMMUNITIES section
Nov 5 2020, 9:37 PM

Oct 30 2020

ngie requested changes to D26220: Improve test coverage for sbuf.

This change does more than advertised in the CR description (which doesn't describe as much as the commit message should).

Oct 30 2020, 7:49 PM · tests
ngie updated subscribers of D26220: Improve test coverage for sbuf.
Oct 30 2020, 7:23 PM · tests

Oct 28 2020

ngie added a comment to D26932: jail(3lua): Add some basic tests.

I'll look through the rest of the review later.

Oct 28 2020, 5:12 PM

Oct 26 2020

ngie requested changes to D26930: atf.tests.mk: add bits needed for adding tests that use atf-lua.

I should have marked this as "Request Changes" in the last message :/...

Oct 26 2020, 3:50 PM
ngie added a comment to D26930: atf.tests.mk: add bits needed for adding tests that use atf-lua.

Wait... Lua? what Lua tests are you planning to add (for the bootloader)?

Oct 26 2020, 3:50 PM

Oct 20 2020

ngie accepted D26751: Significantly reduce compile time for googletest internal tests.

No blocking concerns.

Oct 20 2020, 7:02 PM

Oct 19 2020

ngie added a comment to D26751: Significantly reduce compile time for googletest internal tests.
In D26751#599033, @dim wrote:

Might as well go full -O0. :)

Running the tests at -O2 in QEMU amd64 took:
44.52 real 27.28 user 13.96 sys
Changing it to -O1 makes it
91.80 real 73.32 user 14.28 sys
and -O0 results in
109.46 real 90.08 user 14.38 sys

So we might as well use -O0 since it doesn't seem to make much of a run time difference but has a big impact on compile time :)

Oct 19 2020, 10:53 PM

Oct 15 2020

ngie added inline comments to D26067: Don't build googletest internal tests by default.
Oct 15 2020, 5:52 AM
ngie requested changes to D26067: Don't build googletest internal tests by default.
Oct 15 2020, 5:49 AM
ngie accepted D26760: Enable SUBDIR_PARALLEL for lib/googletest.
Oct 15 2020, 5:42 AM
ngie accepted D26789: [tests] Fix itimer test warning-errors on gcc-6.4.

This LGTM.

Oct 15 2020, 5:41 AM