Page MenuHomeFreeBSD

libcrypto, libssl: link .so's with -Bsymbolic for upstream parity
Needs ReviewPublic

Authored by ngie on Apr 21 2024, 5:44 PM.
Tags
None
Referenced Files
F165386322: D44894.id137468.diff
Fri, Aug 7, 10:35 PM
F165239218: D44894.id137463.diff
Fri, Aug 7, 2:21 AM
Unknown Object (File)
Thu, Aug 6, 12:13 PM
Unknown Object (File)
Thu, Aug 6, 11:20 AM
Unknown Object (File)
Wed, Aug 5, 9:23 AM
Unknown Object (File)
Wed, Jul 22, 10:01 PM
Unknown Object (File)
Mon, Jul 20, 9:39 AM
Unknown Object (File)
Mon, Jul 20, 6:31 AM
Subscribers

Details

Reviewers
cy
emaste
Summary

This change modifies libcrypto, libssl, and dependent .so files to use
-Wl,-Bsymbolic to prefer locally defined symbols over globally defined
symbols in order to have parity with the upstream OpenSSL build process.

Test Plan

TODO: run tinderbox build

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 57263
Build 54151: arc lint + arc unit

Event Timeline

ngie requested review of this revision.Apr 21 2024, 5:44 PM
ngie added reviewers: cy, emaste.

-Wl,-Bsymbolic should be added to SOLINKOPTS instead of LDFLAGS

This avoids breaking the static object build case.