Page MenuHomeFreeBSD

libcrypto, libssl: link .so's with -Bsymbolic for upstream parity
Needs ReviewPublic

Authored by ngie on Sun, Apr 21, 5:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, May 2, 4:07 PM
Unknown Object (File)
Tue, Apr 30, 2:48 PM
Unknown Object (File)
Sat, Apr 27, 6:04 PM
Unknown Object (File)
Sat, Apr 27, 3:30 AM
Unknown Object (File)
Fri, Apr 26, 3:51 PM
Unknown Object (File)
Fri, Apr 26, 3:50 PM
Unknown Object (File)
Fri, Apr 26, 3:50 PM
Unknown Object (File)
Fri, Apr 26, 10:31 AM
Subscribers

Details

Reviewers
cy
emaste
Summary

This change modifies libcrypto, libssl, and dependent .so files to use
-Wl,-Bsymbolic to prefer locally defined symbols over globally defined
symbols in order to have parity with the upstream OpenSSL build process.

Test Plan

TODO: run tinderbox build

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 57263
Build 54151: arc lint + arc unit

Event Timeline

ngie requested review of this revision.Sun, Apr 21, 5:44 PM
ngie added reviewers: cy, emaste.

-Wl,-Bsymbolic should be added to SOLINKOPTS instead of LDFLAGS

This avoids breaking the static object build case.