In D57095#1308692, @markj wrote:

I ran this through the test suite and didn't see any problems, so it's ok with me. I wasn't able to reproduce the crash consistently before, only quite rarely, so it's hard to say that the problem is fixed for sure.

At a glance it's not clear to me that fin->fin_m is always going to have a mbuf header, i.e., that fin->fin_m->m_pkthdr will be valid.

Good to go.

Can you also please submit a review for the port?

I sent (cc you) an email to Harlan Stenn, the primary developer at nwtime.org. (nwtime.org is replacing the ntp.org). Let's see what he says.

Why put the message here, now? It is not we (FreeBSD) who will deprecated it in a certain amount of time. It is nwtime.org that will. Should we not try to upstream this by submitting a patch to them first? Before we apply this patch here?

Update to the latest 15-STABLE is all that is needed.

I think this needs a little more investigation because k5-platform.h already includes autoconf.h. jrtc27@'s October patch should have been enough. I will rebuild again (cleanly).