- User Since
- May 10 2014, 4:26 AM (201 w, 3 d)
Tue, Mar 13
Mon, Mar 12
Are there any more comments or requested revisions?
Wed, Mar 7
This addresses two punctuation issues wblock raised.
Sat, Mar 3
Fri, Mar 2
Wed, Feb 28
Mon, Feb 26
Sun, Feb 25
Still waiting for maintainer (firstname.lastname@example.org) approval. I sent an email Feb 22. No reply yet.
It's been a while but I think this should address all the comments and concerns previously noted.
Sat, Feb 24
Fri, Feb 23
I disagree. What you are suggesting should be a separate revision and a separate commit. Do not mix fixing a little endian build with adding big endian capability. They are two separate issues.
Feb 16 2018
Feb 7 2018
Added sentence to say that the constraint handler doesn't necessarily return and if it does a return code is set.
Reworded the part discussion when the constraint handler is called.
Feb 6 2018
Feb 5 2018
Some of these ports should probably be deprecated and removed... I'll look into deprecating tripwire12,
Feb 2 2018
Jan 30 2018
Jan 28 2018
Jan 26 2018
Jan 24 2018
The ipf bits are acceptable.
As the man page is discussing two functions this may be confusing simply reading the markup. Here it is formatted:
I think we might be losing something in describing both functions in the same man page. Formatting it, it should read like this:
Jan 23 2018
Jan 20 2018
Jan 17 2018
Can you please review this updated diff? (Hopefully I haven't lost track of all the changes.)
Jan 15 2018
Jan 13 2018
Jan 12 2018
I've come to that conclusion too. My three machines are two low power (65w) winsor (family 15h, model 107, stepping 2) and one 89w winsor (family 15h, model 75, stepping 2).
cpucontrol: found cpu family 0xf model 0xb stepping 0x2 extfamily 0 extmodel 0x6.
cpucontrol: /usr/local/share/cpucontrol/microcode_amd_fam15h.bin is not a valid amd firmware: version mismatch
Looks like my issue is outside of the scope of this review. All firmwares result in same as the following:
Doesn't work here.
Jan 11 2018
Jan 9 2018
Jan 5 2018
Apologies for wasting everyone's time. I should have checked bugzilla first or posted a question if anyone was working on this.
Sorry for taking so long, just got back to looking at this today.
Jan 4 2018
Jan 3 2018
Dec 31 2017
Dec 30 2017
This should be the last update. Can you check it over please?
All requested changes have been incorporated.