Page MenuHomeFreeBSD

cy (Cy Schubert)
User

Projects

User Details

User Since
May 10 2014, 4:26 AM (350 w, 3 d)

Recent Activity

Today

cy committed R10:25cdacf79b06: Import sqlite 3.34.1 (3340100). (authored by cy).
Import sqlite 3.34.1 (3340100).
Tue, Jan 26, 4:35 AM

Yesterday

cy committed R10:1fc148624f50: Fix build following bfc99943b04b46a6c1c885ce7bcc6f235b7422aa. (authored by cy).
Fix build following bfc99943b04b46a6c1c885ce7bcc6f235b7422aa.
Mon, Jan 25, 10:48 PM
cy committed R10:83edbc3cb54f: ipfilter: Retire pre-standard C support. (authored by cy).
ipfilter: Retire pre-standard C support.
Mon, Jan 25, 10:48 PM
cy committed R10:5f965438f241: Import sqlite 3.34.1 (3340100). (authored by cy).
Import sqlite 3.34.1 (3340100).
Mon, Jan 25, 6:18 PM

Sun, Jan 24

cy committed rP562443: Update to the latest cfengine commits on github..
Update to the latest cfengine commits on github.
Sun, Jan 24, 3:37 AM
cy committed rP562442: Update to the latest MIT KRB5 commit on github..
Update to the latest MIT KRB5 commit on github.
Sun, Jan 24, 3:37 AM
cy committed rP562441: Update to the latest networkupstools/nut github commit..
Update to the latest networkupstools/nut github commit.
Sun, Jan 24, 3:36 AM
cy committed rP562440: Flag broken on FreeBSD 13 and 14..
Flag broken on FreeBSD 13 and 14.
Sun, Jan 24, 3:36 AM

Wed, Jan 20

cy accepted D27961: Simplify dynamic ipfilter sysctls..

Definitely an improvement. Thank you.

Wed, Jan 20, 5:17 PM
cy committed rP562150: This is the ports version of src commit.
This is the ports version of src commit
Wed, Jan 20, 5:14 PM
cy closed D28249: wpa_supplicant fix rtbuf_len issue.
Wed, Jan 20, 3:46 PM
cy committed R10:d70886d06316: wpa_supplicant uses PF_ROUTE to return the routing table in order to (authored by cy).
wpa_supplicant uses PF_ROUTE to return the routing table in order to
Wed, Jan 20, 3:46 PM
cy accepted D28249: wpa_supplicant fix rtbuf_len issue.

Looks good. I'll commit it and create a pull request to our upstream hostap.

Wed, Jan 20, 3:21 PM

Tue, Jan 19

cy committed rP562012: Update 0.01 --> 0.02..
Update 0.01 --> 0.02.
Tue, Jan 19, 3:07 AM

Mon, Jan 18

cy accepted D28209: Remove dependency of rc.d/tmp on grep.

Agree with glebius.

Mon, Jan 18, 9:12 PM

Sun, Jan 17

cy requested changes to D28209: Remove dependency of rc.d/tmp on grep.

Otherwise it looks good. This has the advantage of:

Sun, Jan 17, 2:46 PM

Tue, Jan 12

cy committed rP561298: Document sudo CVE-2021-23239..
Document sudo CVE-2021-23239.
Tue, Jan 12, 4:28 AM
cy committed rP561297: Fix build on llvm10 and gcc..
Fix build on llvm10 and gcc.
Tue, Jan 12, 4:28 AM

Mon, Jan 11

cy committed rP561259: Update 1.9.4p2 --> 1.9.5.
Update 1.9.4p2 --> 1.9.5
Mon, Jan 11, 8:06 PM

Fri, Jan 8

cy committed R10:c6951fac7846: Fix 32-bit build post 5cc52631b3b88dfc36d8049dc8bece8573c5f9af. (authored by cy).
Fix 32-bit build post 5cc52631b3b88dfc36d8049dc8bece8573c5f9af.
Fri, Jan 8, 7:34 PM

Wed, Jan 6

cy abandoned D28007: Dcoument 3630506b9dae - main - loader: implement framebuffer console.

OK. I figured this was intentional.

Wed, Jan 6, 8:12 PM
cy requested review of D28007: Dcoument 3630506b9dae - main - loader: implement framebuffer console.
Wed, Jan 6, 7:52 PM

Mon, Jan 4

cy committed rP560337: Update to the latest cfengine commits on github..
Update to the latest cfengine commits on github.
Mon, Jan 4, 7:41 PM
cy committed rP560336: Update to the latest networkupstools/nut github commit..
Update to the latest networkupstools/nut github commit.
Mon, Jan 4, 7:40 PM
cy committed rP560335: Update to the latest MIT KRB5 commit on github..
Update to the latest MIT KRB5 commit on github.
Mon, Jan 4, 7:40 PM

Fri, Jan 1

cy committed R10:1d010cd31cdf: Fix i386 build following 37df9d3bba8577fcdd63382ff5a4a5cbb4aa55b4. (authored by cy).
Fix i386 build following 37df9d3bba8577fcdd63382ff5a4a5cbb4aa55b4.
Fri, Jan 1, 4:49 PM

Wed, Dec 30

cy committed rP559641: Fix build with broken nondefault python..
Fix build with broken nondefault python.
Wed, Dec 30, 5:51 AM
cy committed rP559639: Fix LLVM11 build..
Fix LLVM11 build.
Wed, Dec 30, 5:38 AM
cy committed rP559640: Add SIM_SIMULATOR and USIM_SIMULATOR options..
Add SIM_SIMULATOR and USIM_SIMULATOR options.
Wed, Dec 30, 5:38 AM

Dec 24 2020

cy accepted D27571: CLOCK_ADJUST_REALTIME.

Looks good. But I suggest holding off committing this until Juergen or Harlan sign off on this. They're the people who asked for it. They're trying to work around issues where VMware VMs are starved of resources and ntp needs to make big adjustments to catch up the clock after a VM has not executed for a number of seconds or minutes.

Dec 24 2020, 8:13 PM
cy committed R10:75cf00c726f1: MFC: 0ebcbcc0efdd (svn r368734: (authored by cy).
MFC: 0ebcbcc0efdd (svn r368734:
Dec 24 2020, 7:40 PM
cy committed R10:99e169aa276b: MFC: 0ebcbcc0efdd (svn r368734: (authored by cy).
MFC: 0ebcbcc0efdd (svn r368734:
Dec 24 2020, 7:39 PM

Dec 17 2020

cy committed rS368734: Update the unbound version number from r368478..
Update the unbound version number from r368478.
Dec 17 2020, 7:51 PM

Dec 16 2020

cy committed rP558233: Update WWW..
Update WWW.
Dec 16 2020, 5:53 PM
cy accepted D27571: CLOCK_ADJUST_REALTIME.

Looks good.

Dec 16 2020, 9:35 AM
cy committed rS368693: MFC r368478:.
MFC r368478:
Dec 16 2020, 9:22 AM

Dec 15 2020

cy committed rP558164: Update arping 2.19 --> 2.21..
Update arping 2.19 --> 2.21.
Dec 15 2020, 3:39 PM

Dec 13 2020

cy committed R9:95e22d8cb4aa: Remove myself from the contributors list and add myself to the (authored by cy).
Remove myself from the contributors list and add myself to the
Dec 13 2020, 7:29 PM
cy committed R9:0a1a669f9c19: Announce myself as a new ports committer. (authored by cy).
Announce myself as a new ports committer.
Dec 13 2020, 7:29 PM
cy committed R9:316dd422bd01: Add the following ports contributors for their contributions to (authored by cy).
Add the following ports contributors for their contributions to
Dec 13 2020, 7:24 PM
cy committed R9:fd490af5c891: Add Brian Skrab <brian@quynh-and-brian.org> to the list of contributers (authored by cy).
Add Brian Skrab <brian@quynh-and-brian.org> to the list of contributers
Dec 13 2020, 7:23 PM
cy committed R9:73c514722829: Add Patrick Powell, author of LPRng, for contributing LPRngTools to the (authored by cy).
Add Patrick Powell, author of LPRng, for contributing LPRngTools to the
Dec 13 2020, 7:23 PM

Dec 11 2020

cy added a comment to D27571: CLOCK_ADJUST_REALTIME.

I started a new thread with the participants of the original email thread and added kib@ to it. Waiting for their replies.

Dec 11 2020, 7:13 PM
cy accepted D27571: CLOCK_ADJUST_REALTIME.

I expect Harlan Stenn and Juergen Perlinger to be satisfied with this. I'll check in with them and cc you.

Dec 11 2020, 6:57 PM
cy added inline comments to D27571: CLOCK_ADJUST_REALTIME.
Dec 11 2020, 5:49 PM
cy added a comment to D27571: CLOCK_ADJUST_REALTIME.

nwtime.org need it to return the current time, i.e. clock_gettime() output atomically to avoid the expense of making another system call. Adding a clock_id satisfies one of the two requirements. I suppose current time could be returned in *ts upon return.

Dec 11 2020, 5:27 PM

Dec 10 2020

cy committed rP557447: Update abiword 3.0.1 --> 3.0.4. This resolves 13-CURRENT build.
Update abiword 3.0.1 --> 3.0.4. This resolves 13-CURRENT build
Dec 10 2020, 5:38 PM
cy committed rS368495: MFC r368294:.
MFC r368294:
Dec 10 2020, 12:43 AM

Dec 9 2020

cy committed rS368478: MFV r368464:.
MFV r368464:
Dec 9 2020, 3:00 AM

Dec 8 2020

cy committed rS368465: Tag unbound 1.13.0..
Tag unbound 1.13.0.
Dec 8 2020, 9:25 PM
cy committed rS368464: Vendor import of Unbound 1.13.0..
Vendor import of Unbound 1.13.0.
Dec 8 2020, 9:23 PM

Dec 4 2020

cy committed rS368346: Revert r366857..
Revert r366857.
Dec 4 2020, 7:36 PM
cy committed rS368345: Revert r366857..
Revert r366857.
Dec 4 2020, 7:31 PM
cy added a comment to D27459: Only bring down clone interfaces at shutdown.
In D27459#614027, @jhb wrote:
In D27459#613956, @jtl wrote:

This does not fix the regression I am experiencing in my test setup. I am testing with a machine which uses a LAGG interface to communicate with the outside world. Shutting this interface down still makes my SSH sessions hang.

My earlier diagnosis was that this is caused by the following sequence:

  1. init gets the signal to shutdown.
  2. init runs the shutdown scripts. The sshd shutdown script kills off the daemon, but not the forked processes to handle individual sessions. After rS366857, we shut down the network here. (And, this change still shuts down the network as part of the shutdown scripts.)
  3. Only after all shutdown scripts run does init kill off the remaining processes. This is where the child sshd processes now get killed off. However, because the network is gone, the system has no way to close its TCP, SCTP, etc. sessions.

If my analysis is correct, further work is needed to allow shutting down interfaces without this regression. One path is what I proposed in D27464. Another path is to do the interface shutdown after killing off other processes (however, that seems like a relatively major change). Another path is to have the kernel shutdown any TCP/SCTP/etc. sessions when an interface is going down which would make it so the remote side of the session is no longer reachable (however, that also seems like a relatively major change). And, there are probably other alternatives, as well.

I think the third option would probably be a bad idea. As it is today, you can do things like re-dhclient and if you get the same IP, existing connections stay open (this matters when drivers do dumb things like reset for MTU or other changes which result in a link down/up cycle which resets dhclient. I think the Intel drivers have done this in the past if not still today).

I wonder if there is a better way to handle the original PRs. For example, if lagg and vlan interfaces should forward WOL requests down to the all the child interfaces. That will matter for the case where you want to use WOL to wake from suspend or low-power idle without shutting down the host.

Dec 4 2020, 6:40 PM
cy added a comment to D27459: Only bring down clone interfaces at shutdown.

Yes, your analysis is correct.

Dec 4 2020, 6:26 PM
cy added a reviewer for D27459: Only bring down clone interfaces at shutdown: rrs.
Dec 4 2020, 3:18 PM
cy added reviewers for D27459: Only bring down clone interfaces at shutdown: tuexen, jtl.
Dec 4 2020, 3:17 PM
cy added a comment to D27464: Fix hung TCP sessions on shutdown.

See https://reviews.freebsd.org/D27459.

Dec 4 2020, 2:51 PM

Dec 3 2020

cy accepted D27471: Fix compat32 for ntp_adjtime(2)..

I don't see any issues worth noting.

Dec 3 2020, 11:12 PM
cy requested review of D27459: Only bring down clone interfaces at shutdown.
Dec 3 2020, 4:09 PM
cy committed rS368295: MFC r366286:.
MFC r366286:
Dec 3 2020, 5:57 AM
cy committed rS368294: Remove trailing whitespace..
Remove trailing whitespace.
Dec 3 2020, 5:50 AM
cy committed rP556884: MFH: r556844.
MFH: r556844
Dec 3 2020, 4:23 AM

Dec 2 2020

cy committed rP556844: Don't reassign the "len" variable and compute the exact spaces needed..
Don't reassign the "len" variable and compute the exact spaces needed.
Dec 2 2020, 6:44 PM

Dec 1 2020

cy committed rP556713: Update to the latest cfengine commits on github..
Update to the latest cfengine commits on github.
Dec 1 2020, 4:26 AM
cy committed rP556712: Update to the latest MIT KRB5 commit on github..
Update to the latest MIT KRB5 commit on github.
Dec 1 2020, 4:26 AM
cy committed rP556711: Update to the latest networkupstools/nut github commit..
Update to the latest networkupstools/nut github commit.
Dec 1 2020, 4:26 AM
cy abandoned D27418: Fix SAD DNS Exploit CVE-2020-25705.

See https://reviews.freebsd.org/D27354 instead.

Dec 1 2020, 12:42 AM

Nov 30 2020

cy committed rS368201: MFC r366285:.
MFC r366285:
Nov 30 2020, 10:35 PM
cy added inline comments to D27354: Address issue pointed out in CVE-2020-25705.
Nov 30 2020, 4:43 PM
cy added a comment to D27418: Fix SAD DNS Exploit CVE-2020-25705.

This patch is significantly smaller. The difference is icmplim could be exceeded by the modulus of the divisor whereas gnn's patch uses icmplim as an upper limit.

Nov 30 2020, 3:54 PM
cy added a comment to D27354: Address issue pointed out in CVE-2020-25705.

Forgive my (carefully cultivated) ignorance of the network stack, but I'd like to understand this:

  1. We already have a bandwidth limit for outgoing ICMP packets
  2. We already have a packets-per-second limit for outgoing ICMP packets
  3. Outgoing ICMP packets which exceed either the bandwidth or packets-per-second limit are dropped and never sent
  4. This change jitters the packets-per-second limit

Is that correct?

Nov 30 2020, 3:49 PM
cy requested changes to D27354: Address issue pointed out in CVE-2020-25705.
Nov 30 2020, 3:45 PM
cy updated the diff for D27418: Fix SAD DNS Exploit CVE-2020-25705.

Use git diff -U99999 instead of git diff to create this patch. No functional change.

Nov 30 2020, 3:11 AM
cy requested review of D27418: Fix SAD DNS Exploit CVE-2020-25705.
Nov 30 2020, 3:10 AM

Nov 28 2020

cy committed rS368129: MFC r367094:.
MFC r367094:
Nov 28 2020, 6:09 PM

Nov 27 2020

cy committed rS368089: MFC r367980:.
MFC r367980:
Nov 27 2020, 3:17 AM

Nov 24 2020

cy committed rP556149: Fix build with SQL option.
Fix build with SQL option
Nov 24 2020, 6:49 AM
cy committed rS367980: Fix a typo in a comment..
Fix a typo in a comment.
Nov 24 2020, 6:42 AM
cy committed rP556147: Update to the latest networkupstools/nut github commit..
Update to the latest networkupstools/nut github commit.
Nov 24 2020, 4:47 AM
cy committed rP556146: Update to the latest cfengine commits on github..
Update to the latest cfengine commits on github.
Nov 24 2020, 4:47 AM
cy committed rP556145: Update to the latest MIT KRB5 commit on github..
Update to the latest MIT KRB5 commit on github.
Nov 24 2020, 4:47 AM

Nov 21 2020

cy committed rP555808: Welcome the new cfengine317 and cfengine-masterfiles317. They.
Welcome the new cfengine317 and cfengine-masterfiles317. They
Nov 21 2020, 3:48 AM

Nov 20 2020

cy committed rP555726: Support RFC5424/IETF syslog format, as in 12-STABLE and 13-CURRENT..
Support RFC5424/IETF syslog format, as in 12-STABLE and 13-CURRENT.
Nov 20 2020, 1:58 AM
cy committed rP555725: Update 3.29.1 --> 3.30.1.
Update 3.29.1 --> 3.30.1
Nov 20 2020, 1:54 AM

Nov 18 2020

cy added a comment to D26880: Restore identification of VDEVs using non-native block size..

Thank you Matt. I will MFV a new tarball next time.

Nov 18 2020, 2:30 PM
cy committed rP555621: Update to the latest cfengine commits on github..
Update to the latest cfengine commits on github.
Nov 18 2020, 4:15 AM
cy committed rP555620: Update to the latest networkupstools/nut github commit..
Update to the latest networkupstools/nut github commit.
Nov 18 2020, 4:15 AM
cy committed rP555618: Update 1.17.1 --> 1.17.2.
Update 1.17.1 --> 1.17.2
Nov 18 2020, 4:15 AM
cy committed rP555619: Update 1.18.2 --> 1.18.3.
Update 1.18.2 --> 1.18.3
Nov 18 2020, 4:15 AM
cy closed D26880: Restore identification of VDEVs using non-native block size..
Nov 18 2020, 1:19 AM
cy committed rS367779: Restore identification of VDEVs using non-native block size..
Restore identification of VDEVs using non-native block size.
Nov 18 2020, 1:19 AM

Nov 17 2020

cy updated the diff for D26880: Restore identification of VDEVs using non-native block size..

The upstream commit:

Nov 17 2020, 5:55 PM
cy committed rP555529: Fix build under LLVM11 (13-CURRENT)..
Fix build under LLVM11 (13-CURRENT).
Nov 17 2020, 1:34 AM

Nov 14 2020

cy committed rP555092: Update to the latest networkupstools/nut github commit..
Update to the latest networkupstools/nut github commit.
Nov 14 2020, 7:58 AM
cy committed rP555091: Properly check USB errors using sys/errno.h..
Properly check USB errors using sys/errno.h.
Nov 14 2020, 7:58 AM
cy committed rP555083: Only list the offered cfengine ports/packages. Others will be expired.
Only list the offered cfengine ports/packages. Others will be expired
Nov 14 2020, 6:00 AM
cy committed rP555082: Update to the latest cfengine commits on github..
Update to the latest cfengine commits on github.
Nov 14 2020, 5:59 AM
cy committed rP555081: Update to the latest MIT KRB5 commit on github..
Update to the latest MIT KRB5 commit on github.
Nov 14 2020, 5:59 AM
cy committed rP555080: Expire cfengine314 and cfengine-masterfiles314 one year after the.
Expire cfengine314 and cfengine-masterfiles314 one year after the
Nov 14 2020, 5:59 AM